Please review fix for 6951661 (Eliminate jvmstat dependency on sun.management.counter)

[Mandy Chung]

On 05/12/10 15:04, daniel.daugherty at oracle.com wrote:
> On 5/11/2010 4:28 PM, Mandy Chung wrote:
>> Hi,
>>
>> Please review the fix for:*
>> *    6951661 Eliminate jvmstat dependency on sun.management.counter
>>
>> Webrev at:
>>    http://cr.openjdk.java.net/~mchung/6951661/webrev.00/
>>
>> Very simple fix.  jvmstat now has its own copy of Units and 
>> Variability class.
>>
>> Thanks
>> Mandy
>
> Thumbs up modulo a question about the serialVersionUID.
>
> You use the same value for both Units and Variability
> and the same value is used for the sun.management version
> of both classes.
>
> Should different values be used all the way around?

It shouldn't matter because they are in different classes.

Thanks for the review.  Sorry for not including you in the reviewer list 
as I pushed the changeset a moment before seeing your reply.
Mandy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20100512/27f5a311/attachment.html