Review request: 6765718: Indicate which thread throwing OOME when generating the heap dump at OOME

Daniel D. Daugherty daniel.daugherty at oracle.com
Fri Sep 10 06:22:52 PDT 2010


On 9/10/2010 7:08 AM, Tomas Hurka wrote:
>> src/share/vm/services/heapDumper.hpp
>>   Any particular reason for changing the one HeapDumper ctr from
>>   public to private? Just curious...
>>     
> According to the comment from Mandy, the second constructor 
>
> HeapDumper(bool gc_before_heap_dump, bool print_to_tty)
>
> is not used. So I removed it and added new private constructor with oome flag.
>   

Thanks for the explanation!

> The new webrev with above changes is here: <http://cr.openjdk.java.net/~thurka/6765718/webrev.02>

Thumbs up on the latest webrev.

Dan



More information about the serviceability-dev mailing list