From y.s.ramakrishna at oracle.com Mon Aug 1 11:35:33 2011 From: y.s.ramakrishna at oracle.com (Ramki Ramakrishna) Date: Mon, 01 Aug 2011 11:35:33 -0700 Subject: Review request: 7072527 CMS: JMM GC counters overcount in some cases In-Reply-To: <4E333E8D.7070005@oracle.com> References: <4E316E5D.50703@oracle.com> <4E31FEF1.8060205@oracle.com> <4E3207F9.6020805@oracle.com> <4E32E168.7000908@oracle.com> <4E333E8D.7070005@oracle.com> Message-ID: <4E36F1F5.50606@oracle.com> Looks good to me; ship it! -- ramki On 7/29/2011 4:13 PM, Kevin Walls wrote: > > Actually I missed the other comment that we could go further and > remove the unneeded constructor. > > http://cr.openjdk.java.net/~kevinw/7072527/webrev.01/ > > Thanks > Kevin > > On 29/07/11 17:35, Kevin Walls wrote: >> Hi -- >> >> I got this ready in a webrev: >> >> http://cr.openjdk.java.net/~kevinw/7072527/webrev.00/ >> >> The new test is passing, as are the old ones. 8-) >> >> Also, this change means that a CMS cycle ending in concurrent mode >> failure now counts as one collection. One could argue that either >> way (should it be 2 collections?) - but I'm thinking if we are >> counting "completed" collections then we are now counting correctly! >> >> Thanks >> Kevin >> >> >> On 29/07/11 02:08, Y. S. Ramakrishna wrote: >>> I filed: 7072527 CMS: JMM GC counters overcount in some cases >>> >>> On 07/28/11 17:29, Y. S. Ramakrishna wrote: >>>> Hi Kevin -- >>>> >>>> thanks for jumping on this! More inline below ... >>>> >>>> On 07/28/11 09:33, Krystal Mok wrote: >>>>> Hi Kevin, >>>>> >>>>> Thank you for taking care of this, and it's good to see the >>>>> problem is verified. >>>>> >>>>> I think whether or not the suggested fix is sufficient depends on >>>>> what paths can reach CMSCollector::do_compaction_work(). If all >>>>> paths that can reach CMSCollector::do_compaction_work() come from >>>>> GenCollectedHeap::do_collection(), then the fix should be good to >>>>> go. Otherwise it'll need a better workaround. >>>>> >>>>> I believe all concurrent mode failures/interrupts (which includes >>>>> the System.gc() case) does come from >>>>> GenCollectedHeap::do_collection(), but I'm not exactly sure about >>>>> this, could anybody please clarify on it? >>>> >>>> Yes, i believe this is indeed the case, and my browsing of the >>>> code using cscope seemed to confirm that belief. >>>> >>>> More below ... >>>> >>>>> >>>>> Regards, >>>>> Kris Mok >>>>> >>>>> On Thu, Jul 28, 2011 at 10:12 PM, Kevin Walls >>>>> > wrote: >>>>> >>>>> __ >>>>> Hi -- >>>>> >>>>> 6580448 was marked as a duplicate of 6581734, which fixed the >>>>> fact >>>>> that CMS collections were just not counted at all - with CMS, >>>>> only a >>>>> stop the world full gc would be counted in the stats. >>>>> >>>>> But looks like you're right... Here is a quick variation of the >>>>> testcase from 6581734 which shows the same thing, and this >>>>> verifies >>>>> the same, and is solved by ExplicitGCInvokesConcurrent. If >>>>> there is >>>>> no other feedback I can test if the removal of the >>>>> TraceCMSMemoryManagerStats() call in >>>>> CMSCollector::do_compaction_work is all we need... >>>> >>>> >>>> Kevin, yes, it would be great if you could verify this and push the >>>> fix. >>>> I am not sure if the push would need to wait for the signing of OCA >>>> from Kris, but best to check with Those Who Would Know Such Things. >>>> >>>> Since the original CR has been closed, i'll open one momentarily and >>>> can make you RE (if that's OK with you). I'll be happy to serve as >>>> reviewer of the change. >>>> >>>> As regards the jstat counter reporting two pauses per concurrent >>>> CMS cycle, I am of two minds on what the original intention >>>> was. I'd have originally regarded the double increment as a >>>> bug, but as you state it is really two pauses, even if part of >>>> a single cycle. And it makes sense to count them as two. I >>>> agree that this should be documented and left alone, given >>>> how long we have had this behaviour, and the alternative >>>> (of counting cycles, rather than pauses) may be no better >>>> (or arguably worse). There's actually an open CR for this >>>> which we can redirect into a CR to update the relevant documentation. >>>> >>>> -- ramki >>>> >>>>> >>>>> Regards >>>>> Kevin >>>>> >>>>> >>>>> /* >>>>> * Copyright (c) 2011, Oracle and/or its affiliates. All rights >>>>> reserved. >>>>> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >>>>> * >>>>> * This code is free software; you can redistribute it and/or >>>>> modify it >>>>> * under the terms of the GNU General Public License version 2 >>>>> only, as >>>>> * published by the Free Software Foundation. >>>>> * >>>>> * This code is distributed in the hope that it will be >>>>> useful, but >>>>> WITHOUT >>>>> * ANY WARRANTY; without even the implied warranty of >>>>> MERCHANTABILITY or >>>>> * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General >>>>> Public License >>>>> * version 2 for more details (a copy is included in the LICENSE >>>>> file that >>>>> * accompanied this code). >>>>> * >>>>> * You should have received a copy of the GNU General Public >>>>> License >>>>> version >>>>> * 2 along with this work; if not, write to the Free Software >>>>> Foundation, >>>>> * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. >>>>> * >>>>> * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA >>>>> 94065 USA >>>>> * or visit www.oracle.com if you need >>>>> additional information or have any >>>>> * questions. >>>>> */ >>>>> >>>>> /* >>>>> * @test TestFullGCount.java >>>>> * @bug >>>>> * @summary >>>>> * @run main/othervm -XX:+UseConcMarkSweepGC TestFullGCCount >>>>> * >>>>> */ >>>>> import java.util.*; >>>>> import java.lang.management.*; >>>>> >>>>> >>>>> >>>>> public class TestFullGCCount { >>>>> >>>>> private String poolName = "CMS"; >>>>> private String collectorName = "ConcurrentMarkSweep"; >>>>> >>>>> public static void main(String [] args) { >>>>> >>>>> TestFullGCCount t = null; >>>>> if (args.length==2) { >>>>> t = new TestFullGCCount(args[0], args[1]); >>>>> } else { >>>>> System.out.println("Defaulting to monitor CMS pool and >>>>> collector."); >>>>> t = new TestFullGCCount(); >>>>> } >>>>> t.run(); >>>>> >>>>> } >>>>> >>>>> public TestFullGCCount(String pool, String collector) { >>>>> poolName = pool; >>>>> collectorName = collector; >>>>> } >>>>> public TestFullGCCount() { >>>>> } >>>>> >>>>> public void run() { >>>>> >>>>> int count = 0; >>>>> int iterations = 20; >>>>> long counts[] = new long[iterations]; >>>>> boolean diffAlways2 = true; // assume we will fail >>>>> >>>>> for (int i=0; i>>>> System.gc(); >>>>> counts[i] = checkStats(); >>>>> if (i>0) { >>>>> if (counts[i] - counts[i-1] != 2) { >>>>> diffAlways2 = false; >>>>> } >>>>> } >>>>> } >>>>> if (diffAlways2) { >>>>> throw new RuntimeException("FAILED: difference in >>>>> count is >>>>> always 2."); >>>>> } >>>>> System.out.println("Passed."); >>>>> } >>>>> >>>>> private long checkStats() { >>>>> long count = 0; >>>>> List pools = >>>>> ManagementFactory.getMemoryPoolMXBeans(); >>>>> List collectors = >>>>> ManagementFactory.getGarbageCollectorMXBeans(); >>>>> for (int i=0; i>>>> GarbageCollectorMXBean collector = collectors.get(i); >>>>> String name = collector.getName(); >>>>> if (name.contains(collectorName)) { >>>>> System.out.println(name + ": collection count = " >>>>> + collector.getCollectionCount()); >>>>> count = collector.getCollectionCount(); >>>>> } >>>>> } >>>>> return count; >>>>> >>>>> } >>>>> >>>>> } >>>>> >>>>> >>>>> On 27/07/11 17:12, Krystal Mok wrote: >>>>>> Hi all, >>>>>> >>>>>> I've been looking at a strange inconsistency of full GC count >>>>>> recorded by jvmstat and JMM counters. I'd like to know which >>>>>> ones >>>>>> of the following behaviors are by design, which ones are >>>>>> bugs, and >>>>>> which ones are just my misunderstanding. I apologize for >>>>>> making a >>>>>> short story long... >>>>>> >>>>>> ===================================================== >>>>>> >>>>>> The counters involved: >>>>>> >>>>>> * A jvmstat counter named "sun.gc.collector.1.invocations" keeps >>>>>> track of the number of pauses occured as a result of a major >>>>>> collection. It is used by utilities such as jstat as the >>>>>> source of >>>>>> "FGC" (full collection count), and the old gen collection >>>>>> count in >>>>>> Visual GC. It's updated by an TraceCollectorStats object. >>>>>> * A JMM counter, GCMemoryManager::_num_collections, keeps >>>>>> track of >>>>>> the number of collections that have ended. This counter is >>>>>> used as >>>>>> HotSpot's implementation of the JMX >>>>>> GarbageCollectorMXBean.getCollectionCount(). It's updated by >>>>>> either a TraceMemoryManagerStats object or a >>>>>> TraceCMSMemoryManagerStats object. >>>>>> >>>>>> To show the situation, I've made a screenshot of a VisualVM >>>>>> and a >>>>>> JConsole running side by side, both are monitoring the >>>>>> VisualVM's >>>>>> GC stats: >>>>>> >>>>>> http://dl.iteye.com/upload/attachment/524811/913cb0e1-7add-3ac0-a718-24ca705cad22.png >>>>>> >>>>>> (I'll upload the screenshot to somewhere else if anybody >>>>>> can't see it) >>>>>> The VisualVM instance is running on JDK6u26, with ParNew+CMS. >>>>>> In the screenshot, Visual GC reports that the old gen collection >>>>>> count is 20, while JConsole reports 10. >>>>>> >>>>>> I see that there was this bug: >>>>>> 6580448: CMS: Full GC collection count mismatch between >>>>>> GarbageCollectorMXBean and jvmstat (VisualGC) >>>>>> I don't think the current implementation has a bug in the sense >>>>>> that the two counters don't report the same number. >>>>>> >>>>>> This behavior seems reasonable, but the naming of the value in >>>>>> these tools are confusing: both tools say "collections", but >>>>>> apparently the number in Visual GC means "number of pauses" >>>>>> where >>>>>> as the number in JConsole means "number of collection cycles". >>>>>> It'd be great if the difference could be documented >>>>>> somewhere, if >>>>>> that's the intended behavior. >>>>>> >>>>>> And then the buggy behavior. Code demo posted on gist: >>>>>> https://gist.github.com/1106263 >>>>>> Starting from JDK6u23, when using CMS without >>>>>> ExplicitGCInvokesConcurrent, System.gc() (or >>>>>> Runtime.getRuntime().gc(), or MemoryMXBean.gc() via JMX) would >>>>>> make the JMM GC counter increment by 2 per invocation, while the >>>>>> jvmstat counter is only incremented by 1. I believe the >>>>>> latter is >>>>>> correct and the former needs some fixing. >>>>>> >>>>>> ===================================================== >>>>>> >>>>>> My understanding of the behavior shown above: >>>>>> >>>>>> 1. The concurrent GC part: >>>>>> >>>>>> There are 2 pauses in a CMS concurrent GC cycle, one in the >>>>>> initial mark phase, and one in the final remark phase. >>>>>> To trigger a concurrent GC cycle, the CMS thread wakes up >>>>>> periodically to see if it shouldConcurrentCollect(), and >>>>>> trigger a >>>>>> cycle when the predicate returned true, or goes back to sleep if >>>>>> the predicate returned false. The whole concurrent GC cycle >>>>>> doesn't go through GenCollectedHeap::do_collection(). >>>>>> >>>>>> The jvmstat counter for old gen pauses is updated in >>>>>> CMSCollector::do_CMS_operation(CMS_op_type op), which exactly >>>>>> covers both pause phases. >>>>>> >>>>>> The JMM counter, however, is updated in the concurrent sweep >>>>>> phase, CMSCollector::sweep(bool asynch), if there was no >>>>>> concurrent mode failure; or it is updated in >>>>>> CMSCollector::do_compaction_work(bool clear_all_soft_refs) in >>>>>> case >>>>>> of a bailout due to concurrent mode failure (advertised as so in >>>>>> the code comments). So that's an increment by 1 per >>>>>> concurrent GC >>>>>> cycle, which does reflect the "number of collection cycles", >>>>>> fair >>>>>> enough. >>>>>> >>>>>> So far so good. >>>>>> >>>>>> 2. The System.gc() part: >>>>>> >>>>>> Without ExplicitGCInvokesConcurrent set, System.gc() does a >>>>>> stop-the-world full GC, which consists of only one pause, so >>>>>> "number of pauses" would equal "number of collections" in >>>>>> this case. >>>>>> It will go into GenCollectedHeap::do_collection(); both the >>>>>> jvmstat and the JMM GC counter gets incremented by 1 here, >>>>>> >>>>>> TraceCollectorStats tcs(_gens[i]->counters()); >>>>>> TraceMemoryManagerStats tmms(_gens[i]->kind()); >>>>>> >>>>>> But, drilling down into: >>>>>> _gens[i]->collect(full, do_clear_all_soft_refs, size, is_tlab); >>>>>> >>>>>> That'll eventually go into: >>>>>> CMSCollector::acquire_control_and_collect(bool full, bool >>>>>> clear_all_soft_refs) >>>>>> >>>>>> System.gc() is user requested so that'll go further into >>>>>> mark-sweep-compact: >>>>>> CMSCollector::do_compaction_work(bool clear_all_soft_refs) >>>>>> And here, it increments the JMM GC counter again (remember it >>>>>> was >>>>>> in the concurrent GC path too, to handle bailouts), even though >>>>>> this is still in the same collection. This leads to the "buggy >>>>>> behavior" mentioned earlier. >>>>>> >>>>>> The JMM GC counter wasn't added to CMS until this fix got in: >>>>>> 6581734: CMS Old Gen's collection usage is zero after GC >>>>>> which is >>>>>> incorrect >>>>>> >>>>>> The code added to CMSCollector::do_compaction_work() works >>>>>> fine in >>>>>> the concurrent GC path, but interacts badly with the original >>>>>> logic in GenCollectedHeap::do_collection(). >>>>>> >>>>>> ===================================================== >>>>>> >>>>>> I thought all concurrent mode failures/interrupts come from >>>>>> GenCollectedHeap::do_collection(). If that's the case, then it >>>>>> seems unnecessary to update the JMM GC counter in >>>>>> CMSCollector::do_compaction_work(), simply removing it should >>>>>> fix >>>>>> the problem. >>>>>> >>>>>> With that, I'd purpose the following (XS) change: (diff >>>>>> against HS20) >>>>>> >>>>>> diff -r f0f676c5a2c6 >>>>>> >>>>>> src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp >>>>>> >>>>>> --- >>>>>> >>>>>> a/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp >>>>>> >>>>>> Tue Mar 15 19:30:16 2011 -0700 >>>>>> +++ >>>>>> >>>>>> b/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp >>>>>> >>>>>> Thu Jul 28 00:02:41 2011 +0800 >>>>>> @@ -2022,9 +2022,6 @@ >>>>>> >>>>>> _intra_sweep_estimate.padded_average()); >>>>>> } >>>>>> >>>>>> - { >>>>>> - TraceCMSMemoryManagerStats(); >>>>>> - } >>>>>> GenMarkSweep::invoke_at_safepoint(_cmsGen->level(), >>>>>> ref_processor(), clear_all_soft_refs); >>>>>> #ifdef ASSERT >>>>>> >>>>>> The same goes for the changes in: >>>>>> 7036199: Adding a notification to the implementation of >>>>>> GarbageCollectorMXBeans >>>>>> >>>>>> ===================================================== >>>>>> >>>>>> P.S. Is there an "official" name for the counters that I >>>>>> referred >>>>>> to as "jvmstat counters" above? Is it just jvmstat, or >>>>>> PerfData or >>>>>> HSPERFDATA? >>>>> >>>>> >> > From chris.hegarty at oracle.com Tue Aug 2 07:08:59 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 02 Aug 2011 14:08:59 +0000 Subject: hg: jdk8/tl/jdk: 6978200: ServerSocket.toString include "port=0" in the returned String Message-ID: <20110802140909.6A2E3478C2@hg.openjdk.java.net> Changeset: 809e8db0c142 Author: chegar Date: 2011-07-29 10:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/809e8db0c142 6978200: ServerSocket.toString include "port=0" in the returned String Summary: Removal of "port=0" from ServerSocket.toString method Reviewed-by: alanb, chegar Contributed-by: kurchi.subhra.hazra at oracle.com ! src/share/classes/java/net/ServerSocket.java From kevin.walls at oracle.com Wed Aug 3 04:56:38 2011 From: kevin.walls at oracle.com (Kevin Walls) Date: Wed, 03 Aug 2011 12:56:38 +0100 Subject: Review request: 7072527 CMS: JMM GC counters overcount in some cases In-Reply-To: <4E36F1F5.50606@oracle.com> References: <4E316E5D.50703@oracle.com> <4E31FEF1.8060205@oracle.com> <4E3207F9.6020805@oracle.com> <4E32E168.7000908@oracle.com> <4E333E8D.7070005@oracle.com> <4E36F1F5.50606@oracle.com> Message-ID: <4E393776.6080100@oracle.com> Thanks Ramki, and thanks for chasing up and clarifying the OCA point. Kevin On 01/08/11 19:35, Ramki Ramakrishna wrote: > Looks good to me; ship it! > > -- ramki > > On 7/29/2011 4:13 PM, Kevin Walls wrote: >> >> Actually I missed the other comment that we could go further and >> remove the unneeded constructor. >> >> http://cr.openjdk.java.net/~kevinw/7072527/webrev.01/ >> >> Thanks >> Kevin >> >> On 29/07/11 17:35, Kevin Walls wrote: >>> Hi -- >>> >>> I got this ready in a webrev: >>> >>> http://cr.openjdk.java.net/~kevinw/7072527/webrev.00/ >>> >>> The new test is passing, as are the old ones. 8-) >>> >>> Also, this change means that a CMS cycle ending in concurrent mode >>> failure now counts as one collection. One could argue that either >>> way (should it be 2 collections?) - but I'm thinking if we are >>> counting "completed" collections then we are now counting correctly! >>> >>> Thanks >>> Kevin >>> >>> >>> On 29/07/11 02:08, Y. S. Ramakrishna wrote: >>>> I filed: 7072527 CMS: JMM GC counters overcount in some cases >>>> >>>> On 07/28/11 17:29, Y. S. Ramakrishna wrote: >>>>> Hi Kevin -- >>>>> >>>>> thanks for jumping on this! More inline below ... >>>>> >>>>> On 07/28/11 09:33, Krystal Mok wrote: >>>>>> Hi Kevin, >>>>>> >>>>>> Thank you for taking care of this, and it's good to see the >>>>>> problem is verified. >>>>>> >>>>>> I think whether or not the suggested fix is sufficient depends on >>>>>> what paths can reach CMSCollector::do_compaction_work(). If all >>>>>> paths that can reach CMSCollector::do_compaction_work() come from >>>>>> GenCollectedHeap::do_collection(), then the fix should be good to >>>>>> go. Otherwise it'll need a better workaround. >>>>>> >>>>>> I believe all concurrent mode failures/interrupts (which includes >>>>>> the System.gc() case) does come from >>>>>> GenCollectedHeap::do_collection(), but I'm not exactly sure about >>>>>> this, could anybody please clarify on it? >>>>> >>>>> Yes, i believe this is indeed the case, and my browsing of the >>>>> code using cscope seemed to confirm that belief. >>>>> >>>>> More below ... >>>>> >>>>>> >>>>>> Regards, >>>>>> Kris Mok >>>>>> >>>>>> On Thu, Jul 28, 2011 at 10:12 PM, Kevin Walls >>>>>> > wrote: >>>>>> >>>>>> __ >>>>>> Hi -- >>>>>> >>>>>> 6580448 was marked as a duplicate of 6581734, which fixed the >>>>>> fact >>>>>> that CMS collections were just not counted at all - with CMS, >>>>>> only a >>>>>> stop the world full gc would be counted in the stats. >>>>>> >>>>>> But looks like you're right... Here is a quick variation of the >>>>>> testcase from 6581734 which shows the same thing, and this >>>>>> verifies >>>>>> the same, and is solved by ExplicitGCInvokesConcurrent. If >>>>>> there is >>>>>> no other feedback I can test if the removal of the >>>>>> TraceCMSMemoryManagerStats() call in >>>>>> CMSCollector::do_compaction_work is all we need... >>>>> >>>>> >>>>> Kevin, yes, it would be great if you could verify this and push >>>>> the fix. >>>>> I am not sure if the push would need to wait for the signing of OCA >>>>> from Kris, but best to check with Those Who Would Know Such Things. >>>>> >>>>> Since the original CR has been closed, i'll open one momentarily and >>>>> can make you RE (if that's OK with you). I'll be happy to serve as >>>>> reviewer of the change. >>>>> >>>>> As regards the jstat counter reporting two pauses per concurrent >>>>> CMS cycle, I am of two minds on what the original intention >>>>> was. I'd have originally regarded the double increment as a >>>>> bug, but as you state it is really two pauses, even if part of >>>>> a single cycle. And it makes sense to count them as two. I >>>>> agree that this should be documented and left alone, given >>>>> how long we have had this behaviour, and the alternative >>>>> (of counting cycles, rather than pauses) may be no better >>>>> (or arguably worse). There's actually an open CR for this >>>>> which we can redirect into a CR to update the relevant documentation. >>>>> >>>>> -- ramki >>>>> >>>>>> >>>>>> Regards >>>>>> Kevin >>>>>> >>>>>> >>>>>> /* >>>>>> * Copyright (c) 2011, Oracle and/or its affiliates. All rights >>>>>> reserved. >>>>>> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >>>>>> * >>>>>> * This code is free software; you can redistribute it and/or >>>>>> modify it >>>>>> * under the terms of the GNU General Public License version >>>>>> 2 only, as >>>>>> * published by the Free Software Foundation. >>>>>> * >>>>>> * This code is distributed in the hope that it will be >>>>>> useful, but >>>>>> WITHOUT >>>>>> * ANY WARRANTY; without even the implied warranty of >>>>>> MERCHANTABILITY or >>>>>> * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General >>>>>> Public License >>>>>> * version 2 for more details (a copy is included in the LICENSE >>>>>> file that >>>>>> * accompanied this code). >>>>>> * >>>>>> * You should have received a copy of the GNU General Public >>>>>> License >>>>>> version >>>>>> * 2 along with this work; if not, write to the Free Software >>>>>> Foundation, >>>>>> * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. >>>>>> * >>>>>> * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA >>>>>> 94065 USA >>>>>> * or visit www.oracle.com if you need >>>>>> additional information or have any >>>>>> * questions. >>>>>> */ >>>>>> >>>>>> /* >>>>>> * @test TestFullGCount.java >>>>>> * @bug >>>>>> * @summary >>>>>> * @run main/othervm -XX:+UseConcMarkSweepGC TestFullGCCount >>>>>> * >>>>>> */ >>>>>> import java.util.*; >>>>>> import java.lang.management.*; >>>>>> >>>>>> >>>>>> >>>>>> public class TestFullGCCount { >>>>>> >>>>>> private String poolName = "CMS"; >>>>>> private String collectorName = "ConcurrentMarkSweep"; >>>>>> >>>>>> public static void main(String [] args) { >>>>>> >>>>>> TestFullGCCount t = null; >>>>>> if (args.length==2) { >>>>>> t = new TestFullGCCount(args[0], args[1]); >>>>>> } else { >>>>>> System.out.println("Defaulting to monitor CMS pool and >>>>>> collector."); >>>>>> t = new TestFullGCCount(); >>>>>> } >>>>>> t.run(); >>>>>> >>>>>> } >>>>>> >>>>>> public TestFullGCCount(String pool, String collector) { >>>>>> poolName = pool; >>>>>> collectorName = collector; >>>>>> } >>>>>> public TestFullGCCount() { >>>>>> } >>>>>> >>>>>> public void run() { >>>>>> >>>>>> int count = 0; >>>>>> int iterations = 20; >>>>>> long counts[] = new long[iterations]; >>>>>> boolean diffAlways2 = true; // assume we will fail >>>>>> >>>>>> for (int i=0; i>>>>> System.gc(); >>>>>> counts[i] = checkStats(); >>>>>> if (i>0) { >>>>>> if (counts[i] - counts[i-1] != 2) { >>>>>> diffAlways2 = false; >>>>>> } >>>>>> } >>>>>> } >>>>>> if (diffAlways2) { >>>>>> throw new RuntimeException("FAILED: difference in >>>>>> count is >>>>>> always 2."); >>>>>> } >>>>>> System.out.println("Passed."); >>>>>> } >>>>>> >>>>>> private long checkStats() { >>>>>> long count = 0; >>>>>> List pools = >>>>>> ManagementFactory.getMemoryPoolMXBeans(); >>>>>> List collectors = >>>>>> ManagementFactory.getGarbageCollectorMXBeans(); >>>>>> for (int i=0; i>>>>> GarbageCollectorMXBean collector = collectors.get(i); >>>>>> String name = collector.getName(); >>>>>> if (name.contains(collectorName)) { >>>>>> System.out.println(name + ": collection count = " >>>>>> + >>>>>> collector.getCollectionCount()); >>>>>> count = collector.getCollectionCount(); >>>>>> } >>>>>> } >>>>>> return count; >>>>>> >>>>>> } >>>>>> >>>>>> } >>>>>> >>>>>> >>>>>> On 27/07/11 17:12, Krystal Mok wrote: >>>>>>> Hi all, >>>>>>> >>>>>>> I've been looking at a strange inconsistency of full GC count >>>>>>> recorded by jvmstat and JMM counters. I'd like to know which >>>>>>> ones >>>>>>> of the following behaviors are by design, which ones are >>>>>>> bugs, and >>>>>>> which ones are just my misunderstanding. I apologize for >>>>>>> making a >>>>>>> short story long... >>>>>>> >>>>>>> ===================================================== >>>>>>> >>>>>>> The counters involved: >>>>>>> >>>>>>> * A jvmstat counter named "sun.gc.collector.1.invocations" >>>>>>> keeps >>>>>>> track of the number of pauses occured as a result of a major >>>>>>> collection. It is used by utilities such as jstat as the >>>>>>> source of >>>>>>> "FGC" (full collection count), and the old gen collection >>>>>>> count in >>>>>>> Visual GC. It's updated by an TraceCollectorStats object. >>>>>>> * A JMM counter, GCMemoryManager::_num_collections, keeps >>>>>>> track of >>>>>>> the number of collections that have ended. This counter is >>>>>>> used as >>>>>>> HotSpot's implementation of the JMX >>>>>>> GarbageCollectorMXBean.getCollectionCount(). It's updated by >>>>>>> either a TraceMemoryManagerStats object or a >>>>>>> TraceCMSMemoryManagerStats object. >>>>>>> >>>>>>> To show the situation, I've made a screenshot of a VisualVM >>>>>>> and a >>>>>>> JConsole running side by side, both are monitoring the >>>>>>> VisualVM's >>>>>>> GC stats: >>>>>>> >>>>>>> http://dl.iteye.com/upload/attachment/524811/913cb0e1-7add-3ac0-a718-24ca705cad22.png >>>>>>> >>>>>>> (I'll upload the screenshot to somewhere else if anybody >>>>>>> can't see it) >>>>>>> The VisualVM instance is running on JDK6u26, with ParNew+CMS. >>>>>>> In the screenshot, Visual GC reports that the old gen >>>>>>> collection >>>>>>> count is 20, while JConsole reports 10. >>>>>>> >>>>>>> I see that there was this bug: >>>>>>> 6580448: CMS: Full GC collection count mismatch between >>>>>>> GarbageCollectorMXBean and jvmstat (VisualGC) >>>>>>> I don't think the current implementation has a bug in the sense >>>>>>> that the two counters don't report the same number. >>>>>>> >>>>>>> This behavior seems reasonable, but the naming of the value in >>>>>>> these tools are confusing: both tools say "collections", but >>>>>>> apparently the number in Visual GC means "number of pauses" >>>>>>> where >>>>>>> as the number in JConsole means "number of collection cycles". >>>>>>> It'd be great if the difference could be documented >>>>>>> somewhere, if >>>>>>> that's the intended behavior. >>>>>>> >>>>>>> And then the buggy behavior. Code demo posted on gist: >>>>>>> https://gist.github.com/1106263 >>>>>>> Starting from JDK6u23, when using CMS without >>>>>>> ExplicitGCInvokesConcurrent, System.gc() (or >>>>>>> Runtime.getRuntime().gc(), or MemoryMXBean.gc() via JMX) would >>>>>>> make the JMM GC counter increment by 2 per invocation, while >>>>>>> the >>>>>>> jvmstat counter is only incremented by 1. I believe the >>>>>>> latter is >>>>>>> correct and the former needs some fixing. >>>>>>> >>>>>>> ===================================================== >>>>>>> >>>>>>> My understanding of the behavior shown above: >>>>>>> >>>>>>> 1. The concurrent GC part: >>>>>>> >>>>>>> There are 2 pauses in a CMS concurrent GC cycle, one in the >>>>>>> initial mark phase, and one in the final remark phase. >>>>>>> To trigger a concurrent GC cycle, the CMS thread wakes up >>>>>>> periodically to see if it shouldConcurrentCollect(), and >>>>>>> trigger a >>>>>>> cycle when the predicate returned true, or goes back to >>>>>>> sleep if >>>>>>> the predicate returned false. The whole concurrent GC cycle >>>>>>> doesn't go through GenCollectedHeap::do_collection(). >>>>>>> >>>>>>> The jvmstat counter for old gen pauses is updated in >>>>>>> CMSCollector::do_CMS_operation(CMS_op_type op), which exactly >>>>>>> covers both pause phases. >>>>>>> >>>>>>> The JMM counter, however, is updated in the concurrent sweep >>>>>>> phase, CMSCollector::sweep(bool asynch), if there was no >>>>>>> concurrent mode failure; or it is updated in >>>>>>> CMSCollector::do_compaction_work(bool clear_all_soft_refs) >>>>>>> in case >>>>>>> of a bailout due to concurrent mode failure (advertised as >>>>>>> so in >>>>>>> the code comments). So that's an increment by 1 per >>>>>>> concurrent GC >>>>>>> cycle, which does reflect the "number of collection cycles", >>>>>>> fair >>>>>>> enough. >>>>>>> >>>>>>> So far so good. >>>>>>> >>>>>>> 2. The System.gc() part: >>>>>>> >>>>>>> Without ExplicitGCInvokesConcurrent set, System.gc() does a >>>>>>> stop-the-world full GC, which consists of only one pause, so >>>>>>> "number of pauses" would equal "number of collections" in >>>>>>> this case. >>>>>>> It will go into GenCollectedHeap::do_collection(); both the >>>>>>> jvmstat and the JMM GC counter gets incremented by 1 here, >>>>>>> >>>>>>> TraceCollectorStats tcs(_gens[i]->counters()); >>>>>>> TraceMemoryManagerStats tmms(_gens[i]->kind()); >>>>>>> >>>>>>> But, drilling down into: >>>>>>> _gens[i]->collect(full, do_clear_all_soft_refs, size, is_tlab); >>>>>>> >>>>>>> That'll eventually go into: >>>>>>> CMSCollector::acquire_control_and_collect(bool full, bool >>>>>>> clear_all_soft_refs) >>>>>>> >>>>>>> System.gc() is user requested so that'll go further into >>>>>>> mark-sweep-compact: >>>>>>> CMSCollector::do_compaction_work(bool clear_all_soft_refs) >>>>>>> And here, it increments the JMM GC counter again (remember >>>>>>> it was >>>>>>> in the concurrent GC path too, to handle bailouts), even though >>>>>>> this is still in the same collection. This leads to the "buggy >>>>>>> behavior" mentioned earlier. >>>>>>> >>>>>>> The JMM GC counter wasn't added to CMS until this fix got in: >>>>>>> 6581734: CMS Old Gen's collection usage is zero after GC >>>>>>> which is >>>>>>> incorrect >>>>>>> >>>>>>> The code added to CMSCollector::do_compaction_work() works >>>>>>> fine in >>>>>>> the concurrent GC path, but interacts badly with the original >>>>>>> logic in GenCollectedHeap::do_collection(). >>>>>>> >>>>>>> ===================================================== >>>>>>> >>>>>>> I thought all concurrent mode failures/interrupts come from >>>>>>> GenCollectedHeap::do_collection(). If that's the case, then it >>>>>>> seems unnecessary to update the JMM GC counter in >>>>>>> CMSCollector::do_compaction_work(), simply removing it >>>>>>> should fix >>>>>>> the problem. >>>>>>> >>>>>>> With that, I'd purpose the following (XS) change: (diff >>>>>>> against HS20) >>>>>>> >>>>>>> diff -r f0f676c5a2c6 >>>>>>> >>>>>>> src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp >>>>>>> >>>>>>> --- >>>>>>> >>>>>>> a/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp >>>>>>> >>>>>>> Tue Mar 15 19:30:16 2011 -0700 >>>>>>> +++ >>>>>>> >>>>>>> b/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp >>>>>>> >>>>>>> Thu Jul 28 00:02:41 2011 +0800 >>>>>>> @@ -2022,9 +2022,6 @@ >>>>>>> >>>>>>> _intra_sweep_estimate.padded_average()); >>>>>>> } >>>>>>> >>>>>>> - { >>>>>>> - TraceCMSMemoryManagerStats(); >>>>>>> - } >>>>>>> GenMarkSweep::invoke_at_safepoint(_cmsGen->level(), >>>>>>> ref_processor(), clear_all_soft_refs); >>>>>>> #ifdef ASSERT >>>>>>> >>>>>>> The same goes for the changes in: >>>>>>> 7036199: Adding a notification to the implementation of >>>>>>> GarbageCollectorMXBeans >>>>>>> >>>>>>> ===================================================== >>>>>>> >>>>>>> P.S. Is there an "official" name for the counters that I >>>>>>> referred >>>>>>> to as "jvmstat counters" above? Is it just jvmstat, or >>>>>>> PerfData or >>>>>>> HSPERFDATA? >>>>>> >>>>>> >>> >> From weijun.wang at oracle.com Thu Aug 4 03:19:29 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Thu, 04 Aug 2011 10:19:29 +0000 Subject: hg: jdk8/tl/jdk: 7061379: [Kerberos] Cross-realm authentication fails, due to nameType problem Message-ID: <20110804101955.C941C4792B@hg.openjdk.java.net> Changeset: e68db408d08c Author: weijun Date: 2011-08-04 18:18 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e68db408d08c 7061379: [Kerberos] Cross-realm authentication fails, due to nameType problem Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/PrincipalName.java ! test/sun/security/krb5/auto/KDC.java + test/sun/security/krb5/auto/PrincipalNameEquals.java From Alan.Bateman at oracle.com Thu Aug 4 08:50:38 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 04 Aug 2011 16:50:38 +0100 Subject: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR) In-Reply-To: <4E3A8A4F.60609@oracle.com> References: <4E3A8A4F.60609@oracle.com> Message-ID: <4E3ABFCE.3070408@oracle.com> David Buck wrote: > Hi! > > I would like to request that my fix for 7011591 be reviewed for push > into JDK8 (and JDK7u if possible). > > CR: 7011591 JDWP socket transport should restart interrupted system > calls (EINTR) > : > > Webrev: http://cr.openjdk.java.net/~dbuck/7011591/webrev.00/ I've added serviceability-dev to the CC list as that is where the debugger code is. I looked at the webrev and it mostly looks okay to me. One issue is that dbgsysPoll probably should adjust the timeout when interrupted. A minor nit is that you've changed the copyright date on the file from 1998 to 1997. -Alan. From mike.duigou at oracle.com Thu Aug 4 09:17:50 2011 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 04 Aug 2011 16:17:50 +0000 Subject: hg: jdk8/tl/jdk: 7073296: Executable.equalParamTypes() incorrectly returns true when the number of params differs. Message-ID: <20110804161801.09D1A47938@hg.openjdk.java.net> Changeset: 565555e89034 Author: mduigou Date: 2011-08-04 08:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/565555e89034 7073296: Executable.equalParamTypes() incorrectly returns true when the number of params differs. Reviewed-by: alanb, darcy ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Executable.java + test/java/lang/reflect/Constructor/Equals.java From daniel.daugherty at oracle.com Thu Aug 4 09:19:10 2011 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 04 Aug 2011 10:19:10 -0600 Subject: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR) In-Reply-To: <4E3ABFCE.3070408@oracle.com> References: <4E3A8A4F.60609@oracle.com> <4E3ABFCE.3070408@oracle.com> Message-ID: <4E3AC67E.7080208@oracle.com> On 8/4/11 9:50 AM, Alan Bateman wrote: > David Buck wrote: >> Hi! >> >> I would like to request that my fix for 7011591 be reviewed for push >> into JDK8 (and JDK7u if possible). >> >> CR: 7011591 JDWP socket transport should restart interrupted system >> calls (EINTR) >> : >> >> Webrev: http://cr.openjdk.java.net/~dbuck/7011591/webrev.00/ > I've added serviceability-dev to the CC list as that is where the > debugger code is. Alan, thanks for adding in serviceability-dev... Thumbs up from me since this matches my earlier reviews. > I looked at the webrev and it mostly looks okay to me. One issue is > that dbgsysPoll probably should adjust the timeout when interrupted. Adjust it how? (Just curious) > A minor nit is that you've changed the copyright date on the file from > 1998 to 1997. Don't know how I missed that with the earlier reviews, but the Teamware history shows that the earliest date for this file is indeed in 1998 and not 1997: $ sccs prs -r1.1 src/solaris/transport/socket/socket_md.c src/solaris/transport/socket/SCCS/s.socket_md.c: D 1.1 98/11/21 21:20:56 gordonh 1 0 00149/00000/00000 MRs: COMMENTS: Dan From Dmitry.Samersoff at oracle.com Thu Aug 4 09:35:00 2011 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Thu, 04 Aug 2011 20:35:00 +0400 Subject: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR) In-Reply-To: <4E3AC67E.7080208@oracle.com> References: <4E3A8A4F.60609@oracle.com> <4E3ABFCE.3070408@oracle.com> <4E3AC67E.7080208@oracle.com> Message-ID: <4E3ACA34.9090509@oracle.com> On 2011-08-04 20:19, Daniel D. Daugherty wrote: > >> I looked at the webrev and it mostly looks okay to me. One issue is >> that dbgsysPoll probably should adjust the timeout when interrupted. > > Adjust it how? (Just curious) If my memory is not bogus poll could be interrupted before first request only. So no need to adjust timeout. We may consider to use ppoll under linux but it's a RFE ... -Dmitry > > >> A minor nit is that you've changed the copyright date on the file from >> 1998 to 1997. > > Don't know how I missed that with the earlier reviews, but the > Teamware history shows that the earliest date for this file > is indeed in 1998 and not 1997: > > $ sccs prs -r1.1 src/solaris/transport/socket/socket_md.c > src/solaris/transport/socket/SCCS/s.socket_md.c: > > D 1.1 98/11/21 21:20:56 gordonh 1 0 00149/00000/00000 > MRs: > COMMENTS: > > Dan > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From joe.darcy at oracle.com Thu Aug 4 11:17:07 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 04 Aug 2011 18:17:07 +0000 Subject: hg: jdk8/tl/langtools: 7071246: Enclosing string literal in parenthesis in switch-case crashes javac Message-ID: <20110804181712.289234793D@hg.openjdk.java.net> Changeset: 64b9b7ae3366 Author: darcy Date: 2011-08-04 11:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64b9b7ae3366 7071246: Enclosing string literal in parenthesis in switch-case crashes javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! test/tools/javac/StringsInSwitch/StringSwitches.java From Alan.Bateman at oracle.com Thu Aug 4 12:40:12 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 04 Aug 2011 20:40:12 +0100 Subject: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR) In-Reply-To: <4E3AC67E.7080208@oracle.com> References: <4E3A8A4F.60609@oracle.com> <4E3ABFCE.3070408@oracle.com> <4E3AC67E.7080208@oracle.com> Message-ID: <4E3AF59C.5090206@oracle.com> Daniel D. Daugherty wrote: > : > >> I looked at the webrev and it mostly looks okay to me. One issue is >> that dbgsysPoll probably should adjust the timeout when interrupted. > > Adjust it how? (Just curious) If the poll is interrupted close to the timeout then it will restart the poll with the original timeout so it will be longer than it should. For the debugger transport I don't think this is a big issue as the timeout is only used in the initial handshake (if I remember correctly). It may be more trouble that its worth to fix this. As to how then gettimeofday could be used so that we get the elapsed time of the interrupted poll and that could be used to adjust the timeout. There are a couple of example in other places in the JDK. -Alan From jonathan.gibbons at oracle.com Fri Aug 5 15:58:29 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 05 Aug 2011 22:58:29 +0000 Subject: hg: jdk8/tl/langtools: 7074189: some javac tests fail with latest jtreg 4.1 b03 Message-ID: <20110805225832.1F8B547984@hg.openjdk.java.net> Changeset: c0d5f93af048 Author: jjg Date: 2011-08-05 15:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c0d5f93af048 7074189: some javac tests fail with latest jtreg 4.1 b03 Reviewed-by: darcy + test/tools/javac/lib/CompileFail.java ! test/tools/javac/processing/errors/TestOptionSyntaxErrors.java ! test/tools/javac/processing/errors/TestReturnCode.java ! test/tools/javac/warnings/Serial.java From kumar.x.srinivasan at oracle.com Sat Aug 6 14:18:55 2011 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Sat, 06 Aug 2011 21:18:55 +0000 Subject: hg: jdk8/tl/langtools: 7064544: (javadoc) miscellaneous fixes requested by netbeans Message-ID: <20110806211858.32160479B5@hg.openjdk.java.net> Changeset: e9f118c2bd3c Author: ksrini Date: 2011-08-05 19:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e9f118c2bd3c 7064544: (javadoc) miscellaneous fixes requested by netbeans Summary: Contributed by netbeans team, modified to suit by the langtools team. Reviewed-by: jjg, bpatel ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/Comment.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! test/com/sun/javadoc/testLinkTaglet/TestLinkTaglet.java ! test/com/sun/javadoc/testLinkTaglet/pkg/C.java From joe.darcy at oracle.com Sat Aug 6 14:37:19 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 06 Aug 2011 21:37:19 +0000 Subject: hg: jdk8/tl/jdk: 7075098: Remove unused fdlibm files Message-ID: <20110806213742.31439479B6@hg.openjdk.java.net> Changeset: b9fffbe98230 Author: darcy Date: 2011-08-06 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b9fffbe98230 7075098: Remove unused fdlibm files Reviewed-by: alanb, mduigou ! make/java/fdlibm/FILES_c.gmk ! src/share/native/java/lang/fdlibm/include/fdlibm.h ! src/share/native/java/lang/fdlibm/include/jfdlibm.h - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c From lana.steuck at oracle.com Sun Aug 7 17:20:34 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 08 Aug 2011 00:20:34 +0000 Subject: hg: jdk8/tl/jdk: 27 new changesets Message-ID: <20110808002500.E045C479F3@hg.openjdk.java.net> Changeset: 6444b0a364d7 Author: jrose Date: 2011-06-14 22:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6444b0a364d7 7054590: (JSR-292) MethodHandleProxies.asInterfaceInstance() accepts private/protected nested interfaces Summary: fix non-compliant logic in MethodHandleProxies, fix invalid private classes in MethodHandlesTest Reviewed-by: twisti, never ! src/share/classes/java/lang/invoke/MethodHandleProxies.java ! test/java/lang/invoke/MethodHandlesTest.java Changeset: 5f3cd0cbad56 Author: jrose Date: 2011-07-13 01:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f3cd0cbad56 Merge - src/share/classes/sun/misc/JavaxSecurityAuthKerberosAccess.java - test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java Changeset: bfc5ec581c48 Author: jrose Date: 2011-07-16 15:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bfc5ec581c48 7058630: JSR 292 method handle proxy violates contract for Object methods Reviewed-by: never, twisti ! src/share/classes/java/lang/invoke/MethodHandleProxies.java ! test/java/lang/invoke/MethodHandlesTest.java Changeset: 668edf27e9c7 Author: jrose Date: 2011-07-16 15:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/668edf27e9c7 7058651: JSR 292 unit tests need a refresh Summary: Enhancements to unit tests. Reviewed-by: never, twisti ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodHandlesTest.java ! test/java/lang/invoke/RicochetTest.java + test/java/lang/invoke/ThrowExceptionsTest.java Changeset: b42029cd1744 Author: jrose Date: 2011-07-16 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b42029cd1744 6983728: JSR 292 remove argument count limitations Summary: Remove workarounds and limitations from before 6939861. Reviewed-by: never ! src/share/classes/java/lang/invoke/AdapterMethodHandle.java - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodTypeForm.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java Changeset: 74598b748a57 Author: lana Date: 2011-07-01 12:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/74598b748a57 Merge Changeset: 0a00216a858c Author: lana Date: 2011-07-07 19:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a00216a858c Merge - src/share/classes/sun/misc/JavaxSecurityAuthKerberosAccess.java - test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java Changeset: 77d5cc943286 Author: prr Date: 2011-07-19 14:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77d5cc943286 7068471: NPE in sun.font.FontConfigManager.getFontConfigFont() when libfontconfig.so is not installed Reviewed-by: jgodinez, prr Contributed-by: spoole at linux.vnet.ibm.com ! src/solaris/classes/sun/font/FontConfigManager.java Changeset: ae05aa9ede7b Author: bae Date: 2011-07-20 16:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ae05aa9ede7b 7044285: 64 bit VM crashes in Java_sun_java2d_loops_MaskFill_MaskFill Reviewed-by: jgodinez, prr ! src/share/native/sun/java2d/loops/GraphicsPrimitiveMgr.h Changeset: 40d0dea5d0fc Author: neugens Date: 2011-07-26 21:34 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40d0dea5d0fc 7070155: A small refactoring patch for the abstract RenderingEngine. Summary: Simplify code by using ReflectiveOperationException instead of 3 ignored catch blocks Reviewed-by: prr ! src/share/classes/sun/java2d/pipe/RenderingEngine.java Changeset: 0795f0dacfec Author: bagiras Date: 2011-07-11 15:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0795f0dacfec 7050935: closed/java/awt/Choice/WheelEventsConsumed/WheelEventsConsumed.html fails on win32 Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Choice.cpp ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp + test/java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java Changeset: acea32663757 Author: peytoia Date: 2011-07-12 08:00 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/acea32663757 7042148: closed/java/awt/font/TextLayout/CheckLayoutLTR.java failed Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java + test/java/text/Bidi/Bug7042148.java Changeset: 75ee78eb7322 Author: peytoia Date: 2011-07-12 08:46 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/75ee78eb7322 7051769: java.text.Bidi.toString() output is wrong Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java + test/java/text/Bidi/Bug7051769.java Changeset: 6bc0e1709d97 Author: lana Date: 2011-07-11 16:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6bc0e1709d97 Merge Changeset: cce5659427bb Author: rupashka Date: 2011-07-12 11:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cce5659427bb 7019963: The goto parent directory button doesn't operate in JFileChooser Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java Changeset: 5c22624d193e Author: rupashka Date: 2011-07-15 14:43 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c22624d193e 4909150: WindowsTreeUI can cause NullPointerException occasionally Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTreeUI.java Changeset: 6ee24f03760d Author: serb Date: 2011-07-15 19:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6ee24f03760d 7043679: Wrong class name is used in Java_sun_awt_windows_WPrinterJob_initIDs Reviewed-by: dav, art ! src/windows/native/sun/windows/awt_PrintJob.cpp Changeset: c90a43ebf8fd Author: serb Date: 2011-07-15 19:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c90a43ebf8fd 7043815: AWT-XAWT - AWT-EventQueue-0 deadlock. Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java Changeset: 252f71b26b23 Author: serb Date: 2011-07-15 19:23 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/252f71b26b23 6596915: JCK-runtime-6a/tests/api/java_awt/Component/index.html tesPaintAll fails Reviewed-by: art, dcherepanov, anthony ! src/solaris/classes/sun/awt/X11/XButtonPeer.java ! src/solaris/classes/sun/awt/X11/XCheckboxPeer.java ! src/solaris/classes/sun/awt/X11/XChoicePeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XLabelPeer.java ! src/solaris/classes/sun/awt/X11/XListPeer.java ! src/solaris/classes/sun/awt/X11/XMenuBarPeer.java ! src/solaris/classes/sun/awt/X11/XMenuWindow.java ! src/solaris/classes/sun/awt/X11/XPanelPeer.java ! src/solaris/classes/sun/awt/X11/XRepaintArea.java ! src/solaris/classes/sun/awt/X11/XScrollPanePeer.java ! src/solaris/classes/sun/awt/X11/XScrollbarPeer.java ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java ! src/solaris/classes/sun/awt/X11/XWarningWindow.java ! src/solaris/classes/sun/awt/X11/XWindow.java + test/java/awt/Component/PaintAll/PaintAll.java Changeset: 3ed58dbad819 Author: serb Date: 2011-07-15 19:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3ed58dbad819 6642728: Use reflection to access ScrollPane's private method from within sun.awt package Reviewed-by: art, anthony ! src/share/classes/java/awt/ScrollPaneAdjustable.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/solaris/classes/sun/awt/X11/XScrollPanePeer.java ! src/windows/classes/sun/awt/windows/WScrollPanePeer.java ! src/windows/native/sun/windows/awt_ScrollPane.cpp Changeset: 9c642ae9a543 Author: serb Date: 2011-07-15 19:25 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c642ae9a543 4717864: setFont() does not update Fonts of Menus already on screen Reviewed-by: art, bagiras ! src/windows/classes/sun/awt/windows/WMenuItemPeer.java ! src/windows/native/sun/windows/awt_Menu.cpp ! src/windows/native/sun/windows/awt_Menu.h ! src/windows/native/sun/windows/awt_MenuBar.cpp ! src/windows/native/sun/windows/awt_MenuBar.h ! src/windows/native/sun/windows/awt_MenuItem.cpp ! src/windows/native/sun/windows/awt_MenuItem.h Changeset: 3ac81907aa7d Author: rupashka Date: 2011-07-18 17:40 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3ac81907aa7d 6509273: Password in JPasswordField gets Printed in clear text Reviewed-by: alexp ! src/share/classes/sun/swing/text/TextComponentPrintable.java Changeset: c05b36e4749e Author: rupashka Date: 2011-07-18 18:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c05b36e4749e 7031941: Use generificated JComboBox and JList in core libraries Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/motif/MotifFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicComboPopup.java ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java ! src/share/classes/javax/swing/text/html/FormView.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/text/html/HTMLWriter.java ! src/share/classes/javax/swing/text/html/OptionComboBoxModel.java ! src/share/classes/javax/swing/text/html/OptionListModel.java ! src/share/classes/sun/swing/FilePane.java ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java Changeset: 190b11164876 Author: lana Date: 2011-07-27 22:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/190b11164876 Merge Changeset: 996547848b00 Author: lana Date: 2011-08-01 17:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/996547848b00 Merge Changeset: 3f3a59423a7e Author: lana Date: 2011-08-05 16:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f3a59423a7e Merge - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java Changeset: a5f825ef8587 Author: lana Date: 2011-08-07 17:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5f825ef8587 Merge - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c From lana.steuck at oracle.com Sun Aug 7 17:19:35 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 08 Aug 2011 00:19:35 +0000 Subject: hg: jdk8/tl/hotspot: 82 new changesets Message-ID: <20110808002207.D3432479F1@hg.openjdk.java.net> Changeset: 2b27ef5c2173 Author: kvn Date: 2011-05-20 12:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2b27ef5c2173 7046096: SEGV IN C2 WITH 6U25 Summary: Missing fail flag set in strings concatenation code. Reviewed-by: never ! src/share/vm/opto/stringopts.cpp Changeset: cfbca4d74a61 Author: jcoomes Date: 2011-05-20 22:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cfbca4d74a61 Merge Changeset: 789d04408ca3 Author: kvn Date: 2011-05-21 11:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/789d04408ca3 7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently Summary: New limit for unrolled loop should be set only for zero trip guard and loop iteration test. Reviewed-by: never ! src/share/vm/opto/loopTransform.cpp Changeset: b55f5bd7ec66 Author: kvn Date: 2011-05-21 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b55f5bd7ec66 7045506: assert(!can_reshape || !new_phi) failed: for igvn new phi should be hooked Summary: Replace the assert in PhiNode::Ideal with check to avoid transformation of new phi. Reviewed-by: never ! src/share/vm/opto/cfgnode.cpp Changeset: 7523488edce5 Author: kvn Date: 2011-05-24 12:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7523488edce5 7047300: VM crashes with assert(_base == InstPtr) failed: Not an object pointer Summary: The code incorrectly used is_instptr() instead of is_oopptr() to get const_oop. Reviewed-by: never ! src/share/vm/opto/output.cpp Changeset: ccf072cdba91 Author: iveresov Date: 2011-05-24 15:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ccf072cdba91 7046893: LP64 problem with double_quadword in c1_LIRAssembler_x86.cpp Summary: Fixed invalid casts in address computation Reviewed-by: kvn, never Contributed-by: thomas.salter at unisys.com ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: 28a9fe9534ea Author: kvn Date: 2011-05-24 20:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/28a9fe9534ea 7048030: is_scavengable changes causing compiler to embed more constants Summary: ciObject::can_be_constant() and should_be_constant() should use is_perm() instead of !is_scavengable() Reviewed-by: never, jrose ! src/share/vm/ci/ciObject.cpp ! src/share/vm/ci/ciObject.hpp Changeset: 7db2b9499c36 Author: never Date: 2011-05-25 16:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7db2b9499c36 7046732: JSR 292 assert(result == cpce->f1()) failed: expected result for assembly code Reviewed-by: kvn, iveresov, jrose ! src/share/vm/interpreter/interpreterRuntime.cpp Changeset: c7c81f18c834 Author: kvn Date: 2011-05-25 21:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c7c81f18c834 7048332: Cadd_cmpLTMask doesn't handle 64-bit tmp register properly Summary: Use ins_encode %{ %} form to encode cadd_cmpLTMask() instruction and remove unused code. Reviewed-by: never ! src/cpu/x86/vm/x86_64.ad + test/compiler/7048332/Test7048332.java Changeset: 28263a73ebfb Author: iveresov Date: 2011-05-26 13:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/28263a73ebfb 7047491: C1: registers saved incorrectly when calling checkcast_arraycopy stub Summary: Save and restore the argument registers around the call to checkcast_arraycopy Reviewed-by: never, roland ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: 5ac411b3b8fc Author: never Date: 2011-05-26 14:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5ac411b3b8fc 7047961: JSR 292 MethodHandleWalk swap args doesn't handle T_LONG and T_DOUBLE properly Reviewed-by: kvn, jrose ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp Changeset: c76c13577460 Author: never Date: 2011-05-26 16:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c76c13577460 Merge Changeset: b2cb497dec28 Author: kvn Date: 2011-05-27 12:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b2cb497dec28 7047069: Array can dynamically change size when assigned to an object field Summary: Fix initialization of a newly-allocated array with arraycopy Reviewed-by: never ! src/share/vm/opto/library_call.cpp + test/compiler/7047069/Test7047069.java Changeset: 33e2b8f1d466 Author: kvn Date: 2011-05-31 10:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/33e2b8f1d466 6956668: misbehavior of XOR operator (^) with int Summary: optimize cmp_ne(xor(X,1),0) to cmp_eq(X,0) only for boolean values X. Reviewed-by: never ! src/share/vm/opto/subnode.cpp + test/compiler/6956668/Test6956668.java Changeset: 60b8287df30e Author: jrose Date: 2011-06-01 23:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/60b8287df30e 7049415: Failure of resolution of sym.reference to the c.s.s. should be wrapped in BootstrapMethodError Summary: Delegate invokedynamic linkage errors to MethodHandleNatives.raiseException. Reviewed-by: never ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp Changeset: a93146d0e4be Author: jrose Date: 2011-06-01 23:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a93146d0e4be 7049410: JSR 292 old method name MethodHandle.invokeGeneric should not be accepted by the JVM Summary: change the default setting of the flag AllowInvokeGeneric to false Reviewed-by: never ! src/share/vm/runtime/globals.hpp Changeset: 537a4053b0f9 Author: ysr Date: 2011-05-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/537a4053b0f9 7042740: CMS: assert(n> q) failed: Looping at: ... blockOffsetTable.cpp:557 Summary: Do a one-step look-ahead, when sweeping free or garbage blocks, to avoid overstepping sweep limit, which may become a non-block-boundary because of a heap expansion delta coalescing with a previously co-terminal free block. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/memory/blockOffsetTable.cpp Changeset: f153114134c8 Author: jcoomes Date: 2011-06-07 13:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f153114134c8 Merge Changeset: d3b9f2be46ab Author: coleenp Date: 2011-05-21 15:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d3b9f2be46ab 7033141: assert(has_cp_cache(i)) failed: oob Summary: Unrewrite bytecodes for OOM error allocating the constant pool cache. Reviewed-by: dcubed, acorn, never ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandleWalk.cpp Changeset: 9dd6c4ba364f Author: coleenp Date: 2011-06-02 14:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9dd6c4ba364f 7049928: VM crashes with "assert(_adapter != NULL) failed: must have" at methodOop.cpp:63 Summary: Removed extra change from another bug fix that caused this regression Reviewed-by: phh, dcubed, kvn, kamg, never ! src/share/vm/oops/methodOop.cpp Changeset: 96c891ebe56a Author: coleenp Date: 2011-06-02 21:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/96c891ebe56a Merge ! src/share/vm/prims/methodHandleWalk.cpp Changeset: ae1d716e395c Author: dsamersoff Date: 2011-06-09 01:33 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ae1d716e395c Merge Changeset: f918d6096e23 Author: never Date: 2011-06-02 13:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f918d6096e23 7050554: JSR 292 - need optimization for selectAlternative Reviewed-by: kvn, jrose ! src/share/vm/ci/ciCallProfile.hpp ! src/share/vm/ci/ciMethodHandle.cpp ! src/share/vm/ci/ciMethodHandle.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/doCall.cpp Changeset: cba7b5c2d53f Author: never Date: 2011-06-03 22:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cba7b5c2d53f 7045514: SPARC assembly code for JSR 292 ricochet frames Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp + src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/sparc/vm/registerMap_sparc.hpp ! src/cpu/sparc/vm/runtime_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/stubRoutines_sparc.hpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/cpu/x86/vm/runtime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.hpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: 642c68c75db9 Author: kvn Date: 2011-06-04 10:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/642c68c75db9 7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity Summary: Mark all associated (same box and obj) lock and unlock nodes for elimination if some of them marked already. Reviewed-by: iveresov, never ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp Changeset: 5cf771a79037 Author: jrose Date: 2011-06-08 17:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5cf771a79037 7047697: MethodHandle.invokeExact call for wrong method causes VM failure if run with -Xcomp Reviewed-by: never, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/share/vm/code/pcDesc.cpp Changeset: c8f2186acf6d Author: twisti Date: 2011-06-14 12:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c8f2186acf6d 7053520: JSR292: crash in invokedynamic with C1 using tiered and compressed oops Reviewed-by: iveresov, never ! src/share/vm/c1/c1_LIRGenerator.cpp Changeset: f8c9417e3571 Author: never Date: 2011-06-14 14:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f8c9417e3571 7052219: JSR 292: Crash in ~BufferBlob::MethodHandles adapters Reviewed-by: twisti, kvn, jrose ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubCodeGenerator.cpp ! src/share/vm/runtime/stubCodeGenerator.hpp Changeset: e2ce15aa3daf Author: never Date: 2011-06-14 15:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e2ce15aa3daf Merge Changeset: cfcf2ba8f3eb Author: never Date: 2011-06-15 10:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cfcf2ba8f3eb Merge ! src/share/vm/prims/methodHandleWalk.cpp Changeset: e2af886d540b Author: trims Date: 2011-07-01 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e2af886d540b 7061691: Fork HS21 to HS22 - renumber Minor and build numbers of JVM Summary: Update the Minor and Build numbers for HS22 fork Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1e3493ac2d11 Author: ysr Date: 2011-05-27 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1e3493ac2d11 7048342: CMS: eob == _limit || fc->isFree() failed: Only a free chunk should allow us to cross over the limit Summary: The freeness bit was being cleared in debug code when it shouldn't have been. Also removed unused FreeChunk methods linkAfterNonNull and clearPrev. Reviewed-by: brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp Changeset: 5c0a3c1858b1 Author: ysr Date: 2011-06-02 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5c0a3c1858b1 7048782: CMS: assert(last_chunk_index_to_check<= last_chunk_index) failed: parCardTableModRefBS.cpp:359 Summary: The LNC array is sized before the start of a scavenge, while the heap may expand during a scavenge. With CMS, the last block of an arbitrary suffice of the LNC array may expand due to coalition with the expansion delta. We now take care not to attempt access past the end of the LNC array. LNC array code will be cleaned up and suitably encapsulated as part of the forthcoming performance RFE 7043675. Reviewed-by: brutisso ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp Changeset: e66f38dd58a9 Author: ysr Date: 2011-06-08 08:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e66f38dd58a9 Merge Changeset: 053d84a76d3d Author: tonyp Date: 2011-06-08 15:31 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/053d84a76d3d 7032531: G1: enhance GC logging to include more accurate eden / survivor size transitions Summary: This changeset extends the logging information generated by +PrintGCDetails to also print out separate size transitions for the eden, survivors, and old regions. Reviewed-by: ysr, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: ae5b2f1dcf12 Author: tonyp Date: 2011-06-08 21:48 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ae5b2f1dcf12 7045662: G1: OopsInHeapRegionClosure::set_region() should not be virtual Summary: make the method non-virtual, remove five unused closures, and fix a couple of copyright typos. Reviewed-by: stefank, johnc, poonam ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp ! src/share/vm/gc_implementation/g1/heapRegionSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionSets.hpp Changeset: c3f1170908be Author: tonyp Date: 2011-06-10 13:16 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c3f1170908be 7045330: G1: Simplify/fix the HeapRegionSeq class 7042285: G1: native memory leak during humongous object allocation 6804436: G1: heap region indices should be size_t Summary: A series of fixes and improvements to the HeapRegionSeq class: a) replace the _regions growable array with a standard C array, b) avoid de-allocating / re-allocating HeapRegion instances when the heap shrinks / grows (fix for 7042285), c) introduce fast method to map address to HeapRegion via a "biased" array pointer, d) embed the _hrs object in G1CollectedHeap, instead of pointing to it via an indirection, e) assume that all the regions added to the HeapRegionSeq instance are contiguous, f) replace int's with size_t's for indexes (and expand that to HeapRegion as part of 6804436), g) remove unnecessary / unused methods, h) rename a couple of fields (_alloc_search_start and _seq_bottom), i) fix iterate_from() not to always start from index 0 irrespective of the region passed to it, j) add a verification method to check the HeapRegionSeq assumptions, k) always call the wrappers for _hrs.iterate(), _hrs_length(), and _hrs.at() from G1CollectedHeap, not those methods di rectly, and l) unify the code that expands the sequence (by either re-using or creating a new HeapRegion) and make it robust wrt to a HeapRegion allocation failing. Reviewed-by: stefank, johnc, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.inline.hpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp Changeset: 2a241e764894 Author: minqi Date: 2011-06-10 15:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2a241e764894 6941923: RFE: Handling large log files produced by long running Java Applications Summary: supply optinal flags to realize gc log rotation Reviewed-by: ysr, jwilhelm ! src/share/vm/gc_implementation/shared/concurrentGCThread.cpp ! src/share/vm/gc_implementation/shared/concurrentGCThread.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/atomic.cpp ! src/share/vm/runtime/atomic.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp + test/gc/6941923/test6941923.sh Changeset: 42df21744b50 Author: minqi Date: 2011-06-10 15:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/42df21744b50 Merge Changeset: ef2d1b8f2dd4 Author: ysr Date: 2011-06-13 09:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ef2d1b8f2dd4 7051430: CMS: ongoing CMS cycle should terminate abruptly to allow prompt JVM termination at exit Summary: It turns out that there is no need to explicitly stop CMS since the JVM is taken down at a terminal safepoint during which CMS threads are (terminally) inactive. This will need to be revised if and when we evolve in the future to a point where we allow JVM reincarnation in the same process, but those changes will be much more sweeping than just terminating CMS threads. The unused ::stop() methods will be removed in a separate CR. Also include in this CR is the fix for a small typo in the spelling of UseGCLogFileRotation in a message in arguments.cpp, brought to our attention by Rainer Jung and reviewed by minqi. Reviewed-by: johnc, jwilhelm ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/thread.cpp Changeset: 74cd10898bea Author: brutisso Date: 2011-06-13 13:48 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/74cd10898bea 6918185: Remove unused code for lost card-marking optimization in BacktraceBuilder Summary: Removed dead code Reviewed-by: ysr, coleenp, dholmes ! src/share/vm/classfile/javaClasses.cpp Changeset: 842b840e67db Author: tonyp Date: 2011-06-14 10:33 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/842b840e67db 7046558: G1: concurrent marking optimizations Summary: Some optimizations to improve the concurrent marking phase: specialize the main oop closure, make sure a few methods in the fast path are properly inlined, a few more bits and pieces, and some cosmetic fixes. Reviewed-by: stefank, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp + src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp ! src/share/vm/utilities/bitMap.hpp Changeset: 6747fd0512e0 Author: johnc Date: 2011-06-14 11:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6747fd0512e0 7004681: G1: Extend marking verification to Full GCs Summary: Perform a heap verification after the first phase of G1's full GC using objects' mark words to determine liveness. The third parameter of the heap verification routines, which was used in G1 to determine which marking bitmap to use in liveness calculations, has been changed from a boolean to an enum with values defined for using the mark word, and the 'prev' and 'next' bitmaps. Reviewed-by: tonyp, ysr ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp Changeset: 5130fa1b24f1 Author: johnc Date: 2011-06-15 10:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5130fa1b24f1 7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses Summary: When ExplicitGCInvokesConcurrent is enabled, do not perform an evacuation pause if a marking cycle is already in progress and block the requesting thread until the marking cycle completes. Reviewed-by: tonyp, ysr ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp Changeset: c9ca3f51cf41 Author: tonyp Date: 2011-06-16 15:51 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c9ca3f51cf41 6994322: Remove the is_tlab and is_noref / is_large_noref parameters from the CollectedHeap Summary: Remove two unused parameters from the mem_allocate() method and update its uses accordingly. Reviewed-by: stefank, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/psOldGen.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPermGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.hpp ! src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.cpp ! src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/oops/typeArrayKlass.cpp Changeset: f75137faa7fe Author: ysr Date: 2011-06-20 09:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f75137faa7fe 6916968: CMS: freeList.cpp:304 assert(_allocation_stats.prevSweep() + ..., "Conservation Principle") Summary: Fix assert and adjust demand volume computation by adding missing factor. Reviewed-by: jmasa, tonyp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp Changeset: 23d434c6290d Author: tonyp Date: 2011-06-20 22:03 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/23d434c6290d 7055073: G1: code cleanup in the concurrentMark.* files Summary: Only cosmetic changes to make the concurrentMark.* more consistent, code-style-wise, with the rest of the codebase. Reviewed-by: johnc, ysr ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp Changeset: e8b0b0392037 Author: tonyp Date: 2011-06-21 15:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e8b0b0392037 7046182: G1: remove unnecessary iterations over the collection set Summary: Remove two unnecessary iterations over the collection set which are supposed to prepare the RSet's of the CSet regions for parallel iterations (we'll make sure this is done incrementally). I'll piggyback on this CR the removal of the G1_REM_SET_LOGGING code. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionSets.cpp ! src/share/vm/gc_implementation/g1/heapRegionSets.hpp Changeset: 5f6f2615433a Author: tonyp Date: 2011-06-24 12:38 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5f6f2615433a 7049999: G1: Make the G1PrintHeapRegions output consistent and complete Summary: Extend and make more consistent the output from the G1PrintHeapRegions flag. Reviewed-by: johnc, jmasa ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp + src/share/vm/gc_implementation/g1/g1HRPrinter.cpp + src/share/vm/gc_implementation/g1/g1HRPrinter.hpp Changeset: 04760e41b01e Author: brutisso Date: 2011-06-28 14:23 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/04760e41b01e 7016112: CMS: crash during promotion testing Summary: Also reviewed by mikael.gerdin at oracle.com; stdlib:qsort() does byte-by-byte swapping on Windows. This leads to pointer shearing. Fix is to implement a quicksort that does full pointer updates. Reviewed-by: never, coleenp, ysr ! src/share/vm/oops/methodOop.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/globals.hpp + src/share/vm/utilities/quickSort.cpp + src/share/vm/utilities/quickSort.hpp Changeset: 4bf3cbef0b3e Author: jcoomes Date: 2011-07-06 08:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4bf3cbef0b3e Merge ! src/share/vm/oops/methodOop.cpp ! src/share/vm/runtime/globals.hpp Changeset: d83ac25d0304 Author: never Date: 2011-06-16 13:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d83ac25d0304 7055355: JSR 292: crash while throwing WrongMethodTypeException Reviewed-by: jrose, twisti, bdelsart ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/templateInterpreter.cpp ! src/share/vm/interpreter/templateInterpreterGenerator.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: aacaff365100 Author: kvn Date: 2011-06-20 16:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aacaff365100 7052494: Eclipse test fails on JDK 7 b142 Summary: Keep 'ne' test in Counted loop when we can't guarantee during compilation that init < limit. Reviewed-by: never ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp + test/compiler/7052494/Test7052494.java Changeset: de6a837d75cf Author: never Date: 2011-06-21 09:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/de6a837d75cf 7056380: VM crashes with SIGSEGV in compiled code Summary: code was using andq reg, imm instead of addq addr, imm Reviewed-by: kvn, jrose, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_64.ad Changeset: aabf25fa3f05 Author: never Date: 2011-06-22 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aabf25fa3f05 7057587: JSR 292 - crash with jruby in test/test_respond_to.rb Summary: don't skip receiver when GC'ing compiled invokedynamic callsites Reviewed-by: twisti, kvn, jrose ! src/share/vm/code/nmethod.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse.hpp Changeset: ddd894528dbc Author: jrose Date: 2011-06-23 17:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ddd894528dbc 7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path Reviewed-by: never ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciField.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethodHandle.cpp ! src/share/vm/ci/ciObjArrayKlass.cpp ! src/share/vm/ci/ciSignature.cpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/constantPoolOop.hpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp Changeset: 498c6cf70f7e Author: kvn Date: 2011-06-28 14:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/498c6cf70f7e 7058036: FieldsAllocationStyle=2 does not work in 32-bit VM Summary: parseClassFile() incorrectly uses nonstatic_oop_map_size() method instead of nonstatic_oop_map_count(). Reviewed-by: never Contributed-by: Krystal Mok ! src/share/vm/classfile/classFileParser.cpp Changeset: 6ae7a1561b53 Author: kvn Date: 2011-06-28 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6ae7a1561b53 6990015: Incorrect Icache line size is used for 64 bit x86 Summary: correct Icache::line_size for x64 and add verification code into vm_version_x86. Reviewed-by: never, phh ! src/cpu/x86/vm/icache_x86.hpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp Changeset: e3cbc9ddd434 Author: kvn Date: 2011-06-28 15:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e3cbc9ddd434 7044738: Loop unroll optimization causes incorrect result Summary: take into account memory dependencies when clonning nodes in clone_up_backedge_goo(). Reviewed-by: never ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp + test/compiler/7044738/Test7044738.java + test/compiler/7046096/Test7046096.java Changeset: 7889bbcc7f88 Author: kvn Date: 2011-06-28 15:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7889bbcc7f88 7047954: VM crashes with assert(is_Mem()) failed Summary: cast constant array ptrs to bottom Reviewed-by: never ! src/share/vm/opto/compile.cpp Changeset: 6f6e91603a45 Author: iveresov Date: 2011-07-01 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6f6e91603a45 7058689: Tiered: Reprofiling doesn't happen in presence of level 4 OSR methods Summary: Take into account current state of profiling before believing that existing higher level versions are valid Reviewed-by: kvn, never ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp Changeset: 2c359f27615c Author: iveresov Date: 2011-07-01 10:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2c359f27615c 7057120: Tiered: Allow C1 to inline methods with loops Summary: Recompile the enclosing methods without inlining of the method that has OSRed to level 4 or recompile the enclosing method at level 4. Reviewed-by: kvn, never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/advancedThresholdPolicy.hpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/compilationPolicy.hpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.hpp Changeset: 15559220ce79 Author: never Date: 2011-07-05 16:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/15559220ce79 6478991: C1 NullCheckEliminator yields incorrect exceptions Reviewed-by: twisti, iveresov ! src/share/vm/c1/c1_Optimizer.cpp + test/compiler/6478991/NullCheckTest.java Changeset: fe240d87c6ec Author: never Date: 2011-07-06 09:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fe240d87c6ec 7061101: adlc should complain about mixing block and expression forms of ins_encode Reviewed-by: kvn ! src/share/vm/adlc/adlparse.cpp Changeset: 3e23978ea0c3 Author: never Date: 2011-07-06 18:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3e23978ea0c3 7062856: Disassembler needs to be smarter about finding hsdis after 1.7 launcher changes Summary: do explicit lookup emulating old LD_LIBRARY_PATH search Reviewed-by: kvn, jrose ! src/share/tools/hsdis/README ! src/share/vm/compiler/disassembler.cpp Changeset: b16582d6c7db Author: kvn Date: 2011-07-07 10:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b16582d6c7db Merge ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/oops/methodOop.cpp Changeset: 7d9e451f5416 Author: jcoomes Date: 2011-07-06 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7d9e451f5416 7061187: need some includes for arm/ppc Reviewed-by: dholmes, never, jwilhelm, kvn ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/runtime/atomic.cpp Changeset: eb94b7226b7a Author: jcoomes Date: 2011-07-06 12:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/eb94b7226b7a 7061192: option handling adjustments for oracle and embedded builds Reviewed-by: dholmes, never, jwilhelm, kvn ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 65dba8692db7 Author: jcoomes Date: 2011-07-06 12:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/65dba8692db7 7061197: ThreadLocalStorage sp map table should be optional Reviewed-by: dholmes, never, jwilhelm, kvn ! src/os_cpu/linux_x86/vm/assembler_linux_x86.cpp ! src/os_cpu/linux_x86/vm/threadLS_linux_x86.cpp ! src/os_cpu/linux_x86/vm/threadLS_linux_x86.hpp Changeset: 48048b59a551 Author: jcoomes Date: 2011-07-06 12:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/48048b59a551 7061204: clean the chunk table synchronously in embedded builds Reviewed-by: dholmes, never, jwilhelm, kvn ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp Changeset: bf6481e5f96d Author: jcoomes Date: 2011-07-06 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bf6481e5f96d 7061225: os::print_cpu_info() should support os-specific data Reviewed-by: dholmes, never, jwilhelm, kvn ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp Changeset: 8a4fc2990229 Author: jcoomes Date: 2011-07-07 15:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8a4fc2990229 7053189: remove some unnecessary platform-dependent includes Reviewed-by: dholmes, never, jwilhelm, kvn ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/arguments.cpp Changeset: b0b8491925fe Author: jcoomes Date: 2011-07-11 14:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b0b8491925fe 7061212: use o/s low memory notification in embedded builds Reviewed-by: dholmes, never, jwilhelm, kvn ! src/os/linux/vm/os_linux.cpp Changeset: 0defeba52583 Author: jcoomes Date: 2011-07-12 16:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0defeba52583 Merge Changeset: faa472957b38 Author: kvn Date: 2011-07-08 09:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/faa472957b38 7059034: Use movxtod/movdtox on T4 Summary: Use new VIS3 mov instructions on T4 for move data between general and float registers. Reviewed-by: never, twisti ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/share/vm/runtime/globals.hpp Changeset: 263247c478c5 Author: iveresov Date: 2011-07-08 15:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/263247c478c5 7058510: multinewarray with 6 dimensions uncommon traps in server compiler Summary: Pass arguments to runtime via java array for arrays with > 5 dimensions Reviewed-by: never, kvn, jrose, pbk ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp Changeset: 1f4f4ae84625 Author: kvn Date: 2011-07-13 10:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1f4f4ae84625 Merge ! src/share/vm/runtime/globals.hpp Changeset: 3fbb609d9e96 Author: kvn Date: 2011-07-14 15:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3fbb609d9e96 7067288: compiler regression test Test7052494 timeouts with client VM Summary: Test is modified to reduce number of iterations in test5() and test6(). Reviewed-by: never, iveresov ! test/compiler/7052494/Test7052494.java Changeset: 341a57af9b0a Author: never Date: 2011-07-15 15:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/341a57af9b0a 6990212: JSR 292 JVMTI MethodEnter hook is not called for JSR 292 bootstrap and target methods Summary: check for single stepping when dispatching invokes from method handles Reviewed-by: coleenp, twisti, kvn, dsamersoff ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp + test/compiler/6990212/Test6990212.java Changeset: 968305b802ee Author: trims Date: 2011-07-23 01:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/968305b802ee Merge Changeset: 8e5d4aa73a8c Author: trims Date: 2011-07-22 23:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8e5d4aa73a8c 7069176: Update the JDK version numbers in Hotspot for JDK 8 Summary: Change JDK_MINOR_VER and JDK_PREVIOUS_VERSION to reflect JDK8 values Reviewed-by: jcoomes ! make/hotspot_version Changeset: 0cc8a70952c3 Author: trims Date: 2011-07-22 23:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0cc8a70952c3 7070061: Adjust Hotspot make/jprt.properties for new JDK8 settings Summary: Fix so the JPRT can build with -release jdk8 now Reviewed-by: ohair ! make/jprt.properties From alan.bateman at oracle.com Mon Aug 8 05:43:01 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 08 Aug 2011 12:43:01 +0000 Subject: hg: jdk8/tl/jdk: 7076215: (jli) jdk/src/share/bin/jli_util.h should include function prototypes for str functions Message-ID: <20110808124324.2AF9C47A11@hg.openjdk.java.net> Changeset: 94934ebbb654 Author: alanb Date: 2011-08-08 13:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94934ebbb654 7076215: (jli) jdk/src/share/bin/jli_util.h should include function prototypes for str functions Reviewed-by: alanb Contributed-by: neil.richards at ngmr.net ! src/share/bin/jli_util.h From joe.darcy at oracle.com Mon Aug 8 09:08:11 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 08 Aug 2011 16:08:11 +0000 Subject: hg: jdk8/tl/jdk: 6380161: (reflect) Exception from newInstance() not chained to cause. Message-ID: <20110808160821.684DE47A19@hg.openjdk.java.net> Changeset: d4ab25d65adb Author: darcy Date: 2011-08-08 09:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d4ab25d65adb 6380161: (reflect) Exception from newInstance() not chained to cause. Reviewed-by: dholmes, lancea, forax ! src/share/classes/java/lang/Class.java From mandy.chung at oracle.com Mon Aug 8 16:28:41 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Mon, 08 Aug 2011 23:28:41 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20110808232918.C481B47A2D@hg.openjdk.java.net> Changeset: 0f1b4b3bc833 Author: mchung Date: 2011-08-08 16:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f1b4b3bc833 7036518: TEST_BUG: add cygwin support to test/java/nio/charset/coders/CheckSJISMappingProp.sh 7036519: TEST_BUG: add cygwin support to test/demo/zipfs/basic.sh Reviewed-by: sherman ! test/demo/zipfs/basic.sh ! test/java/nio/charset/coders/CheckSJISMappingProp.sh Changeset: 39498fc31d63 Author: mchung Date: 2011-08-08 16:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39498fc31d63 7012365: TEST_BUG: test/java/nio/charset/spi/basic.sh can be run with Cygwin Reviewed-by: darcy ! test/java/nio/charset/spi/basic.sh From Dmitry.Samersoff at oracle.com Tue Aug 9 01:39:16 2011 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Tue, 09 Aug 2011 12:39:16 +0400 Subject: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR) In-Reply-To: <4E40D147.9000107@oracle.com> References: <4E3A8A4F.60609@oracle.com> <4E3A9DB5.8080909@oracle.com> <4E40D147.9000107@oracle.com> Message-ID: <4E40F234.2030807@oracle.com> On 2011-08-09 10:18, David Buck wrote: > Hi Dmitry! > > Thank you for the helpful feedback. > > Even on Solaris, I should have called getsockopt() after poll() returns. > Not sure how I missed that. Thanks for the catch! > > I am not so sure i should include a second call to connect() after the > first one returns with EINTR. All of the "standard" unix docs (SUS, > Richard Steven's "Unix Network Programming") for connect() clearly > require that an interrupted call to connect() (on a blocking socket) > result in a asynchronous connection setup. connect() continues async setup for both blocking/non-blocking socket. > This seems to work fine on > Linux as well. My understanding is that the fact that Linux will > sometimes let us just re-call connect() and get the blocking behavior > (just like our original call) or return EINPROGRESS is more of a > convenience (that encourages programmers to write non-portable code). Behavior of second connect() call is portable: for blocking/non-blocking sockets it can: - block/retry; return EISCONN; return EALREADY/EINPROGRESS. Generally speaking it allows better error handling than just poll because it can catch an error happened between connect and poll calls (e.g. a peer reset connection) but in you probably don't need it. See http://pubs.opengroup.org/onlinepubs/009695399/functions/connect.html -Dmitry > In > other words, I don't think you HAVE to call connect() again before doing > a poll() or select(). The specification guarantees an asynchronous > attempt at connection setup and if we found an instance where it didn't > do that, we would be justified in calling it a bug. > > If possible, I would like one implementation that works on both (and > follows the specification strictly) and avoid adding any ifdefs to the > code. > > Cheers, > -Buck > > On 08/04/11 22:25, Dmitry Samersoff wrote: >> David, >> >> To be on safe side with connect() (on Linux, not sure for Solaris) >> you need to call connect() again and if it returns EINPROGRESS, run >> polling loop. After poll() it's recommended to call getsockopt() and >> read the SO_ERROR to determine whether connect was successful or not. >> >> -Dmitry >> >> >> On 2011-08-04 16:02, David Buck wrote: >>> Hi! >>> >>> I would like to request that my fix for 7011591 be reviewed for push >>> into JDK8 (and JDK7u if possible). >>> >>> CR: 7011591 JDWP socket transport should restart interrupted system >>> calls (EINTR) >>> >>> Weblink: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=2205030 >>> (for some reason, the public URL for the parent bug is not working. (I >>> believe that SubCR 2205030 will have all needed information.) >>> >>> Webrev: http://cr.openjdk.java.net/~dbuck/7011591/webrev.00/ >>> >>> Description: >>> Syscalls that can be interrupted by signal handling should automatically >>> retry if they fail with EINTR. Unfortunately, the JDWP socket transport >>> implementation does not do this. Since HotSpot does not use signals for >>> thread suspension, HotSpot customers have not run into any problem (as >>> far as I know). But because JRockit R27 and earlier releases use signals >>> to suspend threads, all threads are constantly being interrupted thus >>> JRockit customers are much more likely (almost guaranteed under some >>> circumstances) to have system calls interrupted by signal handling. >>> >>> I have added a loop to automatically retry send(), recv(), sendto(), >>> recvfrom(), accept(), and poll() calls if the call fails with EINTR. >>> Note that I do not believe that the UDP versions of the calls >>> (recvfrom() and sendto()) are actualy ever used in the JDK, but I fixed >>> them in case they are used in the future. >>> >>> The implementation for connect() was more complicated because Solaris >>> does not let us just call connect() again after EINTR. Once a call to >>> connect() fails with EINTR on Solaris, the connection setup continues >>> asynchronously and we need to use select() or poll() to determine when >>> the socket can be used. >>> >>> The patch for jdk7u2 is identical to this (jdk8) fix, if possible, I >>> would like to receive pre-approval to push to jdk7u-dev repository as >>> well. >>> >>> This fix has already been done for 1.4.2/5/6 as part of the JRockit >>> Simplification Project. This needs to be forward ported into 7 and 8 to >>> avoid a regression. >>> >>> Best Regards, >>> -Buck >> >> -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From dmitriy.samersoff at oracle.com Tue Aug 9 05:42:00 2011 From: dmitriy.samersoff at oracle.com (dmitriy.samersoff at oracle.com) Date: Tue, 09 Aug 2011 12:42:00 +0000 Subject: hg: jdk7/hotspot-rt/hotspot: 7073913: The fix for 7017193 causes segfaults Message-ID: <20110809124204.9858447A4D@hg.openjdk.java.net> Changeset: 5dce25362b8a Author: dsamersoff Date: 2011-08-09 11:54 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/5dce25362b8a 7073913: The fix for 7017193 causes segfaults Summary: Buffer overflow in os::get_line_chars Reviewed-by: coleenp, dholmes, dcubed Contributed-by: aph at redhat.com ! src/share/vm/runtime/os.cpp From chris.hegarty at oracle.com Tue Aug 9 07:29:36 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 09 Aug 2011 15:29:36 +0100 Subject: Fwd: Code Review 7073295: TEST_BUG: test/java/lang/instrument/ManifestTest.sh causing havoc (win) Message-ID: <4E414450.9040006@oracle.com> Sorry, should have cc'ed serviceability-dev at openjdk.java.net too. -Chris. -------- Original Message -------- Subject: Code Review 7073295: TEST_BUG: test/java/lang/instrument/ManifestTest.sh causing havoc (win) Date: Tue, 09 Aug 2011 14:05:08 +0100 From: Chris Hegarty To: core-libs-dev , "alan.bateman at oracle.com" Hi, This test creates temporary directories in the scratch area with spaces in their names. It fails on Cygwin because jtreg cannot cleanup after it. Easiest to just have the test cleanup (minimally) after itself. Webrev: http://cr.openjdk.java.net/~chegar/7073295/webrev.00/webrev/ Thanks, -Chris. From chris.hegarty at oracle.com Tue Aug 9 07:52:41 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 09 Aug 2011 15:52:41 +0100 Subject: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin Message-ID: <4E4149B9.1010909@oracle.com> Hi Dan, Alan, This is a trivial change to use /dev/null instead of NUL for Windows test with Cygwin. http://cr.openjdk.java.net/~chegar/7076756/webrev.00/webrev/ Thanks, -Chris. From Alan.Bateman at oracle.com Tue Aug 9 08:07:16 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 09 Aug 2011 16:07:16 +0100 Subject: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin In-Reply-To: <4E4149B9.1010909@oracle.com> References: <4E4149B9.1010909@oracle.com> Message-ID: <4E414D24.2010003@oracle.com> Chris Hegarty wrote: > Hi Dan, Alan, > > This is a trivial change to use /dev/null instead of NUL for Windows > test with Cygwin. > > http://cr.openjdk.java.net/~chegar/7076756/webrev.00/webrev/ > > Thanks, > -Chris. Looks okay although it might be slightly cleaner to set devnull consistently, ie: case Windows* ) devnull=NUL ;; Just a suggestion. -Alan. From mandy.chung at oracle.com Tue Aug 9 08:11:04 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 09 Aug 2011 08:11:04 -0700 Subject: Code Review 7073295: TEST_BUG: test/java/lang/instrument/ManifestTest.sh causing havoc (win) In-Reply-To: <4E413084.7020105@oracle.com> References: <4E413084.7020105@oracle.com> Message-ID: <4E414E08.8060409@oracle.com> Looks good. Mandy On 8/9/11 6:05 AM, Chris Hegarty wrote: > Hi, > > This test creates temporary directories in the scratch area with > spaces in their names. It fails on Cygwin because jtreg cannot cleanup > after it. Easiest to just have the test cleanup (minimally) after itself. > > Webrev: > http://cr.openjdk.java.net/~chegar/7073295/webrev.00/webrev/ > > Thanks, > -Chris. From chris.hegarty at oracle.com Tue Aug 9 08:40:42 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 09 Aug 2011 15:40:42 +0000 Subject: hg: jdk8/tl/jdk: 7073295: TEST_BUG: test/java/lang/instrument/ManifestTest.sh causing havoc (win) Message-ID: <20110809154108.32B0647A55@hg.openjdk.java.net> Changeset: 26fe74aa48ef Author: chegar Date: 2011-08-09 16:39 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/26fe74aa48ef 7073295: TEST_BUG: test/java/lang/instrument/ManifestTest.sh causing havoc (win) Reviewed-by: mchung ! test/java/lang/instrument/ManifestTest.sh From daniel.daugherty at oracle.com Tue Aug 9 08:52:55 2011 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 09 Aug 2011 09:52:55 -0600 Subject: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin In-Reply-To: <4E4149B9.1010909@oracle.com> References: <4E4149B9.1010909@oracle.com> Message-ID: <4E4157D7.9060309@oracle.com> On 8/9/11 8:52 AM, Chris Hegarty wrote: > Hi Dan, Alan, > > This is a trivial change to use /dev/null instead of NUL for Windows > test with Cygwin. > > http://cr.openjdk.java.net/~chegar/7076756/webrev.00/webrev/ > > Thanks, > -Chris. I'm good with the change, but the bug report itself is less than clear. I run these tests all the time on WinXP/Cygwin so I'm guessing that there is more going on here than meets the eye. I'm going to guess that the '-samevm' option is the enabler for this failure mode. The failure mode that you fixed should also affect tests other than BreakpointWithFullGC.sh so I'm not quite sure why this issue appears with just that test. Or maybe it does appear with other tests, but again the bug report isn't clear. In any case, thumbs up on the change. Dan From chris.hegarty at oracle.com Tue Aug 9 08:56:49 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 09 Aug 2011 16:56:49 +0100 Subject: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin In-Reply-To: <4E4157D7.9060309@oracle.com> References: <4E4149B9.1010909@oracle.com> <4E4157D7.9060309@oracle.com> Message-ID: <4E4158C1.8000502@oracle.com> Sorry Dan, I'll put a more complete description in the bug report. This issue, from what I can tell only happens with very recent Cygwin versions. I'm running 1.7.9. When running the com/sun/jdi tests in a batch, in samevm mode, this test leave behind a file, NUL, in the scratch directory that cannot be deleted. This causes the remaining tests to also fail. Thanks for the review, -Chris. On 08/ 9/11 04:52 PM, Daniel D. Daugherty wrote: > On 8/9/11 8:52 AM, Chris Hegarty wrote: >> Hi Dan, Alan, >> >> This is a trivial change to use /dev/null instead of NUL for Windows >> test with Cygwin. >> >> http://cr.openjdk.java.net/~chegar/7076756/webrev.00/webrev/ >> >> Thanks, >> -Chris. > > I'm good with the change, but the bug report itself is less than clear. > > I run these tests all the time on WinXP/Cygwin so I'm guessing > that there is more going on here than meets the eye. I'm going to > guess that the '-samevm' option is the enabler for this failure > mode. The failure mode that you fixed should also affect tests > other than BreakpointWithFullGC.sh so I'm not quite sure why > this issue appears with just that test. Or maybe it does appear > with other tests, but again the bug report isn't clear. > > In any case, thumbs up on the change. > > Dan > From chris.hegarty at oracle.com Tue Aug 9 09:00:41 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 09 Aug 2011 16:00:41 +0000 Subject: hg: jdk8/tl/jdk: 7076756: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin Message-ID: <20110809160051.5F3A647A58@hg.openjdk.java.net> Changeset: cf203f293b4e Author: chegar Date: 2011-08-09 16:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf203f293b4e 7076756: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin Reviewed-by: alanb, dcubed ! test/com/sun/jdi/ShellScaffold.sh From daniel.daugherty at oracle.com Tue Aug 9 09:11:16 2011 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 09 Aug 2011 10:11:16 -0600 Subject: Fwd: Code Review 7073295: TEST_BUG: test/java/lang/instrument/ManifestTest.sh causing havoc (win) In-Reply-To: <4E414450.9040006@oracle.com> References: <4E414450.9040006@oracle.com> Message-ID: <4E415C24.1090302@oracle.com> On 8/9/11 8:29 AM, Chris Hegarty wrote: > Sorry, should have cc'ed serviceability-dev at openjdk.java.net too. > > -Chris. > > -------- Original Message -------- > Subject: Code Review 7073295: TEST_BUG: > test/java/lang/instrument/ManifestTest.sh causing havoc (win) > Date: Tue, 09 Aug 2011 14:05:08 +0100 > From: Chris Hegarty > To: core-libs-dev , > "alan.bateman at oracle.com" > > Hi, > > This test creates temporary directories in the scratch area with spaces > in their names. It fails on Cygwin because jtreg cannot cleanup after > it. Easiest to just have the test cleanup (minimally) after itself. > > Webrev: > http://cr.openjdk.java.net/~chegar/7073295/webrev.00/webrev/ > > Thanks, > -Chris. I run these tests all the time on WinXP/Cygwin so the use of the '-samevm' option is the enabler here also. 'samevm' mode is mentioned in this bug report (yeah!), but it could be more clear that the test falls over because that option is used. Alan and I discussed this test off list and our last hypothesis was that the strange filenames/dirnames were the culprit. I just didn't get back to the issue. Sorry about that. I'm not quite sure I have my brain wrapped around why ExampleForBootClassPath had to be added to the "@run build" line, but I'm OK with that change also. I'm presuming that you are only cleaning up the hard to remove stuff and leaving the other dirs for JTREG to clean up. For example, there are two dirs: "has_leading_blank" and " has_leading_blank". The dir without the blank has the bad class file in it to make sure that we actually use the right dir (the one with the blank in it). Your fix only removes " has_leading_blank" and "has_leading_blank" is left behind. The bug ID list should also be updated, but that's a nit. Thumbs up. Dan From james.holmlund at oracle.com Tue Aug 9 09:18:38 2011 From: james.holmlund at oracle.com (Jim Holmlund) Date: Tue, 09 Aug 2011 09:18:38 -0700 Subject: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin In-Reply-To: <4E4158C1.8000502@oracle.com> References: <4E4149B9.1010909@oracle.com> <4E4157D7.9060309@oracle.com> <4E4158C1.8000502@oracle.com> Message-ID: <4E415DDE.1060504@oracle.com> Will this work on older versions of cygwin? Or do we have a spec someplace that says cygwin versions older than xxxx aren't supported? - jjh On 8/9/2011 8:56 AM, Chris Hegarty wrote: > Sorry Dan, I'll put a more complete description in the bug report. > > This issue, from what I can tell only happens with very recent Cygwin versions. I'm running 1.7.9. > When running the com/sun/jdi tests in a batch, in samevm mode, this test leave behind a file, NUL, > in the scratch directory that cannot be deleted. This causes the remaining tests to also fail. > > Thanks for the review, > -Chris. > > On 08/ 9/11 04:52 PM, Daniel D. Daugherty wrote: >> On 8/9/11 8:52 AM, Chris Hegarty wrote: >>> Hi Dan, Alan, >>> >>> This is a trivial change to use /dev/null instead of NUL for Windows >>> test with Cygwin. >>> >>> http://cr.openjdk.java.net/~chegar/7076756/webrev.00/webrev/ >>> >>> Thanks, >>> -Chris. >> >> I'm good with the change, but the bug report itself is less than clear. >> >> I run these tests all the time on WinXP/Cygwin so I'm guessing >> that there is more going on here than meets the eye. I'm going to >> guess that the '-samevm' option is the enabler for this failure >> mode. The failure mode that you fixed should also affect tests >> other than BreakpointWithFullGC.sh so I'm not quite sure why >> this issue appears with just that test. Or maybe it does appear >> with other tests, but again the bug report isn't clear. >> >> In any case, thumbs up on the change. >> >> Dan >> From daniel.daugherty at oracle.com Tue Aug 9 09:23:14 2011 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 09 Aug 2011 10:23:14 -0600 Subject: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin In-Reply-To: <4E415DDE.1060504@oracle.com> References: <4E4149B9.1010909@oracle.com> <4E4157D7.9060309@oracle.com> <4E4158C1.8000502@oracle.com> <4E415DDE.1060504@oracle.com> Message-ID: <4E415EF2.4060709@oracle.com> Yes, "/dev/null" works with the "1.5.X" version of Cygwin. 1.5.X is considered the "legacy" version of Cygwin and I believe the VM/SQE is still using it in the nightly testing infrastructure. Dan 547 2011.08.09 10:22:32 $ uname -a CYGWIN_NT-5.1 oliver-lt 1.5.25(0.156/4/2) 2008-06-12 19:34 i686 Cygwin 548 2011.08.09 10:22:41 $ ls -l /dev/null crw-rw-rw- 1 dcubed None 1, 3 Nov 30 2006 /dev/null 549 2011.08.09 10:22:45 $ echo "hello" > /dev/null 550 2011.08.09 10:22:52 $ On 8/9/11 10:18 AM, Jim Holmlund wrote: > Will this work on older versions of cygwin? Or do we have a spec > someplace that says cygwin versions older than xxxx aren't supported? > - jjh > > > On 8/9/2011 8:56 AM, Chris Hegarty wrote: >> Sorry Dan, I'll put a more complete description in the bug report. >> >> This issue, from what I can tell only happens with very recent Cygwin >> versions. I'm running 1.7.9. When running the com/sun/jdi tests in a >> batch, in samevm mode, this test leave behind a file, NUL, in the >> scratch directory that cannot be deleted. This causes the remaining >> tests to also fail. >> >> Thanks for the review, >> -Chris. >> >> On 08/ 9/11 04:52 PM, Daniel D. Daugherty wrote: >>> On 8/9/11 8:52 AM, Chris Hegarty wrote: >>>> Hi Dan, Alan, >>>> >>>> This is a trivial change to use /dev/null instead of NUL for Windows >>>> test with Cygwin. >>>> >>>> http://cr.openjdk.java.net/~chegar/7076756/webrev.00/webrev/ >>>> >>>> Thanks, >>>> -Chris. >>> >>> I'm good with the change, but the bug report itself is less than clear. >>> >>> I run these tests all the time on WinXP/Cygwin so I'm guessing >>> that there is more going on here than meets the eye. I'm going to >>> guess that the '-samevm' option is the enabler for this failure >>> mode. The failure mode that you fixed should also affect tests >>> other than BreakpointWithFullGC.sh so I'm not quite sure why >>> this issue appears with just that test. Or maybe it does appear >>> with other tests, but again the bug report isn't clear. >>> >>> In any case, thumbs up on the change. >>> >>> Dan >>> From chris.hegarty at oracle.com Tue Aug 9 09:25:55 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 09 Aug 2011 17:25:55 +0100 Subject: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin In-Reply-To: <4E415DDE.1060504@oracle.com> References: <4E4149B9.1010909@oracle.com> <4E4157D7.9060309@oracle.com> <4E4158C1.8000502@oracle.com> <4E415DDE.1060504@oracle.com> Message-ID: <4E415F93.4020605@oracle.com> On 08/ 9/11 05:18 PM, Jim Holmlund wrote: > Will this work on older versions of cygwin? Or do we have a spec > someplace that says cygwin versions older than xxxx aren't supported? I have not seen any docs/spec anywhere for support of /dev/null in specific Cygwin releases, but I did test on 1.5 and 1.7.9 and MKS, and all went fine. http://www.cygwin.com/cygwin-ug-net/using-specialnames.html I didn't have time to submit a jprt job on this, but tested on Windows Cygwin/MKS, Solaris, and Linux. I believe the TL integrator will be doing a full jprt run later today. If we don't see a few hundred failures then we should be good ;-) -Chris. > - jjh > > > On 8/9/2011 8:56 AM, Chris Hegarty wrote: >> Sorry Dan, I'll put a more complete description in the bug report. >> >> This issue, from what I can tell only happens with very recent Cygwin >> versions. I'm running 1.7.9. When running the com/sun/jdi tests in a >> batch, in samevm mode, this test leave behind a file, NUL, in the >> scratch directory that cannot be deleted. This causes the remaining >> tests to also fail. >> >> Thanks for the review, >> -Chris. >> >> On 08/ 9/11 04:52 PM, Daniel D. Daugherty wrote: >>> On 8/9/11 8:52 AM, Chris Hegarty wrote: >>>> Hi Dan, Alan, >>>> >>>> This is a trivial change to use /dev/null instead of NUL for Windows >>>> test with Cygwin. >>>> >>>> http://cr.openjdk.java.net/~chegar/7076756/webrev.00/webrev/ >>>> >>>> Thanks, >>>> -Chris. >>> >>> I'm good with the change, but the bug report itself is less than clear. >>> >>> I run these tests all the time on WinXP/Cygwin so I'm guessing >>> that there is more going on here than meets the eye. I'm going to >>> guess that the '-samevm' option is the enabler for this failure >>> mode. The failure mode that you fixed should also affect tests >>> other than BreakpointWithFullGC.sh so I'm not quite sure why >>> this issue appears with just that test. Or maybe it does appear >>> with other tests, but again the bug report isn't clear. >>> >>> In any case, thumbs up on the change. >>> >>> Dan >>> From james.holmlund at oracle.com Tue Aug 9 09:59:36 2011 From: james.holmlund at oracle.com (Jim Holmlund) Date: Tue, 09 Aug 2011 09:59:36 -0700 Subject: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin In-Reply-To: <4E415F93.4020605@oracle.com> References: <4E4149B9.1010909@oracle.com> <4E4157D7.9060309@oracle.com> <4E4158C1.8000502@oracle.com> <4E415DDE.1060504@oracle.com> <4E415F93.4020605@oracle.com> Message-ID: <4E416778.1040509@oracle.com> > Yes, "/dev/null" works with the "1.5.X" version of Cygwin. > 1.5.X is considered the "legacy" version of Cygwin and I > believe the VM/SQE is still using it in the nightly testing > infrastructure. > > Dan Ok thanks Chris and Dan. When I created ShellScaffold.sh long ago and far away, it must have been on a pre 1.5 version of cygwin. - jjh On 8/9/2011 9:25 AM, Chris Hegarty wrote: > On 08/ 9/11 05:18 PM, Jim Holmlund wrote: >> Will this work on older versions of cygwin? Or do we have a spec >> someplace that says cygwin versions older than xxxx aren't supported? > > I have not seen any docs/spec anywhere for support of /dev/null in specific Cygwin releases, but I > did test on 1.5 and 1.7.9 and MKS, and all went fine. > > http://www.cygwin.com/cygwin-ug-net/using-specialnames.html > > I didn't have time to submit a jprt job on this, but tested on Windows Cygwin/MKS, Solaris, and > Linux. I believe the TL integrator will be doing a full jprt run later today. If we don't see a > few hundred failures then we should be good ;-) > > -Chris. > >> - jjh >> >> >> On 8/9/2011 8:56 AM, Chris Hegarty wrote: >>> Sorry Dan, I'll put a more complete description in the bug report. >>> >>> This issue, from what I can tell only happens with very recent Cygwin >>> versions. I'm running 1.7.9. When running the com/sun/jdi tests in a >>> batch, in samevm mode, this test leave behind a file, NUL, in the >>> scratch directory that cannot be deleted. This causes the remaining >>> tests to also fail. >>> >>> Thanks for the review, >>> -Chris. >>> >>> On 08/ 9/11 04:52 PM, Daniel D. Daugherty wrote: >>>> On 8/9/11 8:52 AM, Chris Hegarty wrote: >>>>> Hi Dan, Alan, >>>>> >>>>> This is a trivial change to use /dev/null instead of NUL for Windows >>>>> test with Cygwin. >>>>> >>>>> http://cr.openjdk.java.net/~chegar/7076756/webrev.00/webrev/ >>>>> >>>>> Thanks, >>>>> -Chris. >>>> >>>> I'm good with the change, but the bug report itself is less than clear. >>>> >>>> I run these tests all the time on WinXP/Cygwin so I'm guessing >>>> that there is more going on here than meets the eye. I'm going to >>>> guess that the '-samevm' option is the enabler for this failure >>>> mode. The failure mode that you fixed should also affect tests >>>> other than BreakpointWithFullGC.sh so I'm not quite sure why >>>> this issue appears with just that test. Or maybe it does appear >>>> with other tests, but again the bug report isn't clear. >>>> >>>> In any case, thumbs up on the change. >>>> >>>> Dan >>>> From chris.hegarty at oracle.com Tue Aug 9 13:02:07 2011 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Tue, 09 Aug 2011 21:02:07 +0100 Subject: Fwd: Code Review 7073295: TEST_BUG: test/java/lang/instrument/ManifestTest.sh causing havoc (win) In-Reply-To: <4E415C24.1090302@oracle.com> References: <4E414450.9040006@oracle.com> <4E415C24.1090302@oracle.com> Message-ID: <4E41923F.1040004@oracle.com> On 08/ 9/11 05:11 PM, Daniel D. Daugherty wrote: > On 8/9/11 8:29 AM, Chris Hegarty wrote: >> Sorry, should have cc'ed serviceability-dev at openjdk.java.net too. >> >> -Chris. >> >> -------- Original Message -------- >> Subject: Code Review 7073295: TEST_BUG: >> test/java/lang/instrument/ManifestTest.sh causing havoc (win) >> Date: Tue, 09 Aug 2011 14:05:08 +0100 >> From: Chris Hegarty >> To: core-libs-dev , >> "alan.bateman at oracle.com" >> >> Hi, >> >> This test creates temporary directories in the scratch area with spaces >> in their names. It fails on Cygwin because jtreg cannot cleanup after >> it. Easiest to just have the test cleanup (minimally) after itself. >> >> Webrev: >> http://cr.openjdk.java.net/~chegar/7073295/webrev.00/webrev/ >> >> Thanks, >> -Chris. > > I run these tests all the time on WinXP/Cygwin so the use of the > '-samevm' option is the enabler here also. 'samevm' mode is mentioned > in this bug report (yeah!), but it could be more clear that the test > falls over because that option is used. Sorry my fault, most of our recent test issues have been caused by samevm mode, it's hard to think of anything else now ;-( > Alan and I discussed this test off list and our last hypothesis was > that the strange filenames/dirnames were the culprit. I just didn't > get back to the issue. Sorry about that. > > I'm not quite sure I have my brain wrapped around why > ExampleForBootClassPath had to be added to the "@run build" line, > but I'm OK with that change also. The reason for adding ExampleForBootClassPath to the build line is that the shell script at some point moves ExampleForBootClassPath.class to a different dir. If the test is rerun without removing ManifestTestApp.class, then jtreg does not recompile ManifestTestApp.java, which means that ExampleForBootClassPath doesn't get compiled, which means the .class file is not in the expected dir. (Thanks JimH for finding this.) Not a showstopper, but worth fixing since we noticed it. > I'm presuming that you are only cleaning up the hard to remove stuff > and leaving the other dirs for JTREG to clean up. For example, there > are two dirs: "has_leading_blank" and " has_leading_blank". The dir > without the blank has the bad class file in it to make sure that we > actually use the right dir (the one with the blank in it). Your fix > only removes " has_leading_blank" and "has_leading_blank" is left > behind. That's right, not exactly pretty but I though it was the simplest way to go here. jtreg can handle the rest. > The bug ID list should also be updated, but that's a nit. Ahhh... sorry. Probably not worth filing a CR to add this, but I will piggyback it to my next changeset if that is ok. -Chris. > Thumbs up. > > Dan > > > From daniel.daugherty at oracle.com Tue Aug 9 13:06:49 2011 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 09 Aug 2011 14:06:49 -0600 Subject: Fwd: Code Review 7073295: TEST_BUG: test/java/lang/instrument/ManifestTest.sh causing havoc (win) In-Reply-To: <4E41923F.1040004@oracle.com> References: <4E414450.9040006@oracle.com> <4E415C24.1090302@oracle.com> <4E41923F.1040004@oracle.com> Message-ID: <4E419359.1000209@oracle.com> Thanks for closing the loop. The changes are good as is. Dan On 8/9/11 2:02 PM, Chris Hegarty wrote: > On 08/ 9/11 05:11 PM, Daniel D. Daugherty wrote: >> On 8/9/11 8:29 AM, Chris Hegarty wrote: >>> Sorry, should have cc'ed serviceability-dev at openjdk.java.net too. >>> >>> -Chris. >>> >>> -------- Original Message -------- >>> Subject: Code Review 7073295: TEST_BUG: >>> test/java/lang/instrument/ManifestTest.sh causing havoc (win) >>> Date: Tue, 09 Aug 2011 14:05:08 +0100 >>> From: Chris Hegarty >>> To: core-libs-dev , >>> "alan.bateman at oracle.com" >>> >>> Hi, >>> >>> This test creates temporary directories in the scratch area with spaces >>> in their names. It fails on Cygwin because jtreg cannot cleanup after >>> it. Easiest to just have the test cleanup (minimally) after itself. >>> >>> Webrev: >>> http://cr.openjdk.java.net/~chegar/7073295/webrev.00/webrev/ >>> >>> Thanks, >>> -Chris. >> >> I run these tests all the time on WinXP/Cygwin so the use of the >> '-samevm' option is the enabler here also. 'samevm' mode is mentioned >> in this bug report (yeah!), but it could be more clear that the test >> falls over because that option is used. > > Sorry my fault, most of our recent test issues have been caused by > samevm mode, it's hard to think of anything else now ;-( > >> Alan and I discussed this test off list and our last hypothesis was >> that the strange filenames/dirnames were the culprit. I just didn't >> get back to the issue. Sorry about that. >> >> I'm not quite sure I have my brain wrapped around why >> ExampleForBootClassPath had to be added to the "@run build" line, >> but I'm OK with that change also. > > The reason for adding ExampleForBootClassPath to the build line is > that the shell script at some point moves > ExampleForBootClassPath.class to a different dir. If the test is > rerun without removing ManifestTestApp.class, then jtreg does not > recompile ManifestTestApp.java, which means that > ExampleForBootClassPath doesn't get compiled, which means the .class > file is not in the expected dir. (Thanks JimH for finding this.) > > Not a showstopper, but worth fixing since we noticed it. > >> I'm presuming that you are only cleaning up the hard to remove stuff >> and leaving the other dirs for JTREG to clean up. For example, there >> are two dirs: "has_leading_blank" and " has_leading_blank". The dir >> without the blank has the bad class file in it to make sure that we >> actually use the right dir (the one with the blank in it). Your fix >> only removes " has_leading_blank" and "has_leading_blank" is left >> behind. > > That's right, not exactly pretty but I though it was the simplest way > to go here. jtreg can handle the rest. > >> The bug ID list should also be updated, but that's a nit. > > Ahhh... sorry. Probably not worth filing a CR to add this, but I will > piggyback it to my next changeset if that is ok. > > -Chris. > >> Thumbs up. >> >> Dan >> >> >> From John.Coomes at oracle.com Tue Aug 9 17:39:44 2011 From: John.Coomes at oracle.com (John Coomes) Date: Tue, 9 Aug 2011 17:39:44 -0700 Subject: hg: jdk7/hotspot-rt/hotspot: 7073913: The fix for 7017193 causes segfaults In-Reply-To: <20110809124204.9858447A4D@hg.openjdk.java.net> References: <20110809124204.9858447A4D@hg.openjdk.java.net> Message-ID: <20033.54096.263634.771402@oracle.com> dmitriy.samersoff at oracle.com (dmitriy.samersoff at oracle.com) wrote: > Changeset: 5dce25362b8a > Author: dsamersoff > Date: 2011-08-09 11:54 +0400 > URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/5dce25362b8a > > 7073913: The fix for 7017193 causes segfaults > Summary: Buffer overflow in os::get_line_chars > Reviewed-by: coleenp, dholmes, dcubed > Contributed-by: aph at redhat.com > > ! src/share/vm/runtime/os.cpp Hi Dmitry, This went to the wrong repo; you should push to hsx/hotspot-rt/hotspot. -John From Dmitry.Samersoff at oracle.com Wed Aug 10 00:26:23 2011 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 10 Aug 2011 11:26:23 +0400 Subject: hg: jdk7/hotspot-rt/hotspot: 7073913: The fix for 7017193 causes segfaults In-Reply-To: <20033.54096.263634.771402@oracle.com> References: <20110809124204.9858447A4D@hg.openjdk.java.net> <20033.54096.263634.771402@oracle.com> Message-ID: <4E42329F.3020101@oracle.com> John, Will do. Sorry for mistake. -Dmitry On 2011-08-10 04:39, John Coomes wrote: > dmitriy.samersoff at oracle.com (dmitriy.samersoff at oracle.com) wrote: >> Changeset: 5dce25362b8a >> Author: dsamersoff >> Date: 2011-08-09 11:54 +0400 >> URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/5dce25362b8a >> >> 7073913: The fix for 7017193 causes segfaults >> Summary: Buffer overflow in os::get_line_chars >> Reviewed-by: coleenp, dholmes, dcubed >> Contributed-by: aph at redhat.com >> >> ! src/share/vm/runtime/os.cpp > > Hi Dmitry, > > This went to the wrong repo; you should push to > hsx/hotspot-rt/hotspot. > > -John -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From chris.hegarty at oracle.com Wed Aug 10 04:32:02 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 10 Aug 2011 11:32:02 +0000 Subject: hg: jdk8/tl/jdk: 7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE Message-ID: <20110810113223.B96B047A8D@hg.openjdk.java.net> Changeset: af15e902cf08 Author: chegar Date: 2011-08-10 12:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af15e902cf08 7076523: TEST_BUG: test/java/net/NetworkInterface/NetParamsTest.java can fail with NPE Reviewed-by: alanb ! test/java/net/NetworkInterface/NetParamsTest.java From david.buck at oracle.com Mon Aug 8 22:33:16 2011 From: david.buck at oracle.com (David Buck) Date: Tue, 09 Aug 2011 14:33:16 +0900 Subject: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR) In-Reply-To: <4E3AF59C.5090206@oracle.com> References: <4E3A8A4F.60609@oracle.com> <4E3ABFCE.3070408@oracle.com> <4E3AC67E.7080208@oracle.com> <4E3AF59C.5090206@oracle.com> Message-ID: <4E40C69C.3040003@oracle.com> Hi Alan! After looking at the code, I think that not-honoring the timeout would be a bug. I will fix this and resubmit my review request. (I also have other changes to make based on Dmitry Samersoff's comment, so this may take a bit longer before the new version is submitted. Thanks for the catch! Cheers, -Buck On 08/05/11 04:40, Alan Bateman wrote: > Daniel D. Daugherty wrote: >> : >> >>> I looked at the webrev and it mostly looks okay to me. One issue is >>> that dbgsysPoll probably should adjust the timeout when interrupted. >> >> Adjust it how? (Just curious) > If the poll is interrupted close to the timeout then it will restart the > poll with the original timeout so it will be longer than it should. For > the debugger transport I don't think this is a big issue as the timeout > is only used in the initial handshake (if I remember correctly). It may > be more trouble that its worth to fix this. As to how then gettimeofday > could be used so that we get the elapsed time of the interrupted poll > and that could be used to adjust the timeout. There are a couple of > example in other places in the JDK. > > -Alan From david.buck at oracle.com Mon Aug 8 23:18:47 2011 From: david.buck at oracle.com (David Buck) Date: Tue, 09 Aug 2011 15:18:47 +0900 Subject: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR) In-Reply-To: <4E3A9DB5.8080909@oracle.com> References: <4E3A8A4F.60609@oracle.com> <4E3A9DB5.8080909@oracle.com> Message-ID: <4E40D147.9000107@oracle.com> Hi Dmitry! Thank you for the helpful feedback. Even on Solaris, I should have called getsockopt() after poll() returns. Not sure how I missed that. Thanks for the catch! I am not so sure i should include a second call to connect() after the first one returns with EINTR. All of the "standard" unix docs (SUS, Richard Steven's "Unix Network Programming") for connect() clearly require that an interrupted call to connect() (on a blocking socket) result in a asynchronous connection setup. This seems to work fine on Linux as well. My understanding is that the fact that Linux will sometimes let us just re-call connect() and get the blocking behavior (just like our original call) or return EINPROGRESS is more of a convenience (that encourages programmers to write non-portable code). In other words, I don't think you HAVE to call connect() again before doing a poll() or select(). The specification guarantees an asynchronous attempt at connection setup and if we found an instance where it didn't do that, we would be justified in calling it a bug. If possible, I would like one implementation that works on both (and follows the specification strictly) and avoid adding any ifdefs to the code. Cheers, -Buck On 08/04/11 22:25, Dmitry Samersoff wrote: > David, > > To be on safe side with connect() (on Linux, not sure for Solaris) > you need to call connect() again and if it returns EINPROGRESS, run > polling loop. After poll() it's recommended to call getsockopt() and > read the SO_ERROR to determine whether connect was successful or not. > > -Dmitry > > > On 2011-08-04 16:02, David Buck wrote: >> Hi! >> >> I would like to request that my fix for 7011591 be reviewed for push >> into JDK8 (and JDK7u if possible). >> >> CR: 7011591 JDWP socket transport should restart interrupted system >> calls (EINTR) >> >> Weblink: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=2205030 >> (for some reason, the public URL for the parent bug is not working. (I >> believe that SubCR 2205030 will have all needed information.) >> >> Webrev: http://cr.openjdk.java.net/~dbuck/7011591/webrev.00/ >> >> Description: >> Syscalls that can be interrupted by signal handling should automatically >> retry if they fail with EINTR. Unfortunately, the JDWP socket transport >> implementation does not do this. Since HotSpot does not use signals for >> thread suspension, HotSpot customers have not run into any problem (as >> far as I know). But because JRockit R27 and earlier releases use signals >> to suspend threads, all threads are constantly being interrupted thus >> JRockit customers are much more likely (almost guaranteed under some >> circumstances) to have system calls interrupted by signal handling. >> >> I have added a loop to automatically retry send(), recv(), sendto(), >> recvfrom(), accept(), and poll() calls if the call fails with EINTR. >> Note that I do not believe that the UDP versions of the calls >> (recvfrom() and sendto()) are actualy ever used in the JDK, but I fixed >> them in case they are used in the future. >> >> The implementation for connect() was more complicated because Solaris >> does not let us just call connect() again after EINTR. Once a call to >> connect() fails with EINTR on Solaris, the connection setup continues >> asynchronously and we need to use select() or poll() to determine when >> the socket can be used. >> >> The patch for jdk7u2 is identical to this (jdk8) fix, if possible, I >> would like to receive pre-approval to push to jdk7u-dev repository as >> well. >> >> This fix has already been done for 1.4.2/5/6 as part of the JRockit >> Simplification Project. This needs to be forward ported into 7 and 8 to >> avoid a regression. >> >> Best Regards, >> -Buck > > From dmitriy.samersoff at oracle.com Wed Aug 10 11:05:12 2011 From: dmitriy.samersoff at oracle.com (dmitriy.samersoff at oracle.com) Date: Wed, 10 Aug 2011 18:05:12 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7073913: The fix for 7017193 causes segfaults Message-ID: <20110810180517.7540947AA2@hg.openjdk.java.net> Changeset: 46cb9a7b8b01 Author: dsamersoff Date: 2011-08-10 15:04 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/46cb9a7b8b01 7073913: The fix for 7017193 causes segfaults Summary: Buffer overflow in os::get_line_chars Reviewed-by: coleenp, dholmes, dcubed Contributed-by: aph at redhat.com ! src/share/vm/runtime/os.cpp From lance.andersen at oracle.com Wed Aug 10 13:25:05 2011 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Wed, 10 Aug 2011 20:25:05 +0000 Subject: hg: jdk8/tl/jdk: 7077451: SerialLob, SerialClob have the wrong checks for setStream methods Message-ID: <20110810202515.3906547AA7@hg.openjdk.java.net> Changeset: 7676670d1e97 Author: lancea Date: 2011-08-10 16:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7676670d1e97 7077451: SerialLob, SerialClob have the wrong checks for setStream methods Reviewed-by: alanb Contributed-by: Patrick Reinhart ! src/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/share/classes/javax/sql/rowset/serial/SerialClob.java + test/javax/sql/rowset/serial/SerialBlob/SetBinaryStream.java + test/javax/sql/rowset/serial/SerialClob/SetAsciiStream.java + test/javax/sql/rowset/serial/SerialClob/SetCharacterStream.java From jonathan.gibbons at oracle.com Wed Aug 10 14:09:18 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 10 Aug 2011 21:09:18 +0000 Subject: hg: jdk8/tl/jdk: 7072353: JNDI libraries do not build with javac -Xlint:all -Werror Message-ID: <20110810210928.54A6E47AAC@hg.openjdk.java.net> Changeset: 18329abcdb7c Author: jjg Date: 2011-08-10 13:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18329abcdb7c 7072353: JNDI libraries do not build with javac -Xlint:all -Werror Reviewed-by: xuelei Contributed-by: alexandre.boulgakov at oracle.com ! make/com/sun/jndi/Makefile ! make/javax/others/Makefile ! src/share/classes/com/sun/jndi/cosnaming/CNBindingEnumeration.java ! src/share/classes/com/sun/jndi/cosnaming/CNCtx.java ! src/share/classes/com/sun/jndi/cosnaming/CNNameParser.java ! src/share/classes/com/sun/jndi/cosnaming/ExceptionMapper.java ! src/share/classes/com/sun/jndi/cosnaming/IiopUrl.java ! src/share/classes/com/sun/jndi/dns/DnsClient.java ! src/share/classes/com/sun/jndi/dns/DnsContext.java ! src/share/classes/com/sun/jndi/dns/DnsContextFactory.java ! src/share/classes/com/sun/jndi/dns/DnsName.java ! src/share/classes/com/sun/jndi/dns/NameNode.java ! src/share/classes/com/sun/jndi/dns/Resolver.java ! src/share/classes/com/sun/jndi/dns/ResourceRecords.java ! src/share/classes/com/sun/jndi/dns/ZoneNode.java + src/share/classes/com/sun/jndi/ldap/AbstractLdapNamingEnumeration.java ! src/share/classes/com/sun/jndi/ldap/Ber.java ! src/share/classes/com/sun/jndi/ldap/ClientId.java ! src/share/classes/com/sun/jndi/ldap/Connection.java ! src/share/classes/com/sun/jndi/ldap/DigestClientId.java ! src/share/classes/com/sun/jndi/ldap/EventQueue.java ! src/share/classes/com/sun/jndi/ldap/EventSupport.java ! src/share/classes/com/sun/jndi/ldap/LdapAttribute.java ! src/share/classes/com/sun/jndi/ldap/LdapBindingEnumeration.java ! src/share/classes/com/sun/jndi/ldap/LdapClient.java ! src/share/classes/com/sun/jndi/ldap/LdapCtx.java ! src/share/classes/com/sun/jndi/ldap/LdapCtxFactory.java ! src/share/classes/com/sun/jndi/ldap/LdapEntry.java ! src/share/classes/com/sun/jndi/ldap/LdapName.java ! src/share/classes/com/sun/jndi/ldap/LdapNamingEnumeration.java ! src/share/classes/com/sun/jndi/ldap/LdapPoolManager.java ! src/share/classes/com/sun/jndi/ldap/LdapReferralContext.java ! src/share/classes/com/sun/jndi/ldap/LdapReferralException.java ! src/share/classes/com/sun/jndi/ldap/LdapResult.java ! src/share/classes/com/sun/jndi/ldap/LdapSchemaCtx.java ! src/share/classes/com/sun/jndi/ldap/LdapSchemaParser.java ! src/share/classes/com/sun/jndi/ldap/LdapSearchEnumeration.java ! src/share/classes/com/sun/jndi/ldap/NamingEventNotifier.java ! src/share/classes/com/sun/jndi/ldap/NotifierArgs.java ! src/share/classes/com/sun/jndi/ldap/Obj.java ! src/share/classes/com/sun/jndi/ldap/ReferralEnumeration.java ! src/share/classes/com/sun/jndi/ldap/ServiceLocator.java ! src/share/classes/com/sun/jndi/ldap/SimpleClientId.java ! src/share/classes/com/sun/jndi/ldap/UnsolicitedResponseImpl.java ! src/share/classes/com/sun/jndi/ldap/VersionHelper.java ! src/share/classes/com/sun/jndi/ldap/VersionHelper12.java ! src/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java ! src/share/classes/com/sun/jndi/ldap/pool/Connections.java ! src/share/classes/com/sun/jndi/ldap/pool/ConnectionsWeakRef.java ! src/share/classes/com/sun/jndi/ldap/pool/Pool.java ! src/share/classes/com/sun/jndi/ldap/pool/PoolCleaner.java ! src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java ! src/share/classes/com/sun/jndi/ldap/sasl/LdapSasl.java ! src/share/classes/com/sun/jndi/rmi/registry/RegistryContext.java ! src/share/classes/com/sun/jndi/rmi/registry/RegistryContextFactory.java ! src/share/classes/com/sun/jndi/toolkit/corba/CorbaUtils.java ! src/share/classes/com/sun/jndi/toolkit/ctx/AtomicContext.java ! src/share/classes/com/sun/jndi/toolkit/ctx/AtomicDirContext.java ! src/share/classes/com/sun/jndi/toolkit/ctx/ComponentContext.java ! src/share/classes/com/sun/jndi/toolkit/ctx/ComponentDirContext.java ! src/share/classes/com/sun/jndi/toolkit/ctx/Continuation.java ! src/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeContext.java ! src/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeDirContext.java ! src/share/classes/com/sun/jndi/toolkit/dir/ContainmentFilter.java ! src/share/classes/com/sun/jndi/toolkit/dir/ContextEnumerator.java ! src/share/classes/com/sun/jndi/toolkit/dir/DirSearch.java ! src/share/classes/com/sun/jndi/toolkit/dir/HierMemDirCtx.java ! src/share/classes/com/sun/jndi/toolkit/dir/LazySearchEnumerationImpl.java ! src/share/classes/com/sun/jndi/toolkit/dir/SearchFilter.java ! src/share/classes/com/sun/jndi/toolkit/url/GenericURLContext.java ! src/share/classes/com/sun/jndi/toolkit/url/GenericURLDirContext.java ! src/share/classes/com/sun/jndi/url/dns/dnsURLContext.java ! src/share/classes/com/sun/jndi/url/dns/dnsURLContextFactory.java ! src/share/classes/com/sun/jndi/url/iiop/iiopURLContext.java ! src/share/classes/com/sun/jndi/url/iiop/iiopURLContextFactory.java ! src/share/classes/com/sun/jndi/url/ldap/ldapURLContext.java ! src/share/classes/com/sun/jndi/url/ldap/ldapURLContextFactory.java ! src/share/classes/com/sun/jndi/url/rmi/rmiURLContext.java ! src/share/classes/com/sun/jndi/url/rmi/rmiURLContextFactory.java ! src/share/classes/com/sun/naming/internal/FactoryEnumeration.java ! src/share/classes/com/sun/naming/internal/NamedWeakReference.java ! src/share/classes/com/sun/naming/internal/ResourceManager.java ! src/share/classes/com/sun/naming/internal/VersionHelper.java ! src/share/classes/com/sun/naming/internal/VersionHelper12.java ! src/share/classes/javax/naming/CompositeName.java ! src/share/classes/javax/naming/CompoundName.java ! src/share/classes/javax/naming/InitialContext.java ! src/share/classes/javax/naming/NameImpl.java ! src/share/classes/javax/naming/Reference.java ! src/share/classes/javax/naming/directory/BasicAttribute.java ! src/share/classes/javax/naming/directory/BasicAttributes.java ! src/share/classes/javax/naming/ldap/InitialLdapContext.java ! src/share/classes/javax/naming/ldap/LdapName.java ! src/share/classes/javax/naming/ldap/Rdn.java ! src/share/classes/javax/naming/ldap/Rfc2253Parser.java ! src/share/classes/javax/naming/ldap/StartTlsRequest.java ! src/share/classes/javax/naming/spi/ContinuationContext.java ! src/share/classes/javax/naming/spi/ContinuationDirContext.java ! src/share/classes/javax/naming/spi/DirectoryManager.java ! src/share/classes/javax/naming/spi/NamingManager.java From sean.coffey at oracle.com Thu Aug 11 04:41:36 2011 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Thu, 11 Aug 2011 11:41:36 +0000 Subject: hg: jdk8/tl/jdk: 7047325: Internal API to improve management of direct buffers Message-ID: <20110811114200.656D047ACD@hg.openjdk.java.net> Changeset: ddcb874581eb Author: coffeys Date: 2011-08-11 12:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddcb874581eb 7047325: Internal API to improve management of direct buffers Reviewed-by: alanb, mduigou ! make/com/oracle/Makefile - make/com/oracle/net/Makefile ! make/common/Release.gmk ! src/share/classes/java/nio/Bits.java ! src/share/classes/java/nio/Buffer.java ! src/share/classes/java/nio/Direct-X-Buffer.java.template ! src/share/classes/sun/misc/JavaNioAccess.java ! src/share/classes/sun/nio/ch/DirectBuffer.java From nils.loodin at oracle.com Thu Aug 11 08:05:47 2011 From: nils.loodin at oracle.com (Nils Loodin) Date: Thu, 11 Aug 2011 17:05:47 +0200 Subject: code review for 7067811: Update demo/sample code to state it should not be used for production Message-ID: <4E43EFCB.70406@oracle.com> Added a comment in each demo source file stating that the code below is unfit for production. Made a separate comment blog from the copyright one to make it stand out more and be more warning-like :) http://cr.openjdk.java.net/~nloodin/7067811/webrev.00/ /Nisse From Alan.Bateman at oracle.com Thu Aug 11 08:58:58 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 11 Aug 2011 16:58:58 +0100 Subject: code review for 7067811: Update demo/sample code to state it should not be used for production In-Reply-To: <4E43EFCB.70406@oracle.com> References: <4E43EFCB.70406@oracle.com> Message-ID: <4E43FC42.1080902@oracle.com> Nils Loodin wrote: > Added a comment in each demo source file stating that the code below > is unfit for production. > Made a separate comment blog from the copyright one to make it stand > out more and be more warning-like :) > > http://cr.openjdk.java.net/~nloodin/7067811/webrev.00/ > > /Nisse > Nils - is it just demo code or do you plan to do this to sample code too (sample code is in src/share/sample/**)? One thing that isn't clear to me is why this needs to be added to every file. Seems like a warning in each demo's README should be sufficient. One specific file in the webrev that might need special treatment is hprof_b_spec.h. That header file is essentially the "spec" to the HPROF binary format (sad I know). It just seems a bit strange to add a comment saying that it "has been deliberately simplified" to this file specifically. -Alan. From jonathan.gibbons at oracle.com Thu Aug 11 13:45:18 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 11 Aug 2011 20:45:18 +0000 Subject: hg: jdk8/tl/jdk: 7077672: jdk8_tl nightly fail in step-2 build on 8/10/11 Message-ID: <20110811204536.D221847AE7@hg.openjdk.java.net> Changeset: 79bd5691d85f Author: jjg Date: 2011-08-11 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/79bd5691d85f 7077672: jdk8_tl nightly fail in step-2 build on 8/10/11 Reviewed-by: mchung, jjg Contributed-by: alexandre.boulgakov at oracle.com ! src/share/classes/com/sun/jndi/ldap/Obj.java ! src/share/classes/com/sun/jndi/toolkit/corba/CorbaUtils.java From weijun.wang at oracle.com Thu Aug 11 20:23:51 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 12 Aug 2011 03:23:51 +0000 Subject: hg: jdk8/tl/jdk: 7076415: sun/security/krb5/runNameEquals.sh failed on sles 10 Message-ID: <20110812032401.2A32D47AFA@hg.openjdk.java.net> Changeset: 4574445f35ac Author: weijun Date: 2011-08-12 11:20 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4574445f35ac 7076415: sun/security/krb5/runNameEquals.sh failed on sles 10 Reviewed-by: xuelei ! test/sun/security/krb5/Krb5NameEquals.java From weijun.wang at oracle.com Thu Aug 11 21:27:31 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 12 Aug 2011 04:27:31 +0000 Subject: hg: jdk8/tl/jdk: 7055363: jdk_security3 test target cleanup Message-ID: <20110812042741.0F97947AFD@hg.openjdk.java.net> Changeset: cb83fe13af98 Author: weijun Date: 2011-08-12 12:26 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb83fe13af98 7055363: jdk_security3 test target cleanup Reviewed-by: alanb, xuelei ! test/Makefile ! test/ProblemList.txt ! test/com/sun/security/auth/login/ConfigFile/IllegalURL.java + test/java/security/testlibrary/Providers.java ! test/javax/security/auth/login/LoginContext/ResetConfigModule.java ! test/sun/security/ec/TestEC.java ! test/sun/security/jgss/spnego/NoSpnegoAsDefMech.java ! test/sun/security/pkcs11/PKCS11Test.java ! test/sun/security/pkcs11/Secmod/AddPrivateKey.java ! test/sun/security/pkcs11/Secmod/AddTrustedCert.java ! test/sun/security/pkcs11/Secmod/Crypto.java ! test/sun/security/pkcs11/Secmod/GetPrivateKey.java ! test/sun/security/pkcs11/Secmod/JksSetPrivateKey.java ! test/sun/security/pkcs11/Secmod/TrustAnchors.java ! test/sun/security/pkcs11/SecmodTest.java ! test/sun/security/pkcs11/ec/ReadCertificates.java ! test/sun/security/pkcs11/ec/ReadPKCS12.java ! test/sun/security/pkcs11/ec/TestECDH.java ! test/sun/security/pkcs11/ec/TestECDSA.java ! test/sun/security/pkcs11/fips/CipherTest.java ! test/sun/security/pkcs11/fips/ClientJSSEServerJSSE.java ! test/sun/security/pkcs11/fips/TrustManagerTest.java ! test/sun/security/pkcs11/rsa/TestCACerts.java ! test/sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java ! test/sun/security/pkcs12/PKCS12SameKeyId.java ! test/sun/security/provider/PolicyFile/Comparator.java ! test/sun/security/ssl/com/sun/net/ssl/SSLSecurity/ProviderTest.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/AppInputStream/ReadBlocksClose.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/AppInputStream/ReadHandshake.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/AppInputStream/ReadZeroBytes.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/AppInputStream/RemoveMarkReset.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/AppOutputStream/NoExceptionOnClose.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ClientHandshaker/CipherSuiteOrder.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ClientHandshaker/RSAExport.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/GenSSLConfigs/main.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/HandshakeOutStream/NullCerts.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/ClientHelloRead.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/SSLSocketTimeoutNulls.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ProtocolVersion/HttpsProtocols.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/BadKSProvider.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/BadTSProvider.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLContextImpl/GoodProvider.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/RehandshakeFinished.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/SSLEngineDeadlock.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSessionImpl/HashCodeMissing.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/AsyncSSLSocketClose.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/ClientModeClientAuth.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/ClientTimeout.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/CloseSocketException.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/InvalidateServerSessionRenegotiate.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NewSocketMethods.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/NonAutoClose.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/ReuseAddr.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/ReverseNameLookup.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/ServerTimeout.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/SetClientMode.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/UnconnectedSocketWrongExceptions.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ServerHandshaker/AnonCipherWithWantClientAuth.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ServerHandshaker/GetPeerHost.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SocketCreation/SocketCreation.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/ClientServer.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/PKIXExtendedTM.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/SelfIssuedCert.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/SunX509ExtendedTM.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/X509ExtendedTMEnabled.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/spi/ProviderInit.java ! test/sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsClient/ProxyAuthTest.java ! test/sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsClient/ServerIdentityTest.java ! test/sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnection/CriticalSubjectAltName.java ! test/sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnection/GetResponseCode.java ! test/sun/security/ssl/javax/net/ssl/Fix5070632.java ! test/sun/security/ssl/javax/net/ssl/FixingJavadocs/ComURLNulls.java ! test/sun/security/ssl/javax/net/ssl/FixingJavadocs/ImplicitHandshake.java ! test/sun/security/ssl/javax/net/ssl/FixingJavadocs/JavaxURLNulls.java ! test/sun/security/ssl/javax/net/ssl/FixingJavadocs/SSLSessionNulls.java ! test/sun/security/ssl/javax/net/ssl/FixingJavadocs/SSLSocketInherit.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/CheckMyTrustedKeystore.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/HttpsURLConnectionLocalCertificateChain.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/JSSERenegotiate.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/KeyManagerTrustManager.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLCtxAccessToSessCtx.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/AcceptLargeFragments.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/ExtendedKeySocket.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/LargePacket.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/NoAuthClientAuth.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SessionCacheSizeTests.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SessionTimeOutTests.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/testEnabledProtocols.java ! test/sun/security/ssl/javax/net/ssl/SSLServerSocket/DefaultSSLServSocketFac.java ! test/sun/security/ssl/javax/net/ssl/TLSv11/EmptyCertificateAuthorities.java ! test/sun/security/ssl/javax/net/ssl/TLSv11/ExportableBlockCipher.java ! test/sun/security/ssl/javax/net/ssl/TLSv11/ExportableStreamCipher.java ! test/sun/security/ssl/javax/net/ssl/TLSv11/GenericBlockCipher.java ! test/sun/security/ssl/javax/net/ssl/TLSv11/GenericStreamCipher.java ! test/sun/security/ssl/sanity/pluggability/CheckSSLContextExport.java ! test/sun/security/ssl/sanity/pluggability/CheckSockFacExport1.java ! test/sun/security/ssl/sanity/pluggability/CheckSockFacExport2.java ! test/sun/security/ssl/sun/net/www/http/ChunkedOutputStream/Test.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/B6216082.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHandlerTest.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/DNSIdentities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/HttpsCreateSockTest.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/HttpsPost.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/HttpsProxyStackOverflow.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/HttpsSocketFacTest.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPAddressDNSIdentities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPAddressIPIdentities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/IPIdentities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/Identities.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/PostThruProxy.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/ReadTimeout.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/Redirect.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/RetryHttps.java ! test/sun/security/ssl/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java ! test/sun/security/ssl/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java ! test/sun/security/ssl/sun/net/www/protocol/https/NewImpl/JavaxHTTPSConnection.java ! test/sun/security/ssl/sun/net/www/protocol/https/NewImpl/JavaxHostnameVerifier.java ! test/sun/security/ssl/templates/SSLEngineTemplate.java ! test/sun/security/ssl/templates/SSLSocketTemplate.java ! test/sun/security/tools/keytool/StartDateTest.java ! test/sun/security/x509/AlgorithmId/ExtensibleAlgorithmId.java From nils.loodin at oracle.com Fri Aug 12 00:21:57 2011 From: nils.loodin at oracle.com (Nils Loodin) Date: Fri, 12 Aug 2011 09:21:57 +0200 Subject: code review for 7067811: Update demo/sample code to state it should not be used for production In-Reply-To: <4E43FC42.1080902@oracle.com> References: <4E43EFCB.70406@oracle.com> <4E43FC42.1080902@oracle.com> Message-ID: <4E44D495.20904@oracle.com> Ah, you're right, i forgot the samples directory. And as for the text being in each source file, that's how I undestood the requirement from Aurelio after some email conversation. Looping him in and he might shed some light on it. As I understood On 08/11/2011 05:58 PM, Alan Bateman wrote: > Nils Loodin wrote: >> Added a comment in each demo source file stating that the code below >> is unfit for production. >> Made a separate comment blog from the copyright one to make it stand >> out more and be more warning-like :) >> >> >> >> /Nisse >> > Nils - is it just demo code or do you plan to do this to sample code > too (sample code is in src/share/sample/**)? One thing that isn't > clear to me is why this needs to be added to every file. Seems like a > warning in each demo's README should be sufficient. > > One specific file in the webrev that might need special treatment is > hprof_b_spec.h. That header file is essentially the "spec" to the > HPROF binary format (sad I know). It just seems a bit strange to add a > comment saying that it "has been deliberately simplified" to this file > specifically. > > -Alan. From spoole at linux.vnet.ibm.com Fri Aug 12 02:11:31 2011 From: spoole at linux.vnet.ibm.com (Steve Poole) Date: Fri, 12 Aug 2011 10:11:31 +0100 Subject: code review for 7067811: Update demo/sample code to state it should not be used for production In-Reply-To: <4E44D495.20904@oracle.com> References: <4E43EFCB.70406@oracle.com> <4E43FC42.1080902@oracle.com> <4E44D495.20904@oracle.com> Message-ID: <1313140291.3049.2.camel@jazzette> On Fri, 2011-08-12 at 09:21 +0200, Nils Loodin wrote: > Ah, you're right, i forgot the samples directory. And as for the text > being in each source file, that's how I undestood the requirement from > Aurelio after some email conversation. Looping him in and he might shed > some light on it. I'm sorry to moan about this - but please post the details behind the requirement. Unilateral and undocumented changes are not useful to people outside Oracle. Discussions should happen on the mailing list not off it. > > As I understood > > On 08/11/2011 05:58 PM, Alan Bateman wrote: > > Nils Loodin wrote: > >> Added a comment in each demo source file stating that the code below > >> is unfit for production. > >> Made a separate comment blog from the copyright one to make it stand > >> out more and be more warning-like :) > >> > >> > >> > >> /Nisse > >> > > Nils - is it just demo code or do you plan to do this to sample code > > too (sample code is in src/share/sample/**)? One thing that isn't > > clear to me is why this needs to be added to every file. Seems like a > > warning in each demo's README should be sufficient. > > > > One specific file in the webrev that might need special treatment is > > hprof_b_spec.h. That header file is essentially the "spec" to the > > HPROF binary format (sad I know). It just seems a bit strange to add a > > comment saying that it "has been deliberately simplified" to this file > > specifically. > > > > -Alan. > From weijun.wang at oracle.com Fri Aug 12 06:05:21 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 12 Aug 2011 13:05:21 +0000 Subject: hg: jdk8/tl/jdk: 7078355: sun/net/www/protocol/file/DirPermissionDenied.sh leaves garbage on some linux systems Message-ID: <20110812130539.86C6547B18@hg.openjdk.java.net> Changeset: e533c13df9ad Author: weijun Date: 2011-08-12 21:04 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e533c13df9ad 7078355: sun/net/www/protocol/file/DirPermissionDenied.sh leaves garbage on some linux systems Reviewed-by: chegar ! test/sun/net/www/protocol/file/DirPermissionDenied.sh From daniel.daugherty at oracle.com Fri Aug 12 07:40:15 2011 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Fri, 12 Aug 2011 08:40:15 -0600 Subject: code review for 7067811: Update demo/sample code to state it should not be used for production In-Reply-To: <4E43EFCB.70406@oracle.com> References: <4E43EFCB.70406@oracle.com> Message-ID: <4E453B4F.3000707@oracle.com> On 8/11/11 9:05 AM, Nils Loodin wrote: > Added a comment in each demo source file stating that the code below > is unfit for production. > Made a separate comment blog from the copyright one to make it stand > out more and be more warning-like :) > > http://cr.openjdk.java.net/~nloodin/7067811/webrev.00/ > > /Nisse While the majority of these demo files are in the Serviceability area, I also see changes in applet, java2d and jfc areas. I don't know the right alias(es) to use, but those folks need to be advised of this change also. This change reads like legal/lawyer wording. I'm guessing this is yet another Oracle (legal) requirement... Dan From suraj.puvvada at gmail.com Fri Aug 12 12:08:26 2011 From: suraj.puvvada at gmail.com (suraj puvvada) Date: Fri, 12 Aug 2011 12:08:26 -0700 Subject: RedefineClasses() API Message-ID: "I use RedefineClasses() API extensively. Wanted to know what is the impact redefining a class has on Perm Gen ? Are the older versions of a redefined class retained in memory forever ?" If there is a more appropriate forum to post appreciate if you can let me know. Thanks Suraj -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20110812/e55ac8e5/attachment.html From daniel.daugherty at oracle.com Fri Aug 12 12:23:55 2011 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Fri, 12 Aug 2011 13:23:55 -0600 Subject: RedefineClasses() API In-Reply-To: References: Message-ID: <4E457DCB.1070001@oracle.com> On 8/12/11 1:08 PM, suraj puvvada wrote: > "I use RedefineClasses() API extensively. Wanted to know what is the > impact redefining a class has on Perm Gen ? Are the older versions of > a redefined class retained in memory forever ?" > > If there is a more appropriate forum to post appreciate if you can let > me know. > > Thanks > Suraj You've found the right forum. Short answer: older versions of redefined methods are only kept around as long as a thread is executing that method. Longer answer: When RedefineClasses() replaces a target class, it keeps weak references to various parts (methods and the constant pool come to mind) of the original class for internal book keeping reasons. As threads finish executing the obsolete or old methods, they become GC'able. That doesn't mean they are GC'ed right away, but they will be eventually. Dan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20110812/01bdb097/attachment.html From mandy.chung at oracle.com Fri Aug 12 12:57:00 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Fri, 12 Aug 2011 12:57:00 -0700 Subject: code review for 7067811: Update demo/sample code to state it should not be used for production In-Reply-To: <4E43FC42.1080902@oracle.com> References: <4E43EFCB.70406@oracle.com> <4E43FC42.1080902@oracle.com> Message-ID: <4E45858C.7060400@oracle.com> On 08/11/11 08:58, Alan Bateman wrote: > Nils Loodin wrote: >> Added a comment in each demo source file stating that the code below >> is unfit for production. >> Made a separate comment blog from the copyright one to make it stand >> out more and be more warning-like :) >> >> http://cr.openjdk.java.net/~nloodin/7067811/webrev.00/ >> >> /Nisse >> > Nils - is it just demo code or do you plan to do this to sample code > too (sample code is in src/share/sample/**)? One thing that isn't > clear to me is why this needs to be added to every file. Seems like a > warning in each demo's README should be sufficient. > I agree with Alan that README in each demo would be a proper and adequate place to add this warning. In addition, there is a typo "suich" in the third line of the warning: > * required for a production-quality application, suich as security checks, Is this intentional? Or a typo should be fixed? Mandy From joe.darcy at oracle.com Fri Aug 12 13:37:51 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Fri, 12 Aug 2011 20:37:51 +0000 Subject: hg: jdk8/tl/jdk: 4900206: Include worst-case rounding tests for Math library functions Message-ID: <20110812203812.09B1647B2A@hg.openjdk.java.net> Changeset: 8f962aca221e Author: darcy Date: 2011-08-12 13:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8f962aca221e 4900206: Include worst-case rounding tests for Math library functions Reviewed-by: alanb ! test/java/lang/Math/Tests.java + test/java/lang/Math/WorstCaseTests.java From stuart.marks at oracle.com Fri Aug 12 14:55:03 2011 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 12 Aug 2011 21:55:03 +0000 Subject: hg: jdk8/tl/jdk: 7076526: add test MemoryMXBean/CollectionUsageThreshold to the problem list Message-ID: <20110812215514.64F1347B2F@hg.openjdk.java.net> Changeset: 3f66f9ca1ba5 Author: smarks Date: 2011-08-12 14:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f66f9ca1ba5 7076526: add test MemoryMXBean/CollectionUsageThreshold to the problem list Reviewed-by: weijun, alanb ! test/ProblemList.txt From weijun.wang at oracle.com Sun Aug 14 19:43:29 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 15 Aug 2011 02:43:29 +0000 Subject: hg: jdk8/tl/jdk: 7078816: /test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failure Message-ID: <20110815024347.3805347BA1@hg.openjdk.java.net> Changeset: b759d1a55cd4 Author: weijun Date: 2011-08-15 10:42 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b759d1a55cd4 7078816: /test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh failure Reviewed-by: alanb ! test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh From weijun.wang at oracle.com Sun Aug 14 20:43:39 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 15 Aug 2011 03:43:39 +0000 Subject: hg: jdk8/tl/jdk: 7079144: concise_jarsigner.sh test often fails on solaris Message-ID: <20110815034349.2E59D47BA4@hg.openjdk.java.net> Changeset: 4af32446555d Author: weijun Date: 2011-08-15 11:43 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4af32446555d 7079144: concise_jarsigner.sh test often fails on solaris Reviewed-by: xuelei ! test/sun/security/tools/jarsigner/concise_jarsigner.sh From xuelei.fan at oracle.com Mon Aug 15 00:31:16 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 15 Aug 2011 07:31:16 +0000 Subject: hg: jdk8/tl/jdk: 7063647: To use synchronized map in key manager Message-ID: <20110815073126.0CF0E47BAD@hg.openjdk.java.net> Changeset: b07cf6cbb62a Author: xuelei Date: 2011-08-15 00:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b07cf6cbb62a 7063647: To use synchronized map in key manager Reviewed-by: wetmore, weijun ! src/share/classes/sun/security/ssl/SunX509KeyManagerImpl.java From nils.loodin at oracle.com Mon Aug 15 01:15:52 2011 From: nils.loodin at oracle.com (Nils Loodin) Date: Mon, 15 Aug 2011 10:15:52 +0200 Subject: code review for 7067811: Update demo/sample code to state it should not be used for production In-Reply-To: <4E45858C.7060400@oracle.com> References: <4E43EFCB.70406@oracle.com> <4E43FC42.1080902@oracle.com> <4E45858C.7060400@oracle.com> Message-ID: <0810FDCE-255B-4962-953F-1F49DA909BF3@oracle.com> >> Nils - is it just demo code or do you plan to do this to sample code too (sample code is in src/share/sample/**)? One thing that isn't clear to me is why this needs to be added to every file. Seems like a warning in each demo's README should be sufficient. >> > Also samples. > I agree with Alan that README in each demo would be a proper and adequate place to add this warning. In addition, there is a typo "suich" in the third line of the warning: > >> * required for a production-quality application, suich as security checks, > That was not intentional. > Is this intentional? Or a typo should be fixed? > > Mandy I'm holding off sending to the other mailing lists until I can get the requirements that the text be included in each source file officially by the one who set the demand. As background, yes this is a legal thing. Oracle has strict requirements on in which form Demos and samples can be included in packaging.. /Nisse From joe.darcy at oracle.com Mon Aug 15 12:57:23 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 15 Aug 2011 19:57:23 +0000 Subject: hg: jdk8/tl/jdk: 4850225: Integer.getInteger() : Bad reference to getProperty? Message-ID: <20110815195733.4E65947BCD@hg.openjdk.java.net> Changeset: 6e9ed747d0ca Author: darcy Date: 2011-08-15 12:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6e9ed747d0ca 4850225: Integer.getInteger() : Bad reference to getProperty? Reviewed-by: lancea ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java From jonathan.gibbons at oracle.com Mon Aug 15 14:31:35 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Mon, 15 Aug 2011 21:31:35 +0000 Subject: hg: jdk8/tl/jdk: 7064075: Security libraries don't build with javac -Xlint:all, -deprecation -Werror Message-ID: <20110815213145.F2CA047BD5@hg.openjdk.java.net> Changeset: afb6f2370cd3 Author: jjg Date: 2011-08-15 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/afb6f2370cd3 7064075: Security libraries don't build with javac -Xlint:all,-deprecation -Werror Reviewed-by: xuelei, mullan Contributed-by: alexandre.boulgakov at oracle.com ! make/com/sun/crypto/provider/Makefile ! make/com/sun/security/Makefile ! make/java/security/Makefile ! make/javax/crypto/Makefile ! make/sun/security/Makefile ! make/sun/security/ec/Makefile ! make/sun/security/other/Makefile ! make/sun/security/pkcs11/Makefile ! src/share/classes/com/sun/crypto/provider/AESCrypt.java ! src/share/classes/com/sun/crypto/provider/AESParameters.java ! src/share/classes/com/sun/crypto/provider/BlockCipherParamsCore.java ! src/share/classes/com/sun/crypto/provider/BlowfishParameters.java ! src/share/classes/com/sun/crypto/provider/CipherBlockChaining.java ! src/share/classes/com/sun/crypto/provider/CipherCore.java ! src/share/classes/com/sun/crypto/provider/DESCrypt.java ! src/share/classes/com/sun/crypto/provider/DESKey.java ! src/share/classes/com/sun/crypto/provider/DESKeyFactory.java ! src/share/classes/com/sun/crypto/provider/DESParameters.java ! src/share/classes/com/sun/crypto/provider/DESedeKey.java ! src/share/classes/com/sun/crypto/provider/DESedeKeyFactory.java ! src/share/classes/com/sun/crypto/provider/DESedeParameters.java ! src/share/classes/com/sun/crypto/provider/DESedeWrapCipher.java ! src/share/classes/com/sun/crypto/provider/DHKeyFactory.java ! src/share/classes/com/sun/crypto/provider/DHParameterGenerator.java ! src/share/classes/com/sun/crypto/provider/DHParameters.java ! src/share/classes/com/sun/crypto/provider/DHPrivateKey.java ! src/share/classes/com/sun/crypto/provider/DHPublicKey.java ! src/share/classes/com/sun/crypto/provider/EncryptedPrivateKeyInfo.java ! src/share/classes/com/sun/crypto/provider/HmacCore.java ! src/share/classes/com/sun/crypto/provider/JceKeyStore.java ! src/share/classes/com/sun/crypto/provider/KeyProtector.java ! src/share/classes/com/sun/crypto/provider/OAEPParameters.java ! src/share/classes/com/sun/crypto/provider/PBECipherCore.java ! src/share/classes/com/sun/crypto/provider/PBEKey.java ! src/share/classes/com/sun/crypto/provider/PBEKeyFactory.java ! src/share/classes/com/sun/crypto/provider/PBEParameters.java ! src/share/classes/com/sun/crypto/provider/PBKDF2HmacSHA1Factory.java ! src/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java ! src/share/classes/com/sun/crypto/provider/PCBC.java ! src/share/classes/com/sun/crypto/provider/RC2Cipher.java ! src/share/classes/com/sun/crypto/provider/RC2Parameters.java ! src/share/classes/com/sun/crypto/provider/RSACipher.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java ! src/share/classes/com/sun/crypto/provider/TlsKeyMaterialGenerator.java ! src/share/classes/com/sun/crypto/provider/TlsMasterSecretGenerator.java ! src/share/classes/com/sun/security/auth/PolicyFile.java ! src/share/classes/com/sun/security/auth/SubjectCodeSource.java ! src/share/classes/com/sun/security/auth/module/JndiLoginModule.java ! src/share/classes/com/sun/security/auth/module/KeyStoreLoginModule.java ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java ! src/share/classes/com/sun/security/auth/module/LdapLoginModule.java ! src/share/classes/com/sun/security/jgss/InquireSecContextPermission.java ! src/share/classes/com/sun/security/ntlm/NTLMException.java ! src/share/classes/com/sun/security/sasl/CramMD5Server.java ! src/share/classes/com/sun/security/sasl/digest/DigestMD5Base.java ! src/share/classes/com/sun/security/sasl/digest/DigestMD5Client.java ! src/share/classes/com/sun/security/sasl/digest/DigestMD5Server.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Base.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Client.java ! src/share/classes/com/sun/security/sasl/gsskerb/GssKrb5Server.java ! src/share/classes/com/sun/security/sasl/ntlm/NTLMClient.java ! src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java ! src/share/classes/com/sun/security/sasl/util/AbstractSaslImpl.java ! src/share/classes/com/sun/security/sasl/util/PolicyUtils.java ! src/share/classes/java/security/AccessControlContext.java ! src/share/classes/java/security/AccessController.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/security/Permissions.java ! src/share/classes/java/security/Policy.java ! src/share/classes/java/security/ProtectionDomain.java ! src/share/classes/java/security/Provider.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/UnresolvedPermission.java ! src/share/classes/java/security/UnresolvedPermissionCollection.java ! src/share/classes/java/security/cert/CertificateRevokedException.java ! src/share/classes/java/security/cert/X509CRLSelector.java ! src/share/classes/java/security/cert/X509CertSelector.java ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/CryptoAllPermission.java ! src/share/classes/javax/crypto/CryptoPermission.java ! src/share/classes/javax/crypto/CryptoPermissions.java ! src/share/classes/javax/crypto/CryptoPolicyParser.java ! src/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java ! src/share/classes/javax/crypto/JarVerifier.java ! src/share/classes/javax/crypto/JceSecurity.java ! src/share/classes/javax/crypto/JceSecurityManager.java ! src/share/classes/javax/crypto/KeyAgreement.java ! src/share/classes/javax/crypto/KeyGenerator.java ! src/share/classes/javax/crypto/Mac.java ! src/share/classes/javax/crypto/SealedObject.java ! src/share/classes/javax/crypto/SecretKeyFactory.java ! src/share/classes/javax/crypto/SecretKeyFactorySpi.java ! src/share/classes/javax/crypto/spec/DESKeySpec.java ! src/share/classes/javax/crypto/spec/DESedeKeySpec.java ! src/share/classes/javax/crypto/spec/IvParameterSpec.java ! src/share/classes/javax/crypto/spec/PBEKeySpec.java ! src/share/classes/javax/crypto/spec/PBEParameterSpec.java ! src/share/classes/javax/crypto/spec/PSource.java ! src/share/classes/javax/crypto/spec/RC2ParameterSpec.java ! src/share/classes/javax/crypto/spec/RC5ParameterSpec.java ! src/share/classes/javax/crypto/spec/SecretKeySpec.java ! src/share/classes/sun/security/acl/AclEntryImpl.java ! src/share/classes/sun/security/action/PutAllAction.java ! src/share/classes/sun/security/ec/ECDSASignature.java ! src/share/classes/sun/security/ec/ECKeyFactory.java ! src/share/classes/sun/security/ec/ECParameters.java ! src/share/classes/sun/security/jca/GetInstance.java ! src/share/classes/sun/security/jca/ProviderList.java ! src/share/classes/sun/security/jca/Providers.java ! src/share/classes/sun/security/jgss/GSSUtil.java ! src/share/classes/sun/security/jgss/krb5/CipherHelper.java ! src/share/classes/sun/security/jgss/krb5/Krb5Context.java ! src/share/classes/sun/security/jgss/krb5/Krb5Util.java ! src/share/classes/sun/security/jgss/krb5/MessageToken.java ! src/share/classes/sun/security/jgss/krb5/SubjectComber.java ! src/share/classes/sun/security/jgss/spnego/SpNegoContext.java ! src/share/classes/sun/security/jgss/wrapper/NativeGSSFactory.java ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java ! src/share/classes/sun/security/krb5/Checksum.java ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/KrbServiceLocator.java ! src/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java ! src/share/classes/sun/security/pkcs/ContentInfo.java ! src/share/classes/sun/security/pkcs/PKCS10.java ! src/share/classes/sun/security/pkcs/PKCS7.java ! src/share/classes/sun/security/pkcs/PKCS8Key.java ! src/share/classes/sun/security/pkcs/PKCS9Attribute.java ! src/share/classes/sun/security/pkcs/SignerInfo.java ! src/share/classes/sun/security/pkcs11/Config.java ! src/share/classes/sun/security/pkcs11/P11Cipher.java ! src/share/classes/sun/security/pkcs11/P11DHKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11DSAKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11Key.java ! src/share/classes/sun/security/pkcs11/P11KeyAgreement.java ! src/share/classes/sun/security/pkcs11/P11KeyFactory.java ! src/share/classes/sun/security/pkcs11/P11KeyStore.java ! src/share/classes/sun/security/pkcs11/P11RSAKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11Signature.java ! src/share/classes/sun/security/pkcs11/P11TlsPrfGenerator.java ! src/share/classes/sun/security/pkcs11/P11Util.java ! src/share/classes/sun/security/pkcs11/Secmod.java ! src/share/classes/sun/security/pkcs11/wrapper/Functions.java ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11Exception.java ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11RuntimeException.java ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! src/share/classes/sun/security/provider/DSAKeyFactory.java ! src/share/classes/sun/security/provider/DSAParameters.java ! src/share/classes/sun/security/provider/MD4.java ! src/share/classes/sun/security/provider/PolicyFile.java ! src/share/classes/sun/security/provider/certpath/AdaptableX509CertSelector.java ! src/share/classes/sun/security/provider/certpath/Builder.java ! src/share/classes/sun/security/provider/certpath/CrlRevocationChecker.java ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ForwardState.java ! src/share/classes/sun/security/provider/certpath/IndexedCollectionCertStore.java ! src/share/classes/sun/security/provider/certpath/OCSP.java ! src/share/classes/sun/security/provider/certpath/OCSPChecker.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/PolicyChecker.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java ! src/share/classes/sun/security/provider/certpath/Vertex.java ! src/share/classes/sun/security/provider/certpath/X509CertPath.java ! src/share/classes/sun/security/rsa/RSAKeyFactory.java ! src/share/classes/sun/security/rsa/RSASignature.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/JsseJce.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/share/classes/sun/security/ssl/X509KeyManagerImpl.java ! src/share/classes/sun/security/timestamp/HttpTimestamper.java ! src/share/classes/sun/security/timestamp/TSResponse.java ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/tools/TimestampedSigner.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java ! src/share/classes/sun/security/util/Cache.java ! src/share/classes/sun/security/util/ManifestDigester.java ! src/share/classes/sun/security/util/Password.java ! src/share/classes/sun/security/util/SignatureFileVerifier.java ! src/share/classes/sun/security/validator/SimpleValidator.java ! src/share/classes/sun/security/x509/AVA.java ! src/share/classes/sun/security/x509/AccessDescription.java ! src/share/classes/sun/security/x509/AlgorithmId.java ! src/share/classes/sun/security/x509/AuthorityInfoAccessExtension.java ! src/share/classes/sun/security/x509/CRLDistributionPointsExtension.java ! src/share/classes/sun/security/x509/CRLExtensions.java ! src/share/classes/sun/security/x509/CRLNumberExtension.java ! src/share/classes/sun/security/x509/CRLReasonCodeExtension.java ! src/share/classes/sun/security/x509/CertAndKeyGen.java ! src/share/classes/sun/security/x509/CertificateAlgorithmId.java ! src/share/classes/sun/security/x509/CertificateExtensions.java ! src/share/classes/sun/security/x509/CertificateIssuerExtension.java ! src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java ! src/share/classes/sun/security/x509/CertificatePoliciesExtension.java ! src/share/classes/sun/security/x509/CertificatePolicyId.java ! src/share/classes/sun/security/x509/CertificateSerialNumber.java ! src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java ! src/share/classes/sun/security/x509/CertificateValidity.java ! src/share/classes/sun/security/x509/CertificateVersion.java ! src/share/classes/sun/security/x509/CertificateX509Key.java ! src/share/classes/sun/security/x509/ExtendedKeyUsageExtension.java ! src/share/classes/sun/security/x509/Extension.java ! src/share/classes/sun/security/x509/InhibitAnyPolicyExtension.java ! src/share/classes/sun/security/x509/InvalidityDateExtension.java ! src/share/classes/sun/security/x509/IssuerAlternativeNameExtension.java ! src/share/classes/sun/security/x509/KeyUsageExtension.java ! src/share/classes/sun/security/x509/NameConstraintsExtension.java ! src/share/classes/sun/security/x509/NetscapeCertTypeExtension.java ! src/share/classes/sun/security/x509/OIDMap.java ! src/share/classes/sun/security/x509/OIDName.java ! src/share/classes/sun/security/x509/OtherName.java ! src/share/classes/sun/security/x509/PolicyConstraintsExtension.java ! src/share/classes/sun/security/x509/PolicyInformation.java ! src/share/classes/sun/security/x509/PolicyMappingsExtension.java ! src/share/classes/sun/security/x509/PrivateKeyUsageExtension.java ! src/share/classes/sun/security/x509/RDN.java ! src/share/classes/sun/security/x509/SubjectAlternativeNameExtension.java ! src/share/classes/sun/security/x509/SubjectInfoAccessExtension.java ! src/share/classes/sun/security/x509/SubjectKeyIdentifierExtension.java ! src/share/classes/sun/security/x509/X500Name.java ! src/share/classes/sun/security/x509/X509CRLEntryImpl.java ! src/share/classes/sun/security/x509/X509CRLImpl.java ! src/share/classes/sun/security/x509/X509CertImpl.java ! src/share/classes/sun/security/x509/X509CertInfo.java ! src/share/classes/sun/security/x509/X509Key.java ! src/windows/classes/sun/security/mscapi/KeyStore.java ! src/windows/classes/sun/security/mscapi/PRNG.java ! src/windows/classes/sun/security/mscapi/RSAPrivateKey.java ! src/windows/classes/sun/security/mscapi/RSAPublicKey.java ! src/windows/classes/sun/security/mscapi/RSASignature.java ! src/windows/classes/sun/security/mscapi/SunMSCAPI.java From weijun.wang at oracle.com Mon Aug 15 17:53:42 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Tue, 16 Aug 2011 00:53:42 +0000 Subject: hg: jdk8/tl/jdk: 7079204: add several security and networking tests to problems list Message-ID: <20110816005353.2695847BDE@hg.openjdk.java.net> Changeset: dd218ad64d5c Author: weijun Date: 2011-08-16 08:53 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd218ad64d5c 7079204: add several security and networking tests to problems list Reviewed-by: smarks ! test/ProblemList.txt From zhengyu.gu at oracle.com Tue Aug 16 10:43:27 2011 From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com) Date: Tue, 16 Aug 2011 17:43:27 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 3 new changesets Message-ID: <20110816174337.B7ADB47C0C@hg.openjdk.java.net> Changeset: b1cbb0907b36 Author: zgu Date: 2011-04-15 09:34 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b1cbb0907b36 7016797: Hotspot: securely/restrictive load dlls and new API for loading system dlls Summary: Created Windows Dll wrapped to handle jdk6 and jdk7 platform requirements, also provided more restictive Dll search orders for Windows system Dlls. Reviewed-by: acorn, dcubed, ohair, alanb ! make/windows/makefiles/compile.make ! src/os/windows/vm/decoder_windows.cpp ! src/os/windows/vm/jvm_windows.h ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp Changeset: 279ef1916773 Author: zgu Date: 2011-07-12 21:13 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/279ef1916773 7065535: Mistyped function name that disabled UseLargePages on Windows Summary: Missing suffix "A" of Windows API LookupPrivilegeValue failed finding function pointer, caused VM to disable UseLargePages option Reviewed-by: coleenp, phh ! src/os/windows/vm/os_windows.cpp Changeset: a68e11dceb83 Author: zgu Date: 2011-08-16 09:18 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a68e11dceb83 Merge From naoto.sato at oracle.com Wed Aug 17 11:10:16 2011 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Wed, 17 Aug 2011 18:10:16 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20110817181050.4D8BB47C69@hg.openjdk.java.net> Changeset: c3a8d5feee94 Author: naoto Date: 2011-08-17 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c3a8d5feee94 7073906: Locale.getDefault() returns wrong Locale for Java SE 7 Reviewed-by: okutsu ! src/windows/native/java/lang/java_props_md.c Changeset: f59c83f515e6 Author: naoto Date: 2011-08-17 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f59c83f515e6 7079486: Locale.getDisplayScript() (no args) does not honor default DISPLAY locale Reviewed-by: okutsu ! src/share/classes/java/util/Locale.java ! test/java/util/Locale/LocaleCategory.java ! test/java/util/Locale/LocaleCategory.sh From jonathan.gibbons at oracle.com Wed Aug 17 12:11:07 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 17 Aug 2011 19:11:07 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20110817191127.0FDE947C6C@hg.openjdk.java.net> Changeset: f4fe826b8034 Author: jjg Date: 2011-08-17 05:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4fe826b8034 7079606: tl nightly build failure due to incomplete generification Reviewed-by: jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/com/sun/security/Makefile Changeset: 259b2536d11c Author: jjg Date: 2011-08-17 12:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/259b2536d11c Merge From jonathan.gibbons at oracle.com Wed Aug 17 12:12:52 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 17 Aug 2011 19:12:52 +0000 Subject: hg: jdk8/tl/jdk: 7077389: Reflection classes do not build with javac -Xlint:all -Werror Message-ID: <20110817191302.1AC1247C6D@hg.openjdk.java.net> Changeset: e59aad6ed600 Author: jjg Date: 2011-08-15 17:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e59aad6ed600 7077389: Reflection classes do not build with javac -Xlint:all -Werror Reviewed-by: darcy Contributed-by: alexandre.boulgakov at oracle.com ! make/java/java/Makefile ! src/share/classes/java/lang/reflect/Array.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Method.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/sun/reflect/AccessorGenerator.java ! src/share/classes/sun/reflect/BootstrapConstructorAccessorImpl.java ! src/share/classes/sun/reflect/ClassDefiner.java ! src/share/classes/sun/reflect/ConstantPool.java ! src/share/classes/sun/reflect/Label.java ! src/share/classes/sun/reflect/MethodAccessorGenerator.java ! src/share/classes/sun/reflect/NativeConstructorAccessorImpl.java ! src/share/classes/sun/reflect/Reflection.java ! src/share/classes/sun/reflect/ReflectionFactory.java ! src/share/classes/sun/reflect/UnsafeFieldAccessorFactory.java ! src/share/classes/sun/reflect/UnsafeFieldAccessorImpl.java ! src/share/classes/sun/reflect/annotation/AnnotationParser.java ! src/share/classes/sun/reflect/annotation/EnumConstantNotPresentExceptionProxy.java ! src/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java ! src/share/classes/sun/reflect/generics/repository/GenericDeclRepository.java ! src/share/classes/sun/reflect/generics/scope/AbstractScope.java ! src/share/classes/sun/reflect/generics/scope/ConstructorScope.java ! src/share/classes/sun/reflect/generics/tree/ClassSignature.java ! src/share/classes/sun/reflect/generics/tree/MethodTypeSignature.java From xueming.shen at oracle.com Wed Aug 17 14:05:55 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 17 Aug 2011 21:05:55 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20110817210614.B652147C73@hg.openjdk.java.net> Changeset: 2961329a6774 Author: sherman Date: 2011-08-17 14:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2961329a6774 6237353: Remove sun.io package from j2se binary Summary: Removed sun.io package and related test cases Reviewed-by: alanb ! make/java/sun_nio/FILES_java.gmk ! make/java/sun_nio/Makefile ! make/sun/nio/cs/FILES_java.gmk ! make/tools/CharsetMapping/SingleByte-X.java.template - src/share/classes/sun/io/ByteToCharASCII.java - src/share/classes/sun/io/ByteToCharBig5.java - src/share/classes/sun/io/ByteToCharBig5_HKSCS.java - src/share/classes/sun/io/ByteToCharBig5_Solaris.java - src/share/classes/sun/io/ByteToCharConverter.java - src/share/classes/sun/io/ByteToCharCp037.java - src/share/classes/sun/io/ByteToCharCp1006.java - src/share/classes/sun/io/ByteToCharCp1025.java - src/share/classes/sun/io/ByteToCharCp1026.java - src/share/classes/sun/io/ByteToCharCp1046.java - src/share/classes/sun/io/ByteToCharCp1047.java - src/share/classes/sun/io/ByteToCharCp1097.java - src/share/classes/sun/io/ByteToCharCp1098.java - src/share/classes/sun/io/ByteToCharCp1112.java - src/share/classes/sun/io/ByteToCharCp1122.java - src/share/classes/sun/io/ByteToCharCp1123.java - src/share/classes/sun/io/ByteToCharCp1124.java - src/share/classes/sun/io/ByteToCharCp1140.java - src/share/classes/sun/io/ByteToCharCp1141.java - src/share/classes/sun/io/ByteToCharCp1142.java - src/share/classes/sun/io/ByteToCharCp1143.java - src/share/classes/sun/io/ByteToCharCp1144.java - src/share/classes/sun/io/ByteToCharCp1145.java - src/share/classes/sun/io/ByteToCharCp1146.java - src/share/classes/sun/io/ByteToCharCp1147.java - src/share/classes/sun/io/ByteToCharCp1148.java - src/share/classes/sun/io/ByteToCharCp1149.java - src/share/classes/sun/io/ByteToCharCp1250.java - src/share/classes/sun/io/ByteToCharCp1251.java - src/share/classes/sun/io/ByteToCharCp1252.java - src/share/classes/sun/io/ByteToCharCp1253.java - src/share/classes/sun/io/ByteToCharCp1254.java - src/share/classes/sun/io/ByteToCharCp1255.java - src/share/classes/sun/io/ByteToCharCp1256.java - src/share/classes/sun/io/ByteToCharCp1257.java - src/share/classes/sun/io/ByteToCharCp1258.java - src/share/classes/sun/io/ByteToCharCp1381.java - src/share/classes/sun/io/ByteToCharCp1383.java - src/share/classes/sun/io/ByteToCharCp273.java - src/share/classes/sun/io/ByteToCharCp277.java - src/share/classes/sun/io/ByteToCharCp278.java - src/share/classes/sun/io/ByteToCharCp280.java - src/share/classes/sun/io/ByteToCharCp284.java - src/share/classes/sun/io/ByteToCharCp285.java - src/share/classes/sun/io/ByteToCharCp297.java - src/share/classes/sun/io/ByteToCharCp33722.java - src/share/classes/sun/io/ByteToCharCp420.java - src/share/classes/sun/io/ByteToCharCp424.java - src/share/classes/sun/io/ByteToCharCp437.java - src/share/classes/sun/io/ByteToCharCp500.java - src/share/classes/sun/io/ByteToCharCp737.java - src/share/classes/sun/io/ByteToCharCp775.java - src/share/classes/sun/io/ByteToCharCp833.java - src/share/classes/sun/io/ByteToCharCp834.java - src/share/classes/sun/io/ByteToCharCp838.java - src/share/classes/sun/io/ByteToCharCp850.java - src/share/classes/sun/io/ByteToCharCp852.java - src/share/classes/sun/io/ByteToCharCp855.java - src/share/classes/sun/io/ByteToCharCp856.java - src/share/classes/sun/io/ByteToCharCp857.java - src/share/classes/sun/io/ByteToCharCp858.java - src/share/classes/sun/io/ByteToCharCp860.java - src/share/classes/sun/io/ByteToCharCp861.java - src/share/classes/sun/io/ByteToCharCp862.java - src/share/classes/sun/io/ByteToCharCp863.java - src/share/classes/sun/io/ByteToCharCp864.java - src/share/classes/sun/io/ByteToCharCp865.java - src/share/classes/sun/io/ByteToCharCp866.java - src/share/classes/sun/io/ByteToCharCp868.java - src/share/classes/sun/io/ByteToCharCp869.java - src/share/classes/sun/io/ByteToCharCp870.java - src/share/classes/sun/io/ByteToCharCp871.java - src/share/classes/sun/io/ByteToCharCp874.java - src/share/classes/sun/io/ByteToCharCp875.java - src/share/classes/sun/io/ByteToCharCp918.java - src/share/classes/sun/io/ByteToCharCp921.java - src/share/classes/sun/io/ByteToCharCp922.java - src/share/classes/sun/io/ByteToCharCp930.java - src/share/classes/sun/io/ByteToCharCp933.java - src/share/classes/sun/io/ByteToCharCp935.java - src/share/classes/sun/io/ByteToCharCp937.java - src/share/classes/sun/io/ByteToCharCp939.java - src/share/classes/sun/io/ByteToCharCp942.java - src/share/classes/sun/io/ByteToCharCp942C.java - src/share/classes/sun/io/ByteToCharCp943.java - src/share/classes/sun/io/ByteToCharCp943C.java - src/share/classes/sun/io/ByteToCharCp948.java - src/share/classes/sun/io/ByteToCharCp949.java - src/share/classes/sun/io/ByteToCharCp949C.java - src/share/classes/sun/io/ByteToCharCp950.java - src/share/classes/sun/io/ByteToCharCp964.java - src/share/classes/sun/io/ByteToCharCp970.java - src/share/classes/sun/io/ByteToCharDBCS_ASCII.java - src/share/classes/sun/io/ByteToCharDBCS_EBCDIC.java - src/share/classes/sun/io/ByteToCharDoubleByte.java - src/share/classes/sun/io/ByteToCharEUC.java - src/share/classes/sun/io/ByteToCharEUC2.java - src/share/classes/sun/io/ByteToCharEUC_CN.java - src/share/classes/sun/io/ByteToCharEUC_JP.java - src/share/classes/sun/io/ByteToCharEUC_JP_LINUX.java - src/share/classes/sun/io/ByteToCharEUC_JP_Solaris.java - src/share/classes/sun/io/ByteToCharEUC_KR.java - src/share/classes/sun/io/ByteToCharEUC_TW.java - src/share/classes/sun/io/ByteToCharGB18030.java - src/share/classes/sun/io/ByteToCharGB18030DB.java - src/share/classes/sun/io/ByteToCharGBK.java - src/share/classes/sun/io/ByteToCharISCII91.java - src/share/classes/sun/io/ByteToCharISO2022.java - src/share/classes/sun/io/ByteToCharISO2022CN.java - src/share/classes/sun/io/ByteToCharISO2022JP.java - src/share/classes/sun/io/ByteToCharISO2022KR.java - src/share/classes/sun/io/ByteToCharISO8859_1.java - src/share/classes/sun/io/ByteToCharISO8859_13.java - src/share/classes/sun/io/ByteToCharISO8859_15.java - src/share/classes/sun/io/ByteToCharISO8859_2.java - src/share/classes/sun/io/ByteToCharISO8859_3.java - src/share/classes/sun/io/ByteToCharISO8859_4.java - src/share/classes/sun/io/ByteToCharISO8859_5.java - src/share/classes/sun/io/ByteToCharISO8859_6.java - src/share/classes/sun/io/ByteToCharISO8859_7.java - src/share/classes/sun/io/ByteToCharISO8859_8.java - src/share/classes/sun/io/ByteToCharISO8859_9.java - src/share/classes/sun/io/ByteToCharJIS0201.java - src/share/classes/sun/io/ByteToCharJIS0208.java - src/share/classes/sun/io/ByteToCharJIS0208_Solaris.java - src/share/classes/sun/io/ByteToCharJIS0212.java - src/share/classes/sun/io/ByteToCharJIS0212_Solaris.java - src/share/classes/sun/io/ByteToCharJISAutoDetect.java - src/share/classes/sun/io/ByteToCharJohab.java - src/share/classes/sun/io/ByteToCharKOI8_R.java - src/share/classes/sun/io/ByteToCharMS874.java - src/share/classes/sun/io/ByteToCharMS932.java - src/share/classes/sun/io/ByteToCharMS936.java - src/share/classes/sun/io/ByteToCharMS949.java - src/share/classes/sun/io/ByteToCharMS950.java - src/share/classes/sun/io/ByteToCharMS950_HKSCS.java - src/share/classes/sun/io/ByteToCharMacArabic.java - src/share/classes/sun/io/ByteToCharMacCentralEurope.java - src/share/classes/sun/io/ByteToCharMacCroatian.java - src/share/classes/sun/io/ByteToCharMacCyrillic.java - src/share/classes/sun/io/ByteToCharMacDingbat.java - src/share/classes/sun/io/ByteToCharMacGreek.java - src/share/classes/sun/io/ByteToCharMacHebrew.java - src/share/classes/sun/io/ByteToCharMacIceland.java - src/share/classes/sun/io/ByteToCharMacRoman.java - src/share/classes/sun/io/ByteToCharMacRomania.java - src/share/classes/sun/io/ByteToCharMacSymbol.java - src/share/classes/sun/io/ByteToCharMacThai.java - src/share/classes/sun/io/ByteToCharMacTurkish.java - src/share/classes/sun/io/ByteToCharMacUkraine.java - src/share/classes/sun/io/ByteToCharPCK.java - src/share/classes/sun/io/ByteToCharSJIS.java - src/share/classes/sun/io/ByteToCharSingleByte.java - src/share/classes/sun/io/ByteToCharTIS620.java - src/share/classes/sun/io/ByteToCharUTF16.java - src/share/classes/sun/io/ByteToCharUTF8.java - src/share/classes/sun/io/ByteToCharUnicode.java - src/share/classes/sun/io/ByteToCharUnicodeBig.java - src/share/classes/sun/io/ByteToCharUnicodeBigUnmarked.java - src/share/classes/sun/io/ByteToCharUnicodeLittle.java - src/share/classes/sun/io/ByteToCharUnicodeLittleUnmarked.java - src/share/classes/sun/io/CharToByteASCII.java - src/share/classes/sun/io/CharToByteBig5.java - src/share/classes/sun/io/CharToByteBig5_HKSCS.java - src/share/classes/sun/io/CharToByteBig5_Solaris.java - src/share/classes/sun/io/CharToByteConverter.java - src/share/classes/sun/io/CharToByteCp037.java - src/share/classes/sun/io/CharToByteCp1006.java - src/share/classes/sun/io/CharToByteCp1025.java - src/share/classes/sun/io/CharToByteCp1026.java - src/share/classes/sun/io/CharToByteCp1046.java - src/share/classes/sun/io/CharToByteCp1047.java - src/share/classes/sun/io/CharToByteCp1097.java - src/share/classes/sun/io/CharToByteCp1098.java - src/share/classes/sun/io/CharToByteCp1112.java - src/share/classes/sun/io/CharToByteCp1122.java - src/share/classes/sun/io/CharToByteCp1123.java - src/share/classes/sun/io/CharToByteCp1124.java - src/share/classes/sun/io/CharToByteCp1140.java - src/share/classes/sun/io/CharToByteCp1141.java - src/share/classes/sun/io/CharToByteCp1142.java - src/share/classes/sun/io/CharToByteCp1143.java - src/share/classes/sun/io/CharToByteCp1144.java - src/share/classes/sun/io/CharToByteCp1145.java - src/share/classes/sun/io/CharToByteCp1146.java - src/share/classes/sun/io/CharToByteCp1147.java - src/share/classes/sun/io/CharToByteCp1148.java - src/share/classes/sun/io/CharToByteCp1149.java - src/share/classes/sun/io/CharToByteCp1250.java - src/share/classes/sun/io/CharToByteCp1251.java - src/share/classes/sun/io/CharToByteCp1252.java - src/share/classes/sun/io/CharToByteCp1253.java - src/share/classes/sun/io/CharToByteCp1254.java - src/share/classes/sun/io/CharToByteCp1255.java - src/share/classes/sun/io/CharToByteCp1256.java - src/share/classes/sun/io/CharToByteCp1257.java - src/share/classes/sun/io/CharToByteCp1258.java - src/share/classes/sun/io/CharToByteCp1381.java - src/share/classes/sun/io/CharToByteCp1383.java - src/share/classes/sun/io/CharToByteCp273.java - src/share/classes/sun/io/CharToByteCp277.java - src/share/classes/sun/io/CharToByteCp278.java - src/share/classes/sun/io/CharToByteCp280.java - src/share/classes/sun/io/CharToByteCp284.java - src/share/classes/sun/io/CharToByteCp285.java - src/share/classes/sun/io/CharToByteCp297.java - src/share/classes/sun/io/CharToByteCp33722.java - src/share/classes/sun/io/CharToByteCp420.java - src/share/classes/sun/io/CharToByteCp424.java - src/share/classes/sun/io/CharToByteCp437.java - src/share/classes/sun/io/CharToByteCp500.java - src/share/classes/sun/io/CharToByteCp737.java - src/share/classes/sun/io/CharToByteCp775.java - src/share/classes/sun/io/CharToByteCp833.java - src/share/classes/sun/io/CharToByteCp834.java - src/share/classes/sun/io/CharToByteCp838.java - src/share/classes/sun/io/CharToByteCp850.java - src/share/classes/sun/io/CharToByteCp852.java - src/share/classes/sun/io/CharToByteCp855.java - src/share/classes/sun/io/CharToByteCp856.java - src/share/classes/sun/io/CharToByteCp857.java - src/share/classes/sun/io/CharToByteCp858.java - src/share/classes/sun/io/CharToByteCp860.java - src/share/classes/sun/io/CharToByteCp861.java - src/share/classes/sun/io/CharToByteCp862.java - src/share/classes/sun/io/CharToByteCp863.java - src/share/classes/sun/io/CharToByteCp864.java - src/share/classes/sun/io/CharToByteCp865.java - src/share/classes/sun/io/CharToByteCp866.java - src/share/classes/sun/io/CharToByteCp868.java - src/share/classes/sun/io/CharToByteCp869.java - src/share/classes/sun/io/CharToByteCp870.java - src/share/classes/sun/io/CharToByteCp871.java - src/share/classes/sun/io/CharToByteCp874.java - src/share/classes/sun/io/CharToByteCp875.java - src/share/classes/sun/io/CharToByteCp918.java - src/share/classes/sun/io/CharToByteCp921.java - src/share/classes/sun/io/CharToByteCp922.java - src/share/classes/sun/io/CharToByteCp930.java - src/share/classes/sun/io/CharToByteCp933.java - src/share/classes/sun/io/CharToByteCp935.java - src/share/classes/sun/io/CharToByteCp937.java - src/share/classes/sun/io/CharToByteCp939.java - src/share/classes/sun/io/CharToByteCp942.java - src/share/classes/sun/io/CharToByteCp942C.java - src/share/classes/sun/io/CharToByteCp943.java - src/share/classes/sun/io/CharToByteCp943C.java - src/share/classes/sun/io/CharToByteCp948.java - src/share/classes/sun/io/CharToByteCp949.java - src/share/classes/sun/io/CharToByteCp949C.java - src/share/classes/sun/io/CharToByteCp950.java - src/share/classes/sun/io/CharToByteCp964.java - src/share/classes/sun/io/CharToByteCp970.java - src/share/classes/sun/io/CharToByteDBCS_ASCII.java - src/share/classes/sun/io/CharToByteDBCS_EBCDIC.java - src/share/classes/sun/io/CharToByteDoubleByte.java - src/share/classes/sun/io/CharToByteEUC.java - src/share/classes/sun/io/CharToByteEUC_CN.java - src/share/classes/sun/io/CharToByteEUC_JP.java - src/share/classes/sun/io/CharToByteEUC_JP_LINUX.java - src/share/classes/sun/io/CharToByteEUC_JP_Solaris.java - src/share/classes/sun/io/CharToByteEUC_KR.java - src/share/classes/sun/io/CharToByteEUC_TW.java - src/share/classes/sun/io/CharToByteGB18030.java - src/share/classes/sun/io/CharToByteGBK.java - src/share/classes/sun/io/CharToByteISCII91.java - src/share/classes/sun/io/CharToByteISO2022.java - src/share/classes/sun/io/CharToByteISO2022CN_CNS.java - src/share/classes/sun/io/CharToByteISO2022CN_GB.java - src/share/classes/sun/io/CharToByteISO2022JP.java - src/share/classes/sun/io/CharToByteISO2022KR.java - src/share/classes/sun/io/CharToByteISO8859_1.java - src/share/classes/sun/io/CharToByteISO8859_13.java - src/share/classes/sun/io/CharToByteISO8859_15.java - src/share/classes/sun/io/CharToByteISO8859_2.java - src/share/classes/sun/io/CharToByteISO8859_3.java - src/share/classes/sun/io/CharToByteISO8859_4.java - src/share/classes/sun/io/CharToByteISO8859_5.java - src/share/classes/sun/io/CharToByteISO8859_6.java - src/share/classes/sun/io/CharToByteISO8859_7.java - src/share/classes/sun/io/CharToByteISO8859_8.java - src/share/classes/sun/io/CharToByteISO8859_9.java - src/share/classes/sun/io/CharToByteJIS0201.java - src/share/classes/sun/io/CharToByteJIS0208.java - src/share/classes/sun/io/CharToByteJIS0208_Solaris.java - src/share/classes/sun/io/CharToByteJIS0212.java - src/share/classes/sun/io/CharToByteJIS0212_Solaris.java - src/share/classes/sun/io/CharToByteJohab.java - src/share/classes/sun/io/CharToByteKOI8_R.java - src/share/classes/sun/io/CharToByteMS874.java - src/share/classes/sun/io/CharToByteMS932.java - src/share/classes/sun/io/CharToByteMS936.java - src/share/classes/sun/io/CharToByteMS949.java - src/share/classes/sun/io/CharToByteMS950.java - src/share/classes/sun/io/CharToByteMS950_HKSCS.java - src/share/classes/sun/io/CharToByteMacArabic.java - src/share/classes/sun/io/CharToByteMacCentralEurope.java - src/share/classes/sun/io/CharToByteMacCroatian.java - src/share/classes/sun/io/CharToByteMacCyrillic.java - src/share/classes/sun/io/CharToByteMacDingbat.java - src/share/classes/sun/io/CharToByteMacGreek.java - src/share/classes/sun/io/CharToByteMacHebrew.java - src/share/classes/sun/io/CharToByteMacIceland.java - src/share/classes/sun/io/CharToByteMacRoman.java - src/share/classes/sun/io/CharToByteMacRomania.java - src/share/classes/sun/io/CharToByteMacSymbol.java - src/share/classes/sun/io/CharToByteMacThai.java - src/share/classes/sun/io/CharToByteMacTurkish.java - src/share/classes/sun/io/CharToByteMacUkraine.java - src/share/classes/sun/io/CharToBytePCK.java - src/share/classes/sun/io/CharToByteSJIS.java - src/share/classes/sun/io/CharToByteSingleByte.java - src/share/classes/sun/io/CharToByteTIS620.java - src/share/classes/sun/io/CharToByteUTF16.java - src/share/classes/sun/io/CharToByteUTF8.java - src/share/classes/sun/io/CharToByteUnicode.java - src/share/classes/sun/io/CharToByteUnicodeBig.java - src/share/classes/sun/io/CharToByteUnicodeBigUnmarked.java - src/share/classes/sun/io/CharToByteUnicodeLittle.java - src/share/classes/sun/io/CharToByteUnicodeLittleUnmarked.java - src/share/classes/sun/io/CharacterEncoding.java - src/share/classes/sun/io/ConversionBufferFullException.java - src/share/classes/sun/io/Converters.java - src/share/classes/sun/io/MalformedInputException.java - src/share/classes/sun/io/UnknownCharacterException.java ! src/share/classes/sun/nio/cs/ext/GB18030.java ! src/share/classes/sun/nio/cs/ext/IBM33722.java ! src/share/classes/sun/nio/cs/ext/IBM964.java ! src/share/classes/sun/nio/cs/ext/ISCII91.java ! src/share/classes/sun/nio/cs/ext/JIS_X_0208_Decoder.java ! src/share/classes/sun/nio/cs/ext/JIS_X_0208_Encoder.java ! src/share/classes/sun/nio/cs/ext/JIS_X_0208_Solaris_Decoder.java ! src/share/classes/sun/nio/cs/ext/JIS_X_0212_Decoder.java ! src/share/classes/sun/nio/cs/ext/JIS_X_0212_Encoder.java ! src/share/classes/sun/nio/cs/ext/JIS_X_0212_Solaris_Decoder.java ! src/share/classes/sun/nio/cs/ext/JIS_X_0212_Solaris_Encoder.java ! test/sun/nio/cs/TestCp834_SBCS.java - test/sun/nio/cs/TestISCII91.java Changeset: 07ad16388170 Author: sherman Date: 2011-08-17 14:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/07ad16388170 Merge From xueming.shen at oracle.com Wed Aug 17 15:05:47 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Wed, 17 Aug 2011 22:05:47 +0000 Subject: hg: jdk8/tl/jdk: 7066490: @since 1.7 tag is missing for java.util.regex.Matcher.group(java.lang.String) Message-ID: <20110817220558.C539D47C77@hg.openjdk.java.net> Changeset: 11cc9c2e0431 Author: sherman Date: 2011-08-17 15:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11cc9c2e0431 7066490: @since 1.7 tag is missing for java.util.regex.Matcher.group(java.lang.String) Summary: Added the @since 1.7 tag Reviewed-by: mduigou, forax ! src/share/classes/java/util/regex/Matcher.java From gary.collins at sun.com Wed Aug 17 07:06:22 2011 From: gary.collins at sun.com (gary.collins at sun.com) Date: Wed, 17 Aug 2011 14:06:22 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 10 new changesets Message-ID: <20110817140640.B2CC747C5B@hg.openjdk.java.net> Changeset: 14a2fd14c0db Author: johnc Date: 2011-08-01 10:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/14a2fd14c0db 7068240: G1: Long "parallel other time" and "ext root scanning" when running specific benchmark Summary: In root processing, move the scanning of the reference processor's discovered lists to before RSet updating and scanning. When scanning the reference processor's discovered lists, use a buffering closure so that the time spent copying any reference object is correctly attributed. Also removed a couple of unused and irrelevant timers. Reviewed-by: ysr, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: 6aa4feb8a366 Author: johnc Date: 2011-08-02 12:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6aa4feb8a366 7069863: G1: SIGSEGV running SPECjbb2011 and -UseBiasedLocking Summary: Align the reserved size of the heap and perm to the heap region size to get a preferred heap base that is aligned to the region size, and call the correct heap reservation constructor. Also add a check in the heap reservation code that the reserved space starts at the requested address (if any). Reviewed-by: kvn, ysr ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/virtualspace.cpp Changeset: a20e6e447d3d Author: iveresov Date: 2011-08-05 16:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a20e6e447d3d 7060842: UseNUMA crash with UseHugreTLBFS running SPECjvm2008 Summary: Use mmap() instead of madvise(MADV_DONTNEED) to uncommit pages Reviewed-by: ysr ! src/os/linux/vm/os_linux.cpp Changeset: 7c2653aefc46 Author: iveresov Date: 2011-08-05 16:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7c2653aefc46 7060836: RHEL 5.5 and 5.6 should support UseNUMA Summary: Add a wrapper for sched_getcpu() for systems where libc lacks it Reviewed-by: ysr Contributed-by: Andrew John Hughes ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp Changeset: 41e6ee74f879 Author: kevinw Date: 2011-08-02 14:37 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/41e6ee74f879 7072527: CMS: JMM GC counters overcount in some cases Summary: Avoid overcounting when CMS has concurrent mode failure. Reviewed-by: ysr Contributed-by: rednaxelafx at gmail.com ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp + test/gc/7072527/TestFullGCCount.java Changeset: e9db47a083cc Author: kevinw Date: 2011-08-11 14:58 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e9db47a083cc Merge Changeset: 87e40b34bc2b Author: johnc Date: 2011-08-11 11:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/87e40b34bc2b 7074579: G1: JVM crash with JDK7 running ATG CRMDemo Fusion App Summary: Handlize MemoryUsage klass oop in createGCInfo routine Reviewed-by: tonyp, fparain, ysr, jcoomes ! src/share/vm/services/gcNotifier.cpp Changeset: f44782f04dd4 Author: tonyp Date: 2011-08-12 11:31 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f44782f04dd4 7039627: G1: avoid BOT updates for survivor allocations and dirty survivor regions incrementally Summary: Refactor the allocation code during GC to use the G1AllocRegion abstraction. Use separate subclasses of G1AllocRegion for survivor and old regions. Avoid BOT updates and dirty survivor cards incrementally for the former. Reviewed-by: brutisso, johnc, ysr ! src/share/vm/gc_implementation/g1/g1AllocRegion.cpp ! src/share/vm/gc_implementation/g1/g1AllocRegion.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp Changeset: 76b1a9420e3d Author: ysr Date: 2011-08-16 08:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/76b1a9420e3d Merge Changeset: 00ed4ccfe642 Author: collins Date: 2011-08-17 07:05 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/00ed4ccfe642 Merge From lana.steuck at oracle.com Wed Aug 17 23:07:56 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 18 Aug 2011 06:07:56 +0000 Subject: hg: jdk8/tl/jdk: 7 new changesets Message-ID: <20110818060904.5F79447CC5@hg.openjdk.java.net> Changeset: 34fdcdb70d20 Author: rupashka Date: 2011-07-28 18:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/34fdcdb70d20 6995769: occasion NPE thrown from SwingUtilities.computeIntersection() Reviewed-by: alexp ! src/share/classes/javax/swing/RepaintManager.java Changeset: 86098b3f7789 Author: rupashka Date: 2011-07-28 18:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/86098b3f7789 7071166: LayoutStyle.getPreferredGap() - IAE is expected but not thrown Reviewed-by: peterz ! src/share/classes/sun/swing/DefaultLayoutStyle.java + test/javax/swing/GroupLayout/7071166/bug7071166.java Changeset: 0ce1f0b21446 Author: serb Date: 2011-08-01 17:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ce1f0b21446 7068060: closed/java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java failed on windows Reviewed-by: art, dcherepanov + test/java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java Changeset: 854e74d8d956 Author: rupashka Date: 2011-08-03 16:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/854e74d8d956 7072328: Sun URL in the MetalLookAndFeel.getLayoutStyle() specification should be replaced with Oracle one Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java Changeset: 634c2a492cf5 Author: lana Date: 2011-08-05 15:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/634c2a492cf5 Merge - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java Changeset: 2cdbbc4a6359 Author: lana Date: 2011-08-09 17:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2cdbbc4a6359 Merge - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c Changeset: 7d8927b76d68 Author: lana Date: 2011-08-17 22:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7d8927b76d68 Merge From alan.bateman at oracle.com Thu Aug 18 08:54:11 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 18 Aug 2011 15:54:11 +0000 Subject: hg: jdk8/tl/jdk: 7015589: (spec) BufferedWriter.close leaves stream open if close of underlying Writer fails Message-ID: <20110818155435.84FEE47D09@hg.openjdk.java.net> Changeset: 759aa847dcaf Author: alanb Date: 2011-08-18 16:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/759aa847dcaf 7015589: (spec) BufferedWriter.close leaves stream open if close of underlying Writer fails Reviewed-by: forax, mduigou ! src/share/classes/java/io/BufferedReader.java ! src/share/classes/java/io/BufferedWriter.java ! src/share/classes/java/io/Closeable.java ! src/share/classes/java/io/FilterOutputStream.java ! src/share/classes/java/lang/AutoCloseable.java + test/java/io/etc/FailingFlushAndClose.java ! test/java/lang/ProcessBuilder/Basic.java From weijun.wang at oracle.com Thu Aug 18 22:43:33 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Fri, 19 Aug 2011 05:43:33 +0000 Subject: hg: jdk8/tl/jdk: 7043847: NTML impl of SaslServer throws UnsupportedOperationException from (un)wrap method; ... Message-ID: <20110819054352.194BE47DBF@hg.openjdk.java.net> Changeset: 55952703809f Author: weijun Date: 2011-08-19 13:42 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/55952703809f 7043847: NTML impl of SaslServer throws UnsupportedOperationException from (un)wrap method 7043860: NTML impl of SaslServer doesn't throw ISE from getAuthorizationID() method 7043882: NTML impl of SaslServer doesn't throw ISE from getNegotiatedProperty() method 7043938: NTML impl of SaslClientFactory throws NPE instead of SaslException 7043959: NTML impl of SaslClientFactory throws NPE for null CallBackHandler instance Reviewed-by: vinnie ! src/share/classes/com/sun/security/ntlm/Client.java ! src/share/classes/com/sun/security/ntlm/NTLMException.java ! src/share/classes/com/sun/security/ntlm/Server.java ! src/share/classes/com/sun/security/sasl/ntlm/FactoryImpl.java ! src/share/classes/com/sun/security/sasl/ntlm/NTLMClient.java ! src/share/classes/com/sun/security/sasl/ntlm/NTLMServer.java + test/com/sun/security/sasl/ntlm/Conformance.java From chris.hegarty at oracle.com Fri Aug 19 02:56:45 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 19 Aug 2011 09:56:45 +0000 Subject: hg: jdk8/tl/jdk: 7025938: Add bitmap mime type to content-types.properties Message-ID: <20110819095709.84ABF47DDC@hg.openjdk.java.net> Changeset: 46b53f80ab0a Author: chegar Date: 2011-08-19 10:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46b53f80ab0a 7025938: Add bitmap mime type to content-types.properties Reviewed-by: chegar, alanb, michaelm Contributed-by: lvjing at linux.vnet.ibm.com ! src/solaris/lib/content-types.properties ! src/windows/lib/content-types.properties From nils.loodin at oracle.com Fri Aug 19 06:53:11 2011 From: nils.loodin at oracle.com (Nils Loodin) Date: Fri, 19 Aug 2011 15:53:11 +0200 Subject: code review for 7067811: Update demo/sample code to state it should not be used for production In-Reply-To: <4E43EFCB.70406@oracle.com> References: <4E43EFCB.70406@oracle.com> Message-ID: <4E4E6AC7.1070608@oracle.com> I've contacted Aurelio, and he has updated the bug with the additional demands. Also I've updated the webrev (accessible here: http://cr.openjdk.java.net/~nloodin/7067811/webrev.02/ ) Added comment to each demo file (as stated in the bug), put a top level readme in the demo and sample dir containing a similar text. So basically a comment block in a bunch of demo source files, and some updated makefiles.. I'll send the review out here first, and then to other lists as I get comments. /Nisse From joe.darcy at oracle.com Fri Aug 19 17:42:47 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Sat, 20 Aug 2011 00:42:47 +0000 Subject: hg: jdk8/tl/jdk: 4748706: typos in java.util.Observable documentation Message-ID: <20110820004257.3A94E47E7A@hg.openjdk.java.net> Changeset: 8018d541a7b2 Author: darcy Date: 2011-08-19 17:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8018d541a7b2 4748706: typos in java.util.Observable documentation Reviewed-by: iris ! src/share/classes/java/util/Observable.java From alan.bateman at oracle.com Mon Aug 22 03:41:52 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 22 Aug 2011 10:41:52 +0000 Subject: hg: jdk8/tl/jdk: 7081796: (ch) rawtype warning in sun.nio.ch.InheritedChannel Message-ID: <20110822104215.F3F9F47FCD@hg.openjdk.java.net> Changeset: b3425b50bc36 Author: alanb Date: 2011-08-22 11:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b3425b50bc36 7081796: (ch) rawtype warning in sun.nio.ch.InheritedChannel Reviewed-by: chegar ! src/solaris/classes/sun/nio/ch/InheritedChannel.java From chris.hegarty at oracle.com Mon Aug 22 06:10:33 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Mon, 22 Aug 2011 13:10:33 +0000 Subject: hg: jdk8/tl/jdk: 7023713: HttpCookie.domainMatches("hostname.local", "hostname") should return true Message-ID: <20110822131044.950FF47FD3@hg.openjdk.java.net> Changeset: 5c1f90dd0405 Author: chegar Date: 2011-08-22 14:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5c1f90dd0405 7023713: HttpCookie.domainMatches("hostname.local", "hostname") should return true Reviewed-by: chegar Contributed-by: zhouyx at linux.vnet.ibm.com ! src/share/classes/java/net/HttpCookie.java ! test/java/net/CookieHandler/TestHttpCookie.java From alan.bateman at oracle.com Mon Aug 22 08:06:25 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 22 Aug 2011 15:06:25 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20110822150645.EE18247FD9@hg.openjdk.java.net> Changeset: fd07a2b7bf4d Author: alanb Date: 2011-08-22 16:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fd07a2b7bf4d 7081813: ProblemList.txt updates (8/2011) Reviewed-by: weijun, mchung ! test/ProblemList.txt ! test/java/io/IOException/LastErrorString.java Changeset: 605ea77f2e6f Author: alanb Date: 2011-08-22 16:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/605ea77f2e6f Merge From joe.darcy at oracle.com Mon Aug 22 12:16:58 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Mon, 22 Aug 2011 19:16:58 +0000 Subject: hg: jdk8/tl/jdk: 7080020: Add conventional constructors to InternalError and VirtualMachineError Message-ID: <20110822191717.9FF1347FE5@hg.openjdk.java.net> Changeset: c43af666d130 Author: darcy Date: 2011-08-22 12:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c43af666d130 7080020: Add conventional constructors to InternalError and VirtualMachineError Reviewed-by: darcy Contributed-by: nsebastian.sickelmann at gmx.de ! src/share/classes/com/sun/servicetag/SunConnection.java ! src/share/classes/java/lang/InternalError.java ! src/share/classes/java/lang/VirtualMachineError.java ! src/share/classes/java/util/prefs/Preferences.java ! src/share/classes/sun/font/FontManagerFactory.java ! src/share/classes/sun/misc/URLClassPath.java ! src/share/classes/sun/reflect/MethodAccessorGenerator.java ! src/share/classes/sun/security/x509/X500Name.java ! src/share/classes/sun/tools/jconsole/ProxyClient.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java From mandy.chung at oracle.com Mon Aug 22 14:52:19 2011 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 22 Aug 2011 14:52:19 -0700 Subject: java.nio.BufferPoolMXBean getObjectName() occasionally returns null In-Reply-To: <4E250380.1000409@oracle.com> References: <4E250380.1000409@oracle.com> Message-ID: <4E52CF93.2040102@oracle.com> Steve, I have prepared a patch from your contribution [1] to fix: 7068328: BufferPoolMXBean and PlatformLoggingMXBean getObjectName may return null Webrev at: http://cr.openjdk.java.net/~mchung/7068328/webrev.00/ I have modified the fix to move the "result = objname" assignment before the check to construct the ObjectName and also cover the logging mxbean. Are you okay with this? Serviceability team, May I get a reviewer for this patch? I won't count myself as a reviewer as I modify the fix. Thanks Mandy [1] http://mail.openjdk.java.net/pipermail/nio-dev/2011-July/001385.html From joe.darcy at oracle.com Mon Aug 22 17:13:40 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 23 Aug 2011 00:13:40 +0000 Subject: hg: jdk8/tl/jdk: 6476261: (reflect) GenericSignatureFormatError When signature includes nested inner classes; ... Message-ID: <20110823001350.8555147FF3@hg.openjdk.java.net> Changeset: b1f99f9c2879 Author: darcy Date: 2011-08-22 17:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b1f99f9c2879 6476261: (reflect) GenericSignatureFormatError When signature includes nested inner classes 6832374: (reflect) malformed signature can cause parser to go into infinite loop 7052898: (reflect) SignatureParser will accept strings outside of the grammar Summary: Various signature parsing fixes; additional review by sonali.goel at oracle.com Reviewed-by: alanb ! src/share/classes/sun/reflect/generics/parser/SignatureParser.java ! test/java/lang/reflect/Generics/Probe.java + test/java/lang/reflect/Generics/SignatureTest.java + test/java/lang/reflect/Generics/TestBadSignatures.java From joe.darcy at oracle.com Mon Aug 22 17:34:46 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 23 Aug 2011 00:34:46 +0000 Subject: hg: jdk8/tl/jdk: 7080038: (ann) Serializable types in sun.reflect.annotation do not declare serialVersionUIDs Message-ID: <20110823003457.AF30C47FF6@hg.openjdk.java.net> Changeset: 71e353aba896 Author: darcy Date: 2011-08-22 17:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71e353aba896 7080038: (ann) Serializable types in sun.reflect.annotation do not declare serialVersionUIDs Reviewed-by: alanb ! src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java ! src/share/classes/sun/reflect/annotation/AnnotationTypeMismatchExceptionProxy.java ! src/share/classes/sun/reflect/annotation/EnumConstantNotPresentExceptionProxy.java ! src/share/classes/sun/reflect/annotation/TypeNotPresentExceptionProxy.java From gary.collins at sun.com Mon Aug 22 17:56:23 2011 From: gary.collins at sun.com (gary.collins at sun.com) Date: Tue, 23 Aug 2011 00:56:23 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 30 new changesets Message-ID: <20110823005721.A841947FF9@hg.openjdk.java.net> Changeset: 43f9d800f276 Author: iveresov Date: 2011-07-20 18:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/43f9d800f276 7066339: Tiered: policy should make consistent decisions about osr levels Summary: Added feedback disabling flag to common(), fixed handling of TieredStopAtLevel. Reviewed-by: kvn, never ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/advancedThresholdPolicy.hpp ! src/share/vm/runtime/compilationPolicy.hpp ! src/share/vm/runtime/javaCalls.cpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.hpp Changeset: 6a991dcb52bb Author: never Date: 2011-07-21 08:38 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6a991dcb52bb 7012081: JSR 292: SA-JDI can't read MH/MT/Indy ConstantPool entries Reviewed-by: kvn, twisti, jrose ! agent/src/share/classes/sun/jvm/hotspot/interpreter/Bytecode.java - agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeFastAAccess0.java - agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeFastIAccess0.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeLoadConstant.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeStream.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeWideable.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeWithCPIndex.java ! agent/src/share/classes/sun/jvm/hotspot/interpreter/Bytecodes.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPool.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCache.java ! agent/src/share/classes/sun/jvm/hotspot/oops/GenerateOopMap.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Method.java ! agent/src/share/classes/sun/jvm/hotspot/oops/TypeArray.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/ConstantTag.java ! src/share/vm/oops/generateOopMap.cpp Changeset: 3d42f82cd811 Author: kvn Date: 2011-07-21 11:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3d42f82cd811 7063628: Use cbcond on T4 Summary: Add new short branch instruction to Hotspot sparc assembler. Reviewed-by: never, twisti, jrose ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_MacroAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/interpreter_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/machnode.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/globals.hpp Changeset: 4e761e7e6e12 Author: kvn Date: 2011-07-26 19:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4e761e7e6e12 7070134: Hotspot crashes with sigsegv from PorterStemmer Summary: Do not move data nodes which are attached to a predicate test to a dominating test. Reviewed-by: never ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp + test/compiler/7070134/Stemmer.java + test/compiler/7070134/Test7070134.sh + test/compiler/7070134/words Changeset: 0f34fdee809e Author: never Date: 2011-07-27 15:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0f34fdee809e 7071427: AdapterFingerPrint can hold 8 entries per int Reviewed-by: kvn ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: c7b60b601eb4 Author: kvn Date: 2011-07-27 17:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c7b60b601eb4 7069452: Cleanup NodeFlags Summary: Remove flags which duplicate information in Node::NodeClasses. Reviewed-by: never ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/formssel.hpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/cfgnode.hpp ! src/share/vm/opto/coalesce.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/machnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/mulnode.hpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/superword.hpp ! src/share/vm/opto/vectornode.cpp ! src/share/vm/opto/vectornode.hpp Changeset: d17bd0b18663 Author: twisti Date: 2011-07-28 02:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d17bd0b18663 7066143: JSR 292: Zero support after regressions from 7009923 and 7009309 Reviewed-by: jrose, twisti Contributed-by: Xerxes Ranby ! src/cpu/zero/vm/stack_zero.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: ce3e1d4dc416 Author: never Date: 2011-07-28 13:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ce3e1d4dc416 7060619: C1 should respect inline and dontinline directives from CompilerOracle Reviewed-by: kvn, iveresov ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: c96c3eb1efae Author: kvn Date: 2011-07-29 09:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c96c3eb1efae 7068051: SIGSEGV in PhaseIdealLoop::build_loop_late_post Summary: Removed predicate cloning from loop peeling optimization and from split fall-in paths. Reviewed-by: never ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/phaseX.hpp Changeset: 4aa5974a06dd Author: kvn Date: 2011-08-06 08:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4aa5974a06dd 7075559: JPRT windows_x64 build failure Summary: use SA_CLASSDIR variable instead of dirsctory saclasses. Reviewed-by: kamg, dcubed ! make/linux/makefiles/defs.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/saproc.make ! make/windows/makefiles/defs.make ! make/windows/makefiles/sa.make Changeset: a3142bdb6707 Author: twisti Date: 2011-08-08 05:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a3142bdb6707 7071823: Zero: zero/shark doesn't build after b147-fcs Reviewed-by: gbenson, twisti Contributed-by: Chris Phillips ! src/cpu/zero/vm/frame_zero.cpp + src/cpu/zero/vm/methodHandles_zero.hpp ! src/cpu/zero/vm/sharedRuntime_zero.cpp ! src/share/vm/shark/sharkContext.hpp Changeset: a19c671188cb Author: never Date: 2011-08-08 13:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a19c671188cb 7075623: 6990212 broke raiseException in 64 bit Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp Changeset: f1c12354c3f7 Author: roland Date: 2011-08-02 18:36 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f1c12354c3f7 7074017: Introduce MemBarAcquireLock/MemBarReleaseLock nodes for monitor enter/exit code paths Summary: replace MemBarAcquire/MemBarRelease nodes on the monitor enter/exit code paths with new MemBarAcquireLock/MemBarReleaseLock nodes Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp Changeset: 6987871cfb9b Author: kvn Date: 2011-08-10 14:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6987871cfb9b 7077439: Possible reference through NULL in loopPredicate.cpp:726 Summary: Use cl->is_valid_counted_loop() check. Reviewed-by: never ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/superword.cpp Changeset: 95134e034042 Author: kvn Date: 2011-08-11 12:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/95134e034042 7063629: use cbcond in C2 generated code on T4 Summary: Use new short branch instruction in C2 generated code. Reviewed-by: never ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os_cpu/linux_x86/vm/linux_x86_32.ad ! src/os_cpu/linux_x86/vm/linux_x86_64.ad ! src/os_cpu/solaris_x86/vm/solaris_x86_32.ad ! src/os_cpu/solaris_x86/vm/solaris_x86_64.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/machnode.hpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp Changeset: fdb992d83a87 Author: twisti Date: 2011-08-16 04:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fdb992d83a87 7071653: JSR 292: call site change notification should be pushed not pulled Reviewed-by: kvn, never, bdelsart ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.hpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/ci/ciCallSite.cpp ! src/share/vm/ci/ciCallSite.hpp ! src/share/vm/ci/ciField.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/dependencies.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/templateTable.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse3.cpp Changeset: 11211f7cb5a0 Author: kvn Date: 2011-08-16 11:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/11211f7cb5a0 7079317: Incorrect branch's destination block in PrintoOptoAssembly output Summary: save/restore label and block in scratch_emit_size() Reviewed-by: never ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/machnode.hpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp Changeset: 1af104d6cf99 Author: kvn Date: 2011-08-16 16:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1af104d6cf99 7079329: Adjust allocation prefetching for T4 Summary: on T4 2 BIS instructions should be issued to prefetch 64 bytes Reviewed-by: iveresov, phh, twisti ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/memory/threadLocalAllocBuffer.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp Changeset: 381bf869f784 Author: twisti Date: 2011-08-17 05:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/381bf869f784 7079626: x64 emits unnecessary REX prefix Reviewed-by: kvn, iveresov, never ! src/cpu/x86/vm/assembler_x86.cpp Changeset: bd87c0dcaba5 Author: twisti Date: 2011-08-17 11:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bd87c0dcaba5 7079769: JSR 292: incorrect size() for CallStaticJavaHandle on sparc Reviewed-by: never, kvn ! src/cpu/sparc/vm/sparc.ad Changeset: 739a9abbbd4b Author: kvn Date: 2011-08-18 11:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/739a9abbbd4b 7080431: VM asserts if specified size(x) in .ad is larger than emitted size Summary: Move code from finalize_offsets_and_shorten() to fill_buffer() to restore previous behavior. Reviewed-by: never ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/output.cpp Changeset: de147f62e695 Author: kvn Date: 2011-08-19 08:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/de147f62e695 Merge - agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeFastAAccess0.java - agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeFastIAccess0.java Changeset: 24cee90e9453 Author: jcoomes Date: 2011-08-17 10:32 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/24cee90e9453 6791672: enable 1G and larger pages on solaris Reviewed-by: ysr, iveresov, johnc ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp Changeset: 3be7439273c5 Author: katleman Date: 2011-05-25 13:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3be7439273c5 7044486: open jdk repos have files with incorrect copyright headers, which can end up in src bundles Reviewed-by: ohair, trims ! agent/src/share/classes/sun/jvm/hotspot/runtime/ServiceThread.java ! make/linux/README ! make/windows/projectfiles/kernel/Makefile ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/os_cpu/solaris_sparc/vm/solaris_sparc.s ! src/share/tools/hsdis/README ! src/share/vm/gc_implementation/g1/heapRegionSet.inline.hpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/utilities/yieldingWorkgroup.cpp Changeset: 8b135e6129d6 Author: jeff Date: 2011-05-27 15:01 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8b135e6129d6 7045697: JDK7 THIRD PARTY README update Reviewed-by: lana ! THIRD_PARTY_README Changeset: 52e4ba46751f Author: kamg Date: 2011-04-12 16:42 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/52e4ba46751f 7020373: JSR rewriting can overflow memory address size variables Summary: Abort if incoming classfile's parameters would cause overflows Reviewed-by: coleenp, dcubed, never ! src/share/vm/oops/generateOopMap.cpp + test/runtime/7020373/Test7020373.sh Changeset: bca686989d4b Author: asaha Date: 2011-06-15 14:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bca686989d4b 7055247: Ignore test of # 7020373 Reviewed-by: dcubed ! test/runtime/7020373/Test7020373.sh Changeset: 337ffef74c37 Author: jeff Date: 2011-06-22 10:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/337ffef74c37 7057046: Add embedded license to THIRD PARTY README Reviewed-by: lana ! THIRD_PARTY_README Changeset: 9f12ede5571a Author: jcoomes Date: 2011-08-19 14:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9f12ede5571a Merge ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/share/vm/oops/generateOopMap.cpp ! src/share/vm/runtime/os.cpp Changeset: 7c29742c41b4 Author: jcoomes Date: 2011-08-19 14:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7c29742c41b4 7081251: bump the hs22 build number to 02 Reviewed-by: johnc ! make/hotspot_version From xuelei.fan at oracle.com Mon Aug 22 18:23:09 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Tue, 23 Aug 2011 01:23:09 +0000 Subject: hg: jdk8/tl/jdk: 7081817: test/sun/security/provider/certpath/X509CertPath/IllegalCertiticates.java failing Message-ID: <20110823012319.B160447FFB@hg.openjdk.java.net> Changeset: 21f4d2d96191 Author: xuelei Date: 2011-08-22 18:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21f4d2d96191 7081817: test/sun/security/provider/certpath/X509CertPath/IllegalCertiticates.java failing Reviewed-by: alanb, weijun ! src/share/classes/sun/security/provider/certpath/X509CertPath.java From Alan.Bateman at oracle.com Tue Aug 23 02:11:38 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 23 Aug 2011 10:11:38 +0100 Subject: java.nio.BufferPoolMXBean getObjectName() occasionally returns null In-Reply-To: <4E52CF93.2040102@oracle.com> References: <4E250380.1000409@oracle.com> <4E52CF93.2040102@oracle.com> Message-ID: <4E536ECA.2050107@oracle.com> Mandy Chung wrote: > Steve, > > I have prepared a patch from your contribution [1] to fix: > 7068328: BufferPoolMXBean and PlatformLoggingMXBean getObjectName > may return null > > Webrev at: > http://cr.openjdk.java.net/~mchung/7068328/webrev.00/ > > I have modified the fix to move the "result = objname" assignment > before the check to construct the ObjectName and also cover the > logging mxbean. Are you okay with this? > > Serviceability team, > May I get a reviewer for this patch? I won't count myself as a > reviewer as I modify the fix. > Thanks for picking this up. At L175 then this can be "if (result == null)" to avoid reading objname again. Same thing at L233. The test looks fine. -Alan. From spoole at linux.vnet.ibm.com Tue Aug 23 02:36:31 2011 From: spoole at linux.vnet.ibm.com (Steve Poole) Date: Tue, 23 Aug 2011 10:36:31 +0100 Subject: java.nio.BufferPoolMXBean getObjectName() occasionally returns null In-Reply-To: <4E536ECA.2050107@oracle.com> References: <4E250380.1000409@oracle.com> <4E52CF93.2040102@oracle.com> <4E536ECA.2050107@oracle.com> Message-ID: <1314092191.10906.4.camel@jazzette> On Tue, 2011-08-23 at 10:11 +0100, Alan Bateman wrote: > Mandy Chung wrote: > > Steve, > > > > I have prepared a patch from your contribution [1] to fix: > > 7068328: BufferPoolMXBean and PlatformLoggingMXBean getObjectName > > may return null > > > > Webrev at: > > http://cr.openjdk.java.net/~mchung/7068328/webrev.00/ > > > > I have modified the fix to move the "result = objname" assignment > > before the check to construct the ObjectName and also cover the > > logging mxbean. Are you okay with this? > > > > Serviceability team, > > May I get a reviewer for this patch? I won't count myself as a > > reviewer as I modify the fix. > > > Thanks for picking this up. > > At L175 then this can be "if (result == null)" to avoid reading objname > again. Same thing at L233. The test looks fine. > > -Alan. > > Mandy, Alan - thanks for completing this work. I hadn't forgotten just not got round to it :-(. I like the new testcase BTW. Now I have a great example for the future Steve From mandy.chung at oracle.com Tue Aug 23 10:36:29 2011 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Tue, 23 Aug 2011 17:36:29 +0000 Subject: hg: jdk8/tl/jdk: 7068328: BufferPoolMXBean and PlatformLoggingMXBean getObjectName may return null Message-ID: <20110823173654.5A11347033@hg.openjdk.java.net> Changeset: 4e53fc6bcac0 Author: mchung Date: 2011-08-23 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4e53fc6bcac0 7068328: BufferPoolMXBean and PlatformLoggingMXBean getObjectName may return null Reviewed-by: alanb Contributed-by: spoole at uk.ibm.com ! src/share/classes/sun/management/ManagementFactoryHelper.java + test/java/lang/management/ManagementFactory/GetObjectName.java From joe.darcy at oracle.com Tue Aug 23 16:36:18 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Tue, 23 Aug 2011 23:36:18 +0000 Subject: hg: jdk8/tl/jdk: 7082231: Put a @since 1.7 on System.lineSeparator Message-ID: <20110823233645.44FCF4706C@hg.openjdk.java.net> Changeset: 440161cc9af8 Author: darcy Date: 2011-08-23 16:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/440161cc9af8 7082231: Put a @since 1.7 on System.lineSeparator Reviewed-by: mduigou ! src/share/classes/java/lang/System.java From nils.loodin at oracle.com Wed Aug 24 06:11:19 2011 From: nils.loodin at oracle.com (Nils Loodin) Date: Wed, 24 Aug 2011 15:11:19 +0200 Subject: code review for 7067811: Update demo/sample code to state it should not be used for production In-Reply-To: <0810FDCE-255B-4962-953F-1F49DA909BF3@oracle.com> References: <4E43EFCB.70406@oracle.com> <4E43FC42.1080902@oracle.com> <4E45858C.7060400@oracle.com> <0810FDCE-255B-4962-953F-1F49DA909BF3@oracle.com> Message-ID: <4E54F877.80802@oracle.com> Finally the public changes in the bug is visible. From the description: ----- The documentation should include the following disclaimer: The source code provided with samples and demos for the JDK is meant to illustrate the usage of a given feature or technique and has been deliberately simplified. Additional steps required for a production-quality application, such as security checks, input validation, and proper error handling, might not be present in the sample code. Usage of sample code in production environments is strongly discouraged. On the actual source code a variation of the message should be included as a comment in the header: This source code is provided to illustrate the usage of a given feature or technique and has been deliberately simplified. Additional steps required for a production-quality application, such as security checks, input validation, and proper error handling, might not be present in this sample code. Finally on the documentation of applications, such as the lightweight HTTP server, that are shipped for testing/debugging, the following disclaimer should be added: Applications such as the lightweight HTTP server are shipped with the JDK to help developers deploy and test their code easily. They have not been developed in accordance to software development standards for production-quality applications. Usage of such test and/or support applications in production environments is strongly discouraged. ------- Comment block after copyright in demo / sample sources, i've excluded hprof_b_spec.h from these comments as it contains a public api that's actually supposed to be used. also makefiles are updated to copy a toplevel readme in the sample and demo dirs. Webrev: http://cr.openjdk.java.net/~nloodin/7067811/webrev.03/ CC:ing i18n and 2d since they have demos in these dirs. Regards, Nisse On 08/15/2011 10:15 AM, Nils Loodin wrote: >>> Nils - is it just demo code or do you plan to do this to sample code too (sample code is in src/share/sample/**)? One thing that isn't clear to me is why this needs to be added to every file. Seems like a warning in each demo's README should be sufficient. >>> > Also samples. > >> I agree with Alan that README in each demo would be a proper and adequate place to add this warning. In addition, there is a typo "suich" in the third line of the warning: >> >>> * required for a production-quality application, suich as security checks, > That was not intentional. > >> Is this intentional? Or a typo should be fixed? >> >> Mandy > I'm holding off sending to the other mailing lists until I can get the requirements that the text be included in each source file officially by the one who set the demand. > > As background, yes this is a legal thing. Oracle has strict requirements on in which form Demos and samples can be included in packaging.. > > /Nisse > From Alan.Bateman at oracle.com Wed Aug 24 12:03:49 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 24 Aug 2011 20:03:49 +0100 Subject: code review for 7067811: Update demo/sample code to state it should not be used for production In-Reply-To: <4E54F877.80802@oracle.com> References: <4E43EFCB.70406@oracle.com> <4E43FC42.1080902@oracle.com> <4E45858C.7060400@oracle.com> <0810FDCE-255B-4962-953F-1F49DA909BF3@oracle.com> <4E54F877.80802@oracle.com> Message-ID: <4E554B15.1010509@oracle.com> Nils Loodin wrote: > : > > Finally on the documentation of applications, such as the lightweight > HTTP server, that are shipped for testing/debugging, the following > disclaimer should be added: > > Applications such as the lightweight HTTP server are shipped with the > JDK to help developers deploy and test their code easily. They have > not been developed in accordance to software development standards for > production-quality applications. Usage of such test and/or support > applications in production environments is strongly discouraged. > "Applications such as the lightweight HTTP server" - I'm not sure that I understand what the requester means here. I wonder if they are talking about the HTTP server API (src/share/classes/com/sun/net/httpserver) or do they really mean the NIO sample code in src/share/sample/nio/server? -Alan. From chris.hegarty at oracle.com Thu Aug 25 08:10:09 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 25 Aug 2011 15:10:09 +0000 Subject: hg: jdk8/tl/jdk: 7044870: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10 Message-ID: <20110825151031.89A11470EC@hg.openjdk.java.net> Changeset: c9e78769c0da Author: chegar Date: 2011-08-25 16:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9e78769c0da 7044870: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10 Reviewed-by: alanb, chegar Contributed-by: kurchi.subhra.hazra at oracle.com ! test/java/nio/channels/DatagramChannel/SelectWhenRefused.java From joe.darcy at oracle.com Thu Aug 25 09:43:52 2011 From: joe.darcy at oracle.com (joe.darcy at oracle.com) Date: Thu, 25 Aug 2011 16:43:52 +0000 Subject: hg: jdk8/tl/jdk: 7082727: VirtualMachineError should declare its serialVersionUID Message-ID: <20110825164417.3BA3F470F1@hg.openjdk.java.net> Changeset: 624cc18a6cf9 Author: darcy Date: 2011-08-25 09:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/624cc18a6cf9 7082727: VirtualMachineError should declare its serialVersionUID Reviewed-by: alanb ! src/share/classes/java/lang/VirtualMachineError.java From y.s.ramakrishna at oracle.com Thu Aug 25 13:37:11 2011 From: y.s.ramakrishna at oracle.com (Ramki Ramakrishna) Date: Thu, 25 Aug 2011 13:37:11 -0700 Subject: Enabling non product flags like "Verbose" in GC Code In-Reply-To: References: Message-ID: <4E56B277.7080803@oracle.com> Hi Suraj -- Either: (1) use a non-product build where the flag is available, OR (2) rebuild with Verbose declared a product flag (but you will have to deal with develop->product contagion which will require more such changes), OR (3) (probably the easiest in a specific product build) rebuild with Verbose changed to a new product flag of your choice for the specific sites where you want to print the info but want to retain the option of turning it off. Depending on where you do this, this may also cause a develop->product contagion, but it will be a more controlled burn, if i may be allowed to mix my metaphors. (..) anything else? The above are all one-off's for use in a specific build. There may be good reason to protect some of these more useful messages with a product flag rather than with a develop flag. I recall Krystal Mok also mentioning something similar. Perhaps the community can work on what are the kinds of messages one might want to see in production (under control of a suitable manageable/product flag), and submit an OpenJDK patch with those changes (hopefully the performance impact of the check or enablement will be minor enough when these changes are for example communicating ergonomic decisions etc. -- this should of course be performance checked before a patch is submitted). I'm also hoping that in the future some of these may be captured by the logging framework under construction. Those working on or planning to work on the logging framework may hav more to add. So I am cc'ing the serviceability alias as well. -- ramki On 8/25/2011 12:58 PM, suraj puvvada wrote: > Hi, > > How can I enable DEVELOP mode flags like "Verbose" ? I'm interested in > seeing what the GC code logs - for example : > > if (PrintGCDetails && Verbose) { > gclog_or_tty->print_cr("ConcurrentMarkSweepGeneration::shrink_by:" > " desired_bytes " SIZE_FORMAT > " shrinkable_size_in_bytes " SIZE_FORMAT > " aligned_shrinkable_size_in_bytes " SIZE_FORMAT > " bytes " SIZE_FORMAT, > desired_bytes, shrinkable_size_in_bytes, > aligned_shrinkable_size_in_bytes, bytes); > gclog_or_tty->print_cr(" old_end " SIZE_FORMAT > " unallocated_start " SIZE_FORMAT, > old_end, unallocated_start); > } > > > -Suraj -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20110825/7b6e5cf9/attachment.html From suraj.puvvada at gmail.com Thu Aug 25 14:34:31 2011 From: suraj.puvvada at gmail.com (suraj puvvada) Date: Thu, 25 Aug 2011 14:34:31 -0700 Subject: Enabling non product flags like "Verbose" in GC Code In-Reply-To: <4E56B277.7080803@oracle.com> References: <4E56B277.7080803@oracle.com> Message-ID: Thanks. Are the non-product builds available online to download ? -Suraj On Thu, Aug 25, 2011 at 1:37 PM, Ramki Ramakrishna < y.s.ramakrishna at oracle.com> wrote: > ** > Hi Suraj -- > > Either: > > (1) use a non-product build where the flag is available, OR > > (2) rebuild with Verbose declared a product flag (but you will have to deal > with > develop->product contagion which will require more such changes), OR > > (3) (probably the easiest in a specific product build) rebuild with Verbose > changed to > a new product flag of your choice for the specific sites where you > want to print the info > but want to retain the option of turning it off. Depending on where > you do this, this > may also cause a develop->product contagion, but it will be a more > controlled burn, if > i may be allowed to mix my metaphors. > > (..) anything else? > > The above are all one-off's for use in a specific build. > > There may be good reason to protect some of these more useful messages with > a product > flag rather than with a develop flag. I recall Krystal Mok also mentioning > something similar. > Perhaps the community can work on what are the kinds of messages one might > want to > see in production (under control of a suitable manageable/product flag), > and submit an OpenJDK > patch with those changes (hopefully the performance impact of the check or > enablement > will be minor enough when these changes are for example communicating > ergonomic > decisions etc. -- this should of course be performance checked before a > patch is submitted). > > I'm also hoping that in the future some of these may be captured by the > logging framework > under construction. Those working on or planning to work on the logging > framework may hav > more to add. So I am cc'ing the serviceability alias as well. > > -- ramki > > > On 8/25/2011 12:58 PM, suraj puvvada wrote: > > Hi, > > How can I enable DEVELOP mode flags like "Verbose" ? I'm interested in > seeing what the GC code logs - for example : > > if (PrintGCDetails && Verbose) { > gclog_or_tty->print_cr("ConcurrentMarkSweepGeneration::shrink_by:" > " desired_bytes " SIZE_FORMAT > " shrinkable_size_in_bytes " SIZE_FORMAT > " aligned_shrinkable_size_in_bytes " SIZE_FORMAT > " bytes " SIZE_FORMAT, > desired_bytes, shrinkable_size_in_bytes, > aligned_shrinkable_size_in_bytes, bytes); > gclog_or_tty->print_cr(" old_end " SIZE_FORMAT > " unallocated_start " SIZE_FORMAT, > old_end, unallocated_start); > } > > > -Suraj > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20110825/e8acb7b0/attachment.html From y.s.ramakrishna at oracle.com Thu Aug 25 15:21:10 2011 From: y.s.ramakrishna at oracle.com (Ramki Ramakrishna) Date: Thu, 25 Aug 2011 15:21:10 -0700 Subject: Enabling non product flags like "Verbose" in GC Code In-Reply-To: References: <4E56B277.7080803@oracle.com> Message-ID: <4E56CAD6.4030007@oracle.com> i don't know about that (maybe someone on the list knows where one can download pre-built non-product binaries from), but if you are set up to build hotspot, you would use target fastdebug. -- ramki On 8/25/2011 2:34 PM, suraj puvvada wrote: > Thanks. > > Are the non-product builds available online to download ? > > -Suraj > > On Thu, Aug 25, 2011 at 1:37 PM, Ramki Ramakrishna > > wrote: > > Hi Suraj -- > > Either: > > (1) use a non-product build where the flag is available, OR > > (2) rebuild with Verbose declared a product flag (but you will > have to deal with > develop->product contagion which will require more such > changes), OR > > (3) (probably the easiest in a specific product build) rebuild > with Verbose changed to > a new product flag of your choice for the specific sites > where you want to print the info > but want to retain the option of turning it off. Depending > on where you do this, this > may also cause a develop->product contagion, but it will be > a more controlled burn, if > i may be allowed to mix my metaphors. > > (..) anything else? > > The above are all one-off's for use in a specific build. > > There may be good reason to protect some of these more useful > messages with a product > flag rather than with a develop flag. I recall Krystal Mok also > mentioning something similar. > Perhaps the community can work on what are the kinds of messages > one might want to > see in production (under control of a suitable manageable/product > flag), and submit an OpenJDK > patch with those changes (hopefully the performance impact of the > check or enablement > will be minor enough when these changes are for example > communicating ergonomic > decisions etc. -- this should of course be performance checked > before a patch is submitted). > > I'm also hoping that in the future some of these may be captured > by the logging framework > under construction. Those working on or planning to work on the > logging framework may hav > more to add. So I am cc'ing the serviceability alias as well. > > -- ramki > > > On 8/25/2011 12:58 PM, suraj puvvada wrote: >> Hi, >> >> How can I enable DEVELOP mode flags like "Verbose" ? I'm >> interested in seeing what the GC code logs - for example : >> >> if (PrintGCDetails && Verbose) { >> >> gclog_or_tty->print_cr("ConcurrentMarkSweepGeneration::shrink_by:" >> " desired_bytes " SIZE_FORMAT >> " shrinkable_size_in_bytes " SIZE_FORMAT >> " aligned_shrinkable_size_in_bytes " SIZE_FORMAT >> " bytes " SIZE_FORMAT, >> desired_bytes, shrinkable_size_in_bytes, >> aligned_shrinkable_size_in_bytes, bytes); >> gclog_or_tty->print_cr(" old_end " SIZE_FORMAT >> " unallocated_start " SIZE_FORMAT, >> old_end, unallocated_start); >> } >> >> >> -Suraj > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20110825/98ffad66/attachment-0001.html From rednaxelafx at gmail.com Thu Aug 25 22:16:25 2011 From: rednaxelafx at gmail.com (Krystal Mok) Date: Fri, 26 Aug 2011 13:16:25 +0800 Subject: Enabling non product flags like "Verbose" in GC Code In-Reply-To: <4E56CAD6.4030007@oracle.com> References: <4E56B277.7080803@oracle.com> <4E56CAD6.4030007@oracle.com> Message-ID: Comments inline below. On Fri, Aug 26, 2011 at 4:37 AM, Ramki Ramakrishna < y.s.ramakrishna at oracle.com> wrote: > Hi Suraj -- > Either: > (1) use a non-product build where the flag is available, OR > (2) rebuild with Verbose declared a product flag (but you will have to deal > with > develop->product contagion which will require more such changes), OR > (3) (probably the easiest in a specific product build) rebuild with Verbose > changed to > a new product flag of your choice for the specific sites where you > want to print the info > but want to retain the option of turning it off. Depending on where > you do this, this > may also cause a develop->product contagion, but it will be a more > controlled burn, if > i may be allowed to mix my metaphors. > (..) anything else? > The above are all one-off's for use in a specific build. Yep, these are all valid. I've tried all of them. (1) is good for those who's not interested in building a VM themselves. See below for links for downloading a fastdebug build. (2) is probably not the way one would want to go if the interest is only in a specific part of the Verbose log. Turning Verbose from develop to product almost always give you too much information, and it's hard to filter out what you really want. Not to mention there's significant overhead to turing all Verbose log on. Besides, part of the Verbose log printing is wrapped in #ifndef PRODUCT, those are often really expensive and won't show up in a product build even if Verbose is changed to a product flag. (3) is what I've been using for investigating some of our GC issues in production, It works great. But of course it's only for a specific purpose. On Fri, Aug 26, 2011 at 4:37 AM, Ramki Ramakrishna < y.s.ramakrishna at oracle.com> wrote: > There may be good reason to protect some of these more useful messages with > a product > flag rather than with a develop flag. I recall Krystal Mok also mentioning > something similar. > Perhaps the community can work on what are the kinds of messages one might > want to > see in production (under control of a suitable manageable/product flag), > and submit an OpenJDK > patch with those changes (hopefully the performance impact of the check or > enablement > will be minor enough when these changes are for example communicating > ergonomic > decisions etc. -- this should of course be performance checked before a > patch is submitted). That's right, I've been working in this direction. I've temporarily added a "PrintGCReason" production flag in my own build to print short messages of the direct cause of a collection. Not done yet. It's not as simple as just replacing some of the (PrintGCDetails && Verbose) log to using the new flag, because there are cases where a collection is triggered but no verbose log is printed. If I can get it to a point when it's mature enough, I'll submit a patch to OpenJDK for open discussion. But that'll be after our OCA issue is resolved. (The "PrintGCReason" stuff is very different from HotSpot's existing notion of "GCCause". The latter is too coarse and doesn't really provide enough diagnostics of what's going on.) I'm also experimenting on a new GC log parser that tries to parse some of the output from the fancier flags. The original parser framework in GCHisto doesn't seem to be powerful enough to do so, because it's stuck with regular expressions but I think it needs a PDA to really get the job done. Wonder how other guys are approaching this problem. On Fri, Aug 26, 2011 at 4:37 AM, Ramki Ramakrishna < y.s.ramakrishna at oracle.com> wrote: > I'm also hoping that in the future some of these may be captured by the > logging framework > under construction. Those working on or planning to work on the logging > framework may have > more to add. So I am cc'ing the serviceability alias as well. I'm really looking forward to this one. Please keep us updated on any plans of a more uniform GC log format and the accompanying logging framework. On Fri, Aug 26, 2011 at 5:34 AM, suraj puvvada wrote: > Thanks. > Are the non-product builds available online to download ? You can find some of the older builds on java.net, such as [1]. The fastdebug build for JDK 6 used to be published at [2]. But they're no longer available. They used to be removed (or hidden? I don't know) once an FCS is released, though. Making your own build of the HotSpot VM isn't hard. Charles Nutter was kind enough to share his build script recently, following something similar may be a good starting point [3]. Regards, Kris Mok [1]: http://download.java.net/jdk6/6u25/promoted/b03/binaries/ [2]: http://download.java.net/jdk6/binaries/ [3]: http://mail.openjdk.java.net/pipermail/mlvm-dev/2011-August/003775.html -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20110826/2e796b0c/attachment.html From sean.coffey at oracle.com Fri Aug 26 02:56:21 2011 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Fri, 26 Aug 2011 09:56:21 +0000 Subject: hg: jdk8/tl/jdk: 7024697: SessionRef.dispose() should determine if the token referred to by the token object is still valid Message-ID: <20110826095639.080AB47129@hg.openjdk.java.net> Changeset: 3a13b7ab57f7 Author: coffeys Date: 2011-08-26 10:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a13b7ab57f7 7024697: SessionRef.dispose() should determine if the token referred to by the token object is still valid Reviewed-by: valeriep ! src/share/classes/sun/security/pkcs11/Session.java ! src/share/classes/sun/security/pkcs11/Token.java From alan.bateman at oracle.com Fri Aug 26 14:26:13 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 26 Aug 2011 21:26:13 +0000 Subject: hg: jdk8/tl/jdk: 7060243: (dc) Multicasting tests fail on Windows XP if IPv6 is enabled Message-ID: <20110826212638.5FB2B47149@hg.openjdk.java.net> Changeset: 6d2f09eed4e3 Author: alanb Date: 2011-08-26 22:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d2f09eed4e3 7060243: (dc) Multicasting tests fail on Windows XP if IPv6 is enabled Reviewed-by: alanb Contributed-by: kurchi.subhra.hazra at oracle.com ! test/java/nio/channels/DatagramChannel/NetworkConfiguration.java From xueming.shen at oracle.com Fri Aug 26 15:25:44 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Fri, 26 Aug 2011 22:25:44 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20110826222610.C33384714C@hg.openjdk.java.net> Changeset: 973d923af88c Author: sherman Date: 2011-08-26 15:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/973d923af88c 7077769: (zipfs) ZipFileSystem.writeCEN() writes wrong "data size" for ZIP64 extended information extra field Summary: fixed the wrong size when writing out the cen table for ZIP64 Reviewed-by: alanb ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! test/java/util/zip/LargeZip.java Changeset: 9bd06beac455 Author: sherman Date: 2011-08-26 15:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bd06beac455 Merge From xuelei.fan at oracle.com Sat Aug 27 02:18:18 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Sat, 27 Aug 2011 09:18:18 +0000 Subject: hg: jdk8/tl/jdk: 7084040: Clearup warning in HttpsURLConnection Message-ID: <20110827091835.6692D47166@hg.openjdk.java.net> Changeset: e4729ad0d7b5 Author: xuelei Date: 2011-08-27 02:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4729ad0d7b5 7084040: Clearup warning in HttpsURLConnection Reviewed-by: xuelei Contributed-by: nsebastian.sickelmann at gmx.de ! src/share/classes/javax/net/ssl/HttpsURLConnection.java From alan.bateman at oracle.com Sat Aug 27 08:13:50 2011 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 27 Aug 2011 15:13:50 +0000 Subject: hg: jdk8/tl/jdk: 7060790: (fs) FileSystem.newWatchService error message confusing when maximum inotify descriptors reached Message-ID: <20110827151410.DCB4347173@hg.openjdk.java.net> Changeset: 83add4632b49 Author: alanb Date: 2011-08-27 15:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83add4632b49 7060790: (fs) FileSystem.newWatchService error message confusing when maximum inotify descriptors reached Reviewed-by: forax ! src/solaris/classes/sun/nio/fs/LinuxWatchService.java ! src/solaris/native/sun/nio/fs/genUnixConstants.c From Xuelei.Fan at Oracle.Com Sat Aug 27 17:21:29 2011 From: Xuelei.Fan at Oracle.Com (Xuelei Fan) Date: Sun, 28 Aug 2011 08:21:29 +0800 Subject: hg: jdk8/tl/jdk: 7084040: Clearup warning in HttpsURLConnection In-Reply-To: <20110827091835.6692D47166@hg.openjdk.java.net> References: <20110827091835.6692D47166@hg.openjdk.java.net> Message-ID: Sorry that there is a typo of the email address of the contributor. The mail address should be sebastian.sickelmann at gmx.de. My apologies for my mistake. Xuelei On Aug 27, 2011, at 5:18 PM, xuelei.fan at oracle.com wrote: > Changeset: e4729ad0d7b5 > Author: xuelei > Date: 2011-08-27 02:17 -0700 > URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4729ad0d7b5 > > 7084040: Clearup warning in HttpsURLConnection > Reviewed-by: xuelei > Contributed-by: nsebastian.sickelmann at gmx.de > > ! src/share/classes/javax/net/ssl/HttpsURLConnection.java > From xuelei.fan at oracle.com Mon Aug 29 05:56:22 2011 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 29 Aug 2011 12:56:22 +0000 Subject: hg: jdk8/tl/jdk: 7059542: JNDI name operations should be locale independent Message-ID: <20110829125644.4A6A5471D1@hg.openjdk.java.net> Changeset: 02c2d38f4271 Author: xuelei Date: 2011-08-29 05:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/02c2d38f4271 7059542: JNDI name operations should be locale independent Reviewed-by: weijun ! src/share/classes/com/sun/jndi/ldap/ClientId.java ! src/share/classes/com/sun/jndi/ldap/LdapClient.java ! src/share/classes/com/sun/jndi/ldap/LdapCtx.java ! src/share/classes/com/sun/jndi/ldap/LdapName.java ! src/share/classes/com/sun/jndi/ldap/LdapPoolManager.java ! src/share/classes/com/sun/jndi/toolkit/dir/HierMemDirCtx.java ! src/share/classes/com/sun/jndi/toolkit/dir/SearchFilter.java ! src/share/classes/com/sun/security/ntlm/NTLM.java ! src/share/classes/java/security/KeyRep.java ! src/share/classes/java/security/Security.java ! src/share/classes/javax/naming/NameImpl.java ! src/share/classes/javax/naming/directory/BasicAttributes.java ! src/share/classes/javax/naming/ldap/Rdn.java ! src/share/classes/sun/security/jgss/krb5/Krb5NameElement.java ! src/share/classes/sun/security/krb5/PrincipalName.java ! src/share/classes/sun/security/pkcs12/PKCS12KeyStore.java ! src/share/classes/sun/security/provider/JavaKeyStore.java ! src/share/classes/sun/security/provider/certpath/ldap/LDAPCertStore.java ! src/share/classes/sun/security/ssl/SSLSessionContextImpl.java ! src/share/classes/sun/security/tools/KeyStoreUtil.java ! src/share/classes/sun/security/util/HostnameChecker.java ! src/share/classes/sun/security/x509/DNSName.java ! src/share/classes/sun/security/x509/RFC822Name.java ! test/javax/naming/ldap/LdapName/CompareToEqualsTests.java From sean.mullan at oracle.com Mon Aug 29 10:41:27 2011 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Mon, 29 Aug 2011 17:41:27 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20110829174147.1BB9F471E4@hg.openjdk.java.net> Changeset: d1c04dac850d Author: mullan Date: 2011-08-29 12:22 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1c04dac850d 7024771: "\\<>" in attribute value part of X500Principal constructor parameter makes strange effect Reviewed-by: vinnie ! src/share/classes/sun/security/x509/AVA.java ! src/share/classes/sun/security/x509/X500Name.java + test/javax/security/auth/x500/X500Principal/Parse.java Changeset: c2b4e0ea3ab9 Author: mullan Date: 2011-08-29 12:23 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2b4e0ea3ab9 Merge ! src/share/classes/sun/security/x509/X500Name.java From weijun.wang at oracle.com Mon Aug 29 19:46:54 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Tue, 30 Aug 2011 02:46:54 +0000 Subject: hg: jdk8/tl/jdk: 7083576: add javax/xml/crypto into jdk_security2 Message-ID: <20110830024704.BF422471FA@hg.openjdk.java.net> Changeset: 6d6d75421e8a Author: weijun Date: 2011-08-30 10:46 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d6d75421e8a 7083576: add javax/xml/crypto into jdk_security2 Reviewed-by: mullan ! test/Makefile ! test/javax/xml/crypto/dsig/SecurityManager/XMLDSigWithSecMgr.java From michael.x.mcmahon at oracle.com Tue Aug 30 06:41:53 2011 From: michael.x.mcmahon at oracle.com (michael.x.mcmahon at oracle.com) Date: Tue, 30 Aug 2011 13:41:53 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20110830134225.AFE1F47215@hg.openjdk.java.net> Changeset: fe205518c3a7 Author: michaelm Date: 2011-08-30 14:40 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe205518c3a7 7084560: Crash in net.dll Reviewed-by: chegar Contributed-by: luchsh at linux.vnet.ibm.com ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface_winXP.c Changeset: ef4f24534a96 Author: michaelm Date: 2011-08-30 14:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ef4f24534a96 Merge From xueming.shen at oracle.com Tue Aug 30 11:38:05 2011 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 30 Aug 2011 18:38:05 +0000 Subject: hg: jdk8/tl/jdk: 7084245: Update usages of InternalError to use exception chaining Message-ID: <20110830183814.F1AB147230@hg.openjdk.java.net> Changeset: 8a51f0e24380 Author: sherman Date: 2011-08-30 11:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a51f0e24380 7084245: Update usages of InternalError to use exception chaining Summary: to use new InternalError constructor with cause chainning Reviewed-by: alanb, ksrini, xuelei, neugens Contributed-by: sebastian.sickelmann at gmx.de ! src/share/classes/com/sun/imageio/plugins/jpeg/JFIFMarkerSegment.java ! src/share/classes/com/sun/jmx/snmp/SnmpCounter64.java ! src/share/classes/com/sun/jmx/snmp/SnmpInt.java ! src/share/classes/com/sun/jmx/snmp/SnmpNull.java ! src/share/classes/com/sun/jmx/snmp/SnmpString.java ! src/share/classes/com/sun/jmx/snmp/daemon/SnmpRequestHandler.java ! src/share/classes/com/sun/servicetag/BrowserSupport.java ! src/share/classes/com/sun/servicetag/RegistrationDocument.java ! src/share/classes/java/awt/BufferCapabilities.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/GridBagConstraints.java ! src/share/classes/java/awt/ImageCapabilities.java ! src/share/classes/java/awt/Insets.java ! src/share/classes/java/awt/JobAttributes.java ! src/share/classes/java/awt/PageAttributes.java ! src/share/classes/java/awt/RenderingHints.java ! src/share/classes/java/awt/font/TextLayout.java ! src/share/classes/java/awt/geom/AffineTransform.java ! src/share/classes/java/awt/geom/CubicCurve2D.java ! src/share/classes/java/awt/geom/Dimension2D.java ! src/share/classes/java/awt/geom/Line2D.java ! src/share/classes/java/awt/geom/Point2D.java ! src/share/classes/java/awt/geom/QuadCurve2D.java ! src/share/classes/java/awt/geom/RectangularShape.java ! src/share/classes/java/awt/image/ImageFilter.java ! src/share/classes/java/awt/image/Kernel.java ! src/share/classes/java/io/ObjectStreamClass.java ! src/share/classes/java/lang/CharacterName.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/Invokers.java ! src/share/classes/java/lang/invoke/MemberName.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/java/lang/invoke/MethodTypeForm.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/java/rmi/dgc/VMID.java ! src/share/classes/java/security/cert/CollectionCertStoreParameters.java ! src/share/classes/java/security/cert/LDAPCertStoreParameters.java ! src/share/classes/java/security/cert/PKIXCertPathChecker.java ! src/share/classes/java/security/cert/PKIXCertPathValidatorResult.java ! src/share/classes/java/security/cert/PKIXParameters.java ! src/share/classes/java/security/cert/X509CRLSelector.java ! src/share/classes/java/security/cert/X509CertSelector.java ! src/share/classes/java/text/AttributedString.java ! src/share/classes/java/text/BreakDictionary.java ! src/share/classes/java/text/BreakIterator.java ! src/share/classes/java/text/Collator.java ! src/share/classes/java/text/DateFormatSymbols.java ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/DecimalFormatSymbols.java ! src/share/classes/java/text/DigitList.java ! src/share/classes/java/text/Format.java ! src/share/classes/java/text/RuleBasedBreakIterator.java ! src/share/classes/java/text/StringCharacterIterator.java ! src/share/classes/java/util/ArrayList.java ! src/share/classes/java/util/BitSet.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/Currency.java ! src/share/classes/java/util/HashSet.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/IdentityHashMap.java ! src/share/classes/java/util/LinkedList.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/ResourceBundle.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/TreeSet.java ! src/share/classes/java/util/UUID.java ! src/share/classes/java/util/Vector.java ! src/share/classes/java/util/zip/ZipEntry.java ! src/share/classes/javax/management/openmbean/TabularDataSupport.java ! src/share/classes/javax/swing/text/ElementIterator.java ! src/share/classes/javax/swing/text/rtf/RTFReader.java ! src/share/classes/sun/dc/DuctusRenderingEngine.java ! src/share/classes/sun/font/FontLineMetrics.java ! src/share/classes/sun/font/GlyphLayout.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! src/share/classes/sun/java2d/pipe/LoopPipe.java ! src/share/classes/sun/management/counter/perf/PerfDataEntry.java ! src/share/classes/sun/management/counter/perf/PerfDataType.java ! src/share/classes/sun/misc/Launcher.java ! src/share/classes/sun/misc/ProxyGenerator.java ! src/share/classes/sun/net/NetworkClient.java ! src/share/classes/sun/net/NetworkServer.java ! src/share/classes/sun/net/ftp/impl/FtpClient.java ! src/share/classes/sun/net/smtp/SmtpClient.java ! src/share/classes/sun/net/www/http/ChunkedOutputStream.java ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/gopher/GopherClient.java ! src/share/classes/sun/net/www/protocol/https/HttpsClient.java ! src/share/classes/sun/nio/ch/Util.java ! src/share/classes/sun/reflect/UTF8.java ! src/share/classes/sun/reflect/misc/MethodUtil.java ! src/share/classes/sun/rmi/transport/LiveRef.java ! src/share/classes/sun/security/provider/SecureRandom.java ! src/share/classes/sun/security/provider/SeedGenerator.java ! src/share/classes/sun/security/provider/certpath/ForwardState.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java ! src/share/classes/sun/security/util/SecurityConstants.java ! src/share/classes/sun/text/CompactByteArray.java ! src/share/classes/sun/text/normalizer/NormalizerBase.java ! src/share/classes/sun/tools/attach/HotSpotAttachProvider.java ! src/share/classes/sun/tools/attach/HotSpotVirtualMachine.java ! src/share/classes/sun/tools/jconsole/LocalVirtualMachine.java ! src/share/classes/sun/tools/tree/Node.java ! src/share/classes/sun/tracing/dtrace/DTraceProvider.java ! src/share/classes/sun/util/calendar/CalendarDate.java ! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java ! src/solaris/classes/sun/awt/X11/XMenuItemPeer.java ! src/solaris/classes/sun/nio/ch/InheritedChannel.java ! src/solaris/classes/sun/tools/attach/LinuxVirtualMachine.java From weijun.wang at oracle.com Tue Aug 30 18:23:32 2011 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 31 Aug 2011 01:23:32 +0000 Subject: hg: jdk8/tl/jdk: 7083664: test hard code of using c:/temp but this dir might not exist Message-ID: <20110831012342.3169047240@hg.openjdk.java.net> Changeset: f5120b47f93d Author: weijun Date: 2011-08-31 09:22 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f5120b47f93d 7083664: test hard code of using c:/temp but this dir might not exist Reviewed-by: xuelei, ohair ! test/lib/security/java.policy/Ext_AllPolicy.sh ! test/sun/security/tools/jarsigner/AlgOptions.sh ! test/sun/security/tools/jarsigner/PercentSign.sh ! test/sun/security/tools/jarsigner/diffend.sh ! test/sun/security/tools/jarsigner/oldsig.sh ! test/sun/security/tools/keytool/AltProviderPath.sh ! test/sun/security/tools/keytool/SecretKeyKS.sh ! test/sun/security/tools/keytool/StandardAlgName.sh ! test/sun/security/tools/keytool/i18n.sh ! test/sun/security/tools/keytool/resource.sh ! test/sun/security/tools/policytool/Alias.sh ! test/sun/security/tools/policytool/ChangeUI.sh ! test/sun/security/tools/policytool/OpenPolicy.sh ! test/sun/security/tools/policytool/SaveAs.sh ! test/sun/security/tools/policytool/UpdatePermissions.sh ! test/sun/security/tools/policytool/UsePolicy.sh ! test/sun/security/tools/policytool/i18n.sh From maurizio.cimadamore at oracle.com Wed Aug 31 08:16:29 2011 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 31 Aug 2011 15:16:29 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20110831151633.4F19247260@hg.openjdk.java.net> Changeset: b86277584776 Author: mcimadamore Date: 2011-08-31 16:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b86277584776 7085024: internal error; cannot instantiate Foo Summary: Types.isConvertible does not handle erroneous types correctly Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/7085024/T7085024.java + test/tools/javac/7085024/T7085024.out Changeset: d0257833498e Author: mcimadamore Date: 2011-08-31 16:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d0257833498e 7079713: javac hangs when compiling a class that references a cyclically inherited class Summary: Types.membersClosure needs to handle pathological cases of cyclic inheritance Reviewed-by: jjg, jjh ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/7079713/TestCircularClassfile.java From jonathan.gibbons at oracle.com Wed Aug 31 15:39:26 2011 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 31 Aug 2011 22:39:26 +0000 Subject: hg: jdk8/tl/langtools: 7074416: Regression: JSR199: javac doesn't unwrap clientcodewrapper objects Message-ID: <20110831223928.C51BA47275@hg.openjdk.java.net> Changeset: f85d980faaf8 Author: jjg Date: 2011-08-31 15:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f85d980faaf8 7074416: Regression: JSR199: javac doesn't unwrap clientcodewrapper objects Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java ! src/share/classes/javax/tools/JavaCompiler.java ! test/tools/javac/TryWithResources/UnusedResourcesTest.java ! test/tools/javac/diags/Example.java ! test/tools/javac/processing/errors/TestSuppression.java From chris.hegarty at oracle.com Wed Aug 31 22:45:47 2011 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Thu, 01 Sep 2011 05:45:47 +0000 Subject: hg: jdk8/tl/jdk: 7014860: Socket.getInputStream().available() not clear for shutdown input Message-ID: <20110901054606.0B82E47290@hg.openjdk.java.net> Changeset: a5a28b040714 Author: chegar Date: 2011-09-01 06:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5a28b040714 7014860: Socket.getInputStream().available() not clear for shutdown input Reviewed-by: alanb, michaelm ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/net/Socket.java ! src/share/classes/java/net/SocketImpl.java + test/java/net/Socket/ShutdownInput.java