Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR)
Dmitry Samersoff
Dmitry.Samersoff at oracle.com
Thu Aug 4 09:35:00 PDT 2011
On 2011-08-04 20:19, Daniel D. Daugherty wrote:
>
>> I looked at the webrev and it mostly looks okay to me. One issue is
>> that dbgsysPoll probably should adjust the timeout when interrupted.
>
> Adjust it how? (Just curious)
If my memory is not bogus poll could be interrupted before first request
only. So no need to adjust timeout.
We may consider to use ppoll under linux but it's a RFE ...
-Dmitry
>
>
>> A minor nit is that you've changed the copyright date on the file from
>> 1998 to 1997.
>
> Don't know how I missed that with the earlier reviews, but the
> Teamware history shows that the earliest date for this file
> is indeed in 1998 and not 1997:
>
> $ sccs prs -r1.1 src/solaris/transport/socket/socket_md.c
> src/solaris/transport/socket/SCCS/s.socket_md.c:
>
> D 1.1 98/11/21 21:20:56 gordonh 1 0 00149/00000/00000
> MRs:
> COMMENTS:
>
> Dan
>
--
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...
More information about the serviceability-dev
mailing list