Request for Review (XXL): 7104647: Adding a diagnostic command framework

[Mandy Chung]

On 12/7/2011 2:04 PM, Mandy Chung wrote:
>
> On 12/7/2011 1:30 PM, Frederic Parain wrote:
>>
>>> The execute method doesn't throw any exception other than
>>> IAE. What happens if the specified command execution fails
>>> in the target VM? If no exception is thrown, how does the
>>> caller detect if the command succeeds or not and handle it
>>> gracefully? It seems that this mechanism should provide
>>> a way to detect if a command succeeds or fails programmatically
>>> rather than burying the error message in the returned string.
>>
>> This changeset contains the framework, and the framework
>> only throws NPE or IAE. However, a diagnostic command
>> impementation is free to throw any other exception. If such
>> an exception is thrown, it is simply printed on the output
>> stream if the command has been invoked through the attachAPI,
>> or it is propagated like any other exception through JMX
>> if the command has been invoked from the HotSpotDiagnosticMXBean.
>>
>
> What happens when HotSpotDiagnosticMXBean is called locally within the 
> same process but through JMX MBeanServer?

oops.. typo.

s/but through/but not through/

the uncaught exception will cause the running JVM to crash which seems 
to be undesirable.

Mandy