Wrong package name in jsdbproc64.sh

Krystal Mok rednaxelafx at gmail.com
Wed May 4 07:33:59 PDT 2011


Hi all,

There seem to be a typo in Serviceability Agent's JSDB launcher
script, jsdbproc64.sh.
The class name "sun.jvm.hotspot.tools.soql.JSDB" is incorrectly written as
"sun.jvm.hotspot.tools.JSDB" in this script.
This script also contains a few extra Carriage Return characters at the end
of lines, which should be removed.
This is found in jdk7/jdk7/hotspot and hsx20/baseline, and in earlier
releases as well.

The 32-bit counterpart, jsdbproc.sh doesn't have these problems, nor do the
Windows versions, jsdbwindbg(64).bat.

The fix would be: (based on hsx20/baseline)
$ hg diff
diff -r f0f676c5a2c6 agent/make/jsdbproc64.sh
--- a/agent/make/jsdbproc64.sh Tue Mar 15 19:30:16 2011 -0700
+++ b/agent/make/jsdbproc64.sh Wed May 04 22:25:52 2011 +0800
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/sh

 #
 # Copyright (c) 2004, Oracle and/or its affiliates. All rights reserved.
@@ -24,7 +24,7 @@
 #
 #

-
-. `dirname $0`/saenv64.sh
-
-$SA_JAVA_CMD sun.jvm.hotspot.tools.JSDB $*
+
+. `dirname $0`/saenv64.sh
+
+$SA_JAVA_CMD sun.jvm.hotspot.tools.soql.JSDB $*

P.S. Are there any simple-to-follow guides on how one can make small
contributions to this kind of code?

Regards,
Kris Mok
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20110504/aa6f5c07/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jsdbproc64.diff
Type: application/octet-stream
Size: 474 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20110504/aa6f5c07/attachment.obj 


More information about the serviceability-dev mailing list