Request for review (JVMTI spec, small)

Jim Holmlund james.holmlund at oracle.com
Thu May 5 08:47:22 PDT 2011



On 5/5/2011 6:21 AM, Keith McGuigan wrote:
>
> It's the ™ character. (trademark, if that doesn't come through for some reason on your mail client).
>
Keith, Joe Darcy said that the current way to represent tm  in HTML is to use ™  instead of  
#8482.  Can you do  that?
- jjh

> Thanks for the review!
>
> -- 
> - Keith
>
> On May 5, 2011, at 9:17 AM, Karen Kinnear wrote:
>
>> Keith,
>>
>> Looks good. Only mismatch I found is the one David already caught.
>> In jvmti.xsl - line 1044 - what is #8482 for?
>>
>> thanks for doing this,
>> Karen
>>
>> On May 5, 2011, at 8:42 AM, Keith McGuigan wrote:
>>
>>>
>>> On May 4, 2011, at 11:18 PM, David Holmes wrote:
>>>
>>>> Hi Keith,
>>>>
>>>> Keith McGuigan said the following on 05/05/11 11:10:
>>>>> There has been a request for us to not link directly to the JVMS from the JVMTI spec 
>>>>> (especially using the old location in the java.sun.com domain, which will likely go away 
>>>>> someday).  This change removes the hyperlinks to the JVMS from the JVMTI Specification and 
>>>>> replaces it with the proper legal name and (when applicable) the chapter number referred to.  
>>>>> I would appreciate any reviews.
>>>>> Webrev: http://cr.openjdk.java.net/~kamg/7033669/webrev.00/
>>>>
>>>> There are a couple of places where you use "the <vmspec/>" and so get "the The" in the output:
>>>>
>>>> 2627             Return the stack showing the <vmspec/>
>>>> 2707         That is (using the <vmspec/> terminology):
>>>> 11409       instruction as defined in the <vmspec/>. However, some implementations
>>>
>>> Ok, I'll change these.  I was aware of this awkwardness but thought that since "The Virtual..." 
>>> was the title, that it made sense to refer to it as "the <title>", but I suppose these sentences 
>>> still work okay without the "the".  (dang I did it again!)
>>>
>>>> This one seems to refer to the wrong Chapter/Section - Constant pool should be 4.4
>>>
>>> Good catch - thanks I'll fix that.
>>>
>>> -- 
>>> - Keith
>>
>


More information about the serviceability-dev mailing list