request for review (XS)

[Daniel D. Daugherty]

On 5/11/2011 10:57 AM, Keith McGuigan wrote:
> Hello,
>
> This is a forward port of the jdk6 bugfix for 6659215:
>
> webrev: http://cr.openjdk.java.net/~kamg/6659215/webrev.00/

src/share/classes/javax/management/timer/Timer.java
    No comments; matches JDK6_10 version

test/javax/management/timer/StartTest.java
    Not really your problems since you're simply importing the
    test from JDK6_10:
        - sent variable should be "final" and maybe all caps
        - received and stopping variables should be volatile since
          I think that handleNotification() is called by a separate
          thread

    line 47: move "stopping = true" to after the sleep() call;
        that could cause spurious failures because received
        won't be incremented

    line 18: "passed" -> "past"
    line 40: "pasted" -> "past"

>
> Thanks for any review!
>
> -- 
> - Keith