request for review (XS)

Alan Bateman Alan.Bateman at oracle.com
Wed May 11 11:38:51 PDT 2011


Keith McGuigan wrote:
> Hello,
>
> This is a forward port of the jdk6 bugfix for 6659215:
>
> webrev: http://cr.openjdk.java.net/~kamg/6659215/webrev.00/
>
> Thanks for any review!
>
> -- 
> - Keith
The test needs the GPL header. Also I assume that "StartTest.java 1.1 
08/02/26" should be removed from the @test tag. 

I assume received and stopping need to be volatile as they are accessed 
in the NotificationListener.

In sendPastNotifications I assume you can use the diamond operator.

Otherwise looks okay to me.

-Alan.











More information about the serviceability-dev mailing list