code review request: 7104161: test/sun/tools/jinfo/Basic.sh fails on Ubuntu
Weijun Wang
weijun.wang at oracle.com
Thu Oct 27 02:15:07 PDT 2011
Webrev updated:
http://cr.openjdk.java.net/~weijun/7104161/webrev.01/
The isWindows check is removed. JPRT test passes on all platforms.
Thanks
Max
On 10/27/2011 04:40 PM, Alan Bateman wrote:
> On 27/10/2011 04:36, Weijun Wang wrote:
>> Hi Alan/Dan
>>
>> Please review:
>>
>> http://cr.openjdk.java.net/~weijun/7104161/webrev.00/
>>
> Thanks Max, I think this is only test that we have in the jdk repo that
> uses SA and it's good to not have it fail when non-child ptrace is
> blocked (which seems to be the out of box setting on Ubuntu now). The
> change looks fine to me, I just wonder about Windows as Poonam sorted
> out SA on that platform in jdk7 so it should work now (ie: maybe remove
> lines 49-51).
>
> -Alan.
>
More information about the serviceability-dev
mailing list