RFR: 7160924: jvmti: GetPhase returns incorrect phase before VMInit event is issued

Dmitry Samersoff Dmitry.Samersoff at oracle.com
Thu Apr 12 06:12:28 PDT 2012


Rickard,

As far as I understand the code, after your changes we will
post JVMTI event

  JvmtiExport::post_vm_initialized();

ever if later JVM aborts on some error.

I'm not sure it's a good idea because in couple of other
places we abort VM without sending the event, so
behavior of agent become inconsistent.

-Dmitry



On 2012-04-12 16:12, Rickard Bäckman wrote:
> Hi,
>
> can I get review for this small change? The issue is that if we are
> running tracing startup code inbetween setting the phase to
> JVMTI_PHASE_LIVE and posting the VMInit event.
>
> Webrev:
> http://cr.openjdk.java.net/~rbackman/7160924/webrev/
>
> CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7160924
>
> Thanks
> /R


-- 
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...


More information about the serviceability-dev mailing list