jmx-dev JDK-7120365 DiffHBTest.java fails due to ConcurrentModificationException

[shanliang]

Thanks for all comments, here is the new webrev:
    http://cr.openjdk.java.net/~sjiang/JDK-7120365/webrev.03/

Indeed, no need to have @run for the test.

Shanliang

Alan Bateman wrote:
> On 26/12/2012 15:07, shanliang wrote:
>> Yes should use a cop[y, it is a mistake to use a unmodifiable view.
>>
>> Here is the new webrev:
>>    http://cr.openjdk.java.net/~sjiang/JDK-7120365/webrev.02/
>>
>> I have added a new test to reproduce the bug in an almost sure way.
>>
>> Thanks,
>>
>> Shanliang
> Thanks for the update, the synchronization and copy looks right to me. 
> An alternative you be "if (delegateSet == null || 
> delegateSet.isEmpty()) return; " which might be a bit cleaner.
>
> I didn't study the new test very closely but I assume you should only 
> catch MalformedURLException at line 122 rather than Exception. As it's 
> a new test then I assume it should have 2012 as the date. You can 
> probably remove the @run as the defaults (compile + run) is right for 
> this test.
>
> -Alan