Review Request: 7009098: SA cannot open core file larger than 2GB

[Krystal Mok]

Hi Poonam,

Could the synopsis include the fact that this only affects Linux/x86 32-bit?
I got a bit confused when I first read the synopsis, because I've been
using SA to open core files around 4GB~5GB on Linux/x64 routinely, and it
worked.

Regards,
Kris Mok

On Thu, Feb 9, 2012 at 12:41 PM, Poonam Bajaj <poonam.bajaj at oracle.com>wrote:

>  Could I have code reviews for the following fix:
>
> 7009098: SA cannot open core file larger than 2GB
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7009098<http://monaco.sfbay.sun.com/detail.jsf?cr=7009098>
> Webrev: http://cr.openjdk.java.net/~poonam/7009098/webrev.00/
>
> Serviceability Agent on Linux is not able to open core files larger
> than 2GB. The fix is to enable the 'Large File Support' by compiling
> the libsaproc.so with -D_FILE_OFFSET_BITS=64. This is added to both
> agent/src/os/linux/Makefile (which builds SA from agent/make/) and
> make/linux/makefiles/saproc.make (which builds SA with Hotspot build).
>
> There is one more change with which SA should first load libraries
> from the path specified with SA_ALTROOT rather than loading from
> the host system.
>
>
> Thanks,
> Poonam
> --
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120209/e7b97367/attachment.html