Review Request: 7009098: SA cannot open core file larger than 2GB

[David Holmes]

On 9/02/2012 2:41 PM, Poonam Bajaj wrote:
> Could I have code reviews for the following fix:
>
> 7009098: SA cannot open core file larger than 2GB
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7009098
> Webrev: http://cr.openjdk.java.net/~poonam/7009098/webrev.00/
>
> Serviceability Agent on Linux is not able to open core files larger
> than 2GB. The fix is to enable the 'Large File Support' by compiling
> the libsaproc.so with -D_FILE_OFFSET_BITS=64. This is added to both
> agent/src/os/linux/Makefile (which builds SA from agent/make/) and
> make/linux/makefiles/saproc.make (which builds SA with Hotspot build).

This seems ok.

> There is one more change with which SA should first load libraries
> from the path specified with SA_ALTROOT rather than loading from
> the host system.

Where does this come from? It is not related to this CR. Is there 
another CR indicating the current behaviour is incorrect? Or a spec for 
it that indicates it is incorrect?

David
-----

>
> Thanks,
> Poonam
> --
>
>