Request for Review (XS): 7143760 Memory leak in GarbageCollectionNotifications

[Dmitry Samersoff]

Frederic,

GCNotificationRequest *request = getRequest();

request variable also leaks memory because it will never be deleted on
CHECK return path. Could you fix it too?

-Dmitry


On 2012-02-10 13:27, Frederic Parain wrote:
> Here's a small fix (one line) for CR 7143760  Memory leak in
> GarbageCollectionNotifications
> 
> There's a missing HandleMark at the beginning of the
> GCNotifier::sendNotificatin() method. Without this HandleMark, all
> handles used when creating GC notifications are kept alive causing a
> double leak: in the Java heap and in the thread local handle area of the
> service thread.
> 
> Here's the CR:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7143760
> (Warning, the changeset referenced in the CR is not the
> one containing the original bug).
> 
> Here's the webrev:
> http://cr.openjdk.java.net/~fparain/7143760/webrev.00/
> 
> Thanks,
> 
> Fred
> 


-- 
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...