Diagnostic command fixes

Nils Loodin nils.loodin at oracle.com
Tue Feb 14 09:33:33 PST 2012


Forgot an important point - the testing

First I ran all the testing we have for the tracing framework that makes use of these commands.
I have also debugged through with frivolous command lines to make sure we don't do anything bad, like crash.
Also I've manually tried to use all the combinations of the command line arguments I can think of that should work, and that shouldn't. 

Regards
Nils Loodin

On Feb 14, 2012, at 18:29 , Nils Loodin wrote:

> Thanks all for suggestions on improvements.
> I have an updated webrev here:
> http://cr.openjdk.java.net/~nloodin/7145243/webrev.01/
> 
> Regards
> Nils Loodin
> 
> PS: Note - Frederic Parain has graciously taken upon himself to sponsor this. Many thanks!
> 
> DS
> 
> On Feb 13, 2012, at 22:58 , Nils Loodin wrote:
> 
>> Hey all!
>> 
>> The new diagnostic command parser needs some additional specializations for time and bytes, here included.
>> Also a few fixes for crashes for some combinations of commandlines.
>> 
>> Tested by throwing a lot of different arguments on the parser, also by running the tests in sun/tools/jcmd.
>> 
>> http://cr.openjdk.java.net/~nloodin/7145243/webrev.00/
>> 
>> I would also need a sponsor to get this in..
>> 
>> Regards
>> Nils Loodin
> 



More information about the serviceability-dev mailing list