Request for code review (smallest review ever)

David Holmes david.holmes at oracle.com
Tue Feb 14 23:34:09 PST 2012


On 15/02/2012 7:20 AM, keith mcguigan wrote:
>
> Well, ok, I guess it's not the smallest code change -- I think I've
> matched this before -- but I guarantee you won't see one smaller than this!
>
> It's a one-liner (a one-character-er) to accept 0 as a successful return
> from an ioctl() call, for registering dtrace providers.
>
> http://cr.openjdk.java.net/~kamg/7145589/webrev.00/

Have to ask - why have we not noticed this before? No test coverage?

David

> --
> - Keith
>


More information about the serviceability-dev mailing list