Request for Review: 7144833 sun/tools/jcmd/jcmd-Defaults.sh failing intermittently

[Frederic Parain]

Thanks Alan,

I've fixed the indentation in the BEGIN block.

Fred

On 02/15/12 10:04 AM, Alan Bateman wrote:
> On 14/02/2012 11:01, Frederic Parain wrote:
>> This is a request for review for 7144833:
>> sun/tools/jcmd/jcmd-Defaults.sh failing intermittently
>>
>> Bug:
>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7144833
>>
>> The problem occurs when one or several lines printed by the jcmd tool
>> match several rules in the awk script checking the output. The counter
>> counting the number of lines matching the expected pattern is
>> incremented each time the line matches a rule. If the line matches
>> several rules, the counter is incremented several times. When this
>> occurs, the test at the end of the script checking that the number
>> of lines matching the pattern is equal to the number of lines of the
>> output fails.
>>
>> The proposed fix is a modification of the awk script. Each rule
>> checking a pattern now sets a variable to 1 when a match is found,
>> and the variable is added to the counter only once per line.
>>
>> Here's the Webrev:
>>
>> http://cr.openjdk.java.net/~fparain/7144833/webrev.00/
>>
>> The webrev also contains the removal of the sun/tools/jps/jps-Vvml.sh
>> test from the problem list. The test has been fixed (see CR 6986875)
>> but the test was still in the exclusion list.
> Looks good to me although you might want to check the indentation in the
> BEGIN block.
>
> Also thanks for updating the ProblemList file.
>
> -Alan

-- 
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: Frederic.Parain at Oracle.com