RFR(S): 7079093 & 7073626: cygwin problems in tests

Alan Bateman Alan.Bateman at oracle.com
Fri Feb 24 08:35:42 PST 2012


On 24/02/2012 16:12, Staffan Larsen wrote:
> Please review the following changes:
>
> webrev: http://cr.openjdk.java.net/~sla/7073626/webrev.00/ 
> <http://cr.openjdk.java.net/%7Esla/7073626/webrev.00/>
>
> This is a combo review for the following two bugs (although I will 
> push as two changes):
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7079093
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7073626
>
>
> The first problem is to recognize cygwin as a valid platform and to 
> set up the SystemRoot environment variable (which can be called 
> SYSTEMROOT) in some cases.
>
> The second problem is that some versions of cygwin (or at least some 
> installations of cygwin) will add extra newlines when cat:ing files, 
> so I remove those.
>
Looks good to me. I see you've commented out ManifestTest.sh in the 
ProblemList and I assume it can be removed completely.

-Alan

**

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120224/c783b992/attachment.html 


More information about the serviceability-dev mailing list