Request for Review: 7120511: Add diagnostic commands

[Daniel D. Daugherty]

On 1/5/12 8:19 AM, Frederic Parain wrote:
> This changeset aims to add a first set of diagnostic commands
> to the HotSpot JVM. It also includes minor modifications to
> the diagnostic command framework implementation to ease
> development of new diagnostic commands.
>
> The webrev is here:
>
> http://cr.openjdk.java.net/~fparain/7120511/webrev.00/
Thumbs up!


src/share/vm/classfile/vmSymbols.hpp
     No comments.

src/share/vm/runtime/arguments.cpp
     No comments.

src/share/vm/runtime/globals.cpp
     No comments.

src/share/vm/runtime/globals.hpp
     No comments other than thanks for adding an explicit outputStream.

src/share/vm/runtime/init.cpp
     No comments.

src/share/vm/services/attachListener.cpp
     The "out->cr()" on line 162 should follow line 160 (I think).

src/share/vm/services/diagnosticCommand.cpp
     No comments.

src/share/vm/services/diagnosticCommand.hpp
     No comments.

src/share/vm/services/diagnosticFramework.cpp
     No comments.

src/share/vm/services/diagnosticFramework.hpp
     No comments.

src/share/vm/services/management.cpp
     A comment above line 120 describing what the two boolean parameters
     to DCmdFactoryImp() mean would be helpful to the casual reader...


Dan



>
>
> Here's the list of new diagnostic commands:
>
> Thread.print
>         Print all threads with stacktraces.
>
> GC.class_histogram
>         Provides statistics about the Java heap usage
>
> GC.heap_dump
>         Generate a HPROF format dump of the Java heap
>
> GC.run_finalization
>         Call java.lang.System.runFinalization().
>
> GC.run
>         Call java.lang.System.gc().
>
> VM.uptime
>         Print VM uptime.
>
> VM.flags
>         Print VM flag options and their current values.
>
> VM.system_properties
>         Print system properties
>
> VM.command_line
>         Print the command line used to start this VM instance.
>
>
> Thanks,
>
> Fred
>