Request for Review: 7120511: Add diagnostic commands

[serguei.spitsyn at oracle.com]

Thumbs up.

Thanks,
Serguei

On 1/6/12 4:21 AM, Frederic Parain wrote:
> Thanks for the review,
>
> I've made consistent both the description strings
> and the impact strings. I've also fixed the indentation
> issue.
>
> New webrev: http://cr.openjdk.java.net/~fparain/7120511/webrev.01/
>
> Regards,
>
> Fred
>
> On 01/ 5/12 09:05 PM, serguei.spitsyn at oracle.com wrote:
>> Looks good.
>> Some minor comments.
>>
>> share/vm/services/diagnosticCommand.hpp
>>
>> Format of description() return is not consistent:
>> - Some have dot at the end, some - not.
>> - Some has an extra space.
>>
>>    72     return "Print the command line used to start this VM 
>> instance.";
>>
>>    86         return "Print system properties";
>>
>>   102     return "Print VM flag options and their current values. ";
>>
>>   166     return "Generate a HPROF format dump of the Java heap";
>>
>>   185     return "Provide statistics about the Java heap usage";
>>
>>
>> Should the impact() function result be formatted the same way as
>> description()
>> - to have or not have dot at the end ?
>>
>> The following lines are incorrectly indented:
>>
>>    85     static const char* description() {
>>    86         return "Print system properties";
>>    87     }
>>    88     static const char* impact() {
>>    89         return "Low:";
>>    90     }
>>
>>   131     static const char* description() {
>>   132         return "Call java.lang.System.gc().";
>>   133     }
>>   134     static const char* impact() {
>>   135         return "Medium: Depends on Java heap size and content";
>>   136     }
>>
>>   145     static const char* description() {
>>   146         return "Call java.lang.System.runFinalization().";
>>   147     }
>>   148     static const char* impact() {
>>   149         return "Medium: Depends on Java content";
>>   150     }
>>
>>
>> Thanks,
>> Serguei
>>
>> On 1/5/12 7:19 AM, Frederic Parain wrote:
>>> This changeset aims to add a first set of diagnostic commands
>>> to the HotSpot JVM. It also includes minor modifications to
>>> the diagnostic command framework implementation to ease
>>> development of new diagnostic commands.
>>>
>>> The webrev is here:
>>>
>>> http://cr.openjdk.java.net/~fparain/7120511/webrev.00/
>>>
>>>
>>> Here's the list of new diagnostic commands:
>>>
>>> Thread.print
>>> Print all threads with stacktraces.
>>>
>>> GC.class_histogram
>>> Provides statistics about the Java heap usage
>>>
>>> GC.heap_dump
>>> Generate a HPROF format dump of the Java heap
>>>
>>> GC.run_finalization
>>> Call java.lang.System.runFinalization().
>>>
>>> GC.run
>>> Call java.lang.System.gc().
>>>
>>> VM.uptime
>>> Print VM uptime.
>>>
>>> VM.flags
>>> Print VM flag options and their current values.
>>>
>>> VM.system_properties
>>> Print system properties
>>>
>>> VM.command_line
>>> Print the command line used to start this VM instance.
>>>
>>>
>>> Thanks,
>>>
>>> Fred
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120106/4fa85889/attachment.html