Code Review Request: 7117570: Warnings in sun.mangement.* and its subpackages

Dmitry Samersoff Dmitry.Samersoff at oracle.com
Fri Jan 13 04:43:42 PST 2012


David,

On 2012-01-13 16:00, David Holmes wrote:

> Totally disagree - that's not the way to write the exception code. If
> you have different actions then you use different catch clauses not
> instanceof:
> 
>    catch (FileNotFoundException fnfe) {
>       error(CONFIG_FILE_NOT_FOUND, fname);
>    }
>    catch (IOException ioe) {
>       error(CONFIG_FILE_OPEN_FAILED, e.getMessage());
>    }

OK. Lets it be two different catch statements ...

-Dmitry

-- 
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...


More information about the serviceability-dev mailing list