Request for Review: 7132199: sun/management/jmxremote/bootstrap/JvmstatCountersTest.java failing on all platforms

Dmitry Samersoff Dmitry.Samersoff at oracle.com
Mon Jan 30 03:23:56 PST 2012


Staffan,

1. Why we can't use System.getProperty("java.io.tmpdir") ?

2. If you decide to hardcode "/tmp" please, create a global constant for it.

-Dmitry


On 2012-01-30 14:05, Staffan Larsen wrote:
> Please review the following fix.
> 
> Webrev: http://cr.openjdk.java.net/~sla/7132199/webrev.00/
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7132199
> 
> The problem is that HotSpot will always create the .java_pid1234
> socket/door file in /tmp (see CR 7009828).
> 
> The JDK will currently look first in the current directory then in
> java.io.tmpdir. If java.io.tmpdir has the default value of /tmp this
> works, but if the user has set it to something else it doesn't. 
> 
> My fix hardcodes /tmp in LinuxVirtualMachine.java and
> SolarisVirtualMachine.java. 
> 
> The same fix will be needed in BsdVirtualMachine.java eventually.
> 
> Thanks,
> /Staffan


-- 
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...


More information about the serviceability-dev mailing list