RFR(M): 7178703: Fix handling of quoted arguments and better error messages in dcmd

[Markus Grönlund]

Staffan,

 

Changes look good. 

 

Thanks for incorporating the comments for some more context about "impact" field/method.

 

Cheers

Markus

 

From: Staffan Larsen 
Sent: den 25 juni 2012 15:50
To: hotspot-runtime-dev at openjdk.java.net; serviceability-dev serviceability-dev at openjdk.java.net
Subject: Re: RFR(M): 7178703: Fix handling of quoted arguments and better error messages in dcmd

 

Here is an updated webrev. The last one didn't compile on Solaris.

 

http://cr.openjdk.java.net/~sla/7178703/webrev.02/

 

Thanks,

/Staffan

 

On 21 jun 2012, at 13:30, Staffan Larsen wrote:





Please review the following fix to the diagnostic command framework to improve information and error messages as well as handling of quoted arguments.

 

webrev: http://cr.openjdk.java.net/~sla/7178703/webrev.01/

 

The bug hasn't been made public yet so here is the description from the bug:

----

Error messages in the dcmd parser can be improved to include information on which argument failed to parse or did not exists.

 

Dcmd parser does not handle quoted arguments correctly (fails to parse them).

----

 

A new test has been added to verify the handling of quoted arguments.

 

Thanks,

/Staffan

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120627/4367af05/attachment.html