RFR(S): 7074616: java.lang.management.ManagementFactory.getPlatformManagementInterfaces fails

[Staffan Larsen]

Looks good!

/Staffan

On 8 mar 2012, at 11:22, Frederic Parain wrote:

> Here's an updated webrev including a simple unit test:
> http://cr.openjdk.java.net/~fparain/7074616/webrev.01/
> 
> After investigation, there's a open bug related to the
> missing tests in the JCK, so the JCK will eventually
> include tests for this method.
> 
> Thanks,
> 
> Fred
> 
> On 3/2/12 1:09 PM, Frederic Parain wrote:
>> I was surprised too that this bug has not been
>> detected during testing. I can add a test for
>> this method, however, this is a public method
>> of a public class in the java.lang.management
>> package. I would expect the JCK to have a test
>> for it.
>> 
>> Fred
>> 
>> On 3/2/12 12:17 PM, David Holmes wrote:
>>> On 2/03/2012 9:07 PM, Staffan Larsen wrote:
>>>> Looks good. But should we add a test for this?
>>> 
>>> I was about to say exactly the same thing! How has this never been
>>> noticed?
>>> 
>>> David
>>> 
>>>> /Staffan
>>>> 
>>>> On 2 mar 2012, at 10:42, Frederic Parain wrote:
>>>> 
>>>>> Greetings,
>>>>> 
>>>>> A simple bug fix. The getPlatformManagementInterfaces()
>>>>> method tries to populate a TreeSet with classes that
>>>>> don't implement the Comparable interface. The return
>>>>> type of the method is Set<Class<? extends PlatformManagedObject>>,
>>>>> so no need to have a sorted collection.
>>>>> The fix replaces the use of a TreeSet with a HashSet.
>>>>> 
>>>>> The bug:
>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7074616
>>>>> 
>>>>> The webrev:
>>>>> http://cr.openjdk.java.net/~fparain/7074616/webrev.00/
>>>>> 
>>>>> Thanks,
>>>>> 
>>>>> Fred
>>>>> 
>>>>> --
>>>>> Frederic Parain - Oracle
>>>>> Grenoble Engineering Center - France
>>>>> Phone: +33 4 76 18 81 17
>>>>> Email: Frederic.Parain at Oracle.com
>>>>> 
>>>> 
>> 
> 
> -- 
> Frederic Parain - Oracle
> Grenoble Engineering Center - France
> Phone: +33 4 76 18 81 17
> Email: Frederic.Parain at oracle.com
>