RFR: 7154113: jcmd, jps and jstat tests failing when there are unknown Java processes on the system

[Staffan Larsen]

On 20 mar 2012, at 11:57, Dmitry Samersoff wrote:

> Staffan,
> 
> 1.
> 
> test/sun/tools/jstatd/jstatdServerName.sh:89
> 
> echo output not changed.

I'll fix this.

> 2. AWK patterns has extra space
>    /^[0-9]+ $/
>   is it intentional? Is this space always here?

Yes, the space is always there.

Thanks,
/Staffan

> 
> Otherwise looks good.
> 
> -Dmitry
> 
> 
> 
> On 2012-03-20 14:37, Staffan Larsen wrote:
>> I'd love to get another review of this by a Reviewer. Someone, please?
>> 
>> Thanks,
>> /Staffan
>> 
>> On 16 mar 2012, at 09:25, Rickard Bäckman wrote:
>> 
>>> Staffan,
>>> 
>>> nice fixes, looks good to me.
>>> 
>>> /R
>>> 
>>> On Mar 16, 2012, at 9:10 AM, Staffan Larsen wrote:
>>> 
>>>> Please review the following test fixes.
>>>> 
>>>> Webrev: http://cr.openjdk.java.net/~sla/7154114/webrev.01/
>>>> 
>>>> The bugs are not available on the public server yet, but below is the
>>>> text of the bugs. I intend to submit both fixes as one push.
>>>> 
>>>> Fixes have been verified in JPRT.
>>>> 
>>>> Thanks,
>>>> /Staffan
>>>> 
>>>> 
>>>> ---------
>>>> 7154113: jcmd, jps and jstat tests failing when there are unknown
>>>> Java processes on the system
>>>> 
>>>> Some tests in sun/tools/{jcmd,jps,jstat,jstatd} fails when there are
>>>> Java processes in the system for which we cannot determine the main
>>>> class.
>>>> 
>>>> These processes show up in jps and jcmd as just the pid, no name.
>>>> This can happen if processes uses custom launchers or if they are
>>>> launched with other JVMs.
>>>> 
>>>> The tests should handle this gracefully.
>>>> ---------
>>>> 
>>>> ---------
>>>> 7154114: jstat tests failing on non-english locales
>>>> 
>>>> Some tests in sun/tools/{jstat,jstatd} fails when running on a
>>>> non-english locale. Output from jstat has , instead of . as decimal
>>>> delimiter on a swedish locale.
>>>> --------
>>> 
>> 
> 
> 
> -- 
> Dmitry Samersoff
> Java Hotspot development team, SPB04
> * There will come soft rains ...