From alan.bateman at oracle.com Tue May 1 03:19:40 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 01 May 2012 10:19:40 +0000 Subject: hg: jdk8/tl/jdk: 7164570: (fs) WatchService queues CREATE event but not DELETE event for very short lived files [sol11] Message-ID: <20120501102003.7E06F470B3@hg.openjdk.java.net> Changeset: c22b2f9066dd Author: alanb Date: 2012-05-01 11:17 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c22b2f9066dd 7164570: (fs) WatchService queues CREATE event but not DELETE event for very short lived files [sol11] Reviewed-by: chegar ! src/solaris/classes/sun/nio/fs/SolarisWatchService.java + test/java/nio/file/WatchService/MayFlies.java From xuelei.fan at oracle.com Tue May 1 03:53:55 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Tue, 01 May 2012 10:53:55 +0000 Subject: hg: jdk8/tl/jdk: 7158688: Typo in SSLContext Spec Message-ID: <20120501105406.79860470B4@hg.openjdk.java.net> Changeset: 71fdf32fdc65 Author: xuelei Date: 2012-05-01 03:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71fdf32fdc65 7158688: Typo in SSLContext Spec Reviewed-by: weijun, wetmore ! src/share/classes/javax/net/ssl/SSLContext.java From lana.steuck at oracle.com Tue May 1 11:44:05 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 01 May 2012 18:44:05 +0000 Subject: hg: jdk8/tl: Added tag jdk8-b36 for changeset 6a6ba0a07f33 Message-ID: <20120501184406.02FD6470BA@hg.openjdk.java.net> Changeset: 47aa0ddc9126 Author: katleman Date: 2012-04-26 14:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/47aa0ddc9126 Added tag jdk8-b36 for changeset 6a6ba0a07f33 ! .hgtags From lana.steuck at oracle.com Tue May 1 11:44:07 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 01 May 2012 18:44:07 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20120501184410.489D0470BB@hg.openjdk.java.net> Changeset: 83fac66442cf Author: katleman Date: 2012-04-26 14:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/83fac66442cf Added tag jdk8-b36 for changeset a5a61f259961 ! .hgtags Changeset: 4a653e435441 Author: lana Date: 2012-05-01 11:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/4a653e435441 Merge From lana.steuck at oracle.com Tue May 1 11:44:09 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 01 May 2012 18:44:09 +0000 Subject: hg: jdk8/tl/jaxws: Added tag jdk8-b36 for changeset 89b36c658e39 Message-ID: <20120501184414.AD2B9470BC@hg.openjdk.java.net> Changeset: b05a948db1b6 Author: katleman Date: 2012-04-26 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/b05a948db1b6 Added tag jdk8-b36 for changeset 89b36c658e39 ! .hgtags From lana.steuck at oracle.com Tue May 1 11:44:10 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 01 May 2012 18:44:10 +0000 Subject: hg: jdk8/tl/hotspot: Added tag jdk8-b36 for changeset 50b4400ca1ec Message-ID: <20120501184416.9C575470BD@hg.openjdk.java.net> Changeset: bfcf92bfefb8 Author: katleman Date: 2012-04-26 14:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bfcf92bfefb8 Added tag jdk8-b36 for changeset 50b4400ca1ec ! .hgtags From lana.steuck at oracle.com Tue May 1 11:44:11 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 01 May 2012 18:44:11 +0000 Subject: hg: jdk8/tl/jaxp: Added tag jdk8-b36 for changeset cfd288fe1d3e Message-ID: <20120501184416.9FA7C470BE@hg.openjdk.java.net> Changeset: c388369cf4da Author: katleman Date: 2012-04-26 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c388369cf4da Added tag jdk8-b36 for changeset cfd288fe1d3e ! .hgtags From lana.steuck at oracle.com Tue May 1 11:44:14 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 01 May 2012 18:44:14 +0000 Subject: hg: jdk8/tl/langtools: Added tag jdk8-b36 for changeset 94bbaa67686f Message-ID: <20120501184417.45665470C1@hg.openjdk.java.net> Changeset: 5891b38985e8 Author: katleman Date: 2012-04-26 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5891b38985e8 Added tag jdk8-b36 for changeset 94bbaa67686f ! .hgtags From lana.steuck at oracle.com Tue May 1 11:44:17 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 01 May 2012 18:44:17 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20120501184444.65216470C2@hg.openjdk.java.net> Changeset: 9e82ac15ab80 Author: katleman Date: 2012-04-26 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e82ac15ab80 Added tag jdk8-b36 for changeset 45da9cb055ee ! .hgtags Changeset: 6c9c3d7ce9e2 Author: lana Date: 2012-05-01 11:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6c9c3d7ce9e2 Merge From mandy.chung at oracle.com Tue May 1 19:47:40 2012 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 02 May 2012 02:47:40 +0000 Subject: hg: jdk8/tl/jdk: 7164376: Replace use of sun.security.action.LoadLibraryAction with System.loadLibrary Message-ID: <20120502024757.A5CE9470D8@hg.openjdk.java.net> Changeset: 46e0bd218fcc Author: mchung Date: 2012-05-01 19:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46e0bd218fcc 7164376: Replace use of sun.security.action.LoadLibraryAction with System.loadLibrary Reviewed-by: alanb, mullan, prr ! src/macosx/classes/apple/launcher/JavaAppLauncher.java ! src/macosx/classes/apple/security/KeychainStore.java ! src/macosx/classes/com/apple/concurrent/LibDispatchNative.java ! src/macosx/classes/com/apple/eawt/Application.java ! src/macosx/classes/com/apple/eio/FileManager.java ! src/macosx/classes/com/apple/laf/AquaFileView.java ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/com/apple/laf/AquaNativeResources.java ! src/macosx/classes/com/apple/laf/ScreenMenu.java ! src/macosx/classes/com/apple/laf/ScreenPopupFactory.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java ! src/macosx/classes/sun/awt/CGraphicsEnvironment.java ! src/macosx/classes/sun/lwawt/macosx/CAccessibility.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java ! src/share/classes/java/awt/SplashScreen.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/event/NativeLibLoader.java ! src/share/classes/java/awt/image/ColorModel.java ! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/net/DatagramPacket.java ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/net/NetworkInterface.java ! src/share/classes/sun/awt/NativeLibLoader.java ! src/share/classes/sun/awt/image/JPEGImageDecoder.java ! src/share/classes/sun/awt/image/NativeLibLoader.java ! src/share/classes/sun/java2d/Disposer.java ! src/share/classes/sun/management/ManagementFactoryHelper.java ! src/share/classes/sun/net/sdp/SdpSupport.java ! src/share/classes/sun/net/spi/DefaultProxySelector.java ! src/share/classes/sun/nio/ch/Util.java - src/share/classes/sun/security/action/LoadLibraryAction.java ! src/share/classes/sun/security/krb5/SCDynamicStoreConfig.java ! src/share/classes/sun/security/smartcardio/PCSC.java ! src/share/classes/sun/tracing/dtrace/JVM.java ! src/solaris/classes/sun/management/FileSystemImpl.java ! src/solaris/classes/sun/net/dns/ResolverConfigurationImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpChannelImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java ! src/solaris/classes/sun/print/CUPSPrinter.java ! src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/classes/sun/management/FileSystemImpl.java ! src/windows/classes/sun/net/dns/ResolverConfigurationImpl.java ! src/windows/classes/sun/print/Win32PrintServiceLookup.java ! src/windows/classes/sun/security/smartcardio/PlatformPCSC.java From Alan.Bateman at oracle.com Wed May 2 01:36:37 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 02 May 2012 09:36:37 +0100 Subject: Request for Review: 7165722 invalid path in MemoryMonitor demo's README.txt In-Reply-To: <4FA0F004.3090407@linux.vnet.ibm.com> References: <4FA0F004.3090407@linux.vnet.ibm.com> Message-ID: <4FA0F215.2040605@oracle.com> On 02/05/2012 09:27, Jonathan Lu wrote: > Hi build-dev, > > I've got a minor change to fix an invalid path from README.txt of > MemoryMonitor demo, could anybody please help to take a look? > > http://cr.openjdk.java.net/~luchsh/7165722/ > > Best regards! > - Jonathan > 7165722 was submitted as an incident and I've moved it to the right place. Also cc'ing serviceability-dev as that is where these java.lang.management demos came from. The patch looks fine and I assume Charles will push it for you. -Alan. From nils.loodin at oracle.com Wed May 2 02:38:16 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Wed, 2 May 2012 11:38:16 +0200 Subject: RFR: 7165755 OS Information much longer on linux than other platforms Message-ID: When looking at the info from os::print_os_info() in src/os/linux/vm/os_linux.cpp:2024 (and other files for other platforms) the length of the text is radically longer for linux than other platforms. This can make it hard for tool writers to get a summary that look good and similar for multiple platforms (sizing of gui fields, having to parse info in the tool code etc) Lookin at the code, it's in some serious need of refactoring. It would be nice with a method to get a "brief" os info for these kinds of tools that looks similar on all platforms. This is my suggested change: http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ Regards, Nils Loodin From david.holmes at oracle.com Wed May 2 03:18:13 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 02 May 2012 20:18:13 +1000 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: References: Message-ID: <4FA109E5.2020309@oracle.com> Hi Nils, On 2/05/2012 7:38 PM, Nils Loodin wrote: > When looking at the info from os::print_os_info() in > src/os/linux/vm/os_linux.cpp:2024 (and other files for other platforms) > the length of the text is radically longer for linux than other platforms. Ignoring Windows (with prints very little) I'd say it is the printing of /proc/meminfo that is the main difference. Not sure why printing that was necessary ... but if we are going to remove it I think we need to know why it was added. > This can make it hard for tool writers to get a summary that look good and similar for multiple platforms (sizing of gui fields, having to parse info in the tool code etc) > Lookin at the code, it's in some serious need of refactoring. It would be nice with a method to get a "brief" os info for these kinds of tools that looks similar on all platforms. > > This is my suggested change: > http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ Seems to me some of this could be factored into the top-level OS class if we shoehorn Windows into the same shape as the other OSes ;-) Or at least perhaps put some of the common stuff into os_posix.cpp ? Cheers, David > Regards, > Nils Loodin From nils.loodin at oracle.com Wed May 2 04:56:26 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Wed, 2 May 2012 13:56:26 +0200 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: <4FA109E5.2020309@oracle.com> References: <4FA109E5.2020309@oracle.com> Message-ID: Hey David! > Ignoring Windows (with prints very little) I'd say it is the printing of /proc/meminfo that is the main difference. Not sure why printing that was necessary ... but if we are going to remove it I think we need to know why it was added. Yes, that's the reason. Note that nothing is removed. The method still prints exactly the same info, but I introduced another method to print briefer info, to be kinder to tool developers. I really don't want to change the output for say, hs_err files, where I believe this info is used. > >> This can make it hard for tool writers to get a summary that look good and similar for multiple platforms (sizing of gui fields, having to parse info in the tool code etc) >> Lookin at the code, it's in some serious need of refactoring. It would be nice with a method to get a "brief" os info for these kinds of tools that looks similar on all platforms. >> >> This is my suggested change: >> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ > > Seems to me some of this could be factored into the top-level OS class if we shoehorn Windows into the same shape as the other OSes ;-) This was my first attempt also, but then a lot of empty windows-methods ensued, which was kind of ugly. > Or at least perhaps put some of the common stuff into os_posix.cpp ? There's a thought! I'll investigate that route, it could get things to look nicer. > Cheers, > David Regards, Nils Loodin From david.holmes at oracle.com Wed May 2 05:00:56 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 02 May 2012 22:00:56 +1000 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: References: <4FA109E5.2020309@oracle.com> Message-ID: <4FA121F8.3080008@oracle.com> Hi Nils, On 2/05/2012 9:56 PM, Nils Loodin wrote: >> Ignoring Windows (with prints very little) I'd say it is the printing of /proc/meminfo that is the main difference. Not sure why printing that was necessary ... but if we are going to remove it I think we need to know why it was added. > Yes, that's the reason. > Note that nothing is removed. The method still prints exactly the same info, but I introduced another method to print briefer info, to be kinder to tool developers. The current one prints /proc/meminfo. You turned that code into print_full_memory_info but in the main routine you call print_memory_info. Was that a mistake? David > I really don't want to change the output for say, hs_err files, where I believe this info is used. > >> >>> This can make it hard for tool writers to get a summary that look good and similar for multiple platforms (sizing of gui fields, having to parse info in the tool code etc) >>> Lookin at the code, it's in some serious need of refactoring. It would be nice with a method to get a "brief" os info for these kinds of tools that looks similar on all platforms. >>> >>> This is my suggested change: >>> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ >> >> Seems to me some of this could be factored into the top-level OS class if we shoehorn Windows into the same shape as the other OSes ;-) > This was my first attempt also, but then a lot of empty windows-methods ensued, which was kind of ugly. > >> Or at least perhaps put some of the common stuff into os_posix.cpp ? > There's a thought! > I'll investigate that route, it could get things to look nicer. > > >> Cheers, >> David > Regards, > Nils Loodin > From nils.loodin at oracle.com Wed May 2 05:08:10 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Wed, 2 May 2012 14:08:10 +0200 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: <4FA121F8.3080008@oracle.com> References: <4FA109E5.2020309@oracle.com> <4FA121F8.3080008@oracle.com> Message-ID: <8372B427-9B5F-4DE0-88A7-10025623B257@oracle.com> On May 2, 2012, at 14:00 , David Holmes wrote: > Hi Nils, > > On 2/05/2012 9:56 PM, Nils Loodin wrote: >>> Ignoring Windows (with prints very little) I'd say it is the printing of /proc/meminfo that is the main difference. Not sure why printing that was necessary ... but if we are going to remove it I think we need to know why it was added. >> Yes, that's the reason. >> Note that nothing is removed. The method still prints exactly the same info, but I introduced another method to print briefer info, to be kinder to tool developers. > > The current one prints /proc/meminfo. You turned that code into print_full_memory_info but in the main routine you call print_memory_info. Was that a mistake? YES! Glad you caught that :) Guess (or hope) it would have been caught in dump testing otherwise :) Regards, Nils Loodin > > David > >> I really don't want to change the output for say, hs_err files, where I believe this info is used. >> >>> >>>> This can make it hard for tool writers to get a summary that look good and similar for multiple platforms (sizing of gui fields, having to parse info in the tool code etc) >>>> Lookin at the code, it's in some serious need of refactoring. It would be nice with a method to get a "brief" os info for these kinds of tools that looks similar on all platforms. >>>> >>>> This is my suggested change: >>>> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ >>> >>> Seems to me some of this could be factored into the top-level OS class if we shoehorn Windows into the same shape as the other OSes ;-) >> This was my first attempt also, but then a lot of empty windows-methods ensued, which was kind of ugly. >> >>> Or at least perhaps put some of the common stuff into os_posix.cpp ? >> There's a thought! >> I'll investigate that route, it could get things to look nicer. >> >> >>> Cheers, >>> David >> Regards, >> Nils Loodin >> From vincent.x.ryan at oracle.com Wed May 2 06:51:19 2012 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Wed, 02 May 2012 13:51:19 +0000 Subject: hg: jdk8/tl/jdk: 7087021: TEST: com/sun/crypto/provider/Mac/MacClone.java failed on Solaris sparc 5.10 Message-ID: <20120502135137.7263B470E8@hg.openjdk.java.net> Changeset: d78c6095dc98 Author: vinnie Date: 2012-05-02 14:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d78c6095dc98 7087021: TEST: com/sun/crypto/provider/Mac/MacClone.java failed on Solaris sparc 5.10 Reviewed-by: mullan ! test/com/sun/crypto/provider/Mac/MacClone.java From mandy.chung at oracle.com Wed May 2 11:30:30 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 02 May 2012 11:30:30 -0700 Subject: Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction In-Reply-To: <4FA1783C.7030809@oracle.com> References: <4F9998CF.9000308@oracle.com> <4FA1783C.7030809@oracle.com> Message-ID: <4FA17D46.1070805@oracle.com> On 5/2/2012 11:09 AM, Artem Ananiev wrote: > Hi, Mandy, > > the client part of the fix looks fine. Thanks for the review. I have pushed the changeset and hope you don't mind I couldn't fix the changeset comment to add you as a reviewer. > Let me ask a naive question, though. > > From your explanation, I see that System.loadLibrary() is now aware of > modules. What prevents us to change LoadLibraryAction the same way? > "FROM" code looks much more elegant than the new (the old?) "TO" one. > I would say the old code is little compact than the new one and both versions look elegant to me. The fix here is to get the caller of System.loadLibrary be in the same class loader as the native library being loaded (see ClassLoader.findLibrary). Another alternative is that each component can have its own copy of LoadLibraryAction (e.g. sun.awt.LoadLibraryAction) and so you can modify the old code like this: java.security.AccessController.doPrivileged(new sun.awt.LoadLibraryAction("awt")); provided that sun.awt.LoadLibraryAction is loaded by the same class loader with whom awt.dll is associated. Adding one copy of this simple LoadLibraryAction utility class for each component seems overkill and also error-prone e.g. refactoring a module into two modules require adding another copy of this per-module utility class if both have native libraries. This is certainly an option if the component team prefers to use the utility class. Mandy > Thanks, > > Artem > > On 4/26/2012 10:49 PM, Mandy Chung wrote: >> 7164376 Replace use of sun.security.action.LoadLibraryAction >> with direct call of System.loadLibrary >> >> Webrev: >> http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7164376/webrev.00/ >> >> This change is required for jdk modularization. High level summary: >> it replaces the use of LoadLibraryAction: >> >> FROM: >> java.security.AccessController.doPrivileged(new >> LoadLibraryAction("net")); >> >> TO: >> AccessController.doPrivileged( >> new java.security.PrivilegedAction() { >> public Void run() { >> System.loadLibrary("net"); >> return null; >> } >> }); >> >> It touches files in awt, security and serviceability area (cc'ed). >> For this type of simple change, I think 1-2 reviewers can >> review all files (simpler to review jdk.patch) and no need >> for all teams to do the reviews. >> >> System.loadLibrary and Runtime.loadLibrary loads a system library of the >> given >> library name that requires RuntimePermission("loadLibrary."+lib) >> permission. >> Many places in the JDK code loading a system native library is using the >> sun.security.action.LoadLibraryAction convenient class that will load >> the >> system library as a privileged action: >> java.security.AccessController.doPrivileged(new >> LoadLibraryAction("net")); >> >> The search path of native libraries are coupled with an associated class >> loader. >> For example, the application class loader uses the path specified in the >> "java.library.path" system property for native library lookup. The >> loadLibrary >> implementation uses the caller's class loader for finding the native >> library being >> requested. For system libraries, the class loader is null and the system >> library >> lookup is handled as a special case. When the >> sun.security.action.LoadLibraryAction >> class is used that is the caller of System.loadLibrary, the caller's >> class loader >> in this case is "null" loader and thus it always finds the native >> library from >> the system library path. >> >> In a modular world, JDK modules may be loaded by multiple different >> module class >> loader. The following code would not work if it is expected to load a >> native >> library from a module which is not the module where the >> sun.security.action.LoadLibraryAction lives. >> >> For example, the management module is trying to load libmanagement.so. >> Calling >> the following will fail to find libmanagement.so because the caller of >> System.loadLibrary is the LoadLibraryAction which is in the base module >> and search the library from the base module only. To prepare for jdk >> modularization, the use of LoadLibraryAction should be replaced with >> a direct call of System.loadLibrary. >> >> This patch also removes sun.security.action.LoadLibraryAction >> class to avoid regression. >> >> Thanks >> Mandy >> From alan.bateman at oracle.com Wed May 2 12:15:24 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 02 May 2012 19:15:24 +0000 Subject: hg: jdk8/tl/jdk: 7165102: Only run assertion on Integer autoboxing cache size once Message-ID: <20120502191548.7B127470F1@hg.openjdk.java.net> Changeset: bb2cefc89bc0 Author: forax Date: 2012-05-02 20:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb2cefc89bc0 7165102: Only run assertion on Integer autoboxing cache size once Reviewed-by: darcy, alanb ! src/share/classes/java/lang/Integer.java From alan.bateman at oracle.com Wed May 2 13:47:22 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 02 May 2012 20:47:22 +0000 Subject: hg: jdk8/tl/jdk: 7160714: Strange or obsolete @see tags in some exception java.util javadoc Message-ID: <20120502204733.6B314470F7@hg.openjdk.java.net> Changeset: 531ebfd8eb65 Author: jgish Date: 2012-05-02 21:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/531ebfd8eb65 7160714: Strange or obsolete @see tags in some exception java.util javadoc Reviewed-by: mduigou, dholmes, alanb ! src/share/classes/java/util/NoSuchElementException.java From rickard.backman at oracle.com Thu May 3 02:39:09 2012 From: rickard.backman at oracle.com (=?UTF-8?B?Umlja2FyZCBCw6Rja21hbg==?=) Date: Thu, 03 May 2012 11:39:09 +0200 Subject: RFR: 7161732: Improve handling of thread_id in OSThread Message-ID: <4FA2523D.6000106@oracle.com> Hi all, I've made a refactoring of thread_id in OSThread, which reduces the amount of duplicated code. Please review this change at: http://cr.openjdk.java.net/~rbackman/7161732/webrev/ Thanks /R From mikael.vidstedt at oracle.com Thu May 3 05:00:51 2012 From: mikael.vidstedt at oracle.com (Mikael Vidstedt) Date: Thu, 03 May 2012 14:00:51 +0200 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: <8372B427-9B5F-4DE0-88A7-10025623B257@oracle.com> References: <4FA109E5.2020309@oracle.com> <4FA121F8.3080008@oracle.com> <8372B427-9B5F-4DE0-88A7-10025623B257@oracle.com> Message-ID: <4FA27373.4090909@oracle.com> Does anybody know if there are any tests that verify the actual contents of the dump? /Mikael On 2012-05-02 14:08, Nils Loodin wrote: > On May 2, 2012, at 14:00 , David Holmes wrote: > >> Hi Nils, >> >> On 2/05/2012 9:56 PM, Nils Loodin wrote: >>>> Ignoring Windows (with prints very little) I'd say it is the printing of /proc/meminfo that is the main difference. Not sure why printing that was necessary ... but if we are going to remove it I think we need to know why it was added. >>> Yes, that's the reason. >>> Note that nothing is removed. The method still prints exactly the same info, but I introduced another method to print briefer info, to be kinder to tool developers. >> The current one prints /proc/meminfo. You turned that code into print_full_memory_info but in the main routine you call print_memory_info. Was that a mistake? > YES! Glad you caught that :) Guess (or hope) it would have been caught in dump testing otherwise :) > > Regards, > Nils Loodin > > >> David >> >>> I really don't want to change the output for say, hs_err files, where I believe this info is used. >>> >>>>> This can make it hard for tool writers to get a summary that look good and similar for multiple platforms (sizing of gui fields, having to parse info in the tool code etc) >>>>> Lookin at the code, it's in some serious need of refactoring. It would be nice with a method to get a "brief" os info for these kinds of tools that looks similar on all platforms. >>>>> >>>>> This is my suggested change: >>>>> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ >>>> Seems to me some of this could be factored into the top-level OS class if we shoehorn Windows into the same shape as the other OSes ;-) >>> This was my first attempt also, but then a lot of empty windows-methods ensued, which was kind of ugly. >>> >>>> Or at least perhaps put some of the common stuff into os_posix.cpp ? >>> There's a thought! >>> I'll investigate that route, it could get things to look nicer. >>> >>> >>>> Cheers, >>>> David >>> Regards, >>> Nils Loodin >>> From nils.loodin at oracle.com Fri May 4 01:26:50 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Fri, 4 May 2012 10:26:50 +0200 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: <8372B427-9B5F-4DE0-88A7-10025623B257@oracle.com> References: <4FA109E5.2020309@oracle.com> <4FA121F8.3080008@oracle.com> <8372B427-9B5F-4DE0-88A7-10025623B257@oracle.com> Message-ID: <35EE9EE2-C0CA-4A04-A91B-0B54C5923C6A@oracle.com> Updated this with pulling out some shared code to os_posix.cpp. Some methods were different enough that this wasn't possible though. Do you like this better? Webrev: http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ On May 2, 2012, at 14:08 , Nils Loodin wrote: > > On May 2, 2012, at 14:00 , David Holmes wrote: > >> Hi Nils, >> >> On 2/05/2012 9:56 PM, Nils Loodin wrote: >>>> Ignoring Windows (with prints very little) I'd say it is the printing of /proc/meminfo that is the main difference. Not sure why printing that was necessary ... but if we are going to remove it I think we need to know why it was added. >>> Yes, that's the reason. >>> Note that nothing is removed. The method still prints exactly the same info, but I introduced another method to print briefer info, to be kinder to tool developers. >> >> The current one prints /proc/meminfo. You turned that code into print_full_memory_info but in the main routine you call print_memory_info. Was that a mistake? > > YES! Glad you caught that :) Guess (or hope) it would have been caught in dump testing otherwise :) > > Regards, > Nils Loodin > > >> >> David >> >>> I really don't want to change the output for say, hs_err files, where I believe this info is used. >>> >>>> >>>>> This can make it hard for tool writers to get a summary that look good and similar for multiple platforms (sizing of gui fields, having to parse info in the tool code etc) >>>>> Lookin at the code, it's in some serious need of refactoring. It would be nice with a method to get a "brief" os info for these kinds of tools that looks similar on all platforms. >>>>> >>>>> This is my suggested change: >>>>> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ >>>> >>>> Seems to me some of this could be factored into the top-level OS class if we shoehorn Windows into the same shape as the other OSes ;-) >>> This was my first attempt also, but then a lot of empty windows-methods ensued, which was kind of ugly. >>> >>>> Or at least perhaps put some of the common stuff into os_posix.cpp ? >>> There's a thought! >>> I'll investigate that route, it could get things to look nicer. >>> >>> >>>> Cheers, >>>> David >>> Regards, >>> Nils Loodin >>> > From nils.loodin at oracle.com Fri May 4 02:28:11 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Fri, 4 May 2012 11:28:11 +0200 Subject: RFR - BUG7163117: SA Agent can't connect to process on Mac OSX Message-ID: <6492C401-0DC1-466C-8747-C27444408CDF@oracle.com> looking for cpu-arch "amd64" only, and not "x86_64" as mac osx is using nowadays. http://cr.openjdk.java.net/~nloodin/7163117/webrev.00/ Need reviews and a sponsor! Regards, Nils Loodin From Dmitry.Samersoff at oracle.com Fri May 4 02:41:43 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Fri, 04 May 2012 13:41:43 +0400 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: <35EE9EE2-C0CA-4A04-A91B-0B54C5923C6A@oracle.com> References: <4FA109E5.2020309@oracle.com> <4FA121F8.3080008@oracle.com> <8372B427-9B5F-4DE0-88A7-10025623B257@oracle.com> <35EE9EE2-C0CA-4A04-A91B-0B54C5923C6A@oracle.com> Message-ID: <4FA3A457.8070700@oracle.com> Nils, os_bsd.cpp: 2359: // Print warning if unsafe chroot environment detected constant below is unstable_chroot_error 2373: Never heard about neither about /etc/XXX-release on BSD nor about mandrake or redhat bsd. Please fix it as well. 2409: st->print(os::Bsd::glibc_version()) glibc_version() looks a little bit weird as none of BSD has glibc. -Dmitry On 2012-05-04 12:26, Nils Loodin wrote: > Updated this with pulling out some shared code to os_posix.cpp. > Some methods were different enough that this wasn't possible though. > > Do you like this better? > > Webrev: > http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ > > On May 2, 2012, at 14:08 , Nils Loodin wrote: > >> >> On May 2, 2012, at 14:00 , David Holmes wrote: >> >>> Hi Nils, >>> >>> On 2/05/2012 9:56 PM, Nils Loodin wrote: >>>>> Ignoring Windows (with prints very little) I'd say it is the printing of /proc/meminfo that is the main difference. Not sure why printing that was necessary ... but if we are going to remove it I think we need to know why it was added. >>>> Yes, that's the reason. >>>> Note that nothing is removed. The method still prints exactly the same info, but I introduced another method to print briefer info, to be kinder to tool developers. >>> >>> The current one prints /proc/meminfo. You turned that code into print_full_memory_info but in the main routine you call print_memory_info. Was that a mistake? >> >> YES! Glad you caught that :) Guess (or hope) it would have been caught in dump testing otherwise :) >> >> Regards, >> Nils Loodin >> >> >>> >>> David >>> >>>> I really don't want to change the output for say, hs_err files, where I believe this info is used. >>>> >>>>> >>>>>> This can make it hard for tool writers to get a summary that look good and similar for multiple platforms (sizing of gui fields, having to parse info in the tool code etc) >>>>>> Lookin at the code, it's in some serious need of refactoring. It would be nice with a method to get a "brief" os info for these kinds of tools that looks similar on all platforms. >>>>>> >>>>>> This is my suggested change: >>>>>> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ >>>>> >>>>> Seems to me some of this could be factored into the top-level OS class if we shoehorn Windows into the same shape as the other OSes ;-) >>>> This was my first attempt also, but then a lot of empty windows-methods ensued, which was kind of ugly. >>>> >>>>> Or at least perhaps put some of the common stuff into os_posix.cpp ? >>>> There's a thought! >>>> I'll investigate that route, it could get things to look nicer. >>>> >>>> >>>>> Cheers, >>>>> David >>>> Regards, >>>> Nils Loodin >>>> >> > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From staffan.larsen at oracle.com Fri May 4 03:05:59 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 4 May 2012 12:05:59 +0200 Subject: RFR - BUG7163117: SA Agent can't connect to process on Mac OSX In-Reply-To: <6492C401-0DC1-466C-8747-C27444408CDF@oracle.com> References: <6492C401-0DC1-466C-8747-C27444408CDF@oracle.com> Message-ID: <380ADA04-9AE5-4B42-A37D-2FA7F188951A@oracle.com> Looks good. I can sponsor the push. What kind of testing have you done? /Staffan On 4 maj 2012, at 11:28, Nils Loodin wrote: > looking for cpu-arch "amd64" only, and not "x86_64" as mac osx is using nowadays. > > http://cr.openjdk.java.net/~nloodin/7163117/webrev.00/ > > > > Need reviews and a sponsor! > Regards, > Nils Loodin From staffan.larsen at oracle.com Fri May 4 03:11:32 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 4 May 2012 12:11:32 +0200 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: <4FA3A457.8070700@oracle.com> References: <4FA109E5.2020309@oracle.com> <4FA121F8.3080008@oracle.com> <8372B427-9B5F-4DE0-88A7-10025623B257@oracle.com> <35EE9EE2-C0CA-4A04-A91B-0B54C5923C6A@oracle.com> <4FA3A457.8070700@oracle.com> Message-ID: Note that there is _lots_ of old cruft in os_bsd.cpp that are leftovers from the bsd port and needs to be cleaned up. Basically the file is a copy of os_linux.cpp with things removed by #ifdefs. I don't think it is in the scope of Nils' current work to do this cleanup. /Staffan On 4 maj 2012, at 11:41, Dmitry Samersoff wrote: > Nils, > > os_bsd.cpp: > > 2359: // Print warning if unsafe chroot environment detected > constant below is > unstable_chroot_error > > 2373: Never heard about neither about /etc/XXX-release on BSD nor > about mandrake or redhat bsd. > Please fix it as well. > > 2409: st->print(os::Bsd::glibc_version()) > glibc_version() looks a little bit weird as > none of BSD has glibc. > > > -Dmitry > > > > On 2012-05-04 12:26, Nils Loodin wrote: >> Updated this with pulling out some shared code to os_posix.cpp. >> Some methods were different enough that this wasn't possible though. >> >> Do you like this better? >> >> Webrev: >> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ >> >> On May 2, 2012, at 14:08 , Nils Loodin wrote: >> >>> >>> On May 2, 2012, at 14:00 , David Holmes wrote: >>> >>>> Hi Nils, >>>> >>>> On 2/05/2012 9:56 PM, Nils Loodin wrote: >>>>>> Ignoring Windows (with prints very little) I'd say it is the printing of /proc/meminfo that is the main difference. Not sure why printing that was necessary ... but if we are going to remove it I think we need to know why it was added. >>>>> Yes, that's the reason. >>>>> Note that nothing is removed. The method still prints exactly the same info, but I introduced another method to print briefer info, to be kinder to tool developers. >>>> >>>> The current one prints /proc/meminfo. You turned that code into print_full_memory_info but in the main routine you call print_memory_info. Was that a mistake? >>> >>> YES! Glad you caught that :) Guess (or hope) it would have been caught in dump testing otherwise :) >>> >>> Regards, >>> Nils Loodin >>> >>> >>>> >>>> David >>>> >>>>> I really don't want to change the output for say, hs_err files, where I believe this info is used. >>>>> >>>>>> >>>>>>> This can make it hard for tool writers to get a summary that look good and similar for multiple platforms (sizing of gui fields, having to parse info in the tool code etc) >>>>>>> Lookin at the code, it's in some serious need of refactoring. It would be nice with a method to get a "brief" os info for these kinds of tools that looks similar on all platforms. >>>>>>> >>>>>>> This is my suggested change: >>>>>>> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ >>>>>> >>>>>> Seems to me some of this could be factored into the top-level OS class if we shoehorn Windows into the same shape as the other OSes ;-) >>>>> This was my first attempt also, but then a lot of empty windows-methods ensued, which was kind of ugly. >>>>> >>>>>> Or at least perhaps put some of the common stuff into os_posix.cpp ? >>>>> There's a thought! >>>>> I'll investigate that route, it could get things to look nicer. >>>>> >>>>> >>>>>> Cheers, >>>>>> David >>>>> Regards, >>>>> Nils Loodin >>>>> >>> >> > > > -- > Dmitry Samersoff > Java Hotspot development team, SPB04 > * There will come soft rains ... From Dmitry.Samersoff at oracle.com Fri May 4 03:15:24 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Fri, 04 May 2012 14:15:24 +0400 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: References: <4FA109E5.2020309@oracle.com> <4FA121F8.3080008@oracle.com> <8372B427-9B5F-4DE0-88A7-10025623B257@oracle.com> <35EE9EE2-C0CA-4A04-A91B-0B54C5923C6A@oracle.com> <4FA3A457.8070700@oracle.com> Message-ID: <4FA3AC3C.1000703@oracle.com> Staffan, OK. -Dmitry On 2012-05-04 14:11, Staffan Larsen wrote: > Note that there is _lots_ of old cruft in os_bsd.cpp that are leftovers from the bsd port and needs to be cleaned up. > Basically the file is a copy of os_linux.cpp with things removed by #ifdefs. > > I don't think it is in the scope of Nils' current work to do this cleanup. > > /Staffan > > On 4 maj 2012, at 11:41, Dmitry Samersoff wrote: > >> Nils, >> >> os_bsd.cpp: >> >> 2359: // Print warning if unsafe chroot environment detected >> constant below is >> unstable_chroot_error >> >> 2373: Never heard about neither about /etc/XXX-release on BSD nor >> about mandrake or redhat bsd. >> Please fix it as well. >> >> 2409: st->print(os::Bsd::glibc_version()) >> glibc_version() looks a little bit weird as >> none of BSD has glibc. >> >> >> -Dmitry >> >> >> >> On 2012-05-04 12:26, Nils Loodin wrote: >>> Updated this with pulling out some shared code to os_posix.cpp. >>> Some methods were different enough that this wasn't possible though. >>> >>> Do you like this better? >>> >>> Webrev: >>> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ >>> >>> On May 2, 2012, at 14:08 , Nils Loodin wrote: >>> >>>> >>>> On May 2, 2012, at 14:00 , David Holmes wrote: >>>> >>>>> Hi Nils, >>>>> >>>>> On 2/05/2012 9:56 PM, Nils Loodin wrote: >>>>>>> Ignoring Windows (with prints very little) I'd say it is the printing of /proc/meminfo that is the main difference. Not sure why printing that was necessary ... but if we are going to remove it I think we need to know why it was added. >>>>>> Yes, that's the reason. >>>>>> Note that nothing is removed. The method still prints exactly the same info, but I introduced another method to print briefer info, to be kinder to tool developers. >>>>> >>>>> The current one prints /proc/meminfo. You turned that code into print_full_memory_info but in the main routine you call print_memory_info. Was that a mistake? >>>> >>>> YES! Glad you caught that :) Guess (or hope) it would have been caught in dump testing otherwise :) >>>> >>>> Regards, >>>> Nils Loodin >>>> >>>> >>>>> >>>>> David >>>>> >>>>>> I really don't want to change the output for say, hs_err files, where I believe this info is used. >>>>>> >>>>>>> >>>>>>>> This can make it hard for tool writers to get a summary that look good and similar for multiple platforms (sizing of gui fields, having to parse info in the tool code etc) >>>>>>>> Lookin at the code, it's in some serious need of refactoring. It would be nice with a method to get a "brief" os info for these kinds of tools that looks similar on all platforms. >>>>>>>> >>>>>>>> This is my suggested change: >>>>>>>> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ >>>>>>> >>>>>>> Seems to me some of this could be factored into the top-level OS class if we shoehorn Windows into the same shape as the other OSes ;-) >>>>>> This was my first attempt also, but then a lot of empty windows-methods ensued, which was kind of ugly. >>>>>> >>>>>>> Or at least perhaps put some of the common stuff into os_posix.cpp ? >>>>>> There's a thought! >>>>>> I'll investigate that route, it could get things to look nicer. >>>>>> >>>>>> >>>>>>> Cheers, >>>>>>> David >>>>>> Regards, >>>>>> Nils Loodin >>>>>> >>>> >>> >> >> >> -- >> Dmitry Samersoff >> Java Hotspot development team, SPB04 >> * There will come soft rains ... > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From nils.loodin at oracle.com Fri May 4 04:01:51 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Fri, 4 May 2012 13:01:51 +0200 Subject: RFR - BUG7163117: SA Agent can't connect to process on Mac OSX In-Reply-To: <380ADA04-9AE5-4B42-A37D-2FA7F188951A@oracle.com> References: <6492C401-0DC1-466C-8747-C27444408CDF@oracle.com> <380ADA04-9AE5-4B42-A37D-2FA7F188951A@oracle.com> Message-ID: <7363224D-2724-4188-AB18-4812CDA12E5B@oracle.com> Built it and connected to a running java process and ran some commands. I see other issues, but the connecting part actually works now. This will probably open up more bugs. /Nils Loodin On May 4, 2012, at 12:05 , Staffan Larsen wrote: > Looks good. I can sponsor the push. > > What kind of testing have you done? > > /Staffan > > On 4 maj 2012, at 11:28, Nils Loodin wrote: > >> looking for cpu-arch "amd64" only, and not "x86_64" as mac osx is using nowadays. >> >> http://cr.openjdk.java.net/~nloodin/7163117/webrev.00/ >> >> >> >> Need reviews and a sponsor! >> Regards, >> Nils Loodin > From Dmitry.Samersoff at oracle.com Fri May 4 05:31:03 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Fri, 04 May 2012 16:31:03 +0400 Subject: RR(S) 7164191: properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario In-Reply-To: <4F98A320.2030803@linux.vnet.ibm.com> References: <4F853485.7020607@linux.vnet.ibm.com> <4F863945.7020701@oracle.com> <4F8D1CBC.5040205@linux.vnet.ibm.com> <4F8E5282.3070507@oracle.com> <4F8E5D34.8050901@linux.vnet.ibm.com> <4F94EE8B.8070101@linux.vnet.ibm.com> <4F94F70D.1060906@oracle.com> <4F94F880.2020206@oracle.com> <4F95080C.7090007@linux.vnet.ibm.com> <4F969953.9090107@oracle.com> <4F97EEDE.7050102@oracle.com> <4F98A320.2030803@linux.vnet.ibm.com> Message-ID: <4FA3CC07.1050400@oracle.com> Hi Everybody, Below is slightly modified version of the fix created by Deven You. http://cr.openjdk.java.net/~dsamersoff/7164191/webrev.00/ -Dmitry On 2012-04-26 05:21, Deven You wrote: > Hi Dmitry, > > Thanks for your help. I have created a CR with internal id 2236492 which > hasn't be published yet. So please set this internal CR id as duplicate > to 716419 as well. > > This is the original mail for this problem: > > > > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Hi core-libs-devs, > > I am not sure if sun.management.Agent belongs to jmx-dev mailing list, > if so please anyone tell me. > > This issue is that the sun.management.Agent.loadManagementProperties() > will invoke properties.putAll which will throw > ConcurrentModifcationException if there are other threads which modify > the properties concurrently. > > I have made a patch[1] which synchronize the sysProps so that putAll can > work on multi-thread scenario. The test case is also available in [1]. > > Thanks a lot! > > [1] http://cr.openjdk.java.net/~littlee/OJDK-256/webrev.00 > > > ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > > Thanks a lot! > > > > On 04/25/2012 08:32 PM, Dmitry Samersoff wrote: >> Deven, >> >> CR number is 7164191 . >> >> Could you re-send me your original e-mail with problem description and >> webrev link. >> >> I'll put it to CR comment field. >> >> >> -Dmitry >> >> >> >> On 2012-04-24 16:15, Dmitry Samersoff wrote: >>> Deven, >>> >>> After close look and off-line discussion with David Holmes, >>> the changes looks good for me. >>> >>> I'll take care of the rest. >>> >>> We have one more place in Agent.java executing exactly the same code >>> so I'll change both of them on your behalf. >>> >>> -Dmitry >>> >>> >>> On 2012-04-23 11:43, Deven You wrote: >>>> Thanks David, >>>> >>>> So is it ok for you to contribute this patch? >>>> >>>> On 04/23/2012 02:36 PM, David Holmes wrote: >>>>> Except of course that Properties is a Hashtable and synchronizes on >>>>> 'this' for all public methods. So locking the properties object in the >>>>> client code will guarantee exclusive access to it. >>>>> >>>>> Sorry about that. >>>>> >>>>> David >>>>> ----- >>>>> >>>>> On 23/04/2012 4:30 PM, David Holmes wrote: >>>>>> Deven, >>>>>> >>>>>> On 23/04/2012 3:54 PM, Deven You wrote: >>>>>>> On 04/18/2012 02:20 PM, Deven You wrote: >>>>>>>> On 04/18/2012 01:34 PM, Mandy Chung wrote: >>>>>>>>> >>>>>>>>> I think this could still run into CME. System Properties is not a >>>>>>>>> synchronized map and the setter methods (System.setProperty or >>>>>>>>> Properties.put method) doesn't synchronize on the Properties >>>>>>>>> object. >>>>>>>>> >>>>>>>>> >>>>>>>>> The setter methods I'm referring to are System.setProperty and >>>>>>>>> System.getProperties().put(). >>>>>>>>> >>>>>>>> I have gone through the Agent.java, I think other set/put methods >>>>>>>> related to properties are protected properly. >>>>>>>> >>>>>>>> public static void agentmain using parseString(args) which return a >>>>>>>> properties which is a local var and is not possible to cause >>>>>>>> concurrent problem when call config_props.putAll(arg_props). >>>>>>>> >>>>>>>> private static synchronized void startLocalManagementAgent() is >>>>>>>> synchronized already. >>>>>>>> >>>>>>>> private static synchronized void startRemoteManagementAgent(String >>>>>>>> args) is synchronized also. >>>>>>>> >>>>>>>> Could you point where the CME may ocurr? >>>>>>> Is there any suggestion from the mailing list? >>>>>> The problem is that System.getProperties() returns a globally >>>>>> accessible >>>>>> set of properties. So even if you prevent the Agent code from >>>>>> modifying >>>>>> those properties concurrently with other use in the Agent, you >>>>>> have no >>>>>> such guard for any other piece of code in the system which might also >>>>>> modify the properties. So the race condition you were trying to fix >>>>>> still exists. I don't see any way to fix this. No matter what you do >>>>>> another thread can modify the system properties while you are >>>>>> iterating >>>>>> them. Instead you need to anticipate the CME and try to recover >>>>>> from it >>>>>> (also non-trivial). >>>>>> >>>>>> Cheers, >>>>>> David Holmes >>>> >>> >> > > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From kumar.x.srinivasan at oracle.com Fri May 4 09:00:57 2012 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Fri, 04 May 2012 16:00:57 +0000 Subject: hg: jdk8/tl/langtools: 7166010: (javac) JavacMessager incorrectly restores log source file Message-ID: <20120504160059.9C88647156@hg.openjdk.java.net> Changeset: d10db3576c08 Author: ksrini Date: 2012-05-04 07:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d10db3576c08 7166010: (javac) JavacMessager incorrectly restores log source file Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/processing/JavacMessager.java + test/tools/javac/processing/messager/MessagerDiags.java From lance.andersen at oracle.com Fri May 4 13:02:17 2012 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Fri, 04 May 2012 20:02:17 +0000 Subject: hg: jdk8/tl/jdk: 7166598: FilteredRowSetImpl can result in Invalid Cursor Position Message-ID: <20120504200228.53CE747161@hg.openjdk.java.net> Changeset: 4580652d9828 Author: lancea Date: 2012-05-04 16:00 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4580652d9828 7166598: FilteredRowSetImpl can result in Invalid Cursor Position Reviewed-by: lancea Contributed-by: Knut Anders Hatlen ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java From xuelei.fan at oracle.com Fri May 4 17:31:24 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Sat, 05 May 2012 00:31:24 +0000 Subject: hg: jdk8/tl/jdk: 7153184: NullPointerException when calling SSLEngineImpl.getSupportedCipherSuites Message-ID: <20120505003134.C962847165@hg.openjdk.java.net> Changeset: 41d3f7509e00 Author: xuelei Date: 2012-05-04 17:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41d3f7509e00 7153184: NullPointerException when calling SSLEngineImpl.getSupportedCipherSuites Reviewed-by: weijun ! src/share/classes/sun/security/ssl/SSLContextImpl.java From caoxudong818 at gmail.com Sat May 5 04:05:39 2012 From: caoxudong818 at gmail.com (=?GB2312?B?stzQ8bar?=) Date: Sat, 5 May 2012 19:05:39 +0800 Subject: typo in JConsole's MemoryPoolStat.getAfterGcUsage() Message-ID: Hi all, I've found a typo in JConsole's MemoryPoolStat.getAfterGcUsage(), which is returning the wrong field. Here's a patch to fix it: diff -r 9e82ac15ab80 src/share/classes/sun/tools/jconsole/MemoryPoolStat.java --- a/src/share/classes/sun/tools/jconsole/MemoryPoolStat.java Thu Apr 26 14:07:12 2012 -0700 +++ b/src/share/classes/sun/tools/jconsole/MemoryPoolStat.java Sat May 05 16:33:46 2012 +0800 @@ -129,6 +129,6 @@ * null if no GC occurs. */ public MemoryUsage getAfterGcUsage() { - return beforeGcUsage; + return afterGcUsage; } } In addition, I searched "MemoryPoolStat" in JConsole's source code, and I got a method "getStat" in "src/share/classes/sun/tools/jconsole/MemoryPoolProxy.java", which could generate an MemoryPoolStat object. But when searching "getStat", I got nothing. So my question is that, have class MemoryPoolStat not been used yet, or dose it be used in other jar? Thanks, caoxudong -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120505/bf8c08be/attachment.html From erik.gahlin at oracle.com Sat May 5 05:55:21 2012 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Sat, 5 May 2012 05:55:21 -0700 (PDT) Subject: Sv: typo in JConsole's MemoryPoolStat.getAfterGcUsage() Message-ID: Hi, I noticed the same thing when I was going through the code yesterday, fixing localization issues. I changed it to afterGcUsage, but I haven't tested or checked in the code in yet - Erik Hi all, I've found a typo in JConsole's MemoryPoolStat.getAfterGcUsage(), which is returning the wrong field. Here's a patch to fix it: diff -r 9e82ac15ab80 src/share/classes/sun/tools/jconsole/MemoryPoolStat.java --- a/src/share/classes/sun/tools/jconsole/MemoryPoolStat.java Thu Apr 26 14:07:12 2012 -0700 +++ b/src/share/classes/sun/tools/jconsole/MemoryPoolStat.java Sat May 05 16:33:46 2012 +0800 @@ -129,6 +129,6 @@ ? ? ? * null if no GC occurs. ? ? ? */ ? ? ?public MemoryUsage getAfterGcUsage() { - ? ? ? ?return beforeGcUsage; + ? ? ? ?return afterGcUsage; ? ? ?} ?} In addition, I searched "MemoryPoolStat" in JConsole's source code, and I got a method "getStat" in? "src/share/classes/sun/tools/jconsole/MemoryPoolProxy.java", which could generate an?MemoryPoolStat object. But when searching "getStat", I got nothing. ?So my question is that, ?have class?MemoryPoolStat not been used yet, or dose it be used in other jar? Thanks, caoxudong -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120505/aea95bcb/attachment.html From caoxudong818 at gmail.com Sat May 5 07:43:19 2012 From: caoxudong818 at gmail.com (=?GB2312?B?stzQ8bar?=) Date: Sat, 5 May 2012 22:43:19 +0800 Subject: typo in JConsole's MemoryPoolStat.getAfterGcUsage() In-Reply-To: References: Message-ID: Thanks for your response. I changed it, too. 2012/5/5 Erik Gahlin > Hi, > > > > I noticed the same thing when I was going through the code yesterday, > fixing localization issues. > > > > I changed it to afterGcUsage, but I haven't tested or checked in the code > in yet > > > - Erik > > > Hi all, > > I've found a typo in JConsole's MemoryPoolStat.getAfterGcUsage(), which is > returning the wrong field. Here's a patch to fix it: > > diff -r 9e82ac15ab80 > src/share/classes/sun/tools/jconsole/MemoryPoolStat.java > --- a/src/share/classes/sun/tools/jconsole/MemoryPoolStat.java Thu Apr 26 > 14:07:12 2012 -0700 > +++ b/src/share/classes/sun/tools/jconsole/MemoryPoolStat.java Sat May 05 > 16:33:46 2012 +0800 > @@ -129,6 +129,6 @@ > * null if no GC occurs. > */ > public MemoryUsage getAfterGcUsage() { > - return beforeGcUsage; > + return afterGcUsage; > } > } > > In addition, I searched "MemoryPoolStat" in JConsole's source code, and I > got a method "getStat" in > "src/share/classes/sun/tools/jconsole/MemoryPoolProxy.java", which could > generate an MemoryPoolStat object. But when searching > "getStat", I got nothing. So my question is that, have > class MemoryPoolStat not been used yet, or dose it be used in other jar? > > Thanks, > caoxudong > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120505/96f2c955/attachment.html From david.holmes at oracle.com Sun May 6 05:10:55 2012 From: david.holmes at oracle.com (David Holmes) Date: Sun, 06 May 2012 22:10:55 +1000 Subject: RFR: 7161732: Improve handling of thread_id in OSThread In-Reply-To: <4FA2523D.6000106@oracle.com> References: <4FA2523D.6000106@oracle.com> Message-ID: <4FA66A4F.3050803@oracle.com> Hi Rickard, One initial comment. Isn't this redundant: 102 #ifdef _ALLBSD_SOURCE 103 #ifdef __APPLE__ 104 void set_thread_id(thread_t id) { 105 _thread_id = id; 106 } 107 #else 108 void set_thread_id(pthread_t id) { 109 _thread_id = id; 110 } 111 #endif 112 #else 113 void set_thread_id(pid_t id) { 114 _thread_id = id; 115 } 116 #endif Given you have set a typedef for thread_id_t, and rely on it to avoid a cast on the assignment, can't you just define a single function: void set_thread_id(thread_id_t id) { _thread_id = id; } ? David ----- On 3/05/2012 7:39 PM, Rickard B?ckman wrote: > Hi all, > > I've made a refactoring of thread_id in OSThread, which reduces the > amount of duplicated code. > > Please review this change at: > http://cr.openjdk.java.net/~rbackman/7161732/webrev/ > > Thanks > /R From david.holmes at oracle.com Sun May 6 05:18:52 2012 From: david.holmes at oracle.com (David Holmes) Date: Sun, 06 May 2012 22:18:52 +1000 Subject: RR(S) 7164191: properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario In-Reply-To: <4FA3CC07.1050400@oracle.com> References: <4F853485.7020607@linux.vnet.ibm.com> <4F863945.7020701@oracle.com> <4F8D1CBC.5040205@linux.vnet.ibm.com> <4F8E5282.3070507@oracle.com> <4F8E5D34.8050901@linux.vnet.ibm.com> <4F94EE8B.8070101@linux.vnet.ibm.com> <4F94F70D.1060906@oracle.com> <4F94F880.2020206@oracle.com> <4F95080C.7090007@linux.vnet.ibm.com> <4F969953.9090107@oracle.com> <4F97EEDE.7050102@oracle.com> <4F98A320.2030803@linux.vnet.ibm.com> <4FA3CC07.1050400@oracle.com> Message-ID: <4FA66C2C.50500@oracle.com> Hi Dmitry, Sorry for late response but I've been travelling. One concern with the test is that it isn't guaranteed to fail with the buggy code. Not sure there is anything we can do about that though. One nit with the test is that it is using an indent of 8 instead of 4. David On 4/05/2012 10:31 PM, Dmitry Samersoff wrote: > Hi Everybody, > > Below is slightly modified version of the fix created by Deven You. > > http://cr.openjdk.java.net/~dsamersoff/7164191/webrev.00/ > > -Dmitry > > > On 2012-04-26 05:21, Deven You wrote: >> Hi Dmitry, >> >> Thanks for your help. I have created a CR with internal id 2236492 which >> hasn't be published yet. So please set this internal CR id as duplicate >> to 716419 as well. >> >> This is the original mail for this problem: >> >> >> >> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- >> >> Hi core-libs-devs, >> >> I am not sure if sun.management.Agent belongs to jmx-dev mailing list, >> if so please anyone tell me. >> >> This issue is that the sun.management.Agent.loadManagementProperties() >> will invoke properties.putAll which will throw >> ConcurrentModifcationException if there are other threads which modify >> the properties concurrently. >> >> I have made a patch[1] which synchronize the sysProps so that putAll can >> work on multi-thread scenario. The test case is also available in [1]. >> >> Thanks a lot! >> >> [1] http://cr.openjdk.java.net/~littlee/OJDK-256/webrev.00 >> >> >> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- >> >> >> Thanks a lot! >> >> >> >> On 04/25/2012 08:32 PM, Dmitry Samersoff wrote: >>> Deven, >>> >>> CR number is 7164191 . >>> >>> Could you re-send me your original e-mail with problem description and >>> webrev link. >>> >>> I'll put it to CR comment field. >>> >>> >>> -Dmitry >>> >>> >>> >>> On 2012-04-24 16:15, Dmitry Samersoff wrote: >>>> Deven, >>>> >>>> After close look and off-line discussion with David Holmes, >>>> the changes looks good for me. >>>> >>>> I'll take care of the rest. >>>> >>>> We have one more place in Agent.java executing exactly the same code >>>> so I'll change both of them on your behalf. >>>> >>>> -Dmitry >>>> >>>> >>>> On 2012-04-23 11:43, Deven You wrote: >>>>> Thanks David, >>>>> >>>>> So is it ok for you to contribute this patch? >>>>> >>>>> On 04/23/2012 02:36 PM, David Holmes wrote: >>>>>> Except of course that Properties is a Hashtable and synchronizes on >>>>>> 'this' for all public methods. So locking the properties object in the >>>>>> client code will guarantee exclusive access to it. >>>>>> >>>>>> Sorry about that. >>>>>> >>>>>> David >>>>>> ----- >>>>>> >>>>>> On 23/04/2012 4:30 PM, David Holmes wrote: >>>>>>> Deven, >>>>>>> >>>>>>> On 23/04/2012 3:54 PM, Deven You wrote: >>>>>>>> On 04/18/2012 02:20 PM, Deven You wrote: >>>>>>>>> On 04/18/2012 01:34 PM, Mandy Chung wrote: >>>>>>>>>> >>>>>>>>>> I think this could still run into CME. System Properties is not a >>>>>>>>>> synchronized map and the setter methods (System.setProperty or >>>>>>>>>> Properties.put method) doesn't synchronize on the Properties >>>>>>>>>> object. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> The setter methods I'm referring to are System.setProperty and >>>>>>>>>> System.getProperties().put(). >>>>>>>>>> >>>>>>>>> I have gone through the Agent.java, I think other set/put methods >>>>>>>>> related to properties are protected properly. >>>>>>>>> >>>>>>>>> public static void agentmain using parseString(args) which return a >>>>>>>>> properties which is a local var and is not possible to cause >>>>>>>>> concurrent problem when call config_props.putAll(arg_props). >>>>>>>>> >>>>>>>>> private static synchronized void startLocalManagementAgent() is >>>>>>>>> synchronized already. >>>>>>>>> >>>>>>>>> private static synchronized void startRemoteManagementAgent(String >>>>>>>>> args) is synchronized also. >>>>>>>>> >>>>>>>>> Could you point where the CME may ocurr? >>>>>>>> Is there any suggestion from the mailing list? >>>>>>> The problem is that System.getProperties() returns a globally >>>>>>> accessible >>>>>>> set of properties. So even if you prevent the Agent code from >>>>>>> modifying >>>>>>> those properties concurrently with other use in the Agent, you >>>>>>> have no >>>>>>> such guard for any other piece of code in the system which might also >>>>>>> modify the properties. So the race condition you were trying to fix >>>>>>> still exists. I don't see any way to fix this. No matter what you do >>>>>>> another thread can modify the system properties while you are >>>>>>> iterating >>>>>>> them. Instead you need to anticipate the CME and try to recover >>>>>>> from it >>>>>>> (also non-trivial). >>>>>>> >>>>>>> Cheers, >>>>>>> David Holmes >>>>> >>>> >>> >> >> > > From Dmitry.Samersoff at oracle.com Sun May 6 05:30:45 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Sun, 06 May 2012 16:30:45 +0400 Subject: RR(S) 7164191: properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario In-Reply-To: <4FA66C2C.50500@oracle.com> References: <4F853485.7020607@linux.vnet.ibm.com> <4F863945.7020701@oracle.com> <4F8D1CBC.5040205@linux.vnet.ibm.com> <4F8E5282.3070507@oracle.com> <4F8E5D34.8050901@linux.vnet.ibm.com> <4F94EE8B.8070101@linux.vnet.ibm.com> <4F94F70D.1060906@oracle.com> <4F94F880.2020206@oracle.com> <4F95080C.7090007@linux.vnet.ibm.com> <4F969953.9090107@oracle.com> <4F97EEDE.7050102@oracle.com> <4F98A320.2030803@linux.vnet.ibm.com> <4FA3CC07.1050400@oracle.com> <4FA66C2C.50500@oracle.com> Message-ID: <4FA66EF5.207@oracle.com> David, Thank you for your response! On 2012-05-06 16:18, David Holmes wrote: > Hi Dmitry, > > Sorry for late response but I've been travelling. > > One concern with the test is that it isn't guaranteed to fail with the > buggy code. Not sure there is anything we can do about that though. It used to fall, so I guess it's good enough. > One nit with the test is that it is using an indent of 8 instead of 4. Will fix it. -Dmitry > > David > > On 4/05/2012 10:31 PM, Dmitry Samersoff wrote: >> Hi Everybody, >> >> Below is slightly modified version of the fix created by Deven You. >> >> http://cr.openjdk.java.net/~dsamersoff/7164191/webrev.00/ >> >> -Dmitry >> >> >> On 2012-04-26 05:21, Deven You wrote: >>> Hi Dmitry, >>> >>> Thanks for your help. I have created a CR with internal id 2236492 which >>> hasn't be published yet. So please set this internal CR id as duplicate >>> to 716419 as well. >>> >>> This is the original mail for this problem: >>> >>> >>> >>> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- >>> >>> >>> Hi core-libs-devs, >>> >>> I am not sure if sun.management.Agent belongs to jmx-dev mailing list, >>> if so please anyone tell me. >>> >>> This issue is that the sun.management.Agent.loadManagementProperties() >>> will invoke properties.putAll which will throw >>> ConcurrentModifcationException if there are other threads which modify >>> the properties concurrently. >>> >>> I have made a patch[1] which synchronize the sysProps so that putAll can >>> work on multi-thread scenario. The test case is also available in [1]. >>> >>> Thanks a lot! >>> >>> [1] http://cr.openjdk.java.net/~littlee/OJDK-256/webrev.00 >>> >>> >>> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- >>> >>> >>> >>> Thanks a lot! >>> >>> >>> >>> On 04/25/2012 08:32 PM, Dmitry Samersoff wrote: >>>> Deven, >>>> >>>> CR number is 7164191 . >>>> >>>> Could you re-send me your original e-mail with problem description and >>>> webrev link. >>>> >>>> I'll put it to CR comment field. >>>> >>>> >>>> -Dmitry >>>> >>>> >>>> >>>> On 2012-04-24 16:15, Dmitry Samersoff wrote: >>>>> Deven, >>>>> >>>>> After close look and off-line discussion with David Holmes, >>>>> the changes looks good for me. >>>>> >>>>> I'll take care of the rest. >>>>> >>>>> We have one more place in Agent.java executing exactly the same code >>>>> so I'll change both of them on your behalf. >>>>> >>>>> -Dmitry >>>>> >>>>> >>>>> On 2012-04-23 11:43, Deven You wrote: >>>>>> Thanks David, >>>>>> >>>>>> So is it ok for you to contribute this patch? >>>>>> >>>>>> On 04/23/2012 02:36 PM, David Holmes wrote: >>>>>>> Except of course that Properties is a Hashtable and synchronizes on >>>>>>> 'this' for all public methods. So locking the properties object >>>>>>> in the >>>>>>> client code will guarantee exclusive access to it. >>>>>>> >>>>>>> Sorry about that. >>>>>>> >>>>>>> David >>>>>>> ----- >>>>>>> >>>>>>> On 23/04/2012 4:30 PM, David Holmes wrote: >>>>>>>> Deven, >>>>>>>> >>>>>>>> On 23/04/2012 3:54 PM, Deven You wrote: >>>>>>>>> On 04/18/2012 02:20 PM, Deven You wrote: >>>>>>>>>> On 04/18/2012 01:34 PM, Mandy Chung wrote: >>>>>>>>>>> >>>>>>>>>>> I think this could still run into CME. System Properties is >>>>>>>>>>> not a >>>>>>>>>>> synchronized map and the setter methods (System.setProperty or >>>>>>>>>>> Properties.put method) doesn't synchronize on the Properties >>>>>>>>>>> object. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> The setter methods I'm referring to are System.setProperty and >>>>>>>>>>> System.getProperties().put(). >>>>>>>>>>> >>>>>>>>>> I have gone through the Agent.java, I think other set/put methods >>>>>>>>>> related to properties are protected properly. >>>>>>>>>> >>>>>>>>>> public static void agentmain using parseString(args) which >>>>>>>>>> return a >>>>>>>>>> properties which is a local var and is not possible to cause >>>>>>>>>> concurrent problem when call config_props.putAll(arg_props). >>>>>>>>>> >>>>>>>>>> private static synchronized void startLocalManagementAgent() is >>>>>>>>>> synchronized already. >>>>>>>>>> >>>>>>>>>> private static synchronized void >>>>>>>>>> startRemoteManagementAgent(String >>>>>>>>>> args) is synchronized also. >>>>>>>>>> >>>>>>>>>> Could you point where the CME may ocurr? >>>>>>>>> Is there any suggestion from the mailing list? >>>>>>>> The problem is that System.getProperties() returns a globally >>>>>>>> accessible >>>>>>>> set of properties. So even if you prevent the Agent code from >>>>>>>> modifying >>>>>>>> those properties concurrently with other use in the Agent, you >>>>>>>> have no >>>>>>>> such guard for any other piece of code in the system which might >>>>>>>> also >>>>>>>> modify the properties. So the race condition you were trying to fix >>>>>>>> still exists. I don't see any way to fix this. No matter what >>>>>>>> you do >>>>>>>> another thread can modify the system properties while you are >>>>>>>> iterating >>>>>>>> them. Instead you need to anticipate the CME and try to recover >>>>>>>> from it >>>>>>>> (also non-trivial). >>>>>>>> >>>>>>>> Cheers, >>>>>>>> David Holmes >>>>>> >>>>> >>>> >>> >>> >> >> -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From youdwei at linux.vnet.ibm.com Sun May 6 23:16:23 2012 From: youdwei at linux.vnet.ibm.com (Deven You) Date: Mon, 07 May 2012 14:16:23 +0800 Subject: RR(S) 7164191: properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario In-Reply-To: <4FA66EF5.207@oracle.com> References: <4F853485.7020607@linux.vnet.ibm.com> <4F863945.7020701@oracle.com> <4F8D1CBC.5040205@linux.vnet.ibm.com> <4F8E5282.3070507@oracle.com> <4F8E5D34.8050901@linux.vnet.ibm.com> <4F94EE8B.8070101@linux.vnet.ibm.com> <4F94F70D.1060906@oracle.com> <4F94F880.2020206@oracle.com> <4F95080C.7090007@linux.vnet.ibm.com> <4F969953.9090107@oracle.com> <4F97EEDE.7050102@oracle.com> <4F98A320.2030803@linux.vnet.ibm.com> <4FA3CC07.1050400@oracle.com> <4FA66C2C.50500@oracle.com> <4FA66EF5.207@oracle.com> Message-ID: <4FA768B7.1070006@linux.vnet.ibm.com> Hi Dmitry, Besides David's suggestion, I don't see the @run main tag for the test, is it optional? Thanks a lot! On 05/06/2012 08:30 PM, Dmitry Samersoff wrote: > David, > > Thank you for your response! > > On 2012-05-06 16:18, David Holmes wrote: >> Hi Dmitry, >> >> Sorry for late response but I've been travelling. >> >> One concern with the test is that it isn't guaranteed to fail with the >> buggy code. Not sure there is anything we can do about that though. > It used to fall, so I guess it's good enough. > >> One nit with the test is that it is using an indent of 8 instead of 4. > Will fix it. > > -Dmitry > >> David >> >> On 4/05/2012 10:31 PM, Dmitry Samersoff wrote: >>> Hi Everybody, >>> >>> Below is slightly modified version of the fix created by Deven You. >>> >>> http://cr.openjdk.java.net/~dsamersoff/7164191/webrev.00/ >>> >>> -Dmitry >>> >>> >>> On 2012-04-26 05:21, Deven You wrote: >>>> Hi Dmitry, >>>> >>>> Thanks for your help. I have created a CR with internal id 2236492 which >>>> hasn't be published yet. So please set this internal CR id as duplicate >>>> to 716419 as well. >>>> >>>> This is the original mail for this problem: >>>> >>>> >>>> >>>> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- >>>> >>>> >>>> Hi core-libs-devs, >>>> >>>> I am not sure if sun.management.Agent belongs to jmx-dev mailing list, >>>> if so please anyone tell me. >>>> >>>> This issue is that the sun.management.Agent.loadManagementProperties() >>>> will invoke properties.putAll which will throw >>>> ConcurrentModifcationException if there are other threads which modify >>>> the properties concurrently. >>>> >>>> I have made a patch[1] which synchronize the sysProps so that putAll can >>>> work on multi-thread scenario. The test case is also available in [1]. >>>> >>>> Thanks a lot! >>>> >>>> [1] http://cr.openjdk.java.net/~littlee/OJDK-256/webrev.00 >>>> >>>> >>>> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- >>>> >>>> >>>> >>>> Thanks a lot! >>>> >>>> >>>> >>>> On 04/25/2012 08:32 PM, Dmitry Samersoff wrote: >>>>> Deven, >>>>> >>>>> CR number is 7164191 . >>>>> >>>>> Could you re-send me your original e-mail with problem description and >>>>> webrev link. >>>>> >>>>> I'll put it to CR comment field. >>>>> >>>>> >>>>> -Dmitry >>>>> >>>>> >>>>> >>>>> On 2012-04-24 16:15, Dmitry Samersoff wrote: >>>>>> Deven, >>>>>> >>>>>> After close look and off-line discussion with David Holmes, >>>>>> the changes looks good for me. >>>>>> >>>>>> I'll take care of the rest. >>>>>> >>>>>> We have one more place in Agent.java executing exactly the same code >>>>>> so I'll change both of them on your behalf. >>>>>> >>>>>> -Dmitry >>>>>> >>>>>> >>>>>> On 2012-04-23 11:43, Deven You wrote: >>>>>>> Thanks David, >>>>>>> >>>>>>> So is it ok for you to contribute this patch? >>>>>>> >>>>>>> On 04/23/2012 02:36 PM, David Holmes wrote: >>>>>>>> Except of course that Properties is a Hashtable and synchronizes on >>>>>>>> 'this' for all public methods. So locking the properties object >>>>>>>> in the >>>>>>>> client code will guarantee exclusive access to it. >>>>>>>> >>>>>>>> Sorry about that. >>>>>>>> >>>>>>>> David >>>>>>>> ----- >>>>>>>> >>>>>>>> On 23/04/2012 4:30 PM, David Holmes wrote: >>>>>>>>> Deven, >>>>>>>>> >>>>>>>>> On 23/04/2012 3:54 PM, Deven You wrote: >>>>>>>>>> On 04/18/2012 02:20 PM, Deven You wrote: >>>>>>>>>>> On 04/18/2012 01:34 PM, Mandy Chung wrote: >>>>>>>>>>>> I think this could still run into CME. System Properties is >>>>>>>>>>>> not a >>>>>>>>>>>> synchronized map and the setter methods (System.setProperty or >>>>>>>>>>>> Properties.put method) doesn't synchronize on the Properties >>>>>>>>>>>> object. >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> The setter methods I'm referring to are System.setProperty and >>>>>>>>>>>> System.getProperties().put(). >>>>>>>>>>>> >>>>>>>>>>> I have gone through the Agent.java, I think other set/put methods >>>>>>>>>>> related to properties are protected properly. >>>>>>>>>>> >>>>>>>>>>> public static void agentmain using parseString(args) which >>>>>>>>>>> return a >>>>>>>>>>> properties which is a local var and is not possible to cause >>>>>>>>>>> concurrent problem when call config_props.putAll(arg_props). >>>>>>>>>>> >>>>>>>>>>> private static synchronized void startLocalManagementAgent() is >>>>>>>>>>> synchronized already. >>>>>>>>>>> >>>>>>>>>>> private static synchronized void >>>>>>>>>>> startRemoteManagementAgent(String >>>>>>>>>>> args) is synchronized also. >>>>>>>>>>> >>>>>>>>>>> Could you point where the CME may ocurr? >>>>>>>>>> Is there any suggestion from the mailing list? >>>>>>>>> The problem is that System.getProperties() returns a globally >>>>>>>>> accessible >>>>>>>>> set of properties. So even if you prevent the Agent code from >>>>>>>>> modifying >>>>>>>>> those properties concurrently with other use in the Agent, you >>>>>>>>> have no >>>>>>>>> such guard for any other piece of code in the system which might >>>>>>>>> also >>>>>>>>> modify the properties. So the race condition you were trying to fix >>>>>>>>> still exists. I don't see any way to fix this. No matter what >>>>>>>>> you do >>>>>>>>> another thread can modify the system properties while you are >>>>>>>>> iterating >>>>>>>>> them. Instead you need to anticipate the CME and try to recover >>>>>>>>> from it >>>>>>>>> (also non-trivial). >>>>>>>>> >>>>>>>>> Cheers, >>>>>>>>> David Holmes >>>> >>> > -- Best Regards, Deven -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120507/bc5e4630/attachment.html From rickard.backman at oracle.com Mon May 7 00:21:22 2012 From: rickard.backman at oracle.com (=?UTF-8?B?Umlja2FyZCBCw6Rja21hbg==?=) Date: Mon, 07 May 2012 09:21:22 +0200 Subject: RFR: 7161732: Improve handling of thread_id in OSThread In-Reply-To: <4FA66A4F.3050803@oracle.com> References: <4FA2523D.6000106@oracle.com> <4FA66A4F.3050803@oracle.com> Message-ID: <4FA777F2.3000304@oracle.com> David, I can't find that code in any of the modified files (only as "blue" text in osThread_bsd.hpp, but that is removed code). There is a set_thread_id in osThread.hpp 118 void set_thread_id(thread_id_t id) { _thread_id = id; } Thanks /R On 05/06/2012 02:10 PM, David Holmes wrote: > Hi Rickard, > > One initial comment. Isn't this redundant: > > 102 #ifdef _ALLBSD_SOURCE > 103 #ifdef __APPLE__ > 104 void set_thread_id(thread_t id) { > 105 _thread_id = id; > 106 } > 107 #else > 108 void set_thread_id(pthread_t id) { > 109 _thread_id = id; > 110 } > 111 #endif > 112 #else > 113 void set_thread_id(pid_t id) { > 114 _thread_id = id; > 115 } > 116 #endif > > Given you have set a typedef for thread_id_t, and rely on it to avoid a > cast on the assignment, can't you just define a single function: > > void set_thread_id(thread_id_t id) { > _thread_id = id; > } > > ? > > David > ----- > > On 3/05/2012 7:39 PM, Rickard B?ckman wrote: >> Hi all, >> >> I've made a refactoring of thread_id in OSThread, which reduces the >> amount of duplicated code. >> >> Please review this change at: >> http://cr.openjdk.java.net/~rbackman/7161732/webrev/ >> >> Thanks >> /R From staffan.larsen at oracle.com Mon May 7 00:47:18 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 7 May 2012 09:47:18 +0200 Subject: RR(S) 7164191: properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario In-Reply-To: <4FA3CC07.1050400@oracle.com> References: <4F853485.7020607@linux.vnet.ibm.com> <4F863945.7020701@oracle.com> <4F8D1CBC.5040205@linux.vnet.ibm.com> <4F8E5282.3070507@oracle.com> <4F8E5D34.8050901@linux.vnet.ibm.com> <4F94EE8B.8070101@linux.vnet.ibm.com> <4F94F70D.1060906@oracle.com> <4F94F880.2020206@oracle.com> <4F95080C.7090007@linux.vnet.ibm.com> <4F969953.9090107@oracle.com> <4F97EEDE.7050102@oracle.com> <4F98A320.2030803@linux.vnet.ibm.com> <4FA3CC07.1050400@oracle.com> Message-ID: Looks good! /Staffan On 4 maj 2012, at 14:31, Dmitry Samersoff wrote: > Hi Everybody, > > Below is slightly modified version of the fix created by Deven You. > > http://cr.openjdk.java.net/~dsamersoff/7164191/webrev.00/ > > -Dmitry > > > On 2012-04-26 05:21, Deven You wrote: >> Hi Dmitry, >> >> Thanks for your help. I have created a CR with internal id 2236492 which >> hasn't be published yet. So please set this internal CR id as duplicate >> to 716419 as well. >> >> This is the original mail for this problem: >> >> >> >> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- >> >> Hi core-libs-devs, >> >> I am not sure if sun.management.Agent belongs to jmx-dev mailing list, >> if so please anyone tell me. >> >> This issue is that the sun.management.Agent.loadManagementProperties() >> will invoke properties.putAll which will throw >> ConcurrentModifcationException if there are other threads which modify >> the properties concurrently. >> >> I have made a patch[1] which synchronize the sysProps so that putAll can >> work on multi-thread scenario. The test case is also available in [1]. >> >> Thanks a lot! >> >> [1] http://cr.openjdk.java.net/~littlee/OJDK-256/webrev.00 >> >> >> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- >> >> >> Thanks a lot! >> >> >> >> On 04/25/2012 08:32 PM, Dmitry Samersoff wrote: >>> Deven, >>> >>> CR number is 7164191 . >>> >>> Could you re-send me your original e-mail with problem description and >>> webrev link. >>> >>> I'll put it to CR comment field. >>> >>> >>> -Dmitry >>> >>> >>> >>> On 2012-04-24 16:15, Dmitry Samersoff wrote: >>>> Deven, >>>> >>>> After close look and off-line discussion with David Holmes, >>>> the changes looks good for me. >>>> >>>> I'll take care of the rest. >>>> >>>> We have one more place in Agent.java executing exactly the same code >>>> so I'll change both of them on your behalf. >>>> >>>> -Dmitry >>>> >>>> >>>> On 2012-04-23 11:43, Deven You wrote: >>>>> Thanks David, >>>>> >>>>> So is it ok for you to contribute this patch? >>>>> >>>>> On 04/23/2012 02:36 PM, David Holmes wrote: >>>>>> Except of course that Properties is a Hashtable and synchronizes on >>>>>> 'this' for all public methods. So locking the properties object in the >>>>>> client code will guarantee exclusive access to it. >>>>>> >>>>>> Sorry about that. >>>>>> >>>>>> David >>>>>> ----- >>>>>> >>>>>> On 23/04/2012 4:30 PM, David Holmes wrote: >>>>>>> Deven, >>>>>>> >>>>>>> On 23/04/2012 3:54 PM, Deven You wrote: >>>>>>>> On 04/18/2012 02:20 PM, Deven You wrote: >>>>>>>>> On 04/18/2012 01:34 PM, Mandy Chung wrote: >>>>>>>>>> >>>>>>>>>> I think this could still run into CME. System Properties is not a >>>>>>>>>> synchronized map and the setter methods (System.setProperty or >>>>>>>>>> Properties.put method) doesn't synchronize on the Properties >>>>>>>>>> object. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> The setter methods I'm referring to are System.setProperty and >>>>>>>>>> System.getProperties().put(). >>>>>>>>>> >>>>>>>>> I have gone through the Agent.java, I think other set/put methods >>>>>>>>> related to properties are protected properly. >>>>>>>>> >>>>>>>>> public static void agentmain using parseString(args) which return a >>>>>>>>> properties which is a local var and is not possible to cause >>>>>>>>> concurrent problem when call config_props.putAll(arg_props). >>>>>>>>> >>>>>>>>> private static synchronized void startLocalManagementAgent() is >>>>>>>>> synchronized already. >>>>>>>>> >>>>>>>>> private static synchronized void startRemoteManagementAgent(String >>>>>>>>> args) is synchronized also. >>>>>>>>> >>>>>>>>> Could you point where the CME may ocurr? >>>>>>>> Is there any suggestion from the mailing list? >>>>>>> The problem is that System.getProperties() returns a globally >>>>>>> accessible >>>>>>> set of properties. So even if you prevent the Agent code from >>>>>>> modifying >>>>>>> those properties concurrently with other use in the Agent, you >>>>>>> have no >>>>>>> such guard for any other piece of code in the system which might also >>>>>>> modify the properties. So the race condition you were trying to fix >>>>>>> still exists. I don't see any way to fix this. No matter what you do >>>>>>> another thread can modify the system properties while you are >>>>>>> iterating >>>>>>> them. Instead you need to anticipate the CME and try to recover >>>>>>> from it >>>>>>> (also non-trivial). >>>>>>> >>>>>>> Cheers, >>>>>>> David Holmes >>>>> >>>> >>> >> >> > > > -- > Dmitry Samersoff > Java Hotspot development team, SPB04 > * There will come soft rains ... From littlee at linux.vnet.ibm.com Mon May 7 01:43:51 2012 From: littlee at linux.vnet.ibm.com (littlee at linux.vnet.ibm.com) Date: Mon, 07 May 2012 08:43:51 +0000 Subject: hg: jdk8/tl/jdk: 7166048: Remove the embeded epoll data structure. Message-ID: <20120507084420.528C94718B@hg.openjdk.java.net> Changeset: 62557a1336c0 Author: zhouyx Date: 2012-05-07 16:43 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/62557a1336c0 7166048: Remove the embeded epoll data structure. Reviewed-by: alanb ! src/solaris/native/sun/nio/ch/EPollArrayWrapper.c From david.holmes at oracle.com Mon May 7 01:55:19 2012 From: david.holmes at oracle.com (David Holmes) Date: Mon, 07 May 2012 18:55:19 +1000 Subject: RFR: 7161732: Improve handling of thread_id in OSThread In-Reply-To: <4FA777F2.3000304@oracle.com> References: <4FA2523D.6000106@oracle.com> <4FA66A4F.3050803@oracle.com> <4FA777F2.3000304@oracle.com> Message-ID: <4FA78DF7.7010406@oracle.com> On 7/05/2012 5:21 PM, Rickard B?ckman wrote: > David, > > I can't find that code in any of the modified files (only as "blue" text > in osThread_bsd.hpp, but that is removed code). Sorry the frames view of the webrev confused me. It is "blue" but that is normally added or modified code, while "red" is deleted. In this case it seems it has been modified out of existence ;-) David > There is a set_thread_id in osThread.hpp > > 118 void set_thread_id(thread_id_t id) { _thread_id = id; } > > Thanks > /R > > On 05/06/2012 02:10 PM, David Holmes wrote: >> Hi Rickard, >> >> One initial comment. Isn't this redundant: >> >> 102 #ifdef _ALLBSD_SOURCE >> 103 #ifdef __APPLE__ >> 104 void set_thread_id(thread_t id) { >> 105 _thread_id = id; >> 106 } >> 107 #else >> 108 void set_thread_id(pthread_t id) { >> 109 _thread_id = id; >> 110 } >> 111 #endif >> 112 #else >> 113 void set_thread_id(pid_t id) { >> 114 _thread_id = id; >> 115 } >> 116 #endif >> >> Given you have set a typedef for thread_id_t, and rely on it to avoid a >> cast on the assignment, can't you just define a single function: >> >> void set_thread_id(thread_id_t id) { >> _thread_id = id; >> } >> >> ? >> >> David >> ----- >> >> On 3/05/2012 7:39 PM, Rickard B?ckman wrote: >>> Hi all, >>> >>> I've made a refactoring of thread_id in OSThread, which reduces the >>> amount of duplicated code. >>> >>> Please review this change at: >>> http://cr.openjdk.java.net/~rbackman/7161732/webrev/ >>> >>> Thanks >>> /R > From rickard.backman at oracle.com Mon May 7 01:57:13 2012 From: rickard.backman at oracle.com (=?UTF-8?B?Umlja2FyZCBCw6Rja21hbg==?=) Date: Mon, 07 May 2012 10:57:13 +0200 Subject: RFR: 7161732: Improve handling of thread_id in OSThread In-Reply-To: <4FA78DF7.7010406@oracle.com> References: <4FA2523D.6000106@oracle.com> <4FA66A4F.3050803@oracle.com> <4FA777F2.3000304@oracle.com> <4FA78DF7.7010406@oracle.com> Message-ID: <4FA78E69.60507@oracle.com> On 05/07/2012 10:55 AM, David Holmes wrote: > On 7/05/2012 5:21 PM, Rickard B?ckman wrote: >> David, >> >> I can't find that code in any of the modified files (only as "blue" text >> in osThread_bsd.hpp, but that is removed code). > > Sorry the frames view of the webrev confused me. It is "blue" but that > is normally added or modified code, while "red" is deleted. In this case > it seems it has been modified out of existence ;-) > It's the best kind of modification :) /R > David > >> There is a set_thread_id in osThread.hpp >> >> 118 void set_thread_id(thread_id_t id) { _thread_id = id; } >> >> Thanks >> /R >> >> On 05/06/2012 02:10 PM, David Holmes wrote: >>> Hi Rickard, >>> >>> One initial comment. Isn't this redundant: >>> >>> 102 #ifdef _ALLBSD_SOURCE >>> 103 #ifdef __APPLE__ >>> 104 void set_thread_id(thread_t id) { >>> 105 _thread_id = id; >>> 106 } >>> 107 #else >>> 108 void set_thread_id(pthread_t id) { >>> 109 _thread_id = id; >>> 110 } >>> 111 #endif >>> 112 #else >>> 113 void set_thread_id(pid_t id) { >>> 114 _thread_id = id; >>> 115 } >>> 116 #endif >>> >>> Given you have set a typedef for thread_id_t, and rely on it to avoid a >>> cast on the assignment, can't you just define a single function: >>> >>> void set_thread_id(thread_id_t id) { >>> _thread_id = id; >>> } >>> >>> ? >>> >>> David >>> ----- >>> >>> On 3/05/2012 7:39 PM, Rickard B?ckman wrote: >>>> Hi all, >>>> >>>> I've made a refactoring of thread_id in OSThread, which reduces the >>>> amount of duplicated code. >>>> >>>> Please review this change at: >>>> http://cr.openjdk.java.net/~rbackman/7161732/webrev/ >>>> >>>> Thanks >>>> /R >> From rob.mckenna at oracle.com Mon May 7 05:33:32 2012 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Mon, 07 May 2012 12:33:32 +0000 Subject: hg: jdk8/tl/jdk: 7166687: InetAddress.getLocalHost().getHostName() returns FQDN Message-ID: <20120507123402.865554718C@hg.openjdk.java.net> Changeset: b26c04717735 Author: robm Date: 2012-05-07 13:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b26c04717735 7166687: InetAddress.getLocalHost().getHostName() returns FQDN Reviewed-by: chegar ! src/solaris/native/java/net/Inet6AddressImpl.c From artem.ananiev at oracle.com Wed May 2 11:09:00 2012 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Wed, 02 May 2012 22:09:00 +0400 Subject: Review Request: 7164376 Replace use of sun.security.action.LoadLibraryAction In-Reply-To: <4F9998CF.9000308@oracle.com> References: <4F9998CF.9000308@oracle.com> Message-ID: <4FA1783C.7030809@oracle.com> Hi, Mandy, the client part of the fix looks fine. Let me ask a naive question, though. From your explanation, I see that System.loadLibrary() is now aware of modules. What prevents us to change LoadLibraryAction the same way? "FROM" code looks much more elegant than the new (the old?) "TO" one. Thanks, Artem On 4/26/2012 10:49 PM, Mandy Chung wrote: > 7164376 Replace use of sun.security.action.LoadLibraryAction > with direct call of System.loadLibrary > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk8/webrevs/7164376/webrev.00/ > > This change is required for jdk modularization. High level summary: > it replaces the use of LoadLibraryAction: > > FROM: > java.security.AccessController.doPrivileged(new LoadLibraryAction("net")); > > TO: > AccessController.doPrivileged( > new java.security.PrivilegedAction() { > public Void run() { > System.loadLibrary("net"); > return null; > } > }); > > It touches files in awt, security and serviceability area (cc'ed). > For this type of simple change, I think 1-2 reviewers can > review all files (simpler to review jdk.patch) and no need > for all teams to do the reviews. > > System.loadLibrary and Runtime.loadLibrary loads a system library of the > given > library name that requires RuntimePermission("loadLibrary."+lib) > permission. > Many places in the JDK code loading a system native library is using the > sun.security.action.LoadLibraryAction convenient class that will load the > system library as a privileged action: > java.security.AccessController.doPrivileged(new LoadLibraryAction("net")); > > The search path of native libraries are coupled with an associated class > loader. > For example, the application class loader uses the path specified in the > "java.library.path" system property for native library lookup. The > loadLibrary > implementation uses the caller's class loader for finding the native > library being > requested. For system libraries, the class loader is null and the system > library > lookup is handled as a special case. When the > sun.security.action.LoadLibraryAction > class is used that is the caller of System.loadLibrary, the caller's > class loader > in this case is "null" loader and thus it always finds the native > library from > the system library path. > > In a modular world, JDK modules may be loaded by multiple different > module class > loader. The following code would not work if it is expected to load a > native > library from a module which is not the module where the > sun.security.action.LoadLibraryAction lives. > > For example, the management module is trying to load libmanagement.so. > Calling > the following will fail to find libmanagement.so because the caller of > System.loadLibrary is the LoadLibraryAction which is in the base module > and search the library from the base module only. To prepare for jdk > modularization, the use of LoadLibraryAction should be replaced with > a direct call of System.loadLibrary. > > This patch also removes sun.security.action.LoadLibraryAction > class to avoid regression. > > Thanks > Mandy > From luchsh at linux.vnet.ibm.com Wed May 2 19:00:06 2012 From: luchsh at linux.vnet.ibm.com (Jonathan Lu) Date: Thu, 03 May 2012 10:00:06 +0800 Subject: Request for Review: 7165722 invalid path in MemoryMonitor demo's README.txt In-Reply-To: <4FA0F215.2040605@oracle.com> References: <4FA0F004.3090407@linux.vnet.ibm.com> <4FA0F215.2040605@oracle.com> Message-ID: <4FA1E6A6.6030505@linux.vnet.ibm.com> Thanks a lot, Alan. I'll go to serviceability-dev list for further discussion. Best regards! - Jonathan Lu On 05/02/2012 04:36 PM, Alan Bateman wrote: > On 02/05/2012 09:27, Jonathan Lu wrote: >> Hi build-dev, >> >> I've got a minor change to fix an invalid path from README.txt of >> MemoryMonitor demo, could anybody please help to take a look? >> >> http://cr.openjdk.java.net/~luchsh/7165722/ >> >> Best regards! >> - Jonathan >> > 7165722 was submitted as an incident and I've moved it to the right > place. Also cc'ing serviceability-dev as that is where these > java.lang.management demos came from. > > The patch looks fine and I assume Charles will push it for you. > > -Alan. > From david.holmes at oracle.com Mon May 7 22:37:30 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 08 May 2012 15:37:30 +1000 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: <35EE9EE2-C0CA-4A04-A91B-0B54C5923C6A@oracle.com> References: <4FA109E5.2020309@oracle.com> <4FA121F8.3080008@oracle.com> <8372B427-9B5F-4DE0-88A7-10025623B257@oracle.com> <35EE9EE2-C0CA-4A04-A91B-0B54C5923C6A@oracle.com> Message-ID: <4FA8B11A.50401@oracle.com> On 4/05/2012 6:26 PM, Nils Loodin wrote: > Updated this with pulling out some shared code to os_posix.cpp. > Some methods were different enough that this wasn't possible though. > > Do you like this better? > > Webrev: > http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ I don't see any os_posix.cpp changes here? David ----- > On May 2, 2012, at 14:08 , Nils Loodin wrote: > >> >> On May 2, 2012, at 14:00 , David Holmes wrote: >> >>> Hi Nils, >>> >>> On 2/05/2012 9:56 PM, Nils Loodin wrote: >>>>> Ignoring Windows (with prints very little) I'd say it is the printing of /proc/meminfo that is the main difference. Not sure why printing that was necessary ... but if we are going to remove it I think we need to know why it was added. >>>> Yes, that's the reason. >>>> Note that nothing is removed. The method still prints exactly the same info, but I introduced another method to print briefer info, to be kinder to tool developers. >>> >>> The current one prints /proc/meminfo. You turned that code into print_full_memory_info but in the main routine you call print_memory_info. Was that a mistake? >> >> YES! Glad you caught that :) Guess (or hope) it would have been caught in dump testing otherwise :) >> >> Regards, >> Nils Loodin >> >> >>> >>> David >>> >>>> I really don't want to change the output for say, hs_err files, where I believe this info is used. >>>> >>>>> >>>>>> This can make it hard for tool writers to get a summary that look good and similar for multiple platforms (sizing of gui fields, having to parse info in the tool code etc) >>>>>> Lookin at the code, it's in some serious need of refactoring. It would be nice with a method to get a "brief" os info for these kinds of tools that looks similar on all platforms. >>>>>> >>>>>> This is my suggested change: >>>>>> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ >>>>> >>>>> Seems to me some of this could be factored into the top-level OS class if we shoehorn Windows into the same shape as the other OSes ;-) >>>> This was my first attempt also, but then a lot of empty windows-methods ensued, which was kind of ugly. >>>> >>>>> Or at least perhaps put some of the common stuff into os_posix.cpp ? >>>> There's a thought! >>>> I'll investigate that route, it could get things to look nicer. >>>> >>>> >>>>> Cheers, >>>>> David >>>> Regards, >>>> Nils Loodin >>>> >> > From david.holmes at oracle.com Tue May 8 00:36:44 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Tue, 08 May 2012 07:36:44 +0000 Subject: hg: jdk8/tl/jdk: 7103570: AtomicIntegerFieldUpdater does not work when SecurityManager is installed Message-ID: <20120508073706.E5A36471B4@hg.openjdk.java.net> Changeset: 48513d156965 Author: dholmes Date: 2012-05-08 02:59 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48513d156965 7103570: AtomicIntegerFieldUpdater does not work when SecurityManager is installed Summary: Perform class.getField inside a doPrivileged block Reviewed-by: chegar, psandoz ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java + test/java/util/concurrent/atomic/AtomicUpdaters.java From nils.loodin at oracle.com Tue May 8 00:48:13 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Tue, 8 May 2012 09:48:13 +0200 Subject: RFR - BUG7163117: SA Agent can't connect to process on Mac OSX In-Reply-To: <7363224D-2724-4188-AB18-4812CDA12E5B@oracle.com> References: <6492C401-0DC1-466C-8747-C27444408CDF@oracle.com> <380ADA04-9AE5-4B42-A37D-2FA7F188951A@oracle.com> <7363224D-2724-4188-AB18-4812CDA12E5B@oracle.com> Message-ID: <5F398A66-C73A-443B-B4FB-36A30D31953E@oracle.com> Can I get a Reviewer to look at this? Does no reviewer care about SA? :) Regards Nils Loodin On May 4, 2012, at 13:01 , Nils Loodin wrote: > Built it and connected to a running java process and ran some commands. > I see other issues, but the connecting part actually works now. > > This will probably open up more bugs. > > /Nils Loodin > > On May 4, 2012, at 12:05 , Staffan Larsen wrote: > >> Looks good. I can sponsor the push. >> >> What kind of testing have you done? >> >> /Staffan >> >> On 4 maj 2012, at 11:28, Nils Loodin wrote: >> >>> looking for cpu-arch "amd64" only, and not "x86_64" as mac osx is using nowadays. >>> >>> http://cr.openjdk.java.net/~nloodin/7163117/webrev.00/ >>> >>> >>> >>> Need reviews and a sponsor! >>> Regards, >>> Nils Loodin >> > From nils.loodin at oracle.com Tue May 8 01:03:52 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Tue, 8 May 2012 10:03:52 +0200 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: <4FA8B11A.50401@oracle.com> References: <4FA109E5.2020309@oracle.com> <4FA121F8.3080008@oracle.com> <8372B427-9B5F-4DE0-88A7-10025623B257@oracle.com> <35EE9EE2-C0CA-4A04-A91B-0B54C5923C6A@oracle.com> <4FA8B11A.50401@oracle.com> Message-ID: <15E71A00-D43E-457C-A5AB-38E10D9184D3@oracle.com> Hrm, sorry about that people, The webrev number should have been bumped from 00 to 01. :) http://cr.openjdk.java.net/~nloodin/7165755/webrev.01/ Nisse On May 8, 2012, at 07:37 , David Holmes wrote: > On 4/05/2012 6:26 PM, Nils Loodin wrote: >> Updated this with pulling out some shared code to os_posix.cpp. >> Some methods were different enough that this wasn't possible though. >> >> Do you like this better? >> >> Webrev: >> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ > > I don't see any os_posix.cpp changes here? > > David > ----- > > >> On May 2, 2012, at 14:08 , Nils Loodin wrote: >> >>> >>> On May 2, 2012, at 14:00 , David Holmes wrote: >>> >>>> Hi Nils, >>>> >>>> On 2/05/2012 9:56 PM, Nils Loodin wrote: >>>>>> Ignoring Windows (with prints very little) I'd say it is the printing of /proc/meminfo that is the main difference. Not sure why printing that was necessary ... but if we are going to remove it I think we need to know why it was added. >>>>> Yes, that's the reason. >>>>> Note that nothing is removed. The method still prints exactly the same info, but I introduced another method to print briefer info, to be kinder to tool developers. >>>> >>>> The current one prints /proc/meminfo. You turned that code into print_full_memory_info but in the main routine you call print_memory_info. Was that a mistake? >>> >>> YES! Glad you caught that :) Guess (or hope) it would have been caught in dump testing otherwise :) >>> >>> Regards, >>> Nils Loodin >>> >>> >>>> >>>> David >>>> >>>>> I really don't want to change the output for say, hs_err files, where I believe this info is used. >>>>> >>>>>> >>>>>>> This can make it hard for tool writers to get a summary that look good and similar for multiple platforms (sizing of gui fields, having to parse info in the tool code etc) >>>>>>> Lookin at the code, it's in some serious need of refactoring. It would be nice with a method to get a "brief" os info for these kinds of tools that looks similar on all platforms. >>>>>>> >>>>>>> This is my suggested change: >>>>>>> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ >>>>>> >>>>>> Seems to me some of this could be factored into the top-level OS class if we shoehorn Windows into the same shape as the other OSes ;-) >>>>> This was my first attempt also, but then a lot of empty windows-methods ensued, which was kind of ugly. >>>>> >>>>>> Or at least perhaps put some of the common stuff into os_posix.cpp ? >>>>> There's a thought! >>>>> I'll investigate that route, it could get things to look nicer. >>>>> >>>>> >>>>>> Cheers, >>>>>> David >>>>> Regards, >>>>> Nils Loodin >>>>> >>> >> From david.holmes at oracle.com Tue May 8 01:18:35 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 08 May 2012 18:18:35 +1000 Subject: RFR - BUG7163117: SA Agent can't connect to process on Mac OSX In-Reply-To: <5F398A66-C73A-443B-B4FB-36A30D31953E@oracle.com> References: <6492C401-0DC1-466C-8747-C27444408CDF@oracle.com> <380ADA04-9AE5-4B42-A37D-2FA7F188951A@oracle.com> <7363224D-2724-4188-AB18-4812CDA12E5B@oracle.com> <5F398A66-C73A-443B-B4FB-36A30D31953E@oracle.com> Message-ID: <4FA8D6DB.5010909@oracle.com> On 8/05/2012 5:48 PM, Nils Loodin wrote: > Can I get a Reviewer to look at this? Does no reviewer care about SA? :) Don't have a Mac or know inner details of BSD/OSX ;-) Changes to x86_64 seem okay though it seems a little odd to accept amd64 but report the only valid values are x86/x86_64. Also I'm a little confused ... some of this is not BSD/OSX specific and we should already support x86_64 for Linux/Solaris shouldn't we? (I guess not but why not? we don't use amd64 on any platform any more). David > Regards > Nils Loodin > > > On May 4, 2012, at 13:01 , Nils Loodin wrote: > >> Built it and connected to a running java process and ran some commands. >> I see other issues, but the connecting part actually works now. >> >> This will probably open up more bugs. >> >> /Nils Loodin >> >> On May 4, 2012, at 12:05 , Staffan Larsen wrote: >> >>> Looks good. I can sponsor the push. >>> >>> What kind of testing have you done? >>> >>> /Staffan >>> >>> On 4 maj 2012, at 11:28, Nils Loodin wrote: >>> >>>> looking for cpu-arch "amd64" only, and not "x86_64" as mac osx is using nowadays. >>>> >>>> http://cr.openjdk.java.net/~nloodin/7163117/webrev.00/ >>>> >>>> >>>> >>>> Need reviews and a sponsor! >>>> Regards, >>>> Nils Loodin >>> >> > From david.holmes at oracle.com Tue May 8 01:30:16 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 08 May 2012 18:30:16 +1000 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: <15E71A00-D43E-457C-A5AB-38E10D9184D3@oracle.com> References: <4FA109E5.2020309@oracle.com> <4FA121F8.3080008@oracle.com> <8372B427-9B5F-4DE0-88A7-10025623B257@oracle.com> <35EE9EE2-C0CA-4A04-A91B-0B54C5923C6A@oracle.com> <4FA8B11A.50401@oracle.com> <15E71A00-D43E-457C-A5AB-38E10D9184D3@oracle.com> Message-ID: <4FA8D998.20304@oracle.com> On 8/05/2012 6:03 PM, Nils Loodin wrote: > Hrm, sorry about that people, The webrev number should have been bumped from 00 to 01. :) > > http://cr.openjdk.java.net/~nloodin/7165755/webrev.01/ Why are all the os_XXX.cpp files now explicitly #including their os_XXX.hpp counterpart? Was this something previously missing from the great includeDB conversion? src/os/posix/vm/os_posix.cpp 115 //Isn't there on OSX 116 #ifdef __APPLE__ Shouldn't that be ifndef ? Any why test __APPLE__ instead of for BSD/OSX eg TARGET_OS_FAMILY_bsd? Otherwise seems okay. David ----- > Nisse > > On May 8, 2012, at 07:37 , David Holmes wrote: > >> On 4/05/2012 6:26 PM, Nils Loodin wrote: >>> Updated this with pulling out some shared code to os_posix.cpp. >>> Some methods were different enough that this wasn't possible though. >>> >>> Do you like this better? >>> >>> Webrev: >>> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ >> >> I don't see any os_posix.cpp changes here? >> >> David >> ----- >> >> >>> On May 2, 2012, at 14:08 , Nils Loodin wrote: >>> >>>> >>>> On May 2, 2012, at 14:00 , David Holmes wrote: >>>> >>>>> Hi Nils, >>>>> >>>>> On 2/05/2012 9:56 PM, Nils Loodin wrote: >>>>>>> Ignoring Windows (with prints very little) I'd say it is the printing of /proc/meminfo that is the main difference. Not sure why printing that was necessary ... but if we are going to remove it I think we need to know why it was added. >>>>>> Yes, that's the reason. >>>>>> Note that nothing is removed. The method still prints exactly the same info, but I introduced another method to print briefer info, to be kinder to tool developers. >>>>> >>>>> The current one prints /proc/meminfo. You turned that code into print_full_memory_info but in the main routine you call print_memory_info. Was that a mistake? >>>> >>>> YES! Glad you caught that :) Guess (or hope) it would have been caught in dump testing otherwise :) >>>> >>>> Regards, >>>> Nils Loodin >>>> >>>> >>>>> >>>>> David >>>>> >>>>>> I really don't want to change the output for say, hs_err files, where I believe this info is used. >>>>>> >>>>>>> >>>>>>>> This can make it hard for tool writers to get a summary that look good and similar for multiple platforms (sizing of gui fields, having to parse info in the tool code etc) >>>>>>>> Lookin at the code, it's in some serious need of refactoring. It would be nice with a method to get a "brief" os info for these kinds of tools that looks similar on all platforms. >>>>>>>> >>>>>>>> This is my suggested change: >>>>>>>> http://cr.openjdk.java.net/~nloodin/7165755/webrev.00/ >>>>>>> >>>>>>> Seems to me some of this could be factored into the top-level OS class if we shoehorn Windows into the same shape as the other OSes ;-) >>>>>> This was my first attempt also, but then a lot of empty windows-methods ensued, which was kind of ugly. >>>>>> >>>>>>> Or at least perhaps put some of the common stuff into os_posix.cpp ? >>>>>> There's a thought! >>>>>> I'll investigate that route, it could get things to look nicer. >>>>>> >>>>>> >>>>>>> Cheers, >>>>>>> David >>>>>> Regards, >>>>>> Nils Loodin >>>>>> >>>> >>> > From Ulf.Zibis at gmx.de Tue May 8 03:02:51 2012 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Tue, 08 May 2012 12:02:51 +0200 Subject: hg: jdk8/tl/jdk: 7103570: AtomicIntegerFieldUpdater does not work when SecurityManager is installed In-Reply-To: <20120508073706.E5A36471B4@hg.openjdk.java.net> References: <20120508073706.E5A36471B4@hg.openjdk.java.net> Message-ID: <4FA8EF4B.5070508@gmx.de> Hi all, I'm a little bit late, but I just have seen: (1) some indentations in the patch are broken (2) following code snipped is repeated many times: + ClassLoader cl = tclass.getClassLoader(); + ClassLoader ccl = caller.getClassLoader(); + if ((ccl != null) && (ccl != cl) && + ((cl == null) || !isAncestor(cl, ccl))) { + sun.reflect.misc.ReflectUtil.checkPackageAccess(tclass); + } Wouldn't it be better, to move it in a method, maybe in sun.reflect.misc.ReflectUtil ? -Ulf Am 08.05.2012 09:36, schrieb david.holmes at oracle.com: > Changeset: 48513d156965 > Author: dholmes > Date: 2012-05-08 02:59 -0400 > URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48513d156965 > > 7103570: AtomicIntegerFieldUpdater does not work when SecurityManager is installed > Summary: Perform class.getField inside a doPrivileged block > Reviewed-by: chegar, psandoz > > ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java > ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java > ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java > + test/java/util/concurrent/atomic/AtomicUpdaters.java > > From staffan.larsen at oracle.com Tue May 8 04:11:38 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 8 May 2012 13:11:38 +0200 Subject: RFR (L): Adding core file parsing on Mac OS X to SA Message-ID: <06CFCD3A-A8F4-4FDE-B8CD-D201C892AA30@oracle.com> The Serviceability Agent currently has an outage on Mac OS X compared to other platforms in that we cannot read core files. We plan to address this for 7u6 by incorporating code from a separate tool called "kjdb" developed at Oracle. Kjdb is a cross-platform core-file debugger written completely in Java that currently works on ELF (solaris, linux) and Mach-O (mac) core files. Since it is written in Java it can read core files from a different system than the system you are running kjdb on, which is very useful. The alternative to incorporating the kjdb technology would have been to implement this in C as is done for the other platforms, but reusing existing code saves us some trouble. The kjdb debugger backend will automatically be enabled when you are opening a Mach-O core file (or if you explicitly set the -Duse.kjdb property when starting SA). The risks with this is that this is a large addition of relatively new code to SA (around 100 files). It also means that debugging a live process or a core file on OS X will use different debugger backends which may have different behavior and bugs. This change also adds a basic test that creates a core file and uses SA to print the thread dumps in the core. This test runs on all platforms, not just Mac OS X. Other than that test, some level of manual testing has been done with various core files. Please see the webrev at: http://cr.openjdk.java.net/~sla/kjdb/webrev.01/ There are quite a number of added files in this webrev, so it's probably best to concentrate on the changes in the existing files. Thanks, /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120508/8044888d/attachment.html From kevin.walls at oracle.com Tue May 8 05:10:13 2012 From: kevin.walls at oracle.com (Kevin Walls) Date: Tue, 08 May 2012 13:10:13 +0100 Subject: RFR (L): Adding core file parsing on Mac OS X to SA In-Reply-To: <06CFCD3A-A8F4-4FDE-B8CD-D201C892AA30@oracle.com> References: <06CFCD3A-A8F4-4FDE-B8CD-D201C892AA30@oracle.com> Message-ID: <4FA90D25.8010000@oracle.com> Hi - Just a note that I'd like to contribute a cleaner way for the Debugger and Process classes here to load a core file, which I hadn't yet handed over. I'll have that ready shortly... Thanks Kevin On 08/05/12 12:11, Staffan Larsen wrote: > The Serviceability Agent currently has an outage on Mac OS X compared > to other platforms in that we cannot read core files. We plan to > address this for 7u6 by incorporating code from a separate tool called > "kjdb" developed at Oracle. Kjdb is a cross-platform core-file > debugger written completely in Java that currently works on ELF > (solaris, linux) and Mach-O (mac) core files. Since it is written in > Java it can read core files from a different system than the system > you are running kjdb on, which is very useful. > > The alternative to incorporating the kjdb technology would have been > to implement this in C as is done for the other platforms, but reusing > existing code saves us some trouble. The kjdb debugger backend will > automatically be enabled when you are opening a Mach-O core file (or > if you explicitly set the -Duse.kjdb property when starting SA). > > The risks with this is that this is a large addition of relatively new > code to SA (around 100 files). It also means that debugging a live > process or a core file on OS X will use different debugger backends > which may have different behavior and bugs. > > This change also adds a basic test that creates a core file and uses > SA to print the thread dumps in the core. This test runs on all > platforms, not just Mac OS X. Other than that test, some level of > manual testing has been done with various core files. > > Please see the webrev at: > http://cr.openjdk.java.net/~sla/kjdb/webrev.01/ > > > There are quite a number of added files in this webrev, so it's > probably best to concentrate on the changes in the existing files. > > Thanks, > /Staffan From luchsh at linux.vnet.ibm.com Tue May 8 06:13:23 2012 From: luchsh at linux.vnet.ibm.com (Jonathan Lu) Date: Tue, 08 May 2012 21:13:23 +0800 Subject: Request for Review: 7165722 invalid path in MemoryMonitor demo's README.txt In-Reply-To: <4FA1E6A6.6030505@linux.vnet.ibm.com> References: <4FA0F004.3090407@linux.vnet.ibm.com> <4FA0F215.2040605@oracle.com> <4FA1E6A6.6030505@linux.vnet.ibm.com> Message-ID: <4FA91BF3.20006@linux.vnet.ibm.com> Hi serviceability-dev, is it OK to push this change? Thanks! On 05/03/2012 10:00 AM, Jonathan Lu wrote: > Thanks a lot, Alan. > > I'll go to serviceability-dev list for further discussion. > > Best regards! > > - Jonathan Lu > > On 05/02/2012 04:36 PM, Alan Bateman wrote: >> On 02/05/2012 09:27, Jonathan Lu wrote: >>> Hi build-dev, >>> >>> I've got a minor change to fix an invalid path from README.txt of >>> MemoryMonitor demo, could anybody please help to take a look? >>> >>> http://cr.openjdk.java.net/~luchsh/7165722/ >>> >>> Best regards! >>> - Jonathan >>> >> 7165722 was submitted as an incident and I've moved it to the right >> place. Also cc'ing serviceability-dev as that is where these >> java.lang.management demos came from. >> >> The patch looks fine and I assume Charles will push it for you. >> >> -Alan. >> > From staffan.larsen at oracle.com Tue May 8 06:24:21 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 8 May 2012 15:24:21 +0200 Subject: Request for Review: 7165722 invalid path in MemoryMonitor demo's README.txt In-Reply-To: <4FA91BF3.20006@linux.vnet.ibm.com> References: <4FA0F004.3090407@linux.vnet.ibm.com> <4FA0F215.2040605@oracle.com> <4FA1E6A6.6030505@linux.vnet.ibm.com> <4FA91BF3.20006@linux.vnet.ibm.com> Message-ID: <06F51AD8-48C5-4FEC-8789-F0AAA3C47620@oracle.com> Looks good to me. Do you want me to push it for you? /Staffan On 8 maj 2012, at 15:13, Jonathan Lu wrote: > Hi serviceability-dev, > > is it OK to push this change? > > Thanks! > > On 05/03/2012 10:00 AM, Jonathan Lu wrote: >> Thanks a lot, Alan. >> >> I'll go to serviceability-dev list for further discussion. >> >> Best regards! >> >> - Jonathan Lu >> >> On 05/02/2012 04:36 PM, Alan Bateman wrote: >>> On 02/05/2012 09:27, Jonathan Lu wrote: >>>> Hi build-dev, >>>> >>>> I've got a minor change to fix an invalid path from README.txt of MemoryMonitor demo, could anybody please help to take a look? >>>> >>>> http://cr.openjdk.java.net/~luchsh/7165722/ >>>> >>>> Best regards! >>>> - Jonathan >>>> >>> 7165722 was submitted as an incident and I've moved it to the right place. Also cc'ing serviceability-dev as that is where these java.lang.management demos came from. >>> >>> The patch looks fine and I assume Charles will push it for you. >>> >>> -Alan. >>> >> > From nils.loodin at oracle.com Tue May 8 06:28:50 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Tue, 8 May 2012 15:28:50 +0200 Subject: RFR - BUG7163117: SA Agent can't connect to process on Mac OSX In-Reply-To: <4FA918E1.8090606@oracle.com> References: <6492C401-0DC1-466C-8747-C27444408CDF@oracle.com> <380ADA04-9AE5-4B42-A37D-2FA7F188951A@oracle.com> <7363224D-2724-4188-AB18-4812CDA12E5B@oracle.com> <5F398A66-C73A-443B-B4FB-36A30D31953E@oracle.com> <4FA918E1.8090606@oracle.com> Message-ID: <38BA8777-3225-49CB-BC10-9FE848746E78@oracle.com> On May 8, 2012, at 15:00 , Coleen Phillimore wrote: > Actually, I reviewed this and why do you have an extra set of parenthesis around the second clause? I don't think they help anything and look kind of odd. > > + } else if (cpu.equals("amd64") || (cpu.equals("x86_64"))) { > > maybe instead } else if (cpu.equals("amd64") || cpu.equals("x86_64")) { Whoops, no reason at all, just a typo. Regards, Nils Loodin From nils.loodin at oracle.com Tue May 8 06:39:05 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Tue, 8 May 2012 15:39:05 +0200 Subject: RFR - BUG7163117: SA Agent can't connect to process on Mac OSX In-Reply-To: <4FA8D6DB.5010909@oracle.com> References: <6492C401-0DC1-466C-8747-C27444408CDF@oracle.com> <380ADA04-9AE5-4B42-A37D-2FA7F188951A@oracle.com> <7363224D-2724-4188-AB18-4812CDA12E5B@oracle.com> <5F398A66-C73A-443B-B4FB-36A30D31953E@oracle.com> <4FA8D6DB.5010909@oracle.com> Message-ID: <26B4616C-DFF5-4A57-A0DF-E8A7DF3AE3EE@oracle.com> Hey David! On May 8, 2012, at 10:18 , David Holmes wrote: > Changes to x86_64 seem okay though it seems a little odd to accept amd64 but report the only valid values are x86/x86_64. I guess you mean that I've changed the exception output like this: - throw new DebuggerException("Bsd only supported on x86/amd64"); + throw new DebuggerException("Bsd only supported on x86/x86_64. Current arch: " + cpu); I interpreted the existing output to refer to bitness, and not to the actual string of the cpu. However, since we changed the string used to refer to the cpu on mac to be "x86_64" from "amd64", I thought it best to mention the actual string we expected in the checks however. Do you think this is a bad idea? > > Also I'm a little confused ... some of this is not BSD/OSX specific and we should already support x86_64 for Linux/Solaris shouldn't we? (I guess not but why not? we don't use amd64 on any platform any more). This confuse me too. I changed some places where it seemed to break for OSX. In general, I'd say that the code checks the cpu-string far to often and is in need of some serious refactorisation. Regards, Nils Loodin. > > David > >> Regards >> Nils Loodin >> >> >> On May 4, 2012, at 13:01 , Nils Loodin wrote: >> >>> Built it and connected to a running java process and ran some commands. >>> I see other issues, but the connecting part actually works now. >>> >>> This will probably open up more bugs. >>> >>> /Nils Loodin >>> >>> On May 4, 2012, at 12:05 , Staffan Larsen wrote: >>> >>>> Looks good. I can sponsor the push. >>>> >>>> What kind of testing have you done? >>>> >>>> /Staffan >>>> >>>> On 4 maj 2012, at 11:28, Nils Loodin wrote: >>>> >>>>> looking for cpu-arch "amd64" only, and not "x86_64" as mac osx is using nowadays. >>>>> >>>>> http://cr.openjdk.java.net/~nloodin/7163117/webrev.00/ >>>>> >>>>> >>>>> >>>>> Need reviews and a sponsor! >>>>> Regards, >>>>> Nils Loodin >>>> >>> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120508/2e500d0b/attachment.html From mikael.gerdin at oracle.com Tue May 8 08:17:14 2012 From: mikael.gerdin at oracle.com (Mikael Gerdin) Date: Tue, 08 May 2012 17:17:14 +0200 Subject: RFR (L): Adding core file parsing on Mac OS X to SA In-Reply-To: <06CFCD3A-A8F4-4FDE-B8CD-D201C892AA30@oracle.com> References: <06CFCD3A-A8F4-4FDE-B8CD-D201C892AA30@oracle.com> Message-ID: <4FA938FA.2030306@oracle.com> Staffan, I looked through test makefile changes and the white box test, the changes seem alright but I'm not convinced that using a white box test for this is the best approach. There are some existing tests for the error handler and hs_err creation in test_error_handler in debug.cpp (look for use of the ErrorHandlerTest flag) I realize that this would not work for your test since you use jstack to verify that the SA works and ErrorHandlerTest crashes the VM before any Java frames are on the stack. But it would be great if we could re-use the existing code to force the VM to crash instead of duplicating it. Anyway, I won't object to the changes in their current state (and I'm not a Committer, so don't listen to me). /mg On 2012-05-08 13:11, Staffan Larsen wrote: > The Serviceability Agent currently has an outage on Mac OS X compared to > other platforms in that we cannot read core files. We plan to address > this for 7u6 by incorporating code from a separate tool called "kjdb" > developed at Oracle. Kjdb is a cross-platform core-file debugger written > completely in Java that currently works on ELF (solaris, linux) and > Mach-O (mac) core files. Since it is written in Java it can read core > files from a different system than the system you are running kjdb on, > which is very useful. > > The alternative to incorporating the kjdb technology would have been to > implement this in C as is done for the other platforms, but reusing > existing code saves us some trouble. The kjdb debugger backend will > automatically be enabled when you are opening a Mach-O core file (or if > you explicitly set the -Duse.kjdb property when starting SA). > > The risks with this is that this is a large addition of relatively new > code to SA (around 100 files). It also means that debugging a live > process or a core file on OS X will use different debugger backends > which may have different behavior and bugs. > > This change also adds a basic test that creates a core file and uses SA > to print the thread dumps in the core. This test runs on all platforms, > not just Mac OS X. Other than that test, some level of manual testing > has been done with various core files. > > Please see the webrev at: http://cr.openjdk.java.net/~sla/kjdb/webrev.01/ > > There are quite a number of added files in this webrev, so it's probably > best to concentrate on the changes in the existing files. > > Thanks, > /Staffan From kelly.ohair at oracle.com Tue May 8 08:27:00 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Tue, 8 May 2012 08:27:00 -0700 Subject: RFR (L): Adding core file parsing on Mac OS X to SA In-Reply-To: <06CFCD3A-A8F4-4FDE-B8CD-D201C892AA30@oracle.com> References: <06CFCD3A-A8F4-4FDE-B8CD-D201C892AA30@oracle.com> Message-ID: On May 8, 2012, at 4:11 AM, Staffan Larsen wrote: > The Serviceability Agent currently has an outage on Mac OS X compared to other platforms in that we cannot read core files. We plan to address this for 7u6 by incorporating code from a separate tool called "kjdb" developed at Oracle. Kjdb is a cross-platform core-file debugger written completely in Java that currently works on ELF (solaris, linux) and Mach-O (mac) core files. Since it is written in Java it can read core files from a different system than the system you are running kjdb on, which is very useful. Keep in mind that a core file usually does not capture the entire process image, shared system library text sections (shared code of the system) is typically not included, which creates a situation where a core file cannot be transported from the specific system it was created on and interpreted 100% correctly on any similar system. Unless you can guarantee that the two systems have the exact same system shared libraries. As far as I know, there is no tracking of this issue, and consequently, core files can only be trusted to be valid on the system that created it. We had many discussions on this topic when I was in the dbx team. First there is a question of validation, 'how do you know the use of the core file is correct?' and then how do you get the right information 'can we access the shared libraries of the system that created the core file?' So be careful with core files, even as big as they are, there is missing information, and they become less and less accurate as you drift away from the system that created it. Having given you my warning on core files.... It has been a long time since I used libelf and walked around Elf files, now you have me curious what this Java code looks like. It is an interesting idea/approach. -kto > > The alternative to incorporating the kjdb technology would have been to implement this in C as is done for the other platforms, but reusing existing code saves us some trouble. The kjdb debugger backend will automatically be enabled when you are opening a Mach-O core file (or if you explicitly set the -Duse.kjdb property when starting SA). > > The risks with this is that this is a large addition of relatively new code to SA (around 100 files). It also means that debugging a live process or a core file on OS X will use different debugger backends which may have different behavior and bugs. > > This change also adds a basic test that creates a core file and uses SA to print the thread dumps in the core. This test runs on all platforms, not just Mac OS X. Other than that test, some level of manual testing has been done with various core files. > > Please see the webrev at: http://cr.openjdk.java.net/~sla/kjdb/webrev.01/ > > There are quite a number of added files in this webrev, so it's probably best to concentrate on the changes in the existing files. > > Thanks, > /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120508/4c7f8fc9/attachment.html From daniel.daugherty at oracle.com Tue May 8 08:59:07 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 08 May 2012 09:59:07 -0600 Subject: Request for review (XS): Wrong filter predicate of visible locals in SA JSJavaFrame In-Reply-To: References: Message-ID: <4FA942CB.1050007@oracle.com> Thumbs up! Thanks for including a sample failure and a sample success. agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaFrame.java No comments. Dan On 4/23/12 9:05 PM, Krystal Mok wrote: > Hi all, > > Could I get a review for this patch, please? > > Regards, > Kris > > On Thu, Apr 19, 2012 at 3:55 PM, Krystal Mok > wrote: > > Thanks, Staffan :-) > > - Kris > > > On Thu, Apr 19, 2012 at 3:53 PM, Staffan Larsen > > wrote: > > Hi Kris, > > This fix looks good to me. I've created a bug for > you: 7162726. I'll be happy to push the fix for you once the > review is done (need one Reviewer). > > Thanks, > /Staffan > > On 19 apr 2012, at 06:49, Krystal Mok wrote: > >> Hi all, >> >> There seems to be a bug in the filtering logic of visible >> local variable in Serviceability Agent's JSJavaFrame. >> >> I've made a patch here: [1]. The diff is against tip of >> jdk8/jdk8/hotspot >> An example of running CLHSDB before and after applying the >> patch is avaiable [2]. >> >> Could anyone please review this for me? >> >> - Kris >> >> [1]: https://gist.github.com/2418558#file_getlocal.patch >> [2]: https://gist.github.com/2418558#file_clhsdb_session2 > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120508/4cff4c3d/attachment-0001.html From rednaxelafx at gmail.com Tue May 8 09:23:25 2012 From: rednaxelafx at gmail.com (Krystal Mok) Date: Wed, 9 May 2012 00:23:25 +0800 Subject: Request for review (XS): Wrong filter predicate of visible locals in SA JSJavaFrame In-Reply-To: <4FA942CB.1050007@oracle.com> References: <4FA942CB.1050007@oracle.com> Message-ID: Thanks, Dan ^_^ - Kris On Tue, May 8, 2012 at 11:59 PM, Daniel D. Daugherty < daniel.daugherty at oracle.com> wrote: > ** > Thumbs up! > > Thanks for including a sample failure and a sample success. > > agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaFrame.java > No comments. > > Dan > > > On 4/23/12 9:05 PM, Krystal Mok wrote: > > Hi all, > > Could I get a review for this patch, please? > > Regards, > Kris > > On Thu, Apr 19, 2012 at 3:55 PM, Krystal Mok wrote: > >> Thanks, Staffan :-) >> >> - Kris >> >> >> On Thu, Apr 19, 2012 at 3:53 PM, Staffan Larsen < >> staffan.larsen at oracle.com> wrote: >> >>> Hi Kris, >>> >>> This fix looks good to me. I've created a bug for you: 7162726. I'll >>> be happy to push the fix for you once the review is done (need one >>> Reviewer). >>> >>> Thanks, >>> /Staffan >>> >>> On 19 apr 2012, at 06:49, Krystal Mok wrote: >>> >>> Hi all, >>> >>> There seems to be a bug in the filtering logic of visible local >>> variable in Serviceability Agent's JSJavaFrame. >>> >>> I've made a patch here: [1]. The diff is against tip of >>> jdk8/jdk8/hotspot >>> An example of running CLHSDB before and after applying the patch is >>> avaiable [2]. >>> >>> Could anyone please review this for me? >>> >>> - Kris >>> >>> [1]: https://gist.github.com/2418558#file_getlocal.patch >>> [2]: https://gist.github.com/2418558#file_clhsdb_session2 >>> >>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120509/cdcfe36d/attachment.html From staffan.larsen at oracle.com Tue May 8 10:20:47 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 8 May 2012 19:20:47 +0200 Subject: RFR (L): Adding core file parsing on Mac OS X to SA In-Reply-To: <4FA90D25.8010000@oracle.com> References: <06CFCD3A-A8F4-4FDE-B8CD-D201C892AA30@oracle.com> <4FA90D25.8010000@oracle.com> Message-ID: <6D712B96-F212-4337-BD61-AFB22ECDB0CB@oracle.com> Here are some late breaking additions that Kevin sent me. These are only changes to the kjdb core. Full webrev: http://cr.openjdk.java.net/~sla/kjdb/webrev.02/ Difference from the last webrev: http://cr.openjdk.java.net/~sla/kjdb/webrev.02-delta/ And I should add credit where credit is due. The kjdb implementation is all Kevin Walls' great work. Integration in SA and tests are my work. Any errors are of course my fault as well. Thanks, /Staffan On 8 maj 2012, at 14:10, Kevin Walls wrote: > > Hi - > > Just a note that I'd like to contribute a cleaner way for the Debugger and Process classes here to load a core file, which I hadn't yet handed over. I'll have that ready shortly... > > Thanks > Kevin > > On 08/05/12 12:11, Staffan Larsen wrote: >> The Serviceability Agent currently has an outage on Mac OS X compared to other platforms in that we cannot read core files. We plan to address this for 7u6 by incorporating code from a separate tool called "kjdb" developed at Oracle. Kjdb is a cross-platform core-file debugger written completely in Java that currently works on ELF (solaris, linux) and Mach-O (mac) core files. Since it is written in Java it can read core files from a different system than the system you are running kjdb on, which is very useful. >> >> The alternative to incorporating the kjdb technology would have been to implement this in C as is done for the other platforms, but reusing existing code saves us some trouble. The kjdb debugger backend will automatically be enabled when you are opening a Mach-O core file (or if you explicitly set the -Duse.kjdb property when starting SA). >> >> The risks with this is that this is a large addition of relatively new code to SA (around 100 files). It also means that debugging a live process or a core file on OS X will use different debugger backends which may have different behavior and bugs. >> >> This change also adds a basic test that creates a core file and uses SA to print the thread dumps in the core. This test runs on all platforms, not just Mac OS X. Other than that test, some level of manual testing has been done with various core files. >> >> Please see the webrev at: http://cr.openjdk.java.net/~sla/kjdb/webrev.01/ >> >> There are quite a number of added files in this webrev, so it's probably best to concentrate on the changes in the existing files. >> >> Thanks, >> /Staffan > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120508/62b037d4/attachment.html From staffan.larsen at oracle.com Tue May 8 10:28:48 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 8 May 2012 19:28:48 +0200 Subject: RFR (L): Adding core file parsing on Mac OS X to SA In-Reply-To: <4FA938FA.2030306@oracle.com> References: <06CFCD3A-A8F4-4FDE-B8CD-D201C892AA30@oracle.com> <4FA938FA.2030306@oracle.com> Message-ID: <25E1827D-F7CC-4A7B-811D-F559DAEA8A12@oracle.com> Good one - I wasn't aware of the ErrorHandlerTest. I agree that duplication of code is not good and perhaps the whitebox API is overkill for the job at hand. I see other tests uses sun.misc.Unsafe to cause crashes which may make more sense than reusing the ErrorHandlerTest since I want Java frames on the stack. On the other hand I can envision expanding the test to check for both Java frames and native C++ frames, in which case neither ErrorHandlerTest or sun.misc.Unsafe works out of the box. > (and I'm not a Committer, so don't listen to me). Of course I do. Ideas are welcome, /Staffan On 8 maj 2012, at 17:17, Mikael Gerdin wrote: > Staffan, > > I looked through test makefile changes and the white box test, the changes seem alright but I'm not convinced that using a white box test for this is the best approach. > There are some existing tests for the error handler and hs_err creation in test_error_handler in debug.cpp (look for use of the ErrorHandlerTest flag) > > I realize that this would not work for your test since you use jstack to verify that the SA works and ErrorHandlerTest crashes the VM before any Java frames are on the stack. But it would be great if we could re-use the existing code to force the VM to crash instead of duplicating it. > > Anyway, I won't object to the changes in their current state > > /mg > > On 2012-05-08 13:11, Staffan Larsen wrote: >> The Serviceability Agent currently has an outage on Mac OS X compared to >> other platforms in that we cannot read core files. We plan to address >> this for 7u6 by incorporating code from a separate tool called "kjdb" >> developed at Oracle. Kjdb is a cross-platform core-file debugger written >> completely in Java that currently works on ELF (solaris, linux) and >> Mach-O (mac) core files. Since it is written in Java it can read core >> files from a different system than the system you are running kjdb on, >> which is very useful. >> >> The alternative to incorporating the kjdb technology would have been to >> implement this in C as is done for the other platforms, but reusing >> existing code saves us some trouble. The kjdb debugger backend will >> automatically be enabled when you are opening a Mach-O core file (or if >> you explicitly set the -Duse.kjdb property when starting SA). >> >> The risks with this is that this is a large addition of relatively new >> code to SA (around 100 files). It also means that debugging a live >> process or a core file on OS X will use different debugger backends >> which may have different behavior and bugs. >> >> This change also adds a basic test that creates a core file and uses SA >> to print the thread dumps in the core. This test runs on all platforms, >> not just Mac OS X. Other than that test, some level of manual testing >> has been done with various core files. >> >> Please see the webrev at: http://cr.openjdk.java.net/~sla/kjdb/webrev.01/ >> >> There are quite a number of added files in this webrev, so it's probably >> best to concentrate on the changes in the existing files. >> >> Thanks, >> /Staffan From staffan.larsen at oracle.com Tue May 8 10:31:05 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 8 May 2012 19:31:05 +0200 Subject: RFR (L): Adding core file parsing on Mac OS X to SA In-Reply-To: References: <06CFCD3A-A8F4-4FDE-B8CD-D201C892AA30@oracle.com> Message-ID: <286724B0-6374-4001-B705-350842ED1941@oracle.com> Right you are. Playing with core files can bite you. While this code enables you to look at core files on a different platform, it does not require it. There is support in SA for moving library files from a different system (via the SA_ALT_ROOT environment variable). /Staffan On 8 maj 2012, at 17:27, Kelly O'Hair wrote: > > On May 8, 2012, at 4:11 AM, Staffan Larsen wrote: > >> The Serviceability Agent currently has an outage on Mac OS X compared to other platforms in that we cannot read core files. We plan to address this for 7u6 by incorporating code from a separate tool called "kjdb" developed at Oracle. Kjdb is a cross-platform core-file debugger written completely in Java that currently works on ELF (solaris, linux) and Mach-O (mac) core files. Since it is written in Java it can read core files from a different system than the system you are running kjdb on, which is very useful. > > Keep in mind that a core file usually does not capture the entire process image, shared system library text sections (shared code of the system) > is typically not included, which creates a situation where a core file cannot be transported from the specific system it was created on > and interpreted 100% correctly on any similar system. Unless you can guarantee that the two systems have the exact same system shared libraries. > As far as I know, there is no tracking of this issue, and consequently, core files can only be trusted to be valid on the system that created it. > > We had many discussions on this topic when I was in the dbx team. First there is a question of validation, 'how do you know the use of the core file is correct?' > and then how do you get the right information 'can we access the shared libraries of the system that created the core file?' > > So be careful with core files, even as big as they are, there is missing information, and they become less and less accurate as > you drift away from the system that created it. > > Having given you my warning on core files.... It has been a long time since I used libelf and walked around Elf files, > now you have me curious what this Java code looks like. It is an interesting idea/approach. > > -kto > >> >> The alternative to incorporating the kjdb technology would have been to implement this in C as is done for the other platforms, but reusing existing code saves us some trouble. The kjdb debugger backend will automatically be enabled when you are opening a Mach-O core file (or if you explicitly set the -Duse.kjdb property when starting SA). >> >> The risks with this is that this is a large addition of relatively new code to SA (around 100 files). It also means that debugging a live process or a core file on OS X will use different debugger backends which may have different behavior and bugs. >> >> This change also adds a basic test that creates a core file and uses SA to print the thread dumps in the core. This test runs on all platforms, not just Mac OS X. Other than that test, some level of manual testing has been done with various core files. >> >> Please see the webrev at: http://cr.openjdk.java.net/~sla/kjdb/webrev.01/ >> >> There are quite a number of added files in this webrev, so it's probably best to concentrate on the changes in the existing files. >> >> Thanks, >> /Staffan > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120508/45ab6898/attachment-0001.html From vladimir.kozlov at oracle.com Tue May 8 09:39:31 2012 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Tue, 08 May 2012 09:39:31 -0700 Subject: RFR - BUG7163117: SA Agent can't connect to process on Mac OSX In-Reply-To: <5F398A66-C73A-443B-B4FB-36A30D31953E@oracle.com> References: <6492C401-0DC1-466C-8747-C27444408CDF@oracle.com> <380ADA04-9AE5-4B42-A37D-2FA7F188951A@oracle.com> <7363224D-2724-4188-AB18-4812CDA12E5B@oracle.com> <5F398A66-C73A-443B-B4FB-36A30D31953E@oracle.com> Message-ID: <4FA94C43.7080205@oracle.com> Nils Loodin wrote: > Can I get a Reviewer to look at this? Does no reviewer care about SA? :) We do care about SA :) Changes looks good. Vladimir > > Regards > Nils Loodin > > > On May 4, 2012, at 13:01 , Nils Loodin wrote: > >> Built it and connected to a running java process and ran some commands. >> I see other issues, but the connecting part actually works now. >> >> This will probably open up more bugs. >> >> /Nils Loodin >> >> On May 4, 2012, at 12:05 , Staffan Larsen wrote: >> >>> Looks good. I can sponsor the push. >>> >>> What kind of testing have you done? >>> >>> /Staffan >>> >>> On 4 maj 2012, at 11:28, Nils Loodin wrote: >>> >>>> looking for cpu-arch "amd64" only, and not "x86_64" as mac osx is using nowadays. >>>> >>>> http://cr.openjdk.java.net/~nloodin/7163117/webrev.00/ >>>> >>>> >>>> >>>> Need reviews and a sponsor! >>>> Regards, >>>> Nils Loodin > From xueming.shen at oracle.com Tue May 8 10:55:29 2012 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 08 May 2012 17:55:29 +0000 Subject: hg: jdk8/tl/jdk: 7014640: To add a metachar \R for line ending and character classes for vertical/horizontal ws \v \V \h \H Message-ID: <20120508175547.56E86471C5@hg.openjdk.java.net> Changeset: af209a223b6b Author: sherman Date: 2012-05-08 10:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af209a223b6b 7014640: To add a metachar \R for line ending and character classes for vertical/horizontal ws \v \V \h \H Summary: added propsoed constructs Reviewed-by: alanb ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java From yumin.qi at oracle.com Tue May 8 11:07:30 2012 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Tue, 08 May 2012 11:07:30 -0700 Subject: RFR - BUG7163117: SA Agent can't connect to process on Mac OSX In-Reply-To: <7363224D-2724-4188-AB18-4812CDA12E5B@oracle.com> References: <6492C401-0DC1-466C-8747-C27444408CDF@oracle.com> <380ADA04-9AE5-4B42-A37D-2FA7F188951A@oracle.com> <7363224D-2724-4188-AB18-4812CDA12E5B@oracle.com> Message-ID: <4FA960E2.2010206@oracle.com> Looks good! Yumin On 5/4/2012 4:01 AM, Nils Loodin wrote: > Built it and connected to a running java process and ran some commands. > I see other issues, but the connecting part actually works now. > > This will probably open up more bugs. > > /Nils Loodin > > On May 4, 2012, at 12:05 , Staffan Larsen wrote: > >> Looks good. I can sponsor the push. >> >> What kind of testing have you done? >> >> /Staffan >> >> On 4 maj 2012, at 11:28, Nils Loodin wrote: >> >>> looking for cpu-arch "amd64" only, and not "x86_64" as mac osx is using nowadays. >>> >>> http://cr.openjdk.java.net/~nloodin/7163117/webrev.00/ >>> >>> >>> >>> Need reviews and a sponsor! >>> Regards, >>> Nils Loodin From xueming.shen at oracle.com Tue May 8 11:14:46 2012 From: xueming.shen at oracle.com (xueming.shen at oracle.com) Date: Tue, 08 May 2012 18:14:46 +0000 Subject: hg: jdk8/tl/jdk: 7157656: (zipfs) SeekableByteChannel to entry in zip file always reports its position as 0 Message-ID: <20120508181456.B16E4471C6@hg.openjdk.java.net> Changeset: 1ece20885be4 Author: sherman Date: 2012-05-08 11:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ece20885be4 7157656: (zipfs) SeekableByteChannel to entry in zip file always reports its position as 0 Summary: updated SeekableByteChannel.read() to count the bytes read correctly Reviewed-by: sherman Contributed-by: paul.sandoz at oracle.com ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh From staffan.larsen at oracle.com Tue May 8 13:47:37 2012 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Tue, 08 May 2012 20:47:37 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7162726: Wrong filter predicate of visible locals in SA JSJavaFrame Message-ID: <20120508204741.B305E471CE@hg.openjdk.java.net> Changeset: 0251d217257f Author: sla Date: 2012-05-08 20:28 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0251d217257f 7162726: Wrong filter predicate of visible locals in SA JSJavaFrame Reviewed-by: sla, dcubed Contributed-by: Krystal Mok ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaFrame.java From xuelei.fan at oracle.com Tue May 8 17:57:37 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Wed, 09 May 2012 00:57:37 +0000 Subject: hg: jdk8/tl/jdk: 7167092: Need to put the return clause in the synchronized block Message-ID: <20120509005747.AADC5471D5@hg.openjdk.java.net> Changeset: fbf98cbd2e6b Author: xuelei Date: 2012-05-08 17:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fbf98cbd2e6b 7167092: Need to put the return clause in the synchronized block Summary: a regression fix for bug 7153184 Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/SSLContextImpl.java From xuelei.fan at oracle.com Tue May 8 18:09:36 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Wed, 09 May 2012 01:09:36 +0000 Subject: hg: jdk8/tl/jdk: 7166570: JSSE certificate validation has started to fail for certificate chains Message-ID: <20120509010947.4AC6B471D8@hg.openjdk.java.net> Changeset: 0f63f3390ac9 Author: xuelei Date: 2012-05-08 18:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0f63f3390ac9 7166570: JSSE certificate validation has started to fail for certificate chains Reviewed-by: wetmore ! src/share/classes/sun/security/validator/SimpleValidator.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/BasicConstraints.java From littlee at linux.vnet.ibm.com Tue May 8 20:21:27 2012 From: littlee at linux.vnet.ibm.com (littlee at linux.vnet.ibm.com) Date: Wed, 09 May 2012 03:21:27 +0000 Subject: hg: jdk8/tl/jdk: 7165722: Invalid path in MemoryMonitor demo's README.txt Message-ID: <20120509032146.D6D62471DD@hg.openjdk.java.net> Changeset: abb63b7357a1 Author: luchsh Date: 2012-05-09 11:19 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abb63b7357a1 7165722: Invalid path in MemoryMonitor demo's README.txt Reviewed-by: alanb, sla ! src/share/demo/management/MemoryMonitor/README.txt From littlee at linux.vnet.ibm.com Tue May 8 20:29:12 2012 From: littlee at linux.vnet.ibm.com (Charles Lee) Date: Wed, 09 May 2012 11:29:12 +0800 Subject: Request for Review: 7165722 invalid path in MemoryMonitor demo's README.txt In-Reply-To: <4FA1E6A6.6030505@linux.vnet.ibm.com> References: <4FA0F004.3090407@linux.vnet.ibm.com> <4FA0F215.2040605@oracle.com> <4FA1E6A6.6030505@linux.vnet.ibm.com> Message-ID: <4FA9E488.9020908@linux.vnet.ibm.com> Hi Jonathan, The patch is committed @ Changeset: abb63b7357a1 Author: luchsh Date: 2012-05-09 11:19 +0800 URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abb63b7357a1 7165722: Invalid path in MemoryMonitor demo's README.txt Reviewed-by: alanb, sla Please verify it and thank you all for reviewing. On 05/03/2012 10:00 AM, Jonathan Lu wrote: > Thanks a lot, Alan. > > I'll go to serviceability-dev list for further discussion. > > Best regards! > > - Jonathan Lu > > On 05/02/2012 04:36 PM, Alan Bateman wrote: >> On 02/05/2012 09:27, Jonathan Lu wrote: >>> Hi build-dev, >>> >>> I've got a minor change to fix an invalid path from README.txt of >>> MemoryMonitor demo, could anybody please help to take a look? >>> >>> http://cr.openjdk.java.net/~luchsh/7165722/ >>> >>> Best regards! >>> - Jonathan >>> >> 7165722 was submitted as an incident and I've moved it to the right >> place. Also cc'ing serviceability-dev as that is where these >> java.lang.management demos came from. >> >> The patch looks fine and I assume Charles will push it for you. >> >> -Alan. >> > -- Yours Charles From luchsh at linux.vnet.ibm.com Tue May 8 23:32:11 2012 From: luchsh at linux.vnet.ibm.com (Jonathan Lu) Date: Wed, 09 May 2012 14:32:11 +0800 Subject: Request for Review: 7165722 invalid path in MemoryMonitor demo's README.txt In-Reply-To: <06F51AD8-48C5-4FEC-8789-F0AAA3C47620@oracle.com> References: <4FA0F004.3090407@linux.vnet.ibm.com> <4FA0F215.2040605@oracle.com> <4FA1E6A6.6030505@linux.vnet.ibm.com> <4FA91BF3.20006@linux.vnet.ibm.com> <06F51AD8-48C5-4FEC-8789-F0AAA3C47620@oracle.com> Message-ID: <4FAA0F6B.2020700@linux.vnet.ibm.com> Hello Staffan, Thanks for reviewing! I think Charles has helped to push the patch. Best regards! - Jonathan On 05/08/2012 09:24 PM, Staffan Larsen wrote: > Looks good to me. Do you want me to push it for you? > > /Staffan > > > On 8 maj 2012, at 15:13, Jonathan Lu wrote: > >> Hi serviceability-dev, >> >> is it OK to push this change? >> >> Thanks! >> >> On 05/03/2012 10:00 AM, Jonathan Lu wrote: >>> Thanks a lot, Alan. >>> >>> I'll go to serviceability-dev list for further discussion. >>> >>> Best regards! >>> >>> - Jonathan Lu >>> >>> On 05/02/2012 04:36 PM, Alan Bateman wrote: >>>> On 02/05/2012 09:27, Jonathan Lu wrote: >>>>> Hi build-dev, >>>>> >>>>> I've got a minor change to fix an invalid path from README.txt of MemoryMonitor demo, could anybody please help to take a look? >>>>> >>>>> http://cr.openjdk.java.net/~luchsh/7165722/ >>>>> >>>>> Best regards! >>>>> - Jonathan >>>>> >>>> 7165722 was submitted as an incident and I've moved it to the right place. Also cc'ing serviceability-dev as that is where these java.lang.management demos came from. >>>> >>>> The patch looks fine and I assume Charles will push it for you. >>>> >>>> -Alan. >>>> From luchsh at linux.vnet.ibm.com Tue May 8 23:30:38 2012 From: luchsh at linux.vnet.ibm.com (Jonathan Lu) Date: Wed, 09 May 2012 14:30:38 +0800 Subject: Request for Review: 7165722 invalid path in MemoryMonitor demo's README.txt In-Reply-To: <4FA9E488.9020908@linux.vnet.ibm.com> References: <4FA0F004.3090407@linux.vnet.ibm.com> <4FA0F215.2040605@oracle.com> <4FA1E6A6.6030505@linux.vnet.ibm.com> <4FA9E488.9020908@linux.vnet.ibm.com> Message-ID: <4FAA0F0E.8050101@linux.vnet.ibm.com> Hi Charles, Verified, thanks! Regards - Jonathan On 05/09/2012 11:29 AM, Charles Lee wrote: > Hi Jonathan, > > The patch is committed @ > > Changeset: abb63b7357a1 > Author: luchsh > Date: 2012-05-09 11:19 +0800 > URL:http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abb63b7357a1 > > 7165722: Invalid path in MemoryMonitor demo's README.txt > Reviewed-by: alanb, sla > > > Please verify it and thank you all for reviewing. > > On 05/03/2012 10:00 AM, Jonathan Lu wrote: >> Thanks a lot, Alan. >> >> I'll go to serviceability-dev list for further discussion. >> >> Best regards! >> >> - Jonathan Lu >> >> On 05/02/2012 04:36 PM, Alan Bateman wrote: >>> On 02/05/2012 09:27, Jonathan Lu wrote: >>>> Hi build-dev, >>>> >>>> I've got a minor change to fix an invalid path from README.txt of >>>> MemoryMonitor demo, could anybody please help to take a look? >>>> >>>> http://cr.openjdk.java.net/~luchsh/7165722/ >>>> >>>> Best regards! >>>> - Jonathan >>>> >>> 7165722 was submitted as an incident and I've moved it to the right >>> place. Also cc'ing serviceability-dev as that is where these >>> java.lang.management demos came from. >>> >>> The patch looks fine and I assume Charles will push it for you. >>> >>> -Alan. >>> >> > > From david.holmes at oracle.com Wed May 9 07:00:35 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 09 May 2012 14:00:35 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20120509140042.70ECB471ED@hg.openjdk.java.net> Changeset: 7f410b6ea66c Author: dholmes Date: 2012-05-09 00:28 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7f410b6ea66c 7167406: (Zero) Fix for InvokeDynamic needed Reviewed-by: chrisphi, dholmes Contributed-by: Andrew Dinn ! src/cpu/zero/vm/cppInterpreter_zero.cpp Changeset: d506b2cf2ad0 Author: dholmes Date: 2012-05-09 04:32 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d506b2cf2ad0 Merge From kumar.x.srinivasan at oracle.com Wed May 9 09:29:07 2012 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Wed, 09 May 2012 16:29:07 +0000 Subject: hg: jdk8/tl/jdk: 7166955: (pack200) JNI_GetCreatedJavaVMs needs additional checking Message-ID: <20120509162917.E58A2471F0@hg.openjdk.java.net> Changeset: 5e8caf6984f5 Author: ksrini Date: 2012-05-09 07:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e8caf6984f5 7166955: (pack200) JNI_GetCreatedJavaVMs needs additional checking Reviewed-by: alanb, dholmes, ksrini Contributed-by: youdwei at linux.vnet.ibm.com ! src/share/native/com/sun/java/util/jar/pack/jni.cpp From kurchi.subhra.hazra at oracle.com Wed May 9 11:15:02 2012 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Wed, 09 May 2012 18:15:02 +0000 Subject: hg: jdk8/tl/jdk: 7165118: (prefs) AbstractPreferences.remove(null) does not throw NPE Message-ID: <20120509181511.CE5FB471F8@hg.openjdk.java.net> Changeset: 59121a4c71c6 Author: khazra Date: 2012-05-09 11:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/59121a4c71c6 7165118: (prefs) AbstractPreferences.remove(null) does not throw NPE Summary: Insert null argument check in AbstractPreferences.remove() Reviewed-by: dholmes, chegar, alanb ! src/share/classes/java/util/prefs/AbstractPreferences.java ! test/java/util/prefs/RemoveNullKeyCheck.java From staffan.larsen at oracle.com Wed May 9 12:08:30 2012 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Wed, 09 May 2012 19:08:30 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7163117: Agent can't connect to process on Mac OSX Message-ID: <20120509190834.7A98F471F9@hg.openjdk.java.net> Changeset: 78d2ae5ab35b Author: nloodin Date: 2012-05-09 16:24 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/78d2ae5ab35b 7163117: Agent can't connect to process on Mac OSX Reviewed-by: dholmes, coleenp, sla, minqi, kvn ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdCDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThreadContextFactory.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerClient.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java From bradford.wetmore at oracle.com Wed May 9 16:34:25 2012 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Wed, 09 May 2012 23:34:25 +0000 Subject: hg: jdk8/tl/jdk: 7167362: SecureRandom.init should be converted, amendment to 7084245 Message-ID: <20120509233435.8C5CB47206@hg.openjdk.java.net> Changeset: 6438f1277df6 Author: wetmore Date: 2012-05-09 16:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6438f1277df6 7167362: SecureRandom.init should be converted, amendment to 7084245 Reviewed-by: sherman ! src/share/classes/sun/security/provider/SecureRandom.java From kurchi.subhra.hazra at oracle.com Wed May 9 16:57:06 2012 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Wed, 09 May 2012 23:57:06 +0000 Subject: hg: jdk8/tl/jdk: 7096436: (sc) SocketChannel.connect fails on Windows 8 when channel configured non-blocking Message-ID: <20120509235717.1BB084720C@hg.openjdk.java.net> Changeset: 5152c832745a Author: khazra Date: 2012-05-09 16:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5152c832745a 7096436: (sc) SocketChannel.connect fails on Windows 8 when channel configured non-blocking Summary: Set localAddress only when connection is established Reviewed-by: alanb ! src/share/classes/sun/nio/ch/SocketChannelImpl.java From sean.coffey at oracle.com Thu May 10 02:43:45 2012 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Thu, 10 May 2012 09:43:45 +0000 Subject: hg: jdk8/tl/jdk: 7163470: Build fails if javax.crypto src files not present Message-ID: <20120510094414.56FE047220@hg.openjdk.java.net> Changeset: fdf5e15293e6 Author: coffeys Date: 2012-05-10 10:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fdf5e15293e6 7163470: Build fails if javax.crypto src files not present Reviewed-by: valeriep ! make/com/oracle/security/ucrypto/Makefile ! make/common/shared/Defs-java.gmk ! make/sun/security/ec/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile ! makefiles/com/oracle/security/ucrypto/Makefile ! makefiles/common/shared/Defs-java.gmk ! makefiles/sun/security/ec/Makefile ! makefiles/sun/security/mscapi/Makefile ! makefiles/sun/security/pkcs11/Makefile From daniel.daugherty at oracle.com Thu May 10 08:52:21 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 10 May 2012 09:52:21 -0600 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: References: Message-ID: <4FABE435.3070101@oracle.com> Adding serviceability-dev at openjdk.java.net to this e-mail thread. On 5/10/12 7:49 AM, Mark Wielaard wrote: > Hi, > > The following three patches enable support for dtrace compatible sdt probes > on GNU/Linux. Most of the support was already submitted earlier. These are > just the last three things left in IcedTea that actually enable it in > hotspot. It has been in production use for some time already. > > The patches could be applied all as one, or individually if you want to be > able to test them independently. > > The first patch is just a consistency cleanup patch. The JNI Set and > SetStatic Field methods used HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N > directly instead of just using DTRACE_PROBE[N] like all other JNI methods. > This doesn't matter for the Solaris macros, but on GNU/Linux the macros > don't use direct function declarations (which is introduced in the second > patch). > > The second patch introduces the DTRACE macros for use with the GNU/Linux > SystemTap provided sys/sdt.h. Like Solaris this uses USDT1, but using > macros instead of function declaractions. So it just adds a check for > whether USDT1 is used with SOLARIS (HS_DTRACE_WORKAROUND_TAIL_CALL_BUG > is only needed there) and defines HS_DTRACE_PROBE[N] for the LINUX case. > > The last patch enables the support in the build. I took the approach > used in the make/solaris/dtrace.make and vm.make file with a test to > see whether sys/sdt.h is available or not and printing a notice when > they are not found. In IcedTea there is a more elaborate configure > check to see if a small C++ program can be build with DTRACE probes > in it, but that looked like overkill here. > > Patches in separate emails. > > Cheers, > > Mark > > The second patch adds the actual > src/share/vm/prims/jni.cpp | 11 ++------ > src/share/vm/utilities/dtrace.hpp | 50 ++++++++++++++++++++++++++++++++++++++- > make/linux/makefiles/dtrace.make | 24 ++++++++++++++++++ > make/linux/makefiles/vm.make | 2 +- > 4 files changed, 77 insertions(+), 10 deletions(-) From daniel.daugherty at oracle.com Thu May 10 08:52:30 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 10 May 2012 09:52:30 -0600 Subject: [PATCH 1 of 3] XXXXXX: Use DTRACE_PROBE[N] in JNI Set and SetStatic Field In-Reply-To: References: Message-ID: <4FABE43E.1020900@oracle.com> Adding serviceability-dev at openjdk.java.net to this e-mail thread. On 5/10/12 7:49 AM, Mark Wielaard wrote: > src/share/vm/prims/jni.cpp | 11 +++-------- > 1 files changed, 3 insertions(+), 8 deletions(-) > > > # HG changeset patch > # User Mark Wielaard > # Date 1336656680 -7200 > # Node ID ed003325d9977d3bd8b38afd5db5a97200b310af > # Parent 2766551175a024338344350b9c279797b4a7d8ac > XXXXXX: Use DTRACE_PROBE[N] in JNI Set and SetStatic Field. > Summary: Don't use HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N directly. > Contributed-by: Mark Wielaard > > diff -r 2766551175a0 -r ed003325d997 src/share/vm/prims/jni.cpp > --- a/src/share/vm/prims/jni.cpp Wed May 09 10:54:29 2012 -0700 > +++ b/src/share/vm/prims/jni.cpp Thu May 10 15:31:20 2012 +0200 > @@ -1,5 +1,6 @@ > /* > * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2012 Red Hat, Inc. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -2818,10 +2819,7 @@ > JNI_QUICK_ENTRY(void, jni_Set##Result##Field(JNIEnv *env, jobject obj, jfieldID fieldID, Argument value)) \ > JNIWrapper("Set" XSTR(Result) "Field"); \ > \ > - HS_DTRACE_PROBE_CDECL_N(hotspot_jni, Set##Result##Field__entry, \ > - ( JNIEnv*, jobject, jfieldID FP_SELECT_##Result(COMMA Argument,/*empty*/) ) ); \ > - HS_DTRACE_PROBE_N(hotspot_jni, Set##Result##Field__entry, \ > - ( env, obj, fieldID FP_SELECT_##Result(COMMA value,/*empty*/) ) ); \ > + FP_SELECT_##Result(DTRACE_PROBE4(hotspot_jni, Set##Result##Field__entry, env, obj, fieldID, value),DTRACE_PROBE3(hotspot_jni, Set##Result##Field__entry, env, obj, fieldID)); \ > \ > oop o = JNIHandles::resolve_non_null(obj); \ > klassOop k = o->klass(); \ > @@ -3128,10 +3126,7 @@ > \ > JNI_ENTRY(void, jni_SetStatic##Result##Field(JNIEnv *env, jclass clazz, jfieldID fieldID, Argument value)) \ > JNIWrapper("SetStatic" XSTR(Result) "Field"); \ > - HS_DTRACE_PROBE_CDECL_N(hotspot_jni, SetStatic##Result##Field__entry,\ > - ( JNIEnv*, jclass, jfieldID FP_SELECT_##Result(COMMA Argument,/*empty*/) ) ); \ > - HS_DTRACE_PROBE_N(hotspot_jni, SetStatic##Result##Field__entry, \ > - ( env, clazz, fieldID FP_SELECT_##Result(COMMA value,/*empty*/) ) ); \ > + FP_SELECT_##Result(DTRACE_PROBE4(hotspot_jni, SetStatic##Result##Field__entry, env, clazz, fieldID, value),DTRACE_PROBE3(hotspot_jni, SetStatic##Result##Field__entry, env, clazz, fieldID)); \ > \ > JNIid* id = jfieldIDWorkaround::from_static_jfieldID(fieldID); \ > assert(id->is_static_field_id(), "invalid static field id"); \ From daniel.daugherty at oracle.com Thu May 10 08:52:36 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 10 May 2012 09:52:36 -0600 Subject: [PATCH 2 of 3] XXXXXX: Define DTRACE macros for use with GNU/Linux SystemTap sys/sdt.h In-Reply-To: References: Message-ID: <4FABE444.2040504@oracle.com> Adding serviceability-dev at openjdk.java.net to this e-mail thread. On 5/10/12 7:49 AM, Mark Wielaard wrote: > src/share/vm/utilities/dtrace.hpp | 50 ++++++++++++++++++++++++++++++++++++++- > 1 files changed, 49 insertions(+), 1 deletions(-) > > > # HG changeset patch > # User Mark Wielaard > # Date 1336657104 -7200 > # Node ID ec675cf936d8eeefb11b7624c8f292fdd7e1f847 > # Parent ed003325d9977d3bd8b38afd5db5a97200b310af > XXXXXX: Define DTRACE macros for use with GNU/Linux SystemTap sys/sdt.h. > Summary: LINUX also uses USDT1, but with macros instead of function decls. > Contributed-by: Mark Wielaard > > diff -r ed003325d997 -r ec675cf936d8 src/share/vm/utilities/dtrace.hpp > --- a/src/share/vm/utilities/dtrace.hpp Thu May 10 15:31:20 2012 +0200 > +++ b/src/share/vm/utilities/dtrace.hpp Thu May 10 15:38:24 2012 +0200 > @@ -1,5 +1,6 @@ > /* > * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2009, 2012 Red Hat, Inc. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -32,12 +33,15 @@ > #define DTRACE_ONLY(x) x > #define NOT_DTRACE(x) > > +#if defined(SOLARIS) > // Work around dtrace tail call bug 6672627 until it is fixed in solaris 10. > #define HS_DTRACE_WORKAROUND_TAIL_CALL_BUG() \ > do { volatile size_t dtrace_workaround_tail_call_bug = 1; } while (0) > > -#if defined(SOLARIS) > #define USDT1 1 > +#elif defined(LINUX) > +#define USDT1 1 > +#define HS_DTRACE_WORKAROUND_TAIL_CALL_BUG() > #elif defined(__APPLE__) > #define USDT2 1 > #include > @@ -63,6 +67,11 @@ > #define DTRACE_PROBE3(a,b,c,d,e) {;} > #define DTRACE_PROBE4(a,b,c,d,e,f) {;} > #define DTRACE_PROBE5(a,b,c,d,e,f,g) {;} > +#define DTRACE_PROBE6(a,b,c,d,e,f,g,h) {;} > +#define DTRACE_PROBE7(a,b,c,d,e,f,g,h,i) {;} > +#define DTRACE_PROBE8(a,b,c,d,e,f,g,h,i,j) {;} > +#define DTRACE_PROBE9(a,b,c,d,e,f,g,h,i,j,k) {;} > +#define DTRACE_PROBE10(a,b,c,d,e,f,g,h,i,j,k,l) {;} > > #else /* USDT2 */ > > @@ -76,10 +85,19 @@ > #define HS_DTRACE_PROBE_FN(provider,name)\ > __dtrace_##provider##___##name > > +#ifdef SOLARIS > +// Solaris dtrace needs actual extern function decls. > #define HS_DTRACE_PROBE_DECL_N(provider,name,args) \ > DTRACE_ONLY(extern "C" void HS_DTRACE_PROBE_FN(provider,name) args) > #define HS_DTRACE_PROBE_CDECL_N(provider,name,args) \ > DTRACE_ONLY(extern void HS_DTRACE_PROBE_FN(provider,name) args) > +#elif defined(LINUX) > +// Systemtap dtrace compatible probes on GNU/Linux don't. > +#define HS_DTRACE_PROBE_DECL_N(provider,name,args) > +#define HS_DTRACE_PROBE_CDECL_N(provider,name,args) > +#else > +#error "USDT1 enabled for unknown os" > +#endif > > /* Dtrace probe declarations */ > #define HS_DTRACE_PROBE_DECL(provider,name) \ > @@ -118,6 +136,8 @@ > uintptr_t,uintptr_t,uintptr_t)) > > /* Dtrace probe definitions */ > +#if defined(SOLARIS) > +// Solaris dtrace uses actual function calls. > #define HS_DTRACE_PROBE_N(provider,name, args) \ > DTRACE_ONLY(HS_DTRACE_PROBE_FN(provider,name) args) > > @@ -153,6 +173,34 @@ > HS_DTRACE_PROBE_N(provider,name,((uintptr_t)a0,(uintptr_t)a1,(uintptr_t)a2,\ > (uintptr_t)a3,(uintptr_t)a4,(uintptr_t)a5,(uintptr_t)a6,(uintptr_t)a7,\ > (uintptr_t)a8,(uintptr_t)a9)) > +#elif defined(LINUX) > +// Systemtap dtrace compatible probes on GNU/Linux use direct macros. > +#define HS_DTRACE_PROBE(provider,name) HS_DTRACE_PROBE0(provider,name) > +#define HS_DTRACE_PROBE0(provider,name)\ > + DTRACE_PROBE(provider,name) > +#define HS_DTRACE_PROBE1(provider,name,a0)\ > + DTRACE_PROBE1(provider,name,a0) > +#define HS_DTRACE_PROBE2(provider,name,a0,a1)\ > + DTRACE_PROBE2(provider,name,a0,a1) > +#define HS_DTRACE_PROBE3(provider,name,a0,a1,a2)\ > + DTRACE_PROBE3(provider,name,a0,a1,a2) > +#define HS_DTRACE_PROBE4(provider,name,a0,a1,a2,a3)\ > + DTRACE_PROBE4(provider,name,a0,a1,a2,a3) > +#define HS_DTRACE_PROBE5(provider,name,a0,a1,a2,a3,a4)\ > + DTRACE_PROBE5(provider,name,a0,a1,a2,a3,a4) > +#define HS_DTRACE_PROBE6(provider,name,a0,a1,a2,a3,a4,a5)\ > + DTRACE_PROBE6(provider,name,a0,a1,a2,a3,a4,a5) > +#define HS_DTRACE_PROBE7(provider,name,a0,a1,a2,a3,a4,a5,a6)\ > + DTRACE_PROBE7(provider,name,a0,a1,a2,a3,a4,a5,a6) > +#define HS_DTRACE_PROBE8(provider,name,a0,a1,a2,a3,a4,a5,a6,a7)\ > + DTRACE_PROBE8(provider,name,a0,a1,a2,a3,a4,a5,a6,a7) > +#define HS_DTRACE_PROBE9(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8)\ > + DTRACE_PROBE9(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8) > +#define HS_DTRACE_PROBE10(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8)\ > + DTRACE_PROBE10(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8) > +#else > +#error "USDT1 enabled for unknown os" > +#endif > > #endif /* !USDT2 */ > From daniel.daugherty at oracle.com Thu May 10 08:52:40 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 10 May 2012 09:52:40 -0600 Subject: [PATCH 3 of 3] XXXXXX: Enable dtrace compatible sdt probes on GNU/Linux builds In-Reply-To: <6a35858b331dca2ce76b.1336657748@springer.wildebeest.org> References: <6a35858b331dca2ce76b.1336657748@springer.wildebeest.org> Message-ID: <4FABE448.2050700@oracle.com> Adding serviceability-dev at openjdk.java.net to this e-mail thread. On 5/10/12 7:49 AM, Mark Wielaard wrote: > make/linux/makefiles/dtrace.make | 24 ++++++++++++++++++++++++ > make/linux/makefiles/vm.make | 2 +- > 2 files changed, 25 insertions(+), 1 deletions(-) > > > # HG changeset patch > # User Mark Wielaard > # Date 1336657292 -7200 > # Node ID 6a35858b331dca2ce76b6328ff57f893349303a0 > # Parent ec675cf936d8eeefb11b7624c8f292fdd7e1f847 > XXXXXX: Enable dtrace compatible sdt probes on GNU/Linux builds. > Summary: If sys/sdt.h is found, then enable dtrace compatible sdt probes. > Contributed-by: Mark Wielaard > > diff -r ec675cf936d8 -r 6a35858b331d make/linux/makefiles/dtrace.make > --- a/make/linux/makefiles/dtrace.make Thu May 10 15:38:24 2012 +0200 > +++ b/make/linux/makefiles/dtrace.make Thu May 10 15:41:32 2012 +0200 > @@ -1,5 +1,6 @@ > # > # Copyright (c) 2005, 2008, Oracle and/or its affiliates. All rights reserved. > +# Copyright (c) 2012 Red Hat, Inc. > # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > # > # This code is free software; you can redistribute it and/or modify it > @@ -25,3 +26,26 @@ > # Linux does not build jvm_db > LIBJVM_DB = > > +# But it does have a SystemTap dtrace compatible sys/sdt.h > +ifneq ($(ALT_SDT_H),) > + SDT_H_FILE = $(ALT_SDT_H) > +else > + SDT_H_FILE = /usr/include/sys/sdt.h > +endif > +DTRACE_ENABLED = $(shell test -f $(SDT_H_FILE)&& echo $(SDT_H_FILE)) > + > +ifneq ($(DTRACE_ENABLED),) > + CFLAGS += -DDTRACE_ENABLED > +endif > + > +# Phone target used in vm.make build target to check whether enabled. > +.PHONY: dtraceCheck > +ifeq ($(DTRACE_ENABLED),) > +dtraceCheck: > + $(QUIETLY) echo "**NOTICE** Dtrace support disabled $(SDT_H_FILE) not found" > +else > +dtraceCheck: > +endif > + > +# It doesn't support HAVE_DTRACE_H though. > + > diff -r ec675cf936d8 -r 6a35858b331d make/linux/makefiles/vm.make > --- a/make/linux/makefiles/vm.make Thu May 10 15:38:24 2012 +0200 > +++ b/make/linux/makefiles/vm.make Thu May 10 15:41:32 2012 +0200 > @@ -383,7 +383,7 @@ > > #---------------------------------------------------------------------- > > -build: $(LIBJVM) $(LAUNCHER) $(LIBJSIG) $(LIBJVM_DB) $(BUILDLIBSAPROC) $(WB_JAR) > +build: $(LIBJVM) $(LAUNCHER) $(LIBJSIG) $(LIBJVM_DB) $(BUILDLIBSAPROC) dtraceCheck $(WB_JAR) > > install: install_jvm install_jsig install_saproc > From valerie.peng at oracle.com Thu May 10 11:40:00 2012 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Thu, 10 May 2012 18:40:00 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20120510184042.669D047234@hg.openjdk.java.net> Changeset: 3e3017eba8ac Author: valeriep Date: 2012-05-08 17:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e3017eba8ac 4963723: Implement SHA-224 Summary: Add support for SHA-224, SHA224withRSA, SHA224withECDSA, HmacSHA224 and OAEPwithSHA-224AndMGF1Padding. Reviewed-by: vinnie ! src/share/classes/com/sun/crypto/provider/HmacCore.java ! src/share/classes/com/sun/crypto/provider/HmacMD5.java ! src/share/classes/com/sun/crypto/provider/HmacPKCS12PBESHA1.java ! src/share/classes/com/sun/crypto/provider/HmacSHA1.java ! src/share/classes/com/sun/crypto/provider/KeyGeneratorCore.java ! src/share/classes/com/sun/crypto/provider/OAEPParameters.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java ! src/share/classes/java/security/spec/MGF1ParameterSpec.java ! src/share/classes/java/security/spec/PSSParameterSpec.java ! src/share/classes/sun/security/ec/ECDSASignature.java ! src/share/classes/sun/security/ec/SunECEntries.java ! src/share/classes/sun/security/pkcs11/P11Digest.java ! src/share/classes/sun/security/pkcs11/P11Mac.java ! src/share/classes/sun/security/pkcs11/P11Signature.java ! src/share/classes/sun/security/pkcs11/SunPKCS11.java ! src/share/classes/sun/security/pkcs11/wrapper/Functions.java ! src/share/classes/sun/security/provider/DigestBase.java ! src/share/classes/sun/security/provider/MD2.java ! src/share/classes/sun/security/provider/MD4.java ! src/share/classes/sun/security/provider/MD5.java ! src/share/classes/sun/security/provider/SHA.java ! src/share/classes/sun/security/provider/SHA2.java ! src/share/classes/sun/security/provider/SHA5.java ! src/share/classes/sun/security/provider/SunEntries.java ! src/share/classes/sun/security/rsa/RSASignature.java ! src/share/classes/sun/security/rsa/SunRsaSignEntries.java ! src/share/classes/sun/security/x509/AlgorithmId.java ! src/windows/classes/sun/security/mscapi/RSASignature.java ! src/windows/classes/sun/security/mscapi/SunMSCAPI.java ! test/com/sun/crypto/provider/Cipher/RSA/TestOAEP.java ! test/com/sun/crypto/provider/Cipher/RSA/TestOAEPParameterSpec.java ! test/com/sun/crypto/provider/Cipher/RSA/TestOAEPWithParams.java ! test/com/sun/crypto/provider/KeyGenerator/Test4628062.java ! test/com/sun/crypto/provider/Mac/MacClone.java ! test/com/sun/crypto/provider/Mac/MacKAT.java ! test/sun/security/mscapi/SignUsingNONEwithRSA.java ! test/sun/security/mscapi/SignUsingSHA2withRSA.java ! test/sun/security/pkcs11/MessageDigest/DigestKAT.java ! test/sun/security/pkcs11/MessageDigest/TestCloning.java ! test/sun/security/pkcs11/Signature/TestRSAKeyLength.java ! test/sun/security/pkcs11/ec/TestCurves.java ! test/sun/security/pkcs11/rsa/TestKeyPairGenerator.java ! test/sun/security/pkcs11/rsa/TestSignatures.java ! test/sun/security/provider/MessageDigest/DigestKAT.java ! test/sun/security/provider/MessageDigest/Offsets.java ! test/sun/security/provider/MessageDigest/TestSHAClone.java ! test/sun/security/rsa/TestKeyPairGenerator.java ! test/sun/security/rsa/TestSignatures.java Changeset: dfce31760a2f Author: valeriep Date: 2012-05-08 18:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dfce31760a2f Merge Changeset: 9f8210f23773 Author: valeriep Date: 2012-05-10 11:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f8210f23773 Merge From kumar.x.srinivasan at oracle.com Thu May 10 13:53:31 2012 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Thu, 10 May 2012 20:53:31 +0000 Subject: hg: jdk8/tl/langtools: 7159445: (javac) emits inaccurate diagnostics for enhanced for-loops Message-ID: <20120510205333.D760047244@hg.openjdk.java.net> Changeset: 833bab705918 Author: ksrini Date: 2012-05-10 12:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/833bab705918 7159445: (javac) emits inaccurate diagnostics for enhanced for-loops Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/ForeachBadInitialization.java ! test/tools/javac/parser/JavacParserTest.java From kevin.walls at oracle.com Thu May 10 14:36:03 2012 From: kevin.walls at oracle.com (Kevin Walls) Date: Thu, 10 May 2012 22:36:03 +0100 Subject: RFR (L): Adding core file parsing on Mac OS X to SA In-Reply-To: <06CFCD3A-A8F4-4FDE-B8CD-D201C892AA30@oracle.com> References: <06CFCD3A-A8F4-4FDE-B8CD-D201C892AA30@oracle.com> Message-ID: <4FAC34C3.7020407@oracle.com> Hi - For that property, want to avoid embedding some project name in any kind of interface, even an "unpublished" one, maybe "-Dsa.portable" for the portable serviceability agent? Thanks Kevin On 08/05/12 12:11, Staffan Larsen wrote: > The Serviceability Agent currently has an outage on Mac OS X compared > to other platforms in that we cannot read core files. We plan to > address this for 7u6 by incorporating code from a separate tool called > "kjdb" developed at Oracle. Kjdb is a cross-platform core-file > debugger written completely in Java that currently works on ELF > (solaris, linux) and Mach-O (mac) core files. Since it is written in > Java it can read core files from a different system than the system > you are running kjdb on, which is very useful. > > The alternative to incorporating the kjdb technology would have been > to implement this in C as is done for the other platforms, but reusing > existing code saves us some trouble. The kjdb debugger backend will > automatically be enabled when you are opening a Mach-O core file (or > if you explicitly set the -Duse.kjdb property when starting SA). > > The risks with this is that this is a large addition of relatively new > code to SA (around 100 files). It also means that debugging a live > process or a core file on OS X will use different debugger backends > which may have different behavior and bugs. > > This change also adds a basic test that creates a core file and uses > SA to print the thread dumps in the core. This test runs on all > platforms, not just Mac OS X. Other than that test, some level of > manual testing has been done with various core files. > > Please see the webrev at: > http://cr.openjdk.java.net/~sla/kjdb/webrev.01/ > > > There are quite a number of added files in this webrev, so it's > probably best to concentrate on the changes in the existing files. > > Thanks, > /Staffan From john.coomes at oracle.com Thu May 10 20:57:13 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 May 2012 03:57:13 +0000 Subject: hg: hsx/hotspot-rt: 6 new changesets Message-ID: <20120511035713.C7E414726D@hg.openjdk.java.net> Changeset: afeeed8e5f8c Author: ihse Date: 2012-04-30 12:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/afeeed8e5f8c 7165277: Fix missing execute permission issue running logger.sh Reviewed-by: ohair ! common/autoconf/configure ! common/autoconf/configure.ac Changeset: b2972095a4b1 Author: katleman Date: 2012-05-02 15:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/b2972095a4b1 Merge Changeset: 2eeb9fac7dfc Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/2eeb9fac7dfc Added tag jdk8-b37 for changeset b2972095a4b1 ! .hgtags Changeset: 2f06b15e2439 Author: ewendeli Date: 2012-05-03 14:17 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/2f06b15e2439 7154130: Add Mac OS X Instructions to README-builds.html Reviewed-by: ohair Contributed-by: edvard.wendelin at oracle.com ! README-builds.html Changeset: d939bd0ab13c Author: katleman Date: 2012-05-09 16:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/d939bd0ab13c Merge Changeset: b67bdaca36c2 Author: katleman Date: 2012-05-10 10:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/b67bdaca36c2 Added tag jdk8-b38 for changeset d939bd0ab13c ! .hgtags From john.coomes at oracle.com Thu May 10 20:57:18 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 May 2012 03:57:18 +0000 Subject: hg: hsx/hotspot-rt/corba: 7 new changesets Message-ID: <20120511035724.48EAC4726E@hg.openjdk.java.net> Changeset: c6c0b1047985 Author: jmelvin Date: 2012-04-16 17:10 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/c6c0b1047985 7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with Apple JDK6 Summary: On Mac OS X, align system property "os.arch" with Apple legacy JDKs. Also, improve os.name string matching by using .contains() method instead of .startsWith(). This fix spans multiple repositories. Reviewed-by: dcubed, phh, ohair, katleman ! make/common/shared/Platform.gmk Changeset: 9cdcc0152526 Author: coffeys Date: 2012-04-20 17:34 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/9cdcc0152526 7161925: sjava files in corba don't have copyright string and legal notice Reviewed-by: chegar Contributed-by: misha.bykov at oracle.com ! src/share/classes/com/sun/corba/se/impl/orbutil/DefineWrapper.sjava ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLTypesUtil_save.sjava Changeset: df0c7369a86b Author: lana Date: 2012-04-26 14:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/df0c7369a86b Merge Changeset: 4a653e435441 Author: lana Date: 2012-05-01 11:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/4a653e435441 Merge Changeset: 2d2f6b0f855b Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/2d2f6b0f855b Added tag jdk8-b37 for changeset 83fac66442cf ! .hgtags Changeset: b8cbfb31139f Author: katleman Date: 2012-05-09 13:11 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/b8cbfb31139f Merge Changeset: 785af00e2827 Author: katleman Date: 2012-05-10 10:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/785af00e2827 Added tag jdk8-b38 for changeset b8cbfb31139f ! .hgtags From john.coomes at oracle.com Thu May 10 20:57:29 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 May 2012 03:57:29 +0000 Subject: hg: hsx/hotspot-rt/jaxp: 4 new changesets Message-ID: <20120511035743.5780B4726F@hg.openjdk.java.net> Changeset: aabc08ea546f Author: ohair Date: 2012-04-30 16:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/aabc08ea546f 7165312: Fix jaxp source movement for new build-infra Reviewed-by: ohrstrom ! makefiles/Makefile Changeset: 90204bfab4e2 Author: katleman Date: 2012-05-02 15:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/90204bfab4e2 Merge Changeset: 5bbe0cb6f2f2 Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/5bbe0cb6f2f2 Added tag jdk8-b37 for changeset 90204bfab4e2 ! .hgtags Changeset: f95fdbe525c8 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/f95fdbe525c8 Added tag jdk8-b38 for changeset 5bbe0cb6f2f2 ! .hgtags From john.coomes at oracle.com Thu May 10 20:57:48 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 May 2012 03:57:48 +0000 Subject: hg: hsx/hotspot-rt/jaxws: 2 new changesets Message-ID: <20120511035755.26DFC47270@hg.openjdk.java.net> Changeset: ac1ba3b56775 Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/ac1ba3b56775 Added tag jdk8-b37 for changeset b05a948db1b6 ! .hgtags Changeset: 7f6b44fd3034 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/7f6b44fd3034 Added tag jdk8-b38 for changeset ac1ba3b56775 ! .hgtags From john.coomes at oracle.com Thu May 10 20:59:46 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 May 2012 03:59:46 +0000 Subject: hg: hsx/hotspot-rt/jdk: 49 new changesets Message-ID: <20120511040826.12C3247272@hg.openjdk.java.net> Changeset: 8e3fb7dd21cd Author: skovatch Date: 2012-04-25 12:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8e3fb7dd21cd 7128699: Fix bundle name so it contains the bugfix number in the name. Reviewed-by: robilad ! make/common/Release-macosx.gmk Changeset: 919be2f7fd6e Author: cgruszka Date: 2012-04-27 14:37 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/919be2f7fd6e Merge Changeset: 762661efef30 Author: jgodinez Date: 2012-04-24 13:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/762661efef30 7157659: [macosx] Landscape Printing orientation doesn't work Reviewed-by: bae, prr ! src/macosx/native/sun/awt/PrinterView.m Changeset: cdaadcc2c6a4 Author: jgodinez Date: 2012-04-26 13:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cdaadcc2c6a4 7013850: Please change the mnemonic assignment system to avoid translation issue Reviewed-by: prr, mfang ! src/share/classes/sun/print/ServiceDialog.java ! src/share/classes/sun/print/resources/serviceui.properties ! src/share/classes/sun/print/resources/serviceui_de.properties ! src/share/classes/sun/print/resources/serviceui_es.properties ! src/share/classes/sun/print/resources/serviceui_fr.properties ! src/share/classes/sun/print/resources/serviceui_it.properties ! src/share/classes/sun/print/resources/serviceui_ja.properties ! src/share/classes/sun/print/resources/serviceui_ko.properties ! src/share/classes/sun/print/resources/serviceui_pt_BR.properties ! src/share/classes/sun/print/resources/serviceui_sv.properties ! src/share/classes/sun/print/resources/serviceui_zh_CN.properties ! src/share/classes/sun/print/resources/serviceui_zh_TW.properties Changeset: c2d29a375871 Author: lana Date: 2012-04-26 18:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c2d29a375871 Merge Changeset: 4a19075bb989 Author: lana Date: 2012-05-02 09:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4a19075bb989 Merge Changeset: 44beb8a52aec Author: zhouyx Date: 2012-04-20 10:34 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/44beb8a52aec 7129742: Unable to view focus in Non-Editable TextArea Summary: Make sure the cursor is visible by setVisible(true) Reviewed-by: rupashka, alexp ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java + test/java/awt/TextArea/TextAreaCaretVisibilityTest/bug7129742.java Changeset: dfa2ea47257d Author: luchsh Date: 2012-04-20 13:13 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/dfa2ea47257d 7055065: NullPointerException when sorting JTable with empty cell Reviewed-by: rupashka ! src/share/classes/javax/swing/JTable.java + test/javax/swing/JTable/7055065/bug7055065.java Changeset: 738b32fc3ef1 Author: anthony Date: 2012-04-24 17:47 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/738b32fc3ef1 7150109: [macosx] the Frame showed incomplete. Summary: Open-source the tests Reviewed-by: art + test/java/awt/Frame/FrameStateTest/FrameStateTest.html + test/java/awt/Frame/FrameStateTest/FrameStateTest.java Changeset: 9ed029a0326d Author: anthony Date: 2012-04-24 19:12 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9ed029a0326d 7163898: add isLoggable() check to doLog() Summary: Add the check and return immediately if it's false Reviewed-by: anthony, mchung, sla Contributed-by: Nicolas Carranza ! src/share/classes/sun/util/logging/PlatformLogger.java Changeset: 4a0f6ef43a09 Author: anthony Date: 2012-04-24 20:39 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4a0f6ef43a09 7131021: [macosx] Consider using system properties to pass arguments from the launcher to AWT/SplashScreen Summary: Document the environment variables and add tests Reviewed-by: ksrini ! src/macosx/bin/java_md_macosx.c + test/tools/launcher/EnvironmentVariables.java ! test/tools/launcher/TestHelper.java + test/tools/launcher/TestSpecialArgs.java Changeset: 36fd5078198b Author: alexsch Date: 2012-04-25 16:48 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/36fd5078198b 7163482: [macosx] Regtest closed/javax/swing/JTree/4908142/bug4908142.java intermittent failure Reviewed-by: rupashka + test/javax/swing/JTree/4908142/bug4908142.java Changeset: f1d1dab11a06 Author: leonidr Date: 2012-04-25 18:15 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f1d1dab11a06 7154480: [macosx] Not all popup menu items are visible Reviewed-by: art ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/sun/awt/SunToolkit.java Changeset: 340cda7e1430 Author: luchsh Date: 2012-04-26 12:39 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/340cda7e1430 7154030: java.awt.Component.hide() does not repaint parent component Reviewed-by: rupashka ! src/share/classes/javax/swing/JComponent.java + test/javax/swing/JComponent/7154030/bug7154030.java Changeset: 6314933aeaa9 Author: alexp Date: 2012-04-26 21:16 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6314933aeaa9 7124210: [macosx] Replacing text in a TextField does generate an extra TextEvent Reviewed-by: serb ! src/macosx/classes/sun/lwawt/LWTextAreaPeer.java ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java Changeset: 4184e5cbf46e Author: alexp Date: 2012-04-26 21:25 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4184e5cbf46e 7124328: [macosx] javax.swing.JDesktopPane.getAllFramesInLayer returns unexpected value Reviewed-by: anthony ! src/share/classes/javax/swing/JDesktopPane.java Changeset: d148d3d194af Author: lana Date: 2012-04-26 18:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d148d3d194af Merge Changeset: bbbf4e63562b Author: dcherepanov Date: 2012-05-02 13:53 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bbbf4e63562b 7154062: [macosx] Mouse cursor isn't updated in applets Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/macosx/CCursorManager.java ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java ! src/macosx/native/sun/awt/CCursorManager.m Changeset: 0fad89bd606b Author: alexsch Date: 2012-05-02 17:54 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0fad89bd606b 7154048: [macosx] At least drag twice, the toolbar can be dragged to the left side Reviewed-by: anthony, leonidr ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTView.h ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m + test/java/awt/Mouse/EnterExitEvents/DragWindowOutOfFrameTest.java + test/java/awt/Mouse/EnterExitEvents/DragWindowTest.java + test/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java ! test/java/awt/regtesthelpers/Util.java Changeset: f906d6068b43 Author: lana Date: 2012-05-02 09:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f906d6068b43 Merge Changeset: 7b023213681c Author: psandoz Date: 2012-04-19 14:05 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7b023213681c 7162262: (fs) Typo in java.nio.file.Path class description Reviewed-by: alanb ! src/share/classes/java/nio/file/Path.java Changeset: 77b35c5c4b95 Author: jmelvin Date: 2012-04-16 18:09 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/77b35c5c4b95 7130404: [macosx] "os.arch" value should be "x86_64" for compatibility with Apple JDK6 Summary: On Mac OS X, align system property "os.arch" with Apple legacy JDKs. Also, improve os.name string matching by using .contains() method instead of .startsWith(). This fix spans multiple repositories. Reviewed-by: dcubed, phh, ohair, katleman ! make/common/Defs-macosx.gmk ! make/common/shared/Platform.gmk ! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/share/classes/java/nio/Bits.java ! src/share/classes/java/util/prefs/Preferences.java ! src/share/classes/sun/awt/OSInfo.java ! src/share/classes/sun/font/FontUtilities.java ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java ! src/share/classes/sun/print/PSPrinterJob.java ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/Credentials.java ! src/share/classes/sun/security/provider/ByteArrayAccess.java ! src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java ! src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java ! src/solaris/classes/sun/print/UnixPrintServiceLookup.java ! test/demo/jvmti/DemoRun.java ! test/java/io/File/GetXSpace.java ! test/java/lang/ProcessBuilder/Basic.java ! test/java/lang/ProcessBuilder/Zombies.java ! test/java/lang/invoke/InvokeGenericTest.java ! test/java/lang/management/OperatingSystemMXBean/GetSystemLoadAverage.java ! test/java/nio/channels/FileChannel/Size.java ! test/java/nio/channels/FileChannel/Transfer.java ! test/java/nio/file/FileSystem/Basic.java ! test/sun/nio/ch/SelProvider.java ! test/tools/launcher/TestHelper.java Changeset: 079bb040b2ee Author: coleenp Date: 2012-04-19 10:53 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/079bb040b2ee Merge Changeset: 404c8e097ae9 Author: vinnie Date: 2012-04-19 16:58 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/404c8e097ae9 7162823: Modify the list of excluded tests (ProblemList Reviewed-by: alanb ! test/ProblemList.txt Changeset: bc51d0569ccd Author: khazra Date: 2012-04-19 13:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bc51d0569ccd 7162385: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing again Summary: Enable finding "foo1.jar" Reviewed-by: chegar ! test/sun/net/www/protocol/jar/B4957695.java Changeset: 715f50872ae7 Author: khazra Date: 2012-04-19 18:11 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/715f50872ae7 7158636: InterfaceAddress.getBroadcast() returns invalid broadcast address on WLAN Summary: Update Windows native code to infer WLAN interface type in Windows Vista and later Reviewed-by: chegar, alanb ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface.h Changeset: c3905c1f5da7 Author: zhouyx Date: 2012-04-20 16:11 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c3905c1f5da7 7159982: ZipFile uses static for error message when malformed zip file encountered Reviewed-by: alanb, dholmes ! src/share/native/java/util/zip/ZipFile.c ! src/share/native/java/util/zip/zip_util.c Changeset: ec9876082b4e Author: ksrini Date: 2012-04-22 06:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ec9876082b4e 6981776: Pack200 must support -target 7 bytecodes Summary: pack200 implementation of JSR-200 updated for JSR-292 changes Reviewed-by: jrose, ksrini Contributed-by: john.r.rose at oracle.com, kumar.x.srinivasan at oracle.com ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java ! src/share/classes/com/sun/java/util/jar/pack/ClassWriter.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/Instruction.java ! src/share/classes/com/sun/java/util/jar/pack/Package.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/TLGlobals.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java ! src/share/native/com/sun/java/util/jar/pack/bands.cpp ! src/share/native/com/sun/java/util/jar/pack/bands.h ! src/share/native/com/sun/java/util/jar/pack/constants.h ! src/share/native/com/sun/java/util/jar/pack/defines.h ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! src/share/native/com/sun/java/util/jar/pack/unpack.h ! test/tools/pack200/AttributeTests.java ! test/tools/pack200/PackageVersionTest.java ! test/tools/pack200/Utils.java - test/tools/pack200/dyn.jar ! test/tools/pack200/pack200-verifier/data/README ! test/tools/pack200/pack200-verifier/data/golden.jar ! test/tools/pack200/pack200-verifier/make/build.xml ! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: c2da01f0bdc1 Author: alanb Date: 2012-04-22 19:09 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c2da01f0bdc1 7163395: jdk8/tl no longer builds on Mac Reviewed-by: chegar, ohair, ksrini - src/macosx/bin/amd64/jvm.cfg + src/macosx/bin/x86_64/jvm.cfg Changeset: 07dab8d9e34a Author: alanb Date: 2012-04-22 19:12 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/07dab8d9e34a Merge - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: 1980be18d0f8 Author: alanb Date: 2012-04-22 21:22 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1980be18d0f8 7132924: (dc) DatagramChannel.disconnect throws SocketException with IPv4 socket and IPv6 enabled [macosx] Reviewed-by: chegar ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/solaris/native/sun/nio/ch/DatagramChannelImpl.c ! src/windows/native/sun/nio/ch/DatagramChannelImpl.c + test/java/nio/channels/DatagramChannel/Disconnect.java Changeset: fd22345bf1bf Author: sla Date: 2012-04-23 16:34 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fd22345bf1bf 7163524: Add SecTaskAccess attribute to jstack [macosx] Reviewed-by: dholmes ! make/launchers/Makefile.launcher Changeset: 2c35304e885a Author: youdwei Date: 2012-04-24 21:06 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2c35304e885a 7163865: Performance improvement for DateFormatSymbols.getZoneIndex(String) Reviewed-by: okutsu ! src/share/classes/java/text/DateFormatSymbols.java Changeset: f68c854fa584 Author: ksrini Date: 2012-04-24 10:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f68c854fa584 7151434: java -jar -XX crashes java launcher Reviewed-by: mchung, darcy ! src/share/bin/java.c ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/TestHelper.java Changeset: fcdbd1f34309 Author: khazra Date: 2012-04-24 14:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fcdbd1f34309 7144274: [macosx] Default IPv6 multicast interface is not being set when calling MulticastSocket.joinGroup() Summary: Get default interface for Mac OS X when interface is not set Reviewed-by: chegar ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/net_util_md.c Changeset: 3e398b549cea Author: khazra Date: 2012-04-25 12:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3e398b549cea 7160242: (prefs) Preferences.remove(null) does not throw NPE [macosx] Summary: Insert null check of argument in remove()'s implementation Reviewed-by: forax, chegar, alanb ! src/macosx/classes/java/util/prefs/MacOSXPreferences.java + test/java/util/prefs/RemoveNullKeyCheck.java Changeset: 108a02a57b75 Author: khazra Date: 2012-04-26 12:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/108a02a57b75 7118100: (prefs) Inconsistency when using system and user preference on OSX Lion Summary: Enable user to read/write preferences to persistent storage Reviewed-by: alanb ! src/macosx/classes/java/util/prefs/MacOSXPreferences.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java Changeset: 1cdcca9f3530 Author: lana Date: 2012-04-26 14:21 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1cdcca9f3530 Merge Changeset: f0842ed897c3 Author: xuelei Date: 2012-04-27 04:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f0842ed897c3 6996372: synchronizing handshaking hash Summary: remove the unnecessary synchronization. Also reviewed by David Schlosnagle (schlosna at gmail.com) Reviewed-by: weijun ! src/share/classes/sun/security/util/DisabledAlgorithmConstraints.java Changeset: c22b2f9066dd Author: alanb Date: 2012-05-01 11:17 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c22b2f9066dd 7164570: (fs) WatchService queues CREATE event but not DELETE event for very short lived files [sol11] Reviewed-by: chegar ! src/solaris/classes/sun/nio/fs/SolarisWatchService.java + test/java/nio/file/WatchService/MayFlies.java Changeset: 71fdf32fdc65 Author: xuelei Date: 2012-05-01 03:48 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/71fdf32fdc65 7158688: Typo in SSLContext Spec Reviewed-by: weijun, wetmore ! src/share/classes/javax/net/ssl/SSLContext.java Changeset: 6c9c3d7ce9e2 Author: lana Date: 2012-05-01 11:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6c9c3d7ce9e2 Merge Changeset: 46e0bd218fcc Author: mchung Date: 2012-05-01 19:45 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/46e0bd218fcc 7164376: Replace use of sun.security.action.LoadLibraryAction with System.loadLibrary Reviewed-by: alanb, mullan, prr ! src/macosx/classes/apple/launcher/JavaAppLauncher.java ! src/macosx/classes/apple/security/KeychainStore.java ! src/macosx/classes/com/apple/concurrent/LibDispatchNative.java ! src/macosx/classes/com/apple/eawt/Application.java ! src/macosx/classes/com/apple/eio/FileManager.java ! src/macosx/classes/com/apple/laf/AquaFileView.java ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/com/apple/laf/AquaNativeResources.java ! src/macosx/classes/com/apple/laf/ScreenMenu.java ! src/macosx/classes/com/apple/laf/ScreenPopupFactory.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java ! src/macosx/classes/sun/awt/CGraphicsEnvironment.java ! src/macosx/classes/sun/lwawt/macosx/CAccessibility.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java ! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java ! src/share/classes/java/awt/SplashScreen.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/event/NativeLibLoader.java ! src/share/classes/java/awt/image/ColorModel.java ! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/net/DatagramPacket.java ! src/share/classes/java/net/InetAddress.java ! src/share/classes/java/net/NetworkInterface.java ! src/share/classes/sun/awt/NativeLibLoader.java ! src/share/classes/sun/awt/image/JPEGImageDecoder.java ! src/share/classes/sun/awt/image/NativeLibLoader.java ! src/share/classes/sun/java2d/Disposer.java ! src/share/classes/sun/management/ManagementFactoryHelper.java ! src/share/classes/sun/net/sdp/SdpSupport.java ! src/share/classes/sun/net/spi/DefaultProxySelector.java ! src/share/classes/sun/nio/ch/Util.java - src/share/classes/sun/security/action/LoadLibraryAction.java ! src/share/classes/sun/security/krb5/SCDynamicStoreConfig.java ! src/share/classes/sun/security/smartcardio/PCSC.java ! src/share/classes/sun/tracing/dtrace/JVM.java ! src/solaris/classes/sun/management/FileSystemImpl.java ! src/solaris/classes/sun/net/dns/ResolverConfigurationImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpChannelImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpMultiChannelImpl.java ! src/solaris/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java ! src/solaris/classes/sun/print/CUPSPrinter.java ! src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/classes/sun/management/FileSystemImpl.java ! src/windows/classes/sun/net/dns/ResolverConfigurationImpl.java ! src/windows/classes/sun/print/Win32PrintServiceLookup.java ! src/windows/classes/sun/security/smartcardio/PlatformPCSC.java Changeset: d78c6095dc98 Author: vinnie Date: 2012-05-02 14:50 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d78c6095dc98 7087021: TEST: com/sun/crypto/provider/Mac/MacClone.java failed on Solaris sparc 5.10 Reviewed-by: mullan ! test/com/sun/crypto/provider/Mac/MacClone.java Changeset: 717582c056f3 Author: lana Date: 2012-05-02 10:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/717582c056f3 Merge - src/macosx/bin/amd64/jvm.cfg - src/share/classes/sun/security/action/LoadLibraryAction.java ! test/tools/launcher/TestHelper.java - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: bc0f9e693620 Author: lana Date: 2012-05-08 13:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bc0f9e693620 Merge - src/macosx/bin/amd64/jvm.cfg - src/share/classes/sun/security/action/LoadLibraryAction.java - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: 185821106403 Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/185821106403 Added tag jdk8-b37 for changeset 9e82ac15ab80 ! .hgtags Changeset: c45f3509a707 Author: katleman Date: 2012-05-09 13:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c45f3509a707 Merge - src/macosx/bin/amd64/jvm.cfg - src/share/classes/sun/security/action/LoadLibraryAction.java - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: b5726775b0d8 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b5726775b0d8 Added tag jdk8-b38 for changeset c45f3509a707 ! .hgtags From littlee at linux.vnet.ibm.com Fri May 11 01:22:15 2012 From: littlee at linux.vnet.ibm.com (littlee at linux.vnet.ibm.com) Date: Fri, 11 May 2012 08:22:15 +0000 Subject: hg: jdk8/tl/jdk: 7163874: InetAddress.isReachable should support pinging 0.0.0.0 Message-ID: <20120511082234.A2A0F47277@hg.openjdk.java.net> Changeset: c5a07e3dca63 Author: youdwei Date: 2012-05-11 16:20 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c5a07e3dca63 7163874: InetAddress.isReachable should support pinging 0.0.0.0 Reviewed-by: alanb, chegar ! src/share/native/java/net/net_util.h ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/net_util_md.c + test/java/net/Inet4Address/PingThis.java From sean.coffey at oracle.com Fri May 11 02:09:22 2012 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Fri, 11 May 2012 09:09:22 +0000 Subject: hg: jdk8/tl/jdk: 7167359: (tz) SEGV on solaris if TZ variable not set Message-ID: <20120511090932.BD28847278@hg.openjdk.java.net> Changeset: 3e83229a3779 Author: coffeys Date: 2012-05-11 10:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3e83229a3779 7167359: (tz) SEGV on solaris if TZ variable not set Reviewed-by: okutsu ! src/solaris/native/java/util/TimeZone_md.c From staffan.larsen at oracle.com Fri May 11 02:34:32 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 11 May 2012 11:34:32 +0200 Subject: RFR (S): 7167157: jcmd command file parsing does not respect the "stop" command Message-ID: Please review the following fix for the fix for 7154822. Previously all lines in the command file were sent to the JVM as one string, but the size limit was 1024 bytes so this was changed in 7154822 to sending one line at a time. Problem with this is that the jcmd utility keeps sending commands even if it has encountered a 'stop'. So instead of relying on the JVM to parse the 'stop' command, we must now parse this in the jcmd utility. webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.00/ Thanks, /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120511/3667d489/attachment.html From nils.loodin at oracle.com Fri May 11 02:41:23 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Fri, 11 May 2012 11:41:23 +0200 Subject: RFR (S): 7167157: jcmd command file parsing does not respect the "stop" command In-Reply-To: References: Message-ID: Should it be "startsWith"? I don't know if we ever plan to implement a command that's called stopFeatureX, but still.. Regards, Nils Loodin On May 11, 2012, at 11:34 , Staffan Larsen wrote: > Please review the following fix for the fix for 7154822. Previously all lines in the command file were sent to the JVM as one string, but the size limit was 1024 bytes so this was changed in 7154822 to sending one line at a time. Problem with this is that the jcmd utility keeps sending commands even if it has encountered a 'stop'. So instead of relying on the JVM to parse the 'stop' command, we must now parse this in the jcmd utility. > > webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.00/ > > Thanks, > /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120511/a5133b61/attachment.html From staffan.larsen at oracle.com Fri May 11 03:17:48 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 11 May 2012 12:17:48 +0200 Subject: RFR (S): 7167157: jcmd command file parsing does not respect the "stop" command In-Reply-To: References: Message-ID: <818D2614-C90C-47AF-A8D6-4F8489A353C6@oracle.com> Right. Should probably be line.trim().equals("stop") /Staffan On 11 maj 2012, at 11:41, Nils Loodin wrote: > Should it be "startsWith"? I don't know if we ever plan to implement a command that's called stopFeatureX, but still.. > > Regards, > Nils Loodin > > On May 11, 2012, at 11:34 , Staffan Larsen wrote: > >> Please review the following fix for the fix for 7154822. Previously all lines in the command file were sent to the JVM as one string, but the size limit was 1024 bytes so this was changed in 7154822 to sending one line at a time. Problem with this is that the jcmd utility keeps sending commands even if it has encountered a 'stop'. So instead of relying on the JVM to parse the 'stop' command, we must now parse this in the jcmd utility. >> >> webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.00/ >> >> Thanks, >> /Staffan > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120511/8fd2c662/attachment.html From staffan.larsen at oracle.com Fri May 11 03:42:15 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 11 May 2012 12:42:15 +0200 Subject: RFR (S): 7167157: jcmd command file parsing does not respect the "stop" command In-Reply-To: <818D2614-C90C-47AF-A8D6-4F8489A353C6@oracle.com> References: <818D2614-C90C-47AF-A8D6-4F8489A353C6@oracle.com> Message-ID: <708DB3B1-A7A4-4B3D-B7D0-D641D13AC80A@oracle.com> New webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.01/ On 11 maj 2012, at 12:17, Staffan Larsen wrote: > Right. Should probably be line.trim().equals("stop") > > /Staffan > > On 11 maj 2012, at 11:41, Nils Loodin wrote: > >> Should it be "startsWith"? I don't know if we ever plan to implement a command that's called stopFeatureX, but still.. >> >> Regards, >> Nils Loodin >> >> On May 11, 2012, at 11:34 , Staffan Larsen wrote: >> >>> Please review the following fix for the fix for 7154822. Previously all lines in the command file were sent to the JVM as one string, but the size limit was 1024 bytes so this was changed in 7154822 to sending one line at a time. Problem with this is that the jcmd utility keeps sending commands even if it has encountered a 'stop'. So instead of relying on the JVM to parse the 'stop' command, we must now parse this in the jcmd utility. >>> >>> webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.00/ >>> >>> Thanks, >>> /Staffan >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120511/3b56456a/attachment.html From nils.loodin at oracle.com Fri May 11 05:07:46 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Fri, 11 May 2012 14:07:46 +0200 Subject: Fwd: RFR: 7165755 OS Information much longer on linux than other platforms References: <4FACEF5C.6070503@oracle.com> Message-ID: Lists accidentally dropped of here. For the official record, Davd Holmes, are you hereby happy with the state of my changes and ready to stand by that as an official reviewer? :) Regards, Nils Loodin Begin forwarded message: > From: David Holmes > Subject: Re: RFR: 7165755 OS Information much longer on linux than other platforms > Date: May 11, 2012 12:52:12 GMT+02:00 > To: Nils Loodin > > On 11/05/2012 5:22 PM, Nils Loodin wrote: >>> Missed one: >>> >>> 39 #include "os_linux.hpp" >>> >> Gah. Indeed. >> >>> >>> Do we want the initial st->print("OS:") on the brief info the way we >>> have on the full info? >> I judged no, due to the fact that this would (well in our case anyway, >> but I thought generally) be used by other tools to get a brief info. >> They would then have that string as a label in a gui, or something else. >> Or if they want to print somewhere, they should print that string on >> their own. > > Ok. > >> About OS_xx.cpp including OS_xx.hpp, I feel I'm missing something.. can >> you please help me say why that's a no-no? And what does it have to do >> with the old included implementation? > > It isn't that it is wrong, it's that it hasn't been necessary. So I was wondering why it was now necessary, as if it had been necessary I would have expected it to be done when the old include system got converted. I think these files only need include the generic os.hpp and that it turn will include the platform specific ones. > >> Changing the above, are you ok with the changes? > > Yes. > > Though we should probably be having this conversation on the open lists ;-) > > Cheers, > David > > >>> >>> David >> >> Regards, >> Nils Loodin >> >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120511/1e22d591/attachment-0001.html From nils.loodin at oracle.com Fri May 11 06:45:48 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Fri, 11 May 2012 15:45:48 +0200 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: References: <4FACEF5C.6070503@oracle.com> Message-ID: And, to be clear, I updated a few lines after the conversation with David. Here's the lastest: http://cr.openjdk.java.net/~nloodin/7165755/webrev.03 Also, David, could you sponsor my push if you're happy? Dear regards, Nils Loodin On May 11, 2012, at 14:07 , Nils Loodin wrote: > Lists accidentally dropped of here. > > For the official record, Davd Holmes, are you hereby happy with the state of my changes and ready to stand by that as an official reviewer? :) > > Regards, > Nils Loodin > > Begin forwarded message: > >> From: David Holmes >> Subject: Re: RFR: 7165755 OS Information much longer on linux than other platforms >> Date: May 11, 2012 12:52:12 GMT+02:00 >> To: Nils Loodin >> >> On 11/05/2012 5:22 PM, Nils Loodin wrote: >>>> Missed one: >>>> >>>> 39 #include "os_linux.hpp" >>>> >>> Gah. Indeed. >>> >>>> >>>> Do we want the initial st->print("OS:") on the brief info the way we >>>> have on the full info? >>> I judged no, due to the fact that this would (well in our case anyway, >>> but I thought generally) be used by other tools to get a brief info. >>> They would then have that string as a label in a gui, or something else. >>> Or if they want to print somewhere, they should print that string on >>> their own. >> >> Ok. >> >>> About OS_xx.cpp including OS_xx.hpp, I feel I'm missing something.. can >>> you please help me say why that's a no-no? And what does it have to do >>> with the old included implementation? >> >> It isn't that it is wrong, it's that it hasn't been necessary. So I was wondering why it was now necessary, as if it had been necessary I would have expected it to be done when the old include system got converted. I think these files only need include the generic os.hpp and that it turn will include the platform specific ones. >> >>> Changing the above, are you ok with the changes? >> >> Yes. >> >> Though we should probably be having this conversation on the open lists ;-) >> >> Cheers, >> David >> >> >>>> >>>> David >>> >>> Regards, >>> Nils Loodin >>> >>> >>> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120511/a1c9b5f1/attachment.html From john.coomes at oracle.com Fri May 11 07:31:20 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 May 2012 14:31:20 +0000 Subject: hg: hsx/hotspot-rt/langtools: 9 new changesets Message-ID: <20120511143140.3B00E4728B@hg.openjdk.java.net> Changeset: 55ae94116e89 Author: jjg Date: 2012-04-06 10:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/55ae94116e89 7157626: Create a new test to check major version for a class file Reviewed-by: jjg Contributed-by: sonali.goel at oracle.com + test/tools/javac/classfiles/ClassVersionChecker.java Changeset: 9c429f38ca7e Author: ksrini Date: 2012-04-09 14:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/9c429f38ca7e 7156633: (javac) incorrect errors when parsing variable declaration in block statements. Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/IllegalStartOfStmt.java + test/tools/javac/diags/examples/NotAllowedClass.java + test/tools/javac/diags/examples/NotAllowedVariable.java ! test/tools/javac/parser/JavacParserTest.java Changeset: c35b158e2290 Author: lana Date: 2012-04-10 23:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/c35b158e2290 Merge Changeset: 6f0ed5a89c25 Author: mcimadamore Date: 2012-04-11 10:50 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/6f0ed5a89c25 7154127: Inference cleanup: remove bound check analysis from visitors in Types.java Summary: Remove bound checking rules from recursive subtype visitors in Types.java and replace with centralized bound-checking logic Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! test/tools/javac/Diagnostics/6722234/T6722234b_1.out ! test/tools/javac/Diagnostics/6722234/T6722234b_2.out ! test/tools/javac/Diagnostics/6799605/T6799605.out ! test/tools/javac/cast/7123100/T7123100a.out ! test/tools/javac/diags/examples.not-yet.txt ! test/tools/javac/diags/examples/CantApplyDiamond1.java ! test/tools/javac/diags/examples/IncompatibleTypes1.java + test/tools/javac/diags/examples/InferNoConformingAssignment.java - test/tools/javac/diags/examples/InferredDoNotConformToBounds.java + test/tools/javac/diags/examples/InferredDoNotConformToEq.java + test/tools/javac/diags/examples/InferredDoNotConformToLower.java + test/tools/javac/diags/examples/InferredDoNotConformToUpper.java ! test/tools/javac/diags/examples/InvalidInferredTypes.java ! test/tools/javac/diags/examples/WhereCaptured.java ! test/tools/javac/diags/examples/WhereCaptured1.java + test/tools/javac/diags/examples/WhereFreshTvar.java ! test/tools/javac/generics/diamond/neg/Neg06.out ! test/tools/javac/generics/diamond/neg/Neg07.out ! test/tools/javac/generics/inference/6315770/T6315770.out ! test/tools/javac/generics/inference/6611449/T6611449.out ! test/tools/javac/generics/inference/6638712/T6638712b.out ! test/tools/javac/generics/inference/6638712/T6638712d.out ! test/tools/javac/generics/inference/6638712/T6638712e.out ! test/tools/javac/generics/inference/6650759/T6650759m.out ! test/tools/javac/generics/inference/7086601/T7086601a.out + test/tools/javac/generics/inference/7154127/T7154127.java + test/tools/javac/generics/inference/7154127/T7154127.out Changeset: d023d5c3fbd2 Author: lana Date: 2012-04-18 10:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d023d5c3fbd2 Merge - test/tools/javac/diags/examples/InferredDoNotConformToBounds.java Changeset: 94bbaa67686f Author: lana Date: 2012-04-23 16:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/94bbaa67686f Merge - test/tools/javac/diags/examples/InferredDoNotConformToBounds.java Changeset: 5891b38985e8 Author: katleman Date: 2012-04-26 14:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/5891b38985e8 Added tag jdk8-b36 for changeset 94bbaa67686f ! .hgtags Changeset: 1f224f160aa8 Author: katleman Date: 2012-05-09 13:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/1f224f160aa8 Added tag jdk8-b37 for changeset 5891b38985e8 ! .hgtags Changeset: a9f547c218d9 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/a9f547c218d9 Added tag jdk8-b38 for changeset 1f224f160aa8 ! .hgtags From sundararajan.athijegannathan at oracle.com Fri May 11 07:34:46 2012 From: sundararajan.athijegannathan at oracle.com (sundararajan.athijegannathan at oracle.com) Date: Fri, 11 May 2012 14:34:46 +0000 Subject: hg: jdk8/tl/langtools: 7166990: java/compiler Inherited interfaces using generics sometimes looses the generic type Message-ID: <20120511143449.B11294728C@hg.openjdk.java.net> Changeset: 96a8278e323c Author: sundar Date: 2012-05-11 20:06 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/96a8278e323c 7166990: java/compiler Inherited interfaces using generics sometimes looses the generic type Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/TryWithResources/T7164542.java From erik.gahlin at oracle.com Fri May 11 07:36:20 2012 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Fri, 11 May 2012 16:36:20 +0200 Subject: RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team Message-ID: <4FAD23E4.90501@oracle.com> Could you please review? I also need a sponsor. http://cr.openjdk.java.net/~egahlin/7156518/1_0/ http://monaco.us.oracle.com/detail.jsf?cr=7017818 The patch is for JDK8, but it needs to ported to 7u6 before 5/16. Thanks! Erik Changes: - Moved localization messages to property files, one message per line, as needed. - Added '&' to messages so mnemonics could be identified. - Introduced Message class with static fields corresponding to the keys in the property files. - Added map for looking up mnemonics. Testing: - Verified programmatically that all the messages and mnemonics are "compatible" with the previous mechanism, for Chinese, Japanese and the default locale. - The intention is to run through the GUI to confirm that everything looks ok, but I'm waiting for a build. Other: - Fixed a typo in the MemoryPoolStat class, the method getAfterGcUsage returned this.beforeGCUsage instead of this.afterGcUsage - When going through all the code I did some minor clean up that should not impact the program flow: * removed unused imports. * inlined temporary variables holding messages. * removed private member variables that were not accessed. * removed private methods that were not referenced. * removed local variables that were not used. * added generic types where needed. * static methods are now called statically. * added suppress serialization warning where it was needed. * removed suppress serialization annotation where it was not needed. - In the Message class, the comment "remove? not found in code" will be removed once I know those message are not needed for 7u6. From michael.fang at oracle.com Fri May 11 09:16:35 2012 From: michael.fang at oracle.com (Michael Fang) Date: Fri, 11 May 2012 09:16:35 -0700 Subject: RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team In-Reply-To: <4FAD23E4.90501@oracle.com> References: <4FAD23E4.90501@oracle.com> Message-ID: <4FAD3B63.8070501@oracle.com> Thanks so much Erik for the fix! The messages.properties file look good. I only reviewed the English *messages.properties* file. WPTG will re-translate the ja and zh_CN files. They will attempt to leverage existing translation from *JConsoleResources_xx.java*. I have a comments about another translatability rule that WPTG follows: By Oracle software development guideline, ALL CAPs or StudlyCaps strings will not be translated. Examples are: 19 ACTION_CAPITALIZED=ACTION 20 ACTION_INFO_CAPITALIZED=ACTION_INFO 149 MBEAN_INFO=MBeanInfo 150 MBEAN_NOTIFICATION_INFO=MBeanNotificationInfo 151 MBEAN_OPERATION_INFO=MBeanOperationInfo 206 OBJECT_NAME=ObjectName 231 R_FORWARD_SLASH_W_CAPITALIZED=R/W 241 SEQ_NUM=SeqNum 249 SUMMARY_TAB_HEADER_DATE_TIME_FORMAT=FULL,FULL 273 UNKNOWN_CAPITALIZED=UNKNOWN If any of the above such as ACTION or UNKNOWN needs to be translated, they should not be ALL CAPS. The translators will not translate those lines by default. The translators have the ability to see comments (or special requests) if a comment line is inserted immediately prior to any of the resources (each resource string and one comment line immediately before it is stored in translation memory). If you must leave ACTION or UNKNOWN in CAPS, you can try to insert comments.However, WPTG does not guarantee they will be followed. thanks, -michael On 12?05?11? 07:36 ??, Erik Gahlin wrote: > Could you please review? I also need a sponsor. > > http://cr.openjdk.java.net/~egahlin/7156518/1_0/ > > http://monaco.us.oracle.com/detail.jsf?cr=7017818 > > The patch is for JDK8, but it needs to ported to 7u6 before 5/16. > > Thanks! > > Erik > > Changes: > > - Moved localization messages to property files, one message per line, > as needed. > - Added '&' to messages so mnemonics could be identified. > - Introduced Message class with static fields corresponding to the > keys in the property files. > - Added map for looking up mnemonics. > > Testing: > > - Verified programmatically that all the messages and mnemonics are > "compatible" with the previous mechanism, for Chinese, Japanese and > the default locale. > - The intention is to run through the GUI to confirm that everything > looks ok, but I'm waiting for a build. > > Other: > > - Fixed a typo in the MemoryPoolStat class, the method getAfterGcUsage > returned this.beforeGCUsage instead of this.afterGcUsage > - When going through all the code I did some minor clean up that > should not impact the program flow: > * removed unused imports. > * inlined temporary variables holding messages. > * removed private member variables that were not accessed. > * removed private methods that were not referenced. > * removed local variables that were not used. > * added generic types where needed. > * static methods are now called statically. > * added suppress serialization warning where it was needed. > * removed suppress serialization annotation where it was not needed. > - In the Message class, the comment "remove? not found in code" will > be removed once I know those message are not needed for 7u6. > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120511/e1bdd4e3/attachment-0001.html From mike.duigou at oracle.com Fri May 11 11:33:09 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Fri, 11 May 2012 18:33:09 +0000 Subject: hg: jdk8/tl/jdk: 7071826: Avoid benign race condition in initialization of UUID Message-ID: <20120511183329.C6DDD47296@hg.openjdk.java.net> Changeset: 944676ef3c58 Author: mduigou Date: 2012-05-11 11:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/944676ef3c58 7071826: Avoid benign race condition in initialization of UUID Summary: Avoids mostly benign but sometimes expensive race condition on initialization of UUID.numberGenerator which is used by UUID.randomUUID() Reviewed-by: alanb, chegar ! src/share/classes/java/util/UUID.java ! test/java/util/UUID/UUIDTest.java From lana.steuck at oracle.com Fri May 11 13:24:19 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 May 2012 20:24:19 +0000 Subject: hg: jdk8/tl: 6 new changesets Message-ID: <20120511202419.87820472A2@hg.openjdk.java.net> Changeset: afeeed8e5f8c Author: ihse Date: 2012-04-30 12:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/afeeed8e5f8c 7165277: Fix missing execute permission issue running logger.sh Reviewed-by: ohair ! common/autoconf/configure ! common/autoconf/configure.ac Changeset: b2972095a4b1 Author: katleman Date: 2012-05-02 15:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b2972095a4b1 Merge Changeset: 2eeb9fac7dfc Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/2eeb9fac7dfc Added tag jdk8-b37 for changeset b2972095a4b1 ! .hgtags Changeset: 2f06b15e2439 Author: ewendeli Date: 2012-05-03 14:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/rev/2f06b15e2439 7154130: Add Mac OS X Instructions to README-builds.html Reviewed-by: ohair Contributed-by: edvard.wendelin at oracle.com ! README-builds.html Changeset: d939bd0ab13c Author: katleman Date: 2012-05-09 16:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/d939bd0ab13c Merge Changeset: b67bdaca36c2 Author: katleman Date: 2012-05-10 10:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b67bdaca36c2 Added tag jdk8-b38 for changeset d939bd0ab13c ! .hgtags From lana.steuck at oracle.com Fri May 11 13:24:17 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 May 2012 20:24:17 +0000 Subject: hg: jdk8/tl/corba: 3 new changesets Message-ID: <20120511202421.7AE32472A3@hg.openjdk.java.net> Changeset: 2d2f6b0f855b Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/2d2f6b0f855b Added tag jdk8-b37 for changeset 83fac66442cf ! .hgtags Changeset: b8cbfb31139f Author: katleman Date: 2012-05-09 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/b8cbfb31139f Merge Changeset: 785af00e2827 Author: katleman Date: 2012-05-10 10:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/785af00e2827 Added tag jdk8-b38 for changeset b8cbfb31139f ! .hgtags From lana.steuck at oracle.com Fri May 11 13:24:24 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 May 2012 20:24:24 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20120511202431.A4534472A4@hg.openjdk.java.net> Changeset: ac1ba3b56775 Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/ac1ba3b56775 Added tag jdk8-b37 for changeset b05a948db1b6 ! .hgtags Changeset: 7f6b44fd3034 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/7f6b44fd3034 Added tag jdk8-b38 for changeset ac1ba3b56775 ! .hgtags From lana.steuck at oracle.com Fri May 11 13:24:28 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 May 2012 20:24:28 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20120511202437.85022472A5@hg.openjdk.java.net> Changeset: 1f224f160aa8 Author: katleman Date: 2012-05-09 13:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1f224f160aa8 Added tag jdk8-b37 for changeset 5891b38985e8 ! .hgtags Changeset: a9f547c218d9 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a9f547c218d9 Added tag jdk8-b38 for changeset 1f224f160aa8 ! .hgtags Changeset: 885806e74240 Author: lana Date: 2012-05-11 12:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/885806e74240 Merge From lana.steuck at oracle.com Fri May 11 13:24:27 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 May 2012 20:24:27 +0000 Subject: hg: jdk8/tl/jaxp: 4 new changesets Message-ID: <20120511202441.17C96472A6@hg.openjdk.java.net> Changeset: aabc08ea546f Author: ohair Date: 2012-04-30 16:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/aabc08ea546f 7165312: Fix jaxp source movement for new build-infra Reviewed-by: ohrstrom ! makefiles/Makefile Changeset: 90204bfab4e2 Author: katleman Date: 2012-05-02 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/90204bfab4e2 Merge Changeset: 5bbe0cb6f2f2 Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/5bbe0cb6f2f2 Added tag jdk8-b37 for changeset 90204bfab4e2 ! .hgtags Changeset: f95fdbe525c8 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/f95fdbe525c8 Added tag jdk8-b38 for changeset 5bbe0cb6f2f2 ! .hgtags From lana.steuck at oracle.com Fri May 11 13:24:32 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 May 2012 20:24:32 +0000 Subject: hg: jdk8/tl/hotspot: 21 new changesets Message-ID: <20120511202518.77CC9472A7@hg.openjdk.java.net> Changeset: 4ee58fcab520 Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4ee58fcab520 Added tag jdk8-b37 for changeset bfcf92bfefb8 ! .hgtags Changeset: 3c91f2c9fd21 Author: amurillo Date: 2012-04-20 17:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3c91f2c9fd21 7163193: new hotspot build - hs24-b09 Reviewed-by: jcoomes ! make/hotspot_version Changeset: f3a4ee95783b Author: kevinw Date: 2012-04-20 14:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f3a4ee95783b 7162488: VM not printing unknown -XX options Reviewed-by: dholmes, kamg ! src/share/vm/runtime/arguments.cpp + test/runtime/7162488/Test7162488.sh Changeset: 29ee40a082d3 Author: sla Date: 2012-04-23 13:30 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/29ee40a082d3 7162063: libsaproc debug print should format size_t correctly on 64bit platform Reviewed-by: rbackman, mgronlun, dholmes ! agent/src/os/linux/ps_core.c Changeset: f33c4d0f4c9e Author: dcubed Date: 2012-04-23 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f33c4d0f4c9e Merge Changeset: d652a62d6e03 Author: dcubed Date: 2012-03-23 11:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d652a62d6e03 7102323: RFE: enable Full Debug Symbols Phase 1 on Solaris Summary: Add support for ENABLE_FULL_DEBUG_SYMBOLS and ZIP_DEBUGINFO_FILES build flags. Add support for .diz files. Reviewed-by: dholmes, ohair, sspitsyn ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/jsig.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/vm.make ! make/solaris/Makefile ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/dtrace.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make ! make/windows/build.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/defs.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/product.make ! make/windows/makefiles/sa.make Changeset: 744728c16316 Author: dcubed Date: 2012-04-03 09:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/744728c16316 7158067: FDS: ENABLE_FULL_DEBUG_SYMBOLS flag should only affect product builds Summary: Build option FULL_DEBUG_SYMBOLS=0 only affects product builds. Reviewed-by: ohair, jmelvin, sspitsyn ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/defs.make ! make/solaris/Makefile ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make Changeset: 74c359c4a9e5 Author: dcubed Date: 2012-04-24 15:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/74c359c4a9e5 Merge ! make/Makefile ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/buildtree.make ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/sparcWorks.make ! make/solaris/makefiles/vm.make ! make/windows/build.make ! make/windows/makefiles/compile.make ! make/windows/makefiles/debug.make ! make/windows/makefiles/defs.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/product.make Changeset: d6c393b0164b Author: dcubed Date: 2012-04-25 15:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d6c393b0164b 7164344: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Solaris and Windows Summary: Disable FDS by default on Solaris; disable ZIP_DEBUGINFO_FILES by default on Windows. Reviewed-by: acorn, sspitsyn ! make/solaris/makefiles/defs.make ! make/windows/makefiles/defs.make Changeset: 973046802b6f Author: dlong Date: 2012-04-26 16:24 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/973046802b6f 7162955: Attach api on Solaris, too many open files Summary: Release server-side socket after client receives it. Reviewed-by: sla, dsamersoff, dcubed, acorn Contributed-by: dean.long at oracle.com ! src/os/solaris/vm/attachListener_solaris.cpp Changeset: 6f0612ea55ce Author: jprovino Date: 2012-05-02 15:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6f0612ea55ce Merge Changeset: 9f059abe8cf2 Author: jmasa Date: 2012-03-29 19:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9f059abe8cf2 7131629: Generalize the CMS free list code Summary: Make the FreeChunk, FreeList, TreeList, and BinaryTreeDictionary classes usable outside CMS. Reviewed-by: brutisso, johnc, jwilhelm Contributed-by: coleen.phillimore at oracle.com - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp + src/share/vm/memory/binaryTreeDictionary.cpp + src/share/vm/memory/binaryTreeDictionary.hpp + src/share/vm/memory/freeBlockDictionary.cpp + src/share/vm/memory/freeBlockDictionary.hpp + src/share/vm/memory/freeList.cpp + src/share/vm/memory/freeList.hpp ! src/share/vm/memory/generationSpec.cpp ! src/share/vm/precompiled/precompiled.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 8a2e5a6a19a4 Author: johnc Date: 2012-04-25 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8a2e5a6a19a4 7143490: G1: Remove HeapRegion::_top_at_conc_mark_count Summary: Removed the HeapRegion::_top_at_conc_mark_count field. It is no longer needed as a result of the changes for 6888336 and 7127706. Refactored the closures that finalize and verify the liveness counting data so that common functionality was placed into a base class. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegion.inline.hpp Changeset: f69a5d43dc19 Author: jmasa Date: 2012-04-25 09:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f69a5d43dc19 7164144: Fix variable naming style in freeBlockDictionary.* and binaryTreeDictionary* Summary: Fix naming style to be consistent with the predominant hotspot style. Reviewed-by: ysr, brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/promotionInfo.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/promotionInfo.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/binaryTreeDictionary.hpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/freeBlockDictionary.hpp ! src/share/vm/memory/freeList.cpp ! src/share/vm/memory/freeList.hpp Changeset: ee89f2110312 Author: jmasa Date: 2012-04-25 15:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ee89f2110312 Merge Changeset: 48fac5d60c3c Author: brutisso Date: 2012-04-25 12:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/48fac5d60c3c 7163848: G1: Log GC Cause for a GC Reviewed-by: johnc, jwilhelm, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: bb18e8eecb7e Author: jcoomes Date: 2012-05-04 10:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bb18e8eecb7e Merge - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp Changeset: 7d5ec8bf38d1 Author: amurillo Date: 2012-05-04 14:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7d5ec8bf38d1 Merge - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp Changeset: 4e6554041847 Author: amurillo Date: 2012-05-04 14:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4e6554041847 Added tag hs24-b09 for changeset 7d5ec8bf38d1 ! .hgtags Changeset: 637c3f5f068f Author: amurillo Date: 2012-05-09 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/637c3f5f068f Merge ! .hgtags Changeset: 3c394919ca69 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3c394919ca69 Added tag jdk8-b38 for changeset 637c3f5f068f ! .hgtags From lana.steuck at oracle.com Fri May 11 13:26:12 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 11 May 2012 20:26:12 +0000 Subject: hg: jdk8/tl/jdk: 26 new changesets Message-ID: <20120511203038.395E8472A8@hg.openjdk.java.net> Changeset: 8e3fb7dd21cd Author: skovatch Date: 2012-04-25 12:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e3fb7dd21cd 7128699: Fix bundle name so it contains the bugfix number in the name. Reviewed-by: robilad ! make/common/Release-macosx.gmk Changeset: 919be2f7fd6e Author: cgruszka Date: 2012-04-27 14:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/919be2f7fd6e Merge Changeset: 762661efef30 Author: jgodinez Date: 2012-04-24 13:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/762661efef30 7157659: [macosx] Landscape Printing orientation doesn't work Reviewed-by: bae, prr ! src/macosx/native/sun/awt/PrinterView.m Changeset: cdaadcc2c6a4 Author: jgodinez Date: 2012-04-26 13:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdaadcc2c6a4 7013850: Please change the mnemonic assignment system to avoid translation issue Reviewed-by: prr, mfang ! src/share/classes/sun/print/ServiceDialog.java ! src/share/classes/sun/print/resources/serviceui.properties ! src/share/classes/sun/print/resources/serviceui_de.properties ! src/share/classes/sun/print/resources/serviceui_es.properties ! src/share/classes/sun/print/resources/serviceui_fr.properties ! src/share/classes/sun/print/resources/serviceui_it.properties ! src/share/classes/sun/print/resources/serviceui_ja.properties ! src/share/classes/sun/print/resources/serviceui_ko.properties ! src/share/classes/sun/print/resources/serviceui_pt_BR.properties ! src/share/classes/sun/print/resources/serviceui_sv.properties ! src/share/classes/sun/print/resources/serviceui_zh_CN.properties ! src/share/classes/sun/print/resources/serviceui_zh_TW.properties Changeset: c2d29a375871 Author: lana Date: 2012-04-26 18:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2d29a375871 Merge Changeset: 4a19075bb989 Author: lana Date: 2012-05-02 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a19075bb989 Merge Changeset: 44beb8a52aec Author: zhouyx Date: 2012-04-20 10:34 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44beb8a52aec 7129742: Unable to view focus in Non-Editable TextArea Summary: Make sure the cursor is visible by setVisible(true) Reviewed-by: rupashka, alexp ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java + test/java/awt/TextArea/TextAreaCaretVisibilityTest/bug7129742.java Changeset: dfa2ea47257d Author: luchsh Date: 2012-04-20 13:13 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dfa2ea47257d 7055065: NullPointerException when sorting JTable with empty cell Reviewed-by: rupashka ! src/share/classes/javax/swing/JTable.java + test/javax/swing/JTable/7055065/bug7055065.java Changeset: 738b32fc3ef1 Author: anthony Date: 2012-04-24 17:47 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/738b32fc3ef1 7150109: [macosx] the Frame showed incomplete. Summary: Open-source the tests Reviewed-by: art + test/java/awt/Frame/FrameStateTest/FrameStateTest.html + test/java/awt/Frame/FrameStateTest/FrameStateTest.java Changeset: 9ed029a0326d Author: anthony Date: 2012-04-24 19:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9ed029a0326d 7163898: add isLoggable() check to doLog() Summary: Add the check and return immediately if it's false Reviewed-by: anthony, mchung, sla Contributed-by: Nicolas Carranza ! src/share/classes/sun/util/logging/PlatformLogger.java Changeset: 4a0f6ef43a09 Author: anthony Date: 2012-04-24 20:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4a0f6ef43a09 7131021: [macosx] Consider using system properties to pass arguments from the launcher to AWT/SplashScreen Summary: Document the environment variables and add tests Reviewed-by: ksrini ! src/macosx/bin/java_md_macosx.c + test/tools/launcher/EnvironmentVariables.java ! test/tools/launcher/TestHelper.java + test/tools/launcher/TestSpecialArgs.java Changeset: 36fd5078198b Author: alexsch Date: 2012-04-25 16:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/36fd5078198b 7163482: [macosx] Regtest closed/javax/swing/JTree/4908142/bug4908142.java intermittent failure Reviewed-by: rupashka + test/javax/swing/JTree/4908142/bug4908142.java Changeset: f1d1dab11a06 Author: leonidr Date: 2012-04-25 18:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1d1dab11a06 7154480: [macosx] Not all popup menu items are visible Reviewed-by: art ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/share/classes/javax/swing/JPopupMenu.java ! src/share/classes/sun/awt/SunToolkit.java Changeset: 340cda7e1430 Author: luchsh Date: 2012-04-26 12:39 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/340cda7e1430 7154030: java.awt.Component.hide() does not repaint parent component Reviewed-by: rupashka ! src/share/classes/javax/swing/JComponent.java + test/javax/swing/JComponent/7154030/bug7154030.java Changeset: 6314933aeaa9 Author: alexp Date: 2012-04-26 21:16 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6314933aeaa9 7124210: [macosx] Replacing text in a TextField does generate an extra TextEvent Reviewed-by: serb ! src/macosx/classes/sun/lwawt/LWTextAreaPeer.java ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java Changeset: 4184e5cbf46e Author: alexp Date: 2012-04-26 21:25 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4184e5cbf46e 7124328: [macosx] javax.swing.JDesktopPane.getAllFramesInLayer returns unexpected value Reviewed-by: anthony ! src/share/classes/javax/swing/JDesktopPane.java Changeset: d148d3d194af Author: lana Date: 2012-04-26 18:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d148d3d194af Merge Changeset: bbbf4e63562b Author: dcherepanov Date: 2012-05-02 13:53 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bbbf4e63562b 7154062: [macosx] Mouse cursor isn't updated in applets Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/macosx/CCursorManager.java ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java ! src/macosx/native/sun/awt/CCursorManager.m Changeset: 0fad89bd606b Author: alexsch Date: 2012-05-02 17:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0fad89bd606b 7154048: [macosx] At least drag twice, the toolbar can be dragged to the left side Reviewed-by: anthony, leonidr ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTView.h ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m + test/java/awt/Mouse/EnterExitEvents/DragWindowOutOfFrameTest.java + test/java/awt/Mouse/EnterExitEvents/DragWindowTest.java + test/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java ! test/java/awt/regtesthelpers/Util.java Changeset: f906d6068b43 Author: lana Date: 2012-05-02 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f906d6068b43 Merge Changeset: 717582c056f3 Author: lana Date: 2012-05-02 10:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/717582c056f3 Merge - src/macosx/bin/amd64/jvm.cfg - src/share/classes/sun/security/action/LoadLibraryAction.java ! test/tools/launcher/TestHelper.java - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: bc0f9e693620 Author: lana Date: 2012-05-08 13:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc0f9e693620 Merge - src/macosx/bin/amd64/jvm.cfg - src/share/classes/sun/security/action/LoadLibraryAction.java - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: 185821106403 Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/185821106403 Added tag jdk8-b37 for changeset 9e82ac15ab80 ! .hgtags Changeset: c45f3509a707 Author: katleman Date: 2012-05-09 13:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c45f3509a707 Merge - src/macosx/bin/amd64/jvm.cfg - src/share/classes/sun/security/action/LoadLibraryAction.java - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: b5726775b0d8 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b5726775b0d8 Added tag jdk8-b38 for changeset c45f3509a707 ! .hgtags Changeset: 85d7677a75bf Author: lana Date: 2012-05-11 12:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85d7677a75bf Merge From stuart.marks at oracle.com Fri May 11 14:26:25 2012 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 11 May 2012 21:26:25 +0000 Subject: hg: jdk8/tl/jdk: 7144861: speed up RMI activation tests Message-ID: <20120511212644.C182F472AA@hg.openjdk.java.net> Changeset: f131d4361faf Author: olagneau Date: 2012-05-11 14:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f131d4361faf 7144861: speed up RMI activation tests Reviewed-by: alanb, smarks, dholmes, dmocek ! test/java/rmi/activation/checkusage/CheckUsage.java ! test/java/rmi/testlibrary/ActivationLibrary.java ! test/java/rmi/testlibrary/JavaVM.java ! test/java/rmi/testlibrary/RMID.java ! test/java/rmi/testlibrary/StreamPipe.java ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java From yumin.qi at oracle.com Fri May 11 14:48:18 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Fri, 11 May 2012 14:48:18 -0700 Subject: request for codereview, bug 7149528: easy usage of serviceability agent Message-ID: <4FAD8922.9010902@oracle.com> Hi, all Can I have your codereview for bug 7149528: easy usage of serviceability agent. Problems 1) for launching Serviceability Agent(SA) is that it needs setting several environmental variables for class path, library path options. It is not easy for user to become familiar with those settings. 2) SA launched from java and attached to java process (or the binary which loaded JVM). On MacOS, attaching to process needs permission. If we grant access for SA, we have to grant all java processes have the same access permission so brings security concern on the platform since java is too generic for doing so. With a separate SA launcher, giving it permission attaching to java process solves the concern. the change for both hotspot and jdk: http://cr.openjdk.java.net/~minqi/7149528 Thanks Yumin From kevin.walls at oracle.com Fri May 11 15:59:43 2012 From: kevin.walls at oracle.com (kevin.walls at oracle.com) Date: Fri, 11 May 2012 22:59:43 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7157734: hotspot test scripts not testing 64-bit JVM under JPRT/JTREG. Message-ID: <20120511225945.D53BE472AC@hg.openjdk.java.net> Changeset: 037973617842 Author: kevinw Date: 2012-05-11 17:24 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/037973617842 7157734: hotspot test scripts not testing 64-bit JVM under JPRT/JTREG. Reviewed-by: kvn ! test/compiler/6894807/Test6894807.sh ! test/gc/6941923/test6941923.sh ! test/runtime/6626217/Test6626217.sh ! test/runtime/6878713/Test6878713.sh ! test/runtime/6929067/Test6929067.sh ! test/runtime/7020373/Test7020373.sh ! test/runtime/7051189/Xchecksig.sh ! test/runtime/7158988/TestFieldMonitor.sh From david.holmes at oracle.com Sat May 12 05:22:26 2012 From: david.holmes at oracle.com (David Holmes) Date: Sat, 12 May 2012 22:22:26 +1000 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: References: <4FACEF5C.6070503@oracle.com> Message-ID: <4FAE5602.4020206@oracle.com> Hi Nils, On 11/05/2012 11:45 PM, Nils Loodin wrote: > And, to be clear, I updated a few lines after the conversation with > David. Here's the lastest: > http://cr.openjdk.java.net/~nloodin/7165755/webrev.03 > I'm okay with this change. Do you have a second reviewer for this final format? > Also, David, could you sponsor my push if you're happy? Where are you pushing to? hotspot-rt? I can do the push once my home directory server comes back online :( And once I see a second reviewer. Thanks, David > Dear regards, > Nils Loodin > > On May 11, 2012, at 14:07 , Nils Loodin wrote: > >> Lists accidentally dropped of here. >> >> For the official record, Davd Holmes, are you hereby happy with the >> state of my changes and ready to stand by that as an official reviewer? :) >> >> Regards, >> Nils Loodin >> >> Begin forwarded message: >> >>> *From: *David Holmes >> > >>> *Subject: **Re: RFR: 7165755 OS Information much longer on linux than >>> other platforms* >>> *Date: *May 11, 2012 12:52:12 GMT+02:00 >>> *To: *Nils Loodin >> > >>> >>> On 11/05/2012 5:22 PM, Nils Loodin wrote: >>>>> Missed one: >>>>> >>>>> 39 #include "os_linux.hpp" >>>>> >>>> Gah. Indeed. >>>> >>>>> >>>>> Do we want the initial st->print("OS:") on the brief info the way we >>>>> have on the full info? >>>> I judged no, due to the fact that this would (well in our case anyway, >>>> but I thought generally) be used by other tools to get a brief info. >>>> They would then have that string as a label in a gui, or something else. >>>> Or if they want to print somewhere, they should print that string on >>>> their own. >>> >>> Ok. >>> >>>> About OS_xx.cpp including OS_xx.hpp, I feel I'm missing something.. can >>>> you please help me say why that's a no-no? And what does it have to do >>>> with the old included implementation? >>> >>> It isn't that it is wrong, it's that it hasn't been necessary. So I >>> was wondering why it was now necessary, as if it had been necessary I >>> would have expected it to be done when the old include system got >>> converted. I think these files only need include the generic os.hpp >>> and that it turn will include the platform specific ones. >>> >>>> Changing the above, are you ok with the changes? >>> >>> Yes. >>> >>> Though we should probably be having this conversation on the open >>> lists ;-) >>> >>> Cheers, >>> David >>> >>> >>>>> >>>>> David >>>> >>>> Regards, >>>> Nils Loodin >>>> >>>> >>>> >> > From zhengyu.gu at oracle.com Sat May 12 06:10:27 2012 From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com) Date: Sat, 12 May 2012 13:10:27 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 24 new changesets Message-ID: <20120512131117.1EE78472BC@hg.openjdk.java.net> Changeset: 973046802b6f Author: dlong Date: 2012-04-26 16:24 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/973046802b6f 7162955: Attach api on Solaris, too many open files Summary: Release server-side socket after client receives it. Reviewed-by: sla, dsamersoff, dcubed, acorn Contributed-by: dean.long at oracle.com ! src/os/solaris/vm/attachListener_solaris.cpp Changeset: 6f0612ea55ce Author: jprovino Date: 2012-05-02 15:47 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6f0612ea55ce Merge Changeset: 9f059abe8cf2 Author: jmasa Date: 2012-03-29 19:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9f059abe8cf2 7131629: Generalize the CMS free list code Summary: Make the FreeChunk, FreeList, TreeList, and BinaryTreeDictionary classes usable outside CMS. Reviewed-by: brutisso, johnc, jwilhelm Contributed-by: coleen.phillimore at oracle.com - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp + src/share/vm/memory/binaryTreeDictionary.cpp + src/share/vm/memory/binaryTreeDictionary.hpp + src/share/vm/memory/freeBlockDictionary.cpp + src/share/vm/memory/freeBlockDictionary.hpp + src/share/vm/memory/freeList.cpp + src/share/vm/memory/freeList.hpp ! src/share/vm/memory/generationSpec.cpp ! src/share/vm/precompiled/precompiled.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 8a2e5a6a19a4 Author: johnc Date: 2012-04-25 10:23 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8a2e5a6a19a4 7143490: G1: Remove HeapRegion::_top_at_conc_mark_count Summary: Removed the HeapRegion::_top_at_conc_mark_count field. It is no longer needed as a result of the changes for 6888336 and 7127706. Refactored the closures that finalize and verify the liveness counting data so that common functionality was placed into a base class. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegion.inline.hpp Changeset: f69a5d43dc19 Author: jmasa Date: 2012-04-25 09:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f69a5d43dc19 7164144: Fix variable naming style in freeBlockDictionary.* and binaryTreeDictionary* Summary: Fix naming style to be consistent with the predominant hotspot style. Reviewed-by: ysr, brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/promotionInfo.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/promotionInfo.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/binaryTreeDictionary.hpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/freeBlockDictionary.hpp ! src/share/vm/memory/freeList.cpp ! src/share/vm/memory/freeList.hpp Changeset: ee89f2110312 Author: jmasa Date: 2012-04-25 15:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ee89f2110312 Merge Changeset: 48fac5d60c3c Author: brutisso Date: 2012-04-25 12:36 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/48fac5d60c3c 7163848: G1: Log GC Cause for a GC Reviewed-by: johnc, jwilhelm, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: bb18e8eecb7e Author: jcoomes Date: 2012-05-04 10:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bb18e8eecb7e Merge - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp Changeset: bfcf92bfefb8 Author: katleman Date: 2012-04-26 14:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bfcf92bfefb8 Added tag jdk8-b36 for changeset 50b4400ca1ec ! .hgtags Changeset: 7d5ec8bf38d1 Author: amurillo Date: 2012-05-04 14:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7d5ec8bf38d1 Merge - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp Changeset: 4e6554041847 Author: amurillo Date: 2012-05-04 14:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4e6554041847 Added tag hs24-b09 for changeset 7d5ec8bf38d1 ! .hgtags Changeset: 36538fd1225e Author: amurillo Date: 2012-05-04 15:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/36538fd1225e 7166615: new hotspot build - hs24-b10 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 8bafad97cd26 Author: jiangli Date: 2012-05-02 13:21 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8bafad97cd26 7158552: The instanceKlsss::_host_klass is only needed for anonymous class for JSR 292 support. Summary: Change the _host_klass to be conditionally created embedded instanceKlass field. Reviewed-by: jrose, coleenp, dholmes ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/instanceKlassKlass.hpp Changeset: 38b4116b6766 Author: jprovino Date: 2012-05-05 10:24 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/38b4116b6766 Merge Changeset: c7ed11779ce8 Author: jiangli Date: 2012-04-10 09:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c7ed11779ce8 7159772: instanceKlass::all_fields_count() returns incorrect total field count Summary: Fix instanceKlass::all_fields_count() bug. Reviewed-by: kvn, never Contributed-by: Jiangli Zhou ! src/share/vm/oops/instanceKlass.hpp Changeset: 3576af4cb939 Author: iveresov Date: 2012-04-11 19:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3576af4cb939 7160539: JDeveloper crashes on 64-bit Windows Summary: x64 C1 needs to zero upper 32bits when doing l2i conversion Reviewed-by: never, kvn ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: 847da049d62f Author: never Date: 2012-04-17 11:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/847da049d62f 7162094: LateInlineCallGenerator::do_late_inline crashed on uninitialized _call_node Reviewed-by: never, twisti Contributed-by: nils.eliasson at oracle.com ! src/share/vm/opto/callGenerator.cpp Changeset: df3d4a91f7f6 Author: never Date: 2012-04-18 16:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/df3d4a91f7f6 7161796: PhaseStringOpts::fetch_static_field tries to fetch field from the Klass instead of the mirror Reviewed-by: twisti ! src/share/vm/opto/stringopts.cpp Changeset: ec15e8f6e4f1 Author: twisti Date: 2012-04-24 12:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ec15e8f6e4f1 7157695: Add windows implementation of socket interface Reviewed-by: kvn, dholmes, twisti Contributed-by: Nils Eliasson ! src/os/windows/vm/jvm_windows.h ! src/os/windows/vm/os_windows.cpp Changeset: dc682d9431f3 Author: kvn Date: 2012-05-07 12:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/dc682d9431f3 7160610: Unknown Native Code compilation issue Summary: When constructing input vector use type of vector's operation which use it since element's sizes should match. Reviewed-by: never, twisti ! src/share/vm/opto/superword.cpp + test/compiler/7160610/Test7160610.java Changeset: 3a97daec1b34 Author: kvn Date: 2012-05-08 15:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3a97daec1b34 7167266: missing copyright notes in 3rd party code Summary: add missing copyright notes to the regression test file. Reviewed-by: twisti, johnc ! test/compiler/7070134/Stemmer.java Changeset: 2766551175a0 Author: kvn Date: 2012-05-09 10:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2766551175a0 Merge ! src/share/vm/oops/instanceKlass.hpp Changeset: 2f4819f92dc7 Author: zgu Date: 2012-05-10 18:19 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2f4819f92dc7 Merge - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/binaryTreeDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeBlockDictionary.hpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/freeList.hpp Changeset: b4f7c4315c36 Author: zgu Date: 2012-05-12 06:50 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b4f7c4315c36 Merge From mjw at redhat.com Mon May 14 01:06:51 2012 From: mjw at redhat.com (Mark Wielaard) Date: Mon, 14 May 2012 10:06:51 +0200 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FABE435.3070101@oracle.com> References: <4FABE435.3070101@oracle.com> Message-ID: <1336982811.3015.1.camel@springer.wildebeest.org> On Thu, 2012-05-10 at 09:52 -0600, Daniel D. Daugherty wrote: > Adding serviceability-dev at openjdk.java.net to this e-mail thread. Thanks. Please let me know if there is anything I can do to help integration of these patches, or if there are other places/people I need to add to the CC for review. > On 5/10/12 7:49 AM, Mark Wielaard wrote: > > Hi, > > > > The following three patches enable support for dtrace compatible sdt probes > > on GNU/Linux. Most of the support was already submitted earlier. These are > > just the last three things left in IcedTea that actually enable it in > > hotspot. It has been in production use for some time already. > > > > The patches could be applied all as one, or individually if you want to be > > able to test them independently. > > > > The first patch is just a consistency cleanup patch. The JNI Set and > > SetStatic Field methods used HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N > > directly instead of just using DTRACE_PROBE[N] like all other JNI methods. > > This doesn't matter for the Solaris macros, but on GNU/Linux the macros > > don't use direct function declarations (which is introduced in the second > > patch). > > > > The second patch introduces the DTRACE macros for use with the GNU/Linux > > SystemTap provided sys/sdt.h. Like Solaris this uses USDT1, but using > > macros instead of function declaractions. So it just adds a check for > > whether USDT1 is used with SOLARIS (HS_DTRACE_WORKAROUND_TAIL_CALL_BUG > > is only needed there) and defines HS_DTRACE_PROBE[N] for the LINUX case. > > > > The last patch enables the support in the build. I took the approach > > used in the make/solaris/dtrace.make and vm.make file with a test to > > see whether sys/sdt.h is available or not and printing a notice when > > they are not found. In IcedTea there is a more elaborate configure > > check to see if a small C++ program can be build with DTRACE probes > > in it, but that looked like overkill here. > > > > Patches in separate emails. > > > > Cheers, > > > > Mark > > > > The second patch adds the actual > > src/share/vm/prims/jni.cpp | 11 ++------ > > src/share/vm/utilities/dtrace.hpp | 50 ++++++++++++++++++++++++++++++++++++++- > > make/linux/makefiles/dtrace.make | 24 ++++++++++++++++++ > > make/linux/makefiles/vm.make | 2 +- > > 4 files changed, 77 insertions(+), 10 deletions(-) From nils.loodin at oracle.com Mon May 14 01:41:13 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Mon, 14 May 2012 10:41:13 +0200 Subject: RFR: 7165755 OS Information much longer on linux than other platforms In-Reply-To: <4FAE5602.4020206@oracle.com> References: <4FACEF5C.6070503@oracle.com> <4FAE5602.4020206@oracle.com> Message-ID: <19CA986F-3BEA-4E70-847A-9B41EE457A0E@oracle.com> Right! Well Staffan Larsen was, but he's gone on vacation this week. I'll dig up another. I'm looking to push this to hotspot-rt as well as 7u6, which as you probably know is here: http://hg.openjdk.java.net/hsx/hsx23.2/hotspot/ Regards, Nils Loodin On May 12, 2012, at 14:22 , David Holmes wrote: > Hi Nils, > > On 11/05/2012 11:45 PM, Nils Loodin wrote: >> And, to be clear, I updated a few lines after the conversation with >> David. Here's the lastest: >> http://cr.openjdk.java.net/~nloodin/7165755/webrev.03 >> > > I'm okay with this change. Do you have a second reviewer for this final format? > >> Also, David, could you sponsor my push if you're happy? > > Where are you pushing to? hotspot-rt? > > I can do the push once my home directory server comes back online :( > > And once I see a second reviewer. > > Thanks, > David > > >> Dear regards, >> Nils Loodin >> >> On May 11, 2012, at 14:07 , Nils Loodin wrote: >> >>> Lists accidentally dropped of here. >>> >>> For the official record, Davd Holmes, are you hereby happy with the >>> state of my changes and ready to stand by that as an official reviewer? :) >>> >>> Regards, >>> Nils Loodin >>> >>> Begin forwarded message: >>> >>>> *From: *David Holmes >>> > >>>> *Subject: **Re: RFR: 7165755 OS Information much longer on linux than >>>> other platforms* >>>> *Date: *May 11, 2012 12:52:12 GMT+02:00 >>>> *To: *Nils Loodin >>> > >>>> >>>> On 11/05/2012 5:22 PM, Nils Loodin wrote: >>>>>> Missed one: >>>>>> >>>>>> 39 #include "os_linux.hpp" >>>>>> >>>>> Gah. Indeed. >>>>> >>>>>> >>>>>> Do we want the initial st->print("OS:") on the brief info the way we >>>>>> have on the full info? >>>>> I judged no, due to the fact that this would (well in our case anyway, >>>>> but I thought generally) be used by other tools to get a brief info. >>>>> They would then have that string as a label in a gui, or something else. >>>>> Or if they want to print somewhere, they should print that string on >>>>> their own. >>>> >>>> Ok. >>>> >>>>> About OS_xx.cpp including OS_xx.hpp, I feel I'm missing something.. can >>>>> you please help me say why that's a no-no? And what does it have to do >>>>> with the old included implementation? >>>> >>>> It isn't that it is wrong, it's that it hasn't been necessary. So I >>>> was wondering why it was now necessary, as if it had been necessary I >>>> would have expected it to be done when the old include system got >>>> converted. I think these files only need include the generic os.hpp >>>> and that it turn will include the platform specific ones. >>>> >>>>> Changing the above, are you ok with the changes? >>>> >>>> Yes. >>>> >>>> Though we should probably be having this conversation on the open >>>> lists ;-) >>>> >>>> Cheers, >>>> David >>>> >>>> >>>>>> >>>>>> David >>>>> >>>>> Regards, >>>>> Nils Loodin >>>>> >>>>> >>>>> >>> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120514/5a451373/attachment.html From rickard.backman at oracle.com Mon May 14 01:55:30 2012 From: rickard.backman at oracle.com (=?UTF-8?B?Umlja2FyZCBCw6Rja21hbg==?=) Date: Mon, 14 May 2012 10:55:30 +0200 Subject: RFR: 7161732: Improve handling of thread_id in OSThread In-Reply-To: <4FA2523D.6000106@oracle.com> References: <4FA2523D.6000106@oracle.com> Message-ID: <4FB0C882.3010202@oracle.com> Hi, this has been out on review for a while, without any OK or objections. So I'll ask again, can I have a review or two on this small change? Thanks /R On 05/03/2012 11:39 AM, Rickard B?ckman wrote: > Hi all, > > I've made a refactoring of thread_id in OSThread, which reduces the > amount of duplicated code. > > Please review this change at: > http://cr.openjdk.java.net/~rbackman/7161732/webrev/ > > Thanks > /R From nils.loodin at oracle.com Mon May 14 02:37:52 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Mon, 14 May 2012 11:37:52 +0200 Subject: RFR: 7161732: Improve handling of thread_id in OSThread In-Reply-To: <4FB0C882.3010202@oracle.com> References: <4FA2523D.6000106@oracle.com> <4FB0C882.3010202@oracle.com> Message-ID: <0F242ACD-307C-497C-B5AC-88D3C989B883@oracle.com> Well it looks ok to me anyway.. Regards, Nils Loodin On May 14, 2012, at 10:55 , Rickard B?ckman wrote: > Hi, > > this has been out on review for a while, without any OK or objections. > So I'll ask again, can I have a review or two on this small change? > > Thanks > /R > > On 05/03/2012 11:39 AM, Rickard B?ckman wrote: >> Hi all, >> >> I've made a refactoring of thread_id in OSThread, which reduces the >> amount of duplicated code. >> >> Please review this change at: >> http://cr.openjdk.java.net/~rbackman/7161732/webrev/ >> >> Thanks >> /R > From david.holmes at oracle.com Mon May 14 04:29:59 2012 From: david.holmes at oracle.com (David Holmes) Date: Mon, 14 May 2012 21:29:59 +1000 Subject: RFR: 7161732: Improve handling of thread_id in OSThread In-Reply-To: <4FB0C882.3010202@oracle.com> References: <4FA2523D.6000106@oracle.com> <4FB0C882.3010202@oracle.com> Message-ID: <4FB0ECB7.4030806@oracle.com> On 14/05/2012 6:55 PM, Rickard B?ckman wrote: > this has been out on review for a while, without any OK or objections. > So I'll ask again, can I have a review or two on this small change? Sorry Rickard I got distracted from my earlier start on this. Reviewed! David ----- > Thanks > /R > > On 05/03/2012 11:39 AM, Rickard B?ckman wrote: >> Hi all, >> >> I've made a refactoring of thread_id in OSThread, which reduces the >> amount of duplicated code. >> >> Please review this change at: >> http://cr.openjdk.java.net/~rbackman/7161732/webrev/ >> >> Thanks >> /R > From rickard.backman at oracle.com Mon May 14 04:32:58 2012 From: rickard.backman at oracle.com (=?UTF-8?B?Umlja2FyZCBCw6Rja21hbg==?=) Date: Mon, 14 May 2012 13:32:58 +0200 Subject: RFR: 7161732: Improve handling of thread_id in OSThread In-Reply-To: <4FB0ECB7.4030806@oracle.com> References: <4FA2523D.6000106@oracle.com> <4FB0C882.3010202@oracle.com> <4FB0ECB7.4030806@oracle.com> Message-ID: <4FB0ED6A.5080802@oracle.com> Thank you, David! /R On 05/14/2012 01:29 PM, David Holmes wrote: > On 14/05/2012 6:55 PM, Rickard B?ckman wrote: >> this has been out on review for a while, without any OK or objections. >> So I'll ask again, can I have a review or two on this small change? > > Sorry Rickard I got distracted from my earlier start on this. > > Reviewed! > > David > ----- > >> Thanks >> /R >> >> On 05/03/2012 11:39 AM, Rickard B?ckman wrote: >>> Hi all, >>> >>> I've made a refactoring of thread_id in OSThread, which reduces the >>> amount of duplicated code. >>> >>> Please review this change at: >>> http://cr.openjdk.java.net/~rbackman/7161732/webrev/ >>> >>> Thanks >>> /R >> From daniel.daugherty at oracle.com Mon May 14 06:41:50 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Mon, 14 May 2012 07:41:50 -0600 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <1336982811.3015.1.camel@springer.wildebeest.org> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> Message-ID: <4FB10B9E.8060500@oracle.com> On 5/14/12 2:06 AM, Mark Wielaard wrote: > On Thu, 2012-05-10 at 09:52 -0600, Daniel D. Daugherty wrote: >> Adding serviceability-dev at openjdk.java.net to this e-mail thread. > Thanks. Please let me know if there is anything I can do to help > integration of these patches, or if there are other places/people I need > to add to the CC for review. No problem. I was just making sure your e-mails got to the right aliases. As I no longer work on the Serviceability team, I'll leave it to them to address your e-mails. Dan >> On 5/10/12 7:49 AM, Mark Wielaard wrote: >>> Hi, >>> >>> The following three patches enable support for dtrace compatible sdt probes >>> on GNU/Linux. Most of the support was already submitted earlier. These are >>> just the last three things left in IcedTea that actually enable it in >>> hotspot. It has been in production use for some time already. >>> >>> The patches could be applied all as one, or individually if you want to be >>> able to test them independently. >>> >>> The first patch is just a consistency cleanup patch. The JNI Set and >>> SetStatic Field methods used HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N >>> directly instead of just using DTRACE_PROBE[N] like all other JNI methods. >>> This doesn't matter for the Solaris macros, but on GNU/Linux the macros >>> don't use direct function declarations (which is introduced in the second >>> patch). >>> >>> The second patch introduces the DTRACE macros for use with the GNU/Linux >>> SystemTap provided sys/sdt.h. Like Solaris this uses USDT1, but using >>> macros instead of function declaractions. So it just adds a check for >>> whether USDT1 is used with SOLARIS (HS_DTRACE_WORKAROUND_TAIL_CALL_BUG >>> is only needed there) and defines HS_DTRACE_PROBE[N] for the LINUX case. >>> >>> The last patch enables the support in the build. I took the approach >>> used in the make/solaris/dtrace.make and vm.make file with a test to >>> see whether sys/sdt.h is available or not and printing a notice when >>> they are not found. In IcedTea there is a more elaborate configure >>> check to see if a small C++ program can be build with DTRACE probes >>> in it, but that looked like overkill here. >>> >>> Patches in separate emails. >>> >>> Cheers, >>> >>> Mark >>> >>> The second patch adds the actual >>> src/share/vm/prims/jni.cpp | 11 ++------ >>> src/share/vm/utilities/dtrace.hpp | 50 ++++++++++++++++++++++++++++++++++++++- >>> make/linux/makefiles/dtrace.make | 24 ++++++++++++++++++ >>> make/linux/makefiles/vm.make | 2 +- >>> 4 files changed, 77 insertions(+), 10 deletions(-) > From xuelei.fan at oracle.com Mon May 14 07:27:51 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Mon, 14 May 2012 14:27:51 +0000 Subject: hg: jdk8/tl/jdk: 7167988: PKIX CertPathBuilder in reverse mode doesn't work if more than one trust anchor is specified Message-ID: <20120514142802.3D861472EA@hg.openjdk.java.net> Changeset: df3152beef2f Author: xuelei Date: 2012-05-14 07:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df3152beef2f 7167988: PKIX CertPathBuilder in reverse mode doesn't work if more than one trust anchor is specified Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java + test/sun/security/provider/certpath/ReverseBuilder/ReverseBuild.java From dmitriy.samersoff at oracle.com Tue May 15 05:49:20 2012 From: dmitriy.samersoff at oracle.com (dmitriy.samersoff at oracle.com) Date: Tue, 15 May 2012 12:49:20 +0000 Subject: hg: jdk8/tl/jdk: 7164191: properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario Message-ID: <20120515124941.2EF834731A@hg.openjdk.java.net> Changeset: df33f5f750ec Author: dsamersoff Date: 2012-05-15 16:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df33f5f750ec 7164191: properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario Reviewed-by: dholmes, sla Contributed-by: Deven You ! src/share/classes/sun/management/Agent.java + test/sun/management/AgentCMETest.java From daniel.daugherty at oracle.com Tue May 15 10:44:01 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 15 May 2012 11:44:01 -0600 Subject: code review for FDS and dtrace work around (7165060) Message-ID: <4FB295E1.1080906@oracle.com> Greetings, This is a code review request for a work around for a Full Debug Symbols and DTrace work around on Solaris. The gobjcopy utility on Solaris 10 corrupts the SUNW_dof section of libjvm.so. I've created a minimal tool that adds the ".gnu_debuglink" section to libjvm.so without corrupting other sections in the libjvm.so file. Here is the webrev URL for the HSX-24 version: http://cr.openjdk.java.net/~dcubed/fds_revamp/7165060-webrev/1/ This fix has been reviewed internally by Serguei Spitsyn (sspitsyn), Karen Kinnear (acorn) and some folks from different Solaris groups. This fix will also be backported to HSX23.2/7u6 and I expect the changes to virtually identical. Thanks, in advance, for any additional reviews! Dan From kurchi.subhra.hazra at oracle.com Tue May 15 11:52:37 2012 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Tue, 15 May 2012 18:52:37 +0000 Subject: hg: jdk8/tl/jdk: 7164636: (prefs) Cleanup src/macosx/classes/java/util/prefs Message-ID: <20120515185255.5F19F47323@hg.openjdk.java.net> Changeset: 9a18e318f95a Author: khazra Date: 2012-05-15 11:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a18e318f95a 7164636: (prefs) Cleanup src/macosx/classes/java/util/prefs Summary: Remove rawtype usages and other code cleanup Reviewed-by: chegar, briangoetz ! src/macosx/classes/java/util/prefs/MacOSXPreferences.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFactory.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java From daniel.daugherty at oracle.com Tue May 15 14:42:54 2012 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Tue, 15 May 2012 21:42:54 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20120515214258.E2BE54732D@hg.openjdk.java.net> Changeset: 7d4e6dabc6bf Author: dcubed Date: 2012-05-15 10:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7d4e6dabc6bf 7165060: dtrace tests fail with FDS debug info files Summary: Work around 'gobjcopy --add-gnu-debuglink' failure by adding a temporary tool that adds the '.gnu_debuglink' section and nothing more. Reviewed-by: sspitsyn, acorn + make/solaris/makefiles/add_gnu_debuglink.make ! make/solaris/makefiles/vm.make + src/os/solaris/add_gnu_debuglink/add_gnu_debuglink.c Changeset: 80b9cc90b643 Author: dcubed Date: 2012-05-15 11:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/80b9cc90b643 Merge ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/vm.make From daniel.daugherty at oracle.com Tue May 15 16:04:03 2012 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Tue, 15 May 2012 23:04:03 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7169102: 7165060 merge lost changes to make/windows/makefiles/defs.make Message-ID: <20120515230406.289A247331@hg.openjdk.java.net> Changeset: 9793f47cdebc Author: dcubed Date: 2012-05-15 15:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9793f47cdebc 7169102: 7165060 merge lost changes to make/windows/makefiles/defs.make Reviewed-by: sspitsyn, acorn ! make/windows/makefiles/defs.make From david.holmes at oracle.com Wed May 16 03:52:35 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 16 May 2012 10:52:35 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7165755: OS Information much longer on linux than other platforms Message-ID: <20120516105242.D37FA4734B@hg.openjdk.java.net> Changeset: 7432b9db36ff Author: nloodin Date: 2012-05-10 15:44 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7432b9db36ff 7165755: OS Information much longer on linux than other platforms Reviewed-by: sla, dholmes ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/os/posix/vm/os_posix.cpp + src/os/posix/vm/os_posix.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/os/windows/vm/os_windows.cpp ! src/os/windows/vm/os_windows.hpp ! src/share/vm/runtime/os.hpp From alan.bateman at oracle.com Wed May 16 04:45:16 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 16 May 2012 11:45:16 +0000 Subject: hg: jdk8/tl/jdk: 7168505: (bf) MappedByteBuffer.load does not load buffer's content into memory Message-ID: <20120516114536.A425D4734C@hg.openjdk.java.net> Changeset: 332bebb463d1 Author: alanb Date: 2012-05-16 12:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/332bebb463d1 7168505: (bf) MappedByteBuffer.load does not load buffer's content into memory Reviewed-by: mduigou, forax ! src/share/classes/java/nio/MappedByteBuffer.java From daniel.daugherty at oracle.com Wed May 16 16:39:03 2012 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Wed, 16 May 2012 23:39:03 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7169409: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Windows X86 Message-ID: <20120516233907.D0D8F47368@hg.openjdk.java.net> Changeset: 198dcc84088c Author: dcubed Date: 2012-05-16 12:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/198dcc84088c 7169409: enabling ZIP_DEBUGINFO_FILES causes unexpected test failures on Windows X86 Summary: Disable ZIP_DEBUGINFO_FILES by default on Windows. Reviewed-by: acorn ! make/windows/makefiles/defs.make From Dmitry.Samersoff at oracle.com Thu May 17 00:44:37 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Thu, 17 May 2012 11:44:37 +0400 Subject: sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario In-Reply-To: <4F98A320.2030803@linux.vnet.ibm.com> References: <4F853485.7020607@linux.vnet.ibm.com> <4F863945.7020701@oracle.com> <4F8D1CBC.5040205@linux.vnet.ibm.com> <4F8E5282.3070507@oracle.com> <4F8E5D34.8050901@linux.vnet.ibm.com> <4F94EE8B.8070101@linux.vnet.ibm.com> <4F94F70D.1060906@oracle.com> <4F94F880.2020206@oracle.com> <4F95080C.7090007@linux.vnet.ibm.com> <4F969953.9090107@oracle.com> <4F97EEDE.7050102@oracle.com> <4F98A320.2030803@linux.vnet.ibm.com> Message-ID: <4FB4AC65.7090906@oracle.com> Deven, The fix is submitted to openjdk tl workspace http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df33f5f750ec -Dmitry On 2012-04-26 05:21, Deven You wrote: > Hi Dmitry, > > Thanks for your help. I have created a CR with internal id 2236492 which > hasn't be published yet. So please set this internal CR id as duplicate > to 716419 as well. > > This is the original mail for this problem: > > > > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Hi core-libs-devs, > > I am not sure if sun.management.Agent belongs to jmx-dev mailing list, > if so please anyone tell me. > > This issue is that the sun.management.Agent.loadManagementProperties() > will invoke properties.putAll which will throw > ConcurrentModifcationException if there are other threads which modify > the properties concurrently. > > I have made a patch[1] which synchronize the sysProps so that putAll can > work on multi-thread scenario. The test case is also available in [1]. > > Thanks a lot! > > [1] http://cr.openjdk.java.net/~littlee/OJDK-256/webrev.00 > > > ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > > Thanks a lot! > > > > On 04/25/2012 08:32 PM, Dmitry Samersoff wrote: >> Deven, >> >> CR number is 7164191 . >> >> Could you re-send me your original e-mail with problem description and >> webrev link. >> >> I'll put it to CR comment field. >> >> >> -Dmitry >> >> >> >> On 2012-04-24 16:15, Dmitry Samersoff wrote: >>> Deven, >>> >>> After close look and off-line discussion with David Holmes, >>> the changes looks good for me. >>> >>> I'll take care of the rest. >>> >>> We have one more place in Agent.java executing exactly the same code >>> so I'll change both of them on your behalf. >>> >>> -Dmitry >>> >>> >>> On 2012-04-23 11:43, Deven You wrote: >>>> Thanks David, >>>> >>>> So is it ok for you to contribute this patch? >>>> >>>> On 04/23/2012 02:36 PM, David Holmes wrote: >>>>> Except of course that Properties is a Hashtable and synchronizes on >>>>> 'this' for all public methods. So locking the properties object in the >>>>> client code will guarantee exclusive access to it. >>>>> >>>>> Sorry about that. >>>>> >>>>> David >>>>> ----- >>>>> >>>>> On 23/04/2012 4:30 PM, David Holmes wrote: >>>>>> Deven, >>>>>> >>>>>> On 23/04/2012 3:54 PM, Deven You wrote: >>>>>>> On 04/18/2012 02:20 PM, Deven You wrote: >>>>>>>> On 04/18/2012 01:34 PM, Mandy Chung wrote: >>>>>>>>> >>>>>>>>> I think this could still run into CME. System Properties is not a >>>>>>>>> synchronized map and the setter methods (System.setProperty or >>>>>>>>> Properties.put method) doesn't synchronize on the Properties >>>>>>>>> object. >>>>>>>>> >>>>>>>>> >>>>>>>>> The setter methods I'm referring to are System.setProperty and >>>>>>>>> System.getProperties().put(). >>>>>>>>> >>>>>>>> I have gone through the Agent.java, I think other set/put methods >>>>>>>> related to properties are protected properly. >>>>>>>> >>>>>>>> public static void agentmain using parseString(args) which return a >>>>>>>> properties which is a local var and is not possible to cause >>>>>>>> concurrent problem when call config_props.putAll(arg_props). >>>>>>>> >>>>>>>> private static synchronized void startLocalManagementAgent() is >>>>>>>> synchronized already. >>>>>>>> >>>>>>>> private static synchronized void startRemoteManagementAgent(String >>>>>>>> args) is synchronized also. >>>>>>>> >>>>>>>> Could you point where the CME may ocurr? >>>>>>> Is there any suggestion from the mailing list? >>>>>> The problem is that System.getProperties() returns a globally >>>>>> accessible >>>>>> set of properties. So even if you prevent the Agent code from >>>>>> modifying >>>>>> those properties concurrently with other use in the Agent, you >>>>>> have no >>>>>> such guard for any other piece of code in the system which might also >>>>>> modify the properties. So the race condition you were trying to fix >>>>>> still exists. I don't see any way to fix this. No matter what you do >>>>>> another thread can modify the system properties while you are >>>>>> iterating >>>>>> them. Instead you need to anticipate the CME and try to recover >>>>>> from it >>>>>> (also non-trivial). >>>>>> >>>>>> Cheers, >>>>>> David Holmes >>>> >>> >> > > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From youdwei at linux.vnet.ibm.com Thu May 17 00:58:39 2012 From: youdwei at linux.vnet.ibm.com (Deven You) Date: Thu, 17 May 2012 15:58:39 +0800 Subject: sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario In-Reply-To: <4FB4AC65.7090906@oracle.com> References: <4F853485.7020607@linux.vnet.ibm.com> <4F863945.7020701@oracle.com> <4F8D1CBC.5040205@linux.vnet.ibm.com> <4F8E5282.3070507@oracle.com> <4F8E5D34.8050901@linux.vnet.ibm.com> <4F94EE8B.8070101@linux.vnet.ibm.com> <4F94F70D.1060906@oracle.com> <4F94F880.2020206@oracle.com> <4F95080C.7090007@linux.vnet.ibm.com> <4F969953.9090107@oracle.com> <4F97EEDE.7050102@oracle.com> <4F98A320.2030803@linux.vnet.ibm.com> <4FB4AC65.7090906@oracle.com> Message-ID: <4FB4AFAF.5030709@linux.vnet.ibm.com> Hi Dmitry, I have verified the change set. Thanks for your commit! On 05/17/2012 03:44 PM, Dmitry Samersoff wrote: > Deven, > > The fix is submitted to openjdk tl workspace > > http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df33f5f750ec > > -Dmitry > > > On 2012-04-26 05:21, Deven You wrote: >> Hi Dmitry, >> >> Thanks for your help. I have created a CR with internal id 2236492 which >> hasn't be published yet. So please set this internal CR id as duplicate >> to 716419 as well. >> >> This is the original mail for this problem: >> >> >> >> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- >> >> Hi core-libs-devs, >> >> I am not sure if sun.management.Agent belongs to jmx-dev mailing list, >> if so please anyone tell me. >> >> This issue is that the sun.management.Agent.loadManagementProperties() >> will invoke properties.putAll which will throw >> ConcurrentModifcationException if there are other threads which modify >> the properties concurrently. >> >> I have made a patch[1] which synchronize the sysProps so that putAll can >> work on multi-thread scenario. The test case is also available in [1]. >> >> Thanks a lot! >> >> [1] http://cr.openjdk.java.net/~littlee/OJDK-256/webrev.00 >> >> >> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- >> >> >> Thanks a lot! >> >> >> >> On 04/25/2012 08:32 PM, Dmitry Samersoff wrote: >>> Deven, >>> >>> CR number is 7164191 . >>> >>> Could you re-send me your original e-mail with problem description and >>> webrev link. >>> >>> I'll put it to CR comment field. >>> >>> >>> -Dmitry >>> >>> >>> >>> On 2012-04-24 16:15, Dmitry Samersoff wrote: >>>> Deven, >>>> >>>> After close look and off-line discussion with David Holmes, >>>> the changes looks good for me. >>>> >>>> I'll take care of the rest. >>>> >>>> We have one more place in Agent.java executing exactly the same code >>>> so I'll change both of them on your behalf. >>>> >>>> -Dmitry >>>> >>>> >>>> On 2012-04-23 11:43, Deven You wrote: >>>>> Thanks David, >>>>> >>>>> So is it ok for you to contribute this patch? >>>>> >>>>> On 04/23/2012 02:36 PM, David Holmes wrote: >>>>>> Except of course that Properties is a Hashtable and synchronizes on >>>>>> 'this' for all public methods. So locking the properties object in the >>>>>> client code will guarantee exclusive access to it. >>>>>> >>>>>> Sorry about that. >>>>>> >>>>>> David >>>>>> ----- >>>>>> >>>>>> On 23/04/2012 4:30 PM, David Holmes wrote: >>>>>>> Deven, >>>>>>> >>>>>>> On 23/04/2012 3:54 PM, Deven You wrote: >>>>>>>> On 04/18/2012 02:20 PM, Deven You wrote: >>>>>>>>> On 04/18/2012 01:34 PM, Mandy Chung wrote: >>>>>>>>>> I think this could still run into CME. System Properties is not a >>>>>>>>>> synchronized map and the setter methods (System.setProperty or >>>>>>>>>> Properties.put method) doesn't synchronize on the Properties >>>>>>>>>> object. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> The setter methods I'm referring to are System.setProperty and >>>>>>>>>> System.getProperties().put(). >>>>>>>>>> >>>>>>>>> I have gone through the Agent.java, I think other set/put methods >>>>>>>>> related to properties are protected properly. >>>>>>>>> >>>>>>>>> public static void agentmain using parseString(args) which return a >>>>>>>>> properties which is a local var and is not possible to cause >>>>>>>>> concurrent problem when call config_props.putAll(arg_props). >>>>>>>>> >>>>>>>>> private static synchronized void startLocalManagementAgent() is >>>>>>>>> synchronized already. >>>>>>>>> >>>>>>>>> private static synchronized void startRemoteManagementAgent(String >>>>>>>>> args) is synchronized also. >>>>>>>>> >>>>>>>>> Could you point where the CME may ocurr? >>>>>>>> Is there any suggestion from the mailing list? >>>>>>> The problem is that System.getProperties() returns a globally >>>>>>> accessible >>>>>>> set of properties. So even if you prevent the Agent code from >>>>>>> modifying >>>>>>> those properties concurrently with other use in the Agent, you >>>>>>> have no >>>>>>> such guard for any other piece of code in the system which might also >>>>>>> modify the properties. So the race condition you were trying to fix >>>>>>> still exists. I don't see any way to fix this. No matter what you do >>>>>>> another thread can modify the system properties while you are >>>>>>> iterating >>>>>>> them. Instead you need to anticipate the CME and try to recover >>>>>>> from it >>>>>>> (also non-trivial). >>>>>>> >>>>>>> Cheers, >>>>>>> David Holmes >> > -- Best Regards, Deven From daniel.daugherty at oracle.com Thu May 17 07:14:22 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 17 May 2012 08:14:22 -0600 Subject: code review request for FDS/aurora bug fix (7168520) Message-ID: <4FB507BE.3030107@oracle.com> Greetings, This is a code review request for the following P1 bug: 7168520 1/3 No jdk8 TL Nightly linux builds due to broken link in b39-2012-05-13_231 Here is the URL for the webrev: http://cr.openjdk.java.net/~dcubed/fds_revamp/7168520-webrev/0/ This fix has already been reviewed internally and is in the process of being pushed to the JDK8 T&L repo. Since the bug impacts our internal aurora tool, we're moving very quickly on this issue. If this code review request generates any additional changes, then we'll use another bug ID to make those changes. Gory details below... In the original FDS implementation, per-VM libjsig.debuginfo symlinks were created that refer to ../libjsig.debuginfo. When the ZIP_DEBUGINFO_FILES feature is enabled (the default), the jre/lib//libjsig.debuginfo files are ZIPed into jre/lib//libjsig.diz. This makes the per-VM libjsig.debuginfo symlinks "dangling" because the ../libjsig.debuginfo files are ZIP'ed. Aurora doesn't tolerate dangling symlinks so this fix puts a work around in place. The work around ZIPs the per-VM libjsig.debuginfo symlinks into a per-VM libjsig.diz file. Aurora has no problem with ZIP files. After the work around is in place, the default libjsig.diz layout is: jre/lib//libjsig.diz - ZIP'ed real libjsig.debuginfo jre/lib//client/libjsig.diz - ZIP'ed symlink (libjsig.debuginfo -> ../libjsig.debuginfo) jre/lib//server/libjsig.diz - ZIP'ed symlink (libjsig.debuginfo -> ../libjsig.debuginfo) Dan From karen.kinnear at oracle.com Thu May 17 07:24:56 2012 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Thu, 17 May 2012 10:24:56 -0400 Subject: code review request for FDS/aurora bug fix (7168520) In-Reply-To: <4FB507BE.3030107@oracle.com> References: <4FB507BE.3030107@oracle.com> Message-ID: Dan, Code looks good. Thank you for figuring out this work-around. thanks, Karen On May 17, 2012, at 10:14 AM, Daniel D. Daugherty wrote: > Greetings, > > This is a code review request for the following P1 bug: > > 7168520 1/3 No jdk8 TL Nightly linux builds due to broken link in > b39-2012-05-13_231 > > Here is the URL for the webrev: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7168520-webrev/0/ > > This fix has already been reviewed internally and is in the process of > being pushed to the JDK8 T&L repo. Since the bug impacts our internal > aurora tool, we're moving very quickly on this issue. If this code > review request generates any additional changes, then we'll use another > bug ID to make those changes. > > Gory details below... > > In the original FDS implementation, per-VM libjsig.debuginfo symlinks were > created that refer to ../libjsig.debuginfo. When the ZIP_DEBUGINFO_FILES > feature is enabled (the default), the jre/lib//libjsig.debuginfo > files are ZIPed into jre/lib//libjsig.diz. This makes the per-VM > libjsig.debuginfo symlinks "dangling" because the ../libjsig.debuginfo > files are ZIP'ed. Aurora doesn't tolerate dangling symlinks so this fix > puts a work around in place. > > The work around ZIPs the per-VM libjsig.debuginfo symlinks into a per-VM > libjsig.diz file. Aurora has no problem with ZIP files. After the work > around is in place, the default libjsig.diz layout is: > > jre/lib//libjsig.diz - ZIP'ed real libjsig.debuginfo > jre/lib//client/libjsig.diz - ZIP'ed symlink > (libjsig.debuginfo -> ../libjsig.debuginfo) > jre/lib//server/libjsig.diz - ZIP'ed symlink > (libjsig.debuginfo -> ../libjsig.debuginfo) > > Dan > From daniel.daugherty at oracle.com Thu May 17 07:31:07 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 17 May 2012 08:31:07 -0600 Subject: code review request for FDS/aurora bug fix (7168520) In-Reply-To: References: <4FB507BE.3030107@oracle.com> Message-ID: <4FB50BAB.6050000@oracle.com> Thanks Karen! Since the JDK8 changeset is already in flight, I can't add you as a reviewer there, but I will add you as a reviewer to the 7u6 version which I'm putting together right now... Dan On 5/17/12 8:24 AM, Karen Kinnear wrote: > Dan, > > Code looks good. Thank you for figuring out this work-around. > > thanks, > Karen > > On May 17, 2012, at 10:14 AM, Daniel D. Daugherty wrote: > >> Greetings, >> >> This is a code review request for the following P1 bug: >> >> 7168520 1/3 No jdk8 TL Nightly linux builds due to broken link in >> b39-2012-05-13_231 >> >> Here is the URL for the webrev: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7168520-webrev/0/ >> >> This fix has already been reviewed internally and is in the process of >> being pushed to the JDK8 T&L repo. Since the bug impacts our internal >> aurora tool, we're moving very quickly on this issue. If this code >> review request generates any additional changes, then we'll use another >> bug ID to make those changes. >> >> Gory details below... >> >> In the original FDS implementation, per-VM libjsig.debuginfo symlinks were >> created that refer to ../libjsig.debuginfo. When the ZIP_DEBUGINFO_FILES >> feature is enabled (the default), the jre/lib//libjsig.debuginfo >> files are ZIPed into jre/lib//libjsig.diz. This makes the per-VM >> libjsig.debuginfo symlinks "dangling" because the ../libjsig.debuginfo >> files are ZIP'ed. Aurora doesn't tolerate dangling symlinks so this fix >> puts a work around in place. >> >> The work around ZIPs the per-VM libjsig.debuginfo symlinks into a per-VM >> libjsig.diz file. Aurora has no problem with ZIP files. After the work >> around is in place, the default libjsig.diz layout is: >> >> jre/lib//libjsig.diz - ZIP'ed real libjsig.debuginfo >> jre/lib//client/libjsig.diz - ZIP'ed symlink >> (libjsig.debuginfo -> ../libjsig.debuginfo) >> jre/lib//server/libjsig.diz - ZIP'ed symlink >> (libjsig.debuginfo -> ../libjsig.debuginfo) >> >> Dan >> From daniel.daugherty at oracle.com Thu May 17 07:59:51 2012 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Thu, 17 May 2012 14:59:51 +0000 Subject: hg: jdk8/tl/jdk: 7168520: No jdk8 TL Nightly linux builds due to broken link in b39-2012-05-13_231 Message-ID: <20120517150002.474624738B@hg.openjdk.java.net> Changeset: ce165aa48dcb Author: dcubed Date: 2012-05-17 06:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce165aa48dcb 7168520: No jdk8 TL Nightly linux builds due to broken link in b39-2012-05-13_231 Summary: ZIP libjsig.debuginfo links into libjsig.diz files since aurora doesn't like dangling symlinks Reviewed-by: katleman ! make/java/redist/Makefile From rob.mckenna at oracle.com Thu May 17 08:50:01 2012 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 17 May 2012 16:50:01 +0100 Subject: Codereview request for 7168110: Misleading jstack error message Message-ID: <4FB51E29.7060900@oracle.com> Hi folks, A straightforward enough fix for an issue whereby windows sees fit to return a cryptic error message when attempting to run jstack on a process created in another terminal session. As per the webrev, see the remarks section at: http://msdn.microsoft.com/en-us/library/ms682437%28VS.85%29.aspx Webrev at: http://cr.openjdk.java.net/~robm/7168110/webrev.01/ Thanks! -Rob From Dmitry.Samersoff at oracle.com Thu May 17 08:56:08 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Thu, 17 May 2012 19:56:08 +0400 Subject: Codereview request for 7168110: Misleading jstack error message In-Reply-To: <4FB51E29.7060900@oracle.com> References: <4FB51E29.7060900@oracle.com> Message-ID: <4FB51F98.80404@oracle.com> Rob, Looks good for me. -Dmitry On 2012-05-17 19:50, Rob McKenna wrote: > Hi folks, > > A straightforward enough fix for an issue whereby windows sees fit to > return a cryptic error message when attempting to run jstack on a > process created in another terminal session. > > As per the webrev, see the remarks section at: > > http://msdn.microsoft.com/en-us/library/ms682437%28VS.85%29.aspx > > Webrev at: > > http://cr.openjdk.java.net/~robm/7168110/webrev.01/ > > Thanks! > > -Rob -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From Alan.Bateman at oracle.com Thu May 17 08:58:57 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 17 May 2012 16:58:57 +0100 Subject: Codereview request for 7168110: Misleading jstack error message In-Reply-To: <4FB51E29.7060900@oracle.com> References: <4FB51E29.7060900@oracle.com> Message-ID: <4FB52041.5040606@oracle.com> On 17/05/2012 16:50, Rob McKenna wrote: > Hi folks, > > A straightforward enough fix for an issue whereby windows sees fit to > return a cryptic error message when attempting to run jstack on a > process created in another terminal session. > > As per the webrev, see the remarks section at: > > http://msdn.microsoft.com/en-us/library/ms682437%28VS.85%29.aspx > > Webrev at: > > http://cr.openjdk.java.net/~robm/7168110/webrev.01/ This looks okay to me and should be help in the event that someone specifies the vmid/pid that is in another terminal session. -Alan. From mjw at redhat.com Thu May 17 12:25:55 2012 From: mjw at redhat.com (Mark Wielaard) Date: Thu, 17 May 2012 21:25:55 +0200 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FB10B9E.8060500@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> Message-ID: <20120517192555.GB2423@toonder.wildebeest.org> On Mon, May 14, 2012 at 07:41:50AM -0600, Daniel D. Daugherty wrote: > On 5/14/12 2:06 AM, Mark Wielaard wrote: > >On Thu, 2012-05-10 at 09:52 -0600, Daniel D. Daugherty wrote: > >>Adding serviceability-dev at openjdk.java.net to this e-mail thread. > >Thanks. Please let me know if there is anything I can do to help > >integration of these patches, or if there are other places/people I need > >to add to the CC for review. > > No problem. I was just making sure your e-mails got to the right aliases. > As I no longer work on the Serviceability team, I'll leave it to them to > address your e-mails. Feedback from the Serviceability team is highly appreciated. Please let me know how I can help getting these patches in as soon as possible. Thanks, Mark > >>On 5/10/12 7:49 AM, Mark Wielaard wrote: > >>>Hi, > >>> > >>>The following three patches enable support for dtrace compatible sdt probes > >>>on GNU/Linux. Most of the support was already submitted earlier. These are > >>>just the last three things left in IcedTea that actually enable it in > >>>hotspot. It has been in production use for some time already. > >>> > >>>The patches could be applied all as one, or individually if you want to be > >>>able to test them independently. > >>> > >>>The first patch is just a consistency cleanup patch. The JNI Set and > >>>SetStatic Field methods used HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N > >>>directly instead of just using DTRACE_PROBE[N] like all other JNI methods. > >>>This doesn't matter for the Solaris macros, but on GNU/Linux the macros > >>>don't use direct function declarations (which is introduced in the second > >>>patch). > >>> > >>>The second patch introduces the DTRACE macros for use with the GNU/Linux > >>>SystemTap provided sys/sdt.h. Like Solaris this uses USDT1, but using > >>>macros instead of function declaractions. So it just adds a check for > >>>whether USDT1 is used with SOLARIS (HS_DTRACE_WORKAROUND_TAIL_CALL_BUG > >>>is only needed there) and defines HS_DTRACE_PROBE[N] for the LINUX case. > >>> > >>>The last patch enables the support in the build. I took the approach > >>>used in the make/solaris/dtrace.make and vm.make file with a test to > >>>see whether sys/sdt.h is available or not and printing a notice when > >>>they are not found. In IcedTea there is a more elaborate configure > >>>check to see if a small C++ program can be build with DTRACE probes > >>>in it, but that looked like overkill here. > >>> > >>>Patches in separate emails. > >>> > >>>Cheers, > >>> > >>>Mark > >>> > >>>The second patch adds the actual > >>> src/share/vm/prims/jni.cpp | 11 ++------ > >>> src/share/vm/utilities/dtrace.hpp | 50 ++++++++++++++++++++++++++++++++++++++- > >>> make/linux/makefiles/dtrace.make | 24 ++++++++++++++++++ > >>> make/linux/makefiles/vm.make | 2 +- > >>> 4 files changed, 77 insertions(+), 10 deletions(-) > > From rob.mckenna at oracle.com Thu May 17 14:40:58 2012 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Thu, 17 May 2012 21:40:58 +0000 Subject: hg: jdk8/tl/jdk: 7168110: Misleading jstack error message Message-ID: <20120517214108.601F94739F@hg.openjdk.java.net> Changeset: 178c480998b1 Author: robm Date: 2012-05-17 22:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/178c480998b1 7168110: Misleading jstack error message Reviewed-by: alanb, dsamersoff ! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c From serguei.spitsyn at oracle.com Thu May 17 16:47:37 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 17 May 2012 16:47:37 -0700 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <20120517192555.GB2423@toonder.wildebeest.org> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> Message-ID: <4FB58E19.8070002@oracle.com> Hi Mark, Where are the patches? I do not see them in your emails. Thanks, Serguei On 5/17/12 12:25 PM, Mark Wielaard wrote: > On Mon, May 14, 2012 at 07:41:50AM -0600, Daniel D. Daugherty wrote: >> On 5/14/12 2:06 AM, Mark Wielaard wrote: >>> On Thu, 2012-05-10 at 09:52 -0600, Daniel D. Daugherty wrote: >>>> Adding serviceability-dev at openjdk.java.net to this e-mail thread. >>> Thanks. Please let me know if there is anything I can do to help >>> integration of these patches, or if there are other places/people I need >>> to add to the CC for review. >> No problem. I was just making sure your e-mails got to the right aliases. >> As I no longer work on the Serviceability team, I'll leave it to them to >> address your e-mails. > Feedback from the Serviceability team is highly appreciated. Please let > me know how I can help getting these patches in as soon as possible. > > Thanks, > > Mark > >>>> On 5/10/12 7:49 AM, Mark Wielaard wrote: >>>>> Hi, >>>>> >>>>> The following three patches enable support for dtrace compatible sdt probes >>>>> on GNU/Linux. Most of the support was already submitted earlier. These are >>>>> just the last three things left in IcedTea that actually enable it in >>>>> hotspot. It has been in production use for some time already. >>>>> >>>>> The patches could be applied all as one, or individually if you want to be >>>>> able to test them independently. >>>>> >>>>> The first patch is just a consistency cleanup patch. The JNI Set and >>>>> SetStatic Field methods used HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N >>>>> directly instead of just using DTRACE_PROBE[N] like all other JNI methods. >>>>> This doesn't matter for the Solaris macros, but on GNU/Linux the macros >>>>> don't use direct function declarations (which is introduced in the second >>>>> patch). >>>>> >>>>> The second patch introduces the DTRACE macros for use with the GNU/Linux >>>>> SystemTap provided sys/sdt.h. Like Solaris this uses USDT1, but using >>>>> macros instead of function declaractions. So it just adds a check for >>>>> whether USDT1 is used with SOLARIS (HS_DTRACE_WORKAROUND_TAIL_CALL_BUG >>>>> is only needed there) and defines HS_DTRACE_PROBE[N] for the LINUX case. >>>>> >>>>> The last patch enables the support in the build. I took the approach >>>>> used in the make/solaris/dtrace.make and vm.make file with a test to >>>>> see whether sys/sdt.h is available or not and printing a notice when >>>>> they are not found. In IcedTea there is a more elaborate configure >>>>> check to see if a small C++ program can be build with DTRACE probes >>>>> in it, but that looked like overkill here. >>>>> >>>>> Patches in separate emails. >>>>> >>>>> Cheers, >>>>> >>>>> Mark >>>>> >>>>> The second patch adds the actual >>>>> src/share/vm/prims/jni.cpp | 11 ++------ >>>>> src/share/vm/utilities/dtrace.hpp | 50 ++++++++++++++++++++++++++++++++++++++- >>>>> make/linux/makefiles/dtrace.make | 24 ++++++++++++++++++ >>>>> make/linux/makefiles/vm.make | 2 +- >>>>> 4 files changed, 77 insertions(+), 10 deletions(-) -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120517/70792138/attachment.html From john.coomes at oracle.com Thu May 17 21:00:56 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 18 May 2012 04:00:56 +0000 Subject: hg: hsx/hotspot-rt: 4 new changesets Message-ID: <20120518040056.B303F473C7@hg.openjdk.java.net> Changeset: 955a3e8ed4f0 Author: ohair Date: 2012-05-10 08:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/955a3e8ed4f0 7167593: Changed get_source.sh to allow for getting full oracle jdk repo forest Reviewed-by: erikj, asaha, chegar, sla, dholmes, mbykov, coleenp ! get_source.sh ! make/scripts/hgforest.sh Changeset: 8a4e92c10a9a Author: ohair Date: 2012-05-11 17:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/8a4e92c10a9a 7167976: Fix broken get_source.sh script Reviewed-by: tbell ! make/scripts/hgforest.sh Changeset: 8927dd68aee3 Author: katleman Date: 2012-05-16 22:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/8927dd68aee3 Merge Changeset: a2b2d435f1d2 Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/a2b2d435f1d2 Added tag jdk8-b39 for changeset 8927dd68aee3 ! .hgtags From john.coomes at oracle.com Thu May 17 21:01:01 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 18 May 2012 04:01:01 +0000 Subject: hg: hsx/hotspot-rt/corba: Added tag jdk8-b39 for changeset 785af00e2827 Message-ID: <20120518040104.0754B473C8@hg.openjdk.java.net> Changeset: 56d030e5035f Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/56d030e5035f Added tag jdk8-b39 for changeset 785af00e2827 ! .hgtags From john.coomes at oracle.com Thu May 17 21:01:09 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 18 May 2012 04:01:09 +0000 Subject: hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b39 for changeset f95fdbe525c8 Message-ID: <20120518040116.41D2E473C9@hg.openjdk.java.net> Changeset: 9ecfdbd6aed4 Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/9ecfdbd6aed4 Added tag jdk8-b39 for changeset f95fdbe525c8 ! .hgtags From john.coomes at oracle.com Thu May 17 21:01:22 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 18 May 2012 04:01:22 +0000 Subject: hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b39 for changeset 7f6b44fd3034 Message-ID: <20120518040126.CD016473CA@hg.openjdk.java.net> Changeset: 09a0ddda03cb Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/09a0ddda03cb Added tag jdk8-b39 for changeset 7f6b44fd3034 ! .hgtags From john.coomes at oracle.com Thu May 17 21:01:36 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 18 May 2012 04:01:36 +0000 Subject: hg: hsx/hotspot-rt/jdk: 4 new changesets Message-ID: <20120518040246.B6FEB473CB@hg.openjdk.java.net> Changeset: c2d9166f3284 Author: ihse Date: 2012-05-11 08:21 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c2d9166f3284 7168208: Change use of @ in one sed command involving paths to different character Reviewed-by: ohair ! make/common/Release.gmk Changeset: 8d665b69ebf1 Author: mfang Date: 2012-05-15 11:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8d665b69ebf1 7157855: jvisualvm.1 not included in binaries Reviewed-by: katleman, thurka ! make/common/Release.gmk Changeset: b6f529117521 Author: katleman Date: 2012-05-16 22:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b6f529117521 Merge Changeset: 47cd90bf0f66 Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/47cd90bf0f66 Added tag jdk8-b39 for changeset b6f529117521 ! .hgtags From john.coomes at oracle.com Thu May 17 21:04:07 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 18 May 2012 04:04:07 +0000 Subject: hg: hsx/hotspot-rt/langtools: Added tag jdk8-b39 for changeset a9f547c218d9 Message-ID: <20120518040413.CF588473CC@hg.openjdk.java.net> Changeset: 8b869afd2eb4 Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/8b869afd2eb4 Added tag jdk8-b39 for changeset a9f547c218d9 ! .hgtags From david.holmes at oracle.com Thu May 17 21:48:01 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 18 May 2012 14:48:01 +1000 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FB58E19.8070002@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> Message-ID: <4FB5D481.2060307@oracle.com> Serguei, The patches themselves are the emails with the subjects: [PATCH 1 of 3] ... [PATCH 2 of 3] ... [PATCH 3 of 3] ... David On 18/05/2012 9:47 AM, serguei.spitsyn at oracle.com wrote: > Hi Mark, > > Where are the patches? > I do not see them in your emails. > > Thanks, > Serguei > > On 5/17/12 12:25 PM, Mark Wielaard wrote: >> On Mon, May 14, 2012 at 07:41:50AM -0600, Daniel D. Daugherty wrote: >>> On 5/14/12 2:06 AM, Mark Wielaard wrote: >>>> On Thu, 2012-05-10 at 09:52 -0600, Daniel D. Daugherty wrote: >>>>> Addingserviceability-dev at openjdk.java.net to this e-mail thread. >>>> Thanks. Please let me know if there is anything I can do to help >>>> integration of these patches, or if there are other places/people I need >>>> to add to the CC for review. >>> No problem. I was just making sure your e-mails got to the right aliases. >>> As I no longer work on the Serviceability team, I'll leave it to them to >>> address your e-mails. >> Feedback from the Serviceability team is highly appreciated. Please let >> me know how I can help getting these patches in as soon as possible. >> >> Thanks, >> >> Mark >> >>>>> On 5/10/12 7:49 AM, Mark Wielaard wrote: >>>>>> Hi, >>>>>> >>>>>> The following three patches enable support for dtrace compatible sdt probes >>>>>> on GNU/Linux. Most of the support was already submitted earlier. These are >>>>>> just the last three things left in IcedTea that actually enable it in >>>>>> hotspot. It has been in production use for some time already. >>>>>> >>>>>> The patches could be applied all as one, or individually if you want to be >>>>>> able to test them independently. >>>>>> >>>>>> The first patch is just a consistency cleanup patch. The JNI Set and >>>>>> SetStatic Field methods used HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N >>>>>> directly instead of just using DTRACE_PROBE[N] like all other JNI methods. >>>>>> This doesn't matter for the Solaris macros, but on GNU/Linux the macros >>>>>> don't use direct function declarations (which is introduced in the second >>>>>> patch). >>>>>> >>>>>> The second patch introduces the DTRACE macros for use with the GNU/Linux >>>>>> SystemTap provided sys/sdt.h. Like Solaris this uses USDT1, but using >>>>>> macros instead of function declaractions. So it just adds a check for >>>>>> whether USDT1 is used with SOLARIS (HS_DTRACE_WORKAROUND_TAIL_CALL_BUG >>>>>> is only needed there) and defines HS_DTRACE_PROBE[N] for the LINUX case. >>>>>> >>>>>> The last patch enables the support in the build. I took the approach >>>>>> used in the make/solaris/dtrace.make and vm.make file with a test to >>>>>> see whether sys/sdt.h is available or not and printing a notice when >>>>>> they are not found. In IcedTea there is a more elaborate configure >>>>>> check to see if a small C++ program can be build with DTRACE probes >>>>>> in it, but that looked like overkill here. >>>>>> >>>>>> Patches in separate emails. >>>>>> >>>>>> Cheers, >>>>>> >>>>>> Mark >>>>>> >>>>>> The second patch adds the actual >>>>>> src/share/vm/prims/jni.cpp | 11 ++------ >>>>>> src/share/vm/utilities/dtrace.hpp | 50 ++++++++++++++++++++++++++++++++++++++- >>>>>> make/linux/makefiles/dtrace.make | 24 ++++++++++++++++++ >>>>>> make/linux/makefiles/vm.make | 2 +- >>>>>> 4 files changed, 77 insertions(+), 10 deletions(-) > From xuelei.fan at oracle.com Thu May 17 22:00:42 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Fri, 18 May 2012 05:00:42 +0000 Subject: hg: jdk8/tl/jdk: 7145960: sun/security/mscapi/ShortRSAKey1024.sh failing on windows Message-ID: <20120518050052.B838E473D0@hg.openjdk.java.net> Changeset: 9fe6ebbe5895 Author: xuelei Date: 2012-05-17 21:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fe6ebbe5895 7145960: sun/security/mscapi/ShortRSAKey1024.sh failing on windows Reviewed-by: vinnie, wetmore ! test/sun/security/mscapi/ShortRSAKey1024.sh ! test/sun/security/mscapi/ShortRSAKey512.sh ! test/sun/security/mscapi/ShortRSAKey768.sh From serguei.spitsyn at oracle.com Thu May 17 23:30:53 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 17 May 2012 23:30:53 -0700 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FB5D481.2060307@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> Message-ID: <4FB5EC9D.10302@oracle.com> David, I've found these emails, they somehow got to the trash folder - very strange. Thanks! Serguei On 5/17/12 9:48 PM, David Holmes wrote: > Serguei, > > The patches themselves are the emails with the subjects: > > [PATCH 1 of 3] ... > [PATCH 2 of 3] ... > [PATCH 3 of 3] ... > > David > > On 18/05/2012 9:47 AM, serguei.spitsyn at oracle.com wrote: >> Hi Mark, >> >> Where are the patches? >> I do not see them in your emails. >> >> Thanks, >> Serguei >> >> On 5/17/12 12:25 PM, Mark Wielaard wrote: >>> On Mon, May 14, 2012 at 07:41:50AM -0600, Daniel D. Daugherty wrote: >>>> On 5/14/12 2:06 AM, Mark Wielaard wrote: >>>>> On Thu, 2012-05-10 at 09:52 -0600, Daniel D. Daugherty wrote: >>>>>> Addingserviceability-dev at openjdk.java.net to this e-mail thread. >>>>> Thanks. Please let me know if there is anything I can do to help >>>>> integration of these patches, or if there are other places/people >>>>> I need >>>>> to add to the CC for review. >>>> No problem. I was just making sure your e-mails got to the right >>>> aliases. >>>> As I no longer work on the Serviceability team, I'll leave it to >>>> them to >>>> address your e-mails. >>> Feedback from the Serviceability team is highly appreciated. Please let >>> me know how I can help getting these patches in as soon as possible. >>> >>> Thanks, >>> >>> Mark >>> >>>>>> On 5/10/12 7:49 AM, Mark Wielaard wrote: >>>>>>> Hi, >>>>>>> >>>>>>> The following three patches enable support for dtrace compatible >>>>>>> sdt probes >>>>>>> on GNU/Linux. Most of the support was already submitted earlier. >>>>>>> These are >>>>>>> just the last three things left in IcedTea that actually enable >>>>>>> it in >>>>>>> hotspot. It has been in production use for some time already. >>>>>>> >>>>>>> The patches could be applied all as one, or individually if you >>>>>>> want to be >>>>>>> able to test them independently. >>>>>>> >>>>>>> The first patch is just a consistency cleanup patch. The JNI Set >>>>>>> and >>>>>>> SetStatic Field methods used HS_DTRACE_PROBE_CDECL_N and >>>>>>> HS_DTRACE_PROBE_N >>>>>>> directly instead of just using DTRACE_PROBE[N] like all other >>>>>>> JNI methods. >>>>>>> This doesn't matter for the Solaris macros, but on GNU/Linux the >>>>>>> macros >>>>>>> don't use direct function declarations (which is introduced in >>>>>>> the second >>>>>>> patch). >>>>>>> >>>>>>> The second patch introduces the DTRACE macros for use with the >>>>>>> GNU/Linux >>>>>>> SystemTap provided sys/sdt.h. Like Solaris this uses USDT1, but >>>>>>> using >>>>>>> macros instead of function declaractions. So it just adds a >>>>>>> check for >>>>>>> whether USDT1 is used with SOLARIS >>>>>>> (HS_DTRACE_WORKAROUND_TAIL_CALL_BUG >>>>>>> is only needed there) and defines HS_DTRACE_PROBE[N] for the >>>>>>> LINUX case. >>>>>>> >>>>>>> The last patch enables the support in the build. I took the >>>>>>> approach >>>>>>> used in the make/solaris/dtrace.make and vm.make file with a >>>>>>> test to >>>>>>> see whether sys/sdt.h is available or not and printing a notice >>>>>>> when >>>>>>> they are not found. In IcedTea there is a more elaborate configure >>>>>>> check to see if a small C++ program can be build with DTRACE probes >>>>>>> in it, but that looked like overkill here. >>>>>>> >>>>>>> Patches in separate emails. >>>>>>> >>>>>>> Cheers, >>>>>>> >>>>>>> Mark >>>>>>> >>>>>>> The second patch adds the actual >>>>>>> src/share/vm/prims/jni.cpp | 11 ++------ >>>>>>> src/share/vm/utilities/dtrace.hpp | 50 >>>>>>> ++++++++++++++++++++++++++++++++++++++- >>>>>>> make/linux/makefiles/dtrace.make | 24 ++++++++++++++++++ >>>>>>> make/linux/makefiles/vm.make | 2 +- >>>>>>> 4 files changed, 77 insertions(+), 10 deletions(-) >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120517/ce46a902/attachment.html From daniel.daugherty at oracle.com Fri May 18 11:54:35 2012 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Fri, 18 May 2012 18:54:35 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7170010: conditional "ZIP_DEBUGINFO_FILES ?= 0" setting is not reliable on Windows Message-ID: <20120518185439.69628473E8@hg.openjdk.java.net> Changeset: 4b37c0dafe3a Author: dcubed Date: 2012-05-18 09:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4b37c0dafe3a 7170010: conditional "ZIP_DEBUGINFO_FILES ?= 0" setting is not reliable on Windows Summary: Always disable ZIP_DEBUGINFO_FILES on Windows. Reviewed-by: acorn ! make/windows/makefiles/defs.make From valerie.peng at oracle.com Fri May 18 12:49:05 2012 From: valerie.peng at oracle.com (valerie.peng at oracle.com) Date: Fri, 18 May 2012 19:49:05 +0000 Subject: hg: jdk8/tl/jdk: 7169496: Problem with the SHA-224 support for SunMSCAPI provider Message-ID: <20120518194916.6B505473ED@hg.openjdk.java.net> Changeset: af1030be726a Author: valeriep Date: 2012-05-18 12:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/af1030be726a 7169496: Problem with the SHA-224 support for SunMSCAPI provider Summary: Remove SHA224withRSA signature from SunMSCAPI provider due to lack of windows support. Reviewed-by: vinnie ! src/windows/classes/sun/security/mscapi/RSASignature.java ! src/windows/classes/sun/security/mscapi/SunMSCAPI.java ! test/sun/security/mscapi/SignUsingNONEwithRSA.java ! test/sun/security/mscapi/SignUsingSHA2withRSA.java From weijun.wang at oracle.com Mon May 21 00:41:17 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 21 May 2012 07:41:17 +0000 Subject: hg: jdk8/tl/jdk: 7170308: timing error in the krb5 test SSL.java Message-ID: <20120521074127.D574B47424@hg.openjdk.java.net> Changeset: 72af24348b2b Author: weijun Date: 2012-05-21 15:40 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72af24348b2b 7170308: timing error in the krb5 test SSL.java Reviewed-by: xuelei ! test/sun/security/krb5/auto/SSL.java From staffan.larsen at oracle.com Mon May 21 01:05:41 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 21 May 2012 10:05:41 +0200 Subject: RFR (S): 7167157: jcmd command file parsing does not respect the "stop" command In-Reply-To: <708DB3B1-A7A4-4B3D-B7D0-D641D13AC80A@oracle.com> References: <818D2614-C90C-47AF-A8D6-4F8489A353C6@oracle.com> <708DB3B1-A7A4-4B3D-B7D0-D641D13AC80A@oracle.com> Message-ID: <70A91D48-D3F6-42B6-972C-7AEC8C4D6316@oracle.com> All, I need a Review of this change. Thanks, /Staffan On 11 maj 2012, at 12:42, Staffan Larsen wrote: > New webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.01/ > > On 11 maj 2012, at 12:17, Staffan Larsen wrote: > >> Right. Should probably be line.trim().equals("stop") >> >> /Staffan >> >> On 11 maj 2012, at 11:41, Nils Loodin wrote: >> >>> Should it be "startsWith"? I don't know if we ever plan to implement a command that's called stopFeatureX, but still.. >>> >>> Regards, >>> Nils Loodin >>> >>> On May 11, 2012, at 11:34 , Staffan Larsen wrote: >>> >>>> Please review the following fix for the fix for 7154822. Previously all lines in the command file were sent to the JVM as one string, but the size limit was 1024 bytes so this was changed in 7154822 to sending one line at a time. Problem with this is that the jcmd utility keeps sending commands even if it has encountered a 'stop'. So instead of relying on the JVM to parse the 'stop' command, we must now parse this in the jcmd utility. >>>> >>>> webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.00/ >>>> >>>> Thanks, >>>> /Staffan >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120521/59135719/attachment.html From nils.loodin at oracle.com Mon May 21 01:13:34 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Mon, 21 May 2012 10:13:34 +0200 Subject: RFR (S): 7167157: jcmd command file parsing does not respect the "stop" command In-Reply-To: <70A91D48-D3F6-42B6-972C-7AEC8C4D6316@oracle.com> References: <818D2614-C90C-47AF-A8D6-4F8489A353C6@oracle.com> <708DB3B1-A7A4-4B3D-B7D0-D641D13AC80A@oracle.com> <70A91D48-D3F6-42B6-972C-7AEC8C4D6316@oracle.com> Message-ID: <49686013-844B-4162-9E8E-5057F66B9185@oracle.com> I think it looks good now. Regards Nils On May 21, 2012, at 10:05 , Staffan Larsen wrote: > All, > > I need a Review of this change. > > Thanks, > /Staffan > > On 11 maj 2012, at 12:42, Staffan Larsen wrote: > >> New webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.01/ >> >> On 11 maj 2012, at 12:17, Staffan Larsen wrote: >> >>> Right. Should probably be line.trim().equals("stop") >>> >>> /Staffan >>> >>> On 11 maj 2012, at 11:41, Nils Loodin wrote: >>> >>>> Should it be "startsWith"? I don't know if we ever plan to implement a command that's called stopFeatureX, but still.. >>>> >>>> Regards, >>>> Nils Loodin >>>> >>>> On May 11, 2012, at 11:34 , Staffan Larsen wrote: >>>> >>>>> Please review the following fix for the fix for 7154822. Previously all lines in the command file were sent to the JVM as one string, but the size limit was 1024 bytes so this was changed in 7154822 to sending one line at a time. Problem with this is that the jcmd utility keeps sending commands even if it has encountered a 'stop'. So instead of relying on the JVM to parse the 'stop' command, we must now parse this in the jcmd utility. >>>>> >>>>> webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.00/ >>>>> >>>>> Thanks, >>>>> /Staffan >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120521/4f921f9e/attachment.html From Dmitry.Samersoff at oracle.com Mon May 21 01:23:31 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Mon, 21 May 2012 12:23:31 +0400 Subject: RFR (S): 7167157: jcmd command file parsing does not respect the "stop" command In-Reply-To: <70A91D48-D3F6-42B6-972C-7AEC8C4D6316@oracle.com> References: <818D2614-C90C-47AF-A8D6-4F8489A353C6@oracle.com> <708DB3B1-A7A4-4B3D-B7D0-D641D13AC80A@oracle.com> <70A91D48-D3F6-42B6-972C-7AEC8C4D6316@oracle.com> Message-ID: <4FB9FB83.6090404@oracle.com> Staffan, Looks OK for me. Is stop command case-sensitive? -Dmitry On 2012-05-21 12:05, Staffan Larsen wrote: > All, > > I need a Review of this change. > > Thanks, > /Staffan > > On 11 maj 2012, at 12:42, Staffan Larsen wrote: > >> New webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.01/ >> >> On 11 maj 2012, at 12:17, Staffan Larsen wrote: >> >>> Right. Should probably be line.trim().equals("stop") >>> >>> /Staffan >>> >>> On 11 maj 2012, at 11:41, Nils Loodin wrote: >>> >>>> Should it be "startsWith"? I don't know if we ever plan to implement >>>> a command that's called stopFeatureX, but still.. >>>> >>>> Regards, >>>> Nils Loodin >>>> >>>> On May 11, 2012, at 11:34 , Staffan Larsen wrote: >>>> >>>>> Please review the following fix for the fix for 7154822. Previously >>>>> all lines in the command file were sent to the JVM as one string, >>>>> but the size limit was 1024 bytes so this was changed in 7154822 to >>>>> sending one line at a time. Problem with this is that the jcmd >>>>> utility keeps sending commands even if it has encountered a 'stop'. >>>>> So instead of relying on the JVM to parse the 'stop' command, we >>>>> must now parse this in the jcmd utility. >>>>> >>>>> webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.00/ >>>>> >>>>> Thanks, >>>>> /Staffan >>>> >>> >> > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From Alan.Bateman at oracle.com Mon May 21 01:29:07 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 21 May 2012 09:29:07 +0100 Subject: RFR (S): 7167157: jcmd command file parsing does not respect the "stop" command In-Reply-To: <70A91D48-D3F6-42B6-972C-7AEC8C4D6316@oracle.com> References: <818D2614-C90C-47AF-A8D6-4F8489A353C6@oracle.com> <708DB3B1-A7A4-4B3D-B7D0-D641D13AC80A@oracle.com> <70A91D48-D3F6-42B6-972C-7AEC8C4D6316@oracle.com> Message-ID: <4FB9FCD3.2070900@oracle.com> Staffan, I probably don't have the full context here but what is the reason for the "stop" command. I guess I'm just wondering why someone would specify -f with a stop command embedded. Also I wonder if this file should support comment (# or whatever) so that they are ignored by jcmd. Otherwise I agree with Nils command that the line needs to be trimmed to ensure that it only contains "stop". -Alan On 21/05/2012 09:05, Staffan Larsen wrote: > All, > > I need a Review of this change. > > Thanks, > /Staffan > > On 11 maj 2012, at 12:42, Staffan Larsen wrote: > >> New webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.01/ >> >> >> On 11 maj 2012, at 12:17, Staffan Larsen wrote: >> >>> Right. Should probably be line.trim().equals("stop") >>> >>> /Staffan >>> >>> On 11 maj 2012, at 11:41, Nils Loodin wrote: >>> >>>> Should it be "startsWith"? I don't know if we ever plan to >>>> implement a command that's called stopFeatureX, but still.. >>>> >>>> Regards, >>>> Nils Loodin >>>> >>>> On May 11, 2012, at 11:34 , Staffan Larsen wrote: >>>> >>>>> Please review the following fix for the fix for 7154822. >>>>> Previously all lines in the command file were sent to the JVM as >>>>> one string, but the size limit was 1024 bytes so this was changed >>>>> in 7154822 to sending one line at a time. Problem with this is >>>>> that the jcmd utility keeps sending commands even if it has >>>>> encountered a 'stop'. So instead of relying on the JVM to parse >>>>> the 'stop' command, we must now parse this in the jcmd utility. >>>>> >>>>> webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.00/ >>>>> >>>>> >>>>> Thanks, >>>>> /Staffan >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120521/bbfe4a46/attachment-0001.html From staffan.larsen at oracle.com Mon May 21 01:38:07 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 21 May 2012 10:38:07 +0200 Subject: RFR (S): 7167157: jcmd command file parsing does not respect the "stop" command In-Reply-To: <4FB9FB83.6090404@oracle.com> References: <818D2614-C90C-47AF-A8D6-4F8489A353C6@oracle.com> <708DB3B1-A7A4-4B3D-B7D0-D641D13AC80A@oracle.com> <70A91D48-D3F6-42B6-972C-7AEC8C4D6316@oracle.com> <4FB9FB83.6090404@oracle.com> Message-ID: Thanks Dmitry, All commands are case-sensitive. /Staffan On 21 maj 2012, at 10:23, Dmitry Samersoff wrote: > Staffan, > > Looks OK for me. > > Is stop command case-sensitive? > > -Dmitry > > > On 2012-05-21 12:05, Staffan Larsen wrote: >> All, >> >> I need a Review of this change. >> >> Thanks, >> /Staffan >> >> On 11 maj 2012, at 12:42, Staffan Larsen wrote: >> >>> New webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.01/ >>> >>> On 11 maj 2012, at 12:17, Staffan Larsen wrote: >>> >>>> Right. Should probably be line.trim().equals("stop") >>>> >>>> /Staffan >>>> >>>> On 11 maj 2012, at 11:41, Nils Loodin wrote: >>>> >>>>> Should it be "startsWith"? I don't know if we ever plan to implement >>>>> a command that's called stopFeatureX, but still.. >>>>> >>>>> Regards, >>>>> Nils Loodin >>>>> >>>>> On May 11, 2012, at 11:34 , Staffan Larsen wrote: >>>>> >>>>>> Please review the following fix for the fix for 7154822. Previously >>>>>> all lines in the command file were sent to the JVM as one string, >>>>>> but the size limit was 1024 bytes so this was changed in 7154822 to >>>>>> sending one line at a time. Problem with this is that the jcmd >>>>>> utility keeps sending commands even if it has encountered a 'stop'. >>>>>> So instead of relying on the JVM to parse the 'stop' command, we >>>>>> must now parse this in the jcmd utility. >>>>>> >>>>>> webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.00/ >>>>>> >>>>>> Thanks, >>>>>> /Staffan >>>>> >>>> >>> >> > > > -- > Dmitry Samersoff > Java Hotspot development team, SPB04 > * There will come soft rains ... From staffan.larsen at oracle.com Mon May 21 01:41:22 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 21 May 2012 10:41:22 +0200 Subject: RFR (S): 7167157: jcmd command file parsing does not respect the "stop" command In-Reply-To: <4FB9FCD3.2070900@oracle.com> References: <818D2614-C90C-47AF-A8D6-4F8489A353C6@oracle.com> <708DB3B1-A7A4-4B3D-B7D0-D641D13AC80A@oracle.com> <70A91D48-D3F6-42B6-972C-7AEC8C4D6316@oracle.com> <4FB9FCD3.2070900@oracle.com> Message-ID: <9EB1E571-8BD2-4C10-99AB-676A4AD060CE@oracle.com> I don't really know the historical reason or the use case for the "stop" command. This was part of the JRockit implementation and I think we inherited that into HotSpot without really questioning it. The file does support comments using '#' as the first character on the line. This parsing is done inside HotSpot. /Staffan On 21 maj 2012, at 10:29, Alan Bateman wrote: > Staffan, > > I probably don't have the full context here but what is the reason for the "stop" command. I guess I'm just wondering why someone would specify -f with a stop command embedded. Also I wonder if this file should support comment (# or whatever) so that they are ignored by jcmd. Otherwise I agree with Nils command that the line needs to be trimmed to ensure that it only contains "stop". > > -Alan > > On 21/05/2012 09:05, Staffan Larsen wrote: >> >> All, >> >> I need a Review of this change. >> >> Thanks, >> /Staffan >> >> On 11 maj 2012, at 12:42, Staffan Larsen wrote: >> >>> New webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.01/ >>> >>> On 11 maj 2012, at 12:17, Staffan Larsen wrote: >>> >>>> Right. Should probably be line.trim().equals("stop") >>>> >>>> /Staffan >>>> >>>> On 11 maj 2012, at 11:41, Nils Loodin wrote: >>>> >>>>> Should it be "startsWith"? I don't know if we ever plan to implement a command that's called stopFeatureX, but still.. >>>>> >>>>> Regards, >>>>> Nils Loodin >>>>> >>>>> On May 11, 2012, at 11:34 , Staffan Larsen wrote: >>>>> >>>>>> Please review the following fix for the fix for 7154822. Previously all lines in the command file were sent to the JVM as one string, but the size limit was 1024 bytes so this was changed in 7154822 to sending one line at a time. Problem with this is that the jcmd utility keeps sending commands even if it has encountered a 'stop'. So instead of relying on the JVM to parse the 'stop' command, we must now parse this in the jcmd utility. >>>>>> >>>>>> webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.00/ >>>>>> >>>>>> Thanks, >>>>>> /Staffan >>>>> >>>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120521/737146c0/attachment.html From mjw at redhat.com Mon May 21 02:28:42 2012 From: mjw at redhat.com (Mark Wielaard) Date: Mon, 21 May 2012 11:28:42 +0200 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FB5EC9D.10302@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> Message-ID: <1337592522.3408.16.camel@springer.wildebeest.org> On Thu, 2012-05-17 at 23:30 -0700, serguei.spitsyn at oracle.com wrote: > On 18/05/2012 9:47 AM, serguei.spitsyn at oracle.com wrote: > On 5/17/12 9:48 PM, David Holmes wrote: > > > Where are the patches? > > > I do not see them in your emails. > > > > > The patches themselves are the emails with the subjects: > > > > [PATCH 1 of 3] ... > > [PATCH 2 of 3] ... > > [PATCH 3 of 3] ... > > > I've found these emails, they somehow got to the trash folder - very > strange. Apologies. That is how hg email sends them. I have a local mercurial repository that contain the patches. Maybe your spam filter caught it because all subjects start with XXXXXX as placeholder because I don't have official bug numbers for them. If you could create the bugs and/or let me know if you rather see these patches split up differently (or not split up at all), please let me know and I rebase my patches and resend them. > > > On 5/17/12 12:25 PM, Mark Wielaard wrote: > > > > On Mon, May 14, 2012 at 07:41:50AM -0600, Daniel D. Daugherty > > > > wrote: > > > > > On 5/14/12 2:06 AM, Mark Wielaard wrote: > > > > > > On Thu, 2012-05-10 at 09:52 -0600, Daniel D. Daugherty > > > > > > wrote: > > > > > > > Addingserviceability-dev at openjdk.java.net to this e-mail > > > > > > > thread. > > > > > > Thanks. Please let me know if there is anything I can do to > > > > > > help > > > > > > integration of these patches, or if there are other > > > > > > places/people I need > > > > > > to add to the CC for review. > > > > > No problem. I was just making sure your e-mails got to the > > > > > right aliases. > > > > > As I no longer work on the Serviceability team, I'll leave it > > > > > to them to > > > > > address your e-mails. > > > > Feedback from the Serviceability team is highly appreciated. > > > > Please let > > > > me know how I can help getting these patches in as soon as > > > > possible. > > > > > > > On 5/10/12 7:49 AM, Mark Wielaard wrote: > > > > > > > > The following three patches enable support for dtrace > > > > > > > > compatible sdt probes > > > > > > > > on GNU/Linux. Most of the support was already submitted > > > > > > > > earlier. These are > > > > > > > > just the last three things left in IcedTea that actually > > > > > > > > enable it in > > > > > > > > hotspot. It has been in production use for some time > > > > > > > > already. > > > > > > > > > > > > > > > > The patches could be applied all as one, or individually > > > > > > > > if you want to be > > > > > > > > able to test them independently. > > > > > > [... explanation of separate patches removed ...] > > > > > > > > Patches in separate emails. From alan.bateman at oracle.com Mon May 21 02:42:42 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 21 May 2012 09:42:42 +0000 Subject: hg: jdk8/tl/jdk: 7170203: TEST_BUG: test/java/nio/MappedByteBuffer/Truncate.java failing intermittently Message-ID: <20120521094309.40EA347426@hg.openjdk.java.net> Changeset: 9cb304dd71d4 Author: alanb Date: 2012-05-21 10:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9cb304dd71d4 7170203: TEST_BUG: test/java/nio/MappedByteBuffer/Truncate.java failing intermittently Reviewed-by: chegar ! test/java/nio/MappedByteBuffer/Truncate.java From erik.gahlin at oracle.com Mon May 21 04:18:15 2012 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Mon, 21 May 2012 13:18:15 +0200 Subject: RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team In-Reply-To: <4FAD3B63.8070501@oracle.com> References: <4FAD23E4.90501@oracle.com> <4FAD3B63.8070501@oracle.com> Message-ID: <4FBA2477.7040101@oracle.com> Thanks Michael, When it comes to ALL CAPs or SturdlyCaps, it's okay if those strings are not translated. Here is an updated webrev. I removed strings that were no longer in use and made some changes to the make-files. http://cr.openjdk.java.net/~egahlin/7017818_4/ /E Michael Fang skrev 2012-05-11 18:16: > Thanks so much Erik for the fix! The messages.properties file look > good. I only reviewed the English *messages.properties* file. WPTG > will re-translate the ja and zh_CN files. They will attempt to > leverage existing translation from *JConsoleResources_xx.java*. > > I have a comments about another translatability rule that WPTG follows: > > By Oracle software development guideline, ALL CAPs or StudlyCaps > strings will not be translated. Examples are: > 19 ACTION_CAPITALIZED=ACTION > 20 ACTION_INFO_CAPITALIZED=ACTION_INFO > 149 MBEAN_INFO=MBeanInfo > 150 MBEAN_NOTIFICATION_INFO=MBeanNotificationInfo > 151 MBEAN_OPERATION_INFO=MBeanOperationInfo > 206 OBJECT_NAME=ObjectName > 231 R_FORWARD_SLASH_W_CAPITALIZED=R/W > > 241 SEQ_NUM=SeqNum > 249 SUMMARY_TAB_HEADER_DATE_TIME_FORMAT=FULL,FULL > > 273 UNKNOWN_CAPITALIZED=UNKNOWN > > If any of the above such as ACTION or UNKNOWN needs to be translated, > they should not be ALL CAPS. The translators will not translate those > lines by default. > > The translators have the ability to see comments (or special requests) > if a comment line is inserted immediately prior to any of the > resources (each resource string and one comment line immediately > before it is stored in translation memory). If you must leave ACTION > or UNKNOWN in CAPS, you can try to insert comments.However, WPTG does > not guarantee they will be followed. > > thanks, > > -michael > > On 12?05?11? 07:36 ??, Erik Gahlin wrote: >> Could you please review? I also need a sponsor. >> >> http://cr.openjdk.java.net/~egahlin/7156518/1_0/ >> >> http://monaco.us.oracle.com/detail.jsf?cr=7017818 >> >> The patch is for JDK8, but it needs to ported to 7u6 before 5/16. >> >> Thanks! >> >> Erik >> >> Changes: >> >> - Moved localization messages to property files, one message per >> line, as needed. >> - Added '&' to messages so mnemonics could be identified. >> - Introduced Message class with static fields corresponding to the >> keys in the property files. >> - Added map for looking up mnemonics. >> >> Testing: >> >> - Verified programmatically that all the messages and mnemonics are >> "compatible" with the previous mechanism, for Chinese, Japanese and >> the default locale. >> - The intention is to run through the GUI to confirm that everything >> looks ok, but I'm waiting for a build. >> >> Other: >> >> - Fixed a typo in the MemoryPoolStat class, the method >> getAfterGcUsage returned this.beforeGCUsage instead of this.afterGcUsage >> - When going through all the code I did some minor clean up that >> should not impact the program flow: >> * removed unused imports. >> * inlined temporary variables holding messages. >> * removed private member variables that were not accessed. >> * removed private methods that were not referenced. >> * removed local variables that were not used. >> * added generic types where needed. >> * static methods are now called statically. >> * added suppress serialization warning where it was needed. >> * removed suppress serialization annotation where it was not needed. >> - In the Message class, the comment "remove? not found in code" will >> be removed once I know those message are not needed for 7u6. >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120521/62f43dec/attachment-0001.html From kumar.x.srinivasan at oracle.com Mon May 21 09:41:15 2012 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Mon, 21 May 2012 16:41:15 +0000 Subject: hg: jdk8/tl/jdk: 7170087: tools/launcher/Arrghs.java test has wrong bugID for 7151434 Message-ID: <20120521164139.5E9C747444@hg.openjdk.java.net> Changeset: f109feb13698 Author: ksrini Date: 2012-05-21 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f109feb13698 7170087: tools/launcher/Arrghs.java test has wrong bugID for 7151434 Reviewed-by: ohair ! test/tools/launcher/Arrrghs.java From staffan.larsen at oracle.com Mon May 21 10:07:03 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Mon, 21 May 2012 19:07:03 +0200 Subject: RFR (L): Adding core file parsing on Mac OS X to SA In-Reply-To: <6D712B96-F212-4337-BD61-AFB22ECDB0CB@oracle.com> References: <06CFCD3A-A8F4-4FDE-B8CD-D201C892AA30@oracle.com> <4FA90D25.8010000@oracle.com> <6D712B96-F212-4337-BD61-AFB22ECDB0CB@oracle.com> Message-ID: <2451199D-2FA1-432D-A37B-F007293FD724@oracle.com> I'm looking for a Reviewer for the change detailed below. I've added the hotspot-dev alias to the request. For the discussion so far see: http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-May/005979.html Short version: Add core file parsing to SA on Mac OS X by incorporating the KJDB tool developed by Kevin Walls. Please let me know if you can review the code. It's quite a bit of code. Both myself and Kevin can answer questions on the code. Thanks, /Staffan On 8 maj 2012, at 19:20, Staffan Larsen wrote: > Here are some late breaking additions that Kevin sent me. These are only changes to the kjdb core. > > Full webrev: http://cr.openjdk.java.net/~sla/kjdb/webrev.02/ > Difference from the last webrev: http://cr.openjdk.java.net/~sla/kjdb/webrev.02-delta/ > > And I should add credit where credit is due. The kjdb implementation is all Kevin Walls' great work. Integration in SA and tests are my work. Any errors are of course my fault as well. > > Thanks, > /Staffan > > On 8 maj 2012, at 14:10, Kevin Walls wrote: > >> >> Hi - >> >> Just a note that I'd like to contribute a cleaner way for the Debugger and Process classes here to load a core file, which I hadn't yet handed over. I'll have that ready shortly... >> >> Thanks >> Kevin >> >> On 08/05/12 12:11, Staffan Larsen wrote: >>> The Serviceability Agent currently has an outage on Mac OS X compared to other platforms in that we cannot read core files. We plan to address this for 7u6 by incorporating code from a separate tool called "kjdb" developed at Oracle. Kjdb is a cross-platform core-file debugger written completely in Java that currently works on ELF (solaris, linux) and Mach-O (mac) core files. Since it is written in Java it can read core files from a different system than the system you are running kjdb on, which is very useful. >>> >>> The alternative to incorporating the kjdb technology would have been to implement this in C as is done for the other platforms, but reusing existing code saves us some trouble. The kjdb debugger backend will automatically be enabled when you are opening a Mach-O core file (or if you explicitly set the -Duse.kjdb property when starting SA). >>> >>> The risks with this is that this is a large addition of relatively new code to SA (around 100 files). It also means that debugging a live process or a core file on OS X will use different debugger backends which may have different behavior and bugs. >>> >>> This change also adds a basic test that creates a core file and uses SA to print the thread dumps in the core. This test runs on all platforms, not just Mac OS X. Other than that test, some level of manual testing has been done with various core files. >>> >>> Please see the webrev at: http://cr.openjdk.java.net/~sla/kjdb/webrev.01/ >>> >>> There are quite a number of added files in this webrev, so it's probably best to concentrate on the changes in the existing files. >>> >>> Thanks, >>> /Staffan >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120521/73dc7fcf/attachment.html From staffan.larsen at oracle.com Mon May 21 10:29:21 2012 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Mon, 21 May 2012 17:29:21 +0000 Subject: hg: jdk8/tl/jdk: 7167157: jcmd command file parsing does not respect the "stop" command Message-ID: <20120521172931.4584047447@hg.openjdk.java.net> Changeset: 0a1ef7e07e01 Author: sla Date: 2012-05-21 19:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a1ef7e07e01 7167157: jcmd command file parsing does not respect the "stop" command Reviewed-by: alanb, dsamersoff, nloodin ! src/share/classes/sun/tools/jcmd/JCmd.java From mandy.chung at oracle.com Mon May 21 14:13:14 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 21 May 2012 14:13:14 -0700 Subject: RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team In-Reply-To: <4FBA2477.7040101@oracle.com> References: <4FAD23E4.90501@oracle.com> <4FAD3B63.8070501@oracle.com> <4FBA2477.7040101@oracle.com> Message-ID: <4FBAAFEA.6090305@oracle.com> Erik, I like your idea of trying to define the string constants for the keys to benefit from the compiler checking and catch any issue due to typos at compile time. My review comments below. Your webrev includes other cleanup. While it's good to do the simple minor cleanup with this fix, I'd like to the warnings cleanup changes be separated from this patch and done by a separate CR. > * added generic types where needed. > * added suppress serialization warning where it was needed. > * removed suppress serialization annotation where it was not needed. Specifically, I'm concerned with @SuppressWarning("serial"). Tab.java L31 - it should not be suppressed and instead be fixed by defining the serialVersionUID (you can find the value by running serialver tool). Same to XOperations.java and XTable.java. I notice that the current code does suppress "serial" warning that you should check if it should be fixed as well. As for the generics, ProxyClient.java and XTree.java (and maybe some other places). When I saw the use of Iterator, I typically would also suggest to replacethe Iterator and while loop with foreach (L601-617 and L710, 736). Anyway, the warning cleanup deserves a separate CR and review. Below are comments on the change to support translateability. sun/tools/jconsole/resources/Messages.java I suggest to move Messages to sun.tools.jconsole since it's a utility class and conventionally resources are put in a "resources" subpackage (i.e. sun.tools.jconsole.resources in this case). The initializeMessage method uses the field name as the key and initializes its value to its localized message via reflection. Such approach seems strange. Have you considered about defining the constants with the key as the value (i.e. the variable name and its value are the same). Instead of initializing each static field of the Messages class, you can build a map of a key to the localized message + itsmnemonic key (like what you have done in building the MNEMONIC_LOOKUP map - why not change such hash map to map from a string to an object {message+mnemonic}). In that case, the MNEMONIC_LOOKUP doesn't need to be a synchronized map and could be done as the class initialization of Resources class. It would only need to keep Resources.getText(String) method that returns the localized message, e.g. Resources.getText(Messages.HELP_ABOUT_DIALOG_TITLE) I just don't see it's worth the complexity to initialize the static fields via reflection to get rid of a convenience method. It is only my suggestion and I understand that this fix needs to be backport to 7u6. If you agree that replacing this static field initialization logic with a separate map, I'm okay with pushing this approach to 7u6 and push a better fix to jdk8. Or I miss the benefit you were considering :) There are a few names with '_' suffix e.g. L93, 97, 104, 160 and also some names with '__' (L97, 159). Do you want to embed the space of the message in the key name? In any case, the key names with '_' suffix or double underscores '__' is a little confusing. It would be better just to use '_' for separating words of a key name and no need for '_' suffix. The names 'CHART_COLON', 'ERROR_COLON_MBEANS...', 'JCONSOLE_COLON', and the ones with 'COLON' to describe its message with ":" are strange. If ":" was removed from the message in the future, the name would need to be modified to follow this naming convention which is overkill. sun/tools/jconsole/Resources.java L52-54 and also other @param, nit:generally we put the description in the same line as the @param. XOpenTypeViewer.java L255: this doesn't look right - I think it should be Comparable. However, this method has @SuppressWarning("unchecked") and why was this line changed? Did you get other warning? Formatting nits: it's good to go through your changes and fix the formatting nits. The lines need to be updated to aligned, a few examples are: BorderedComponent.java L152 CreateMBeanDialog.java L77-78, 165-167, 169-171 MemoryTab.java L120-121, 126-127 OverviewTab.java L59-60 Plotter.java L319-321, 329-331 I didn't include all and please check the files not mentioned above. On 5/21/2012 4:18 AM, Erik Gahlin wrote: > Thanks Michael, > > When it comes to ALL CAPs or SturdlyCaps, it's okay if those strings > are not translated. > > Here is an updated webrev. I removed strings that were no longer in > use and made some changes to the make-files. > > http://cr.openjdk.java.net/~egahlin/7017818_4/ > > /E > > Michael Fang skrev 2012-05-11 18:16: >> Thanks so much Erik for the fix! The messages.properties file look >> good. I only reviewed the English *messages.properties* file. WPTG >> will re-translate the ja and zh_CN files. They will attempt to >> leverage existing translation from *JConsoleResources_xx.java*. >> >> I have a comments about another translatability rule that WPTG follows: >> >> By Oracle software development guideline, ALL CAPs or StudlyCaps >> strings will not be translated. Examples are: >> 19 ACTION_CAPITALIZED=ACTION >> 20 ACTION_INFO_CAPITALIZED=ACTION_INFO >> 149 MBEAN_INFO=MBeanInfo >> 150 MBEAN_NOTIFICATION_INFO=MBeanNotificationInfo >> 151 MBEAN_OPERATION_INFO=MBeanOperationInfo >> 206 OBJECT_NAME=ObjectName >> 231 R_FORWARD_SLASH_W_CAPITALIZED=R/W >> >> 241 SEQ_NUM=SeqNum >> 249 SUMMARY_TAB_HEADER_DATE_TIME_FORMAT=FULL,FULL >> >> 273 UNKNOWN_CAPITALIZED=UNKNOWN >> >> If any of the above such as ACTION or UNKNOWN needs to be translated, >> they should not be ALL CAPS. The translators will not translate those >> lines by default. >> >> The translators have the ability to see comments (or special >> requests) if a comment line is inserted immediately prior to any of >> the resources (each resource string and one comment line immediately >> before it is stored in translation memory). If you must leave ACTION >> or UNKNOWN in CAPS, you can try to insert comments.However, WPTG does >> not guarantee they will be followed. >> >> thanks, >> >> -michael >> >> On 12?05?11? 07:36 ??, Erik Gahlin wrote: >>> Could you please review? I also need a sponsor. >>> >>> http://cr.openjdk.java.net/~egahlin/7156518/1_0/ >>> >>> http://monaco.us.oracle.com/detail.jsf?cr=7017818 >>> >>> The patch is for JDK8, but it needs to ported to 7u6 before 5/16. >>> >>> Thanks! >>> >>> Erik >>> >>> Changes: >>> >>> - Moved localization messages to property files, one message per >>> line, as needed. >>> - Added '&' to messages so mnemonics could be identified. >>> - Introduced Message class with static fields corresponding to the >>> keys in the property files. >>> - Added map for looking up mnemonics. >>> >>> Testing: >>> >>> - Verified programmatically that all the messages and mnemonics are >>> "compatible" with the previous mechanism, for Chinese, Japanese and >>> the default locale. >>> - The intention is to run through the GUI to confirm that everything >>> looks ok, but I'm waiting for a build. >>> >>> Other: >>> >>> - Fixed a typo in the MemoryPoolStat class, the method >>> getAfterGcUsage returned this.beforeGCUsage instead of >>> this.afterGcUsage >>> - When going through all the code I did some minor clean up that >>> should not impact the program flow: >>> * removed unused imports. >>> * inlined temporary variables holding messages. >>> * removed private member variables that were not accessed. >>> * removed private methods that were not referenced. >>> * removed local variables that were not used. >>> * added generic types where needed. >>> * static methods are now called statically. >>> * added suppress serialization warning where it was needed. >>> * removed suppress serialization annotation where it was not needed. >>> - In the Message class, the comment "remove? not found in code" will >>> be removed once I know those message are not needed for 7u6. >>> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120521/d712a0df/attachment.html From james.holmlund at oracle.com Mon May 21 16:16:39 2012 From: james.holmlund at oracle.com (james.holmlund at oracle.com) Date: Mon, 21 May 2012 23:16:39 +0000 Subject: hg: jdk8/tl/langtools: 7157798: Add 6 test scenarios for testing inheritance of multiple same-name methods from mulitple interfaces Message-ID: <20120521231643.477004744C@hg.openjdk.java.net> Changeset: f5dbd6895994 Author: jjh Date: 2012-05-21 16:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f5dbd6895994 7157798: Add 6 test scenarios for testing inheritance of multiple same-name methods from mulitple interfaces Reviewed-by: mcimadamore Contributed-by: sue.wei at oracle.com + test/tools/javac/generics/rawOverride/7157798/Test1.java + test/tools/javac/generics/rawOverride/7157798/Test2.java + test/tools/javac/generics/rawOverride/7157798/Test3.java + test/tools/javac/generics/rawOverride/7157798/Test3.out + test/tools/javac/generics/rawOverride/7157798/Test4.java + test/tools/javac/generics/rawOverride/7157798/Test4.out From serguei.spitsyn at oracle.com Mon May 21 20:28:01 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 21 May 2012 20:28:01 -0700 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <1337592522.3408.16.camel@springer.wildebeest.org> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> Message-ID: <4FBB07C1.8000302@oracle.com> Mark, I've created new RFE: 7170638: enable support for dtrace compatible sdt probes on GNU/Linux The patches look good. But I think, it is better to be reviewed by Keith McGuigan, who originally added DTrace probes to HotSpot. Also, let's check if we have to submit a CCC request for this. Keith, do you have cycles to review the patches from Mark? I've included them into the bug report. Thanks, Serguei On 5/21/12 2:28 AM, Mark Wielaard wrote: > On Thu, 2012-05-17 at 23:30 -0700, serguei.spitsyn at oracle.com wrote: >> On 18/05/2012 9:47 AM, serguei.spitsyn at oracle.com wrote: >> On 5/17/12 9:48 PM, David Holmes wrote: >>>> Where are the patches? >>>> I do not see them in your emails. >>>> >>> The patches themselves are the emails with the subjects: >>> >>> [PATCH 1 of 3] ... >>> [PATCH 2 of 3] ... >>> [PATCH 3 of 3] ... >>> >> I've found these emails, they somehow got to the trash folder - very >> strange. > Apologies. That is how hg email sends them. I have a local mercurial > repository that contain the patches. Maybe your spam filter caught it > because all subjects start with XXXXXX as placeholder because I don't > have official bug numbers for them. If you could create the bugs and/or > let me know if you rather see these patches split up differently (or not > split up at all), please let me know and I rebase my patches and resend > them. > >>>> On 5/17/12 12:25 PM, Mark Wielaard wrote: >>>>> On Mon, May 14, 2012 at 07:41:50AM -0600, Daniel D. Daugherty >>>>> wrote: >>>>>> On 5/14/12 2:06 AM, Mark Wielaard wrote: >>>>>>> On Thu, 2012-05-10 at 09:52 -0600, Daniel D. Daugherty >>>>>>> wrote: >>>>>>>> Addingserviceability-dev at openjdk.java.net to this e-mail >>>>>>>> thread. >>>>>>> Thanks. Please let me know if there is anything I can do to >>>>>>> help >>>>>>> integration of these patches, or if there are other >>>>>>> places/people I need >>>>>>> to add to the CC for review. >>>>>> No problem. I was just making sure your e-mails got to the >>>>>> right aliases. >>>>>> As I no longer work on the Serviceability team, I'll leave it >>>>>> to them to >>>>>> address your e-mails. >>>>> Feedback from the Serviceability team is highly appreciated. >>>>> Please let >>>>> me know how I can help getting these patches in as soon as >>>>> possible. >>>>>>>> On 5/10/12 7:49 AM, Mark Wielaard wrote: >>>>>>>>> The following three patches enable support for dtrace >>>>>>>>> compatible sdt probes >>>>>>>>> on GNU/Linux. Most of the support was already submitted >>>>>>>>> earlier. These are >>>>>>>>> just the last three things left in IcedTea that actually >>>>>>>>> enable it in >>>>>>>>> hotspot. It has been in production use for some time >>>>>>>>> already. >>>>>>>>> >>>>>>>>> The patches could be applied all as one, or individually >>>>>>>>> if you want to be >>>>>>>>> able to test them independently. >>>>>>> [... explanation of separate patches removed ...] >>>>>>>>> Patches in separate emails. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120521/e75ebb44/attachment-0001.html From david.holmes at oracle.com Mon May 21 21:27:14 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 22 May 2012 14:27:14 +1000 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBB07C1.8000302@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> Message-ID: <4FBB15A2.7090808@oracle.com> Is systemTap part of regular distros these days - in particular in our build environment? I'm just wondering who is going to ensure that these probe entries compile and run correctly? Can we see a complete webrev of the proposed changes? Thanks, David On 22/05/2012 1:28 PM, serguei.spitsyn at oracle.com wrote: > Mark, > > I've created new RFE: > 7170638: enable support for dtrace compatible sdt probes on GNU/Linux > > The patches look good. > But I think, it is better to be reviewed by Keith McGuigan, who > originally added DTrace probes to HotSpot. > Also, let's check if we have to submit a CCC request for this. > > Keith, do you have cycles to review the patches from Mark? > I've included them into the bug report. > > Thanks, > Serguei > > > On 5/21/12 2:28 AM, Mark Wielaard wrote: >> On Thu, 2012-05-17 at 23:30 -0700,serguei.spitsyn at oracle.com wrote: >>> On 18/05/2012 9:47 AM,serguei.spitsyn at oracle.com wrote: >>> On 5/17/12 9:48 PM, David Holmes wrote: >>>>> Where are the patches? >>>>> I do not see them in your emails. >>>>> >>>> The patches themselves are the emails with the subjects: >>>> >>>> [PATCH 1 of 3] ... >>>> [PATCH 2 of 3] ... >>>> [PATCH 3 of 3] ... >>>> >>> I've found these emails, they somehow got to the trash folder - very >>> strange. >> Apologies. That is how hg email sends them. I have a local mercurial >> repository that contain the patches. Maybe your spam filter caught it >> because all subjects start with XXXXXX as placeholder because I don't >> have official bug numbers for them. If you could create the bugs and/or >> let me know if you rather see these patches split up differently (or not >> split up at all), please let me know and I rebase my patches and resend >> them. >> >>>>> On 5/17/12 12:25 PM, Mark Wielaard wrote: >>>>>> On Mon, May 14, 2012 at 07:41:50AM -0600, Daniel D. Daugherty >>>>>> wrote: >>>>>>> On 5/14/12 2:06 AM, Mark Wielaard wrote: >>>>>>>> On Thu, 2012-05-10 at 09:52 -0600, Daniel D. Daugherty >>>>>>>> wrote: >>>>>>>>> Addingserviceability-dev at openjdk.java.net to this e-mail >>>>>>>>> thread. >>>>>>>> Thanks. Please let me know if there is anything I can do to >>>>>>>> help >>>>>>>> integration of these patches, or if there are other >>>>>>>> places/people I need >>>>>>>> to add to the CC for review. >>>>>>> No problem. I was just making sure your e-mails got to the >>>>>>> right aliases. >>>>>>> As I no longer work on the Serviceability team, I'll leave it >>>>>>> to them to >>>>>>> address your e-mails. >>>>>> Feedback from the Serviceability team is highly appreciated. >>>>>> Please let >>>>>> me know how I can help getting these patches in as soon as >>>>>> possible. >>>>>>>>> On 5/10/12 7:49 AM, Mark Wielaard wrote: >>>>>>>>>> The following three patches enable support for dtrace >>>>>>>>>> compatible sdt probes >>>>>>>>>> on GNU/Linux. Most of the support was already submitted >>>>>>>>>> earlier. These are >>>>>>>>>> just the last three things left in IcedTea that actually >>>>>>>>>> enable it in >>>>>>>>>> hotspot. It has been in production use for some time >>>>>>>>>> already. >>>>>>>>>> >>>>>>>>>> The patches could be applied all as one, or individually >>>>>>>>>> if you want to be >>>>>>>>>> able to test them independently. >>>>>>>> [... explanation of separate patches removed ...] >>>>>>>>>> Patches in separate emails. > From serguei.spitsyn at oracle.com Mon May 21 23:42:29 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 21 May 2012 23:42:29 -0700 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBB15A2.7090808@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> Message-ID: <4FBB3555.2080607@oracle.com> On 5/21/12 9:27 PM, David Holmes wrote: > Is systemTap part of regular distros these days - in particular in our > build environment? > I don't know yet, we have to figure it out. It'd be nice to have a Keith's opinion first. > I'm just wondering who is going to ensure that these probe entries > compile and run correctly? It depends on the availability or possible setup of linux machines with the systemTap. Some test is needed as well. > > Can we see a complete webrev of the proposed changes? I'll prepare a complete webrev. Thanks, Serguei > > Thanks, > David > > On 22/05/2012 1:28 PM, serguei.spitsyn at oracle.com wrote: >> Mark, >> >> I've created new RFE: >> 7170638: enable support for dtrace compatible sdt probes on GNU/Linux >> >> The patches look good. >> But I think, it is better to be reviewed by Keith McGuigan, who >> originally added DTrace probes to HotSpot. >> Also, let's check if we have to submit a CCC request for this. >> >> Keith, do you have cycles to review the patches from Mark? >> I've included them into the bug report. >> >> Thanks, >> Serguei >> >> >> On 5/21/12 2:28 AM, Mark Wielaard wrote: >>> On Thu, 2012-05-17 at 23:30 -0700,serguei.spitsyn at oracle.com wrote: >>>> On 18/05/2012 9:47 AM,serguei.spitsyn at oracle.com wrote: >>>> On 5/17/12 9:48 PM, David Holmes wrote: >>>>>> Where are the patches? >>>>>> I do not see them in your emails. >>>>>> >>>>> The patches themselves are the emails with the subjects: >>>>> >>>>> [PATCH 1 of 3] ... >>>>> [PATCH 2 of 3] ... >>>>> [PATCH 3 of 3] ... >>>>> >>>> I've found these emails, they somehow got to the trash folder - very >>>> strange. >>> Apologies. That is how hg email sends them. I have a local mercurial >>> repository that contain the patches. Maybe your spam filter caught it >>> because all subjects start with XXXXXX as placeholder because I don't >>> have official bug numbers for them. If you could create the bugs and/or >>> let me know if you rather see these patches split up differently (or >>> not >>> split up at all), please let me know and I rebase my patches and resend >>> them. >>> >>>>>> On 5/17/12 12:25 PM, Mark Wielaard wrote: >>>>>>> On Mon, May 14, 2012 at 07:41:50AM -0600, Daniel D. Daugherty >>>>>>> wrote: >>>>>>>> On 5/14/12 2:06 AM, Mark Wielaard wrote: >>>>>>>>> On Thu, 2012-05-10 at 09:52 -0600, Daniel D. Daugherty >>>>>>>>> wrote: >>>>>>>>>> Addingserviceability-dev at openjdk.java.net to this e-mail >>>>>>>>>> thread. >>>>>>>>> Thanks. Please let me know if there is anything I can do to >>>>>>>>> help >>>>>>>>> integration of these patches, or if there are other >>>>>>>>> places/people I need >>>>>>>>> to add to the CC for review. >>>>>>>> No problem. I was just making sure your e-mails got to the >>>>>>>> right aliases. >>>>>>>> As I no longer work on the Serviceability team, I'll leave it >>>>>>>> to them to >>>>>>>> address your e-mails. >>>>>>> Feedback from the Serviceability team is highly appreciated. >>>>>>> Please let >>>>>>> me know how I can help getting these patches in as soon as >>>>>>> possible. >>>>>>>>>> On 5/10/12 7:49 AM, Mark Wielaard wrote: >>>>>>>>>>> The following three patches enable support for dtrace >>>>>>>>>>> compatible sdt probes >>>>>>>>>>> on GNU/Linux. Most of the support was already submitted >>>>>>>>>>> earlier. These are >>>>>>>>>>> just the last three things left in IcedTea that actually >>>>>>>>>>> enable it in >>>>>>>>>>> hotspot. It has been in production use for some time >>>>>>>>>>> already. >>>>>>>>>>> >>>>>>>>>>> The patches could be applied all as one, or individually >>>>>>>>>>> if you want to be >>>>>>>>>>> able to test them independently. >>>>>>>>> [... explanation of separate patches removed ...] >>>>>>>>>>> Patches in separate emails. >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120521/0acf4638/attachment.html From mjw at redhat.com Tue May 22 03:45:46 2012 From: mjw at redhat.com (Mark Wielaard) Date: Tue, 22 May 2012 12:45:46 +0200 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBB07C1.8000302@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> Message-ID: <1337683546.30205.40.camel@springer.wildebeest.org> On Mon, 2012-05-21 at 20:28 -0700, serguei.spitsyn at oracle.com wrote: > Mark, > > I've created new RFE: > 7170638: enable support for dtrace compatible sdt probes on GNU/Linux > > The patches look good. Thanks. > But I think, it is better to be reviewed by Keith McGuigan, who > originally added DTrace probes to HotSpot. That would be nice. Keith also integrated earlier patches from me in this area. > Also, let's check if we have to submit a CCC request for this. I cannot find how that works. Do you have a pointer to the CCC process? Thanks, Mark From mjw at redhat.com Tue May 22 04:02:44 2012 From: mjw at redhat.com (Mark Wielaard) Date: Tue, 22 May 2012 13:02:44 +0200 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBB15A2.7090808@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> Message-ID: <1337684564.30205.55.camel@springer.wildebeest.org> On Tue, 2012-05-22 at 14:27 +1000, David Holmes wrote: > Is systemTap part of regular distros these days - in particular in our > build environment? > > I'm just wondering who is going to ensure that these probe entries > compile and run correctly? Note that SDT markers are just that, markers. There is not really something that "runs" them. But systemtap and recent GDB can find them and use them for introspection. There are several icedtea autobuilders that can do that: http://builder.classpath.org/icedtea/buildbot/waterfall This has been included through IcedTea at least on Fedora based systems for some years now and on RHEL6 since release (2010 I believe). In theory SDT markers on GNU/Linux should be source compatible with those on Solaris. That was how it was designed. The make patch checks there is a sys/sdt.h include file available, which is really all there is to it [*] (the only difference between dtrace sdt and gnu/linux sdt markers is how/where they are stored in the ELF file). But in practice there have of course been bugs in compilers (but I believe any modern g++ 4.4+ compiler should do, 4.4.6 is the oldest I can find on my RHEL6 install, current GCC version is 4.7). Cheers, Mark [*] http://sourceware.org/systemtap/wiki/UserSpaceProbeImplementation From mjw at redhat.com Tue May 22 04:11:12 2012 From: mjw at redhat.com (Mark Wielaard) Date: Tue, 22 May 2012 13:11:12 +0200 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBB3555.2080607@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> Message-ID: <1337685072.30205.62.camel@springer.wildebeest.org> On Mon, 2012-05-21 at 23:42 -0700, serguei.spitsyn at oracle.com wrote: > On 5/21/12 9:27 PM, David Holmes wrote: > It depends on the availability or possible setup of linux machines > with the systemTap. > Some test is needed as well. IcedTea contains a tapset to use them with systemtap and a testsuite written in Perl by Jon VanAlten. But really the SDT markers themselves are independent from any program that consumes them (on Solaris you would use dtrace, on GNU/Linux you can also use GDB or just list them with readelf -n). > > Can we see a complete webrev of the proposed changes? > > I'll prepare a complete webrev. Thanks. If that is a lot of work then feel free to ask me to set that up. Just tell me how you want them split up. Since the patches are mostly independent. Cheers, Mark From david.holmes at oracle.com Tue May 22 04:25:22 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 22 May 2012 21:25:22 +1000 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <1337685072.30205.62.camel@springer.wildebeest.org> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> <1337685072.30205.62.camel@springer.wildebeest.org> Message-ID: <4FBB77A2.2060300@oracle.com> On 22/05/2012 9:11 PM, Mark Wielaard wrote: > On Mon, 2012-05-21 at 23:42 -0700, serguei.spitsyn at oracle.com wrote: >> On 5/21/12 9:27 PM, David Holmes wrote: >> It depends on the availability or possible setup of linux machines >> with the systemTap. >> Some test is needed as well. > > IcedTea contains a tapset to use them with systemtap and a testsuite > written in Perl by Jon VanAlten. But really the SDT markers themselves > are independent from any program that consumes them (on Solaris you > would use dtrace, on GNU/Linux you can also use GDB or just list them > with readelf -n). I need to understand this aspect a bit better. >>> Can we see a complete webrev of the proposed changes? >> >> I'll prepare a complete webrev. > > Thanks. If that is a lot of work then feel free to ask me to set that > up. Just tell me how you want them split up. Since the patches are > mostly independent. No need to split anything up. These patches work together to achieve one goal - which is why a single CR was created to cover them. It won't be much effort for Serguei to create a webrev. Thanks, David > Cheers, > > Mark From staffan.larsen at oracle.com Tue May 22 04:39:39 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Tue, 22 May 2012 13:39:39 +0200 Subject: request for codereview, bug 7149528: easy usage of serviceability agent In-Reply-To: <4FAD8922.9010902@oracle.com> References: <4FAD8922.9010902@oracle.com> Message-ID: <2DC2B513-1692-487E-82C7-ED0CE00332FD@oracle.com> Yumin, Thanks for doing this! I still wonder if we should support -startsvr in the new launcher, given that we already have a jsadebugd launcher that does exactly that. I don't like having two ways of doing the same thing that we have to support. Either we have jsadebugd or we have "jsa -startsvr", but I think it will be a lot of work to remove jsadebugd so it's simpler to leave it and remove the -startsvr flag. I think the usage instructions could be made easier to read by splitting them on multiple lines for the "live process" case and the "core" case. See the output from jsadebugd for an example. It would also be good if these two tools used the same terminology. A couple of nits for SAMain: * the case statements do not need parentheses around the value: "case (0):" should be "case 0:" * line 35: missing space before { * line 37: missing space after the if * line 37: always use {} and newlines after if * line 42 & 43: I prefer having the method implementation on a new line after the declaration Thanks, /Staffan On 11 maj 2012, at 23:48, Yumin Qi wrote: > Hi, all > > Can I have your codereview for bug 7149528: easy usage of serviceability agent. > Problems 1) for launching Serviceability Agent(SA) is that it needs setting several environmental variables for class path, library path options. It is not easy for user to become familiar with those settings. 2) SA launched from java and attached to java process (or the binary which loaded JVM). On MacOS, attaching to process needs permission. If we grant access for SA, we have to grant all java processes have the same access permission so brings security concern on the platform since java is too generic for doing so. With a separate SA launcher, giving it permission attaching to java process solves the concern. > > the change for both hotspot and jdk: > http://cr.openjdk.java.net/~minqi/7149528 > > Thanks > Yumin From mjw at redhat.com Tue May 22 04:45:37 2012 From: mjw at redhat.com (Mark Wielaard) Date: Tue, 22 May 2012 13:45:37 +0200 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBB77A2.2060300@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> <1337685072.30205.62.camel@springer.wildebeest.org> <4FBB77A2.2060300@oracle.com> Message-ID: <1337687137.30205.79.camel@springer.wildebeest.org> On Tue, 2012-05-22 at 21:25 +1000, David Holmes wrote: > On 22/05/2012 9:11 PM, Mark Wielaard wrote: > >But really the SDT markers themselves > > are independent from any program that consumes them (on Solaris you > > would use dtrace, on GNU/Linux you can also use GDB or just list them > > with readelf -n). > > I need to understand this aspect a bit better. SDT markers are defined by simple macros. e.g: DTRACE_PROBE5(provider,probe,parm1,parm2,parm3,parm4,parm5) Which is a marker for a named provider with a probe name and 5 arguments. Of course in the hotspot source code there are macros around these macros, and some convenience functions. All the patches really do is make sure that if a sys/sdt.h file is found on a GNU/Linux system it is included and the macros are used. These macros expand to a little bit of code that just puts those names and where the arguments can be found in a little ELF notes section. So with the patch applied and compiled on a system that has sys/sdt.h you will get a libjvm.so that contains: $ eu-readelf -n libjvm.so Note section [29] '.note.stapsdt' of 53916 bytes at offset 0x99fac8: Owner Data size Type stapsdt 77 Version: 3 PC: 0x35612f, Base: 0x7f2378, Semaphore: 0 Provider: hotspot, Name: class__loaded, Args: '8@%r13 -4@%r14d 8@%rax 1@%r12b' stapsdt 76 Version: 3 PC: 0x3561e5, Base: 0x7f2378, Semaphore: 0 Provider: hotspot, Name: class__unloaded, Args: '8@%rbx -4@%r12d 8@%rax 1@$0' [etc.] That ELF notes section can then be used by programs like stap or gdb to put breakpoints/probes on those locations and retrieve the arguments found. A more technical explanation with some more details I left out can be found at: http://sourceware.org/systemtap/wiki/UserSpaceProbeImplementation Another high level overview from one of the GDB maintainers is here: http://tromey.com/blog/?p=687 It works similar for SDT probes on Solaris and dtrace, though they use different conventions for storing the addresses/names/arguments. The main difference is that on solaris a different ELF section is used and the arguments are assumed to follow function calling conventions, while on gnu/linux they can just be "anywhere". Hope that helps, Mark From david.holmes at oracle.com Tue May 22 05:25:25 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 22 May 2012 22:25:25 +1000 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <1337687137.30205.79.camel@springer.wildebeest.org> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> <1337685072.30205.62.camel@springer.wildebeest.org> <4FBB77A2.2060300@oracle.com> <1337687137.30205.79.camel@springer.wildebeest.org> Message-ID: <4FBB85B5.6040000@oracle.com> On 22/05/2012 9:45 PM, Mark Wielaard wrote: > On Tue, 2012-05-22 at 21:25 +1000, David Holmes wrote: >> On 22/05/2012 9:11 PM, Mark Wielaard wrote: >>> But really the SDT markers themselves >>> are independent from any program that consumes them (on Solaris you >>> would use dtrace, on GNU/Linux you can also use GDB or just list them >>> with readelf -n). >> >> I need to understand this aspect a bit better. > > SDT markers are defined by simple macros. e.g: > DTRACE_PROBE5(provider,probe,parm1,parm2,parm3,parm4,parm5) > Which is a marker for a named provider with a probe name and 5 > arguments. Of course in the hotspot source code there are macros around > these macros, and some convenience functions. All the patches really do > is make sure that if a sys/sdt.h file is found on a GNU/Linux system it > is included and the macros are used. These macros expand to a little bit > of code that just puts those names and where the arguments can be found > in a little ELF notes section. Many thanks for the explanation Mark. Do you know what the effect of this is on the static size of libjvm.so? I think we would need a way to disable this even if sys/sdt.h is present - just as dtrace support can be disabled. David ----- > So with the patch applied and compiled on a system that has sys/sdt.h > you will get a libjvm.so that contains: > > $ eu-readelf -n libjvm.so > > Note section [29] '.note.stapsdt' of 53916 bytes at offset 0x99fac8: > Owner Data size Type > stapsdt 77 Version: 3 > PC: 0x35612f, Base: 0x7f2378, Semaphore: 0 > Provider: hotspot, Name: class__loaded, Args: '8@%r13 -4@%r14d 8@%rax 1@%r12b' > stapsdt 76 Version: 3 > PC: 0x3561e5, Base: 0x7f2378, Semaphore: 0 > Provider: hotspot, Name: class__unloaded, Args: '8@%rbx -4@%r12d 8@%rax 1@$0' > > [etc.] > > That ELF notes section can then be used by programs like stap or gdb to > put breakpoints/probes on those locations and retrieve the arguments > found. > > A more technical explanation with some more details I left out can be > found at: > http://sourceware.org/systemtap/wiki/UserSpaceProbeImplementation > Another high level overview from one of the GDB maintainers is here: > http://tromey.com/blog/?p=687 > > It works similar for SDT probes on Solaris and dtrace, though they use > different conventions for storing the addresses/names/arguments. The > main difference is that on solaris a different ELF section is used and > the arguments are assumed to follow function calling conventions, while > on gnu/linux they can just be "anywhere". > > Hope that helps, > > Mark From mjw at redhat.com Tue May 22 05:55:38 2012 From: mjw at redhat.com (Mark Wielaard) Date: Tue, 22 May 2012 14:55:38 +0200 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBB85B5.6040000@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> <1337685072.30205.62.camel@springer.wildebeest.org> <4FBB77A2.2060300@oracle.com> <1337687137.30205.79.camel@springer.wildebeest.org> <4FBB85B5.6040000@oracle.com> Message-ID: <1337691338.30205.93.camel@springer.wildebeest.org> On Tue, 2012-05-22 at 22:25 +1000, David Holmes wrote: > Do you know what the effect of this is on the static size of libjvm.so? On my system the .note.stapsdt section is d29c bytes. So ~50K. That is for 522 probes (yes, hotspot does define that many) expanded to 547 unique locations. > I think we would need a way to disable this even if sys/sdt.h is present > - just as dtrace support can be disabled. Just don't install /usr/include/sys/sdt.h on the build system. Or define ALT_SDT_H to something like /no/sdt.h and it will be disabled. See the last patch for make/linux/makefiles/dtrace.make and vm.make. I took the same approach as was used in make/solaris. Cheers, Mark From yumin.qi at oracle.com Tue May 22 10:42:35 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Tue, 22 May 2012 10:42:35 -0700 Subject: request for codereview, bug 7149528: easy usage of serviceability agent In-Reply-To: <2DC2B513-1692-487E-82C7-ED0CE00332FD@oracle.com> References: <4FAD8922.9010902@oracle.com> <2DC2B513-1692-487E-82C7-ED0CE00332FD@oracle.com> Message-ID: <4FBBD00B.8080609@oracle.com> Staffan, Thanks. Will change per your concern. Will remove -startsvr option. CCC not approved yet, it may take long time waiting. Thanks Yumin On 2012/5/22 4:39, Staffan Larsen wrote: > Yumin, > > Thanks for doing this! > > I still wonder if we should support -startsvr in the new launcher, given that we already have a jsadebugd launcher that does exactly that. I don't like having two ways of doing the same thing that we have to support. Either we have jsadebugd or we have "jsa -startsvr", but I think it will be a lot of work to remove jsadebugd so it's simpler to leave it and remove the -startsvr flag. > > I think the usage instructions could be made easier to read by splitting them on multiple lines for the "live process" case and the "core" case. See the output from jsadebugd for an example. It would also be good if these two tools used the same terminology. > > A couple of nits for SAMain: > * the case statements do not need parentheses around the value: "case (0):" should be "case 0:" > * line 35: missing space before { > * line 37: missing space after the if > * line 37: always use {} and newlines after if > * line 42& 43: I prefer having the method implementation on a new line after the declaration > > Thanks, > /Staffan > > > > On 11 maj 2012, at 23:48, Yumin Qi wrote: > >> Hi, all >> >> Can I have your codereview for bug 7149528: easy usage of serviceability agent. >> Problems 1) for launching Serviceability Agent(SA) is that it needs setting several environmental variables for class path, library path options. It is not easy for user to become familiar with those settings. 2) SA launched from java and attached to java process (or the binary which loaded JVM). On MacOS, attaching to process needs permission. If we grant access for SA, we have to grant all java processes have the same access permission so brings security concern on the platform since java is too generic for doing so. With a separate SA launcher, giving it permission attaching to java process solves the concern. >> >> the change for both hotspot and jdk: >> http://cr.openjdk.java.net/~minqi/7149528 >> >> Thanks >> Yumin From joe.darcy at oracle.com Tue May 22 11:22:09 2012 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 22 May 2012 11:22:09 -0700 Subject: request for codereview, bug 7149528: easy usage of serviceability agent In-Reply-To: <4FBBD00B.8080609@oracle.com> References: <4FAD8922.9010902@oracle.com> <2DC2B513-1692-487E-82C7-ED0CE00332FD@oracle.com> <4FBBD00B.8080609@oracle.com> Message-ID: <4FBBD951.1040302@oracle.com> Yumin, For the last two years, the average latency to get a finalized ccc request approved has been less than three days. Over 10% of request are approved the same day they come in. The ccc request for 7149528 is in "draft" state. In other words, it has not yet been submitted to the ccc for consideration. This state model is explained in the "process" link at the top of every ccc page and was additionally explained in a tech talk I gave earlier this year: http://j2se.us.oracle.com/web/pub/PrgMgmt/TechTalks/ccc-and-you.pdf Please do not blame excessive wait times on the ccc process when the ccc is not being used as documented, especially when the explanatory talk tech was largely given in response to the experiences the serviceability team had with JFR. Regards, -Joe On 5/22/2012 10:42 AM, Yumin Qi wrote: > Staffan, > > Thanks. Will change per your concern. Will remove -startsvr option. > CCC not approved yet, it may take long time waiting. > > Thanks > Yumin > > On 2012/5/22 4:39, Staffan Larsen wrote: >> Yumin, >> >> Thanks for doing this! >> >> I still wonder if we should support -startsvr in the new launcher, >> given that we already have a jsadebugd launcher that does exactly >> that. I don't like having two ways of doing the same thing that we >> have to support. Either we have jsadebugd or we have "jsa -startsvr", >> but I think it will be a lot of work to remove jsadebugd so it's >> simpler to leave it and remove the -startsvr flag. >> >> I think the usage instructions could be made easier to read by >> splitting them on multiple lines for the "live process" case and the >> "core" case. See the output from jsadebugd for an example. It would >> also be good if these two tools used the same terminology. >> >> A couple of nits for SAMain: >> * the case statements do not need parentheses around the value: "case >> (0):" should be "case 0:" >> * line 35: missing space before { >> * line 37: missing space after the if >> * line 37: always use {} and newlines after if >> * line 42& 43: I prefer having the method implementation on a new >> line after the declaration >> >> Thanks, >> /Staffan >> >> >> >> On 11 maj 2012, at 23:48, Yumin Qi wrote: >> >>> Hi, all >>> >>> Can I have your codereview for bug 7149528: easy usage of >>> serviceability agent. >>> Problems 1) for launching Serviceability Agent(SA) is that it >>> needs setting several environmental variables for class path, >>> library path options. It is not easy for user to become familiar >>> with those settings. 2) SA launched from java and attached to java >>> process (or the binary which loaded JVM). On MacOS, attaching to >>> process needs permission. If we grant access for SA, we have to >>> grant all java processes have the same access permission so brings >>> security concern on the platform since java is too generic for doing >>> so. With a separate SA launcher, giving it permission attaching to >>> java process solves the concern. >>> >>> the change for both hotspot and jdk: >>> http://cr.openjdk.java.net/~minqi/7149528 >>> >>> Thanks >>> Yumin From erik.gahlin at oracle.com Tue May 22 12:40:08 2012 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Tue, 22 May 2012 21:40:08 +0200 Subject: RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team In-Reply-To: <4FBAAFEA.6090305@oracle.com> References: <4FAD23E4.90501@oracle.com> <4FAD3B63.8070501@oracle.com> <4FBA2477.7040101@oracle.com> <4FBAAFEA.6090305@oracle.com> Message-ID: <4FBBEB98.50704@oracle.com> Mandy Chung skrev 2012-05-21 23:13: > Erik, > > I like your idea of trying to define the string constants > for the keys to benefit from the compiler checking and > catch any issue due to typos at compile time. My review > comments below. > > Your webrev includes other cleanup. While it's good to > do the simple minor cleanup with this fix, I'd like to > the warnings cleanup changes be separated from this patch > and done by a separate CR. Thanks for reviewing, I got a lot of unused import warnings from the IDE when I changed the Resources class. When I cleaned them up I thought I might as well clean up the others too, so I could more easily see that I had taken care of all the warnings I caused. Same thing with unused member variables and unused methods. Import-statements will not change how the program executes, so I thought it was safe to remove them (no risk of introducing new bugs). > >> * added generic types where needed. >> * added suppress serialization warning where it was needed. >> * removed suppress serialization annotation where it was not needed. > > Specifically, I'm concerned with @SuppressWarning("serial"). > Tab.java L31 - it should not be suppressed and instead be > fixed by defining the serialVersionUID (you can find the > value by running serialver tool). Same to XOperations.java and > XTable.java. I notice that the current code does suppress > "serial" warning that you should check if it should be fixed > as well. I agree, I was trying to get rid of all the warnings so I could see the real problems more easily. Adding serialVersionUID might be beyond the scope of the CR. I can bring back the warnings, if you like, now that I know my code is free of warnings. > > As for the generics, ProxyClient.java and XTree.java (and > maybe some other places). When I saw the use of Iterator, > I typically would also suggest to replacethe Iterator and > while loop with foreach (L601-617 and L710, 736). I agree, I was trying to get rid of all the warnings so I could see the real problems. Foreach is prefered, but I think it's beyond the scope of the CR to replace all those. Also, adding generics doesn't change the byte code and should be safe. Rewritings loops could potentially introduce other bugs and to me there is little benefit. > Anyway, > the warning cleanup deserves a separate CR and review. Breaking it up into seperate patches and CRs will take time. Is it really necessary? I cleaned up the code so I could make the fix more easily. I don't think it's worth the hazzle to create a separate bug and patch. I might as well revert the clean ups. > > Below are comments on the change to support translateability. > > sun/tools/jconsole/resources/Messages.java > I suggest to move Messages to sun.tools.jconsole since > it's a utility class and conventionally resources are put > in a "resources" subpackage (i.e. sun.tools.jconsole.resources > in this case). I think one package private Message class for each package and separate resource files for each package would be the best, but I didn't want this CR to blow up, so I put the Message class where the other Java classes related to resources were before. I can move it to sun.tools.jconsole, if you think that's better. > > The initializeMessage method uses the field name as the > key and initializes its value to its localized message via > reflection. Such approach seems strange. I like to enforce one-to-one mapping between the keys in the property file and the keys used in the Java code. When going through the fields in the Message class, using reflection, I can ensure that all fields have a corresponding property value in the file, and vice versa. With this approrach it's not necessary click through all the GUI to verify that all keys exists in the property file. It's also possible to detect if a value in a property file is no longer in use. The code that does the one-to-one check was removed, but it should probably be added back so similar problems can be catched automatically in the future. > > Have you considered about defining the constants with > the key as the value (i.e. the variable name and its > value are the same). The Java constants can't be the same as the property value since the character you can use for a variable name is limited, for instance a constant can't contain the ':'-character. > Instead of initializing each > static field of the Messages class, you can build > a map of a key to the localized message + itsmnemonic > key (like what you have done in building the MNEMONIC_LOOKUP > map - why not change such hash map to map from a string to > an object {message+mnemonic}). In that case, the MNEMONIC_LOOKUP > doesn't need to be a synchronized map and could be done > as the class initialization of Resources class. > > It would only need to keep > Resources.getText(String) method that returns the localized > message, e.g. > Resources.getText(Messages.HELP_ABOUT_DIALOG_TITLE) > > I just don't see it's worth the complexity to initialize > the static fields via reflection to get rid of a convenience > method. The synchronization is not really needed, if you always use the keys to lookup the messages. The static initializer in the Message class should ensure correct ordering. Looking up messages "dynamically" means you have to trigger all the code in the GUI that needs a translated message to be sure you got things correct. Since there are several hundred messages I think the static-fields-reflection approach is better. > > > It is only my suggestion and I understand that this fix needs > to be backport to 7u6. If you agree that replacing this > static field initialization logic with a separate map, > I'm okay with pushing this approach to 7u6 and push > a better fix to jdk8. Or I miss the benefit you were > considering :) You are missing it :) .. and it's probably because I removed the code that did the actual check :) > > There are a few names with '_' suffix e.g. L93, 97, 104, 160 > and also some names with '__' (L97, 159). Do you want to > embed the space of the message in the key name? In any case, > the key names with '_' suffix or double underscores '__' is > a little confusing. It would be better just to use '_' for > separating words of a key name and no need for '_' suffix. > The names 'CHART_COLON', 'ERROR_COLON_MBEANS...', 'JCONSOLE_COLON', > and the ones with 'COLON' to describe its message with ":" > are strange. If ":" was removed from the message in the > future, the name would need to be modified to follow this > naming convention which is overkill. The keys were generated programmatically. The 'COLON' was needed so I could differentiate between message that looked the same, except for the ':' at the end. The pattern was applied to all messages. Some of those message were removed (since they were no longer in use) I can remove the 'COLON' suffix where it's not needed, same thing with spaces. I will go over the message keys and clean up the names, but they were not that clean before either :) > > sun/tools/jconsole/Resources.java > L52-54 and also other @param, nit:generally we put > the description in the same line as the @param. Will fix! > XOpenTypeViewer.java > L255: this doesn't look right - I think it should be > Comparable. However, this method has > @SuppressWarning("unchecked") and why was this line > changed? Did you get other warning? > CompositeData#get returns Object and because of type erasure it can't be guaranteed to be Comparable without an explicit cast, which I didn't dare to add, so I put in Object. Yes, I got a rawtypes warning on the Comparable. > Formatting nits: it's good to go through your changes and > fix the formatting nits. The lines need to be updated to > aligned, a few examples are: > BorderedComponent.java L152 > CreateMBeanDialog.java L77-78, 165-167, 169-171 > MemoryTab.java L120-121, 126-127 > OverviewTab.java L59-60 > Plotter.java L319-321, 329-331 > > I didn't include all and please check the files not mentioned above. > Will do! > On 5/21/2012 4:18 AM, Erik Gahlin wrote: >> Thanks Michael, >> >> When it comes to ALL CAPs or SturdlyCaps, it's okay if those strings >> are not translated. >> >> Here is an updated webrev. I removed strings that were no longer in >> use and made some changes to the make-files. >> >> http://cr.openjdk.java.net/~egahlin/7017818_4/ >> >> /E >> >> Michael Fang skrev 2012-05-11 18:16: >>> Thanks so much Erik for the fix! The messages.properties file look >>> good. I only reviewed the English *messages.properties* file. WPTG >>> will re-translate the ja and zh_CN files. They will attempt to >>> leverage existing translation from *JConsoleResources_xx.java*. >>> >>> I have a comments about another translatability rule that WPTG follows: >>> >>> By Oracle software development guideline, ALL CAPs or StudlyCaps >>> strings will not be translated. Examples are: >>> 19 ACTION_CAPITALIZED=ACTION >>> 20 ACTION_INFO_CAPITALIZED=ACTION_INFO >>> 149 MBEAN_INFO=MBeanInfo >>> 150 MBEAN_NOTIFICATION_INFO=MBeanNotificationInfo >>> 151 MBEAN_OPERATION_INFO=MBeanOperationInfo >>> 206 OBJECT_NAME=ObjectName >>> 231 R_FORWARD_SLASH_W_CAPITALIZED=R/W >>> >>> 241 SEQ_NUM=SeqNum >>> 249 SUMMARY_TAB_HEADER_DATE_TIME_FORMAT=FULL,FULL >>> >>> 273 UNKNOWN_CAPITALIZED=UNKNOWN >>> >>> If any of the above such as ACTION or UNKNOWN needs to be >>> translated, they should not be ALL CAPS. The translators will not >>> translate those lines by default. >>> >>> The translators have the ability to see comments (or special >>> requests) if a comment line is inserted immediately prior to any of >>> the resources (each resource string and one comment line immediately >>> before it is stored in translation memory). If you must leave ACTION >>> or UNKNOWN in CAPS, you can try to insert comments.However, WPTG >>> does not guarantee they will be followed. >>> >>> thanks, >>> >>> -michael >>> >>> On 12?05?11? 07:36 ??, Erik Gahlin wrote: >>>> Could you please review? I also need a sponsor. >>>> >>>> http://cr.openjdk.java.net/~egahlin/7156518/1_0/ >>>> >>>> http://monaco.us.oracle.com/detail.jsf?cr=7017818 >>>> >>>> The patch is for JDK8, but it needs to ported to 7u6 before 5/16. >>>> >>>> Thanks! >>>> >>>> Erik >>>> >>>> Changes: >>>> >>>> - Moved localization messages to property files, one message per >>>> line, as needed. >>>> - Added '&' to messages so mnemonics could be identified. >>>> - Introduced Message class with static fields corresponding to the >>>> keys in the property files. >>>> - Added map for looking up mnemonics. >>>> >>>> Testing: >>>> >>>> - Verified programmatically that all the messages and mnemonics are >>>> "compatible" with the previous mechanism, for Chinese, Japanese and >>>> the default locale. >>>> - The intention is to run through the GUI to confirm that >>>> everything looks ok, but I'm waiting for a build. >>>> >>>> Other: >>>> >>>> - Fixed a typo in the MemoryPoolStat class, the method >>>> getAfterGcUsage returned this.beforeGCUsage instead of >>>> this.afterGcUsage >>>> - When going through all the code I did some minor clean up that >>>> should not impact the program flow: >>>> * removed unused imports. >>>> * inlined temporary variables holding messages. >>>> * removed private member variables that were not accessed. >>>> * removed private methods that were not referenced. >>>> * removed local variables that were not used. >>>> * added generic types where needed. >>>> * static methods are now called statically. >>>> * added suppress serialization warning where it was needed. >>>> * removed suppress serialization annotation where it was not needed. >>>> - In the Message class, the comment "remove? not found in code" >>>> will be removed once I know those message are not needed for 7u6. >>>> >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120522/1a50514c/attachment-0001.html From michael.fang at oracle.com Tue May 22 12:58:34 2012 From: michael.fang at oracle.com (Michael Fang) Date: Tue, 22 May 2012 12:58:34 -0700 Subject: RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team In-Reply-To: <4FBA2477.7040101@oracle.com> References: <4FAD23E4.90501@oracle.com> <4FAD3B63.8070501@oracle.com> <4FBA2477.7040101@oracle.com> Message-ID: <4FBBEFEA.9050601@oracle.com> Thanks Erik. I have already downloaded the raw message.properties file from the webrev on 5/16 to proceed with the 7u6 translation. I performed a diff with current webrev, and it consists of mostly deleted resources and 1 renamed key CONNECTION_LOST1 => CONNECTION_LOST. I am fine with the changes from l10n perspective. thanks, -michael On 12?05?21? 04:18 ??, Erik Gahlin wrote: > Thanks Michael, > > When it comes to ALL CAPs or SturdlyCaps, it's okay if those strings > are not translated. > > Here is an updated webrev. I removed strings that were no longer in > use and made some changes to the make-files. > > http://cr.openjdk.java.net/~egahlin/7017818_4/ > > /E > > Michael Fang skrev 2012-05-11 18:16: >> Thanks so much Erik for the fix! The messages.properties file look >> good. I only reviewed the English *messages.properties* file. WPTG >> will re-translate the ja and zh_CN files. They will attempt to >> leverage existing translation from *JConsoleResources_xx.java*. >> >> I have a comments about another translatability rule that WPTG follows: >> >> By Oracle software development guideline, ALL CAPs or StudlyCaps >> strings will not be translated. Examples are: >> 19 ACTION_CAPITALIZED=ACTION >> 20 ACTION_INFO_CAPITALIZED=ACTION_INFO >> 149 MBEAN_INFO=MBeanInfo >> 150 MBEAN_NOTIFICATION_INFO=MBeanNotificationInfo >> 151 MBEAN_OPERATION_INFO=MBeanOperationInfo >> 206 OBJECT_NAME=ObjectName >> 231 R_FORWARD_SLASH_W_CAPITALIZED=R/W >> >> 241 SEQ_NUM=SeqNum >> 249 SUMMARY_TAB_HEADER_DATE_TIME_FORMAT=FULL,FULL >> >> 273 UNKNOWN_CAPITALIZED=UNKNOWN >> >> If any of the above such as ACTION or UNKNOWN needs to be translated, >> they should not be ALL CAPS. The translators will not translate those >> lines by default. >> >> The translators have the ability to see comments (or special >> requests) if a comment line is inserted immediately prior to any of >> the resources (each resource string and one comment line immediately >> before it is stored in translation memory). If you must leave ACTION >> or UNKNOWN in CAPS, you can try to insert comments.However, WPTG does >> not guarantee they will be followed. >> >> thanks, >> >> -michael >> >> On 12?05?11? 07:36 ??, Erik Gahlin wrote: >>> Could you please review? I also need a sponsor. >>> >>> http://cr.openjdk.java.net/~egahlin/7156518/1_0/ >>> >>> http://monaco.us.oracle.com/detail.jsf?cr=7017818 >>> >>> The patch is for JDK8, but it needs to ported to 7u6 before 5/16. >>> >>> Thanks! >>> >>> Erik >>> >>> Changes: >>> >>> - Moved localization messages to property files, one message per >>> line, as needed. >>> - Added '&' to messages so mnemonics could be identified. >>> - Introduced Message class with static fields corresponding to the >>> keys in the property files. >>> - Added map for looking up mnemonics. >>> >>> Testing: >>> >>> - Verified programmatically that all the messages and mnemonics are >>> "compatible" with the previous mechanism, for Chinese, Japanese and >>> the default locale. >>> - The intention is to run through the GUI to confirm that everything >>> looks ok, but I'm waiting for a build. >>> >>> Other: >>> >>> - Fixed a typo in the MemoryPoolStat class, the method >>> getAfterGcUsage returned this.beforeGCUsage instead of >>> this.afterGcUsage >>> - When going through all the code I did some minor clean up that >>> should not impact the program flow: >>> * removed unused imports. >>> * inlined temporary variables holding messages. >>> * removed private member variables that were not accessed. >>> * removed private methods that were not referenced. >>> * removed local variables that were not used. >>> * added generic types where needed. >>> * static methods are now called statically. >>> * added suppress serialization warning where it was needed. >>> * removed suppress serialization annotation where it was not needed. >>> - In the Message class, the comment "remove? not found in code" will >>> be removed once I know those message are not needed for 7u6. >>> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120522/c21fe2bc/attachment.html From mandy.chung at oracle.com Tue May 22 14:49:55 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Tue, 22 May 2012 14:49:55 -0700 Subject: RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team In-Reply-To: <4FBBEB98.50704@oracle.com> References: <4FAD23E4.90501@oracle.com> <4FAD3B63.8070501@oracle.com> <4FBA2477.7040101@oracle.com> <4FBAAFEA.6090305@oracle.com> <4FBBEB98.50704@oracle.com> Message-ID: <4FBC0A03.2000906@oracle.com> Erik, I approve what you have - please go through and fix the formatting nits. I inlined my comment below and you can follow up them later if needed. On 5/22/2012 12:40 PM, Erik Gahlin wrote: > Thanks for reviewing, > > I got a lot of unused import warnings from the IDE when I changed the > Resources class. When I cleaned them up I thought I might as well > clean up the > others too, so I could more easily see that I had taken care of all the > warnings I caused. Same thing with unused member variables and unused > methods. > > Import-statements will not change how the program executes, so I > thought it > was safe to remove them (no risk of introducing new bugs). > > ... >> Anyway, >> the warning cleanup deserves a separate CR and review. > Breaking it up into seperate patches and CRs will take time. Is it really > necessary? I'm okay for this patch to include the removal of unused imports and dead code fixes. The warnings I referred to are the @SuppressedWarnings("serial") and rawtypes changes since it may require a separate pair of eyes to review them. As a general advice, when the number of warnings cleaned up is not small, it's always recommended to separate them as two separate CRs for bug management and backport and it also helps the reviewers :) Since you have made the change along with the fix for this CR, I can understand why you said it will take time. I also understand that you're under a time pressure. I can go with what you have but please consider in the future when to separate the change in a separate CR. > > I cleaned up the code so I could make the fix more easily. I don't > think it's > worth the hazzle to create a separate bug and patch. I might as well > revert > the clean ups. > BTW, backporting to an update release might request not to include the warnings cleanup. I'm not sure the putback approval requirements for 7u6. >> >> Below are comments on the change to support translateability. >> >> sun/tools/jconsole/resources/Messages.java >> I suggest to move Messages to sun.tools.jconsole since >> it's a utility class and conventionally resources are put >> in a "resources" subpackage (i.e. sun.tools.jconsole.resources >> in this case). > I think one package private Message class for each package and separate > resource files for each package would be the best, but I didn't want > this CR to blow up, so I put the Message class where the other Java > classes > related to resources were before. > > I can move it to sun.tools.jconsole, if you think that's better. > I think so so that sun.tools.jconsole.resources.* are resource files. >> >> The initializeMessage method uses the field name as the >> key and initializes its value to its localized message via >> reflection. Such approach seems strange. > I like to enforce one-to-one mapping between the keys in the property > file and > the keys used in the Java code. When going through the fields in the > Message > class, using reflection, I can ensure that all fields have a corresponding > property value in the file, and vice versa. > > With this approrach it's not necessary click through all the GUI to > verify that > all keys exists in the property file. It's also possible to detect if > a value > in a property file is no longer in use. > > The code that does the one-to-one check was removed, but it should > probably be > added back so similar problems can be catched automatically in the future. > >> >> Have you considered about defining the constants with >> the key as the value (i.e. the variable name and its >> value are the same). > The Java constants can't be the same as the property value I meant the key value in messages.properties (not the property value). Essentially variable and the value is the same e.g. static final String ONE_DAY = "ONE_DAY"; >> Instead of initializing each >> static field of the Messages class, you can build >> a map of a key to the localized message + itsmnemonic >> key (like what you have done in building the MNEMONIC_LOOKUP >> map - why not change such hash map to map from a string to >> an object {message+mnemonic}). In that case, the MNEMONIC_LOOKUP >> doesn't need to be a synchronized map and could be done >> as the class initialization of Resources class. >> >> It would only need to keep >> Resources.getText(String) method that returns the localized >> message, e.g. >> Resources.getText(Messages.HELP_ABOUT_DIALOG_TITLE) >> >> I just don't see it's worth the complexity to initialize >> the static fields via reflection to get rid of a convenience >> method. > > The synchronization is not really needed, if you always use the keys to > lookup the messages. The static initializer in the Message class should > ensure correct ordering. > > Looking up messages "dynamically" means you have to trigger all the > code in the GUI that needs a translated message to be sure you got things > correct. Since there are several hundred messages I think the > static-fields-reflection approach is better. > >> >> >> It is only my suggestion and I understand that this fix needs >> to be backport to 7u6. If you agree that replacing this >> static field initialization logic with a separate map, >> I'm okay with pushing this approach to 7u6 and push >> a better fix to jdk8. Or I miss the benefit you were >> considering :) > > You are missing it :) > > .. and it's probably because I removed the code that did the actual > check :) > I agree that checking one-to-one mapping between the keys in the property file and the keys used in the Java code is good. What you need is to compare the list of constants with the keys in messages.properties. Anyway, my suggestion was just to simplify such initialization. You can go with what you have. // >> >> There are a few names with '_' suffix e.g. L93, 97, 104, 160 >> and also some names with '__' (L97, 159). Do you want to >> embed the space of the message in the key name? In any case, >> the key names with '_' suffix or double underscores '__' is >> a little confusing. It would be better just to use '_' for >> separating words of a key name and no need for '_' suffix. >> The names 'CHART_COLON', 'ERROR_COLON_MBEANS...', 'JCONSOLE_COLON', >> and the ones with 'COLON' to describe its message with ":" >> are strange. If ":" was removed from the message in the >> future, the name would need to be modified to follow this >> naming convention which is overkill. > The keys were generated programmatically. > Ah - that's what I guess. > The 'COLON' was needed so I could differentiate between message that > looked > the same, except for the ':' at the end. The pattern was applied to all > messages. Some of those message were removed (since they were no > longer in use) > > I can remove the 'COLON' suffix where it's not needed, same thing > with spaces. > That'd be good since "COLON" and '_' is meaningless w.r.t. the key name. IDE refactoring feature should make this renaming effortless :) > I will go over the message keys and clean up the names, but they were > not that > clean before either :) Thanks. Mandy -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120522/ce4e4f4b/attachment-0001.html From yumin.qi at oracle.com Tue May 22 17:50:38 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Tue, 22 May 2012 17:50:38 -0700 Subject: request for codereview, bug 7149528: easy usage of serviceability agent In-Reply-To: <2DC2B513-1692-487E-82C7-ED0CE00332FD@oracle.com> References: <4FAD8922.9010902@oracle.com> <2DC2B513-1692-487E-82C7-ED0CE00332FD@oracle.com> Message-ID: <4FBC345E.4030200@oracle.com> HI, Second version based on suggestion by Staffan L. http://cr.openjdk.java.net/~minqi/7149528/webrev.1 Thanks Yumin On 2012/5/22 4:39, Staffan Larsen wrote: > Yumin, > > Thanks for doing this! > > I still wonder if we should support -startsvr in the new launcher, given that we already have a jsadebugd launcher that does exactly that. I don't like having two ways of doing the same thing that we have to support. Either we have jsadebugd or we have "jsa -startsvr", but I think it will be a lot of work to remove jsadebugd so it's simpler to leave it and remove the -startsvr flag. > > I think the usage instructions could be made easier to read by splitting them on multiple lines for the "live process" case and the "core" case. See the output from jsadebugd for an example. It would also be good if these two tools used the same terminology. > > A couple of nits for SAMain: > * the case statements do not need parentheses around the value: "case (0):" should be "case 0:" > * line 35: missing space before { > * line 37: missing space after the if > * line 37: always use {} and newlines after if > * line 42& 43: I prefer having the method implementation on a new line after the declaration > > Thanks, > /Staffan > > > > On 11 maj 2012, at 23:48, Yumin Qi wrote: > >> Hi, all >> >> Can I have your codereview for bug 7149528: easy usage of serviceability agent. >> Problems 1) for launching Serviceability Agent(SA) is that it needs setting several environmental variables for class path, library path options. It is not easy for user to become familiar with those settings. 2) SA launched from java and attached to java process (or the binary which loaded JVM). On MacOS, attaching to process needs permission. If we grant access for SA, we have to grant all java processes have the same access permission so brings security concern on the platform since java is too generic for doing so. With a separate SA launcher, giving it permission attaching to java process solves the concern. >> >> the change for both hotspot and jdk: >> http://cr.openjdk.java.net/~minqi/7149528 >> >> Thanks >> Yumin From mark at klomp.org Wed May 23 00:20:08 2012 From: mark at klomp.org (Mark Wielaard) Date: Wed, 23 May 2012 09:20:08 +0200 Subject: CCC (Was: request for codereview, bug 7149528: easy usage of serviceability agent) In-Reply-To: <4FBBD951.1040302@oracle.com> References: <4FAD8922.9010902@oracle.com> <2DC2B513-1692-487E-82C7-ED0CE00332FD@oracle.com> <4FBBD00B.8080609@oracle.com> <4FBBD951.1040302@oracle.com> Message-ID: <20120523072008.GA4569@toonder.wildebeest.org> Hi Joe, On Tue, May 22, 2012 at 11:22:09AM -0700, Joe Darcy wrote: > This state > model is explained in the "process" link at the top of every ccc > page and was additionally explained in a tech talk I gave earlier > this year: > > http://j2se.us.oracle.com/web/pub/PrgMgmt/TechTalks/ccc-and-you.pdf > > Please do not blame excessive wait times on the ccc process when the > ccc is not being used as documented It looks like that site isn't publicly reachable. Could you put the document somewhere on openjdk.java.net or another more public place? I recently got a question about submitting a CCC request in response to one of my patches, but found very little documentation. Thanks, Mark From weijun.wang at oracle.com Wed May 23 00:52:32 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Wed, 23 May 2012 07:52:32 +0000 Subject: hg: jdk8/tl/jdk: 7162687: enhance KDC server availability detection Message-ID: <20120523075252.C982747490@hg.openjdk.java.net> Changeset: a2fc04c2dfc8 Author: weijun Date: 2012-05-23 15:51 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a2fc04c2dfc8 7162687: enhance KDC server availability detection Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/KdcComm.java ! src/share/classes/sun/security/krb5/internal/NetClient.java ! test/ProblemList.txt ! test/sun/security/krb5/auto/BadKdc.java ! test/sun/security/krb5/auto/MaxRetries.java ! test/sun/security/krb5/auto/TcpTimeout.java + test/sun/security/krb5/auto/Unreachable.java + test/sun/security/krb5/auto/unreachable.krb5.conf From serguei.spitsyn at oracle.com Wed May 23 02:52:43 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 23 May 2012 02:52:43 -0700 Subject: CCC (Was: request for codereview, bug 7149528: easy usage of serviceability agent) In-Reply-To: <20120523072008.GA4569@toonder.wildebeest.org> References: <4FAD8922.9010902@oracle.com> <2DC2B513-1692-487E-82C7-ED0CE00332FD@oracle.com> <4FBBD00B.8080609@oracle.com> <4FBBD951.1040302@oracle.com> <20120523072008.GA4569@toonder.wildebeest.org> Message-ID: <4FBCB36B.8040209@oracle.com> Hi Joe, In fact, we have the following question: Q1: Do we have to submit a CCC request to enable the HotSpot DTrace probes on Linux? The following is not completely clear to me: Q2: Do we go through the CCC process when some interfaces are already enabled on one platform and we want to enable on another? My guess is that the answers must be positive but wanted to double-check. Thanks, Serguei On 5/23/12 12:20 AM, Mark Wielaard wrote: > Hi Joe, > > On Tue, May 22, 2012 at 11:22:09AM -0700, Joe Darcy wrote: >> This state >> model is explained in the "process" link at the top of every ccc >> page and was additionally explained in a tech talk I gave earlier >> this year: >> >> http://j2se.us.oracle.com/web/pub/PrgMgmt/TechTalks/ccc-and-you.pdf >> >> Please do not blame excessive wait times on the ccc process when the >> ccc is not being used as documented > It looks like that site isn't publicly reachable. Could you put the > document somewhere on openjdk.java.net or another more public place? > I recently got a question about submitting a CCC request in response > to one of my patches, but found very little documentation. > > Thanks, > > Mark -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/4e62f73a/attachment.html From staffan.larsen at oracle.com Wed May 23 03:17:08 2012 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Wed, 23 May 2012 10:17:08 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7161732: Improve handling of thread_id in OSThread Message-ID: <20120523101715.5F76147492@hg.openjdk.java.net> Changeset: 960a442eae91 Author: rbackman Date: 2012-05-22 10:11 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/960a442eae91 7161732: Improve handling of thread_id in OSThread Reviewed-by: dholmes, kamg ! src/os/bsd/vm/osThread_bsd.hpp ! src/os/linux/vm/osThread_linux.hpp ! src/os/solaris/vm/osThread_solaris.hpp ! src/os/windows/vm/osThread_windows.hpp ! src/os_cpu/bsd_x86/vm/vmStructs_bsd_x86.hpp ! src/os_cpu/linux_sparc/vm/vmStructs_linux_sparc.hpp ! src/os_cpu/linux_x86/vm/vmStructs_linux_x86.hpp ! src/os_cpu/solaris_sparc/vm/vmStructs_solaris_sparc.hpp ! src/os_cpu/solaris_x86/vm/vmStructs_solaris_x86.hpp ! src/os_cpu/windows_x86/vm/vmStructs_windows_x86.hpp ! src/share/vm/runtime/osThread.hpp From serguei.spitsyn at oracle.com Wed May 23 03:19:51 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 23 May 2012 03:19:51 -0700 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBB3555.2080607@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> Message-ID: <4FBCB9C7.3000304@oracle.com> I've generated the webrev (sorry it is not on the public domain yet): http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/DTrace-Probes-Linux-HS.0/ Below is the patch related to the webrev above. Thanks, Serguei diff -r 4b37c0dafe3a make/linux/makefiles/dtrace.make --- a/make/linux/makefiles/dtrace.make Fri May 18 09:15:15 2012 -0700 +++ b/make/linux/makefiles/dtrace.make Wed May 23 03:03:58 2012 -0700 @@ -1,5 +1,6 @@ # # Copyright (c) 2005, 2008, Oracle and/or its affiliates. All rights reserved. +# Copyright (c) 2012 Red Hat, Inc. # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. # # This code is free software; you can redistribute it and/or modify it @@ -25,3 +26,26 @@ # Linux does not build jvm_db LIBJVM_DB = +# But it does have a SystemTap dtrace compatible sys/sdt.h +ifneq ($(ALT_SDT_H),) + SDT_H_FILE = $(ALT_SDT_H) +else + SDT_H_FILE = /usr/include/sys/sdt.h +endif +DTRACE_ENABLED = $(shell test -f $(SDT_H_FILE)&& echo $(SDT_H_FILE)) + +ifneq ($(DTRACE_ENABLED),) + CFLAGS += -DDTRACE_ENABLED +endif + +# Phone target used in vm.make build target to check whether enabled. +.PHONY: dtraceCheck +ifeq ($(DTRACE_ENABLED),) +dtraceCheck: + $(QUIETLY) echo "**NOTICE** Dtrace support disabled $(SDT_H_FILE) not found" +else +dtraceCheck: +endif + +# It doesn't support HAVE_DTRACE_H though. + diff -r 4b37c0dafe3a make/linux/makefiles/vm.make --- a/make/linux/makefiles/vm.make Fri May 18 09:15:15 2012 -0700 +++ b/make/linux/makefiles/vm.make Wed May 23 03:03:58 2012 -0700 @@ -383,7 +383,7 @@ #---------------------------------------------------------------------- -build: $(LIBJVM) $(LAUNCHER) $(LIBJSIG) $(LIBJVM_DB) $(BUILDLIBSAPROC) $(WB_JAR) +build: $(LIBJVM) $(LAUNCHER) $(LIBJSIG) $(LIBJVM_DB) $(BUILDLIBSAPROC) dtraceCheck $(WB_JAR) install: install_jvm install_jsig install_saproc diff -r 4b37c0dafe3a src/share/vm/prims/jni.cpp --- a/src/share/vm/prims/jni.cpp Fri May 18 09:15:15 2012 -0700 +++ b/src/share/vm/prims/jni.cpp Wed May 23 03:03:58 2012 -0700 @@ -1,5 +1,6 @@ /* * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012 Red Hat, Inc. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -2818,10 +2819,8 @@ JNI_QUICK_ENTRY(void, jni_Set##Result##Field(JNIEnv *env, jobject obj, jfieldID fieldID, Argument value)) \ JNIWrapper("Set" XSTR(Result) "Field"); \ \ - HS_DTRACE_PROBE_CDECL_N(hotspot_jni, Set##Result##Field__entry, \ - ( JNIEnv*, jobject, jfieldID FP_SELECT_##Result(COMMA Argument,/*empty*/) ) ); \ - HS_DTRACE_PROBE_N(hotspot_jni, Set##Result##Field__entry, \ - ( env, obj, fieldID FP_SELECT_##Result(COMMA value,/*empty*/) ) ); \ + FP_SELECT_##Result(DTRACE_PROBE4(hotspot_jni, Set##Result##Field__entry, env, obj, fieldID, value), \ + DTRACE_PROBE3(hotspot_jni, Set##Result##Field__entry, env, obj, fieldID)); \ \ oop o = JNIHandles::resolve_non_null(obj); \ klassOop k = o->klass(); \ @@ -3128,10 +3127,8 @@ \ JNI_ENTRY(void, jni_SetStatic##Result##Field(JNIEnv *env, jclass clazz, jfieldID fieldID, Argument value)) \ JNIWrapper("SetStatic" XSTR(Result) "Field"); \ - HS_DTRACE_PROBE_CDECL_N(hotspot_jni, SetStatic##Result##Field__entry,\ - ( JNIEnv*, jclass, jfieldID FP_SELECT_##Result(COMMA Argument,/*empty*/) ) ); \ - HS_DTRACE_PROBE_N(hotspot_jni, SetStatic##Result##Field__entry, \ - ( env, clazz, fieldID FP_SELECT_##Result(COMMA value,/*empty*/) ) ); \ + FP_SELECT_##Result(DTRACE_PROBE4(hotspot_jni, SetStatic##Result##Field__entry, env, clazz, fieldID, value), \ + DTRACE_PROBE3(hotspot_jni, SetStatic##Result##Field__entry, env, clazz, fieldID)); \ \ JNIid* id = jfieldIDWorkaround::from_static_jfieldID(fieldID); \ assert(id->is_static_field_id(), "invalid static field id"); \ diff -r 4b37c0dafe3a src/share/vm/utilities/dtrace.hpp --- a/src/share/vm/utilities/dtrace.hpp Fri May 18 09:15:15 2012 -0700 +++ b/src/share/vm/utilities/dtrace.hpp Wed May 23 03:03:58 2012 -0700 @@ -1,5 +1,6 @@ /* * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2009, 2012 Red Hat, Inc. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -32,12 +33,15 @@ #define DTRACE_ONLY(x) x #define NOT_DTRACE(x) +#if defined(SOLARIS) // Work around dtrace tail call bug 6672627 until it is fixed in solaris 10. #define HS_DTRACE_WORKAROUND_TAIL_CALL_BUG() \ do { volatile size_t dtrace_workaround_tail_call_bug = 1; } while (0) -#if defined(SOLARIS) #define USDT1 1 +#elif defined(LINUX) +#define USDT1 1 +#define HS_DTRACE_WORKAROUND_TAIL_CALL_BUG() #elif defined(__APPLE__) #define USDT2 1 #include @@ -63,6 +67,11 @@ #define DTRACE_PROBE3(a,b,c,d,e) {;} #define DTRACE_PROBE4(a,b,c,d,e,f) {;} #define DTRACE_PROBE5(a,b,c,d,e,f,g) {;} +#define DTRACE_PROBE6(a,b,c,d,e,f,g,h) {;} +#define DTRACE_PROBE7(a,b,c,d,e,f,g,h,i) {;} +#define DTRACE_PROBE8(a,b,c,d,e,f,g,h,i,j) {;} +#define DTRACE_PROBE9(a,b,c,d,e,f,g,h,i,j,k) {;} +#define DTRACE_PROBE10(a,b,c,d,e,f,g,h,i,j,k,l) {;} #else /* USDT2 */ @@ -76,10 +85,19 @@ #define HS_DTRACE_PROBE_FN(provider,name)\ __dtrace_##provider##___##name +#ifdef SOLARIS +// Solaris dtrace needs actual extern function decls. #define HS_DTRACE_PROBE_DECL_N(provider,name,args) \ DTRACE_ONLY(extern "C" void HS_DTRACE_PROBE_FN(provider,name) args) #define HS_DTRACE_PROBE_CDECL_N(provider,name,args) \ DTRACE_ONLY(extern void HS_DTRACE_PROBE_FN(provider,name) args) +#elif defined(LINUX) +// Systemtap dtrace compatible probes on GNU/Linux don't. +#define HS_DTRACE_PROBE_DECL_N(provider,name,args) +#define HS_DTRACE_PROBE_CDECL_N(provider,name,args) +#else +#error "USDT1 enabled for unknown os" +#endif /* Dtrace probe declarations */ #define HS_DTRACE_PROBE_DECL(provider,name) \ @@ -118,6 +136,8 @@ uintptr_t,uintptr_t,uintptr_t)) /* Dtrace probe definitions */ +#if defined(SOLARIS) +// Solaris dtrace uses actual function calls. #define HS_DTRACE_PROBE_N(provider,name, args) \ DTRACE_ONLY(HS_DTRACE_PROBE_FN(provider,name) args) @@ -153,6 +173,34 @@ HS_DTRACE_PROBE_N(provider,name,((uintptr_t)a0,(uintptr_t)a1,(uintptr_t)a2,\ (uintptr_t)a3,(uintptr_t)a4,(uintptr_t)a5,(uintptr_t)a6,(uintptr_t)a7,\ (uintptr_t)a8,(uintptr_t)a9)) +#elif defined(LINUX) +// Systemtap dtrace compatible probes on GNU/Linux use direct macros. +#define HS_DTRACE_PROBE(provider,name) HS_DTRACE_PROBE0(provider,name) +#define HS_DTRACE_PROBE0(provider,name)\ + DTRACE_PROBE(provider,name) +#define HS_DTRACE_PROBE1(provider,name,a0)\ + DTRACE_PROBE1(provider,name,a0) +#define HS_DTRACE_PROBE2(provider,name,a0,a1)\ + DTRACE_PROBE2(provider,name,a0,a1) +#define HS_DTRACE_PROBE3(provider,name,a0,a1,a2)\ + DTRACE_PROBE3(provider,name,a0,a1,a2) +#define HS_DTRACE_PROBE4(provider,name,a0,a1,a2,a3)\ + DTRACE_PROBE4(provider,name,a0,a1,a2,a3) +#define HS_DTRACE_PROBE5(provider,name,a0,a1,a2,a3,a4)\ + DTRACE_PROBE5(provider,name,a0,a1,a2,a3,a4) +#define HS_DTRACE_PROBE6(provider,name,a0,a1,a2,a3,a4,a5)\ + DTRACE_PROBE6(provider,name,a0,a1,a2,a3,a4,a5) +#define HS_DTRACE_PROBE7(provider,name,a0,a1,a2,a3,a4,a5,a6)\ + DTRACE_PROBE7(provider,name,a0,a1,a2,a3,a4,a5,a6) +#define HS_DTRACE_PROBE8(provider,name,a0,a1,a2,a3,a4,a5,a6,a7)\ + DTRACE_PROBE8(provider,name,a0,a1,a2,a3,a4,a5,a6,a7) +#define HS_DTRACE_PROBE9(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8)\ + DTRACE_PROBE9(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8) +#define HS_DTRACE_PROBE10(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8)\ + DTRACE_PROBE10(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8) +#else +#error "USDT1 enabled for unknown os" +#endif #endif /* !USDT2 */ On 5/21/12 11:42 PM, serguei.spitsyn at oracle.com wrote: > > > > On 5/21/12 9:27 PM, David Holmes wrote: >> Is systemTap part of regular distros these days - in particular in >> our build environment? >> > I don't know yet, we have to figure it out. > It'd be nice to have a Keith's opinion first. > >> I'm just wondering who is going to ensure that these probe entries >> compile and run correctly? > > It depends on the availability or possible setup of linux machines > with the systemTap. > Some test is needed as well. > >> >> Can we see a complete webrev of the proposed changes? > > I'll prepare a complete webrev. > > Thanks, > Serguei > >> >> Thanks, >> David >> >> On 22/05/2012 1:28 PM, serguei.spitsyn at oracle.com wrote: >>> Mark, >>> >>> I've created new RFE: >>> 7170638: enable support for dtrace compatible sdt probes on GNU/Linux >>> >>> The patches look good. >>> But I think, it is better to be reviewed by Keith McGuigan, who >>> originally added DTrace probes to HotSpot. >>> Also, let's check if we have to submit a CCC request for this. >>> >>> Keith, do you have cycles to review the patches from Mark? >>> I've included them into the bug report. >>> >>> Thanks, >>> Serguei >>> >>> >>> On 5/21/12 2:28 AM, Mark Wielaard wrote: >>>> On Thu, 2012-05-17 at 23:30 -0700,serguei.spitsyn at oracle.com wrote: >>>>> On 18/05/2012 9:47 AM,serguei.spitsyn at oracle.com wrote: >>>>> On 5/17/12 9:48 PM, David Holmes wrote: >>>>>>> Where are the patches? >>>>>>> I do not see them in your emails. >>>>>>> >>>>>> The patches themselves are the emails with the subjects: >>>>>> >>>>>> [PATCH 1 of 3] ... >>>>>> [PATCH 2 of 3] ... >>>>>> [PATCH 3 of 3] ... >>>>>> >>>>> I've found these emails, they somehow got to the trash folder - very >>>>> strange. >>>> Apologies. That is how hg email sends them. I have a local mercurial >>>> repository that contain the patches. Maybe your spam filter caught it >>>> because all subjects start with XXXXXX as placeholder because I don't >>>> have official bug numbers for them. If you could create the bugs >>>> and/or >>>> let me know if you rather see these patches split up differently >>>> (or not >>>> split up at all), please let me know and I rebase my patches and >>>> resend >>>> them. >>>> >>>>>>> On 5/17/12 12:25 PM, Mark Wielaard wrote: >>>>>>>> On Mon, May 14, 2012 at 07:41:50AM -0600, Daniel D. Daugherty >>>>>>>> wrote: >>>>>>>>> On 5/14/12 2:06 AM, Mark Wielaard wrote: >>>>>>>>>> On Thu, 2012-05-10 at 09:52 -0600, Daniel D. Daugherty >>>>>>>>>> wrote: >>>>>>>>>>> Addingserviceability-dev at openjdk.java.net to this e-mail >>>>>>>>>>> thread. >>>>>>>>>> Thanks. Please let me know if there is anything I can do to >>>>>>>>>> help >>>>>>>>>> integration of these patches, or if there are other >>>>>>>>>> places/people I need >>>>>>>>>> to add to the CC for review. >>>>>>>>> No problem. I was just making sure your e-mails got to the >>>>>>>>> right aliases. >>>>>>>>> As I no longer work on the Serviceability team, I'll leave it >>>>>>>>> to them to >>>>>>>>> address your e-mails. >>>>>>>> Feedback from the Serviceability team is highly appreciated. >>>>>>>> Please let >>>>>>>> me know how I can help getting these patches in as soon as >>>>>>>> possible. >>>>>>>>>>> On 5/10/12 7:49 AM, Mark Wielaard wrote: >>>>>>>>>>>> The following three patches enable support for dtrace >>>>>>>>>>>> compatible sdt probes >>>>>>>>>>>> on GNU/Linux. Most of the support was already submitted >>>>>>>>>>>> earlier. These are >>>>>>>>>>>> just the last three things left in IcedTea that actually >>>>>>>>>>>> enable it in >>>>>>>>>>>> hotspot. It has been in production use for some time >>>>>>>>>>>> already. >>>>>>>>>>>> >>>>>>>>>>>> The patches could be applied all as one, or individually >>>>>>>>>>>> if you want to be >>>>>>>>>>>> able to test them independently. >>>>>>>>>> [... explanation of separate patches removed ...] >>>>>>>>>>>> Patches in separate emails. >>> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/b24173ca/attachment-0001.html From keith.mcguigan at oracle.com Wed May 23 06:14:24 2012 From: keith.mcguigan at oracle.com (Keith McGuigan) Date: Wed, 23 May 2012 09:14:24 -0400 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBCB9C7.3000304@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> <4FBCB9C7.3000304@oracle.com> Message-ID: <4FBCE2B0.3050201@oracle.com> Just a couple of quick comments/questions on the code: Why did we get rid of a couple of the declarations in jni.cpp? Why aren't they needed? dtrace.hpp should be refactored (if possible) into the os-specific subdirectories, instead of using #ifdef macros in the header. I.e., you might have to make a src/solaris/vm/dtrace_solaris.hpp and src/linux/vm/dtrace_linux.hpp file and include it from here. Has this been built on solaris, and is the dtrace functionality unchanged? -- - Keith On 5/23/2012 6:19 AM, serguei.spitsyn at oracle.com wrote: > > I've generated the webrev (sorry it is not on the public domain yet): > http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/DTrace-Probes-Linux-HS.0/ > > Below is the patch related to the webrev above. > > Thanks, > Serguei > > > diff -r 4b37c0dafe3a make/linux/makefiles/dtrace.make > --- a/make/linux/makefiles/dtrace.make Fri May 18 09:15:15 2012 -0700 > +++ b/make/linux/makefiles/dtrace.make Wed May 23 03:03:58 2012 -0700 > @@ -1,5 +1,6 @@ > # > # Copyright (c) 2005, 2008, Oracle and/or its affiliates. All rights > reserved. > +# Copyright (c) 2012 Red Hat, Inc. > # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > # > # This code is free software; you can redistribute it and/or modify it > @@ -25,3 +26,26 @@ > # Linux does not build jvm_db > LIBJVM_DB = > > +# But it does have a SystemTap dtrace compatible sys/sdt.h > +ifneq ($(ALT_SDT_H),) > + SDT_H_FILE = $(ALT_SDT_H) > +else > + SDT_H_FILE = /usr/include/sys/sdt.h > +endif > +DTRACE_ENABLED = $(shell test -f $(SDT_H_FILE)&& echo $(SDT_H_FILE)) > + > +ifneq ($(DTRACE_ENABLED),) > + CFLAGS += -DDTRACE_ENABLED > +endif > + > +# Phone target used in vm.make build target to check whether enabled. > +.PHONY: dtraceCheck > +ifeq ($(DTRACE_ENABLED),) > +dtraceCheck: > + $(QUIETLY) echo "**NOTICE** Dtrace support disabled $(SDT_H_FILE) > not found" > +else > +dtraceCheck: > +endif > + > +# It doesn't support HAVE_DTRACE_H though. > + > diff -r 4b37c0dafe3a make/linux/makefiles/vm.make > --- a/make/linux/makefiles/vm.make Fri May 18 09:15:15 2012 -0700 > +++ b/make/linux/makefiles/vm.make Wed May 23 03:03:58 2012 -0700 > @@ -383,7 +383,7 @@ > > #---------------------------------------------------------------------- > > -build: $(LIBJVM) $(LAUNCHER) $(LIBJSIG) $(LIBJVM_DB) $(BUILDLIBSAPROC) > $(WB_JAR) > +build: $(LIBJVM) $(LAUNCHER) $(LIBJSIG) $(LIBJVM_DB) $(BUILDLIBSAPROC) > dtraceCheck $(WB_JAR) > > install: install_jvm install_jsig install_saproc > > diff -r 4b37c0dafe3a src/share/vm/prims/jni.cpp > --- a/src/share/vm/prims/jni.cpp Fri May 18 09:15:15 2012 -0700 > +++ b/src/share/vm/prims/jni.cpp Wed May 23 03:03:58 2012 -0700 > @@ -1,5 +1,6 @@ > /* > * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2012 Red Hat, Inc. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -2818,10 +2819,8 @@ > JNI_QUICK_ENTRY(void, jni_Set##Result##Field(JNIEnv *env, jobject obj, > jfieldID fieldID, Argument value)) \ > JNIWrapper("Set" XSTR(Result) "Field"); \ > \ > - HS_DTRACE_PROBE_CDECL_N(hotspot_jni, Set##Result##Field__entry, \ > - ( JNIEnv*, jobject, jfieldID FP_SELECT_##Result(COMMA > Argument,/*empty*/) ) ); \ > - HS_DTRACE_PROBE_N(hotspot_jni, Set##Result##Field__entry, \ > - ( env, obj, fieldID FP_SELECT_##Result(COMMA value,/*empty*/) ) ); \ > + FP_SELECT_##Result(DTRACE_PROBE4(hotspot_jni, > Set##Result##Field__entry, env, obj, fieldID, value), \ > + DTRACE_PROBE3(hotspot_jni, > Set##Result##Field__entry, env, obj, fieldID)); \ > \ > oop o = JNIHandles::resolve_non_null(obj); \ > klassOop k = o->klass(); \ > @@ -3128,10 +3127,8 @@ > \ > JNI_ENTRY(void, jni_SetStatic##Result##Field(JNIEnv *env, jclass > clazz, jfieldID fieldID, Argument value)) \ > JNIWrapper("SetStatic" XSTR(Result) "Field"); \ > - HS_DTRACE_PROBE_CDECL_N(hotspot_jni, SetStatic##Result##Field__entry,\ > - ( JNIEnv*, jclass, jfieldID FP_SELECT_##Result(COMMA > Argument,/*empty*/) ) ); \ > - HS_DTRACE_PROBE_N(hotspot_jni, SetStatic##Result##Field__entry, \ > - ( env, clazz, fieldID FP_SELECT_##Result(COMMA value,/*empty*/) ) ); \ > + FP_SELECT_##Result(DTRACE_PROBE4(hotspot_jni, > SetStatic##Result##Field__entry, env, clazz, fieldID, value), \ > + DTRACE_PROBE3(hotspot_jni, > SetStatic##Result##Field__entry, env, clazz, fieldID)); \ > \ > JNIid* id = jfieldIDWorkaround::from_static_jfieldID(fieldID); \ > assert(id->is_static_field_id(), "invalid static field id"); \ > diff -r 4b37c0dafe3a src/share/vm/utilities/dtrace.hpp > --- a/src/share/vm/utilities/dtrace.hpp Fri May 18 09:15:15 2012 -0700 > +++ b/src/share/vm/utilities/dtrace.hpp Wed May 23 03:03:58 2012 -0700 > @@ -1,5 +1,6 @@ > /* > * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights > reserved. > + * Copyright (c) 2009, 2012 Red Hat, Inc. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > * This code is free software; you can redistribute it and/or modify it > @@ -32,12 +33,15 @@ > #define DTRACE_ONLY(x) x > #define NOT_DTRACE(x) > > +#if defined(SOLARIS) > // Work around dtrace tail call bug 6672627 until it is fixed in > solaris 10. > #define HS_DTRACE_WORKAROUND_TAIL_CALL_BUG() \ > do { volatile size_t dtrace_workaround_tail_call_bug = 1; } while (0) > > -#if defined(SOLARIS) > #define USDT1 1 > +#elif defined(LINUX) > +#define USDT1 1 > +#define HS_DTRACE_WORKAROUND_TAIL_CALL_BUG() > #elif defined(__APPLE__) > #define USDT2 1 > #include > @@ -63,6 +67,11 @@ > #define DTRACE_PROBE3(a,b,c,d,e) {;} > #define DTRACE_PROBE4(a,b,c,d,e,f) {;} > #define DTRACE_PROBE5(a,b,c,d,e,f,g) {;} > +#define DTRACE_PROBE6(a,b,c,d,e,f,g,h) {;} > +#define DTRACE_PROBE7(a,b,c,d,e,f,g,h,i) {;} > +#define DTRACE_PROBE8(a,b,c,d,e,f,g,h,i,j) {;} > +#define DTRACE_PROBE9(a,b,c,d,e,f,g,h,i,j,k) {;} > +#define DTRACE_PROBE10(a,b,c,d,e,f,g,h,i,j,k,l) {;} > > #else /* USDT2 */ > > @@ -76,10 +85,19 @@ > #define HS_DTRACE_PROBE_FN(provider,name)\ > __dtrace_##provider##___##name > > +#ifdef SOLARIS > +// Solaris dtrace needs actual extern function decls. > #define HS_DTRACE_PROBE_DECL_N(provider,name,args) \ > DTRACE_ONLY(extern "C" void HS_DTRACE_PROBE_FN(provider,name) args) > #define HS_DTRACE_PROBE_CDECL_N(provider,name,args) \ > DTRACE_ONLY(extern void HS_DTRACE_PROBE_FN(provider,name) args) > +#elif defined(LINUX) > +// Systemtap dtrace compatible probes on GNU/Linux don't. > +#define HS_DTRACE_PROBE_DECL_N(provider,name,args) > +#define HS_DTRACE_PROBE_CDECL_N(provider,name,args) > +#else > +#error "USDT1 enabled for unknown os" > +#endif > > /* Dtrace probe declarations */ > #define HS_DTRACE_PROBE_DECL(provider,name) \ > @@ -118,6 +136,8 @@ > uintptr_t,uintptr_t,uintptr_t)) > > /* Dtrace probe definitions */ > +#if defined(SOLARIS) > +// Solaris dtrace uses actual function calls. > #define HS_DTRACE_PROBE_N(provider,name, args) \ > DTRACE_ONLY(HS_DTRACE_PROBE_FN(provider,name) args) > > @@ -153,6 +173,34 @@ > > HS_DTRACE_PROBE_N(provider,name,((uintptr_t)a0,(uintptr_t)a1,(uintptr_t)a2,\ > > (uintptr_t)a3,(uintptr_t)a4,(uintptr_t)a5,(uintptr_t)a6,(uintptr_t)a7,\ > (uintptr_t)a8,(uintptr_t)a9)) > +#elif defined(LINUX) > +// Systemtap dtrace compatible probes on GNU/Linux use direct macros. > +#define HS_DTRACE_PROBE(provider,name) HS_DTRACE_PROBE0(provider,name) > +#define HS_DTRACE_PROBE0(provider,name)\ > + DTRACE_PROBE(provider,name) > +#define HS_DTRACE_PROBE1(provider,name,a0)\ > + DTRACE_PROBE1(provider,name,a0) > +#define HS_DTRACE_PROBE2(provider,name,a0,a1)\ > + DTRACE_PROBE2(provider,name,a0,a1) > +#define HS_DTRACE_PROBE3(provider,name,a0,a1,a2)\ > + DTRACE_PROBE3(provider,name,a0,a1,a2) > +#define HS_DTRACE_PROBE4(provider,name,a0,a1,a2,a3)\ > + DTRACE_PROBE4(provider,name,a0,a1,a2,a3) > +#define HS_DTRACE_PROBE5(provider,name,a0,a1,a2,a3,a4)\ > + DTRACE_PROBE5(provider,name,a0,a1,a2,a3,a4) > +#define HS_DTRACE_PROBE6(provider,name,a0,a1,a2,a3,a4,a5)\ > + DTRACE_PROBE6(provider,name,a0,a1,a2,a3,a4,a5) > +#define HS_DTRACE_PROBE7(provider,name,a0,a1,a2,a3,a4,a5,a6)\ > + DTRACE_PROBE7(provider,name,a0,a1,a2,a3,a4,a5,a6) > +#define HS_DTRACE_PROBE8(provider,name,a0,a1,a2,a3,a4,a5,a6,a7)\ > + DTRACE_PROBE8(provider,name,a0,a1,a2,a3,a4,a5,a6,a7) > +#define HS_DTRACE_PROBE9(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8)\ > + DTRACE_PROBE9(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8) > +#define HS_DTRACE_PROBE10(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8)\ > + DTRACE_PROBE10(provider,name,a0,a1,a2,a3,a4,a5,a6,a7,a8) > +#else > +#error "USDT1 enabled for unknown os" > +#endif > > #endif /* !USDT2 */ > > > > > > On 5/21/12 11:42 PM, serguei.spitsyn at oracle.com wrote: >> >> >> >> On 5/21/12 9:27 PM, David Holmes wrote: >>> Is systemTap part of regular distros these days - in particular in >>> our build environment? >>> >> I don't know yet, we have to figure it out. >> It'd be nice to have a Keith's opinion first. >> >>> I'm just wondering who is going to ensure that these probe entries >>> compile and run correctly? >> >> It depends on the availability or possible setup of linux machines >> with the systemTap. >> Some test is needed as well. >> >>> >>> Can we see a complete webrev of the proposed changes? >> >> I'll prepare a complete webrev. >> >> Thanks, >> Serguei >> >>> >>> Thanks, >>> David >>> >>> On 22/05/2012 1:28 PM, serguei.spitsyn at oracle.com wrote: >>>> Mark, >>>> >>>> I've created new RFE: >>>> 7170638: enable support for dtrace compatible sdt probes on GNU/Linux >>>> >>>> The patches look good. >>>> But I think, it is better to be reviewed by Keith McGuigan, who >>>> originally added DTrace probes to HotSpot. >>>> Also, let's check if we have to submit a CCC request for this. >>>> >>>> Keith, do you have cycles to review the patches from Mark? >>>> I've included them into the bug report. >>>> >>>> Thanks, >>>> Serguei >>>> >>>> >>>> On 5/21/12 2:28 AM, Mark Wielaard wrote: >>>>> On Thu, 2012-05-17 at 23:30 -0700,serguei.spitsyn at oracle.com wrote: >>>>>> On 18/05/2012 9:47 AM,serguei.spitsyn at oracle.com wrote: >>>>>> On 5/17/12 9:48 PM, David Holmes wrote: >>>>>>>> Where are the patches? >>>>>>>> I do not see them in your emails. >>>>>>>> >>>>>>> The patches themselves are the emails with the subjects: >>>>>>> >>>>>>> [PATCH 1 of 3] ... >>>>>>> [PATCH 2 of 3] ... >>>>>>> [PATCH 3 of 3] ... >>>>>>> >>>>>> I've found these emails, they somehow got to the trash folder - very >>>>>> strange. >>>>> Apologies. That is how hg email sends them. I have a local mercurial >>>>> repository that contain the patches. Maybe your spam filter caught it >>>>> because all subjects start with XXXXXX as placeholder because I don't >>>>> have official bug numbers for them. If you could create the bugs >>>>> and/or >>>>> let me know if you rather see these patches split up differently >>>>> (or not >>>>> split up at all), please let me know and I rebase my patches and >>>>> resend >>>>> them. >>>>> >>>>>>>> On 5/17/12 12:25 PM, Mark Wielaard wrote: >>>>>>>>> On Mon, May 14, 2012 at 07:41:50AM -0600, Daniel D. Daugherty >>>>>>>>> wrote: >>>>>>>>>> On 5/14/12 2:06 AM, Mark Wielaard wrote: >>>>>>>>>>> On Thu, 2012-05-10 at 09:52 -0600, Daniel D. Daugherty >>>>>>>>>>> wrote: >>>>>>>>>>>> Addingserviceability-dev at openjdk.java.net to this e-mail >>>>>>>>>>>> thread. >>>>>>>>>>> Thanks. Please let me know if there is anything I can do to >>>>>>>>>>> help >>>>>>>>>>> integration of these patches, or if there are other >>>>>>>>>>> places/people I need >>>>>>>>>>> to add to the CC for review. >>>>>>>>>> No problem. I was just making sure your e-mails got to the >>>>>>>>>> right aliases. >>>>>>>>>> As I no longer work on the Serviceability team, I'll leave it >>>>>>>>>> to them to >>>>>>>>>> address your e-mails. >>>>>>>>> Feedback from the Serviceability team is highly appreciated. >>>>>>>>> Please let >>>>>>>>> me know how I can help getting these patches in as soon as >>>>>>>>> possible. >>>>>>>>>>>> On 5/10/12 7:49 AM, Mark Wielaard wrote: >>>>>>>>>>>>> The following three patches enable support for dtrace >>>>>>>>>>>>> compatible sdt probes >>>>>>>>>>>>> on GNU/Linux. Most of the support was already submitted >>>>>>>>>>>>> earlier. These are >>>>>>>>>>>>> just the last three things left in IcedTea that actually >>>>>>>>>>>>> enable it in >>>>>>>>>>>>> hotspot. It has been in production use for some time >>>>>>>>>>>>> already. >>>>>>>>>>>>> >>>>>>>>>>>>> The patches could be applied all as one, or individually >>>>>>>>>>>>> if you want to be >>>>>>>>>>>>> able to test them independently. >>>>>>>>>>> [... explanation of separate patches removed ...] >>>>>>>>>>>>> Patches in separate emails. >>>> >> > From mjw at redhat.com Wed May 23 06:26:15 2012 From: mjw at redhat.com (Mark Wielaard) Date: Wed, 23 May 2012 15:26:15 +0200 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBCE2B0.3050201@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> <4FBCB9C7.3000304@oracle.com> <4FBCE2B0.3050201@oracle.com> Message-ID: <1337779575.3002.6.camel@springer.wildebeest.org> On Wed, 2012-05-23 at 09:14 -0400, Keith McGuigan wrote: > Just a couple of quick comments/questions on the code: > > Why did we get rid of a couple of the declarations in jni.cpp? Why > aren't they needed? Could you say which ones you think we got rid of? It was not my intention to get rid of anything. Maybe you are referring to the first patch? That came with the following description: > The first patch is just a consistency cleanup patch. The JNI Set and > SetStatic Field methods used HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N > directly instead of just using DTRACE_PROBE[N] like all other JNI methods. > This doesn't matter for the Solaris macros, but on GNU/Linux the macros > don't use direct function declarations (which is introduced in the second > patch). > dtrace.hpp should be refactored (if possible) into the os-specific > subdirectories, instead of using #ifdef macros in the header. > I.e., you might have to make a src/solaris/vm/dtrace_solaris.hpp and > src/linux/vm/dtrace_linux.hpp file and include it from here. I rather not, the code should be identical except for two small details between solaris and gnu/linux as the patch shows (and one is just a hack for a solaris tailcall bug). The apple/macos part looks very different and could be split out, but that was already there. > Has this been built on solaris, and is the dtrace functionality unchanged? I don't have access to solaris, the dtrace functionality should of course be unchanged. Thanks, Mark From keith.mcguigan at oracle.com Wed May 23 06:42:04 2012 From: keith.mcguigan at oracle.com (Keith McGuigan) Date: Wed, 23 May 2012 09:42:04 -0400 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <1337779575.3002.6.camel@springer.wildebeest.org> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> <4FBCB9C7.3000304@oracle.com> <4FBCE2B0.3050201@oracle.com> <1337779575.3002.6.camel@springer.wildebeest.org> Message-ID: <4FBCE92C.8010708@oracle.com> On 5/23/2012 9:26 AM, Mark Wielaard wrote: > On Wed, 2012-05-23 at 09:14 -0400, Keith McGuigan wrote: >> Just a couple of quick comments/questions on the code: >> >> Why did we get rid of a couple of the declarations in jni.cpp? Why >> aren't they needed? > > Could you say which ones you think we got rid of? It was not my > intention to get rid of anything. Maybe you are referring to the first > patch? That came with the following description: > >> The first patch is just a consistency cleanup patch. The JNI Set and >> SetStatic Field methods used HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N >> directly instead of just using DTRACE_PROBE[N] like all other JNI methods. >> This doesn't matter for the Solaris macros, but on GNU/Linux the macros >> don't use direct function declarations (which is introduced in the second >> patch). Ok, might be that it's fine. I don't remember if there was a reason that SetStatic was different from the other JNI calls, but it certainly could just have been an omission in refactoring or something. We just need to make sure that it still works (solaris-dtrace-wise). It's certainly better this way! >> dtrace.hpp should be refactored (if possible) into the os-specific >> subdirectories, instead of using #ifdef macros in the header. >> I.e., you might have to make a src/solaris/vm/dtrace_solaris.hpp and >> src/linux/vm/dtrace_linux.hpp file and include it from here. > > I rather not, the code should be identical except for two small details > between solaris and gnu/linux as the patch shows (and one is just a hack > for a solaris tailcall bug). The apple/macos part looks very different > and could be split out, but that was already there. I refer to the redefinition blocks of HS_DTRACE_PROBEx, which I don't consider a small detail (though the solaris tailcall thing certainly is). It's (of course) just a style thing, but traditionally in hotspot we've wanted the os or arch specific code in os or arch specific directories, instead of littering the code with #ifdefs. I know the OSX stuff started violated this some, but I hope we're going to resolve that rather than continue down that path. >> Has this been built on solaris, and is the dtrace functionality unchanged? > > I don't have access to solaris, the dtrace functionality should of > course be unchanged. Understood. We'll just have to make sure that gets done somehow. -- - Keith From mjw at redhat.com Wed May 23 06:56:40 2012 From: mjw at redhat.com (Mark Wielaard) Date: Wed, 23 May 2012 15:56:40 +0200 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBCE92C.8010708@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> <4FBCB9C7.3000304@oracle.com> <4FBCE2B0.3050201@oracle.com> <1337779575.3002.6.camel@springer.wildebeest.org> <4FBCE92C.8010708@oracle.com> Message-ID: <1337781400.3002.17.camel@springer.wildebeest.org> On Wed, 2012-05-23 at 09:42 -0400, Keith McGuigan wrote: > >> The first patch is just a consistency cleanup patch. The JNI Set and > >> SetStatic Field methods used HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N > >> directly instead of just using DTRACE_PROBE[N] like all other JNI methods. > >> This doesn't matter for the Solaris macros, but on GNU/Linux the macros > >> don't use direct function declarations (which is introduced in the second > >> patch). > > Ok, might be that it's fine. I don't remember if there was a reason > that SetStatic was different from the other JNI calls, but it certainly > could just have been an omission in refactoring or something. We just > need to make sure that it still works (solaris-dtrace-wise). It's > certainly better this way! Yeah, that is why I originally split out the patches, so that anything that might potentially impact other architectures could be applied and tested separately. Especially since I don't have access to solaris. > >> dtrace.hpp should be refactored (if possible) into the os-specific > >> subdirectories, instead of using #ifdef macros in the header. > >> I.e., you might have to make a src/solaris/vm/dtrace_solaris.hpp and > >> src/linux/vm/dtrace_linux.hpp file and include it from here. > > > > I rather not, the code should be identical except for two small details > > between solaris and gnu/linux as the patch shows (and one is just a hack > > for a solaris tailcall bug). The apple/macos part looks very different > > and could be split out, but that was already there. > > I refer to the redefinition blocks of HS_DTRACE_PROBEx, which I don't > consider a small detail (though the solaris tailcall thing certainly > is). > > It's (of course) just a style thing, but traditionally in hotspot > we've wanted the os or arch specific code in os or arch specific > directories, instead of littering the code with #ifdefs. I know the OSX > stuff started violated this some, but I hope we're going to resolve that > rather than continue down that path. I wouldn't have mind if the OSX stuff was split out this way, but now I don't have any example to follow here. What/How do you suggest it is done? Thanks, Mark From erik.gahlin at oracle.com Wed May 23 07:01:39 2012 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Wed, 23 May 2012 16:01:39 +0200 Subject: RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team In-Reply-To: <4FBBEFEA.9050601@oracle.com> References: <4FAD23E4.90501@oracle.com> <4FAD3B63.8070501@oracle.com> <4FBA2477.7040101@oracle.com> <4FBBEFEA.9050601@oracle.com> Message-ID: <4FBCEDC3.2080605@oracle.com> Michael Fang skrev 2012-05-22 21:58: > Thanks Erik. > > I have already downloaded the raw message.properties file from the > webrev on 5/16 to proceed with the 7u6 translation. > > I performed a diff with current webrev, and it consists of mostly > deleted resources and 1 renamed key CONNECTION_LOST1 => > CONNECTION_LOST. I am fine with the changes from l10n perspective. > That's good to know. I will rename CONNECTION_LOST back to CONNECTION_LOST1 so it will work with the translated texts you get back. I won't add the 1:1 check since you will get more translated mesages then needed. > > -michael > > On 12?05?21? 04:18 ??, Erik Gahlin wrote: >> Thanks Michael, >> >> When it comes to ALL CAPs or SturdlyCaps, it's okay if those strings >> are not translated. >> >> Here is an updated webrev. I removed strings that were no longer in >> use and made some changes to the make-files. >> >> http://cr.openjdk.java.net/~egahlin/7017818_4/ >> >> /E >> >> Michael Fang skrev 2012-05-11 18:16: >>> Thanks so much Erik for the fix! The messages.properties file look >>> good. I only reviewed the English *messages.properties* file. WPTG >>> will re-translate the ja and zh_CN files. They will attempt to >>> leverage existing translation from *JConsoleResources_xx.java*. >>> >>> I have a comments about another translatability rule that WPTG follows: >>> >>> By Oracle software development guideline, ALL CAPs or StudlyCaps >>> strings will not be translated. Examples are: >>> 19 ACTION_CAPITALIZED=ACTION >>> 20 ACTION_INFO_CAPITALIZED=ACTION_INFO >>> 149 MBEAN_INFO=MBeanInfo >>> 150 MBEAN_NOTIFICATION_INFO=MBeanNotificationInfo >>> 151 MBEAN_OPERATION_INFO=MBeanOperationInfo >>> 206 OBJECT_NAME=ObjectName >>> 231 R_FORWARD_SLASH_W_CAPITALIZED=R/W >>> >>> 241 SEQ_NUM=SeqNum >>> 249 SUMMARY_TAB_HEADER_DATE_TIME_FORMAT=FULL,FULL >>> >>> 273 UNKNOWN_CAPITALIZED=UNKNOWN >>> >>> If any of the above such as ACTION or UNKNOWN needs to be >>> translated, they should not be ALL CAPS. The translators will not >>> translate those lines by default. >>> >>> The translators have the ability to see comments (or special >>> requests) if a comment line is inserted immediately prior to any of >>> the resources (each resource string and one comment line immediately >>> before it is stored in translation memory). If you must leave ACTION >>> or UNKNOWN in CAPS, you can try to insert comments.However, WPTG >>> does not guarantee they will be followed. >>> >>> thanks, >>> >>> -michael >>> >>> On 12?05?11? 07:36 ??, Erik Gahlin wrote: >>>> Could you please review? I also need a sponsor. >>>> >>>> http://cr.openjdk.java.net/~egahlin/7156518/1_0/ >>>> >>>> http://monaco.us.oracle.com/detail.jsf?cr=7017818 >>>> >>>> The patch is for JDK8, but it needs to ported to 7u6 before 5/16. >>>> >>>> Thanks! >>>> >>>> Erik >>>> >>>> Changes: >>>> >>>> - Moved localization messages to property files, one message per >>>> line, as needed. >>>> - Added '&' to messages so mnemonics could be identified. >>>> - Introduced Message class with static fields corresponding to the >>>> keys in the property files. >>>> - Added map for looking up mnemonics. >>>> >>>> Testing: >>>> >>>> - Verified programmatically that all the messages and mnemonics are >>>> "compatible" with the previous mechanism, for Chinese, Japanese and >>>> the default locale. >>>> - The intention is to run through the GUI to confirm that >>>> everything looks ok, but I'm waiting for a build. >>>> >>>> Other: >>>> >>>> - Fixed a typo in the MemoryPoolStat class, the method >>>> getAfterGcUsage returned this.beforeGCUsage instead of >>>> this.afterGcUsage >>>> - When going through all the code I did some minor clean up that >>>> should not impact the program flow: >>>> * removed unused imports. >>>> * inlined temporary variables holding messages. >>>> * removed private member variables that were not accessed. >>>> * removed private methods that were not referenced. >>>> * removed local variables that were not used. >>>> * added generic types where needed. >>>> * static methods are now called statically. >>>> * added suppress serialization warning where it was needed. >>>> * removed suppress serialization annotation where it was not needed. >>>> - In the Message class, the comment "remove? not found in code" >>>> will be removed once I know those message are not needed for 7u6. >>>> >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/fc9fa7ec/attachment.html From keith.mcguigan at oracle.com Wed May 23 07:23:11 2012 From: keith.mcguigan at oracle.com (Keith McGuigan) Date: Wed, 23 May 2012 10:23:11 -0400 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <1337781400.3002.17.camel@springer.wildebeest.org> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> <4FBCB9C7.3000304@oracle.com> <4FBCE2B0.3050201@oracle.com> <1337779575.3002.6.camel@springer.wildebeest.org> <4FBCE92C.8010708@oracle.com> <1337781400.3002.17.camel@springer.wildebeest.org> Message-ID: <4FBCF2CF.9000301@oracle.com> On 5/23/2012 9:56 AM, Mark Wielaard wrote: >> It's (of course) just a style thing, but traditionally in hotspot >> we've wanted the os or arch specific code in os or arch specific >> directories, instead of littering the code with #ifdefs. I know the OSX >> stuff started violated this some, but I hope we're going to resolve that >> rather than continue down that path. > > I wouldn't have mind if the OSX stuff was split out this way, but now I > don't have any example to follow here. What/How do you suggest it is > done? My first thought would be to create a dtrace_solaris.hpp file in src/os/solaris/vm and a dtrace_linux.hpp file in src/os/linux/vm (and maybe the same for bsd and windows?) for any OS-specific stuff, like the macro definitions and maybe even that solaris workaround. Leave anything common in the original file (like the default empty definitions and such). Then you include the specific-file based on the target OS, similar to what's done here: http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/file/03d61caacd1e/src/share/vm/runtime/interfaceSupport.hpp Yeah... it's a bit of a pain, and maybe in this case it's a little overkill. But it's definitely nice to have a location for the OS-specific stuff and it keeps the code rather neat. I think the only reason it wasn't done like this in the first place is that originally the DTrace code was either on or off based upon a 'make' variable so there wasn't many OS-based decisions (except in the Makefile of course). Probably it should have been done this way (split out) originally. My bad. -- - Keith From joe.darcy at oracle.com Wed May 23 08:32:58 2012 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 23 May 2012 08:32:58 -0700 Subject: CCC (Was: request for codereview, bug 7149528: easy usage of serviceability agent) In-Reply-To: <20120523072008.GA4569@toonder.wildebeest.org> References: <4FAD8922.9010902@oracle.com> <2DC2B513-1692-487E-82C7-ED0CE00332FD@oracle.com> <4FBBD00B.8080609@oracle.com> <4FBBD951.1040302@oracle.com> <20120523072008.GA4569@toonder.wildebeest.org> Message-ID: <4FBD032A.9010302@oracle.com> Hi Mark, On 5/23/2012 12:20 AM, Mark Wielaard wrote: > Hi Joe, > > On Tue, May 22, 2012 at 11:22:09AM -0700, Joe Darcy wrote: >> This state >> model is explained in the "process" link at the top of every ccc >> page and was additionally explained in a tech talk I gave earlier >> this year: >> >> http://j2se.us.oracle.com/web/pub/PrgMgmt/TechTalks/ccc-and-you.pdf >> >> Please do not blame excessive wait times on the ccc process when the >> ccc is not being used as documented Oops; thought I was sending to an internal alias. In any case, the ccc is currently an Oracle-internal process for reviewing and tracking interface changes to the JDK. I've been chairing the process for about the past two years. > It looks like that site isn't publicly reachable. Could you put the > document somewhere on openjdk.java.net or another more public place? > I recently got a question about submitting a CCC request in response > to one of my patches, but found very little documentation. The long-standing intention is to externalize the ccc process as part of the overall effort to open up the JDK-related infrastructure, like the bug system. When that occurs, I'll provide appropriate documentation about the intention of the process, how it process works, and so on. Cheers, -Joe > Thanks, > > Mark From mjw at redhat.com Wed May 23 09:19:29 2012 From: mjw at redhat.com (Mark Wielaard) Date: Wed, 23 May 2012 18:19:29 +0200 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBCF2CF.9000301@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> <4FBCB9C7.3000304@oracle.com> <4FBCE2B0.3050201@oracle.com> <1337779575.3002.6.camel@springer.wildebeest.org> <4FBCE92C.8010708@oracle.com> <1337781400.3002.17.camel@springer.wildebeest.org> <4FBCF2CF.9000301@oracle.com> Message-ID: <1337789969.3002.25.camel@springer.wildebeest.org> On Wed, 2012-05-23 at 10:23 -0400, Keith McGuigan wrote: > On 5/23/2012 9:56 AM, Mark Wielaard wrote: > >> It's (of course) just a style thing, but traditionally in hotspot > >> we've wanted the os or arch specific code in os or arch specific > >> directories, instead of littering the code with #ifdefs. I know the OSX > >> stuff started violated this some, but I hope we're going to resolve that > >> rather than continue down that path. > > > > I wouldn't have mind if the OSX stuff was split out this way, but now I > > don't have any example to follow here. What/How do you suggest it is > > done? > > My first thought would be to create a dtrace_solaris.hpp file in > src/os/solaris/vm and a dtrace_linux.hpp file in src/os/linux/vm (and > maybe the same for bsd and windows?) for any OS-specific stuff, like the > macro definitions and maybe even that solaris workaround. Leave > anything common in the original file (like the default empty definitions > and such). Then you include the specific-file based on the target OS, > similar to what's done here: > http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/file/03d61caacd1e/src/share/vm/runtime/interfaceSupport.hpp > > Yeah... it's a bit of a pain, and maybe in this case it's a little > overkill. But it's definitely nice to have a location for the > OS-specific stuff and it keeps the code rather neat. So, do you require this change or not? I don't particularly like that style (you loose the overview/a central place where all the magic macros are defined), but I can certainly do it if you require it now. But then I want to do it as additional patches on top of the current patches to make sure they are separate. Since I will then have to touch code for at least two architectures to which I don't have access (I also don't have access to windows nor bsd, but I hope I don't have to touch those too). So I want such changes to be testable separately by the architecture maintainers. Thanks, Mark From keith.mcguigan at oracle.com Wed May 23 09:27:42 2012 From: keith.mcguigan at oracle.com (Keith McGuigan) Date: Wed, 23 May 2012 12:27:42 -0400 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <1337789969.3002.25.camel@springer.wildebeest.org> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> <4FBCB9C7.3000304@oracle.com> <4FBCE2B0.3050201@oracle.com> <1337779575.3002.6.camel@springer.wildebeest.org> <4FBCE92C.8010708@oracle.com> <1337781400.3002.17.camel@springer.wildebeest.org> <4FBCF2CF.9000301@oracle.com> <1337789969.3002.25.camel@springer.wildebeest.org> Message-ID: <4FBD0FFE.6060402@oracle.com> Hi Mark - I'd prefer that it's done the "right" way (based on *my* definition of "right", of course :) ), but I won't put up a fuss if whomever shepherds this through agrees with you and wants to keep it in it's current form. I expect that will be Serguei, or someone else from the serviceability team? (Serguei?) -- - Keith On 5/23/2012 12:19 PM, Mark Wielaard wrote: > On Wed, 2012-05-23 at 10:23 -0400, Keith McGuigan wrote: >> On 5/23/2012 9:56 AM, Mark Wielaard wrote: >>>> It's (of course) just a style thing, but traditionally in hotspot >>>> we've wanted the os or arch specific code in os or arch specific >>>> directories, instead of littering the code with #ifdefs. I know the OSX >>>> stuff started violated this some, but I hope we're going to resolve that >>>> rather than continue down that path. >>> >>> I wouldn't have mind if the OSX stuff was split out this way, but now I >>> don't have any example to follow here. What/How do you suggest it is >>> done? >> >> My first thought would be to create a dtrace_solaris.hpp file in >> src/os/solaris/vm and a dtrace_linux.hpp file in src/os/linux/vm (and >> maybe the same for bsd and windows?) for any OS-specific stuff, like the >> macro definitions and maybe even that solaris workaround. Leave >> anything common in the original file (like the default empty definitions >> and such). Then you include the specific-file based on the target OS, >> similar to what's done here: >> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/file/03d61caacd1e/src/share/vm/runtime/interfaceSupport.hpp >> >> Yeah... it's a bit of a pain, and maybe in this case it's a little >> overkill. But it's definitely nice to have a location for the >> OS-specific stuff and it keeps the code rather neat. > > So, do you require this change or not? I don't particularly like that > style (you loose the overview/a central place where all the magic macros > are defined), but I can certainly do it if you require it now. But then > I want to do it as additional patches on top of the current patches to > make sure they are separate. Since I will then have to touch code for at > least two architectures to which I don't have access (I also don't have > access to windows nor bsd, but I hope I don't have to touch those too). > So I want such changes to be testable separately by the architecture > maintainers. > > Thanks, > > Mark From joe.darcy at oracle.com Wed May 23 09:32:54 2012 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 23 May 2012 09:32:54 -0700 Subject: CCC (Was: request for codereview, bug 7149528: easy usage of serviceability agent) In-Reply-To: <4FBCB36B.8040209@oracle.com> References: <4FAD8922.9010902@oracle.com> <2DC2B513-1692-487E-82C7-ED0CE00332FD@oracle.com> <4FBBD00B.8080609@oracle.com> <4FBBD951.1040302@oracle.com> <20120523072008.GA4569@toonder.wildebeest.org> <4FBCB36B.8040209@oracle.com> Message-ID: <4FBD1136.1020307@oracle.com> Hi Serguei, On 5/23/2012 2:52 AM, serguei.spitsyn at oracle.com wrote: > Hi Joe, > > In fact, we have the following question: > Q1: Do we have to submit a CCC request to enable the HotSpot DTrace > probes on Linux? There isn't a lot of information in the 7149528 bug report to give a final answer, but I would lean on saying "yes" this requires a ccc. > > The following is not completely clear to me: > Q2: Do we go through the CCC process when some interfaces are already > enabled on one platform and we want to enable on another? Yes, a ccc would often be required in those circumstances. Cheers, -Joe > > My guess is that the answers must be positive but wanted to double-check. > > Thanks, > Serguei > > > On 5/23/12 12:20 AM, Mark Wielaard wrote: >> Hi Joe, >> >> On Tue, May 22, 2012 at 11:22:09AM -0700, Joe Darcy wrote: >>> This state >>> model is explained in the "process" link at the top of every ccc >>> page and was additionally explained in a tech talk I gave earlier >>> this year: >>> >>> http://j2se.us.oracle.com/web/pub/PrgMgmt/TechTalks/ccc-and-you.pdf >>> >>> Please do not blame excessive wait times on the ccc process when the >>> ccc is not being used as documented >> It looks like that site isn't publicly reachable. Could you put the >> document somewhere on openjdk.java.net or another more public place? >> I recently got a question about submitting a CCC request in response >> to one of my patches, but found very little documentation. >> >> Thanks, >> >> Mark > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/adb4724a/attachment.html From serguei.spitsyn at oracle.com Wed May 23 09:35:12 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 23 May 2012 09:35:12 -0700 Subject: CCC (Was: request for codereview, bug 7149528: easy usage of serviceability agent) In-Reply-To: <4FBD1136.1020307@oracle.com> References: <4FAD8922.9010902@oracle.com> <2DC2B513-1692-487E-82C7-ED0CE00332FD@oracle.com> <4FBBD00B.8080609@oracle.com> <4FBBD951.1040302@oracle.com> <20120523072008.GA4569@toonder.wildebeest.org> <4FBCB36B.8040209@oracle.com> <4FBD1136.1020307@oracle.com> Message-ID: <4FBD11C0.9000807@oracle.com> Thanks! Serguei On 5/23/12 9:32 AM, Joe Darcy wrote: > Hi Serguei, > > On 5/23/2012 2:52 AM, serguei.spitsyn at oracle.com wrote: >> Hi Joe, >> >> In fact, we have the following question: >> Q1: Do we have to submit a CCC request to enable the HotSpot DTrace >> probes on Linux? > > There isn't a lot of information in the 7149528 bug report to give a > final answer, but I would lean on saying "yes" this requires a ccc. > >> >> The following is not completely clear to me: >> Q2: Do we go through the CCC process when some interfaces are >> already enabled on one platform and we want to enable on another? > > Yes, a ccc would often be required in those circumstances. > > Cheers, > > -Joe > >> >> My guess is that the answers must be positive but wanted to double-check. >> >> Thanks, >> Serguei >> >> >> On 5/23/12 12:20 AM, Mark Wielaard wrote: >>> Hi Joe, >>> >>> On Tue, May 22, 2012 at 11:22:09AM -0700, Joe Darcy wrote: >>>> This state >>>> model is explained in the "process" link at the top of every ccc >>>> page and was additionally explained in a tech talk I gave earlier >>>> this year: >>>> >>>> http://j2se.us.oracle.com/web/pub/PrgMgmt/TechTalks/ccc-and-you.pdf >>>> >>>> Please do not blame excessive wait times on the ccc process when the >>>> ccc is not being used as documented >>> It looks like that site isn't publicly reachable. Could you put the >>> document somewhere on openjdk.java.net or another more public place? >>> I recently got a question about submitting a CCC request in response >>> to one of my patches, but found very little documentation. >>> >>> Thanks, >>> >>> Mark >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/838ea75e/attachment.html From mark at klomp.org Wed May 23 09:39:01 2012 From: mark at klomp.org (Mark Wielaard) Date: Wed, 23 May 2012 18:39:01 +0200 Subject: CCC (Was: request for codereview, bug 7149528: easy usage of serviceability agent) In-Reply-To: <4FBD1136.1020307@oracle.com> References: <4FAD8922.9010902@oracle.com> <2DC2B513-1692-487E-82C7-ED0CE00332FD@oracle.com> <4FBBD00B.8080609@oracle.com> <4FBBD951.1040302@oracle.com> <20120523072008.GA4569@toonder.wildebeest.org> <4FBCB36B.8040209@oracle.com> <4FBD1136.1020307@oracle.com> Message-ID: <1337791141.3002.26.camel@springer.wildebeest.org> On Wed, 2012-05-23 at 09:32 -0700, Joe Darcy wrote: > On 5/23/2012 2:52 AM, serguei.spitsyn at oracle.com wrote: > > In fact, we have the following question: > > Q1: Do we have to submit a CCC request to enable the HotSpot DTrace > > probes on Linux? > > There isn't a lot of information in the 7149528 bug report to give a > final answer, but I would lean on saying "yes" this requires a ccc. Are you talking about the same bug report? Serguei created: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170638 From serguei.spitsyn at oracle.com Wed May 23 09:47:55 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 23 May 2012 09:47:55 -0700 Subject: CCC (Was: request for codereview, bug 7149528: easy usage of serviceability agent) In-Reply-To: <1337791141.3002.26.camel@springer.wildebeest.org> References: <4FAD8922.9010902@oracle.com> <2DC2B513-1692-487E-82C7-ED0CE00332FD@oracle.com> <4FBBD00B.8080609@oracle.com> <4FBBD951.1040302@oracle.com> <20120523072008.GA4569@toonder.wildebeest.org> <4FBCB36B.8040209@oracle.com> <4FBD1136.1020307@oracle.com> <1337791141.3002.26.camel@springer.wildebeest.org> Message-ID: <4FBD14BB.4040806@oracle.com> On 5/23/12 9:39 AM, Mark Wielaard wrote: > On Wed, 2012-05-23 at 09:32 -0700, Joe Darcy wrote: >> On 5/23/2012 2:52 AM, serguei.spitsyn at oracle.com wrote: >>> In fact, we have the following question: >>> Q1: Do we have to submit a CCC request to enable the HotSpot DTrace >>> probes on Linux? >> There isn't a lot of information in the 7149528 bug report to give a >> final answer, but I would lean on saying "yes" this requires a ccc. > Are you talking about the same bug report? Serguei created: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170638 Mark, Thank you for catching this! Joe, Just to avoid confusions... This is the bug report I was talking about (monaco-based link for your convenience): http://monaco.us.oracle.com/detail.jsf?cr=7170638 Thanks, Serguei -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/81ec25ca/attachment.html From serguei.spitsyn at oracle.com Wed May 23 10:06:08 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 23 May 2012 10:06:08 -0700 Subject: CCC (Was: request for codereview, bug 7149528: easy usage of serviceability agent) In-Reply-To: <4FBD14BB.4040806@oracle.com> References: <4FAD8922.9010902@oracle.com> <2DC2B513-1692-487E-82C7-ED0CE00332FD@oracle.com> <4FBBD00B.8080609@oracle.com> <4FBBD951.1040302@oracle.com> <20120523072008.GA4569@toonder.wildebeest.org> <4FBCB36B.8040209@oracle.com> <4FBD1136.1020307@oracle.com> <1337791141.3002.26.camel@springer.wildebeest.org> <4FBD14BB.4040806@oracle.com> Message-ID: <4FBD1900.4090401@oracle.com> On 5/23/12 9:47 AM, serguei.spitsyn at oracle.com wrote: > On 5/23/12 9:39 AM, Mark Wielaard wrote: >> On Wed, 2012-05-23 at 09:32 -0700, Joe Darcy wrote: >>> On 5/23/2012 2:52 AM,serguei.spitsyn at oracle.com wrote: >>>> In fact, we have the following question: >>>> Q1: Do we have to submit a CCC request to enable the HotSpot DTrace >>>> probes on Linux? >>> There isn't a lot of information in the 7149528 bug report to give a >>> final answer, but I would lean on saying "yes" this requires a ccc. >> Are you talking about the same bug report? Serguei created: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7170638 > Mark, > > Thank you for catching this! > Joe, > > Just to avoid confusions... > > This is the bug report I was talking about (monaco-based link for your > convenience): > http://monaco.us.oracle.com/detail.jsf?cr=7170638 Need to explain it better. Last questions from Mark and me are unrelated to the original discussion about SA (7149528). I had to send my questions with a different subject. But your answers must be still correct, right? Thanks, Serguei > > Thanks, > Serguei > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/db21f24b/attachment-0001.html From serguei.spitsyn at oracle.com Wed May 23 10:25:10 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 23 May 2012 10:25:10 -0700 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBD0FFE.6060402@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> <4FBCB9C7.3000304@oracle.com> <4FBCE2B0.3050201@oracle.com> <1337779575.3002.6.camel@springer.wildebeest.org> <4FBCE92C.8010708@oracle.com> <1337781400.3002.17.camel@springer.wildebeest.org> <4FBCF2CF.9000301@oracle.com> <1337789969.3002.25.camel@springer.wildebeest.org> <4FBD0FFE.6060402@oracle.com> Message-ID: <4FBD1D76.90206@oracle.com> Keith, I agree that it'd be nice to follow the rules. But we also can do it in two stages: - first integration to keep close to the original fix that was already tested on Linux platform (as Mark tells) - separate refactoring to follow the platform separation rules (will need to file another CR) Not sure I'll be able to work on this in the near future (a month) as I have to switch to the urgent security issue. But it is still can be possible to do in a background with a low priority. Other action items for this integration: 1. Test that the HS DTrace are not broken on Solaris 2. Find or setup a Linux machine with the systemTap 3. Check that the fix is built Ok 4. Test that the fix works on Linux Need a unit test for the fix (Mark, do you have any?) Thanks, Serguei On 5/23/12 9:27 AM, Keith McGuigan wrote: > > Hi Mark - > > I'd prefer that it's done the "right" way (based on *my* definition of > "right", of course :) ), but I won't put up a fuss if whomever > shepherds this through agrees with you and wants to keep it in it's > current form. I expect that will be Serguei, or someone else from the > serviceability team? (Serguei?) > > -- > - Keith > > On 5/23/2012 12:19 PM, Mark Wielaard wrote: >> On Wed, 2012-05-23 at 10:23 -0400, Keith McGuigan wrote: >>> On 5/23/2012 9:56 AM, Mark Wielaard wrote: >>>>> It's (of course) just a style thing, but traditionally in hotspot >>>>> we've wanted the os or arch specific code in os or arch specific >>>>> directories, instead of littering the code with #ifdefs. I know >>>>> the OSX >>>>> stuff started violated this some, but I hope we're going to >>>>> resolve that >>>>> rather than continue down that path. >>>> >>>> I wouldn't have mind if the OSX stuff was split out this way, but >>>> now I >>>> don't have any example to follow here. What/How do you suggest it is >>>> done? >>> >>> My first thought would be to create a dtrace_solaris.hpp file in >>> src/os/solaris/vm and a dtrace_linux.hpp file in src/os/linux/vm (and >>> maybe the same for bsd and windows?) for any OS-specific stuff, like >>> the >>> macro definitions and maybe even that solaris workaround. Leave >>> anything common in the original file (like the default empty >>> definitions >>> and such). Then you include the specific-file based on the target OS, >>> similar to what's done here: >>> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/file/03d61caacd1e/src/share/vm/runtime/interfaceSupport.hpp >>> >>> >>> Yeah... it's a bit of a pain, and maybe in this case it's a little >>> overkill. But it's definitely nice to have a location for the >>> OS-specific stuff and it keeps the code rather neat. >> >> So, do you require this change or not? I don't particularly like that >> style (you loose the overview/a central place where all the magic macros >> are defined), but I can certainly do it if you require it now. But then >> I want to do it as additional patches on top of the current patches to >> make sure they are separate. Since I will then have to touch code for at >> least two architectures to which I don't have access (I also don't have >> access to windows nor bsd, but I hope I don't have to touch those too). >> So I want such changes to be testable separately by the architecture >> maintainers. >> >> Thanks, >> >> Mark -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/0f51fba2/attachment.html From kurchi.subhra.hazra at oracle.com Wed May 23 10:42:35 2012 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Wed, 23 May 2012 17:42:35 +0000 Subject: hg: jdk8/tl/jdk: 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows 8 Message-ID: <20120523174245.9C036474A0@hg.openjdk.java.net> Changeset: 0c3d9050c918 Author: khazra Date: 2012-05-23 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c3d9050c918 7170169: (props) System.getProperty("os.name") should return "Windows 8" when run on Windows 8 Summary: Enable Windows Version 6.2 to be recognized as Windows 8 Reviewed-by: darcy, dholmes, alanb, chegar ! src/windows/native/java/lang/java_props_md.c From rob.mckenna at oracle.com Wed May 23 10:44:38 2012 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 23 May 2012 18:44:38 +0100 Subject: Codereview request for 7171184: Make the failure message in 7168110 more specific In-Reply-To: <4FB51E29.7060900@oracle.com> References: <4FB51E29.7060900@oracle.com> Message-ID: <4FBD2206.3020404@oracle.com> Hi folks, David Holmes suggested a rewrite of the original bug (7168110) so I've put together the following: http://cr.openjdk.java.net/~robm/7171184/webrev.01/ It will narrow down the cause of the error and return a more specific message when there is a problem attaching jstack to a process created in another session. Let me know what you think, -Rob -------- Original Message -------- Subject: Codereview request for 7168110: Misleading jstack error message Date: Thu, 17 May 2012 16:50:01 +0100 From: Rob McKenna To: serviceability-dev at openjdk.java.net Hi folks, A straightforward enough fix for an issue whereby windows sees fit to return a cryptic error message when attempting to run jstack on a process created in another terminal session. As per the webrev, see the remarks section at: http://msdn.microsoft.com/en-us/library/ms682437%28VS.85%29.aspx Webrev at: http://cr.openjdk.java.net/~robm/7168110/webrev.01/ Thanks! -Rob -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/966e4356/attachment.html From keith.mcguigan at oracle.com Wed May 23 10:49:28 2012 From: keith.mcguigan at oracle.com (Keith McGuigan) Date: Wed, 23 May 2012 13:49:28 -0400 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBD1D76.90206@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> <4FBCB9C7.3000304@oracle.com> <4FBCE2B0.3050201@oracle.com> <1337779575.3002.6.camel@springer.wildebeest.org> <4FBCE92C.8010708@oracle.com> <1337781400.3002.17.camel@springer.wildebeest.org> <4FBCF2CF.9000301@oracle.com> <1337789969.3002.25.camel@springer.wildebeest.org> <4FBD0FFE.6060402@oracle.com> <4FBD1D76.90206@oracle.com> Message-ID: <4FBD2328.2040901@oracle.com> Serguei - I think that all sounds fine. -- - Keith On 5/23/2012 1:25 PM, serguei.spitsyn at oracle.com wrote: > Keith, > > I agree that it'd be nice to follow the rules. > But we also can do it in two stages: > - first integration to keep close to the original fix that was already > tested on Linux platform (as Mark tells) > - separate refactoring to follow the platform separation rules (will > need to file another CR) > > Not sure I'll be able to work on this in the near future (a month) as I > have to switch to the urgent security issue. > But it is still can be possible to do in a background with a low priority. > > Other action items for this integration: > 1. Test that the HS DTrace are not broken on Solaris > 2. Find or setup a Linux machine with the systemTap > 3. Check that the fix is built Ok > 4. Test that the fix works on Linux > Need a unit test for the fix (Mark, do you have any?) > > Thanks, > Serguei > > > On 5/23/12 9:27 AM, Keith McGuigan wrote: >> >> Hi Mark - >> >> I'd prefer that it's done the "right" way (based on *my* definition of >> "right", of course :) ), but I won't put up a fuss if whomever >> shepherds this through agrees with you and wants to keep it in it's >> current form. I expect that will be Serguei, or someone else from the >> serviceability team? (Serguei?) >> >> -- >> - Keith >> >> On 5/23/2012 12:19 PM, Mark Wielaard wrote: >>> On Wed, 2012-05-23 at 10:23 -0400, Keith McGuigan wrote: >>>> On 5/23/2012 9:56 AM, Mark Wielaard wrote: >>>>>> It's (of course) just a style thing, but traditionally in hotspot >>>>>> we've wanted the os or arch specific code in os or arch specific >>>>>> directories, instead of littering the code with #ifdefs. I know >>>>>> the OSX >>>>>> stuff started violated this some, but I hope we're going to >>>>>> resolve that >>>>>> rather than continue down that path. >>>>> >>>>> I wouldn't have mind if the OSX stuff was split out this way, but >>>>> now I >>>>> don't have any example to follow here. What/How do you suggest it is >>>>> done? >>>> >>>> My first thought would be to create a dtrace_solaris.hpp file in >>>> src/os/solaris/vm and a dtrace_linux.hpp file in src/os/linux/vm (and >>>> maybe the same for bsd and windows?) for any OS-specific stuff, like >>>> the >>>> macro definitions and maybe even that solaris workaround. Leave >>>> anything common in the original file (like the default empty >>>> definitions >>>> and such). Then you include the specific-file based on the target OS, >>>> similar to what's done here: >>>> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/file/03d61caacd1e/src/share/vm/runtime/interfaceSupport.hpp >>>> >>>> >>>> Yeah... it's a bit of a pain, and maybe in this case it's a little >>>> overkill. But it's definitely nice to have a location for the >>>> OS-specific stuff and it keeps the code rather neat. >>> >>> So, do you require this change or not? I don't particularly like that >>> style (you loose the overview/a central place where all the magic macros >>> are defined), but I can certainly do it if you require it now. But then >>> I want to do it as additional patches on top of the current patches to >>> make sure they are separate. Since I will then have to touch code for at >>> least two architectures to which I don't have access (I also don't have >>> access to windows nor bsd, but I hope I don't have to touch those too). >>> So I want such changes to be testable separately by the architecture >>> maintainers. >>> >>> Thanks, >>> >>> Mark > From staffan.larsen at oracle.com Wed May 23 11:11:54 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 23 May 2012 20:11:54 +0200 Subject: Codereview request for 7171184: Make the failure message in 7168110 more specific In-Reply-To: <4FBD2206.3020404@oracle.com> References: <4FB51E29.7060900@oracle.com> <4FBD2206.3020404@oracle.com> Message-ID: <5FCD9C1C-60C0-44B5-8464-8DF8B808604B@oracle.com> Looks good! /Staffan On 23 maj 2012, at 19:44, Rob McKenna wrote: > Hi folks, > > David Holmes suggested a rewrite of the original bug (7168110) so I've put together the following: > > http://cr.openjdk.java.net/~robm/7171184/webrev.01/ > > It will narrow down the cause of the error and return a more specific message when there is a problem attaching jstack to a process created in another session. > > Let me know what you think, > > -Rob > > -------- Original Message -------- > Subject: Codereview request for 7168110: Misleading jstack error message > Date: Thu, 17 May 2012 16:50:01 +0100 > From: Rob McKenna > To: serviceability-dev at openjdk.java.net > > Hi folks, > > A straightforward enough fix for an issue whereby windows sees fit to > return a cryptic error message when attempting to run jstack on a > process created in another terminal session. > > As per the webrev, see the remarks section at: > > http://msdn.microsoft.com/en-us/library/ms682437%28VS.85%29.aspx > > Webrev at: > > http://cr.openjdk.java.net/~robm/7168110/webrev.01/ > > Thanks! > > -Rob -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/1e04d7f9/attachment-0001.html From serguei.spitsyn at oracle.com Wed May 23 11:16:18 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 23 May 2012 11:16:18 -0700 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBD2328.2040901@oracle.com> References: <4FABE435.3070101@oracle.com> <1336982811.3015.1.camel@springer.wildebeest.org> <4FB10B9E.8060500@oracle.com> <20120517192555.GB2423@toonder.wildebeest.org> <4FB58E19.8070002@oracle.com> <4FB5D481.2060307@oracle.com> <4FB5EC9D.10302@oracle.com> <1337592522.3408.16.camel@springer.wildebeest.org> <4FBB07C1.8000302@oracle.com> <4FBB15A2.7090808@oracle.com> <4FBB3555.2080607@oracle.com> <4FBCB9C7.3000304@oracle.com> <4FBCE2B0.3050201@oracle.com> <1337779575.3002.6.camel@springer.wildebeest.org> <4FBCE92C.8010708@oracle.com> <1337781400.3002.17.camel@springer.wildebeest.org> <4FBCF2CF.9000301@oracle.com> <1337789969.3002.25.camel@springer.wildebeest.org> <4FBD0FFE.6060402@oracle.com> <4FBD1D76.90206@oracle.com> <4FBD2328.2040901@oracle.com> Message-ID: <4FBD2972.5090208@oracle.com> Keith, Thank you for reviewing at the fix! I forgot to mention another AI: 5. Submit a CCC request and get an approval I'll do this as a background work. Mark, are you Ok with that? Thanks, Serguei On 5/23/12 10:49 AM, Keith McGuigan wrote: > > Serguei - > > I think that all sounds fine. > > -- > - Keith > > On 5/23/2012 1:25 PM, serguei.spitsyn at oracle.com wrote: >> Keith, >> >> I agree that it'd be nice to follow the rules. >> But we also can do it in two stages: >> - first integration to keep close to the original fix that was already >> tested on Linux platform (as Mark tells) >> - separate refactoring to follow the platform separation rules (will >> need to file another CR) >> >> Not sure I'll be able to work on this in the near future (a month) as I >> have to switch to the urgent security issue. >> But it is still can be possible to do in a background with a low >> priority. >> >> Other action items for this integration: >> 1. Test that the HS DTrace are not broken on Solaris >> 2. Find or setup a Linux machine with the systemTap >> 3. Check that the fix is built Ok >> 4. Test that the fix works on Linux >> Need a unit test for the fix (Mark, do you have any?) >> >> Thanks, >> Serguei >> >> >> On 5/23/12 9:27 AM, Keith McGuigan wrote: >>> >>> Hi Mark - >>> >>> I'd prefer that it's done the "right" way (based on *my* definition of >>> "right", of course :) ), but I won't put up a fuss if whomever >>> shepherds this through agrees with you and wants to keep it in it's >>> current form. I expect that will be Serguei, or someone else from the >>> serviceability team? (Serguei?) >>> >>> -- >>> - Keith >>> >>> On 5/23/2012 12:19 PM, Mark Wielaard wrote: >>>> On Wed, 2012-05-23 at 10:23 -0400, Keith McGuigan wrote: >>>>> On 5/23/2012 9:56 AM, Mark Wielaard wrote: >>>>>>> It's (of course) just a style thing, but traditionally in >>>>>>> hotspot >>>>>>> we've wanted the os or arch specific code in os or arch specific >>>>>>> directories, instead of littering the code with #ifdefs. I know >>>>>>> the OSX >>>>>>> stuff started violated this some, but I hope we're going to >>>>>>> resolve that >>>>>>> rather than continue down that path. >>>>>> >>>>>> I wouldn't have mind if the OSX stuff was split out this way, but >>>>>> now I >>>>>> don't have any example to follow here. What/How do you suggest it is >>>>>> done? >>>>> >>>>> My first thought would be to create a dtrace_solaris.hpp file in >>>>> src/os/solaris/vm and a dtrace_linux.hpp file in src/os/linux/vm (and >>>>> maybe the same for bsd and windows?) for any OS-specific stuff, like >>>>> the >>>>> macro definitions and maybe even that solaris workaround. Leave >>>>> anything common in the original file (like the default empty >>>>> definitions >>>>> and such). Then you include the specific-file based on the target >>>>> OS, >>>>> similar to what's done here: >>>>> http://hg.openjdk.java.net/hsx/hotspot-main/hotspot/file/03d61caacd1e/src/share/vm/runtime/interfaceSupport.hpp >>>>> >>>>> >>>>> >>>>> Yeah... it's a bit of a pain, and maybe in this case it's a little >>>>> overkill. But it's definitely nice to have a location for the >>>>> OS-specific stuff and it keeps the code rather neat. >>>> >>>> So, do you require this change or not? I don't particularly like that >>>> style (you loose the overview/a central place where all the magic >>>> macros >>>> are defined), but I can certainly do it if you require it now. But >>>> then >>>> I want to do it as additional patches on top of the current patches to >>>> make sure they are separate. Since I will then have to touch code >>>> for at >>>> least two architectures to which I don't have access (I also don't >>>> have >>>> access to windows nor bsd, but I hope I don't have to touch those >>>> too). >>>> So I want such changes to be testable separately by the architecture >>>> maintainers. >>>> >>>> Thanks, >>>> >>>> Mark >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/d48540d8/attachment.html From Alan.Bateman at oracle.com Wed May 23 11:58:24 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 23 May 2012 19:58:24 +0100 Subject: Codereview request for 7171184: Make the failure message in 7168110 more specific In-Reply-To: <4FBD2206.3020404@oracle.com> References: <4FB51E29.7060900@oracle.com> <4FBD2206.3020404@oracle.com> Message-ID: <4FBD3350.1010805@oracle.com> On 23/05/2012 18:44, Rob McKenna wrote: > Hi folks, > > David Holmes suggested a rewrite of the original bug (7168110) so I've > put together the following: > > http://cr.openjdk.java.net/~robm/7171184/webrev.01/ > > It will narrow down the cause of the error and return a more specific > message when there is a problem attaching jstack to a process created > in another session. > > Let me know what you think, I wasn't aware of ProcessIdToSessionId but seems a good idea. I assume you should check the return value from ProcessIdToSessionId before looking at the session id or last error. Minor nit but you are missing a space in "if(" (line 479) One idea to avoid duplicating the cleanup (VirtualFreeEx) code is: if (GetLastError() == ERROR_NOT_ENOUGH_MEMORY) { if (( ProcessIdToSessionId( GetCurrentProcessId(), &cSid) != 0) { BOOL result = ProcessIdToSessionId(GetProcessId(hProcess), &pSid); if ((result != 0 && (pSid != cSid)) || GetLastError() == ERROR_ACCESS_DENIED)) { JNU_ThrowIOException(env, "useful message"); SetLastError(0); } } } if (GetLastError() != 0) JNU_ThrowIOExceptionWithLastError(env, "CreateRemoteThread failed"); Just a suggestion so that you have one return path. The one downside (and you've got this issue already) is that if ProcessIdToSessionId fails with something other access denied then the error for the exception wont' be right. -Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/2ca8a4ed/attachment.html From rob.mckenna at oracle.com Wed May 23 12:37:37 2012 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 23 May 2012 20:37:37 +0100 Subject: Codereview request for 7171184: Make the failure message in 7168110 more specific In-Reply-To: <4FBD3350.1010805@oracle.com> References: <4FB51E29.7060900@oracle.com> <4FBD2206.3020404@oracle.com> <4FBD3350.1010805@oracle.com> Message-ID: <4FBD3C81.5020100@oracle.com> Hi Alan, Sorry, you've picked me up on that "if (" space a number of times. Thanks for pointing it out again. What should I be checking w.r.t. the ProcessIdToSessionId? It returns a 0 on failure so once the session id's are unequal or we've encountered an ERROR_ACCESS_DENIED we should really be good to go right? Looking at that reminds me that I had got an && instead of an || for the session id / error check. Its a good point that if the ProcessIdToSessionId call fails for a reason outside ACCESS_DENIED, we won't know about it. I'm wondering if I should revert that now? -Rob On 23/05/12 19:58, Alan Bateman wrote: > On 23/05/2012 18:44, Rob McKenna wrote: >> Hi folks, >> >> David Holmes suggested a rewrite of the original bug (7168110) so >> I've put together the following: >> >> http://cr.openjdk.java.net/~robm/7171184/webrev.01/ >> >> It will narrow down the cause of the error and return a more specific >> message when there is a problem attaching jstack to a process created >> in another session. >> >> Let me know what you think, > I wasn't aware of ProcessIdToSessionId but seems a good idea. > > I assume you should check the return value from ProcessIdToSessionId > before looking at the session id or last error. > > Minor nit but you are missing a space in "if(" (line 479) > > One idea to avoid duplicating the cleanup (VirtualFreeEx) code is: > > if (GetLastError() == ERROR_NOT_ENOUGH_MEMORY) { > if (( ProcessIdToSessionId( GetCurrentProcessId(), &cSid) != 0) { > BOOL result = ProcessIdToSessionId(GetProcessId(hProcess), &pSid); > if ((result != 0 && (pSid != cSid)) || GetLastError() == > ERROR_ACCESS_DENIED)) { > JNU_ThrowIOException(env, "useful message"); > SetLastError(0); > } > } > } > if (GetLastError() != 0) > JNU_ThrowIOExceptionWithLastError(env, "CreateRemoteThread failed"); > > Just a suggestion so that you have one return path. The one downside > (and you've got this issue already) is that if ProcessIdToSessionId > fails with something other access denied then the error for the > exception wont' be right. > > -Alan. > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/b70db0ca/attachment.html From rob.mckenna at oracle.com Wed May 23 12:37:56 2012 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 23 May 2012 20:37:56 +0100 Subject: Codereview request for 7171184: Make the failure message in 7168110 more specific In-Reply-To: <4FBD3350.1010805@oracle.com> References: <4FB51E29.7060900@oracle.com> <4FBD2206.3020404@oracle.com> <4FBD3350.1010805@oracle.com> Message-ID: <4FBD3C94.3000900@oracle.com> Hi Alan, Sorry, you've picked me up on that "if (" space a number of times. Thanks for pointing it out again. What should I be checking w.r.t. the ProcessIdToSessionId? It returns a 0 on failure so once the session id's are unequal or we've encountered an ERROR_ACCESS_DENIED we should really be good to go right? Looking at that reminds me that I had got an && instead of an || for the session id / error check. Its a good point that if the ProcessIdToSessionId call fails for a reason outside ACCESS_DENIED, we won't know about it. I'm wondering if I should revert that now? -Rob On 23/05/12 19:58, Alan Bateman wrote: > On 23/05/2012 18:44, Rob McKenna wrote: >> Hi folks, >> >> David Holmes suggested a rewrite of the original bug (7168110) so >> I've put together the following: >> >> http://cr.openjdk.java.net/~robm/7171184/webrev.01/ >> >> It will narrow down the cause of the error and return a more specific >> message when there is a problem attaching jstack to a process created >> in another session. >> >> Let me know what you think, > I wasn't aware of ProcessIdToSessionId but seems a good idea. > > I assume you should check the return value from ProcessIdToSessionId > before looking at the session id or last error. > > Minor nit but you are missing a space in "if(" (line 479) > > One idea to avoid duplicating the cleanup (VirtualFreeEx) code is: > > if (GetLastError() == ERROR_NOT_ENOUGH_MEMORY) { > if (( ProcessIdToSessionId( GetCurrentProcessId(), &cSid) != 0) { > BOOL result = ProcessIdToSessionId(GetProcessId(hProcess), &pSid); > if ((result != 0 && (pSid != cSid)) || GetLastError() == > ERROR_ACCESS_DENIED)) { > JNU_ThrowIOException(env, "useful message"); > SetLastError(0); > } > } > } > if (GetLastError() != 0) > JNU_ThrowIOExceptionWithLastError(env, "CreateRemoteThread failed"); > > Just a suggestion so that you have one return path. The one downside > (and you've got this issue already) is that if ProcessIdToSessionId > fails with something other access denied then the error for the > exception wont' be right. > > -Alan. > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/523f5c44/attachment.html From daniel.daugherty at oracle.com Wed May 23 12:50:18 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 23 May 2012 13:50:18 -0600 Subject: code review for JDK FDS gobjcopy work arounds (7170449) Message-ID: <4FBD3F7A.4030501@oracle.com> Greetings, This is a JDK code review request for a pair of Full Debug Symbols gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10 corrupts the SUNW_* sections on objects. This has caused dtrace test failures and Monitoring & Management test failures. The gobjcopy utility crashes due to empty sections with the SHF_ALLOC flagset on Solaris X64 objects. This causes build failures. There are two new temporary work around tools: add_gnu_debuglink - adds the ".gnu_debuglink" section to an ELF object without corrupting the other sections in the object. fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty sections in ELF objects. These temporary work arounds are only needed until the proper Solaris 10 Update 6 patches are made available. The two patches are independent of one another which is why there are two separate temporary work arounds. However, we're putting the temporary work arounds in place because the 7u6 project window is closing fast. Here is the webrev URL for the JDK8-T&L version: http://cr.openjdk.java.net/~dcubed/fds_revamp/7170449-webrev/0/ This fix will also be backported to 7u6-T&L and I expect the changes to virtually identical. Thanks, in advance, for any reviews! Dan From daniel.daugherty at oracle.com Wed May 23 12:59:28 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 23 May 2012 13:59:28 -0600 Subject: code review for second hotspot FDS gobjcopy work around (7165598) Message-ID: <4FBD41A0.4080408@oracle.com> Greetings, This is a hotspot code review request for the second of a pair of Full Debug Symbols gobjcopy work arounds on Solaris. The first hotspot FDS gobjcopy work around was reviewed using bug 7165060 and that fixed the dtrace test failures. The gobjcopy utility also crashes due to empty sections with the SHF_ALLOC flagset on Solaris X64 objects. This causes build failures. The first new temporary work around tool is add_gnu_debuglink and it was added by 7165060.The second new temporary work around tool is: fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty sections in ELF objects. These temporary work arounds are only needed until the proper Solaris 10 Update 6 patches are made available. The two patches are independent of one another which is why there are two separate temporary work arounds. However, we're putting the temporary work arounds in place because the 7u6/HSX-23.2 project window is closing fast. Here is the webrev URL for the HSX-24 version: http://cr.openjdk.java.net/~dcubed/fds_revamp/7165598-webrev/0/ This fix will also be backported to 7u6/HSX-23.2 and I expect the changes to virtually identical. Thanks, in advance, for any reviews! Dan From Alan.Bateman at oracle.com Wed May 23 14:02:49 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 23 May 2012 22:02:49 +0100 Subject: Codereview request for 7171184: Make the failure message in 7168110 more specific In-Reply-To: <4FBD3C94.3000900@oracle.com> References: <4FB51E29.7060900@oracle.com> <4FBD2206.3020404@oracle.com> <4FBD3350.1010805@oracle.com> <4FBD3C94.3000900@oracle.com> Message-ID: <4FBD5079.6060803@oracle.com> On 23/05/2012 20:37, Rob McKenna wrote: > Hi Alan, > > Sorry, you've picked me up on that "if (" space a number of times. > Thanks for pointing it out again. > > What should I be checking w.r.t. the ProcessIdToSessionId? It returns > a 0 on failure so once the session id's are unequal or we've > encountered an ERROR_ACCESS_DENIED we should really be good to go right? > > Looking at that reminds me that I had got an && instead of an || for > the session id / error check. Its a good point that if the > ProcessIdToSessionId call fails for a reason outside ACCESS_DENIED, we > won't know about it. I'm wondering if I should revert that now? What you have will work but we shouldn't be comparing pSid to cSid unless both calls to ProcessIdToSessionId succeed. -Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120523/d4b5b5f7/attachment-0001.html From david.holmes at oracle.com Wed May 23 16:58:25 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 24 May 2012 09:58:25 +1000 Subject: Codereview request for 7171184: Make the failure message in 7168110 more specific In-Reply-To: <4FBD5079.6060803@oracle.com> References: <4FB51E29.7060900@oracle.com> <4FBD2206.3020404@oracle.com> <4FBD3350.1010805@oracle.com> <4FBD3C94.3000900@oracle.com> <4FBD5079.6060803@oracle.com> Message-ID: <4FBD79A1.9050901@oracle.com> On 24/05/2012 7:02 AM, Alan Bateman wrote: > On 23/05/2012 20:37, Rob McKenna wrote: >> Hi Alan, >> >> Sorry, you've picked me up on that "if (" space a number of times. >> Thanks for pointing it out again. >> >> What should I be checking w.r.t. the ProcessIdToSessionId? It returns >> a 0 on failure so once the session id's are unequal or we've >> encountered an ERROR_ACCESS_DENIED we should really be good to go right? >> >> Looking at that reminds me that I had got an && instead of an || for >> the session id / error check. Its a good point that if the >> ProcessIdToSessionId call fails for a reason outside ACCESS_DENIED, we >> won't know about it. I'm wondering if I should revert that now? > What you have will work but we shouldn't be comparing pSid to cSid > unless both calls to ProcessIdToSessionId succeed. Yeah I raised this previously with Rob and the response was that on failure the sessionId will be set to zero but I do not see that in the docs for ProcessIdToSessionId. The other assumptions was that requesting the session Id for the current process could never fail - I don't know how valid that is (these APIs don't document any actual errors). If those two assumptions hold then the current code is correct, otherwise ... something like this: if (( ProcessIdToSessionId( GetCurrentProcessId(), &cSid) != 0) { BOOL result = ProcessIdToSessionId(GetProcessId(hProcess), &pSid); if (result != 0) { // have valid sessionIds if (pSid != cSid) JNU_ThrowIOException(env, "useful message"); // else same session so original memory error stands } else if (GetLastError() == ERROR_ACCESS_DENIED) { // implies that the sessions must be different JNU_ThrowIOException(env, "useful message"); } // else some other error getting other session id } // else some error getting current session Id But this needs to ensure the original error is not lost, and it would be nice not to have two throws statements :( I get the feeling what seemed like a simple suggestion is getting out of control. Feel free to drop this. David ----- > -Alan. From mjw at redhat.com Wed May 23 23:39:19 2012 From: mjw at redhat.com (Mark Wielaard) Date: Thu, 24 May 2012 08:39:19 +0200 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBD1D76.90206@oracle.com> References: <4FBB3555.2080607@oracle.com> <4FBCB9C7.3000304@oracle.com> <4FBCE2B0.3050201@oracle.com> <1337779575.3002.6.camel@springer.wildebeest.org> <4FBCE92C.8010708@oracle.com> <1337781400.3002.17.camel@springer.wildebeest.org> <4FBCF2CF.9000301@oracle.com> <1337789969.3002.25.camel@springer.wildebeest.org> <4FBD0FFE.6060402@oracle.com> <4FBD1D76.90206@oracle.com> Message-ID: <20120524063918.GB2002@toonder.wildebeest.org> On Wed, May 23, 2012 at 10:25:10AM -0700, serguei.spitsyn at oracle.com wrote: > Other action items for this integration: > 1. Test that the HS DTrace are not broken on Solaris If someone who has access to a solaris setup could do that, that would be appreciated. > 2. Find or setup a Linux machine with the systemTap > 3. Check that the fix is built Ok Any recent Fedora release, or RHEL6 release should do, just make sure that the systemtap-sdt-devel package is installed (which contains little more than the /usr/include/sys/sdt.h include file). There are some icedtea autobuilders that should have the build requirements. I'll make sure they are setup correctly. http://builder.classpath.org/icedtea/buildbot/buildslaves > 4. Test that the fix works on Linux > Need a unit test for the fix (Mark, do you have any?) Are there any tests for the solaris functionality? I can probably adapt one to work on gnu/linux. Otherwise I can write something gnu/linux specific. Thanks, Mark From mjw at redhat.com Wed May 23 23:42:01 2012 From: mjw at redhat.com (Mark Wielaard) Date: Thu, 24 May 2012 08:42:01 +0200 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBD2972.5090208@oracle.com> References: <4FBCE2B0.3050201@oracle.com> <1337779575.3002.6.camel@springer.wildebeest.org> <4FBCE92C.8010708@oracle.com> <1337781400.3002.17.camel@springer.wildebeest.org> <4FBCF2CF.9000301@oracle.com> <1337789969.3002.25.camel@springer.wildebeest.org> <4FBD0FFE.6060402@oracle.com> <4FBD1D76.90206@oracle.com> <4FBD2328.2040901@oracle.com> <4FBD2972.5090208@oracle.com> Message-ID: <20120524064201.GC2002@toonder.wildebeest.org> On Wed, May 23, 2012 at 11:16:18AM -0700, serguei.spitsyn at oracle.com wrote: > I forgot to mention another AI: > 5. Submit a CCC request and get an approval > > I'll do this as a background work. > Mark, are you Ok with that? Sure, please do. As far as I understood it, this CCC is just an internal bureaucratic procedure for Oracle employees that I cannot help with because it isn't public. Thanks, Mark From nils.loodin at oracle.com Thu May 24 00:46:55 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Thu, 24 May 2012 09:46:55 +0200 Subject: RFR: 7143353: hprof not working with invokedynamic Message-ID: <039CF08D-DC70-46F8-A4BC-B5280FE08AB2@oracle.com> when the 'demo' java_crw_demo (which is used by hprof) tries to mirror the constant pool of a class, a few of the constants introduced by invokedynamic ins't recognized. Fairly simple fix. For my simple repro, it seems to work with this patch. Also slightly improved the error message for future niceness. Webrev here: http://cr.openjdk.java.net/~nloodin/7143353/webrev.00/ Regards, Nils Loodin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120524/1049ebea/attachment.html From serguei.spitsyn at oracle.com Thu May 24 00:50:00 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 24 May 2012 00:50:00 -0700 Subject: code review for JDK FDS gobjcopy work arounds (7170449) In-Reply-To: <4FBD3F7A.4030501@oracle.com> References: <4FBD3F7A.4030501@oracle.com> Message-ID: <4FBDE828.60303@oracle.com> Dan, I've reviewed the fixes as did not notice any problems. Looks good. Thanks, Serguei On 5/23/12 12:50 PM, Daniel D. Daugherty wrote: > Greetings, > > This is a JDK code review request for a pair of Full Debug Symbols > gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10 > corrupts the SUNW_* sections on objects. This has caused dtrace test > failures and Monitoring & Management test failures. The gobjcopy > utility crashes due to empty sections with the SHF_ALLOC flagset on > Solaris X64 objects. This causes build failures. > > There are two new temporary work around tools: > > add_gnu_debuglink - adds the ".gnu_debuglink" section to an ELF > object without corrupting the other sections in the object. > > fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty > sections in ELF objects. > > These temporary work arounds are only needed until the proper > Solaris 10 Update 6 patches are made available. The two patches > are independent of one another which is why there are two > separate temporary work arounds. However, we're putting the > temporary work arounds in place because the 7u6 project window > is closing fast. > > Here is the webrev URL for the JDK8-T&L version: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7170449-webrev/0/ > > This fix will also be backported to 7u6-T&L and I expect the > changes to virtually identical. > > Thanks, in advance, for any reviews! > > Dan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120524/8d41a268/attachment.html From serguei.spitsyn at oracle.com Thu May 24 00:52:25 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 24 May 2012 00:52:25 -0700 Subject: code review for second hotspot FDS gobjcopy work around (7165598) In-Reply-To: <4FBD41A0.4080408@oracle.com> References: <4FBD41A0.4080408@oracle.com> Message-ID: <4FBDE8B9.2090406@oracle.com> I do not see any issues with that webrev. Looks good. Thanks, Serguei On 5/23/12 12:59 PM, Daniel D. Daugherty wrote: > Greetings, > > This is a hotspot code review request for the second of a pair of > Full Debug Symbols gobjcopy work arounds on Solaris. The first > hotspot FDS gobjcopy work around was reviewed using bug 7165060 > and that fixed the dtrace test failures. > > The gobjcopy utility also crashes due to empty sections with the > SHF_ALLOC flagset on Solaris X64 objects. This causes build > failures. > > The first new temporary work around tool is add_gnu_debuglink > and it was added by 7165060.The second new temporary work around > tool is: > > fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty > sections in ELF objects. > > These temporary work arounds are only needed until the proper > Solaris 10 Update 6 patches are made available. The two patches > are independent of one another which is why there are two > separate temporary work arounds. However, we're putting the > temporary work arounds in place because the 7u6/HSX-23.2 project > window is closing fast. > > Here is the webrev URL for the HSX-24 version: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7165598-webrev/0/ > > This fix will also be backported to 7u6/HSX-23.2 and I expect the > changes to virtually identical. > > Thanks, in advance, for any reviews! > > Dan > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120524/afc69a93/attachment.html From serguei.spitsyn at oracle.com Thu May 24 00:55:51 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 24 May 2012 00:55:51 -0700 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <20120524064201.GC2002@toonder.wildebeest.org> References: <4FBCE2B0.3050201@oracle.com> <1337779575.3002.6.camel@springer.wildebeest.org> <4FBCE92C.8010708@oracle.com> <1337781400.3002.17.camel@springer.wildebeest.org> <4FBCF2CF.9000301@oracle.com> <1337789969.3002.25.camel@springer.wildebeest.org> <4FBD0FFE.6060402@oracle.com> <4FBD1D76.90206@oracle.com> <4FBD2328.2040901@oracle.com> <4FBD2972.5090208@oracle.com> <20120524064201.GC2002@toonder.wildebeest.org> Message-ID: <4FBDE987.9030105@oracle.com> I wanted to say that I'll work on all 5 item actions in a background when get cycles. I'll ask you for help when needed. Thanks, Serguei On 5/23/12 11:42 PM, Mark Wielaard wrote: > On Wed, May 23, 2012 at 11:16:18AM -0700, serguei.spitsyn at oracle.com wrote: >> I forgot to mention another AI: >> 5. Submit a CCC request and get an approval >> >> I'll do this as a background work. >> Mark, are you Ok with that? > Sure, please do. As far as I understood it, this CCC is just an internal > bureaucratic procedure for Oracle employees that I cannot help with > because it isn't public. > > Thanks, > > Mark -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120524/848a7685/attachment-0001.html From john.r.rose at oracle.com Thu May 24 01:01:35 2012 From: john.r.rose at oracle.com (John Rose) Date: Thu, 24 May 2012 01:01:35 -0700 Subject: RFR: 7143353: hprof not working with invokedynamic In-Reply-To: <039CF08D-DC70-46F8-A4BC-B5280FE08AB2@oracle.com> References: <039CF08D-DC70-46F8-A4BC-B5280FE08AB2@oracle.com> Message-ID: <4AB76CD2-3BE6-469D-B287-622202A644FF@oracle.com> Looks good. (General rule: Adding constant pool types causes lots of ripples like this.) ? John On May 24, 2012, at 12:46 AM, Nils Loodin wrote: > when the 'demo' java_crw_demo (which is used by hprof) tries to mirror the constant pool of a class, a few of the constants introduced by invokedynamic ins't recognized. > Fairly simple fix. For my simple repro, it seems to work with this patch. > > Also slightly improved the error message for future niceness. > > Webrev here: > http://cr.openjdk.java.net/~nloodin/7143353/webrev.00/ > > Regards, > Nils Loodin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120524/d3e0c676/attachment.html From rickard.backman at oracle.com Thu May 24 01:15:42 2012 From: rickard.backman at oracle.com (=?ISO-8859-1?Q?Rickard_B=E4ckman?=) Date: Thu, 24 May 2012 10:15:42 +0200 Subject: RFR: 7143353: hprof not working with invokedynamic In-Reply-To: <039CF08D-DC70-46F8-A4BC-B5280FE08AB2@oracle.com> References: <039CF08D-DC70-46F8-A4BC-B5280FE08AB2@oracle.com> Message-ID: <4FBDEE2E.2050309@oracle.com> Looks good. /R On 05/24/2012 09:46 AM, Nils Loodin wrote: > when the 'demo' java_crw_demo (which is used by hprof) tries to mirror the constant pool of a class, a few of the constants introduced by invokedynamic ins't recognized. > Fairly simple fix. For my simple repro, it seems to work with this patch. > > Also slightly improved the error message for future niceness. > > Webrev here: > http://cr.openjdk.java.net/~nloodin/7143353/webrev.00/ > > Regards, > Nils Loodin From serguei.spitsyn at oracle.com Thu May 24 01:17:42 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 24 May 2012 01:17:42 -0700 Subject: RFR: 7143353: hprof not working with invokedynamic In-Reply-To: <039CF08D-DC70-46F8-A4BC-B5280FE08AB2@oracle.com> References: <039CF08D-DC70-46F8-A4BC-B5280FE08AB2@oracle.com> Message-ID: <4FBDEEA6.70907@oracle.com> Looks good. Thanks, Serguei On 5/24/12 12:46 AM, Nils Loodin wrote: > when the 'demo' java_crw_demo (which is used by hprof) tries to mirror > the constant pool of a class, a few of the constants introduced by > invokedynamic ins't recognized. > Fairly simple fix. For my simple repro, it seems to work with this patch. > > Also slightly improved the error message for future niceness. > > Webrev here: > http://cr.openjdk.java.net/~nloodin/7143353/webrev.00/ > > > Regards, > Nils Loodin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120524/cae04978/attachment.html From nils.loodin at oracle.com Thu May 24 01:45:26 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Thu, 24 May 2012 10:45:26 +0200 Subject: RFR: 7143353: hprof not working with invokedynamic In-Reply-To: <4AB76CD2-3BE6-469D-B287-622202A644FF@oracle.com> References: <039CF08D-DC70-46F8-A4BC-B5280FE08AB2@oracle.com> <4AB76CD2-3BE6-469D-B287-622202A644FF@oracle.com> Message-ID: <1EBAC571-18A0-49AB-A0B6-D9294847C316@oracle.com> Guess this could be mitigated by some form of testing? ;) /Nisse On May 24, 2012, at 10:01 , John Rose wrote: > Looks good. > > (General rule: Adding constant pool types causes lots of ripples like this.) > > ? John > > On May 24, 2012, at 12:46 AM, Nils Loodin wrote: > >> when the 'demo' java_crw_demo (which is used by hprof) tries to mirror the constant pool of a class, a few of the constants introduced by invokedynamic ins't recognized. >> Fairly simple fix. For my simple repro, it seems to work with this patch. >> >> Also slightly improved the error message for future niceness. >> >> Webrev here: >> http://cr.openjdk.java.net/~nloodin/7143353/webrev.00/ >> >> Regards, >> Nils Loodin > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120524/91447b04/attachment.html From mjw at redhat.com Thu May 24 02:54:47 2012 From: mjw at redhat.com (Mark Wielaard) Date: Thu, 24 May 2012 11:54:47 +0200 Subject: [PATCH 0 of 3] Add support for dtrace compatible sdt probes on GNU/Linux In-Reply-To: <4FBDE987.9030105@oracle.com> References: <4FBCE2B0.3050201@oracle.com> <1337779575.3002.6.camel@springer.wildebeest.org> <4FBCE92C.8010708@oracle.com> <1337781400.3002.17.camel@springer.wildebeest.org> <4FBCF2CF.9000301@oracle.com> <1337789969.3002.25.camel@springer.wildebeest.org> <4FBD0FFE.6060402@oracle.com> <4FBD1D76.90206@oracle.com> <4FBD2328.2040901@oracle.com> <4FBD2972.5090208@oracle.com> <20120524064201.GC2002@toonder.wildebeest.org> <4FBDE987.9030105@oracle.com> Message-ID: <1337853287.2954.2.camel@springer.wildebeest.org> On Thu, 2012-05-24 at 00:55 -0700, serguei.spitsyn at oracle.com wrote: > I wanted to say that I'll work on all 5 item actions in a background > when get cycles. > I'll ask you for help when needed. Sure. Could you indicate if that means days or weeks? I am more than willing to help polish the code and help with the process so that it finally gets committed sooner rather than later. Thanks, Mark From daniel.daugherty at oracle.com Thu May 24 04:40:12 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 24 May 2012 05:40:12 -0600 Subject: code review for JDK FDS gobjcopy work arounds (7170449) In-Reply-To: <4FBDE828.60303@oracle.com> References: <4FBD3F7A.4030501@oracle.com> <4FBDE828.60303@oracle.com> Message-ID: <4FBE1E1C.7080508@oracle.com> Thanks Serguei! Dan On 5/24/12 1:50 AM, serguei.spitsyn at oracle.com wrote: > Dan, > > I've reviewed the fixes as did not notice any problems. > Looks good. > > Thanks, > Serguei > > On 5/23/12 12:50 PM, Daniel D. Daugherty wrote: >> Greetings, >> >> This is a JDK code review request for a pair of Full Debug Symbols >> gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10 >> corrupts the SUNW_* sections on objects. This has caused dtrace test >> failures and Monitoring & Management test failures. The gobjcopy >> utility crashes due to empty sections with the SHF_ALLOC flagset on >> Solaris X64 objects. This causes build failures. >> >> There are two new temporary work around tools: >> >> add_gnu_debuglink - adds the ".gnu_debuglink" section to an ELF >> object without corrupting the other sections in the object. >> >> fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty >> sections in ELF objects. >> >> These temporary work arounds are only needed until the proper >> Solaris 10 Update 6 patches are made available. The two patches >> are independent of one another which is why there are two >> separate temporary work arounds. However, we're putting the >> temporary work arounds in place because the 7u6 project window >> is closing fast. >> >> Here is the webrev URL for the JDK8-T&L version: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7170449-webrev/0/ >> >> This fix will also be backported to 7u6-T&L and I expect the >> changes to virtually identical. >> >> Thanks, in advance, for any reviews! >> >> Dan >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120524/7b2fd8d4/attachment.html From rickard.backman at oracle.com Thu May 24 05:16:15 2012 From: rickard.backman at oracle.com (=?UTF-8?B?Umlja2FyZCBCw6Rja21hbg==?=) Date: Thu, 24 May 2012 14:16:15 +0200 Subject: RFR: CR7171422: Change 7161732 breaks SA on Windows Message-ID: <4FBE268F.6040107@oracle.com> Hi, my refactoring broke the SA on Windows, the only platform that didn't have a declaration of the thread_id type in vmStructs. This change adds the declares the field as an unsigned integer. Tested by building in JPRT and connecting with jsadebugd.exe on Win64. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171422 Webrev: http://cr.openjdk.java.net/~rbackman/7171422/webrev/ Thanks /R From david.holmes at oracle.com Thu May 24 05:28:01 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 24 May 2012 22:28:01 +1000 Subject: RFR: CR7171422: Change 7161732 breaks SA on Windows In-Reply-To: <4FBE268F.6040107@oracle.com> References: <4FBE268F.6040107@oracle.com> Message-ID: <4FBE2951.3010903@oracle.com> OK. David On 24/05/2012 10:16 PM, Rickard B?ckman wrote: > Hi, > > my refactoring broke the SA on Windows, the only platform that didn't > have a declaration of the thread_id type in vmStructs. > > This change adds the declares the field as an unsigned integer. > Tested by building in JPRT and connecting with jsadebugd.exe on Win64. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171422 > Webrev: http://cr.openjdk.java.net/~rbackman/7171422/webrev/ > > Thanks > /R From rickard.backman at oracle.com Thu May 24 05:31:29 2012 From: rickard.backman at oracle.com (=?UTF-8?B?Umlja2FyZCBCw6Rja21hbg==?=) Date: Thu, 24 May 2012 14:31:29 +0200 Subject: RFR: CR7171422: Change 7161732 breaks SA on Windows In-Reply-To: <4FBE2951.3010903@oracle.com> References: <4FBE268F.6040107@oracle.com> <4FBE2951.3010903@oracle.com> Message-ID: <4FBE2A21.70509@oracle.com> Thank you for the quick review David. /R On 05/24/2012 02:28 PM, David Holmes wrote: > OK. > > David > > On 24/05/2012 10:16 PM, Rickard B?ckman wrote: >> Hi, >> >> my refactoring broke the SA on Windows, the only platform that didn't >> have a declaration of the thread_id type in vmStructs. >> >> This change adds the declares the field as an unsigned integer. >> Tested by building in JPRT and connecting with jsadebugd.exe on Win64. >> >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171422 >> Webrev: http://cr.openjdk.java.net/~rbackman/7171422/webrev/ >> >> Thanks >> /R From alan.bateman at oracle.com Thu May 24 05:44:52 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 24 May 2012 12:44:52 +0000 Subject: hg: jdk8/tl/jdk: 7169050: (se) Selector.select slow on Solaris due to insertion of POLLREMOVE and 0 events Message-ID: <20120524124502.74760474C1@hg.openjdk.java.net> Changeset: 21703d431217 Author: alanb Date: 2012-05-24 10:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21703d431217 7169050: (se) Selector.select slow on Solaris due to insertion of POLLREMOVE and 0 events Reviewed-by: chegar, coffeys ! src/solaris/classes/sun/nio/ch/DevPollArrayWrapper.java ! src/solaris/native/sun/nio/ch/DevPollArrayWrapper.c From staffan.larsen at oracle.com Thu May 24 05:51:55 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 24 May 2012 14:51:55 +0200 Subject: RFR: CR7171422: Change 7161732 breaks SA on Windows In-Reply-To: <4FBE268F.6040107@oracle.com> References: <4FBE268F.6040107@oracle.com> Message-ID: <86D6E755-D6E5-49A3-9392-2F04FE8E024A@oracle.com> Looks good. /Staffan On 24 maj 2012, at 14:16, Rickard B?ckman wrote: > Hi, > > my refactoring broke the SA on Windows, the only platform that didn't have a declaration of the thread_id type in vmStructs. > > This change adds the declares the field as an unsigned integer. > Tested by building in JPRT and connecting with jsadebugd.exe on Win64. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171422 > Webrev: http://cr.openjdk.java.net/~rbackman/7171422/webrev/ > > Thanks > /R From rickard.backman at oracle.com Thu May 24 05:56:40 2012 From: rickard.backman at oracle.com (=?ISO-8859-1?Q?Rickard_B=E4ckman?=) Date: Thu, 24 May 2012 14:56:40 +0200 Subject: RFR: CR7171422: Change 7161732 breaks SA on Windows In-Reply-To: <86D6E755-D6E5-49A3-9392-2F04FE8E024A@oracle.com> References: <4FBE268F.6040107@oracle.com> <86D6E755-D6E5-49A3-9392-2F04FE8E024A@oracle.com> Message-ID: <4FBE3008.9080903@oracle.com> Thanks Staffan! /R On 05/24/2012 02:51 PM, Staffan Larsen wrote: > Looks good. > > /Staffan > > On 24 maj 2012, at 14:16, Rickard B?ckman wrote: > >> Hi, >> >> my refactoring broke the SA on Windows, the only platform that didn't have a declaration of the thread_id type in vmStructs. >> >> This change adds the declares the field as an unsigned integer. >> Tested by building in JPRT and connecting with jsadebugd.exe on Win64. >> >> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171422 >> Webrev: http://cr.openjdk.java.net/~rbackman/7171422/webrev/ >> >> Thanks >> /R > From daniel.daugherty at oracle.com Thu May 24 06:04:45 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 24 May 2012 07:04:45 -0600 Subject: code review for second hotspot FDS gobjcopy work around (7165598) In-Reply-To: <4FBDE8B9.2090406@oracle.com> References: <4FBD41A0.4080408@oracle.com> <4FBDE8B9.2090406@oracle.com> Message-ID: <4FBE31ED.3040101@oracle.com> Thanks Serguei! Dan On 5/24/12 1:52 AM, serguei.spitsyn at oracle.com wrote: > I do not see any issues with that webrev. > Looks good. > > Thanks, > Serguei > > On 5/23/12 12:59 PM, Daniel D. Daugherty wrote: >> Greetings, >> >> This is a hotspot code review request for the second of a pair of >> Full Debug Symbols gobjcopy work arounds on Solaris. The first >> hotspot FDS gobjcopy work around was reviewed using bug 7165060 >> and that fixed the dtrace test failures. >> >> The gobjcopy utility also crashes due to empty sections with the >> SHF_ALLOC flagset on Solaris X64 objects. This causes build >> failures. >> >> The first new temporary work around tool is add_gnu_debuglink >> and it was added by 7165060.The second new temporary work around >> tool is: >> >> fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty >> sections in ELF objects. >> >> These temporary work arounds are only needed until the proper >> Solaris 10 Update 6 patches are made available. The two patches >> are independent of one another which is why there are two >> separate temporary work arounds. However, we're putting the >> temporary work arounds in place because the 7u6/HSX-23.2 project >> window is closing fast. >> >> Here is the webrev URL for the HSX-24 version: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7165598-webrev/0/ >> >> This fix will also be backported to 7u6/HSX-23.2 and I expect the >> changes to virtually identical. >> >> Thanks, in advance, for any reviews! >> >> Dan >> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120524/5b62c72b/attachment.html From alan.bateman at oracle.com Thu May 24 06:45:35 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 24 May 2012 13:45:35 +0000 Subject: hg: jdk8/tl/jdk: 7160725: Strange or obsolete @see tags in some exception java.lang javadoc Message-ID: <20120524134553.D7082474C5@hg.openjdk.java.net> Changeset: a11c964d1319 Author: jgish Date: 2012-05-24 14:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a11c964d1319 7160725: Strange or obsolete @see tags in some exception java.lang javadoc Summary: update javadoc for IllegalArgumentException and NumberFormatException Reviewed-by: alanb ! src/share/classes/java/lang/IllegalArgumentException.java From nils.loodin at oracle.com Thu May 24 07:21:40 2012 From: nils.loodin at oracle.com (nils.loodin at oracle.com) Date: Thu, 24 May 2012 14:21:40 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20120524142201.04CAA474C6@hg.openjdk.java.net> Changeset: 5ec5588c733d Author: nloodin Date: 2012-05-24 09:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ec5588c733d 7143353: -Xrunhprof fails in Java 7 due to bad switch Reviewed-by: jrose, sspitsyn ! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c ! src/share/javavm/export/classfile_constants.h Changeset: 1c869c799ef9 Author: nloodin Date: 2012-05-24 10:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c869c799ef9 Merge From karen.kinnear at oracle.com Thu May 24 07:28:46 2012 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Thu, 24 May 2012 10:28:46 -0400 Subject: code review for second hotspot FDS gobjcopy work around (7165598) In-Reply-To: <4FBD41A0.4080408@oracle.com> References: <4FBD41A0.4080408@oracle.com> Message-ID: <780948D8-5796-4052-932E-D5AA099250A0@oracle.com> Dan, Code looks good. Thank you for the work-around. So is this HDR_FLAGS workaround also needed in all the other jdk repositories? And I assume the windows/makefiles/defs.make change is because you determined that the failing tests actually pre-dated the zipped debuginfo. Did you find the root cause for that yet, or is that an orthogonal topic? And this also appears to have additional modifications for the earlier workaround add_gnu_debuglink. I has assumed in reviewing 7165060 that you only used that for makefiles that built with DOF sections, i.e. libjvm.so and that you had chosen not to use the simpler add_gnu_debuglink in all cases, even though it is generally less risky. Did you change your approach here? Your comment was changed from SUNW_DOF to SUNW_*. That makes sense to me. And are you also changing that for the other jdk repositories? thanks, Karen On May 23, 2012, at 3:59 PM, Daniel D. Daugherty wrote: > Greetings, > > This is a hotspot code review request for the second of a pair of > Full Debug Symbols gobjcopy work arounds on Solaris. The first > hotspot FDS gobjcopy work around was reviewed using bug 7165060 > and that fixed the dtrace test failures. > > The gobjcopy utility also crashes due to empty sections with the > SHF_ALLOC flagset on Solaris X64 objects. This causes build > failures. > > The first new temporary work around tool is add_gnu_debuglink > and it was added by 7165060.The second new temporary work around > tool is: > > fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty > sections in ELF objects. > > These temporary work arounds are only needed until the proper > Solaris 10 Update 6 patches are made available. The two patches > are independent of one another which is why there are two > separate temporary work arounds. However, we're putting the > temporary work arounds in place because the 7u6/HSX-23.2 project > window is closing fast. > > Here is the webrev URL for the HSX-24 version: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7165598-webrev/0/ > > This fix will also be backported to 7u6/HSX-23.2 and I expect the > changes to virtually identical. > > Thanks, in advance, for any reviews! > > Dan > > From kelly.ohair at oracle.com Thu May 24 08:19:25 2012 From: kelly.ohair at oracle.com (Kelly O'Hair) Date: Thu, 24 May 2012 08:19:25 -0700 Subject: RFR: 7143353: hprof not working with invokedynamic In-Reply-To: <039CF08D-DC70-46F8-A4BC-B5280FE08AB2@oracle.com> References: <039CF08D-DC70-46F8-A4BC-B5280FE08AB2@oracle.com> Message-ID: The stack requirements (char message[BUFSIZE]) for this method increasing by 256 all the time seems unnecessary, a fixed string plus two numerics doesn't need 256 characters anyway, does it? Not sure it matters that much in this case since it isn't in any kind of recursive call situation. Fixed buffers bumping up the stack size needed always make my eye twitch. Worked in compilers too long. :^( But I don't see anything logically wrong with the change. -kto On May 24, 2012, at 12:46 AM, Nils Loodin wrote: > when the 'demo' java_crw_demo (which is used by hprof) tries to mirror the constant pool of a class, a few of the constants introduced by invokedynamic ins't recognized. > Fairly simple fix. For my simple repro, it seems to work with this patch. > > Also slightly improved the error message for future niceness. > > Webrev here: > http://cr.openjdk.java.net/~nloodin/7143353/webrev.00/ > > Regards, > Nils Loodin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120524/a6d1a212/attachment.html From karen.kinnear at oracle.com Thu May 24 08:30:25 2012 From: karen.kinnear at oracle.com (karen.kinnear at oracle.com) Date: Thu, 24 May 2012 15:30:25 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7171422: Change 7161732 breaks SA on Windows Message-ID: <20120524153029.5C637474C7@hg.openjdk.java.net> Changeset: df84b4a3ebcb Author: rbackman Date: 2012-05-24 13:37 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/df84b4a3ebcb 7171422: Change 7161732 breaks SA on Windows Reviewed-by: dholmes, sla ! src/os_cpu/windows_x86/vm/vmStructs_windows_x86.hpp From daniel.daugherty at oracle.com Thu May 24 09:01:55 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 24 May 2012 10:01:55 -0600 Subject: code review for second hotspot FDS gobjcopy work around (7165598) In-Reply-To: <780948D8-5796-4052-932E-D5AA099250A0@oracle.com> References: <4FBD41A0.4080408@oracle.com> <780948D8-5796-4052-932E-D5AA099250A0@oracle.com> Message-ID: <4FBE5B73.5090702@oracle.com> On 5/24/12 8:28 AM, Karen Kinnear wrote: > Dan, > > Code looks good. Thanks! > Thank you for the work-around. > > So is this HDR_FLAGS workaround also needed in all the other jdk repositories? SHF_ALLOC flag? We know that gobjcopy crashes when running into empty ELF sections where the SHF_ALLOC flag is set. We have only seen the loader (ld) generate empty ELF sections with the SHF_ALLOC flag set when compiling for Solaris X64. However, it seems safer to me to always apply the work around when building on Solaris just to be sure. The fix_empty_sec_hdr_flags prints a diagnostic message when it modifies an ELF object so we can check build logs periodically to verify which Solaris builds are affected. > And I assume the windows/makefiles/defs.make change is because you determined > that the failing tests actually pre-dated the zipped debuginfo. Correct. ZIP'ing the .pdb and .map files was not the cause of library loading failures. > Did you find the root cause for that > yet, or is that an orthogonal topic? Evgeny's team found that several Windows machines were missing the msvcr71.dll library. That version of the MS runtime is needed by the affected testbase(s) (just VM/NSK I think, not sure). > And this also appears to have additional modifications for the earlier workaround add_gnu_debuglink. Yes, after getting hit by the M&M test failures on Solaris 11, I decided to apply the add_gnu_debuglink work around to every FDS use of gobjcopy. > I has assumed in reviewing 7165060 that you only used that for makefiles that built with DOF sections, > i.e. libjvm.so and that you had chosen not to use the simpler add_gnu_debuglink in all cases, even though > it is generally less risky. Did you change your approach here? Yes, I've changed approaches due to the unexpected M&M failures. I was originally balancing the risk of changing more Makefiles to use the add_gnu_debuglink work around versus the risk that gobjcopy would screw up some other ELF section in ways that we couldn't easily detect. In hindsight, I should have gone with using the add_gnu_debuglink because the changes that it makes to an ELF object are rather easy to verify as correct by comparing two elfdump output files. > Your comment was changed from SUNW_DOF to > SUNW_*. That makes sense to me. Yes, Dean's guess is that the SUNW_cap section is what the M&M tests were relying on and when gobjcopy munged it, the tests started to fail on Solaris 11. Interesting data points: the tests don't fail on Solaris 10 or on a recent Solaris 11 Update 1 build (I used jurassic for a quick test). So whatever gobjcopy did to the SUNW_cap section is properly handled by newer Solaris 11 versions... > And are you also changing that for > the other jdk repositories? Yes, please search for 7170449 in your InBox and you'll see that review thread. I would love to have your review there also. Dan > thanks, > Karen > > On May 23, 2012, at 3:59 PM, Daniel D. Daugherty wrote: > >> Greetings, >> >> This is a hotspot code review request for the second of a pair of >> Full Debug Symbols gobjcopy work arounds on Solaris. The first >> hotspot FDS gobjcopy work around was reviewed using bug 7165060 >> and that fixed the dtrace test failures. >> >> The gobjcopy utility also crashes due to empty sections with the >> SHF_ALLOC flagset on Solaris X64 objects. This causes build >> failures. >> >> The first new temporary work around tool is add_gnu_debuglink >> and it was added by 7165060.The second new temporary work around >> tool is: >> >> fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty >> sections in ELF objects. >> >> These temporary work arounds are only needed until the proper >> Solaris 10 Update 6 patches are made available. The two patches >> are independent of one another which is why there are two >> separate temporary work arounds. However, we're putting the >> temporary work arounds in place because the 7u6/HSX-23.2 project >> window is closing fast. >> >> Here is the webrev URL for the HSX-24 version: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7165598-webrev/0/ >> >> This fix will also be backported to 7u6/HSX-23.2 and I expect the >> changes to virtually identical. >> >> Thanks, in advance, for any reviews! >> >> Dan >> >> From erik.gahlin at oracle.com Thu May 24 09:20:05 2012 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Thu, 24 May 2012 18:20:05 +0200 Subject: RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team In-Reply-To: <4FBC0A03.2000906@oracle.com> References: <4FAD23E4.90501@oracle.com> <4FAD3B63.8070501@oracle.com> <4FBA2477.7040101@oracle.com> <4FBAAFEA.6090305@oracle.com> <4FBBEB98.50704@oracle.com> <4FBC0A03.2000906@oracle.com> Message-ID: <4FBE5FB5.3080909@oracle.com> Here is an updated webrev: http://cr.openjdk.java.net/~egahlin/7017818_6/ Changes from previous webrev: - Removed all @SuppressWarning changes - Moved the Messages class from sun.tools.jconsole.resource to sun.tools.jconsole and updated the makefile - Aligned parameters in the method calls. - Changed CONNECTION_LOST back to CONNECTION_LOST1 and kept message keys as is since they should work with the property files sent away. Erik Mandy Chung skrev 2012-05-22 23:49: > Erik, > > I approve what you have - please go through and fix the formatting > nits. I inlined my comment below and you can follow up them later if > needed. > > On 5/22/2012 12:40 PM, Erik Gahlin wrote: >> Thanks for reviewing, >> >> I got a lot of unused import warnings from the IDE when I changed the >> Resources class. When I cleaned them up I thought I might as well >> clean up the >> others too, so I could more easily see that I had taken care of all the >> warnings I caused. Same thing with unused member variables and unused >> methods. >> >> Import-statements will not change how the program executes, so I >> thought it >> was safe to remove them (no risk of introducing new bugs). >> >> ... >>> Anyway, >>> the warning cleanup deserves a separate CR and review. >> Breaking it up into seperate patches and CRs will take time. Is it really >> necessary? > > I'm okay for this patch to include the removal of unused imports and > dead code fixes. The warnings I referred to are the > @SuppressedWarnings("serial") and rawtypes changes since it may > require a separate pair of eyes to review them. As a general advice, > when the number of warnings cleaned up is not small, it's always > recommended to separate them as two separate CRs for bug management > and backport and it also helps the reviewers :) > > Since you have made the change along with the fix for this CR, I can > understand why you said it will take time. I also understand that > you're under a time pressure. I can go with what you have but please > consider in the future when to separate the change in a separate CR. > > >> >> I cleaned up the code so I could make the fix more easily. I don't >> think it's >> worth the hazzle to create a separate bug and patch. I might as well >> revert >> the clean ups. >> > > BTW, backporting to an update release might request not to include the > warnings cleanup. I'm not sure the putback approval requirements for 7u6. > >>> >>> Below are comments on the change to support translateability. >>> >>> sun/tools/jconsole/resources/Messages.java >>> I suggest to move Messages to sun.tools.jconsole since >>> it's a utility class and conventionally resources are put >>> in a "resources" subpackage (i.e. sun.tools.jconsole.resources >>> in this case). >> I think one package private Message class for each package and separate >> resource files for each package would be the best, but I didn't want >> this CR to blow up, so I put the Message class where the other Java >> classes >> related to resources were before. >> >> I can move it to sun.tools.jconsole, if you think that's better. >> > > I think so so that sun.tools.jconsole.resources.* are resource files. > >>> >>> The initializeMessage method uses the field name as the >>> key and initializes its value to its localized message via >>> reflection. Such approach seems strange. >> I like to enforce one-to-one mapping between the keys in the property >> file and >> the keys used in the Java code. When going through the fields in the >> Message >> class, using reflection, I can ensure that all fields have a >> corresponding >> property value in the file, and vice versa. >> >> With this approrach it's not necessary click through all the GUI to >> verify that >> all keys exists in the property file. It's also possible to detect if >> a value >> in a property file is no longer in use. >> >> The code that does the one-to-one check was removed, but it should >> probably be >> added back so similar problems can be catched automatically in the >> future. >> >>> >>> Have you considered about defining the constants with >>> the key as the value (i.e. the variable name and its >>> value are the same). >> The Java constants can't be the same as the property value > > I meant the key value in messages.properties (not the property value). > Essentially variable and the value is the same e.g. static final > String ONE_DAY = "ONE_DAY"; > >>> Instead of initializing each >>> static field of the Messages class, you can build >>> a map of a key to the localized message + itsmnemonic >>> key (like what you have done in building the MNEMONIC_LOOKUP >>> map - why not change such hash map to map from a string to >>> an object {message+mnemonic}). In that case, the MNEMONIC_LOOKUP >>> doesn't need to be a synchronized map and could be done >>> as the class initialization of Resources class. >>> >>> It would only need to keep >>> Resources.getText(String) method that returns the localized >>> message, e.g. >>> Resources.getText(Messages.HELP_ABOUT_DIALOG_TITLE) >>> >>> I just don't see it's worth the complexity to initialize >>> the static fields via reflection to get rid of a convenience >>> method. >> >> The synchronization is not really needed, if you always use the keys to >> lookup the messages. The static initializer in the Message class should >> ensure correct ordering. >> >> Looking up messages "dynamically" means you have to trigger all the >> code in the GUI that needs a translated message to be sure you got >> things >> correct. Since there are several hundred messages I think the >> static-fields-reflection approach is better. >> >>> >>> >>> It is only my suggestion and I understand that this fix needs >>> to be backport to 7u6. If you agree that replacing this >>> static field initialization logic with a separate map, >>> I'm okay with pushing this approach to 7u6 and push >>> a better fix to jdk8. Or I miss the benefit you were >>> considering :) >> >> You are missing it :) >> >> .. and it's probably because I removed the code that did the actual >> check :) >> > > I agree that checking one-to-one mapping between the keys in the > property file and > the keys used in the Java code is good. What you need is to compare > the list of constants with the keys in messages.properties. Anyway, > my suggestion was just to simplify such initialization. You can go > with what you have. > >>> >>> There are a few names with '_' suffix e.g. L93, 97, 104, 160 >>> and also some names with '__' (L97, 159). Do you want to >>> embed the space of the message in the key name? In any case, >>> the key names with '_' suffix or double underscores '__' is >>> a little confusing. It would be better just to use '_' for >>> separating words of a key name and no need for '_' suffix. >>> The names 'CHART_COLON', 'ERROR_COLON_MBEANS...', 'JCONSOLE_COLON', >>> and the ones with 'COLON' to describe its message with ":" >>> are strange. If ":" was removed from the message in the >>> future, the name would need to be modified to follow this >>> naming convention which is overkill. >> The keys were generated programmatically. >> > > Ah - that's what I guess. > >> The 'COLON' was needed so I could differentiate between message that >> looked >> the same, except for the ':' at the end. The pattern was applied to all >> messages. Some of those message were removed (since they were no >> longer in use) >> >> I can remove the 'COLON' suffix where it's not needed, same thing >> with spaces. >> > > That'd be good since "COLON" and '_' is meaningless w.r.t. the key > name. IDE refactoring feature should make this renaming effortless :) > >> I will go over the message keys and clean up the names, but they were >> not that >> clean before either :) > > Thanks. > Mandy -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120524/dafcf13c/attachment-0001.html From karen.kinnear at oracle.com Thu May 24 09:33:22 2012 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Thu, 24 May 2012 12:33:22 -0400 Subject: code review for JDK FDS gobjcopy work arounds (7170449) In-Reply-To: <4FBD3F7A.4030501@oracle.com> References: <4FBD3F7A.4030501@oracle.com> Message-ID: Looks good. Thank you. thanks, Karen On May 23, 2012, at 3:50 PM, Daniel D. Daugherty wrote: > Greetings, > > This is a JDK code review request for a pair of Full Debug Symbols > gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10 > corrupts the SUNW_* sections on objects. This has caused dtrace test > failures and Monitoring & Management test failures. The gobjcopy > utility crashes due to empty sections with the SHF_ALLOC flagset on > Solaris X64 objects. This causes build failures. > > There are two new temporary work around tools: > > add_gnu_debuglink - adds the ".gnu_debuglink" section to an ELF > object without corrupting the other sections in the object. > > fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty > sections in ELF objects. > > These temporary work arounds are only needed until the proper > Solaris 10 Update 6 patches are made available. The two patches > are independent of one another which is why there are two > separate temporary work arounds. However, we're putting the > temporary work arounds in place because the 7u6 project window > is closing fast. > > Here is the webrev URL for the JDK8-T&L version: > > http://cr.openjdk.java.net/~dcubed/fds_revamp/7170449-webrev/0/ > > This fix will also be backported to 7u6-T&L and I expect the > changes to virtually identical. > > Thanks, in advance, for any reviews! > > Dan > > From daniel.daugherty at oracle.com Thu May 24 09:49:22 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 24 May 2012 10:49:22 -0600 Subject: code review for JDK FDS gobjcopy work arounds (7170449) In-Reply-To: References: <4FBD3F7A.4030501@oracle.com> Message-ID: <4FBE6692.1050706@oracle.com> Thanks for the review! Dan On 5/24/12 10:33 AM, Karen Kinnear wrote: > Looks good. Thank you. > > thanks, > Karen > > On May 23, 2012, at 3:50 PM, Daniel D. Daugherty wrote: > >> Greetings, >> >> This is a JDK code review request for a pair of Full Debug Symbols >> gobjcopy work arounds on Solaris. The gobjcopy utility on Solaris 10 >> corrupts the SUNW_* sections on objects. This has caused dtrace test >> failures and Monitoring& Management test failures. The gobjcopy >> utility crashes due to empty sections with the SHF_ALLOC flagset on >> Solaris X64 objects. This causes build failures. >> >> There are two new temporary work around tools: >> >> add_gnu_debuglink - adds the ".gnu_debuglink" section to an ELF >> object without corrupting the other sections in the object. >> >> fix_empty_sec_hdr_flags - removes the SHF_ALLOC flag from empty >> sections in ELF objects. >> >> These temporary work arounds are only needed until the proper >> Solaris 10 Update 6 patches are made available. The two patches >> are independent of one another which is why there are two >> separate temporary work arounds. However, we're putting the >> temporary work arounds in place because the 7u6 project window >> is closing fast. >> >> Here is the webrev URL for the JDK8-T&L version: >> >> http://cr.openjdk.java.net/~dcubed/fds_revamp/7170449-webrev/0/ >> >> This fix will also be backported to 7u6-T&L and I expect the >> changes to virtually identical. >> >> Thanks, in advance, for any reviews! >> >> Dan >> >> > From mandy.chung at oracle.com Thu May 24 10:00:36 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 24 May 2012 10:00:36 -0700 Subject: RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team In-Reply-To: <4FBE5FB5.3080909@oracle.com> References: <4FAD23E4.90501@oracle.com> <4FAD3B63.8070501@oracle.com> <4FBA2477.7040101@oracle.com> <4FBAAFEA.6090305@oracle.com> <4FBBEB98.50704@oracle.com> <4FBC0A03.2000906@oracle.com> <4FBE5FB5.3080909@oracle.com> Message-ID: <4FBE6934.7020101@oracle.com> Thumbs up. Minor comment (no need for new webrev if you fix it): Resources.java L46: the AssertionError is not needed since it can't get there. L133: would it be better to throw an internal error here to catch any regression e.g. if isWriteField is modified incorrectly for whatever reason? Messages.java - it'd be good to add a comment there to describe that the names are auto-generated and there are some names with double underscore or ends with '_' that will help anyone who has question if they are typos or some convention we should follow. Mandy On 5/24/2012 9:20 AM, Erik Gahlin wrote: > Here is an updated webrev: > http://cr.openjdk.java.net/~egahlin/7017818_6/ > > Changes from previous webrev: > > - Removed all @SuppressWarning changes > - Moved the Messages class from sun.tools.jconsole.resource to > sun.tools.jconsole and updated the makefile > - Aligned parameters in the method calls. > - Changed CONNECTION_LOST back to CONNECTION_LOST1 and kept message > keys as is since they should work with the property files sent away. > > Erik > > Mandy Chung skrev 2012-05-22 23:49: >> Erik, >> >> I approve what you have - please go through and fix the formatting >> nits. I inlined my comment below and you can follow up them later if >> needed. >> >> On 5/22/2012 12:40 PM, Erik Gahlin wrote: >>> Thanks for reviewing, >>> >>> I got a lot of unused import warnings from the IDE when I changed the >>> Resources class. When I cleaned them up I thought I might as well >>> clean up the >>> others too, so I could more easily see that I had taken care of all the >>> warnings I caused. Same thing with unused member variables and >>> unused methods. >>> >>> Import-statements will not change how the program executes, so I >>> thought it >>> was safe to remove them (no risk of introducing new bugs). >>> >>> ... >>>> Anyway, >>>> the warning cleanup deserves a separate CR and review. >>> Breaking it up into seperate patches and CRs will take time. Is it >>> really >>> necessary? >> >> I'm okay for this patch to include the removal of unused imports and >> dead code fixes. The warnings I referred to are the >> @SuppressedWarnings("serial") and rawtypes changes since it may >> require a separate pair of eyes to review them. As a general >> advice, when the number of warnings cleaned up is not small, it's >> always recommended to separate them as two separate CRs for bug >> management and backport and it also helps the reviewers :) >> >> Since you have made the change along with the fix for this CR, I can >> understand why you said it will take time. I also understand that >> you're under a time pressure. I can go with what you have but please >> consider in the future when to separate the change in a separate CR. >> >> >>> >>> I cleaned up the code so I could make the fix more easily. I don't >>> think it's >>> worth the hazzle to create a separate bug and patch. I might as well >>> revert >>> the clean ups. >>> >> >> BTW, backporting to an update release might request not to include >> the warnings cleanup. I'm not sure the putback approval requirements >> for 7u6. >> >>>> >>>> Below are comments on the change to support translateability. >>>> >>>> sun/tools/jconsole/resources/Messages.java >>>> I suggest to move Messages to sun.tools.jconsole since >>>> it's a utility class and conventionally resources are put >>>> in a "resources" subpackage (i.e. sun.tools.jconsole.resources >>>> in this case). >>> I think one package private Message class for each package and separate >>> resource files for each package would be the best, but I didn't want >>> this CR to blow up, so I put the Message class where the other Java >>> classes >>> related to resources were before. >>> >>> I can move it to sun.tools.jconsole, if you think that's better. >>> >> >> I think so so that sun.tools.jconsole.resources.* are resource files. >> >>>> >>>> The initializeMessage method uses the field name as the >>>> key and initializes its value to its localized message via >>>> reflection. Such approach seems strange. >>> I like to enforce one-to-one mapping between the keys in the >>> property file and >>> the keys used in the Java code. When going through the fields in the >>> Message >>> class, using reflection, I can ensure that all fields have a >>> corresponding >>> property value in the file, and vice versa. >>> >>> With this approrach it's not necessary click through all the GUI to >>> verify that >>> all keys exists in the property file. It's also possible to detect >>> if a value >>> in a property file is no longer in use. >>> >>> The code that does the one-to-one check was removed, but it should >>> probably be >>> added back so similar problems can be catched automatically in the >>> future. >>> >>>> >>>> Have you considered about defining the constants with >>>> the key as the value (i.e. the variable name and its >>>> value are the same). >>> The Java constants can't be the same as the property value >> >> I meant the key value in messages.properties (not the property >> value). Essentially variable and the value is the same e.g. static >> final String ONE_DAY = "ONE_DAY"; >> >>>> Instead of initializing each >>>> static field of the Messages class, you can build >>>> a map of a key to the localized message + itsmnemonic >>>> key (like what you have done in building the MNEMONIC_LOOKUP >>>> map - why not change such hash map to map from a string to >>>> an object {message+mnemonic}). In that case, the MNEMONIC_LOOKUP >>>> doesn't need to be a synchronized map and could be done >>>> as the class initialization of Resources class. >>>> >>>> It would only need to keep >>>> Resources.getText(String) method that returns the localized >>>> message, e.g. >>>> Resources.getText(Messages.HELP_ABOUT_DIALOG_TITLE) >>>> >>>> I just don't see it's worth the complexity to initialize >>>> the static fields via reflection to get rid of a convenience >>>> method. >>> >>> The synchronization is not really needed, if you always use the keys to >>> lookup the messages. The static initializer in the Message class should >>> ensure correct ordering. >>> >>> Looking up messages "dynamically" means you have to trigger all the >>> code in the GUI that needs a translated message to be sure you got >>> things >>> correct. Since there are several hundred messages I think the >>> static-fields-reflection approach is better. >>> >>>> >>>> >>>> It is only my suggestion and I understand that this fix needs >>>> to be backport to 7u6. If you agree that replacing this >>>> static field initialization logic with a separate map, >>>> I'm okay with pushing this approach to 7u6 and push >>>> a better fix to jdk8. Or I miss the benefit you were >>>> considering :) >>> >>> You are missing it :) >>> >>> .. and it's probably because I removed the code that did the actual >>> check :) >>> >> >> I agree that checking one-to-one mapping between the keys in the >> property file and >> the keys used in the Java code is good. What you need is to compare >> the list of constants with the keys in messages.properties. Anyway, >> my suggestion was just to simplify such initialization. You can go >> with what you have. >> >>>> >>>> There are a few names with '_' suffix e.g. L93, 97, 104, 160 >>>> and also some names with '__' (L97, 159). Do you want to >>>> embed the space of the message in the key name? In any case, >>>> the key names with '_' suffix or double underscores '__' is >>>> a little confusing. It would be better just to use '_' for >>>> separating words of a key name and no need for '_' suffix. >>>> The names 'CHART_COLON', 'ERROR_COLON_MBEANS...', 'JCONSOLE_COLON', >>>> and the ones with 'COLON' to describe its message with ":" >>>> are strange. If ":" was removed from the message in the >>>> future, the name would need to be modified to follow this >>>> naming convention which is overkill. >>> The keys were generated programmatically. >>> >> >> Ah - that's what I guess. >> >>> The 'COLON' was needed so I could differentiate between message that >>> looked >>> the same, except for the ':' at the end. The pattern was applied to all >>> messages. Some of those message were removed (since they were no >>> longer in use) >>> >>> I can remove the 'COLON' suffix where it's not needed, same thing >>> with spaces. >>> >> >> That'd be good since "COLON" and '_' is meaningless w.r.t. the key >> name. IDE refactoring feature should make this renaming effortless :) >> >>> I will go over the message keys and clean up the names, but they >>> were not that >>> clean before either :) >> >> Thanks. >> Mandy > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120524/672786d2/attachment-0001.html From rob.mckenna at oracle.com Thu May 24 10:16:43 2012 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 24 May 2012 18:16:43 +0100 Subject: Codereview request for 7171184: Make the failure message in 7168110 more specific In-Reply-To: <4FBD79A1.9050901@oracle.com> References: <4FB51E29.7060900@oracle.com> <4FBD2206.3020404@oracle.com> <4FBD3350.1010805@oracle.com> <4FBD3C94.3000900@oracle.com> <4FBD5079.6060803@oracle.com> <4FBD79A1.9050901@oracle.com> Message-ID: <4FBE6CFB.80600@oracle.com> Apologies, I mixed up the docs with what I was seeing in testing. You're right, the sid might not always be 0. I've been speaking with Alan and we agree that its not worth pursuing given the direction this is headed. -Rob On 24/05/12 00:58, David Holmes wrote: > On 24/05/2012 7:02 AM, Alan Bateman wrote: >> On 23/05/2012 20:37, Rob McKenna wrote: >>> Hi Alan, >>> >>> Sorry, you've picked me up on that "if (" space a number of times. >>> Thanks for pointing it out again. >>> >>> What should I be checking w.r.t. the ProcessIdToSessionId? It returns >>> a 0 on failure so once the session id's are unequal or we've >>> encountered an ERROR_ACCESS_DENIED we should really be good to go >>> right? >>> >>> Looking at that reminds me that I had got an && instead of an || for >>> the session id / error check. Its a good point that if the >>> ProcessIdToSessionId call fails for a reason outside ACCESS_DENIED, we >>> won't know about it. I'm wondering if I should revert that now? >> What you have will work but we shouldn't be comparing pSid to cSid >> unless both calls to ProcessIdToSessionId succeed. > > Yeah I raised this previously with Rob and the response was that on > failure the sessionId will be set to zero but I do not see that in the > docs for ProcessIdToSessionId. The other assumptions was that > requesting the session Id for the current process could never fail - I > don't know how valid that is (these APIs don't document any actual > errors). If those two assumptions hold then the current code is > correct, otherwise ... something like this: > > if (( ProcessIdToSessionId( GetCurrentProcessId(), &cSid) != 0) { > BOOL result = ProcessIdToSessionId(GetProcessId(hProcess), &pSid); > if (result != 0) { // have valid sessionIds > if (pSid != cSid) > JNU_ThrowIOException(env, "useful message"); > // else same session so original memory error stands > } else if (GetLastError() == ERROR_ACCESS_DENIED) { > // implies that the sessions must be different > JNU_ThrowIOException(env, "useful message"); > } > // else some other error getting other session id > } > // else some error getting current session Id > > But this needs to ensure the original error is not lost, and it would > be nice not to have two throws statements :( > > I get the feeling what seemed like a simple suggestion is getting out > of control. Feel free to drop this. > > David > ----- > > >> -Alan. From erik.gahlin at oracle.com Thu May 24 12:40:53 2012 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Thu, 24 May 2012 21:40:53 +0200 Subject: RFR: 7017818 NLS: JConsoleResources.java cannot be handled by translation team In-Reply-To: <4FBE6934.7020101@oracle.com> References: <4FAD23E4.90501@oracle.com> <4FAD3B63.8070501@oracle.com> <4FBA2477.7040101@oracle.com> <4FBAAFEA.6090305@oracle.com> <4FBBEB98.50704@oracle.com> <4FBC0A03.2000906@oracle.com> <4FBE5FB5.3080909@oracle.com> <4FBE6934.7020101@oracle.com> Message-ID: <4FBE8EC5.9080504@oracle.com> Mandy Chung skrev 2012-05-24 19:00: > Thumbs up. Minor comment (no need for new webrev if you fix it): > Great! Thanks for taking the time doing the review, it was a lot of files to go through, > Resources.java L46: the AssertionError is not needed since it can't > get there. The constructor can be invoked from within the class, a corner case but still. > L133: would it be better to throw an internal error here to catch any > regression e.g. if isWriteField is modified incorrectly for whatever > reason? > It's probably better to throw an error but I never liked InternalError, since it's supposed to signal an unexpected error in the Java Virtual Machine. It's not like we are running out of resources. I will take Error, unless you disagree. > Messages.java - it'd be good to add a comment there to describe that > the names are auto-generated and there are some names with double > underscore or ends with '_' that will help anyone who has question if > they are typos or some convention we should follow. I will add a comment . Thanks again Erik > > Mandy > > On 5/24/2012 9:20 AM, Erik Gahlin wrote: >> Here is an updated webrev: >> http://cr.openjdk.java.net/~egahlin/7017818_6/ >> >> Changes from previous webrev: >> >> - Removed all @SuppressWarning changes >> - Moved the Messages class from sun.tools.jconsole.resource to >> sun.tools.jconsole and updated the makefile >> - Aligned parameters in the method calls. >> - Changed CONNECTION_LOST back to CONNECTION_LOST1 and kept message >> keys as is since they should work with the property files sent away. >> >> Erik >> >> Mandy Chung skrev 2012-05-22 23:49: >>> Erik, >>> >>> I approve what you have - please go through and fix the formatting >>> nits. I inlined my comment below and you can follow up them later >>> if needed. >>> >>> On 5/22/2012 12:40 PM, Erik Gahlin wrote: >>>> Thanks for reviewing, >>>> >>>> I got a lot of unused import warnings from the IDE when I changed the >>>> Resources class. When I cleaned them up I thought I might as well >>>> clean up the >>>> others too, so I could more easily see that I had taken care of all >>>> the >>>> warnings I caused. Same thing with unused member variables and >>>> unused methods. >>>> >>>> Import-statements will not change how the program executes, so I >>>> thought it >>>> was safe to remove them (no risk of introducing new bugs). >>>> >>>> ... >>>>> Anyway, >>>>> the warning cleanup deserves a separate CR and review. >>>> Breaking it up into seperate patches and CRs will take time. Is it >>>> really >>>> necessary? >>> >>> I'm okay for this patch to include the removal of unused imports and >>> dead code fixes. The warnings I referred to are the >>> @SuppressedWarnings("serial") and rawtypes changes since it may >>> require a separate pair of eyes to review them. As a general >>> advice, when the number of warnings cleaned up is not small, it's >>> always recommended to separate them as two separate CRs for bug >>> management and backport and it also helps the reviewers :) >>> >>> Since you have made the change along with the fix for this CR, I can >>> understand why you said it will take time. I also understand that >>> you're under a time pressure. I can go with what you have but >>> please consider in the future when to separate the change in a >>> separate CR. >>> >>> >>>> >>>> I cleaned up the code so I could make the fix more easily. I don't >>>> think it's >>>> worth the hazzle to create a separate bug and patch. I might as >>>> well revert >>>> the clean ups. >>>> >>> >>> BTW, backporting to an update release might request not to include >>> the warnings cleanup. I'm not sure the putback approval >>> requirements for 7u6. >>> >>>>> >>>>> Below are comments on the change to support translateability. >>>>> >>>>> sun/tools/jconsole/resources/Messages.java >>>>> I suggest to move Messages to sun.tools.jconsole since >>>>> it's a utility class and conventionally resources are put >>>>> in a "resources" subpackage (i.e. sun.tools.jconsole.resources >>>>> in this case). >>>> I think one package private Message class for each package and >>>> separate >>>> resource files for each package would be the best, but I didn't want >>>> this CR to blow up, so I put the Message class where the other Java >>>> classes >>>> related to resources were before. >>>> >>>> I can move it to sun.tools.jconsole, if you think that's better. >>>> >>> >>> I think so so that sun.tools.jconsole.resources.* are resource files. >>> >>>>> >>>>> The initializeMessage method uses the field name as the >>>>> key and initializes its value to its localized message via >>>>> reflection. Such approach seems strange. >>>> I like to enforce one-to-one mapping between the keys in the >>>> property file and >>>> the keys used in the Java code. When going through the fields in >>>> the Message >>>> class, using reflection, I can ensure that all fields have a >>>> corresponding >>>> property value in the file, and vice versa. >>>> >>>> With this approrach it's not necessary click through all the GUI to >>>> verify that >>>> all keys exists in the property file. It's also possible to detect >>>> if a value >>>> in a property file is no longer in use. >>>> >>>> The code that does the one-to-one check was removed, but it should >>>> probably be >>>> added back so similar problems can be catched automatically in the >>>> future. >>>> >>>>> >>>>> Have you considered about defining the constants with >>>>> the key as the value (i.e. the variable name and its >>>>> value are the same). >>>> The Java constants can't be the same as the property value >>> >>> I meant the key value in messages.properties (not the property >>> value). Essentially variable and the value is the same e.g. static >>> final String ONE_DAY = "ONE_DAY"; >>> >>>>> Instead of initializing each >>>>> static field of the Messages class, you can build >>>>> a map of a key to the localized message + itsmnemonic >>>>> key (like what you have done in building the MNEMONIC_LOOKUP >>>>> map - why not change such hash map to map from a string to >>>>> an object {message+mnemonic}). In that case, the MNEMONIC_LOOKUP >>>>> doesn't need to be a synchronized map and could be done >>>>> as the class initialization of Resources class. >>>>> >>>>> It would only need to keep >>>>> Resources.getText(String) method that returns the localized >>>>> message, e.g. >>>>> Resources.getText(Messages.HELP_ABOUT_DIALOG_TITLE) >>>>> >>>>> I just don't see it's worth the complexity to initialize >>>>> the static fields via reflection to get rid of a convenience >>>>> method. >>>> >>>> The synchronization is not really needed, if you always use the >>>> keys to >>>> lookup the messages. The static initializer in the Message class >>>> should >>>> ensure correct ordering. >>>> >>>> Looking up messages "dynamically" means you have to trigger all the >>>> code in the GUI that needs a translated message to be sure you got >>>> things >>>> correct. Since there are several hundred messages I think the >>>> static-fields-reflection approach is better. >>>> >>>>> >>>>> >>>>> It is only my suggestion and I understand that this fix needs >>>>> to be backport to 7u6. If you agree that replacing this >>>>> static field initialization logic with a separate map, >>>>> I'm okay with pushing this approach to 7u6 and push >>>>> a better fix to jdk8. Or I miss the benefit you were >>>>> considering :) >>>> >>>> You are missing it :) >>>> >>>> .. and it's probably because I removed the code that did the actual >>>> check :) >>>> >>> >>> I agree that checking one-to-one mapping between the keys in the >>> property file and >>> the keys used in the Java code is good. What you need is to compare >>> the list of constants with the keys in messages.properties. Anyway, >>> my suggestion was just to simplify such initialization. You can go >>> with what you have. >>> >>>>> >>>>> There are a few names with '_' suffix e.g. L93, 97, 104, 160 >>>>> and also some names with '__' (L97, 159). Do you want to >>>>> embed the space of the message in the key name? In any case, >>>>> the key names with '_' suffix or double underscores '__' is >>>>> a little confusing. It would be better just to use '_' for >>>>> separating words of a key name and no need for '_' suffix. >>>>> The names 'CHART_COLON', 'ERROR_COLON_MBEANS...', 'JCONSOLE_COLON', >>>>> and the ones with 'COLON' to describe its message with ":" >>>>> are strange. If ":" was removed from the message in the >>>>> future, the name would need to be modified to follow this >>>>> naming convention which is overkill. >>>> The keys were generated programmatically. >>>> >>> >>> Ah - that's what I guess. >>> >>>> The 'COLON' was needed so I could differentiate between message >>>> that looked >>>> the same, except for the ':' at the end. The pattern was applied to >>>> all >>>> messages. Some of those message were removed (since they were no >>>> longer in use) >>>> >>>> I can remove the 'COLON' suffix where it's not needed, same thing >>>> with spaces. >>>> >>> >>> That'd be good since "COLON" and '_' is meaningless w.r.t. the key >>> name. IDE refactoring feature should make this renaming effortless :) >>> >>>> I will go over the message keys and clean up the names, but they >>>> were not that >>>> clean before either :) >>> >>> Thanks. >>> Mandy >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120524/57866004/attachment.html From coleen.phillimore at oracle.com Thu May 24 12:48:34 2012 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Thu, 24 May 2012 15:48:34 -0400 Subject: Testing dtrace Message-ID: <4FBE9092.8020606@oracle.com> Hi, I made some jhelper.d changes for the permgen elimination repository. I'm strictly pattern matching. Do the NSK dtrace tests test this code? Is there a complicated setup for these tests or do I just need to be root? thanks, Coleen From serguei.spitsyn at oracle.com Thu May 24 14:34:03 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 24 May 2012 14:34:03 -0700 Subject: Testing dtrace In-Reply-To: <4FBE9092.8020606@oracle.com> References: <4FBE9092.8020606@oracle.com> Message-ID: <4FBEA94B.7010501@oracle.com> I don't know these tests well. But I see there is the jhelper/ smoke test there. It does a fairly surface testing that checks that a simple d-script does not fail and that the jhelper.d (supporting DTrace jstack action) was installed on the system. I still have some old half-manual tests for jhelper.d that were used 5 years ago. I can share them if you need. Most likely, they will need some tweaks. Dan already answered the last question. Thanks, Serguei On 5/24/12 12:48 PM, Coleen Phillimore wrote: > > Hi, > > I made some jhelper.d changes for the permgen elimination > repository. I'm strictly pattern matching. Do the NSK dtrace tests > test this code? > Is there a complicated setup for these tests or do I just need to be > root? > > thanks, > Coleen > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120524/7195d7e3/attachment-0001.html From stuart.marks at oracle.com Thu May 24 19:28:41 2012 From: stuart.marks at oracle.com (stuart.marks at oracle.com) Date: Fri, 25 May 2012 02:28:41 +0000 Subject: hg: jdk8/tl/jdk: 7117230: clean up warnings in java.text Message-ID: <20120525022852.9EB87474E4@hg.openjdk.java.net> Changeset: e309917fb9af Author: dbhole Date: 2012-05-24 19:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e309917fb9af 7117230: clean up warnings in java.text Reviewed-by: jrose, smarks ! src/share/classes/java/text/AttributedCharacterIterator.java ! src/share/classes/java/text/AttributedString.java ! src/share/classes/java/text/BreakDictionary.java ! src/share/classes/java/text/BreakIterator.java ! src/share/classes/java/text/CharacterIteratorFieldDelegate.java ! src/share/classes/java/text/ChoiceFormat.java ! src/share/classes/java/text/CollationElementIterator.java ! src/share/classes/java/text/DateFormat.java ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/DictionaryBasedBreakIterator.java ! src/share/classes/java/text/MergeCollation.java ! src/share/classes/java/text/MessageFormat.java ! src/share/classes/java/text/NumberFormat.java ! src/share/classes/java/text/ParseException.java ! src/share/classes/java/text/RBCollationTables.java ! src/share/classes/java/text/RBTableBuilder.java ! src/share/classes/java/text/RuleBasedBreakIterator.java From john.coomes at oracle.com Thu May 24 20:53:15 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 25 May 2012 03:53:15 +0000 Subject: hg: hsx/hotspot-rt: Added tag jdk8-b40 for changeset a2b2d435f1d2 Message-ID: <20120525035315.80BE7474F9@hg.openjdk.java.net> Changeset: 1a8c7c530f8a Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/1a8c7c530f8a Added tag jdk8-b40 for changeset a2b2d435f1d2 ! .hgtags From john.coomes at oracle.com Thu May 24 20:53:20 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 25 May 2012 03:53:20 +0000 Subject: hg: hsx/hotspot-rt/corba: Added tag jdk8-b40 for changeset 56d030e5035f Message-ID: <20120525035323.638D1474FA@hg.openjdk.java.net> Changeset: 113f0d5f0a08 Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/113f0d5f0a08 Added tag jdk8-b40 for changeset 56d030e5035f ! .hgtags From john.coomes at oracle.com Thu May 24 20:53:28 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 25 May 2012 03:53:28 +0000 Subject: hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b40 for changeset 9ecfdbd6aed4 Message-ID: <20120525035336.C2E9A474FB@hg.openjdk.java.net> Changeset: 6f5c0e17415d Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/6f5c0e17415d Added tag jdk8-b40 for changeset 9ecfdbd6aed4 ! .hgtags From john.coomes at oracle.com Thu May 24 20:53:42 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 25 May 2012 03:53:42 +0000 Subject: hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b40 for changeset 09a0ddda03cb Message-ID: <20120525035348.223D8474FC@hg.openjdk.java.net> Changeset: f2072b164b05 Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/f2072b164b05 Added tag jdk8-b40 for changeset 09a0ddda03cb ! .hgtags From john.coomes at oracle.com Thu May 24 20:54:53 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 25 May 2012 03:54:53 +0000 Subject: hg: hsx/hotspot-rt/jdk: 71 new changesets Message-ID: <20120525040831.286C347500@hg.openjdk.java.net> Changeset: 7c4eed4b6c19 Author: bae Date: 2012-05-21 14:04 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7c4eed4b6c19 7124400: [macosx] CGraphicsDevice.getConfigurations() returns reference to member (does not copy configs) Reviewed-by: anthony, kizune ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! test/java/awt/GraphicsDevice/CloneConfigsTest.java Changeset: 416b3a498e71 Author: bae Date: 2012-05-21 14:53 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/416b3a498e71 7154088: [macosx] Regression: Component.createImage do not inherits component attributes Reviewed-by: art, kizune ! src/macosx/classes/sun/lwawt/LWComponentPeer.java Changeset: 1b90a0113359 Author: lana Date: 2012-05-21 11:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1b90a0113359 Merge Changeset: c31eeeda3ed1 Author: serb Date: 2012-05-03 18:29 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c31eeeda3ed1 7160623: [macosx] Editable TextArea/TextField are blocking GUI applications from exit Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java Changeset: a420895ee2c3 Author: leonidr Date: 2012-05-03 19:22 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a420895ee2c3 7124376: [macosx] Modal dialog lost focus Reviewed-by: anthony ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 95c8b63a3c47 Author: kizune Date: 2012-05-03 21:54 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/95c8b63a3c47 7148289: [macosx] Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame Reviewed-by: leonidr ! src/macosx/classes/sun/lwawt/macosx/CToolkitThreadBlockedHandler.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/LWCToolkit.m Changeset: a714e2e2b257 Author: alexsch Date: 2012-05-04 13:15 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a714e2e2b257 7024963: Notepad demo: remove non-translatable resources from Notepad.properties file Reviewed-by: rupashka ! src/share/demo/jfc/Notepad/Notepad.java ! src/share/demo/jfc/Notepad/resources/Notepad.properties + src/share/demo/jfc/Notepad/resources/system.properties Changeset: 4cc873e28c78 Author: bagiras Date: 2012-05-04 18:42 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4cc873e28c78 7146237: closed/java/awt/Focus/SetFocusTraversalKeysTest/SetFocusTraversalTest.html failed since 1.8.0b19 Reviewed-by: art, anthony ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/javax/swing/JComponent.java Changeset: 0feee4541f67 Author: serb Date: 2012-05-04 21:25 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0feee4541f67 7147055: [macosx] Cursors are changing over a blocked window; also blinking Reviewed-by: art, kizune ! src/macosx/classes/sun/lwawt/LWCursorManager.java Changeset: 912e666b4e1d Author: serb Date: 2012-05-10 20:05 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/912e666b4e1d 7080109: Dialog.show() lacks doPrivileged() to access system event queue Reviewed-by: art, anthony ! src/share/classes/java/awt/Dialog.java + test/java/awt/Dialog/ModalDialogPermission/ModalDialogPermission.java + test/java/awt/Dialog/ModalDialogPermission/java.policy Changeset: 18842bb6676a Author: lana Date: 2012-05-10 11:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/18842bb6676a Merge - src/macosx/bin/amd64/jvm.cfg - src/share/classes/sun/security/action/LoadLibraryAction.java - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: 4f39a13e74c6 Author: anthony Date: 2012-05-11 16:11 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4f39a13e74c6 7166437: [macosx] Support for Window.Type.UTILITY on the Mac Summary: Apply the native UTILITY style for UTILITY Java windows Reviewed-by: art ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: 689c0cd214e8 Author: anthony Date: 2012-05-11 20:37 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/689c0cd214e8 7149062: [macosx] dock menu don't show available frames Summary: Inherit from either NSWindow for normal windows or NSPanel for utility windows Reviewed-by: skovatch, swingler ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 3b8635e357e9 Author: alexsch Date: 2012-05-12 12:01 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3b8635e357e9 7024965: Stylepad demo: remove non-translatable resources from Stylepad.properties file Reviewed-by: alexp ! src/share/demo/jfc/Notepad/Notepad.java + src/share/demo/jfc/Notepad/resources/NotepadSystem.properties - src/share/demo/jfc/Notepad/resources/system.properties Changeset: cc8d1cc533bf Author: alexp Date: 2012-05-12 17:46 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cc8d1cc533bf 7149005: [macosx] Java Control Panel's UI controls are distorted when draging scroll bar. Reviewed-by: serb ! src/macosx/classes/com/apple/laf/AquaButtonLabeledUI.java Changeset: 69301efaac91 Author: ant Date: 2012-05-12 18:50 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/69301efaac91 7110683: Issues with some KeyboardFocusManager method Reviewed-by: ahgross ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/Window.java Changeset: 28ec5b811aa2 Author: dcherepanov Date: 2012-05-15 15:04 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/28ec5b811aa2 7168550: [macosx] duplicate OGL context state changes related to vertex cache Reviewed-by: bae, swingler ! src/macosx/native/sun/java2d/opengl/CGLSurfaceData.m ! src/share/native/sun/java2d/opengl/OGLContext.h ! src/share/native/sun/java2d/opengl/OGLTextRenderer.c ! src/share/native/sun/java2d/opengl/OGLVertexCache.c ! src/share/native/sun/java2d/opengl/OGLVertexCache.h Changeset: cad0bb1a9bdb Author: dcherepanov Date: 2012-05-16 13:15 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cad0bb1a9bdb 7124337: [macosx] FileDialog fails to select multiple files Reviewed-by: anthony, swingler ! src/macosx/classes/sun/lwawt/macosx/CFileDialog.java ! src/macosx/native/sun/awt/CFileDialog.h ! src/macosx/native/sun/awt/CFileDialog.m ! src/share/classes/java/awt/FileDialog.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/solaris/classes/sun/awt/X11/GtkFileDialogPeer.java ! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java Changeset: 7c0b390ab5f9 Author: anthony Date: 2012-05-16 14:28 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7c0b390ab5f9 7168851: [macosx] Netbeans crashes in CImage.nativeCreateNSImageFromArray Summary: Eliminate unnecessary -release call Reviewed-by: dcherepanov ! src/macosx/native/sun/awt/CImage.m Changeset: 3c819d638e36 Author: alexsch Date: 2012-05-16 16:27 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3c819d638e36 7169226: NLS: Please change the mnemonic assignment system for windows and motif properties Reviewed-by: rupashka ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_de.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_es.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_fr.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_it.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ja.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ko.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_sv.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_TW.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_de.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_es.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_it.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ja.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ko.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_sv.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_TW.properties Changeset: 19edcc438203 Author: alexsch Date: 2012-05-16 18:11 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/19edcc438203 7158928: [macosx] NLS: Please change the mnemonic assignment system Reviewed-by: rupashka, serb ! make/com/apple/osxui/Makefile ! make/common/internal/Resources.gmk ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/com/apple/laf/resources/aqua.properties Changeset: 731ee59c6ba2 Author: alexsch Date: 2012-05-17 14:27 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/731ee59c6ba2 7148281: [macosx] JTabbedPane tabs with HTML text do not render correctly Reviewed-by: kizune ! src/macosx/classes/com/apple/laf/AquaTabbedPaneUI.java Changeset: f9217bd87199 Author: rupashka Date: 2012-05-17 15:41 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f9217bd87199 7166322: closed/javax/swing/text/html/HTMLEditorKit/4242228/bug4242228.java failed since 1.8.0b36 Reviewed-by: alexsch + test/javax/swing/text/html/HTMLEditorKit/4242228/bug4242228.java Changeset: c00d6508afce Author: ant Date: 2012-05-17 21:27 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c00d6508afce 7142565: [macosx] Many special keys processed twice in text fields Summary: forward port from 7u4 Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTView.m Changeset: 17c5e1a12965 Author: ant Date: 2012-05-17 21:31 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/17c5e1a12965 7154072: [macosx] swallowing key events Summary: forward posrt from 7u4 Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTView.m Changeset: ef77fa799b34 Author: ant Date: 2012-05-17 21:48 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ef77fa799b34 7125044: [macosx] Test failure because Component.transferFocus() works differently in applet and application. Summary: forward port from 7u4 Reviewed-by: art ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/Frame.java ! src/share/classes/java/awt/Window.java ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JFrame.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/UIManager.java ! src/share/classes/sun/awt/SunToolkit.java + test/java/awt/Focus/FocusTraversalPolicy/InitialFTP.java + test/java/awt/Focus/FocusTraversalPolicy/InitialFTP_AWT.java + test/java/awt/Focus/FocusTraversalPolicy/InitialFTP_Swing.java + test/java/awt/event/KeyEvent/SwallowKeyEvents/SwallowKeyEvents.java Changeset: 5976b5848554 Author: ant Date: 2012-05-17 22:10 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5976b5848554 7145768: [macosx] Regression: failure in b11 of ModalDialogInFocusEventTest Summary: forward port from 7u4 Reviewed-by: art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java Changeset: 1d75ff45586e Author: ant Date: 2012-05-17 22:21 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1d75ff45586e 7145827: [macosx] JCK failure in b11: FocusableWindow3 Summary: forward posrt from 7u4 Reviewed-by: art ! src/macosx/classes/sun/lwawt/LWWindowPeer.java Changeset: 2eca75e0a063 Author: dcherepanov Date: 2012-05-18 19:39 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2eca75e0a063 7156191: [macosx] Can't type into applet demos in Pivot Reviewed-by: art ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: 1ee12bca4823 Author: rupashka Date: 2012-05-21 18:55 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1ee12bca4823 7168144: No appropriate CCC request for changes introduced by 7154030 Reviewed-by: alexsch ! src/share/classes/javax/swing/JComponent.java Changeset: 967b38bfd5c1 Author: ant Date: 2012-05-22 01:12 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/967b38bfd5c1 7170427: setGlobalCurrentFocusCycleRoot unexpectedly throws SecurityException Reviewed-by: art ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/KeyboardFocusManager.java Changeset: 5b2095d7a60b Author: lana Date: 2012-05-21 11:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5b2095d7a60b Merge ! src/macosx/classes/sun/lwawt/LWComponentPeer.java Changeset: bb2cefc89bc0 Author: forax Date: 2012-05-02 20:01 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bb2cefc89bc0 7165102: Only run assertion on Integer autoboxing cache size once Reviewed-by: darcy, alanb ! src/share/classes/java/lang/Integer.java Changeset: 531ebfd8eb65 Author: jgish Date: 2012-05-02 21:46 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/531ebfd8eb65 7160714: Strange or obsolete @see tags in some exception java.util javadoc Reviewed-by: mduigou, dholmes, alanb ! src/share/classes/java/util/NoSuchElementException.java Changeset: 4580652d9828 Author: lancea Date: 2012-05-04 16:00 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4580652d9828 7166598: FilteredRowSetImpl can result in Invalid Cursor Position Reviewed-by: lancea Contributed-by: Knut Anders Hatlen ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java Changeset: 41d3f7509e00 Author: xuelei Date: 2012-05-04 17:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/41d3f7509e00 7153184: NullPointerException when calling SSLEngineImpl.getSupportedCipherSuites Reviewed-by: weijun ! src/share/classes/sun/security/ssl/SSLContextImpl.java Changeset: 62557a1336c0 Author: zhouyx Date: 2012-05-07 16:43 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/62557a1336c0 7166048: Remove the embeded epoll data structure. Reviewed-by: alanb ! src/solaris/native/sun/nio/ch/EPollArrayWrapper.c Changeset: b26c04717735 Author: robm Date: 2012-05-07 13:34 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b26c04717735 7166687: InetAddress.getLocalHost().getHostName() returns FQDN Reviewed-by: chegar ! src/solaris/native/java/net/Inet6AddressImpl.c Changeset: 48513d156965 Author: dholmes Date: 2012-05-08 02:59 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/48513d156965 7103570: AtomicIntegerFieldUpdater does not work when SecurityManager is installed Summary: Perform class.getField inside a doPrivileged block Reviewed-by: chegar, psandoz ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java + test/java/util/concurrent/atomic/AtomicUpdaters.java Changeset: af209a223b6b Author: sherman Date: 2012-05-08 10:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/af209a223b6b 7014640: To add a metachar \R for line ending and character classes for vertical/horizontal ws \v \V \h \H Summary: added propsoed constructs Reviewed-by: alanb ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java Changeset: 1ece20885be4 Author: sherman Date: 2012-05-08 11:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1ece20885be4 7157656: (zipfs) SeekableByteChannel to entry in zip file always reports its position as 0 Summary: updated SeekableByteChannel.read() to count the bytes read correctly Reviewed-by: sherman Contributed-by: paul.sandoz at oracle.com ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh Changeset: fbf98cbd2e6b Author: xuelei Date: 2012-05-08 17:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fbf98cbd2e6b 7167092: Need to put the return clause in the synchronized block Summary: a regression fix for bug 7153184 Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/SSLContextImpl.java Changeset: 0f63f3390ac9 Author: xuelei Date: 2012-05-08 18:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0f63f3390ac9 7166570: JSSE certificate validation has started to fail for certificate chains Reviewed-by: wetmore ! src/share/classes/sun/security/validator/SimpleValidator.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/BasicConstraints.java Changeset: abb63b7357a1 Author: luchsh Date: 2012-05-09 11:19 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/abb63b7357a1 7165722: Invalid path in MemoryMonitor demo's README.txt Reviewed-by: alanb, sla ! src/share/demo/management/MemoryMonitor/README.txt Changeset: 5e8caf6984f5 Author: ksrini Date: 2012-05-09 07:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5e8caf6984f5 7166955: (pack200) JNI_GetCreatedJavaVMs needs additional checking Reviewed-by: alanb, dholmes, ksrini Contributed-by: youdwei at linux.vnet.ibm.com ! src/share/native/com/sun/java/util/jar/pack/jni.cpp Changeset: 59121a4c71c6 Author: khazra Date: 2012-05-09 11:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/59121a4c71c6 7165118: (prefs) AbstractPreferences.remove(null) does not throw NPE Summary: Insert null argument check in AbstractPreferences.remove() Reviewed-by: dholmes, chegar, alanb ! src/share/classes/java/util/prefs/AbstractPreferences.java ! test/java/util/prefs/RemoveNullKeyCheck.java Changeset: 6438f1277df6 Author: wetmore Date: 2012-05-09 16:33 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6438f1277df6 7167362: SecureRandom.init should be converted, amendment to 7084245 Reviewed-by: sherman ! src/share/classes/sun/security/provider/SecureRandom.java Changeset: 5152c832745a Author: khazra Date: 2012-05-09 16:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5152c832745a 7096436: (sc) SocketChannel.connect fails on Windows 8 when channel configured non-blocking Summary: Set localAddress only when connection is established Reviewed-by: alanb ! src/share/classes/sun/nio/ch/SocketChannelImpl.java Changeset: fdf5e15293e6 Author: coffeys Date: 2012-05-10 10:45 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fdf5e15293e6 7163470: Build fails if javax.crypto src files not present Reviewed-by: valeriep ! make/com/oracle/security/ucrypto/Makefile ! make/common/shared/Defs-java.gmk ! make/sun/security/ec/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile ! makefiles/com/oracle/security/ucrypto/Makefile ! makefiles/common/shared/Defs-java.gmk ! makefiles/sun/security/ec/Makefile ! makefiles/sun/security/mscapi/Makefile ! makefiles/sun/security/pkcs11/Makefile Changeset: 3e3017eba8ac Author: valeriep Date: 2012-05-08 17:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3e3017eba8ac 4963723: Implement SHA-224 Summary: Add support for SHA-224, SHA224withRSA, SHA224withECDSA, HmacSHA224 and OAEPwithSHA-224AndMGF1Padding. Reviewed-by: vinnie ! src/share/classes/com/sun/crypto/provider/HmacCore.java ! src/share/classes/com/sun/crypto/provider/HmacMD5.java ! src/share/classes/com/sun/crypto/provider/HmacPKCS12PBESHA1.java ! src/share/classes/com/sun/crypto/provider/HmacSHA1.java ! src/share/classes/com/sun/crypto/provider/KeyGeneratorCore.java ! src/share/classes/com/sun/crypto/provider/OAEPParameters.java ! src/share/classes/com/sun/crypto/provider/SunJCE.java ! src/share/classes/java/security/spec/MGF1ParameterSpec.java ! src/share/classes/java/security/spec/PSSParameterSpec.java ! src/share/classes/sun/security/ec/ECDSASignature.java ! src/share/classes/sun/security/ec/SunECEntries.java ! src/share/classes/sun/security/pkcs11/P11Digest.java ! src/share/classes/sun/security/pkcs11/P11Mac.java ! src/share/classes/sun/security/pkcs11/P11Signature.java ! src/share/classes/sun/security/pkcs11/SunPKCS11.java ! src/share/classes/sun/security/pkcs11/wrapper/Functions.java ! src/share/classes/sun/security/provider/DigestBase.java ! src/share/classes/sun/security/provider/MD2.java ! src/share/classes/sun/security/provider/MD4.java ! src/share/classes/sun/security/provider/MD5.java ! src/share/classes/sun/security/provider/SHA.java ! src/share/classes/sun/security/provider/SHA2.java ! src/share/classes/sun/security/provider/SHA5.java ! src/share/classes/sun/security/provider/SunEntries.java ! src/share/classes/sun/security/rsa/RSASignature.java ! src/share/classes/sun/security/rsa/SunRsaSignEntries.java ! src/share/classes/sun/security/x509/AlgorithmId.java ! src/windows/classes/sun/security/mscapi/RSASignature.java ! src/windows/classes/sun/security/mscapi/SunMSCAPI.java ! test/com/sun/crypto/provider/Cipher/RSA/TestOAEP.java ! test/com/sun/crypto/provider/Cipher/RSA/TestOAEPParameterSpec.java ! test/com/sun/crypto/provider/Cipher/RSA/TestOAEPWithParams.java ! test/com/sun/crypto/provider/KeyGenerator/Test4628062.java ! test/com/sun/crypto/provider/Mac/MacClone.java ! test/com/sun/crypto/provider/Mac/MacKAT.java ! test/sun/security/mscapi/SignUsingNONEwithRSA.java ! test/sun/security/mscapi/SignUsingSHA2withRSA.java ! test/sun/security/pkcs11/MessageDigest/DigestKAT.java ! test/sun/security/pkcs11/MessageDigest/TestCloning.java ! test/sun/security/pkcs11/Signature/TestRSAKeyLength.java ! test/sun/security/pkcs11/ec/TestCurves.java ! test/sun/security/pkcs11/rsa/TestKeyPairGenerator.java ! test/sun/security/pkcs11/rsa/TestSignatures.java ! test/sun/security/provider/MessageDigest/DigestKAT.java ! test/sun/security/provider/MessageDigest/Offsets.java ! test/sun/security/provider/MessageDigest/TestSHAClone.java ! test/sun/security/rsa/TestKeyPairGenerator.java ! test/sun/security/rsa/TestSignatures.java Changeset: dfce31760a2f Author: valeriep Date: 2012-05-08 18:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/dfce31760a2f Merge Changeset: 9f8210f23773 Author: valeriep Date: 2012-05-10 11:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9f8210f23773 Merge Changeset: c5a07e3dca63 Author: youdwei Date: 2012-05-11 16:20 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c5a07e3dca63 7163874: InetAddress.isReachable should support pinging 0.0.0.0 Reviewed-by: alanb, chegar ! src/share/native/java/net/net_util.h ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/net_util_md.c + test/java/net/Inet4Address/PingThis.java Changeset: 3e83229a3779 Author: coffeys Date: 2012-05-11 10:09 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3e83229a3779 7167359: (tz) SEGV on solaris if TZ variable not set Reviewed-by: okutsu ! src/solaris/native/java/util/TimeZone_md.c Changeset: 944676ef3c58 Author: mduigou Date: 2012-05-11 11:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/944676ef3c58 7071826: Avoid benign race condition in initialization of UUID Summary: Avoids mostly benign but sometimes expensive race condition on initialization of UUID.numberGenerator which is used by UUID.randomUUID() Reviewed-by: alanb, chegar ! src/share/classes/java/util/UUID.java ! test/java/util/UUID/UUIDTest.java Changeset: 85d7677a75bf Author: lana Date: 2012-05-11 12:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/85d7677a75bf Merge Changeset: f131d4361faf Author: olagneau Date: 2012-05-11 14:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f131d4361faf 7144861: speed up RMI activation tests Reviewed-by: alanb, smarks, dholmes, dmocek ! test/java/rmi/activation/checkusage/CheckUsage.java ! test/java/rmi/testlibrary/ActivationLibrary.java ! test/java/rmi/testlibrary/JavaVM.java ! test/java/rmi/testlibrary/RMID.java ! test/java/rmi/testlibrary/StreamPipe.java ! test/sun/rmi/runtime/Log/6409194/NoConsoleOutput.java Changeset: df3152beef2f Author: xuelei Date: 2012-05-14 07:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/df3152beef2f 7167988: PKIX CertPathBuilder in reverse mode doesn't work if more than one trust anchor is specified Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java + test/sun/security/provider/certpath/ReverseBuilder/ReverseBuild.java Changeset: df33f5f750ec Author: dsamersoff Date: 2012-05-15 16:46 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/df33f5f750ec 7164191: properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario Reviewed-by: dholmes, sla Contributed-by: Deven You ! src/share/classes/sun/management/Agent.java + test/sun/management/AgentCMETest.java Changeset: 9a18e318f95a Author: khazra Date: 2012-05-15 11:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9a18e318f95a 7164636: (prefs) Cleanup src/macosx/classes/java/util/prefs Summary: Remove rawtype usages and other code cleanup Reviewed-by: chegar, briangoetz ! src/macosx/classes/java/util/prefs/MacOSXPreferences.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFactory.java ! src/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java Changeset: 332bebb463d1 Author: alanb Date: 2012-05-16 12:43 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/332bebb463d1 7168505: (bf) MappedByteBuffer.load does not load buffer's content into memory Reviewed-by: mduigou, forax ! src/share/classes/java/nio/MappedByteBuffer.java Changeset: ce165aa48dcb Author: dcubed Date: 2012-05-17 06:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ce165aa48dcb 7168520: No jdk8 TL Nightly linux builds due to broken link in b39-2012-05-13_231 Summary: ZIP libjsig.debuginfo links into libjsig.diz files since aurora doesn't like dangling symlinks Reviewed-by: katleman ! make/java/redist/Makefile Changeset: 178c480998b1 Author: robm Date: 2012-05-17 22:42 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/178c480998b1 7168110: Misleading jstack error message Reviewed-by: alanb, dsamersoff ! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c Changeset: 9fe6ebbe5895 Author: xuelei Date: 2012-05-17 21:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9fe6ebbe5895 7145960: sun/security/mscapi/ShortRSAKey1024.sh failing on windows Reviewed-by: vinnie, wetmore ! test/sun/security/mscapi/ShortRSAKey1024.sh ! test/sun/security/mscapi/ShortRSAKey512.sh ! test/sun/security/mscapi/ShortRSAKey768.sh Changeset: af1030be726a Author: valeriep Date: 2012-05-18 12:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/af1030be726a 7169496: Problem with the SHA-224 support for SunMSCAPI provider Summary: Remove SHA224withRSA signature from SunMSCAPI provider due to lack of windows support. Reviewed-by: vinnie ! src/windows/classes/sun/security/mscapi/RSASignature.java ! src/windows/classes/sun/security/mscapi/SunMSCAPI.java ! test/sun/security/mscapi/SignUsingNONEwithRSA.java ! test/sun/security/mscapi/SignUsingSHA2withRSA.java Changeset: 72af24348b2b Author: weijun Date: 2012-05-21 15:40 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/72af24348b2b 7170308: timing error in the krb5 test SSL.java Reviewed-by: xuelei ! test/sun/security/krb5/auto/SSL.java Changeset: 9cb304dd71d4 Author: alanb Date: 2012-05-21 10:41 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9cb304dd71d4 7170203: TEST_BUG: test/java/nio/MappedByteBuffer/Truncate.java failing intermittently Reviewed-by: chegar ! test/java/nio/MappedByteBuffer/Truncate.java Changeset: f109feb13698 Author: ksrini Date: 2012-05-21 09:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f109feb13698 7170087: tools/launcher/Arrghs.java test has wrong bugID for 7151434 Reviewed-by: ohair ! test/tools/launcher/Arrrghs.java Changeset: 0a1ef7e07e01 Author: sla Date: 2012-05-21 19:28 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0a1ef7e07e01 7167157: jcmd command file parsing does not respect the "stop" command Reviewed-by: alanb, dsamersoff, nloodin ! src/share/classes/sun/tools/jcmd/JCmd.java Changeset: b88fc3359dc7 Author: lana Date: 2012-05-21 11:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b88fc3359dc7 Merge Changeset: 7def50698e78 Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7def50698e78 Added tag jdk8-b40 for changeset b88fc3359dc7 ! .hgtags From littlee at linux.vnet.ibm.com Thu May 24 22:31:53 2012 From: littlee at linux.vnet.ibm.com (littlee at linux.vnet.ibm.com) Date: Fri, 25 May 2012 05:31:53 +0000 Subject: hg: jdk8/tl/jdk: 7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled Message-ID: <20120525053212.D046D47505@hg.openjdk.java.net> Changeset: 71cf74329a9e Author: youdwei Date: 2012-05-25 13:28 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71cf74329a9e 7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled Reviewed-by: okutsu ! src/windows/native/java/util/TimeZone_md.c + test/java/util/TimeZone/DstTzTest.java From littlee at linux.vnet.ibm.com Thu May 24 23:34:09 2012 From: littlee at linux.vnet.ibm.com (littlee at linux.vnet.ibm.com) Date: Fri, 25 May 2012 06:34:09 +0000 Subject: hg: jdk8/tl/jdk: 7171028: dots are missed in the datetime for Slovanian Message-ID: <20120525063429.F2FEF47507@hg.openjdk.java.net> Changeset: 85696e57d447 Author: youdwei Date: 2012-05-25 14:32 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85696e57d447 7171028: dots are missed in the datetime for Slovanian Reviewed-by: yhuang ! src/share/classes/sun/text/resources/FormatData_sl.java ! test/sun/text/resources/LocaleData ! test/sun/text/resources/LocaleDataTest.java From nils.loodin at oracle.com Fri May 25 05:57:17 2012 From: nils.loodin at oracle.com (nils.loodin at oracle.com) Date: Fri, 25 May 2012 12:57:17 +0000 Subject: hg: jdk8/tl/jdk: 7017818: NLS: JConsoleResources.java cannot be handled by translation team Message-ID: <20120525125738.14B7647513@hg.openjdk.java.net> Changeset: 1def6b6bfbd9 Author: egahlin Date: 2012-05-25 12:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1def6b6bfbd9 7017818: NLS: JConsoleResources.java cannot be handled by translation team Reviewed-by: mchung, mfang ! make/netbeans/jconsole/build.xml ! make/sun/jconsole/FILES.gmk ! make/sun/jconsole/Makefile ! src/share/classes/sun/tools/jconsole/AboutDialog.java ! src/share/classes/sun/tools/jconsole/BorderedComponent.java ! src/share/classes/sun/tools/jconsole/ClassTab.java ! src/share/classes/sun/tools/jconsole/ConnectDialog.java ! src/share/classes/sun/tools/jconsole/CreateMBeanDialog.java ! src/share/classes/sun/tools/jconsole/Formatter.java ! src/share/classes/sun/tools/jconsole/HTMLPane.java ! src/share/classes/sun/tools/jconsole/InternalDialog.java ! src/share/classes/sun/tools/jconsole/JConsole.java ! src/share/classes/sun/tools/jconsole/LabeledComponent.java ! src/share/classes/sun/tools/jconsole/LocalVirtualMachine.java ! src/share/classes/sun/tools/jconsole/MBeansTab.java ! src/share/classes/sun/tools/jconsole/MaximizableInternalFrame.java ! src/share/classes/sun/tools/jconsole/MemoryPoolProxy.java ! src/share/classes/sun/tools/jconsole/MemoryPoolStat.java ! src/share/classes/sun/tools/jconsole/MemoryTab.java + src/share/classes/sun/tools/jconsole/Messages.java ! src/share/classes/sun/tools/jconsole/OverviewPanel.java ! src/share/classes/sun/tools/jconsole/OverviewTab.java ! src/share/classes/sun/tools/jconsole/Plotter.java ! src/share/classes/sun/tools/jconsole/PlotterPanel.java ! src/share/classes/sun/tools/jconsole/ProxyClient.java ! src/share/classes/sun/tools/jconsole/Resources.java ! src/share/classes/sun/tools/jconsole/SummaryTab.java ! src/share/classes/sun/tools/jconsole/Tab.java ! src/share/classes/sun/tools/jconsole/ThreadTab.java ! src/share/classes/sun/tools/jconsole/VMInternalFrame.java ! src/share/classes/sun/tools/jconsole/VMPanel.java ! src/share/classes/sun/tools/jconsole/VariableGridLayout.java ! src/share/classes/sun/tools/jconsole/Version.java.template ! src/share/classes/sun/tools/jconsole/inspector/OperationEntry.java ! src/share/classes/sun/tools/jconsole/inspector/TableSorter.java ! src/share/classes/sun/tools/jconsole/inspector/ThreadDialog.java ! src/share/classes/sun/tools/jconsole/inspector/Utils.java ! src/share/classes/sun/tools/jconsole/inspector/XArrayDataViewer.java ! src/share/classes/sun/tools/jconsole/inspector/XDataViewer.java ! src/share/classes/sun/tools/jconsole/inspector/XMBeanAttributes.java ! src/share/classes/sun/tools/jconsole/inspector/XMBeanInfo.java ! src/share/classes/sun/tools/jconsole/inspector/XMBeanNotifications.java ! src/share/classes/sun/tools/jconsole/inspector/XObject.java ! src/share/classes/sun/tools/jconsole/inspector/XOpenTypeViewer.java ! src/share/classes/sun/tools/jconsole/inspector/XOperations.java ! src/share/classes/sun/tools/jconsole/inspector/XPlotter.java ! src/share/classes/sun/tools/jconsole/inspector/XPlottingViewer.java ! src/share/classes/sun/tools/jconsole/inspector/XSheet.java ! src/share/classes/sun/tools/jconsole/inspector/XTable.java ! src/share/classes/sun/tools/jconsole/inspector/XTextField.java ! src/share/classes/sun/tools/jconsole/inspector/XTree.java ! src/share/classes/sun/tools/jconsole/inspector/XTreeRenderer.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_ja.java - src/share/classes/sun/tools/jconsole/resources/JConsoleResources_zh_CN.java + src/share/classes/sun/tools/jconsole/resources/messages.properties + src/share/classes/sun/tools/jconsole/resources/messages_ja.properties + src/share/classes/sun/tools/jconsole/resources/messages_zh_CN.properties From staffan.larsen at oracle.com Fri May 25 06:41:31 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 25 May 2012 15:41:31 +0200 Subject: RFR (S): 7165257: Adding JFR test targets Message-ID: Please review the following change to makefiles to add a target for the JFR tests. Webrev: http://cr.openjdk.java.net/~sla/7165257/webrev.01/ Thanks, /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120525/01146f03/attachment.html From alan.bateman at oracle.com Fri May 25 06:56:22 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 25 May 2012 13:56:22 +0000 Subject: hg: jdk8/tl/jdk: 7171474: Incorrect @see tags in java.lang.NumberFormatException javadoc Message-ID: <20120525135643.C02C047518@hg.openjdk.java.net> Changeset: f92325f12654 Author: jgish Date: 2012-05-24 11:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f92325f12654 7171474: Incorrect @see tags in java.lang.NumberFormatException javadoc Summary: update javadoc for NumberFormatException Reviewed-by: alanb ! src/share/classes/java/lang/NumberFormatException.java From markus.gronlund at oracle.com Fri May 25 08:26:52 2012 From: markus.gronlund at oracle.com (=?iso-8859-1?B?TWFya3VzIEdy9m5sdW5k?=) Date: Fri, 25 May 2012 08:26:52 -0700 (PDT) Subject: RFR (S): 7165257: Adding JFR test targets In-Reply-To: References: Message-ID: Looks good! ? /Markus ? From: Staffan Larsen Sent: den 25 maj 2012 15:42 To: serviceability-dev serviceability-dev at openjdk.java.net Subject: RFR (S): 7165257: Adding JFR test targets ? Please review the following change to makefiles to add a target for the JFR tests. ? Webrev:?http://cr.openjdk.java.net/~sla/7165257/webrev.01/ ? Thanks, /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120525/50291a37/attachment.html From daniel.daugherty at oracle.com Fri May 25 10:38:51 2012 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Fri, 25 May 2012 17:38:51 +0000 Subject: hg: jdk8/tl/jdk: 7170449: Management is completely broken at least on Solaris 11 X86 Message-ID: <20120525173901.EA8F14751F@hg.openjdk.java.net> Changeset: 82134992123c Author: dcubed Date: 2012-05-25 08:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82134992123c 7170449: Management is completely broken at least on Solaris 11 X86 Summary: Work around 'gobjcopy' failures on Solaris by adding temporary tools to add the '.gnu_debuglink' section and remove the SHF_ALLOC flag from "empty" section headers. Reviewed-by: sspitsyn, acorn ! make/common/Defs-solaris.gmk ! make/common/Defs.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/tools/Makefile + make/tools/add_gnu_debuglink/Makefile + make/tools/add_gnu_debuglink/add_gnu_debuglink.c + make/tools/fix_empty_sec_hdr_flags/Makefile + make/tools/fix_empty_sec_hdr_flags/fix_empty_sec_hdr_flags.c From daniel.daugherty at oracle.com Fri May 25 13:00:35 2012 From: daniel.daugherty at oracle.com (daniel.daugherty at oracle.com) Date: Fri, 25 May 2012 20:00:35 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20120525200041.B42EE47524@hg.openjdk.java.net> Changeset: 9c1709c4c80c Author: dcubed Date: 2012-05-24 12:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9c1709c4c80c 7165598: enable FDS on Solaris X64 when 7165593 is fixed Summary: Work around 'gobjcopy' failure on Solaris X64 by adding a temporary tool that removes the SHF_ALLOC flag from "empty" section headers. Reviewed-by: sspitsyn, acorn ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/dtrace.make + make/solaris/makefiles/fix_empty_sec_hdr_flags.make ! make/solaris/makefiles/jsig.make ! make/solaris/makefiles/saproc.make ! make/solaris/makefiles/vm.make + src/os/solaris/fix_empty_sec_hdr_flags/fix_empty_sec_hdr_flags.c Changeset: fb8f9ab27c14 Author: dcubed Date: 2012-05-24 12:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fb8f9ab27c14 Merge ! make/solaris/makefiles/defs.make ! make/solaris/makefiles/vm.make ! make/windows/makefiles/defs.make From john.coomes at oracle.com Fri May 25 16:25:45 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 25 May 2012 23:25:45 +0000 Subject: hg: hsx/hotspot-rt/langtools: 6 new changesets Message-ID: <20120525232603.2B14647530@hg.openjdk.java.net> Changeset: d10db3576c08 Author: ksrini Date: 2012-05-04 07:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d10db3576c08 7166010: (javac) JavacMessager incorrectly restores log source file Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/processing/JavacMessager.java + test/tools/javac/processing/messager/MessagerDiags.java Changeset: 833bab705918 Author: ksrini Date: 2012-05-10 12:32 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/833bab705918 7159445: (javac) emits inaccurate diagnostics for enhanced for-loops Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/ForeachBadInitialization.java ! test/tools/javac/parser/JavacParserTest.java Changeset: 96a8278e323c Author: sundar Date: 2012-05-11 20:06 +0530 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/96a8278e323c 7166990: java/compiler Inherited interfaces using generics sometimes looses the generic type Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/TryWithResources/T7164542.java Changeset: 885806e74240 Author: lana Date: 2012-05-11 12:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/885806e74240 Merge Changeset: 86e0dad6aadf Author: lana Date: 2012-05-21 11:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/86e0dad6aadf Merge Changeset: 179fa85aeefa Author: katleman Date: 2012-05-24 16:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/179fa85aeefa Added tag jdk8-b40 for changeset 86e0dad6aadf ! .hgtags From lana.steuck at oracle.com Fri May 25 19:13:27 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 26 May 2012 02:13:27 +0000 Subject: hg: jdk8/tl: 5 new changesets Message-ID: <20120526021328.54F6347537@hg.openjdk.java.net> Changeset: 955a3e8ed4f0 Author: ohair Date: 2012-05-10 08:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/955a3e8ed4f0 7167593: Changed get_source.sh to allow for getting full oracle jdk repo forest Reviewed-by: erikj, asaha, chegar, sla, dholmes, mbykov, coleenp ! get_source.sh ! make/scripts/hgforest.sh Changeset: 8a4e92c10a9a Author: ohair Date: 2012-05-11 17:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8a4e92c10a9a 7167976: Fix broken get_source.sh script Reviewed-by: tbell ! make/scripts/hgforest.sh Changeset: 8927dd68aee3 Author: katleman Date: 2012-05-16 22:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8927dd68aee3 Merge Changeset: a2b2d435f1d2 Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/a2b2d435f1d2 Added tag jdk8-b39 for changeset 8927dd68aee3 ! .hgtags Changeset: 1a8c7c530f8a Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/1a8c7c530f8a Added tag jdk8-b40 for changeset a2b2d435f1d2 ! .hgtags From lana.steuck at oracle.com Fri May 25 19:13:25 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 26 May 2012 02:13:25 +0000 Subject: hg: jdk8/tl/corba: 2 new changesets Message-ID: <20120526021328.2A6F647536@hg.openjdk.java.net> Changeset: 56d030e5035f Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/56d030e5035f Added tag jdk8-b39 for changeset 785af00e2827 ! .hgtags Changeset: 113f0d5f0a08 Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/113f0d5f0a08 Added tag jdk8-b40 for changeset 56d030e5035f ! .hgtags From lana.steuck at oracle.com Fri May 25 19:13:28 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 26 May 2012 02:13:28 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20120526021336.2978F47538@hg.openjdk.java.net> Changeset: 09a0ddda03cb Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/09a0ddda03cb Added tag jdk8-b39 for changeset 7f6b44fd3034 ! .hgtags Changeset: f2072b164b05 Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/f2072b164b05 Added tag jdk8-b40 for changeset 09a0ddda03cb ! .hgtags From lana.steuck at oracle.com Fri May 25 19:13:39 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 26 May 2012 02:13:39 +0000 Subject: hg: jdk8/tl/jaxp: 2 new changesets Message-ID: <20120526021344.6E9DA47539@hg.openjdk.java.net> Changeset: 9ecfdbd6aed4 Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/9ecfdbd6aed4 Added tag jdk8-b39 for changeset f95fdbe525c8 ! .hgtags Changeset: 6f5c0e17415d Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6f5c0e17415d Added tag jdk8-b40 for changeset 9ecfdbd6aed4 ! .hgtags From lana.steuck at oracle.com Fri May 25 19:13:39 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 26 May 2012 02:13:39 +0000 Subject: hg: jdk8/tl/langtools: 4 new changesets Message-ID: <20120526021348.100DA4753A@hg.openjdk.java.net> Changeset: 8b869afd2eb4 Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8b869afd2eb4 Added tag jdk8-b39 for changeset a9f547c218d9 ! .hgtags Changeset: 86e0dad6aadf Author: lana Date: 2012-05-21 11:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/86e0dad6aadf Merge Changeset: 179fa85aeefa Author: katleman Date: 2012-05-24 16:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/179fa85aeefa Added tag jdk8-b40 for changeset 86e0dad6aadf ! .hgtags Changeset: f43aded513e7 Author: lana Date: 2012-05-25 16:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f43aded513e7 Merge From lana.steuck at oracle.com Fri May 25 19:13:35 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 26 May 2012 02:13:35 +0000 Subject: hg: jdk8/tl/hotspot: 32 new changesets Message-ID: <20120526021441.28B774753B@hg.openjdk.java.net> Changeset: 36538fd1225e Author: amurillo Date: 2012-05-04 15:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/36538fd1225e 7166615: new hotspot build - hs24-b10 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 8bafad97cd26 Author: jiangli Date: 2012-05-02 13:21 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8bafad97cd26 7158552: The instanceKlsss::_host_klass is only needed for anonymous class for JSR 292 support. Summary: Change the _host_klass to be conditionally created embedded instanceKlass field. Reviewed-by: jrose, coleenp, dholmes ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/instanceKlassKlass.hpp Changeset: 38b4116b6766 Author: jprovino Date: 2012-05-05 10:24 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/38b4116b6766 Merge Changeset: c7ed11779ce8 Author: jiangli Date: 2012-04-10 09:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c7ed11779ce8 7159772: instanceKlass::all_fields_count() returns incorrect total field count Summary: Fix instanceKlass::all_fields_count() bug. Reviewed-by: kvn, never Contributed-by: Jiangli Zhou ! src/share/vm/oops/instanceKlass.hpp Changeset: 3576af4cb939 Author: iveresov Date: 2012-04-11 19:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3576af4cb939 7160539: JDeveloper crashes on 64-bit Windows Summary: x64 C1 needs to zero upper 32bits when doing l2i conversion Reviewed-by: never, kvn ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: 847da049d62f Author: never Date: 2012-04-17 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/847da049d62f 7162094: LateInlineCallGenerator::do_late_inline crashed on uninitialized _call_node Reviewed-by: never, twisti Contributed-by: nils.eliasson at oracle.com ! src/share/vm/opto/callGenerator.cpp Changeset: df3d4a91f7f6 Author: never Date: 2012-04-18 16:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/df3d4a91f7f6 7161796: PhaseStringOpts::fetch_static_field tries to fetch field from the Klass instead of the mirror Reviewed-by: twisti ! src/share/vm/opto/stringopts.cpp Changeset: ec15e8f6e4f1 Author: twisti Date: 2012-04-24 12:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ec15e8f6e4f1 7157695: Add windows implementation of socket interface Reviewed-by: kvn, dholmes, twisti Contributed-by: Nils Eliasson ! src/os/windows/vm/jvm_windows.h ! src/os/windows/vm/os_windows.cpp Changeset: dc682d9431f3 Author: kvn Date: 2012-05-07 12:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dc682d9431f3 7160610: Unknown Native Code compilation issue Summary: When constructing input vector use type of vector's operation which use it since element's sizes should match. Reviewed-by: never, twisti ! src/share/vm/opto/superword.cpp + test/compiler/7160610/Test7160610.java Changeset: 3a97daec1b34 Author: kvn Date: 2012-05-08 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3a97daec1b34 7167266: missing copyright notes in 3rd party code Summary: add missing copyright notes to the regression test file. Reviewed-by: twisti, johnc ! test/compiler/7070134/Stemmer.java Changeset: 2766551175a0 Author: kvn Date: 2012-05-09 10:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2766551175a0 Merge ! src/share/vm/oops/instanceKlass.hpp Changeset: a05a695ea044 Author: stefank Date: 2012-05-10 11:27 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a05a695ea044 7167437: Can't build on linux without precompiled headers Reviewed-by: brutisso, mgerdin ! src/share/vm/memory/space.hpp ! src/share/vm/memory/space.inline.hpp Changeset: f47478089efc Author: brutisso Date: 2012-05-10 14:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f47478089efc 7167069: 6 VM flags crash the VM when queried via jinfo Summary: Added missing double format to Flag::print_as_flag() Reviewed-by: dholmes, stefank, coleenp ! src/share/vm/runtime/globals.cpp + test/runtime/7167069/PrintAsFlag.java Changeset: 5799726c54d7 Author: jcoomes Date: 2012-05-11 06:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5799726c54d7 Merge Changeset: 73147e6c4881 Author: amurillo Date: 2012-05-11 14:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/73147e6c4881 Merge Changeset: 96a403721094 Author: amurillo Date: 2012-05-11 14:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/96a403721094 Added tag hs24-b10 for changeset 73147e6c4881 ! .hgtags Changeset: 26423ef693ac Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/26423ef693ac Added tag jdk8-b39 for changeset 96a403721094 ! .hgtags Changeset: 56d1af561395 Author: amurillo Date: 2012-05-11 14:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/56d1af561395 7168247: new hotspot build - hs24-b11 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 35e504cb49a6 Author: collins Date: 2012-05-11 11:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/35e504cb49a6 7167625: Adjustments for SE-Embedded build process Summary: Simple change to the SE-Embedded build rules that should not affect any other OpenJDK users. Reviewed-by: kvn, dholmes ! make/linux/makefiles/vm.make ! src/share/vm/runtime/arguments.cpp Changeset: fada85d11d92 Author: jprovino Date: 2012-05-16 13:33 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fada85d11d92 Merge Changeset: 8f972594effc Author: kvn Date: 2012-05-14 09:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8f972594effc 6924259: Remove String.count/String.offset Summary: Allow a version of String class that doesn't have count and offset fields. Reviewed-by: never, coleenp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/memory/dump.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/opto/stringopts.hpp Changeset: de0cc3dd9f10 Author: kvn Date: 2012-05-17 09:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/de0cc3dd9f10 Merge Changeset: 3a22b77e755a Author: brutisso Date: 2012-05-14 17:32 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3a22b77e755a 7161545: G1: Minor cleanups to the G1 logging Summary: Rename "to-space-overflow" to "to-space-exhausted", Introduce one decimal point in the size format, Add Sum to the aggregate and re-order the entries, Add number of GC workers to the log output Reviewed-by: johnc, jwilhelm ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 78a1b285cda8 Author: mikael Date: 2012-05-15 00:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/78a1b285cda8 7158457: division by zero in adaptiveweightedaverage Summary: Add ceiling to AdaptiveWeightedAverage Reviewed-by: ysr, iveresov ! src/share/vm/gc_implementation/shared/gcUtil.cpp ! src/share/vm/gc_implementation/shared/gcUtil.hpp Changeset: 33e366609904 Author: johnc Date: 2012-05-14 21:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/33e366609904 Merge Changeset: 1096fc5a52eb Author: johnc Date: 2012-05-15 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1096fc5a52eb 7168294: G1: Some Full GCs incorrectly report GC cause as "No GC" Summary: GC cause was not being set by the VM_G1CollectForAllocation VM operation. Reviewed-by: jmasa, ysr, brutisso ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp Changeset: cdfa5139bd58 Author: brutisso Date: 2012-05-15 22:26 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cdfa5139bd58 7169056: Add gigabyte unit to proper_unit_for_byte_size() and byte_size_in_proper_unit() Reviewed-by: jwilhelm, johnc, dholmes ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 9d679effd28c Author: brutisso Date: 2012-05-15 10:25 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9d679effd28c 7166894: Add gc cause to GC logging for all collectors Reviewed-by: mgerdin, johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_interface/gcCause.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.hpp Changeset: cdeda3fd141e Author: jcoomes Date: 2012-05-18 10:27 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cdeda3fd141e Merge ! src/share/vm/runtime/arguments.cpp Changeset: 14b0e07ab9a6 Author: amurillo Date: 2012-05-18 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/14b0e07ab9a6 Merge Changeset: ff9decc8235d Author: amurillo Date: 2012-05-18 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ff9decc8235d Added tag hs24-b11 for changeset 14b0e07ab9a6 ! .hgtags Changeset: 48064e53e997 Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/48064e53e997 Added tag jdk8-b40 for changeset ff9decc8235d ! .hgtags From lana.steuck at oracle.com Fri May 25 19:14:31 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Sat, 26 May 2012 02:14:31 +0000 Subject: hg: jdk8/tl/jdk: 39 new changesets Message-ID: <20120526022105.9185D4753C@hg.openjdk.java.net> Changeset: c2d9166f3284 Author: ihse Date: 2012-05-11 08:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2d9166f3284 7168208: Change use of @ in one sed command involving paths to different character Reviewed-by: ohair ! make/common/Release.gmk Changeset: 8d665b69ebf1 Author: mfang Date: 2012-05-15 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d665b69ebf1 7157855: jvisualvm.1 not included in binaries Reviewed-by: katleman, thurka ! make/common/Release.gmk Changeset: b6f529117521 Author: katleman Date: 2012-05-16 22:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b6f529117521 Merge Changeset: 47cd90bf0f66 Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/47cd90bf0f66 Added tag jdk8-b39 for changeset b6f529117521 ! .hgtags Changeset: 7c4eed4b6c19 Author: bae Date: 2012-05-21 14:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c4eed4b6c19 7124400: [macosx] CGraphicsDevice.getConfigurations() returns reference to member (does not copy configs) Reviewed-by: anthony, kizune ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! test/java/awt/GraphicsDevice/CloneConfigsTest.java Changeset: 416b3a498e71 Author: bae Date: 2012-05-21 14:53 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/416b3a498e71 7154088: [macosx] Regression: Component.createImage do not inherits component attributes Reviewed-by: art, kizune ! src/macosx/classes/sun/lwawt/LWComponentPeer.java Changeset: 1b90a0113359 Author: lana Date: 2012-05-21 11:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1b90a0113359 Merge Changeset: c31eeeda3ed1 Author: serb Date: 2012-05-03 18:29 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c31eeeda3ed1 7160623: [macosx] Editable TextArea/TextField are blocking GUI applications from exit Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java Changeset: a420895ee2c3 Author: leonidr Date: 2012-05-03 19:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a420895ee2c3 7124376: [macosx] Modal dialog lost focus Reviewed-by: anthony ! src/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/macosx/classes/sun/lwawt/PlatformWindow.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 95c8b63a3c47 Author: kizune Date: 2012-05-03 21:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/95c8b63a3c47 7148289: [macosx] Deadlock in sun.lwawt.macosx.CWrapper$NSScreen.visibleFrame Reviewed-by: leonidr ! src/macosx/classes/sun/lwawt/macosx/CToolkitThreadBlockedHandler.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/macosx/native/sun/awt/LWCToolkit.m Changeset: a714e2e2b257 Author: alexsch Date: 2012-05-04 13:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a714e2e2b257 7024963: Notepad demo: remove non-translatable resources from Notepad.properties file Reviewed-by: rupashka ! src/share/demo/jfc/Notepad/Notepad.java ! src/share/demo/jfc/Notepad/resources/Notepad.properties + src/share/demo/jfc/Notepad/resources/system.properties Changeset: 4cc873e28c78 Author: bagiras Date: 2012-05-04 18:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4cc873e28c78 7146237: closed/java/awt/Focus/SetFocusTraversalKeysTest/SetFocusTraversalTest.html failed since 1.8.0b19 Reviewed-by: art, anthony ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/javax/swing/JComponent.java Changeset: 0feee4541f67 Author: serb Date: 2012-05-04 21:25 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0feee4541f67 7147055: [macosx] Cursors are changing over a blocked window; also blinking Reviewed-by: art, kizune ! src/macosx/classes/sun/lwawt/LWCursorManager.java Changeset: 912e666b4e1d Author: serb Date: 2012-05-10 20:05 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/912e666b4e1d 7080109: Dialog.show() lacks doPrivileged() to access system event queue Reviewed-by: art, anthony ! src/share/classes/java/awt/Dialog.java + test/java/awt/Dialog/ModalDialogPermission/ModalDialogPermission.java + test/java/awt/Dialog/ModalDialogPermission/java.policy Changeset: 18842bb6676a Author: lana Date: 2012-05-10 11:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18842bb6676a Merge - src/macosx/bin/amd64/jvm.cfg - src/share/classes/sun/security/action/LoadLibraryAction.java - test/tools/pack200/dyn.jar - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java Changeset: 4f39a13e74c6 Author: anthony Date: 2012-05-11 16:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f39a13e74c6 7166437: [macosx] Support for Window.Type.UTILITY on the Mac Summary: Apply the native UTILITY style for UTILITY Java windows Reviewed-by: art ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: 689c0cd214e8 Author: anthony Date: 2012-05-11 20:37 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/689c0cd214e8 7149062: [macosx] dock menu don't show available frames Summary: Inherit from either NSWindow for normal windows or NSPanel for utility windows Reviewed-by: skovatch, swingler ! src/macosx/native/sun/awt/AWTView.m ! src/macosx/native/sun/awt/AWTWindow.h ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 3b8635e357e9 Author: alexsch Date: 2012-05-12 12:01 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b8635e357e9 7024965: Stylepad demo: remove non-translatable resources from Stylepad.properties file Reviewed-by: alexp ! src/share/demo/jfc/Notepad/Notepad.java + src/share/demo/jfc/Notepad/resources/NotepadSystem.properties - src/share/demo/jfc/Notepad/resources/system.properties Changeset: cc8d1cc533bf Author: alexp Date: 2012-05-12 17:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc8d1cc533bf 7149005: [macosx] Java Control Panel's UI controls are distorted when draging scroll bar. Reviewed-by: serb ! src/macosx/classes/com/apple/laf/AquaButtonLabeledUI.java Changeset: 69301efaac91 Author: ant Date: 2012-05-12 18:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/69301efaac91 7110683: Issues with some KeyboardFocusManager method Reviewed-by: ahgross ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/Window.java Changeset: 28ec5b811aa2 Author: dcherepanov Date: 2012-05-15 15:04 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28ec5b811aa2 7168550: [macosx] duplicate OGL context state changes related to vertex cache Reviewed-by: bae, swingler ! src/macosx/native/sun/java2d/opengl/CGLSurfaceData.m ! src/share/native/sun/java2d/opengl/OGLContext.h ! src/share/native/sun/java2d/opengl/OGLTextRenderer.c ! src/share/native/sun/java2d/opengl/OGLVertexCache.c ! src/share/native/sun/java2d/opengl/OGLVertexCache.h Changeset: cad0bb1a9bdb Author: dcherepanov Date: 2012-05-16 13:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cad0bb1a9bdb 7124337: [macosx] FileDialog fails to select multiple files Reviewed-by: anthony, swingler ! src/macosx/classes/sun/lwawt/macosx/CFileDialog.java ! src/macosx/native/sun/awt/CFileDialog.h ! src/macosx/native/sun/awt/CFileDialog.m ! src/share/classes/java/awt/FileDialog.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/solaris/classes/sun/awt/X11/GtkFileDialogPeer.java ! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java ! src/windows/classes/sun/awt/windows/WFileDialogPeer.java Changeset: 7c0b390ab5f9 Author: anthony Date: 2012-05-16 14:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c0b390ab5f9 7168851: [macosx] Netbeans crashes in CImage.nativeCreateNSImageFromArray Summary: Eliminate unnecessary -release call Reviewed-by: dcherepanov ! src/macosx/native/sun/awt/CImage.m Changeset: 3c819d638e36 Author: alexsch Date: 2012-05-16 16:27 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c819d638e36 7169226: NLS: Please change the mnemonic assignment system for windows and motif properties Reviewed-by: rupashka ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_de.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_es.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_fr.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_it.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ja.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ko.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_sv.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_TW.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_de.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_es.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_it.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ja.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ko.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_sv.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_TW.properties Changeset: 19edcc438203 Author: alexsch Date: 2012-05-16 18:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19edcc438203 7158928: [macosx] NLS: Please change the mnemonic assignment system Reviewed-by: rupashka, serb ! make/com/apple/osxui/Makefile ! make/common/internal/Resources.gmk ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java ! src/macosx/classes/com/apple/laf/resources/aqua.properties Changeset: 731ee59c6ba2 Author: alexsch Date: 2012-05-17 14:27 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/731ee59c6ba2 7148281: [macosx] JTabbedPane tabs with HTML text do not render correctly Reviewed-by: kizune ! src/macosx/classes/com/apple/laf/AquaTabbedPaneUI.java Changeset: f9217bd87199 Author: rupashka Date: 2012-05-17 15:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9217bd87199 7166322: closed/javax/swing/text/html/HTMLEditorKit/4242228/bug4242228.java failed since 1.8.0b36 Reviewed-by: alexsch + test/javax/swing/text/html/HTMLEditorKit/4242228/bug4242228.java Changeset: c00d6508afce Author: ant Date: 2012-05-17 21:27 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c00d6508afce 7142565: [macosx] Many special keys processed twice in text fields Summary: forward port from 7u4 Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTView.m Changeset: 17c5e1a12965 Author: ant Date: 2012-05-17 21:31 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17c5e1a12965 7154072: [macosx] swallowing key events Summary: forward posrt from 7u4 Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTView.m Changeset: ef77fa799b34 Author: ant Date: 2012-05-17 21:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ef77fa799b34 7125044: [macosx] Test failure because Component.transferFocus() works differently in applet and application. Summary: forward port from 7u4 Reviewed-by: art ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/Frame.java ! src/share/classes/java/awt/Window.java ! src/share/classes/javax/swing/JApplet.java ! src/share/classes/javax/swing/JDialog.java ! src/share/classes/javax/swing/JFrame.java ! src/share/classes/javax/swing/JInternalFrame.java ! src/share/classes/javax/swing/JWindow.java ! src/share/classes/javax/swing/UIManager.java ! src/share/classes/sun/awt/SunToolkit.java + test/java/awt/Focus/FocusTraversalPolicy/InitialFTP.java + test/java/awt/Focus/FocusTraversalPolicy/InitialFTP_AWT.java + test/java/awt/Focus/FocusTraversalPolicy/InitialFTP_Swing.java + test/java/awt/event/KeyEvent/SwallowKeyEvents/SwallowKeyEvents.java Changeset: 5976b5848554 Author: ant Date: 2012-05-17 22:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5976b5848554 7145768: [macosx] Regression: failure in b11 of ModalDialogInFocusEventTest Summary: forward port from 7u4 Reviewed-by: art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWWindowPeer.java Changeset: 1d75ff45586e Author: ant Date: 2012-05-17 22:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d75ff45586e 7145827: [macosx] JCK failure in b11: FocusableWindow3 Summary: forward posrt from 7u4 Reviewed-by: art ! src/macosx/classes/sun/lwawt/LWWindowPeer.java Changeset: 2eca75e0a063 Author: dcherepanov Date: 2012-05-18 19:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2eca75e0a063 7156191: [macosx] Can't type into applet demos in Pivot Reviewed-by: art ! src/macosx/classes/sun/lwawt/macosx/CEmbeddedFrame.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformView.java ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java Changeset: 1ee12bca4823 Author: rupashka Date: 2012-05-21 18:55 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ee12bca4823 7168144: No appropriate CCC request for changes introduced by 7154030 Reviewed-by: alexsch ! src/share/classes/javax/swing/JComponent.java Changeset: 967b38bfd5c1 Author: ant Date: 2012-05-22 01:12 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/967b38bfd5c1 7170427: setGlobalCurrentFocusCycleRoot unexpectedly throws SecurityException Reviewed-by: art ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/KeyboardFocusManager.java Changeset: 5b2095d7a60b Author: lana Date: 2012-05-21 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5b2095d7a60b Merge ! src/macosx/classes/sun/lwawt/LWComponentPeer.java Changeset: b88fc3359dc7 Author: lana Date: 2012-05-21 11:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b88fc3359dc7 Merge Changeset: 7def50698e78 Author: katleman Date: 2012-05-24 16:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7def50698e78 Added tag jdk8-b40 for changeset b88fc3359dc7 ! .hgtags Changeset: 7abdd3cb14ed Author: lana Date: 2012-05-25 16:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7abdd3cb14ed Merge From zhengyu.gu at oracle.com Sat May 26 08:01:31 2012 From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com) Date: Sat, 26 May 2012 15:01:31 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 27 new changesets Message-ID: <20120526150223.C91DD4754E@hg.openjdk.java.net> Changeset: a05a695ea044 Author: stefank Date: 2012-05-10 11:27 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a05a695ea044 7167437: Can't build on linux without precompiled headers Reviewed-by: brutisso, mgerdin ! src/share/vm/memory/space.hpp ! src/share/vm/memory/space.inline.hpp Changeset: f47478089efc Author: brutisso Date: 2012-05-10 14:16 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f47478089efc 7167069: 6 VM flags crash the VM when queried via jinfo Summary: Added missing double format to Flag::print_as_flag() Reviewed-by: dholmes, stefank, coleenp ! src/share/vm/runtime/globals.cpp + test/runtime/7167069/PrintAsFlag.java Changeset: 5799726c54d7 Author: jcoomes Date: 2012-05-11 06:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5799726c54d7 Merge Changeset: 4ee58fcab520 Author: katleman Date: 2012-05-09 13:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4ee58fcab520 Added tag jdk8-b37 for changeset bfcf92bfefb8 ! .hgtags Changeset: 637c3f5f068f Author: amurillo Date: 2012-05-09 14:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/637c3f5f068f Merge ! .hgtags Changeset: 3c394919ca69 Author: katleman Date: 2012-05-10 10:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3c394919ca69 Added tag jdk8-b38 for changeset 637c3f5f068f ! .hgtags Changeset: 73147e6c4881 Author: amurillo Date: 2012-05-11 14:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/73147e6c4881 Merge Changeset: 96a403721094 Author: amurillo Date: 2012-05-11 14:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/96a403721094 Added tag hs24-b10 for changeset 73147e6c4881 ! .hgtags Changeset: 56d1af561395 Author: amurillo Date: 2012-05-11 14:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/56d1af561395 7168247: new hotspot build - hs24-b11 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 35e504cb49a6 Author: collins Date: 2012-05-11 11:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/35e504cb49a6 7167625: Adjustments for SE-Embedded build process Summary: Simple change to the SE-Embedded build rules that should not affect any other OpenJDK users. Reviewed-by: kvn, dholmes ! make/linux/makefiles/vm.make ! src/share/vm/runtime/arguments.cpp Changeset: fada85d11d92 Author: jprovino Date: 2012-05-16 13:33 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fada85d11d92 Merge Changeset: 8f972594effc Author: kvn Date: 2012-05-14 09:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8f972594effc 6924259: Remove String.count/String.offset Summary: Allow a version of String class that doesn't have count and offset fields. Reviewed-by: never, coleenp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/memory/dump.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/opto/stringopts.hpp Changeset: de0cc3dd9f10 Author: kvn Date: 2012-05-17 09:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/de0cc3dd9f10 Merge Changeset: 3a22b77e755a Author: brutisso Date: 2012-05-14 17:32 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3a22b77e755a 7161545: G1: Minor cleanups to the G1 logging Summary: Rename "to-space-overflow" to "to-space-exhausted", Introduce one decimal point in the size format, Add Sum to the aggregate and re-order the entries, Add number of GC workers to the log output Reviewed-by: johnc, jwilhelm ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 78a1b285cda8 Author: mikael Date: 2012-05-15 00:56 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/78a1b285cda8 7158457: division by zero in adaptiveweightedaverage Summary: Add ceiling to AdaptiveWeightedAverage Reviewed-by: ysr, iveresov ! src/share/vm/gc_implementation/shared/gcUtil.cpp ! src/share/vm/gc_implementation/shared/gcUtil.hpp Changeset: 33e366609904 Author: johnc Date: 2012-05-14 21:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/33e366609904 Merge Changeset: 1096fc5a52eb Author: johnc Date: 2012-05-15 09:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1096fc5a52eb 7168294: G1: Some Full GCs incorrectly report GC cause as "No GC" Summary: GC cause was not being set by the VM_G1CollectForAllocation VM operation. Reviewed-by: jmasa, ysr, brutisso ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp Changeset: cdfa5139bd58 Author: brutisso Date: 2012-05-15 22:26 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cdfa5139bd58 7169056: Add gigabyte unit to proper_unit_for_byte_size() and byte_size_in_proper_unit() Reviewed-by: jwilhelm, johnc, dholmes ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 9d679effd28c Author: brutisso Date: 2012-05-15 10:25 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9d679effd28c 7166894: Add gc cause to GC logging for all collectors Reviewed-by: mgerdin, johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_interface/gcCause.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.hpp Changeset: cdeda3fd141e Author: jcoomes Date: 2012-05-18 10:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cdeda3fd141e Merge ! src/share/vm/runtime/arguments.cpp Changeset: 26423ef693ac Author: katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/26423ef693ac Added tag jdk8-b39 for changeset 96a403721094 ! .hgtags Changeset: 14b0e07ab9a6 Author: amurillo Date: 2012-05-18 14:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/14b0e07ab9a6 Merge Changeset: ff9decc8235d Author: amurillo Date: 2012-05-18 14:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ff9decc8235d Added tag hs24-b11 for changeset 14b0e07ab9a6 ! .hgtags Changeset: 03d61caacd1e Author: amurillo Date: 2012-05-18 14:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/03d61caacd1e 7170006: new hotspot build - hs24-b12 Reviewed-by: jcoomes ! make/hotspot_version Changeset: cee14a6fc5ac Author: zgu Date: 2012-05-22 20:29 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cee14a6fc5ac Merge Changeset: cd3a8ab0352b Author: zgu Date: 2012-05-24 20:04 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/cd3a8ab0352b Merge Changeset: 17be2328b50b Author: zgu Date: 2012-05-26 06:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/17be2328b50b Merge From littlee at linux.vnet.ibm.com Mon May 28 18:43:59 2012 From: littlee at linux.vnet.ibm.com (littlee at linux.vnet.ibm.com) Date: Tue, 29 May 2012 01:43:59 +0000 Subject: hg: jdk8/tl/jdk: 7172177: test/java/util/TimeZone/DstTzTest.java failing on all platforms Message-ID: <20120529014409.398D14757F@hg.openjdk.java.net> Changeset: 60033ab79213 Author: littlee Date: 2012-05-29 09:42 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60033ab79213 7172177: test/java/util/TimeZone/DstTzTest.java failing on all platforms Reviewed-by: alanb, okutsu - test/java/util/TimeZone/DstTzTest.java From kurchi.subhra.hazra at oracle.com Tue May 29 13:17:07 2012 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Tue, 29 May 2012 20:17:07 +0000 Subject: hg: jdk8/tl/jdk: 7171591: getDefaultScopeID() in src/solaris/native/java/net/net_util_md.c should return a value Message-ID: <20120529201726.3F0474759D@hg.openjdk.java.net> Changeset: eb441933f6fe Author: khazra Date: 2012-05-29 13:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/eb441933f6fe 7171591: getDefaultScopeID() in src/solaris/native/java/net/net_util_md.c should return a value Summary: Use CHECK_NULL_RETURN instead of CHECK_NULL Reviewed-by: alanb ! src/solaris/native/java/net/net_util_md.c From erik.gahlin at oracle.com Wed May 30 04:40:47 2012 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Wed, 30 May 2012 13:40:47 +0200 Subject: RFR: 7172176 java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing Message-ID: <4FC6073F.6060005@oracle.com> Hi, Could you please review 7172176, which is a test fix for 7017818 - JConsoleResources.java cannot be handled by translation team. Webrev: http://cr.openjdk.java.net/~egahlin/7172176_01/ Changes: - Removed the ImmutableRequest.java and ImmutableRequest.sh since the JConsoleResources class was refactored away with 7017818. - Removed hard-wired resource bundle keys in ResourceCheckTest.java, the keys are now looked up by reflection on the Messages class. The test also checks there is one-to-one mapping between reource bundle keys and the constants available in the Message class. Michael, I removed sun/tools/jconsole/ResourceCheckTest.sh from the jdk/test/ ProblemList.txt. This means the test will break once the translated files will be checked in. Unused messages were sent for translation and they need to be removed. Are you ok with that? Thanks! Erik From kumar.x.srinivasan at oracle.com Wed May 30 09:42:50 2012 From: kumar.x.srinivasan at oracle.com (kumar.x.srinivasan at oracle.com) Date: Wed, 30 May 2012 16:42:50 +0000 Subject: hg: jdk8/tl/jdk: 7168401: pack200 does not produce a compatible pack file for JDK7 classes if indy is not present Message-ID: <20120530164309.E6A5D475C4@hg.openjdk.java.net> Changeset: 41dcfdbf8f07 Author: ksrini Date: 2012-05-29 14:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41dcfdbf8f07 7168401: pack200 does not produce a compatible pack file for JDK7 classes if indy is not present Reviewed-by: jrose ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java ! src/share/classes/com/sun/java/util/jar/pack/ClassWriter.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/Package.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java ! test/tools/pack200/PackageVersionTest.java From tim.bell at oracle.com Wed May 30 10:00:27 2012 From: tim.bell at oracle.com (Tim Bell) Date: Wed, 30 May 2012 10:00:27 -0700 Subject: RFR: 7172176 java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing In-Reply-To: <4FC6073F.6060005@oracle.com> References: <4FC6073F.6060005@oracle.com> Message-ID: <4FC6522B.3010601@oracle.com> Erik: Well done - thank you for fixing this! I apologize for inflicting the original test implementation on jconsole. It is very embarrassing to look at code I wrote eight years ago. Tim Bell On 05/30/12 04:40, Erik Gahlin wrote: > Hi, > > Could you please review 7172176, which is a test fix for 7017818 - > JConsoleResources.java cannot be handled by translation team. > > Webrev: > http://cr.openjdk.java.net/~egahlin/7172176_01/ > > Changes: > > - Removed the ImmutableRequest.java and ImmutableRequest.sh since the > JConsoleResources class was refactored away with 7017818. > > - Removed hard-wired resource bundle keys in ResourceCheckTest.java, > the keys > are now looked up by reflection on the Messages class. The test also > checks there is one-to-one mapping between reource bundle keys and > the constants available in the Message class. > > Michael, > > I removed sun/tools/jconsole/ResourceCheckTest.sh from the jdk/test/ > ProblemList.txt. This means the test will break once the translated files > will be checked in. Unused messages were sent for translation and they > need to be removed. > > Are you ok with that? > > Thanks! > Erik From michael.fang at oracle.com Wed May 30 17:09:41 2012 From: michael.fang at oracle.com (Michael Fang) Date: Wed, 30 May 2012 17:09:41 -0700 Subject: RFR: 7172176 java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing In-Reply-To: <4FC6073F.6060005@oracle.com> References: <4FC6073F.6060005@oracle.com> Message-ID: <4FC6B6C5.4060401@oracle.com> Hi Erik, No problem, I will manually remove the unused messages for now. In the future message update, they will automatically not be present either. thanks, -michael On 12?05?30? 04:40 ??, Erik Gahlin wrote: > Hi, > > Could you please review 7172176, which is a test fix for 7017818 - > JConsoleResources.java cannot be handled by translation team. > > Webrev: > http://cr.openjdk.java.net/~egahlin/7172176_01/ > > Changes: > > - Removed the ImmutableRequest.java and ImmutableRequest.sh since the > JConsoleResources class was refactored away with 7017818. > > - Removed hard-wired resource bundle keys in ResourceCheckTest.java, > the keys > are now looked up by reflection on the Messages class. The test also > checks there is one-to-one mapping between reource bundle keys and > the constants available in the Message class. > > Michael, > > I removed sun/tools/jconsole/ResourceCheckTest.sh from the jdk/test/ > ProblemList.txt. This means the test will break once the translated files > will be checked in. Unused messages were sent for translation and they > need to be removed. > > Are you ok with that? > > Thanks! > Erik From mandy.chung at oracle.com Wed May 30 18:15:38 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 30 May 2012 18:15:38 -0700 Subject: RFR: 7172176 java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing In-Reply-To: <4FC6073F.6060005@oracle.com> References: <4FC6073F.6060005@oracle.com> Message-ID: <4FC6C63A.1070906@oracle.com> Looks good. Sorry for not catching the test issue during the review for 7017818. Mandy On 5/30/2012 4:40 AM, Erik Gahlin wrote: > Hi, > > Could you please review 7172176, which is a test fix for 7017818 - > JConsoleResources.java cannot be handled by translation team. > > Webrev: > http://cr.openjdk.java.net/~egahlin/7172176_01/ > > Changes: > > - Removed the ImmutableRequest.java and ImmutableRequest.sh since the > JConsoleResources class was refactored away with 7017818. > > - Removed hard-wired resource bundle keys in ResourceCheckTest.java, > the keys > are now looked up by reflection on the Messages class. The test also > checks there is one-to-one mapping between reource bundle keys and > the constants available in the Message class. > > Michael, > > I removed sun/tools/jconsole/ResourceCheckTest.sh from the jdk/test/ > ProblemList.txt. This means the test will break once the translated files > will be checked in. Unused messages were sent for translation and they > need to be removed. > > Are you ok with that? > > Thanks! > Erik From mike.duigou at oracle.com Wed May 30 20:22:35 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 31 May 2012 03:22:35 +0000 Subject: hg: jdk8/tl/jdk: 6924259: Remove offset and count fields from java.lang.String Message-ID: <20120531032252.A69774763C@hg.openjdk.java.net> Changeset: 2c773daa825d Author: mduigou Date: 2012-05-17 10:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2c773daa825d 6924259: Remove offset and count fields from java.lang.String Summary: Removes the use of shared character array buffers by String along with the two fields needed to support the use of shared buffers. Reviewed-by: alanb, mduigou, forax, briangoetz Contributed-by: brian.doherty at oracle.com ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/StringCoding.java From weijun.wang at oracle.com Wed May 30 21:35:23 2012 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 31 May 2012 12:35:23 +0800 Subject: Code review request: 7173036: test/com/sun/jdi/ConnectedVMs.java does not run as expected In-Reply-To: <944281.1338438053117.JavaMail.sbladm@swsblss4-new.central.sun.com> References: <944281.1338438053117.JavaMail.sbladm@swsblss4-new.central.sun.com> Message-ID: <4FC6F50B.70302@oracle.com> Hi All I was working on something else and noticed a jtreg problem, that it does not handle parenthesis and whitespaces like a normal shell does. A little grep shows this test might not work as expected. Here is the webrev: http://cr.openjdk.java.net/~weijun/7173036/webrev.00/ I've added an else clause to avoid similar errors in the future. Thanks Max -------- Original Message -------- *Change Request ID*: 7173036 *Synopsis*: test/com/sun/jdi/ConnectedVMs.java does not run as expected http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7173036 === *Description* ============================================================ jtreg does not support parenthesis and whitespaces on its @run action line, therefore this test is never really exceuted as expected. *** (#1 of 1): 2012-05-31 04:13:51 GMT+00:00 weijun.wang at oracle.com From mike.duigou at oracle.com Wed May 30 22:19:10 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Thu, 31 May 2012 05:19:10 +0000 Subject: hg: jdk8/tl/jdk: 7126277: Alternative String hashing implementation Message-ID: <20120531051930.AA11E47640@hg.openjdk.java.net> Changeset: 43bd5ee0205e Author: mduigou Date: 2012-05-30 22:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43bd5ee0205e 7126277: Alternative String hashing implementation Summary: All of the hashing based Map implementations: HashMap, Hashtable, LinkedHashMap, WeakHashMap and ConcurrentHashMap are modified to use an enhanced hashing algorithm for string keys when the capacity of the hash table has ever grown beyond 512 entries. The enhanced hashing implementation uses the murmur3 hashing algorithm along with random hash seeds and index masks. These enhancements mitigate cases where colliding String hash values could result in a performance bottleneck. Reviewed-by: alanb, forax, dl ! make/java/java/FILES_java.gmk ! src/share/classes/java/lang/String.java ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/LinkedHashMap.java ! src/share/classes/java/util/WeakHashMap.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java + src/share/classes/sun/misc/Hashing.java ! test/java/util/Collection/BiggernYours.java ! test/java/util/Hashtable/HashCode.java ! test/java/util/Hashtable/SimpleSerialization.java + test/java/util/Map/Collisions.java ! test/java/util/Map/Get.java + test/sun/misc/Hashing.java From zhouyx at linux.vnet.ibm.com Thu May 31 00:17:15 2012 From: zhouyx at linux.vnet.ibm.com (Sean Chou) Date: Thu, 31 May 2012 15:17:15 +0800 Subject: Request for review: 7173044: Memory monitor demo hangs if MemoryUsage obj returns -1 in getMax Message-ID: Hi all, MemoryMonitor demo will hang if MemoryUsage obj returns -1 in getMax method. The demo obtains totalMemory from getMax method, and it is used in following loop: " // .. Memory Free .. big.setColor(mfColor); int MemUsage = (int) (((totalMemory - usedMemory) / totalMemory) * 10); int i = 0; for ( ; i < MemUsage ; i++) { mfRect.setRect(x1+5,(float) y1+ssH+i*blockHeight, blockWidth, blockHeight-1); big.fill(mfRect); } " If -1 is returned, MemUsage becomes a very large positive value and the loop hangs the demo. The bug is not seen in current openjdk because the beans returned all has a Max value returned. However, -1 is allowed by spec when Max is not set for the bean, and other jdk might return. In the patch, max is set to 1m or the max memory usage in history for the bean if there is no max specified. Please take a look. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7173044 Webrev: http://cr.openjdk.java.net/~zhouyx/7173044/webrev.01/ . -- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120531/da646426/attachment.html From nils.loodin at oracle.com Thu May 31 05:49:14 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Thu, 31 May 2012 14:49:14 +0200 Subject: Fwd: JPSE-J2SE Code Review Request-6310967-jdk160-pool_b01#4592, due by 5/30/12_12:53_AM References: <4FC6E993.306@oracle.com> Message-ID: <871C40FD-EE56-4AE0-B7DB-1556BA9065DF@oracle.com> Also forwarding to serviceability dev.. /Nisse Begin forwarded message: > From: Poonam Bajaj > Subject: Re: JPSE-J2SE Code Review Request-6310967-jdk160-pool_b01#4592, due by 5/30/12_12:53_AM > Date: May 31, 2012 5:46:27 GMT+02:00 > To: nils.loodin at oracle.com, yumin.qi at oracle.com > > Hi Nils, Yumin, > > Could you please review these code changes. > > Thanks, > Poonam > > On 5/25/2012 1:24 PM, poonam.bajaj at oracle.com wrote: >> >> >> poonam.bajaj at oracle.com's following code review request has been sent to yumin.qi at oracle.com,nils.loodin at oracle.com. >> Please review the code before 5/30/12_12:53_AM. >> >> If yumin.qi at oracle.com,nils.loodin at oracle.com can not meet the review timeline, please contact >> poonam.bajaj at oracle.com to negotiate for an appropriate time-frame. >> >> http://jpsesvr.us.oracle.com:8080/ctetools/html/Approve.jsp?index=4592 >> >> webrev: http://jpsesvr.us.oracle.com:8080/ctetools/html/ViewDetail.jsp?index=4592 >> ====================================== >> Escalation ID : 13503116 >> Escalation Synopsis : JSTACK -M RETURNS SUN.JVM.HOTSPOT.DEBUGGER.UNALIGNED EXCEPTION FOR SOME THREAD >> Bug ID : 6310967 >> Bug Synopsis : SA: jstack -m produce failures in output >> >> Request Engineer : poonam.bajaj at oracle.com >> Code Reviewer : yumin.qi at oracle.com,nils.loodin at oracle.com >> Parent Workspace : /net/nightsvr/export4/integration/6u34/hotspot >> Child Workspace : /net/jdk/export/jpse06/poonam/ws/6u34_6310967/hotspot >> Platforms : Shared Code >> Version : JDK6-pool_b01 >> Fix information : New Fix >> Severity : normal - level 1 >> Submit Date : 5/25/12 12:53 AM >> >> Problem and Fix Description : >> Problem: jstack -m fails with UnalignedAddressException >> >> The problem is that while finding the caller frame of a frame in sender() method, we don't check the validity of the frame pointer (rbp / ebp). >> >> These changes add a simple check that the frame pointer(rbp) should be a valid pointer on the stack by making sure that it should not be less than the stack pointer(rsp). >> >> These changes are for jdk6. >> >> Modified source lists : >> agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java >> agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/CFrame.java >> agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java >> agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java >> agent/src/share/classes/sun/jvm/hotspot/debugger/linux/amd64/LinuxAMD64CFrame.java >> agent/src/share/classes/sun/jvm/hotspot/debugger/linux/sparc/LinuxSPARCCFrame.java >> agent/src/share/classes/sun/jvm/hotspot/debugger/linux/x86/LinuxX86CFrame.java >> agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcCFrame.java >> agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java >> >> Approve Info : >> >> >> Putback info : >> ====================================== >> This message is autogenerated by code management tool. > > -- > Best regards, Poonam > > Poonam Bajaj | Principal Member of Technical Staff > Phone: +91 80 67283726 | Mobile: +91 9844511366 > Oracle JVM Sustaining Engineering > > ORACLE India Bangalore > Oracle is committed to developing practices and products that help protect the environment > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120531/b665f518/attachment-0001.html -------------- next part -------------- A non-text attachment was scrubbed... Name: oracle_sig_logo.gif Type: image/gif Size: 658 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120531/b665f518/oracle_sig_logo-0001.gif -------------- next part -------------- A non-text attachment was scrubbed... Name: green-for-email-sig_0.gif Type: image/gif Size: 356 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120531/b665f518/green-for-email-sig_0-0001.gif From nils.loodin at oracle.com Thu May 31 05:55:29 2012 From: nils.loodin at oracle.com (Nils Loodin) Date: Thu, 31 May 2012 14:55:29 +0200 Subject: JPSE-J2SE Code Review Request-6310967-jdk160-pool_b01#4592, due by 5/30/12_12:53_AM In-Reply-To: <871C40FD-EE56-4AE0-B7DB-1556BA9065DF@oracle.com> References: <4FC6E993.306@oracle.com> <871C40FD-EE56-4AE0-B7DB-1556BA9065DF@oracle.com> Message-ID: In agent/src/share/classes/sun/jvm/hotspot/debugger/linux/amd64/LinuxAMD64CFrame.java there are some commented out system.out.printlns that perhaps should be removed. Otherwise I guess the changes looks good, but it's too bad that the current design of SA requires so much code duplication? Regards, Nils Loodin On May 31, 2012, at 14:49 , Nils Loodin wrote: > > Also forwarding to serviceability dev.. > > /Nisse > > Begin forwarded message: > >> From: Poonam Bajaj >> Subject: Re: JPSE-J2SE Code Review Request-6310967-jdk160-pool_b01#4592, due by 5/30/12_12:53_AM >> Date: May 31, 2012 5:46:27 GMT+02:00 >> To: nils.loodin at oracle.com, yumin.qi at oracle.com >> >> Hi Nils, Yumin, >> >> Could you please review these code changes. >> >> Thanks, >> Poonam >> >> On 5/25/2012 1:24 PM, poonam.bajaj at oracle.com wrote: >>> >>> >>> poonam.bajaj at oracle.com's following code review request has been sent to yumin.qi at oracle.com,nils.loodin at oracle.com. >>> Please review the code before 5/30/12_12:53_AM. >>> >>> If yumin.qi at oracle.com,nils.loodin at oracle.com can not meet the review timeline, please contact >>> poonam.bajaj at oracle.com to negotiate for an appropriate time-frame. >>> >>> http://jpsesvr.us.oracle.com:8080/ctetools/html/Approve.jsp?index=4592 >>> >>> webrev: http://jpsesvr.us.oracle.com:8080/ctetools/html/ViewDetail.jsp?index=4592 >>> ====================================== >>> Escalation ID : 13503116 >>> Escalation Synopsis : JSTACK -M RETURNS SUN.JVM.HOTSPOT.DEBUGGER.UNALIGNED EXCEPTION FOR SOME THREAD >>> Bug ID : 6310967 >>> Bug Synopsis : SA: jstack -m produce failures in output >>> >>> Request Engineer : poonam.bajaj at oracle.com >>> Code Reviewer : yumin.qi at oracle.com,nils.loodin at oracle.com >>> Parent Workspace : /net/nightsvr/export4/integration/6u34/hotspot >>> Child Workspace : /net/jdk/export/jpse06/poonam/ws/6u34_6310967/hotspot >>> Platforms : Shared Code >>> Version : JDK6-pool_b01 >>> Fix information : New Fix >>> Severity : normal - level 1 >>> Submit Date : 5/25/12 12:53 AM >>> >>> Problem and Fix Description : >>> Problem: jstack -m fails with UnalignedAddressException >>> >>> The problem is that while finding the caller frame of a frame in sender() method, we don't check the validity of the frame pointer (rbp / ebp). >>> >>> These changes add a simple check that the frame pointer(rbp) should be a valid pointer on the stack by making sure that it should not be less than the stack pointer(rsp). >>> >>> These changes are for jdk6. >>> >>> Modified source lists : >>> agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpot.java >>> agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/CFrame.java >>> agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/amd64/AMD64CFrame.java >>> agent/src/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/x86/X86CFrame.java >>> agent/src/share/classes/sun/jvm/hotspot/debugger/linux/amd64/LinuxAMD64CFrame.java >>> agent/src/share/classes/sun/jvm/hotspot/debugger/linux/sparc/LinuxSPARCCFrame.java >>> agent/src/share/classes/sun/jvm/hotspot/debugger/linux/x86/LinuxX86CFrame.java >>> agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcCFrame.java >>> agent/src/share/classes/sun/jvm/hotspot/tools/PStack.java >>> >>> Approve Info : >>> >>> >>> Putback info : >>> ====================================== >>> This message is autogenerated by code management tool. >> >> -- >> Best regards, Poonam >> >> Poonam Bajaj | Principal Member of Technical Staff >> Phone: +91 80 67283726 | Mobile: +91 9844511366 >> Oracle JVM Sustaining Engineering >> >> ORACLE India Bangalore >> Oracle is committed to developing practices and products that help protect the environment >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120531/23408e85/attachment.html From erik.gahlin at oracle.com Thu May 31 07:50:09 2012 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Thu, 31 May 2012 16:50:09 +0200 Subject: RFR: 7172176 java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing In-Reply-To: <4FC6C63A.1070906@oracle.com> References: <4FC6073F.6060005@oracle.com> <4FC6C63A.1070906@oracle.com> Message-ID: <4FC78521.8020905@oracle.com> Tim, Great to have the original author look at the test(s). Don't want to break anything. Mandy, Thanks for taking the time to do another review. This should of course been part of the original fix. Mea culpa. Michael, Good, then we will have some solid checks that the translation works as expected going forward! /Erik Mandy Chung skrev 2012-05-31 03:15: > Looks good. Sorry for not catching the test issue during the review > for 7017818. > > Mandy > > On 5/30/2012 4:40 AM, Erik Gahlin wrote: >> Hi, >> >> Could you please review 7172176, which is a test fix for 7017818 - >> JConsoleResources.java cannot be handled by translation team. >> >> Webrev: >> http://cr.openjdk.java.net/~egahlin/7172176_01/ >> >> Changes: >> >> - Removed the ImmutableRequest.java and ImmutableRequest.sh since the >> JConsoleResources class was refactored away with 7017818. >> >> - Removed hard-wired resource bundle keys in ResourceCheckTest.java, >> the keys >> are now looked up by reflection on the Messages class. The test also >> checks there is one-to-one mapping between reource bundle keys and >> the constants available in the Message class. >> >> Michael, >> >> I removed sun/tools/jconsole/ResourceCheckTest.sh from the jdk/test/ >> ProblemList.txt. This means the test will break once the translated >> files >> will be checked in. Unused messages were sent for translation and they >> need to be removed. >> >> Are you ok with that? >> >> Thanks! >> Erik From maurizio.cimadamore at oracle.com Thu May 31 09:53:34 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 31 May 2012 16:53:34 +0000 Subject: hg: jdk8/tl/langtools: 2 new changesets Message-ID: <20120531165338.65BF84764F@hg.openjdk.java.net> Changeset: af6a4c24f4e3 Author: mcimadamore Date: 2012-05-31 17:42 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/af6a4c24f4e3 7166552: Inference: cleanup usage of Type.ForAll Summary: Remove hack to callback into type-inference from assignment context Reviewed-by: dlsmith, jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/AttrContext.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/6758789/T6758789b.out ! test/tools/javac/diags/examples.not-yet.txt ! test/tools/javac/diags/examples/ApplicableMethodFound1.java ! test/tools/javac/diags/examples/CantApplyDiamond1.java - test/tools/javac/diags/examples/FullInstSig.java ! test/tools/javac/diags/examples/IncompatibleTypes1.java ! test/tools/javac/diags/examples/InferredDoNotConformToLower.java - test/tools/javac/diags/examples/InvalidInferredTypes.java + test/tools/javac/diags/examples/NoUniqueMaximalInstance.java - test/tools/javac/diags/examples/UndeterminedType1.java ! test/tools/javac/diags/examples/WhereFreshTvar.java ! test/tools/javac/generics/7015430/T7015430.out ! test/tools/javac/generics/7151802/T7151802.out ! test/tools/javac/generics/inference/6315770/T6315770.out ! test/tools/javac/generics/inference/6638712/T6638712b.out ! test/tools/javac/generics/inference/6638712/T6638712e.out ! test/tools/javac/generics/inference/6650759/T6650759m.out ! test/tools/javac/generics/inference/7154127/T7154127.out ! test/tools/javac/varargs/6313164/T6313164.out Changeset: 37dc15c68760 Author: mcimadamore Date: 2012-05-31 17:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37dc15c68760 7160084: javac fails to compile an apparently valid class/interface combination Summary: javac generates wrong syntetized trees for nested enum constants Reviewed-by: dlsmith, jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/javac/enum/7160084/T7160084a.java + test/tools/javac/enum/7160084/T7160084b.java From sean.mullan at oracle.com Thu May 31 14:10:51 2012 From: sean.mullan at oracle.com (sean.mullan at oracle.com) Date: Thu, 31 May 2012 21:10:51 +0000 Subject: hg: jdk8/tl/jdk: 3 new changesets Message-ID: <20120531211128.69A6447659@hg.openjdk.java.net> Changeset: 0c6830e7241f Author: mullan Date: 2012-05-30 17:19 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0c6830e7241f 6854712: Revocation checking enhancements (JEP-124) 6637288: Add OCSP support to PKIX CertPathBuilder implementation 7126011: ReverseBuilder.getMatchingCACerts may throws NPE Reviewed-by: xuelei ! src/share/classes/java/security/cert/CertPathBuilder.java ! src/share/classes/java/security/cert/CertPathBuilderSpi.java + src/share/classes/java/security/cert/CertPathChecker.java ! src/share/classes/java/security/cert/CertPathValidator.java ! src/share/classes/java/security/cert/CertPathValidatorSpi.java ! src/share/classes/java/security/cert/PKIXCertPathChecker.java + src/share/classes/java/security/cert/PKIXRevocationChecker.java ! src/share/classes/java/security/cert/package.html ! src/share/classes/sun/security/provider/certpath/AdjacencyList.java ! src/share/classes/sun/security/provider/certpath/BasicChecker.java ! src/share/classes/sun/security/provider/certpath/BuildStep.java ! src/share/classes/sun/security/provider/certpath/Builder.java ! src/share/classes/sun/security/provider/certpath/CertStoreHelper.java ! src/share/classes/sun/security/provider/certpath/CollectionCertStore.java ! src/share/classes/sun/security/provider/certpath/ConstraintsChecker.java - src/share/classes/sun/security/provider/certpath/CrlRevocationChecker.java ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ForwardState.java ! src/share/classes/sun/security/provider/certpath/IndexedCollectionCertStore.java ! src/share/classes/sun/security/provider/certpath/KeyChecker.java ! src/share/classes/sun/security/provider/certpath/OCSP.java - src/share/classes/sun/security/provider/certpath/OCSPChecker.java ! src/share/classes/sun/security/provider/certpath/OCSPRequest.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java + src/share/classes/sun/security/provider/certpath/PKIX.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/PKIXMasterCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/PolicyChecker.java ! src/share/classes/sun/security/provider/certpath/PolicyNodeImpl.java ! src/share/classes/sun/security/provider/certpath/ReverseBuilder.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java + src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilderParameters.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java ! src/share/classes/sun/security/provider/certpath/Vertex.java ! src/share/classes/sun/security/provider/certpath/X509CertPath.java ! src/share/classes/sun/security/provider/certpath/X509CertificatePair.java ! src/share/classes/sun/security/x509/X509CRLEntryImpl.java + test/java/security/cert/PKIXRevocationChecker/UnitTest.java Changeset: 3192e73394fe Author: mullan Date: 2012-05-31 17:07 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3192e73394fe Merge - src/share/classes/sun/security/provider/certpath/CrlRevocationChecker.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ForwardState.java - src/share/classes/sun/security/provider/certpath/OCSPChecker.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/ReverseBuilder.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java Changeset: 48dfc0df61d0 Author: mullan Date: 2012-05-31 17:10 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/48dfc0df61d0 Merge From erik.gahlin at oracle.com Thu May 31 14:20:07 2012 From: erik.gahlin at oracle.com (Erik Gahlin) Date: Thu, 31 May 2012 23:20:07 +0200 Subject: Request for review: 7173044: Memory monitor demo hangs if MemoryUsage obj returns -1 in getMax In-Reply-To: References: Message-ID: <4FC7E087.1010901@oracle.com> Hi, I'm not an offical reviewer, but why do you initialize the array to 1024K and not 1? Do you get problems with lower values? Best regards Erik Sean Chou skrev 2012-05-31 09:17: > Hi all, > > MemoryMonitor demo will hang if MemoryUsage obj returns -1 > in getMax method. > The demo obtains totalMemory from getMax method, and it is used in > following loop: > > " // .. Memory Free .. > big.setColor(mfColor); > int MemUsage = (int) (((totalMemory - usedMemory) / totalMemory) > * 10); > int i = 0; > for ( ; i < MemUsage ; i++) { > mfRect.setRect(x1+5,(float) y1+ssH+i*blockHeight, > blockWidth, blockHeight-1); > big.fill(mfRect); > } > " > If -1 is returned, MemUsage becomes a very large positive value and > the loop hangs > the demo. > > The bug is not seen in current openjdk because the beans returned > all has a Max > value returned. However, -1 is allowed by spec when Max is not set for > the bean, and > other jdk might return. > > In the patch, max is set to 1m or the max memory usage in history > for the bean > if there is no max specified. Please take a look. > > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7173044 > Webrev: http://cr.openjdk.java.net/~zhouyx/7173044/webrev.01/ > . > > > -- > Best Regards, > Sean Chou > From james.holmlund at oracle.com Thu May 31 15:08:26 2012 From: james.holmlund at oracle.com (james.holmlund at oracle.com) Date: Thu, 31 May 2012 22:08:26 +0000 Subject: hg: jdk8/tl/langtools: 7159016: Static import of member in processor-generated class fails in JDK 7 Message-ID: <20120531220829.D825B4766E@hg.openjdk.java.net> Changeset: 844478076c25 Author: jjh Date: 2012-05-31 15:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/844478076c25 7159016: Static import of member in processor-generated class fails in JDK 7 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/T7159016.java From zhouyx at linux.vnet.ibm.com Thu May 31 19:46:06 2012 From: zhouyx at linux.vnet.ibm.com (Sean Chou) Date: Fri, 1 Jun 2012 10:46:06 +0800 Subject: Request for review: 7173044: Memory monitor demo hangs if MemoryUsage obj returns -1 in getMax In-Reply-To: <4FC7E087.1010901@oracle.com> References: <4FC7E087.1010901@oracle.com> Message-ID: Hi Erik, In fact there is no technical reason. I hope 1024K might keep the start usage in the middle of the graph and 1 is too small which will make the painting start at the top of the graph. On Fri, Jun 1, 2012 at 5:20 AM, Erik Gahlin wrote: > Hi, > > I'm not an offical reviewer, but why do you initialize the array to 1024K > and not 1? > > Do you get problems with lower values? > > Best regards > Erik > > Sean Chou skrev 2012-05-31 09:17: > >> Hi all, >> >> MemoryMonitor demo will hang if MemoryUsage obj returns -1 in getMax >> method. >> The demo obtains totalMemory from getMax method, and it is used in >> following loop: >> >> " // .. Memory Free .. >> big.setColor(mfColor); >> int MemUsage = (int) (((totalMemory - usedMemory) / totalMemory) * >> 10); >> int i = 0; >> for ( ; i < MemUsage ; i++) { >> mfRect.setRect(x1+5,(float) y1+ssH+i*blockHeight, >> blockWidth, blockHeight-1); >> big.fill(mfRect); >> } >> " >> If -1 is returned, MemUsage becomes a very large positive value and the >> loop hangs >> the demo. >> >> The bug is not seen in current openjdk because the beans returned all >> has a Max >> value returned. However, -1 is allowed by spec when Max is not set for >> the bean, and >> other jdk might return. >> >> In the patch, max is set to 1m or the max memory usage in history for >> the bean >> if there is no max specified. Please take a look. >> >> Bug: http://bugs.sun.com/**bugdatabase/view_bug.do?bug_**id=7173044 >> Webrev: http://cr.openjdk.java.net/~**zhouyx/7173044/webrev.01/< >> http://cr.openjdk.java.net/%**7Ezhouyx/7173044/webrev.01/> >> . >> >> >> >> -- >> Best Regards, >> Sean Chou >> >> > -- Best Regards, Sean Chou -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120601/d4a47e01/attachment.html