RFR (S): 7167157: jcmd command file parsing does not respect the "stop" command

[Staffan Larsen]

Thanks Dmitry,

All commands are case-sensitive.

/Staffan

On 21 maj 2012, at 10:23, Dmitry Samersoff wrote:

> Staffan,
> 
> Looks OK for me.
> 
> Is stop command case-sensitive?
> 
> -Dmitry
> 
> 
> On 2012-05-21 12:05, Staffan Larsen wrote:
>> All, 
>> 
>> I need a Review of this change.
>> 
>> Thanks,
>> /Staffan
>> 
>> On 11 maj 2012, at 12:42, Staffan Larsen wrote:
>> 
>>> New webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.01/
>>> 
>>> On 11 maj 2012, at 12:17, Staffan Larsen wrote:
>>> 
>>>> Right. Should probably be line.trim().equals("stop")
>>>> 
>>>> /Staffan
>>>> 
>>>> On 11 maj 2012, at 11:41, Nils Loodin wrote:
>>>> 
>>>>> Should it be "startsWith"? I don't know if we ever plan to implement
>>>>> a command that's called stopFeatureX, but still..
>>>>> 
>>>>> Regards,
>>>>> Nils Loodin
>>>>> 
>>>>> On May 11, 2012, at 11:34 , Staffan Larsen wrote:
>>>>> 
>>>>>> Please review the following fix for the fix for 7154822. Previously
>>>>>> all lines in the command file were sent to the JVM as one string,
>>>>>> but the size limit was 1024 bytes so this was changed in 7154822 to
>>>>>> sending one line at a time. Problem with this is that the jcmd
>>>>>> utility keeps sending commands even if it has encountered a 'stop'.
>>>>>> So instead of relying on the JVM to parse the 'stop' command, we
>>>>>> must now parse this in the jcmd utility. 
>>>>>> 
>>>>>> webrev: http://cr.openjdk.java.net/~sla/7167157/webrev.00/
>>>>>> 
>>>>>> Thanks,
>>>>>> /Staffan
>>>>> 
>>>> 
>>> 
>> 
> 
> 
> -- 
> Dmitry Samersoff
> Java Hotspot development team, SPB04
> * There will come soft rains ...