From alan.bateman at oracle.com Mon Oct 1 07:43:23 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Mon, 01 Oct 2012 14:43:23 +0000 Subject: hg: jdk8/tl/jdk: 8000269: Cleanup javadoc warnings Message-ID: <20121001144346.24F384714B@hg.openjdk.java.net> Changeset: 39cbe256c3d1 Author: alanb Date: 2012-10-01 15:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39cbe256c3d1 8000269: Cleanup javadoc warnings Reviewed-by: lancea, darcy, ulfzibis, iris, naoto, dholmes ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/io/PrintWriter.java ! src/share/classes/java/io/Reader.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/InheritableThreadLocal.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/StrictMath.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/ThreadGroup.java ! src/share/classes/java/lang/ThreadLocal.java ! src/share/classes/java/lang/management/ThreadInfo.java ! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/Inet4Address.java ! src/share/classes/java/net/SocketInputStream.java ! src/share/classes/java/net/SocketPermission.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/nio/channels/Channels.java ! src/share/classes/java/nio/file/FileSystem.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/nio/file/attribute/AclFileAttributeView.java ! src/share/classes/java/nio/file/attribute/FileTime.java ! src/share/classes/java/security/AllPermission.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/security/CodeSource.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/cert/PKIXRevocationChecker.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/text/CollationElementIterator.java ! src/share/classes/java/text/DigitList.java ! src/share/classes/java/text/Format.java ! src/share/classes/java/text/RBCollationTables.java ! src/share/classes/java/text/RBTableBuilder.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/Currency.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/java/util/JumboEnumSet.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/PropertyPermission.java ! src/share/classes/java/util/RegularEnumSet.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/logging/Logging.java ! src/share/classes/java/util/prefs/XmlSupport.java ! src/share/classes/javax/crypto/CryptoAllPermission.java ! src/share/classes/javax/crypto/CryptoPermission.java ! src/share/classes/javax/crypto/CryptoPolicyParser.java ! src/share/classes/javax/crypto/NullCipherSpi.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java ! src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java ! src/share/classes/javax/naming/spi/NamingManager.java ! src/share/classes/javax/security/auth/kerberos/DelegationPermission.java ! src/share/classes/javax/security/auth/kerberos/ServicePermission.java ! src/share/classes/javax/sql/ConnectionPoolDataSource.java ! src/share/classes/javax/sql/PooledConnection.java ! src/share/classes/javax/sql/rowset/spi/SyncProvider.java From kevin.walls at oracle.com Mon Oct 1 11:19:01 2012 From: kevin.walls at oracle.com (kevin.walls at oracle.com) Date: Mon, 01 Oct 2012 18:19:01 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7200145: runtime/7196045/Test7196045.java fails with No class provided for `main' Message-ID: <20121001181905.D7F0E4714E@hg.openjdk.java.net> Changeset: fab6fbf427d2 Author: kevinw Date: 2012-09-30 23:24 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fab6fbf427d2 7200145: runtime/7196045/Test7196045.java fails with No class provided for `main' Reviewed-by: dholmes, dsamersoff ! test/runtime/7196045/Test7196045.java From jaroslav.bachorik at oracle.com Tue Oct 2 01:33:13 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 02 Oct 2012 10:33:13 +0200 Subject: Review Request: 7195779 javax/management/remote/mandatory/threads/ExecutorTest.java fail intermittently In-Reply-To: <505C46EB.60800@oracle.com> References: <5059BD10.40801@oracle.com> <5059C33D.7@oracle.com> <5059C5B3.6020808@oracle.com> <5059CB04.30107@oracle.com> <505C46EB.60800@oracle.com> Message-ID: <506AA6C9.30909@oracle.com> On Fri 21 Sep 2012 12:52:27 PM CEST, Alan Bateman wrote: > On 20/09/2012 17:02, Eamonn McManus wrote: >> Changing the generated RMI/IIOP code >> so that it no longer causes this exception, or so that it catches it >> and rethrows a RemoteException, sounds as if it ought to be fairly >> straightforward, and that's probably what I would do if it were up to >> me. > I think this is what I would do to, even though it means going into > the corba repository as that is there the stub generator is. I should > say that I don't violently object to Jaroslav's patch, it's just that > it is an ugly workaround. The generated TIE class is inherently thread-unsafe. The internal state (the target field) can be manipulated without any enforced synchronization - eg. it is valid to set the target field to null by calling the deactivate() method after the _invoke() method has been entered from a different thread. This will lead to the NPE we can observe. Given this example one should make critical sections out of deactivate() and _invoke() methods to prevent this situation. However, this simplistic approach might lead to deadlocks in the existing code as the _invoke() method body might be blocking (it is a 3rd party code) and thus preventing execution of the deactivate() method indefinitely. Also, it is not really possible to solve this problem outside of the generated TIE class - it is caused by the concurrent change of the TIE's internal state. So, the solution would be either caching the target attribute at the beginning of the invoke() operation in a synchronized block and use the cached version afterwards (and throwing a remote exception if it is null - the TIE was deactivated effectively before entering the invoke() operation) or postponing deactivation when the invoke() method is detected as being in progress. -JB- > > >> Disabling this test for the IIOP case, and probably other failing >> JMX tests that involve IIOP, is an option if it is judged that nobody >> uses the RMI/IIOP connector any more so it is all right to let it rot. >> That judgement is a non-technical one that I don't have an informed >> opinion on. >> > I don't know if the rmi-iiop connector was ever used much but since it > seems to be required by the JMX Remote API spec then I think we should > continue to test it. As I think I mentioned in another mail recently, > I think we have to look at making this transport optional as it's > painful to have the CORBA tie/stub classes in > javax.management.remote.rmi. I don't what to hijack Jaroslav's thread > to discuss that, that's a topic for another thread. > > -Alan > From alan.bateman at oracle.com Tue Oct 2 02:14:41 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 02 Oct 2012 09:14:41 +0000 Subject: hg: jdk8/tl/jdk: 7050528: Improve performance of java.text.DecimalFormat.format() call stack Message-ID: <20121002091518.BA1934715D@hg.openjdk.java.net> Changeset: 75080f572f84 Author: olagneau Date: 2012-10-02 10:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/75080f572f84 7050528: Improve performance of java.text.DecimalFormat.format() call stack Reviewed-by: darcy ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/NumberFormat.java + test/java/text/Format/DecimalFormat/FormatMicroBenchmark.java + test/java/text/Format/DecimalFormat/GoldenDoubleValues.java + test/java/text/Format/DecimalFormat/GoldenFormattedValues.java + test/java/text/Format/DecimalFormat/RoundingAndPropertyTest.java From alan.bateman at oracle.com Tue Oct 2 02:37:28 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 02 Oct 2012 09:37:28 +0000 Subject: hg: jdk8/tl/jdk: 7197642: (sl) ServiceLoader.load(null) doesn't throw NPE Message-ID: <20121002093922.444EE4715E@hg.openjdk.java.net> Changeset: 041c687c4f40 Author: psandoz Date: 2012-10-02 10:36 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/041c687c4f40 7197642: (sl) ServiceLoader.load(null) doesn't throw NPE Reviewed-by: alanb ! src/share/classes/java/util/ServiceLoader.java + test/java/util/ServiceLoader/NPE.java From alan.bateman at oracle.com Tue Oct 2 04:24:22 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 02 Oct 2012 11:24:22 +0000 Subject: hg: jdk8/tl/jdk: 8000268: sun/security/provider/X509Factory/BigCRL.java failing on Linux 32-bit Message-ID: <20121002112435.42F3A47162@hg.openjdk.java.net> Changeset: 6750ab947255 Author: alanb Date: 2012-10-02 12:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6750ab947255 8000268: sun/security/provider/X509Factory/BigCRL.java failing on Linux 32-bit Reviewed-by: mullan ! test/sun/security/provider/X509Factory/BigCRL.java From Alan.Bateman at oracle.com Tue Oct 2 06:38:13 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Tue, 02 Oct 2012 14:38:13 +0100 Subject: jmx-dev Review Request: 7195779 javax/management/remote/mandatory/threads/ExecutorTest.java fail intermittently In-Reply-To: <506AA6C9.30909@oracle.com> References: <5059BD10.40801@oracle.com> <5059C33D.7@oracle.com> <5059C5B3.6020808@oracle.com> <5059CB04.30107@oracle.com> <505C46EB.60800@oracle.com> <506AA6C9.30909@oracle.com> Message-ID: <506AEE45.7020403@oracle.com> On 02/10/2012 09:33, Jaroslav Bachorik wrote: > : > The generated TIE class is inherently thread-unsafe. The internal state > (the target field) can be manipulated without any enforced > synchronization - eg. it is valid to set the target field to null by > calling the deactivate() method after the _invoke() method has been > entered from a different thread. This will lead to the NPE we can > observe. Given this example one should make critical sections out of > deactivate() and _invoke() methods to prevent this situation. However, > this simplistic approach might lead to deadlocks in the existing code > as the _invoke() method body might be blocking (it is a 3rd party code) > and thus preventing execution of the deactivate() method indefinitely. > > Also, it is not really possible to solve this problem outside of the > generated TIE class - it is caused by the concurrent change of the > TIE's internal state. So, the solution would be either caching the > target attribute at the beginning of the invoke() operation in a > synchronized block and use the cached version afterwards (and throwing > a remote exception if it is null - the TIE was deactivated effectively > before entering the invoke() operation) or postponing deactivation when > the invoke() method is detected as being in progress. > > -JB- > Jaroslav and I chatted on IM about this today. Jaroslav is going to have a go at changing the stub generator and will send a follow-up mail with an updated webrev (this time for the corba repo as the that is where the stub generator lives). -Alan From yumin.qi at oracle.com Tue Oct 2 10:33:44 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Tue, 02 Oct 2012 10:33:44 -0700 Subject: RFR: JI-29: SA ClassDump throws exception after permgen removal Message-ID: <506B2578.4040602@oracle.com> Hi, May I have your codereview http://cr.openjdk.java.net/~minqi/ji-29 JI-29: SA ClassDump throws exception after permgen removal Summary: In ClassWrite.writeFields(), fields count was set to fields length which overflows the array index. Also removed a file which should be removed in changeset of 6879063: SA should use hsdis. Reviewed-by: Contributed-by: yumin.qi at oracle.com Thanks Yumin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121002/f35a15e6/attachment.html From yumin.qi at oracle.com Tue Oct 2 13:50:02 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Tue, 02 Oct 2012 13:50:02 -0700 Subject: RFR: JI-29: SA ClassDump throws exception after permgen removal In-Reply-To: <506B2578.4040602@oracle.com> References: <506B2578.4040602@oracle.com> Message-ID: <506B537A.9060906@oracle.com> Hi, all This is real URL for this bug codereview, I accidentally created the bug with JIRA by click incidents link. Now the link is http://cr.openjdk.java.net/~minqi/JDK-8000332/ Thanks Yumin On 10/2/2012 10:33 AM, Yumin Qi wrote: > Hi, May I have your codereview > > http://cr.openjdk.java.net/~minqi/ji-29 > > > JI-29: SA ClassDump throws exception after permgen removal > Summary: In ClassWrite.writeFields(), fields count was set to fields > length which overflows the array index. > > Also removed a file which should be removed in changeset of 6879063: > SA should use hsdis. > > Reviewed-by: > Contributed-by: yumin.qi at oracle.com > > > Thanks > Yumin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121002/ad2622e3/attachment.html From yumin.qi at oracle.com Tue Oct 2 22:12:28 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Tue, 02 Oct 2012 22:12:28 -0700 Subject: RFR: JI-29: SA ClassDump throws exception after permgen removal In-Reply-To: <506B537A.9060906@oracle.com> References: <506B2578.4040602@oracle.com> <506B537A.9060906@oracle.com> Message-ID: <506BC93C.4000802@oracle.com> Hi, All Based on Coleen's feedback, sadis.c has compilation warning, fixed, also removed some unused code in SA. http://cr.openjdk.java.net/~minqi/8000332/ Thanks Yumin On 10/2/2012 1:50 PM, Yumin Qi wrote: > Hi, all > > This is real URL for this bug codereview, I accidentally created the > bug with JIRA by click incidents link. Now the link is > http://cr.openjdk.java.net/~minqi/JDK-8000332/ > > > Thanks > Yumin > > On 10/2/2012 10:33 AM, Yumin Qi wrote: >> Hi, May I have your codereview >> >> http://cr.openjdk.java.net/~minqi/ji-29 >> >> >> JI-29: SA ClassDump throws exception after permgen removal >> Summary: In ClassWrite.writeFields(), fields count was set to fields >> length which overflows the array index. >> >> Also removed a file which should be removed in changeset of 6879063: >> SA should use hsdis. >> >> Reviewed-by: >> Contributed-by: yumin.qi at oracle.com >> >> >> Thanks >> Yumin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121002/f00b258a/attachment.html From yuka.kamiya at oracle.com Tue Oct 2 23:13:12 2012 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Wed, 03 Oct 2012 06:13:12 +0000 Subject: hg: jdk8/tl/jdk: 7104012: AIOOBE from RuleBasedBreakIterator.lookupState for some suppl. chars Message-ID: <20121003061355.63DA747171@hg.openjdk.java.net> Changeset: 4744dc70e5d1 Author: peytoia Date: 2012-10-03 15:11 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4744dc70e5d1 7104012: AIOOBE from RuleBasedBreakIterator.lookupState for some suppl. chars Reviewed-by: okutsu ! src/share/classes/sun/text/SupplementaryCharacterData.java + test/java/text/BreakIterator/Bug7104012.java From david.holmes at oracle.com Wed Oct 3 00:52:58 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 03 Oct 2012 17:52:58 +1000 Subject: RFR: JI-29: SA ClassDump throws exception after permgen removal In-Reply-To: <506BC93C.4000802@oracle.com> References: <506B2578.4040602@oracle.com> <506B537A.9060906@oracle.com> <506BC93C.4000802@oracle.com> Message-ID: <506BEEDA.9020808@oracle.com> Hi Yumin, Seems to be a lot of incidental cleanup here. What is the general state of ia64 files/references? David On 3/10/2012 3:12 PM, Yumin Qi wrote: > Hi, All > > Based on Coleen's feedback, sadis.c has compilation warning, fixed, > also removed some unused code in SA. > > http://cr.openjdk.java.net/~minqi/8000332/ > > > Thanks > Yumin > > On 10/2/2012 1:50 PM, Yumin Qi wrote: >> Hi, all >> >> This is real URL for this bug codereview, I accidentally created the >> bug with JIRA by click incidents link. Now the link is >> http://cr.openjdk.java.net/~minqi/JDK-8000332/ >> >> >> Thanks >> Yumin >> >> On 10/2/2012 10:33 AM, Yumin Qi wrote: >>> Hi, May I have your codereview >>> >>> http://cr.openjdk.java.net/~minqi/ji-29 >>> >>> >>> JI-29: SA ClassDump throws exception after permgen removal >>> Summary: In ClassWrite.writeFields(), fields count was set to fields >>> length which overflows the array index. >>> >>> Also removed a file which should be removed in changeset of 6879063: >>> SA should use hsdis. >>> >>> Reviewed-by: >>> Contributed-by: yumin.qi at oracle.com >>> >>> >>> Thanks >>> Yumin From alan.bateman at oracle.com Wed Oct 3 01:03:55 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 03 Oct 2012 08:03:55 +0000 Subject: hg: jdk8/tl/jdk: 6910472: Typo in : java.io.ObjectOutputStream.reset() "refered" Message-ID: <20121003080418.3979A47174@hg.openjdk.java.net> Changeset: 7fe88d457d85 Author: dxu Date: 2012-10-03 09:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7fe88d457d85 6910472: Typo in : java.io.ObjectOutputStream.reset() "refered" Reviewed-by: dholmes, alanb ! src/share/classes/java/io/ObjectOutputStream.java From lberk at redhat.com Wed Oct 3 09:13:14 2012 From: lberk at redhat.com (Lukas Berk) Date: Wed, 3 Oct 2012 12:13:14 -0400 Subject: JEP 167: Event-Based JVM Tracing Message-ID: <20121003161313.GB2828@redhat.com> Hey, I've written a patch that adds dtrace style probe points to various garbage collection events, namely: Concurrent Mark Sweep Collections G1 Mark Sweep Collections ParNew Generation Collections Parallel Scavenges Parallel Compactions and Moves Tenured Generation Collections DefNew Generation Collections I've also attached the systemtap script that I've been using on linux for additional context. Any objection to applying this patch? Cheers, Lukas -------------- next part -------------- diff -r ede14825dbfa src/share/vm/compiler/oopMap.cpp --- a/src/share/vm/compiler/oopMap.cpp Mon Sep 24 21:55:54 2012 +0100 +++ b/src/share/vm/compiler/oopMap.cpp Wed Oct 03 11:42:31 2012 -0400 @@ -33,9 +33,13 @@ #include "memory/resourceArea.hpp" #include "runtime/frame.inline.hpp" #include "runtime/signature.hpp" +#include "utilities/dtrace.hpp" #ifdef COMPILER1 #include "c1/c1_Defs.hpp" #endif +#ifndef USDT2 + HS_DTRACE_PROBE_DECL1(provider, gc__collection__delete, *uintptr_t); +#endif /* !USDT2 */ // OopMapStream @@ -677,6 +681,9 @@ " - Derived: " INTPTR_FORMAT " Base: " INTPTR_FORMAT " (Offset: %d)", derived_loc, (address)*derived_loc, (address)base, offset); } +#ifndef USDT2 + HS_DTRACE_PROBE1(hotspot, gc__collection__delete, entry); +#endif /* !USDT2 */ // Delete entry delete entry; diff -r ede14825dbfa src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp --- a/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Mon Sep 24 21:55:54 2012 +0100 +++ b/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Wed Oct 03 11:42:31 2012 -0400 @@ -55,6 +55,12 @@ #include "runtime/vmThread.hpp" #include "services/memoryService.hpp" #include "services/runtimeService.hpp" +#include "utilities/dtrace.hpp" + +#ifndef USDT2 + HS_DTRACE_PROBE_DECL4(provider, gc__collection__contig__begin, bool, bool, size_t, bool); + HS_DTRACE_PROBE_DECL4(provider, gc__collection__contig__end, bool, bool, size_t, bool); +#endif /* !USDT2 */ // statics CMSCollector* ConcurrentMarkSweepGeneration::_collector = NULL; @@ -1647,7 +1653,13 @@ size_t size, bool tlab) { +#ifndef USDT2 + HS_DTRACE_PROBE4(hotspot, gc__collection__contig__begin, full, clear_all_soft_refs, size, tlab); +#endif /* !USDT2 */ collector()->collect(full, clear_all_soft_refs, size, tlab); +#ifndef USDT2 + HS_DTRACE_PROBE4(hotspot, gc__collection__contig__end, full, clear_all_soft_refs, size, tlab); +#endif /* !USDT2 */ } void CMSCollector::collect(bool full, diff -r ede14825dbfa src/share/vm/gc_implementation/g1/g1MarkSweep.cpp --- a/src/share/vm/gc_implementation/g1/g1MarkSweep.cpp Mon Sep 24 21:55:54 2012 +0100 +++ b/src/share/vm/gc_implementation/g1/g1MarkSweep.cpp Wed Oct 03 11:42:31 2012 -0400 @@ -45,8 +45,14 @@ #include "runtime/thread.hpp" #include "runtime/vmThread.hpp" #include "utilities/copy.hpp" +#include "utilities/dtrace.hpp" #include "utilities/events.hpp" +#ifndef USDT2 + HS_DTRACE_PROBE_DECL2(provider, gc__collection__G1__begin, *uintptr_t, *uintptr_t); + HS_DTRACE_PROBE_DECL2(provider, gc__collection__G1__end, *uintptr_t, *uintptr_t); + #endif /* !USDT2 */ + class HeapRegion; void G1MarkSweep::invoke_at_safepoint(ReferenceProcessor* rp, @@ -84,6 +90,10 @@ // The marking doesn't preserve the marks of biased objects. BiasedLocking::preserve_marks(); +#ifndef USDT2 + HS_DTRACE_PROBE2(hotspot, gc__collection__G1__begin, &sh, sh->gc_cause()); +#endif /* !USDT2 */ + mark_sweep_phase1(marked_for_unloading, clear_all_softrefs); mark_sweep_phase2(); @@ -103,6 +113,10 @@ GenRemSet* rs = sh->rem_set(); rs->invalidate(sh->perm_gen()->used_region(), true /*whole_heap*/); +#ifndef USDT2 + HS_DTRACE_PROBE2(hotspot, gc__collection__G1__end, &sh, sh->gc_cause()); +#endif /* !USDT2 */ + // "free at last gc" is calculated from these. // CHF: cheating for now!!! // Universe::set_heap_capacity_at_last_gc(Universe::heap()->capacity()); diff -r ede14825dbfa src/share/vm/gc_implementation/parNew/parNewGeneration.cpp --- a/src/share/vm/gc_implementation/parNew/parNewGeneration.cpp Mon Sep 24 21:55:54 2012 +0100 +++ b/src/share/vm/gc_implementation/parNew/parNewGeneration.cpp Wed Oct 03 11:42:31 2012 -0400 @@ -47,9 +47,15 @@ #include "runtime/java.hpp" #include "runtime/thread.hpp" #include "utilities/copy.hpp" +#include "utilities/dtrace.hpp" #include "utilities/globalDefinitions.hpp" #include "utilities/workgroup.hpp" +#ifndef USDT2 + HS_DTRACE_PROBE_DECL4(provider, gc__collection__parnew__begin, bool, bool, size_t, bool); + HS_DTRACE_PROBE_DECL4(provider, gc__collection__parnew__end, bool, bool, size_t, bool); +#endif /* !USDT2 */ + #ifdef _MSC_VER #pragma warning( push ) #pragma warning( disable:4355 ) // 'this' : used in base member initializer list @@ -878,6 +884,9 @@ bool clear_all_soft_refs, size_t size, bool is_tlab) { +#ifndef USDT2 + HS_DTRACE_PROBE4(hotspot, gc__collection__parnew__begin, full, clear_all_soft_refs, size, is_tlab); +#endif /* !USDT2 */ assert(full || size > 0, "otherwise we don't want to collect"); GenCollectedHeap* gch = GenCollectedHeap::heap(); assert(gch->kind() == CollectedHeap::GenCollectedHeap, @@ -1032,6 +1041,10 @@ gch->print_heap_change(gch_prev_used); } +#ifndef USDT2 + HS_DTRACE_PROBE4(hotspot, gc__collection__parnew__end, full, clear_all_soft_refs, size, is_tlab); +#endif /* !USDT2 */ + if (PrintGCDetails && ParallelGCVerbose) { TASKQUEUE_STATS_ONLY(thread_state_set.print_termination_stats()); TASKQUEUE_STATS_ONLY(thread_state_set.print_taskqueue_stats()); diff -r ede14825dbfa src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp --- a/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp Mon Sep 24 21:55:54 2012 +0100 +++ b/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp Wed Oct 03 11:42:31 2012 -0400 @@ -40,8 +40,14 @@ #include "runtime/handles.inline.hpp" #include "runtime/java.hpp" #include "runtime/vmThread.hpp" +#include "utilities/dtrace.hpp" #include "utilities/vmError.hpp" +#ifndef USDT2 + HS_DTRACE_PROBE_DECL2(provider, gc__collection__parscavenge__heap__begin, *uintptr_t, *uintptr_t); + HS_DTRACE_PROBE_DECL2(provider, gc__collection__parscavenge__heap__end, *uintptr_t, *uintptr_t); +#endif /* !USDT2 */ + PSYoungGen* ParallelScavengeHeap::_young_gen = NULL; PSOldGen* ParallelScavengeHeap::_old_gen = NULL; PSPermGen* ParallelScavengeHeap::_perm_gen = NULL; @@ -806,7 +812,13 @@ } VM_ParallelGCSystemGC op(gc_count, full_gc_count, cause); +#ifndef USDT2 + HS_DTRACE_PROBE2(hotspot, gc__collection__parscavenge__heap__begin, &op, cause); +#endif /* !USDT2 */ VMThread::execute(&op); +#ifndef USDT2 + HS_DTRACE_PROBE2(hotspot, gc__collection__parscavenge__heap__end, &op, cause); +#endif /* !USDT2 */ } // This interface assumes that it's being called by the diff -r ede14825dbfa src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp --- a/src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp Mon Sep 24 21:55:54 2012 +0100 +++ b/src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp Wed Oct 03 11:42:31 2012 -0400 @@ -53,11 +53,18 @@ #include "runtime/vmThread.hpp" #include "services/management.hpp" #include "services/memoryService.hpp" +#include "utilities/dtrace.hpp" #include "utilities/events.hpp" #include "utilities/stack.inline.hpp" #include +#ifndef USDT2 + HS_DTRACE_PROBE_DECL2(provider, gc__collection__ParallelCompact__clear, *uintptr_t, *uintptr_t); + HS_DTRACE_PROBE_DECL2(provider, gc__collection__parallel__collect, *uintptr_t, *uintptr_t); + HS_DTRACE_PROBE_DECL4(provider, gc__collection__move, *uintptr_t, *uintptr_t, *uintptr_t, *uintptr_t); +#endif /* !USDT2 */ + // All sizes are in HeapWords. const size_t ParallelCompactData::Log2RegionSize = 9; // 512 words const size_t ParallelCompactData::RegionSize = (size_t)1 << Log2RegionSize; @@ -432,6 +439,9 @@ void ParallelCompactData::clear() { +#ifndef USDT2 + HS_DTRACE_PROBE2(hotspot, gc__collection__ParallelCompact__clear, &_region_data, _region_data->data_location()); +#endif /* !USDT2 */ memset(_region_data, 0, _region_vspace->committed_size()); } @@ -1971,6 +1981,9 @@ ParallelScavengeHeap* heap = gc_heap(); GCCause::Cause gc_cause = heap->gc_cause(); assert(!heap->is_gc_active(), "not reentrant"); +#ifndef USDT2 + HS_DTRACE_PROBE2(hotspot, gc__collection__parallel__collect, heap, heap->gc_cause()); +#endif /* !USDT2 */ PSAdaptiveSizePolicy* policy = heap->size_policy(); IsGCActiveMark mark; @@ -3377,6 +3390,9 @@ HeapWord* const new_top = _space_info[space_id].new_top(); assert(new_top >= dest_addr, "bad new_top value"); const size_t words = pointer_delta(new_top, dest_addr); +#ifndef USDT2 + HS_DTRACE_PROBE4(hotspot, gc__collection__move, &beg_addr, &end_addr, &dest_addr, &new_top); +#endif /* !USDT2 */ if (words > 0) { ObjectStartArray* start_array = _space_info[space_id].start_array(); diff -r ede14825dbfa src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp --- a/src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp Mon Sep 24 21:55:54 2012 +0100 +++ b/src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp Wed Oct 03 11:42:31 2012 -0400 @@ -51,8 +51,17 @@ #include "runtime/vmThread.hpp" #include "runtime/vm_operations.hpp" #include "services/memoryService.hpp" +#include "utilities/dtrace.cpp" #include "utilities/stack.inline.hpp" +#ifndef USDT2 + HS_DTRACE_PROBE_DECL2(provider, gc__collection__PSScavenge__begin, *uintptr_t, *uintptr_t); + HS_DTRACE_PROBE_DECL2(provider, gc__collection__PSScavenge__end, *uintptr_t, *uintptr_t); + HS_DTRACE_PROBE_DECL2(provider, gc__collection__PSParallelCompact__begin, *uintptr_t, *uintptr_t); + HS_DTRACE_PROBE_DECL2(provider, gc__collection__PSParallelCompact__end, *uintptr_t, *uintptr_t); + HS_DTRACE_PROBE_DECL2(provider, gc__collection__PSMarkSweep__begin, *uintptr_t, *uintptr_t); + HS_DTRACE_PROBE_DECL2(provider, gc__collection__PSMarkSweep__end, *uintptr_t, *uintptr_t); +#endif /* !USDT2 */ HeapWord* PSScavenge::_to_space_top_before_gc = NULL; int PSScavenge::_consecutive_skipped_scavenges = 0; @@ -226,7 +235,13 @@ PSAdaptiveSizePolicy* policy = heap->size_policy(); IsGCActiveMark mark; +#ifndef USDT2 + HS_DTRACE_PROBE2(hotspot, gc__collection__PSScavenge__begin, *heap, heap->gc_cause()); +#endif /* !USDT2 */ const bool scavenge_done = PSScavenge::invoke_no_policy(); +#ifndef USDT2 + HS_DTRACE_PROBE2(hotspot, gc__collection__PSScavenge__end, *heap, heap->gc_cause()); +#endif /* !USDT2 */ const bool need_full_gc = !scavenge_done || policy->should_full_GC(heap->old_gen()->free_in_bytes()); bool full_gc_done = false; @@ -243,9 +258,21 @@ const bool clear_all_softrefs = cp->should_clear_all_soft_refs(); if (UseParallelOldGC) { +#ifndef USDT2 + HS_DTRACE_PROBE2(hotspot, gc__collection__PSParallelCompact__begin, *heap, heap->gc_cause()); +#endif /* !USDT2 */ full_gc_done = PSParallelCompact::invoke_no_policy(clear_all_softrefs); +#ifndef USDT2 + HS_DTRACE_PROBE2(hotspot, gc__collection__PSParallelCompact__end, *heap, heap->gc_cause()); +#endif /* !USDT2 */ } else { +#ifndef USDT2 + HS_DTRACE_PROBE2(hotspot, gc__collection__PSMarkSweep__begin, *heap, heap->gc_cause()); +#endif /* !USDT2 */ full_gc_done = PSMarkSweep::invoke_no_policy(clear_all_softrefs); +#ifndef USDT2 + HS_DTRACE_PROBE2(hotspot, gc__collection__PSMarkSweep__end, *heap, heap->gc_cause()); +#endif /* !USDT2 */ } } diff -r ede14825dbfa src/share/vm/memory/defNewGeneration.cpp --- a/src/share/vm/memory/defNewGeneration.cpp Mon Sep 24 21:55:54 2012 +0100 +++ b/src/share/vm/memory/defNewGeneration.cpp Wed Oct 03 11:42:31 2012 -0400 @@ -38,6 +38,7 @@ #include "oops/oop.inline.hpp" #include "runtime/java.hpp" #include "utilities/copy.hpp" +#include "utilities/dtrace.hpp" #include "utilities/stack.inline.hpp" #ifdef TARGET_OS_FAMILY_linux # include "thread_linux.inline.hpp" @@ -52,6 +53,11 @@ # include "thread_bsd.inline.hpp" #endif +#ifndef USDT2 + HS_DTRACE_PROBE_DECL4(provider, gc__collection__defnew__begin, bool, bool, size_t, bool); + HS_DTRACE_PROBE_DECL4(provider, gc__collection__defnew__end, bool, bool, size_t, bool); +#endif /* !USDT2 */ + // // DefNewGeneration functions. @@ -528,6 +534,9 @@ bool clear_all_soft_refs, size_t size, bool is_tlab) { +#ifndef USDT2 + HS_DTRACE_PROBE4(hotspot, gc__collection__defnew__begin, full, clear_all_soft_refs, size, is_tlab); +#endif /* !USDT2 */ assert(full || size > 0, "otherwise we don't want to collect"); GenCollectedHeap* gch = GenCollectedHeap::heap(); _next_gen = gch->next_gen(this); @@ -661,6 +670,9 @@ // does not guarantee monotonicity. jlong now = os::javaTimeNanos() / NANOSECS_PER_MILLISEC; update_time_of_last_gc(now); +#ifndef USDT2 + HS_DTRACE_PROBE4(hotspot, gc__collection__defnew__end, full, clear_all_soft_refs, size, is_tlab); +#endif /* !USDT2 */ } class RemoveForwardPointerClosure: public ObjectClosure { diff -r ede14825dbfa src/share/vm/memory/generation.cpp --- a/src/share/vm/memory/generation.cpp Mon Sep 24 21:55:54 2012 +0100 +++ b/src/share/vm/memory/generation.cpp Wed Oct 03 11:42:31 2012 -0400 @@ -39,8 +39,14 @@ #include "oops/oop.inline.hpp" #include "runtime/java.hpp" #include "utilities/copy.hpp" +#include "utilities/dtrace.hpp" #include "utilities/events.hpp" +#ifndef USDT2 + HS_DTRACE_PROBE_DECL4(provider, gc__collection__contig__begin, bool, bool, size_t, bool); + HS_DTRACE_PROBE_DECL4(provider, gc__collection__contig__end, bool, bool, size_t, bool); +#endif /* !USDT2 */ + Generation::Generation(ReservedSpace rs, size_t initial_size, int level) : _level(level), _ref_processor(NULL) { @@ -470,7 +476,13 @@ // refs discovery is over the entire heap, not just this generation ReferenceProcessorSpanMutator x(ref_processor(), GenCollectedHeap::heap()->reserved_region()); +#ifndef USDT2 + HS_DTRACE_PROBE4(hotspot, gc__collection__contig__begin, full, clear_all_soft_refs, size, is_tlab); +#endif /* !USDT2 */ GenMarkSweep::invoke_at_safepoint(_level, ref_processor(), clear_all_soft_refs); +#ifndef USDT2 + HS_DTRACE_PROBE4(hotspot, gc__collection__contig__end, full, clear_all_soft_refs, size, is_tlab); +#endif /* !USDT2 */ SpecializationStats::print(); } diff -r ede14825dbfa src/share/vm/memory/tenuredGeneration.cpp --- a/src/share/vm/memory/tenuredGeneration.cpp Mon Sep 24 21:55:54 2012 +0100 +++ b/src/share/vm/memory/tenuredGeneration.cpp Wed Oct 03 11:42:31 2012 -0400 @@ -33,6 +33,12 @@ #include "memory/tenuredGeneration.hpp" #include "oops/oop.inline.hpp" #include "runtime/java.hpp" +#include "utilities/dtrace.hpp" + +#ifndef USDT2 + HS_DTRACE_PROBE_DECL4(provider, gc__collection__tenured__begin, bool, bool, size_t, bool); + HS_DTRACE_PROBE_DECL4(provider, gc__collection__tenured__end, bool, bool, size_t, bool); +#endif /* !USDT2 */ TenuredGeneration::TenuredGeneration(ReservedSpace rs, size_t initial_byte_size, int level, @@ -307,8 +313,14 @@ size_t size, bool is_tlab) { retire_alloc_buffers_before_full_gc(); +#ifndef USDT2 + HS_DTRACE_PROBE4(hotspot, gc__collection__tenured__begin, full, clear_all_soft_refs, size, is_tlab); +#endif /* !USDT2 */ OneContigSpaceCardGeneration::collect(full, clear_all_soft_refs, size, is_tlab); +#ifndef USDT2 + HS_DTRACE_PROBE4(hotspot, gc__collection__tenured__end, full, clear_all_soft_refs, size, is_tlab); +#endif /* !USDT2 */ } void TenuredGeneration::update_gc_stats(int current_level, -------------- next part -------------- /* * probe - gc_collect_contig_begin * * @name: gc_collect_contig_begin * @is_full: If TRUE, attempt a full collection of the generation. * Else; perform a scavenge * @size: The collection should achieve a minimum region of available * memory to allow for an allocation of 'size'. * @is_tlab: Is this a Thread Local Allocation Buffer? * * Description: This marks the start of a contiguous space generation collection. * */ probe hotspot.gc_collect_contig_begin = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__contig__begin"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__contig__begin") { name = "gc_collect_contig_begin"; is_full = $arg2; size = $arg3; is_tlab = $arg4; probestr = sprintf("%s(is_full='%d', size='%d', is_tlab='%d')", name, is_full, size, is_tlab); } /* * probe - gc_collect_contig_end * * @name: gc_collect_contig_end_ * @is_full: If TRUE, attempt a full collection of the generation. * Else; perform a scavenge. * @size: The collection should achieve a minimum region of available * memory to allow for an allocation of 'size'. * @is_tlab: Is this a Thread Local Allocation Buffer? * * Description: This marks the end of a contiguous space generation collection. * */ probe hotspot.gc_collect_contig_end = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__contig__end"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__contig__end") { name = "gc_collect_contig_end"; is_full = $arg2; size = $arg3; is_tlab = $arg4; probestr = sprintf("%s(is_full='%d', size='%d', is_tlab='%d')", name, is_full, size, is_tlab); } /* * probe - gc_collect_parnew_begin * * @name: gc_collect_parnew_begin * @is_full: If TRUE, attempt a full collection of the generation. * Else; perform a scavenge * @size: The collection should achieve a minimum region of available * memory to allow for an allocation of 'size'. * @is_tlab: Is this a Thread Local Allocation Buffer? * * Description: This marks the beginning of a parallel collection of a new * generation. * */ probe hotspot.gc_collect_parnew = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__parnew__begin"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__parnew__begin") { name = "gc_collect_parnew_begin"; is_full = $arg2; size = $arg3; is_tlab = $arg4; probestr = sprintf("%s(is_full='%d', size='%d', is_tlab='%d')", name, is_full, size, is_tlab); } /* * probe - gc_collect_parnew_end * * @name: gc_collect_parnew_end * @is_full: If TRUE, attempt a full collection of the generation. * Else; perform a scavenge * @size: The collection should achieve a minimum region of available * memory to allow for an allocation of 'size'. * @is_tlab: Is this a Thread Local Allocation Buffer? * * Description: This marks the end of a parallel collection of a new * generation. * */ probe hotspot.gc_collect_parnew_end = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__parnew__end"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__parnew__end") { name = "gc_collect_parnew_end"; is_full = $arg2; size = $arg3; is_tlab = $arg4; probestr = sprintf("%s(is_full='%d', size='%d', is_tlab='%d')", name, is_full, size, is_tlab); } /* * probe - gc_collect_defnew_begin * * @name: gc_collect_defnew_begin * @is_full: If TRUE, attempt a full collection of the generation. * Else; perform a scavenge * @size: The collection should achieve a minimum region of available * memory to allow for an allocation of 'size'. * @is_tlab: Is this a Thread Local Allocation Buffer? * * Description: This marks the start of a newly defined generation * collection * */ probe hotspot.gc_collect_defnew_begin = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__defnew__begin"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__defnew__begin") { name = "gc_collect_defnew_begin"; is_full = $arg2; size = $arg3; is_tlab = $arg4; probestr = sprintf("%s(is_full='%d', size='%d', is_tlab='%d')", name, is_full, size, is_tlab); } /* * probe - gc_collect_defnew_end * * @name: gc_collect_defnew_end * @is_full: If TRUE, attempt a full collection of the generation. * Else; perform a scavenge * @size: The collection should achieve a minimum region of available * memory to allow for an allocation of 'size'. * @is_tlab: Is this a Thread Local Allocation Buffer? * * Description: This marks the end of a newly defined generation * collection * */ probe hotspot.gc_collect_defnew_end = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__defnew__end"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__defnew__end") { name = "gc_collect_defnew_end"; is_full = $arg2; size = $arg3; is_tlab = $arg4; probestr = sprintf("%s(is_full='%d', size='%d', is_tlab='%d')", name, is_full, size, is_tlab); } /* * probe - gc_collect_tenured_begin * * @name: gc_collect_tenured_begin * @is_full: If TRUE, attempt a full collection of the generation. * Else; perform a scavenge * @size: The collection should achieve a minimum region of available * memory to allow for an allocation of 'size'. * @is_tlab: Is this a Thread Local Allocation Buffer? * * Description: This is the start of a collection of a tenured generation * (a generation that has survived multiple garbage collections and is * now in a 'tenured' object space. * */ probe hotspot.gc_collect_tenured_begin = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__tenured__begin"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__tenured__begin") { name = "gc_collect_tenured_begin"; is_full = $arg2; size = $arg3; is_tlab = $arg4; probestr = sprintf("%s(is_full='%d', size='%d', is_tlab='%d')", name, is_full, size, is_tlab); } /* * probe - gc_collect_tenured_end * * @name: gc_collect_tenured_end * @is_full: If TRUE, attempt a full collection of the generation. * Else; perform a scavenge * @size: The collection should achieve a minimum region of available * memory to allow for an allocation of 'size'. * @is_tlab: Is this a Thread Local Allocation Buffer? * * Description: This is the end of a collection of a tenured generation * (a generation that has survived multiple garbage collections and is * now in a 'tenured' object space. * */ probe hotspot.gc_collect_tenured_end = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__tenured__end"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__tenured__end") { name = "gc_collect_tenured_end"; is_full = $arg2; size = $arg3; is_tlab = $arg4; probestr = sprintf("%s(is_full='%d', size='%d', is_tlab='%d')", name, is_full, size, is_tlab); } /* * probe - gc_collect_parallel_scavenge_heap_begin * * @name: gc_collect_parallel_scavenge_heap_begin * @address: Address of region being collected. * @cause: Cause of the collection. * * Description: This is a parallel heap scavenge beginning, the jvm process doesn't * have to halt while the gc is being completed. */ probe hotspot.gc_collect_parallel_scavenge = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__parscavenge__heap__begin"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__parscavenge__heap__begin") { name = "gc_collect_parallel_scavenge_heap_begin"; address = sprintf("0x%x", $arg1); cause = $arg2; probestr = sprintf("%s(address='%s', cause='%d')", name, address, cause); } /* * probe - gc_collect_parallel_scavenge_heap_end * * @name: gc_collect_parallel_scavenge_heap_end * @address: Address of region being collected. * @cause: Cause of the collection. * * Description: This is a parallel heap scavenge ending, the jvm process doesn't * have to halt while the gc is being completed. */ probe hotspot.gc_collect_parallel_scavenge_heap_end = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__parscavenge__heap__end"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__parscavenge__heap__end") { name = "gc_collect_parallel_scavenge_heap_end"; address = sprintf("0x%x", $arg1); cause = $arg2; probestr = sprintf("%s(address='%s', cause='%d')", name, address, cause); } /* * probe - gc_collect_parallel_collect * * @name: gc_collect_parallel_collect * @address: Address of object being collected. * @cause: Cause of the collection. * * Description: This marks a parallel collection. * */ probe hotspot.gc_collect_parallel_collect = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__parallel__collect"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__parallel__collect") { name = "gc_collect_parallel_collect"; address = sprintf("0x%x", $arg1); cause = $arg2; probestr = sprintf("%s(address='%s', cause='%d')", name, address, cause); } /* * probe - gc_collect_g1_begin * * @name: gc_collect_g1_begin * @address: Address of object being collected. * @cause: Cause of the collection. * * Description: This marks the start of a G1 style garbage collection * (Garbage-First Garbage Collector). * */ probe hotspot.gc_collect_g1_begin = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__G1__begin"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__G1__begin") { name = "gc_collect_g1_begin"; address = sprintf("0x%x", $arg1); cause = $arg2; probestr = sprintf("%s(address='%s', cause='%d')", name, address, cause); } /* * probe - gc_collect_g1_end * * @name: gc_collect_g1_end * @address: Address of object being collected. * @cause: Cause of the collection. * * Description: This marks then end of a G1 style garbage collection * (Garbage-First Garbage Collector). * */ probe hotspot.gc_collect_g1_end = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__G1__end"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__G1__end") { name = "gc_collect_g1_end"; address = sprintf("0x%x", $arg1); cause = $arg2; probestr = sprintf("%s(address='%s', cause='%d')", name, address, cause); } /* * probe - gc_collect_delete * * @name: gc_collect_delete * @address: Address of object being collected. * @cause: Cause of the collection. * * Description: A delete statement of an object. * */ probe hotspot.gc_collect_delete = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__delete"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__delete") { name = "gc_collect_delete"; address = sprintf("0x%x", $arg1); probestr = sprintf("%s(address='%s')", name, address); } /* * probe - gc_collect_PSScavenge_begin * * @name: gc_collect_PSScavenge_begin * @address: Address of scavenge * @cause: Cause of the collection. * * Description: A parallel scavenge begins. A scavenge is a partial garbage * collection which should be much more common than a full garbage collection * throughout the course of the java program. * */ probe hotspot.gc_collect_PSScavenge_begin = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__PSScavenge__begin"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__PSScavenge__begin") { name = "gc_collect_PSScavenge_begin"; address = sprintf("0x%x", $arg1); cause = $arg2; probestr = sprintf("%s(address='%s', cause='%d')", name, address, cause); } /* * probe - gc_collect_PSScavenge_end * * @name: gc_collect_PSScavenge_end * @address: Address of scavenge. * @cause: Cause of the collection. * * Description: The end of the parallel scavenge. The beginning and end of * the scavenge is noted due to the possbility of multiple scavenges occuring * at the same time. * */ probe hotspot.gc_collect_PSScavenge_end = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__PSScavenge__end"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__PSScavenge__end") { name = "gc_collect_PSScavenge_end"; address = sprintf("0x%x", $arg1); cause = $arg2; probestr = sprintf("%s(address='%s', cause='%d')", name, address, cause); } /* * probe - gc_collect_PSParallelCompact_begin * * @name: gc_collect_PSParallelCompact_begin * @address: Address of compaction. * @cause: Cause of the collection. * * Description: This marks the start of a parallel compaction. * */ probe hotspot.gc_collect_PSParallelCompact_begin = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__PSParallelCompact__begin"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__PSParallelCompact__begin") { name = "gc_collect_PSParallelCompact_begin"; address = sprintf("0x%x", $arg1); cause = $arg2; probestr = sprintf("%s(address='%s', cause='%d')", name, address, cause); } /* * probe - gc_collect_PSParallelCompact_end * * @name: gc_collect_PSParallelCompact_end * @address: Address of compaction. * @cause: Cause of the collection. * * Description: This marks the end of a parallel compaction. * */ probe hotspot.gc_collect_PSParallelCompact_end = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__PSParallelCompact__end"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__PSParallelCompact__end") { name = "gc_collect_PSParallelCompact_end"; address = sprintf("0x%x", $arg1); cause = $arg2; probestr = sprintf("%s(address='%s', cause='%d')", name, address, cause); } /* * probe - gc_collect_PSMarkSweep_begin * * @name: gc_collect_PSMarkSweep_begin * @address: Address of parallel mark sweep process. * @cause: Cause of the collection. * * Description: This marks the start of a parallel mark sweep for * objects that require collection. * */ probe hotspot.gc_collect_PSMarkSweep_begin = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__PSMarkSweep__begin"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__PSMarkSweep__begin") { name = "gc_collect_PSMarkSweep_begin"; address = sprintf("0x%x", $arg1); cause = $arg2; probestr = sprintf("%s(address='%s', cause='%d')", name, address, cause); } /* * probe - gc_collect_PSMarkSweep_end * * @name: gc_collect_PSMarkSweep_end * @address: Address of parallel mark sweep process. * @cause: Cause of the collection. * * Description: This marks the start of a parallel mark sweep for * objects that require collection. * */ probe hotspot.gc_collect_PSMarkSweep_end = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__PSMarkSweep__end"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__PSMarkSweep__end") { name = "gc_collect_PSMarkSweep_end"; address = sprintf("0x%x", $arg1); cause = $arg2; probestr = sprintf("%s(address='%s', cause='%d')", name, address, cause); } /* * probe - gc_collect_move * * @name: gc_collect_move * @from_bottom_address: The bottom address of the object being moved. * @from_top_address: The top address of the object being moved. * @to_bottom_address: The bottom address of where the object is being moved to. * @to_top_address: The top address of where the object is being moved to. * @cause: Cause of the collection. * * Description: During garbage collections there are times where objects or * blocks of memory need to be moved. This probe will detail from where * the memory is moving and where to. * */ probe hotspot.gc_collect_move = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__move"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__move") { name = "gc_collect_move"; from_bottom_address = sprintf("0x%x", $arg1); from_top_address = sprintf("0x%x", $arg2); to_bottom_address = sprintf("0x%x", $arg3); to_top_address = sprintf("0x%x", $arg4); probestr = sprintf("%s(from_bottom_address='%s', from_top_address='%s', to_bottom_address='%s', to_top_address='%s')", name, from_bottom_address, from_top_address, to_bottom_address, to_top_address); } /* * probe - gc_collect_clear * * @name: gc_collect_clear * @address: Address of object being collected. * @cause: Cause of the collection. * * Description: This probe dictates the region of data that needs to be * cleared in a compaction action. * */ probe hotspot.gc_collect_clear = process("@ABS_CLIENT_LIBJVM_SO@").mark("gc__collection__ParallelCompact__clear"), process("@ABS_SERVER_LIBJVM_SO@").mark("gc__collection__ParallelCompact__clear") { name = "gc_collect_clear"; region_data = sprintf("0x%x", $arg1); data_location = sprintf("0x%x", $arg2); probestr = sprintf("%s(region_data='%s', data_location='%s')", name, region_data, data_location); } -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121003/4c3c97cf/attachment-0001.bin From staffan.larsen at oracle.com Wed Oct 3 09:15:39 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 3 Oct 2012 09:15:39 -0700 Subject: RFR: JI-29: SA ClassDump throws exception after permgen removal In-Reply-To: <506BEEDA.9020808@oracle.com> References: <506B2578.4040602@oracle.com> <506B537A.9060906@oracle.com> <506BC93C.4000802@oracle.com> <506BEEDA.9020808@oracle.com> Message-ID: <3C1BC87A-D6E3-42D5-A700-217457F988CA@oracle.com> I'm working on a change to remove all references to ia64/itanium in SA since it is dead code. It's ok with me if some references disappear before that. /Staffan On 3 okt 2012, at 00:52, David Holmes wrote: > Hi Yumin, > > Seems to be a lot of incidental cleanup here. What is the general state of ia64 files/references? > > David > > On 3/10/2012 3:12 PM, Yumin Qi wrote: >> Hi, All >> >> Based on Coleen's feedback, sadis.c has compilation warning, fixed, >> also removed some unused code in SA. >> >> http://cr.openjdk.java.net/~minqi/8000332/ >> >> >> Thanks >> Yumin >> >> On 10/2/2012 1:50 PM, Yumin Qi wrote: >>> Hi, all >>> >>> This is real URL for this bug codereview, I accidentally created the >>> bug with JIRA by click incidents link. Now the link is >>> http://cr.openjdk.java.net/~minqi/JDK-8000332/ >>> >>> >>> Thanks >>> Yumin >>> >>> On 10/2/2012 10:33 AM, Yumin Qi wrote: >>>> Hi, May I have your codereview >>>> >>>> http://cr.openjdk.java.net/~minqi/ji-29 >>>> >>>> >>>> JI-29: SA ClassDump throws exception after permgen removal >>>> Summary: In ClassWrite.writeFields(), fields count was set to fields >>>> length which overflows the array index. >>>> >>>> Also removed a file which should be removed in changeset of 6879063: >>>> SA should use hsdis. >>>> >>>> Reviewed-by: >>>> Contributed-by: yumin.qi at oracle.com >>>> >>>> >>>> Thanks >>>> Yumin From staffan.larsen at oracle.com Wed Oct 3 09:26:59 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 3 Oct 2012 09:26:59 -0700 Subject: RFR: JI-29: SA ClassDump throws exception after permgen removal In-Reply-To: <3C1BC87A-D6E3-42D5-A700-217457F988CA@oracle.com> References: <506B2578.4040602@oracle.com> <506B537A.9060906@oracle.com> <506BC93C.4000802@oracle.com> <506BEEDA.9020808@oracle.com> <3C1BC87A-D6E3-42D5-A700-217457F988CA@oracle.com> Message-ID: Actually, let me rephrase this. It's good to remove dangling ia64 code, but it would be better if these changes were made explicitly under their own CR and changeset. Thanks, /Staffan On 3 okt 2012, at 09:15, Staffan Larsen wrote: > I'm working on a change to remove all references to ia64/itanium in SA since it is dead code. It's ok with me if some references disappear before that. > > /Staffan > > On 3 okt 2012, at 00:52, David Holmes wrote: > >> Hi Yumin, >> >> Seems to be a lot of incidental cleanup here. What is the general state of ia64 files/references? >> >> David >> >> On 3/10/2012 3:12 PM, Yumin Qi wrote: >>> Hi, All >>> >>> Based on Coleen's feedback, sadis.c has compilation warning, fixed, >>> also removed some unused code in SA. >>> >>> http://cr.openjdk.java.net/~minqi/8000332/ >>> >>> >>> Thanks >>> Yumin >>> >>> On 10/2/2012 1:50 PM, Yumin Qi wrote: >>>> Hi, all >>>> >>>> This is real URL for this bug codereview, I accidentally created the >>>> bug with JIRA by click incidents link. Now the link is >>>> http://cr.openjdk.java.net/~minqi/JDK-8000332/ >>>> >>>> >>>> Thanks >>>> Yumin >>>> >>>> On 10/2/2012 10:33 AM, Yumin Qi wrote: >>>>> Hi, May I have your codereview >>>>> >>>>> http://cr.openjdk.java.net/~minqi/ji-29 >>>>> >>>>> >>>>> JI-29: SA ClassDump throws exception after permgen removal >>>>> Summary: In ClassWrite.writeFields(), fields count was set to fields >>>>> length which overflows the array index. >>>>> >>>>> Also removed a file which should be removed in changeset of 6879063: >>>>> SA should use hsdis. >>>>> >>>>> Reviewed-by: >>>>> Contributed-by: yumin.qi at oracle.com >>>>> >>>>> >>>>> Thanks >>>>> Yumin > From yumin.qi at oracle.com Wed Oct 3 09:26:18 2012 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Wed, 03 Oct 2012 09:26:18 -0700 Subject: RFR: JI-29: SA ClassDump throws exception after permgen removal In-Reply-To: <3C1BC87A-D6E3-42D5-A700-217457F988CA@oracle.com> References: <506B2578.4040602@oracle.com> <506B537A.9060906@oracle.com> <506BC93C.4000802@oracle.com> <506BEEDA.9020808@oracle.com> <3C1BC87A-D6E3-42D5-A700-217457F988CA@oracle.com> Message-ID: <506C672A.4030508@oracle.com> Staffan & David, Can I put you two as reviewers? Thanks Yumin On 10/3/2012 9:15 AM, Staffan Larsen wrote: > I'm working on a change to remove all references to ia64/itanium in SA since it is dead code. It's ok with me if some references disappear before that. > > /Staffan > > On 3 okt 2012, at 00:52, David Holmes wrote: > >> Hi Yumin, >> >> Seems to be a lot of incidental cleanup here. What is the general state of ia64 files/references? >> >> David >> >> On 3/10/2012 3:12 PM, Yumin Qi wrote: >>> Hi, All >>> >>> Based on Coleen's feedback, sadis.c has compilation warning, fixed, >>> also removed some unused code in SA. >>> >>> http://cr.openjdk.java.net/~minqi/8000332/ >>> >>> >>> Thanks >>> Yumin >>> >>> On 10/2/2012 1:50 PM, Yumin Qi wrote: >>>> Hi, all >>>> >>>> This is real URL for this bug codereview, I accidentally created the >>>> bug with JIRA by click incidents link. Now the link is >>>> http://cr.openjdk.java.net/~minqi/JDK-8000332/ >>>> >>>> >>>> Thanks >>>> Yumin >>>> >>>> On 10/2/2012 10:33 AM, Yumin Qi wrote: >>>>> Hi, May I have your codereview >>>>> >>>>> http://cr.openjdk.java.net/~minqi/ji-29 >>>>> >>>>> >>>>> JI-29: SA ClassDump throws exception after permgen removal >>>>> Summary: In ClassWrite.writeFields(), fields count was set to fields >>>>> length which overflows the array index. >>>>> >>>>> Also removed a file which should be removed in changeset of 6879063: >>>>> SA should use hsdis. >>>>> >>>>> Reviewed-by: >>>>> Contributed-by: yumin.qi at oracle.com >>>>> >>>>> >>>>> Thanks >>>>> Yumin From staffan.larsen at oracle.com Wed Oct 3 11:56:24 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 3 Oct 2012 11:56:24 -0700 Subject: RFR: JI-29: SA ClassDump throws exception after permgen removal In-Reply-To: <506C672A.4030508@oracle.com> References: <506B2578.4040602@oracle.com> <506B537A.9060906@oracle.com> <506BC93C.4000802@oracle.com> <506BEEDA.9020808@oracle.com> <3C1BC87A-D6E3-42D5-A700-217457F988CA@oracle.com> <506C672A.4030508@oracle.com> Message-ID: As I said, I would like to see the ia64-removal in a separate changeset. Thanks, /Staffan On 3 okt 2012, at 09:26, yumin.qi at oracle.com wrote: > Staffan & David, > > Can I put you two as reviewers? > > Thanks > Yumin > > On 10/3/2012 9:15 AM, Staffan Larsen wrote: >> I'm working on a change to remove all references to ia64/itanium in SA since it is dead code. It's ok with me if some references disappear before that. >> >> /Staffan >> >> On 3 okt 2012, at 00:52, David Holmes wrote: >> >>> Hi Yumin, >>> >>> Seems to be a lot of incidental cleanup here. What is the general state of ia64 files/references? >>> >>> David >>> >>> On 3/10/2012 3:12 PM, Yumin Qi wrote: >>>> Hi, All >>>> >>>> Based on Coleen's feedback, sadis.c has compilation warning, fixed, >>>> also removed some unused code in SA. >>>> >>>> http://cr.openjdk.java.net/~minqi/8000332/ >>>> >>>> >>>> Thanks >>>> Yumin >>>> >>>> On 10/2/2012 1:50 PM, Yumin Qi wrote: >>>>> Hi, all >>>>> >>>>> This is real URL for this bug codereview, I accidentally created the >>>>> bug with JIRA by click incidents link. Now the link is >>>>> http://cr.openjdk.java.net/~minqi/JDK-8000332/ >>>>> >>>>> >>>>> Thanks >>>>> Yumin >>>>> >>>>> On 10/2/2012 10:33 AM, Yumin Qi wrote: >>>>>> Hi, May I have your codereview >>>>>> >>>>>> http://cr.openjdk.java.net/~minqi/ji-29 >>>>>> >>>>>> >>>>>> JI-29: SA ClassDump throws exception after permgen removal >>>>>> Summary: In ClassWrite.writeFields(), fields count was set to fields >>>>>> length which overflows the array index. >>>>>> >>>>>> Also removed a file which should be removed in changeset of 6879063: >>>>>> SA should use hsdis. >>>>>> >>>>>> Reviewed-by: >>>>>> Contributed-by: yumin.qi at oracle.com >>>>>> >>>>>> >>>>>> Thanks >>>>>> Yumin From yumin.qi at oracle.com Wed Oct 3 13:21:23 2012 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Wed, 03 Oct 2012 13:21:23 -0700 Subject: RFR: JI-29: SA ClassDump throws exception after permgen removal In-Reply-To: References: <506B2578.4040602@oracle.com> <506B537A.9060906@oracle.com> <506BC93C.4000802@oracle.com> <506BEEDA.9020808@oracle.com> <3C1BC87A-D6E3-42D5-A700-217457F988CA@oracle.com> Message-ID: <506C9E43.3050909@oracle.com> I will create another bug id and put all the removal work under it. Thanks Yumin On 10/3/2012 9:26 AM, Staffan Larsen wrote: > Actually, let me rephrase this. It's good to remove dangling ia64 code, but it would be better if these changes were made explicitly under their own CR and changeset. > > Thanks, > /Staffan > > On 3 okt 2012, at 09:15, Staffan Larsen wrote: > >> I'm working on a change to remove all references to ia64/itanium in SA since it is dead code. It's ok with me if some references disappear before that. >> >> /Staffan >> >> On 3 okt 2012, at 00:52, David Holmes wrote: >> >>> Hi Yumin, >>> >>> Seems to be a lot of incidental cleanup here. What is the general state of ia64 files/references? >>> >>> David >>> >>> On 3/10/2012 3:12 PM, Yumin Qi wrote: >>>> Hi, All >>>> >>>> Based on Coleen's feedback, sadis.c has compilation warning, fixed, >>>> also removed some unused code in SA. >>>> >>>> http://cr.openjdk.java.net/~minqi/8000332/ >>>> >>>> >>>> Thanks >>>> Yumin >>>> >>>> On 10/2/2012 1:50 PM, Yumin Qi wrote: >>>>> Hi, all >>>>> >>>>> This is real URL for this bug codereview, I accidentally created the >>>>> bug with JIRA by click incidents link. Now the link is >>>>> http://cr.openjdk.java.net/~minqi/JDK-8000332/ >>>>> >>>>> >>>>> Thanks >>>>> Yumin >>>>> >>>>> On 10/2/2012 10:33 AM, Yumin Qi wrote: >>>>>> Hi, May I have your codereview >>>>>> >>>>>> http://cr.openjdk.java.net/~minqi/ji-29 >>>>>> >>>>>> >>>>>> JI-29: SA ClassDump throws exception after permgen removal >>>>>> Summary: In ClassWrite.writeFields(), fields count was set to fields >>>>>> length which overflows the array index. >>>>>> >>>>>> Also removed a file which should be removed in changeset of 6879063: >>>>>> SA should use hsdis. >>>>>> >>>>>> Reviewed-by: >>>>>> Contributed-by: yumin.qi at oracle.com >>>>>> >>>>>> >>>>>> Thanks >>>>>> Yumin From yuka.kamiya at oracle.com Wed Oct 3 19:38:08 2012 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Thu, 04 Oct 2012 02:38:08 +0000 Subject: hg: jdk8/tl/jdk: 7196316: Wrong rounding mode in DecimalFormat after deserialization Message-ID: <20121004023839.5A4B147194@hg.openjdk.java.net> Changeset: 123db1c28d92 Author: peytoia Date: 2012-10-04 11:36 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/123db1c28d92 7196316: Wrong rounding mode in DecimalFormat after deserialization Reviewed-by: okutsu ! src/share/classes/java/text/DecimalFormat.java + test/java/text/Format/DecimalFormat/Bug7196316.java From yuka.kamiya at oracle.com Thu Oct 4 02:07:35 2012 From: yuka.kamiya at oracle.com (yuka.kamiya at oracle.com) Date: Thu, 04 Oct 2012 09:07:35 +0000 Subject: hg: jdk8/tl/jdk: 7201151: Fix Contribution : Java cannot get Windows's IME name correctly Message-ID: <20121004090757.E256947199@hg.openjdk.java.net> Changeset: 8692e14b8ea8 Author: peytoia Date: 2012-10-04 18:05 +0900 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8692e14b8ea8 7201151: Fix Contribution : Java cannot get Windows's IME name correctly Reviewed-by: okutsu ! src/windows/native/sun/windows/awt_InputMethod.cpp From vincent.x.ryan at oracle.com Thu Oct 4 03:58:02 2012 From: vincent.x.ryan at oracle.com (vincent.x.ryan at oracle.com) Date: Thu, 04 Oct 2012 10:58:02 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121004105931.35A3A4719A@hg.openjdk.java.net> Changeset: 344f0acff085 Author: vinnie Date: 2012-02-14 11:18 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/344f0acff085 7133495: [macosx] KeyChain KeyStore implementation retrieves only one private key entry Reviewed-by: weijun ! src/macosx/native/apple/security/KeystoreImpl.m + test/sun/security/tools/keytool/ListKeychainStore.sh Changeset: 77af5b4ae4f0 Author: vinnie Date: 2012-10-04 11:54 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77af5b4ae4f0 Merge From maurizio.cimadamore at oracle.com Thu Oct 4 05:27:29 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 04 Oct 2012 12:27:29 +0000 Subject: hg: jdk8/tl/langtools: 7177387: Add target-typing support in method context Message-ID: <20121004122734.6397E4719D@hg.openjdk.java.net> Changeset: 1408af4cd8b0 Author: mcimadamore Date: 2012-10-04 13:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1408af4cd8b0 7177387: Add target-typing support in method context Summary: Add support for deferred types and speculative attribution Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeTags.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/AttrContext.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! test/tools/javac/conditional/Conditional.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/IncompatibleTypesInConditional.java + test/tools/javac/diags/examples/TypeConditional.java From rickard.backman at oracle.com Thu Oct 4 06:01:46 2012 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Thu, 4 Oct 2012 15:01:46 +0200 Subject: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval Message-ID: <944656E5-9306-411E-A916-4DDC95E819D4@oracle.com> Hi all, can I please have a couple of reviews on the following change: http://cr.openjdk.java.net/~rbackman/7127792/ http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127792 In short the purpose is to enable tasks to change the interval they are executed in. We would also like to be able to add (and remove) tasks after the WatcherThread has started. Thanks /R From jaroslav.bachorik at oracle.com Thu Oct 4 08:28:05 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 04 Oct 2012 17:28:05 +0200 Subject: jmx-dev Review Request: 7195779 javax/management/remote/mandatory/threads/ExecutorTest.java fail intermittently In-Reply-To: <506AEE45.7020403@oracle.com> References: <5059BD10.40801@oracle.com> <5059C33D.7@oracle.com> <5059C5B3.6020808@oracle.com> <5059CB04.30107@oracle.com> <505C46EB.60800@oracle.com> <506AA6C9.30909@oracle.com> <506AEE45.7020403@oracle.com> Message-ID: <506DAB05.4050500@oracle.com> On Tue 02 Oct 2012 03:38:13 PM CEST, Alan Bateman wrote: > On 02/10/2012 09:33, Jaroslav Bachorik wrote: >> : >> The generated TIE class is inherently thread-unsafe. The internal state >> (the target field) can be manipulated without any enforced >> synchronization - eg. it is valid to set the target field to null by >> calling the deactivate() method after the _invoke() method has been >> entered from a different thread. This will lead to the NPE we can >> observe. Given this example one should make critical sections out of >> deactivate() and _invoke() methods to prevent this situation. However, >> this simplistic approach might lead to deadlocks in the existing code >> as the _invoke() method body might be blocking (it is a 3rd party code) >> and thus preventing execution of the deactivate() method indefinitely. >> >> Also, it is not really possible to solve this problem outside of the >> generated TIE class - it is caused by the concurrent change of the >> TIE's internal state. So, the solution would be either caching the >> target attribute at the beginning of the invoke() operation in a >> synchronized block and use the cached version afterwards (and throwing >> a remote exception if it is null - the TIE was deactivated effectively >> before entering the invoke() operation) or postponing deactivation when >> the invoke() method is detected as being in progress. >> >> -JB- >> > Jaroslav and I chatted on IM about this today. Jaroslav is going to > have a go at changing the stub generator and will send a follow-up > mail with an updated webrev (this time for the corba repo as the that > is where the stub generator lives). This is a follow-up. I've prepared the patch and put it on github - https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/7195779 I wonder who else should be included in the review process since I am changing the IIOP generator code. Also, I didn't find any tests in the corba repository. Which test suite is appropriate to run after changing the corba related code? -JB- > > -Alan From Alan.Bateman at oracle.com Thu Oct 4 08:42:15 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 04 Oct 2012 16:42:15 +0100 Subject: jmx-dev Review Request: 7195779 javax/management/remote/mandatory/threads/ExecutorTest.java fail intermittently In-Reply-To: <506DAB05.4050500@oracle.com> References: <5059BD10.40801@oracle.com> <5059C33D.7@oracle.com> <5059C5B3.6020808@oracle.com> <5059CB04.30107@oracle.com> <505C46EB.60800@oracle.com> <506AA6C9.30909@oracle.com> <506AEE45.7020403@oracle.com> <506DAB05.4050500@oracle.com> Message-ID: <506DAE57.3020300@oracle.com> On 04/10/2012 16:28, Jaroslav Bachorik wrote: > : > This is a follow-up. I've prepared the patch and put it on github - > https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/7195779 > > I wonder who else should be included in the review process since I am > changing the IIOP generator code. Also, I didn't find any tests in the > corba repository. Which test suite is appropriate to run after changing > the corba related code? > > -JB- > I don't mind being reviewer and sponsor for this. Also cc'ing Sean as he is one of the maintainers of the corba code. I don't think the corba tests are in OpenJDK, at least I don't think Oracle has contributed its tests for this area. I think your change looks okay and I assume you've at least run the JMX tests that use RMI-IIOP to verify that the intermittent NPE is gone and those tests now pass reliably. Minor comment but if I were doing this myself then I probably would have added this instead: p.pln(getName(theType) + " target = this.target;"); You'll see lots of examples of this in the core libs and j.u.c. Also as target is now volatile then I'm not sure why you synchronized around target=null, perhaps there is other code generated in the tie class that I don't see? Otherwise it's great to get issue finally resolved. -Alan. From jaroslav.bachorik at oracle.com Thu Oct 4 08:56:10 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 04 Oct 2012 17:56:10 +0200 Subject: jmx-dev Review Request: 7195779 javax/management/remote/mandatory/threads/ExecutorTest.java fail intermittently In-Reply-To: <506DAE57.3020300@oracle.com> References: <5059BD10.40801@oracle.com> <5059C33D.7@oracle.com> <5059C5B3.6020808@oracle.com> <5059CB04.30107@oracle.com> <505C46EB.60800@oracle.com> <506AA6C9.30909@oracle.com> <506AEE45.7020403@oracle.com> <506DAB05.4050500@oracle.com> <506DAE57.3020300@oracle.com> Message-ID: <506DB19A.7070604@oracle.com> On Thu 04 Oct 2012 05:42:15 PM CEST, Alan Bateman wrote: > On 04/10/2012 16:28, Jaroslav Bachorik wrote: >> : >> This is a follow-up. I've prepared the patch and put it on github - >> https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/7195779 >> >> I wonder who else should be included in the review process since I am >> changing the IIOP generator code. Also, I didn't find any tests in the >> corba repository. Which test suite is appropriate to run after changing >> the corba related code? >> >> -JB- >> > I don't mind being reviewer and sponsor for this. Also cc'ing Sean as > he is one of the maintainers of the corba code. I don't think the Thanks. > corba tests are in OpenJDK, at least I don't think Oracle has > contributed its tests for this area. > > I think your change looks okay and I assume you've at least run the > JMX tests that use RMI-IIOP to verify that the intermittent NPE is > gone and those tests now pass reliably. Yes, I ran those. Especially on the test machine yielding the biggest ration of failed tests previously. Now they all pass. > > Minor comment but if I were doing this myself then I probably would > have added this instead: > p.pln(getName(theType) + " target = this.target;"); > > You'll see lots of examples of this in the core libs and j.u.c. No problem. If it is a convention I will stick to it (I've used a different variable name to prevent confusion about what is a field and what is a local variable). > > Also as target is now volatile then I'm not sure why you synchronized > around target=null, perhaps there is other code generated in the tie > class that I don't see? The synchronization should not be there. It just escaped my purging when I've exchanged the synchronized access for volatile. -JB- > > Otherwise it's great to get issue finally resolved. > > -Alan. > > From sean.coffey at oracle.com Thu Oct 4 09:16:49 2012 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 04 Oct 2012 17:16:49 +0100 Subject: jmx-dev Review Request: 7195779 javax/management/remote/mandatory/threads/ExecutorTest.java fail intermittently In-Reply-To: <506DAE57.3020300@oracle.com> References: <5059BD10.40801@oracle.com> <5059C33D.7@oracle.com> <5059C5B3.6020808@oracle.com> <5059CB04.30107@oracle.com> <505C46EB.60800@oracle.com> <506AA6C9.30909@oracle.com> <506AEE45.7020403@oracle.com> <506DAB05.4050500@oracle.com> <506DAE57.3020300@oracle.com> Message-ID: <506DB671.3090706@oracle.com> Looks ok to me too Jaraslav, Corba tests are sadly lacking. I can run this through a testsuite which QA team use. regards, Sean. On 04/10/2012 16:42, Alan Bateman wrote: > On 04/10/2012 16:28, Jaroslav Bachorik wrote: >> : >> This is a follow-up. I've prepared the patch and put it on github - >> https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/7195779 >> >> I wonder who else should be included in the review process since I am >> changing the IIOP generator code. Also, I didn't find any tests in the >> corba repository. Which test suite is appropriate to run after changing >> the corba related code? >> >> -JB- >> > I don't mind being reviewer and sponsor for this. Also cc'ing Sean as > he is one of the maintainers of the corba code. I don't think the > corba tests are in OpenJDK, at least I don't think Oracle has > contributed its tests for this area. > > I think your change looks okay and I assume you've at least run the > JMX tests that use RMI-IIOP to verify that the intermittent NPE is > gone and those tests now pass reliably. > > Minor comment but if I were doing this myself then I probably would > have added this instead: > p.pln(getName(theType) + " target = this.target;"); > > You'll see lots of examples of this in the core libs and j.u.c. > > Also as target is now volatile then I'm not sure why you synchronized > around target=null, perhaps there is other code generated in the tie > class that I don't see? > > Otherwise it's great to get issue finally resolved. > > -Alan. > > From naoto.sato at oracle.com Thu Oct 4 10:06:07 2012 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Thu, 04 Oct 2012 17:06:07 +0000 Subject: hg: jdk8/tl/jdk: 7196799: CLDR adapter can not be invoked when region code is specified in Locale; ... Message-ID: <20121004170630.E257C471A8@hg.openjdk.java.net> Changeset: c6a0b13e6efa Author: naoto Date: 2012-10-04 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6a0b13e6efa 7196799: CLDR adapter can not be invoked when region code is specified in Locale 7197573: java/util/Locale/LocaleProviders.sh failed. Reviewed-by: okutsu ! make/java/java/FILES_java.gmk ! src/share/classes/sun/util/locale/provider/CalendarDataProviderImpl.java + src/share/classes/sun/util/locale/provider/FallbackLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh From rob.mckenna at oracle.com Thu Oct 4 11:50:24 2012 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Thu, 04 Oct 2012 18:50:24 +0000 Subject: hg: jdk8/tl/jdk: 7184932: Remove the temporary Selector usage in the NIO socket adapters Message-ID: <20121004185045.DA1DF471A9@hg.openjdk.java.net> Changeset: bba370caafad Author: robm Date: 2012-10-04 19:53 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bba370caafad 7184932: Remove the temporary Selector usage in the NIO socket adapters Reviewed-by: alanb ! make/java/nio/mapfile-bsd ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/DatagramSocketAdaptor.java ! src/share/classes/sun/nio/ch/Net.java ! src/share/classes/sun/nio/ch/ServerSocketAdaptor.java ! src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/SocketAdaptor.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/share/classes/sun/nio/ch/Util.java ! src/solaris/native/sun/nio/ch/Net.c ! src/windows/native/sun/nio/ch/Net.c + test/java/nio/channels/etc/AdaptorCloseAndInterrupt.java From coleen.phillimore at oracle.com Thu Oct 4 17:05:14 2012 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Fri, 05 Oct 2012 00:05:14 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20121005000519.EC315471B7@hg.openjdk.java.net> Changeset: ba8fd2fe198b Author: coleenp Date: 2012-10-04 08:38 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ba8fd2fe198b 7198519: Broken build, hotspot-rt win USE_PRECOMPILED_HEADER=0 Summary: Uncommented out include for sys/stat.h and deleted include statements that were commented out. Reviewed-by: coleenp, acorn, dholmes Contributed-by: harold.seigel at oracle.com ! src/os/windows/vm/jvm_windows.h Changeset: bacdc1d5c21c Author: coleenp Date: 2012-10-04 08:43 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bacdc1d5c21c 6884973: java -XX:Atomics=2 crashes Summary: Remove buggy experimental option Reviewed-by: acorn, coleenp Contributed-by: harold.seigel at oracle.com ! src/cpu/x86/vm/assembler_x86.cpp ! src/share/vm/runtime/globals.hpp From david.holmes at oracle.com Thu Oct 4 19:16:05 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Fri, 05 Oct 2012 02:16:05 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20121005021613.4DA1A471BD@hg.openjdk.java.net> Changeset: 48087f745a86 Author: dholmes Date: 2012-10-04 19:52 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/48087f745a86 7199186: runtime/7194254/Test7194254.java fails - wrong test name on @run Reviewed-by: kvn, twisti ! test/runtime/7194254/Test7194254.java Changeset: f2eb2d4488db Author: dholmes Date: 2012-10-04 20:09 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f2eb2d4488db Merge From naoto.sato at oracle.com Thu Oct 4 21:05:39 2012 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Fri, 05 Oct 2012 04:05:39 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121005040612.79C33471BE@hg.openjdk.java.net> Changeset: cd4f181eb666 Author: naoto Date: 2012-10-04 21:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cd4f181eb666 7200119: Collator.getAvailableLocales() doesn't return Locale.US Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java + test/java/text/Collator/Bug7200119.java Changeset: 647424d6cf65 Author: naoto Date: 2012-10-04 21:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/647424d6cf65 Merge From jaroslav.bachorik at oracle.com Fri Oct 5 01:10:31 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Fri, 05 Oct 2012 10:10:31 +0200 Subject: jmx-dev Review Request: 7195779 javax/management/remote/mandatory/threads/ExecutorTest.java fail intermittently In-Reply-To: <506DB19A.7070604@oracle.com> References: <5059BD10.40801@oracle.com> <5059C33D.7@oracle.com> <5059C5B3.6020808@oracle.com> <5059CB04.30107@oracle.com> <505C46EB.60800@oracle.com> <506AA6C9.30909@oracle.com> <506AEE45.7020403@oracle.com> <506DAB05.4050500@oracle.com> <506DAE57.3020300@oracle.com> <506DB19A.7070604@oracle.com> Message-ID: <506E95F7.7000304@oracle.com> I have updated the patch to reflect Alan's remarks. The webrev is at the same location - github takes care of versioning ... -JB- On 10/04/2012 05:56 PM, Jaroslav Bachorik wrote: > On Thu 04 Oct 2012 05:42:15 PM CEST, Alan Bateman wrote: >> On 04/10/2012 16:28, Jaroslav Bachorik wrote: >>> : >>> This is a follow-up. I've prepared the patch and put it on github - >>> https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/7195779 >>> >>> I wonder who else should be included in the review process since I am >>> changing the IIOP generator code. Also, I didn't find any tests in the >>> corba repository. Which test suite is appropriate to run after changing >>> the corba related code? >>> >>> -JB- >>> >> I don't mind being reviewer and sponsor for this. Also cc'ing Sean as >> he is one of the maintainers of the corba code. I don't think the > > Thanks. > >> corba tests are in OpenJDK, at least I don't think Oracle has >> contributed its tests for this area. >> >> I think your change looks okay and I assume you've at least run the >> JMX tests that use RMI-IIOP to verify that the intermittent NPE is >> gone and those tests now pass reliably. > > Yes, I ran those. Especially on the test machine yielding the biggest > ration of failed tests previously. Now they all pass. > >> >> Minor comment but if I were doing this myself then I probably would >> have added this instead: >> p.pln(getName(theType) + " target = this.target;"); >> >> You'll see lots of examples of this in the core libs and j.u.c. > > No problem. If it is a convention I will stick to it (I've used a > different variable name to prevent confusion about what is a field and > what is a local variable). > >> >> Also as target is now volatile then I'm not sure why you synchronized >> around target=null, perhaps there is other code generated in the tie >> class that I don't see? > > The synchronization should not be there. It just escaped my purging > when I've exchanged the synchronized access for volatile. > > -JB- > >> >> Otherwise it's great to get issue finally resolved. >> >> -Alan. >> >> > > From Alan.Bateman at oracle.com Fri Oct 5 01:59:51 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 05 Oct 2012 09:59:51 +0100 Subject: jmx-dev Review Request: 7195779 javax/management/remote/mandatory/threads/ExecutorTest.java fail intermittently In-Reply-To: <506E95F7.7000304@oracle.com> References: <5059BD10.40801@oracle.com> <5059C33D.7@oracle.com> <5059C5B3.6020808@oracle.com> <5059CB04.30107@oracle.com> <505C46EB.60800@oracle.com> <506AA6C9.30909@oracle.com> <506AEE45.7020403@oracle.com> <506DAB05.4050500@oracle.com> <506DAE57.3020300@oracle.com> <506DB19A.7070604@oracle.com> <506E95F7.7000304@oracle.com> Message-ID: <506EA187.6040008@oracle.com> On 05/10/2012 09:10, Jaroslav Bachorik wrote: > I have updated the patch to reflect Alan's remarks. The webrev is at the > same location - github takes care of versioning ... > > -JB- > Thanks Jaroslav, I grabbed it from here: https://raw.github.com/jbachorik/openjdk-patches/master/webrevs/7195779/corba.patch I'll push this into jdk8/tl shortly, listing you as the contributor. -Alan. From maurizio.cimadamore at oracle.com Fri Oct 5 06:50:10 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Fri, 05 Oct 2012 13:50:10 +0000 Subject: hg: jdk8/tl/langtools: 7177385: Add attribution support for lambda expressions Message-ID: <20121005135014.E3F20471C9@hg.openjdk.java.net> Changeset: 573ceb23beeb Author: mcimadamore Date: 2012-10-05 14:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/573ceb23beeb 7177385: Add attribution support for lambda expressions Summary: Add support for function descriptor lookup, functional interface inference and lambda expression type-checking Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! test/tools/javac/6402516/TestLocalElements.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/CantAccessArgTypeInFunctionalDesc.java + test/tools/javac/diags/examples/CantAccessReturnTypeInFunctionalDesc.java + test/tools/javac/diags/examples/CantAccessThrownTypesInFunctionalDesc.java ! test/tools/javac/diags/examples/CantRefNonEffectivelyFinalVar.java ! test/tools/javac/diags/examples/CatchWithoutTry.java + test/tools/javac/diags/examples/CyclicInference.java + test/tools/javac/diags/examples/IncompatibleAbstracts.java + test/tools/javac/diags/examples/IncompatibleArgTypesInLambda.java + test/tools/javac/diags/examples/IncompatibleDescsInFunctionalIntf.java + test/tools/javac/diags/examples/IncompatibleRetTypeInLambda.java + test/tools/javac/diags/examples/IncompatibleThrownTypesInLambda.java + test/tools/javac/diags/examples/InvalidGenericDescInFunctionalInterface.java + test/tools/javac/diags/examples/MissingReturnValueFragment.java + test/tools/javac/diags/examples/NoAbstracts.java + test/tools/javac/diags/examples/NoSuitableFunctionalIntfInst.java + test/tools/javac/diags/examples/NotAFunctionalIntf.java + test/tools/javac/diags/examples/PotentialLambdaFound.java - test/tools/javac/diags/examples/TypeConditional.java + test/tools/javac/diags/examples/UnexpectedLambda.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/typeAnnotations/newlocations/BasicTest.out From alan.bateman at oracle.com Fri Oct 5 07:08:04 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 05 Oct 2012 14:08:04 +0000 Subject: hg: jdk8/tl/corba: 7195779: javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently, NPE in tie class Message-ID: <20121005140804.E6F84471CA@hg.openjdk.java.net> Changeset: 27d87f0031bf Author: alanb Date: 2012-10-05 15:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/27d87f0031bf 7195779: javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently, NPE in tie class Reviewed-by: alanb, coffeys Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/sun/rmi/rmic/iiop/StubGenerator.java From naoto.sato at oracle.com Fri Oct 5 10:00:31 2012 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Fri, 05 Oct 2012 17:00:31 +0000 Subject: hg: jdk8/tl/jdk: 7198834: HOST Adapter: one extra empty space in the end of the pattern string Message-ID: <20121005170052.C74A1471D1@hg.openjdk.java.net> Changeset: 88a726a5b2dc Author: naoto Date: 2012-10-05 09:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88a726a5b2dc 7198834: HOST Adapter: one extra empty space in the end of the pattern string Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/windows/native/sun/util/locale/provider/HostLocaleProviderAdapter_md.c ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh From bhavesh.x.patel at oracle.com Fri Oct 5 14:22:00 2012 From: bhavesh.x.patel at oracle.com (bhavesh.x.patel at oracle.com) Date: Fri, 05 Oct 2012 21:22:00 +0000 Subject: hg: jdk8/tl/langtools: 3 new changesets Message-ID: <20121005212208.3DF32471D7@hg.openjdk.java.net> Changeset: d604fd09480b Author: bpatel Date: 2012-10-05 14:13 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d604fd09480b 7132631: The help-doc.html generates an invalid link to constant-values.html Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties + test/com/sun/javadoc/testHelpFile/TestHelpFile.java Changeset: ef88ae455c88 Author: bpatel Date: 2012-10-05 14:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ef88ae455c88 7068595: html files in class-use dir do not get loaded correctly when Frames link is clicked Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! test/com/sun/javadoc/testUseOption/TestUseOption.java Changeset: f4e45397722a Author: bpatel Date: 2012-10-05 14:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f4e45397722a 4696488: javadoc doesn't handle UNC paths for destination directory Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java + test/tools/javadoc/T4696488.java From maurizio.cimadamore at oracle.com Sat Oct 6 02:51:30 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Sat, 06 Oct 2012 09:51:30 +0000 Subject: hg: jdk8/tl/langtools: 7177386: Add attribution support for method references Message-ID: <20121006095137.CD840471E8@hg.openjdk.java.net> Changeset: d4b3cb1ece84 Author: mcimadamore Date: 2012-10-06 10:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d4b3cb1ece84 7177386: Add attribution support for method references Summary: Add type-checking/lookup routines for method references Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! test/tools/javac/6758789/T6758789a.out ! test/tools/javac/6840059/T6840059.out ! test/tools/javac/7132880/T7132880.out ! test/tools/javac/Diagnostics/6722234/T6722234a_1.out ! test/tools/javac/Diagnostics/6722234/T6722234a_2.out ! test/tools/javac/Diagnostics/6722234/T6722234b_1.out ! test/tools/javac/Diagnostics/6722234/T6722234b_2.out ! test/tools/javac/Diagnostics/6722234/T6722234c.out ! test/tools/javac/Diagnostics/6862608/T6862608a.out ! test/tools/javac/Diagnostics/6862608/T6862608b.out ! test/tools/javac/T6326754.out ! test/tools/javac/diags/CheckResourceKeys.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/CantAccessInnerClsConstr.java + test/tools/javac/diags/examples/CantApplySymbolFragment.java + test/tools/javac/diags/examples/CantApplySymbolsFragment.java + test/tools/javac/diags/examples/CantResolveLocationArgsFragment.java + test/tools/javac/diags/examples/CantResolveLocationArgsParamsFragment.java ! test/tools/javac/diags/examples/CyclicInference.java ! test/tools/javac/diags/examples/ExplicitParamsDoNotConformToBounds.java ! test/tools/javac/diags/examples/InaccessibleVarargsType/InaccessibleVarargsType.java ! test/tools/javac/diags/examples/IncompatibleEqUpperBounds.java + test/tools/javac/diags/examples/IncompatibleRetTypeInMref.java + test/tools/javac/diags/examples/IncompatibleThrownTypesInMref.java ! test/tools/javac/diags/examples/InferArgsLengthMismatch.java ! test/tools/javac/diags/examples/InferNoConformingAssignment.java ! test/tools/javac/diags/examples/InferVarargsArgumentMismatch.java ! test/tools/javac/diags/examples/InferredDoNotConformToEq.java ! test/tools/javac/diags/examples/InferredDoNotConformToUpper.java ! test/tools/javac/diags/examples/KindnameConstructor.java ! test/tools/javac/diags/examples/MethodReferencesNotSupported.java ! test/tools/javac/diags/examples/NoArgs.java + test/tools/javac/diags/examples/NonStaticCantBeRefFragment.java ! test/tools/javac/diags/examples/NotApplicableMethodFound.java + test/tools/javac/diags/examples/NotDefAccessClassIntfCantAccessFragment.java + test/tools/javac/diags/examples/RefAmbiguousFragment.java + test/tools/javac/diags/examples/UnexpectedMref.java ! test/tools/javac/diags/examples/VarargsArgumentMismatch.java ! test/tools/javac/diags/examples/VerboseResolveMulti1.java ! test/tools/javac/diags/examples/WhereCaptured.java ! test/tools/javac/diags/examples/WhereCaptured1.java ! test/tools/javac/diags/examples/WhereTypeVar.java ! test/tools/javac/generics/7034511/T7034511a.out ! test/tools/javac/generics/7034511/T7034511b.out ! test/tools/javac/generics/inference/6611449/T6611449.out ! test/tools/javac/generics/inference/6638712/T6638712a.out ! test/tools/javac/generics/inference/6638712/T6638712c.out ! test/tools/javac/generics/inference/6638712/T6638712d.out ! test/tools/javac/generics/inference/6838943/T6838943.out ! test/tools/javac/generics/inference/7086586/T7086586.out ! test/tools/javac/generics/inference/7177306/T7177306b.out ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/quid/T6999438.out ! test/tools/javac/varargs/6313164/T6313164.out From alan.bateman at oracle.com Sat Oct 6 06:08:47 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 06 Oct 2012 13:08:47 +0000 Subject: hg: jdk8/tl/jdk: 8000354: (props) Properties.storeToXML/loadFromXML need to allow for alternative implementations Message-ID: <20121006130910.CB0FF471EB@hg.openjdk.java.net> Changeset: f65871e75fde Author: alanb Date: 2012-10-06 13:56 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f65871e75fde 8000354: (props) Properties.storeToXML/loadFromXML need to allow for alternative implementations Reviewed-by: mchung, forax ! make/java/java/FILES_java.gmk ! make/sun/util/Makefile ! src/share/classes/java/util/Properties.java + src/share/classes/sun/util/spi/XmlPropertiesProvider.java + src/share/classes/sun/util/xml/META-INF/services/sun.util.spi.XmlPropertiesProvider + src/share/classes/sun/util/xml/PlatformXmlPropertiesProvider.java - src/share/classes/sun/util/xml/XMLUtils.java + test/java/util/Properties/CustomProvider.java + test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/MyXmlPropertiesProvider.java From Alan.Bateman at oracle.com Sun Oct 7 12:35:17 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sun, 07 Oct 2012 20:35:17 +0100 Subject: 7173494: some jdk tests are not run in test/Makefile Message-ID: <5071D975.7080904@oracle.com> This one is a small clean-up of the test targets defined in jdk/test/Makefile. The union of the tests executed by each of the make targets should be the entire test suite but this isn't so, there are small number of tests that aren't run. I've renamed jdk_misc to jdk_other (the original name is confusing because of sun.misc) and expanded it to run additional areas that have a small number of tests. If more tests are added to these areas over time then it may make sense to add new targets in the future. "make jdk_jmx" now runs the JMX tests as it was confusing to have those tests split between management1 and management2. I've also renamed jdk_tools1 to jdk_jdi to make it clear that this is the JDI tests rather than tools. When Kelly originally set this up he split the NIO tests into 3 batches, I don't think this is necessary any longer (the really slow tests have been long been dialed down or changed to run much faster). The webrev with the proposed changes is here: http://cr.openjdk.java.net/~alanb/7173494/webrev/ -Alan. From weijun.wang at oracle.com Sun Oct 7 19:43:54 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 08 Oct 2012 02:43:54 +0000 Subject: hg: jdk8/tl/jdk: 7201053: Krb5LoginModule shows NPE when both useTicketCache and storeKey are set to true Message-ID: <20121008024417.12A4D471FE@hg.openjdk.java.net> Changeset: 92f3a96f3c78 Author: weijun Date: 2012-10-08 10:42 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92f3a96f3c78 7201053: Krb5LoginModule shows NPE when both useTicketCache and storeKey are set to true Reviewed-by: mullan ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java + test/sun/security/krb5/auto/UseCacheAndStoreKey.java From chris.hegarty at oracle.com Mon Oct 8 10:08:55 2012 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Mon, 08 Oct 2012 18:08:55 +0100 Subject: 7173494: some jdk tests are not run in test/Makefile In-Reply-To: <5071D975.7080904@oracle.com> References: <5071D975.7080904@oracle.com> Message-ID: <507308A7.8040406@oracle.com> This update looks ok to me. At some point ( not asking you to do it now ) we will need to update 7u-dev, to avoid confusion around what tests are being run in what batches. -Chris. On 07/10/2012 20:35, Alan Bateman wrote: > > This one is a small clean-up of the test targets defined in > jdk/test/Makefile. The union of the tests executed by each of the make > targets should be the entire test suite but this isn't so, there are > small number of tests that aren't run. > > I've renamed jdk_misc to jdk_other (the original name is confusing > because of sun.misc) and expanded it to run additional areas that have a > small number of tests. If more tests are added to these areas over time > then it may make sense to add new targets in the future. > > "make jdk_jmx" now runs the JMX tests as it was confusing to have those > tests split between management1 and management2. I've also renamed > jdk_tools1 to jdk_jdi to make it clear that this is the JDI tests rather > than tools. When Kelly originally set this up he split the NIO tests > into 3 batches, I don't think this is necessary any longer (the really > slow tests have been long been dialed down or changed to run much faster). > > The webrev with the proposed changes is here: > http://cr.openjdk.java.net/~alanb/7173494/webrev/ > > -Alan. From mandy.chung at oracle.com Mon Oct 8 10:44:51 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 08 Oct 2012 10:44:51 -0700 Subject: 7173494: some jdk tests are not run in test/Makefile In-Reply-To: <5071D975.7080904@oracle.com> References: <5071D975.7080904@oracle.com> Message-ID: <50731113.9070400@oracle.com> It's good to clean this up and the change looks fine in general. A couple of minor comments: jdk_management - Might be good to include java/lang/management tests in this target in case someone only runs one target to verify that area. On the other hands, they are currently covered by jdk_lang target and might be better to take them out from jdk_lang (maybe in the future). jdk_rmi target - you change "javax/rmi" to "javax/rmi/ssl". There is no test in the test/javax/rmi directory currently but if a new test (or new subdirectory) is added under test/javax/rmi, you would have to change the jdk_rmi target. Would it be better to keep "javax/rmi" as it is? test/sun/misc seems to belong to jdk_lang. Do you know why they are in jdk_other? Mandy On 10/7/2012 12:35 PM, Alan Bateman wrote: > > This one is a small clean-up of the test targets defined in > jdk/test/Makefile. The union of the tests executed by each of the make > targets should be the entire test suite but this isn't so, there are > small number of tests that aren't run. > > I've renamed jdk_misc to jdk_other (the original name is confusing > because of sun.misc) and expanded it to run additional areas that have > a small number of tests. If more tests are added to these areas over > time then it may make sense to add new targets in the future. > > "make jdk_jmx" now runs the JMX tests as it was confusing to have > those tests split between management1 and management2. I've also > renamed jdk_tools1 to jdk_jdi to make it clear that this is the JDI > tests rather than tools. When Kelly originally set this up he split > the NIO tests into 3 batches, I don't think this is necessary any > longer (the really slow tests have been long been dialed down or > changed to run much faster). > > The webrev with the proposed changes is here: > http://cr.openjdk.java.net/~alanb/7173494/webrev/ > > -Alan. From Alan.Bateman at oracle.com Mon Oct 8 11:12:33 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 08 Oct 2012 19:12:33 +0100 Subject: 7173494: some jdk tests are not run in test/Makefile In-Reply-To: <50731113.9070400@oracle.com> References: <5071D975.7080904@oracle.com> <50731113.9070400@oracle.com> Message-ID: <50731791.4020806@oracle.com> On 08/10/2012 18:44, Mandy Chung wrote: > It's good to clean this up and the change looks fine in general. A > couple of minor comments: > > jdk_management - Might be good to include java/lang/management tests > in this target in case someone only runs one target to verify that > area. On the other hands, they are currently covered by jdk_lang > target and might be better to take them out from jdk_lang (maybe in > the future). The jdk_management target could run the java/lang/management tests too but it would mean these tests would run twice. I have experimented with moving these tests to test/java/lang_management (same thing for java/lang/instrument to java/lang_instrument) but decided not to include those changes here as it's a disruptive change. With compact profiles [1] and future modularization then we may need to look at this again as it would be really nice to be able to specify the test directories to jtreg that correspond to the modules or profiles (I think it's just a bit early to know how the tests will run). > > jdk_rmi target - you change "javax/rmi" to "javax/rmi/ssl". There is > no test in the test/javax/rmi directory currently but if a new test > (or new subdirectory) is added under test/javax/rmi, you would have to > change the jdk_rmi target. Would it be better to keep "javax/rmi" as > it is? javax.rmi.CORBA has the classes for RMI-IIOP and I would expect tests for this area to be run by a different make target, say jdk_corba. As it happens we don't have any tests for this area in the jdk repository so it doesn't make any difference at this time So somewhat of a drive-by fix (again profiles and modules motivated so that "make jdk_rmi" would run the RMI tests only). > > test/sun/misc seems to belong to jdk_lang. Do you know why they are > in jdk_other? The tests in test/sun/misc provide very sparse coverage and are somewhat of a mixed bag so I decided to leave them where they are. I wouldn't object to moving them to the jdk_lang target, do you have a strong opinion on this? -Alan [1] http://openjdk.java.net/jeps/161 From mandy.chung at oracle.com Mon Oct 8 11:38:14 2012 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 08 Oct 2012 11:38:14 -0700 Subject: 7173494: some jdk tests are not run in test/Makefile In-Reply-To: <50731791.4020806@oracle.com> References: <5071D975.7080904@oracle.com> <50731113.9070400@oracle.com> <50731791.4020806@oracle.com> Message-ID: <50731D96.3040809@oracle.com> On 10/8/2012 11:12 AM, Alan Bateman wrote: > On 08/10/2012 18:44, Mandy Chung wrote: >> It's good to clean this up and the change looks fine in general. A >> couple of minor comments: >> >> jdk_management - Might be good to include java/lang/management tests >> in this target in case someone only runs one target to verify that >> area. On the other hands, they are currently covered by jdk_lang >> target and might be better to take them out from jdk_lang (maybe in >> the future). > The jdk_management target could run the java/lang/management tests too > but it would mean these tests would run twice. I have experimented > with moving these tests to test/java/lang_management (same thing for > java/lang/instrument to java/lang_instrument) but decided not to > include those changes here as it's a disruptive change. With compact > profiles [1] and future modularization then we may need to look at > this again as it would be really nice to be able to specify the test > directories to jtreg that correspond to the modules or profiles (I > think it's just a bit early to know how the tests will run). Agree and it's fine to leave it as it is. >> >> jdk_rmi target - you change "javax/rmi" to "javax/rmi/ssl". There is >> no test in the test/javax/rmi directory currently but if a new test >> (or new subdirectory) is added under test/javax/rmi, you would have >> to change the jdk_rmi target. Would it be better to keep "javax/rmi" >> as it is? > javax.rmi.CORBA has the classes for RMI-IIOP and I would expect tests > for this area to be run by a different make target, say jdk_corba. As > it happens we don't have any tests for this area in the jdk repository > so it doesn't make any difference at this time So somewhat of a > drive-by fix (again profiles and modules motivated so that "make > jdk_rmi" would run the RMI tests only). > That's right - I missed javax.rmi.CORBA package. >> >> test/sun/misc seems to belong to jdk_lang. Do you know why they are >> in jdk_other? > The tests in test/sun/misc provide very sparse coverage and are > somewhat of a mixed bag so I decided to leave them where they are. I > wouldn't object to moving them to the jdk_lang target, do you have a > strong opinion on this? Just looking at the list of tests in test/sun/misc, it seems reasonable to move them to jdk_lang so that the default jprt target will include them. This will require some work to verify. It's fine if we do it in a future cleanup. Thanks Mandy Mandy From mike.duigou at oracle.com Mon Oct 8 11:40:20 2012 From: mike.duigou at oracle.com (Mike Duigou) Date: Mon, 8 Oct 2012 11:40:20 -0700 Subject: 7173494: some jdk tests are not run in test/Makefile In-Reply-To: <5071D975.7080904@oracle.com> References: <5071D975.7080904@oracle.com> Message-ID: This looks like all good changes to me. Mike On Oct 7 2012, at 12:35 , Alan Bateman wrote: > > This one is a small clean-up of the test targets defined in jdk/test/Makefile. The union of the tests executed by each of the make targets should be the entire test suite but this isn't so, there are small number of tests that aren't run. > > I've renamed jdk_misc to jdk_other (the original name is confusing because of sun.misc) and expanded it to run additional areas that have a small number of tests. If more tests are added to these areas over time then it may make sense to add new targets in the future. > > "make jdk_jmx" now runs the JMX tests as it was confusing to have those tests split between management1 and management2. I've also renamed jdk_tools1 to jdk_jdi to make it clear that this is the JDI tests rather than tools. When Kelly originally set this up he split the NIO tests into 3 batches, I don't think this is necessary any longer (the really slow tests have been long been dialed down or changed to run much faster). > > The webrev with the proposed changes is here: > http://cr.openjdk.java.net/~alanb/7173494/webrev/ > > -Alan. From iris.clark at oracle.com Mon Oct 8 11:51:04 2012 From: iris.clark at oracle.com (Iris Clark) Date: Mon, 8 Oct 2012 11:51:04 -0700 (PDT) Subject: 7173494: some jdk tests are not run in test/Makefile In-Reply-To: <5071D975.7080904@oracle.com> References: <5071D975.7080904@oracle.com> Message-ID: <5fdd9c7a-c76f-4011-9834-4d12e33cb6a3@default> > The webrev with the proposed changes is here: > http://cr.openjdk.java.net/~alanb/7173494/webrev/ Looks like a good clean-up. iris From Alan.Bateman at oracle.com Mon Oct 8 13:58:23 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 08 Oct 2012 21:58:23 +0100 Subject: 7173494: some jdk tests are not run in test/Makefile In-Reply-To: <507308A7.8040406@oracle.com> References: <5071D975.7080904@oracle.com> <507308A7.8040406@oracle.com> Message-ID: <50733E6F.307@oracle.com> On 08/10/2012 18:08, Chris Hegarty wrote: > This update looks ok to me. > > At some point ( not asking you to do it now ) we will need to update > 7u-dev, to avoid confusion around what tests are being run in what > batches. Yes, I think this should go into jdk7u-dev too. -Alan From yumin.qi at oracle.com Mon Oct 8 14:32:22 2012 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Mon, 08 Oct 2012 14:32:22 -0700 Subject: RFR: JDK-8000332: SA ClassDump throws exception after permgen removal Message-ID: <50734666.4010405@oracle.com> Hi, all Can I have your codereview for 8000332: SA ClassDump throws exception after permgen removal Summary: In ClassWrite.writeFields(), fields count was mistakenly set to fields length which overflow the array index. Also fixed a compilation warning from 6879063 changeset. Reviewed-by: Contributed-by: yumin.qi at oracle.com http://javaweb.sfbay.sun.com/~yqi/webrev/8000332/ Thanks Yumin From serguei.spitsyn at oracle.com Mon Oct 8 16:02:07 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 08 Oct 2012 16:02:07 -0700 Subject: RFR: JDK-8000332: SA ClassDump throws exception after permgen removal In-Reply-To: <50734666.4010405@oracle.com> References: <50734666.4010405@oracle.com> Message-ID: <50735B6F.9030708@oracle.com> Hi Yumin, It looks good. Thanks, Serguei On 10/8/12 2:32 PM, yumin.qi at oracle.com wrote: > Hi, all > > Can I have your codereview for > > 8000332: SA ClassDump throws exception after permgen removal > Summary: In ClassWrite.writeFields(), fields count was mistakenly set > to fields length which overflow the array index. Also fixed a compilation > warning from 6879063 changeset. > > Reviewed-by: > Contributed-by: yumin.qi at oracle.com > > > http://javaweb.sfbay.sun.com/~yqi/webrev/8000332/ > > > Thanks > Yumin > > From yumin.qi at oracle.com Mon Oct 8 16:12:16 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Mon, 08 Oct 2012 16:12:16 -0700 Subject: RFR: JDK-8000332: SA ClassDump throws exception after permgen removal In-Reply-To: <5073512F.6000509@oracle.com> References: <50734666.4010405@oracle.com> <5073512F.6000509@oracle.com> Message-ID: <50735DD0.5040607@oracle.com> Coleen and Serguei, Thanks for your review. Thanks Yumin On 10/8/2012 3:18 PM, Coleen Phillimore wrote: > Looks good. > Thanks, > Coleen > > On 10/8/2012 5:32 PM, yumin.qi at oracle.com wrote: >> Hi, all >> >> Can I have your codereview for >> >> 8000332: SA ClassDump throws exception after permgen removal >> Summary: In ClassWrite.writeFields(), fields count was mistakenly set >> to fields length which overflow the array index. Also fixed a >> compilation >> warning from 6879063 changeset. >> >> Reviewed-by: >> Contributed-by: yumin.qi at oracle.com >> >> >> http://javaweb.sfbay.sun.com/~yqi/webrev/8000332/ >> >> >> Thanks >> Yumin >> >> From yumin.qi at oracle.com Mon Oct 8 16:27:04 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Mon, 08 Oct 2012 16:27:04 -0700 Subject: RFR: 8000412: Clean SA code on ia64 Message-ID: <50736148.5060002@oracle.com> Hi, All Can I have your codereview for 8000412 : Clean SA code on ia64 Summary: Clean up IA64 code in SA since SA does no t support this cpu architecture. Reviewed-by: Contributed-by: yumin.qi at oracle.com,staffan.larsen at oracle.com http://cr.openjdk.java.net/~minqi/8000412/ Thanks Yumin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121008/824a7336/attachment.html From coleen.phillimore at oracle.com Mon Oct 8 16:56:34 2012 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Mon, 08 Oct 2012 23:56:34 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7170638: Use DTRACE_PROBE[N] in JNI Set and SetStatic Field. Message-ID: <20121008235644.596D94722E@hg.openjdk.java.net> Changeset: 75982791ddb6 Author: coleenp Date: 2012-10-08 09:18 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/75982791ddb6 7170638: Use DTRACE_PROBE[N] in JNI Set and SetStatic Field. Summary: Don't use HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N directly. Reviewed-by: coleenp, kamg, dholmes, sspitsyn Contributed-by: Mark Wielaard ! make/bsd/makefiles/buildtree.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/dtrace.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/buildtree.make ! src/share/vm/prims/jni.cpp ! src/share/vm/utilities/dtrace.hpp From yumin.qi at oracle.com Mon Oct 8 18:59:37 2012 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Tue, 09 Oct 2012 01:59:37 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20121009015944.1DFAF47231@hg.openjdk.java.net> Changeset: 7a40901e0d5c Author: minqi Date: 2012-10-08 16:48 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7a40901e0d5c 8000332: SA ClassDump throws exception after permgen removal Summary: In ClassWrite.writeFields(), fields count was mistakenly set to fields length which overflow the array index. Also removed a file which is leftover from 6879063 changeset. Reviewed-by: coleenp, sspitsyn Contributed-by: yumin.qi at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! agent/src/share/native/sadis.c Changeset: 0e8ca886e4e1 Author: minqi Date: 2012-10-08 16:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0e8ca886e4e1 Merge From david.holmes at oracle.com Mon Oct 8 20:38:28 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 09 Oct 2012 13:38:28 +1000 Subject: RFR: JDK-8000332: SA ClassDump throws exception after permgen removal In-Reply-To: <50734666.4010405@oracle.com> References: <50734666.4010405@oracle.com> Message-ID: <50739C34.10208@oracle.com> Hi Yumin, On 9/10/2012 7:32 AM, yumin.qi at oracle.com wrote: > Hi, all > > Can I have your codereview for > > 8000332: SA ClassDump throws exception after permgen removal > Summary: In ClassWrite.writeFields(), fields count was mistakenly set to > fields length which overflow the array index. Also fixed a compilation > warning from 6879063 changeset. > > Reviewed-by: > Contributed-by: yumin.qi at oracle.com > > > http://javaweb.sfbay.sun.com/~yqi/webrev/8000332/ > Please post a webrev that can be accessed by everyone. Thanks, David > Thanks > Yumin > > From rickard.backman at oracle.com Mon Oct 8 23:00:03 2012 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Tue, 9 Oct 2012 08:00:03 +0200 Subject: RFR: 8000412: Clean SA code on ia64 In-Reply-To: <50736148.5060002@oracle.com> References: <50736148.5060002@oracle.com> Message-ID: <3E061272-FEBC-4C21-906A-53E6BC99E484@oracle.com> Looks good, ship it. /R On Oct 9, 2012, at 1:27 AM, Yumin Qi wrote: > Hi, All > > Can I have your codereview for > > 8000412 > : Clean SA code on ia64 > Summary: Clean up IA64 code in SA since SA does no t support this cpu architecture. > > Reviewed-by: > Contributed-by: > yumin.qi at oracle.com,staffan.larsen at oracle.com > > > > http://cr.openjdk.java.net/~minqi/8000412/ > > > Thanks > Yumin > > From rickard.backman at oracle.com Mon Oct 8 23:34:51 2012 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Tue, 9 Oct 2012 08:34:51 +0200 Subject: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval In-Reply-To: <944656E5-9306-411E-A916-4DDC95E819D4@oracle.com> References: <944656E5-9306-411E-A916-4DDC95E819D4@oracle.com> Message-ID: <892BC3F6-C669-41E9-9536-CD5879309480@oracle.com> Trying again, can I have a couple of reviews, please? /R On Oct 4, 2012, at 3:01 PM, Rickard B?ckman wrote: > Hi all, > > can I please have a couple of reviews on the following change: > > http://cr.openjdk.java.net/~rbackman/7127792/ > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127792 > > In short the purpose is to enable tasks to change the interval they are executed in. We > would also like to be able to add (and remove) tasks after the WatcherThread has started. > > Thanks > /R From rickard.backman at oracle.com Tue Oct 9 00:41:04 2012 From: rickard.backman at oracle.com (rickard.backman at oracle.com) Date: Tue, 09 Oct 2012 07:41:04 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 22 new changesets Message-ID: <20121009074203.779DD47238@hg.openjdk.java.net> Changeset: 988bf00cc564 Author: johnc Date: 2012-09-27 15:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/988bf00cc564 7200261: G1: Liveness counting inconsistencies during marking verification Summary: The clipping code in the routine that sets the bits for a range of cards, in the liveness accounting verification code was incorrect. It set all the bits in the card bitmap from the given starting index which would lead to spurious marking verification failures. Reviewed-by: brutisso, jwilhelm, jmasa ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp Changeset: 5c8fbbfed964 Author: stefank Date: 2012-10-01 11:07 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5c8fbbfed964 Merge - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java Changeset: 85f1cded9793 Author: stefank Date: 2012-09-28 15:34 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/85f1cded9793 8000230: Change os::print_location to be more descriptive when a location is pointing into an object Reviewed-by: mgerdin, twisti ! src/share/vm/runtime/os.cpp Changeset: 86af3dacab81 Author: stefank Date: 2012-10-01 13:29 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/86af3dacab81 8000227: [obj|type]ArrayKlass::oop_print_on prints one line to tty instead of the provided output stream Reviewed-by: brutisso, sla, jmasa, coleenp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.cpp Changeset: 87ac5c0a404d Author: stefank Date: 2012-10-01 13:29 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/87ac5c0a404d 8000228: Missing call to cr() when printing entry_point in nmethod, in os::print_location Reviewed-by: brutisso, neliasso ! src/share/vm/runtime/os.cpp Changeset: f81a7c0c618d Author: jmasa Date: 2012-10-03 08:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f81a7c0c618d 7199349: NPG: PS: Crash seen in jprt Reviewed-by: johnc ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.hpp ! src/share/vm/runtime/globals.hpp Changeset: 22b8d3d181d9 Author: jwilhelm Date: 2012-10-03 20:31 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/22b8d3d181d9 8000351: Tenuring threshold should be unsigned Summary: Change the flags and variables related to tenuring threshold to be unsigned Reviewed-by: jmasa, johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/shared/ageTable.cpp ! src/share/vm/gc_implementation/shared/ageTable.hpp ! src/share/vm/gc_implementation/shared/gcAdaptivePolicyCounters.hpp ! src/share/vm/memory/defNewGeneration.hpp ! src/share/vm/memory/threadLocalAllocBuffer.hpp ! src/share/vm/oops/markOop.hpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/biasedLocking.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 2e6857353b2c Author: johnc Date: 2012-10-04 10:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2e6857353b2c 8000311: G1: ParallelGCThreads==0 broken Summary: Divide by zero error, if ParallelGCThreads is 0, when adjusting the PLAB size. Reviewed-by: jmasa, jcoomes ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/shared/parGCAllocBuffer.cpp ! src/share/vm/gc_implementation/shared/parGCAllocBuffer.hpp Changeset: 097d78aaf2b5 Author: jmasa Date: 2012-10-04 10:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/097d78aaf2b5 7198873: NPG: VM Does not unload classes with UseConcMarkSweepGC Reviewed-by: johnc, mgerdin, jwilhelm ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp Changeset: ca70b919819f Author: jmasa Date: 2012-10-04 14:01 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/ca70b919819f Merge Changeset: f6b0eb4e44cf Author: twisti Date: 2012-10-01 14:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f6b0eb4e44cf 7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path Reviewed-by: jrose, kvn ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/ci/ciClassList.hpp + src/share/vm/ci/ciMethodType.hpp ! src/share/vm/ci/ciObject.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciSignature.cpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/ci/ciStreams.cpp ! src/share/vm/ci/ciStreams.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/linkResolver.hpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp Changeset: 859c45fb8cea Author: kvn Date: 2012-10-02 12:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/859c45fb8cea 7201026: add vector for shift count Summary: Add generation of vectors for scalar shift count. Reviewed-by: roland, twisti, dlong ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/vectornode.cpp ! src/share/vm/opto/vectornode.hpp ! test/compiler/7200264/Test7200264.sh Changeset: f13867c41f73 Author: kvn Date: 2012-10-02 14:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f13867c41f73 7199742: A lot of C2 OSR compilations of the same method's bci Summary: Don't clone head of OSR loop. Reviewed-by: jrose, twisti ! src/share/vm/ci/ciTypeFlow.cpp ! src/share/vm/opto/parse1.cpp + test/compiler/7199742/Test7199742.java Changeset: bf2edd3c9b0f Author: neliasso Date: 2012-10-04 06:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bf2edd3c9b0f 8000102: Resolve include conflicts Summary: Removing include of c1/c1_runtime.hpp and opto/runtime.hpp from all os-files. Reviewed-by: kvn Contributed-by: nils.eliasson at oracle.com ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp Changeset: 685457683e86 Author: kvn Date: 2012-10-05 10:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/685457683e86 Merge Changeset: 2dd08e86a2bf Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2dd08e86a2bf Added tag jdk8-b58 for changeset 6bb378c50828 ! .hgtags Changeset: 8a1a6b9b4f20 Author: katleman Date: 2012-10-03 15:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8a1a6b9b4f20 Merge ! .hgtags - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java Changeset: a3fd4914ac81 Author: katleman Date: 2012-10-04 14:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/a3fd4914ac81 Added tag jdk8-b59 for changeset 8a1a6b9b4f20 ! .hgtags Changeset: 1cc7a2a11d00 Author: amurillo Date: 2012-10-05 13:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1cc7a2a11d00 Merge Changeset: 3cfd05b2219a Author: amurillo Date: 2012-10-05 13:28 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3cfd05b2219a Added tag hs25-b04 for changeset 1cc7a2a11d00 ! .hgtags Changeset: 81e878c53615 Author: amurillo Date: 2012-10-05 13:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/81e878c53615 8000498: new hotspot build - hs25-b05 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 6e5a59a8e4a7 Author: rbackman Date: 2012-10-09 07:41 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/6e5a59a8e4a7 Merge ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp From david.holmes at oracle.com Tue Oct 9 00:46:41 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 09 Oct 2012 17:46:41 +1000 Subject: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval In-Reply-To: <892BC3F6-C669-41E9-9536-CD5879309480@oracle.com> References: <944656E5-9306-411E-A916-4DDC95E819D4@oracle.com> <892BC3F6-C669-41E9-9536-CD5879309480@oracle.com> Message-ID: <5073D661.1080908@oracle.com> Sorry Rickard, missed the original RFR :) So to be clear here the synopsis concerns changing the period, while the mechanism implemented is for a more general dynamic disenroll / enroll. So changing a period is effected by removing a task and then adding it with the new period. And for anyone not reading the fine-print when you dynamically enroll a task its first firing is somewhat arbitrary - somewhere between the time of enrollment and that time plus its period. src/share/vm/runtime/thread.hpp Can you add a comment: static void stop(); + // Only allow start once the VM is sufficiently initialized + // Otherwise the first task to enroll will trigger the start + static void make_startable(); --- src/share/vm/runtime/thread.cpp We have a bit of type mixing here: - size_t time_to_wait - jlong time_slept - int remaining = time_to_wait I don't understand why Task is using size_t for time intervals. If you make "remaining" a size_t then it will cause issues when you pass it to wait. But I would expect the initialization of "remaining" to cause an unsigned-to-signed conversion warning, so perhaps an explicit cast to silence that. 1203 bool status = PeriodicTask_lock->wait(Mutex::_no_safepoint_check_flag, remaining); 1204 if (status || _should_terminate) { 1205 break; 1206 } Can you rename status to timedout to make the logic more obvious. Also note that you will potentially return with time_slept still at zero, even though you may have slept for an arbitrary amount of time. That seems wrong as zero will then be passed to "tick". 1208 // spurious wakeup of some kind This comment is no longer accurate as you may have been woken up due to a change in the task list, I suggest: // Change to task list or spurious wakeup of some kind 1213 remaining = PeriodicTask::time_to_wait(); 1214 if (remaining == 0) { 1215 continue; 1216 } Can you insert a comment before continue: // Last task was just disenrolled so loop around and wait until // another task gets enrolled continue; 1218 remaining -= time_slept; Again type mixing: subtracting a long from an int. Again a potential warning to get rid of. Also in a long running VM perhaps there have been no periodic tasks for many days and then one turns up. The subtraction could wrap and cause remaining to remain positive. I know you've now documented the uncertainty in the first fire time but this seems somewhat too random. Let's see what others think. :) 1329 PeriodicTask_lock->notify_all(); There is only one thread that waits so notify() will suffice. Thanks, David On 9/10/2012 4:34 PM, Rickard B?ckman wrote: > Trying again, > > can I have a couple of reviews, please? > > /R > > On Oct 4, 2012, at 3:01 PM, Rickard B?ckman wrote: > >> Hi all, >> >> can I please have a couple of reviews on the following change: >> >> http://cr.openjdk.java.net/~rbackman/7127792/ >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127792 >> >> In short the purpose is to enable tasks to change the interval they are executed in. We >> would also like to be able to add (and remove) tasks after the WatcherThread has started. >> >> Thanks >> /R > From rickard.backman at oracle.com Tue Oct 9 02:36:29 2012 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Tue, 9 Oct 2012 11:36:29 +0200 Subject: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval In-Reply-To: <5073D661.1080908@oracle.com> References: <944656E5-9306-411E-A916-4DDC95E819D4@oracle.com> <892BC3F6-C669-41E9-9536-CD5879309480@oracle.com> <5073D661.1080908@oracle.com> Message-ID: David, thanks for your reply! I've changed the code according to the suggestions, I've also changed the types in PeriodicTask from being a size_t to being a jint (see updated webrev for details). To prevent the waiting for very long time (which could overflow, etc) when we don't have any active task, I added an extra if so that if we are waiting while no tasks are available, we reset the time_before_wait and consider time_slept to be zero after sleeping. That means the first task added will always sleep for the period requested. Updated webrev: http://cr.openjdk.java.net/~rbackman/7127792.1/ Thanks /R On Oct 9, 2012, at 9:46 AM, David Holmes wrote: > Sorry Rickard, missed the original RFR :) > > So to be clear here the synopsis concerns changing the period, while the mechanism implemented is for a more general dynamic disenroll / enroll. So changing a period is effected by removing a task and then adding it with the new period. > > And for anyone not reading the fine-print when you dynamically enroll a task its first firing is somewhat arbitrary - somewhere between the time of enrollment and that time plus its period. > > src/share/vm/runtime/thread.hpp > > Can you add a comment: > > static void stop(); > + // Only allow start once the VM is sufficiently initialized > + // Otherwise the first task to enroll will trigger the start > + static void make_startable(); > > --- > > src/share/vm/runtime/thread.cpp > > We have a bit of type mixing here: > > - size_t time_to_wait > - jlong time_slept > - int remaining = time_to_wait > > I don't understand why Task is using size_t for time intervals. If you make "remaining" a size_t then it will cause issues when you pass it to wait. But I would expect the initialization of "remaining" to cause an unsigned-to-signed conversion warning, so perhaps an explicit cast to silence that. > > 1203 bool status = PeriodicTask_lock->wait(Mutex::_no_safepoint_check_flag, remaining); > 1204 if (status || _should_terminate) { > 1205 break; > 1206 } > > Can you rename status to timedout to make the logic more obvious. Also note that you will potentially return with time_slept still at zero, even though you may have slept for an arbitrary amount of time. That seems wrong as zero will then be passed to "tick". > > 1208 // spurious wakeup of some kind > > This comment is no longer accurate as you may have been woken up due to a change in the task list, I suggest: > > // Change to task list or spurious wakeup of some kind > > 1213 remaining = PeriodicTask::time_to_wait(); > 1214 if (remaining == 0) { > 1215 continue; > 1216 } > > Can you insert a comment before continue: > > // Last task was just disenrolled so loop around and wait until > // another task gets enrolled > continue; > > > 1218 remaining -= time_slept; > > Again type mixing: subtracting a long from an int. Again a potential warning to get rid of. > > Also in a long running VM perhaps there have been no periodic tasks for many days and then one turns up. The subtraction could wrap and cause remaining to remain positive. I know you've now documented the uncertainty in the first fire time but this seems somewhat too random. Let's see what others think. :) > > > 1329 PeriodicTask_lock->notify_all(); > > There is only one thread that waits so notify() will suffice. > > Thanks, > David > > On 9/10/2012 4:34 PM, Rickard B?ckman wrote: >> Trying again, >> >> can I have a couple of reviews, please? >> >> /R >> >> On Oct 4, 2012, at 3:01 PM, Rickard B?ckman wrote: >> >>> Hi all, >>> >>> can I please have a couple of reviews on the following change: >>> >>> http://cr.openjdk.java.net/~rbackman/7127792/ >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127792 >>> >>> In short the purpose is to enable tasks to change the interval they are executed in. We >>> would also like to be able to add (and remove) tasks after the WatcherThread has started. >>> >>> Thanks >>> /R >> From david.holmes at oracle.com Tue Oct 9 04:18:55 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 09 Oct 2012 21:18:55 +1000 Subject: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval In-Reply-To: References: <944656E5-9306-411E-A916-4DDC95E819D4@oracle.com> <892BC3F6-C669-41E9-9536-CD5879309480@oracle.com> <5073D661.1080908@oracle.com> Message-ID: <5074081F.1040807@oracle.com> On 9/10/2012 7:36 PM, Rickard B?ckman wrote: > David, > > thanks for your reply! > I've changed the code according to the suggestions, I've also changed the types in PeriodicTask from being a size_t to being a > jint (see updated webrev for details). But now the type changes have been pushed out to the task creators. Most task creations pass an int already but BiasedLocking uses a size_t. Just shows how messed up the typing was to begin with. Minor nit: should be an int rather than jint as these are not Java types. > To prevent the waiting for very long time (which could overflow, etc) when we don't have any active task, I added an extra if > so that if we are waiting while no tasks are available, we reset the time_before_wait and consider time_slept to be zero after sleeping. > That means the first task added will always sleep for the period requested. Those semantics seem reasonable. The only thing that concerns me here is the affect of calling real_time_tick(0). I can't quite tell what the profiling code does. David ----- > Updated webrev: > http://cr.openjdk.java.net/~rbackman/7127792.1/ > > Thanks > /R > > On Oct 9, 2012, at 9:46 AM, David Holmes wrote: > >> Sorry Rickard, missed the original RFR :) >> >> So to be clear here the synopsis concerns changing the period, while the mechanism implemented is for a more general dynamic disenroll / enroll. So changing a period is effected by removing a task and then adding it with the new period. >> >> And for anyone not reading the fine-print when you dynamically enroll a task its first firing is somewhat arbitrary - somewhere between the time of enrollment and that time plus its period. >> >> src/share/vm/runtime/thread.hpp >> >> Can you add a comment: >> >> static void stop(); >> + // Only allow start once the VM is sufficiently initialized >> + // Otherwise the first task to enroll will trigger the start >> + static void make_startable(); >> >> --- >> >> src/share/vm/runtime/thread.cpp >> >> We have a bit of type mixing here: >> >> - size_t time_to_wait >> - jlong time_slept >> - int remaining = time_to_wait >> >> I don't understand why Task is using size_t for time intervals. If you make "remaining" a size_t then it will cause issues when you pass it to wait. But I would expect the initialization of "remaining" to cause an unsigned-to-signed conversion warning, so perhaps an explicit cast to silence that. >> >> 1203 bool status = PeriodicTask_lock->wait(Mutex::_no_safepoint_check_flag, remaining); >> 1204 if (status || _should_terminate) { >> 1205 break; >> 1206 } >> >> Can you rename status to timedout to make the logic more obvious. Also note that you will potentially return with time_slept still at zero, even though you may have slept for an arbitrary amount of time. That seems wrong as zero will then be passed to "tick". >> >> 1208 // spurious wakeup of some kind >> >> This comment is no longer accurate as you may have been woken up due to a change in the task list, I suggest: >> >> // Change to task list or spurious wakeup of some kind >> >> 1213 remaining = PeriodicTask::time_to_wait(); >> 1214 if (remaining == 0) { >> 1215 continue; >> 1216 } >> >> Can you insert a comment before continue: >> >> // Last task was just disenrolled so loop around and wait until >> // another task gets enrolled >> continue; >> >> >> 1218 remaining -= time_slept; >> >> Again type mixing: subtracting a long from an int. Again a potential warning to get rid of. >> >> Also in a long running VM perhaps there have been no periodic tasks for many days and then one turns up. The subtraction could wrap and cause remaining to remain positive. I know you've now documented the uncertainty in the first fire time but this seems somewhat too random. Let's see what others think. :) >> >> >> 1329 PeriodicTask_lock->notify_all(); >> >> There is only one thread that waits so notify() will suffice. >> >> Thanks, >> David >> >> On 9/10/2012 4:34 PM, Rickard B?ckman wrote: >>> Trying again, >>> >>> can I have a couple of reviews, please? >>> >>> /R >>> >>> On Oct 4, 2012, at 3:01 PM, Rickard B?ckman wrote: >>> >>>> Hi all, >>>> >>>> can I please have a couple of reviews on the following change: >>>> >>>> http://cr.openjdk.java.net/~rbackman/7127792/ >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127792 >>>> >>>> In short the purpose is to enable tasks to change the interval they are executed in. We >>>> would also like to be able to add (and remove) tasks after the WatcherThread has started. >>>> >>>> Thanks >>>> /R >>> > From rickard.backman at oracle.com Tue Oct 9 04:42:01 2012 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Tue, 9 Oct 2012 13:42:01 +0200 Subject: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval In-Reply-To: <5074081F.1040807@oracle.com> References: <944656E5-9306-411E-A916-4DDC95E819D4@oracle.com> <892BC3F6-C669-41E9-9536-CD5879309480@oracle.com> <5073D661.1080908@oracle.com> <5074081F.1040807@oracle.com> Message-ID: David, see inline. On Oct 9, 2012, at 1:18 PM, David Holmes wrote: > On 9/10/2012 7:36 PM, Rickard B?ckman wrote: >> David, >> >> thanks for your reply! >> I've changed the code according to the suggestions, I've also changed the types in PeriodicTask from being a size_t to being a >> jint (see updated webrev for details). > > But now the type changes have been pushed out to the task creators. Most task creations pass an int already but BiasedLocking uses a size_t. Just shows how messed up the typing was to begin with. Agreed. Two ways of solving it, 1) change the callers to use an int. 2) Do the cast in the constructor (should be safe since we check the possible interval). > > Minor nit: should be an int rather than jint as these are not Java types. Will fix. > >> To prevent the waiting for very long time (which could overflow, etc) when we don't have any active task, I added an extra if >> so that if we are waiting while no tasks are available, we reset the time_before_wait and consider time_slept to be zero after sleeping. >> That means the first task added will always sleep for the period requested. > > Those semantics seem reasonable. > > The only thing that concerns me here is the affect of calling real_time_tick(0). I can't quite tell what the profiling code does. I could avoid calling that if time_slept = 0 Thanks /R > > David > ----- > >> Updated webrev: >> http://cr.openjdk.java.net/~rbackman/7127792.1/ >> >> Thanks >> /R >> >> On Oct 9, 2012, at 9:46 AM, David Holmes wrote: >> >>> Sorry Rickard, missed the original RFR :) >>> >>> So to be clear here the synopsis concerns changing the period, while the mechanism implemented is for a more general dynamic disenroll / enroll. So changing a period is effected by removing a task and then adding it with the new period. >>> >>> And for anyone not reading the fine-print when you dynamically enroll a task its first firing is somewhat arbitrary - somewhere between the time of enrollment and that time plus its period. >>> >>> src/share/vm/runtime/thread.hpp >>> >>> Can you add a comment: >>> >>> static void stop(); >>> + // Only allow start once the VM is sufficiently initialized >>> + // Otherwise the first task to enroll will trigger the start >>> + static void make_startable(); >>> >>> --- >>> >>> src/share/vm/runtime/thread.cpp >>> >>> We have a bit of type mixing here: >>> >>> - size_t time_to_wait >>> - jlong time_slept >>> - int remaining = time_to_wait >>> >>> I don't understand why Task is using size_t for time intervals. If you make "remaining" a size_t then it will cause issues when you pass it to wait. But I would expect the initialization of "remaining" to cause an unsigned-to-signed conversion warning, so perhaps an explicit cast to silence that. >>> >>> 1203 bool status = PeriodicTask_lock->wait(Mutex::_no_safepoint_check_flag, remaining); >>> 1204 if (status || _should_terminate) { >>> 1205 break; >>> 1206 } >>> >>> Can you rename status to timedout to make the logic more obvious. Also note that you will potentially return with time_slept still at zero, even though you may have slept for an arbitrary amount of time. That seems wrong as zero will then be passed to "tick". >>> >>> 1208 // spurious wakeup of some kind >>> >>> This comment is no longer accurate as you may have been woken up due to a change in the task list, I suggest: >>> >>> // Change to task list or spurious wakeup of some kind >>> >>> 1213 remaining = PeriodicTask::time_to_wait(); >>> 1214 if (remaining == 0) { >>> 1215 continue; >>> 1216 } >>> >>> Can you insert a comment before continue: >>> >>> // Last task was just disenrolled so loop around and wait until >>> // another task gets enrolled >>> continue; >>> >>> >>> 1218 remaining -= time_slept; >>> >>> Again type mixing: subtracting a long from an int. Again a potential warning to get rid of. >>> >>> Also in a long running VM perhaps there have been no periodic tasks for many days and then one turns up. The subtraction could wrap and cause remaining to remain positive. I know you've now documented the uncertainty in the first fire time but this seems somewhat too random. Let's see what others think. :) >>> >>> >>> 1329 PeriodicTask_lock->notify_all(); >>> >>> There is only one thread that waits so notify() will suffice. >>> >>> Thanks, >>> David >>> >>> On 9/10/2012 4:34 PM, Rickard B?ckman wrote: >>>> Trying again, >>>> >>>> can I have a couple of reviews, please? >>>> >>>> /R >>>> >>>> On Oct 4, 2012, at 3:01 PM, Rickard B?ckman wrote: >>>> >>>>> Hi all, >>>>> >>>>> can I please have a couple of reviews on the following change: >>>>> >>>>> http://cr.openjdk.java.net/~rbackman/7127792/ >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127792 >>>>> >>>>> In short the purpose is to enable tasks to change the interval they are executed in. We >>>>> would also like to be able to add (and remove) tasks after the WatcherThread has started. >>>>> >>>>> Thanks >>>>> /R >>>> >> From david.holmes at oracle.com Tue Oct 9 05:01:20 2012 From: david.holmes at oracle.com (David Holmes) Date: Tue, 09 Oct 2012 22:01:20 +1000 Subject: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval In-Reply-To: References: <944656E5-9306-411E-A916-4DDC95E819D4@oracle.com> <892BC3F6-C669-41E9-9536-CD5879309480@oracle.com> <5073D661.1080908@oracle.com> <5074081F.1040807@oracle.com> Message-ID: <50741210.7080800@oracle.com> On 9/10/2012 9:42 PM, Rickard B?ckman wrote: > David, > see inline. > > On Oct 9, 2012, at 1:18 PM, David Holmes wrote: > >> On 9/10/2012 7:36 PM, Rickard B?ckman wrote: >>> David, >>> >>> thanks for your reply! >>> I've changed the code according to the suggestions, I've also changed the types in PeriodicTask from being a size_t to being a >>> jint (see updated webrev for details). >> >> But now the type changes have been pushed out to the task creators. Most task creations pass an int already but BiasedLocking uses a size_t. Just shows how messed up the typing was to begin with. > > Agreed. Two ways of solving it, 1) change the callers to use an int. 2) Do the cast in the constructor (should be safe since we check the possible interval). int -> size_t shouldn't cause a warning so callers currently passing int are ok. So keeping it as size_t in constructor arg and casting to int before storing internally seems okay. >> >> Minor nit: should be an int rather than jint as these are not Java types. > > Will fix. > >> >>> To prevent the waiting for very long time (which could overflow, etc) when we don't have any active task, I added an extra if >>> so that if we are waiting while no tasks are available, we reset the time_before_wait and consider time_slept to be zero after sleeping. >>> That means the first task added will always sleep for the period requested. >> >> Those semantics seem reasonable. >> >> The only thing that concerns me here is the affect of calling real_time_tick(0). I can't quite tell what the profiling code does. > > I could avoid calling that if time_slept = 0 Ok. You could skip real_time_tick altogether on zero. I'm generally okay with the approach being taken here, but the changes are disruptive enough that I can't see for sure that existing tasks will be unaffected. I guess time will tell. And let's see what others might spot. Thanks, David (signing off for the night) > Thanks > /R > >> >> David >> ----- >> >>> Updated webrev: >>> http://cr.openjdk.java.net/~rbackman/7127792.1/ >>> >>> Thanks >>> /R >>> >>> On Oct 9, 2012, at 9:46 AM, David Holmes wrote: >>> >>>> Sorry Rickard, missed the original RFR :) >>>> >>>> So to be clear here the synopsis concerns changing the period, while the mechanism implemented is for a more general dynamic disenroll / enroll. So changing a period is effected by removing a task and then adding it with the new period. >>>> >>>> And for anyone not reading the fine-print when you dynamically enroll a task its first firing is somewhat arbitrary - somewhere between the time of enrollment and that time plus its period. >>>> >>>> src/share/vm/runtime/thread.hpp >>>> >>>> Can you add a comment: >>>> >>>> static void stop(); >>>> + // Only allow start once the VM is sufficiently initialized >>>> + // Otherwise the first task to enroll will trigger the start >>>> + static void make_startable(); >>>> >>>> --- >>>> >>>> src/share/vm/runtime/thread.cpp >>>> >>>> We have a bit of type mixing here: >>>> >>>> - size_t time_to_wait >>>> - jlong time_slept >>>> - int remaining = time_to_wait >>>> >>>> I don't understand why Task is using size_t for time intervals. If you make "remaining" a size_t then it will cause issues when you pass it to wait. But I would expect the initialization of "remaining" to cause an unsigned-to-signed conversion warning, so perhaps an explicit cast to silence that. >>>> >>>> 1203 bool status = PeriodicTask_lock->wait(Mutex::_no_safepoint_check_flag, remaining); >>>> 1204 if (status || _should_terminate) { >>>> 1205 break; >>>> 1206 } >>>> >>>> Can you rename status to timedout to make the logic more obvious. Also note that you will potentially return with time_slept still at zero, even though you may have slept for an arbitrary amount of time. That seems wrong as zero will then be passed to "tick". >>>> >>>> 1208 // spurious wakeup of some kind >>>> >>>> This comment is no longer accurate as you may have been woken up due to a change in the task list, I suggest: >>>> >>>> // Change to task list or spurious wakeup of some kind >>>> >>>> 1213 remaining = PeriodicTask::time_to_wait(); >>>> 1214 if (remaining == 0) { >>>> 1215 continue; >>>> 1216 } >>>> >>>> Can you insert a comment before continue: >>>> >>>> // Last task was just disenrolled so loop around and wait until >>>> // another task gets enrolled >>>> continue; >>>> >>>> >>>> 1218 remaining -= time_slept; >>>> >>>> Again type mixing: subtracting a long from an int. Again a potential warning to get rid of. >>>> >>>> Also in a long running VM perhaps there have been no periodic tasks for many days and then one turns up. The subtraction could wrap and cause remaining to remain positive. I know you've now documented the uncertainty in the first fire time but this seems somewhat too random. Let's see what others think. :) >>>> >>>> >>>> 1329 PeriodicTask_lock->notify_all(); >>>> >>>> There is only one thread that waits so notify() will suffice. >>>> >>>> Thanks, >>>> David >>>> >>>> On 9/10/2012 4:34 PM, Rickard B?ckman wrote: >>>>> Trying again, >>>>> >>>>> can I have a couple of reviews, please? >>>>> >>>>> /R >>>>> >>>>> On Oct 4, 2012, at 3:01 PM, Rickard B?ckman wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> can I please have a couple of reviews on the following change: >>>>>> >>>>>> http://cr.openjdk.java.net/~rbackman/7127792/ >>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127792 >>>>>> >>>>>> In short the purpose is to enable tasks to change the interval they are executed in. We >>>>>> would also like to be able to add (and remove) tasks after the WatcherThread has started. >>>>>> >>>>>> Thanks >>>>>> /R >>>>> >>> > From sean.coffey at oracle.com Tue Oct 9 04:47:42 2012 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Tue, 09 Oct 2012 11:47:42 +0000 Subject: hg: jdk8/tl/jdk: 7196533: TimeZone.getDefault() slow due to synchronization bottleneck Message-ID: <20121009114834.DBD304723C@hg.openjdk.java.net> Changeset: fecba6a8b78e Author: coffeys Date: 2012-10-09 12:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fecba6a8b78e 7196533: TimeZone.getDefault() slow due to synchronization bottleneck Reviewed-by: okutsu ! src/share/classes/java/util/TimeZone.java From alan.bateman at oracle.com Tue Oct 9 05:25:59 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 09 Oct 2012 12:25:59 +0000 Subject: hg: jdk8/tl: 7173494: some jdk tests are not run in test/Makefile Message-ID: <20121009122559.9D6B747240@hg.openjdk.java.net> Changeset: 4bde5640fb36 Author: alanb Date: 2012-10-09 13:25 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4bde5640fb36 7173494: some jdk tests are not run in test/Makefile Reviewed-by: chegar, mchung, mduigou, iris ! make/jprt.properties ! test/Makefile From alan.bateman at oracle.com Tue Oct 9 05:28:29 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Tue, 09 Oct 2012 12:28:29 +0000 Subject: hg: jdk8/tl/jdk: 7173494: some jdk tests are not run in test/Makefile Message-ID: <20121009122913.280C647241@hg.openjdk.java.net> Changeset: 3b79177ebfef Author: alanb Date: 2012-10-09 13:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b79177ebfef 7173494: some jdk tests are not run in test/Makefile Reviewed-by: chegar, mchung, mduigou, iris ! make/jprt.properties ! test/Makefile ! test/ProblemList.txt From lance.andersen at oracle.com Tue Oct 9 05:58:59 2012 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Tue, 09 Oct 2012 12:58:59 +0000 Subject: hg: jdk8/tl/jdk: 7197395: Add @Deprecated to all deprecated methods to eliminate compiler warnings in JDBC Message-ID: <20121009125922.A5D8F47243@hg.openjdk.java.net> Changeset: 036c55976cef Author: lancea Date: 2012-10-09 08:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/036c55976cef 7197395: Add @Deprecated to all deprecated methods to eliminate compiler warnings in JDBC Reviewed-by: alanb, smarks ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/SyncResolverImpl.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/sql/Date.java ! src/share/classes/java/sql/DriverManager.java ! src/share/classes/java/sql/PreparedStatement.java ! src/share/classes/java/sql/ResultSet.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java From rickard.backman at oracle.com Tue Oct 9 06:00:23 2012 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Tue, 9 Oct 2012 15:00:23 +0200 Subject: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval In-Reply-To: <50741210.7080800@oracle.com> References: <944656E5-9306-411E-A916-4DDC95E819D4@oracle.com> <892BC3F6-C669-41E9-9536-CD5879309480@oracle.com> <5073D661.1080908@oracle.com> <5074081F.1040807@oracle.com> <50741210.7080800@oracle.com> Message-ID: <86F37B4C-6211-47BE-ACB8-F6FC5FEAD16A@oracle.com> David, thanks for your review! /R On Oct 9, 2012, at 2:01 PM, David Holmes wrote: > On 9/10/2012 9:42 PM, Rickard B?ckman wrote: >> David, >> see inline. >> >> On Oct 9, 2012, at 1:18 PM, David Holmes wrote: >> >>> On 9/10/2012 7:36 PM, Rickard B?ckman wrote: >>>> David, >>>> >>>> thanks for your reply! >>>> I've changed the code according to the suggestions, I've also changed the types in PeriodicTask from being a size_t to being a >>>> jint (see updated webrev for details). >>> >>> But now the type changes have been pushed out to the task creators. Most task creations pass an int already but BiasedLocking uses a size_t. Just shows how messed up the typing was to begin with. >> >> Agreed. Two ways of solving it, 1) change the callers to use an int. 2) Do the cast in the constructor (should be safe since we check the possible interval). > > int -> size_t shouldn't cause a warning so callers currently passing int are ok. So keeping it as size_t in constructor arg and casting to int before storing internally seems okay. > >>> >>> Minor nit: should be an int rather than jint as these are not Java types. >> >> Will fix. >> >>> >>>> To prevent the waiting for very long time (which could overflow, etc) when we don't have any active task, I added an extra if >>>> so that if we are waiting while no tasks are available, we reset the time_before_wait and consider time_slept to be zero after sleeping. >>>> That means the first task added will always sleep for the period requested. >>> >>> Those semantics seem reasonable. >>> >>> The only thing that concerns me here is the affect of calling real_time_tick(0). I can't quite tell what the profiling code does. >> >> I could avoid calling that if time_slept = 0 > > Ok. You could skip real_time_tick altogether on zero. > > I'm generally okay with the approach being taken here, but the changes are disruptive enough that I can't see for sure that existing tasks will be unaffected. I guess time will tell. And let's see what others might spot. > > Thanks, > David (signing off for the night) > >> Thanks >> /R >> >>> >>> David >>> ----- >>> >>>> Updated webrev: >>>> http://cr.openjdk.java.net/~rbackman/7127792.1/ >>>> >>>> Thanks >>>> /R >>>> >>>> On Oct 9, 2012, at 9:46 AM, David Holmes wrote: >>>> >>>>> Sorry Rickard, missed the original RFR :) >>>>> >>>>> So to be clear here the synopsis concerns changing the period, while the mechanism implemented is for a more general dynamic disenroll / enroll. So changing a period is effected by removing a task and then adding it with the new period. >>>>> >>>>> And for anyone not reading the fine-print when you dynamically enroll a task its first firing is somewhat arbitrary - somewhere between the time of enrollment and that time plus its period. >>>>> >>>>> src/share/vm/runtime/thread.hpp >>>>> >>>>> Can you add a comment: >>>>> >>>>> static void stop(); >>>>> + // Only allow start once the VM is sufficiently initialized >>>>> + // Otherwise the first task to enroll will trigger the start >>>>> + static void make_startable(); >>>>> >>>>> --- >>>>> >>>>> src/share/vm/runtime/thread.cpp >>>>> >>>>> We have a bit of type mixing here: >>>>> >>>>> - size_t time_to_wait >>>>> - jlong time_slept >>>>> - int remaining = time_to_wait >>>>> >>>>> I don't understand why Task is using size_t for time intervals. If you make "remaining" a size_t then it will cause issues when you pass it to wait. But I would expect the initialization of "remaining" to cause an unsigned-to-signed conversion warning, so perhaps an explicit cast to silence that. >>>>> >>>>> 1203 bool status = PeriodicTask_lock->wait(Mutex::_no_safepoint_check_flag, remaining); >>>>> 1204 if (status || _should_terminate) { >>>>> 1205 break; >>>>> 1206 } >>>>> >>>>> Can you rename status to timedout to make the logic more obvious. Also note that you will potentially return with time_slept still at zero, even though you may have slept for an arbitrary amount of time. That seems wrong as zero will then be passed to "tick". >>>>> >>>>> 1208 // spurious wakeup of some kind >>>>> >>>>> This comment is no longer accurate as you may have been woken up due to a change in the task list, I suggest: >>>>> >>>>> // Change to task list or spurious wakeup of some kind >>>>> >>>>> 1213 remaining = PeriodicTask::time_to_wait(); >>>>> 1214 if (remaining == 0) { >>>>> 1215 continue; >>>>> 1216 } >>>>> >>>>> Can you insert a comment before continue: >>>>> >>>>> // Last task was just disenrolled so loop around and wait until >>>>> // another task gets enrolled >>>>> continue; >>>>> >>>>> >>>>> 1218 remaining -= time_slept; >>>>> >>>>> Again type mixing: subtracting a long from an int. Again a potential warning to get rid of. >>>>> >>>>> Also in a long running VM perhaps there have been no periodic tasks for many days and then one turns up. The subtraction could wrap and cause remaining to remain positive. I know you've now documented the uncertainty in the first fire time but this seems somewhat too random. Let's see what others think. :) >>>>> >>>>> >>>>> 1329 PeriodicTask_lock->notify_all(); >>>>> >>>>> There is only one thread that waits so notify() will suffice. >>>>> >>>>> Thanks, >>>>> David >>>>> >>>>> On 9/10/2012 4:34 PM, Rickard B?ckman wrote: >>>>>> Trying again, >>>>>> >>>>>> can I have a couple of reviews, please? >>>>>> >>>>>> /R >>>>>> >>>>>> On Oct 4, 2012, at 3:01 PM, Rickard B?ckman wrote: >>>>>> >>>>>>> Hi all, >>>>>>> >>>>>>> can I please have a couple of reviews on the following change: >>>>>>> >>>>>>> http://cr.openjdk.java.net/~rbackman/7127792/ >>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127792 >>>>>>> >>>>>>> In short the purpose is to enable tasks to change the interval they are executed in. We >>>>>>> would also like to be able to add (and remove) tasks after the WatcherThread has started. >>>>>>> >>>>>>> Thanks >>>>>>> /R >>>>>> >>>> >> From yumin.qi at oracle.com Tue Oct 9 08:40:36 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Tue, 09 Oct 2012 08:40:36 -0700 Subject: RFR: 8000412: Clean SA code on ia64 In-Reply-To: <3E061272-FEBC-4C21-906A-53E6BC99E484@oracle.com> References: <50736148.5060002@oracle.com> <3E061272-FEBC-4C21-906A-53E6BC99E484@oracle.com> Message-ID: <50744574.3010802@oracle.com> Thanks, Richard Yumin On 10/8/2012 11:00 PM, Rickard B?ckman wrote: > Looks good, ship it. > > /R > > On Oct 9, 2012, at 1:27 AM, Yumin Qi wrote: > >> Hi, All >> >> Can I have your codereview for >> >> 8000412 >> : Clean SA code on ia64 >> Summary: Clean up IA64 code in SA since SA does no t support this cpu architecture. >> >> Reviewed-by: >> Contributed-by: >> yumin.qi at oracle.com,staffan.larsen at oracle.com >> >> >> >> http://cr.openjdk.java.net/~minqi/8000412/ >> >> >> Thanks >> Yumin >> >> From naoto.sato at oracle.com Tue Oct 9 10:00:26 2012 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Tue, 09 Oct 2012 17:00:26 +0000 Subject: hg: jdk8/tl/jdk: 7200341: DateFormatSymbols.hashCode() throws ArrayIndexOutOfBoundsException in some circumstances Message-ID: <20121009170052.2CF4E4724F@hg.openjdk.java.net> Changeset: c725ce4bbf12 Author: naoto Date: 2012-10-09 09:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c725ce4bbf12 7200341: DateFormatSymbols.hashCode() throws ArrayIndexOutOfBoundsException in some circumstances Reviewed-by: okutsu ! src/share/classes/java/text/DateFormatSymbols.java ! test/java/util/PluggableLocale/DateFormatSymbolsProviderTest.java ! test/java/util/PluggableLocale/DateFormatSymbolsProviderTest.sh ! test/java/util/PluggableLocale/fooprovider.jar ! test/java/util/PluggableLocale/providersrc/DateFormatSymbolsProviderImpl.java From coleen.phillimore at oracle.com Tue Oct 9 10:11:05 2012 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Tue, 09 Oct 2012 17:11:05 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8000622: Forgot to hg add and check in test for JDK-7170638 Message-ID: <20121009171110.6D3E047250@hg.openjdk.java.net> Changeset: 26351ce8c4b0 Author: coleenp Date: 2012-10-09 02:42 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/26351ce8c4b0 8000622: Forgot to hg add and check in test for JDK-7170638 Summary: add the test Reviewed-by: coleenp, kamg Contributed-by: Mark Wielaard + test/serviceability/7170638/SDTProbesGNULinuxTest.sh From sean.coffey at oracle.com Tue Oct 9 11:42:20 2012 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Tue, 09 Oct 2012 18:42:20 +0000 Subject: hg: jdk8/tl/jdk: 7181793: Socket getOutputStream create streams that cannot be GC'ed until Socket is closed Message-ID: <20121009184322.5A95047253@hg.openjdk.java.net> Changeset: 71de5e31d497 Author: coffeys Date: 2012-10-09 19:45 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71de5e31d497 7181793: Socket getOutputStream create streams that cannot be GC'ed until Socket is closed Reviewed-by: alanb, chegar ! src/share/classes/java/net/AbstractPlainSocketImpl.java + test/java/net/Socket/SocketGrowth.java From sean.coffey at oracle.com Tue Oct 9 12:16:07 2012 From: sean.coffey at oracle.com (sean.coffey at oracle.com) Date: Tue, 09 Oct 2012 19:16:07 +0000 Subject: hg: jdk8/tl/corba: 7196086: update copyright years for files in corba repository (JDK 8) Message-ID: <20121009191609.7C1CC47254@hg.openjdk.java.net> Changeset: 679e8ad9874f Author: coffeys Date: 2012-10-09 20:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/679e8ad9874f 7196086: update copyright years for files in corba repository (JDK 8) Reviewed-by: lancea ! make/common/Defs-bsd.gmk ! make/common/internal/Resources.gmk ! make/common/shared/Defs-bsd.gmk ! make/common/shared/Defs-utils.gmk ! make/tools/src/build/tools/stripproperties/StripPropertiesCorba.java ! make/tools/strip_properties/Makefile From huizhe.wang at oracle.com Tue Oct 9 14:17:05 2012 From: huizhe.wang at oracle.com (huizhe.wang at oracle.com) Date: Tue, 09 Oct 2012 21:17:05 +0000 Subject: hg: jdk8/tl/jaxp: 8000172: 2 SAX features does not work properly Message-ID: <20121009211710.B3FEB47258@hg.openjdk.java.net> Changeset: 53a2a4893c8f Author: joehw Date: 2012-10-09 14:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/53a2a4893c8f 8000172: 2 SAX features does not work properly Summary: When external dtd is not loaded, skippedEntity event should be reported for entity references. Reviewed-by: lancea ! src/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java From david.holmes at oracle.com Tue Oct 9 18:52:39 2012 From: david.holmes at oracle.com (david.holmes at oracle.com) Date: Wed, 10 Oct 2012 01:52:39 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7197424: update copyright year to match last edit in jdk8 hotspot repository Message-ID: <20121010015243.E1D9547266@hg.openjdk.java.net> Changeset: b9a9ed0f8eeb Author: mikael Date: 2012-10-09 10:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b9a9ed0f8eeb 7197424: update copyright year to match last edit in jdk8 hotspot repository Summary: Update copyright year to 2012 for relevant files Reviewed-by: dholmes, coleenp ! agent/src/share/classes/sun/jvm/hotspot/code/CodeCache.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdCDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThreadContextFactory.java ! agent/src/share/classes/sun/jvm/hotspot/oops/BranchData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/CounterData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/JumpData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MultiBranchData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/VirtualCallData.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Bytes.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/BasicHashtable.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/BasicHashtableEntry.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/Hashtable.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HashtableBucket.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HashtableEntry.java ! make/bsd/Makefile ! make/bsd/makefiles/adlc.make ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/dtrace.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/jvmg.make ! make/bsd/makefiles/launcher.make ! make/bsd/makefiles/product.make ! make/bsd/makefiles/rules.make ! make/bsd/makefiles/sparcWorks.make ! make/bsd/makefiles/top.make ! make/linux/makefiles/launcher.make ! make/linux/makefiles/ppc.make ! make/linux/makefiles/product.make ! make/linux/makefiles/rules.make ! make/linux/makefiles/sparcWorks.make ! make/linux/makefiles/top.make ! make/solaris/makefiles/adlc.make ! make/solaris/makefiles/gcc.make ! make/solaris/makefiles/jvmg.make ! make/solaris/makefiles/optimized.make ! make/solaris/makefiles/rules.make ! make/solaris/makefiles/top.make ! make/windows/build.bat ! make/windows/build_vm_def.sh ! make/windows/get_msc_ver.sh ! make/windows/makefiles/adlc.make ! make/windows/makefiles/launcher.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/rules.make ! make/windows/makefiles/sanity.make ! make/windows/makefiles/shared.make ! make/windows/makefiles/vm.make ! make/windows/projectfiles/common/Makefile ! src/cpu/sparc/vm/c1_FrameMap_sparc.cpp ! src/cpu/sparc/vm/c1_FrameMap_sparc.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.hpp ! src/cpu/sparc/vm/c1_LinearScan_sparc.hpp ! src/cpu/sparc/vm/interpreterGenerator_sparc.hpp ! src/cpu/x86/vm/c1_FrameMap_x86.cpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LinearScan_x86.cpp ! src/cpu/x86/vm/interpreterGenerator_x86.hpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/cpu/x86/vm/templateTable_x86_32.hpp ! src/cpu/x86/vm/templateTable_x86_64.hpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/cpu/zero/vm/interpreterGenerator_zero.hpp ! src/cpu/zero/vm/methodHandles_zero.hpp ! src/os/bsd/vm/decoder_machO.cpp ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/bsd/vm/perfMemory_bsd.cpp ! src/os/linux/vm/decoder_linux.cpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/linux/vm/perfMemory_linux.cpp ! src/os/posix/launcher/java_md.c ! src/os/posix/launcher/launcher.script ! src/os/posix/vm/os_posix.cpp ! src/os/posix/vm/os_posix.hpp ! src/os/solaris/dtrace/hs_private.d ! src/os/solaris/vm/attachListener_solaris.cpp ! src/os/solaris/vm/decoder_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/solaris/vm/perfMemory_solaris.cpp ! src/os/windows/vm/decoder_windows.cpp ! src/os/windows/vm/decoder_windows.hpp ! src/os/windows/vm/os_windows.hpp ! src/os/windows/vm/perfMemory_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.hpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.inline.hpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.hpp ! src/os_cpu/linux_x86/vm/os_linux_x86.inline.hpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.hpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.inline.hpp ! src/os_cpu/solaris_x86/vm/solaris_x86_32.il ! src/os_cpu/solaris_x86/vm/solaris_x86_64.il ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.hpp ! src/os_cpu/windows_x86/vm/os_windows_x86.inline.hpp ! src/share/tools/ProjectCreator/ProjectCreator.java ! src/share/tools/ProjectCreator/Util.java ! src/share/tools/ProjectCreator/WinGammaPlatform.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC7.java ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/register.hpp ! src/share/vm/c1/c1_CFGPrinter.cpp ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Canonicalizer.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_Compiler.cpp ! src/share/vm/c1/c1_FrameMap.cpp ! src/share/vm/c1/c1_FrameMap.hpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_IR.cpp ! src/share/vm/c1/c1_IR.hpp ! src/share/vm/c1/c1_InstructionPrinter.hpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_LinearScan.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/c1/c1_ValueMap.cpp ! src/share/vm/c1/c1_ValueMap.hpp ! src/share/vm/c1/c1_ValueStack.cpp ! src/share/vm/c1/c1_ValueStack.hpp ! src/share/vm/ci/ciMethodHandle.hpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/ci/ciSymbol.cpp ! src/share/vm/ci/ciTypeFlow.hpp ! src/share/vm/classfile/classLoader.hpp ! src/share/vm/classfile/javaAssertions.hpp ! src/share/vm/code/stubs.cpp ! src/share/vm/code/stubs.hpp ! src/share/vm/code/vmreg.hpp ! src/share/vm/compiler/abstractCompiler.hpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.hpp ! src/share/vm/gc_implementation/g1/g1MMUTracker.hpp ! src/share/vm/gc_implementation/g1/ptrQueue.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp ! src/share/vm/gc_implementation/g1/survRateGroup.hpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.hpp ! src/share/vm/gc_implementation/parallelScavenge/objectStartArray.hpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psGenerationCounters.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionLAB.hpp ! src/share/vm/gc_implementation/parallelScavenge/psVirtualspace.hpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/gc_implementation/shared/collectorCounters.cpp ! src/share/vm/gc_implementation/shared/collectorCounters.hpp ! src/share/vm/gc_implementation/shared/gSpaceCounters.cpp ! src/share/vm/gc_implementation/shared/gSpaceCounters.hpp ! src/share/vm/gc_implementation/shared/gcPolicyCounters.hpp ! src/share/vm/gc_implementation/shared/gcStats.hpp ! src/share/vm/gc_implementation/shared/gcUtil.cpp ! src/share/vm/gc_implementation/shared/gcUtil.hpp ! src/share/vm/gc_implementation/shared/generationCounters.cpp ! src/share/vm/gc_implementation/shared/generationCounters.hpp ! src/share/vm/gc_implementation/shared/hSpaceCounters.cpp ! src/share/vm/gc_implementation/shared/hSpaceCounters.hpp ! src/share/vm/gc_implementation/shared/spaceCounters.cpp ! src/share/vm/gc_implementation/shared/spaceCounters.hpp ! src/share/vm/gc_implementation/shared/spaceDecorator.hpp ! src/share/vm/interpreter/interpreter.hpp ! src/share/vm/libadt/set.cpp ! src/share/vm/libadt/vectset.cpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/freeList.cpp ! src/share/vm/memory/freeList.hpp ! src/share/vm/memory/heap.cpp ! src/share/vm/memory/heap.hpp ! src/share/vm/memory/referencePolicy.hpp ! src/share/vm/memory/space.inline.hpp ! src/share/vm/memory/threadLocalAllocBuffer.hpp ! src/share/vm/oops/objArrayOop.hpp ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/divnode.cpp ! src/share/vm/opto/domgraph.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/generateOptoStub.cpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/locknode.cpp ! src/share/vm/opto/locknode.hpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/opto/subnode.hpp ! src/share/vm/prims/jniExport.hpp ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp ! src/share/vm/prims/jvmtiExtensions.cpp ! src/share/vm/prims/jvmtiRawMonitor.cpp ! src/share/vm/prims/jvmtiTagMap.hpp ! src/share/vm/prims/jvmtiUtil.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/dtraceJSDT.hpp ! src/share/vm/runtime/interfaceSupport.hpp ! src/share/vm/runtime/java.hpp ! src/share/vm/runtime/monitorChunk.cpp ! src/share/vm/runtime/monitorChunk.hpp ! src/share/vm/runtime/mutex.hpp ! src/share/vm/runtime/park.cpp ! src/share/vm/runtime/perfMemory.cpp ! src/share/vm/runtime/stubCodeGenerator.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/task.hpp ! src/share/vm/runtime/timer.cpp ! src/share/vm/runtime/vmThread.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/g1MemoryPool.cpp ! src/share/vm/services/g1MemoryPool.hpp ! src/share/vm/services/lowMemoryDetector.hpp ! src/share/vm/services/memoryManager.hpp ! src/share/vm/trace/tracing.hpp ! src/share/vm/utilities/array.cpp ! src/share/vm/utilities/decoder.cpp ! src/share/vm/utilities/decoder_elf.cpp ! src/share/vm/utilities/elfFile.cpp ! src/share/vm/utilities/elfFile.hpp ! src/share/vm/utilities/elfStringTable.cpp ! src/share/vm/utilities/elfStringTable.hpp ! src/share/vm/utilities/elfSymbolTable.cpp ! src/share/vm/utilities/elfSymbolTable.hpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp ! src/share/vm/utilities/growableArray.cpp ! src/share/vm/utilities/histogram.cpp ! src/share/vm/utilities/histogram.hpp ! src/share/vm/utilities/intHisto.cpp ! src/share/vm/utilities/intHisto.hpp ! src/share/vm/utilities/preserveException.cpp ! src/share/vm/utilities/stack.hpp ! src/share/vm/utilities/stack.inline.hpp ! src/share/vm/utilities/taskqueue.hpp ! src/share/vm/utilities/vmError.hpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/workgroup.hpp ! test/compiler/6859338/Test6859338.java ! test/compiler/7116216/StackOverflow.java From jonathan.gibbons at oracle.com Tue Oct 9 19:12:07 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 10 Oct 2012 02:12:07 +0000 Subject: hg: jdk8/tl/langtools: 8000663: clean up langtools imports Message-ID: <20121010021212.4397447267@hg.openjdk.java.net> Changeset: c75be5bc5283 Author: jjg Date: 2012-10-09 19:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c75be5bc5283 8000663: clean up langtools imports Reviewed-by: darcy ! src/share/classes/com/sun/source/tree/CompilationUnitTree.java ! src/share/classes/com/sun/source/tree/Scope.java ! src/share/classes/com/sun/source/util/TaskEvent.java ! src/share/classes/com/sun/source/util/TreePath.java ! src/share/classes/com/sun/tools/classfile/ClassTranslator.java ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstantsSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/PackageSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/WriterFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassUseMapper.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DeprecatedAPIListBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFinder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Group.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ImplementedMethods.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/IndexBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MessageRetriever.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MetaKeywords.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PackageListWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java ! src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/api/WrappingJavaFileManager.java ! src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/DeferredLintHandler.java ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/TargetType.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/model/AnnotationProxyMaker.java ! src/share/classes/com/sun/tools/javac/nio/PathFileObject.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javadoc/AbstractTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationDescImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocLocale.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterImpl.java ! src/share/classes/com/sun/tools/javadoc/PrimitiveType.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/SeeTagImpl.java ! src/share/classes/com/sun/tools/javadoc/SerializedForm.java ! src/share/classes/com/sun/tools/javadoc/Start.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! src/share/classes/com/sun/tools/javadoc/WildcardTypeImpl.java ! src/share/classes/javax/annotation/processing/Completions.java ! src/share/classes/javax/annotation/processing/FilerException.java ! src/share/classes/javax/annotation/processing/ProcessingEnvironment.java ! src/share/classes/javax/lang/model/element/AnnotationValue.java ! src/share/classes/javax/lang/model/element/Element.java ! src/share/classes/javax/lang/model/element/ExecutableElement.java ! src/share/classes/javax/lang/model/element/VariableElement.java ! src/share/classes/javax/lang/model/type/MirroredTypeException.java ! src/share/classes/javax/lang/model/type/MirroredTypesException.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor7.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor8.java ! src/share/classes/javax/lang/model/util/ElementFilter.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor7.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor8.java ! src/share/classes/javax/lang/model/util/ElementScanner6.java ! src/share/classes/javax/lang/model/util/ElementScanner7.java ! src/share/classes/javax/lang/model/util/ElementScanner8.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor6.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor7.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor8.java ! src/share/classes/javax/tools/ForwardingJavaFileManager.java ! src/share/classes/javax/tools/JavaFileObject.java From jonathan.gibbons at oracle.com Tue Oct 9 19:32:44 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 10 Oct 2012 02:32:44 +0000 Subject: hg: jdk8/tl/langtools: 8000208: fix langtools javadoc comment issues Message-ID: <20121010023249.D14FF47268@hg.openjdk.java.net> Changeset: fc123bdeddb8 Author: jjg Date: 2012-10-09 19:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fc123bdeddb8 8000208: fix langtools javadoc comment issues Reviewed-by: bpatel, mcimadamore ! src/share/classes/com/sun/javadoc/Tag.java ! src/share/classes/com/sun/tools/classfile/BootstrapMethods_attribute.java ! src/share/classes/com/sun/tools/classfile/Dependencies.java ! src/share/classes/com/sun/tools/classfile/Instruction.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/EnumConstantWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassDocCatalog.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DeprecatedAPIListBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java ! src/share/classes/com/sun/tools/javac/api/DiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/TypeTags.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/Locations.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/nio/PathFileManager.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/parser/UnicodeReader.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/ServiceProxy.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/AbstractLog.java ! src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/Context.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Position.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! src/share/classes/com/sun/tools/javadoc/ModifierFilter.java ! src/share/classes/com/sun/tools/javadoc/ParamTagImpl.java ! src/share/classes/com/sun/tools/javadoc/ThrowsTagImpl.java ! src/share/classes/com/sun/tools/javah/NativeHeaderTool.java ! src/share/classes/com/sun/tools/javap/DisassemblerTool.java From jaroslav.bachorik at oracle.com Wed Oct 10 01:40:01 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 10 Oct 2012 10:40:01 +0200 Subject: [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject Message-ID: <50753461.4070009@oracle.com> I am looking for a review and a sponsor for this fix. The issue is about an empty array of descriptors being written as a part of the serialization process but not read when deserializing an MBeanInfo/MBeanFeatureInfo instance. While the current ObjectInputStream skips all unread custom written fields it is not a behaviour required by the specification and may cause problems. The patch makes the array to be read in all cases - even when it is known to be an empty one. That way all that has been written as a part of serialization is read back. The webrev with the fix and test is available @ https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6783290 -JB- From dmitry.samersoff at oracle.com Wed Oct 10 03:17:59 2012 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Wed, 10 Oct 2012 14:17:59 +0400 Subject: [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject In-Reply-To: <50753461.4070009@oracle.com> References: <50753461.4070009@oracle.com> Message-ID: <56c13fe5-2ca4-4402-98b2-0487799e6a38.maildroid@localhost> I'll sponsor the fix and will review it later today. -Dmitry -----Original Message----- From: Jaroslav Bachorik To: jmx-dev at openjdk.java.net, serviceability-dev at openjdk.java.net Sent: Wed, 10 Oct 2012 12:48 Subject: [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject I am looking for a review and a sponsor for this fix. The issue is about an empty array of descriptors being written as a part of the serialization process but not read when deserializing an MBeanInfo/MBeanFeatureInfo instance. While the current ObjectInputStream skips all unread custom written fields it is not a behaviour required by the specification and may cause problems. The patch makes the array to be read in all cases - even when it is known to be an empty one. That way all that has been written as a part of serialization is read back. The webrev with the fix and test is available @ https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6783290 -JB- -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121010/b21206f7/attachment.html From jaroslav.bachorik at oracle.com Wed Oct 10 07:17:03 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 10 Oct 2012 16:17:03 +0200 Subject: [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer Message-ID: <5075835F.3050604@oracle.com> I am looking for a review and a sponsor. The issue is about some javax.management.timer.Timer notifications not being received by the listeners if the notifications are generated rapidly. The problem is caused by ConcurrentModificationException being thrown - the exception itself is ignored but the dispatcher logic is skipped. Therefore the currently processed notification gets lost. The CME is thrown due to the Timer.timerTable being iterated over while other threads try to remove some of its elements. Fix consists of replacing the Hashtable used for Timer.timerTable by ConcurrentHashMap which handles such situations with grace. The patch webrev is available @ https://jbs.oracle.com/bugs/browse/JDK-6809322 Thanks, -JB- From jaroslav.bachorik at oracle.com Wed Oct 10 07:39:27 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 10 Oct 2012 16:39:27 +0200 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <5075835F.3050604@oracle.com> References: <5075835F.3050604@oracle.com> Message-ID: <5075889F.1070808@oracle.com> I am sorry for the webrev URL - a stale clipboard :( The correct webrev URL is https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6809322 -JB- On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: > I am looking for a review and a sponsor. > > The issue is about some javax.management.timer.Timer notifications not > being received by the listeners if the notifications are generated rapidly. > > The problem is caused by ConcurrentModificationException being thrown - > the exception itself is ignored but the dispatcher logic is skipped. > Therefore the currently processed notification gets lost. > > The CME is thrown due to the Timer.timerTable being iterated over while > other threads try to remove some of its elements. Fix consists of > replacing the Hashtable used for Timer.timerTable by ConcurrentHashMap > which handles such situations with grace. > > The patch webrev is available @ > https://jbs.oracle.com/bugs/browse/JDK-6809322 > > Thanks, > > -JB- > From lance.andersen at oracle.com Wed Oct 10 08:15:48 2012 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Wed, 10 Oct 2012 15:15:48 +0000 Subject: hg: jdk8/tl/jdk: 8000687: Correct javadoc typo for getLogWriter and setLogWriter Message-ID: <20121010151624.EDA6447284@hg.openjdk.java.net> Changeset: 3c4be36de073 Author: lancea Date: 2012-10-10 11:15 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3c4be36de073 8000687: Correct javadoc typo for getLogWriter and setLogWriter Reviewed-by: alanb ! src/share/classes/java/sql/DriverManager.java From Dmitry.Samersoff at oracle.com Wed Oct 10 08:42:43 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 10 Oct 2012 19:42:43 +0400 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <5075889F.1070808@oracle.com> References: <5075835F.3050604@oracle.com> <5075889F.1070808@oracle.com> Message-ID: <50759773.7080602@oracle.com> Jaroslav, Not able to open it as a webrev - only list of files. E-mail me the webrev and I'll put it to cr.openjdk.net/~dsamersoff/sponsorship/jbachorik/NNNNN -Dmitry On 2012-10-10 18:39, Jaroslav Bachorik wrote: > I am sorry for the webrev URL - a stale clipboard :( > > The correct webrev URL is > https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6809322 > > -JB- > > On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >> I am looking for a review and a sponsor. >> >> The issue is about some javax.management.timer.Timer notifications not >> being received by the listeners if the notifications are generated rapidly. >> >> The problem is caused by ConcurrentModificationException being thrown - >> the exception itself is ignored but the dispatcher logic is skipped. >> Therefore the currently processed notification gets lost. >> >> The CME is thrown due to the Timer.timerTable being iterated over while >> other threads try to remove some of its elements. Fix consists of >> replacing the Hashtable used for Timer.timerTable by ConcurrentHashMap >> which handles such situations with grace. >> >> The patch webrev is available @ >> https://jbs.oracle.com/bugs/browse/JDK-6809322 >> >> Thanks, >> >> -JB- >> > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From eamonn at mcmanus.net Wed Oct 10 08:49:11 2012 From: eamonn at mcmanus.net (Eamonn McManus) Date: Wed, 10 Oct 2012 08:49:11 -0700 Subject: jmx-dev [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject In-Reply-To: <50753461.4070009@oracle.com> References: <50753461.4070009@oracle.com> Message-ID: Hi Jaroslav, The patch looks correct and the test is ingenious. I do not understand why the previous SerializationTest needs to be deleted. It doesn't seem that the new test is covering the same things. Reviewed-by: emcmanus Incidentally I was not able to find a way to see the patch with the usual webrev browser UI. Is there a link for that? Regards, ?amonn 2012/10/10 Jaroslav Bachorik : > I am looking for a review and a sponsor for this fix. > > The issue is about an empty array of descriptors being written as a part > of the serialization process but not read when deserializing an > MBeanInfo/MBeanFeatureInfo instance. While the current ObjectInputStream > skips all unread custom written fields it is not a behaviour required by > the specification and may cause problems. > > The patch makes the array to be read in all cases - even when it is > known to be an empty one. That way all that has been written as a part > of serialization is read back. > > The webrev with the fix and test is available @ > https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6783290 > > -JB- From jaroslav.bachorik at oracle.com Wed Oct 10 11:25:51 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 10 Oct 2012 20:25:51 +0200 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <50759773.7080602@oracle.com> References: <5075835F.3050604@oracle.com> <5075889F.1070808@oracle.com> <50759773.7080602@oracle.com> Message-ID: <5075BDAF.6070703@oracle.com> On Wed 10 Oct 2012 05:42:43 PM CEST, Dmitry Samersoff wrote: > Jaroslav, > > Not able to open it as a webrev - only list of files. > > E-mail me the webrev and I'll put it to >file:///opt/src/jdks/openjdk-patches/webrevs/JDK-6809322.zip > cr.openjdk.net/~dsamersoff/sponsorship/jbachorik/NNNNN Attaching... Thanks. I didn't want to put the webrevs on rapidshare or the likes and github seemed like a nice choice. Unfortunately it is not possible to view raw files :( -JB- > > -Dmitry > > > On 2012-10-10 18:39, Jaroslav Bachorik wrote: >> I am sorry for the webrev URL - a stale clipboard :( >> >> The correct webrev URL is >> https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6809322 >> >> -JB- >> >> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>> I am looking for a review and a sponsor. >>> >>> The issue is about some javax.management.timer.Timer notifications not >>> being received by the listeners if the notifications are generated rapidly. >>> >>> The problem is caused by ConcurrentModificationException being thrown - >>> the exception itself is ignored but the dispatcher logic is skipped. >>> Therefore the currently processed notification gets lost. >>> >>> The CME is thrown due to the Timer.timerTable being iterated over while >>> other threads try to remove some of its elements. Fix consists of >>> replacing the Hashtable used for Timer.timerTable by ConcurrentHashMap >>> which handles such situations with grace. >>> >>> The patch webrev is available @ >>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>> >>> Thanks, >>> >>> -JB- >>> >> > > -------------- next part -------------- A non-text attachment was scrubbed... Name: JDK-6809322.zip Type: application/zip Size: 131412 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121010/0a91f1df/JDK-6809322-0001.zip From Dmitry.Samersoff at oracle.com Wed Oct 10 11:32:23 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 10 Oct 2012 22:32:23 +0400 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <5075BDAF.6070703@oracle.com> References: <5075835F.3050604@oracle.com> <5075889F.1070808@oracle.com> <50759773.7080602@oracle.com> <5075BDAF.6070703@oracle.com> Message-ID: <5075BF37.2020400@oracle.com> Jaroslav, http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322/ -Dmitry On 2012-10-10 22:25, Jaroslav Bachorik wrote: > On Wed 10 Oct 2012 05:42:43 PM CEST, Dmitry Samersoff wrote: >> Jaroslav, >> >> Not able to open it as a webrev - only list of files. >> >> E-mail me the webrev and I'll put it to >> file:///opt/src/jdks/openjdk-patches/webrevs/JDK-6809322.zip > >> cr.openjdk.net/~dsamersoff/sponsorship/jbachorik/NNNNN > > Attaching... Thanks. I didn't want to put the webrevs on rapidshare or > the likes and github seemed like a nice choice. Unfortunately it is not > possible to view raw files :( > > -JB- > >> >> -Dmitry >> >> >> On 2012-10-10 18:39, Jaroslav Bachorik wrote: >>> I am sorry for the webrev URL - a stale clipboard :( >>> >>> The correct webrev URL is >>> https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6809322 >>> >>> -JB- >>> >>> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>>> I am looking for a review and a sponsor. >>>> >>>> The issue is about some javax.management.timer.Timer notifications not >>>> being received by the listeners if the notifications are generated rapidly. >>>> >>>> The problem is caused by ConcurrentModificationException being thrown - >>>> the exception itself is ignored but the dispatcher logic is skipped. >>>> Therefore the currently processed notification gets lost. >>>> >>>> The CME is thrown due to the Timer.timerTable being iterated over while >>>> other threads try to remove some of its elements. Fix consists of >>>> replacing the Hashtable used for Timer.timerTable by ConcurrentHashMap >>>> which handles such situations with grace. >>>> >>>> The patch webrev is available @ >>>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>>> >>>> Thanks, >>>> >>>> -JB- >>>> >>> >> >> > > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From Dmitry.Samersoff at oracle.com Wed Oct 10 11:38:21 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 10 Oct 2012 22:38:21 +0400 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <5075BDAF.6070703@oracle.com> References: <5075835F.3050604@oracle.com> <5075889F.1070808@oracle.com> <50759773.7080602@oracle.com> <5075BDAF.6070703@oracle.com> Message-ID: <5075C09D.80103@oracle.com> Jaroslav, The fix looks good for me. -Dmitry On 2012-10-10 22:25, Jaroslav Bachorik wrote: > On Wed 10 Oct 2012 05:42:43 PM CEST, Dmitry Samersoff wrote: >> Jaroslav, >> >> Not able to open it as a webrev - only list of files. >> >> E-mail me the webrev and I'll put it to >> file:///opt/src/jdks/openjdk-patches/webrevs/JDK-6809322.zip > >> cr.openjdk.net/~dsamersoff/sponsorship/jbachorik/NNNNN > > Attaching... Thanks. I didn't want to put the webrevs on rapidshare or > the likes and github seemed like a nice choice. Unfortunately it is not > possible to view raw files :( > > -JB- > >> >> -Dmitry >> >> >> On 2012-10-10 18:39, Jaroslav Bachorik wrote: >>> I am sorry for the webrev URL - a stale clipboard :( >>> >>> The correct webrev URL is >>> https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6809322 >>> >>> -JB- >>> >>> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>>> I am looking for a review and a sponsor. >>>> >>>> The issue is about some javax.management.timer.Timer notifications not >>>> being received by the listeners if the notifications are generated rapidly. >>>> >>>> The problem is caused by ConcurrentModificationException being thrown - >>>> the exception itself is ignored but the dispatcher logic is skipped. >>>> Therefore the currently processed notification gets lost. >>>> >>>> The CME is thrown due to the Timer.timerTable being iterated over while >>>> other threads try to remove some of its elements. Fix consists of >>>> replacing the Hashtable used for Timer.timerTable by ConcurrentHashMap >>>> which handles such situations with grace. >>>> >>>> The patch webrev is available @ >>>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>>> >>>> Thanks, >>>> >>>> -JB- >>>> >>> >> >> > > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From jaroslav.bachorik at oracle.com Wed Oct 10 11:46:04 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 10 Oct 2012 20:46:04 +0200 Subject: jmx-dev [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject In-Reply-To: References: <50753461.4070009@oracle.com> Message-ID: <5075C26C.50309@oracle.com> Hi, On Wed 10 Oct 2012 05:49:11 PM CEST, Eamonn McManus wrote: > Hi Jaroslav, > > The patch looks correct and the test is ingenious. > > I do not understand why the previous SerializationTest needs to be > deleted. It doesn't seem that the new test is covering the same > things. I need to check that. I copied the SerializationTest.java to SerializationTest1.java - apparently the cooperation of the webrev and mercurial queues has its glitches :( I am attaching the corrected webrev. -JB- > > Reviewed-by: emcmanus > > Incidentally I was not able to find a way to see the patch with the > usual webrev browser UI. Is there a link for that? > > Regards, > ?amonn > > > 2012/10/10 Jaroslav Bachorik : >> I am looking for a review and a sponsor for this fix. >> >> The issue is about an empty array of descriptors being written as a part >> of the serialization process but not read when deserializing an >> MBeanInfo/MBeanFeatureInfo instance. While the current ObjectInputStream >> skips all unread custom written fields it is not a behaviour required by >> the specification and may cause problems. >> >> The patch makes the array to be read in all cases - even when it is >> known to be an empty one. That way all that has been written as a part >> of serialization is read back. >> >> The webrev with the fix and test is available @ >> https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6783290 >> >> -JB- -------------- next part -------------- A non-text attachment was scrubbed... Name: JDK-6783290.zip Type: application/zip Size: 116369 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121010/df5fb619/JDK-6783290-0001.zip From jaroslav.bachorik at oracle.com Wed Oct 10 11:52:55 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 10 Oct 2012 20:52:55 +0200 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <5075BF37.2020400@oracle.com> References: <5075835F.3050604@oracle.com> <5075889F.1070808@oracle.com> <50759773.7080602@oracle.com> <5075BDAF.6070703@oracle.com> <5075BF37.2020400@oracle.com> Message-ID: <5075C407.9060105@oracle.com> Thanks, could you update with this webrev? I've fixed the problem with hgmq <-> webrev where the file copy is mistakenly marked as a file move. Thanks, -JB- On 10/10/2012 08:32 PM, Dmitry Samersoff wrote: > Jaroslav, > > http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322/ > > -Dmitry > > > On 2012-10-10 22:25, Jaroslav Bachorik wrote: >> On Wed 10 Oct 2012 05:42:43 PM CEST, Dmitry Samersoff wrote: >>> Jaroslav, >>> >>> Not able to open it as a webrev - only list of files. >>> >>> E-mail me the webrev and I'll put it to >>> file:///opt/src/jdks/openjdk-patches/webrevs/JDK-6809322.zip >> >>> cr.openjdk.net/~dsamersoff/sponsorship/jbachorik/NNNNN >> >> Attaching... Thanks. I didn't want to put the webrevs on rapidshare or >> the likes and github seemed like a nice choice. Unfortunately it is not >> possible to view raw files :( >> >> -JB- >> >>> >>> -Dmitry >>> >>> >>> On 2012-10-10 18:39, Jaroslav Bachorik wrote: >>>> I am sorry for the webrev URL - a stale clipboard :( >>>> >>>> The correct webrev URL is >>>> https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6809322 >>>> >>>> -JB- >>>> >>>> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>>>> I am looking for a review and a sponsor. >>>>> >>>>> The issue is about some javax.management.timer.Timer notifications not >>>>> being received by the listeners if the notifications are generated rapidly. >>>>> >>>>> The problem is caused by ConcurrentModificationException being thrown - >>>>> the exception itself is ignored but the dispatcher logic is skipped. >>>>> Therefore the currently processed notification gets lost. >>>>> >>>>> The CME is thrown due to the Timer.timerTable being iterated over while >>>>> other threads try to remove some of its elements. Fix consists of >>>>> replacing the Hashtable used for Timer.timerTable by ConcurrentHashMap >>>>> which handles such situations with grace. >>>>> >>>>> The patch webrev is available @ >>>>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>>>> >>>>> Thanks, >>>>> >>>>> -JB- >>>>> >>>> >>> >>> >> >> > > From alan.bateman at oracle.com Wed Oct 10 12:47:09 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 10 Oct 2012 19:47:09 +0000 Subject: hg: jdk8/tl/jdk: 7192274: Deprecate LogManager addPropertyChangeListener and removePropertyChangeLister methods Message-ID: <20121010194731.31C134728D@hg.openjdk.java.net> Changeset: 6455182d2797 Author: alanb Date: 2012-10-10 20:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6455182d2797 7192274: Deprecate LogManager addPropertyChangeListener and removePropertyChangeLister methods Reviewed-by: mchung, lancea, chegar ! src/share/classes/java/util/logging/LogManager.java From lance.andersen at oracle.com Wed Oct 10 14:34:43 2012 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Wed, 10 Oct 2012 21:34:43 +0000 Subject: hg: jdk8/tl/jdk: 8000712: Remove unused fields in SyncFactory Message-ID: <20121010213505.A649847297@hg.openjdk.java.net> Changeset: 734ca9f4719c Author: lancea Date: 2012-10-10 17:34 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/734ca9f4719c 8000712: Remove unused fields in SyncFactory Reviewed-by: mchung ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java From jonathan.gibbons at oracle.com Wed Oct 10 16:48:58 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 10 Oct 2012 23:48:58 +0000 Subject: hg: jdk8/tl/langtools: 8000665: fix "internal API" comments on javadoc files Message-ID: <20121010234903.EFFAF472A3@hg.openjdk.java.net> Changeset: 25e14ad23cef Author: jjg Date: 2012-10-10 16:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/25e14ad23cef 8000665: fix "internal API" comments on javadoc files Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/Comment.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/DocType.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlAttr.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlConstants.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocument.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlStyle.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeOptionalMemberWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeRequiredMemberWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstantsSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstructorWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/EnumConstantWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/FieldWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/MemberSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/MethodWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/NestedClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/PackageSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/SerializedFormWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/WriterFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/XMLNode.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseExecutableMemberTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseInlineTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DeprecatedTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DocRootTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritableTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LegacyTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SimpleTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletOutput.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassDocCatalog.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassTree.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassUseMapper.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/CommentedMethodFinder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DeprecatedAPIListBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFinder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletAbortException.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletConstants.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Group.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/ImplementedMethods.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/IndexBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MessageRetriever.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MetaKeywords.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/MethodFinder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PackageListWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/TaggedMethodFinder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/TextTag.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkOutput.java ! src/share/classes/com/sun/tools/javadoc/AbstractTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationDescImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/Comment.java ! src/share/classes/com/sun/tools/javadoc/ConstructorDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocLocale.java ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocTodo.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java ! src/share/classes/com/sun/tools/javadoc/Main.java ! src/share/classes/com/sun/tools/javadoc/MemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ModifierFilter.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParamTagImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterizedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/PrimitiveType.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java ! src/share/classes/com/sun/tools/javadoc/SeeTagImpl.java ! src/share/classes/com/sun/tools/javadoc/SerialFieldTagImpl.java ! src/share/classes/com/sun/tools/javadoc/SerializedForm.java ! src/share/classes/com/sun/tools/javadoc/SourcePositionImpl.java ! src/share/classes/com/sun/tools/javadoc/Start.java ! src/share/classes/com/sun/tools/javadoc/TagImpl.java ! src/share/classes/com/sun/tools/javadoc/ThrowsTagImpl.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! src/share/classes/com/sun/tools/javadoc/WildcardTypeImpl.java From jonathan.gibbons at oracle.com Wed Oct 10 18:08:56 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 11 Oct 2012 01:08:56 +0000 Subject: hg: jdk8/tl/langtools: 8000743: docencoding not available to stylesheet Message-ID: <20121011010901.292FA472A5@hg.openjdk.java.net> Changeset: 560d4a5d14e6 Author: jjg Date: 2012-10-10 18:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/560d4a5d14e6 8000743: docencoding not available to stylesheet Reviewed-by: jjg Contributed-by: jviswana at linux.vnet.ibm.com ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java + test/com/sun/javadoc/testDocEncoding/TestDocEncoding.java + test/com/sun/javadoc/testDocEncoding/pkg/Test.java From jonathan.gibbons at oracle.com Wed Oct 10 18:35:22 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 11 Oct 2012 01:35:22 +0000 Subject: hg: jdk8/tl/langtools: 8000418: javadoc should used a standard "generated by javadoc" string Message-ID: <20121011013525.E77F8472A8@hg.openjdk.java.net> Changeset: 6517bf8e50d0 Author: jjg Date: 2012-10-10 18:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6517bf8e50d0 8000418: javadoc should used a standard "generated by javadoc" string Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! test/com/sun/javadoc/VersionNumber/VersionNumber.java + test/com/sun/javadoc/testGeneratedBy/TestGeneratedBy.java + test/com/sun/javadoc/testGeneratedBy/pkg/MyClass.java From jonathan.gibbons at oracle.com Wed Oct 10 18:44:52 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 11 Oct 2012 01:44:52 +0000 Subject: hg: jdk8/tl/langtools: 8000310: Clean up use of StringBuffer in langtools Message-ID: <20121011014457.34203472A9@hg.openjdk.java.net> Changeset: c46e0c9940d6 Author: jjg Date: 2012-10-10 18:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c46e0c9940d6 8000310: Clean up use of StringBuffer in langtools Reviewed-by: bpatel ! src/share/classes/com/sun/tools/classfile/Descriptor.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletOutputImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DirectoryManager.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/util/Convert.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javah/Gen.java ! src/share/classes/com/sun/tools/javah/LLNI.java ! src/share/classes/com/sun/tools/javah/Mangle.java From coleen.phillimore at oracle.com Wed Oct 10 20:13:28 2012 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Thu, 11 Oct 2012 03:13:28 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7199068: NPG: SharedSkipVerify is meaningless Message-ID: <20121011031332.8928C472AC@hg.openjdk.java.net> Changeset: bdb5f8c9978b Author: coleenp Date: 2012-10-10 17:04 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bdb5f8c9978b 7199068: NPG: SharedSkipVerify is meaningless Summary: Remove the SharedSkipVerify flag Reviewed-by: kamg, sspitsyn, coleenp Contributed-by: harold.seigel at oracle.com ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.hpp From jaroslav.bachorik at oracle.com Thu Oct 11 01:07:54 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 11 Oct 2012 10:07:54 +0200 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <5075835F.3050604@oracle.com> References: <5075835F.3050604@oracle.com> Message-ID: <50767E5A.7060908@oracle.com> Dmitry has put the webrev on the public CR - http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/ Thanks! -JB- On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: > I am looking for a review and a sponsor. > > The issue is about some javax.management.timer.Timer notifications not > being received by the listeners if the notifications are generated rapidly. > > The problem is caused by ConcurrentModificationException being thrown - > the exception itself is ignored but the dispatcher logic is skipped. > Therefore the currently processed notification gets lost. > > The CME is thrown due to the Timer.timerTable being iterated over while > other threads try to remove some of its elements. Fix consists of > replacing the Hashtable used for Timer.timerTable by ConcurrentHashMap > which handles such situations with grace. > > The patch webrev is available @ > https://jbs.oracle.com/bugs/browse/JDK-6809322 > > Thanks, > > -JB- > From alan.bateman at oracle.com Thu Oct 11 03:48:55 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Thu, 11 Oct 2012 10:48:55 +0000 Subject: hg: jdk8/tl/jdk: 7186817: Remove Windows 95/98/ME Support Message-ID: <20121011104917.8EB17472B5@hg.openjdk.java.net> Changeset: c2be39b27e1c Author: dxu Date: 2012-10-11 11:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2be39b27e1c 7186817: Remove Windows 95/98/ME Support Reviewed-by: alanb ! make/java/java/Makefile ! makefiles/CompileNativeLibraries.gmk - src/windows/classes/java/io/Win32FileSystem.java ! src/windows/classes/java/io/WinNTFileSystem.java ! src/windows/native/java/io/FileSystem_md.c - src/windows/native/java/io/Win32FileSystem_md.c ! src/windows/native/java/io/WinNTFileSystem_md.c ! src/windows/native/java/io/io_util_md.c ! src/windows/native/java/lang/ProcessImpl_md.c ! src/windows/native/java/util/TimeZone_md.c ! test/java/io/pathNames/win32/bug6344646.java From rob.mckenna at oracle.com Thu Oct 11 10:22:05 2012 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Thu, 11 Oct 2012 17:22:05 +0000 Subject: hg: jdk8/tl/jdk: 7152183: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently [sol] Message-ID: <20121011172249.A4DF2472C4@hg.openjdk.java.net> Changeset: 7c2f5e52863c Author: robm Date: 2012-10-11 18:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7c2f5e52863c 7152183: TEST_BUG: java/lang/ProcessBuilder/Basic.java failing intermittently [sol] Reviewed-by: alanb, martin, dholmes ! test/java/lang/ProcessBuilder/Basic.java From jaroslav.bachorik at oracle.com Thu Oct 11 10:26:19 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 11 Oct 2012 19:26:19 +0200 Subject: jmx-dev [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject In-Reply-To: <5075C26C.50309@oracle.com> References: <50753461.4070009@oracle.com> <5075C26C.50309@oracle.com> Message-ID: <5077013B.9040801@oracle.com> Just to keep it clear - here is the webrev hosted at CR - http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6783290-v1/ -JB- On Wed 10 Oct 2012 08:46:04 PM CEST, Jaroslav Bachorik wrote: > Hi, > > On Wed 10 Oct 2012 05:49:11 PM CEST, Eamonn McManus wrote: >> Hi Jaroslav, >> >> The patch looks correct and the test is ingenious. >> >> I do not understand why the previous SerializationTest needs to be >> deleted. It doesn't seem that the new test is covering the same >> things. > > I need to check that. I copied the SerializationTest.java to > SerializationTest1.java - apparently the cooperation of the webrev and > mercurial queues has its glitches :( > > I am attaching the corrected webrev. > > -JB- > >> >> Reviewed-by: emcmanus >> >> Incidentally I was not able to find a way to see the patch with the >> usual webrev browser UI. Is there a link for that? >> >> Regards, >> ?amonn >> >> >> 2012/10/10 Jaroslav Bachorik : >>> I am looking for a review and a sponsor for this fix. >>> >>> The issue is about an empty array of descriptors being written as a part >>> of the serialization process but not read when deserializing an >>> MBeanInfo/MBeanFeatureInfo instance. While the current ObjectInputStream >>> skips all unread custom written fields it is not a behaviour required by >>> the specification and may cause problems. >>> >>> The patch makes the array to be read in all cases - even when it is >>> known to be an empty one. That way all that has been written as a part >>> of serialization is read back. >>> >>> The webrev with the fix and test is available @ >>> https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6783290 >>> >>> -JB- > > From eamonn at mcmanus.net Thu Oct 11 10:42:24 2012 From: eamonn at mcmanus.net (Eamonn McManus) Date: Thu, 11 Oct 2012 10:42:24 -0700 Subject: jmx-dev [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject In-Reply-To: <5077013B.9040801@oracle.com> References: <50753461.4070009@oracle.com> <5075C26C.50309@oracle.com> <5077013B.9040801@oracle.com> Message-ID: Looks good. A couple of minor nits about the test: there is a stray IDE template comment on line 74, and the copyright date is wrong. ?amonn 2012/10/11 Jaroslav Bachorik : > Just to keep it clear - here is the webrev hosted at CR - > http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6783290-v1/ > > -JB- > > On Wed 10 Oct 2012 08:46:04 PM CEST, Jaroslav Bachorik wrote: >> Hi, >> >> On Wed 10 Oct 2012 05:49:11 PM CEST, Eamonn McManus wrote: >>> Hi Jaroslav, >>> >>> The patch looks correct and the test is ingenious. >>> >>> I do not understand why the previous SerializationTest needs to be >>> deleted. It doesn't seem that the new test is covering the same >>> things. >> >> I need to check that. I copied the SerializationTest.java to >> SerializationTest1.java - apparently the cooperation of the webrev and >> mercurial queues has its glitches :( >> >> I am attaching the corrected webrev. >> >> -JB- >> >>> >>> Reviewed-by: emcmanus >>> >>> Incidentally I was not able to find a way to see the patch with the >>> usual webrev browser UI. Is there a link for that? >>> >>> Regards, >>> ?amonn >>> >>> >>> 2012/10/10 Jaroslav Bachorik : >>>> I am looking for a review and a sponsor for this fix. >>>> >>>> The issue is about an empty array of descriptors being written as a part >>>> of the serialization process but not read when deserializing an >>>> MBeanInfo/MBeanFeatureInfo instance. While the current ObjectInputStream >>>> skips all unread custom written fields it is not a behaviour required by >>>> the specification and may cause problems. >>>> >>>> The patch makes the array to be read in all cases - even when it is >>>> known to be an empty one. That way all that has been written as a part >>>> of serialization is read back. >>>> >>>> The webrev with the fix and test is available @ >>>> https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6783290 >>>> >>>> -JB- >> >> > > From john.coomes at oracle.com Thu Oct 11 14:57:57 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 11 Oct 2012 21:57:57 +0000 Subject: hg: hsx/hotspot-rt: 4 new changesets Message-ID: <20121011215757.7CA37472E6@hg.openjdk.java.net> Changeset: dae9821589cc Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/dae9821589cc Added tag jdk8-b58 for changeset 936702480487 ! .hgtags Changeset: b9d574659206 Author: katleman Date: 2012-10-04 14:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/b9d574659206 Added tag jdk8-b59 for changeset dae9821589cc ! .hgtags Changeset: 4b54d77a6831 Author: dholmes Date: 2012-10-09 02:08 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/4b54d77a6831 8000461: Top level build doesn't pass OPENJDK=true through to the hotspot build Summary: Add OPENJDK to the COMMON_BUILD_ARGUMENTS Reviewed-by: tbell ! make/Defs-internal.gmk Changeset: e07f499b9dcc Author: katleman Date: 2012-10-10 14:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/e07f499b9dcc Merge From john.coomes at oracle.com Thu Oct 11 14:58:00 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 11 Oct 2012 21:58:00 +0000 Subject: hg: hsx/hotspot-rt/corba: 2 new changesets Message-ID: <20121011215803.505D2472E7@hg.openjdk.java.net> Changeset: d54dc53e223e Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/d54dc53e223e Added tag jdk8-b58 for changeset 18462a19f7bd ! .hgtags Changeset: 207ef43ba69e Author: katleman Date: 2012-10-04 14:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/207ef43ba69e Added tag jdk8-b59 for changeset d54dc53e223e ! .hgtags From john.coomes at oracle.com Thu Oct 11 14:58:07 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 11 Oct 2012 21:58:07 +0000 Subject: hg: hsx/hotspot-rt/jaxp: 2 new changesets Message-ID: <20121011215824.D5A46472E8@hg.openjdk.java.net> Changeset: af9e8b0f1900 Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/af9e8b0f1900 Added tag jdk8-b58 for changeset 1cb19abb3f7b ! .hgtags Changeset: 2d1dff5310da Author: katleman Date: 2012-10-04 14:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/2d1dff5310da Added tag jdk8-b59 for changeset af9e8b0f1900 ! .hgtags From john.coomes at oracle.com Thu Oct 11 14:58:37 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 11 Oct 2012 21:58:37 +0000 Subject: hg: hsx/hotspot-rt/jaxws: 2 new changesets Message-ID: <20121011215851.B4F6F472E9@hg.openjdk.java.net> Changeset: ae107401be11 Author: katleman Date: 2012-09-27 11:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/ae107401be11 Added tag jdk8-b58 for changeset cac4c3937063 ! .hgtags Changeset: 5c5a65ad5291 Author: katleman Date: 2012-10-04 14:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/5c5a65ad5291 Added tag jdk8-b59 for changeset ae107401be11 ! .hgtags From john.coomes at oracle.com Thu Oct 11 15:00:56 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 11 Oct 2012 22:00:56 +0000 Subject: hg: hsx/hotspot-rt/jdk: 64 new changesets Message-ID: <20121011221412.C325C472EE@hg.openjdk.java.net> Changeset: 8a64eeca4450 Author: jgodinez Date: 2012-09-10 10:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8a64eeca4450 7183516: [macosx]Can't print-out the defined fonts for PrintFont_2D and AntialiasTableTest. Reviewed-by: bae, prr ! src/macosx/native/sun/awt/CTextPipe.m Changeset: db828a233f20 Author: bae Date: 2012-09-11 13:32 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/db828a233f20 7181199: [macosx] Startup is much slower in headless mode for apps using Fonts Reviewed-by: jgodinez, prr ! src/macosx/classes/sun/font/CFontManager.java Changeset: bce9611f1e8f Author: lana Date: 2012-09-14 13:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bce9611f1e8f Merge ! src/macosx/native/sun/awt/CTextPipe.m Changeset: 0ecf1a700fca Author: bae Date: 2012-09-17 13:44 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0ecf1a700fca 7186799: Regression tests for ImageIO metadata fail on second run Reviewed-by: prr, bae Contributed-by: Vadim Pakhnushev ! test/javax/imageio/metadata/BooleanAttributes.java ! test/javax/imageio/metadata/DOML3Node.java + test/javax/imageio/metadata/GetChildNames.java + test/javax/imageio/metadata/GetObjectMinValue.java + test/javax/imageio/metadata/IIOMetadataFormat/MetadataFormatTest.java + test/javax/imageio/metadata/IIOMetadataFormat/MetadataFormatThreadTest.java + test/javax/imageio/metadata/IIOMetadataFormat/MetadataTest.java + test/javax/imageio/metadata/IIOMetadataFormat/UserPluginMetadataFormatTest.java + test/javax/imageio/metadata/IIOMetadataFormat/runMetadataFormatTest.sh + test/javax/imageio/metadata/IIOMetadataFormat/runMetadataFormatThreadTest.sh + test/javax/imageio/metadata/IIOMetadataFormatImplTest.java + test/javax/imageio/metadata/MetadataFormatPrinter.java + test/javax/imageio/metadata/ObjectArrayMaxLength.java + test/javax/imageio/metadata/RegisteredFormatsTest.java + test/javax/imageio/metadata/RemoveElement.java + test/javax/imageio/metadata/SetAttributeNode.java Changeset: 47442b1b01eb Author: kizune Date: 2012-09-06 14:59 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/47442b1b01eb 7175183: [macosx] Objective-C exception thrown when switching monitor configuration Reviewed-by: prr, serb ! src/share/classes/sun/awt/image/VolatileSurfaceManager.java Changeset: d14dc0ae1c2c Author: bagiras Date: 2012-09-06 17:57 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d14dc0ae1c2c 7153339: InternalError when drawLine with Xor and Antialiasing Reviewed-by: prr, flar ! src/windows/classes/sun/java2d/ScreenUpdateManager.java Changeset: b8a1ff892b33 Author: alexsch Date: 2012-09-07 13:08 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b8a1ff892b33 7194469: Pressing the Enter key results in an alert tone beep when focus is TextField Reviewed-by: bagiras, denis ! src/windows/native/sun/windows/awt_TextField.cpp Changeset: 04292c0c943b Author: malenkov Date: 2012-09-11 10:58 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/04292c0c943b 7193977: REGRESSION:Java 7's JavaBeans persistence ignoring the "transient" flag on properties Reviewed-by: rupashka ! src/share/classes/java/beans/IndexedPropertyDescriptor.java ! src/share/classes/java/beans/Introspector.java ! src/share/classes/java/beans/PropertyDescriptor.java + test/java/beans/Introspector/Test7193977.java Changeset: 3a2f5544dd00 Author: serb Date: 2012-09-12 21:16 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3a2f5544dd00 7124534: [macosx] Submenu title overlaps with Submenu indicator in JPopupMenu Reviewed-by: art + test/javax/swing/JMenuItem/6438430/bug6438430.java Changeset: aa35dc4d3f70 Author: bagiras Date: 2012-09-13 19:53 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/aa35dc4d3f70 7186109: Simplify lock machinery for PostEventQueue & EventQueue Reviewed-by: art, anthony, dholmes ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/sun/awt/SunToolkit.java + test/java/awt/EventQueue/PostEventOrderingTest/PostEventOrderingTest.java Changeset: 5b7ad5bedbd7 Author: bagiras Date: 2012-09-13 21:23 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5b7ad5bedbd7 7198318: SunToolkitSubclass.java should be removed Reviewed-by: serb - src/macosx/classes/sun/awt/SunToolkitSubclass.java Changeset: 5444be588d18 Author: alexsch Date: 2012-09-14 15:08 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5444be588d18 7197320: [macosx] Full Screen option missing when Window.documentModified Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 77fdcd3df205 Author: alexsch Date: 2012-09-14 15:30 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/77fdcd3df205 7196547: [macosx] Implement dead key detection for KeyEvent Reviewed-by: skovatch, kizune ! src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java ! src/macosx/native/sun/awt/AWTEvent.m + test/java/awt/event/KeyEvent/DeadKey/deadKeyMacOSX.java Changeset: 1785f8335f4d Author: VKARNAUK Date: 2012-09-14 19:51 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1785f8335f4d 6994562: Swing classes (both JTextArea and JTextField) don't support caret width tuning Reviewed-by: rupashka, art ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/javax/swing/text/DefaultCaret.java ! src/windows/native/sun/windows/awt_DesktopProperties.cpp ! src/windows/native/sun/windows/awt_DesktopProperties.h Changeset: b6ad3339f3f4 Author: lana Date: 2012-09-14 14:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b6ad3339f3f4 Merge Changeset: 1ed7fec79bee Author: leonidr Date: 2012-09-17 17:25 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1ed7fec79bee 7160951: ActionListener called twice for JMenuItem using ScreenMenuBar Reviewed-by: anthony, serb Contributed-by: Marco Dinacci ! src/macosx/native/sun/awt/AWTEvent.h ! src/macosx/native/sun/awt/AWTEvent.m ! src/macosx/native/sun/awt/CDragSource.m ! src/macosx/native/sun/awt/CMenuItem.m ! src/macosx/native/sun/awt/DnDUtilities.h ! src/macosx/native/sun/awt/DnDUtilities.m Changeset: 1d1254af05dd Author: kshefov Date: 2012-09-18 17:38 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1d1254af05dd 7190587: Open source and jtreg'ify JAWT regression test Reviewed-by: anthony, omajid + test/java/awt/JAWT/JAWT.sh + test/java/awt/JAWT/Makefile.cygwin + test/java/awt/JAWT/Makefile.unix + test/java/awt/JAWT/Makefile.win + test/java/awt/JAWT/MyCanvas.java + test/java/awt/JAWT/myfile.c + test/java/awt/JAWT/myfile.cpp Changeset: a96f5b1d03f9 Author: lana Date: 2012-09-19 12:38 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a96f5b1d03f9 Merge - src/macosx/classes/sun/awt/SunToolkitSubclass.java Changeset: 076d0dafea5f Author: mgerdin Date: 2012-09-06 14:07 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/076d0dafea5f 7195557: NPG: Unexpected number of memory pools Summary: Update management tests to work with a VM without a permanent generation memory pool Reviewed-by: rbackman, brutisso, sla, dholmes ! test/java/lang/management/MemoryMXBean/CollectionUsageThreshold.java ! test/java/lang/management/MemoryMXBean/MemoryTest.java Changeset: 8c6895afe204 Author: lancea Date: 2012-09-06 13:16 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8c6895afe204 7192302: Remove JDBCRowSetImpl dependency on java.beans Reviewed-by: alanb, mchung ! src/share/classes/com/sun/rowset/JdbcRowSetImpl.java Changeset: 833f4630f3a1 Author: weijun Date: 2012-09-07 10:24 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/833f4630f3a1 7196677: diff compares same file to itself in PaddingTest regression test. Reviewed-by: xuelei ! test/com/sun/crypto/provider/Cipher/DES/PaddingTest.java Changeset: d5d24c08f0dc Author: chegar Date: 2012-09-07 14:00 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d5d24c08f0dc 7032247: java/net/InetAddress/GetLocalHostWithSM.java fails if hostname resolves to loopback address Summary: TESTBUG Reviewed-by: chegar, alanb Contributed-by: Eric Wang ! test/java/net/InetAddress/GetLocalHostWithSM.java Changeset: 3857114d8255 Author: chegar Date: 2012-09-07 15:30 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3857114d8255 6354758: rename old test HttpServer classes Reviewed-by: chegar, michaelm, khazra Contributed-by: John Zavgren ! test/java/net/Authenticator/B4678055.java ! test/java/net/Authenticator/B4722333.java ! test/java/net/Authenticator/B4759514.java ! test/java/net/Authenticator/B4769350.java ! test/java/net/Authenticator/B4921848.java ! test/java/net/Authenticator/B4933582.java ! test/java/net/Authenticator/B4962064.java ! test/java/net/CookieHandler/CookieManagerTest.java ! test/java/net/ProxySelector/LoopbackAddresses.java ! test/java/net/ProxySelector/ProxyTest.java ! test/java/net/URL/PerConnectionProxy.java ! test/java/net/URLConnection/B5052093.java ! test/sun/net/www/AuthHeaderTest.java ! test/sun/net/www/http/ChunkedInputStream/ChunkedEncodingWithProgressMonitorTest.java ! test/sun/net/www/http/KeepAliveCache/B5045306.java - test/sun/net/www/httptest/HttpServer.java ! test/sun/net/www/httptest/HttpTransaction.java + test/sun/net/www/httptest/TestHttpServer.java ! test/sun/net/www/protocol/http/B6296310.java ! test/sun/net/www/protocol/http/B6299712.java ! test/sun/net/www/protocol/http/RelativeRedirect.java ! test/sun/net/www/protocol/http/ResponseCacheStream.java ! test/sun/net/www/protocol/http/SetChunkedStreamingMode.java ! test/sun/security/ssl/sun/net/www/http/ChunkedOutputStream/Test.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java ! test/sun/security/ssl/sun/net/www/httpstest/HttpTransaction.java + test/sun/security/ssl/sun/net/www/httpstest/TestHttpsServer.java ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/B6216082.java Changeset: 7f081e14364e Author: mullan Date: 2012-09-07 12:49 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7f081e14364e 4647343: IDENT variable in sun.security.x509 classes not used Reviewed-by: mullan Contributed-by: jason.uh at oracle.com - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java ! src/share/classes/sun/security/x509/X509CertImpl.java ! src/share/classes/sun/security/x509/X509CertInfo.java Changeset: fffbb33df102 Author: coffeys Date: 2012-09-07 21:22 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/fffbb33df102 7180362: RFE: Implement date cutover functionality for currency.properties file Reviewed-by: naoto ! src/share/classes/java/util/Currency.java ! test/java/util/Currency/PropertiesTest.java ! test/java/util/Currency/PropertiesTest.sh ! test/java/util/Currency/currency.properties Changeset: a51f86e2dce9 Author: mullan Date: 2012-09-10 08:57 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a51f86e2dce9 7195301: XML Signature DOM implementation should not use instanceof to determine type of Node Reviewed-by: xuelei ! src/share/classes/com/sun/org/apache/xml/internal/security/Init.java ! src/share/classes/com/sun/org/apache/xml/internal/security/c14n/implementations/CanonicalizerBase.java ! src/share/classes/com/sun/org/apache/xml/internal/security/encryption/XMLCipher.java ! src/share/classes/com/sun/org/apache/xml/internal/security/keys/keyresolver/implementations/RetrievalMethodResolver.java ! src/share/classes/com/sun/org/apache/xml/internal/security/utils/IdResolver.java Changeset: a14d41fd6f51 Author: mullan Date: 2012-09-10 09:00 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a14d41fd6f51 Merge - make/sun/beans/Makefile - src/share/classes/sun/beans/editors/BooleanEditor.java - src/share/classes/sun/beans/editors/ByteEditor.java - src/share/classes/sun/beans/editors/ColorEditor.java - src/share/classes/sun/beans/editors/DoubleEditor.java - src/share/classes/sun/beans/editors/EnumEditor.java - src/share/classes/sun/beans/editors/FloatEditor.java - src/share/classes/sun/beans/editors/FontEditor.java - src/share/classes/sun/beans/editors/IntegerEditor.java - src/share/classes/sun/beans/editors/LongEditor.java - src/share/classes/sun/beans/editors/NumberEditor.java - src/share/classes/sun/beans/editors/ShortEditor.java - src/share/classes/sun/beans/editors/StringEditor.java - src/share/classes/sun/beans/infos/ComponentBeanInfo.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - src/solaris/classes/sun/awt/X11/XTextTransferHelper.java - test/javax/swing/JColorChooser/Test4380468.html - test/javax/swing/JColorChooser/Test4380468.java - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: 657f7cb0da7e Author: mullan Date: 2012-09-10 09:18 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/657f7cb0da7e Merge Changeset: 2598dad44449 Author: dsamersoff Date: 2012-09-11 19:58 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2598dad44449 7194597: Typeo in com.sun.management.VMOption.toString() Summary: VMOption.toString() returns "...(read-only)" if writable "...(read-write)" otherwise. Reviewed-by: alanb, mchung Contributed-by: dmytro_sheyko at hotmail.com ! src/share/classes/com/sun/management/VMOption.java Changeset: 1f7c783e4f13 Author: dxu Date: 2012-08-31 13:42 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1f7c783e4f13 7193406: Clean-up JDK Build Warnings in java.util, java.io Summary: Clean-up JDK Build Warnings in java.util, java.io Packages Reviewed-by: smarks, darcy, khazra, dholmes, forax, dl, andrew, aph, omajid, ulfzibis, christos, mduigou ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Method.java ! src/share/classes/java/net/SocketPermission.java ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/share/classes/java/nio/channels/FileChannel.java ! src/share/classes/java/util/ArrayDeque.java ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/ComparableTimSort.java ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/JumboEnumSet.java ! src/share/classes/java/util/PriorityQueue.java ! src/share/classes/java/util/PropertyPermission.java ! src/share/classes/java/util/PropertyResourceBundle.java ! src/share/classes/java/util/jar/JarVerifier.java ! src/share/classes/java/util/jar/Pack200.java ! src/share/classes/sun/util/PreHashedMap.java Changeset: 7a16cd3bd2d9 Author: mullan Date: 2012-09-12 15:20 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7a16cd3bd2d9 7196593: java.security.debug=help doesn't list certpath option Reviewed-by: mullan, wetmore, valeriep Contributed-by: jason.uh at oracle.com ! src/share/classes/sun/security/util/Debug.java Changeset: f8c1cf072ba6 Author: mullan Date: 2012-09-12 15:21 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f8c1cf072ba6 Merge Changeset: e095be3820ee Author: chegar Date: 2012-09-13 11:17 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e095be3820ee 7197203: sun/misc/URLClassPath/ClassnameCharTest.sh failed, compile error Reviewed-by: alanb ! test/sun/misc/URLClassPath/ClassnameCharTest.java - test/sun/misc/URLClassPath/ClassnameCharTest.sh Changeset: e8a3807de977 Author: alanb Date: 2012-09-13 15:04 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e8a3807de977 7197637: (ch) sun.nio.ch.Default* cause providers for other platforms to be included in rt.jar Reviewed-by: mchung ! src/solaris/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java ! src/solaris/classes/sun/nio/ch/DefaultSelectorProvider.java ! src/solaris/classes/sun/nio/fs/DefaultFileSystemProvider.java Changeset: eae1384cff39 Author: mullan Date: 2012-09-14 10:13 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/eae1384cff39 7176627: CertPath/jep124/PreferCRL_SoftFail test fails (Could not determine revocation status) Reviewed-by: xuelei ! src/share/classes/sun/security/provider/certpath/CertStoreHelper.java ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/OCSP.java ! src/share/classes/sun/security/provider/certpath/PKIX.java ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! src/share/classes/sun/security/provider/certpath/URICertStore.java ! src/share/classes/sun/security/provider/certpath/ldap/LDAPCertStoreHelper.java ! src/share/classes/sun/security/provider/certpath/ssl/SSLServerCertStoreHelper.java Changeset: 34bcbb110bb0 Author: mullan Date: 2012-09-14 10:14 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/34bcbb110bb0 Merge - make/sun/beans/Makefile - src/share/classes/sun/beans/editors/BooleanEditor.java - src/share/classes/sun/beans/editors/ByteEditor.java - src/share/classes/sun/beans/editors/ColorEditor.java - src/share/classes/sun/beans/editors/DoubleEditor.java - src/share/classes/sun/beans/editors/EnumEditor.java - src/share/classes/sun/beans/editors/FloatEditor.java - src/share/classes/sun/beans/editors/FontEditor.java - src/share/classes/sun/beans/editors/IntegerEditor.java - src/share/classes/sun/beans/editors/LongEditor.java - src/share/classes/sun/beans/editors/NumberEditor.java - src/share/classes/sun/beans/editors/ShortEditor.java - src/share/classes/sun/beans/editors/StringEditor.java - src/share/classes/sun/beans/infos/ComponentBeanInfo.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - src/solaris/classes/sun/awt/X11/XTextTransferHelper.java - test/javax/swing/JColorChooser/Test4380468.html - test/javax/swing/JColorChooser/Test4380468.java - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: c11cec5a9306 Author: mullan Date: 2012-09-14 10:30 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c11cec5a9306 Merge - test/sun/misc/URLClassPath/ClassnameCharTest.sh Changeset: 22d7a9f73a59 Author: mchung Date: 2012-09-14 09:47 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/22d7a9f73a59 7193302: Remove ConstructorProperties annotation from java.lang.management.LockInfo Reviewed-by: alanb, sla, egahlin ! src/share/classes/java/lang/management/LockInfo.java ! src/share/classes/java/lang/management/ThreadInfo.java - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java + src/share/classes/sun/management/LockInfoCompositeData.java ! src/share/classes/sun/management/MappedMXBeanType.java ! src/share/classes/sun/management/MonitorInfoCompositeData.java ! src/share/classes/sun/management/ThreadInfoCompositeData.java ! test/java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Changeset: 356ff53c9b6d Author: lana Date: 2012-09-14 10:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/356ff53c9b6d Merge - test/java/lang/invoke/MaxTest.java Changeset: 92f3cda88d8e Author: mduigou Date: 2012-09-11 07:42 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/92f3cda88d8e 7189926: Reduce test size for default run. Add additional run enabling alternative hashing. Reviewed-by: alanb ! test/java/util/Map/Collisions.java Changeset: 17881ebf811c Author: mullan Date: 2012-09-16 13:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/17881ebf811c 7195409: CertPath/CertPathValidatorTest/KeyParamsInheritanceTest fails with NullPointerException Reviewed-by: xuelei ! src/share/classes/sun/security/provider/certpath/AlgorithmChecker.java ! src/share/classes/sun/security/provider/certpath/BasicChecker.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/ForwardState.java ! src/share/classes/sun/security/provider/certpath/PKIX.java ! src/share/classes/sun/security/provider/certpath/ReverseState.java ! src/share/classes/sun/security/provider/certpath/RevocationChecker.java ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java Changeset: 0c3b0a82c4fc Author: weijun Date: 2012-09-17 17:19 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0c3b0a82c4fc 7198205: CloseTest fails on mac Reviewed-by: alanb, chegar, michaelm ! test/ProblemList.txt ! test/java/net/URLClassLoader/closetest/CloseTest.java Changeset: 39e97f68fa8c Author: sla Date: 2012-09-17 11:27 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/39e97f68fa8c 7198846: Add javax/management/remote/mandatory/notif/DiffHBTest.java to ProblemList.txt Reviewed-by: alanb ! test/ProblemList.txt Changeset: f56f85040c58 Author: weijun Date: 2012-09-17 18:19 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f56f85040c58 7196855: autotest.sh fails on ubuntu because libsoftokn.so not found Reviewed-by: vinnie ! test/sun/security/tools/keytool/autotest.sh Changeset: 8a454e92aaf1 Author: sla Date: 2012-09-17 12:40 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8a454e92aaf1 7198849: Make javax/management/remote/mandatory/notif/ListenerScaleTest.java less timing sensitive Reviewed-by: alanb ! test/javax/management/remote/mandatory/notif/ListenerScaleTest.java Changeset: e20a2e6a92f7 Author: mduigou Date: 2012-09-17 11:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e20a2e6a92f7 7198988: re-order paramaters for Collision.java @run Reviewed-by: alanb ! test/java/util/Map/Collisions.java Changeset: 53ca38f76eaa Author: weijun Date: 2012-09-18 17:38 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/53ca38f76eaa 7198871: cleanup security tests in problem lists with no CR attached Reviewed-by: alanb ! test/ProblemList.txt Changeset: 95a93f039e5c Author: vinnie Date: 2012-09-18 11:08 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/95a93f039e5c 7198901: correct the field size check when decoding a point on ECC curve Reviewed-by: xuelei ! src/share/classes/sun/security/ec/ECParameters.java Changeset: bc5e7ec12717 Author: dxu Date: 2012-09-18 13:14 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bc5e7ec12717 7142919: TEST_BUG: java/nio/channels/AsyncCloseAndInterrupt.java failing intermittently [sol11] Reviewed-by: alanb ! test/ProblemList.txt ! test/java/nio/channels/AsyncCloseAndInterrupt.java Changeset: 88a4f699d233 Author: xuelei Date: 2012-09-18 06:51 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/88a4f699d233 7199066: Typo in method name Reviewed-by: mullan ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketFactoryImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketImpl.java ! src/share/classes/sun/security/ssl/SSLSocketFactoryImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: 0136fca60652 Author: naoto Date: 2012-09-18 10:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0136fca60652 7198984: Add java/text/Bidi/Bug6665028.java to ProblemList.txt Reviewed-by: alanb Contributed-by: yiming.wang at oracle.com ! test/ProblemList.txt Changeset: e7add6d98729 Author: mduigou Date: 2012-09-18 11:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e7add6d98729 7199249: TEST_BUG : Add /othervm to Collisions.java @run main with -D definitions Reviewed-by: alanb ! test/java/util/Map/Collisions.java Changeset: db381a2c0083 Author: alanb Date: 2012-09-18 21:21 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/db381a2c0083 7190273: Deprecate com.sun.security.auth.callback.DialogCallbackHandler Reviewed-by: mullan ! src/share/classes/com/sun/security/auth/callback/DialogCallbackHandler.java Changeset: e143d8f8e477 Author: dxu Date: 2012-09-18 14:45 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/e143d8f8e477 7195933: There is incorrect link to "Info-ZIP Application Note 970311" in doc page of Package java.util.zip Summary: Correct a java doc link in java.util.zip package page Reviewed-by: chegar, lancea, sherman Contributed-by: dan.xu at oracle.com ! src/share/classes/java/util/zip/package.html Changeset: 045a0962b430 Author: mchung Date: 2012-09-18 15:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/045a0962b430 7198070: Eliminate static dependency from JMX to java.beans.ConstructorProperties Reviewed-by: alanb ! src/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java Changeset: 5d064862376d Author: jgish Date: 2012-09-19 08:52 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5d064862376d 4722265: (spec str) StringBuffer.ensureCapacity() should mention that capacity is mutable Summary: add usage note to AbstractStringBuilder ensureCapacity() Reviewed-by: mduigou, dholmes, chegar ! src/share/classes/java/lang/AbstractStringBuilder.java Changeset: 27182d84a244 Author: chegar Date: 2012-09-19 14:55 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/27182d84a244 7199500: Minor typo in AbstractStringBuilder.java header Reviewed-by: coffeys ! src/share/classes/java/lang/AbstractStringBuilder.java Changeset: 002717a1418f Author: lana Date: 2012-09-19 12:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/002717a1418f Merge - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - test/sun/misc/URLClassPath/ClassnameCharTest.sh - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: 3f876919cd58 Author: lana Date: 2012-09-24 21:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3f876919cd58 Merge - src/macosx/classes/sun/awt/SunToolkitSubclass.java - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - test/sun/misc/URLClassPath/ClassnameCharTest.sh - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: 4015dec20965 Author: amurillo Date: 2012-09-26 13:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4015dec20965 Merge - src/macosx/classes/sun/awt/SunToolkitSubclass.java - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java ! test/ProblemList.txt - test/sun/misc/URLClassPath/ClassnameCharTest.sh - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: c9568c94c4e7 Author: ohair Date: 2012-09-21 12:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c9568c94c4e7 7191703: jprt cannot build jdk on MacOSX. Reviewed-by: anthony ! make/common/shared/Defs.gmk ! make/java/jobjc/Makefile Changeset: d94613ac03d8 Author: katleman Date: 2012-09-26 22:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d94613ac03d8 Merge - src/macosx/classes/sun/awt/SunToolkitSubclass.java - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - test/sun/misc/URLClassPath/ClassnameCharTest.sh - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: abad1f417bd3 Author: katleman Date: 2012-09-27 11:25 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/abad1f417bd3 Added tag jdk8-b58 for changeset d94613ac03d8 ! .hgtags Changeset: cec8fa02f156 Author: katleman Date: 2012-10-04 14:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cec8fa02f156 Added tag jdk8-b59 for changeset abad1f417bd3 ! .hgtags From john.coomes at oracle.com Thu Oct 11 15:20:06 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Thu, 11 Oct 2012 22:20:06 +0000 Subject: hg: hsx/hotspot-rt/langtools: 12 new changesets Message-ID: <20121011222032.99EAE472F5@hg.openjdk.java.net> Changeset: 489905e5018e Author: jjg Date: 2012-09-07 11:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/489905e5018e 7186925: JavapTask passes null to java.io.Writer Reviewed-by: jjh ! src/share/classes/com/sun/tools/javap/JavapTask.java + test/tools/javap/T7186925.java Changeset: 324b98626f58 Author: jjg Date: 2012-09-07 11:24 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/324b98626f58 7196774: javac cannot be built with JDK 6 after 7151010 Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Annotate.java Changeset: 1a7c11b22192 Author: jjg Date: 2012-09-07 11:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/1a7c11b22192 7196760: tree end positions incorrect after anno processing Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/api/EndPositions.java Changeset: fa85af323d97 Author: bpatel Date: 2012-09-08 22:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/fa85af323d97 7180906: Javadoc tool does not apply parameter -nosince Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java + test/com/sun/javadoc/testSinceTag/TestSinceTag.java + test/com/sun/javadoc/testSinceTag/pkg1/C1.java Changeset: b2064a216117 Author: bpatel Date: 2012-09-08 22:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/b2064a216117 Merge Changeset: 30c36e23f154 Author: jjg Date: 2012-09-13 14:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/30c36e23f154 7177970: fix issues in langtools doc comments Reviewed-by: mcimadamore ! src/share/classes/com/sun/javadoc/Doc.java ! src/share/classes/com/sun/javadoc/ExecutableMemberDoc.java ! src/share/classes/com/sun/javadoc/Tag.java ! src/share/classes/com/sun/source/tree/LambdaExpressionTree.java ! src/share/classes/com/sun/source/tree/LineMap.java ! src/share/classes/com/sun/source/util/TreeScanner.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/ByteCodes.java ! src/share/classes/com/sun/tools/javac/jvm/CRTable.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Lexer.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/util/Bits.java ! src/share/classes/com/sun/tools/javac/util/Context.java ! src/share/classes/com/sun/tools/javac/util/Name.java ! src/share/classes/com/sun/tools/javac/util/Position.java ! src/share/classes/com/sun/tools/javadoc/Comment.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/javax/lang/model/util/Elements.java ! src/share/classes/javax/tools/JavaCompiler.java Changeset: fabfd2710057 Author: ksrini Date: 2012-09-14 09:21 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/fabfd2710057 7192073: (javac) minor refactoring of tree maker to help IDEs Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java Changeset: 8c3c714eb7de Author: lana Date: 2012-09-14 10:15 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/8c3c714eb7de Merge Changeset: a433bd8f3ba9 Author: lana Date: 2012-09-14 13:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/a433bd8f3ba9 Merge Changeset: 804a3fbc86e2 Author: lana Date: 2012-09-24 21:11 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/804a3fbc86e2 Merge Changeset: f299927fc316 Author: katleman Date: 2012-09-27 11:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/f299927fc316 Added tag jdk8-b58 for changeset 804a3fbc86e2 ! .hgtags Changeset: 3d2b98ffcb53 Author: katleman Date: 2012-10-04 14:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/3d2b98ffcb53 Added tag jdk8-b59 for changeset f299927fc316 ! .hgtags From lance.andersen at oracle.com Thu Oct 11 15:46:48 2012 From: lance.andersen at oracle.com (lance.andersen at oracle.com) Date: Thu, 11 Oct 2012 22:46:48 +0000 Subject: hg: jdk8/tl/jdk: 8000763: use XXX.valueOf methods instead of constructors Message-ID: <20121011224713.E2717472FA@hg.openjdk.java.net> Changeset: daabaafd6798 Author: lancea Date: 2012-10-11 18:46 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/daabaafd6798 8000763: use XXX.valueOf methods instead of constructors Reviewed-by: mchung, forax ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java ! src/share/classes/com/sun/rowset/FilteredRowSetImpl.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java ! src/share/classes/javax/sql/rowset/serial/SQLOutputImpl.java From keith.mcguigan at oracle.com Thu Oct 11 17:26:48 2012 From: keith.mcguigan at oracle.com (keith.mcguigan at oracle.com) Date: Fri, 12 Oct 2012 00:26:48 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7054345: Support version 52.0 class file in HotSpot Message-ID: <20121012002654.A54B5472FE@hg.openjdk.java.net> Changeset: 48a75d2640a5 Author: kamg Date: 2012-10-11 14:27 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/48a75d2640a5 7054345: Support version 52.0 class file in HotSpot Summary: Accept classfiles with major version 52 Reviewed-by: coleenp, acorn ! src/share/vm/classfile/classFileParser.cpp From david.holmes at oracle.com Thu Oct 11 19:44:31 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 12 Oct 2012 12:44:31 +1000 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <50767E5A.7060908@oracle.com> References: <5075835F.3050604@oracle.com> <50767E5A.7060908@oracle.com> Message-ID: <5077840F.6050601@oracle.com> Hi Jaroslav, On 11/10/2012 6:07 PM, Jaroslav Bachorik wrote: > Dmitry has put the webrev on the public CR - > http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/ > > Thanks! > > -JB- > > On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >> I am looking for a review and a sponsor. >> >> The issue is about some javax.management.timer.Timer notifications not >> being received by the listeners if the notifications are generated rapidly. >> >> The problem is caused by ConcurrentModificationException being thrown - >> the exception itself is ignored but the dispatcher logic is skipped. >> Therefore the currently processed notification gets lost. Can you point out where exactly in the code the exception is thrown and caught. I'd like to understand the problem better. >> >> The CME is thrown due to the Timer.timerTable being iterated over while >> other threads try to remove some of its elements. Fix consists of >> replacing the Hashtable used for Timer.timerTable by ConcurrentHashMap >> which handles such situations with grace. Be aware that it may also give surprising results as removal is no longer synchronized at all with processing. So it could now appear that a notification is processed after a listener has been removed. David ----- >> The patch webrev is available @ >> https://jbs.oracle.com/bugs/browse/JDK-6809322 >> >> Thanks, >> >> -JB- >> > From rickard.backman at oracle.com Thu Oct 11 22:06:08 2012 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Fri, 12 Oct 2012 07:06:08 +0200 Subject: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval In-Reply-To: <86F37B4C-6211-47BE-ACB8-F6FC5FEAD16A@oracle.com> References: <944656E5-9306-411E-A916-4DDC95E819D4@oracle.com> <892BC3F6-C669-41E9-9536-CD5879309480@oracle.com> <5073D661.1080908@oracle.com> <5074081F.1040807@oracle.com> <50741210.7080800@oracle.com> <86F37B4C-6211-47BE-ACB8-F6FC5FEAD16A@oracle.com> Message-ID: People, I need at least one more reviewer, thanks! /R On Oct 9, 2012, at 3:00 PM, Rickard B?ckman wrote: > David, > > thanks for your review! > > /R > > On Oct 9, 2012, at 2:01 PM, David Holmes wrote: > >> On 9/10/2012 9:42 PM, Rickard B?ckman wrote: >>> David, >>> see inline. >>> >>> On Oct 9, 2012, at 1:18 PM, David Holmes wrote: >>> >>>> On 9/10/2012 7:36 PM, Rickard B?ckman wrote: >>>>> David, >>>>> >>>>> thanks for your reply! >>>>> I've changed the code according to the suggestions, I've also changed the types in PeriodicTask from being a size_t to being a >>>>> jint (see updated webrev for details). >>>> >>>> But now the type changes have been pushed out to the task creators. Most task creations pass an int already but BiasedLocking uses a size_t. Just shows how messed up the typing was to begin with. >>> >>> Agreed. Two ways of solving it, 1) change the callers to use an int. 2) Do the cast in the constructor (should be safe since we check the possible interval). >> >> int -> size_t shouldn't cause a warning so callers currently passing int are ok. So keeping it as size_t in constructor arg and casting to int before storing internally seems okay. >> >>>> >>>> Minor nit: should be an int rather than jint as these are not Java types. >>> >>> Will fix. >>> >>>> >>>>> To prevent the waiting for very long time (which could overflow, etc) when we don't have any active task, I added an extra if >>>>> so that if we are waiting while no tasks are available, we reset the time_before_wait and consider time_slept to be zero after sleeping. >>>>> That means the first task added will always sleep for the period requested. >>>> >>>> Those semantics seem reasonable. >>>> >>>> The only thing that concerns me here is the affect of calling real_time_tick(0). I can't quite tell what the profiling code does. >>> >>> I could avoid calling that if time_slept = 0 >> >> Ok. You could skip real_time_tick altogether on zero. >> >> I'm generally okay with the approach being taken here, but the changes are disruptive enough that I can't see for sure that existing tasks will be unaffected. I guess time will tell. And let's see what others might spot. >> >> Thanks, >> David (signing off for the night) >> >>> Thanks >>> /R >>> >>>> >>>> David >>>> ----- >>>> >>>>> Updated webrev: >>>>> http://cr.openjdk.java.net/~rbackman/7127792.1/ >>>>> >>>>> Thanks >>>>> /R >>>>> >>>>> On Oct 9, 2012, at 9:46 AM, David Holmes wrote: >>>>> >>>>>> Sorry Rickard, missed the original RFR :) >>>>>> >>>>>> So to be clear here the synopsis concerns changing the period, while the mechanism implemented is for a more general dynamic disenroll / enroll. So changing a period is effected by removing a task and then adding it with the new period. >>>>>> >>>>>> And for anyone not reading the fine-print when you dynamically enroll a task its first firing is somewhat arbitrary - somewhere between the time of enrollment and that time plus its period. >>>>>> >>>>>> src/share/vm/runtime/thread.hpp >>>>>> >>>>>> Can you add a comment: >>>>>> >>>>>> static void stop(); >>>>>> + // Only allow start once the VM is sufficiently initialized >>>>>> + // Otherwise the first task to enroll will trigger the start >>>>>> + static void make_startable(); >>>>>> >>>>>> --- >>>>>> >>>>>> src/share/vm/runtime/thread.cpp >>>>>> >>>>>> We have a bit of type mixing here: >>>>>> >>>>>> - size_t time_to_wait >>>>>> - jlong time_slept >>>>>> - int remaining = time_to_wait >>>>>> >>>>>> I don't understand why Task is using size_t for time intervals. If you make "remaining" a size_t then it will cause issues when you pass it to wait. But I would expect the initialization of "remaining" to cause an unsigned-to-signed conversion warning, so perhaps an explicit cast to silence that. >>>>>> >>>>>> 1203 bool status = PeriodicTask_lock->wait(Mutex::_no_safepoint_check_flag, remaining); >>>>>> 1204 if (status || _should_terminate) { >>>>>> 1205 break; >>>>>> 1206 } >>>>>> >>>>>> Can you rename status to timedout to make the logic more obvious. Also note that you will potentially return with time_slept still at zero, even though you may have slept for an arbitrary amount of time. That seems wrong as zero will then be passed to "tick". >>>>>> >>>>>> 1208 // spurious wakeup of some kind >>>>>> >>>>>> This comment is no longer accurate as you may have been woken up due to a change in the task list, I suggest: >>>>>> >>>>>> // Change to task list or spurious wakeup of some kind >>>>>> >>>>>> 1213 remaining = PeriodicTask::time_to_wait(); >>>>>> 1214 if (remaining == 0) { >>>>>> 1215 continue; >>>>>> 1216 } >>>>>> >>>>>> Can you insert a comment before continue: >>>>>> >>>>>> // Last task was just disenrolled so loop around and wait until >>>>>> // another task gets enrolled >>>>>> continue; >>>>>> >>>>>> >>>>>> 1218 remaining -= time_slept; >>>>>> >>>>>> Again type mixing: subtracting a long from an int. Again a potential warning to get rid of. >>>>>> >>>>>> Also in a long running VM perhaps there have been no periodic tasks for many days and then one turns up. The subtraction could wrap and cause remaining to remain positive. I know you've now documented the uncertainty in the first fire time but this seems somewhat too random. Let's see what others think. :) >>>>>> >>>>>> >>>>>> 1329 PeriodicTask_lock->notify_all(); >>>>>> >>>>>> There is only one thread that waits so notify() will suffice. >>>>>> >>>>>> Thanks, >>>>>> David >>>>>> >>>>>> On 9/10/2012 4:34 PM, Rickard B?ckman wrote: >>>>>>> Trying again, >>>>>>> >>>>>>> can I have a couple of reviews, please? >>>>>>> >>>>>>> /R >>>>>>> >>>>>>> On Oct 4, 2012, at 3:01 PM, Rickard B?ckman wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> can I please have a couple of reviews on the following change: >>>>>>>> >>>>>>>> http://cr.openjdk.java.net/~rbackman/7127792/ >>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127792 >>>>>>>> >>>>>>>> In short the purpose is to enable tasks to change the interval they are executed in. We >>>>>>>> would also like to be able to add (and remove) tasks after the WatcherThread has started. >>>>>>>> >>>>>>>> Thanks >>>>>>>> /R >>>>>>> >>>>> >>> > From markus.gronlund at oracle.com Thu Oct 11 22:29:07 2012 From: markus.gronlund at oracle.com (=?utf-8?Q?Markus_Gr=C3=B6nlund?=) Date: Fri, 12 Oct 2012 07:29:07 +0200 Subject: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval In-Reply-To: References: <944656E5-9306-411E-A916-4DDC95E819D4@oracle.com> <892BC3F6-C669-41E9-9536-CD5879309480@oracle.com> <5073D661.1080908@oracle.com> <5074081F.1040807@oracle.com> <50741210.7080800@oracle.com> <86F37B4C-6211-47BE-ACB8-F6FC5FEAD16A@oracle.com> Message-ID: <9C76558D-E8CB-44C4-BD18-FF35C0E63144@oracle.com> I am ok with this change Rickard. Thanks also to David Holmes for his great feedback and help on this one. /Markus Sent from my iPhone On 12 okt 2012, at 07:06, Rickard B?ckman wrote: > People, > > I need at least one more reviewer, thanks! > > /R > > On Oct 9, 2012, at 3:00 PM, Rickard B?ckman wrote: > >> David, >> >> thanks for your review! >> >> /R >> >> On Oct 9, 2012, at 2:01 PM, David Holmes wrote: >> >>> On 9/10/2012 9:42 PM, Rickard B?ckman wrote: >>>> David, >>>> see inline. >>>> >>>> On Oct 9, 2012, at 1:18 PM, David Holmes wrote: >>>> >>>>> On 9/10/2012 7:36 PM, Rickard B?ckman wrote: >>>>>> David, >>>>>> >>>>>> thanks for your reply! >>>>>> I've changed the code according to the suggestions, I've also changed the types in PeriodicTask from being a size_t to being a >>>>>> jint (see updated webrev for details). >>>>> >>>>> But now the type changes have been pushed out to the task creators. Most task creations pass an int already but BiasedLocking uses a size_t. Just shows how messed up the typing was to begin with. >>>> >>>> Agreed. Two ways of solving it, 1) change the callers to use an int. 2) Do the cast in the constructor (should be safe since we check the possible interval). >>> >>> int -> size_t shouldn't cause a warning so callers currently passing int are ok. So keeping it as size_t in constructor arg and casting to int before storing internally seems okay. >>> >>>>> >>>>> Minor nit: should be an int rather than jint as these are not Java types. >>>> >>>> Will fix. >>>> >>>>> >>>>>> To prevent the waiting for very long time (which could overflow, etc) when we don't have any active task, I added an extra if >>>>>> so that if we are waiting while no tasks are available, we reset the time_before_wait and consider time_slept to be zero after sleeping. >>>>>> That means the first task added will always sleep for the period requested. >>>>> >>>>> Those semantics seem reasonable. >>>>> >>>>> The only thing that concerns me here is the affect of calling real_time_tick(0). I can't quite tell what the profiling code does. >>>> >>>> I could avoid calling that if time_slept = 0 >>> >>> Ok. You could skip real_time_tick altogether on zero. >>> >>> I'm generally okay with the approach being taken here, but the changes are disruptive enough that I can't see for sure that existing tasks will be unaffected. I guess time will tell. And let's see what others might spot. >>> >>> Thanks, >>> David (signing off for the night) >>> >>>> Thanks >>>> /R >>>> >>>>> >>>>> David >>>>> ----- >>>>> >>>>>> Updated webrev: >>>>>> http://cr.openjdk.java.net/~rbackman/7127792.1/ >>>>>> >>>>>> Thanks >>>>>> /R >>>>>> >>>>>> On Oct 9, 2012, at 9:46 AM, David Holmes wrote: >>>>>> >>>>>>> Sorry Rickard, missed the original RFR :) >>>>>>> >>>>>>> So to be clear here the synopsis concerns changing the period, while the mechanism implemented is for a more general dynamic disenroll / enroll. So changing a period is effected by removing a task and then adding it with the new period. >>>>>>> >>>>>>> And for anyone not reading the fine-print when you dynamically enroll a task its first firing is somewhat arbitrary - somewhere between the time of enrollment and that time plus its period. >>>>>>> >>>>>>> src/share/vm/runtime/thread.hpp >>>>>>> >>>>>>> Can you add a comment: >>>>>>> >>>>>>> static void stop(); >>>>>>> + // Only allow start once the VM is sufficiently initialized >>>>>>> + // Otherwise the first task to enroll will trigger the start >>>>>>> + static void make_startable(); >>>>>>> >>>>>>> --- >>>>>>> >>>>>>> src/share/vm/runtime/thread.cpp >>>>>>> >>>>>>> We have a bit of type mixing here: >>>>>>> >>>>>>> - size_t time_to_wait >>>>>>> - jlong time_slept >>>>>>> - int remaining = time_to_wait >>>>>>> >>>>>>> I don't understand why Task is using size_t for time intervals. If you make "remaining" a size_t then it will cause issues when you pass it to wait. But I would expect the initialization of "remaining" to cause an unsigned-to-signed conversion warning, so perhaps an explicit cast to silence that. >>>>>>> >>>>>>> 1203 bool status = PeriodicTask_lock->wait(Mutex::_no_safepoint_check_flag, remaining); >>>>>>> 1204 if (status || _should_terminate) { >>>>>>> 1205 break; >>>>>>> 1206 } >>>>>>> >>>>>>> Can you rename status to timedout to make the logic more obvious. Also note that you will potentially return with time_slept still at zero, even though you may have slept for an arbitrary amount of time. That seems wrong as zero will then be passed to "tick". >>>>>>> >>>>>>> 1208 // spurious wakeup of some kind >>>>>>> >>>>>>> This comment is no longer accurate as you may have been woken up due to a change in the task list, I suggest: >>>>>>> >>>>>>> // Change to task list or spurious wakeup of some kind >>>>>>> >>>>>>> 1213 remaining = PeriodicTask::time_to_wait(); >>>>>>> 1214 if (remaining == 0) { >>>>>>> 1215 continue; >>>>>>> 1216 } >>>>>>> >>>>>>> Can you insert a comment before continue: >>>>>>> >>>>>>> // Last task was just disenrolled so loop around and wait until >>>>>>> // another task gets enrolled >>>>>>> continue; >>>>>>> >>>>>>> >>>>>>> 1218 remaining -= time_slept; >>>>>>> >>>>>>> Again type mixing: subtracting a long from an int. Again a potential warning to get rid of. >>>>>>> >>>>>>> Also in a long running VM perhaps there have been no periodic tasks for many days and then one turns up. The subtraction could wrap and cause remaining to remain positive. I know you've now documented the uncertainty in the first fire time but this seems somewhat too random. Let's see what others think. :) >>>>>>> >>>>>>> >>>>>>> 1329 PeriodicTask_lock->notify_all(); >>>>>>> >>>>>>> There is only one thread that waits so notify() will suffice. >>>>>>> >>>>>>> Thanks, >>>>>>> David >>>>>>> >>>>>>> On 9/10/2012 4:34 PM, Rickard B?ckman wrote: >>>>>>>> Trying again, >>>>>>>> >>>>>>>> can I have a couple of reviews, please? >>>>>>>> >>>>>>>> /R >>>>>>>> >>>>>>>> On Oct 4, 2012, at 3:01 PM, Rickard B?ckman wrote: >>>>>>>> >>>>>>>>> Hi all, >>>>>>>>> >>>>>>>>> can I please have a couple of reviews on the following change: >>>>>>>>> >>>>>>>>> http://cr.openjdk.java.net/~rbackman/7127792/ >>>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127792 >>>>>>>>> >>>>>>>>> In short the purpose is to enable tasks to change the interval they are executed in. We >>>>>>>>> would also like to be able to add (and remove) tasks after the WatcherThread has started. >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> /R > From rickard.backman at oracle.com Thu Oct 11 23:18:03 2012 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Fri, 12 Oct 2012 08:18:03 +0200 Subject: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval In-Reply-To: <9C76558D-E8CB-44C4-BD18-FF35C0E63144@oracle.com> References: <944656E5-9306-411E-A916-4DDC95E819D4@oracle.com> <892BC3F6-C669-41E9-9536-CD5879309480@oracle.com> <5073D661.1080908@oracle.com> <5074081F.1040807@oracle.com> <50741210.7080800@oracle.com> <86F37B4C-6211-47BE-ACB8-F6FC5FEAD16A@oracle.com> <9C76558D-E8CB-44C4-BD18-FF35C0E63144@oracle.com> Message-ID: Thank you Markus. /R On Oct 12, 2012, at 7:29 AM, Markus Gr?nlund wrote: > I am ok with this change Rickard. > > Thanks also to David Holmes for his great feedback and help on this one. > > /Markus > > Sent from my iPhone > > On 12 okt 2012, at 07:06, Rickard B?ckman wrote: > >> People, >> >> I need at least one more reviewer, thanks! >> >> /R >> >> On Oct 9, 2012, at 3:00 PM, Rickard B?ckman wrote: >> >>> David, >>> >>> thanks for your review! >>> >>> /R >>> >>> On Oct 9, 2012, at 2:01 PM, David Holmes wrote: >>> >>>> On 9/10/2012 9:42 PM, Rickard B?ckman wrote: >>>>> David, >>>>> see inline. >>>>> >>>>> On Oct 9, 2012, at 1:18 PM, David Holmes wrote: >>>>> >>>>>> On 9/10/2012 7:36 PM, Rickard B?ckman wrote: >>>>>>> David, >>>>>>> >>>>>>> thanks for your reply! >>>>>>> I've changed the code according to the suggestions, I've also changed the types in PeriodicTask from being a size_t to being a >>>>>>> jint (see updated webrev for details). >>>>>> >>>>>> But now the type changes have been pushed out to the task creators. Most task creations pass an int already but BiasedLocking uses a size_t. Just shows how messed up the typing was to begin with. >>>>> >>>>> Agreed. Two ways of solving it, 1) change the callers to use an int. 2) Do the cast in the constructor (should be safe since we check the possible interval). >>>> >>>> int -> size_t shouldn't cause a warning so callers currently passing int are ok. So keeping it as size_t in constructor arg and casting to int before storing internally seems okay. >>>> >>>>>> >>>>>> Minor nit: should be an int rather than jint as these are not Java types. >>>>> >>>>> Will fix. >>>>> >>>>>> >>>>>>> To prevent the waiting for very long time (which could overflow, etc) when we don't have any active task, I added an extra if >>>>>>> so that if we are waiting while no tasks are available, we reset the time_before_wait and consider time_slept to be zero after sleeping. >>>>>>> That means the first task added will always sleep for the period requested. >>>>>> >>>>>> Those semantics seem reasonable. >>>>>> >>>>>> The only thing that concerns me here is the affect of calling real_time_tick(0). I can't quite tell what the profiling code does. >>>>> >>>>> I could avoid calling that if time_slept = 0 >>>> >>>> Ok. You could skip real_time_tick altogether on zero. >>>> >>>> I'm generally okay with the approach being taken here, but the changes are disruptive enough that I can't see for sure that existing tasks will be unaffected. I guess time will tell. And let's see what others might spot. >>>> >>>> Thanks, >>>> David (signing off for the night) >>>> >>>>> Thanks >>>>> /R >>>>> >>>>>> >>>>>> David >>>>>> ----- >>>>>> >>>>>>> Updated webrev: >>>>>>> http://cr.openjdk.java.net/~rbackman/7127792.1/ >>>>>>> >>>>>>> Thanks >>>>>>> /R >>>>>>> >>>>>>> On Oct 9, 2012, at 9:46 AM, David Holmes wrote: >>>>>>> >>>>>>>> Sorry Rickard, missed the original RFR :) >>>>>>>> >>>>>>>> So to be clear here the synopsis concerns changing the period, while the mechanism implemented is for a more general dynamic disenroll / enroll. So changing a period is effected by removing a task and then adding it with the new period. >>>>>>>> >>>>>>>> And for anyone not reading the fine-print when you dynamically enroll a task its first firing is somewhat arbitrary - somewhere between the time of enrollment and that time plus its period. >>>>>>>> >>>>>>>> src/share/vm/runtime/thread.hpp >>>>>>>> >>>>>>>> Can you add a comment: >>>>>>>> >>>>>>>> static void stop(); >>>>>>>> + // Only allow start once the VM is sufficiently initialized >>>>>>>> + // Otherwise the first task to enroll will trigger the start >>>>>>>> + static void make_startable(); >>>>>>>> >>>>>>>> --- >>>>>>>> >>>>>>>> src/share/vm/runtime/thread.cpp >>>>>>>> >>>>>>>> We have a bit of type mixing here: >>>>>>>> >>>>>>>> - size_t time_to_wait >>>>>>>> - jlong time_slept >>>>>>>> - int remaining = time_to_wait >>>>>>>> >>>>>>>> I don't understand why Task is using size_t for time intervals. If you make "remaining" a size_t then it will cause issues when you pass it to wait. But I would expect the initialization of "remaining" to cause an unsigned-to-signed conversion warning, so perhaps an explicit cast to silence that. >>>>>>>> >>>>>>>> 1203 bool status = PeriodicTask_lock->wait(Mutex::_no_safepoint_check_flag, remaining); >>>>>>>> 1204 if (status || _should_terminate) { >>>>>>>> 1205 break; >>>>>>>> 1206 } >>>>>>>> >>>>>>>> Can you rename status to timedout to make the logic more obvious. Also note that you will potentially return with time_slept still at zero, even though you may have slept for an arbitrary amount of time. That seems wrong as zero will then be passed to "tick". >>>>>>>> >>>>>>>> 1208 // spurious wakeup of some kind >>>>>>>> >>>>>>>> This comment is no longer accurate as you may have been woken up due to a change in the task list, I suggest: >>>>>>>> >>>>>>>> // Change to task list or spurious wakeup of some kind >>>>>>>> >>>>>>>> 1213 remaining = PeriodicTask::time_to_wait(); >>>>>>>> 1214 if (remaining == 0) { >>>>>>>> 1215 continue; >>>>>>>> 1216 } >>>>>>>> >>>>>>>> Can you insert a comment before continue: >>>>>>>> >>>>>>>> // Last task was just disenrolled so loop around and wait until >>>>>>>> // another task gets enrolled >>>>>>>> continue; >>>>>>>> >>>>>>>> >>>>>>>> 1218 remaining -= time_slept; >>>>>>>> >>>>>>>> Again type mixing: subtracting a long from an int. Again a potential warning to get rid of. >>>>>>>> >>>>>>>> Also in a long running VM perhaps there have been no periodic tasks for many days and then one turns up. The subtraction could wrap and cause remaining to remain positive. I know you've now documented the uncertainty in the first fire time but this seems somewhat too random. Let's see what others think. :) >>>>>>>> >>>>>>>> >>>>>>>> 1329 PeriodicTask_lock->notify_all(); >>>>>>>> >>>>>>>> There is only one thread that waits so notify() will suffice. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> David >>>>>>>> >>>>>>>> On 9/10/2012 4:34 PM, Rickard B?ckman wrote: >>>>>>>>> Trying again, >>>>>>>>> >>>>>>>>> can I have a couple of reviews, please? >>>>>>>>> >>>>>>>>> /R >>>>>>>>> >>>>>>>>> On Oct 4, 2012, at 3:01 PM, Rickard B?ckman wrote: >>>>>>>>> >>>>>>>>>> Hi all, >>>>>>>>>> >>>>>>>>>> can I please have a couple of reviews on the following change: >>>>>>>>>> >>>>>>>>>> http://cr.openjdk.java.net/~rbackman/7127792/ >>>>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127792 >>>>>>>>>> >>>>>>>>>> In short the purpose is to enable tasks to change the interval they are executed in. We >>>>>>>>>> would also like to be able to add (and remove) tasks after the WatcherThread has started. >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> /R >> From jaroslav.bachorik at oracle.com Fri Oct 12 00:47:21 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Fri, 12 Oct 2012 09:47:21 +0200 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <5077840F.6050601@oracle.com> References: <5075835F.3050604@oracle.com> <50767E5A.7060908@oracle.com> <5077840F.6050601@oracle.com> Message-ID: <5077CB09.7010005@oracle.com> On Fri 12 Oct 2012 04:44:31 AM CEST, David Holmes wrote: > Hi Jaroslav, > > > On 11/10/2012 6:07 PM, Jaroslav Bachorik wrote: >> Dmitry has put the webrev on the public CR - >> http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/ >> >> >> Thanks! >> >> -JB- >> >> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>> I am looking for a review and a sponsor. >>> >>> The issue is about some javax.management.timer.Timer notifications not >>> being received by the listeners if the notifications are generated >>> rapidly. >>> >>> The problem is caused by ConcurrentModificationException being thrown - >>> the exception itself is ignored but the dispatcher logic is skipped. >>> Therefore the currently processed notification gets lost. > > Can you point out where exactly in the code the exception is thrown > and caught. I'd like to understand the problem better. The CME is thrown in Timer.notifyAlarmClock() method in this case - but may happen in other places as well. Actually, in some places the access to the timerTable map is synchronized while in others it isn't. While switching the Hashtable for ConcurrentHashMap resolves this particular issue it might be beneficial to correct the partial synchronization instead. > >>> >>> The CME is thrown due to the Timer.timerTable being iterated over while >>> other threads try to remove some of its elements. Fix consists of >>> replacing the Hashtable used for Timer.timerTable by ConcurrentHashMap >>> which handles such situations with grace. > > Be aware that it may also give surprising results as removal is no > longer synchronized at all with processing. So it could now appear > that a notification is processed after a listener has been removed. Indeed, the CME is the symptom of the out-of-order processing - the removal method is synchronized on (Timer.this) while the notifyAlarmClock() method, processing the notifications, runs unsynchronized. Thanks for pointing this out. I will have something to think about. -JB- > > David > ----- > >>> The patch webrev is available @ >>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>> >>> Thanks, >>> >>> -JB- >>> >> From john.coomes at oracle.com Fri Oct 12 01:32:22 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 12 Oct 2012 08:32:22 +0000 Subject: hg: hsx/hotspot-rt: Added tag jdk8-b60 for changeset e07f499b9dcc Message-ID: <20121012083222.4ED7C4731E@hg.openjdk.java.net> Changeset: 20ff117b5090 Author: katleman Date: 2012-10-11 09:48 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/20ff117b5090 Added tag jdk8-b60 for changeset e07f499b9dcc ! .hgtags From john.coomes at oracle.com Fri Oct 12 01:32:25 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 12 Oct 2012 08:32:25 +0000 Subject: hg: hsx/hotspot-rt/corba: Added tag jdk8-b60 for changeset 207ef43ba69e Message-ID: <20121012083227.5F0454731F@hg.openjdk.java.net> Changeset: 41bb9e606efd Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/41bb9e606efd Added tag jdk8-b60 for changeset 207ef43ba69e ! .hgtags From john.coomes at oracle.com Fri Oct 12 01:32:31 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 12 Oct 2012 08:32:31 +0000 Subject: hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b60 for changeset 2d1dff5310da Message-ID: <20121012083237.4584347320@hg.openjdk.java.net> Changeset: 6b1db0b41d2f Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/6b1db0b41d2f Added tag jdk8-b60 for changeset 2d1dff5310da ! .hgtags From john.coomes at oracle.com Fri Oct 12 01:32:43 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 12 Oct 2012 08:32:43 +0000 Subject: hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b60 for changeset 5c5a65ad5291 Message-ID: <20121012083248.C855B47321@hg.openjdk.java.net> Changeset: 97e5e74e2a34 Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/97e5e74e2a34 Added tag jdk8-b60 for changeset 5c5a65ad5291 ! .hgtags From john.coomes at oracle.com Fri Oct 12 01:32:55 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 12 Oct 2012 08:32:55 +0000 Subject: hg: hsx/hotspot-rt/jdk: Added tag jdk8-b60 for changeset cec8fa02f156 Message-ID: <20121012083329.8C72047322@hg.openjdk.java.net> Changeset: 869519bc17ce Author: katleman Date: 2012-10-11 09:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/869519bc17ce Added tag jdk8-b60 for changeset cec8fa02f156 ! .hgtags From john.coomes at oracle.com Fri Oct 12 01:35:31 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 12 Oct 2012 08:35:31 +0000 Subject: hg: hsx/hotspot-rt/langtools: Added tag jdk8-b60 for changeset 3d2b98ffcb53 Message-ID: <20121012083537.70C4A47323@hg.openjdk.java.net> Changeset: 67f7408d935e Author: katleman Date: 2012-10-11 09:50 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/67f7408d935e Added tag jdk8-b60 for changeset 3d2b98ffcb53 ! .hgtags From coleen.phillimore at oracle.com Fri Oct 12 04:26:08 2012 From: coleen.phillimore at oracle.com (Coleen Phillmore) Date: Fri, 12 Oct 2012 07:26:08 -0400 Subject: RFR S: 7127792 Add the ability to change an existing PeriodicTask's execution interval In-Reply-To: References: <944656E5-9306-411E-A916-4DDC95E819D4@oracle.com> <892BC3F6-C669-41E9-9536-CD5879309480@oracle.com> <5073D661.1080908@oracle.com> <5074081F.1040807@oracle.com> <50741210.7080800@oracle.com> <86F37B4C-6211-47BE-ACB8-F6FC5FEAD16A@oracle.com> Message-ID: <5077FE50.8000309@oracle.com> Rickard, Are David and Marcus sufficient to push this. I briefly looked at it a few times and have to admit not knowing anything about this code without further study. Dan and Karen probably know more. Keith might too, so I've cc'd him. Sorry I can't be more helpful but if you need a reviewer before the end of your day and nobody else responds, you can use my name. I can be the default reviewer in this case. Coleen On 10/12/2012 1:06 AM, Rickard B?ckman wrote: > People, > > I need at least one more reviewer, thanks! > > /R > > On Oct 9, 2012, at 3:00 PM, Rickard B?ckman wrote: > >> David, >> >> thanks for your review! >> >> /R >> >> On Oct 9, 2012, at 2:01 PM, David Holmes wrote: >> >>> On 9/10/2012 9:42 PM, Rickard B?ckman wrote: >>>> David, >>>> see inline. >>>> >>>> On Oct 9, 2012, at 1:18 PM, David Holmes wrote: >>>> >>>>> On 9/10/2012 7:36 PM, Rickard B?ckman wrote: >>>>>> David, >>>>>> >>>>>> thanks for your reply! >>>>>> I've changed the code according to the suggestions, I've also changed the types in PeriodicTask from being a size_t to being a >>>>>> jint (see updated webrev for details). >>>>> But now the type changes have been pushed out to the task creators. Most task creations pass an int already but BiasedLocking uses a size_t. Just shows how messed up the typing was to begin with. >>>> Agreed. Two ways of solving it, 1) change the callers to use an int. 2) Do the cast in the constructor (should be safe since we check the possible interval). >>> int -> size_t shouldn't cause a warning so callers currently passing int are ok. So keeping it as size_t in constructor arg and casting to int before storing internally seems okay. >>> >>>>> Minor nit: should be an int rather than jint as these are not Java types. >>>> Will fix. >>>> >>>>>> To prevent the waiting for very long time (which could overflow, etc) when we don't have any active task, I added an extra if >>>>>> so that if we are waiting while no tasks are available, we reset the time_before_wait and consider time_slept to be zero after sleeping. >>>>>> That means the first task added will always sleep for the period requested. >>>>> Those semantics seem reasonable. >>>>> >>>>> The only thing that concerns me here is the affect of calling real_time_tick(0). I can't quite tell what the profiling code does. >>>> I could avoid calling that if time_slept = 0 >>> Ok. You could skip real_time_tick altogether on zero. >>> >>> I'm generally okay with the approach being taken here, but the changes are disruptive enough that I can't see for sure that existing tasks will be unaffected. I guess time will tell. And let's see what others might spot. >>> >>> Thanks, >>> David (signing off for the night) >>> >>>> Thanks >>>> /R >>>> >>>>> David >>>>> ----- >>>>> >>>>>> Updated webrev: >>>>>> http://cr.openjdk.java.net/~rbackman/7127792.1/ >>>>>> >>>>>> Thanks >>>>>> /R >>>>>> >>>>>> On Oct 9, 2012, at 9:46 AM, David Holmes wrote: >>>>>> >>>>>>> Sorry Rickard, missed the original RFR :) >>>>>>> >>>>>>> So to be clear here the synopsis concerns changing the period, while the mechanism implemented is for a more general dynamic disenroll / enroll. So changing a period is effected by removing a task and then adding it with the new period. >>>>>>> >>>>>>> And for anyone not reading the fine-print when you dynamically enroll a task its first firing is somewhat arbitrary - somewhere between the time of enrollment and that time plus its period. >>>>>>> >>>>>>> src/share/vm/runtime/thread.hpp >>>>>>> >>>>>>> Can you add a comment: >>>>>>> >>>>>>> static void stop(); >>>>>>> + // Only allow start once the VM is sufficiently initialized >>>>>>> + // Otherwise the first task to enroll will trigger the start >>>>>>> + static void make_startable(); >>>>>>> >>>>>>> --- >>>>>>> >>>>>>> src/share/vm/runtime/thread.cpp >>>>>>> >>>>>>> We have a bit of type mixing here: >>>>>>> >>>>>>> - size_t time_to_wait >>>>>>> - jlong time_slept >>>>>>> - int remaining = time_to_wait >>>>>>> >>>>>>> I don't understand why Task is using size_t for time intervals. If you make "remaining" a size_t then it will cause issues when you pass it to wait. But I would expect the initialization of "remaining" to cause an unsigned-to-signed conversion warning, so perhaps an explicit cast to silence that. >>>>>>> >>>>>>> 1203 bool status = PeriodicTask_lock->wait(Mutex::_no_safepoint_check_flag, remaining); >>>>>>> 1204 if (status || _should_terminate) { >>>>>>> 1205 break; >>>>>>> 1206 } >>>>>>> >>>>>>> Can you rename status to timedout to make the logic more obvious. Also note that you will potentially return with time_slept still at zero, even though you may have slept for an arbitrary amount of time. That seems wrong as zero will then be passed to "tick". >>>>>>> >>>>>>> 1208 // spurious wakeup of some kind >>>>>>> >>>>>>> This comment is no longer accurate as you may have been woken up due to a change in the task list, I suggest: >>>>>>> >>>>>>> // Change to task list or spurious wakeup of some kind >>>>>>> >>>>>>> 1213 remaining = PeriodicTask::time_to_wait(); >>>>>>> 1214 if (remaining == 0) { >>>>>>> 1215 continue; >>>>>>> 1216 } >>>>>>> >>>>>>> Can you insert a comment before continue: >>>>>>> >>>>>>> // Last task was just disenrolled so loop around and wait until >>>>>>> // another task gets enrolled >>>>>>> continue; >>>>>>> >>>>>>> >>>>>>> 1218 remaining -= time_slept; >>>>>>> >>>>>>> Again type mixing: subtracting a long from an int. Again a potential warning to get rid of. >>>>>>> >>>>>>> Also in a long running VM perhaps there have been no periodic tasks for many days and then one turns up. The subtraction could wrap and cause remaining to remain positive. I know you've now documented the uncertainty in the first fire time but this seems somewhat too random. Let's see what others think. :) >>>>>>> >>>>>>> >>>>>>> 1329 PeriodicTask_lock->notify_all(); >>>>>>> >>>>>>> There is only one thread that waits so notify() will suffice. >>>>>>> >>>>>>> Thanks, >>>>>>> David >>>>>>> >>>>>>> On 9/10/2012 4:34 PM, Rickard B?ckman wrote: >>>>>>>> Trying again, >>>>>>>> >>>>>>>> can I have a couple of reviews, please? >>>>>>>> >>>>>>>> /R >>>>>>>> >>>>>>>> On Oct 4, 2012, at 3:01 PM, Rickard B?ckman wrote: >>>>>>>> >>>>>>>>> Hi all, >>>>>>>>> >>>>>>>>> can I please have a couple of reviews on the following change: >>>>>>>>> >>>>>>>>> http://cr.openjdk.java.net/~rbackman/7127792/ >>>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7127792 >>>>>>>>> >>>>>>>>> In short the purpose is to enable tasks to change the interval they are executed in. We >>>>>>>>> would also like to be able to add (and remove) tasks after the WatcherThread has started. >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> /R From jaroslav.bachorik at oracle.com Fri Oct 12 06:14:47 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Fri, 12 Oct 2012 15:14:47 +0200 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <5077CB09.7010005@oracle.com> References: <5075835F.3050604@oracle.com> <50767E5A.7060908@oracle.com> <5077840F.6050601@oracle.com> <5077CB09.7010005@oracle.com> Message-ID: <507817C7.9000703@oracle.com> The updated webrev is now at http://btrace.kenai.com/webrevs/JDK-6809322/ I am sorry for this chaos with webrev locations but its not that easy to work efficiently without an OpenJDK username :/ -JB- On 10/12/2012 09:47 AM, Jaroslav Bachorik wrote: > On Fri 12 Oct 2012 04:44:31 AM CEST, David Holmes wrote: >> Hi Jaroslav, >> >> >> On 11/10/2012 6:07 PM, Jaroslav Bachorik wrote: >>> Dmitry has put the webrev on the public CR - >>> http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/ >>> >>> >>> Thanks! >>> >>> -JB- >>> >>> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>>> I am looking for a review and a sponsor. >>>> >>>> The issue is about some javax.management.timer.Timer notifications not >>>> being received by the listeners if the notifications are generated >>>> rapidly. >>>> >>>> The problem is caused by ConcurrentModificationException being thrown - >>>> the exception itself is ignored but the dispatcher logic is skipped. >>>> Therefore the currently processed notification gets lost. >> >> Can you point out where exactly in the code the exception is thrown >> and caught. I'd like to understand the problem better. > > The CME is thrown in Timer.notifyAlarmClock() method in this case - but > may happen in other places as well. > > Actually, in some places the access to the timerTable map is > synchronized while in others it isn't. While switching the Hashtable > for ConcurrentHashMap resolves this particular issue it might be > beneficial to correct the partial synchronization instead. > >> >>>> >>>> The CME is thrown due to the Timer.timerTable being iterated over while >>>> other threads try to remove some of its elements. Fix consists of >>>> replacing the Hashtable used for Timer.timerTable by ConcurrentHashMap >>>> which handles such situations with grace. >> >> Be aware that it may also give surprising results as removal is no >> longer synchronized at all with processing. So it could now appear >> that a notification is processed after a listener has been removed. > > Indeed, the CME is the symptom of the out-of-order processing - the > removal method is synchronized on (Timer.this) while the > notifyAlarmClock() method, processing the notifications, runs > unsynchronized. > > Thanks for pointing this out. I will have something to think about. > > -JB- > >> >> David >> ----- >> >>>> The patch webrev is available @ >>>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>>> >>>> Thanks, >>>> >>>> -JB- >>>> >>> > > From jaroslav.bachorik at oracle.com Fri Oct 12 06:16:46 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Fri, 12 Oct 2012 15:16:46 +0200 Subject: jmx-dev [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject In-Reply-To: References: <50753461.4070009@oracle.com> <5075C26C.50309@oracle.com> <5077013B.9040801@oracle.com> Message-ID: <5078183E.7060106@oracle.com> Thanks. Minor nits picked ... http://btrace.kenai.com/webrevs/JDK-6783290/webrev.v3/ -JB- On 10/11/2012 07:42 PM, Eamonn McManus wrote: > Looks good. A couple of minor nits about the test: there is a stray > IDE template comment on line 74, and the copyright date is wrong. > > ?amonn > > > 2012/10/11 Jaroslav Bachorik : >> Just to keep it clear - here is the webrev hosted at CR - >> http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6783290-v1/ >> >> -JB- >> >> On Wed 10 Oct 2012 08:46:04 PM CEST, Jaroslav Bachorik wrote: >>> Hi, >>> >>> On Wed 10 Oct 2012 05:49:11 PM CEST, Eamonn McManus wrote: >>>> Hi Jaroslav, >>>> >>>> The patch looks correct and the test is ingenious. >>>> >>>> I do not understand why the previous SerializationTest needs to be >>>> deleted. It doesn't seem that the new test is covering the same >>>> things. >>> >>> I need to check that. I copied the SerializationTest.java to >>> SerializationTest1.java - apparently the cooperation of the webrev and >>> mercurial queues has its glitches :( >>> >>> I am attaching the corrected webrev. >>> >>> -JB- >>> >>>> >>>> Reviewed-by: emcmanus >>>> >>>> Incidentally I was not able to find a way to see the patch with the >>>> usual webrev browser UI. Is there a link for that? >>>> >>>> Regards, >>>> ?amonn >>>> >>>> >>>> 2012/10/10 Jaroslav Bachorik : >>>>> I am looking for a review and a sponsor for this fix. >>>>> >>>>> The issue is about an empty array of descriptors being written as a part >>>>> of the serialization process but not read when deserializing an >>>>> MBeanInfo/MBeanFeatureInfo instance. While the current ObjectInputStream >>>>> skips all unread custom written fields it is not a behaviour required by >>>>> the specification and may cause problems. >>>>> >>>>> The patch makes the array to be read in all cases - even when it is >>>>> known to be an empty one. That way all that has been written as a part >>>>> of serialization is read back. >>>>> >>>>> The webrev with the fix and test is available @ >>>>> https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6783290 >>>>> >>>>> -JB- >>> >>> >> >> From eamonn at mcmanus.net Fri Oct 12 09:02:14 2012 From: eamonn at mcmanus.net (Eamonn McManus) Date: Fri, 12 Oct 2012 09:02:14 -0700 Subject: jmx-dev [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject In-Reply-To: <5078183E.7060106@oracle.com> References: <50753461.4070009@oracle.com> <5075C26C.50309@oracle.com> <5077013B.9040801@oracle.com> <5078183E.7060106@oracle.com> Message-ID: Looks good to me (emcmanus). ?amonn 2012/10/12 Jaroslav Bachorik > Thanks. Minor nits picked ... > > http://btrace.kenai.com/webrevs/JDK-6783290/webrev.v3/ > > -JB- > > On 10/11/2012 07:42 PM, Eamonn McManus wrote: > > Looks good. A couple of minor nits about the test: there is a stray > > IDE template comment on line 74, and the copyright date is wrong. > > > > ?amonn > > > > > > 2012/10/11 Jaroslav Bachorik : > >> Just to keep it clear - here is the webrev hosted at CR - > >> > http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6783290-v1/ > >> > >> -JB- > >> > >> On Wed 10 Oct 2012 08:46:04 PM CEST, Jaroslav Bachorik wrote: > >>> Hi, > >>> > >>> On Wed 10 Oct 2012 05:49:11 PM CEST, Eamonn McManus wrote: > >>>> Hi Jaroslav, > >>>> > >>>> The patch looks correct and the test is ingenious. > >>>> > >>>> I do not understand why the previous SerializationTest needs to be > >>>> deleted. It doesn't seem that the new test is covering the same > >>>> things. > >>> > >>> I need to check that. I copied the SerializationTest.java to > >>> SerializationTest1.java - apparently the cooperation of the webrev and > >>> mercurial queues has its glitches :( > >>> > >>> I am attaching the corrected webrev. > >>> > >>> -JB- > >>> > >>>> > >>>> Reviewed-by: emcmanus > >>>> > >>>> Incidentally I was not able to find a way to see the patch with the > >>>> usual webrev browser UI. Is there a link for that? > >>>> > >>>> Regards, > >>>> ?amonn > >>>> > >>>> > >>>> 2012/10/10 Jaroslav Bachorik : > >>>>> I am looking for a review and a sponsor for this fix. > >>>>> > >>>>> The issue is about an empty array of descriptors being written as a > part > >>>>> of the serialization process but not read when deserializing an > >>>>> MBeanInfo/MBeanFeatureInfo instance. While the current > ObjectInputStream > >>>>> skips all unread custom written fields it is not a behaviour > required by > >>>>> the specification and may cause problems. > >>>>> > >>>>> The patch makes the array to be read in all cases - even when it is > >>>>> known to be an empty one. That way all that has been written as a > part > >>>>> of serialization is read back. > >>>>> > >>>>> The webrev with the fix and test is available @ > >>>>> > https://github.com/jbachorik/openjdk-patches/tree/master/webrevs/JDK-6783290 > >>>>> > >>>>> -JB- > >>> > >>> > >> > >> > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121012/2d0ac61d/attachment.html From lana.steuck at oracle.com Fri Oct 12 15:27:56 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 12 Oct 2012 22:27:56 +0000 Subject: hg: jdk8/tl: 6 new changesets Message-ID: <20121012222757.3269A4733F@hg.openjdk.java.net> Changeset: dae9821589cc Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/dae9821589cc Added tag jdk8-b58 for changeset 936702480487 ! .hgtags Changeset: b9d574659206 Author: katleman Date: 2012-10-04 14:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/b9d574659206 Added tag jdk8-b59 for changeset dae9821589cc ! .hgtags Changeset: 4b54d77a6831 Author: dholmes Date: 2012-10-09 02:08 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4b54d77a6831 8000461: Top level build doesn't pass OPENJDK=true through to the hotspot build Summary: Add OPENJDK to the COMMON_BUILD_ARGUMENTS Reviewed-by: tbell ! make/Defs-internal.gmk Changeset: e07f499b9dcc Author: katleman Date: 2012-10-10 14:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/e07f499b9dcc Merge Changeset: 20ff117b5090 Author: katleman Date: 2012-10-11 09:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/20ff117b5090 Added tag jdk8-b60 for changeset e07f499b9dcc ! .hgtags Changeset: ce2b111ee869 Author: lana Date: 2012-10-12 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ce2b111ee869 Merge From lana.steuck at oracle.com Fri Oct 12 15:28:04 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 12 Oct 2012 22:28:04 +0000 Subject: hg: jdk8/tl/corba: 6 new changesets Message-ID: <20121012222808.64F7847340@hg.openjdk.java.net> Changeset: d54dc53e223e Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d54dc53e223e Added tag jdk8-b58 for changeset 18462a19f7bd ! .hgtags Changeset: 207ef43ba69e Author: katleman Date: 2012-10-04 14:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/207ef43ba69e Added tag jdk8-b59 for changeset d54dc53e223e ! .hgtags Changeset: 41bb9e606efd Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/41bb9e606efd Added tag jdk8-b60 for changeset 207ef43ba69e ! .hgtags Changeset: d9c1dab1515b Author: lana Date: 2012-10-08 15:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d9c1dab1515b Merge Changeset: 0e08ba7648fb Author: lana Date: 2012-10-11 16:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0e08ba7648fb Merge Changeset: 706684c5a058 Author: lana Date: 2012-10-12 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/706684c5a058 Merge From lana.steuck at oracle.com Fri Oct 12 15:30:09 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 12 Oct 2012 22:30:09 +0000 Subject: hg: jdk8/tl/hotspot: 68 new changesets Message-ID: <20121012223233.15DB147342@hg.openjdk.java.net> Changeset: 04ed664b7e30 Author: amurillo Date: 2012-09-21 14:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/04ed664b7e30 7200236: new hotspot build - hs25-b03 Reviewed-by: jcoomes ! make/hotspot_version Changeset: fac3dd92ebaf Author: bpittore Date: 2012-09-19 17:22 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fac3dd92ebaf 7195372: Wrong copyright in new files Summary: Fixed copyrights Reviewed-by: dholmes Contributed-by: Bill Pittore ! agent/make/saenv.sh ! agent/make/start-debug-server-proc.sh ! agent/src/share/classes/sun/jvm/hotspot/debugger/ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/amd64/AMD64ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/ia64/IA64ThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/sparc/SPARCThreadContext.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/x86/X86ThreadContext.java ! make/linux/makefiles/sa.make Changeset: ef7fe63a2d39 Author: vladidan Date: 2012-09-24 19:00 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ef7fe63a2d39 Merge Changeset: 15ba0e7a3ff4 Author: sla Date: 2012-09-17 11:46 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/15ba0e7a3ff4 7193201: [OS X] The development launcher should be signed and given task_for_pid privileges Reviewed-by: sspitsyn, nloodin, mgronlun, coleenp ! make/bsd/makefiles/launcher.make + src/os/bsd/launcher/Info-privileged.plist Changeset: a7509aff1b06 Author: dholmes Date: 2012-09-17 07:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a7509aff1b06 7194254: jstack reports wrong thread priorities Reviewed-by: dholmes, sla, fparain Contributed-by: Dmytro Sheyko ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/thread.cpp + test/runtime/7194254/Test7194254.java Changeset: 7b41bee02500 Author: dholmes Date: 2012-09-17 08:44 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7b41bee02500 Merge Changeset: 716e6ef4482a Author: zgu Date: 2012-09-17 10:20 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/716e6ef4482a 7190089: NMT ON: NMT failed assertion on thread's stack base address Summary: Solaris only, record stack info to NMT after stack size adjustment was made for primordial threads Reviewed-by: kvn, acorn, coleenp ! src/os/solaris/vm/os_solaris.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memTracker.hpp Changeset: c088e2e95e69 Author: zgu Date: 2012-09-17 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c088e2e95e69 Merge ! src/share/vm/runtime/thread.cpp Changeset: 9a86ddfc6c8f Author: zgu Date: 2012-09-17 16:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9a86ddfc6c8f 7188594: Print statistic collected by NMT with VM flag Summary: Print out statistics of collected NMT data if it is on at VM exits Reviewed-by: kvn, coleenp, twisti ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/services/memTracker.hpp Changeset: 45f22ba9348d Author: zgu Date: 2012-09-18 11:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/45f22ba9348d Merge Changeset: 1cb8583c3da8 Author: minqi Date: 2012-09-18 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1cb8583c3da8 7191786: retransformClasses() does not pass in LocalVariableTypeTable of a method Summary: JVMTI REtruncformClasses must support LocalVariableTypeTable attribute Reviewed-by: dcubed, dsamersoff, rbackman Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiClassFileReconstituter.cpp ! src/share/vm/prims/jvmtiClassFileReconstituter.hpp Changeset: 26994b6e10d5 Author: minqi Date: 2012-09-19 08:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/26994b6e10d5 Merge Changeset: 989cf02ca531 Author: ihse Date: 2012-09-17 11:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/989cf02ca531 7172012: Make test-in-build an option (Queens) Reviewed-by: ohair, dholmes ! make/bsd/Makefile ! make/defs.make ! make/linux/Makefile ! make/solaris/Makefile Changeset: 06be7f06c2de Author: ohair Date: 2012-09-18 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/06be7f06c2de Merge Changeset: 37518f191ddb Author: ohair Date: 2012-09-18 13:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/37518f191ddb 7198329: Add $(sort) to object files used in links makes binarties more consistent Reviewed-by: dholmes, tbell, erikj, ihse, ohrstrom ! make/bsd/makefiles/launcher.make ! make/bsd/makefiles/vm.make ! make/linux/makefiles/launcher.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/launcher.make ! make/solaris/makefiles/vm.make Changeset: 0e5be2138cd6 Author: jcoomes Date: 2012-09-18 19:44 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0e5be2138cd6 Merge Changeset: 2c527daec02c Author: jcoomes Date: 2012-09-19 16:18 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2c527daec02c Merge Changeset: 6af8f3562069 Author: kevinw Date: 2012-09-19 15:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6af8f3562069 7196045: Possible JVM deadlock in ThreadTimesClosure when using HotspotInternal non-public API. Reviewed-by: sspitsyn, dholmes ! src/share/vm/services/management.cpp + test/runtime/7196045/Test7196045.java Changeset: 8440414b0fd8 Author: kevinw Date: 2012-09-20 03:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8440414b0fd8 Merge Changeset: b711844284e2 Author: nloodin Date: 2012-09-21 10:56 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b711844284e2 7200092: Make NMT a bit friendlier to work with Reviewed-by: kvn, ysr, azeemj ! src/share/vm/services/memTracker.cpp Changeset: 5a98bf7d847b Author: minqi Date: 2012-09-24 12:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5a98bf7d847b 6879063: SA should use hsdis for disassembly Summary: We should in SA to use hsdis for it like the JVM does to replace the current java based disassembler. Reviewed-by: twisti, jrose, sla Contributed-by: yumin.qi at oracle.com - agent/make/ClosureFinder.java ! agent/make/Makefile ! agent/src/os/bsd/MacosxDebuggerLocal.m ! agent/src/os/linux/Makefile ! agent/src/os/linux/mapfile ! agent/src/os/solaris/proc/Makefile ! agent/src/os/solaris/proc/mapfile ! agent/src/os/win32/windbg/Makefile ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/HotSpotAgent.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java ! agent/src/share/classes/sun/jvm/hotspot/asm/Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java ! agent/src/share/classes/sun/jvm/hotspot/asm/InstructionVisitor.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java ! agent/src/share/classes/sun/jvm/hotspot/bugspot/BugSpotAgent.java ! agent/src/share/classes/sun/jvm/hotspot/code/CodeBlob.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/SADebugServer.java ! agent/src/share/classes/sun/jvm/hotspot/jdi/VirtualMachineImpl.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Bytes.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/x86/X86RegisterMap.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js + agent/src/share/native/sadis.c ! agent/test/jdi/jstack.sh ! agent/test/jdi/jstack64.sh ! agent/test/jdi/runsa.sh ! agent/test/jdi/sasanity.sh ! agent/test/libproc/libproctest.sh ! agent/test/libproc/libproctest64.sh ! make/bsd/makefiles/sa.make ! make/bsd/makefiles/saproc.make ! make/linux/makefiles/sa.make ! make/linux/makefiles/saproc.make ! make/sa.files ! make/solaris/makefiles/sa.make ! make/solaris/makefiles/saproc.make ! make/windows/makefiles/sa.make ! src/share/tools/hsdis/Makefile ! src/share/tools/hsdis/README ! src/share/tools/hsdis/hsdis-demo.c ! src/share/tools/hsdis/hsdis.c ! src/share/tools/hsdis/hsdis.h ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/disassembler.hpp Changeset: 3d739d45d9fd Author: minqi Date: 2012-09-24 20:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3d739d45d9fd Merge - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java Changeset: 45535ab90688 Author: dholmes Date: 2012-09-25 07:58 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/45535ab90688 7200065: Cross-compilation changes to support the new-build Reviewed-by: dholmes, ohair Contributed-by: Fredrik Ohrstrom ! make/linux/makefiles/adlc.make ! make/linux/makefiles/defs.make Changeset: b86575d092a2 Author: dsamersoff Date: 2012-09-27 20:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b86575d092a2 Merge - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java ! make/linux/makefiles/sa.make ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 5baec2e69518 Author: jmasa Date: 2012-09-25 07:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5baec2e69518 7200615: NPG: optimized VM build is broken Reviewed-by: kvn ! src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp ! src/share/vm/memory/metaspace.cpp Changeset: 8966c2d65d96 Author: brutisso Date: 2012-09-25 14:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8966c2d65d96 7200470: KeepAliveClosure not needed in CodeCache::do_unloading Summary: Removed the unused keep_alive parameter Reviewed-by: stefank, dholmes, kamg, coleenp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/memory/genMarkSweep.cpp Changeset: 7c2fd5948145 Author: brutisso Date: 2012-09-25 18:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7c2fd5948145 Merge Changeset: 15fba4382765 Author: stefank Date: 2012-09-28 14:14 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/15fba4382765 Merge Changeset: 2cb2f30450c7 Author: twisti Date: 2012-09-17 12:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2cb2f30450c7 7196262: JSR 292: java/lang/invoke/PrivateInvokeTest.java fails on solaris-sparc Reviewed-by: kvn, jrose, bdelsart ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/share/vm/asm/register.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: 8d3cc6612bd1 Author: kvn Date: 2012-09-17 17:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8d3cc6612bd1 7197033: missing ResourceMark for assert in Method::bci_from() Summary: Added missing ResourceMark. Reviewed-by: dholmes, coleenp, jmasa ! src/share/vm/oops/method.cpp Changeset: 137868b7aa6f Author: kvn Date: 2012-09-17 19:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/137868b7aa6f 7196199: java/text/Bidi/Bug6665028.java failed: Bidi run count incorrect Summary: Save whole XMM/YMM registers in safepoint interrupt handler. Reviewed-by: roland, twisti ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/x86.ad ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/superword.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp + test/compiler/7196199/Test7196199.java Changeset: 9d89c76b0505 Author: twisti Date: 2012-09-19 10:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9d89c76b0505 7198499: TraceTypeProfile as diagnostic option Reviewed-by: kvn Contributed-by: Aleksey Shipilev ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/doCall.cpp Changeset: 8ae8f9dd7099 Author: kvn Date: 2012-09-19 16:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8ae8f9dd7099 7199010: incorrect vector alignment Summary: Fixed vectors alignment when several arrays are accessed in one loop. Reviewed-by: roland, twisti ! src/cpu/x86/vm/vm_version_x86.cpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/superword.hpp Changeset: 7eca5de9e0b6 Author: roland Date: 2012-09-20 16:49 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7eca5de9e0b6 7023898: Intrinsify AtomicLongFieldUpdater.getAndIncrement() Summary: use shorter instruction sequences for atomic add and atomic exchange when possible. Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/x86.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Canonicalizer.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_InstructionPrinter.hpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/c1/c1_ValueMap.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/escape.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp Changeset: b31471cdc53e Author: kvn Date: 2012-09-24 10:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b31471cdc53e 7200163: add CodeComments functionality to assember stubs Summary: Pass the codeBuffer to the Stub constructor, and adapts the disassembler to print the comments. Reviewed-by: jrose, kvn, twisti Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/asm/codeBuffer.cpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/codeBlob.hpp ! src/share/vm/code/icBuffer.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/code/stubs.cpp ! src/share/vm/code/stubs.hpp ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/disassembler.hpp ! src/share/vm/interpreter/interpreter.cpp ! src/share/vm/interpreter/interpreter.hpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 3a327d0b8586 Author: twisti Date: 2012-09-24 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3a327d0b8586 7188176: The JVM should differentiate between T and M series and adjust GC ergonomics Reviewed-by: kvn Contributed-by: Tao Mao ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vm_version_sparc.hpp Changeset: f7c1f489db55 Author: twisti Date: 2012-09-24 12:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f7c1f489db55 Merge Changeset: c92f43386117 Author: kvn Date: 2012-09-24 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c92f43386117 Merge ! src/share/vm/classfile/vmSymbols.hpp Changeset: 9191895df19d Author: twisti Date: 2012-09-24 17:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9191895df19d 7200001: failed C1 OSR compile doesn't get recompiled with C2 Reviewed-by: kvn ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/compiler/compileLog.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/accessFlags.hpp Changeset: 1a9b9cfcef41 Author: neliasso Date: 2012-03-29 16:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1a9b9cfcef41 7163863: Updated projectcreator Summary: Enable source browsing for all platform dependent code Reviewed-by: brutisso, coleenp ! make/windows/makefiles/projectcreator.make ! src/share/tools/ProjectCreator/BuildConfig.java - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java + src/share/tools/ProjectCreator/FileTreeCreator.java + src/share/tools/ProjectCreator/FileTreeCreatorVC10.java + src/share/tools/ProjectCreator/FileTreeCreatorVC7.java ! src/share/tools/ProjectCreator/ProjectCreator.java ! src/share/tools/ProjectCreator/Util.java ! src/share/tools/ProjectCreator/WinGammaPlatform.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC10.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC7.java Changeset: 0702f188baeb Author: kvn Date: 2012-09-25 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0702f188baeb 7200233: C2: can't use expand rules for vector instruction rules Summary: Added missed _bottom_type set in ArchDesc::defineExpand() and missed vector nodes in MatchRule::is_vector(). Reviewed-by: twisti, roland, dlong ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 06f52c4d0e18 Author: kvn Date: 2012-09-25 15:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/06f52c4d0e18 7200264: 7192963 changes disabled shift vectors Summary: Replaced is_vector_use() call with explicit check for vector shift's count. Reviewed-by: twisti, roland, dlong, vlivanov ! src/share/vm/opto/superword.cpp + test/compiler/7200264/Test7200264.sh + test/compiler/7200264/TestIntVect.java Changeset: e626685e9f6c Author: kvn Date: 2012-09-27 09:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e626685e9f6c 7193318: C2: remove number of inputs requirement from Node's new operator Summary: Deleted placement new operator of Node - node(size_t, Compile *, int). Reviewed-by: kvn, twisti Contributed-by: bharadwaj.yadavalli at oracle.com ! src/share/vm/adlc/output_c.cpp ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/divnode.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/generateOptoStub.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/reg_split.cpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/vectornode.cpp Changeset: 69fb89ec6fa7 Author: kvn Date: 2012-09-27 15:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/69fb89ec6fa7 7198084: NPG: distance is too big for short branches in test_invocation_counter_for_mdp() Summary: use long branches in test_invocation_counter_for_mdp() Reviewed-by: twisti ! src/cpu/sparc/vm/interp_masm_sparc.cpp Changeset: f2e12eb74117 Author: kvn Date: 2012-09-28 10:16 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f2e12eb74117 Merge - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/compiler/disassembler.cpp ! src/share/vm/compiler/disassembler.hpp Changeset: 9f008ad79470 Author: amurillo Date: 2012-09-28 13:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9f008ad79470 Added tag hs25-b03 for changeset f2e12eb74117 ! .hgtags Changeset: 2dd08e86a2bf Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2dd08e86a2bf Added tag jdk8-b58 for changeset 6bb378c50828 ! .hgtags Changeset: 8a1a6b9b4f20 Author: katleman Date: 2012-10-03 15:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8a1a6b9b4f20 Merge ! .hgtags - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java Changeset: a3fd4914ac81 Author: katleman Date: 2012-10-04 14:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a3fd4914ac81 Added tag jdk8-b59 for changeset 8a1a6b9b4f20 ! .hgtags Changeset: 1b582b1bf7cb Author: amurillo Date: 2012-09-28 14:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1b582b1bf7cb 8000251: new hotspot build - hs25-b04 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 988bf00cc564 Author: johnc Date: 2012-09-27 15:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/988bf00cc564 7200261: G1: Liveness counting inconsistencies during marking verification Summary: The clipping code in the routine that sets the bits for a range of cards, in the liveness accounting verification code was incorrect. It set all the bits in the card bitmap from the given starting index which would lead to spurious marking verification failures. Reviewed-by: brutisso, jwilhelm, jmasa ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp Changeset: 5c8fbbfed964 Author: stefank Date: 2012-10-01 11:07 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5c8fbbfed964 Merge - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java Changeset: 85f1cded9793 Author: stefank Date: 2012-09-28 15:34 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/85f1cded9793 8000230: Change os::print_location to be more descriptive when a location is pointing into an object Reviewed-by: mgerdin, twisti ! src/share/vm/runtime/os.cpp Changeset: 86af3dacab81 Author: stefank Date: 2012-10-01 13:29 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/86af3dacab81 8000227: [obj|type]ArrayKlass::oop_print_on prints one line to tty instead of the provided output stream Reviewed-by: brutisso, sla, jmasa, coleenp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.cpp Changeset: 87ac5c0a404d Author: stefank Date: 2012-10-01 13:29 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/87ac5c0a404d 8000228: Missing call to cr() when printing entry_point in nmethod, in os::print_location Reviewed-by: brutisso, neliasso ! src/share/vm/runtime/os.cpp Changeset: f81a7c0c618d Author: jmasa Date: 2012-10-03 08:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f81a7c0c618d 7199349: NPG: PS: Crash seen in jprt Reviewed-by: johnc ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.cpp ! src/share/vm/gc_implementation/parallelScavenge/cardTableExtension.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.hpp ! src/share/vm/runtime/globals.hpp Changeset: 22b8d3d181d9 Author: jwilhelm Date: 2012-10-03 20:31 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/22b8d3d181d9 8000351: Tenuring threshold should be unsigned Summary: Change the flags and variables related to tenuring threshold to be unsigned Reviewed-by: jmasa, johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/parallelScavenge/psAdaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.hpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.cpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/shared/ageTable.cpp ! src/share/vm/gc_implementation/shared/ageTable.hpp ! src/share/vm/gc_implementation/shared/gcAdaptivePolicyCounters.hpp ! src/share/vm/memory/defNewGeneration.hpp ! src/share/vm/memory/threadLocalAllocBuffer.hpp ! src/share/vm/oops/markOop.hpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/biasedLocking.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 2e6857353b2c Author: johnc Date: 2012-10-04 10:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/2e6857353b2c 8000311: G1: ParallelGCThreads==0 broken Summary: Divide by zero error, if ParallelGCThreads is 0, when adjusting the PLAB size. Reviewed-by: jmasa, jcoomes ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/shared/parGCAllocBuffer.cpp ! src/share/vm/gc_implementation/shared/parGCAllocBuffer.hpp Changeset: 097d78aaf2b5 Author: jmasa Date: 2012-10-04 10:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/097d78aaf2b5 7198873: NPG: VM Does not unload classes with UseConcMarkSweepGC Reviewed-by: johnc, mgerdin, jwilhelm ! src/share/vm/gc_implementation/shared/vmGCOperations.cpp Changeset: ca70b919819f Author: jmasa Date: 2012-10-04 14:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ca70b919819f Merge Changeset: f6b0eb4e44cf Author: twisti Date: 2012-10-01 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f6b0eb4e44cf 7200949: JSR 292: rubybench/bench/time/bench_base64.rb fails with jruby.jar not on boot class path Reviewed-by: jrose, kvn ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/ci/ciClassList.hpp + src/share/vm/ci/ciMethodType.hpp ! src/share/vm/ci/ciObject.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciSignature.cpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/ci/ciStreams.cpp ! src/share/vm/ci/ciStreams.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/linkResolver.hpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp Changeset: 859c45fb8cea Author: kvn Date: 2012-10-02 12:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/859c45fb8cea 7201026: add vector for shift count Summary: Add generation of vectors for scalar shift count. Reviewed-by: roland, twisti, dlong ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/vectornode.cpp ! src/share/vm/opto/vectornode.hpp ! test/compiler/7200264/Test7200264.sh Changeset: f13867c41f73 Author: kvn Date: 2012-10-02 14:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f13867c41f73 7199742: A lot of C2 OSR compilations of the same method's bci Summary: Don't clone head of OSR loop. Reviewed-by: jrose, twisti ! src/share/vm/ci/ciTypeFlow.cpp ! src/share/vm/opto/parse1.cpp + test/compiler/7199742/Test7199742.java Changeset: bf2edd3c9b0f Author: neliasso Date: 2012-10-04 06:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bf2edd3c9b0f 8000102: Resolve include conflicts Summary: Removing include of c1/c1_runtime.hpp and opto/runtime.hpp from all os-files. Reviewed-by: kvn Contributed-by: nils.eliasson at oracle.com ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp Changeset: 685457683e86 Author: kvn Date: 2012-10-05 10:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/685457683e86 Merge Changeset: 1cc7a2a11d00 Author: amurillo Date: 2012-10-05 13:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1cc7a2a11d00 Merge Changeset: 3cfd05b2219a Author: amurillo Date: 2012-10-05 13:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/3cfd05b2219a Added tag hs25-b04 for changeset 1cc7a2a11d00 ! .hgtags Changeset: 0cc77f9b31ad Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0cc77f9b31ad Added tag jdk8-b60 for changeset 3cfd05b2219a ! .hgtags From lana.steuck at oracle.com Fri Oct 12 15:35:02 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 12 Oct 2012 22:35:02 +0000 Subject: hg: jdk8/tl/jaxp: 4 new changesets Message-ID: <20121012223514.05DCF47344@hg.openjdk.java.net> Changeset: af9e8b0f1900 Author: katleman Date: 2012-09-27 11:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/af9e8b0f1900 Added tag jdk8-b58 for changeset 1cb19abb3f7b ! .hgtags Changeset: 2d1dff5310da Author: katleman Date: 2012-10-04 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/2d1dff5310da Added tag jdk8-b59 for changeset af9e8b0f1900 ! .hgtags Changeset: 6b1db0b41d2f Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/6b1db0b41d2f Added tag jdk8-b60 for changeset 2d1dff5310da ! .hgtags Changeset: b545c99e4f5e Author: lana Date: 2012-10-12 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b545c99e4f5e Merge From lana.steuck at oracle.com Fri Oct 12 15:35:19 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 12 Oct 2012 22:35:19 +0000 Subject: hg: jdk8/tl/jaxws: 3 new changesets Message-ID: <20121012223526.DD16847346@hg.openjdk.java.net> Changeset: ae107401be11 Author: katleman Date: 2012-09-27 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/ae107401be11 Added tag jdk8-b58 for changeset cac4c3937063 ! .hgtags Changeset: 5c5a65ad5291 Author: katleman Date: 2012-10-04 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/5c5a65ad5291 Added tag jdk8-b59 for changeset ae107401be11 ! .hgtags Changeset: 97e5e74e2a34 Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/97e5e74e2a34 Added tag jdk8-b60 for changeset 5c5a65ad5291 ! .hgtags From lana.steuck at oracle.com Fri Oct 12 15:36:28 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 12 Oct 2012 22:36:28 +0000 Subject: hg: jdk8/tl/jdk: 22 new changesets Message-ID: <20121012224050.66FFF47347@hg.openjdk.java.net> Changeset: abad1f417bd3 Author: katleman Date: 2012-09-27 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abad1f417bd3 Added tag jdk8-b58 for changeset d94613ac03d8 ! .hgtags Changeset: cec8fa02f156 Author: katleman Date: 2012-10-04 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cec8fa02f156 Added tag jdk8-b59 for changeset abad1f417bd3 ! .hgtags Changeset: 869519bc17ce Author: katleman Date: 2012-10-11 09:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/869519bc17ce Added tag jdk8-b60 for changeset cec8fa02f156 ! .hgtags Changeset: 4d8b411a2bc1 Author: jgodinez Date: 2012-09-25 09:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4d8b411a2bc1 7158350: [macosx] Strange results of SwingUIText printing Reviewed-by: bae, prr ! src/macosx/native/sun/awt/CTextPipe.m Changeset: 5aff878baaf6 Author: lana Date: 2012-09-28 11:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5aff878baaf6 Merge - make/common/Defs-embedded.gmk - make/common/Release-embedded.gmk - src/macosx/classes/sun/awt/SunToolkitSubclass.java - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - test/sun/misc/URLClassPath/ClassnameCharTest.sh - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: 8dd4cae72975 Author: ceisserer Date: 2012-10-01 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8dd4cae72975 7188093: closed/sun/java2d/pipe/ScaleQualityTest.java fails Reviewed-by: prr, flar ! src/solaris/classes/sun/java2d/xr/XRDrawImage.java Changeset: 89a1094e384f Author: bae Date: 2012-10-05 16:21 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89a1094e384f 8000176: Need automated test for checking scale quality Reviewed-by: prr, bae Contributed-by: Vadim Pakhnushev + test/sun/java2d/pipe/InterpolationQualityTest.java Changeset: 2bc7669294cc Author: lana Date: 2012-10-08 15:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2bc7669294cc Merge Changeset: 9aa37a39cf39 Author: zhouyx Date: 2012-09-20 17:39 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9aa37a39cf39 7194184: JColorChooser swatch cannot accessed from keyboard Reviewed-by: rupashka, alexsch ! src/share/classes/javax/swing/colorchooser/DefaultSwatchChooserPanel.java + test/javax/swing/JColorChooser/Test7194184.java Changeset: 4f519691520c Author: vkarnauk Date: 2012-09-20 17:55 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f519691520c 7123767: Wrong tooltip location in Multi-Monitor configurations Reviewed-by: rupashka ! src/share/classes/javax/swing/ToolTipManager.java + test/javax/swing/ToolTipManager/7123767/bug7123767.java Changeset: adddc599e551 Author: alexsch Date: 2012-09-21 13:48 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/adddc599e551 7199180: [macosx] Dead keys handling for input methods Reviewed-by: kizune, anthony ! src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java ! src/macosx/native/sun/awt/AWTEvent.m ! src/macosx/native/sun/awt/AWTView.m + test/java/awt/event/KeyEvent/DeadKey/DeadKeyMacOSXInputText.java Changeset: 88048b34405e Author: leonidr Date: 2012-09-24 15:25 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88048b34405e 7124239: [macosx] sun.awt.SunToolkit.InfiniteLoop exception in realSync called from SwingTestHelper Reviewed-by: anthony ! src/macosx/native/sun/awt/LWCToolkit.m ! src/macosx/native/sun/osxapp/NSApplicationAWT.h ! src/macosx/native/sun/osxapp/NSApplicationAWT.m Changeset: d6cba7bfbb3d Author: leonidr Date: 2012-09-24 18:24 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6cba7bfbb3d 7179349: [macosx] Java processes on Mac should not use default Apple icon Reviewed-by: anthony ! make/sun/osxapp/Makefile + make/sun/osxapp/ToBin.java ! src/macosx/native/sun/osxapp/NSApplicationAWT.m + src/macosx/native/sun/osxapp/resource/icons/JavaApp.icns Changeset: 39227bb92978 Author: serb Date: 2012-09-24 21:33 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/39227bb92978 7160627: [macosx] TextArea has wrong initial size 7124213: [macosx] pack() does ignore size of a component; doesn't on the other platforms Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWCanvasPeer.java ! src/macosx/classes/sun/lwawt/LWCheckboxPeer.java ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWContainerPeer.java ! src/macosx/classes/sun/lwawt/LWLabelPeer.java ! src/macosx/classes/sun/lwawt/LWListPeer.java ! src/macosx/classes/sun/lwawt/LWPanelPeer.java ! src/macosx/classes/sun/lwawt/LWScrollBarPeer.java ! src/macosx/classes/sun/lwawt/LWTextAreaPeer.java ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java ! src/macosx/classes/sun/lwawt/LWToolkit.java + test/java/awt/ScrollPane/ScrollPanePreferredSize/ScrollPanePreferredSize.java + test/java/awt/TextArea/TextAreaTwicePack/TextAreaTwicePack.java Changeset: c8da47a4d441 Author: alexsch Date: 2012-09-26 18:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8da47a4d441 7124515: [macosx] Test fail like 6366126 (ArrayIndexOutOfBoundException pressing ENTER after removing items) Reviewed-by: serb, anthony + test/java/awt/List/EmptyListEventTest/EmptyListEventTest.java Changeset: ad467dee852a Author: alexsch Date: 2012-09-28 14:54 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ad467dee852a 7197619: Using modifiers for the dead key detection on Windows Reviewed-by: bagiras, leonidr ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h Changeset: 4b8bb77fdda9 Author: lana Date: 2012-09-28 10:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4b8bb77fdda9 Merge - make/common/Defs-embedded.gmk - make/common/Release-embedded.gmk - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - test/sun/misc/URLClassPath/ClassnameCharTest.sh - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: 3ac112755bb5 Author: bagiras Date: 2012-10-03 21:01 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3ac112755bb5 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call Reviewed-by: art, denis ! src/macosx/native/sun/awt/InitIDs.m ! src/share/classes/java/awt/Choice.java ! src/solaris/native/sun/awt/initIDs.c ! src/windows/native/sun/windows/awt_Choice.cpp ! src/windows/native/sun/windows/awt_Choice.h + test/java/awt/Choice/ItemStateChangeTest/ItemStateChangeTest.java Changeset: 27ee94051373 Author: lana Date: 2012-10-08 15:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/27ee94051373 Merge Changeset: d8581143e11d Author: lana Date: 2012-10-08 15:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d8581143e11d Merge - src/share/classes/sun/util/xml/XMLUtils.java - src/share/test/pack200/pack.conf Changeset: 61ddb3fd000a Author: lana Date: 2012-10-11 16:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/61ddb3fd000a Merge - src/share/classes/sun/util/xml/XMLUtils.java - src/share/test/pack200/pack.conf Changeset: e23f8e0a1d89 Author: lana Date: 2012-10-12 14:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e23f8e0a1d89 Merge From lana.steuck at oracle.com Fri Oct 12 15:44:23 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Fri, 12 Oct 2012 22:44:23 +0000 Subject: hg: jdk8/tl/langtools: 6 new changesets Message-ID: <20121012224440.3214447348@hg.openjdk.java.net> Changeset: f299927fc316 Author: katleman Date: 2012-09-27 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f299927fc316 Added tag jdk8-b58 for changeset 804a3fbc86e2 ! .hgtags Changeset: 3d2b98ffcb53 Author: katleman Date: 2012-10-04 14:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3d2b98ffcb53 Added tag jdk8-b59 for changeset f299927fc316 ! .hgtags Changeset: 67f7408d935e Author: katleman Date: 2012-10-11 09:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/67f7408d935e Added tag jdk8-b60 for changeset 3d2b98ffcb53 ! .hgtags Changeset: aa3ef5c09b1b Author: lana Date: 2012-10-08 15:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/aa3ef5c09b1b Merge Changeset: 26020b247ad3 Author: lana Date: 2012-10-11 17:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/26020b247ad3 Merge Changeset: 0d1818e9d4ae Author: lana Date: 2012-10-12 14:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/0d1818e9d4ae Merge From alan.bateman at oracle.com Sat Oct 13 02:16:08 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 13 Oct 2012 09:16:08 +0000 Subject: hg: jdk8/tl/jdk: 7146552: java/util/logging/LoggingMXBeanTest.java failing intermittently Message-ID: <20121013091652.5534847359@hg.openjdk.java.net> Changeset: ff641c5b329b Author: jgish Date: 2012-10-13 10:15 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff641c5b329b 7146552: java/util/logging/LoggingMXBeanTest.java failing intermittently Reviewed-by: alanb, mchung ! test/java/util/logging/LoggingMXBeanTest.java ! test/java/util/logging/LoggingMXBeanTest2.java From alan.bateman at oracle.com Sun Oct 14 15:06:58 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sun, 14 Oct 2012 22:06:58 +0000 Subject: hg: jdk8/tl/jdk: 7194449: String resources for Key Tool and Policy Tool should be in their respective packages Message-ID: <20121014220728.6528947369@hg.openjdk.java.net> Changeset: fe28e0b035e7 Author: sflores Date: 2012-10-14 22:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fe28e0b035e7 7194449: String resources for Key Tool and Policy Tool should be in their respective packages Reviewed-by: alanb, weijun, mullan ! make/common/Release.gmk ! make/launchers/Makefile ! make/sun/security/tools/Makefile ! makefiles/CompileLaunchers.gmk ! makefiles/CreateJars.gmk - src/share/classes/sun/security/tools/CertAndKeyGen.java - src/share/classes/sun/security/tools/JarSigner.java - src/share/classes/sun/security/tools/JarSignerResources.java - src/share/classes/sun/security/tools/JarSignerResources_ja.java - src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java ! src/share/classes/sun/security/tools/KeyStoreUtil.java - src/share/classes/sun/security/tools/KeyTool.java - src/share/classes/sun/security/tools/TimestampedSigner.java + src/share/classes/sun/security/tools/jarsigner/Main.java + src/share/classes/sun/security/tools/jarsigner/Resources.java + src/share/classes/sun/security/tools/jarsigner/Resources_ja.java + src/share/classes/sun/security/tools/jarsigner/Resources_zh_CN.java + src/share/classes/sun/security/tools/jarsigner/TimestampedSigner.java + src/share/classes/sun/security/tools/keytool/CertAndKeyGen.java + src/share/classes/sun/security/tools/keytool/Main.java + src/share/classes/sun/security/tools/keytool/Resources.java + src/share/classes/sun/security/tools/keytool/Resources_de.java + src/share/classes/sun/security/tools/keytool/Resources_es.java + src/share/classes/sun/security/tools/keytool/Resources_fr.java + src/share/classes/sun/security/tools/keytool/Resources_it.java + src/share/classes/sun/security/tools/keytool/Resources_ja.java + src/share/classes/sun/security/tools/keytool/Resources_ko.java + src/share/classes/sun/security/tools/keytool/Resources_pt_BR.java + src/share/classes/sun/security/tools/keytool/Resources_sv.java + src/share/classes/sun/security/tools/keytool/Resources_zh_CN.java + src/share/classes/sun/security/tools/keytool/Resources_zh_HK.java + src/share/classes/sun/security/tools/keytool/Resources_zh_TW.java ! src/share/classes/sun/security/tools/policytool/PolicyTool.java + src/share/classes/sun/security/tools/policytool/Resources.java + src/share/classes/sun/security/tools/policytool/Resources_de.java + src/share/classes/sun/security/tools/policytool/Resources_es.java + src/share/classes/sun/security/tools/policytool/Resources_fr.java + src/share/classes/sun/security/tools/policytool/Resources_it.java + src/share/classes/sun/security/tools/policytool/Resources_ja.java + src/share/classes/sun/security/tools/policytool/Resources_ko.java + src/share/classes/sun/security/tools/policytool/Resources_pt_BR.java + src/share/classes/sun/security/tools/policytool/Resources_sv.java + src/share/classes/sun/security/tools/policytool/Resources_zh_CN.java + src/share/classes/sun/security/tools/policytool/Resources_zh_HK.java + src/share/classes/sun/security/tools/policytool/Resources_zh_TW.java ! src/share/classes/sun/security/util/Resources.java ! src/share/classes/sun/security/util/Resources_de.java ! src/share/classes/sun/security/util/Resources_es.java ! src/share/classes/sun/security/util/Resources_fr.java ! src/share/classes/sun/security/util/Resources_it.java ! src/share/classes/sun/security/util/Resources_ja.java ! src/share/classes/sun/security/util/Resources_ko.java ! src/share/classes/sun/security/util/Resources_pt_BR.java ! src/share/classes/sun/security/util/Resources_sv.java ! src/share/classes/sun/security/util/Resources_zh_CN.java ! src/share/classes/sun/security/util/Resources_zh_TW.java ! test/sun/security/pkcs12/PKCS12SameKeyId.java ! test/sun/security/tools/jarsigner/JarSigningNonAscii.java ! test/sun/security/tools/jarsigner/LargeJarEntry.java ! test/sun/security/tools/keytool/CloseFile.java ! test/sun/security/tools/keytool/KeyToolTest.java ! test/sun/security/tools/keytool/NewSize7.java ! test/sun/security/tools/keytool/StartDateTest.java ! test/sun/security/tools/keytool/UnknownAndUnparseable.java ! test/sun/security/tools/keytool/autotest.sh ! test/sun/security/tools/keytool/standard.sh ! test/sun/security/util/Resources/Format.java ! test/sun/security/util/Resources/NewNamesFormat.java ! test/sun/security/util/Resources/NewResourcesNames.java ! test/sun/security/x509/AlgorithmId/NonStandardNames.java From david.holmes at oracle.com Sun Oct 14 19:19:49 2012 From: david.holmes at oracle.com (David Holmes) Date: Mon, 15 Oct 2012 12:19:49 +1000 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <507817C7.9000703@oracle.com> References: <5075835F.3050604@oracle.com> <50767E5A.7060908@oracle.com> <5077840F.6050601@oracle.com> <5077CB09.7010005@oracle.com> <507817C7.9000703@oracle.com> Message-ID: <507B72C5.4060807@oracle.com> Hi Jaroslav, I think your changes now go further than needed. The original code uses a dual synchronization scheme: a) it synchronizes most of the Timer methods b) it also uses a thread-safe Hashtable This means that not all of the Timer methods need to be synchronized because the only thread-safe action needed is the actual access to the Hashtable in some methods. The flaw with the original code was simply that the iteration of the Hashtable in notifyAlaramClock was not done in a thread-safe manner. I believe this could be fixed simply by synchronizing on the Hashtable here: 1186 synchronized(timerTable) { with no need to change the type of the timerTable, nor the synchronization on other Timer methods. You could alternatively synchronize on the Timer itself - as you now do - provided all methods of the Timer that mutate the Hashtable are themselves synchronized on the timer. What you have is not incorrect though, and may remove unnecessary synchronization in some cases (but increases the size of critical sections in others). Also here: 165 volatile private int counterID = 0; there is no need to add volatile as counterID is only accessed within synchronized methods. David ----- On 12/10/2012 11:14 PM, Jaroslav Bachorik wrote: > The updated webrev is now at http://btrace.kenai.com/webrevs/JDK-6809322/ > > I am sorry for this chaos with webrev locations but its not that easy to > work efficiently without an OpenJDK username :/ > > -JB- > > On 10/12/2012 09:47 AM, Jaroslav Bachorik wrote: >> On Fri 12 Oct 2012 04:44:31 AM CEST, David Holmes wrote: >>> Hi Jaroslav, >>> >>> >>> On 11/10/2012 6:07 PM, Jaroslav Bachorik wrote: >>>> Dmitry has put the webrev on the public CR - >>>> http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/ >>>> >>>> >>>> Thanks! >>>> >>>> -JB- >>>> >>>> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>>>> I am looking for a review and a sponsor. >>>>> >>>>> The issue is about some javax.management.timer.Timer notifications not >>>>> being received by the listeners if the notifications are generated >>>>> rapidly. >>>>> >>>>> The problem is caused by ConcurrentModificationException being thrown - >>>>> the exception itself is ignored but the dispatcher logic is skipped. >>>>> Therefore the currently processed notification gets lost. >>> >>> Can you point out where exactly in the code the exception is thrown >>> and caught. I'd like to understand the problem better. >> >> The CME is thrown in Timer.notifyAlarmClock() method in this case - but >> may happen in other places as well. >> >> Actually, in some places the access to the timerTable map is >> synchronized while in others it isn't. While switching the Hashtable >> for ConcurrentHashMap resolves this particular issue it might be >> beneficial to correct the partial synchronization instead. >> >>> >>>>> >>>>> The CME is thrown due to the Timer.timerTable being iterated over while >>>>> other threads try to remove some of its elements. Fix consists of >>>>> replacing the Hashtable used for Timer.timerTable by ConcurrentHashMap >>>>> which handles such situations with grace. >>> >>> Be aware that it may also give surprising results as removal is no >>> longer synchronized at all with processing. So it could now appear >>> that a notification is processed after a listener has been removed. >> >> Indeed, the CME is the symptom of the out-of-order processing - the >> removal method is synchronized on (Timer.this) while the >> notifyAlarmClock() method, processing the notifications, runs >> unsynchronized. >> >> Thanks for pointing this out. I will have something to think about. >> >> -JB- >> >>> >>> David >>> ----- >>> >>>>> The patch webrev is available @ >>>>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>>>> >>>>> Thanks, >>>>> >>>>> -JB- >>>>> >>>> >> >> > From rob.mckenna at oracle.com Sun Oct 14 19:23:18 2012 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Mon, 15 Oct 2012 02:23:18 +0000 Subject: hg: jdk8/tl/jdk: 8000817: Reinstate accidentally removed sleep() from ProcessBuilder/Basic.java Message-ID: <20121015022331.216EF4736C@hg.openjdk.java.net> Changeset: 7055257a25c4 Author: robm Date: 2012-10-15 03:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7055257a25c4 8000817: Reinstate accidentally removed sleep() from ProcessBuilder/Basic.java Reviewed-by: alanb, martin ! test/java/lang/ProcessBuilder/Basic.java From jaroslav.bachorik at oracle.com Mon Oct 15 03:08:30 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 15 Oct 2012 12:08:30 +0200 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <507B72C5.4060807@oracle.com> References: <5075835F.3050604@oracle.com> <50767E5A.7060908@oracle.com> <5077840F.6050601@oracle.com> <5077CB09.7010005@oracle.com> <507817C7.9000703@oracle.com> <507B72C5.4060807@oracle.com> Message-ID: <507BE09E.5090702@oracle.com> Thanks David, On 10/15/2012 04:19 AM, David Holmes wrote: > Hi Jaroslav, > > I think your changes now go further than needed. The original code uses > a dual synchronization scheme: > > a) it synchronizes most of the Timer methods > b) it also uses a thread-safe Hashtable > > This means that not all of the Timer methods need to be synchronized > because the only thread-safe action needed is the actual access to the > Hashtable in some methods. > > The flaw with the original code was simply that the iteration of the > Hashtable in notifyAlaramClock was not done in a thread-safe manner. I > believe this could be fixed simply by synchronizing on the Hashtable here: > > 1186 synchronized(timerTable) { > > with no need to change the type of the timerTable, nor the > synchronization on other Timer methods. You could alternatively > synchronize on the Timer itself - as you now do - provided all methods > of the Timer that mutate the Hashtable are themselves synchronized on > the timer. > > What you have is not incorrect though, and may remove unnecessary > synchronization in some cases (but increases the size of critical > sections in others). > > Also here: > > 165 volatile private int counterID = 0; > > there is no need to add volatile as counterID is only accessed within > synchronized methods. Yes, I see your point. I just want to ask - in cases of fixing issues like this the preferred way is to introduce minimal changes even if it means leaving the parts of the code sub-optimal? IMO, having dual synchronization scheme might be considered as sub-optimal as it makes it more difficult to see the author's intentions. But I am fine with leaving the Hashtable intact and just synchronizing the iteration part correctly - it resolves the issue. The update webrev is available at http://btrace.kenai.com/webrevs/JDK-6809322/webrev.v4 Regards, -JB- > > David > ----- > > On 12/10/2012 11:14 PM, Jaroslav Bachorik wrote: >> The updated webrev is now at http://btrace.kenai.com/webrevs/JDK-6809322/ >> >> I am sorry for this chaos with webrev locations but its not that easy to >> work efficiently without an OpenJDK username :/ >> >> -JB- >> >> On 10/12/2012 09:47 AM, Jaroslav Bachorik wrote: >>> On Fri 12 Oct 2012 04:44:31 AM CEST, David Holmes wrote: >>>> Hi Jaroslav, >>>> >>>> >>>> On 11/10/2012 6:07 PM, Jaroslav Bachorik wrote: >>>>> Dmitry has put the webrev on the public CR - >>>>> http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/ >>>>> >>>>> >>>>> >>>>> Thanks! >>>>> >>>>> -JB- >>>>> >>>>> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>>>>> I am looking for a review and a sponsor. >>>>>> >>>>>> The issue is about some javax.management.timer.Timer notifications >>>>>> not >>>>>> being received by the listeners if the notifications are generated >>>>>> rapidly. >>>>>> >>>>>> The problem is caused by ConcurrentModificationException being >>>>>> thrown - >>>>>> the exception itself is ignored but the dispatcher logic is skipped. >>>>>> Therefore the currently processed notification gets lost. >>>> >>>> Can you point out where exactly in the code the exception is thrown >>>> and caught. I'd like to understand the problem better. >>> >>> The CME is thrown in Timer.notifyAlarmClock() method in this case - but >>> may happen in other places as well. >>> >>> Actually, in some places the access to the timerTable map is >>> synchronized while in others it isn't. While switching the Hashtable >>> for ConcurrentHashMap resolves this particular issue it might be >>> beneficial to correct the partial synchronization instead. >>> >>>> >>>>>> >>>>>> The CME is thrown due to the Timer.timerTable being iterated over >>>>>> while >>>>>> other threads try to remove some of its elements. Fix consists of >>>>>> replacing the Hashtable used for Timer.timerTable by >>>>>> ConcurrentHashMap >>>>>> which handles such situations with grace. >>>> >>>> Be aware that it may also give surprising results as removal is no >>>> longer synchronized at all with processing. So it could now appear >>>> that a notification is processed after a listener has been removed. >>> >>> Indeed, the CME is the symptom of the out-of-order processing - the >>> removal method is synchronized on (Timer.this) while the >>> notifyAlarmClock() method, processing the notifications, runs >>> unsynchronized. >>> >>> Thanks for pointing this out. I will have something to think about. >>> >>> -JB- >>> >>>> >>>> David >>>> ----- >>>> >>>>>> The patch webrev is available @ >>>>>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>>>>> >>>>>> Thanks, >>>>>> >>>>>> -JB- >>>>>> >>>>> >>> >>> >> From david.holmes at oracle.com Mon Oct 15 04:45:37 2012 From: david.holmes at oracle.com (David Holmes) Date: Mon, 15 Oct 2012 21:45:37 +1000 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <507BE09E.5090702@oracle.com> References: <5075835F.3050604@oracle.com> <50767E5A.7060908@oracle.com> <5077840F.6050601@oracle.com> <5077CB09.7010005@oracle.com> <507817C7.9000703@oracle.com> <507B72C5.4060807@oracle.com> <507BE09E.5090702@oracle.com> Message-ID: <507BF761.8040500@oracle.com> On 15/10/2012 8:08 PM, Jaroslav Bachorik wrote: > On 10/15/2012 04:19 AM, David Holmes wrote: >> I think your changes now go further than needed. The original code uses >> a dual synchronization scheme: >> >> a) it synchronizes most of the Timer methods >> b) it also uses a thread-safe Hashtable >> >> This means that not all of the Timer methods need to be synchronized >> because the only thread-safe action needed is the actual access to the >> Hashtable in some methods. >> >> The flaw with the original code was simply that the iteration of the >> Hashtable in notifyAlaramClock was not done in a thread-safe manner. I >> believe this could be fixed simply by synchronizing on the Hashtable here: >> >> 1186 synchronized(timerTable) { >> >> with no need to change the type of the timerTable, nor the >> synchronization on other Timer methods. You could alternatively >> synchronize on the Timer itself - as you now do - provided all methods >> of the Timer that mutate the Hashtable are themselves synchronized on >> the timer. >> >> What you have is not incorrect though, and may remove unnecessary >> synchronization in some cases (but increases the size of critical >> sections in others). >> >> Also here: >> >> 165 volatile private int counterID = 0; >> >> there is no need to add volatile as counterID is only accessed within >> synchronized methods. > > Yes, I see your point. I just want to ask - in cases of fixing issues > like this the preferred way is to introduce minimal changes even if it > means leaving the parts of the code sub-optimal? IMO, having dual > synchronization scheme might be considered as sub-optimal as it makes it > more difficult to see the author's intentions. Optimal depends on your evaluation criteria. The original design may have been done with performance in mind and a view to minimising critical sections. Without knowing what the original design criteria was, and unless you are fixing a problem caused by key aspects of that design, then minimal changes should be favoured. > But I am fine with leaving the Hashtable intact and just synchronizing > the iteration part correctly - it resolves the issue. > > The update webrev is available at > http://btrace.kenai.com/webrevs/JDK-6809322/webrev.v4 I'm not sure the comment is needed in that form. Hashtable is snchronized internally but you need to use external synchronization when iterating through it. David > Regards, > > -JB- > >> >> David >> ----- >> >> On 12/10/2012 11:14 PM, Jaroslav Bachorik wrote: >>> The updated webrev is now at http://btrace.kenai.com/webrevs/JDK-6809322/ >>> >>> I am sorry for this chaos with webrev locations but its not that easy to >>> work efficiently without an OpenJDK username :/ >>> >>> -JB- >>> >>> On 10/12/2012 09:47 AM, Jaroslav Bachorik wrote: >>>> On Fri 12 Oct 2012 04:44:31 AM CEST, David Holmes wrote: >>>>> Hi Jaroslav, >>>>> >>>>> >>>>> On 11/10/2012 6:07 PM, Jaroslav Bachorik wrote: >>>>>> Dmitry has put the webrev on the public CR - >>>>>> http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/ >>>>>> >>>>>> >>>>>> >>>>>> Thanks! >>>>>> >>>>>> -JB- >>>>>> >>>>>> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>>>>>> I am looking for a review and a sponsor. >>>>>>> >>>>>>> The issue is about some javax.management.timer.Timer notifications >>>>>>> not >>>>>>> being received by the listeners if the notifications are generated >>>>>>> rapidly. >>>>>>> >>>>>>> The problem is caused by ConcurrentModificationException being >>>>>>> thrown - >>>>>>> the exception itself is ignored but the dispatcher logic is skipped. >>>>>>> Therefore the currently processed notification gets lost. >>>>> >>>>> Can you point out where exactly in the code the exception is thrown >>>>> and caught. I'd like to understand the problem better. >>>> >>>> The CME is thrown in Timer.notifyAlarmClock() method in this case - but >>>> may happen in other places as well. >>>> >>>> Actually, in some places the access to the timerTable map is >>>> synchronized while in others it isn't. While switching the Hashtable >>>> for ConcurrentHashMap resolves this particular issue it might be >>>> beneficial to correct the partial synchronization instead. >>>> >>>>> >>>>>>> >>>>>>> The CME is thrown due to the Timer.timerTable being iterated over >>>>>>> while >>>>>>> other threads try to remove some of its elements. Fix consists of >>>>>>> replacing the Hashtable used for Timer.timerTable by >>>>>>> ConcurrentHashMap >>>>>>> which handles such situations with grace. >>>>> >>>>> Be aware that it may also give surprising results as removal is no >>>>> longer synchronized at all with processing. So it could now appear >>>>> that a notification is processed after a listener has been removed. >>>> >>>> Indeed, the CME is the symptom of the out-of-order processing - the >>>> removal method is synchronized on (Timer.this) while the >>>> notifyAlarmClock() method, processing the notifications, runs >>>> unsynchronized. >>>> >>>> Thanks for pointing this out. I will have something to think about. >>>> >>>> -JB- >>>> >>>>> >>>>> David >>>>> ----- >>>>> >>>>>>> The patch webrev is available @ >>>>>>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> -JB- >>>>>>> >>>>>> >>>> >>>> >>> > From jaroslav.bachorik at oracle.com Mon Oct 15 05:14:58 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 15 Oct 2012 14:14:58 +0200 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <507BF761.8040500@oracle.com> References: <5075835F.3050604@oracle.com> <50767E5A.7060908@oracle.com> <5077840F.6050601@oracle.com> <5077CB09.7010005@oracle.com> <507817C7.9000703@oracle.com> <507B72C5.4060807@oracle.com> <507BE09E.5090702@oracle.com> <507BF761.8040500@oracle.com> Message-ID: <507BFE42.1050200@oracle.com> On 10/15/2012 01:45 PM, David Holmes wrote: > On 15/10/2012 8:08 PM, Jaroslav Bachorik wrote: >> On 10/15/2012 04:19 AM, David Holmes wrote: >>> I think your changes now go further than needed. The original code uses >>> a dual synchronization scheme: >>> >>> a) it synchronizes most of the Timer methods >>> b) it also uses a thread-safe Hashtable >>> >>> This means that not all of the Timer methods need to be synchronized >>> because the only thread-safe action needed is the actual access to the >>> Hashtable in some methods. >>> >>> The flaw with the original code was simply that the iteration of the >>> Hashtable in notifyAlaramClock was not done in a thread-safe manner. I >>> believe this could be fixed simply by synchronizing on the Hashtable >>> here: >>> >>> 1186 synchronized(timerTable) { >>> >>> with no need to change the type of the timerTable, nor the >>> synchronization on other Timer methods. You could alternatively >>> synchronize on the Timer itself - as you now do - provided all methods >>> of the Timer that mutate the Hashtable are themselves synchronized on >>> the timer. >>> >>> What you have is not incorrect though, and may remove unnecessary >>> synchronization in some cases (but increases the size of critical >>> sections in others). >>> >>> Also here: >>> >>> 165 volatile private int counterID = 0; >>> >>> there is no need to add volatile as counterID is only accessed within >>> synchronized methods. >> >> Yes, I see your point. I just want to ask - in cases of fixing issues >> like this the preferred way is to introduce minimal changes even if it >> means leaving the parts of the code sub-optimal? IMO, having dual >> synchronization scheme might be considered as sub-optimal as it makes it >> more difficult to see the author's intentions. > > Optimal depends on your evaluation criteria. The original design may > have been done with performance in mind and a view to minimising > critical sections. Without knowing what the original design criteria > was, and unless you are fixing a problem caused by key aspects of that > design, then minimal changes should be favoured. > >> But I am fine with leaving the Hashtable intact and just synchronizing >> the iteration part correctly - it resolves the issue. >> >> The update webrev is available at >> http://btrace.kenai.com/webrevs/JDK-6809322/webrev.v4 > > I'm not sure the comment is needed in that form. Hashtable is > snchronized internally but you need to use external synchronization when > iterating through it. Ok, it's gone. http://btrace.kenai.com/webrevs/JDK-6809322/webrev.v5/ > > David > >> Regards, >> >> -JB- >> >>> >>> David >>> ----- >>> >>> On 12/10/2012 11:14 PM, Jaroslav Bachorik wrote: >>>> The updated webrev is now at >>>> http://btrace.kenai.com/webrevs/JDK-6809322/ >>>> >>>> I am sorry for this chaos with webrev locations but its not that >>>> easy to >>>> work efficiently without an OpenJDK username :/ >>>> >>>> -JB- >>>> >>>> On 10/12/2012 09:47 AM, Jaroslav Bachorik wrote: >>>>> On Fri 12 Oct 2012 04:44:31 AM CEST, David Holmes wrote: >>>>>> Hi Jaroslav, >>>>>> >>>>>> >>>>>> On 11/10/2012 6:07 PM, Jaroslav Bachorik wrote: >>>>>>> Dmitry has put the webrev on the public CR - >>>>>>> http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/ >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> Thanks! >>>>>>> >>>>>>> -JB- >>>>>>> >>>>>>> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>>>>>>> I am looking for a review and a sponsor. >>>>>>>> >>>>>>>> The issue is about some javax.management.timer.Timer notifications >>>>>>>> not >>>>>>>> being received by the listeners if the notifications are generated >>>>>>>> rapidly. >>>>>>>> >>>>>>>> The problem is caused by ConcurrentModificationException being >>>>>>>> thrown - >>>>>>>> the exception itself is ignored but the dispatcher logic is >>>>>>>> skipped. >>>>>>>> Therefore the currently processed notification gets lost. >>>>>> >>>>>> Can you point out where exactly in the code the exception is thrown >>>>>> and caught. I'd like to understand the problem better. >>>>> >>>>> The CME is thrown in Timer.notifyAlarmClock() method in this case - >>>>> but >>>>> may happen in other places as well. >>>>> >>>>> Actually, in some places the access to the timerTable map is >>>>> synchronized while in others it isn't. While switching the Hashtable >>>>> for ConcurrentHashMap resolves this particular issue it might be >>>>> beneficial to correct the partial synchronization instead. >>>>> >>>>>> >>>>>>>> >>>>>>>> The CME is thrown due to the Timer.timerTable being iterated over >>>>>>>> while >>>>>>>> other threads try to remove some of its elements. Fix consists of >>>>>>>> replacing the Hashtable used for Timer.timerTable by >>>>>>>> ConcurrentHashMap >>>>>>>> which handles such situations with grace. >>>>>> >>>>>> Be aware that it may also give surprising results as removal is no >>>>>> longer synchronized at all with processing. So it could now appear >>>>>> that a notification is processed after a listener has been removed. >>>>> >>>>> Indeed, the CME is the symptom of the out-of-order processing - the >>>>> removal method is synchronized on (Timer.this) while the >>>>> notifyAlarmClock() method, processing the notifications, runs >>>>> unsynchronized. >>>>> >>>>> Thanks for pointing this out. I will have something to think about. >>>>> >>>>> -JB- >>>>> >>>>>> >>>>>> David >>>>>> ----- >>>>>> >>>>>>>> The patch webrev is available @ >>>>>>>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>>>> -JB- >>>>>>>> >>>>>>> >>>>> >>>>> >>>> >> From david.holmes at oracle.com Mon Oct 15 05:18:25 2012 From: david.holmes at oracle.com (David Holmes) Date: Mon, 15 Oct 2012 22:18:25 +1000 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <507BFE42.1050200@oracle.com> References: <5075835F.3050604@oracle.com> <50767E5A.7060908@oracle.com> <5077840F.6050601@oracle.com> <5077CB09.7010005@oracle.com> <507817C7.9000703@oracle.com> <507B72C5.4060807@oracle.com> <507BE09E.5090702@oracle.com> <507BF761.8040500@oracle.com> <507BFE42.1050200@oracle.com> Message-ID: <507BFF11.1080404@oracle.com> Looks good to me. Hopefully someone else will chime in too :) Thanks, David On 15/10/2012 10:14 PM, Jaroslav Bachorik wrote: > On 10/15/2012 01:45 PM, David Holmes wrote: >> On 15/10/2012 8:08 PM, Jaroslav Bachorik wrote: >>> On 10/15/2012 04:19 AM, David Holmes wrote: >>>> I think your changes now go further than needed. The original code uses >>>> a dual synchronization scheme: >>>> >>>> a) it synchronizes most of the Timer methods >>>> b) it also uses a thread-safe Hashtable >>>> >>>> This means that not all of the Timer methods need to be synchronized >>>> because the only thread-safe action needed is the actual access to the >>>> Hashtable in some methods. >>>> >>>> The flaw with the original code was simply that the iteration of the >>>> Hashtable in notifyAlaramClock was not done in a thread-safe manner. I >>>> believe this could be fixed simply by synchronizing on the Hashtable >>>> here: >>>> >>>> 1186 synchronized(timerTable) { >>>> >>>> with no need to change the type of the timerTable, nor the >>>> synchronization on other Timer methods. You could alternatively >>>> synchronize on the Timer itself - as you now do - provided all methods >>>> of the Timer that mutate the Hashtable are themselves synchronized on >>>> the timer. >>>> >>>> What you have is not incorrect though, and may remove unnecessary >>>> synchronization in some cases (but increases the size of critical >>>> sections in others). >>>> >>>> Also here: >>>> >>>> 165 volatile private int counterID = 0; >>>> >>>> there is no need to add volatile as counterID is only accessed within >>>> synchronized methods. >>> >>> Yes, I see your point. I just want to ask - in cases of fixing issues >>> like this the preferred way is to introduce minimal changes even if it >>> means leaving the parts of the code sub-optimal? IMO, having dual >>> synchronization scheme might be considered as sub-optimal as it makes it >>> more difficult to see the author's intentions. >> >> Optimal depends on your evaluation criteria. The original design may >> have been done with performance in mind and a view to minimising >> critical sections. Without knowing what the original design criteria >> was, and unless you are fixing a problem caused by key aspects of that >> design, then minimal changes should be favoured. >> >>> But I am fine with leaving the Hashtable intact and just synchronizing >>> the iteration part correctly - it resolves the issue. >>> >>> The update webrev is available at >>> http://btrace.kenai.com/webrevs/JDK-6809322/webrev.v4 >> >> I'm not sure the comment is needed in that form. Hashtable is >> snchronized internally but you need to use external synchronization when >> iterating through it. > > Ok, it's gone. http://btrace.kenai.com/webrevs/JDK-6809322/webrev.v5/ > >> >> David >> >>> Regards, >>> >>> -JB- >>> >>>> >>>> David >>>> ----- >>>> >>>> On 12/10/2012 11:14 PM, Jaroslav Bachorik wrote: >>>>> The updated webrev is now at >>>>> http://btrace.kenai.com/webrevs/JDK-6809322/ >>>>> >>>>> I am sorry for this chaos with webrev locations but its not that >>>>> easy to >>>>> work efficiently without an OpenJDK username :/ >>>>> >>>>> -JB- >>>>> >>>>> On 10/12/2012 09:47 AM, Jaroslav Bachorik wrote: >>>>>> On Fri 12 Oct 2012 04:44:31 AM CEST, David Holmes wrote: >>>>>>> Hi Jaroslav, >>>>>>> >>>>>>> >>>>>>> On 11/10/2012 6:07 PM, Jaroslav Bachorik wrote: >>>>>>>> Dmitry has put the webrev on the public CR - >>>>>>>> http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/ >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Thanks! >>>>>>>> >>>>>>>> -JB- >>>>>>>> >>>>>>>> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>>>>>>>> I am looking for a review and a sponsor. >>>>>>>>> >>>>>>>>> The issue is about some javax.management.timer.Timer notifications >>>>>>>>> not >>>>>>>>> being received by the listeners if the notifications are generated >>>>>>>>> rapidly. >>>>>>>>> >>>>>>>>> The problem is caused by ConcurrentModificationException being >>>>>>>>> thrown - >>>>>>>>> the exception itself is ignored but the dispatcher logic is >>>>>>>>> skipped. >>>>>>>>> Therefore the currently processed notification gets lost. >>>>>>> >>>>>>> Can you point out where exactly in the code the exception is thrown >>>>>>> and caught. I'd like to understand the problem better. >>>>>> >>>>>> The CME is thrown in Timer.notifyAlarmClock() method in this case - >>>>>> but >>>>>> may happen in other places as well. >>>>>> >>>>>> Actually, in some places the access to the timerTable map is >>>>>> synchronized while in others it isn't. While switching the Hashtable >>>>>> for ConcurrentHashMap resolves this particular issue it might be >>>>>> beneficial to correct the partial synchronization instead. >>>>>> >>>>>>> >>>>>>>>> >>>>>>>>> The CME is thrown due to the Timer.timerTable being iterated over >>>>>>>>> while >>>>>>>>> other threads try to remove some of its elements. Fix consists of >>>>>>>>> replacing the Hashtable used for Timer.timerTable by >>>>>>>>> ConcurrentHashMap >>>>>>>>> which handles such situations with grace. >>>>>>> >>>>>>> Be aware that it may also give surprising results as removal is no >>>>>>> longer synchronized at all with processing. So it could now appear >>>>>>> that a notification is processed after a listener has been removed. >>>>>> >>>>>> Indeed, the CME is the symptom of the out-of-order processing - the >>>>>> removal method is synchronized on (Timer.this) while the >>>>>> notifyAlarmClock() method, processing the notifications, runs >>>>>> unsynchronized. >>>>>> >>>>>> Thanks for pointing this out. I will have something to think about. >>>>>> >>>>>> -JB- >>>>>> >>>>>>> >>>>>>> David >>>>>>> ----- >>>>>>> >>>>>>>>> The patch webrev is available @ >>>>>>>>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> >>>>>>>>> -JB- >>>>>>>>> >>>>>>>> >>>>>> >>>>>> >>>>> >>> > From rickard.backman at oracle.com Mon Oct 15 07:15:13 2012 From: rickard.backman at oracle.com (=?iso-8859-1?Q?Rickard_B=E4ckman?=) Date: Mon, 15 Oct 2012 16:15:13 +0200 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <507BFE42.1050200@oracle.com> References: <5075835F.3050604@oracle.com> <50767E5A.7060908@oracle.com> <5077840F.6050601@oracle.com> <5077CB09.7010005@oracle.com> <507817C7.9000703@oracle.com> <507B72C5.4060807@oracle.com> <507BE09E.5090702@oracle.com> <507BF761.8040500@oracle.com> <507BFE42.1050200@oracle.com> Message-ID: <12F6F059-25F8-4448-8D1E-25C25DAE87E9@oracle.com> Looks good! /R On Oct 15, 2012, at 2:14 PM, Jaroslav Bachorik wrote: > On 10/15/2012 01:45 PM, David Holmes wrote: >> On 15/10/2012 8:08 PM, Jaroslav Bachorik wrote: >>> On 10/15/2012 04:19 AM, David Holmes wrote: >>>> I think your changes now go further than needed. The original code uses >>>> a dual synchronization scheme: >>>> >>>> a) it synchronizes most of the Timer methods >>>> b) it also uses a thread-safe Hashtable >>>> >>>> This means that not all of the Timer methods need to be synchronized >>>> because the only thread-safe action needed is the actual access to the >>>> Hashtable in some methods. >>>> >>>> The flaw with the original code was simply that the iteration of the >>>> Hashtable in notifyAlaramClock was not done in a thread-safe manner. I >>>> believe this could be fixed simply by synchronizing on the Hashtable >>>> here: >>>> >>>> 1186 synchronized(timerTable) { >>>> >>>> with no need to change the type of the timerTable, nor the >>>> synchronization on other Timer methods. You could alternatively >>>> synchronize on the Timer itself - as you now do - provided all methods >>>> of the Timer that mutate the Hashtable are themselves synchronized on >>>> the timer. >>>> >>>> What you have is not incorrect though, and may remove unnecessary >>>> synchronization in some cases (but increases the size of critical >>>> sections in others). >>>> >>>> Also here: >>>> >>>> 165 volatile private int counterID = 0; >>>> >>>> there is no need to add volatile as counterID is only accessed within >>>> synchronized methods. >>> >>> Yes, I see your point. I just want to ask - in cases of fixing issues >>> like this the preferred way is to introduce minimal changes even if it >>> means leaving the parts of the code sub-optimal? IMO, having dual >>> synchronization scheme might be considered as sub-optimal as it makes it >>> more difficult to see the author's intentions. >> >> Optimal depends on your evaluation criteria. The original design may >> have been done with performance in mind and a view to minimising >> critical sections. Without knowing what the original design criteria >> was, and unless you are fixing a problem caused by key aspects of that >> design, then minimal changes should be favoured. >> >>> But I am fine with leaving the Hashtable intact and just synchronizing >>> the iteration part correctly - it resolves the issue. >>> >>> The update webrev is available at >>> http://btrace.kenai.com/webrevs/JDK-6809322/webrev.v4 >> >> I'm not sure the comment is needed in that form. Hashtable is >> snchronized internally but you need to use external synchronization when >> iterating through it. > > Ok, it's gone. http://btrace.kenai.com/webrevs/JDK-6809322/webrev.v5/ > >> >> David >> >>> Regards, >>> >>> -JB- >>> >>>> >>>> David >>>> ----- >>>> >>>> On 12/10/2012 11:14 PM, Jaroslav Bachorik wrote: >>>>> The updated webrev is now at >>>>> http://btrace.kenai.com/webrevs/JDK-6809322/ >>>>> >>>>> I am sorry for this chaos with webrev locations but its not that >>>>> easy to >>>>> work efficiently without an OpenJDK username :/ >>>>> >>>>> -JB- >>>>> >>>>> On 10/12/2012 09:47 AM, Jaroslav Bachorik wrote: >>>>>> On Fri 12 Oct 2012 04:44:31 AM CEST, David Holmes wrote: >>>>>>> Hi Jaroslav, >>>>>>> >>>>>>> >>>>>>> On 11/10/2012 6:07 PM, Jaroslav Bachorik wrote: >>>>>>>> Dmitry has put the webrev on the public CR - >>>>>>>> http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/ >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Thanks! >>>>>>>> >>>>>>>> -JB- >>>>>>>> >>>>>>>> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>>>>>>>> I am looking for a review and a sponsor. >>>>>>>>> >>>>>>>>> The issue is about some javax.management.timer.Timer notifications >>>>>>>>> not >>>>>>>>> being received by the listeners if the notifications are generated >>>>>>>>> rapidly. >>>>>>>>> >>>>>>>>> The problem is caused by ConcurrentModificationException being >>>>>>>>> thrown - >>>>>>>>> the exception itself is ignored but the dispatcher logic is >>>>>>>>> skipped. >>>>>>>>> Therefore the currently processed notification gets lost. >>>>>>> >>>>>>> Can you point out where exactly in the code the exception is thrown >>>>>>> and caught. I'd like to understand the problem better. >>>>>> >>>>>> The CME is thrown in Timer.notifyAlarmClock() method in this case - >>>>>> but >>>>>> may happen in other places as well. >>>>>> >>>>>> Actually, in some places the access to the timerTable map is >>>>>> synchronized while in others it isn't. While switching the Hashtable >>>>>> for ConcurrentHashMap resolves this particular issue it might be >>>>>> beneficial to correct the partial synchronization instead. >>>>>> >>>>>>> >>>>>>>>> >>>>>>>>> The CME is thrown due to the Timer.timerTable being iterated over >>>>>>>>> while >>>>>>>>> other threads try to remove some of its elements. Fix consists of >>>>>>>>> replacing the Hashtable used for Timer.timerTable by >>>>>>>>> ConcurrentHashMap >>>>>>>>> which handles such situations with grace. >>>>>>> >>>>>>> Be aware that it may also give surprising results as removal is no >>>>>>> longer synchronized at all with processing. So it could now appear >>>>>>> that a notification is processed after a listener has been removed. >>>>>> >>>>>> Indeed, the CME is the symptom of the out-of-order processing - the >>>>>> removal method is synchronized on (Timer.this) while the >>>>>> notifyAlarmClock() method, processing the notifications, runs >>>>>> unsynchronized. >>>>>> >>>>>> Thanks for pointing this out. I will have something to think about. >>>>>> >>>>>> -JB- >>>>>> >>>>>>> >>>>>>> David >>>>>>> ----- >>>>>>> >>>>>>>>> The patch webrev is available @ >>>>>>>>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> >>>>>>>>> -JB- >>>>>>>>> >>>>>>>> >>>>>> >>>>>> >>>>> >>> > From jaroslav.bachorik at oracle.com Mon Oct 15 09:17:16 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 15 Oct 2012 18:17:16 +0200 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <12F6F059-25F8-4448-8D1E-25C25DAE87E9@oracle.com> References: <5075835F.3050604@oracle.com> <50767E5A.7060908@oracle.com> <5077840F.6050601@oracle.com> <5077CB09.7010005@oracle.com> <507817C7.9000703@oracle.com> <507B72C5.4060807@oracle.com> <507BE09E.5090702@oracle.com> <507BF761.8040500@oracle.com> <507BFE42.1050200@oracle.com> <12F6F059-25F8-4448-8D1E-25C25DAE87E9@oracle.com> Message-ID: <507C370C.8040906@oracle.com> Thank you guys for the reviews! I would like to kindly ask someone with the committer rights to sponsor this fix and push the change. Thanks! -JB- On 10/15/2012 04:15 PM, Rickard B?ckman wrote: > Looks good! > > /R > > On Oct 15, 2012, at 2:14 PM, Jaroslav Bachorik wrote: > >> On 10/15/2012 01:45 PM, David Holmes wrote: >>> On 15/10/2012 8:08 PM, Jaroslav Bachorik wrote: >>>> On 10/15/2012 04:19 AM, David Holmes wrote: >>>>> I think your changes now go further than needed. The original code uses >>>>> a dual synchronization scheme: >>>>> >>>>> a) it synchronizes most of the Timer methods >>>>> b) it also uses a thread-safe Hashtable >>>>> >>>>> This means that not all of the Timer methods need to be synchronized >>>>> because the only thread-safe action needed is the actual access to the >>>>> Hashtable in some methods. >>>>> >>>>> The flaw with the original code was simply that the iteration of the >>>>> Hashtable in notifyAlaramClock was not done in a thread-safe manner. I >>>>> believe this could be fixed simply by synchronizing on the Hashtable >>>>> here: >>>>> >>>>> 1186 synchronized(timerTable) { >>>>> >>>>> with no need to change the type of the timerTable, nor the >>>>> synchronization on other Timer methods. You could alternatively >>>>> synchronize on the Timer itself - as you now do - provided all methods >>>>> of the Timer that mutate the Hashtable are themselves synchronized on >>>>> the timer. >>>>> >>>>> What you have is not incorrect though, and may remove unnecessary >>>>> synchronization in some cases (but increases the size of critical >>>>> sections in others). >>>>> >>>>> Also here: >>>>> >>>>> 165 volatile private int counterID = 0; >>>>> >>>>> there is no need to add volatile as counterID is only accessed within >>>>> synchronized methods. >>>> >>>> Yes, I see your point. I just want to ask - in cases of fixing issues >>>> like this the preferred way is to introduce minimal changes even if it >>>> means leaving the parts of the code sub-optimal? IMO, having dual >>>> synchronization scheme might be considered as sub-optimal as it makes it >>>> more difficult to see the author's intentions. >>> >>> Optimal depends on your evaluation criteria. The original design may >>> have been done with performance in mind and a view to minimising >>> critical sections. Without knowing what the original design criteria >>> was, and unless you are fixing a problem caused by key aspects of that >>> design, then minimal changes should be favoured. >>> >>>> But I am fine with leaving the Hashtable intact and just synchronizing >>>> the iteration part correctly - it resolves the issue. >>>> >>>> The update webrev is available at >>>> http://btrace.kenai.com/webrevs/JDK-6809322/webrev.v4 >>> >>> I'm not sure the comment is needed in that form. Hashtable is >>> snchronized internally but you need to use external synchronization when >>> iterating through it. >> >> Ok, it's gone. http://btrace.kenai.com/webrevs/JDK-6809322/webrev.v5/ >> >>> >>> David >>> >>>> Regards, >>>> >>>> -JB- >>>> >>>>> >>>>> David >>>>> ----- >>>>> >>>>> On 12/10/2012 11:14 PM, Jaroslav Bachorik wrote: >>>>>> The updated webrev is now at >>>>>> http://btrace.kenai.com/webrevs/JDK-6809322/ >>>>>> >>>>>> I am sorry for this chaos with webrev locations but its not that >>>>>> easy to >>>>>> work efficiently without an OpenJDK username :/ >>>>>> >>>>>> -JB- >>>>>> >>>>>> On 10/12/2012 09:47 AM, Jaroslav Bachorik wrote: >>>>>>> On Fri 12 Oct 2012 04:44:31 AM CEST, David Holmes wrote: >>>>>>>> Hi Jaroslav, >>>>>>>> >>>>>>>> >>>>>>>> On 11/10/2012 6:07 PM, Jaroslav Bachorik wrote: >>>>>>>>> Dmitry has put the webrev on the public CR - >>>>>>>>> http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/ >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks! >>>>>>>>> >>>>>>>>> -JB- >>>>>>>>> >>>>>>>>> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>>>>>>>>> I am looking for a review and a sponsor. >>>>>>>>>> >>>>>>>>>> The issue is about some javax.management.timer.Timer notifications >>>>>>>>>> not >>>>>>>>>> being received by the listeners if the notifications are generated >>>>>>>>>> rapidly. >>>>>>>>>> >>>>>>>>>> The problem is caused by ConcurrentModificationException being >>>>>>>>>> thrown - >>>>>>>>>> the exception itself is ignored but the dispatcher logic is >>>>>>>>>> skipped. >>>>>>>>>> Therefore the currently processed notification gets lost. >>>>>>>> >>>>>>>> Can you point out where exactly in the code the exception is thrown >>>>>>>> and caught. I'd like to understand the problem better. >>>>>>> >>>>>>> The CME is thrown in Timer.notifyAlarmClock() method in this case - >>>>>>> but >>>>>>> may happen in other places as well. >>>>>>> >>>>>>> Actually, in some places the access to the timerTable map is >>>>>>> synchronized while in others it isn't. While switching the Hashtable >>>>>>> for ConcurrentHashMap resolves this particular issue it might be >>>>>>> beneficial to correct the partial synchronization instead. >>>>>>> >>>>>>>> >>>>>>>>>> >>>>>>>>>> The CME is thrown due to the Timer.timerTable being iterated over >>>>>>>>>> while >>>>>>>>>> other threads try to remove some of its elements. Fix consists of >>>>>>>>>> replacing the Hashtable used for Timer.timerTable by >>>>>>>>>> ConcurrentHashMap >>>>>>>>>> which handles such situations with grace. >>>>>>>> >>>>>>>> Be aware that it may also give surprising results as removal is no >>>>>>>> longer synchronized at all with processing. So it could now appear >>>>>>>> that a notification is processed after a listener has been removed. >>>>>>> >>>>>>> Indeed, the CME is the symptom of the out-of-order processing - the >>>>>>> removal method is synchronized on (Timer.this) while the >>>>>>> notifyAlarmClock() method, processing the notifications, runs >>>>>>> unsynchronized. >>>>>>> >>>>>>> Thanks for pointing this out. I will have something to think about. >>>>>>> >>>>>>> -JB- >>>>>>> >>>>>>>> >>>>>>>> David >>>>>>>> ----- >>>>>>>> >>>>>>>>>> The patch webrev is available @ >>>>>>>>>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> >>>>>>>>>> -JB- >>>>>>>>>> >>>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>> >> > From Dmitry.Samersoff at oracle.com Mon Oct 15 09:31:54 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Mon, 15 Oct 2012 20:31:54 +0400 Subject: jmx-dev [PATCH] JDK-6809322: Missing notifications from javax.management.timer.Timer In-Reply-To: <507C370C.8040906@oracle.com> References: <5075835F.3050604@oracle.com> <50767E5A.7060908@oracle.com> <5077840F.6050601@oracle.com> <5077CB09.7010005@oracle.com> <507817C7.9000703@oracle.com> <507B72C5.4060807@oracle.com> <507BE09E.5090702@oracle.com> <507BF761.8040500@oracle.com> <507BFE42.1050200@oracle.com> <12F6F059-25F8-4448-8D1E-25C25DAE87E9@oracle.com> <507C370C.8040906@oracle.com> Message-ID: <507C3A7A.4000303@oracle.com> Jaroslav, I'll do it. -Dmitry On 2012-10-15 20:17, Jaroslav Bachorik wrote: > Thank you guys for the reviews! I would like to kindly ask someone with > the committer rights to sponsor this fix and push the change. > > > Thanks! > > -JB- > > On 10/15/2012 04:15 PM, Rickard B?ckman wrote: >> Looks good! >> >> /R >> >> On Oct 15, 2012, at 2:14 PM, Jaroslav Bachorik wrote: >> >>> On 10/15/2012 01:45 PM, David Holmes wrote: >>>> On 15/10/2012 8:08 PM, Jaroslav Bachorik wrote: >>>>> On 10/15/2012 04:19 AM, David Holmes wrote: >>>>>> I think your changes now go further than needed. The original code uses >>>>>> a dual synchronization scheme: >>>>>> >>>>>> a) it synchronizes most of the Timer methods >>>>>> b) it also uses a thread-safe Hashtable >>>>>> >>>>>> This means that not all of the Timer methods need to be synchronized >>>>>> because the only thread-safe action needed is the actual access to the >>>>>> Hashtable in some methods. >>>>>> >>>>>> The flaw with the original code was simply that the iteration of the >>>>>> Hashtable in notifyAlaramClock was not done in a thread-safe manner. I >>>>>> believe this could be fixed simply by synchronizing on the Hashtable >>>>>> here: >>>>>> >>>>>> 1186 synchronized(timerTable) { >>>>>> >>>>>> with no need to change the type of the timerTable, nor the >>>>>> synchronization on other Timer methods. You could alternatively >>>>>> synchronize on the Timer itself - as you now do - provided all methods >>>>>> of the Timer that mutate the Hashtable are themselves synchronized on >>>>>> the timer. >>>>>> >>>>>> What you have is not incorrect though, and may remove unnecessary >>>>>> synchronization in some cases (but increases the size of critical >>>>>> sections in others). >>>>>> >>>>>> Also here: >>>>>> >>>>>> 165 volatile private int counterID = 0; >>>>>> >>>>>> there is no need to add volatile as counterID is only accessed within >>>>>> synchronized methods. >>>>> >>>>> Yes, I see your point. I just want to ask - in cases of fixing issues >>>>> like this the preferred way is to introduce minimal changes even if it >>>>> means leaving the parts of the code sub-optimal? IMO, having dual >>>>> synchronization scheme might be considered as sub-optimal as it makes it >>>>> more difficult to see the author's intentions. >>>> >>>> Optimal depends on your evaluation criteria. The original design may >>>> have been done with performance in mind and a view to minimising >>>> critical sections. Without knowing what the original design criteria >>>> was, and unless you are fixing a problem caused by key aspects of that >>>> design, then minimal changes should be favoured. >>>> >>>>> But I am fine with leaving the Hashtable intact and just synchronizing >>>>> the iteration part correctly - it resolves the issue. >>>>> >>>>> The update webrev is available at >>>>> http://btrace.kenai.com/webrevs/JDK-6809322/webrev.v4 >>>> >>>> I'm not sure the comment is needed in that form. Hashtable is >>>> snchronized internally but you need to use external synchronization when >>>> iterating through it. >>> >>> Ok, it's gone. http://btrace.kenai.com/webrevs/JDK-6809322/webrev.v5/ >>> >>>> >>>> David >>>> >>>>> Regards, >>>>> >>>>> -JB- >>>>> >>>>>> >>>>>> David >>>>>> ----- >>>>>> >>>>>> On 12/10/2012 11:14 PM, Jaroslav Bachorik wrote: >>>>>>> The updated webrev is now at >>>>>>> http://btrace.kenai.com/webrevs/JDK-6809322/ >>>>>>> >>>>>>> I am sorry for this chaos with webrev locations but its not that >>>>>>> easy to >>>>>>> work efficiently without an OpenJDK username :/ >>>>>>> >>>>>>> -JB- >>>>>>> >>>>>>> On 10/12/2012 09:47 AM, Jaroslav Bachorik wrote: >>>>>>>> On Fri 12 Oct 2012 04:44:31 AM CEST, David Holmes wrote: >>>>>>>>> Hi Jaroslav, >>>>>>>>> >>>>>>>>> >>>>>>>>> On 11/10/2012 6:07 PM, Jaroslav Bachorik wrote: >>>>>>>>>> Dmitry has put the webrev on the public CR - >>>>>>>>>> http://cr.openjdk.java.net/~dsamersoff/sponsorship/jbachorik/JDK-6809322-v2/ >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks! >>>>>>>>>> >>>>>>>>>> -JB- >>>>>>>>>> >>>>>>>>>> On 10/10/2012 04:17 PM, Jaroslav Bachorik wrote: >>>>>>>>>>> I am looking for a review and a sponsor. >>>>>>>>>>> >>>>>>>>>>> The issue is about some javax.management.timer.Timer notifications >>>>>>>>>>> not >>>>>>>>>>> being received by the listeners if the notifications are generated >>>>>>>>>>> rapidly. >>>>>>>>>>> >>>>>>>>>>> The problem is caused by ConcurrentModificationException being >>>>>>>>>>> thrown - >>>>>>>>>>> the exception itself is ignored but the dispatcher logic is >>>>>>>>>>> skipped. >>>>>>>>>>> Therefore the currently processed notification gets lost. >>>>>>>>> >>>>>>>>> Can you point out where exactly in the code the exception is thrown >>>>>>>>> and caught. I'd like to understand the problem better. >>>>>>>> >>>>>>>> The CME is thrown in Timer.notifyAlarmClock() method in this case - >>>>>>>> but >>>>>>>> may happen in other places as well. >>>>>>>> >>>>>>>> Actually, in some places the access to the timerTable map is >>>>>>>> synchronized while in others it isn't. While switching the Hashtable >>>>>>>> for ConcurrentHashMap resolves this particular issue it might be >>>>>>>> beneficial to correct the partial synchronization instead. >>>>>>>> >>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> The CME is thrown due to the Timer.timerTable being iterated over >>>>>>>>>>> while >>>>>>>>>>> other threads try to remove some of its elements. Fix consists of >>>>>>>>>>> replacing the Hashtable used for Timer.timerTable by >>>>>>>>>>> ConcurrentHashMap >>>>>>>>>>> which handles such situations with grace. >>>>>>>>> >>>>>>>>> Be aware that it may also give surprising results as removal is no >>>>>>>>> longer synchronized at all with processing. So it could now appear >>>>>>>>> that a notification is processed after a listener has been removed. >>>>>>>> >>>>>>>> Indeed, the CME is the symptom of the out-of-order processing - the >>>>>>>> removal method is synchronized on (Timer.this) while the >>>>>>>> notifyAlarmClock() method, processing the notifications, runs >>>>>>>> unsynchronized. >>>>>>>> >>>>>>>> Thanks for pointing this out. I will have something to think about. >>>>>>>> >>>>>>>> -JB- >>>>>>>> >>>>>>>>> >>>>>>>>> David >>>>>>>>> ----- >>>>>>>>> >>>>>>>>>>> The patch webrev is available @ >>>>>>>>>>> https://jbs.oracle.com/bugs/browse/JDK-6809322 >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> >>>>>>>>>>> -JB- >>>>>>>>>>> >>>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>> >>> >> > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From kevin.walls at oracle.com Mon Oct 15 11:49:39 2012 From: kevin.walls at oracle.com (kevin.walls at oracle.com) Date: Mon, 15 Oct 2012 18:49:39 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7195151: Multiplatform tescase for 6929067 Message-ID: <20121015184944.3ACBA47382@hg.openjdk.java.net> Changeset: e0ea0e94c23c Author: kevinw Date: 2012-10-15 16:48 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e0ea0e94c23c 7195151: Multiplatform tescase for 6929067 Reviewed-by: kamg, kvn ! test/runtime/6929067/Test6929067.sh From rob.mckenna at oracle.com Mon Oct 15 14:32:40 2012 From: rob.mckenna at oracle.com (rob.mckenna at oracle.com) Date: Mon, 15 Oct 2012 21:32:40 +0000 Subject: hg: jdk8/tl/jdk: 8000487: Java JNDI connection library on ldap conn is not honoring configured timeout Message-ID: <20121015213301.C26CB47388@hg.openjdk.java.net> Changeset: c0736b62160e Author: robm Date: 2012-10-15 22:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0736b62160e 8000487: Java JNDI connection library on ldap conn is not honoring configured timeout Reviewed-by: vinnie ! src/share/classes/com/sun/jndi/ldap/Connection.java ! src/share/classes/com/sun/jndi/ldap/LdapClient.java + test/com/sun/jndi/ldap/LdapTimeoutTest.java - test/com/sun/jndi/ldap/LdapsReadTimeoutTest.java - test/com/sun/jndi/ldap/ReadTimeoutTest.java From jonathan.gibbons at oracle.com Mon Oct 15 17:08:34 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 16 Oct 2012 00:08:34 +0000 Subject: hg: jdk8/tl/langtools: 8000666: javadoc should write directly to Writer instead of composing strings Message-ID: <20121016000836.D6EDF4738B@hg.openjdk.java.net> Changeset: 8db45b13526e Author: jjg Date: 2012-10-15 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8db45b13526e 8000666: javadoc should write directly to Writer instead of composing strings Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/Comment.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/DocType.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocument.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ClassWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/ConstantsSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/PackageSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/SerializedFormWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java From coleen.phillimore at oracle.com Mon Oct 15 21:41:36 2012 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Tue, 16 Oct 2012 04:41:36 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 20 new changesets Message-ID: <20121016044216.50DF44739B@hg.openjdk.java.net> Changeset: c3e799c37717 Author: vlivanov Date: 2012-10-05 18:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c3e799c37717 7177003: C1: LogCompilation support Summary: add LogCompilation support in C1 - both client and tiered mode. Reviewed-by: twisti, kvn ! src/os/linux/vm/vmError_linux.cpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileLog.cpp ! src/share/vm/compiler/compileLog.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/utilities/ostream.cpp Changeset: 9a9b6e05ffb4 Author: vlivanov Date: 2012-10-05 19:29 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9a9b6e05ffb4 8000232: NPG: SIGSEGV in Dependencies::DepStream::check_klass_dependency on solaris-x64 Summary: Move decoding into Dependencies::DepStream::argument, so no caller could see encoded context value (NULL) anymore. Reviewed-by: twisti, kvn ! src/share/vm/code/dependencies.cpp Changeset: 9024b6b53ec2 Author: vlivanov Date: 2012-10-05 19:44 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9024b6b53ec2 8000485: Hotspot build fails in Solaris Studio IDE when building dtrace Summary: Prepend '.' to the existing native library path Reviewed-by: kvn, sspitsyn ! make/bsd/makefiles/dtrace.make ! make/solaris/makefiles/dtrace.make Changeset: 377508648226 Author: vlivanov Date: 2012-10-08 13:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/377508648226 8000313: C2 should use jlong for 64bit values Summary: Replace all occurrences of long with jlong in C2 code. Reviewed-by: kvn, twisti ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/phaseX.hpp Changeset: 65d07d9ee446 Author: twisti Date: 2012-10-08 17:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/65d07d9ee446 8000263: JSR 292: signature types may appear to be unloaded Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/globals.hpp Changeset: 8e47bac5643a Author: roland Date: 2012-10-09 10:11 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8e47bac5643a 7054512: Compress class pointers after perm gen removal Summary: support of compress class pointers in the compilers. Reviewed-by: kvn, twisti ! agent/src/share/classes/sun/jvm/hotspot/debugger/Address.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/Debugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/DebuggerBase.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/JVMDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/dummy/DummyAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerClient.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerServer.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/memory/Universe.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Array.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Instance.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MetadataField.java + agent/src/share/classes/sun/jvm/hotspot/oops/NarrowKlassField.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Oop.java ! agent/src/share/classes/sun/jvm/hotspot/oops/java_lang_Class.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/RobustOopDeterminator.java ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_MacroAssembler_sparc.cpp ! src/cpu/sparc/vm/relocInfo_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/c1_MacroAssembler_x86.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os/bsd/dtrace/generateJvmOffsets.cpp ! src/os/bsd/dtrace/jhelper.d ! src/os/solaris/dtrace/generateJvmOffsets.cpp ! src/os/solaris/dtrace/jhelper.d ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/forms.cpp ! src/share/vm/adlc/forms.hpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/instanceOop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/live.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/globalDefinitions.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: f6badecb7ea7 Author: vlivanov Date: 2012-10-09 12:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/f6badecb7ea7 7199654: Remove LoadUI2LNode Summary: Removed LoadUI2L node from Ideal nodes, use match rule in .ad files instead. Reviewed-by: kvn ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/forms.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/superword.cpp Changeset: d336b3173277 Author: kvn Date: 2012-10-09 16:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d336b3173277 8000592: Improve adlc usability Summary: several changes to adlc to improve its usability Reviewed-by: kvn Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/archDesc.hpp ! src/share/vm/adlc/dict2.cpp ! src/share/vm/adlc/filebuff.hpp ! src/share/vm/adlc/forms.hpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/formssel.hpp ! src/share/vm/adlc/main.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp Changeset: 94e9408dbf50 Author: roland Date: 2012-10-11 18:21 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/94e9408dbf50 8000753: compiler/6912517 crashes on 64bit sparc with compressed oops off Summary: code generated by c1 for getClass intrinsic broken when klass field is loaded on 64bit with compressed klass off. Reviewed-by: kvn ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp Changeset: 19eb999cb72c Author: twisti Date: 2012-10-11 14:46 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/19eb999cb72c 8000740: remove LinkWellKnownClasses Reviewed-by: kvn, jrose ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/globals.hpp Changeset: d804e148cff8 Author: kvn Date: 2012-10-12 09:22 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d804e148cff8 Merge ! make/bsd/makefiles/dtrace.make ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fb19af007ffc Author: jprovino Date: 2012-10-10 14:35 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fb19af007ffc 7189254: Change makefiles for more flexibility to override defaults Summary: Change makefiles so that targets and parameters can be overridden by alternate makefiles. Reviewed-by: dholmes, coleenp ! make/Makefile ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/ia64.make + make/bsd/makefiles/minimal1.make ! make/bsd/makefiles/vm.make ! make/defs.make + make/excludeSrc.make ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/ia64.make + make/linux/makefiles/minimal1.make ! make/linux/makefiles/vm.make ! make/windows/makefiles/defs.make ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/memory/metaspaceShared.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/forte.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiEnter.xsl ! src/share/vm/prims/jvmtiEnvBase.hpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiImpl.hpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp ! src/share/vm/prims/jvmtiTagMap.hpp ! src/share/vm/prims/jvmtiThreadState.hpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/globals_extension.hpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/perfData.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/classLoadingService.cpp ! src/share/vm/services/classLoadingService.hpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp ! src/share/vm/services/heapDumper.hpp ! src/share/vm/services/management.cpp ! src/share/vm/services/management.hpp ! src/share/vm/services/memReporter.hpp ! src/share/vm/services/memTracker.hpp ! src/share/vm/services/runtimeService.cpp ! src/share/vm/services/runtimeService.hpp ! src/share/vm/utilities/macros.hpp Changeset: bbeecede56dd Author: jiangli Date: 2012-10-11 14:36 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/bbeecede56dd 8000459: assert(java_lang_String::is_instance(entry)) failure with various mlvm tests. Summary: Remove unneeded assert. Reviewed-by: sspitsyn, coleenp ! src/share/vm/prims/jvmtiTagMap.cpp Changeset: 9855b7e559ae Author: collins Date: 2012-10-12 10:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/9855b7e559ae Merge ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/gcc.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/vm.make ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/jvmtiTagMap.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/management.cpp Changeset: 5876f980ea19 Author: collins Date: 2012-10-12 11:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5876f980ea19 Merge ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 0cc77f9b31ad Author: katleman Date: 2012-10-11 09:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0cc77f9b31ad Added tag jdk8-b60 for changeset 3cfd05b2219a ! .hgtags Changeset: b261523fe66c Author: amurillo Date: 2012-10-12 13:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b261523fe66c Merge Changeset: 4547dc71db76 Author: amurillo Date: 2012-10-12 13:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4547dc71db76 Added tag hs25-b05 for changeset b261523fe66c ! .hgtags Changeset: 58fbf2da3c16 Author: amurillo Date: 2012-10-12 14:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/58fbf2da3c16 8000834: new hotspot build - hs25-b06 Reviewed-by: jcoomes ! make/hotspot_version Changeset: e52361627b65 Author: coleenp Date: 2012-10-15 22:33 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e52361627b65 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/globals.hpp From naoto.sato at oracle.com Tue Oct 16 10:59:49 2012 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Tue, 16 Oct 2012 17:59:49 +0000 Subject: hg: jdk8/tl/jdk: 8000245: SimpleDateFormat.format(date, StringBuffer, FieldPosition) doesn't work as expected with custom extensions; ... Message-ID: <20121016180011.C58AC473AF@hg.openjdk.java.net> Changeset: 32452042b781 Author: naoto Date: 2012-10-16 10:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/32452042b781 8000245: SimpleDateFormat.format(date, StringBuffer, FieldPosition) doesn't work as expected with custom extensions 8000273: java.util.Locale.getDisplayVariant(Locale l) isn't transferred to the custom service provider 8000615: JRE adapter: timezone name of en_US is changed when extension directory is added Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/CurrencyNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleNameProviderImpl.java ! src/share/classes/sun/util/locale/provider/LocaleServiceProviderPool.java ! src/share/classes/sun/util/locale/provider/TimeZoneNameProviderImpl.java ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh ! test/java/util/PluggableLocale/CurrencyNameProviderTest.java ! test/java/util/PluggableLocale/LocaleNameProviderTest.java ! test/java/util/PluggableLocale/LocaleNameProviderTest.sh ! test/java/util/PluggableLocale/ProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java ! test/java/util/PluggableLocale/providersrc/LocaleNameProviderImpl.java From kurchi.subhra.hazra at oracle.com Tue Oct 16 15:23:47 2012 From: kurchi.subhra.hazra at oracle.com (kurchi.subhra.hazra at oracle.com) Date: Tue, 16 Oct 2012 22:23:47 +0000 Subject: hg: jdk8/tl/jdk: 7198073: (prefs) user prefs not saved [macosx] Message-ID: <20121016222408.4153A473CF@hg.openjdk.java.net> Changeset: 3a6b76a468bd Author: khazra Date: 2012-10-16 15:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a6b76a468bd 7198073: (prefs) user prefs not saved [macosx] Summary: Using class member field to get node instead of argument Reviewed-by: alanb ! src/macosx/classes/java/util/prefs/MacOSXPreferences.java + test/java/util/prefs/CheckUserPrefFirst.java + test/java/util/prefs/CheckUserPrefLater.java + test/java/util/prefs/CheckUserPrefsStorage.sh From jonathan.gibbons at oracle.com Tue Oct 16 21:04:11 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 17 Oct 2012 04:04:11 +0000 Subject: hg: jdk8/tl/langtools: 8000673: remove dead code from HtmlWriter and subtypes Message-ID: <20121017040414.9AA73473D3@hg.openjdk.java.net> Changeset: 2013982bee34 Author: jjg Date: 2012-10-16 21:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2013982bee34 8000673: remove dead code from HtmlWriter and subtypes Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeWriter.java From yumin.qi at oracle.com Tue Oct 16 21:51:27 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Tue, 16 Oct 2012 21:51:27 -0700 Subject: RFR: 8000818: SA constant pool need to reference to reference map after permgen removal Message-ID: <507E394F.7080702@oracle.com> Hi, all May I have your codereview on http://cr.openjdk.java.net/~minqi/8000818/ 8000818: SA constant pool need to reference to reference map after permgen removal Summary: After permgen removal, constant pool changed to put _ldc and _ldc_w (fast_ldc and fast_ldcw) index to reference map, no longer calculated via constant pool cache. Also, there is a mistake in 6879063: SA should use hsdis. Bytes.swap should only check if the underlying platform is big endian since java code follows big endian. Revert it back to its orginal form, else it will fail ClassDump. Reviewed-by: Contributed-by: yumin.qi at oracle.com Thanks Yumin From david.holmes at oracle.com Tue Oct 16 22:26:17 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 17 Oct 2012 15:26:17 +1000 Subject: RFR: 8000818: SA constant pool need to reference to reference map after permgen removal In-Reply-To: <507E394F.7080702@oracle.com> References: <507E394F.7080702@oracle.com> Message-ID: <507E4179.6060409@oracle.com> Hi Yumin, Not really a review as I don't understand this part of the code. On 17/10/2012 2:51 PM, Yumin Qi wrote: > Hi, all > > May I have your codereview on > > http://cr.openjdk.java.net/~minqi/8000818/ > > > 8000818: SA constant pool need to reference to reference map after > permgen removal > Summary: After permgen removal, constant pool changed to put _ldc and > _ldc_w (fast_ldc and fast_ldcw) index to reference map, no longer > calculated via constant pool cache. Here: + protected short getConstantPoolIndexFromRefMap(int rawcode, int bci) { + int refIndex = method.getBytecodeByteArg(bci); + String fmt = Bytecodes.format(rawcode); + switch (fmt.length()) { + case 2: refIndex = method.getBytecodeByteArg(bci); break; The setting of refIndex the second time seems to be redundant. > Also, there is a mistake in 6879063: SA should use hsdis. Bytes.swap > should only check if the underlying platform is big endian since java > code follows big endian. Revert it back to its orginal form, else it > will fail ClassDump. I think that needs its own CR. You can still combine them into a single changeset (with two bug lines). Also this seems to indicate a gap in our testing. How did this slip through the 6879063 process? Have we closed that gap now? Thanks, David > Reviewed-by: > Contributed-by: yumin.qi at oracle.com > > > Thanks > Yumin From alan.bateman at oracle.com Wed Oct 17 03:45:23 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 17 Oct 2012 10:45:23 +0000 Subject: hg: jdk8/tl/jdk: 8000685: (props) Properties.storeToXML/loadFromXML should only require UTF-8 and UTF-16 to be supported Message-ID: <20121017104559.88D6E473E0@hg.openjdk.java.net> Changeset: 14b9e294d049 Author: alanb Date: 2012-10-17 11:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/14b9e294d049 8000685: (props) Properties.storeToXML/loadFromXML should only require UTF-8 and UTF-16 to be supported Reviewed-by: mchung, chegar ! src/share/classes/java/util/Properties.java ! src/share/classes/sun/util/spi/XmlPropertiesProvider.java ! src/share/classes/sun/util/xml/PlatformXmlPropertiesProvider.java ! test/java/util/Properties/LoadAndStoreXML.java From neil.richards at ngmr.net Wed Oct 17 05:41:20 2012 From: neil.richards at ngmr.net (neil.richards at ngmr.net) Date: Wed, 17 Oct 2012 12:41:20 +0000 Subject: hg: jdk8/tl/jdk: 8000955: Hashtable.Entry.hashCode() does not conform to Map.Entry.hashCode() defined behaviour Message-ID: <20121017124147.B851D473E1@hg.openjdk.java.net> Changeset: 5eed4a92ca8c Author: ngmr Date: 2012-10-17 13:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5eed4a92ca8c 8000955: Hashtable.Entry.hashCode() does not conform to Map.Entry.hashCode() defined behaviour Reviewed-by: mduigou, alanb ! src/share/classes/java/util/Hashtable.java + test/java/util/Map/EntryHashCode.java From rickard.backman at oracle.com Wed Oct 17 07:02:20 2012 From: rickard.backman at oracle.com (rickard.backman at oracle.com) Date: Wed, 17 Oct 2012 14:02:20 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 7093328: JVMTI: jvmtiPrimitiveFieldCallback always report 0's for static primitives Message-ID: <20121017140224.AD8D3473E3@hg.openjdk.java.net> Changeset: 045cb62046a7 Author: rbackman Date: 2012-08-28 15:15 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/045cb62046a7 7093328: JVMTI: jvmtiPrimitiveFieldCallback always report 0's for static primitives Reviewed-by: dholmes, dcubed ! src/share/vm/prims/jvmtiTagMap.cpp From dmitry.samersoff at oracle.com Wed Oct 17 08:28:18 2012 From: dmitry.samersoff at oracle.com (dmitry.samersoff at oracle.com) Date: Wed, 17 Oct 2012 15:28:18 +0000 Subject: hg: jdk8/tl/jdk: 6809322: javax.management.timer.Timer does not fire all notifications Message-ID: <20121017152840.D794A473E6@hg.openjdk.java.net> Changeset: b2d8a99a049e Author: dsamersoff Date: 2012-10-17 18:34 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b2d8a99a049e 6809322: javax.management.timer.Timer does not fire all notifications Summary: Some notifications get dropped due to ConcurrentModificationException thrown in Timer.notifyAlarmClock() method. Reviewed-by: dholmes, rbackman Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/javax/management/timer/Timer.java + test/javax/management/timer/MissingNotificationTest.java From maurizio.cimadamore at oracle.com Wed Oct 17 08:43:48 2012 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 17 Oct 2012 15:43:48 +0000 Subject: hg: jdk8/tl/langtools: 7192245: Add parser support for default methods Message-ID: <20121017154353.16E8E473E7@hg.openjdk.java.net> Changeset: 12cf6bfd8c05 Author: mcimadamore Date: 2012-10-17 16:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/12cf6bfd8c05 7192245: Add parser support for default methods Summary: Add support for 'default' keyword in modifier position Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/javac/defaultMethods/syntax/TestDefaultMethodsSyntax.java + test/tools/javac/diags/examples/DefaultMethodNotSupported.java From mandy.chung at oracle.com Wed Oct 17 12:03:37 2012 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Wed, 17 Oct 2012 19:03:37 +0000 Subject: hg: jdk8/tl/jdk: 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false Message-ID: <20121017190401.7B317473EC@hg.openjdk.java.net> Changeset: 6156b9235758 Author: mchung Date: 2012-10-17 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6156b9235758 8001012: jdk8 SKIP_BUILD_CYCLE=false build fails with BUILD_JAXWS=false Reviewed-by: alanb, ohair ! make/common/internal/Defs-jaxws.gmk From christian.thalinger at oracle.com Wed Oct 17 12:17:22 2012 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Wed, 17 Oct 2012 12:17:22 -0700 Subject: RFR: 6879063: SA should use hsdis for disassembly In-Reply-To: <503BE193.6090807@oracle.com> References: <503BE193.6090807@oracle.com> Message-ID: This change broke the usage of previously built versions of hsdis. I filed a bug for it: 8000489: older builds of hsdis don't work anymore after 6879063 Yumin, I assigned the bug to you. Could you please take care of it? -- Chris On Aug 27, 2012, at 2:07 PM, Yumin Qi wrote: > Hi, all > > Can I have you code review of > 6879063: SA should use hsdis for disassembly > > http://cr.openjdk.java.net/~minqi/6879063 > > The SA has Java based disassemblers for x86 and sparc but amd64. Instead of porting to amd64 we should switch over to using hsdis for it like the JVM does. This requires a new entry point into hsdis, decode_instructions_virtual, which separates the address of the code being disassembled from the buffer containing the code. The existing uses of decode_instructions have been updated to use the new interface and SA Disassembler has Java native methods that call into hsdis and call back up to Java to perform the disassembly. Also changed makefile for hsdis build for both(i386/amd64). > > All the old disassembler logic was deleted since it's incompatible with the new disassembly interface. Also deleted are dbx based SA interface and few other dead files. > > Tested by dumping full assembly from core files. > > Reviewed-by: > Contributed-by: Tom R (never) > > Thanks > Yumin Qi > From yumin.qi at oracle.com Wed Oct 17 12:21:16 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Wed, 17 Oct 2012 12:21:16 -0700 Subject: RFR: 6879063: SA should use hsdis for disassembly In-Reply-To: References: <503BE193.6090807@oracle.com> Message-ID: <507F052C.9010402@oracle.com> Sure. Thanks Yumin On 10/17/2012 12:17 PM, Christian Thalinger wrote: > This change broke the usage of previously built versions of hsdis. I filed a bug for it: > > 8000489: older builds of hsdis don't work anymore after 6879063 > > Yumin, I assigned the bug to you. Could you please take care of it? > > -- Chris > > On Aug 27, 2012, at 2:07 PM, Yumin Qi wrote: > >> Hi, all >> >> Can I have you code review of >> 6879063: SA should use hsdis for disassembly >> >> http://cr.openjdk.java.net/~minqi/6879063 >> >> The SA has Java based disassemblers for x86 and sparc but amd64. Instead of porting to amd64 we should switch over to using hsdis for it like the JVM does. This requires a new entry point into hsdis, decode_instructions_virtual, which separates the address of the code being disassembled from the buffer containing the code. The existing uses of decode_instructions have been updated to use the new interface and SA Disassembler has Java native methods that call into hsdis and call back up to Java to perform the disassembly. Also changed makefile for hsdis build for both(i386/amd64). >> >> All the old disassembler logic was deleted since it's incompatible with the new disassembly interface. Also deleted are dbx based SA interface and few other dead files. >> >> Tested by dumping full assembly from core files. >> >> Reviewed-by: >> Contributed-by: Tom R (never) >> >> Thanks >> Yumin Qi >> From alan.bateman at oracle.com Wed Oct 17 12:34:21 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 17 Oct 2012 19:34:21 +0000 Subject: hg: jdk8/tl/jdk: 7198496: (sl) ServiceLoader.load(Class, null) behavior differs from spec Message-ID: <20121017193446.0D5B6473EF@hg.openjdk.java.net> Changeset: 586028bbf885 Author: psandoz Date: 2012-10-17 20:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/586028bbf885 7198496: (sl) ServiceLoader.load(Class, null) behavior differs from spec Reviewed-by: dholmes, alanb ! src/share/classes/java/util/ServiceLoader.java ! test/java/util/ServiceLoader/Basic.java ! test/java/util/ServiceLoader/basic.sh From serguei.spitsyn at oracle.com Wed Oct 17 13:05:31 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 17 Oct 2012 13:05:31 -0700 Subject: RFR: 8000818: SA constant pool need to reference to reference map after permgen removal In-Reply-To: <507E394F.7080702@oracle.com> References: <507E394F.7080702@oracle.com> Message-ID: <507F0F8B.7000504@oracle.com> Hi Yumin, I have a question. ByteCodeRewriter.java: 65 return (short)cpool.objectToCPIndex(refIndex & 0xff); Why the mask 0xff is used above? The refIndex can be a short value, right? Otherwise, why would you need to swap bytes at the line 62 ? : 62 case 3: refIndex = bytes.swapShort(method.getBytecodeShortArg(bci)); break; And I agree with David that one of these assignements seems to be redundant: 58 int refIndex = method.getBytecodeByteArg(bci); 61 case 2: refIndex = method.getBytecodeByteArg(bci); break; Thanks, Serguei On 10/16/12 9:51 PM, Yumin Qi wrote: > Hi, all > > May I have your codereview on > > http://cr.openjdk.java.net/~minqi/8000818/ > > > 8000818: SA constant pool need to reference to reference map after > permgen removal > Summary: After permgen removal, constant pool changed to put _ldc and > _ldc_w (fast_ldc and fast_ldcw) index to reference map, no longer > calculated via constant pool cache. > Also, there is a mistake in 6879063: SA should use hsdis. Bytes.swap > should only check if the underlying platform is big endian since java > code follows big endian. Revert it back to its orginal form, else it > will fail ClassDump. > > Reviewed-by: > Contributed-by: yumin.qi at oracle.com > > > Thanks > Yumin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121017/c0eae28b/attachment.html From alan.bateman at oracle.com Wed Oct 17 13:13:49 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 17 Oct 2012 20:13:49 +0000 Subject: hg: jdk8/tl/jdk: 8000362: (pack200) Deprecate Packer/Unpacker addPropertyChangeLister and removePropertyChangeListener methods Message-ID: <20121017201412.EC0B5473F0@hg.openjdk.java.net> Changeset: b265ead7f331 Author: alanb Date: 2012-10-17 21:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b265ead7f331 8000362: (pack200) Deprecate Packer/Unpacker addPropertyChangeLister and removePropertyChangeListener methods Reviewed-by: lancea, chegar, mchung, ksrini ! src/share/classes/java/util/jar/Pack200.java From naoto.sato at oracle.com Wed Oct 17 13:23:38 2012 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Wed, 17 Oct 2012 20:23:38 +0000 Subject: hg: jdk8/tl/jdk: 8001046: java/util/PluggableLocale/LocaleNameProviderTest.sh failing Message-ID: <20121017202352.DE3D2473F1@hg.openjdk.java.net> Changeset: 60994591be6b Author: naoto Date: 2012-10-17 13:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60994591be6b 8001046: java/util/PluggableLocale/LocaleNameProviderTest.sh failing Reviewed-by: okutsu ! test/java/util/PluggableLocale/barprovider.jar From yumin.qi at oracle.com Wed Oct 17 14:37:02 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Wed, 17 Oct 2012 14:37:02 -0700 Subject: RFR: 8000818: SA constant pool need to reference to reference map after permgen removal In-Reply-To: <507F0F8B.7000504@oracle.com> References: <507E394F.7080702@oracle.com> <507F0F8B.7000504@oracle.com> Message-ID: <507F24FE.7030106@oracle.com> Serguei, You are right, here should use 0xffff which is for short. First we got a short from GetBytesXXX function, we assign it to int. When it is used, only lower 16 bits are used. To prevent it has invalid bits set in upper 16 bits, masking off them. Switch bytes, is for in case the index is a short number stored in method byte code. On X86, bytes needed to be switched to reflect the correct value as java conform. Thanks Yumin On 10/17/2012 1:05 PM, serguei.spitsyn at oracle.com wrote: > Hi Yumin, > > I have a question. > ByteCodeRewriter.java: > 65 return (short)cpool.objectToCPIndex(refIndex & 0xff); > > Why the mask 0xff is used above? The refIndex can be a short value, > right? > Otherwise, why would you need to swap bytes at the line 62 ? : > 62 case 3: refIndex = > bytes.swapShort(method.getBytecodeShortArg(bci)); break; > > And I agree with David that one of these assignements seems to be > redundant: > 58 int refIndex = method.getBytecodeByteArg(bci); > 61 case 2: refIndex = method.getBytecodeByteArg(bci); break; > > > Thanks, > Serguei > > > On 10/16/12 9:51 PM, Yumin Qi wrote: >> Hi, all >> >> May I have your codereview on >> >> http://cr.openjdk.java.net/~minqi/8000818/ >> >> >> 8000818: SA constant pool need to reference to reference map after >> permgen removal >> Summary: After permgen removal, constant pool changed to put _ldc and >> _ldc_w (fast_ldc and fast_ldcw) index to reference map, no longer >> calculated via constant pool cache. >> Also, there is a mistake in 6879063: SA should use hsdis. Bytes.swap >> should only check if the underlying platform is big endian since >> java code follows big endian. Revert it back to its orginal form, >> else it will fail ClassDump. >> >> Reviewed-by: >> Contributed-by: yumin.qi at oracle.com >> >> >> Thanks >> Yumin > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121017/479f7ac8/attachment-0001.html From serguei.spitsyn at oracle.com Wed Oct 17 14:59:04 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 17 Oct 2012 14:59:04 -0700 Subject: RFR: 8000818: SA constant pool need to reference to reference map after permgen removal In-Reply-To: <507F24FE.7030106@oracle.com> References: <507E394F.7080702@oracle.com> <507F0F8B.7000504@oracle.com> <507F24FE.7030106@oracle.com> Message-ID: <507F2A28.2090802@oracle.com> Yumin, Ok, thanks! Serguei On 10/17/12 2:37 PM, Yumin Qi wrote: > Serguei, > > You are right, here should use 0xffff which is for short. > First we got a short from GetBytesXXX function, we assign it to > int. When it is used, only lower 16 bits are used. To prevent it has > invalid bits set in upper 16 bits, masking off them. > Switch bytes, is for in case the index is a short number stored in > method byte code. On X86, bytes needed to be switched to reflect the > correct value as java conform. > > Thanks > Yumin > > On 10/17/2012 1:05 PM, serguei.spitsyn at oracle.com wrote: >> Hi Yumin, >> >> I have a question. >> ByteCodeRewriter.java: >> 65 return (short)cpool.objectToCPIndex(refIndex & 0xff); >> >> Why the mask 0xff is used above? The refIndex can be a short >> value, right? >> Otherwise, why would you need to swap bytes at the line 62 ? : >> 62 case 3: refIndex = >> bytes.swapShort(method.getBytecodeShortArg(bci)); break; >> >> And I agree with David that one of these assignements seems to be >> redundant: >> 58 int refIndex = method.getBytecodeByteArg(bci); >> 61 case 2: refIndex = method.getBytecodeByteArg(bci); break; >> >> >> Thanks, >> Serguei >> >> >> On 10/16/12 9:51 PM, Yumin Qi wrote: >>> Hi, all >>> >>> May I have your codereview on >>> >>> http://cr.openjdk.java.net/~minqi/8000818/ >>> >>> >>> 8000818: SA constant pool need to reference to reference map after >>> permgen removal >>> Summary: After permgen removal, constant pool changed to put _ldc >>> and _ldc_w (fast_ldc and fast_ldcw) index to reference map, no >>> longer calculated via constant pool cache. >>> Also, there is a mistake in 6879063: SA should use hsdis. Bytes.swap >>> should only check if the underlying platform is big endian since >>> java code follows big endian. Revert it back to its orginal form, >>> else it will fail ClassDump. >>> >>> Reviewed-by: >>> Contributed-by: yumin.qi at oracle.com >>> >>> >>> Thanks >>> Yumin >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121017/bec12d29/attachment.html From coleen.phillimore at oracle.com Wed Oct 17 15:59:18 2012 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Wed, 17 Oct 2012 22:59:18 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8000617: It should be possible to allocate memory without the VM dying. Message-ID: <20121017225924.374E047402@hg.openjdk.java.net> Changeset: 7b5885dadbdc Author: nloodin Date: 2012-10-17 17:36 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/7b5885dadbdc 8000617: It should be possible to allocate memory without the VM dying. Reviewed-by: coleenp, kamg ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/resourceArea.cpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp From yumin.qi at oracle.com Wed Oct 17 17:25:06 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Wed, 17 Oct 2012 17:25:06 -0700 Subject: RFR: 8000818: SA constant pool need to reference to reference map after permgen removal In-Reply-To: <507E394F.7080702@oracle.com> References: <507E394F.7080702@oracle.com> Message-ID: <507F4C62.1000902@oracle.com> Hi, As suggested by David, I created a new bug 8001055: Bytes.swap should follow big endian to address the issued caused by 6879063 push. new webrevs: http://cr.openjdk.java.net/~minqi/8000818 http://cr.openjdk.java.net/~minqi/8001055 Thanks Yumin On 10/16/2012 9:51 PM, Yumin Qi wrote: > Hi, all > > May I have your codereview on > > http://cr.openjdk.java.net/~minqi/8000818/ > > > 8000818: SA constant pool need to reference to reference map after > permgen removal > Summary: After permgen removal, constant pool changed to put _ldc and > _ldc_w (fast_ldc and fast_ldcw) index to reference map, no longer > calculated via constant pool cache. > Also, there is a mistake in 6879063: SA should use hsdis. Bytes.swap > should only check if the underlying platform is big endian since java > code follows big endian. Revert it back to its orginal form, else it > will fail ClassDump. > > Reviewed-by: > Contributed-by: yumin.qi at oracle.com > > > Thanks > Yumin From david.holmes at oracle.com Wed Oct 17 19:06:11 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 18 Oct 2012 12:06:11 +1000 Subject: RFR: 8000818: SA constant pool need to reference to reference map after permgen removal In-Reply-To: <507F4C62.1000902@oracle.com> References: <507E394F.7080702@oracle.com> <507F4C62.1000902@oracle.com> Message-ID: <507F6413.60102@oracle.com> On 18/10/2012 10:25 AM, Yumin Qi wrote: > Hi, > > As suggested by David, I created a new bug > 8001055: Bytes.swap should follow big endian > to address the issued caused by 6879063 push. This change looks good to me. I'm still concerned about test coverage. Thanks, David ----- > new webrevs: > http://cr.openjdk.java.net/~minqi/8000818 > http://cr.openjdk.java.net/~minqi/8001055 > > Thanks > Yumin > > On 10/16/2012 9:51 PM, Yumin Qi wrote: >> Hi, all >> >> May I have your codereview on >> >> http://cr.openjdk.java.net/~minqi/8000818/ >> >> >> 8000818: SA constant pool need to reference to reference map after >> permgen removal >> Summary: After permgen removal, constant pool changed to put _ldc and >> _ldc_w (fast_ldc and fast_ldcw) index to reference map, no longer >> calculated via constant pool cache. >> Also, there is a mistake in 6879063: SA should use hsdis. Bytes.swap >> should only check if the underlying platform is big endian since java >> code follows big endian. Revert it back to its orginal form, else it >> will fail ClassDump. >> >> Reviewed-by: >> Contributed-by: yumin.qi at oracle.com >> >> >> Thanks >> Yumin From serguei.spitsyn at oracle.com Wed Oct 17 22:06:36 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 17 Oct 2012 22:06:36 -0700 Subject: RFR: 8000818: SA constant pool need to reference to reference map after permgen removal In-Reply-To: <507F4C62.1000902@oracle.com> References: <507E394F.7080702@oracle.com> <507F4C62.1000902@oracle.com> Message-ID: <507F8E5C.5040808@oracle.com> Hi Yumin, I've got another question related to masking. No consistency between methods getConstantPoolIndexFromRefMap and getConstantPoolIndex. Compare the lines 78+79 with 91+92: 74 protected short getConstantPoolIndexFromRefMap(int rawcode, int bci) { 75 int refIndex; 76 String fmt = Bytecodes.format(rawcode); 77 switch (fmt.length()) { 78 case 2: refIndex =0xFF & method.getBytecodeByteArg(bci); break; 79 case 3: refIndex =0xFFFF &bytes.swapShort(method.getBytecodeShortArg(bci)); break; . . . 86 protected short getConstantPoolIndex(int rawcode, int bci) { 87 // get ConstantPool index from ConstantPoolCacheIndex at given bci 88 String fmt = Bytecodes.format(rawcode); 89 int cpCacheIndex; 90 switch (fmt.length()) { 91 case 2: cpCacheIndex = method.getBytecodeByteArg(bci); break; 92 case 3: cpCacheIndex = method.getBytecodeShortArg(bci); break; The refIndex is positive so that there is no point to mask byte and short values at lines 78,79. Also one more question: Why these functions are protected, not private? The rest looks good. Thanks, Serguei On 10/17/12 5:25 PM, Yumin Qi wrote: > Hi, > > As suggested by David, I created a new bug > 8001055: Bytes.swap should follow big endian > to address the issued caused by 6879063 push. > > new webrevs: > http://cr.openjdk.java.net/~minqi/8000818 > http://cr.openjdk.java.net/~minqi/8001055 > > Thanks > Yumin > > On 10/16/2012 9:51 PM, Yumin Qi wrote: >> Hi, all >> >> May I have your codereview on >> >> http://cr.openjdk.java.net/~minqi/8000818/ >> >> >> 8000818: SA constant pool need to reference to reference map after >> permgen removal >> Summary: After permgen removal, constant pool changed to put _ldc and >> _ldc_w (fast_ldc and fast_ldcw) index to reference map, no longer >> calculated via constant pool cache. >> Also, there is a mistake in 6879063: SA should use hsdis. Bytes.swap >> should only check if the underlying platform is big endian since >> java code follows big endian. Revert it back to its orginal form, >> else it will fail ClassDump. >> >> Reviewed-by: >> Contributed-by: yumin.qi at oracle.com >> >> >> Thanks >> Yumin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121017/04af5983/attachment.html From yumin.qi at oracle.com Wed Oct 17 23:29:52 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Wed, 17 Oct 2012 23:29:52 -0700 Subject: RFR: 8000818: SA constant pool need to reference to reference map after permgen removal In-Reply-To: <507F8E5C.5040808@oracle.com> References: <507E394F.7080702@oracle.com> <507F4C62.1000902@oracle.com> <507F8E5C.5040808@oracle.com> Message-ID: <507FA1E0.3020707@oracle.com> Serguei, Line 91, 92 are same, when used after here, they are cast to short and byte according format "JJ" or "j". for 78 and 79, we need to get accurate index, so need to mask corresponding upper bytes since we do not need to check format . If you check usage after line number 91,92, you will find they are treated same as 78,79. I will add _invokehandle since it got missed after permgen removal, Coleen pointed out this. Will send webrev tomorrow. Thanks Yumin On 10/17/2012 10:06 PM, serguei.spitsyn at oracle.com wrote: > Hi Yumin, > > I've got another question related to masking. > No consistency between methods getConstantPoolIndexFromRefMap and > getConstantPoolIndex. > Compare the lines 78+79 with 91+92: > 74 protected short getConstantPoolIndexFromRefMap(int rawcode, int bci) { > 75 int refIndex; > 76 String fmt = Bytecodes.format(rawcode); > 77 switch (fmt.length()) { > 78 case 2: refIndex =0xFF& method.getBytecodeByteArg(bci); break; > 79 case 3: refIndex =0xFFFF& bytes.swapShort(method.getBytecodeShortArg(bci)); break; > . . . > 86 protected short getConstantPoolIndex(int rawcode, int bci) { > 87 // get ConstantPool index from ConstantPoolCacheIndex at given bci > 88 String fmt = Bytecodes.format(rawcode); > 89 int cpCacheIndex; > 90 switch (fmt.length()) { > 91 case 2: cpCacheIndex = method.getBytecodeByteArg(bci); break; > 92 case 3: cpCacheIndex = method.getBytecodeShortArg(bci); break; > > The refIndex is positive so that there is no point to mask byte and short values at lines 78,79. > Also one more question: > Why these functions are protected, not private? > > The rest looks good. > > Thanks, > Serguei > > > On 10/17/12 5:25 PM, Yumin Qi wrote: >> Hi, >> >> As suggested by David, I created a new bug >> 8001055: Bytes.swap should follow big endian >> to address the issued caused by 6879063 push. >> >> new webrevs: >> http://cr.openjdk.java.net/~minqi/8000818 >> http://cr.openjdk.java.net/~minqi/8001055 >> >> Thanks >> Yumin >> >> On 10/16/2012 9:51 PM, Yumin Qi wrote: >>> Hi, all >>> >>> May I have your codereview on >>> >>> http://cr.openjdk.java.net/~minqi/8000818/ >>> >>> >>> 8000818: SA constant pool need to reference to reference map after >>> permgen removal >>> Summary: After permgen removal, constant pool changed to put _ldc >>> and _ldc_w (fast_ldc and fast_ldcw) index to reference map, no >>> longer calculated via constant pool cache. >>> Also, there is a mistake in 6879063: SA should use hsdis. Bytes.swap >>> should only check if the underlying platform is big endian since >>> java code follows big endian. Revert it back to its orginal form, >>> else it will fail ClassDump. >>> >>> Reviewed-by: >>> Contributed-by: yumin.qi at oracle.com >>> >>> >>> Thanks >>> Yumin > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121017/9a974a20/attachment-0001.html From xuelei.fan at oracle.com Thu Oct 18 01:15:04 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Thu, 18 Oct 2012 08:15:04 +0000 Subject: hg: jdk8/tl/jdk: 7068321: Support TLS Server Name Indication (SNI) Extension in JSSE Server Message-ID: <20121018081542.3F0824740F@hg.openjdk.java.net> Changeset: 3f62cfc4e83d Author: xuelei Date: 2012-10-18 01:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f62cfc4e83d 7068321: Support TLS Server Name Indication (SNI) Extension in JSSE Server Reviewed-by: mullan, weijun, wetmore ! src/share/classes/javax/net/ssl/ExtendedSSLSession.java ! src/share/classes/javax/net/ssl/HandshakeCompletedEvent.java + src/share/classes/javax/net/ssl/SNIHostName.java + src/share/classes/javax/net/ssl/SNIMatcher.java + src/share/classes/javax/net/ssl/SNIServerName.java ! src/share/classes/javax/net/ssl/SSLEngine.java ! src/share/classes/javax/net/ssl/SSLParameters.java ! src/share/classes/javax/net/ssl/SSLServerSocket.java ! src/share/classes/javax/net/ssl/SSLSocket.java ! src/share/classes/javax/net/ssl/SSLSocketFactory.java + src/share/classes/javax/net/ssl/StandardConstants.java ! src/share/classes/sun/security/ssl/BaseSSLSocketImpl.java ! src/share/classes/sun/security/ssl/ClientHandshaker.java ! src/share/classes/sun/security/ssl/HandshakeInStream.java ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/HelloExtensions.java ! src/share/classes/sun/security/ssl/ProtocolList.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketImpl.java ! src/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/share/classes/sun/security/ssl/SSLSocketFactoryImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java ! src/share/classes/sun/security/ssl/SunJSSE.java + src/share/classes/sun/security/ssl/Utilities.java ! src/share/classes/sun/security/ssl/X509KeyManagerImpl.java ! src/share/classes/sun/security/ssl/X509TrustManagerImpl.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/LargePacket.java ! test/sun/security/ssl/javax/net/ssl/NewAPIs/SSLEngine/SSLEngineService.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLEngineExplorer.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLEngineExplorerUnmatchedSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLEngineExplorerWithCli.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLEngineExplorerWithSrv.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketConsistentSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketExplorer.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketExplorerFailure.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketExplorerMatchedSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketExplorerUnmatchedSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketExplorerWithCliSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketExplorerWithSrvSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketInconsistentSNI.java + test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketSNISensitive.java + test/sun/security/ssl/templates/SSLCapabilities.java + test/sun/security/ssl/templates/SSLExplorer.java From yumin.qi at oracle.com Thu Oct 18 13:27:11 2012 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Thu, 18 Oct 2012 13:27:11 -0700 Subject: RFR: 8000818: SA constant pool need to reference to reference map after permgen removal In-Reply-To: <507F4C62.1000902@oracle.com> References: <507E394F.7080702@oracle.com> <507F4C62.1000902@oracle.com> Message-ID: <5080661F.8030605@oracle.com> Hi, all Add _invokehandle which is missed in SA. Its java code is _invokevirtual which already processed in ClassWriter. Same links. Thanks Yumin On 10/17/2012 5:25 PM, Yumin Qi wrote: > Hi, > > As suggested by David, I created a new bug > 8001055: Bytes.swap should follow big endian > to address the issued caused by 6879063 push. > > new webrevs: > http://cr.openjdk.java.net/~minqi/8000818 > http://cr.openjdk.java.net/~minqi/8001055 > > Thanks > Yumin > > On 10/16/2012 9:51 PM, Yumin Qi wrote: >> Hi, all >> >> May I have your codereview on >> >> http://cr.openjdk.java.net/~minqi/8000818/ >> >> >> 8000818: SA constant pool need to reference to reference map after >> permgen removal >> Summary: After permgen removal, constant pool changed to put _ldc and >> _ldc_w (fast_ldc and fast_ldcw) index to reference map, no longer >> calculated via constant pool cache. >> Also, there is a mistake in 6879063: SA should use hsdis. Bytes.swap >> should only check if the underlying platform is big endian since >> java code follows big endian. Revert it back to its orginal form, >> else it will fail ClassDump. >> >> Reviewed-by: >> Contributed-by: yumin.qi at oracle.com >> >> >> Thanks >> Yumin From coleen.phillimore at oracle.com Thu Oct 18 13:54:52 2012 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Thu, 18 Oct 2012 20:54:52 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20121018205458.7608747420@hg.openjdk.java.net> Changeset: 85916677fc22 Author: coleenp Date: 2012-10-18 13:08 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/85916677fc22 7188233: UseVMInterruptibleIO flag deprecate for JDK8 Summary: The -XX:+UseVMInterruptibleIO flag is deprecated for JDK8. The flag will still enable Interruptible IO on Solaris, but users will get a warning. Reviewed-by: dholmes, acorn, alanb Contributed-by: harold.seigel at oracle.com ! src/share/vm/runtime/arguments.cpp Changeset: 8ebcedb7604d Author: coleenp Date: 2012-10-18 13:09 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8ebcedb7604d 7053130: hs_err file does not record specified CLASSPATH Summary: Added code to write the value of the java.class.path property to the hs_err file. Reviewed-by: kmo, dholmes, kvn Contributed-by: harold.seigel at oracle.com ! src/share/vm/runtime/arguments.cpp From coleen.phillimore at oracle.com Thu Oct 18 14:17:37 2012 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Thu, 18 Oct 2012 17:17:37 -0400 Subject: RFR: 8000818: SA constant pool need to reference to reference map after permgen removal In-Reply-To: <5080661F.8030605@oracle.com> References: <507E394F.7080702@oracle.com> <507F4C62.1000902@oracle.com> <5080661F.8030605@oracle.com> Message-ID: <508071F1.5070408@oracle.com> Yumin, This looks okay. Did you write a test for this? Is there something that can be added to the (currently internal) nsk.sajdi.testlist tests that tests this functionality? It's probably not possible to add it to the jtreg tests. thanks, Coleen On 10/18/2012 4:27 PM, yumin.qi at oracle.com wrote: > Hi, all > > Add _invokehandle which is missed in SA. Its java code is > _invokevirtual which already processed in ClassWriter. > Same links. > > Thanks > Yumin > > On 10/17/2012 5:25 PM, Yumin Qi wrote: >> Hi, >> >> As suggested by David, I created a new bug >> 8001055: Bytes.swap should follow big endian >> to address the issued caused by 6879063 push. >> >> new webrevs: >> http://cr.openjdk.java.net/~minqi/8000818 >> http://cr.openjdk.java.net/~minqi/8001055 >> >> Thanks >> Yumin >> >> On 10/16/2012 9:51 PM, Yumin Qi wrote: >>> Hi, all >>> >>> May I have your codereview on >>> >>> http://cr.openjdk.java.net/~minqi/8000818/ >>> >>> >>> 8000818: SA constant pool need to reference to reference map after >>> permgen removal >>> Summary: After permgen removal, constant pool changed to put _ldc >>> and _ldc_w (fast_ldc and fast_ldcw) index to reference map, no >>> longer calculated via constant pool cache. >>> Also, there is a mistake in 6879063: SA should use hsdis. Bytes.swap >>> should only check if the underlying platform is big endian since >>> java code follows big endian. Revert it back to its orginal form, >>> else it will fail ClassDump. >>> >>> Reviewed-by: >>> Contributed-by: yumin.qi at oracle.com >>> >>> >>> Thanks >>> Yumin From yumin.qi at oracle.com Thu Oct 18 14:44:16 2012 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Thu, 18 Oct 2012 14:44:16 -0700 Subject: RFR: 8000818: SA constant pool need to reference to reference map after permgen removal In-Reply-To: <508071F1.5070408@oracle.com> References: <507E394F.7080702@oracle.com> <507F4C62.1000902@oracle.com> <5080661F.8030605@oracle.com> <508071F1.5070408@oracle.com> Message-ID: <50807830.6090407@oracle.com> Thanks I dumped all the classes then manually checked with javap on some, the result is OK. Also used BCEL to verify some of the classes, some warnings, not a big deal. There is only one problem, but it is not important for SA usage, the StackMapTable is missed in class dump, anyway rt.jar file does not include that too. For jtreg, we need a Verifier, first dump java classes from SA, then run Verifier against the output. For writing a verifier in java need much more time for me. So currently no plan to write a test case for this. Thanks Yumin On 10/18/2012 2:17 PM, Coleen Phillimore wrote: > > Yumin, > This looks okay. Did you write a test for this? Is there something > that can be added to the (currently internal) nsk.sajdi.testlist tests > that tests this functionality? It's probably not possible to add it > to the jtreg tests. > thanks, > Coleen > > On 10/18/2012 4:27 PM, yumin.qi at oracle.com wrote: >> Hi, all >> >> Add _invokehandle which is missed in SA. Its java code is >> _invokevirtual which already processed in ClassWriter. >> Same links. >> >> Thanks >> Yumin >> >> On 10/17/2012 5:25 PM, Yumin Qi wrote: >>> Hi, >>> >>> As suggested by David, I created a new bug >>> 8001055: Bytes.swap should follow big endian >>> to address the issued caused by 6879063 push. >>> >>> new webrevs: >>> http://cr.openjdk.java.net/~minqi/8000818 >>> http://cr.openjdk.java.net/~minqi/8001055 >>> >>> Thanks >>> Yumin >>> >>> On 10/16/2012 9:51 PM, Yumin Qi wrote: >>>> Hi, all >>>> >>>> May I have your codereview on >>>> >>>> http://cr.openjdk.java.net/~minqi/8000818/ >>>> >>>> >>>> 8000818: SA constant pool need to reference to reference map after >>>> permgen removal >>>> Summary: After permgen removal, constant pool changed to put _ldc >>>> and _ldc_w (fast_ldc and fast_ldcw) index to reference map, no >>>> longer calculated via constant pool cache. >>>> Also, there is a mistake in 6879063: SA should use hsdis. >>>> Bytes.swap should only check if the underlying platform is big >>>> endian since java code follows big endian. Revert it back to its >>>> orginal form, else it will fail ClassDump. >>>> >>>> Reviewed-by: >>>> Contributed-by: yumin.qi at oracle.com >>>> >>>> >>>> Thanks >>>> Yumin From john.coomes at oracle.com Thu Oct 18 21:53:17 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 19 Oct 2012 04:53:17 +0000 Subject: hg: hsx/hotspot-rt: Added tag jdk8-b61 for changeset 20ff117b5090 Message-ID: <20121019045317.2A92D47448@hg.openjdk.java.net> Changeset: 8343ccdd63f1 Author: katleman Date: 2012-10-18 11:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/8343ccdd63f1 Added tag jdk8-b61 for changeset 20ff117b5090 ! .hgtags From john.coomes at oracle.com Thu Oct 18 21:53:21 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 19 Oct 2012 04:53:21 +0000 Subject: hg: hsx/hotspot-rt/corba: 4 new changesets Message-ID: <20121019045325.C910E47449@hg.openjdk.java.net> Changeset: 27d87f0031bf Author: alanb Date: 2012-10-05 15:08 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/27d87f0031bf 7195779: javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently, NPE in tie class Reviewed-by: alanb, coffeys Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/sun/rmi/rmic/iiop/StubGenerator.java Changeset: d9c1dab1515b Author: lana Date: 2012-10-08 15:38 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/d9c1dab1515b Merge Changeset: 0e08ba7648fb Author: lana Date: 2012-10-11 16:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/0e08ba7648fb Merge Changeset: 2394155f9f9e Author: katleman Date: 2012-10-18 11:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/2394155f9f9e Added tag jdk8-b61 for changeset 0e08ba7648fb ! .hgtags From john.coomes at oracle.com Thu Oct 18 21:53:29 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 19 Oct 2012 04:53:29 +0000 Subject: hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b61 for changeset 6b1db0b41d2f Message-ID: <20121019045340.3F6264744A@hg.openjdk.java.net> Changeset: 5d0fa0108d02 Author: katleman Date: 2012-10-18 11:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/5d0fa0108d02 Added tag jdk8-b61 for changeset 6b1db0b41d2f ! .hgtags From john.coomes at oracle.com Thu Oct 18 21:53:44 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 19 Oct 2012 04:53:44 +0000 Subject: hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b61 for changeset 97e5e74e2a34 Message-ID: <20121019045350.AD2C44744B@hg.openjdk.java.net> Changeset: d265b9b4c0f5 Author: katleman Date: 2012-10-18 11:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/d265b9b4c0f5 Added tag jdk8-b61 for changeset 97e5e74e2a34 ! .hgtags From john.coomes at oracle.com Thu Oct 18 21:54:55 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 19 Oct 2012 04:54:55 +0000 Subject: hg: hsx/hotspot-rt/jdk: 51 new changesets Message-ID: <20121019050524.86DCB4744C@hg.openjdk.java.net> Changeset: 4d8b411a2bc1 Author: jgodinez Date: 2012-09-25 09:18 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4d8b411a2bc1 7158350: [macosx] Strange results of SwingUIText printing Reviewed-by: bae, prr ! src/macosx/native/sun/awt/CTextPipe.m Changeset: 5aff878baaf6 Author: lana Date: 2012-09-28 11:45 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/5aff878baaf6 Merge - make/common/Defs-embedded.gmk - make/common/Release-embedded.gmk - src/macosx/classes/sun/awt/SunToolkitSubclass.java - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - test/sun/misc/URLClassPath/ClassnameCharTest.sh - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: 8dd4cae72975 Author: ceisserer Date: 2012-10-01 13:07 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8dd4cae72975 7188093: closed/sun/java2d/pipe/ScaleQualityTest.java fails Reviewed-by: prr, flar ! src/solaris/classes/sun/java2d/xr/XRDrawImage.java Changeset: 89a1094e384f Author: bae Date: 2012-10-05 16:21 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/89a1094e384f 8000176: Need automated test for checking scale quality Reviewed-by: prr, bae Contributed-by: Vadim Pakhnushev + test/sun/java2d/pipe/InterpolationQualityTest.java Changeset: 2bc7669294cc Author: lana Date: 2012-10-08 15:36 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/2bc7669294cc Merge Changeset: 9aa37a39cf39 Author: zhouyx Date: 2012-09-20 17:39 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9aa37a39cf39 7194184: JColorChooser swatch cannot accessed from keyboard Reviewed-by: rupashka, alexsch ! src/share/classes/javax/swing/colorchooser/DefaultSwatchChooserPanel.java + test/javax/swing/JColorChooser/Test7194184.java Changeset: 4f519691520c Author: vkarnauk Date: 2012-09-20 17:55 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4f519691520c 7123767: Wrong tooltip location in Multi-Monitor configurations Reviewed-by: rupashka ! src/share/classes/javax/swing/ToolTipManager.java + test/javax/swing/ToolTipManager/7123767/bug7123767.java Changeset: adddc599e551 Author: alexsch Date: 2012-09-21 13:48 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/adddc599e551 7199180: [macosx] Dead keys handling for input methods Reviewed-by: kizune, anthony ! src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java ! src/macosx/native/sun/awt/AWTEvent.m ! src/macosx/native/sun/awt/AWTView.m + test/java/awt/event/KeyEvent/DeadKey/DeadKeyMacOSXInputText.java Changeset: 88048b34405e Author: leonidr Date: 2012-09-24 15:25 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/88048b34405e 7124239: [macosx] sun.awt.SunToolkit.InfiniteLoop exception in realSync called from SwingTestHelper Reviewed-by: anthony ! src/macosx/native/sun/awt/LWCToolkit.m ! src/macosx/native/sun/osxapp/NSApplicationAWT.h ! src/macosx/native/sun/osxapp/NSApplicationAWT.m Changeset: d6cba7bfbb3d Author: leonidr Date: 2012-09-24 18:24 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d6cba7bfbb3d 7179349: [macosx] Java processes on Mac should not use default Apple icon Reviewed-by: anthony ! make/sun/osxapp/Makefile + make/sun/osxapp/ToBin.java ! src/macosx/native/sun/osxapp/NSApplicationAWT.m + src/macosx/native/sun/osxapp/resource/icons/JavaApp.icns Changeset: 39227bb92978 Author: serb Date: 2012-09-24 21:33 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/39227bb92978 7160627: [macosx] TextArea has wrong initial size 7124213: [macosx] pack() does ignore size of a component; doesn't on the other platforms Reviewed-by: anthony, art ! src/macosx/classes/sun/lwawt/LWCanvasPeer.java ! src/macosx/classes/sun/lwawt/LWCheckboxPeer.java ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! src/macosx/classes/sun/lwawt/LWContainerPeer.java ! src/macosx/classes/sun/lwawt/LWLabelPeer.java ! src/macosx/classes/sun/lwawt/LWListPeer.java ! src/macosx/classes/sun/lwawt/LWPanelPeer.java ! src/macosx/classes/sun/lwawt/LWScrollBarPeer.java ! src/macosx/classes/sun/lwawt/LWTextAreaPeer.java ! src/macosx/classes/sun/lwawt/LWTextComponentPeer.java ! src/macosx/classes/sun/lwawt/LWTextFieldPeer.java ! src/macosx/classes/sun/lwawt/LWToolkit.java + test/java/awt/ScrollPane/ScrollPanePreferredSize/ScrollPanePreferredSize.java + test/java/awt/TextArea/TextAreaTwicePack/TextAreaTwicePack.java Changeset: c8da47a4d441 Author: alexsch Date: 2012-09-26 18:59 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c8da47a4d441 7124515: [macosx] Test fail like 6366126 (ArrayIndexOutOfBoundException pressing ENTER after removing items) Reviewed-by: serb, anthony + test/java/awt/List/EmptyListEventTest/EmptyListEventTest.java Changeset: ad467dee852a Author: alexsch Date: 2012-09-28 14:54 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/ad467dee852a 7197619: Using modifiers for the dead key detection on Windows Reviewed-by: bagiras, leonidr ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h Changeset: 4b8bb77fdda9 Author: lana Date: 2012-09-28 10:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4b8bb77fdda9 Merge - make/common/Defs-embedded.gmk - make/common/Release-embedded.gmk - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - test/sun/misc/URLClassPath/ClassnameCharTest.sh - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: 3ac112755bb5 Author: bagiras Date: 2012-10-03 21:01 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3ac112755bb5 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call Reviewed-by: art, denis ! src/macosx/native/sun/awt/InitIDs.m ! src/share/classes/java/awt/Choice.java ! src/solaris/native/sun/awt/initIDs.c ! src/windows/native/sun/windows/awt_Choice.cpp ! src/windows/native/sun/windows/awt_Choice.h + test/java/awt/Choice/ItemStateChangeTest/ItemStateChangeTest.java Changeset: 27ee94051373 Author: lana Date: 2012-10-08 15:37 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/27ee94051373 Merge Changeset: f5229879ea40 Author: chegar Date: 2012-09-20 09:36 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f5229879ea40 7193520: Removed references to Linux kernel version 2.2 Summary: Linux kernel version 2.2 isn't supported anymore. Reviewed-by: chegar, dsamersoff, alanb Contributed-by: John Zavgren ! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/PlainSocketImpl.c ! src/solaris/native/java/net/SocketInputStream.c ! src/solaris/native/java/net/bsd_close.c ! src/solaris/native/java/net/net_util_md.c ! src/solaris/native/java/net/net_util_md.h Changeset: 3ad5464e7a21 Author: ksrini Date: 2012-09-20 13:01 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3ad5464e7a21 7199614: (pack200) remove unused file Reviewed-by: alanb - src/share/test/pack200/pack.conf Changeset: 3cfb621d5e7e Author: alanb Date: 2012-09-21 15:39 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/3cfb621d5e7e 7199551: (bf) CharBuffer.append(CharSequence) throws BufferOverflowException for read-only buffer Reviewed-by: iris, dxu, chegar ! src/share/classes/java/nio/X-Buffer.java.template ! test/java/nio/Buffer/Basic-X.java.template ! test/java/nio/Buffer/Basic.java ! test/java/nio/Buffer/BasicByte.java ! test/java/nio/Buffer/BasicChar.java ! test/java/nio/Buffer/BasicDouble.java ! test/java/nio/Buffer/BasicFloat.java ! test/java/nio/Buffer/BasicInt.java ! test/java/nio/Buffer/BasicLong.java ! test/java/nio/Buffer/BasicShort.java Changeset: f0aa997ad78b Author: valeriep Date: 2012-09-25 11:27 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f0aa997ad78b 7199941: test about AES/ECB mode fails Summary: Fixed the problem of field "blockMode" not having correct value for AES algorithms. Reviewed-by: vinnie ! src/share/classes/sun/security/pkcs11/P11Cipher.java Changeset: 4fcbddfd97f0 Author: valeriep Date: 2012-09-25 11:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4fcbddfd97f0 7199939: DSA 576 and 640 bit keys fail when initializing for No precomputed parameters Summary: Fixed initialize(int, SecureRandom) call to not error out when no precomputed params available. Reviewed-by: vinnie ! src/share/classes/sun/security/provider/DSAKeyPairGenerator.java ! src/share/classes/sun/security/provider/DSAParameterGenerator.java ! src/share/classes/sun/security/provider/ParameterCache.java Changeset: a58585051c4b Author: xuelei Date: 2012-09-26 21:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a58585051c4b 7200295: CertificateRequest message is wrapping when using large numbers of Certs Reviewed-by: wetmore ! src/share/classes/sun/security/ssl/HandshakeMessage.java ! src/share/classes/sun/security/ssl/HandshakeOutStream.java ! src/share/classes/sun/security/ssl/Record.java + test/sun/security/ssl/com/sun/net/ssl/internal/ssl/X509TrustManagerImpl/CertRequestOverflow.java Changeset: 790b81b631ba Author: alanb Date: 2012-09-27 10:30 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/790b81b631ba 7200742: (se) Selector.select does not block when starting Coherence (sol) Reviewed-by: chegar ! src/solaris/classes/sun/nio/ch/DevPollArrayWrapper.java + test/java/nio/channels/Selector/ChangingInterests.java Changeset: 9e879c0288c2 Author: andrew Date: 2012-09-27 17:55 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/9e879c0288c2 7201205: Add Makefile configuration option to build with unlimited crypto in OpenJDK. Summary: Allow OpenJDK to use the unlimited crypto policy. Reviewed-by: wetmore, ohair ! make/javax/crypto/Makefile Changeset: 11a5da68673c Author: robm Date: 2012-09-27 22:35 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/11a5da68673c 7199862: Make sure that a connection is still alive when retrieved from KeepAliveCache in certain cases Reviewed-by: chegar ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: b3c7a3138c5d Author: robm Date: 2012-09-28 04:39 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b3c7a3138c5d 7199219: Proxy-Connection headers set incorrectly when a HttpClient is retrieved from the Keep Alive Cache Reviewed-by: chegar ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java Changeset: 7529cc41e637 Author: peytoia Date: 2012-09-28 14:14 +0900 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7529cc41e637 7069824: Support for BCP47 locale matching Reviewed-by: naoto, okutsu ! src/share/classes/java/util/Locale.java + src/share/classes/sun/util/locale/LocaleEquivalentMaps.java + src/share/classes/sun/util/locale/LocaleMatcher.java + test/java/util/Locale/Bug7069824.java + test/java/util/Locale/tools/EquivMapsGenerator.java + test/java/util/Locale/tools/language-subtag-registry.txt Changeset: 7e3ef09bb348 Author: weijun Date: 2012-09-28 17:15 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7e3ef09bb348 7200682: TEST_BUG: keytool/autotest.sh still has problems with libsoftokn.so Reviewed-by: alanb, smarks ! test/sun/security/tools/keytool/autotest.sh Changeset: b8e08f5d255a Author: dxu Date: 2012-09-28 11:14 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/b8e08f5d255a 6950237: Test java/nio/file/Path/CopyAndMove.java does not work correctly when test dir in on VFAT Reviewed-by: alanb ! src/solaris/classes/sun/nio/fs/LinuxFileStore.java ! test/java/nio/file/Files/CopyAndMove.java Changeset: 77bf5cde2192 Author: lana Date: 2012-09-28 14:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/77bf5cde2192 Merge - make/common/Defs-embedded.gmk - make/common/Release-embedded.gmk - src/macosx/classes/sun/awt/SunToolkitSubclass.java Changeset: 0c1c4b185451 Author: dsamersoff Date: 2012-09-29 15:44 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/0c1c4b185451 7186723: TEST_BUG: Race condition in sun/management/jmxremote/startstop/JMXStartStopTest.sh Summary: Make test self-terminating and independent to cygwin/mks kill behaviour Reviewed-by: sspitsyn, alanb ! test/ProblemList.txt ! test/sun/management/jmxremote/startstop/JMXStartStopDoSomething.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.java ! test/sun/management/jmxremote/startstop/JMXStartStopTest.sh ! test/sun/management/jmxremote/startstop/REMOTE_TESTING.txt Changeset: 39cbe256c3d1 Author: alanb Date: 2012-10-01 15:36 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/39cbe256c3d1 8000269: Cleanup javadoc warnings Reviewed-by: lancea, darcy, ulfzibis, iris, naoto, dholmes ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/io/PrintWriter.java ! src/share/classes/java/io/Reader.java ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/InheritableThreadLocal.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/StrictMath.java ! src/share/classes/java/lang/String.java ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/ThreadGroup.java ! src/share/classes/java/lang/ThreadLocal.java ! src/share/classes/java/lang/management/ThreadInfo.java ! src/share/classes/java/net/AbstractPlainDatagramSocketImpl.java ! src/share/classes/java/net/AbstractPlainSocketImpl.java ! src/share/classes/java/net/DatagramSocket.java ! src/share/classes/java/net/Inet4Address.java ! src/share/classes/java/net/SocketInputStream.java ! src/share/classes/java/net/SocketPermission.java ! src/share/classes/java/net/SocksSocketImpl.java ! src/share/classes/java/net/URLConnection.java ! src/share/classes/java/nio/channels/Channels.java ! src/share/classes/java/nio/file/FileSystem.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/nio/file/attribute/AclFileAttributeView.java ! src/share/classes/java/nio/file/attribute/FileTime.java ! src/share/classes/java/security/AllPermission.java ! src/share/classes/java/security/BasicPermission.java ! src/share/classes/java/security/CodeSource.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/cert/PKIXRevocationChecker.java ! src/share/classes/java/sql/CallableStatement.java ! src/share/classes/java/text/CollationElementIterator.java ! src/share/classes/java/text/DigitList.java ! src/share/classes/java/text/Format.java ! src/share/classes/java/text/RBCollationTables.java ! src/share/classes/java/text/RBTableBuilder.java ! src/share/classes/java/text/SimpleDateFormat.java ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/Currency.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/java/util/JapaneseImperialCalendar.java ! src/share/classes/java/util/JumboEnumSet.java ! src/share/classes/java/util/Locale.java ! src/share/classes/java/util/PropertyPermission.java ! src/share/classes/java/util/RegularEnumSet.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/java/util/TimeZone.java ! src/share/classes/java/util/logging/Logging.java ! src/share/classes/java/util/prefs/XmlSupport.java ! src/share/classes/javax/crypto/CryptoAllPermission.java ! src/share/classes/javax/crypto/CryptoPermission.java ! src/share/classes/javax/crypto/CryptoPolicyParser.java ! src/share/classes/javax/crypto/NullCipherSpi.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/javax/management/modelmbean/ModelMBeanAttributeInfo.java ! src/share/classes/javax/management/openmbean/CompositeDataInvocationHandler.java ! src/share/classes/javax/naming/spi/NamingManager.java ! src/share/classes/javax/security/auth/kerberos/DelegationPermission.java ! src/share/classes/javax/security/auth/kerberos/ServicePermission.java ! src/share/classes/javax/sql/ConnectionPoolDataSource.java ! src/share/classes/javax/sql/PooledConnection.java ! src/share/classes/javax/sql/rowset/spi/SyncProvider.java Changeset: 75080f572f84 Author: olagneau Date: 2012-10-02 10:11 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/75080f572f84 7050528: Improve performance of java.text.DecimalFormat.format() call stack Reviewed-by: darcy ! src/share/classes/java/text/DecimalFormat.java ! src/share/classes/java/text/NumberFormat.java + test/java/text/Format/DecimalFormat/FormatMicroBenchmark.java + test/java/text/Format/DecimalFormat/GoldenDoubleValues.java + test/java/text/Format/DecimalFormat/GoldenFormattedValues.java + test/java/text/Format/DecimalFormat/RoundingAndPropertyTest.java Changeset: 041c687c4f40 Author: psandoz Date: 2012-10-02 10:36 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/041c687c4f40 7197642: (sl) ServiceLoader.load(null) doesn't throw NPE Reviewed-by: alanb ! src/share/classes/java/util/ServiceLoader.java + test/java/util/ServiceLoader/NPE.java Changeset: 6750ab947255 Author: alanb Date: 2012-10-02 12:23 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/6750ab947255 8000268: sun/security/provider/X509Factory/BigCRL.java failing on Linux 32-bit Reviewed-by: mullan ! test/sun/security/provider/X509Factory/BigCRL.java Changeset: 4744dc70e5d1 Author: peytoia Date: 2012-10-03 15:11 +0900 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/4744dc70e5d1 7104012: AIOOBE from RuleBasedBreakIterator.lookupState for some suppl. chars Reviewed-by: okutsu ! src/share/classes/sun/text/SupplementaryCharacterData.java + test/java/text/BreakIterator/Bug7104012.java Changeset: 7fe88d457d85 Author: dxu Date: 2012-10-03 09:03 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7fe88d457d85 6910472: Typo in : java.io.ObjectOutputStream.reset() "refered" Reviewed-by: dholmes, alanb ! src/share/classes/java/io/ObjectOutputStream.java Changeset: 123db1c28d92 Author: peytoia Date: 2012-10-04 11:36 +0900 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/123db1c28d92 7196316: Wrong rounding mode in DecimalFormat after deserialization Reviewed-by: okutsu ! src/share/classes/java/text/DecimalFormat.java + test/java/text/Format/DecimalFormat/Bug7196316.java Changeset: 8692e14b8ea8 Author: peytoia Date: 2012-10-04 18:05 +0900 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/8692e14b8ea8 7201151: Fix Contribution : Java cannot get Windows's IME name correctly Reviewed-by: okutsu ! src/windows/native/sun/windows/awt_InputMethod.cpp Changeset: 344f0acff085 Author: vinnie Date: 2012-02-14 11:18 +0000 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/344f0acff085 7133495: [macosx] KeyChain KeyStore implementation retrieves only one private key entry Reviewed-by: weijun ! src/macosx/native/apple/security/KeystoreImpl.m + test/sun/security/tools/keytool/ListKeychainStore.sh Changeset: 77af5b4ae4f0 Author: vinnie Date: 2012-10-04 11:54 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/77af5b4ae4f0 Merge Changeset: c6a0b13e6efa Author: naoto Date: 2012-10-04 10:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/c6a0b13e6efa 7196799: CLDR adapter can not be invoked when region code is specified in Locale 7197573: java/util/Locale/LocaleProviders.sh failed. Reviewed-by: okutsu ! make/java/java/FILES_java.gmk ! src/share/classes/sun/util/locale/provider/CalendarDataProviderImpl.java + src/share/classes/sun/util/locale/provider/FallbackLocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleProviderAdapter.java ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh Changeset: bba370caafad Author: robm Date: 2012-10-04 19:53 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/bba370caafad 7184932: Remove the temporary Selector usage in the NIO socket adapters Reviewed-by: alanb ! make/java/nio/mapfile-bsd ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java ! src/share/classes/sun/nio/ch/DatagramSocketAdaptor.java ! src/share/classes/sun/nio/ch/Net.java ! src/share/classes/sun/nio/ch/ServerSocketAdaptor.java ! src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/share/classes/sun/nio/ch/SocketAdaptor.java ! src/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/share/classes/sun/nio/ch/Util.java ! src/solaris/native/sun/nio/ch/Net.c ! src/windows/native/sun/nio/ch/Net.c + test/java/nio/channels/etc/AdaptorCloseAndInterrupt.java Changeset: cd4f181eb666 Author: naoto Date: 2012-10-04 21:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/cd4f181eb666 7200119: Collator.getAvailableLocales() doesn't return Locale.US Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java + test/java/text/Collator/Bug7200119.java Changeset: 647424d6cf65 Author: naoto Date: 2012-10-04 21:05 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/647424d6cf65 Merge Changeset: 88a726a5b2dc Author: naoto Date: 2012-10-05 09:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/88a726a5b2dc 7198834: HOST Adapter: one extra empty space in the end of the pattern string Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/windows/native/sun/util/locale/provider/HostLocaleProviderAdapter_md.c ! test/java/util/Locale/LocaleProviders.java ! test/java/util/Locale/LocaleProviders.sh Changeset: f65871e75fde Author: alanb Date: 2012-10-06 13:56 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/f65871e75fde 8000354: (props) Properties.storeToXML/loadFromXML need to allow for alternative implementations Reviewed-by: mchung, forax ! make/java/java/FILES_java.gmk ! make/sun/util/Makefile ! src/share/classes/java/util/Properties.java + src/share/classes/sun/util/spi/XmlPropertiesProvider.java + src/share/classes/sun/util/xml/META-INF/services/sun.util.spi.XmlPropertiesProvider + src/share/classes/sun/util/xml/PlatformXmlPropertiesProvider.java - src/share/classes/sun/util/xml/XMLUtils.java + test/java/util/Properties/CustomProvider.java + test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/MyXmlPropertiesProvider.java Changeset: 92f3a96f3c78 Author: weijun Date: 2012-10-08 10:42 +0800 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/92f3a96f3c78 7201053: Krb5LoginModule shows NPE when both useTicketCache and storeKey are set to true Reviewed-by: mullan ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java + test/sun/security/krb5/auto/UseCacheAndStoreKey.java Changeset: d8581143e11d Author: lana Date: 2012-10-08 15:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/d8581143e11d Merge - src/share/classes/sun/util/xml/XMLUtils.java - src/share/test/pack200/pack.conf Changeset: 61ddb3fd000a Author: lana Date: 2012-10-11 16:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/61ddb3fd000a Merge - src/share/classes/sun/util/xml/XMLUtils.java - src/share/test/pack200/pack.conf Changeset: 1ae6420126af Author: katleman Date: 2012-10-18 11:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/1ae6420126af Added tag jdk8-b61 for changeset 61ddb3fd000a ! .hgtags From john.coomes at oracle.com Thu Oct 18 22:08:26 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 19 Oct 2012 05:08:26 +0000 Subject: hg: hsx/hotspot-rt/langtools: 22 new changesets Message-ID: <20121019050916.907D54744D@hg.openjdk.java.net> Changeset: 8987971bcb45 Author: jjg Date: 2012-09-24 14:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/8987971bcb45 7196462: JavacProcessingEnvironment should tolerate BasicJavacTask Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/api/BasicJavacTask.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/processing/T7196462.java Changeset: 99983a4a593b Author: mcimadamore Date: 2012-09-25 11:52 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/99983a4a593b 7193913: Cleanup Resolve.findMethod Summary: Refactor method lookup logic in Resolve.findMethod Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: 26d93df3905a Author: mcimadamore Date: 2012-09-25 11:53 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/26d93df3905a 7194586: Add back-end support for invokedynamic Summary: Add support for invokedynamic bytecode instruction; includes suppot for generation of all related classfile attributes Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/jvm/ClassFile.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/util/Names.java + test/tools/javac/lambda/TestInvokeDynamic.java Changeset: 2eca84194807 Author: mcimadamore Date: 2012-09-25 11:55 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/2eca84194807 7175433: Inference cleanup: add helper class to handle inference variables Summary: Add class to handle inference variables instantiation and associated info Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/generics/inference/6638712/T6638712c.out + test/tools/javac/varargs/6313164/T7175433.java Changeset: ad2ca2a4ab5e Author: mcimadamore Date: 2012-09-25 11:56 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/ad2ca2a4ab5e 7177306: Regression: unchecked method call does not erase return type Summary: Spurious extra call to Attr.checkMethod when method call is unchecked Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/6758789/T6758789b.out ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/IncompatibleEqUpperBounds.java ! test/tools/javac/generics/7015430/T7015430.out ! test/tools/javac/generics/7151802/T7151802.out + test/tools/javac/generics/inference/7177306/T7177306a.java + test/tools/javac/generics/inference/7177306/T7177306a.out + test/tools/javac/generics/inference/7177306/T7177306b.java + test/tools/javac/generics/inference/7177306/T7177306b.out + test/tools/javac/generics/inference/7177306/T7177306c.java + test/tools/javac/generics/inference/7177306/T7177306d.java + test/tools/javac/generics/inference/7177306/T7177306e.java + test/tools/javac/generics/inference/7177306/T7177306e.out Changeset: 0e5899f09dab Author: jjg Date: 2012-09-25 13:06 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/0e5899f09dab 7193657: provide internal ArrayUtils class to simplify common usage of arrays in javac Reviewed-by: mcimadamore, jjg Contributed-by: vicenterz at yahoo.es ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java ! src/share/classes/com/sun/tools/javac/api/MultiTaskListener.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/file/Locations.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/parser/UnicodeReader.java + src/share/classes/com/sun/tools/javac/util/ArrayUtils.java ! src/share/classes/com/sun/tools/javac/util/Bits.java ! src/share/classes/com/sun/tools/javac/util/ByteBuffer.java ! src/share/classes/com/sun/tools/javac/util/SharedNameTable.java ! src/share/classes/com/sun/tools/javap/StackMapWriter.java Changeset: 99d23c0ef8ee Author: jjg Date: 2012-09-25 13:11 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/99d23c0ef8ee 7196464: upgrade JavaCompiler.shouldStopPolicy to accomodate policies in face of error and no error Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java Changeset: db36841709e4 Author: mcimadamore Date: 2012-09-26 14:22 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/db36841709e4 7188968: New instance creation expression using diamond is checked twice Summary: Unify method and constructor check logic Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/6840059/T6840059.out ! test/tools/javac/6857948/T6857948.out ! test/tools/javac/diags/examples/KindnameConstructor.java ! test/tools/javac/generics/diamond/7002837/T7002837.java + test/tools/javac/generics/diamond/7002837/T7002837.out + test/tools/javac/generics/diamond/7188968/T7188968.java + test/tools/javac/generics/diamond/7188968/T7188968.out ! test/tools/javac/positions/T6264029.out Changeset: 1a65d6565b45 Author: mcimadamore Date: 2012-09-28 16:56 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/1a65d6565b45 8000233: Fix issues in recent push Summary: Forgot to incorporate review comments in pushed changesets Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! src/share/classes/com/sun/tools/javac/util/Names.java Changeset: f1e6b361a329 Author: mcimadamore Date: 2012-09-28 18:50 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/f1e6b361a329 8000241: langtools doesn't build Summary: bad merge with langtools tip caused build glitch Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Pool.java ! test/tools/javac/lambda/TestInvokeDynamic.java Changeset: 73312ec2cf7c Author: jfranck Date: 2012-09-28 11:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/73312ec2cf7c 7199925: Separate compilation breaks check that elements have a default for the containing annotation Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties Changeset: e77841f2c74b Author: lana Date: 2012-09-28 14:57 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/e77841f2c74b Merge Changeset: 20e4a54b1629 Author: ksrini Date: 2012-09-29 09:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/20e4a54b1629 7198582: (java) Minor refactor of JavacParser Reviewed-by: jjg, ksrini Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javap/CodeWriter.java Changeset: 1408af4cd8b0 Author: mcimadamore Date: 2012-10-04 13:04 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/1408af4cd8b0 7177387: Add target-typing support in method context Summary: Add support for deferred types and speculative attribution Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/TypeTags.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/AttrContext.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/List.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! test/tools/javac/conditional/Conditional.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/IncompatibleTypesInConditional.java + test/tools/javac/diags/examples/TypeConditional.java Changeset: 573ceb23beeb Author: mcimadamore Date: 2012-10-05 14:35 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/573ceb23beeb 7177385: Add attribution support for lambda expressions Summary: Add support for function descriptor lookup, functional interface inference and lambda expression type-checking Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! test/tools/javac/6402516/TestLocalElements.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/CantAccessArgTypeInFunctionalDesc.java + test/tools/javac/diags/examples/CantAccessReturnTypeInFunctionalDesc.java + test/tools/javac/diags/examples/CantAccessThrownTypesInFunctionalDesc.java ! test/tools/javac/diags/examples/CantRefNonEffectivelyFinalVar.java ! test/tools/javac/diags/examples/CatchWithoutTry.java + test/tools/javac/diags/examples/CyclicInference.java + test/tools/javac/diags/examples/IncompatibleAbstracts.java + test/tools/javac/diags/examples/IncompatibleArgTypesInLambda.java + test/tools/javac/diags/examples/IncompatibleDescsInFunctionalIntf.java + test/tools/javac/diags/examples/IncompatibleRetTypeInLambda.java + test/tools/javac/diags/examples/IncompatibleThrownTypesInLambda.java + test/tools/javac/diags/examples/InvalidGenericDescInFunctionalInterface.java + test/tools/javac/diags/examples/MissingReturnValueFragment.java + test/tools/javac/diags/examples/NoAbstracts.java + test/tools/javac/diags/examples/NoSuitableFunctionalIntfInst.java + test/tools/javac/diags/examples/NotAFunctionalIntf.java + test/tools/javac/diags/examples/PotentialLambdaFound.java - test/tools/javac/diags/examples/TypeConditional.java + test/tools/javac/diags/examples/UnexpectedLambda.java ! test/tools/javac/failover/CheckAttributedTree.java ! test/tools/javac/typeAnnotations/newlocations/BasicTest.out Changeset: d604fd09480b Author: bpatel Date: 2012-10-05 14:13 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d604fd09480b 7132631: The help-doc.html generates an invalid link to constant-values.html Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties + test/com/sun/javadoc/testHelpFile/TestHelpFile.java Changeset: ef88ae455c88 Author: bpatel Date: 2012-10-05 14:16 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/ef88ae455c88 7068595: html files in class-use dir do not get loaded correctly when Frames link is clicked Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! test/com/sun/javadoc/testUseOption/TestUseOption.java Changeset: f4e45397722a Author: bpatel Date: 2012-10-05 14:21 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/f4e45397722a 4696488: javadoc doesn't handle UNC paths for destination directory Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java + test/tools/javadoc/T4696488.java Changeset: d4b3cb1ece84 Author: mcimadamore Date: 2012-10-06 10:35 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/d4b3cb1ece84 7177386: Add attribution support for method references Summary: Add type-checking/lookup routines for method references Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! test/tools/javac/6758789/T6758789a.out ! test/tools/javac/6840059/T6840059.out ! test/tools/javac/7132880/T7132880.out ! test/tools/javac/Diagnostics/6722234/T6722234a_1.out ! test/tools/javac/Diagnostics/6722234/T6722234a_2.out ! test/tools/javac/Diagnostics/6722234/T6722234b_1.out ! test/tools/javac/Diagnostics/6722234/T6722234b_2.out ! test/tools/javac/Diagnostics/6722234/T6722234c.out ! test/tools/javac/Diagnostics/6862608/T6862608a.out ! test/tools/javac/Diagnostics/6862608/T6862608b.out ! test/tools/javac/T6326754.out ! test/tools/javac/diags/CheckResourceKeys.java ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/CantAccessInnerClsConstr.java + test/tools/javac/diags/examples/CantApplySymbolFragment.java + test/tools/javac/diags/examples/CantApplySymbolsFragment.java + test/tools/javac/diags/examples/CantResolveLocationArgsFragment.java + test/tools/javac/diags/examples/CantResolveLocationArgsParamsFragment.java ! test/tools/javac/diags/examples/CyclicInference.java ! test/tools/javac/diags/examples/ExplicitParamsDoNotConformToBounds.java ! test/tools/javac/diags/examples/InaccessibleVarargsType/InaccessibleVarargsType.java ! test/tools/javac/diags/examples/IncompatibleEqUpperBounds.java + test/tools/javac/diags/examples/IncompatibleRetTypeInMref.java + test/tools/javac/diags/examples/IncompatibleThrownTypesInMref.java ! test/tools/javac/diags/examples/InferArgsLengthMismatch.java ! test/tools/javac/diags/examples/InferNoConformingAssignment.java ! test/tools/javac/diags/examples/InferVarargsArgumentMismatch.java ! test/tools/javac/diags/examples/InferredDoNotConformToEq.java ! test/tools/javac/diags/examples/InferredDoNotConformToUpper.java ! test/tools/javac/diags/examples/KindnameConstructor.java ! test/tools/javac/diags/examples/MethodReferencesNotSupported.java ! test/tools/javac/diags/examples/NoArgs.java + test/tools/javac/diags/examples/NonStaticCantBeRefFragment.java ! test/tools/javac/diags/examples/NotApplicableMethodFound.java + test/tools/javac/diags/examples/NotDefAccessClassIntfCantAccessFragment.java + test/tools/javac/diags/examples/RefAmbiguousFragment.java + test/tools/javac/diags/examples/UnexpectedMref.java ! test/tools/javac/diags/examples/VarargsArgumentMismatch.java ! test/tools/javac/diags/examples/VerboseResolveMulti1.java ! test/tools/javac/diags/examples/WhereCaptured.java ! test/tools/javac/diags/examples/WhereCaptured1.java ! test/tools/javac/diags/examples/WhereTypeVar.java ! test/tools/javac/generics/7034511/T7034511a.out ! test/tools/javac/generics/7034511/T7034511b.out ! test/tools/javac/generics/inference/6611449/T6611449.out ! test/tools/javac/generics/inference/6638712/T6638712a.out ! test/tools/javac/generics/inference/6638712/T6638712c.out ! test/tools/javac/generics/inference/6638712/T6638712d.out ! test/tools/javac/generics/inference/6838943/T6838943.out ! test/tools/javac/generics/inference/7086586/T7086586.out ! test/tools/javac/generics/inference/7177306/T7177306b.out ! test/tools/javac/lambda/MethodReferenceParserTest.java ! test/tools/javac/quid/T6999438.out ! test/tools/javac/varargs/6313164/T6313164.out Changeset: aa3ef5c09b1b Author: lana Date: 2012-10-08 15:40 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/aa3ef5c09b1b Merge Changeset: 26020b247ad3 Author: lana Date: 2012-10-11 17:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/26020b247ad3 Merge Changeset: b47bb81ba962 Author: katleman Date: 2012-10-18 11:09 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/b47bb81ba962 Added tag jdk8-b61 for changeset 26020b247ad3 ! .hgtags From serguei.spitsyn at oracle.com Fri Oct 19 00:30:51 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 19 Oct 2012 00:30:51 -0700 Subject: RFR: 8000818: SA constant pool need to reference to reference map after permgen removal In-Reply-To: <5080661F.8030605@oracle.com> References: <507E394F.7080702@oracle.com> <507F4C62.1000902@oracle.com> <5080661F.8030605@oracle.com> Message-ID: <508101AB.1090601@oracle.com> Looks good. Thanks, Serguei On 10/18/12 1:27 PM, yumin.qi at oracle.com wrote: > Hi, all > > Add _invokehandle which is missed in SA. Its java code is > _invokevirtual which already processed in ClassWriter. > Same links. > > Thanks > Yumin > > On 10/17/2012 5:25 PM, Yumin Qi wrote: >> Hi, >> >> As suggested by David, I created a new bug >> 8001055: Bytes.swap should follow big endian >> to address the issued caused by 6879063 push. >> >> new webrevs: >> http://cr.openjdk.java.net/~minqi/8000818 >> http://cr.openjdk.java.net/~minqi/8001055 >> >> Thanks >> Yumin >> >> On 10/16/2012 9:51 PM, Yumin Qi wrote: >>> Hi, all >>> >>> May I have your codereview on >>> >>> http://cr.openjdk.java.net/~minqi/8000818/ >>> >>> >>> 8000818: SA constant pool need to reference to reference map after >>> permgen removal >>> Summary: After permgen removal, constant pool changed to put _ldc >>> and _ldc_w (fast_ldc and fast_ldcw) index to reference map, no >>> longer calculated via constant pool cache. >>> Also, there is a mistake in 6879063: SA should use hsdis. Bytes.swap >>> should only check if the underlying platform is big endian since >>> java code follows big endian. Revert it back to its orginal form, >>> else it will fail ClassDump. >>> >>> Reviewed-by: >>> Contributed-by: yumin.qi at oracle.com >>> >>> >>> Thanks >>> Yumin From chris.hegarty at oracle.com Fri Oct 19 04:24:54 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 19 Oct 2012 11:24:54 +0000 Subject: hg: jdk8/tl/jdk: 8000206: Uninitialized variable in PlainDatagramSocketImpl.c Message-ID: <20121019112603.0EF7E47452@hg.openjdk.java.net> Changeset: 27f854a1e5c5 Author: chegar Date: 2012-10-19 11:43 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/27f854a1e5c5 8000206: Uninitialized variable in PlainDatagramSocketImpl.c Reviewed-by: dsamersoff, khazra, chegar Contributed-by: John Zavgren ! src/solaris/native/java/net/PlainDatagramSocketImpl.c From yumin.qi at oracle.com Fri Oct 19 15:59:10 2012 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Fri, 19 Oct 2012 22:59:10 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20121019225917.20D5D47465@hg.openjdk.java.net> Changeset: c7957b458bf8 Author: minqi Date: 2012-10-19 08:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/c7957b458bf8 8000818: SA constant pool need to reference to reference map after permgen removal Summary: After permgen removal, constant pool changed to put _ldc and _ldc_w (fast_ldc and fast_ldcw) index to reference map, no longer calculated via constant pool cache. Reviewed-by: coleenp, sspitsyn, dholmes Contributed-by: yumin.qi at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/interpreter/Bytecodes.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ByteCodeRewriter.java Changeset: 8eeffbc22f10 Author: minqi Date: 2012-10-19 08:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8eeffbc22f10 8001055: Bytes.swap should follow big endian Summary: This is a mistake change in 6879063 about Bytes.swap. Java byte code order always follows big endian, but in that change, assume they follow native platform order that is not right. Reviewed-by: coleenp, sspitsyn, dholmes Contributed-by: yumin.qi at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/runtime/Bytes.java From xuelei.fan at oracle.com Fri Oct 19 20:39:29 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Sat, 20 Oct 2012 03:39:29 +0000 Subject: hg: jdk8/tl/jdk: 8000954: Add final keyword to new method in SSLParameters Message-ID: <20121020033955.881164746A@hg.openjdk.java.net> Changeset: 21f1b88e68ce Author: xuelei Date: 2012-10-19 20:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/21f1b88e68ce 8000954: Add final keyword to new method in SSLParameters Reviewed-by: wetmore ! src/share/classes/javax/net/ssl/SSLParameters.java From zhengyu.gu at oracle.com Fri Oct 19 22:39:40 2012 From: zhengyu.gu at oracle.com (zhengyu.gu at oracle.com) Date: Sat, 20 Oct 2012 05:39:40 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20121020053947.7CDAE4746E@hg.openjdk.java.net> Changeset: 716c64bda5ba Author: zgu Date: 2012-10-19 21:40 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/716c64bda5ba 7199092: NMT: NMT needs to deal overlapped virtual memory ranges Summary: Enhanced virtual memory tracking to track committed regions as well as reserved regions, so NMT now can generate virtual memory map. Reviewed-by: acorn, coleenp ! src/os/bsd/vm/perfMemory_bsd.cpp ! src/os/linux/vm/perfMemory_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/perfMemory_solaris.cpp ! src/os/windows/vm/perfMemory_windows.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/filemap.hpp ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.hpp ! src/share/vm/runtime/handles.inline.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/memBaseline.cpp ! src/share/vm/services/memBaseline.hpp ! src/share/vm/services/memPtr.cpp ! src/share/vm/services/memPtr.hpp ! src/share/vm/services/memRecorder.cpp ! src/share/vm/services/memRecorder.hpp ! src/share/vm/services/memReporter.cpp ! src/share/vm/services/memReporter.hpp ! src/share/vm/services/memSnapshot.cpp ! src/share/vm/services/memSnapshot.hpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memTracker.hpp Changeset: b988bff99b38 Author: zgu Date: 2012-10-19 18:55 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/b988bff99b38 Merge From alan.bateman at oracle.com Sat Oct 20 13:07:58 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 20 Oct 2012 20:07:58 +0000 Subject: hg: jdk8/tl/jdk: 8000941: Remove ftp from the required list of protocol handlers Message-ID: <20121020200842.645E447477@hg.openjdk.java.net> Changeset: 93303f8a4a8e Author: alanb Date: 2012-10-20 21:07 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93303f8a4a8e 8000941: Remove ftp from the required list of protocol handlers Reviewed-by: chegar ! src/share/classes/java/net/ProxySelector.java ! src/share/classes/java/net/URL.java ! src/share/classes/java/net/URLStreamHandler.java ! src/share/classes/java/net/package.html From james.holmlund at oracle.com Sat Oct 20 14:50:48 2012 From: james.holmlund at oracle.com (james.holmlund at oracle.com) Date: Sat, 20 Oct 2012 21:50:48 +0000 Subject: hg: jdk8/tl/jdk: 7197401: Add a subset of the org.objectweb.asm packages to jdk8 Message-ID: <20121020215111.2BBD447478@hg.openjdk.java.net> Changeset: a40b0f51613b Author: jjh Date: 2012-10-20 22:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a40b0f51613b 7197401: Add a subset of the org.objectweb.asm packages to jdk8 Reviewed-by: ohair, briangoetz, erikj, iris ! THIRD_PARTY_README ! make/Makefile + make/jdk/Makefile + make/jdk/asm/Makefile + src/share/classes/jdk/internal/org/objectweb/asm/AnnotationVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/AnnotationWriter.java + src/share/classes/jdk/internal/org/objectweb/asm/Attribute.java + src/share/classes/jdk/internal/org/objectweb/asm/ByteVector.java + src/share/classes/jdk/internal/org/objectweb/asm/ClassReader.java + src/share/classes/jdk/internal/org/objectweb/asm/ClassVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/ClassWriter.java + src/share/classes/jdk/internal/org/objectweb/asm/Edge.java + src/share/classes/jdk/internal/org/objectweb/asm/FieldVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/FieldWriter.java + src/share/classes/jdk/internal/org/objectweb/asm/Frame.java + src/share/classes/jdk/internal/org/objectweb/asm/Handle.java + src/share/classes/jdk/internal/org/objectweb/asm/Handler.java + src/share/classes/jdk/internal/org/objectweb/asm/Item.java + src/share/classes/jdk/internal/org/objectweb/asm/Label.java + src/share/classes/jdk/internal/org/objectweb/asm/MethodVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/MethodWriter.java + src/share/classes/jdk/internal/org/objectweb/asm/Opcodes.java + src/share/classes/jdk/internal/org/objectweb/asm/Type.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/AdviceAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/AnalyzerAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/CodeSizeEvaluator.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/GeneratorAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/InstructionAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/JSRInlinerAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/LocalVariablesSorter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/Method.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/Remapper.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingAnnotationAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingClassAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingFieldAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingMethodAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/RemappingSignatureAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/SerialVersionUIDAdder.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/SimpleRemapper.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/StaticInitMerger.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/TableSwitchGenerator.java + src/share/classes/jdk/internal/org/objectweb/asm/commons/TryCatchBlockSorter.java + src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureReader.java + src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/signature/SignatureWriter.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/AbstractInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/AnnotationNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/ClassNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/FieldNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/FrameNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/IincInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/InnerClassNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnList.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/InsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/IntInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/InvokeDynamicInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/JumpInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/LabelNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/LdcInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/LineNumberNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/LocalVariableNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/LookupSwitchInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/MultiANewArrayInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/TableSwitchInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/TryCatchBlockNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/TypeInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/VarInsnNode.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Analyzer.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/AnalyzerException.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicInterpreter.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicValue.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/BasicVerifier.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Frame.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Interpreter.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SimpleVerifier.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SmallSet.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceInterpreter.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/SourceValue.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Subroutine.java + src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/Value.java + src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifiable.java + src/share/classes/jdk/internal/org/objectweb/asm/util/ASMifier.java + src/share/classes/jdk/internal/org/objectweb/asm/util/CheckAnnotationAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/util/CheckClassAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/util/CheckFieldAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/util/CheckMethodAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/util/CheckSignatureAdapter.java + src/share/classes/jdk/internal/org/objectweb/asm/util/Printer.java + src/share/classes/jdk/internal/org/objectweb/asm/util/Textifiable.java + src/share/classes/jdk/internal/org/objectweb/asm/util/Textifier.java + src/share/classes/jdk/internal/org/objectweb/asm/util/TraceAnnotationVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/util/TraceClassVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/util/TraceFieldVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/util/TraceMethodVisitor.java + src/share/classes/jdk/internal/org/objectweb/asm/util/TraceSignatureVisitor.java ! src/share/lib/security/java.security ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows ! test/Makefile + test/jdk/asm/AsmSanity.java From weijun.wang at oracle.com Sun Oct 21 18:59:44 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 22 Oct 2012 01:59:44 +0000 Subject: hg: jdk8/tl/jdk: 8001204: typo: Unable to obtain Princpal Name for authentication Message-ID: <20121022020007.160B247489@hg.openjdk.java.net> Changeset: b39ab9c6f4cb Author: weijun Date: 2012-10-22 09:59 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b39ab9c6f4cb 8001204: typo: Unable to obtain Princpal Name for authentication Reviewed-by: xuelei ! src/share/classes/com/sun/security/auth/module/Krb5LoginModule.java From weijun.wang at oracle.com Mon Oct 22 02:02:04 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 22 Oct 2012 09:02:04 +0000 Subject: hg: jdk8/tl/jdk: 8000624: Move MaxRetries.java to ProblemList for the moment Message-ID: <20121022090227.BDC7C4748F@hg.openjdk.java.net> Changeset: e19dc885da0d Author: weijun Date: 2012-10-22 17:01 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e19dc885da0d 8000624: Move MaxRetries.java to ProblemList for the moment Reviewed-by: alanb ! test/ProblemList.txt From christian.thalinger at oracle.com Mon Oct 22 14:24:48 2012 From: christian.thalinger at oracle.com (christian.thalinger at oracle.com) Date: Mon, 22 Oct 2012 21:24:48 +0000 Subject: hg: jdk8/tl/jdk: 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp Message-ID: <20121022212523.79B13474A9@hg.openjdk.java.net> Changeset: 2048ce5a12ff Author: twisti Date: 2012-10-22 14:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2048ce5a12ff 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp Reviewed-by: dholmes, mchung ! test/java/lang/ref/Basic.java From weijun.wang at oracle.com Mon Oct 22 19:02:39 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Tue, 23 Oct 2012 02:02:39 +0000 Subject: hg: jdk8/tl/jdk: 8001208: Fix for KRB5CCNAME not complete Message-ID: <20121023020303.85D3F474B6@hg.openjdk.java.net> Changeset: a1e77f7ed52b Author: weijun Date: 2012-10-23 10:02 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a1e77f7ed52b 8001208: Fix for KRB5CCNAME not complete Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java ! test/sun/security/krb5/ccache/EmptyCC.java From coleen.phillimore at oracle.com Mon Oct 22 21:20:30 2012 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Tue, 23 Oct 2012 04:20:30 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 11 new changesets Message-ID: <20121023042057.0DB90474BB@hg.openjdk.java.net> Changeset: 8a5ea0a9ccc4 Author: johnc Date: 2012-10-06 01:17 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8a5ea0a9ccc4 7127708: G1: change task num types from int to uint in concurrent mark Summary: Change the type of various task num fields, parameters etc to unsigned and rename them to be more consistent with the other collectors. Code changes were also reviewed by Vitaly Davidovich. Reviewed-by: johnc Contributed-by: Kaushik Srenevasan ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp Changeset: 04155d9c8c76 Author: johnc Date: 2012-10-08 09:12 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/04155d9c8c76 8000358: G1: metaspace information not printed in PrintHeapAtGC output nor in hs_err file Summary: Missing call to MetaspaceAux::print_on() in G1CollectedHeap::print_on(). Reviewed-by: azeemj, jmasa Contributed-by: Mikael Gerdin ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: dd2b66d09ccd Author: stefank Date: 2012-10-09 22:12 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/dd2b66d09ccd 8000659: NPG: ClassCastExceptions are unexpectedly thrown when testing nashorn Summary: Treat the oops in invoke_method_table() as strong roots when ClassUnloading is enabled. Reviewed-by: kamg, coleenp ! src/share/vm/classfile/systemDictionary.cpp Changeset: 4202510ee0fe Author: johnc Date: 2012-10-15 10:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/4202510ee0fe 8000831: Heap verification output incorrect/incomplete Summary: Restore non-silent output of heap verification. Reviewed-by: ysr, brutisso, jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/utilities/debug.cpp Changeset: 633ba56cb013 Author: jmasa Date: 2012-10-17 13:59 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/633ba56cb013 Merge ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/memory/universe.hpp Changeset: e8c79c2ba3f3 Author: coleenp Date: 2012-10-18 12:29 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e8c79c2ba3f3 Merge Changeset: fcbdaeb69946 Author: katleman Date: 2012-10-18 11:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/fcbdaeb69946 Added tag jdk8-b61 for changeset 4547dc71db76 ! .hgtags Changeset: d0337c31c8be Author: amurillo Date: 2012-10-19 11:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d0337c31c8be Merge Changeset: dccd40de8db1 Author: amurillo Date: 2012-10-19 11:03 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/dccd40de8db1 Added tag hs25-b06 for changeset d0337c31c8be ! .hgtags Changeset: d0e7716b179e Author: amurillo Date: 2012-10-19 11:26 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/d0e7716b179e 8001176: new hotspot build - hs25-b07 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 80f44792c0c9 Author: coleenp Date: 2012-10-22 12:01 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/80f44792c0c9 Merge From chris.hegarty at oracle.com Tue Oct 23 03:58:33 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Tue, 23 Oct 2012 10:58:33 +0000 Subject: hg: jdk8/tl/jdk: 8000204: Memory leak in com/sun/security/auth/module/Unix.c Message-ID: <20121023105924.B3BF4474C8@hg.openjdk.java.net> Changeset: 29b58cb8e4fc Author: chegar Date: 2012-10-23 11:57 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/29b58cb8e4fc 8000204: Memory leak in com/sun/security/auth/module/Unix.c Reviewed-by: dsamersoff, wetmore, khazra, chegar Contributed-by: John Zavgren ! src/solaris/native/com/sun/security/auth/module/Unix.c From bradford.wetmore at oracle.com Tue Oct 23 12:39:55 2012 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Tue, 23 Oct 2012 19:39:55 +0000 Subject: hg: jdk8/tl/jdk: 7197071: Makefiles for various security providers aren't including the default manifest Message-ID: <20121023194007.3E062474D9@hg.openjdk.java.net> Changeset: 940c8cc5a5c4 Author: wetmore Date: 2012-10-23 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/940c8cc5a5c4 7197071: Makefiles for various security providers aren't including the default manifest Reviewed-by: valeriep, mullan, katleman ! make/com/oracle/security/ucrypto/Makefile ! make/javax/crypto/Defs-jce.gmk ! make/sun/security/ec/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile + test/javax/crypto/sanity/CheckManifestForRelease.java From jonathan.gibbons at oracle.com Tue Oct 23 13:21:08 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 23 Oct 2012 20:21:08 +0000 Subject: hg: jdk8/tl/langtools: 8000741: refactor javadoc to use abstraction to handle relative paths Message-ID: <20121023202111.A030A474DA@hg.openjdk.java.net> Changeset: 78962d89f283 Author: jjg Date: 2012-10-23 13:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/78962d89f283 8000741: refactor javadoc to use abstraction to handle relative paths Reviewed-by: darcy ! src/share/classes/com/sun/javadoc/SerialFieldTag.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/PackageSummaryWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DirectoryManager.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPath.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPaths.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletConstants.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PackageListWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SourcePath.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/javadoc/SerializedForm.java ! test/com/sun/javadoc/testIndex/TestIndex.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/com/sun/javadoc/testPackagePage/TestPackagePage.java From jonathan.gibbons at oracle.com Tue Oct 23 14:00:44 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 23 Oct 2012 21:00:44 +0000 Subject: hg: jdk8/tl/langtools: 8000416: refactor javadoc to provide and use an abstraction for relative URIs Message-ID: <20121023210046.9501D474DB@hg.openjdk.java.net> Changeset: 4a1c57a1c410 Author: jjg Date: 2012-10-23 13:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4a1c57a1c410 8000416: refactor javadoc to provide and use an abstraction for relative URIs Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocLink.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPath.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java From bradford.wetmore at oracle.com Tue Oct 23 15:51:47 2012 From: bradford.wetmore at oracle.com (bradford.wetmore at oracle.com) Date: Tue, 23 Oct 2012 22:51:47 +0000 Subject: hg: jdk8/tl/jdk: 8001419: Build the JCE portion of JDK-8000970 Message-ID: <20121023225210.82459474E3@hg.openjdk.java.net> Changeset: 13b46e8eda33 Author: ohrstrom Date: 2012-10-23 15:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13b46e8eda33 8001419: Build the JCE portion of JDK-8000970 Summary: Original code done by Fredrik Ohrstrom, separated/pushed by wetmore Reviewed-by: wetmore ! src/share/classes/com/sun/crypto/provider/KeyProtector.java + src/share/classes/com/sun/crypto/provider/SealedObjectForKeyProtector.java From yumin.qi at oracle.com Tue Oct 23 17:04:24 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Tue, 23 Oct 2012 17:04:24 -0700 Subject: RFR: 6830717: replay of compilations would help with debugging In-Reply-To: <73AAAA90-0AFC-4F91-9BBF-A71BC3924735@oracle.com> References: <502039BE.6090108@oracle.com> <73AAAA90-0AFC-4F91-9BBF-A71BC3924735@oracle.com> Message-ID: <50873088.1080904@oracle.com> Hi, Chris and all After permgen removal integration, the previous webrev (see http://cr.openjdk.java.net/~minqi/6830717) need changes according to metadata changes. Thanks for your comments http://cr.openjdk.java.net/~minqi/6830717.01 Thanks Yumin On 8/13/2012 5:02 PM, Christian Thalinger wrote: > On Aug 6, 2012, at 2:40 PM, yumin.qi at oracle.com wrote: > >> Hi, >> >> Please give your comments of the changes about >> 6830717: replay of compilations would help with debugging. >> http://monaco.sfbay.sun.com/detail.jsf?cr=6830717 >> >> Sometime jvm crashes in the process of compilation or in compiled method. To reproduce the compilation process in debug JVM is helpful for quickly identifying root cause. >> To do recompilation, we collect data by using of SA (Serviceability Agent) to extract application and system class data from core file. Those information includes nmethod, methodOop, methodDataOop, instanceKlass and corresponding ci counterparts. >> With reconfiguring similar (not exactly same) compiling environment as in the core file, try to compile again the failed java methods. >> >> contributed by Tom R (never). webrev: >> >> http://cr.openjdk.java.net/~minqi/6830717/ > src/share/vm/ci/ciReplay.cpp: > > 603 if (strcmp(field_signature, "[B") == 0) { > 604 oop value = oopFactory::new_byteArray(length, CHECK); > 605 java_mirror->obj_field_put(fd.offset(), value); > 606 } else if (strcmp(field_signature, "[Z") == 0) { > 607 oop value = oopFactory::new_boolArray(length, CHECK); > 608 java_mirror->obj_field_put(fd.offset(), value); > 609 } else if (strcmp(field_signature, "[C") == 0) { > 610 oop value = oopFactory::new_charArray(length, CHECK); > 611 java_mirror->obj_field_put(fd.offset(), value); > 612 } else if (strcmp(field_signature, "[S") == 0) { > 613 oop value = oopFactory::new_shortArray(length, CHECK); > 614 java_mirror->obj_field_put(fd.offset(), value); > 615 } else if (strcmp(field_signature, "[F") == 0) { > 616 oop value = oopFactory::new_singleArray(length, CHECK); > 617 java_mirror->obj_field_put(fd.offset(), value); > 618 } else if (strcmp(field_signature, "[D") == 0) { > 619 oop value = oopFactory::new_doubleArray(length, CHECK); > 620 java_mirror->obj_field_put(fd.offset(), value); > 621 } else if (strcmp(field_signature, "[I") == 0) { > 622 oop value = oopFactory::new_intArray(length, CHECK); > 623 java_mirror->obj_field_put(fd.offset(), value); > 624 } else if (strcmp(field_signature, "[J") == 0) { > 625 oop value = oopFactory::new_longArray(length, CHECK); > 626 java_mirror->obj_field_put(fd.offset(), value); > 627 } else if (field_signature[0] == '['&& field_signature[1] == 'L') { > > Can't we switch on the second character? And move this call: > > 630 java_mirror->obj_field_put(fd.offset(), value); > > out of the switch? > > 637 if (strcmp(field_signature, "I") == 0) { > 638 int value = atoi(string_value); > 639 java_mirror->int_field_put(fd.offset(), value); > 640 } else if (strcmp(field_signature, "B") == 0) { > 641 int value = atoi(string_value); > 642 java_mirror->byte_field_put(fd.offset(), value); > 643 } else if (strcmp(field_signature, "C") == 0) { > 644 int value = atoi(string_value); > 645 java_mirror->char_field_put(fd.offset(), value); > 646 } else if (strcmp(field_signature, "S") == 0) { > 647 int value = atoi(string_value); > 648 java_mirror->short_field_put(fd.offset(), value); > 649 } else if (strcmp(field_signature, "Z") == 0) { > 650 int value = atol(string_value); > 651 java_mirror->bool_field_put(fd.offset(), value); > 652 } else if (strcmp(field_signature, "J") == 0) { > 653 jlong value; > 654 if (sscanf(string_value, INT64_FORMAT,&value) != 1) { > 655 fprintf(stderr, "Error parsing long: %s\n", string_value); > 656 return; > 657 } > 658 java_mirror->long_field_put(fd.offset(), value); > 659 } else if (strcmp(field_signature, "F") == 0) { > 660 float value = atof(string_value); > 661 java_mirror->float_field_put(fd.offset(), value); > 662 } else if (strcmp(field_signature, "D") == 0) { > 663 double value = atof(string_value); > 664 java_mirror->double_field_put(fd.offset(), value); > 665 } else if (strcmp(field_signature, "Ljava/lang/String;") == 0) { > 666 Handle value = java_lang_String::create_from_str(string_value, CHECK); > 667 java_mirror->obj_field_put(fd.offset(), value()); > 668 } else if (field_signature[0] == 'L') { > > Same here (not the put though)? > > Otherwise it looks good. > > -- Chris > >> Thanks >> Yumin From jaroslav.bachorik at oracle.com Wed Oct 24 06:45:26 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 24 Oct 2012 15:45:26 +0200 Subject: [PATCH] JDK-7009998: JMX synchronization during connection restart is faulty Message-ID: <5087F0F6.40902@oracle.com> I am looking for a review and patch sponsor. Webrev available at http://cr.openjdk.java.net/~jbachorik/JDK-7009998/webrev.00 The issue is about a possible race condition in the ClientCommunicatorAdmin when the reconnection process may be initiated by more than one thread (eg. 3). The main reason is that the re-connection routine logic is split into two synchronized blocks and it relies on the state staying consistent when transiting from the one synchronized block to the other. The race condition is described by the reporter as: "In reading the code there is a scenario where the synchronization does the wrong thing if 3 threads attempt to go through the code at the same time. Consider the code in com.sun.jmx.remote.internal.ClientCommunicatorAdmin.restart, the first thread will set the state to RE_CONNECTING and then leave the sychronization block, the second thread will find the state to be RE_CONNECTING and wait on the lock. When thread 1 finishes and sets the state to CONNECTED, then thread 2 can leave the synchronization block - but fails to set the state to RE_CONNECTING because that code is incorrectly in the else branch. Thus thread 2 starts the reconnecting and thread 3 wakes to find the state not RE_CONNECTING so it believes it can safely start the reconnect and it also starts reconnecting. The bad mode is discovered in the preReconnection method." The fix is adding a return statement at the end of the first synchronized block in case when the admin has been successfully re-connected by the other thread. Test in "test/com/sun/jmx/remote/CCAdminReconnectTest.java" tests the fix. Changes in "make/netbeans/jmx/build.properties" are there for the NetBeans project to recognize the newly added test. Thanks, -JB- From jaroslav.bachorik at oracle.com Wed Oct 24 06:50:28 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 24 Oct 2012 15:50:28 +0200 Subject: [PATCH] JDK-6976971: TEST: javax/management/remote/mandatory/URLTest.java should be re-integrated Message-ID: <5087F224.5010603@oracle.com> I am looking for review and sponsor. Webrev is available at http://cr.openjdk.java.net/~jbachorik/JDK-6976971/webrev.00 This is a simple fix - just adding back the test that used to fail due to changes in URI spec. The changes were rolled back before mustang and the test has no reason to fail. Thanks, -JB- From jaroslav.bachorik at oracle.com Wed Oct 24 07:03:27 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 24 Oct 2012 16:03:27 +0200 Subject: [PATCH] JDK-6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure Message-ID: <5087F52F.8070809@oracle.com> I am looking for review and a sponsor. Webrev available at http://cr.openjdk.java.net/~jbachorik/JDK-6937053/webrev.00/ The RMI marshalling process may throw java.rmi.UnmarshallException eg. in cases of incompatible changes in enums. The bad thing is that ClientNotifForwarder chooses to silently die instead of reporting the problem. The fix consists of adding support for handling java.rmi.UnmarshallException the same way as java.io.NotSerializableException and appropriate changes in the javadoc. Thanks, -JB- From jaroslav.bachorik at oracle.com Wed Oct 24 07:09:58 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 24 Oct 2012 16:09:58 +0200 Subject: [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject Message-ID: <5087F6B6.3050708@oracle.com> I am looking for review and a sponsor. Webrev is available at http://cr.openjdk.java.net/~jbachorik/JDK-6783290/webrev.01/ The serialization of javax.management.MBeanInfo and javax.management.MBeanFeatureInfo instances is asymmetrical in cases with no attached descriptor. The descriptor is serialized as an empty array but when deserializing the descriptor is not read back at all. Currently for RMI this does not pose any problem but the specification does not explicitly allow this kind of behaviour and it may cause troubles eventually. The patch just reads back the empty array to keep the serialization/deserialization symmetric. Thanks, -JB- From jaroslav.bachorik at oracle.com Wed Oct 24 07:15:34 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 24 Oct 2012 16:15:34 +0200 Subject: [PATCH] JDK-6705499: Bad JMXConnectorProvider class name prevents all connections - even with standard RMI connector Message-ID: <5087F806.40408@oracle.com> I am looking for review and a sponsor. Webrev is available at http://cr.openjdk.java.net/~jbachorik/JDK-6705499/webrev.00/ The issue is caused by the way the java.util.ServiceLoader treats the service registration with incorrect class names. Such a service registration causes java.util.ServiceConfigurationError to be thrown and the JMXConnector(Server)Factory is not ready for this. Thanks to the exception all the other, potentially valid, service registrations are ignored. The patch makes JMXConnector(Server)Factory class ready for java.util.ServiceConfigurationError and when such an exception is caught the factory just proceeds to the next registration. If the only available registration causes the exception it will be rethrown at the end. Thanks, -JB- From jaroslav.bachorik at oracle.com Wed Oct 24 07:17:16 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 24 Oct 2012 16:17:16 +0200 Subject: [PATCH] JDK-6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure In-Reply-To: <5087F52F.8070809@oracle.com> References: <5087F52F.8070809@oracle.com> Message-ID: <5087F86C.4020401@oracle.com> Updated webrev at http://cr.openjdk.java.net/~jbachorik/JDK-6937053/webrev.01/ - removed a dangling debug output. -JB- On 10/24/2012 04:03 PM, Jaroslav Bachorik wrote: > I am looking for review and a sponsor. > > Webrev available at > http://cr.openjdk.java.net/~jbachorik/JDK-6937053/webrev.00/ > > The RMI marshalling process may throw java.rmi.UnmarshallException eg. > in cases of incompatible changes in enums. The bad thing is that > ClientNotifForwarder chooses to silently die instead of reporting the > problem. > > The fix consists of adding support for handling > java.rmi.UnmarshallException the same way as > java.io.NotSerializableException and appropriate changes in the javadoc. > > Thanks, > > -JB- > From Alan.Bateman at oracle.com Wed Oct 24 07:28:17 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 24 Oct 2012 15:28:17 +0100 Subject: jmx-dev [PATCH] JDK-6705499: Bad JMXConnectorProvider class name prevents all connections - even with standard RMI connector In-Reply-To: <5087F806.40408@oracle.com> References: <5087F806.40408@oracle.com> Message-ID: <5087FB01.6010701@oracle.com> On 24/10/2012 15:15, Jaroslav Bachorik wrote: > I am looking for review and a sponsor. > > Webrev is available at > http://cr.openjdk.java.net/~jbachorik/JDK-6705499/webrev.00/ > > The issue is caused by the way the java.util.ServiceLoader treats the > service registration with incorrect class names. Such a service > registration causes java.util.ServiceConfigurationError to be thrown and > the JMXConnector(Server)Factory is not ready for this. Thanks to the > exception all the other, potentially valid, service registrations are > ignored. > > The patch makes JMXConnector(Server)Factory class ready for > java.util.ServiceConfigurationError and when such an exception is caught > the factory just proceeds to the next registration. If the only > available registration causes the exception it will be rethrown at the end. > > Thanks, > > -JB- I'm not so sure this is the right thing to do. When SCE is thrown then there is no guarantee that you can continue and there isn't enough information in the error to know whether it makes sense to attempt to continue or not. We have this same issue in many areas of the platform and I think it requires future work in ServiceLoader to help users of the API decide whether to continue or not. Once we move to modules then many of the reasons for SCE will go away because the list of service provider is precomputed so there is no scanning of class paths or parsing of configuration files at runtime. So if this one is not urgent they it may be something to come back to again in the future. -Alan. From Alan.Bateman at oracle.com Wed Oct 24 07:29:20 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 24 Oct 2012 15:29:20 +0100 Subject: jmx-dev [PATCH] JDK-6976971: TEST: javax/management/remote/mandatory/URLTest.java should be re-integrated In-Reply-To: <5087F224.5010603@oracle.com> References: <5087F224.5010603@oracle.com> Message-ID: <5087FB40.9040905@oracle.com> On 24/10/2012 14:50, Jaroslav Bachorik wrote: > I am looking for review and sponsor. > > Webrev is available at > http://cr.openjdk.java.net/~jbachorik/JDK-6976971/webrev.00 > > This is a simple fix - just adding back the test that used to fail due > to changes in URI spec. The changes were rolled back before mustang and > the test has no reason to fail. > > Thanks, > > -JB- This looks fine to me, I guess it was just missed when the URI work was rolled back. -Alan From xuelei.fan at oracle.com Wed Oct 24 08:26:28 2012 From: xuelei.fan at oracle.com (xuelei.fan at oracle.com) Date: Wed, 24 Oct 2012 15:26:28 +0000 Subject: hg: jdk8/tl/jdk: 8001466: Nightly regression test failure of SSLSocketSNISensitive.java Message-ID: <20121024152727.6057F474FE@hg.openjdk.java.net> Changeset: e782f3c383fe Author: xuelei Date: 2012-10-24 08:25 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e782f3c383fe 8001466: Nightly regression test failure of SSLSocketSNISensitive.java Reviewed-by: weijun ! test/sun/security/ssl/javax/net/ssl/ServerName/SSLSocketSNISensitive.java From eamonn at mcmanus.net Wed Oct 24 08:43:22 2012 From: eamonn at mcmanus.net (Eamonn McManus) Date: Wed, 24 Oct 2012 08:43:22 -0700 Subject: [PATCH] JDK-6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure In-Reply-To: <5087F86C.4020401@oracle.com> References: <5087F52F.8070809@oracle.com> <5087F86C.4020401@oracle.com> Message-ID: The fix looks good, but I would adjust a couple of small things. First, you can improve the existing and new code with multi-catch. Second, the message in the if (notFoundCount > 0) block should be adjusted to take into account the new cases. Finally, hardwiring port 12345 into the test makes it a bit fragile. It would be better for the server to listen on any available port and (for example) write which port it is, or what its JMXServiceURL is, on its stdout. The shell script can then read that and launch the client with it. That would also get rid of the arbitrary sleep 3. ?amonn 2012/10/24 Jaroslav Bachorik > Updated webrev at > http://cr.openjdk.java.net/~jbachorik/JDK-6937053/webrev.01/ - removed a > dangling debug output. > > -JB- > > On 10/24/2012 04:03 PM, Jaroslav Bachorik wrote: > > I am looking for review and a sponsor. > > > > Webrev available at > > http://cr.openjdk.java.net/~jbachorik/JDK-6937053/webrev.00/ > > > > The RMI marshalling process may throw java.rmi.UnmarshallException eg. > > in cases of incompatible changes in enums. The bad thing is that > > ClientNotifForwarder chooses to silently die instead of reporting the > > problem. > > > > The fix consists of adding support for handling > > java.rmi.UnmarshallException the same way as > > java.io.NotSerializableException and appropriate changes in the javadoc. > > > > Thanks, > > > > -JB- > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121024/c85f2448/attachment.html From eamonn at mcmanus.net Wed Oct 24 08:49:32 2012 From: eamonn at mcmanus.net (Eamonn McManus) Date: Wed, 24 Oct 2012 08:49:32 -0700 Subject: [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject In-Reply-To: <5087F6B6.3050708@oracle.com> References: <5087F6B6.3050708@oracle.com> Message-ID: This is already Reviewed-by: emcmanus, but I'm afraid I can't sponsor it. ?amonn 2012/10/24 Jaroslav Bachorik > I am looking for review and a sponsor. > > Webrev is available at > http://cr.openjdk.java.net/~jbachorik/JDK-6783290/webrev.01/ > > The serialization of javax.management.MBeanInfo and > javax.management.MBeanFeatureInfo instances is asymmetrical in cases > with no attached descriptor. The descriptor is serialized as an empty > array but when deserializing the descriptor is not read back at all. > Currently for RMI this does not pose any problem but the specification > does not explicitly allow this kind of behaviour and it may cause > troubles eventually. > > The patch just reads back the empty array to keep the > serialization/deserialization symmetric. > > Thanks, > > -JB- > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121024/fe8a9bbe/attachment-0001.html From yumin.qi at oracle.com Wed Oct 24 10:01:14 2012 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Wed, 24 Oct 2012 10:01:14 -0700 Subject: RFR: 8000489: older builds of hsdis don't work anymore after 6879063 Message-ID: <50881EDA.8020100@oracle.com> Hi, all Can I have your codereview of 8000489: older builds of hsdis don't work anymore after 6879063 It caused old build broke the disassembler. Webrev: http://cr.openjdk.java.net/~minqi/8000489 Thanks Yumin From Dmitry.Samersoff at oracle.com Wed Oct 24 10:03:34 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Wed, 24 Oct 2012 21:03:34 +0400 Subject: [PATCH] JDK-6783290: MBeanInfo/MBeanFeatureInfo has inconsistent readObject/writeObject In-Reply-To: References: <5087F6B6.3050708@oracle.com> Message-ID: <50881F66.1040409@oracle.com> Jaroslav, I'll sponsor it. Just ping me when the fix passed all reviews. -Dmitry On 2012-10-24 19:49, Eamonn McManus wrote: > This is already Reviewed-by: emcmanus, but I'm afraid I can't sponsor it. > > ?amonn > > > 2012/10/24 Jaroslav Bachorik > > > I am looking for review and a sponsor. > > Webrev is available at > http://cr.openjdk.java.net/~jbachorik/JDK-6783290/webrev.01/ > > The serialization of javax.management.MBeanInfo and > javax.management.MBeanFeatureInfo instances is asymmetrical in cases > with no attached descriptor. The descriptor is serialized as an empty > array but when deserializing the descriptor is not read back at all. > Currently for RMI this does not pose any problem but the specification > does not explicitly allow this kind of behaviour and it may cause > troubles eventually. > > The patch just reads back the empty array to keep the > serialization/deserialization symmetric. > > Thanks, > > -JB- > > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From serguei.spitsyn at oracle.com Wed Oct 24 11:14:53 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 24 Oct 2012 11:14:53 -0700 Subject: review request: 6533010 SPEC: A few broken links in jvmti.html In-Reply-To: <5085ABB5.3040801@oracle.com> References: <5085ABB5.3040801@oracle.com> Message-ID: <5088301D.7090403@oracle.com> Hello, Please, review the fix for (preliminary reviewed by james.holmlund at oracle.com) : http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6533010 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc Generated jvmti.html: http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2012/hotspot/6533010-JVMTI-doc/jvmti.html Summary: The fix is to remove the errors in generated jvmti.html reported by the LinkCheck tool: http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ I verified the fix by looking into the generated jvmti.html: http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/jvmti.html One more comment about the JVMTI version and the related changes: + + Fixed the "HTTP" and "Missing Anchor" errors reported by the LinkCheck tool. + diff -r 48a75d2640a5 src/share/vm/prims/jvmtiEnvBase.hpp --- a/src/share/vm/prims/jvmtiEnvBase.hpp Thu Oct 11 14:27:54 2012 -0400 +++ b/src/share/vm/prims/jvmtiEnvBase.hpp Mon Oct 22 13:07:54 2012 -0700 @@ -67,7 +67,7 @@ enum { JDK15_JVMTI_VERSION = JVMTI_VERSION_1_0 + 33, /* version: 1.0.33 */ JDK16_JVMTI_VERSION = JVMTI_VERSION_1_1 + 102, /* version: 1.1.102 */ - JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 1 /* version: 1.2.1 */ + JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 2 /* version: 1.2.2 */ }; I've decided to fix just micro version, so new version is 1.2.2 that matches JDK 7. It is because the fix is for both JFK 7 and 8 and it does not add any new features related to JDK 8. The enum in the jvmtiEnvBase.hpp is not used anywhere in hotspot code. It is just to keep track of JVMTI versions matching different versions of JDK. Thanks, Serguei -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121024/9561ccb5/attachment.html From rednaxelafx at gmail.com Wed Oct 24 12:24:54 2012 From: rednaxelafx at gmail.com (Krystal Mok) Date: Thu, 25 Oct 2012 03:24:54 +0800 Subject: RFR: 8000489: older builds of hsdis don't work anymore after 6879063 In-Reply-To: <50881EDA.8020100@oracle.com> References: <50881EDA.8020100@oracle.com> Message-ID: Hi Yumin, minor typos: s/instrurctions/instructions/ By the way, I tried to use a build of hsdis plugin after 6879063 in an earlier JDK build (e.g. JDK8b59) and it was working strangely. A rough look at the output looks like it's missing some newlines, I didn't go into the details. Could you please check if this fix makes the hsdis plugin work properly on earlier JDK builds as well? Thanks, Kris On Thu, Oct 25, 2012 at 1:01 AM, wrote: > Hi, all > > Can I have your codereview of 8000489: older builds of hsdis don't work > anymore after 6879063 > It caused old build broke the disassembler. > > Webrev: http://cr.openjdk.java.net/~**minqi/8000489 > > Thanks > Yumin > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121025/68b779df/attachment.html From alan.bateman at oracle.com Wed Oct 24 12:43:53 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Wed, 24 Oct 2012 19:43:53 +0000 Subject: hg: jdk8/tl/jdk: 6976971: TEST: javax/management/remote/mandatory/URLTest.java should be re-integrated Message-ID: <20121024194415.B51FD4750C@hg.openjdk.java.net> Changeset: 8e8fcd44b963 Author: jbachorik Date: 2012-10-24 20:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e8fcd44b963 6976971: TEST: javax/management/remote/mandatory/URLTest.java should be re-integrated Reviewed-by: alanb ! test/javax/management/remote/mandatory/URLTest.java From yumin.qi at oracle.com Wed Oct 24 14:15:35 2012 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Wed, 24 Oct 2012 14:15:35 -0700 Subject: RFR: 8000489: older builds of hsdis don't work anymore after 6879063 In-Reply-To: References: <50881EDA.8020100@oracle.com> Message-ID: <50885A77.5030800@oracle.com> Krystal, Thanks. Updated in same webrev. I checked b10, the output looks OK /Yumin On 10/24/2012 12:24 PM, Krystal Mok wrote: > Hi Yumin, > > minor typos: > s/instrurctions/instructions/ > > By the way, I tried to use a build of hsdis plugin after 6879063 in an > earlier JDK build (e.g. JDK8b59) and it was working strangely. A rough > look at the output looks like it's missing some newlines, I didn't go > into the details. Could you please check if this fix makes the hsdis > plugin work properly on earlier JDK builds as well? > > Thanks, > Kris > > On Thu, Oct 25, 2012 at 1:01 AM, > wrote: > > Hi, all > > Can I have your codereview of 8000489: older builds of hsdis > don't work anymore after 6879063 > It caused old build broke the disassembler. > > Webrev: http://cr.openjdk.java.net/~minqi/8000489 > > > Thanks > Yumin > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121024/85f6844f/attachment.html From serguei.spitsyn at oracle.com Wed Oct 24 14:50:21 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 24 Oct 2012 14:50:21 -0700 Subject: RFR: 8000489: older builds of hsdis don't work anymore after 6879063 In-Reply-To: <50885A77.5030800@oracle.com> References: <50881EDA.8020100@oracle.com> <50885A77.5030800@oracle.com> Message-ID: <5088629D.70303@oracle.com> || Yumin, *src/share/tools/hsdis/hsdis.h: * A typo in the comment: 62 /* This is the compatability interface for older version of hotspot */ => 62 /* This is the compatibility interface for older versions of hotspot */ ||*|src|/share/tools/hsdis/hsdis-demo.c:* Would it make sense to change this to avoid using literal name? : 219 printf("Decoding from %p to %p...with decode_instructions_virtual\n", from, to); => 219 printf("Decoding from %p to %p...with %s\n", from, to,DECODE_INSTRUCTIONS_NAME); and 238 printf("Decoding from %p to %p...with old decode_instructions\n", from, to); => 238 printf("Decoding from %p to %p...with old %s\n", from, to,DECODE_INSTRUCTIONS); The (raw && xml) is a special case of the (raw) so that the 4 lines: 225 if (raw && xml) { 226 res = (*decode_instructions_v)(from, to, (unsigned char*)from, to - from, simple_handle_event, stdout, NULL, stdout, options); 227 } else if (raw) { 228 res = (*decode_instructions_v)(from, to, (unsigned char*)from, to - from, simple_handle_event, stdout, NULL, stdout, options); can be replaced with just 2 lines: 225 if (raw) { 226 res = (*decode_instructions_v)(from, to, (unsigned char*)from, to - from, simple_handle_event, stdout, NULL, stdout, options); Thanks, Serguei Thanks, Serguei On 10/24/12 2:15 PM, yumin.qi at oracle.com wrote: > Krystal, > > Thanks. Updated in same webrev. > I checked b10, the output looks OK > > /Yumin > > On 10/24/2012 12:24 PM, Krystal Mok wrote: >> Hi Yumin, >> >> minor typos: >> s/instrurctions/instructions/ >> >> By the way, I tried to use a build of hsdis plugin after 6879063 in >> an earlier JDK build (e.g. JDK8b59) and it was working strangely. A >> rough look at the output looks like it's missing some newlines, I >> didn't go into the details. Could you please check if this fix makes >> the hsdis plugin work properly on earlier JDK builds as well? >> >> Thanks, >> Kris >> >> On Thu, Oct 25, 2012 at 1:01 AM, > > wrote: >> >> Hi, all >> >> Can I have your codereview of 8000489: older builds of hsdis >> don't work anymore after 6879063 >> It caused old build broke the disassembler. >> >> Webrev: http://cr.openjdk.java.net/~minqi/8000489 >> >> >> Thanks >> Yumin >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121024/3ac82a1b/attachment.html From chris.hegarty at oracle.com Wed Oct 24 14:55:30 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Wed, 24 Oct 2012 21:55:30 +0000 Subject: hg: jdk8/tl/jdk: 8000203: File descriptor leak in src/solaris/native/java/net/net_util_md.c Message-ID: <20121024215551.B858247525@hg.openjdk.java.net> Changeset: 909676adaefd Author: chegar Date: 2012-10-24 21:20 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/909676adaefd 8000203: File descriptor leak in src/solaris/native/java/net/net_util_md.c Reviewed-by: dsamersoff, khazra, chegar Contributed-by: John Zavgren ! src/solaris/native/java/net/net_util_md.c From john.r.rose at oracle.com Wed Oct 24 15:27:16 2012 From: john.r.rose at oracle.com (John Rose) Date: Wed, 24 Oct 2012 15:27:16 -0700 Subject: RFR: 8000489: older builds of hsdis don't work anymore after 6879063 In-Reply-To: <50881EDA.8020100@oracle.com> References: <50881EDA.8020100@oracle.com> Message-ID: On Oct 24, 2012, at 10:01 AM, Yumin.Qi at oracle.com wrote: > Hi, all > > Can I have your codereview of 8000489: older builds of hsdis don't work anymore after 6879063 > It caused old build broke the disassembler. > > Webrev: http://cr.openjdk.java.net/~minqi/8000489 Shouldn't there be a corresponding change to disassembler.cpp? I didn't see it in the webrev. ? John From david.holmes at oracle.com Wed Oct 24 20:57:26 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 25 Oct 2012 13:57:26 +1000 Subject: review request: 6533010 SPEC: A few broken links in jvmti.html In-Reply-To: <5088301D.7090403@oracle.com> References: <5085ABB5.3040801@oracle.com> <5088301D.7090403@oracle.com> Message-ID: <5088B8A6.9050508@oracle.com> Serguei, Does the change to the micro version need to go through approval processes? That aside I don't quite understand how you can just bump the micro version for JDK7 when JDK 7 is already out there with a different micro version. The web version of the spec indicates it is 1.2.1 for JDK 7: http://docs.oracle.com/javase/7/docs/platform/jvmti/jvmti.html#ChangeHistory (Though the change history has not been updated since 2006 :( ) This addition seems unrelated to LinkCheck: + + + Holds a Java programming language char. + Unsigned 16 bits. + + Aside: it would be useful to see a blenderrev or specdiff version of the change to compare the before and after redndered html. David On 25/10/2012 4:14 AM, serguei.spitsyn at oracle.com wrote: > Hello, > > > Please, review the fix for (preliminary reviewed by > james.holmlund at oracle.com) : > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6533010 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc > > Generated jvmti.html: > http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2012/hotspot/6533010-JVMTI-doc/jvmti.html > > > Summary: > > The fix is to remove the errors in generated jvmti.html reported by the > LinkCheck tool: > http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ > > > I verified the fix by looking into the generated jvmti.html: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/jvmti.html > > > One more comment about the JVMTI version and the related changes: > > + > + Fixed the "HTTP" and "Missing Anchor" errors reported by the LinkCheck > tool. > + > > > > diff -r 48a75d2640a5 src/share/vm/prims/jvmtiEnvBase.hpp > --- a/src/share/vm/prims/jvmtiEnvBase.hpp Thu Oct 11 14:27:54 2012 -0400 > +++ b/src/share/vm/prims/jvmtiEnvBase.hpp Mon Oct 22 13:07:54 2012 -0700 > @@ -67,7 +67,7 @@ > enum { > JDK15_JVMTI_VERSION = JVMTI_VERSION_1_0 + 33, /* version: 1.0.33 */ > JDK16_JVMTI_VERSION = JVMTI_VERSION_1_1 + 102, /* version: 1.1.102 */ > - JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 1 /* version: 1.2.1 */ > + JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 2 /* version: 1.2.2 */ > }; > > I've decided to fix just micro version, so new version is 1.2.2 that > matches JDK 7. > It is because the fix is for both JFK 7 and 8 and it does not add any > new features related to JDK 8. > The enum in the jvmtiEnvBase.hpp is not used anywhere in hotspot code. > It is just to keep track of JVMTI versions matching different versions > of JDK. > > > Thanks, > Serguei > > > > From yumin.qi at oracle.com Wed Oct 24 21:19:06 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Wed, 24 Oct 2012 21:19:06 -0700 Subject: RFR: 8000489: older builds of hsdis don't work anymore after 6879063 In-Reply-To: <5088629D.70303@oracle.com> References: <50881EDA.8020100@oracle.com> <50885A77.5030800@oracle.com> <5088629D.70303@oracle.com> Message-ID: <5088BDBA.6060205@oracle.com> Thanks. Will update with that. Yumin On 10/24/2012 2:50 PM, serguei.spitsyn at oracle.com wrote: > > || Yumin, > > *src/share/tools/hsdis/hsdis.h: > * > > A typo in the comment: > > 62 /* This is the compatability interface for older version of hotspot */ > => > 62 /* This is the compatibility interface for older versions of hotspot */ > > ||*|src|/share/tools/hsdis/hsdis-demo.c:* > > Would it make sense to change this to avoid using literal name? : > > 219 printf("Decoding from %p to %p...with decode_instructions_virtual\n", from, to); > => > 219 printf("Decoding from %p to %p...with %s\n", from, to,DECODE_INSTRUCTIONS_NAME); > > and > > 238 printf("Decoding from %p to %p...with old decode_instructions\n", from, to); > => > 238 printf("Decoding from %p to %p...with old %s\n", from, to,DECODE_INSTRUCTIONS); > > The (raw&& xml) is a special case of the (raw) so that the 4 lines: > > 225 if (raw&& xml) { > 226 res = (*decode_instructions_v)(from, to, (unsigned char*)from, to - from, simple_handle_event, stdout, NULL, stdout, options); > 227 } else if (raw) { > 228 res = (*decode_instructions_v)(from, to, (unsigned char*)from, to - from, simple_handle_event, stdout, NULL, stdout, options); > can be replaced with just 2 lines: > 225 if (raw) { > 226 res = (*decode_instructions_v)(from, to, (unsigned char*)from, to - from, simple_handle_event, stdout, NULL, stdout, options); > > > Thanks, > Serguei > > > > > Thanks, > Serguei > > > On 10/24/12 2:15 PM, yumin.qi at oracle.com wrote: >> Krystal, >> >> Thanks. Updated in same webrev. >> I checked b10, the output looks OK >> >> /Yumin >> >> On 10/24/2012 12:24 PM, Krystal Mok wrote: >>> Hi Yumin, >>> >>> minor typos: >>> s/instrurctions/instructions/ >>> >>> By the way, I tried to use a build of hsdis plugin after 6879063 in >>> an earlier JDK build (e.g. JDK8b59) and it was working strangely. A >>> rough look at the output looks like it's missing some newlines, I >>> didn't go into the details. Could you please check if this fix makes >>> the hsdis plugin work properly on earlier JDK builds as well? >>> >>> Thanks, >>> Kris >>> >>> On Thu, Oct 25, 2012 at 1:01 AM, >> > wrote: >>> >>> Hi, all >>> >>> Can I have your codereview of 8000489: older builds of hsdis >>> don't work anymore after 6879063 >>> It caused old build broke the disassembler. >>> >>> Webrev: http://cr.openjdk.java.net/~minqi/8000489 >>> >>> >>> Thanks >>> Yumin >>> >>> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121024/7625959e/attachment.html From jaroslav.bachorik at oracle.com Thu Oct 25 03:58:51 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 25 Oct 2012 12:58:51 +0200 Subject: [PATCH] JDK-6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure In-Reply-To: References: <5087F52F.8070809@oracle.com> <5087F86C.4020401@oracle.com> Message-ID: <50891B6B.4010504@oracle.com> Thanks, addressing the comments ... On 10/24/2012 05:43 PM, Eamonn McManus wrote: > The fix looks good, but I would adjust a couple of small things. First, you > can improve the existing and new code with multi-catch. Second, the message > in the if (notFoundCount > 0) block should be adjusted to take into account I was not really sure about the wording of the message - I've added the part warning about incompatibility. But if you have something better in mind I would happily use it. > the new cases. Finally, hardwiring port 12345 into the test makes it a bit > fragile. It would be better for the server to listen on any available port > and (for example) write which port it is, or what its JMXServiceURL is, on > its stdout. The shell script can then read that and launch the client with > it. That would also get rid of the arbitrary sleep 3. Done and done. Webrev at http://cr.openjdk.java.net/~jbachorik/JDK-6937053/webrev.02/ -JB- > > ?amonn > > > 2012/10/24 Jaroslav Bachorik > >> Updated webrev at >> http://cr.openjdk.java.net/~jbachorik/JDK-6937053/webrev.01/ - removed a >> dangling debug output. >> >> -JB- >> >> On 10/24/2012 04:03 PM, Jaroslav Bachorik wrote: >>> I am looking for review and a sponsor. >>> >>> Webrev available at >>> http://cr.openjdk.java.net/~jbachorik/JDK-6937053/webrev.00/ >>> >>> The RMI marshalling process may throw java.rmi.UnmarshallException eg. >>> in cases of incompatible changes in enums. The bad thing is that >>> ClientNotifForwarder chooses to silently die instead of reporting the >>> problem. >>> >>> The fix consists of adding support for handling >>> java.rmi.UnmarshallException the same way as >>> java.io.NotSerializableException and appropriate changes in the javadoc. >>> >>> Thanks, >>> >>> -JB- >>> >> >> > From jaroslav.bachorik at oracle.com Thu Oct 25 04:55:47 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 25 Oct 2012 13:55:47 +0200 Subject: jmx-dev [PATCH] JDK-6705499: Bad JMXConnectorProvider class name prevents all connections - even with standard RMI connector In-Reply-To: <5087FB01.6010701@oracle.com> References: <5087F806.40408@oracle.com> <5087FB01.6010701@oracle.com> Message-ID: <508928C3.6000208@oracle.com> On 10/24/2012 04:28 PM, Alan Bateman wrote: > On 24/10/2012 15:15, Jaroslav Bachorik wrote: >> I am looking for review and a sponsor. >> >> Webrev is available at >> http://cr.openjdk.java.net/~jbachorik/JDK-6705499/webrev.00/ >> >> The issue is caused by the way the java.util.ServiceLoader treats the >> service registration with incorrect class names. Such a service >> registration causes java.util.ServiceConfigurationError to be thrown and >> the JMXConnector(Server)Factory is not ready for this. Thanks to the >> exception all the other, potentially valid, service registrations are >> ignored. >> >> The patch makes JMXConnector(Server)Factory class ready for >> java.util.ServiceConfigurationError and when such an exception is caught >> the factory just proceeds to the next registration. If the only >> available registration causes the exception it will be rethrown at the >> end. >> >> Thanks, >> >> -JB- > I'm not so sure this is the right thing to do. When SCE is thrown then > there is no guarantee that you can continue and there isn't enough > information in the error to know whether it makes sense to attempt to > continue or not. We have this same issue in many areas of the platform Shouldn't this be indicated by the "hasNext()" method of the iterator returned by ServiceLoader? I mean - whether you can continue enumerating the providers or not. I agree that the fact that SCE is an Error subclass alone makes catching and handling it rather dubious but it seems a bit harsh to throw a (supposedly) unrecoverable exception only because one entry in the service configuration file is invalid. > and I think it requires future work in ServiceLoader to help users of > the API decide whether to continue or not. Once we move to modules then Yes, a proper fix would be in the ServiceLoader but it will most probably involve API changes. Eg. instead of generating an Error a checked exception should be thrown indicating a problem with the particular service configuration line. > many of the reasons for SCE will go away because the list of service > provider is precomputed so there is no scanning of class paths or > parsing of configuration files at runtime. So if this one is not urgent > they it may be something to come back to again in the future. Unfortunately, it will take some time till we have modules :( Until then you can completely disable JMX subsystem simply by placing a poison jar on classpath (probably other ServiceLoder based services as well but this issue is about JMX). Even though the issue is P3 it has been there sitting unresolved for 4 years and keeping it for another 3 (till JDK9) would look quite strange, IMO. What about filing an issue for ServiceLoader (if there is none yet) and then pushing this workaround with comment that it should be revisited once the modules are in place? -JB- > > -Alan. > From eamonn at mcmanus.net Thu Oct 25 09:56:20 2012 From: eamonn at mcmanus.net (Eamonn McManus) Date: Thu, 25 Oct 2012 09:56:20 -0700 Subject: [PATCH] JDK-6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure In-Reply-To: <50891B6B.4010504@oracle.com> References: <5087F52F.8070809@oracle.com> <5087F86C.4020401@oracle.com> <50891B6B.4010504@oracle.com> Message-ID: Looks good. Reviewed-by: emcmanus ?amonn 2012/10/25 Jaroslav Bachorik > Thanks, addressing the comments ... > > On 10/24/2012 05:43 PM, Eamonn McManus wrote: > > The fix looks good, but I would adjust a couple of small things. First, > you > > can improve the existing and new code with multi-catch. Second, the > message > > in the if (notFoundCount > 0) block should be adjusted to take into > account > I was not really sure about the wording of the message - I've added the > part warning about incompatibility. But if you have something better in > mind I would happily use it. > > > the new cases. Finally, hardwiring port 12345 into the test makes it a > bit > > fragile. It would be better for the server to listen on any available > port > > and (for example) write which port it is, or what its JMXServiceURL is, > on > > its stdout. The shell script can then read that and launch the client > with > > it. That would also get rid of the arbitrary sleep 3. > Done and done. > > Webrev at http://cr.openjdk.java.net/~jbachorik/JDK-6937053/webrev.02/ > > -JB- > > > > > ?amonn > > > > > > 2012/10/24 Jaroslav Bachorik > > > >> Updated webrev at > >> http://cr.openjdk.java.net/~jbachorik/JDK-6937053/webrev.01/ - removed > a > >> dangling debug output. > >> > >> -JB- > >> > >> On 10/24/2012 04:03 PM, Jaroslav Bachorik wrote: > >>> I am looking for review and a sponsor. > >>> > >>> Webrev available at > >>> http://cr.openjdk.java.net/~jbachorik/JDK-6937053/webrev.00/ > >>> > >>> The RMI marshalling process may throw java.rmi.UnmarshallException eg. > >>> in cases of incompatible changes in enums. The bad thing is that > >>> ClientNotifForwarder chooses to silently die instead of reporting the > >>> problem. > >>> > >>> The fix consists of adding support for handling > >>> java.rmi.UnmarshallException the same way as > >>> java.io.NotSerializableException and appropriate changes in the > javadoc. > >>> > >>> Thanks, > >>> > >>> -JB- > >>> > >> > >> > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121025/efece0d6/attachment.html From eamonn at mcmanus.net Thu Oct 25 10:13:00 2012 From: eamonn at mcmanus.net (Eamonn McManus) Date: Thu, 25 Oct 2012 10:13:00 -0700 Subject: [PATCH] JDK-6937053: RMI unmarshalling errors in ClientNotifForwarder cause silent failure In-Reply-To: <50891B6B.4010504@oracle.com> References: <5087F52F.8070809@oracle.com> <5087F86C.4020401@oracle.com> <50891B6B.4010504@oracle.com> Message-ID: Looks good. Reviewed-by: emcmanus ?amonn 2012/10/25 Jaroslav Bachorik > Thanks, addressing the comments ... > > On 10/24/2012 05:43 PM, Eamonn McManus wrote: > > The fix looks good, but I would adjust a couple of small things. First, > you > > can improve the existing and new code with multi-catch. Second, the > message > > in the if (notFoundCount > 0) block should be adjusted to take into > account > I was not really sure about the wording of the message - I've added the > part warning about incompatibility. But if you have something better in > mind I would happily use it. > > > the new cases. Finally, hardwiring port 12345 into the test makes it a > bit > > fragile. It would be better for the server to listen on any available > port > > and (for example) write which port it is, or what its JMXServiceURL is, > on > > its stdout. The shell script can then read that and launch the client > with > > it. That would also get rid of the arbitrary sleep 3. > Done and done. > > Webrev at http://cr.openjdk.java.net/~jbachorik/JDK-6937053/webrev.02/ > > -JB- > > > > > ?amonn > > > > > > 2012/10/24 Jaroslav Bachorik > > > >> Updated webrev at > >> http://cr.openjdk.java.net/~jbachorik/JDK-6937053/webrev.01/ - removed > a > >> dangling debug output. > >> > >> -JB- > >> > >> On 10/24/2012 04:03 PM, Jaroslav Bachorik wrote: > >>> I am looking for review and a sponsor. > >>> > >>> Webrev available at > >>> http://cr.openjdk.java.net/~jbachorik/JDK-6937053/webrev.00/ > >>> > >>> The RMI marshalling process may throw java.rmi.UnmarshallException eg. > >>> in cases of incompatible changes in enums. The bad thing is that > >>> ClientNotifForwarder chooses to silently die instead of reporting the > >>> problem. > >>> > >>> The fix consists of adding support for handling > >>> java.rmi.UnmarshallException the same way as > >>> java.io.NotSerializableException and appropriate changes in the > javadoc. > >>> > >>> Thanks, > >>> > >>> -JB- > >>> > >> > >> > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121025/36a7e6fe/attachment-0001.html From jonathan.gibbons at oracle.com Thu Oct 25 11:10:26 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 25 Oct 2012 18:10:26 +0000 Subject: hg: jdk8/tl/langtools: 7200915: convert TypeTags from a series of small ints to an enum Message-ID: <20121025181031.6274847544@hg.openjdk.java.net> Changeset: c002fdee76fd Author: jjg Date: 2012-10-25 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c002fdee76fd 7200915: convert TypeTags from a series of small ints to an enum Reviewed-by: jjg, mcimadamore Contributed-by: vicente.romero at oracle.com ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Kinds.java ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Type.java + src/share/classes/com/sun/tools/javac/code/TypeTag.java - src/share/classes/com/sun/tools/javac/code/TypeTags.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/ConstFold.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/UninitializedType.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/model/JavacElements.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/util/Constants.java ! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/MethodDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterizedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! test/tools/javac/6889255/T6889255.java ! test/tools/javac/tree/MakeLiteralTest.java From yumin.qi at oracle.com Thu Oct 25 13:16:09 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Thu, 25 Oct 2012 13:16:09 -0700 Subject: RFR: 8000489: older builds of hsdis don't work anymore after 6879063 In-Reply-To: References: <50881EDA.8020100@oracle.com> Message-ID: <50899E09.3050905@oracle.com> John, and all I updated the webrev. I also made changes to make 'nice new line" to be a argument of decode_instructions_virtual so it can be changed instead of hard coded as 'false'. To John's question, it doesn't require changes to disassembler.cpp: new version ---> decode_instructions_virtual old version ---> decode_instructions ---> decode_instructions_virtual tested with b01 (JDK8) with new hsdis-i386.so. same location: http://cr.openjdk.java.net/~minqi/8000489 Thanks Yumin On 10/24/2012 3:27 PM, John Rose wrote: > On Oct 24, 2012, at 10:01 AM, Yumin.Qi at oracle.com wrote: > >> Hi, all >> >> Can I have your codereview of 8000489: older builds of hsdis don't work anymore after 6879063 >> It caused old build broke the disassembler. >> >> Webrev: http://cr.openjdk.java.net/~minqi/8000489 > Shouldn't there be a corresponding change to disassembler.cpp? I didn't see it in the webrev. ? John From jonathan.gibbons at oracle.com Thu Oct 25 13:33:38 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Thu, 25 Oct 2012 20:33:38 +0000 Subject: hg: jdk8/tl/langtools: 6725230: Java Compilation with Jsr199 ignores Class-Path in manifest Message-ID: <20121025203343.BC83B47548@hg.openjdk.java.net> Changeset: ea2616a6bd01 Author: jjg Date: 2012-10-25 13:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ea2616a6bd01 6725230: Java Compilation with Jsr199 ignores Class-Path in manifest Reviewed-by: jjg, mcimadamore Contributed-by: vicente.romero at oracle.com ! src/share/classes/com/sun/tools/javac/file/Locations.java + test/tools/javac/Paths/TestCompileJARInClassPath.java From mandy.chung at oracle.com Thu Oct 25 15:11:57 2012 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Thu, 25 Oct 2012 22:11:57 +0000 Subject: hg: jdk8/tl/jdk: 7159567: inconsistent configuration of MemoryHandler Message-ID: <20121025221209.B2FA44754A@hg.openjdk.java.net> Changeset: 37a4b4892e8e Author: jgish Date: 2012-10-25 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/37a4b4892e8e 7159567: inconsistent configuration of MemoryHandler Reviewed-by: mchung, alanb ! src/share/classes/java/util/logging/ConsoleHandler.java ! src/share/classes/java/util/logging/FileHandler.java ! src/share/classes/java/util/logging/MemoryHandler.java ! src/share/classes/java/util/logging/SocketHandler.java ! src/share/classes/java/util/logging/StreamHandler.java + test/java/util/logging/MemoryHandlerTest.java + test/java/util/logging/MemoryHandlerTest.props From mandy.chung at oracle.com Thu Oct 25 15:43:13 2012 From: mandy.chung at oracle.com (mandy.chung at oracle.com) Date: Thu, 25 Oct 2012 22:43:13 +0000 Subject: hg: jdk8/tl/jdk: 8001565: (fs) Typo Path.endsWith(String) javadoc Message-ID: <20121025224337.093FF47555@hg.openjdk.java.net> Changeset: 27677928a937 Author: dxu Date: 2012-10-25 15:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/27677928a937 8001565: (fs) Typo Path.endsWith(String) javadoc Reviewed-by: mchung, jgish, lancea ! src/share/classes/java/nio/file/Path.java From robert.field at oracle.com Thu Oct 25 17:34:52 2012 From: robert.field at oracle.com (robert.field at oracle.com) Date: Fri, 26 Oct 2012 00:34:52 +0000 Subject: hg: jdk8/tl/jdk: 8000806: Implement runtime lambda metafactory Message-ID: <20121026003504.1750D4755C@hg.openjdk.java.net> Changeset: 6302932b7380 Author: rfield Date: 2012-10-25 17:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6302932b7380 8000806: Implement runtime lambda metafactory Summary: Implement lambda invokedynamic bootstrap by generating at runtime an inner class that implements the functional interface Reviewed-by: twisti + src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java + src/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java + src/share/classes/java/lang/invoke/LambdaConversionException.java + src/share/classes/java/lang/invoke/LambdaMetafactory.java + src/share/classes/java/lang/invoke/MagicLambdaImpl.java + src/share/classes/java/lang/invoke/TypeConvertingMethodAdapter.java From coleen.phillimore at oracle.com Thu Oct 25 20:22:36 2012 From: coleen.phillimore at oracle.com (coleen.phillimore at oracle.com) Date: Fri, 26 Oct 2012 03:22:36 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20121026032246.DB8B64755F@hg.openjdk.java.net> Changeset: 5ec0c42da025 Author: coleenp Date: 2012-10-25 16:33 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/5ec0c42da025 7188234: Deprecate VM command line options Summary: Remove support for the UseVectoredExceptions flag Reviewed-by: jcoomes, kamg Contributed-by: harold.seigel at oracle.com ! src/os/windows/vm/os_windows.cpp ! src/os_cpu/bsd_x86/vm/globals_bsd_x86.hpp ! src/os_cpu/bsd_zero/vm/globals_bsd_zero.hpp ! src/os_cpu/linux_sparc/vm/globals_linux_sparc.hpp ! src/os_cpu/linux_x86/vm/globals_linux_x86.hpp ! src/os_cpu/linux_zero/vm/globals_linux_zero.hpp ! src/os_cpu/solaris_sparc/vm/globals_solaris_sparc.hpp ! src/os_cpu/solaris_x86/vm/globals_solaris_x86.hpp ! src/os_cpu/windows_x86/vm/globals_windows_x86.hpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: e81fbc04a942 Author: coleenp Date: 2012-10-25 16:33 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/e81fbc04a942 7191817: -XX:+UseSerialGC -XX:+UseLargePages crashes with SIGFPE on MacOS X Summary: Disable -XX:+UseLargePages for MacOS X Reviewed-by: dholmes, coleenp, sla Contributed-by: harold.seigel at oracle.com ! src/share/vm/runtime/arguments.cpp From john.coomes at oracle.com Thu Oct 25 21:03:45 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 26 Oct 2012 04:03:45 +0000 Subject: hg: hsx/hotspot-rt: 3 new changesets Message-ID: <20121026040345.7012D47578@hg.openjdk.java.net> Changeset: c12e759ac4e8 Author: tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/c12e759ac4e8 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tbell Contributed-by: volker.simonis at gmail.com ! README-builds.html + make/scripts/fixpath.pl ! make/scripts/vsvars.sh Changeset: 8a3fe0ae06a8 Author: katleman Date: 2012-10-24 13:11 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/8a3fe0ae06a8 Merge Changeset: 4e984be114bd Author: katleman Date: 2012-10-25 09:52 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/rev/4e984be114bd Added tag jdk8-b62 for changeset 8a3fe0ae06a8 ! .hgtags From john.coomes at oracle.com Thu Oct 25 21:03:49 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 26 Oct 2012 04:03:49 +0000 Subject: hg: hsx/hotspot-rt/corba: 3 new changesets Message-ID: <20121026040352.7701947579@hg.openjdk.java.net> Changeset: 0a5931be9176 Author: tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/0a5931be9176 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tbell Contributed-by: volker.simonis at gmail.com ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Platform.gmk Changeset: 08afb9c6f44f Author: katleman Date: 2012-10-24 13:11 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/08afb9c6f44f Merge Changeset: bbaef650c3d2 Author: katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/corba/rev/bbaef650c3d2 Added tag jdk8-b62 for changeset 08afb9c6f44f ! .hgtags From john.coomes at oracle.com Thu Oct 25 21:03:56 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 26 Oct 2012 04:03:56 +0000 Subject: hg: hsx/hotspot-rt/jaxp: Added tag jdk8-b62 for changeset 5d0fa0108d02 Message-ID: <20121026040403.BBA1B4757A@hg.openjdk.java.net> Changeset: a96e34e038f5 Author: katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxp/rev/a96e34e038f5 Added tag jdk8-b62 for changeset 5d0fa0108d02 ! .hgtags From john.coomes at oracle.com Thu Oct 25 21:04:08 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 26 Oct 2012 04:04:08 +0000 Subject: hg: hsx/hotspot-rt/jaxws: Added tag jdk8-b62 for changeset d265b9b4c0f5 Message-ID: <20121026040413.1E6454757B@hg.openjdk.java.net> Changeset: c27ea8d489e8 Author: katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jaxws/rev/c27ea8d489e8 Added tag jdk8-b62 for changeset d265b9b4c0f5 ! .hgtags From john.coomes at oracle.com Thu Oct 25 21:04:24 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 26 Oct 2012 04:04:24 +0000 Subject: hg: hsx/hotspot-rt/jdk: 5 new changesets Message-ID: <20121026040557.EA2ED4757C@hg.openjdk.java.net> Changeset: 61af38b8d4ff Author: twisti Date: 2012-10-19 17:04 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/61af38b8d4ff 8000989: smaller code changes to make future JSR 292 backports easier Reviewed-by: jrose ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/DirectMethodHandle.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/java/lang/invoke/Invokers.java ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MemberName.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! test/java/lang/invoke/BigArityTest.java ! test/java/lang/invoke/PrivateInvokeTest.java Changeset: 7a7e49acadec Author: kamg Date: 2012-10-22 20:12 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/7a7e49acadec 8001225: Disable jdk regression test java/lang/System/Versions.java until jdk's classfile version code is updated Summary: Exclude java/lang/System/Versions.java test Reviewed-by: sspitsyn, coleenp ! test/ProblemList.txt Changeset: a0a2b186ae28 Author: tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/a0a2b186ae28 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tbell Contributed-by: volker.simonis at gmail.com ! make/com/sun/java/pack/Makefile ! make/common/Defs-windows.gmk ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/common/Release.gmk ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Platform.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/jdk_generic_profile.sh ! make/tools/freetypecheck/Makefile + make/tools/msys_build_scripts/dospath.sh + make/tools/msys_build_scripts/dospath.vbs Changeset: 50b8b17449d2 Author: katleman Date: 2012-10-24 13:14 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/50b8b17449d2 Merge Changeset: 65d2c6726487 Author: katleman Date: 2012-10-25 09:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/jdk/rev/65d2c6726487 Added tag jdk8-b62 for changeset 50b8b17449d2 ! .hgtags From john.coomes at oracle.com Thu Oct 25 21:06:54 2012 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 26 Oct 2012 04:06:54 +0000 Subject: hg: hsx/hotspot-rt/langtools: Added tag jdk8-b62 for changeset b47bb81ba962 Message-ID: <20121026040701.30FD64757D@hg.openjdk.java.net> Changeset: 16498acd21b5 Author: katleman Date: 2012-10-25 09:54 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/langtools/rev/16498acd21b5 Added tag jdk8-b62 for changeset b47bb81ba962 ! .hgtags From serguei.spitsyn at oracle.com Fri Oct 26 00:05:38 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 26 Oct 2012 00:05:38 -0700 Subject: review request: 6533010 SPEC: A few broken links in jvmti.html In-Reply-To: <5088B8A6.9050508@oracle.com> References: <5085ABB5.3040801@oracle.com> <5088301D.7090403@oracle.com> <5088B8A6.9050508@oracle.com> Message-ID: <508A3642.1000702@oracle.com> David, Thank you for reviewing it and sorry for the latency! Had to learn how to use the specdiff tool. I run it this way: % *java -Xss512m -jar /java/re/specdiff/2.0/archive/fcs/binaries/specdiff.jar jvmti.html new.jvmti.html --hu --config="plain" --out=specdiff-out* The specdiff result is: http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/specdiff-out/diff.html I've not found how to get just jvmti.html differences without showing the whole document. Please, let me know if there is a way to generate better differences. Also, this is a simple diff between old and new jvmti.html (please, let me know if you prefer a ontextual diff): sspitsyn at sc11152541 diff jvmti.html new.jvmti.html 5c5 < JVM(TM) Tool Interface 1.2.1 --- > JVM(TM) Tool Interface 1.2.2 248c248 < Java --- > Java 569c569 < GetEnv. --- > GetEnv. 679c679 < --- > 714c714 < Java --- > Java 809c809 < JNI Documentation). --- > JNI Documentation). 839c839 < Java Exceptions --- > Java Exceptions 4136c4136 < Attaching to the VM. --- > Attaching to the VM. 8401c8401 < Set when the reference_kind is --- > Set when the reference_kind is 8858c8858 < array_primitive_value_callback and klass --- > array_primitive_value_callback and klass 8903c8903 < object_reference_callback --- > array_primitive_value_callback 9182c9182 < array_primitive_value_callback and klass --- > array_primitive_value_callback and klass 9227c9227 < object_callback --- > array_primitive_value_callback 14577c14577 < JNI --- > JNI 20780c20780 < See JNI --- > See JNI 24347c24347 < path to a --- > path to a 24463c24463 < In the live phase the segment is a platform-dependent path to a JAR file to be --- > In the live phase the segment is a platform-dependent path to a JAR file to be 26775a26776,26781 > jchar > Holds a Java programming language char. > Unsigned 16 bits. > > > 26967c26973 < JNI Specification. --- > JNI Specification. 32210c32216 < Version: 1.2.1

--- > Version: 1.2.2

33568a33575,33580 > > 1.2.2 >
11 October 2012 > Fixed the "HTTP" and "Missing Anchor" errors reported by the LinkCheck tool. > > My answers on your questions are inlined below. On 10/24/12 8:57 PM, David Holmes wrote: > Serguei, > > Does the change to the micro version need to go through approval > processes? > > That aside I don't quite understand how you can just bump the micro > version for JDK7 when JDK 7 is already out there with a different > micro version. The web version of the spec indicates it is 1.2.1 for > JDK 7: I think, the micro-version must be bumped as it is next version of the document. The mini-version is not bumped because there are not real spec changes. It is just link fixes. Have I answered your question? > > http://docs.oracle.com/javase/7/docs/platform/jvmti/jvmti.html#ChangeHistory > > > (Though the change history has not been updated since 2006 :( ) I believe, the document really has not been updated since 2006. > > This addition seems unrelated to LinkCheck: > > + > + > + Holds a Java programming language char. > + Unsigned 16 bits. > + > + > > Aside: it would be useful to see a blenderrev or specdiff version of > the change to compare the before and after redndered html. It is a fix for this error reported by LinkCheck: 8710: > David > > On 25/10/2012 4:14 AM, serguei.spitsyn at oracle.com wrote: >> Hello, >> >> >> Please, review the fix for (preliminary reviewed by >> james.holmlund at oracle.com) : >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6533010 >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc >> >> Generated jvmti.html: >> http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2012/hotspot/6533010-JVMTI-doc/jvmti.html >> >> >> >> Summary: >> >> The fix is to remove the errors in generated jvmti.html reported by the >> LinkCheck tool: >> http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ >> >> >> >> I verified the fix by looking into the generated jvmti.html: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/jvmti.html >> >> >> >> One more comment about the JVMTI version and the related changes: >> >> + >> + Fixed the "HTTP" and "Missing Anchor" errors reported by the LinkCheck >> tool. >> + >> >> >> >> diff -r 48a75d2640a5 src/share/vm/prims/jvmtiEnvBase.hpp >> --- a/src/share/vm/prims/jvmtiEnvBase.hpp Thu Oct 11 14:27:54 2012 -0400 >> +++ b/src/share/vm/prims/jvmtiEnvBase.hpp Mon Oct 22 13:07:54 2012 -0700 >> @@ -67,7 +67,7 @@ >> enum { >> JDK15_JVMTI_VERSION = JVMTI_VERSION_1_0 + 33, /* version: 1.0.33 */ >> JDK16_JVMTI_VERSION = JVMTI_VERSION_1_1 + 102, /* version: 1.1.102 */ >> - JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 1 /* version: 1.2.1 */ >> + JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 2 /* version: 1.2.2 */ >> }; >> >> I've decided to fix just micro version, so new version is 1.2.2 that >> matches JDK 7. >> It is because the fix is for both JFK 7 and 8 and it does not add any >> new features related to JDK 8. >> The enum in the jvmtiEnvBase.hpp is not used anywhere in hotspot code. >> It is just to keep track of JVMTI versions matching different versions >> of JDK. >> >> >> Thanks, >> Serguei >> >> >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121026/779e5cb9/attachment-0001.html From david.holmes at oracle.com Fri Oct 26 00:28:31 2012 From: david.holmes at oracle.com (David Holmes) Date: Fri, 26 Oct 2012 17:28:31 +1000 Subject: review request: 6533010 SPEC: A few broken links in jvmti.html In-Reply-To: <508A3642.1000702@oracle.com> References: <5085ABB5.3040801@oracle.com> <5088301D.7090403@oracle.com> <5088B8A6.9050508@oracle.com> <508A3642.1000702@oracle.com> Message-ID: <508A3B9F.2020302@oracle.com> Thanks Serguei, The specdiff output was not quite what I expected but it's been a long time since I looked at it (and I don't know how to drive it). :) I'm still unclear about the micro version changes. Maybe Dan, or someone else, can comment on how JVMTI versioning works in terms of "spec" version and what the runtime version reports. David On 26/10/2012 5:05 PM, serguei.spitsyn at oracle.com wrote: > David, > > > Thank you for reviewing it and sorry for the latency! > Had to learn how to use the specdiff tool. > > I run it this way: > % *java -Xss512m -jar > /java/re/specdiff/2.0/archive/fcs/binaries/specdiff.jar jvmti.html > new.jvmti.html --hu --config="plain" --out=specdiff-out* > > The specdiff result is: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/specdiff-out/diff.html > > I've not found how to get just jvmti.html differences without showing > the whole document. > Please, let me know if there is a way to generate better differences. > > > Also, this is a simple diff between old and new jvmti.html (please, let > me know if you prefer a ontextual diff): > > sspitsyn at sc11152541 diff jvmti.html new.jvmti.html > 5c5 > < JVM(TM) Tool Interface 1.2.1 > --- > > JVM(TM) Tool Interface 1.2.2 > 248c248 > < Java > --- > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jpda/architecture.html">Java > > 569c569 > < href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/invocation.html#GetEnv">GetEnv. > --- > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/invocation.html#GetEnv">GetEnv. > 679c679 > < href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/types.html#wp16542"> > --- > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp16542"> > 714c714 > < href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/design.html">Java > > --- > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/design.html">Java > > 809c809 > < href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html#wp18654">JNI > Documentation). > --- > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html#wp18654">JNI > Documentation). > 839c839 > < href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/design.html#wp770">Java > Exceptions > --- > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/design.html#wp770">Java > Exceptions > 4136c4136 > < href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/invocation.html#wp1060">Attaching > to the VM. > --- > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/invocation.html#wp1060">Attaching > to the VM. > 8401c8401 > < Set when the reference_kind is > --- > > Set when the href="#jvmtiHeapReferenceCallback.reference_kind">reference_kind is > 8858c8858 > < href="#FollowReferences.array_primitive_value_callback">array_primitive_value_callback > and klass > --- > > href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback > and klass > 8903c8903 > < href="#jvmtiHeapCallbacks.object_reference_callback">object_reference_callback > --- > > href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback > 9182c9182 > < href="#IterateThroughHeap.array_primitive_value_callback">array_primitive_value_callback > and klass > --- > > href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback > and klass > 9227c9227 > < href="#jvmtiHeapCallbacks.object_callback">object_callback > --- > > href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback > 14577c14577 > < href="http://java.sun.com/javase/6/docs/guide/jni/spec/types.html#wp16432">JNI > > --- > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp16432">JNI > > 20780c20780 > < See href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html">JNI > --- > > See href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html">JNI > 24347c24347 > < path to a > --- > > path to a href="http://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html"> > 24463c24463 > < In the live phase the href="#AddToSystemClassLoaderSearch.segment">segment is > a platform-dependent path to a href="http://java.sun.com/javase/6/docs/guide/jar/jar.html">JAR file > to be > --- > > In the live phase the href="#AddToSystemClassLoaderSearch.segment">segment is > a platform-dependent path to a href="http://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html">JAR > file to be > 26775a26776,26781 > > jchar > > Holds a Java programming language char. > > Unsigned 16 bits. > > > > > > > 26967c26973 > < href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html#wp23720">JNI > Specification. > --- > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html#wp23720">JNI > Specification. > 32210c32216 > < Version: 1.2.1

> --- > > Version: 1.2.2

> 33568a33575,33580 > > > > 1.2.2 > >
11 October 2012 > > Fixed the "HTTP" and "Missing Anchor" errors reported by the > LinkCheck tool. > > > > > > > My answers on your questions are inlined below. > > > > On 10/24/12 8:57 PM, David Holmes wrote: >> Serguei, >> >> Does the change to the micro version need to go through approval >> processes? >> >> That aside I don't quite understand how you can just bump the micro >> version for JDK7 when JDK 7 is already out there with a different >> micro version. The web version of the spec indicates it is 1.2.1 for >> JDK 7: > > I think, the micro-version must be bumped as it is next version of the > document. > The mini-version is not bumped because there are not real spec changes. > It is just link fixes. > > Have I answered your question? > >> >> http://docs.oracle.com/javase/7/docs/platform/jvmti/jvmti.html#ChangeHistory >> >> >> (Though the change history has not been updated since 2006 :( ) > > I believe, the document really has not been updated since 2006. > > >> >> This addition seems unrelated to LinkCheck: >> >> + >> + >> + Holds a Java programming language char. >> + Unsigned 16 bits. >> + >> + >> >> Aside: it would be useful to see a blenderrev or specdiff version of >> the change to compare the before and after redndered html. > > It is a fix for this error reported by LinkCheck: > 8710: > > > > The LinkCheck report: > http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ > > > Provided above. > > > Thanks, > Serguei > >> >> David >> >> On 25/10/2012 4:14 AM, serguei.spitsyn at oracle.com wrote: >>> Hello, >>> >>> >>> Please, review the fix for (preliminary reviewed by >>> james.holmlund at oracle.com) : >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6533010 >>> >>> Open webrev: >>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc >>> >>> Generated jvmti.html: >>> http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2012/hotspot/6533010-JVMTI-doc/jvmti.html >>> >>> >>> >>> Summary: >>> >>> The fix is to remove the errors in generated jvmti.html reported by the >>> LinkCheck tool: >>> http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ >>> >>> >>> >>> I verified the fix by looking into the generated jvmti.html: >>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/jvmti.html >>> >>> >>> >>> One more comment about the JVMTI version and the related changes: >>> >>> + >>> + Fixed the "HTTP" and "Missing Anchor" errors reported by the LinkCheck >>> tool. >>> + >>> >>> >>> >>> diff -r 48a75d2640a5 src/share/vm/prims/jvmtiEnvBase.hpp >>> --- a/src/share/vm/prims/jvmtiEnvBase.hpp Thu Oct 11 14:27:54 2012 -0400 >>> +++ b/src/share/vm/prims/jvmtiEnvBase.hpp Mon Oct 22 13:07:54 2012 -0700 >>> @@ -67,7 +67,7 @@ >>> enum { >>> JDK15_JVMTI_VERSION = JVMTI_VERSION_1_0 + 33, /* version: 1.0.33 */ >>> JDK16_JVMTI_VERSION = JVMTI_VERSION_1_1 + 102, /* version: 1.1.102 */ >>> - JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 1 /* version: 1.2.1 */ >>> + JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 2 /* version: 1.2.2 */ >>> }; >>> >>> I've decided to fix just micro version, so new version is 1.2.2 that >>> matches JDK 7. >>> It is because the fix is for both JFK 7 and 8 and it does not add any >>> new features related to JDK 8. >>> The enum in the jvmtiEnvBase.hpp is not used anywhere in hotspot code. >>> It is just to keep track of JVMTI versions matching different versions >>> of JDK. >>> >>> >>> Thanks, >>> Serguei >>> >>> >>> >>> > From serguei.spitsyn at oracle.com Fri Oct 26 02:21:54 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 26 Oct 2012 02:21:54 -0700 Subject: review request: 6533010 SPEC: A few broken links in jvmti.html In-Reply-To: <508A3B9F.2020302@oracle.com> References: <5085ABB5.3040801@oracle.com> <5088301D.7090403@oracle.com> <5088B8A6.9050508@oracle.com> <508A3642.1000702@oracle.com> <508A3B9F.2020302@oracle.com> Message-ID: <508A5632.9050707@oracle.com> On 10/26/12 12:28 AM, David Holmes wrote: > Thanks Serguei, > > The specdiff output was not quite what I expected but it's been a long > time since I looked at it (and I don't know how to drive it). :) Jim recommended to use this firefox extension to check links: https://addons.mozilla.org/en-US/firefox/addon/linkchecker/ It just colors links green or red. Both Jim and I used it to verify the links and now all links are green. I did not find any link in new jvmti.html colored red. > > I'm still unclear about the micro version changes. Maybe Dan, or > someone else, can comment on how JVMTI versioning works in terms of > "spec" version and what the runtime version reports. BTW, Jim thinks it is probably Ok. Let's check if anyone else shed a light on it. Dan, do you have any opinion on this? Thanks, Serguei > > David > > On 26/10/2012 5:05 PM, serguei.spitsyn at oracle.com wrote: >> David, >> >> >> Thank you for reviewing it and sorry for the latency! >> Had to learn how to use the specdiff tool. >> >> I run it this way: >> % *java -Xss512m -jar >> /java/re/specdiff/2.0/archive/fcs/binaries/specdiff.jar jvmti.html >> new.jvmti.html --hu --config="plain" --out=specdiff-out* >> >> The specdiff result is: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/specdiff-out/diff.html >> >> >> I've not found how to get just jvmti.html differences without showing >> the whole document. >> Please, let me know if there is a way to generate better differences. >> >> >> Also, this is a simple diff between old and new jvmti.html (please, let >> me know if you prefer a ontextual diff): >> >> sspitsyn at sc11152541 diff jvmti.html new.jvmti.html >> 5c5 >> < JVM(TM) Tool Interface 1.2.1 >> --- >> > JVM(TM) Tool Interface 1.2.2 >> 248c248 >> < Java >> --- >> > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jpda/architecture.html">Java >> >> >> 569c569 >> < > href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/invocation.html#GetEnv">GetEnv. >> >> --- >> > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/invocation.html#GetEnv">GetEnv. >> >> 679c679 >> < > href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/types.html#wp16542"> >> >> --- >> > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp16542"> >> >> 714c714 >> < > href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/design.html">Java >> >> >> --- >> > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/design.html">Java >> >> >> 809c809 >> < > href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html#wp18654">JNI >> >> Documentation). >> --- >> > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html#wp18654">JNI >> >> Documentation). >> 839c839 >> < > href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/design.html#wp770">Java >> >> Exceptions >> --- >> > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/design.html#wp770">Java >> >> Exceptions >> 4136c4136 >> < > href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/invocation.html#wp1060">Attaching >> >> to the VM. >> --- >> > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/invocation.html#wp1060">Attaching >> >> to the VM. >> 8401c8401 >> < Set when the > href="#.reference_kind">reference_kind is >> --- >> > Set when the > href="#jvmtiHeapReferenceCallback.reference_kind">reference_kind is >> 8858c8858 >> < > href="#FollowReferences.array_primitive_value_callback">array_primitive_value_callback >> >> and klass >> --- >> > > href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >> >> and klass >> 8903c8903 >> < > href="#jvmtiHeapCallbacks.object_reference_callback">object_reference_callback >> >> --- >> > > href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >> >> 9182c9182 >> < > href="#IterateThroughHeap.array_primitive_value_callback">array_primitive_value_callback >> >> and klass >> --- >> > > href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >> >> and klass >> 9227c9227 >> < > href="#jvmtiHeapCallbacks.object_callback">object_callback >> >> --- >> > > href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >> >> 14577c14577 >> < > href="http://java.sun.com/javase/6/docs/guide/jni/spec/types.html#wp16432">JNI >> >> >> --- >> > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp16432">JNI >> >> >> 20780c20780 >> < See > href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html">JNI >> >> --- >> > See > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html">JNI >> >> 24347c24347 >> < path to a > href="http://java.sun.com/javase/6/docs/guide/jar/jar.html"> >> --- >> > path to a > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html"> >> >> 24463c24463 >> < In the live phase the > href="#AddToSystemClassLoaderSearch.segment">segment is >> a platform-dependent path to a > href="http://java.sun.com/javase/6/docs/guide/jar/jar.html">JAR file >> to be >> --- >> > In the live phase the > href="#AddToSystemClassLoaderSearch.segment">segment is >> a platform-dependent path to a > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html">JAR >> >> file to be >> 26775a26776,26781 >> > jchar >> > Holds a Java programming language char. >> > Unsigned 16 bits. >> > >> > >> > >> 26967c26973 >> < > href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html#wp23720">JNI >> >> Specification. >> --- >> > > href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html#wp23720">JNI >> >> Specification. >> 32210c32216 >> < Version: 1.2.1

>> --- >> > Version: 1.2.2

>> 33568a33575,33580 >> > >> > 1.2.2 >> >
11 October 2012 >> > Fixed the "HTTP" and "Missing Anchor" errors reported by the >> LinkCheck tool. >> > >> > >> >> >> My answers on your questions are inlined below. >> >> >> >> On 10/24/12 8:57 PM, David Holmes wrote: >>> Serguei, >>> >>> Does the change to the micro version need to go through approval >>> processes? >>> >>> That aside I don't quite understand how you can just bump the micro >>> version for JDK7 when JDK 7 is already out there with a different >>> micro version. The web version of the spec indicates it is 1.2.1 for >>> JDK 7: >> >> I think, the micro-version must be bumped as it is next version of the >> document. >> The mini-version is not bumped because there are not real spec changes. >> It is just link fixes. >> >> Have I answered your question? >> >>> >>> http://docs.oracle.com/javase/7/docs/platform/jvmti/jvmti.html#ChangeHistory >>> >>> >>> >>> (Though the change history has not been updated since 2006 :( ) >> >> I believe, the document really has not been updated since 2006. >> >> >>> >>> This addition seems unrelated to LinkCheck: >>> >>> + >>> + >>> + Holds a Java programming language char. >>> + Unsigned 16 bits. >>> + >>> + >>> >>> Aside: it would be useful to see a blenderrev or specdiff version of >>> the change to compare the before and after redndered html. >> >> It is a fix for this error reported by LinkCheck: >> 8710: > >> >> >> >> The LinkCheck report: >> http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ >> >> >> >> Provided above. >> >> >> Thanks, >> Serguei >> >>> >>> David >>> >>> On 25/10/2012 4:14 AM, serguei.spitsyn at oracle.com wrote: >>>> Hello, >>>> >>>> >>>> Please, review the fix for (preliminary reviewed by >>>> james.holmlund at oracle.com) : >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6533010 >>>> >>>> Open webrev: >>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc >>>> >>>> Generated jvmti.html: >>>> http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2012/hotspot/6533010-JVMTI-doc/jvmti.html >>>> >>>> >>>> >>>> >>>> Summary: >>>> >>>> The fix is to remove the errors in generated jvmti.html reported by >>>> the >>>> LinkCheck tool: >>>> http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ >>>> >>>> >>>> >>>> >>>> I verified the fix by looking into the generated jvmti.html: >>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/jvmti.html >>>> >>>> >>>> >>>> >>>> One more comment about the JVMTI version and the related changes: >>>> >>>> + >>>> + Fixed the "HTTP" and "Missing Anchor" errors reported by the >>>> LinkCheck >>>> tool. >>>> + >>>> >>>> >>>> >>>> diff -r 48a75d2640a5 src/share/vm/prims/jvmtiEnvBase.hpp >>>> --- a/src/share/vm/prims/jvmtiEnvBase.hpp Thu Oct 11 14:27:54 2012 >>>> -0400 >>>> +++ b/src/share/vm/prims/jvmtiEnvBase.hpp Mon Oct 22 13:07:54 2012 >>>> -0700 >>>> @@ -67,7 +67,7 @@ >>>> enum { >>>> JDK15_JVMTI_VERSION = JVMTI_VERSION_1_0 + 33, /* version: 1.0.33 */ >>>> JDK16_JVMTI_VERSION = JVMTI_VERSION_1_1 + 102, /* version: 1.1.102 */ >>>> - JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 1 /* version: 1.2.1 */ >>>> + JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 2 /* version: 1.2.2 */ >>>> }; >>>> >>>> I've decided to fix just micro version, so new version is 1.2.2 that >>>> matches JDK 7. >>>> It is because the fix is for both JFK 7 and 8 and it does not add any >>>> new features related to JDK 8. >>>> The enum in the jvmtiEnvBase.hpp is not used anywhere in hotspot code. >>>> It is just to keep track of JVMTI versions matching different versions >>>> of JDK. >>>> >>>> >>>> Thanks, >>>> Serguei >>>> >>>> >>>> >>>> >> From alan.bateman at oracle.com Fri Oct 26 03:22:46 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Fri, 26 Oct 2012 10:22:46 +0000 Subject: hg: jdk8/tl/jdk: 4239752: FileSystem should be a platform-specific class to avoid native code Message-ID: <20121026102335.0C15F47585@hg.openjdk.java.net> Changeset: 0b52c87c39da Author: dxu Date: 2012-10-26 11:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0b52c87c39da 4239752: FileSystem should be a platform-specific class to avoid native code Reviewed-by: alanb, dholmes, erikj, jgish ! make/java/java/Exportedfiles.gmk ! make/java/java/FILES_c.gmk ! make/java/java/FILES_java.gmk ! make/java/java/mapfile-vers ! makefiles/CompileJavaClasses.gmk ! makefiles/mapfiles/libjava/mapfile-vers ! src/share/classes/java/io/File.java ! src/share/classes/java/io/FileSystem.java + src/solaris/classes/java/io/DefaultFileSystem.java - src/solaris/native/java/io/FileSystem_md.c + src/windows/classes/java/io/DefaultFileSystem.java - src/windows/native/java/io/FileSystem_md.c From staffan.larsen at oracle.com Fri Oct 26 05:23:44 2012 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 26 Oct 2012 14:23:44 +0200 Subject: RFR: 8001621: Update awk scripts that check output from jps/jcmd Message-ID: <5A3B4129-4286-407B-A2B3-CEABF0A732FB@oracle.com> Some awk scripts in the tests check for -- process information unavailable as valid output. However, there are other outputs that are also 'ok'. For example: -- main class information unavailable webrev: http://cr.openjdk.java.net/~sla/8001621/webrev.01/ Thanks, /Staffan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121026/7402ef4c/attachment-0001.html From Alan.Bateman at oracle.com Fri Oct 26 05:40:23 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Fri, 26 Oct 2012 13:40:23 +0100 Subject: RFR: 8001621: Update awk scripts that check output from jps/jcmd In-Reply-To: <5A3B4129-4286-407B-A2B3-CEABF0A732FB@oracle.com> References: <5A3B4129-4286-407B-A2B3-CEABF0A732FB@oracle.com> Message-ID: <508A84B7.7090004@oracle.com> On 26/10/2012 13:23, Staffan Larsen wrote: > Some awk scripts in the tests check for > -- process information unavailable > as valid output. However, there are other outputs that are also 'ok'. > For example: > -- main class information unavailable > > webrev: http://cr.openjdk.java.net/~sla/8001621/webrev.01/ > > > > Thanks, > /Staffan This looks good to me and should make these tests more reliable. -Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121026/b94642dd/attachment.html From daniel.daugherty at oracle.com Fri Oct 26 08:08:25 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Fri, 26 Oct 2012 09:08:25 -0600 Subject: review request: 6533010 SPEC: A few broken links in jvmti.html In-Reply-To: <508A5632.9050707@oracle.com> References: <5085ABB5.3040801@oracle.com> <5088301D.7090403@oracle.com> <5088B8A6.9050508@oracle.com> <508A3642.1000702@oracle.com> <508A3B9F.2020302@oracle.com> <508A5632.9050707@oracle.com> Message-ID: <508AA769.4060908@oracle.com> > Dan, do you have any opinion on this? The micro version used to be auto generated from part of the SCCS ident string so it was modified every time the "source" file was changed. That mechanism was not carried forward into the Mercurial world. In other words, the micro version isn't something that any agent code could or should depend on because it could change (in the past) due to something not related to code. That said, the micro version only gets updated now when someone remembers to do it. Now code shouldn't depend on the micro version because it can be stale. That should probably be fixed in some way. Dan On 10/26/12 3:21 AM, serguei.spitsyn at oracle.com wrote: > > > > > > On 10/26/12 12:28 AM, David Holmes wrote: >> Thanks Serguei, >> >> The specdiff output was not quite what I expected but it's been a >> long time since I looked at it (and I don't know how to drive it). :) > > Jim recommended to use this firefox extension to check links: > https://addons.mozilla.org/en-US/firefox/addon/linkchecker/ > > It just colors links green or red. > > Both Jim and I used it to verify the links and now all links are green. > I did not find any link in new jvmti.html colored red. > >> >> I'm still unclear about the micro version changes. Maybe Dan, or >> someone else, can comment on how JVMTI versioning works in terms of >> "spec" version and what the runtime version reports. > > BTW, Jim thinks it is probably Ok. > Let's check if anyone else shed a light on it. > > Dan, do you have any opinion on this? > > > Thanks, > Serguei > >> >> David >> >> On 26/10/2012 5:05 PM, serguei.spitsyn at oracle.com wrote: >>> David, >>> >>> >>> Thank you for reviewing it and sorry for the latency! >>> Had to learn how to use the specdiff tool. >>> >>> I run it this way: >>> % *java -Xss512m -jar >>> /java/re/specdiff/2.0/archive/fcs/binaries/specdiff.jar jvmti.html >>> new.jvmti.html --hu --config="plain" --out=specdiff-out* >>> >>> The specdiff result is: >>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/specdiff-out/diff.html >>> >>> >>> I've not found how to get just jvmti.html differences without showing >>> the whole document. >>> Please, let me know if there is a way to generate better differences. >>> >>> >>> Also, this is a simple diff between old and new jvmti.html (please, let >>> me know if you prefer a ontextual diff): >>> >>> sspitsyn at sc11152541 diff jvmti.html new.jvmti.html >>> 5c5 >>> < JVM(TM) Tool Interface 1.2.1 >>> --- >>> > JVM(TM) Tool Interface 1.2.2 >>> 248c248 >>> < Java >>> --- >>> > >> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jpda/architecture.html">Java >>> >>> >>> 569c569 >>> < >> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/invocation.html#GetEnv">GetEnv. >>> >>> --- >>> > >> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/invocation.html#GetEnv">GetEnv. >>> >>> 679c679 >>> < >> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/types.html#wp16542"> >>> >>> --- >>> > >> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp16542"> >>> >>> 714c714 >>> < >> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/design.html">Java >>> >>> >>> --- >>> > >> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/design.html">Java >>> >>> >>> 809c809 >>> < >> href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html#wp18654">JNI >>> >>> Documentation). >>> --- >>> > >> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html#wp18654">JNI >>> >>> Documentation). >>> 839c839 >>> < >> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/design.html#wp770">Java >>> >>> Exceptions >>> --- >>> > >> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/design.html#wp770">Java >>> >>> Exceptions >>> 4136c4136 >>> < >> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/invocation.html#wp1060">Attaching >>> >>> to the VM. >>> --- >>> > >> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/invocation.html#wp1060">Attaching >>> >>> to the VM. >>> 8401c8401 >>> < Set when the >> href="#.reference_kind">reference_kind is >>> --- >>> > Set when the >> href="#jvmtiHeapReferenceCallback.reference_kind">reference_kind is >>> 8858c8858 >>> < >> href="#FollowReferences.array_primitive_value_callback">array_primitive_value_callback >>> >>> and klass >>> --- >>> > >> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>> >>> and klass >>> 8903c8903 >>> < >> href="#jvmtiHeapCallbacks.object_reference_callback">object_reference_callback >>> >>> --- >>> > >> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>> >>> 9182c9182 >>> < >> href="#IterateThroughHeap.array_primitive_value_callback">array_primitive_value_callback >>> >>> and klass >>> --- >>> > >> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>> >>> and klass >>> 9227c9227 >>> < >> href="#jvmtiHeapCallbacks.object_callback">object_callback >>> >>> --- >>> > >> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>> >>> 14577c14577 >>> < >> href="http://java.sun.com/javase/6/docs/guide/jni/spec/types.html#wp16432">JNI >>> >>> >>> --- >>> > >> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp16432">JNI >>> >>> >>> 20780c20780 >>> < See >> href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html">JNI >>> >>> --- >>> > See >> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html">JNI >>> >>> 24347c24347 >>> < path to a >> href="http://java.sun.com/javase/6/docs/guide/jar/jar.html"> >>> --- >>> > path to a >> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html"> >>> >>> 24463c24463 >>> < In the live phase the >> href="#AddToSystemClassLoaderSearch.segment">segment is >>> >>> a platform-dependent path to a >> href="http://java.sun.com/javase/6/docs/guide/jar/jar.html">JAR >>> file >>> to be >>> --- >>> > In the live phase the >> href="#AddToSystemClassLoaderSearch.segment">segment is >>> >>> a platform-dependent path to a >> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html">JAR >>> >>> file to be >>> 26775a26776,26781 >>> > jchar >>> > Holds a Java programming language char. >>> > Unsigned 16 bits. >>> > >>> > >>> > >>> 26967c26973 >>> < >> href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html#wp23720">JNI >>> >>> Specification. >>> --- >>> > >> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html#wp23720">JNI >>> >>> Specification. >>> 32210c32216 >>> < Version: 1.2.1

>>> --- >>> > Version: 1.2.2

>>> 33568a33575,33580 >>> > >>> > 1.2.2 >>> >
11 October 2012 >>> > Fixed the "HTTP" and "Missing Anchor" errors reported by the >>> LinkCheck tool. >>> > >>> > >>> >>> >>> My answers on your questions are inlined below. >>> >>> >>> >>> On 10/24/12 8:57 PM, David Holmes wrote: >>>> Serguei, >>>> >>>> Does the change to the micro version need to go through approval >>>> processes? >>>> >>>> That aside I don't quite understand how you can just bump the micro >>>> version for JDK7 when JDK 7 is already out there with a different >>>> micro version. The web version of the spec indicates it is 1.2.1 for >>>> JDK 7: >>> >>> I think, the micro-version must be bumped as it is next version of the >>> document. >>> The mini-version is not bumped because there are not real spec changes. >>> It is just link fixes. >>> >>> Have I answered your question? >>> >>>> >>>> http://docs.oracle.com/javase/7/docs/platform/jvmti/jvmti.html#ChangeHistory >>>> >>>> >>>> >>>> (Though the change history has not been updated since 2006 :( ) >>> >>> I believe, the document really has not been updated since 2006. >>> >>> >>>> >>>> This addition seems unrelated to LinkCheck: >>>> >>>> + >>>> + >>>> + Holds a Java programming language char. >>>> + Unsigned 16 bits. >>>> + >>>> + >>>> >>>> Aside: it would be useful to see a blenderrev or specdiff version of >>>> the change to compare the before and after redndered html. >>> >>> It is a fix for this error reported by LinkCheck: >>> 8710: >> >>> >>> >>> >>> The LinkCheck report: >>> http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ >>> >>> >>> >>> Provided above. >>> >>> >>> Thanks, >>> Serguei >>> >>>> >>>> David >>>> >>>> On 25/10/2012 4:14 AM, serguei.spitsyn at oracle.com wrote: >>>>> Hello, >>>>> >>>>> >>>>> Please, review the fix for (preliminary reviewed by >>>>> james.holmlund at oracle.com) : >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6533010 >>>>> >>>>> Open webrev: >>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc >>>>> >>>>> Generated jvmti.html: >>>>> http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2012/hotspot/6533010-JVMTI-doc/jvmti.html >>>>> >>>>> >>>>> >>>>> >>>>> Summary: >>>>> >>>>> The fix is to remove the errors in generated jvmti.html reported >>>>> by the >>>>> LinkCheck tool: >>>>> http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ >>>>> >>>>> >>>>> >>>>> >>>>> I verified the fix by looking into the generated jvmti.html: >>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/jvmti.html >>>>> >>>>> >>>>> >>>>> >>>>> One more comment about the JVMTI version and the related changes: >>>>> >>>>> + >>>>> + Fixed the "HTTP" and "Missing Anchor" errors reported by the >>>>> LinkCheck >>>>> tool. >>>>> + >>>>> >>>>> >>>>> >>>>> diff -r 48a75d2640a5 src/share/vm/prims/jvmtiEnvBase.hpp >>>>> --- a/src/share/vm/prims/jvmtiEnvBase.hpp Thu Oct 11 14:27:54 2012 >>>>> -0400 >>>>> +++ b/src/share/vm/prims/jvmtiEnvBase.hpp Mon Oct 22 13:07:54 2012 >>>>> -0700 >>>>> @@ -67,7 +67,7 @@ >>>>> enum { >>>>> JDK15_JVMTI_VERSION = JVMTI_VERSION_1_0 + 33, /* version: 1.0.33 */ >>>>> JDK16_JVMTI_VERSION = JVMTI_VERSION_1_1 + 102, /* version: 1.1.102 */ >>>>> - JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 1 /* version: 1.2.1 */ >>>>> + JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 2 /* version: 1.2.2 */ >>>>> }; >>>>> >>>>> I've decided to fix just micro version, so new version is 1.2.2 that >>>>> matches JDK 7. >>>>> It is because the fix is for both JFK 7 and 8 and it does not add any >>>>> new features related to JDK 8. >>>>> The enum in the jvmtiEnvBase.hpp is not used anywhere in hotspot >>>>> code. >>>>> It is just to keep track of JVMTI versions matching different >>>>> versions >>>>> of JDK. >>>>> >>>>> >>>>> Thanks, >>>>> Serguei >>>>> >>>>> >>>>> >>>>> >>> > From serguei.spitsyn at oracle.com Fri Oct 26 10:44:00 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Fri, 26 Oct 2012 10:44:00 -0700 Subject: review request: 6533010 SPEC: A few broken links in jvmti.html In-Reply-To: <508AA769.4060908@oracle.com> References: <5085ABB5.3040801@oracle.com> <5088301D.7090403@oracle.com> <5088B8A6.9050508@oracle.com> <508A3642.1000702@oracle.com> <508A3B9F.2020302@oracle.com> <508A5632.9050707@oracle.com> <508AA769.4060908@oracle.com> Message-ID: <508ACBE0.50902@oracle.com> Thanks, Dan! My memory told me that the jvmti version has to be auto-updated, and I was surprised that it is not. I forgot that the SCCS ident string was used in the past and now it is gone. So, David, are we Ok to integrate the fix now? Thanks, Serguei On 10/26/12 8:08 AM, Daniel D. Daugherty wrote: >> Dan, do you have any opinion on this? > > The micro version used to be auto generated from part of the SCCS > ident string so it was modified every time the "source" file was > changed. That mechanism was not carried forward into the Mercurial > world. > > In other words, the micro version isn't something that any agent > code could or should depend on because it could change (in the past) > due to something not related to code. > > That said, the micro version only gets updated now when someone > remembers to do it. Now code shouldn't depend on the micro > version because it can be stale. That should probably be fixed > in some way. > > Dan > > > > On 10/26/12 3:21 AM, serguei.spitsyn at oracle.com wrote: >> >> >> >> >> >> On 10/26/12 12:28 AM, David Holmes wrote: >>> Thanks Serguei, >>> >>> The specdiff output was not quite what I expected but it's been a >>> long time since I looked at it (and I don't know how to drive it). :) >> >> Jim recommended to use this firefox extension to check links: >> https://addons.mozilla.org/en-US/firefox/addon/linkchecker/ >> >> It just colors links green or red. >> >> Both Jim and I used it to verify the links and now all links are green. >> I did not find any link in new jvmti.html colored red. >> >>> >>> I'm still unclear about the micro version changes. Maybe Dan, or >>> someone else, can comment on how JVMTI versioning works in terms of >>> "spec" version and what the runtime version reports. >> >> BTW, Jim thinks it is probably Ok. >> Let's check if anyone else shed a light on it. >> >> Dan, do you have any opinion on this? >> >> >> Thanks, >> Serguei >> >>> >>> David >>> >>> On 26/10/2012 5:05 PM, serguei.spitsyn at oracle.com wrote: >>>> David, >>>> >>>> >>>> Thank you for reviewing it and sorry for the latency! >>>> Had to learn how to use the specdiff tool. >>>> >>>> I run it this way: >>>> % *java -Xss512m -jar >>>> /java/re/specdiff/2.0/archive/fcs/binaries/specdiff.jar jvmti.html >>>> new.jvmti.html --hu --config="plain" --out=specdiff-out* >>>> >>>> The specdiff result is: >>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/specdiff-out/diff.html >>>> >>>> >>>> I've not found how to get just jvmti.html differences without showing >>>> the whole document. >>>> Please, let me know if there is a way to generate better differences. >>>> >>>> >>>> Also, this is a simple diff between old and new jvmti.html (please, >>>> let >>>> me know if you prefer a ontextual diff): >>>> >>>> sspitsyn at sc11152541 diff jvmti.html new.jvmti.html >>>> 5c5 >>>> < JVM(TM) Tool Interface 1.2.1 >>>> --- >>>> > JVM(TM) Tool Interface 1.2.2 >>>> 248c248 >>>> < Java >>>> --- >>>> > >>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jpda/architecture.html">Java >>>> >>>> >>>> 569c569 >>>> < >>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/invocation.html#GetEnv">GetEnv. >>>> >>>> --- >>>> > >>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/invocation.html#GetEnv">GetEnv. >>>> >>>> 679c679 >>>> < >>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/types.html#wp16542"> >>>> >>>> --- >>>> > >>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp16542"> >>>> >>>> 714c714 >>>> < >>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/design.html">Java >>>> >>>> >>>> --- >>>> > >>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/design.html">Java >>>> >>>> >>>> 809c809 >>>> < >>> href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html#wp18654">JNI >>>> >>>> Documentation). >>>> --- >>>> > >>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html#wp18654">JNI >>>> >>>> Documentation). >>>> 839c839 >>>> < >>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/design.html#wp770">Java >>>> >>>> Exceptions >>>> --- >>>> > >>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/design.html#wp770">Java >>>> >>>> Exceptions >>>> 4136c4136 >>>> < >>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/invocation.html#wp1060">Attaching >>>> >>>> to the VM. >>>> --- >>>> > >>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/invocation.html#wp1060">Attaching >>>> >>>> to the VM. >>>> 8401c8401 >>>> < Set when the >>> href="#.reference_kind">reference_kind is >>>> --- >>>> > Set when the >>> href="#jvmtiHeapReferenceCallback.reference_kind">reference_kind is >>>> >>>> 8858c8858 >>>> < >>> href="#FollowReferences.array_primitive_value_callback">array_primitive_value_callback >>>> >>>> and klass >>>> --- >>>> > >>> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>>> >>>> and klass >>>> 8903c8903 >>>> < >>> href="#jvmtiHeapCallbacks.object_reference_callback">object_reference_callback >>>> >>>> --- >>>> > >>> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>>> >>>> 9182c9182 >>>> < >>> href="#IterateThroughHeap.array_primitive_value_callback">array_primitive_value_callback >>>> >>>> and klass >>>> --- >>>> > >>> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>>> >>>> and klass >>>> 9227c9227 >>>> < >>> href="#jvmtiHeapCallbacks.object_callback">object_callback >>>> >>>> --- >>>> > >>> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>>> >>>> 14577c14577 >>>> < >>> href="http://java.sun.com/javase/6/docs/guide/jni/spec/types.html#wp16432">JNI >>>> >>>> >>>> --- >>>> > >>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp16432">JNI >>>> >>>> >>>> 20780c20780 >>>> < See >>> href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html">JNI >>>> >>>> --- >>>> > See >>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html">JNI >>>> >>>> 24347c24347 >>>> < path to a >>> href="http://java.sun.com/javase/6/docs/guide/jar/jar.html"> >>>> --- >>>> > path to a >>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html"> >>>> >>>> 24463c24463 >>>> < In the live phase the >>> href="#AddToSystemClassLoaderSearch.segment">segment >>>> is >>>> a platform-dependent path to a >>> href="http://java.sun.com/javase/6/docs/guide/jar/jar.html">JAR >>>> file >>>> to be >>>> --- >>>> > In the live phase the >>> href="#AddToSystemClassLoaderSearch.segment">segment >>>> is >>>> a platform-dependent path to a >>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html">JAR >>>> >>>> file to be >>>> 26775a26776,26781 >>>> > jchar >>>> > Holds a Java programming language char. >>>> > Unsigned 16 bits. >>>> > >>>> > >>>> > >>>> 26967c26973 >>>> < >>> href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html#wp23720">JNI >>>> >>>> Specification. >>>> --- >>>> > >>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html#wp23720">JNI >>>> >>>> Specification. >>>> 32210c32216 >>>> < Version: 1.2.1

>>>> --- >>>> > Version: 1.2.2

>>>> 33568a33575,33580 >>>> > >>>> > 1.2.2 >>>> >
11 October 2012 >>>> > Fixed the "HTTP" and "Missing Anchor" errors reported by the >>>> LinkCheck tool. >>>> > >>>> > >>>> >>>> >>>> My answers on your questions are inlined below. >>>> >>>> >>>> >>>> On 10/24/12 8:57 PM, David Holmes wrote: >>>>> Serguei, >>>>> >>>>> Does the change to the micro version need to go through approval >>>>> processes? >>>>> >>>>> That aside I don't quite understand how you can just bump the micro >>>>> version for JDK7 when JDK 7 is already out there with a different >>>>> micro version. The web version of the spec indicates it is 1.2.1 for >>>>> JDK 7: >>>> >>>> I think, the micro-version must be bumped as it is next version of the >>>> document. >>>> The mini-version is not bumped because there are not real spec >>>> changes. >>>> It is just link fixes. >>>> >>>> Have I answered your question? >>>> >>>>> >>>>> http://docs.oracle.com/javase/7/docs/platform/jvmti/jvmti.html#ChangeHistory >>>>> >>>>> >>>>> >>>>> (Though the change history has not been updated since 2006 :( ) >>>> >>>> I believe, the document really has not been updated since 2006. >>>> >>>> >>>>> >>>>> This addition seems unrelated to LinkCheck: >>>>> >>>>> + >>>>> + >>>>> + Holds a Java programming language char. >>>>> + Unsigned 16 bits. >>>>> + >>>>> + >>>>> >>>>> Aside: it would be useful to see a blenderrev or specdiff version of >>>>> the change to compare the before and after redndered html. >>>> >>>> It is a fix for this error reported by LinkCheck: >>>> 8710: >>> >>>> >>>> >>>> >>>> The LinkCheck report: >>>> http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ >>>> >>>> >>>> >>>> Provided above. >>>> >>>> >>>> Thanks, >>>> Serguei >>>> >>>>> >>>>> David >>>>> >>>>> On 25/10/2012 4:14 AM, serguei.spitsyn at oracle.com wrote: >>>>>> Hello, >>>>>> >>>>>> >>>>>> Please, review the fix for (preliminary reviewed by >>>>>> james.holmlund at oracle.com) : >>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6533010 >>>>>> >>>>>> Open webrev: >>>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc >>>>>> >>>>>> Generated jvmti.html: >>>>>> http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2012/hotspot/6533010-JVMTI-doc/jvmti.html >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> Summary: >>>>>> >>>>>> The fix is to remove the errors in generated jvmti.html reported >>>>>> by the >>>>>> LinkCheck tool: >>>>>> http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> I verified the fix by looking into the generated jvmti.html: >>>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/jvmti.html >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> One more comment about the JVMTI version and the related changes: >>>>>> >>>>>> + >>>>>> + Fixed the "HTTP" and "Missing Anchor" errors reported by the >>>>>> LinkCheck >>>>>> tool. >>>>>> + >>>>>> >>>>>> >>>>>> >>>>>> diff -r 48a75d2640a5 src/share/vm/prims/jvmtiEnvBase.hpp >>>>>> --- a/src/share/vm/prims/jvmtiEnvBase.hpp Thu Oct 11 14:27:54 >>>>>> 2012 -0400 >>>>>> +++ b/src/share/vm/prims/jvmtiEnvBase.hpp Mon Oct 22 13:07:54 >>>>>> 2012 -0700 >>>>>> @@ -67,7 +67,7 @@ >>>>>> enum { >>>>>> JDK15_JVMTI_VERSION = JVMTI_VERSION_1_0 + 33, /* version: 1.0.33 */ >>>>>> JDK16_JVMTI_VERSION = JVMTI_VERSION_1_1 + 102, /* version: >>>>>> 1.1.102 */ >>>>>> - JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 1 /* version: 1.2.1 */ >>>>>> + JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 2 /* version: 1.2.2 */ >>>>>> }; >>>>>> >>>>>> I've decided to fix just micro version, so new version is 1.2.2 that >>>>>> matches JDK 7. >>>>>> It is because the fix is for both JFK 7 and 8 and it does not add >>>>>> any >>>>>> new features related to JDK 8. >>>>>> The enum in the jvmtiEnvBase.hpp is not used anywhere in hotspot >>>>>> code. >>>>>> It is just to keep track of JVMTI versions matching different >>>>>> versions >>>>>> of JDK. >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Serguei >>>>>> >>>>>> >>>>>> >>>>>> >>>> >> From jonathan.gibbons at oracle.com Fri Oct 26 13:11:00 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 26 Oct 2012 20:11:00 +0000 Subject: hg: jdk8/tl/langtools: 8001219: Clean up use of URLs in javadoc Extern class Message-ID: <20121026201102.1FB584759E@hg.openjdk.java.net> Changeset: 217c265158fe Author: jjg Date: 2012-10-26 13:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/217c265158fe 8001219: Clean up use of URLs in javadoc Extern class Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java From chris.hegarty at oracle.com Fri Oct 26 13:40:49 2012 From: chris.hegarty at oracle.com (chris.hegarty at oracle.com) Date: Fri, 26 Oct 2012 20:40:49 +0000 Subject: hg: jdk8/tl/jdk: 8001575: Minor/sync/cleanup j.u.c with Dougs CVS - Oct 2012 Message-ID: <20121026204109.391A54759F@hg.openjdk.java.net> Changeset: 3fc5457cf779 Author: dl Date: 2012-10-26 21:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fc5457cf779 8001575: Minor/sync/cleanup j.u.c with Dougs CVS - Oct 2012 Reviewed-by: chegar, dholmes ! src/share/classes/java/util/concurrent/AbstractExecutorService.java ! src/share/classes/java/util/concurrent/BlockingQueue.java ! src/share/classes/java/util/concurrent/BrokenBarrierException.java ! src/share/classes/java/util/concurrent/CompletionService.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share/classes/java/util/concurrent/ConcurrentMap.java ! src/share/classes/java/util/concurrent/ConcurrentNavigableMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListSet.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/concurrent/CopyOnWriteArraySet.java ! src/share/classes/java/util/concurrent/CountDownLatch.java ! src/share/classes/java/util/concurrent/CyclicBarrier.java ! src/share/classes/java/util/concurrent/Delayed.java ! src/share/classes/java/util/concurrent/ExecutionException.java ! src/share/classes/java/util/concurrent/Executor.java ! src/share/classes/java/util/concurrent/ExecutorService.java ! src/share/classes/java/util/concurrent/Executors.java ! src/share/classes/java/util/concurrent/Future.java ! src/share/classes/java/util/concurrent/LinkedBlockingDeque.java ! src/share/classes/java/util/concurrent/LinkedBlockingQueue.java ! src/share/classes/java/util/concurrent/LinkedTransferQueue.java ! src/share/classes/java/util/concurrent/RecursiveAction.java ! src/share/classes/java/util/concurrent/RejectedExecutionException.java ! src/share/classes/java/util/concurrent/ScheduledExecutorService.java ! src/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java ! src/share/classes/java/util/concurrent/Semaphore.java ! src/share/classes/java/util/concurrent/SynchronousQueue.java ! src/share/classes/java/util/concurrent/ThreadFactory.java ! src/share/classes/java/util/concurrent/TimeUnit.java ! src/share/classes/java/util/concurrent/atomic/AtomicInteger.java ! src/share/classes/java/util/concurrent/atomic/AtomicIntegerFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicLong.java ! src/share/classes/java/util/concurrent/atomic/AtomicLongFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/AtomicReference.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceArray.java ! src/share/classes/java/util/concurrent/atomic/AtomicReferenceFieldUpdater.java ! src/share/classes/java/util/concurrent/atomic/package-info.java ! src/share/classes/java/util/concurrent/locks/AbstractQueuedLongSynchronizer.java ! src/share/classes/java/util/concurrent/locks/AbstractQueuedSynchronizer.java ! src/share/classes/java/util/concurrent/locks/Condition.java ! src/share/classes/java/util/concurrent/locks/Lock.java ! src/share/classes/java/util/concurrent/locks/LockSupport.java ! src/share/classes/java/util/concurrent/locks/ReentrantLock.java ! src/share/classes/java/util/concurrent/locks/ReentrantReadWriteLock.java ! src/share/classes/java/util/concurrent/package-info.java From jonathan.gibbons at oracle.com Fri Oct 26 16:41:48 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Fri, 26 Oct 2012 23:41:48 +0000 Subject: hg: jdk8/tl/langtools: 8001229: refactor javac so that ct.sym is just used for javac, not all clients of JavacFileManager Message-ID: <20121026234153.3B355475C2@hg.openjdk.java.net> Changeset: e6cb81683ffe Author: jjg Date: 2012-10-26 16:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e6cb81683ffe 8001229: refactor javac so that ct.sym is just used for javac, not all clients of JavacFileManager Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javah/JavahFileManager.java ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/com/sun/tools/javap/JavapFileManager.java From david.holmes at oracle.com Fri Oct 26 17:03:46 2012 From: david.holmes at oracle.com (David Holmes) Date: Sat, 27 Oct 2012 10:03:46 +1000 Subject: RFR: 8001621: Update awk scripts that check output from jps/jcmd In-Reply-To: <5A3B4129-4286-407B-A2B3-CEABF0A732FB@oracle.com> References: <5A3B4129-4286-407B-A2B3-CEABF0A732FB@oracle.com> Message-ID: <508B24E2.2090902@oracle.com> On 26/10/2012 10:23 PM, Staffan Larsen wrote: > Some awk scripts in the tests check for > -- process information unavailable > as valid output. However, there are other outputs that are also 'ok'. > For example: > -- main class information unavailable > > webrev: http://cr.openjdk.java.net/~sla/8001621/webrev.01/ The wildcards seems a little too open to me - is there a risk of matching things they should not? I'm a little puzzled by the problem - is this something new, something related to a specific platform ? David > > Thanks, > /Staffan From jonathan.gibbons at oracle.com Fri Oct 26 17:18:06 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sat, 27 Oct 2012 00:18:06 +0000 Subject: hg: jdk8/tl/langtools: 8001714: add missing tests for 7199925 Message-ID: <20121027001809.24D5A475C4@hg.openjdk.java.net> Changeset: 64fce9f95b1d Author: jjg Date: 2012-10-26 17:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64fce9f95b1d 8001714: add missing tests for 7199925 Reviewed-by: darcy + test/tools/javac/annotations/repeatingAnnotations/ClassReaderDefault.java + test/tools/javac/annotations/repeatingAnnotations/SeparateCompile.java From jonathan.gibbons at oracle.com Fri Oct 26 18:40:48 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Sat, 27 Oct 2012 01:40:48 +0000 Subject: hg: jdk8/tl/langtools: 8001717: TypeTags cleanup breaks GenStubs Message-ID: <20121027014050.4FBB6475CA@hg.openjdk.java.net> Changeset: 384f7a4beae7 Author: jjg Date: 2012-10-26 18:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/384f7a4beae7 8001717: TypeTags cleanup breaks GenStubs Reviewed-by: jjh ! make/tools/genstubs/GenStubs.java From david.holmes at oracle.com Sat Oct 27 00:42:27 2012 From: david.holmes at oracle.com (David Holmes) Date: Sat, 27 Oct 2012 17:42:27 +1000 Subject: review request: 6533010 SPEC: A few broken links in jvmti.html In-Reply-To: <508ACBE0.50902@oracle.com> References: <5085ABB5.3040801@oracle.com> <5088301D.7090403@oracle.com> <5088B8A6.9050508@oracle.com> <508A3642.1000702@oracle.com> <508A3B9F.2020302@oracle.com> <508A5632.9050707@oracle.com> <508AA769.4060908@oracle.com> <508ACBE0.50902@oracle.com> Message-ID: <508B9063.2080007@oracle.com> On 27/10/2012 3:44 AM, serguei.spitsyn at oracle.com wrote: > Thanks, Dan! > > My memory told me that the jvmti version has to be auto-updated, and I > was surprised that it is not. > I forgot that the SCCS ident string was used in the past and now it is > gone. > > So, David, are we Ok to integrate the fix now? I have no problem with it. Thanks, David > Thanks, > Serguei > > > On 10/26/12 8:08 AM, Daniel D. Daugherty wrote: >>> Dan, do you have any opinion on this? >> >> The micro version used to be auto generated from part of the SCCS >> ident string so it was modified every time the "source" file was >> changed. That mechanism was not carried forward into the Mercurial >> world. >> >> In other words, the micro version isn't something that any agent >> code could or should depend on because it could change (in the past) >> due to something not related to code. >> >> That said, the micro version only gets updated now when someone >> remembers to do it. Now code shouldn't depend on the micro >> version because it can be stale. That should probably be fixed >> in some way. >> >> Dan >> >> >> >> On 10/26/12 3:21 AM, serguei.spitsyn at oracle.com wrote: >>> >>> >>> >>> >>> >>> On 10/26/12 12:28 AM, David Holmes wrote: >>>> Thanks Serguei, >>>> >>>> The specdiff output was not quite what I expected but it's been a >>>> long time since I looked at it (and I don't know how to drive it). :) >>> >>> Jim recommended to use this firefox extension to check links: >>> https://addons.mozilla.org/en-US/firefox/addon/linkchecker/ >>> >>> It just colors links green or red. >>> >>> Both Jim and I used it to verify the links and now all links are green. >>> I did not find any link in new jvmti.html colored red. >>> >>>> >>>> I'm still unclear about the micro version changes. Maybe Dan, or >>>> someone else, can comment on how JVMTI versioning works in terms of >>>> "spec" version and what the runtime version reports. >>> >>> BTW, Jim thinks it is probably Ok. >>> Let's check if anyone else shed a light on it. >>> >>> Dan, do you have any opinion on this? >>> >>> >>> Thanks, >>> Serguei >>> >>>> >>>> David >>>> >>>> On 26/10/2012 5:05 PM, serguei.spitsyn at oracle.com wrote: >>>>> David, >>>>> >>>>> >>>>> Thank you for reviewing it and sorry for the latency! >>>>> Had to learn how to use the specdiff tool. >>>>> >>>>> I run it this way: >>>>> % *java -Xss512m -jar >>>>> /java/re/specdiff/2.0/archive/fcs/binaries/specdiff.jar jvmti.html >>>>> new.jvmti.html --hu --config="plain" --out=specdiff-out* >>>>> >>>>> The specdiff result is: >>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/specdiff-out/diff.html >>>>> >>>>> >>>>> I've not found how to get just jvmti.html differences without showing >>>>> the whole document. >>>>> Please, let me know if there is a way to generate better differences. >>>>> >>>>> >>>>> Also, this is a simple diff between old and new jvmti.html (please, >>>>> let >>>>> me know if you prefer a ontextual diff): >>>>> >>>>> sspitsyn at sc11152541 diff jvmti.html new.jvmti.html >>>>> 5c5 >>>>> < JVM(TM) Tool Interface 1.2.1 >>>>> --- >>>>> > JVM(TM) Tool Interface 1.2.2 >>>>> 248c248 >>>>> < Java >>>>> --- >>>>> > >>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jpda/architecture.html">Java >>>>> >>>>> >>>>> 569c569 >>>>> < >>>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/invocation.html#GetEnv">GetEnv. >>>>> >>>>> --- >>>>> > >>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/invocation.html#GetEnv">GetEnv. >>>>> >>>>> 679c679 >>>>> < >>>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/types.html#wp16542"> >>>>> >>>>> --- >>>>> > >>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp16542"> >>>>> >>>>> 714c714 >>>>> < >>>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/design.html">Java >>>>> >>>>> >>>>> --- >>>>> > >>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/design.html">Java >>>>> >>>>> >>>>> 809c809 >>>>> < >>>> href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html#wp18654">JNI >>>>> >>>>> Documentation). >>>>> --- >>>>> > >>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html#wp18654">JNI >>>>> >>>>> Documentation). >>>>> 839c839 >>>>> < >>>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/design.html#wp770">Java >>>>> >>>>> Exceptions >>>>> --- >>>>> > >>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/design.html#wp770">Java >>>>> >>>>> Exceptions >>>>> 4136c4136 >>>>> < >>>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/invocation.html#wp1060">Attaching >>>>> >>>>> to the VM. >>>>> --- >>>>> > >>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/invocation.html#wp1060">Attaching >>>>> >>>>> to the VM. >>>>> 8401c8401 >>>>> < Set when the >>>> href="#.reference_kind">reference_kind is >>>>> --- >>>>> > Set when the >>>> href="#jvmtiHeapReferenceCallback.reference_kind">reference_kind is >>>>> >>>>> 8858c8858 >>>>> < >>>> href="#FollowReferences.array_primitive_value_callback">array_primitive_value_callback >>>>> >>>>> and klass >>>>> --- >>>>> > >>>> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>>>> >>>>> and klass >>>>> 8903c8903 >>>>> < >>>> href="#jvmtiHeapCallbacks.object_reference_callback">object_reference_callback >>>>> >>>>> --- >>>>> > >>>> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>>>> >>>>> 9182c9182 >>>>> < >>>> href="#IterateThroughHeap.array_primitive_value_callback">array_primitive_value_callback >>>>> >>>>> and klass >>>>> --- >>>>> > >>>> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>>>> >>>>> and klass >>>>> 9227c9227 >>>>> < >>>> href="#jvmtiHeapCallbacks.object_callback">object_callback >>>>> >>>>> --- >>>>> > >>>> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>>>> >>>>> 14577c14577 >>>>> < >>>> href="http://java.sun.com/javase/6/docs/guide/jni/spec/types.html#wp16432">JNI >>>>> >>>>> >>>>> --- >>>>> > >>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp16432">JNI >>>>> >>>>> >>>>> 20780c20780 >>>>> < See >>>> href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html">JNI >>>>> >>>>> --- >>>>> > See >>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html">JNI >>>>> >>>>> 24347c24347 >>>>> < path to a >>>> href="http://java.sun.com/javase/6/docs/guide/jar/jar.html"> >>>>> --- >>>>> > path to a >>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html"> >>>>> >>>>> 24463c24463 >>>>> < In the live phase the >>>> href="#AddToSystemClassLoaderSearch.segment">segment >>>>> is >>>>> a platform-dependent path to a >>>> href="http://java.sun.com/javase/6/docs/guide/jar/jar.html">JAR >>>>> file >>>>> to be >>>>> --- >>>>> > In the live phase the >>>> href="#AddToSystemClassLoaderSearch.segment">segment >>>>> is >>>>> a platform-dependent path to a >>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html">JAR >>>>> >>>>> file to be >>>>> 26775a26776,26781 >>>>> > jchar >>>>> > Holds a Java programming language char. >>>>> > Unsigned 16 bits. >>>>> > >>>>> > >>>>> > >>>>> 26967c26973 >>>>> < >>>> href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html#wp23720">JNI >>>>> >>>>> Specification. >>>>> --- >>>>> > >>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html#wp23720">JNI >>>>> >>>>> Specification. >>>>> 32210c32216 >>>>> < Version: 1.2.1

>>>>> --- >>>>> > Version: 1.2.2

>>>>> 33568a33575,33580 >>>>> > >>>>> > 1.2.2 >>>>> >
11 October 2012 >>>>> > Fixed the "HTTP" and "Missing Anchor" errors reported by the >>>>> LinkCheck tool. >>>>> > >>>>> > >>>>> >>>>> >>>>> My answers on your questions are inlined below. >>>>> >>>>> >>>>> >>>>> On 10/24/12 8:57 PM, David Holmes wrote: >>>>>> Serguei, >>>>>> >>>>>> Does the change to the micro version need to go through approval >>>>>> processes? >>>>>> >>>>>> That aside I don't quite understand how you can just bump the micro >>>>>> version for JDK7 when JDK 7 is already out there with a different >>>>>> micro version. The web version of the spec indicates it is 1.2.1 for >>>>>> JDK 7: >>>>> >>>>> I think, the micro-version must be bumped as it is next version of the >>>>> document. >>>>> The mini-version is not bumped because there are not real spec >>>>> changes. >>>>> It is just link fixes. >>>>> >>>>> Have I answered your question? >>>>> >>>>>> >>>>>> http://docs.oracle.com/javase/7/docs/platform/jvmti/jvmti.html#ChangeHistory >>>>>> >>>>>> >>>>>> >>>>>> (Though the change history has not been updated since 2006 :( ) >>>>> >>>>> I believe, the document really has not been updated since 2006. >>>>> >>>>> >>>>>> >>>>>> This addition seems unrelated to LinkCheck: >>>>>> >>>>>> + >>>>>> + >>>>>> + Holds a Java programming language char. >>>>>> + Unsigned 16 bits. >>>>>> + >>>>>> + >>>>>> >>>>>> Aside: it would be useful to see a blenderrev or specdiff version of >>>>>> the change to compare the before and after redndered html. >>>>> >>>>> It is a fix for this error reported by LinkCheck: >>>>> 8710: >>>> >>>>> >>>>> >>>>> >>>>> The LinkCheck report: >>>>> http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ >>>>> >>>>> >>>>> >>>>> Provided above. >>>>> >>>>> >>>>> Thanks, >>>>> Serguei >>>>> >>>>>> >>>>>> David >>>>>> >>>>>> On 25/10/2012 4:14 AM, serguei.spitsyn at oracle.com wrote: >>>>>>> Hello, >>>>>>> >>>>>>> >>>>>>> Please, review the fix for (preliminary reviewed by >>>>>>> james.holmlund at oracle.com) : >>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6533010 >>>>>>> >>>>>>> Open webrev: >>>>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc >>>>>>> >>>>>>> Generated jvmti.html: >>>>>>> http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2012/hotspot/6533010-JVMTI-doc/jvmti.html >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> Summary: >>>>>>> >>>>>>> The fix is to remove the errors in generated jvmti.html reported >>>>>>> by the >>>>>>> LinkCheck tool: >>>>>>> http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> I verified the fix by looking into the generated jvmti.html: >>>>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/jvmti.html >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> One more comment about the JVMTI version and the related changes: >>>>>>> >>>>>>> + >>>>>>> + Fixed the "HTTP" and "Missing Anchor" errors reported by the >>>>>>> LinkCheck >>>>>>> tool. >>>>>>> + >>>>>>> >>>>>>> >>>>>>> >>>>>>> diff -r 48a75d2640a5 src/share/vm/prims/jvmtiEnvBase.hpp >>>>>>> --- a/src/share/vm/prims/jvmtiEnvBase.hpp Thu Oct 11 14:27:54 >>>>>>> 2012 -0400 >>>>>>> +++ b/src/share/vm/prims/jvmtiEnvBase.hpp Mon Oct 22 13:07:54 >>>>>>> 2012 -0700 >>>>>>> @@ -67,7 +67,7 @@ >>>>>>> enum { >>>>>>> JDK15_JVMTI_VERSION = JVMTI_VERSION_1_0 + 33, /* version: 1.0.33 */ >>>>>>> JDK16_JVMTI_VERSION = JVMTI_VERSION_1_1 + 102, /* version: >>>>>>> 1.1.102 */ >>>>>>> - JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 1 /* version: 1.2.1 */ >>>>>>> + JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 2 /* version: 1.2.2 */ >>>>>>> }; >>>>>>> >>>>>>> I've decided to fix just micro version, so new version is 1.2.2 that >>>>>>> matches JDK 7. >>>>>>> It is because the fix is for both JFK 7 and 8 and it does not add >>>>>>> any >>>>>>> new features related to JDK 8. >>>>>>> The enum in the jvmtiEnvBase.hpp is not used anywhere in hotspot >>>>>>> code. >>>>>>> It is just to keep track of JVMTI versions matching different >>>>>>> versions >>>>>>> of JDK. >>>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Serguei >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>> >>> > From Alan.Bateman at oracle.com Sat Oct 27 01:45:50 2012 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Sat, 27 Oct 2012 09:45:50 +0100 Subject: RFR: 8001621: Update awk scripts that check output from jps/jcmd In-Reply-To: <508B24E2.2090902@oracle.com> References: <5A3B4129-4286-407B-A2B3-CEABF0A732FB@oracle.com> <508B24E2.2090902@oracle.com> Message-ID: <508B9F3E.1090504@oracle.com> On 27/10/2012 01:03, David Holmes wrote: > On 26/10/2012 10:23 PM, Staffan Larsen wrote: >> Some awk scripts in the tests check for >> -- process information unavailable >> as valid output. However, there are other outputs that are also 'ok'. >> For example: >> -- main class information unavailable >> >> webrev: http://cr.openjdk.java.net/~sla/8001621/webrev.01/ > > The wildcards seems a little too open to me - is there a risk of > matching things they should not? > > I'm a little puzzled by the problem - is this something new, something > related to a specific platform ? > > David I don't think this is a new problem, the jps tests have been known to fail when run after other tests that have left VMs running. I think Staffan's changes are okay, an alternative would have been to able handle strings such as " -- main class information unavailable" but I think that just complicates things, and there may be others too. -Alan -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121027/763e8d5b/attachment.html From Dmitry.Samersoff at oracle.com Sat Oct 27 03:08:42 2012 From: Dmitry.Samersoff at oracle.com (Dmitry Samersoff) Date: Sat, 27 Oct 2012 14:08:42 +0400 Subject: RFR: 8001621: Update awk scripts that check output from jps/jcmd In-Reply-To: <5A3B4129-4286-407B-A2B3-CEABF0A732FB@oracle.com> References: <5A3B4129-4286-407B-A2B3-CEABF0A732FB@oracle.com> Message-ID: <508BB2AA.60100@oracle.com> Staffan, > /^[0-9]+ -- .*$/ { If I remeber awk regexp correct, one below will do essentially the same. /^[0-9]+ -- / -Dmitry On 2012-10-26 16:23, Staffan Larsen wrote: > Some awk scripts in the tests check for > -- process information unavailable > as valid output. However, there are other outputs that are also 'ok'. > For example: > -- main class information unavailable > > webrev: http://cr.openjdk.java.net/~sla/8001621/webrev.01/ > > > Thanks, > /Staffan -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ... From alan.bateman at oracle.com Sat Oct 27 03:26:14 2012 From: alan.bateman at oracle.com (alan.bateman at oracle.com) Date: Sat, 27 Oct 2012 10:26:14 +0000 Subject: hg: jdk8/tl/jdk: 7176225: Remove JDBC-ODBC Bridge Message-ID: <20121027102657.1AC6847626@hg.openjdk.java.net> Changeset: 615af31cfccc Author: alanb Date: 2012-10-27 09:18 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/615af31cfccc 7176225: Remove JDBC-ODBC Bridge Reviewed-by: lancea, ohair, tbell ! make/common/Sanity.gmk ! make/common/shared/Defs-solaris.gmk ! make/common/shared/Sanity.gmk ! make/sun/Makefile - make/sun/jdbc/Makefile ! makefiles/CompileNativeLibraries.gmk ! makefiles/CopyIntoClasses.gmk ! makefiles/CreateJars.gmk ! makefiles/GensrcMisc.gmk From serguei.spitsyn at oracle.com Sat Oct 27 05:13:22 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Sat, 27 Oct 2012 05:13:22 -0700 Subject: review request: 6533010 SPEC: A few broken links in jvmti.html In-Reply-To: <508B9063.2080007@oracle.com> References: <5085ABB5.3040801@oracle.com> <5088301D.7090403@oracle.com> <5088B8A6.9050508@oracle.com> <508A3642.1000702@oracle.com> <508A3B9F.2020302@oracle.com> <508A5632.9050707@oracle.com> <508AA769.4060908@oracle.com> <508ACBE0.50902@oracle.com> <508B9063.2080007@oracle.com> Message-ID: <508BCFE2.30004@oracle.com> Thanks, David! Serguei On 10/27/12 12:42 AM, David Holmes wrote: > On 27/10/2012 3:44 AM, serguei.spitsyn at oracle.com wrote: >> Thanks, Dan! >> >> My memory told me that the jvmti version has to be auto-updated, and I >> was surprised that it is not. >> I forgot that the SCCS ident string was used in the past and now it is >> gone. >> >> So, David, are we Ok to integrate the fix now? > > I have no problem with it. > > Thanks, > David > >> Thanks, >> Serguei >> >> >> On 10/26/12 8:08 AM, Daniel D. Daugherty wrote: >>>> Dan, do you have any opinion on this? >>> >>> The micro version used to be auto generated from part of the SCCS >>> ident string so it was modified every time the "source" file was >>> changed. That mechanism was not carried forward into the Mercurial >>> world. >>> >>> In other words, the micro version isn't something that any agent >>> code could or should depend on because it could change (in the past) >>> due to something not related to code. >>> >>> That said, the micro version only gets updated now when someone >>> remembers to do it. Now code shouldn't depend on the micro >>> version because it can be stale. That should probably be fixed >>> in some way. >>> >>> Dan >>> >>> >>> >>> On 10/26/12 3:21 AM, serguei.spitsyn at oracle.com wrote: >>>> >>>> >>>> >>>> >>>> >>>> On 10/26/12 12:28 AM, David Holmes wrote: >>>>> Thanks Serguei, >>>>> >>>>> The specdiff output was not quite what I expected but it's been a >>>>> long time since I looked at it (and I don't know how to drive it). :) >>>> >>>> Jim recommended to use this firefox extension to check links: >>>> https://addons.mozilla.org/en-US/firefox/addon/linkchecker/ >>>> >>>> It just colors links green or red. >>>> >>>> Both Jim and I used it to verify the links and now all links are >>>> green. >>>> I did not find any link in new jvmti.html colored red. >>>> >>>>> >>>>> I'm still unclear about the micro version changes. Maybe Dan, or >>>>> someone else, can comment on how JVMTI versioning works in terms of >>>>> "spec" version and what the runtime version reports. >>>> >>>> BTW, Jim thinks it is probably Ok. >>>> Let's check if anyone else shed a light on it. >>>> >>>> Dan, do you have any opinion on this? >>>> >>>> >>>> Thanks, >>>> Serguei >>>> >>>>> >>>>> David >>>>> >>>>> On 26/10/2012 5:05 PM, serguei.spitsyn at oracle.com wrote: >>>>>> David, >>>>>> >>>>>> >>>>>> Thank you for reviewing it and sorry for the latency! >>>>>> Had to learn how to use the specdiff tool. >>>>>> >>>>>> I run it this way: >>>>>> % *java -Xss512m -jar >>>>>> /java/re/specdiff/2.0/archive/fcs/binaries/specdiff.jar jvmti.html >>>>>> new.jvmti.html --hu --config="plain" --out=specdiff-out* >>>>>> >>>>>> The specdiff result is: >>>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/specdiff-out/diff.html >>>>>> >>>>>> >>>>>> >>>>>> I've not found how to get just jvmti.html differences without >>>>>> showing >>>>>> the whole document. >>>>>> Please, let me know if there is a way to generate better >>>>>> differences. >>>>>> >>>>>> >>>>>> Also, this is a simple diff between old and new jvmti.html (please, >>>>>> let >>>>>> me know if you prefer a ontextual diff): >>>>>> >>>>>> sspitsyn at sc11152541 diff jvmti.html new.jvmti.html >>>>>> 5c5 >>>>>> < JVM(TM) Tool Interface 1.2.1 >>>>>> --- >>>>>> > JVM(TM) Tool Interface 1.2.2 >>>>>> 248c248 >>>>>> < Java >>>>>> --- >>>>>> > >>>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jpda/architecture.html">Java >>>>>> >>>>>> >>>>>> >>>>>> 569c569 >>>>>> < >>>>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/invocation.html#GetEnv">GetEnv. >>>>>> >>>>>> >>>>>> --- >>>>>> > >>>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/invocation.html#GetEnv">GetEnv. >>>>>> >>>>>> >>>>>> 679c679 >>>>>> < >>>>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/types.html#wp16542"> >>>>>> >>>>>> >>>>>> --- >>>>>> > >>>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp16542"> >>>>>> >>>>>> >>>>>> 714c714 >>>>>> < >>>>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/design.html">Java >>>>>> >>>>>> >>>>>> >>>>>> --- >>>>>> > >>>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/design.html">Java >>>>>> >>>>>> >>>>>> >>>>>> 809c809 >>>>>> < >>>>> href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html#wp18654">JNI >>>>>> >>>>>> >>>>>> Documentation). >>>>>> --- >>>>>> > >>>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html#wp18654">JNI >>>>>> >>>>>> >>>>>> Documentation). >>>>>> 839c839 >>>>>> < >>>>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/design.html#wp770">Java >>>>>> >>>>>> >>>>>> Exceptions >>>>>> --- >>>>>> > >>>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/design.html#wp770">Java >>>>>> >>>>>> >>>>>> Exceptions >>>>>> 4136c4136 >>>>>> < >>>>> href="http://java.sun.com/javase/6/docs/technotes/guides/jni/spec/invocation.html#wp1060">Attaching >>>>>> >>>>>> >>>>>> to the VM. >>>>>> --- >>>>>> > >>>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/invocation.html#wp1060">Attaching >>>>>> >>>>>> >>>>>> to the VM. >>>>>> 8401c8401 >>>>>> < Set when the >>>>> href="#.reference_kind">reference_kind is >>>>>> --- >>>>>> > Set when the >>>>> href="#jvmtiHeapReferenceCallback.reference_kind">reference_kind >>>>>> is >>>>>> >>>>>> 8858c8858 >>>>>> < >>>>> href="#FollowReferences.array_primitive_value_callback">array_primitive_value_callback >>>>>> >>>>>> >>>>>> and klass >>>>>> --- >>>>>> > >>>>> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>>>>> >>>>>> >>>>>> and klass >>>>>> 8903c8903 >>>>>> < >>>>> href="#jvmtiHeapCallbacks.object_reference_callback">object_reference_callback >>>>>> >>>>>> >>>>>> --- >>>>>> > >>>>> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>>>>> >>>>>> >>>>>> 9182c9182 >>>>>> < >>>>> href="#IterateThroughHeap.array_primitive_value_callback">array_primitive_value_callback >>>>>> >>>>>> >>>>>> and klass >>>>>> --- >>>>>> > >>>>> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>>>>> >>>>>> >>>>>> and klass >>>>>> 9227c9227 >>>>>> < >>>>> href="#jvmtiHeapCallbacks.object_callback">object_callback >>>>>> >>>>>> >>>>>> --- >>>>>> > >>>>> href="#jvmtiHeapCallbacks.array_primitive_value_callback">array_primitive_value_callback >>>>>> >>>>>> >>>>>> 14577c14577 >>>>>> < >>>>> href="http://java.sun.com/javase/6/docs/guide/jni/spec/types.html#wp16432">JNI >>>>>> >>>>>> >>>>>> >>>>>> --- >>>>>> > >>>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/types.html#wp16432">JNI >>>>>> >>>>>> >>>>>> >>>>>> 20780c20780 >>>>>> < See >>>>> href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html">JNI >>>>>> >>>>>> >>>>>> --- >>>>>> > See >>>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html">JNI >>>>>> >>>>>> >>>>>> 24347c24347 >>>>>> < path to a >>>>> href="http://java.sun.com/javase/6/docs/guide/jar/jar.html"> >>>>>> --- >>>>>> > path to a >>>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html"> >>>>>> >>>>>> >>>>>> 24463c24463 >>>>>> < In the live phase the >>>>> href="#AddToSystemClassLoaderSearch.segment">segment >>>>>> >>>>>> is >>>>>> a platform-dependent path to a >>>>> href="http://java.sun.com/javase/6/docs/guide/jar/jar.html">JAR >>>>>> file >>>>>> to be >>>>>> --- >>>>>> > In the live phase the >>>>> href="#AddToSystemClassLoaderSearch.segment">segment >>>>>> >>>>>> is >>>>>> a platform-dependent path to a >>>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jar/jar.html">JAR >>>>>> >>>>>> >>>>>> file to be >>>>>> 26775a26776,26781 >>>>>> > jchar >>>>>> > Holds a Java programming language char. >>>>>> > Unsigned 16 bits. >>>>>> > >>>>>> > >>>>>> > >>>>>> 26967c26973 >>>>>> < >>>>> href="http://java.sun.com/javase/6/docs/guide/jni/spec/functions.html#wp23720">JNI >>>>>> >>>>>> >>>>>> Specification. >>>>>> --- >>>>>> > >>>>> href="http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html#wp23720">JNI >>>>>> >>>>>> >>>>>> Specification. >>>>>> 32210c32216 >>>>>> < Version: 1.2.1

>>>>>> --- >>>>>> > Version: 1.2.2

>>>>>> 33568a33575,33580 >>>>>> > >>>>>> > 1.2.2 >>>>>> >
11 October 2012 >>>>>> > Fixed the "HTTP" and "Missing Anchor" errors reported by the >>>>>> LinkCheck tool. >>>>>> > >>>>>> > >>>>>> >>>>>> >>>>>> My answers on your questions are inlined below. >>>>>> >>>>>> >>>>>> >>>>>> On 10/24/12 8:57 PM, David Holmes wrote: >>>>>>> Serguei, >>>>>>> >>>>>>> Does the change to the micro version need to go through approval >>>>>>> processes? >>>>>>> >>>>>>> That aside I don't quite understand how you can just bump the micro >>>>>>> version for JDK7 when JDK 7 is already out there with a different >>>>>>> micro version. The web version of the spec indicates it is 1.2.1 >>>>>>> for >>>>>>> JDK 7: >>>>>> >>>>>> I think, the micro-version must be bumped as it is next version >>>>>> of the >>>>>> document. >>>>>> The mini-version is not bumped because there are not real spec >>>>>> changes. >>>>>> It is just link fixes. >>>>>> >>>>>> Have I answered your question? >>>>>> >>>>>>> >>>>>>> http://docs.oracle.com/javase/7/docs/platform/jvmti/jvmti.html#ChangeHistory >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> (Though the change history has not been updated since 2006 :( ) >>>>>> >>>>>> I believe, the document really has not been updated since 2006. >>>>>> >>>>>> >>>>>>> >>>>>>> This addition seems unrelated to LinkCheck: >>>>>>> >>>>>>> + >>>>>>> + >>>>>>> + Holds a Java programming language char. >>>>>>> + Unsigned 16 bits. >>>>>>> + >>>>>>> + >>>>>>> >>>>>>> Aside: it would be useful to see a blenderrev or specdiff >>>>>>> version of >>>>>>> the change to compare the before and after redndered html. >>>>>> >>>>>> It is a fix for this error reported by LinkCheck: >>>>>> 8710: >>>>> >>>>>> >>>>>> >>>>>> >>>>>> The LinkCheck report: >>>>>> http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> Provided above. >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Serguei >>>>>> >>>>>>> >>>>>>> David >>>>>>> >>>>>>> On 25/10/2012 4:14 AM, serguei.spitsyn at oracle.com wrote: >>>>>>>> Hello, >>>>>>>> >>>>>>>> >>>>>>>> Please, review the fix for (preliminary reviewed by >>>>>>>> james.holmlund at oracle.com) : >>>>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6533010 >>>>>>>> >>>>>>>> Open webrev: >>>>>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc >>>>>>>> >>>>>>>> >>>>>>>> Generated jvmti.html: >>>>>>>> http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2012/hotspot/6533010-JVMTI-doc/jvmti.html >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Summary: >>>>>>>> >>>>>>>> The fix is to remove the errors in generated jvmti.html reported >>>>>>>> by the >>>>>>>> LinkCheck tool: >>>>>>>> http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/ >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> I verified the fix by looking into the generated jvmti.html: >>>>>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/jvmti.html >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> One more comment about the JVMTI version and the related changes: >>>>>>>> >>>>>>>> + >>>>>>>> + Fixed the "HTTP" and "Missing Anchor" errors reported by the >>>>>>>> LinkCheck >>>>>>>> tool. >>>>>>>> + >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> diff -r 48a75d2640a5 src/share/vm/prims/jvmtiEnvBase.hpp >>>>>>>> --- a/src/share/vm/prims/jvmtiEnvBase.hpp Thu Oct 11 14:27:54 >>>>>>>> 2012 -0400 >>>>>>>> +++ b/src/share/vm/prims/jvmtiEnvBase.hpp Mon Oct 22 13:07:54 >>>>>>>> 2012 -0700 >>>>>>>> @@ -67,7 +67,7 @@ >>>>>>>> enum { >>>>>>>> JDK15_JVMTI_VERSION = JVMTI_VERSION_1_0 + 33, /* version: >>>>>>>> 1.0.33 */ >>>>>>>> JDK16_JVMTI_VERSION = JVMTI_VERSION_1_1 + 102, /* version: >>>>>>>> 1.1.102 */ >>>>>>>> - JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 1 /* version: 1.2.1 */ >>>>>>>> + JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 2 /* version: 1.2.2 */ >>>>>>>> }; >>>>>>>> >>>>>>>> I've decided to fix just micro version, so new version is 1.2.2 >>>>>>>> that >>>>>>>> matches JDK 7. >>>>>>>> It is because the fix is for both JFK 7 and 8 and it does not add >>>>>>>> any >>>>>>>> new features related to JDK 8. >>>>>>>> The enum in the jvmtiEnvBase.hpp is not used anywhere in hotspot >>>>>>>> code. >>>>>>>> It is just to keep track of JVMTI versions matching different >>>>>>>> versions >>>>>>>> of JDK. >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Serguei >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>> >>>> >> From weijun.wang at oracle.com Sun Oct 28 23:15:10 2012 From: weijun.wang at oracle.com (weijun.wang at oracle.com) Date: Mon, 29 Oct 2012 06:15:10 +0000 Subject: hg: jdk8/tl/jdk: 2 new changesets Message-ID: <20121029061542.A54FA4763F@hg.openjdk.java.net> Changeset: 33e29fbc3e5b Author: weijun Date: 2012-10-29 14:14 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/33e29fbc3e5b 7184246: Simplify Config.get() of krb5 Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/Checksum.java ! src/share/classes/sun/security/krb5/Config.java ! src/share/classes/sun/security/krb5/KdcComm.java ! src/share/classes/sun/security/krb5/PrincipalName.java ! src/share/classes/sun/security/krb5/Realm.java ! src/share/classes/sun/security/krb5/SCDynamicStoreConfig.java ! src/share/classes/sun/security/krb5/internal/KDCOptions.java ! src/share/classes/sun/security/krb5/internal/KerberosTime.java ! src/share/classes/sun/security/krb5/internal/crypto/CksumType.java ! src/share/classes/sun/security/krb5/internal/crypto/EType.java ! src/share/classes/sun/security/krb5/internal/ktab/KeyTab.java ! test/sun/security/krb5/ConfPlusProp.java ! test/sun/security/krb5/DnsFallback.java ! test/sun/security/krb5/ParseConfig.java ! test/sun/security/krb5/auto/BasicKrb5Test.java ! test/sun/security/krb5/auto/MaxRetries.java + test/sun/security/krb5/config/Duplicates.java + test/sun/security/krb5/config/SCDynamicConfigTest.java + test/sun/security/krb5/config/k1.conf Changeset: cb70077c6370 Author: weijun Date: 2012-10-29 14:14 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb70077c6370 7195426: kdc_default_options not supported correctly Reviewed-by: xuelei ! src/share/classes/sun/security/krb5/internal/KDCOptions.java + test/sun/security/krb5/config/KdcDefaultOptions.java + test/sun/security/krb5/config/kdc_default_options.conf From staffan.larsen at oracle.com Mon Oct 29 01:24:57 2012 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Mon, 29 Oct 2012 08:24:57 +0000 Subject: hg: jdk8/tl/jdk: 8001621: Update awk scripts that check output from jps/jcmd Message-ID: <20121029082519.8411F47642@hg.openjdk.java.net> Changeset: d1ffbdf7e3c6 Author: sla Date: 2012-10-29 09:23 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d1ffbdf7e3c6 8001621: Update awk scripts that check output from jps/jcmd Reviewed-by: alanb ! test/sun/tools/jcmd/jcmd_Output1.awk ! test/sun/tools/jps/jps-l_Output1.awk ! test/sun/tools/jps/jps_Output1.awk From fredrik.ohrstrom at oracle.com Mon Oct 29 06:24:10 2012 From: fredrik.ohrstrom at oracle.com (fredrik.ohrstrom at oracle.com) Date: Mon, 29 Oct 2012 13:24:10 +0000 Subject: hg: jdk8/tl/corba: 8000970: break out auxiliary classes that will prevent multi-core compilation of the JDK. Message-ID: <20121029132412.718A647644@hg.openjdk.java.net> Changeset: 643e7612cf6d Author: ohrstrom Date: 2012-10-29 14:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/643e7612cf6d 8000970: break out auxiliary classes that will prevent multi-core compilation of the JDK. Reviewed-by: alanb, wetmore ! src/share/classes/com/sun/corba/se/impl/util/IdentityHashtable.java + src/share/classes/com/sun/corba/se/impl/util/IdentityHashtableEntry.java From fredrik.ohrstrom at oracle.com Mon Oct 29 06:25:12 2012 From: fredrik.ohrstrom at oracle.com (fredrik.ohrstrom at oracle.com) Date: Mon, 29 Oct 2012 13:25:12 +0000 Subject: hg: jdk8/tl/jdk: 8000970: break out auxiliary classes that will prevent multi-core compilation of the JDK Message-ID: <20121029132537.2347B47645@hg.openjdk.java.net> Changeset: 17384fc6b31f Author: ohrstrom Date: 2012-10-29 14:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17384fc6b31f 8000970: break out auxiliary classes that will prevent multi-core compilation of the JDK Reviewed-by: alanb, wetmore + make/tools/src/build/tools/generatenimbus/AbstractGradient.java + make/tools/src/build/tools/generatenimbus/Border.java + make/tools/src/build/tools/generatenimbus/Canvas.java + make/tools/src/build/tools/generatenimbus/ComponentColor.java + make/tools/src/build/tools/generatenimbus/Dimension.java + make/tools/src/build/tools/generatenimbus/Ellipse.java + make/tools/src/build/tools/generatenimbus/Gradient.java + make/tools/src/build/tools/generatenimbus/GradientStop.java + make/tools/src/build/tools/generatenimbus/Insets.java + make/tools/src/build/tools/generatenimbus/Layer.java + make/tools/src/build/tools/generatenimbus/Matte.java ! make/tools/src/build/tools/generatenimbus/Paint.java + make/tools/src/build/tools/generatenimbus/Path.java + make/tools/src/build/tools/generatenimbus/Point.java + make/tools/src/build/tools/generatenimbus/RadialGradient.java + make/tools/src/build/tools/generatenimbus/Rectangle.java ! make/tools/src/build/tools/generatenimbus/Shape.java ! make/tools/src/build/tools/generatenimbus/SynthModel.java + make/tools/src/build/tools/generatenimbus/Typeface.java + make/tools/src/build/tools/generatenimbus/UIColor.java + make/tools/src/build/tools/generatenimbus/UIComponent.java ! make/tools/src/build/tools/generatenimbus/UIDefault.java + make/tools/src/build/tools/generatenimbus/UIFont.java + make/tools/src/build/tools/generatenimbus/UIIconRegion.java + make/tools/src/build/tools/generatenimbus/UIProperty.java + make/tools/src/build/tools/generatenimbus/UIRegion.java + make/tools/src/build/tools/generatenimbus/UIState.java + make/tools/src/build/tools/generatenimbus/UIStateType.java ! make/tools/src/build/tools/generatenimbus/UIStyle.java ! src/share/classes/javax/management/timer/Timer.java + src/share/classes/javax/management/timer/TimerAlarmClock.java + src/share/classes/sun/awt/im/ExecutableInputMethodManager.java ! src/share/classes/sun/awt/im/InputMethodManager.java + src/share/classes/sun/misc/FDBigInt.java ! src/share/classes/sun/misc/FloatingDecimal.java ! src/share/classes/sun/net/httpserver/Event.java + src/share/classes/sun/net/httpserver/WriteFinishedEvent.java + src/share/classes/sun/net/www/http/KeepAliveCleanerEntry.java ! src/share/classes/sun/net/www/http/KeepAliveStream.java + src/share/classes/sun/security/ssl/ExtensionType.java + src/share/classes/sun/security/ssl/HelloExtension.java ! src/share/classes/sun/security/ssl/HelloExtensions.java + src/share/classes/sun/security/ssl/RenegotiationInfoExtension.java + src/share/classes/sun/security/ssl/ServerNameExtension.java + src/share/classes/sun/security/ssl/SignatureAlgorithmsExtension.java + src/share/classes/sun/security/ssl/SupportedEllipticCurvesExtension.java + src/share/classes/sun/security/ssl/SupportedEllipticPointFormatsExtension.java + src/share/classes/sun/security/ssl/UnknownExtension.java ! src/solaris/classes/sun/awt/X11/XChoicePeer.java + src/solaris/classes/sun/awt/X11/XChoicePeerListener.java + src/solaris/classes/sun/font/DelegateStrike.java ! src/solaris/classes/sun/font/NativeStrike.java ! src/solaris/classes/sun/java2d/jules/JulesAATileGenerator.java + src/solaris/classes/sun/java2d/jules/TileTrapContainer.java From jaroslav.bachorik at oracle.com Mon Oct 29 07:15:21 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Mon, 29 Oct 2012 15:15:21 +0100 Subject: [PATCH] JDK-7146162: javax/management/remote/mandatory/connection/BrokenConnectionTest.java failing intermittently Message-ID: <508E8F79.60909@oracle.com> I am looking for a sponsor and reviewers. The webrev is available at http://cr.openjdk.java.net/~jbachorik/JDK-7146162/webrev.03 As explained in the issue the failure is caused by the RMI connection heart-beat thread racing against the thread executing the MBean operation and encountering the IOException. The heart beat thread sets the the admin state to "terminated" but does not send the failure notifications. On the other side the operation thread determines the state to be already terminated and skips the notifications as well. The fix adds the call to handle an ioexception, including sending the failure notifications, to the hear-beat connection failure handler. Also it widens the synchronized block since the whole code block checking for the connection failure and recovering must be run atomically, Thanks, -JB- From yumin.qi at oracle.com Mon Oct 29 09:19:12 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Mon, 29 Oct 2012 09:19:12 -0700 Subject: RFR: 8000489: older builds of hsdis don't work anymore after 6879063 In-Reply-To: <5088629D.70303@oracle.com> References: <50881EDA.8020100@oracle.com> <50885A77.5030800@oracle.com> <5088629D.70303@oracle.com> Message-ID: <508EAC80.2060000@oracle.com> Serguei and Krys If you are OK with the second version, I will do integration into hotspot_rt. http://cr.openjdk.java.net/~minqi/8000489 Thanks Yumin On 10/24/2012 2:50 PM, serguei.spitsyn at oracle.com wrote: > > || Yumin, > > *src/share/tools/hsdis/hsdis.h: > * > > A typo in the comment: > > 62 /* This is the compatability interface for older version of hotspot */ > => > 62 /* This is the compatibility interface for older versions of hotspot */ > > ||*|src|/share/tools/hsdis/hsdis-demo.c:* > > Would it make sense to change this to avoid using literal name? : > > 219 printf("Decoding from %p to %p...with decode_instructions_virtual\n", from, to); > => > 219 printf("Decoding from %p to %p...with %s\n", from, to,DECODE_INSTRUCTIONS_NAME); > > and > > 238 printf("Decoding from %p to %p...with old decode_instructions\n", from, to); > => > 238 printf("Decoding from %p to %p...with old %s\n", from, to,DECODE_INSTRUCTIONS); > > The (raw&& xml) is a special case of the (raw) so that the 4 lines: > > 225 if (raw&& xml) { > 226 res = (*decode_instructions_v)(from, to, (unsigned char*)from, to - from, simple_handle_event, stdout, NULL, stdout, options); > 227 } else if (raw) { > 228 res = (*decode_instructions_v)(from, to, (unsigned char*)from, to - from, simple_handle_event, stdout, NULL, stdout, options); > can be replaced with just 2 lines: > 225 if (raw) { > 226 res = (*decode_instructions_v)(from, to, (unsigned char*)from, to - from, simple_handle_event, stdout, NULL, stdout, options); > > > Thanks, > Serguei > > > > > Thanks, > Serguei > > > On 10/24/12 2:15 PM, yumin.qi at oracle.com wrote: >> Krystal, >> >> Thanks. Updated in same webrev. >> I checked b10, the output looks OK >> >> /Yumin >> >> On 10/24/2012 12:24 PM, Krystal Mok wrote: >>> Hi Yumin, >>> >>> minor typos: >>> s/instrurctions/instructions/ >>> >>> By the way, I tried to use a build of hsdis plugin after 6879063 in >>> an earlier JDK build (e.g. JDK8b59) and it was working strangely. A >>> rough look at the output looks like it's missing some newlines, I >>> didn't go into the details. Could you please check if this fix makes >>> the hsdis plugin work properly on earlier JDK builds as well? >>> >>> Thanks, >>> Kris >>> >>> On Thu, Oct 25, 2012 at 1:01 AM, >> > wrote: >>> >>> Hi, all >>> >>> Can I have your codereview of 8000489: older builds of hsdis >>> don't work anymore after 6879063 >>> It caused old build broke the disassembler. >>> >>> Webrev: http://cr.openjdk.java.net/~minqi/8000489 >>> >>> >>> Thanks >>> Yumin >>> >>> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121029/96de60b4/attachment.html From serguei.spitsyn at oracle.com Mon Oct 29 09:36:43 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Mon, 29 Oct 2012 09:36:43 -0700 Subject: RFR: 8000489: older builds of hsdis don't work anymore after 6879063 In-Reply-To: <508EAC80.2060000@oracle.com> References: <50881EDA.8020100@oracle.com> <50885A77.5030800@oracle.com> <5088629D.70303@oracle.com> <508EAC80.2060000@oracle.com> Message-ID: <508EB09B.7080508@oracle.com> Looks good. Thanks, Serguei On 10/29/12 9:19 AM, Yumin Qi wrote: > Serguei and Krys > > If you are OK with the second version, I will do integration into > hotspot_rt. > http://cr.openjdk.java.net/~minqi/8000489 > > Thanks > Yumin > > On 10/24/2012 2:50 PM, serguei.spitsyn at oracle.com wrote: >> >> || Yumin, >> >> *src/share/tools/hsdis/hsdis.h: >> * >> >> A typo in the comment: >> >> 62 /* This is the compatability interface for older version of hotspot */ >> => >> 62 /* This is the compatibility interface for older versions of hotspot */ >> >> ||*|src|/share/tools/hsdis/hsdis-demo.c:* >> >> Would it make sense to change this to avoid using literal name? : >> >> 219 printf("Decoding from %p to %p...with decode_instructions_virtual\n", from, to); >> => >> 219 printf("Decoding from %p to %p...with %s\n", from, to,DECODE_INSTRUCTIONS_NAME); >> >> and >> >> 238 printf("Decoding from %p to %p...with old decode_instructions\n", from, to); >> => >> 238 printf("Decoding from %p to %p...with old %s\n", from, to,DECODE_INSTRUCTIONS); >> >> The (raw && xml) is a special case of the (raw) so that the 4 lines: >> >> 225 if (raw && xml) { >> 226 res = (*decode_instructions_v)(from, to, (unsigned char*)from, to - from, simple_handle_event, stdout, NULL, stdout, options); >> 227 } else if (raw) { >> 228 res = (*decode_instructions_v)(from, to, (unsigned char*)from, to - from, simple_handle_event, stdout, NULL, stdout, options); >> can be replaced with just 2 lines: >> 225 if (raw) { >> 226 res = (*decode_instructions_v)(from, to, (unsigned char*)from, to - from, simple_handle_event, stdout, NULL, stdout, options); >> >> >> Thanks, >> Serguei >> >> >> >> >> Thanks, >> Serguei >> >> >> On 10/24/12 2:15 PM, yumin.qi at oracle.com wrote: >>> Krystal, >>> >>> Thanks. Updated in same webrev. >>> I checked b10, the output looks OK >>> >>> /Yumin >>> >>> On 10/24/2012 12:24 PM, Krystal Mok wrote: >>>> Hi Yumin, >>>> >>>> minor typos: >>>> s/instrurctions/instructions/ >>>> >>>> By the way, I tried to use a build of hsdis plugin after 6879063 in >>>> an earlier JDK build (e.g. JDK8b59) and it was working strangely. A >>>> rough look at the output looks like it's missing some newlines, I >>>> didn't go into the details. Could you please check if this fix >>>> makes the hsdis plugin work properly on earlier JDK builds as well? >>>> >>>> Thanks, >>>> Kris >>>> >>>> On Thu, Oct 25, 2012 at 1:01 AM, >>> > wrote: >>>> >>>> Hi, all >>>> >>>> Can I have your codereview of 8000489: older builds of hsdis >>>> don't work anymore after 6879063 >>>> It caused old build broke the disassembler. >>>> >>>> Webrev: http://cr.openjdk.java.net/~minqi/8000489 >>>> >>>> >>>> Thanks >>>> Yumin >>>> >>>> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121029/13baef2c/attachment-0001.html From john.r.rose at oracle.com Mon Oct 29 09:57:15 2012 From: john.r.rose at oracle.com (John Rose) Date: Mon, 29 Oct 2012 09:57:15 -0700 Subject: RFR: 8000489: older builds of hsdis don't work anymore after 6879063 In-Reply-To: <50899E09.3050905@oracle.com> References: <50881EDA.8020100@oracle.com> <50899E09.3050905@oracle.com> Message-ID: <5B1D00DA-989D-4747-8A78-37269D08C722@oracle.com> On Oct 25, 2012, at 1:16 PM, Yumin Qi wrote: > To John's question, it doesn't require changes to disassembler.cpp: > > new version ---> decode_instructions_virtual > old version ---> decode_instructions ---> decode_instructions_virtual > > tested with b01 (JDK8) with new hsdis-i386.so. I think we are aiming to make all four combinations work: {old JVM , new JVM} x { old hsdis , new hsdis }. For this to work, there must be "tolerance" in both the JVM and hsdis for old code. That's why I was looking for a change to disassembler.cpp, so that old hsdis modules will still work. In particular, the older builds of hsdis won't work properly unless the new JVM looks for the old hsdis entry point (if it fails to find the new hsdis entry point, of course). Basically, I am expecting that if the new JVM fails to find hsdis`decode_instructions_virtual, it will look for hsdis`decode_instructions instead, and will call that latter function with the (fewer) arguments that it expected. Am I missing something here? ? John -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121029/82d7af3e/attachment.html From yumin.qi at oracle.com Mon Oct 29 10:35:09 2012 From: yumin.qi at oracle.com (Yumin Qi) Date: Mon, 29 Oct 2012 10:35:09 -0700 Subject: RFR: 8000489: older builds of hsdis don't work anymore after 6879063 In-Reply-To: <5B1D00DA-989D-4747-8A78-37269D08C722@oracle.com> References: <50881EDA.8020100@oracle.com> <50899E09.3050905@oracle.com> <5B1D00DA-989D-4747-8A78-37269D08C722@oracle.com> Message-ID: <508EBE4D.9050903@oracle.com> John, I haven't considered new JVM work with old hsdis. Will change disassemble.cpp to check: first decode_instructions_virtual exists, use it. If not, next check if decode_instructions exists, then use it. As you expected, it will look like / new hsdis -> decode_instructions -> decode_instructions_virtual old VM \ old hsdis -> decode_instructions / new hsdis -> decode_instructions_virtual new VM \ old hsdis -> decode_instructions Thanks Yumin On 10/29/2012 9:57 AM, John Rose wrote: > On Oct 25, 2012, at 1:16 PM, Yumin Qi wrote: > >> To John's question, it doesn't require changes to disassembler.cpp: >> >> new version ---> decode_instructions_virtual >> old version ---> decode_instructions ---> decode_instructions_virtual >> >> tested with b01 (JDK8) with new hsdis-i386.so. > > I think we are aiming to make all four combinations work: {old JVM , > new JVM} x { old hsdis , new hsdis }. > > For this to work, there must be "tolerance" in both the JVM and hsdis > for old code. That's why I was looking for a change to > disassembler.cpp, so that old hsdis modules will still work. > > In particular, the older builds of hsdis won't work properly unless > the new JVM looks for the old hsdis entry point (if it fails to find > the new hsdis entry point, of course). > > Basically, I am expecting that if the new JVM fails to find > hsdis`decode_instructions_virtual, it will look for > hsdis`decode_instructions instead, and will call that latter function > with the (fewer) arguments that it expected. > > Am I missing something here? > > ? John -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121029/ab018a2e/attachment.html From robert.field at oracle.com Mon Oct 29 10:40:22 2012 From: robert.field at oracle.com (robert.field at oracle.com) Date: Mon, 29 Oct 2012 17:40:22 +0000 Subject: hg: jdk8/tl/langtools: 8000694: Add generation of lambda implementation code: invokedynamic call, lambda method, adaptor methods Message-ID: <20121029174026.863944764F@hg.openjdk.java.net> Changeset: a65971893c50 Author: rfield Date: 2012-10-29 10:39 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a65971893c50 8000694: Add generation of lambda implementation code: invokedynamic call, lambda method, adaptor methods Summary: Add lambda implementation code with calling/supporting code elsewhere in the compiler Reviewed-by: mcimadamore, jjg ! src/share/classes/com/sun/tools/javac/code/Symtab.java + src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/util/Names.java From naoto.sato at oracle.com Mon Oct 29 10:43:25 2012 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Mon, 29 Oct 2012 17:43:25 +0000 Subject: hg: jdk8/tl/jdk: 8000997: Multiple locale sensitive services cannot be loaded Message-ID: <20121029174347.8406347650@hg.openjdk.java.net> Changeset: 7fa45c455034 Author: naoto Date: 2012-10-29 10:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7fa45c455034 8000997: Multiple locale sensitive services cannot be loaded Reviewed-by: okutsu ! src/share/classes/sun/util/locale/provider/LocaleServiceProviderPool.java ! src/share/classes/sun/util/locale/provider/SPILocaleProviderAdapter.java ! test/java/util/PluggableLocale/CurrencyNameProviderTest.java ! test/java/util/PluggableLocale/CurrencyNameProviderTest.sh ! test/java/util/PluggableLocale/GenericTest.java ! test/java/util/PluggableLocale/barprovider.jar + test/java/util/PluggableLocale/providersrc/CurrencyNameProviderImpl2.java ! test/java/util/PluggableLocale/providersrc/Makefile ! test/java/util/PluggableLocale/providersrc/java.util.spi.CurrencyNameProvider From john.r.rose at oracle.com Mon Oct 29 10:47:34 2012 From: john.r.rose at oracle.com (John Rose) Date: Mon, 29 Oct 2012 10:47:34 -0700 Subject: RFR: 8000489: older builds of hsdis don't work anymore after 6879063 In-Reply-To: <508EBE4D.9050903@oracle.com> References: <50881EDA.8020100@oracle.com> <50899E09.3050905@oracle.com> <5B1D00DA-989D-4747-8A78-37269D08C722@oracle.com> <508EBE4D.9050903@oracle.com> Message-ID: On Oct 29, 2012, at 10:35 AM, Yumin Qi wrote: > I haven't considered new JVM work with old hsdis. Will change disassemble.cpp to check: Perfect! Thanks, ? John -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121029/a232cb22/attachment.html From staffan.larsen at oracle.com Mon Oct 29 14:46:27 2012 From: staffan.larsen at oracle.com (staffan.larsen at oracle.com) Date: Mon, 29 Oct 2012 21:46:27 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 8001619: Remove usage of _ALLBSD_SOURCE in bsd files Message-ID: <20121029214632.E7A014766D@hg.openjdk.java.net> Changeset: 0af5da0c9d9d Author: sla Date: 2012-10-29 21:04 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/0af5da0c9d9d 8001619: Remove usage of _ALLBSD_SOURCE in bsd files Reviewed-by: coleenp, dholmes ! src/os/bsd/vm/attachListener_bsd.cpp ! src/os/bsd/vm/osThread_bsd.hpp ! src/os/bsd/vm/os_bsd.cpp ! src/os/bsd/vm/os_bsd.hpp ! src/os_cpu/bsd_x86/vm/bytes_bsd_x86.inline.hpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp From mike.duigou at oracle.com Mon Oct 29 16:55:13 2012 From: mike.duigou at oracle.com (mike.duigou at oracle.com) Date: Mon, 29 Oct 2012 23:55:13 +0000 Subject: hg: jdk8/tl/jdk: 6206780: (str) Forwarding append methods in String{Buffer, Builder} are inconsistent Message-ID: <20121029235552.4F8934766E@hg.openjdk.java.net> Changeset: e2f976a73afb Author: jgish Date: 2012-10-29 16:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2f976a73afb 6206780: (str) Forwarding append methods in String{Buffer,Builder} are inconsistent Summary: update StringBuilder & StringBuffer to consistently handle forwarding to AbstractStringBuilder. Some additional cleanup (removal of refs to sub-classes from AbstractStringBuilder) Reviewed-by: chegar, alanb, mduigou ! src/share/classes/java/lang/AbstractStringBuilder.java ! src/share/classes/java/lang/StringBuffer.java ! src/share/classes/java/lang/StringBuilder.java + test/java/lang/StringBuffer/AppendStringBuilder.java + test/java/lang/StringBuffer/BufferForwarding.java + test/java/lang/StringBuffer/TestSynchronization.java + test/java/lang/StringBuilder/AppendStringBuffer.java + test/java/lang/StringBuilder/BuilderForwarding.java From yumin.qi at oracle.com Mon Oct 29 19:11:29 2012 From: yumin.qi at oracle.com (yumin.qi at oracle.com) Date: Tue, 30 Oct 2012 02:11:29 +0000 Subject: hg: hsx/hotspot-rt/hotspot: 2 new changesets Message-ID: <20121030021136.35DDD47671@hg.openjdk.java.net> Changeset: 39556eae08af Author: sspitsyn Date: 2012-10-29 11:35 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/39556eae08af 6533010: SPEC: A few broken links in jvmti.html Summary: Fix the incorrect links in jvmti.html reported by the LinkCheck tool Reviewed-by: jjh, dholmes Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmti.xml ! src/share/vm/prims/jvmtiEnvBase.hpp Changeset: 845129b692f6 Author: minqi Date: 2012-10-29 16:39 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/845129b692f6 Merge From eamonn at mcmanus.net Tue Oct 30 09:10:21 2012 From: eamonn at mcmanus.net (Eamonn McManus) Date: Tue, 30 Oct 2012 09:10:21 -0700 Subject: [PATCH] JDK-7146162: javax/management/remote/mandatory/connection/BrokenConnectionTest.java failing intermittently In-Reply-To: <508E8F79.60909@oracle.com> References: <508E8F79.60909@oracle.com> Message-ID: This area has historically caused a lot of problems and I am not surprised to see that there are more. While I don't know what the best way to fix the issue at hand is, I don't think this proposed change is it. The reason is that the checkConnection and gotIOException methods do blocking operations, and it is generally not a good idea to do blocking operations in a synchronized block. Is there a way to avoid the race condition without that? ?amonn 2012/10/29 Jaroslav Bachorik : > I am looking for a sponsor and reviewers. > > The webrev is available at > http://cr.openjdk.java.net/~jbachorik/JDK-7146162/webrev.03 > > As explained in the issue the failure is caused by the RMI connection > heart-beat thread racing against the thread executing the MBean > operation and encountering the IOException. The heart beat thread sets > the the admin state to "terminated" but does not send the failure > notifications. On the other side the operation thread determines the > state to be already terminated and skips the notifications as well. > > The fix adds the call to handle an ioexception, including sending the > failure notifications, to the hear-beat connection failure handler. Also > it widens the synchronized block since the whole code block checking for > the connection failure and recovering must be run atomically, > > > Thanks, > > -JB- From jonathan.gibbons at oracle.com Tue Oct 30 10:15:55 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Tue, 30 Oct 2012 17:15:55 +0000 Subject: hg: jdk8/tl/langtools: 8001929: fix doclint errors in langtools doc comments Message-ID: <20121030171600.95A7C47683@hg.openjdk.java.net> Changeset: 23fe1a96bc0f Author: jjg Date: 2012-10-30 10:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/23fe1a96bc0f 8001929: fix doclint errors in langtools doc comments Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPath.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SourcePath.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/javac/code/TypeTag.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java From serguei.spitsyn at oracle.com Tue Oct 30 10:30:41 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 30 Oct 2012 10:30:41 -0700 Subject: 1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge Message-ID: <50900EC1.4020109@oracle.com> Hello, Please, review the fix for CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194607 CR in JIRA: https://jbs.oracle.com/bugs/browse/JDK-7194607 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7194607-JVMTI-max_size Summary: This issue is caused by the changes in the oops/method.hpp for invokedynamic (JSR 292). Now the max_stack() adds +2 to the original code attribute stack size if invokedynamic is enabled. The verifier_max_stack() must be used in the jvmtiClassFileReconstituter.cpp instead of the max_size() to get the code attribute stack size. Thanks, Serguei -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121030/4878983d/attachment.html From daniel.daugherty at oracle.com Tue Oct 30 10:37:01 2012 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 30 Oct 2012 13:37:01 -0400 Subject: 1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge In-Reply-To: <50900EC1.4020109@oracle.com> References: <50900EC1.4020109@oracle.com> Message-ID: <5090103D.1080404@oracle.com> Thumbs up. Is someone going to do an audit for similar missing changes from max_stack() (not max_size()) to verifier_max_stack()? Dan On 10/30/12 1:30 PM, serguei.spitsyn at oracle.com wrote: > Hello, > > > Please, review the fix for CR: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194607 > > CR in JIRA: > https://jbs.oracle.com/bugs/browse/JDK-7194607 > > Open webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7194607-JVMTI-max_size > > > Summary: > > This issue is caused by the changes in the oops/method.hpp for > invokedynamic (JSR 292). > Now the max_stack() adds +2 to the original code attribute stack size > if invokedynamic is enabled. > The verifier_max_stack() must be used in the > jvmtiClassFileReconstituter.cpp > instead of the max_size() to get the code attribute stack size. > > > Thanks, > Serguei > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121030/0ea0a473/attachment.html From serguei.spitsyn at oracle.com Tue Oct 30 10:41:25 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 30 Oct 2012 10:41:25 -0700 Subject: 1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge In-Reply-To: <5090103D.1080404@oracle.com> References: <50900EC1.4020109@oracle.com> <5090103D.1080404@oracle.com> Message-ID: <50901145.1040500@oracle.com> I have a plan to look at it, at least for other serviceablity code. It'd be good if someone from the runtime or compiler team checked it too. Thanks, Serguei On 10/30/12 10:37 AM, Daniel D. Daugherty wrote: > Thumbs up. > > Is someone going to do an audit for similar missing changes > from max_stack() (not max_size()) to verifier_max_stack()? > > Dan > > > On 10/30/12 1:30 PM, serguei.spitsyn at oracle.com wrote: >> Hello, >> >> >> Please, review the fix for CR: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194607 >> >> CR in JIRA: >> https://jbs.oracle.com/bugs/browse/JDK-7194607 >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7194607-JVMTI-max_size >> >> >> Summary: >> >> This issue is caused by the changes in the oops/method.hpp for >> invokedynamic (JSR 292). >> Now the max_stack() adds +2 to the original code attribute stack size >> if invokedynamic is enabled. >> The verifier_max_stack() must be used in the >> jvmtiClassFileReconstituter.cpp >> instead of the max_size() to get the code attribute stack size. >> >> >> Thanks, >> Serguei >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121030/128eb433/attachment-0001.html From serguei.spitsyn at oracle.com Tue Oct 30 10:42:19 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 30 Oct 2012 10:42:19 -0700 Subject: 1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge In-Reply-To: <5090103D.1080404@oracle.com> References: <50900EC1.4020109@oracle.com> <5090103D.1080404@oracle.com> Message-ID: <5090117B.1060106@oracle.com> On 10/30/12 10:37 AM, Daniel D. Daugherty wrote: > Thumbs up. Thanks, Dan! Serguei > > Is someone going to do an audit for similar missing changes > from max_stack() (not max_size()) to verifier_max_stack()? > > Dan > > > On 10/30/12 1:30 PM, serguei.spitsyn at oracle.com wrote: >> Hello, >> >> >> Please, review the fix for CR: >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194607 >> >> CR in JIRA: >> https://jbs.oracle.com/bugs/browse/JDK-7194607 >> >> Open webrev: >> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7194607-JVMTI-max_size >> >> >> Summary: >> >> This issue is caused by the changes in the oops/method.hpp for >> invokedynamic (JSR 292). >> Now the max_stack() adds +2 to the original code attribute stack size >> if invokedynamic is enabled. >> The verifier_max_stack() must be used in the >> jvmtiClassFileReconstituter.cpp >> instead of the max_size() to get the code attribute stack size. >> >> >> Thanks, >> Serguei >> -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121030/5b66ad58/attachment.html From serguei.spitsyn at oracle.com Tue Oct 30 16:25:57 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Tue, 30 Oct 2012 16:25:57 -0700 Subject: 1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge In-Reply-To: <50901145.1040500@oracle.com> References: <50900EC1.4020109@oracle.com> <5090103D.1080404@oracle.com> <50901145.1040500@oracle.com> Message-ID: <50906205.8020607@oracle.com> Ok, it seems there are some suspicious fragments in the interpreter code. Christian, could you, please, check and comment the fragments below? This is how the Method::max_stack() is defined: *src/share/vm/oops/method.hpp*: int verifier_max_stack() const { return _max_stack; } int max_stack() const { return _max_stack + extra_stack_entries(); } void set_max_stack(int size) { _max_stack = size; } . . . static int extra_stack_entries() { return EnableInvokeDynamic ? 2 : 0; } The following code fragments are unaware that the method->max_stack() returns _max_stack + extra_stack_entries() : *src/cpu/sparc/vm/cppInterpreter_sparc.cpp*: *src/cpu/sparc/vm/cppInterpreter_***x86*.cpp*: static int size_activation_helper(int callee_extra_locals, int max_stack, int monitor_size) { . . . const int extra_stack = 0; //6815692//Method::extra_stack_entries(); ???? return (round_to(max_stack + extra_stack + . . . } . . . void BytecodeInterpreter::layout_interpreterState(interpreterState to_fill, . . . int extra_stack = 0; //6815692//Method::extra_stack_entries(); ???? to_fill->_stack_limit = stack_base - (method->max_stack() + 1 + extra_stack); . . . } *src/cpu/sparc/vm/templateInterpreter_sparc.cpp*: static int size_activation_helper(int callee_extra_locals, int max_stack, int monitor_size) { . . . const int max_stack_words = max_stack * Interpreter::stackElementWords; return (round_to((max_stack_words //6815692//+ Method::extra_stack_words() ???? . . . } At the size_activation_helper call sites the second parameter is usually passed as method->max_stack(). *src/cpu/x86/vm/templateInterpreter_x86_32.cpp*: *src/cpu/x86/vm/templateInterpreter_x86_64.cpp*: int AbstractInterpreter::size_top_interpreter_activation(Method* method) { . . . const int extra_stack = Method::extra_stack_entries(); const int method_stack = (method->max_locals() + method->max_stack() + extra_stack) * Interpreter::stackElementWords; . . . } *src/share/vm/interpreter/oopMapCache.cpp*: void OopMapForCacheEntry::compute_map(TRAPS) { . . . // First check if it is a method where the stackmap is always empty if (method()->code_size() == 0 || method()->max_locals() + method()->max_stack() == 0) { _entry->set_mask_size(0); } else { . . . } Above, if the invokedynamic is enabled then the method()->max_stack() can not be 0. We need to check it if this fact does not break the fragment. I'm still looking at other places... Thanks, Serguei On 10/30/12 10:41 AM, serguei.spitsyn at oracle.com wrote: > I have a plan to look at it, at least for other serviceablity code. > It'd be good if someone from the runtime or compiler team checked it too. > > Thanks, > Serguei > > > On 10/30/12 10:37 AM, Daniel D. Daugherty wrote: >> Thumbs up. >> >> Is someone going to do an audit for similar missing changes >> from max_stack() (not max_size()) to verifier_max_stack()? >> >> Dan >> >> >> On 10/30/12 1:30 PM, serguei.spitsyn at oracle.com wrote: >>> Hello, >>> >>> >>> Please, review the fix for CR: >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194607 >>> >>> CR in JIRA: >>> https://jbs.oracle.com/bugs/browse/JDK-7194607 >>> >>> Open webrev: >>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7194607-JVMTI-max_size >>> >>> >>> Summary: >>> >>> This issue is caused by the changes in the oops/method.hpp for >>> invokedynamic (JSR 292). >>> Now the max_stack() adds +2 to the original code attribute stack >>> size if invokedynamic is enabled. >>> The verifier_max_stack() must be used in the >>> jvmtiClassFileReconstituter.cpp >>> instead of the max_size() to get the code attribute stack size. >>> >>> >>> Thanks, >>> Serguei >>> > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121030/671fd34f/attachment.html From david.holmes at oracle.com Wed Oct 31 00:29:58 2012 From: david.holmes at oracle.com (David Holmes) Date: Wed, 31 Oct 2012 17:29:58 +1000 Subject: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling Message-ID: <5090D376.4080204@oracle.com> http://cr.openjdk.java.net/~dholmes/8002034/webrev/ This mainly addresses JDK-8002034 Allow Full Debug Symbols when cross-compiling The initial FDS work simply disables FDS when cross-compilation is involved. But we're now ready to deal with the cross-compilation case (and even if we weren't these changes would be fine anyway). So if FDS is initially enabled we will rely on ALT_OBJCOPY being set to the correct value for cross-compilation; and we don't set the default OBJCOPY in that case. So if you do nothing when cross-compiling OBJCOPY will be empty and that will cause the build to disable FDS, just as if the OBJCOPY command was not found. As this is the same code that causes: JDK-8001756 Hotspot makefiles report missing OBJCOPY command in the wrong circumstances I also fixed this by moving the OBJCOPY checks inside the ENABLE_FULL_DEBUG_SYMBOLS=1 conditional. Basically unless we are asking for FDS we shouldn't complain if the OBJCOPY command is not found. This will be pushed to the hotspot-emb repo as it is needed there ASAP. I'll be doing a similar change, under 8002040, for the JDK side of things. Thanks, David From jaroslav.bachorik at oracle.com Wed Oct 31 05:59:28 2012 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Wed, 31 Oct 2012 13:59:28 +0100 Subject: [PATCH] JDK-7146162: javax/management/remote/mandatory/connection/BrokenConnectionTest.java failing intermittently In-Reply-To: References: <508E8F79.60909@oracle.com> Message-ID: <509120B0.6040703@oracle.com> On 10/30/2012 05:10 PM, Eamonn McManus wrote: > This area has historically caused a lot of problems and I am not > surprised to see that there are more. While I don't know what the best > way to fix the issue at hand is, I don't think this proposed change is > it. The reason is that the checkConnection and gotIOException methods > do blocking operations, and it is generally not a good idea to do > blocking operations in a synchronized block. Is there a way to avoid > the race condition without that? The important part is calling the gotIOException() method even from the heart-beat checker. I've tried to return the synchronization block back to the original state and the test passes with the check period of 10ms which pushes the probability of data races rather high. It seems that the worst that can happen would be one additional checkConnection() call - in case when the state gets set to TERMINATED by another thread right after it has been checked in the synchronized block the loop condition might evaluate to true if the state value has not been flushed yet. I could change the "state" variable to be volatile but I am not sure whether it's worth the hassle. -JB- > > ?amonn > > > 2012/10/29 Jaroslav Bachorik : >> I am looking for a sponsor and reviewers. >> >> The webrev is available at >> http://cr.openjdk.java.net/~jbachorik/JDK-7146162/webrev.03 >> >> As explained in the issue the failure is caused by the RMI connection >> heart-beat thread racing against the thread executing the MBean >> operation and encountering the IOException. The heart beat thread sets >> the the admin state to "terminated" but does not send the failure >> notifications. On the other side the operation thread determines the >> state to be already terminated and skips the notifications as well. >> >> The fix adds the call to handle an ioexception, including sending the >> failure notifications, to the hear-beat connection failure handler. Also >> it widens the synchronized block since the whole code block checking for >> the connection failure and recovering must be run atomically, >> >> >> Thanks, >> >> -JB- From lana.steuck at oracle.com Wed Oct 31 09:51:03 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 31 Oct 2012 16:51:03 +0000 Subject: hg: jdk8/tl: 6 new changesets Message-ID: <20121031165104.977CE476B0@hg.openjdk.java.net> Changeset: 8343ccdd63f1 Author: katleman Date: 2012-10-18 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8343ccdd63f1 Added tag jdk8-b61 for changeset 20ff117b5090 ! .hgtags Changeset: c12e759ac4e8 Author: tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/c12e759ac4e8 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tbell Contributed-by: volker.simonis at gmail.com ! README-builds.html + make/scripts/fixpath.pl ! make/scripts/vsvars.sh Changeset: 8a3fe0ae06a8 Author: katleman Date: 2012-10-24 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8a3fe0ae06a8 Merge Changeset: 4e984be114bd Author: katleman Date: 2012-10-25 09:52 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/4e984be114bd Added tag jdk8-b62 for changeset 8a3fe0ae06a8 ! .hgtags Changeset: 744e165aaf33 Author: lana Date: 2012-10-23 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/744e165aaf33 Merge Changeset: ce212cd7ea69 Author: lana Date: 2012-10-25 20:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/ce212cd7ea69 Merge From lana.steuck at oracle.com Wed Oct 31 09:51:03 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 31 Oct 2012 16:51:03 +0000 Subject: hg: jdk8/tl/corba: 7 new changesets Message-ID: <20121031165111.69EB9476B1@hg.openjdk.java.net> Changeset: 2394155f9f9e Author: katleman Date: 2012-10-18 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/2394155f9f9e Added tag jdk8-b61 for changeset 0e08ba7648fb ! .hgtags Changeset: 0a5931be9176 Author: tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/0a5931be9176 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tbell Contributed-by: volker.simonis at gmail.com ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Platform.gmk Changeset: 08afb9c6f44f Author: katleman Date: 2012-10-24 13:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/08afb9c6f44f Merge Changeset: bbaef650c3d2 Author: katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/bbaef650c3d2 Added tag jdk8-b62 for changeset 08afb9c6f44f ! .hgtags Changeset: 23e0226a31ac Author: lana Date: 2012-10-23 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/23e0226a31ac Merge Changeset: 9094cd4a614f Author: lana Date: 2012-10-25 20:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/9094cd4a614f Merge ! make/common/shared/Defs-utils.gmk Changeset: aac74d377a03 Author: lana Date: 2012-10-30 23:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/aac74d377a03 Merge From lana.steuck at oracle.com Wed Oct 31 09:51:07 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 31 Oct 2012 16:51:07 +0000 Subject: hg: jdk8/tl/jaxws: 2 new changesets Message-ID: <20121031165118.90B9A476B2@hg.openjdk.java.net> Changeset: d265b9b4c0f5 Author: katleman Date: 2012-10-18 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/d265b9b4c0f5 Added tag jdk8-b61 for changeset 97e5e74e2a34 ! .hgtags Changeset: c27ea8d489e8 Author: katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/c27ea8d489e8 Added tag jdk8-b62 for changeset d265b9b4c0f5 ! .hgtags From lana.steuck at oracle.com Wed Oct 31 09:51:08 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 31 Oct 2012 16:51:08 +0000 Subject: hg: jdk8/tl/jaxp: 4 new changesets Message-ID: <20121031165128.3123A476B4@hg.openjdk.java.net> Changeset: 5d0fa0108d02 Author: katleman Date: 2012-10-18 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/5d0fa0108d02 Added tag jdk8-b61 for changeset 6b1db0b41d2f ! .hgtags Changeset: a96e34e038f5 Author: katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a96e34e038f5 Added tag jdk8-b62 for changeset 5d0fa0108d02 ! .hgtags Changeset: 23e1d537224b Author: lana Date: 2012-10-23 09:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/23e1d537224b Merge Changeset: fc589819b335 Author: lana Date: 2012-10-25 20:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/fc589819b335 Merge From lana.steuck at oracle.com Wed Oct 31 09:51:26 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 31 Oct 2012 16:51:26 +0000 Subject: hg: jdk8/tl/langtools: 5 new changesets Message-ID: <20121031165139.4864B476B5@hg.openjdk.java.net> Changeset: b47bb81ba962 Author: katleman Date: 2012-10-18 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b47bb81ba962 Added tag jdk8-b61 for changeset 26020b247ad3 ! .hgtags Changeset: 16498acd21b5 Author: katleman Date: 2012-10-25 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/16498acd21b5 Added tag jdk8-b62 for changeset b47bb81ba962 ! .hgtags Changeset: 5dde04b8bbb3 Author: lana Date: 2012-10-23 09:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5dde04b8bbb3 Merge Changeset: 669468143a5e Author: lana Date: 2012-10-25 20:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/669468143a5e Merge Changeset: 27f7952eea3c Author: lana Date: 2012-10-31 08:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/27f7952eea3c Merge From lana.steuck at oracle.com Wed Oct 31 09:52:52 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 31 Oct 2012 16:52:52 +0000 Subject: hg: jdk8/tl/hotspot: 84 new changesets Message-ID: <20121031165614.973FC476B6@hg.openjdk.java.net> Changeset: 81e878c53615 Author: amurillo Date: 2012-10-05 13:37 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/81e878c53615 8000498: new hotspot build - hs25-b05 Reviewed-by: jcoomes ! make/hotspot_version Changeset: d8ce2825b193 Author: coleenp Date: 2012-09-29 06:40 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d8ce2825b193 8000213: NPG: Should have renamed arrayKlass and typeArrayKlass Summary: Capitalize these metadata types (and objArrayKlass) Reviewed-by: stefank, twisti, kvn ! agent/src/share/classes/sun/jvm/hotspot/oops/ArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Klass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Metadata.java ! agent/src/share/classes/sun/jvm/hotspot/oops/ObjArrayKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/TypeArrayKlass.java ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciArrayKlass.cpp ! src/share/vm/ci/ciArrayKlass.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciKlass.hpp ! src/share/vm/ci/ciObjArrayKlass.cpp ! src/share/vm/ci/ciObjArrayKlass.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciTypeArrayKlass.cpp ! src/share/vm/ci/ciTypeArrayKlass.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/memory/specialized_oop_closures.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/arrayKlass.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayKlass.hpp ! src/share/vm/oops/objArrayKlass.inline.hpp ! src/share/vm/oops/objArrayOop.cpp ! src/share/vm/oops/objArrayOop.hpp ! src/share/vm/oops/oop.pcgc.inline.hpp ! src/share/vm/oops/oop.psgc.inline.hpp ! src/share/vm/oops/oopsHierarchy.hpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.hpp ! src/share/vm/oops/typeArrayOop.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/heapDumper.cpp ! src/share/vm/services/management.cpp ! src/share/vm/services/threadService.cpp ! src/share/vm/shark/sharkRuntime.cpp Changeset: fab6fbf427d2 Author: kevinw Date: 2012-09-30 23:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fab6fbf427d2 7200145: runtime/7196045/Test7196045.java fails with No class provided for `main' Reviewed-by: dholmes, dsamersoff ! test/runtime/7196045/Test7196045.java Changeset: ba8fd2fe198b Author: coleenp Date: 2012-10-04 08:38 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ba8fd2fe198b 7198519: Broken build, hotspot-rt win USE_PRECOMPILED_HEADER=0 Summary: Uncommented out include for sys/stat.h and deleted include statements that were commented out. Reviewed-by: coleenp, acorn, dholmes Contributed-by: harold.seigel at oracle.com ! src/os/windows/vm/jvm_windows.h Changeset: bacdc1d5c21c Author: coleenp Date: 2012-10-04 08:43 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bacdc1d5c21c 6884973: java -XX:Atomics=2 crashes Summary: Remove buggy experimental option Reviewed-by: acorn, coleenp Contributed-by: harold.seigel at oracle.com ! src/cpu/x86/vm/assembler_x86.cpp ! src/share/vm/runtime/globals.hpp Changeset: 48087f745a86 Author: dholmes Date: 2012-10-04 19:52 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/48087f745a86 7199186: runtime/7194254/Test7194254.java fails - wrong test name on @run Reviewed-by: kvn, twisti ! test/runtime/7194254/Test7194254.java Changeset: f2eb2d4488db Author: dholmes Date: 2012-10-04 20:09 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f2eb2d4488db Merge Changeset: 75982791ddb6 Author: coleenp Date: 2012-10-08 09:18 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/75982791ddb6 7170638: Use DTRACE_PROBE[N] in JNI Set and SetStatic Field. Summary: Don't use HS_DTRACE_PROBE_CDECL_N and HS_DTRACE_PROBE_N directly. Reviewed-by: coleenp, kamg, dholmes, sspitsyn Contributed-by: Mark Wielaard ! make/bsd/makefiles/buildtree.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/dtrace.make ! make/linux/makefiles/vm.make ! make/solaris/makefiles/buildtree.make ! src/share/vm/prims/jni.cpp ! src/share/vm/utilities/dtrace.hpp Changeset: 7a40901e0d5c Author: minqi Date: 2012-10-08 16:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7a40901e0d5c 8000332: SA ClassDump throws exception after permgen removal Summary: In ClassWrite.writeFields(), fields count was mistakenly set to fields length which overflow the array index. Also removed a file which is leftover from 6879063 changeset. Reviewed-by: coleenp, sspitsyn Contributed-by: yumin.qi at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java ! agent/src/share/native/sadis.c Changeset: 0e8ca886e4e1 Author: minqi Date: 2012-10-08 16:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/0e8ca886e4e1 Merge Changeset: 6e5a59a8e4a7 Author: rbackman Date: 2012-10-09 07:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6e5a59a8e4a7 Merge ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 26351ce8c4b0 Author: coleenp Date: 2012-10-09 02:42 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/26351ce8c4b0 8000622: Forgot to hg add and check in test for JDK-7170638 Summary: add the test Reviewed-by: coleenp, kamg Contributed-by: Mark Wielaard + test/serviceability/7170638/SDTProbesGNULinuxTest.sh Changeset: b9a9ed0f8eeb Author: mikael Date: 2012-10-09 10:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b9a9ed0f8eeb 7197424: update copyright year to match last edit in jdk8 hotspot repository Summary: Update copyright year to 2012 for relevant files Reviewed-by: dholmes, coleenp ! agent/src/share/classes/sun/jvm/hotspot/code/CodeCache.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdCDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdThreadContextFactory.java ! agent/src/share/classes/sun/jvm/hotspot/oops/BranchData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/CounterData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/JumpData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MultiBranchData.java ! agent/src/share/classes/sun/jvm/hotspot/oops/VirtualCallData.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/Bytes.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/BasicHashtable.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/BasicHashtableEntry.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/Hashtable.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HashtableBucket.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/HashtableEntry.java ! make/bsd/Makefile ! make/bsd/makefiles/adlc.make ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/dtrace.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/jvmg.make ! make/bsd/makefiles/launcher.make ! make/bsd/makefiles/product.make ! make/bsd/makefiles/rules.make ! make/bsd/makefiles/sparcWorks.make ! make/bsd/makefiles/top.make ! make/linux/makefiles/launcher.make ! make/linux/makefiles/ppc.make ! make/linux/makefiles/product.make ! make/linux/makefiles/rules.make ! make/linux/makefiles/sparcWorks.make ! make/linux/makefiles/top.make ! make/solaris/makefiles/adlc.make ! make/solaris/makefiles/gcc.make ! make/solaris/makefiles/jvmg.make ! make/solaris/makefiles/optimized.make ! make/solaris/makefiles/rules.make ! make/solaris/makefiles/top.make ! make/windows/build.bat ! make/windows/build_vm_def.sh ! make/windows/get_msc_ver.sh ! make/windows/makefiles/adlc.make ! make/windows/makefiles/launcher.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/rules.make ! make/windows/makefiles/sanity.make ! make/windows/makefiles/shared.make ! make/windows/makefiles/vm.make ! make/windows/projectfiles/common/Makefile ! src/cpu/sparc/vm/c1_FrameMap_sparc.cpp ! src/cpu/sparc/vm/c1_FrameMap_sparc.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.hpp ! src/cpu/sparc/vm/c1_LinearScan_sparc.hpp ! src/cpu/sparc/vm/interpreterGenerator_sparc.hpp ! src/cpu/x86/vm/c1_FrameMap_x86.cpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LinearScan_x86.cpp ! src/cpu/x86/vm/interpreterGenerator_x86.hpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/cpu/x86/vm/templateTable_x86_32.hpp ! src/cpu/x86/vm/templateTable_x86_64.hpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/cpu/zero/vm/interpreterGenerator_zero.hpp ! src/cpu/zero/vm/methodHandles_zero.hpp ! src/os/bsd/vm/decoder_machO.cpp ! src/os/bsd/vm/os_bsd.inline.hpp ! src/os/bsd/vm/perfMemory_bsd.cpp ! src/os/linux/vm/decoder_linux.cpp ! src/os/linux/vm/os_linux.inline.hpp ! src/os/linux/vm/perfMemory_linux.cpp ! src/os/posix/launcher/java_md.c ! src/os/posix/launcher/launcher.script ! src/os/posix/vm/os_posix.cpp ! src/os/posix/vm/os_posix.hpp ! src/os/solaris/dtrace/hs_private.d ! src/os/solaris/vm/attachListener_solaris.cpp ! src/os/solaris/vm/decoder_solaris.cpp ! src/os/solaris/vm/os_solaris.hpp ! src/os/solaris/vm/os_solaris.inline.hpp ! src/os/solaris/vm/perfMemory_solaris.cpp ! src/os/windows/vm/decoder_windows.cpp ! src/os/windows/vm/decoder_windows.hpp ! src/os/windows/vm/os_windows.hpp ! src/os/windows/vm/perfMemory_windows.cpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.hpp ! src/os_cpu/bsd_x86/vm/os_bsd_x86.inline.hpp ! src/os_cpu/bsd_zero/vm/os_bsd_zero.cpp ! src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/os_cpu/linux_x86/vm/os_linux_x86.hpp ! src/os_cpu/linux_x86/vm/os_linux_x86.inline.hpp ! src/os_cpu/linux_zero/vm/os_linux_zero.cpp ! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp ! src/os_cpu/solaris_sparc/vm/vm_version_solaris_sparc.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.cpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.hpp ! src/os_cpu/solaris_x86/vm/os_solaris_x86.inline.hpp ! src/os_cpu/solaris_x86/vm/solaris_x86_32.il ! src/os_cpu/solaris_x86/vm/solaris_x86_64.il ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.hpp ! src/os_cpu/windows_x86/vm/os_windows_x86.inline.hpp ! src/share/tools/ProjectCreator/ProjectCreator.java ! src/share/tools/ProjectCreator/Util.java ! src/share/tools/ProjectCreator/WinGammaPlatform.java ! src/share/tools/ProjectCreator/WinGammaPlatformVC7.java ! src/share/vm/asm/assembler.cpp ! src/share/vm/asm/assembler.hpp ! src/share/vm/asm/register.hpp ! src/share/vm/c1/c1_CFGPrinter.cpp ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_Canonicalizer.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_Compiler.cpp ! src/share/vm/c1/c1_FrameMap.cpp ! src/share/vm/c1/c1_FrameMap.hpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_IR.cpp ! src/share/vm/c1/c1_IR.hpp ! src/share/vm/c1/c1_InstructionPrinter.hpp ! src/share/vm/c1/c1_LinearScan.cpp ! src/share/vm/c1/c1_LinearScan.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/c1/c1_ValueMap.cpp ! src/share/vm/c1/c1_ValueMap.hpp ! src/share/vm/c1/c1_ValueStack.cpp ! src/share/vm/c1/c1_ValueStack.hpp ! src/share/vm/ci/ciMethodHandle.hpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/ci/ciSymbol.cpp ! src/share/vm/ci/ciTypeFlow.hpp ! src/share/vm/classfile/classLoader.hpp ! src/share/vm/classfile/javaAssertions.hpp ! src/share/vm/code/stubs.cpp ! src/share/vm/code/stubs.hpp ! src/share/vm/code/vmreg.hpp ! src/share/vm/compiler/abstractCompiler.hpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp ! src/share/vm/gc_implementation/g1/dirtyCardQueue.hpp ! src/share/vm/gc_implementation/g1/g1MMUTracker.hpp ! src/share/vm/gc_implementation/g1/ptrQueue.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp ! src/share/vm/gc_implementation/g1/survRateGroup.hpp ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.hpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.cpp ! src/share/vm/gc_implementation/parallelScavenge/gcTaskThread.hpp ! src/share/vm/gc_implementation/parallelScavenge/objectStartArray.hpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psGenerationCounters.cpp ! src/share/vm/gc_implementation/parallelScavenge/psPromotionLAB.hpp ! src/share/vm/gc_implementation/parallelScavenge/psVirtualspace.hpp ! src/share/vm/gc_implementation/shared/adaptiveSizePolicy.hpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/gc_implementation/shared/collectorCounters.cpp ! src/share/vm/gc_implementation/shared/collectorCounters.hpp ! src/share/vm/gc_implementation/shared/gSpaceCounters.cpp ! src/share/vm/gc_implementation/shared/gSpaceCounters.hpp ! src/share/vm/gc_implementation/shared/gcPolicyCounters.hpp ! src/share/vm/gc_implementation/shared/gcStats.hpp ! src/share/vm/gc_implementation/shared/gcUtil.cpp ! src/share/vm/gc_implementation/shared/gcUtil.hpp ! src/share/vm/gc_implementation/shared/generationCounters.cpp ! src/share/vm/gc_implementation/shared/generationCounters.hpp ! src/share/vm/gc_implementation/shared/hSpaceCounters.cpp ! src/share/vm/gc_implementation/shared/hSpaceCounters.hpp ! src/share/vm/gc_implementation/shared/spaceCounters.cpp ! src/share/vm/gc_implementation/shared/spaceCounters.hpp ! src/share/vm/gc_implementation/shared/spaceDecorator.hpp ! src/share/vm/interpreter/interpreter.hpp ! src/share/vm/libadt/set.cpp ! src/share/vm/libadt/vectset.cpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/freeList.cpp ! src/share/vm/memory/freeList.hpp ! src/share/vm/memory/heap.cpp ! src/share/vm/memory/heap.hpp ! src/share/vm/memory/referencePolicy.hpp ! src/share/vm/memory/space.inline.hpp ! src/share/vm/memory/threadLocalAllocBuffer.hpp ! src/share/vm/oops/objArrayOop.hpp ! src/share/vm/opto/addnode.cpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/divnode.cpp ! src/share/vm/opto/domgraph.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/generateOptoStub.cpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/locknode.cpp ! src/share/vm/opto/locknode.hpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.hpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/opto/subnode.hpp ! src/share/vm/prims/jniExport.hpp ! src/share/vm/prims/jvmtiCodeBlobEvents.cpp ! src/share/vm/prims/jvmtiExtensions.cpp ! src/share/vm/prims/jvmtiRawMonitor.cpp ! src/share/vm/prims/jvmtiTagMap.hpp ! src/share/vm/prims/jvmtiUtil.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/dtraceJSDT.hpp ! src/share/vm/runtime/interfaceSupport.hpp ! src/share/vm/runtime/java.hpp ! src/share/vm/runtime/monitorChunk.cpp ! src/share/vm/runtime/monitorChunk.hpp ! src/share/vm/runtime/mutex.hpp ! src/share/vm/runtime/park.cpp ! src/share/vm/runtime/perfMemory.cpp ! src/share/vm/runtime/stubCodeGenerator.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/task.hpp ! src/share/vm/runtime/timer.cpp ! src/share/vm/runtime/vmThread.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/runtime/vm_version.hpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/g1MemoryPool.cpp ! src/share/vm/services/g1MemoryPool.hpp ! src/share/vm/services/lowMemoryDetector.hpp ! src/share/vm/services/memoryManager.hpp ! src/share/vm/trace/tracing.hpp ! src/share/vm/utilities/array.cpp ! src/share/vm/utilities/decoder.cpp ! src/share/vm/utilities/decoder_elf.cpp ! src/share/vm/utilities/elfFile.cpp ! src/share/vm/utilities/elfFile.hpp ! src/share/vm/utilities/elfStringTable.cpp ! src/share/vm/utilities/elfStringTable.hpp ! src/share/vm/utilities/elfSymbolTable.cpp ! src/share/vm/utilities/elfSymbolTable.hpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp ! src/share/vm/utilities/growableArray.cpp ! src/share/vm/utilities/histogram.cpp ! src/share/vm/utilities/histogram.hpp ! src/share/vm/utilities/intHisto.cpp ! src/share/vm/utilities/intHisto.hpp ! src/share/vm/utilities/preserveException.cpp ! src/share/vm/utilities/stack.hpp ! src/share/vm/utilities/stack.inline.hpp ! src/share/vm/utilities/taskqueue.hpp ! src/share/vm/utilities/vmError.hpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/workgroup.hpp ! test/compiler/6859338/Test6859338.java ! test/compiler/7116216/StackOverflow.java Changeset: c3e799c37717 Author: vlivanov Date: 2012-10-05 18:57 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c3e799c37717 7177003: C1: LogCompilation support Summary: add LogCompilation support in C1 - both client and tiered mode. Reviewed-by: twisti, kvn ! src/os/linux/vm/vmError_linux.cpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileLog.cpp ! src/share/vm/compiler/compileLog.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/utilities/ostream.cpp Changeset: 9a9b6e05ffb4 Author: vlivanov Date: 2012-10-05 19:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9a9b6e05ffb4 8000232: NPG: SIGSEGV in Dependencies::DepStream::check_klass_dependency on solaris-x64 Summary: Move decoding into Dependencies::DepStream::argument, so no caller could see encoded context value (NULL) anymore. Reviewed-by: twisti, kvn ! src/share/vm/code/dependencies.cpp Changeset: 9024b6b53ec2 Author: vlivanov Date: 2012-10-05 19:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9024b6b53ec2 8000485: Hotspot build fails in Solaris Studio IDE when building dtrace Summary: Prepend '.' to the existing native library path Reviewed-by: kvn, sspitsyn ! make/bsd/makefiles/dtrace.make ! make/solaris/makefiles/dtrace.make Changeset: 377508648226 Author: vlivanov Date: 2012-10-08 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/377508648226 8000313: C2 should use jlong for 64bit values Summary: Replace all occurrences of long with jlong in C2 code. Reviewed-by: kvn, twisti ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/phaseX.hpp Changeset: 65d07d9ee446 Author: twisti Date: 2012-10-08 17:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/65d07d9ee446 8000263: JSR 292: signature types may appear to be unloaded Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/globals.hpp Changeset: 8e47bac5643a Author: roland Date: 2012-10-09 10:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8e47bac5643a 7054512: Compress class pointers after perm gen removal Summary: support of compress class pointers in the compilers. Reviewed-by: kvn, twisti ! agent/src/share/classes/sun/jvm/hotspot/debugger/Address.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/Debugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/DebuggerBase.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/JVMDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/dummy/DummyAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/linux/LinuxDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/proc/ProcDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerClient.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerServer.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgAddress.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebugger.java ! agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/WindbgDebuggerLocal.java ! agent/src/share/classes/sun/jvm/hotspot/memory/Universe.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Array.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Instance.java ! agent/src/share/classes/sun/jvm/hotspot/oops/MetadataField.java + agent/src/share/classes/sun/jvm/hotspot/oops/NarrowKlassField.java ! agent/src/share/classes/sun/jvm/hotspot/oops/Oop.java ! agent/src/share/classes/sun/jvm/hotspot/oops/java_lang_Class.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/RobustOopDeterminator.java ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_MacroAssembler_sparc.cpp ! src/cpu/sparc/vm/relocInfo_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/c1_MacroAssembler_x86.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/os/bsd/dtrace/generateJvmOffsets.cpp ! src/os/bsd/dtrace/jhelper.d ! src/os/solaris/dtrace/generateJvmOffsets.cpp ! src/os/solaris/dtrace/jhelper.d ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/forms.cpp ! src/share/vm/adlc/forms.hpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/instanceOop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/live.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/machnode.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/matcher.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/subnode.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/utilities/globalDefinitions.cpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: f6badecb7ea7 Author: vlivanov Date: 2012-10-09 12:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f6badecb7ea7 7199654: Remove LoadUI2LNode Summary: Removed LoadUI2L node from Ideal nodes, use match rule in .ad files instead. Reviewed-by: kvn ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/forms.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/superword.cpp Changeset: d336b3173277 Author: kvn Date: 2012-10-09 16:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d336b3173277 8000592: Improve adlc usability Summary: several changes to adlc to improve its usability Reviewed-by: kvn Contributed-by: goetz.lindenmaier at sap.com ! src/share/vm/adlc/adlparse.cpp ! src/share/vm/adlc/archDesc.cpp ! src/share/vm/adlc/archDesc.hpp ! src/share/vm/adlc/dict2.cpp ! src/share/vm/adlc/filebuff.hpp ! src/share/vm/adlc/forms.hpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/adlc/formssel.hpp ! src/share/vm/adlc/main.cpp ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp Changeset: 94e9408dbf50 Author: roland Date: 2012-10-11 18:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/94e9408dbf50 8000753: compiler/6912517 crashes on 64bit sparc with compressed oops off Summary: code generated by c1 for getClass intrinsic broken when klass field is loaded on 64bit with compressed klass off. Reviewed-by: kvn ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp Changeset: 19eb999cb72c Author: twisti Date: 2012-10-11 14:46 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/19eb999cb72c 8000740: remove LinkWellKnownClasses Reviewed-by: kvn, jrose ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/globals.hpp Changeset: d804e148cff8 Author: kvn Date: 2012-10-12 09:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d804e148cff8 Merge ! make/bsd/makefiles/dtrace.make ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_GraphBuilder.hpp ! src/share/vm/c1/c1_Optimizer.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/method.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/connode.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/mulnode.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fb19af007ffc Author: jprovino Date: 2012-10-10 14:35 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fb19af007ffc 7189254: Change makefiles for more flexibility to override defaults Summary: Change makefiles so that targets and parameters can be overridden by alternate makefiles. Reviewed-by: dholmes, coleenp ! make/Makefile ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/defs.make ! make/bsd/makefiles/gcc.make ! make/bsd/makefiles/ia64.make + make/bsd/makefiles/minimal1.make ! make/bsd/makefiles/vm.make ! make/defs.make + make/excludeSrc.make ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/ia64.make + make/linux/makefiles/minimal1.make ! make/linux/makefiles/vm.make ! make/windows/makefiles/defs.make ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/heapInspection.hpp ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/memory/metaspaceShared.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/forte.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiEnter.xsl ! src/share/vm/prims/jvmtiEnvBase.hpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiImpl.hpp ! src/share/vm/prims/jvmtiRedefineClasses.hpp ! src/share/vm/prims/jvmtiTagMap.hpp ! src/share/vm/prims/jvmtiThreadState.hpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/fprofiler.hpp ! src/share/vm/runtime/globals_extension.hpp ! src/share/vm/runtime/init.cpp ! src/share/vm/runtime/perfData.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/classLoadingService.cpp ! src/share/vm/services/classLoadingService.hpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/diagnosticCommand.hpp ! src/share/vm/services/heapDumper.hpp ! src/share/vm/services/management.cpp ! src/share/vm/services/management.hpp ! src/share/vm/services/memReporter.hpp ! src/share/vm/services/memTracker.hpp ! src/share/vm/services/runtimeService.cpp ! src/share/vm/services/runtimeService.hpp ! src/share/vm/utilities/macros.hpp Changeset: bbeecede56dd Author: jiangli Date: 2012-10-11 14:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bbeecede56dd 8000459: assert(java_lang_String::is_instance(entry)) failure with various mlvm tests. Summary: Remove unneeded assert. Reviewed-by: sspitsyn, coleenp ! src/share/vm/prims/jvmtiTagMap.cpp Changeset: 9855b7e559ae Author: collins Date: 2012-10-12 10:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/9855b7e559ae Merge ! make/bsd/Makefile ! make/bsd/makefiles/buildtree.make ! make/bsd/makefiles/gcc.make ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/vm.make ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/jvmtiTagMap.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/services/attachListener.hpp ! src/share/vm/services/diagnosticCommand.cpp ! src/share/vm/services/management.cpp Changeset: 5876f980ea19 Author: collins Date: 2012-10-12 11:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5876f980ea19 Merge ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: b261523fe66c Author: amurillo Date: 2012-10-12 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b261523fe66c Merge Changeset: 4547dc71db76 Author: amurillo Date: 2012-10-12 13:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4547dc71db76 Added tag hs25-b05 for changeset b261523fe66c ! .hgtags Changeset: fcbdaeb69946 Author: katleman Date: 2012-10-18 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fcbdaeb69946 Added tag jdk8-b61 for changeset 4547dc71db76 ! .hgtags Changeset: 58fbf2da3c16 Author: amurillo Date: 2012-10-12 14:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/58fbf2da3c16 8000834: new hotspot build - hs25-b06 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 8a5ea0a9ccc4 Author: johnc Date: 2012-10-06 01:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8a5ea0a9ccc4 7127708: G1: change task num types from int to uint in concurrent mark Summary: Change the type of various task num fields, parameters etc to unsigned and rename them to be more consistent with the other collectors. Code changes were also reviewed by Vitaly Davidovich. Reviewed-by: johnc Contributed-by: Kaushik Srenevasan ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp Changeset: 04155d9c8c76 Author: johnc Date: 2012-10-08 09:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/04155d9c8c76 8000358: G1: metaspace information not printed in PrintHeapAtGC output nor in hs_err file Summary: Missing call to MetaspaceAux::print_on() in G1CollectedHeap::print_on(). Reviewed-by: azeemj, jmasa Contributed-by: Mikael Gerdin ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: dd2b66d09ccd Author: stefank Date: 2012-10-09 22:12 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dd2b66d09ccd 8000659: NPG: ClassCastExceptions are unexpectedly thrown when testing nashorn Summary: Treat the oops in invoke_method_table() as strong roots when ClassUnloading is enabled. Reviewed-by: kamg, coleenp ! src/share/vm/classfile/systemDictionary.cpp Changeset: 4202510ee0fe Author: johnc Date: 2012-10-15 10:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/4202510ee0fe 8000831: Heap verification output incorrect/incomplete Summary: Restore non-silent output of heap verification. Reviewed-by: ysr, brutisso, jmasa ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/utilities/debug.cpp Changeset: 633ba56cb013 Author: jmasa Date: 2012-10-17 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/633ba56cb013 Merge ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/memory/universe.hpp Changeset: bdb5f8c9978b Author: coleenp Date: 2012-10-10 17:04 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bdb5f8c9978b 7199068: NPG: SharedSkipVerify is meaningless Summary: Remove the SharedSkipVerify flag Reviewed-by: kamg, sspitsyn, coleenp Contributed-by: harold.seigel at oracle.com ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.hpp Changeset: 48a75d2640a5 Author: kamg Date: 2012-10-11 14:27 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/48a75d2640a5 7054345: Support version 52.0 class file in HotSpot Summary: Accept classfiles with major version 52 Reviewed-by: coleenp, acorn ! src/share/vm/classfile/classFileParser.cpp Changeset: e0ea0e94c23c Author: kevinw Date: 2012-10-15 16:48 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e0ea0e94c23c 7195151: Multiplatform tescase for 6929067 Reviewed-by: kamg, kvn ! test/runtime/6929067/Test6929067.sh Changeset: e52361627b65 Author: coleenp Date: 2012-10-15 22:33 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e52361627b65 Merge ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/runtime/globals.hpp Changeset: 045cb62046a7 Author: rbackman Date: 2012-08-28 15:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/045cb62046a7 7093328: JVMTI: jvmtiPrimitiveFieldCallback always report 0's for static primitives Reviewed-by: dholmes, dcubed ! src/share/vm/prims/jvmtiTagMap.cpp Changeset: 7b5885dadbdc Author: nloodin Date: 2012-10-17 17:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/7b5885dadbdc 8000617: It should be possible to allocate memory without the VM dying. Reviewed-by: coleenp, kamg ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/resourceArea.cpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: e8c79c2ba3f3 Author: coleenp Date: 2012-10-18 12:29 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e8c79c2ba3f3 Merge Changeset: d0337c31c8be Author: amurillo Date: 2012-10-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d0337c31c8be Merge Changeset: dccd40de8db1 Author: amurillo Date: 2012-10-19 11:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dccd40de8db1 Added tag hs25-b06 for changeset d0337c31c8be ! .hgtags Changeset: 556dd9e475c6 Author: katleman Date: 2012-10-25 09:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/556dd9e475c6 Added tag jdk8-b62 for changeset dccd40de8db1 ! .hgtags Changeset: d0e7716b179e Author: amurillo Date: 2012-10-19 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d0e7716b179e 8001176: new hotspot build - hs25-b07 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 85916677fc22 Author: coleenp Date: 2012-10-18 13:08 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/85916677fc22 7188233: UseVMInterruptibleIO flag deprecate for JDK8 Summary: The -XX:+UseVMInterruptibleIO flag is deprecated for JDK8. The flag will still enable Interruptible IO on Solaris, but users will get a warning. Reviewed-by: dholmes, acorn, alanb Contributed-by: harold.seigel at oracle.com ! src/share/vm/runtime/arguments.cpp Changeset: 8ebcedb7604d Author: coleenp Date: 2012-10-18 13:09 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8ebcedb7604d 7053130: hs_err file does not record specified CLASSPATH Summary: Added code to write the value of the java.class.path property to the hs_err file. Reviewed-by: kmo, dholmes, kvn Contributed-by: harold.seigel at oracle.com ! src/share/vm/runtime/arguments.cpp Changeset: c7957b458bf8 Author: minqi Date: 2012-10-19 08:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/c7957b458bf8 8000818: SA constant pool need to reference to reference map after permgen removal Summary: After permgen removal, constant pool changed to put _ldc and _ldc_w (fast_ldc and fast_ldcw) index to reference map, no longer calculated via constant pool cache. Reviewed-by: coleenp, sspitsyn, dholmes Contributed-by: yumin.qi at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/interpreter/Bytecodes.java ! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ByteCodeRewriter.java Changeset: 8eeffbc22f10 Author: minqi Date: 2012-10-19 08:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/8eeffbc22f10 8001055: Bytes.swap should follow big endian Summary: This is a mistake change in 6879063 about Bytes.swap. Java byte code order always follows big endian, but in that change, assume they follow native platform order that is not right. Reviewed-by: coleenp, sspitsyn, dholmes Contributed-by: yumin.qi at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/runtime/Bytes.java Changeset: 716c64bda5ba Author: zgu Date: 2012-10-19 21:40 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/716c64bda5ba 7199092: NMT: NMT needs to deal overlapped virtual memory ranges Summary: Enhanced virtual memory tracking to track committed regions as well as reserved regions, so NMT now can generate virtual memory map. Reviewed-by: acorn, coleenp ! src/os/bsd/vm/perfMemory_bsd.cpp ! src/os/linux/vm/perfMemory_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/solaris/vm/perfMemory_solaris.cpp ! src/os/windows/vm/perfMemory_windows.cpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/filemap.cpp ! src/share/vm/memory/filemap.hpp ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/memory/resourceArea.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.hpp ! src/share/vm/runtime/handles.inline.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/services/attachListener.cpp ! src/share/vm/services/memBaseline.cpp ! src/share/vm/services/memBaseline.hpp ! src/share/vm/services/memPtr.cpp ! src/share/vm/services/memPtr.hpp ! src/share/vm/services/memRecorder.cpp ! src/share/vm/services/memRecorder.hpp ! src/share/vm/services/memReporter.cpp ! src/share/vm/services/memReporter.hpp ! src/share/vm/services/memSnapshot.cpp ! src/share/vm/services/memSnapshot.hpp ! src/share/vm/services/memTracker.cpp ! src/share/vm/services/memTracker.hpp Changeset: b988bff99b38 Author: zgu Date: 2012-10-19 18:55 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b988bff99b38 Merge Changeset: 80f44792c0c9 Author: coleenp Date: 2012-10-22 12:01 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/80f44792c0c9 Merge Changeset: 685df3c6f84b Author: jmasa Date: 2012-09-18 23:35 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/685df3c6f84b 7045397: NPG: Add freelists to class loader arenas. Reviewed-by: coleenp, stefank, jprovino, ohair ! make/excludeSrc.make + src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.cpp + src/share/vm/gc_implementation/concurrentMarkSweep/adaptiveFreeList.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmStructs_cms.hpp ! src/share/vm/gc_implementation/shared/vmGCOperations.hpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/memory/binaryTreeDictionary.hpp ! src/share/vm/memory/freeBlockDictionary.cpp ! src/share/vm/memory/freeBlockDictionary.hpp ! src/share/vm/memory/freeList.cpp ! src/share/vm/memory/freeList.hpp + src/share/vm/memory/metablock.hpp + src/share/vm/memory/metachunk.hpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 476718ea6759 Author: jmasa Date: 2012-10-25 12:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/476718ea6759 8001584: NPG: Incorrect assertion in BinaryTreeDictionary::get_chunk() Reviewed-by: johnc, tamao ! src/share/vm/memory/binaryTreeDictionary.hpp Changeset: b58313cf9afd Author: jcoomes Date: 2012-10-26 08:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b58313cf9afd Merge Changeset: cfe522e6461c Author: kvn Date: 2012-10-17 12:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cfe522e6461c 8000623: tools/javac/Diagnostics/6769027/T6769027.java crashes in PSPromotionManager::copy_to_survivor_space Summary: Fix type of method pointer load from vtable. Reviewed-by: twisti, johnc, roland ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/library_call.cpp Changeset: e81a8af10cd9 Author: kvn Date: 2012-10-18 07:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e81a8af10cd9 8001071: Add simple range check into VM implemenation of Unsafe access methods Summary: Add simple check in debug version of VM. Reviewed-by: twisti, johnc ! src/share/vm/prims/unsafe.cpp Changeset: aaeb9add1ab3 Author: dlong Date: 2012-10-19 14:21 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/aaeb9add1ab3 8001101: C2: more general vector rule subsetting Summary: Allow which vector rules are supported to be decided at runtime. Also a small change to allow vector types in Type::_type_info[] to apply to more platforms. Reviewed-by: kvn, twisti Contributed-by: dean.long at oracle.com ! src/share/vm/opto/type.cpp ! src/share/vm/opto/vectornode.cpp Changeset: 67f4c477c9ab Author: vlivanov Date: 2012-10-22 11:44 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/67f4c477c9ab 8000805: JMM issue: short loads are non-atomic Summary: perform transforms during IGVN phase when Load has a single user. Reviewed-by: jrose, kvn, twisti ! src/share/vm/opto/mulnode.cpp + test/compiler/8000805/Test8000805.java Changeset: fd1d564dd460 Author: twisti Date: 2012-10-22 16:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fd1d564dd460 8000821: JSR 292: C1 fails to call virtual method (JRUBY-6920) Reviewed-by: kvn ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: b2c669fd8114 Author: kvn Date: 2012-10-23 13:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b2c669fd8114 8001183: incorrect results of char vectors right shift operaiton Summary: do vector right shift operation for small int types only after loads Reviewed-by: jrose, dlong ! src/cpu/x86/vm/x86.ad ! src/share/vm/opto/superword.cpp ! src/share/vm/opto/vectornode.cpp ! test/compiler/6340864/TestByteVect.java ! test/compiler/6340864/TestIntVect.java ! test/compiler/6340864/TestLongVect.java ! test/compiler/6340864/TestShortVect.java + test/compiler/8001183/TestCharVect.java Changeset: a3ecd773a7b9 Author: kvn Date: 2012-10-24 14:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a3ecd773a7b9 7184394: add intrinsics to use AES instructions Summary: Use new x86 AES instructions for AESCrypt. Reviewed-by: twisti, kvn, roland Contributed-by: tom.deneau at amd.com ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.hpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp + test/compiler/7184394/TestAESBase.java + test/compiler/7184394/TestAESDecode.java + test/compiler/7184394/TestAESEncode.java + test/compiler/7184394/TestAESMain.java Changeset: 006174cfe979 Author: kvn Date: 2012-10-25 17:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/006174cfe979 7163534: VM could crashes assert(false) failed: infinite EA connection graph build Summary: In case of time or iterations limit reached C2 stops EA and continue compilation without EA as it does in product VM already. Reviewed-by: twisti ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/escape.cpp Changeset: 410afdc6a07c Author: kvn Date: 2012-10-26 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/410afdc6a07c 8001635: assert(in_bb(n)) failed: must be Summary: Added missed check that Load node is in processed loop block. Reviewed-by: twisti ! src/share/vm/opto/superword.cpp Changeset: 588f08ed16cf Author: kvn Date: 2012-10-26 12:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/588f08ed16cf Merge ! src/share/vm/runtime/globals.hpp Changeset: dc16fe422c53 Author: amurillo Date: 2012-10-26 14:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/dc16fe422c53 Merge Changeset: 57c61f87a1fd Author: amurillo Date: 2012-10-26 14:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/57c61f87a1fd Added tag hs25-b07 for changeset dc16fe422c53 ! .hgtags Changeset: bf14ed159fb0 Author: kvn Date: 2012-05-23 12:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/bf14ed159fb0 7158801: Improve VM CompileOnly option Summary: Fixed buffer overflow during parsing flags -XX:CompileCommand=, -XX:CompileOnly= and command lines in .hotspot_compiler file. Reviewed-by: never ! src/share/vm/compiler/compilerOracle.cpp Changeset: fe4a4ea5bed9 Author: kamg Date: 2012-06-08 12:49 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/fe4a4ea5bed9 7158804: Improve config file parsing Summary: Check buffer length when reading Reviewed-by: dholmes, dcubed ! src/share/vm/compiler/compilerOracle.cpp ! src/share/vm/runtime/arguments.cpp + test/runtime/7158804/Test7158804.sh Changeset: 6b5a3d18fe0e Author: asaha Date: 2012-08-02 14:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6b5a3d18fe0e Merge ! src/share/vm/compiler/compilerOracle.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 000352e00389 Author: asaha Date: 2012-08-02 22:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/000352e00389 Merge Changeset: defeb6dad7d5 Author: asaha Date: 2012-08-10 10:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/defeb6dad7d5 Merge Changeset: e4d10261499c Author: asaha Date: 2012-09-07 18:18 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e4d10261499c Merge - agent/src/share/classes/sun/jvm/hotspot/code/RicochetBlob.java - agent/src/share/classes/sun/jvm/hotspot/runtime/sparc/SPARCRicochetFrame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/x86/X86RicochetFrame.java - src/share/vm/gc_implementation/parNew/parGCAllocBuffer.cpp - src/share/vm/gc_implementation/parNew/parGCAllocBuffer.hpp - src/share/vm/prims/methodHandleWalk.cpp - src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 521c82b9cbf8 Author: kvn Date: 2012-09-19 13:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/521c82b9cbf8 7198606: Improve VM optimization Summary: Remove incorrect code in OptimizeFill optimization. Reviewed-by: roland, twisti ! src/share/vm/opto/loopTransform.cpp Changeset: 849cf0480cb9 Author: asaha Date: 2012-09-25 11:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/849cf0480cb9 Merge Changeset: 5a3a6dac85e2 Author: asaha Date: 2012-09-26 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/5a3a6dac85e2 7199488: [TEST] runtime/7158800/InternTest.java failed due to false-positive on PID match. Reviewed-by: coleenp - test/runtime/7158800/BadUtf8.java - test/runtime/7158800/InternTest.java - test/runtime/7158800/Test7158800.sh - test/runtime/7158800/badstrings.txt Changeset: 218a94758fe7 Author: asaha Date: 2012-10-10 14:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/218a94758fe7 Merge - agent/make/ClosureFinder.java - agent/src/share/classes/sun/jvm/hotspot/TestDebugger.java - agent/src/share/classes/sun/jvm/hotspot/asm/AbstractInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/Address.java - agent/src/share/classes/sun/jvm/hotspot/asm/Arithmetic.java - agent/src/share/classes/sun/jvm/hotspot/asm/ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/BaseIndexScaleDispAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/CPUHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Immediate.java - agent/src/share/classes/sun/jvm/hotspot/asm/IndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLDataTypes.java - agent/src/share/classes/sun/jvm/hotspot/asm/RTLOperations.java - agent/src/share/classes/sun/jvm/hotspot/asm/ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/StoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/amd64/AMD64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/ia64/IA64Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/CoprocessorDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FP2RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FPopDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/FlushDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/Format3ADecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IllegalInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/JmplDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/LogicDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/MemoryInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RegisterDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RestoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/RettDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCAtomicLoadStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCDisassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFP2RegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFPMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFlushInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCFormat3AInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCHelper.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCIndirectCallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCInstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCJmplInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLdstubInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCLogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCMoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCNoopInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCOpcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRestoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCRettInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSaveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSethiInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSpecialStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStbarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCSwapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCTrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCUnimpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV8Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9CasInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ConditionFlags.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9DoneInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FMOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9FlushwInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9IlltrapInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ImpdepInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVccInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MOVrInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9MembarInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PopcInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrefetchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9PrivilegedRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RdprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterBranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RestoredInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9RetryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9ReturnInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SavedInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SirInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisterInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9SpecialRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCV9WrprInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SPARCWriteInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SaveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SethiDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialLoadStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/StoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/SwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/TrapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/UnimpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V8FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLdstubDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpacePrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9AlternateSpaceSwapDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CCBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9CasDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9DoneRetryDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FMOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop1Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FPop2Decoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FloatBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9FlushwDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntRegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9IntegerBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVccDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9MOVrDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PopcDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrefetchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9PrivilegedReadWriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RdprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ReadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9RegisterBranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SavedRestoredDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9SpecialStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/V9WrprDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/sparc/WriteDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/BranchDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/CallDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ConditionalJmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPLoadDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FPStoreDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/FloatGRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/GRPDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/InstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/JmpDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/LogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/MoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/RotateDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEArithmeticDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEInstructionDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSELogicalDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEMoveDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/SSEShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/ShiftDecoder.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86BranchInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CallInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86CondJmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86DirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Disassembler.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPArithmeticInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FPStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86FloatRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86GeneralInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Helper.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86IllegalInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Instruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactory.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86InstructionFactoryImpl.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86JmpInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86LogicInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MMXRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MemoryInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveLoadInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86MoveStoreInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Opcodes.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86PCRelativeAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Register.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterDirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterIndirectAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RegisterPart.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86Registers.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86RotateInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisterAddress.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86SegmentRegisters.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86ShiftInstruction.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegister.java - agent/src/share/classes/sun/jvm/hotspot/asm/x86/X86XMMRegisters.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciInstanceKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciMethodKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciObjArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/ci/ciTypeArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/gc_implementation/parallelScavenge/PSPermGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CMSPermGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CMSPermGenGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CompactingPermGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/CompactingPermGenGen.java - agent/src/share/classes/sun/jvm/hotspot/memory/ContigPermSpace.java - agent/src/share/classes/sun/jvm/hotspot/memory/PermGen.java - agent/src/share/classes/sun/jvm/hotspot/oops/ArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/CompiledICHolderKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethodKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCacheKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/KlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/MethodDataKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/MethodKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/ObjArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/oops/TypeArrayKlassKlass.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64CurrentFrameGuess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64Frame.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64JavaCallWrapper.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/IA64RegisterMap.java - agent/src/share/classes/sun/jvm/hotspot/runtime/ia64/cInterpreter.java - agent/src/share/classes/sun/jvm/hotspot/runtime/linux_ia64/LinuxIA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/runtime/win32_ia64/Win32IA64JavaThreadPDAccess.java - agent/src/share/classes/sun/jvm/hotspot/ui/tree/BadOopTreeNodeAdapter.java - make/solaris/makefiles/reorder_COMPILER1_amd64 - make/solaris/makefiles/reorder_COMPILER1_i486 - make/solaris/makefiles/reorder_COMPILER1_sparc - make/solaris/makefiles/reorder_COMPILER1_sparcv9 - make/solaris/makefiles/reorder_COMPILER2_amd64 - make/solaris/makefiles/reorder_COMPILER2_i486 - make/solaris/makefiles/reorder_COMPILER2_sparc - make/solaris/makefiles/reorder_COMPILER2_sparcv9 - make/solaris/makefiles/reorder_CORE_i486 - make/solaris/makefiles/reorder_CORE_sparc - make/solaris/makefiles/reorder_CORE_sparcv9 - make/solaris/makefiles/reorder_TIERED_amd64 - make/solaris/makefiles/reorder_TIERED_i486 - make/solaris/makefiles/reorder_TIERED_sparc - make/solaris/makefiles/reorder_TIERED_sparcv9 - make/solaris/reorder.sh - src/cpu/sparc/vm/dump_sparc.cpp - src/cpu/x86/vm/dump_x86_32.cpp - src/cpu/x86/vm/dump_x86_64.cpp - src/cpu/zero/vm/dump_zero.cpp - src/share/tools/ProjectCreator/DirectoryTree.java - src/share/tools/ProjectCreator/DirectoryTreeNode.java - src/share/tools/ProjectCreator/FileFormatException.java - src/share/tools/ProjectCreator/WinGammaPlatformVC6.java - src/share/vm/ci/ciArrayKlassKlass.hpp - src/share/vm/ci/ciCPCache.cpp - src/share/vm/ci/ciCPCache.hpp - src/share/vm/ci/ciInstanceKlassKlass.cpp - src/share/vm/ci/ciInstanceKlassKlass.hpp - src/share/vm/ci/ciKlassKlass.cpp - src/share/vm/ci/ciKlassKlass.hpp - src/share/vm/ci/ciMethodKlass.cpp - src/share/vm/ci/ciMethodKlass.hpp - src/share/vm/ci/ciObjArrayKlassKlass.cpp - src/share/vm/ci/ciObjArrayKlassKlass.hpp - src/share/vm/ci/ciTypeArrayKlassKlass.cpp - src/share/vm/ci/ciTypeArrayKlassKlass.hpp ! src/share/vm/compiler/compilerOracle.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.cpp - src/share/vm/gc_implementation/concurrentMarkSweep/cmsPermGen.hpp - src/share/vm/gc_implementation/parallelScavenge/psPermGen.cpp - src/share/vm/gc_implementation/parallelScavenge/psPermGen.hpp - src/share/vm/memory/classify.cpp - src/share/vm/memory/classify.hpp - src/share/vm/memory/compactPermGen.hpp - src/share/vm/memory/compactingPermGenGen.cpp - src/share/vm/memory/compactingPermGenGen.hpp - src/share/vm/memory/dump.cpp - src/share/vm/memory/permGen.cpp - src/share/vm/memory/permGen.hpp - src/share/vm/memory/restore.cpp - src/share/vm/memory/serialize.cpp - src/share/vm/oops/arrayKlassKlass.cpp - src/share/vm/oops/arrayKlassKlass.hpp - src/share/vm/oops/compiledICHolderKlass.cpp - src/share/vm/oops/compiledICHolderKlass.hpp - src/share/vm/oops/compiledICHolderOop.cpp - src/share/vm/oops/compiledICHolderOop.hpp - src/share/vm/oops/constMethodKlass.cpp - src/share/vm/oops/constMethodKlass.hpp - src/share/vm/oops/constMethodOop.cpp - src/share/vm/oops/constMethodOop.hpp - src/share/vm/oops/constantPoolKlass.cpp - src/share/vm/oops/constantPoolKlass.hpp - src/share/vm/oops/constantPoolOop.cpp - src/share/vm/oops/constantPoolOop.hpp - src/share/vm/oops/cpCacheKlass.cpp - src/share/vm/oops/cpCacheKlass.hpp - src/share/vm/oops/cpCacheOop.cpp - src/share/vm/oops/cpCacheOop.hpp - src/share/vm/oops/instanceKlassKlass.cpp - src/share/vm/oops/instanceKlassKlass.hpp - src/share/vm/oops/klassKlass.cpp - src/share/vm/oops/klassKlass.hpp - src/share/vm/oops/klassOop.cpp - src/share/vm/oops/klassOop.hpp - src/share/vm/oops/methodDataKlass.cpp - src/share/vm/oops/methodDataKlass.hpp - src/share/vm/oops/methodDataOop.cpp - src/share/vm/oops/methodDataOop.hpp - src/share/vm/oops/methodKlass.cpp - src/share/vm/oops/methodKlass.hpp - src/share/vm/oops/methodOop.cpp - src/share/vm/oops/methodOop.hpp - src/share/vm/oops/objArrayKlassKlass.cpp - src/share/vm/oops/objArrayKlassKlass.hpp - src/share/vm/oops/typeArrayKlassKlass.cpp - src/share/vm/oops/typeArrayKlassKlass.hpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 6ba00f89fbe1 Author: asaha Date: 2012-10-11 15:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6ba00f89fbe1 Merge ! src/share/vm/runtime/arguments.cpp Changeset: d2582a08fa5d Author: asaha Date: 2012-10-18 21:58 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d2582a08fa5d Merge ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/runtime/arguments.cpp Changeset: cb829aa4c98e Author: lana Date: 2012-10-25 20:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/cb829aa4c98e Merge - test/runtime/7158800/BadUtf8.java - test/runtime/7158800/InternTest.java - test/runtime/7158800/Test7158800.sh - test/runtime/7158800/badstrings.txt Changeset: acabb5c282f5 Author: lana Date: 2012-10-30 13:56 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/acabb5c282f5 Merge ! src/share/vm/runtime/arguments.cpp From lana.steuck at oracle.com Wed Oct 31 09:53:10 2012 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 31 Oct 2012 16:53:10 +0000 Subject: hg: jdk8/tl/jdk: 49 new changesets Message-ID: <20121031170517.78356476BA@hg.openjdk.java.net> Changeset: 1ae6420126af Author: katleman Date: 2012-10-18 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ae6420126af Added tag jdk8-b61 for changeset 61ddb3fd000a ! .hgtags Changeset: 61af38b8d4ff Author: twisti Date: 2012-10-19 17:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/61af38b8d4ff 8000989: smaller code changes to make future JSR 292 backports easier Reviewed-by: jrose ! src/share/classes/java/lang/invoke/BoundMethodHandle.java ! src/share/classes/java/lang/invoke/CallSite.java ! src/share/classes/java/lang/invoke/DirectMethodHandle.java ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/share/classes/java/lang/invoke/Invokers.java ! src/share/classes/java/lang/invoke/LambdaForm.java ! src/share/classes/java/lang/invoke/MemberName.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/sun/invoke/util/ValueConversions.java ! test/java/lang/invoke/BigArityTest.java ! test/java/lang/invoke/PrivateInvokeTest.java Changeset: 7a7e49acadec Author: kamg Date: 2012-10-22 20:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7a7e49acadec 8001225: Disable jdk regression test java/lang/System/Versions.java until jdk's classfile version code is updated Summary: Exclude java/lang/System/Versions.java test Reviewed-by: sspitsyn, coleenp ! test/ProblemList.txt Changeset: a0a2b186ae28 Author: tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a0a2b186ae28 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tbell Contributed-by: volker.simonis at gmail.com ! make/com/sun/java/pack/Makefile ! make/common/Defs-windows.gmk ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/common/Release.gmk ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Platform.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/jdk_generic_profile.sh ! make/tools/freetypecheck/Makefile + make/tools/msys_build_scripts/dospath.sh + make/tools/msys_build_scripts/dospath.vbs Changeset: 50b8b17449d2 Author: katleman Date: 2012-10-24 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50b8b17449d2 Merge Changeset: 65d2c6726487 Author: katleman Date: 2012-10-25 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/65d2c6726487 Added tag jdk8-b62 for changeset 50b8b17449d2 ! .hgtags Changeset: 117eed515e42 Author: bae Date: 2012-10-23 13:10 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/117eed515e42 7051394: NullPointerException when running regression tests LoadProfileTest by using openjdk-7-b144 Reviewed-by: jgodinez, prr ! src/share/native/sun/java2d/cmm/lcms/LCMS.c Changeset: aeb96dec1c6b Author: lana Date: 2012-10-23 09:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/aeb96dec1c6b Merge Changeset: 93e2669f1ac2 Author: leonidr Date: 2012-10-09 18:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/93e2669f1ac2 7185280: Jre7cert: focusgained does not get called for all focus req when do alt + tab Reviewed-by: anthony ! src/windows/native/sun/windows/awt_Window.cpp Changeset: 527f8eeb8e8d Author: leonidr Date: 2012-10-09 20:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/527f8eeb8e8d 7124321: [macosx] TrayIcon MouseListener is never triggered Reviewed-by: anthony ! src/macosx/classes/sun/lwawt/macosx/CTrayIcon.java ! src/macosx/native/sun/awt/CTrayIcon.h ! src/macosx/native/sun/awt/CTrayIcon.m Changeset: d4d0327e36e2 Author: kshefov Date: 2012-10-12 18:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d4d0327e36e2 7184326: TEST_BUG: java/awt/Frame/7024749/bug7024749.java has a typo Reviewed-by: anthony ! test/java/awt/Frame/7024749/bug7024749.java Changeset: 34d502d14a61 Author: lana Date: 2012-10-12 14:47 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/34d502d14a61 Merge - src/share/classes/sun/util/xml/XMLUtils.java - src/share/test/pack200/pack.conf Changeset: f42d178f0452 Author: anthony Date: 2012-10-16 20:11 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f42d178f0452 6818083: When DISPLAY is bad, InternalError thrown, not AWTError Summary: Throw AWTError instead of InternalError if the DISPLAY is bad Reviewed-by: anthony, serb Contributed-by: Mikhail Cherkasov ! src/solaris/native/sun/awt/awt_GraphicsEnv.c + test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.java + test/java/awt/Toolkit/BadDisplayTest/BadDisplayTest.sh Changeset: 47cdc463b4b0 Author: kizune Date: 2012-10-17 14:32 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/47cdc463b4b0 7175704: [macosx] "8" PIT: NPE in GetDisplayMode fullscreen test Reviewed-by: serb, leonidr ! src/macosx/classes/sun/awt/CGraphicsDevice.java Changeset: e6a8ee65d248 Author: alexsch Date: 2012-10-17 17:33 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6a8ee65d248 8000969: [macosx] Directories are not deselected when JFileChooser has FILES_ONLY selection mode Reviewed-by: rupashka ! src/macosx/classes/com/apple/laf/AquaFileChooserUI.java Changeset: 29b7bd890d3a Author: alexsch Date: 2012-10-17 10:16 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/29b7bd890d3a 8000626: Implement dead key detection for KeyEvent on Linux Reviewed-by: kizune ! src/solaris/classes/sun/awt/X11/XKeysym.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/keysym2ucs.h Changeset: 9c6f60a4e996 Author: alexsch Date: 2012-10-18 17:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c6f60a4e996 7199708: FileChooser crashs when opening large folder Reviewed-by: bagiras ! src/windows/classes/sun/awt/shell/Win32ShellFolder2.java Changeset: 8bbc6a5f1e92 Author: alexsch Date: 2012-10-18 18:28 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8bbc6a5f1e92 7175707: [macosx] PIT: 8 b43 Not running on AppKit thread issue again Reviewed-by: serb, anthony ! src/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java ! src/macosx/native/sun/awt/AWTWindow.m Changeset: 6b16f6fc41c5 Author: serb Date: 2012-10-19 15:23 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6b16f6fc41c5 7124520: [macosx] re:6373505 Toolkit.getScreenResolution() != GraphicsConfiguration.getNormalizingTransform() Reviewed-by: anthony, kizune ! src/macosx/classes/sun/awt/CGraphicsDevice.java ! src/macosx/classes/sun/lwawt/macosx/LWCToolkit.java + test/java/awt/GraphicsConfiguration/NormalizingTransformTest/NormalizingTransformTest.java Changeset: e0f91b40b8dd Author: alexsch Date: 2012-10-23 14:30 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e0f91b40b8dd 6624200: Regression test fails: test/closed/javax/swing/JMenuItem/4654927/bug4654927.java Reviewed-by: rupashka + test/javax/swing/JMenuItem/4654927/bug4654927.java ! test/javax/swing/regtesthelpers/Util.java Changeset: 37a6ead4a357 Author: lana Date: 2012-10-23 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/37a6ead4a357 Merge Changeset: cdc7f9be3707 Author: lana Date: 2012-10-23 09:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cdc7f9be3707 Merge - src/share/classes/sun/security/tools/CertAndKeyGen.java - src/share/classes/sun/security/tools/JarSigner.java - src/share/classes/sun/security/tools/JarSignerResources.java - src/share/classes/sun/security/tools/JarSignerResources_ja.java - src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java - src/share/classes/sun/security/tools/KeyTool.java - src/share/classes/sun/security/tools/TimestampedSigner.java - src/windows/classes/java/io/Win32FileSystem.java - src/windows/native/java/io/Win32FileSystem_md.c - test/com/sun/jndi/ldap/LdapsReadTimeoutTest.java - test/com/sun/jndi/ldap/ReadTimeoutTest.java Changeset: 0582dc4674c9 Author: wetmore Date: 2012-05-21 15:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0582dc4674c9 7167656: Multiple Seeders are being created Reviewed-by: smarks, mduigou, ahgross ! src/share/classes/sun/security/provider/SecureRandom.java Changeset: b4f35876d9b5 Author: mullan Date: 2012-06-08 11:02 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b4f35876d9b5 7163198: Tightened package accessibility 7169887: Tightened package accessibility Reviewed-by: vinnie, hawtin ! src/share/lib/security/java.security ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: 89a0551b98d8 Author: weijun Date: 2012-06-15 09:51 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89a0551b98d8 6631398: FilePermission improved path checking Reviewed-by: mullan, skoivu, jdn ! src/share/classes/java/io/FilePermission.java Changeset: 7439e8007e09 Author: mullan Date: 2012-06-18 10:00 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7439e8007e09 7172522: Improve DomainCombiner checking Reviewed-by: vinnie, ahgross ! src/share/classes/java/security/AccessController.java Changeset: 2a98c51549a8 Author: smarks Date: 2012-06-21 00:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2a98c51549a8 7093490: adjust package access in rmiregistry Reviewed-by: ahgross, coffeys, dmocek ! src/share/classes/sun/rmi/registry/RegistryImpl.java Changeset: 263f15439f4b Author: dsamersoff Date: 2012-06-22 16:22 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/263f15439f4b 7158796: Tighten properties checking in EnvHelp Summary: Move getProperty call out of computeBooleanFromString Reviewed-by: skoivu, sla ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/util/EnvHelp.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java Changeset: 3a825f6cbc71 Author: dsamersoff Date: 2012-06-22 18:19 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a825f6cbc71 7169888: Narrowing resource definitions in JMX RMI connector Summary: CPU bug, we can't put offending calls outside doPrivileged, but narrow granted permissions. Reviewed-by: ahgross, fparain ! src/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java Changeset: 90498c1cc87c Author: xuelei Date: 2012-07-28 19:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/90498c1cc87c 7186286: TLS implementation to better adhere to RFC Summary: also reviewed by Alexander Fomin , Andrew Gross, Sean Coffey Reviewed-by: valeriep, wetmore ! src/share/classes/sun/security/ssl/HandshakeInStream.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/RSAClientKeyExchange.java Changeset: 983c17aecdac Author: mullan Date: 2012-08-15 15:31 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/983c17aecdac 7189490: More improvements to DomainCombiner checking Reviewed-by: ahgross, jdn, vinnie ! src/share/classes/java/security/AccessController.java Changeset: 6cc28cc213b6 Author: chegar Date: 2012-08-16 15:02 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cc28cc213b6 7189103: Executors needs to maintain state Reviewed-by: dholmes, hawtin ! src/share/classes/java/util/concurrent/Executors.java Changeset: a09b9ebb61b6 Author: chegar Date: 2012-08-29 14:05 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a09b9ebb61b6 7189567: java net obselete protocol Reviewed-by: alanb, ahgross ! make/sun/net/FILES_java.gmk - src/share/classes/sun/net/www/protocol/gopher/GopherClient.java - src/share/classes/sun/net/www/protocol/gopher/Handler.java ! test/java/net/URL/Test.java Changeset: 2ac636f46c5b Author: alanb Date: 2012-09-08 20:31 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2ac636f46c5b 7169884: LogManager checks do not work correctly for sub-types Reviewed-by: mchung, ahgross ! src/share/classes/java/util/logging/FileHandler.java ! src/share/classes/java/util/logging/Handler.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java ! src/share/classes/java/util/logging/MemoryHandler.java ! src/share/classes/java/util/logging/StreamHandler.java Changeset: 4488ea026532 Author: asaha Date: 2012-09-08 22:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4488ea026532 Merge Changeset: e869a8513cb7 Author: smarks Date: 2012-09-10 16:05 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e869a8513cb7 7195919: (sl) ServiceLoader can throw CCE without needing to create instance Reviewed-by: ahgross, alanb, dmeetry ! src/share/classes/java/util/ServiceLoader.java ! src/share/classes/sun/misc/Service.java Changeset: 9a7e2fa3c9c5 Author: malenkov Date: 2012-09-11 12:57 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a7e2fa3c9c5 7195549: Better bean object persistence Reviewed-by: art, ahgross ! src/share/classes/com/sun/beans/decoder/PropertyElementHandler.java Changeset: 1d1fcf0c1ce8 Author: rupashka Date: 2012-09-11 15:59 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1d1fcf0c1ce8 7195194: Better data validation for Swing Reviewed-by: art, ahgross ! src/share/classes/javax/swing/text/DefaultFormatter.java Changeset: 3b49bd3c392b Author: malenkov Date: 2012-09-19 21:42 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3b49bd3c392b 7195917: XMLDecoder parsing at close-time should be improved Reviewed-by: art, ahgross ! src/share/classes/com/sun/beans/decoder/DocumentHandler.java ! src/share/classes/java/beans/XMLDecoder.java Changeset: 762eee5e6e16 Author: jrose Date: 2012-09-20 14:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/762eee5e6e16 7196190: Improve method of handling MethodHandles Summary: Bind callers to caller-sensitive methods. Reviewed-by: twisti, jjh, vlivanov, ahgross ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/sun/invoke/anon/AnonymousClassLoader.java ! src/share/classes/sun/invoke/util/ValueConversions.java + test/java/lang/invoke/7196190/ClassForNameTest.java + test/java/lang/invoke/7196190/GetUnsafeTest.java + test/java/lang/invoke/7196190/MHProxyTest.java + test/java/lang/invoke/7196190/jtreg.security.policy Changeset: e113ffde452a Author: dsamersoff Date: 2012-09-24 16:15 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e113ffde452a 7198296: Problem with classloader in JMX Summary: wb classes have to be available for hotspot tests Reviewed-by: ahgross, asaha Contributed-by: frederic.parain at oracle.com, daniel.fuchs at oracle.com, jean-francois.denise at oracle.com ! src/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java Changeset: ca79b33a0731 Author: dsamersoff Date: 2012-09-24 17:00 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ca79b33a0731 7192975: Issue with JMX reflection Summary: Make security check unconditional Reviewed-by: ahgross, asaha Contributed-by: jaroslav.bachorik at oracle.com ! src/share/classes/javax/management/modelmbean/DescriptorSupport.java Changeset: 74eec13c464e Author: asaha Date: 2012-09-25 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/74eec13c464e Merge - make/common/Defs-embedded.gmk - make/common/Release-embedded.gmk Changeset: e4ce54b79bb4 Author: asaha Date: 2012-10-10 14:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e4ce54b79bb4 Merge - src/macosx/classes/sun/awt/SunToolkitSubclass.java ! src/share/classes/java/io/FilePermission.java - src/share/classes/sun/management/LockDataConverter.java - src/share/classes/sun/management/LockDataConverterMXBean.java - src/share/classes/sun/security/x509/CertificateIssuerUniqueIdentity.java - src/share/classes/sun/security/x509/CertificateSubjectUniqueIdentity.java - test/sun/misc/URLClassPath/ClassnameCharTest.sh - test/sun/net/www/httptest/HttpServer.java - test/sun/security/ssl/sun/net/www/httpstest/HttpServer.java Changeset: 28fe37b50e3c Author: asaha Date: 2012-10-11 15:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28fe37b50e3c Merge Changeset: d3b3fea7d1d7 Author: asaha Date: 2012-10-18 22:01 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d3b3fea7d1d7 Merge ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/util/ServiceLoader.java - src/share/classes/sun/util/xml/XMLUtils.java - src/share/test/pack200/pack.conf Changeset: e6fbbb2c610d Author: lana Date: 2012-10-23 11:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e6fbbb2c610d Merge ! src/share/classes/java/util/ServiceLoader.java ! src/share/classes/java/util/logging/LogManager.java - src/share/classes/sun/net/www/protocol/gopher/GopherClient.java - src/share/classes/sun/net/www/protocol/gopher/Handler.java ! src/share/classes/sun/security/ssl/HandshakeInStream.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/lib/security/java.security ! src/share/lib/security/java.security-macosx ! src/share/lib/security/java.security-solaris ! src/share/lib/security/java.security-windows Changeset: dfd509da3da6 Author: lana Date: 2012-10-25 20:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dfd509da3da6 Merge ! make/common/Release.gmk ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/share/classes/sun/invoke/util/ValueConversions.java - src/share/classes/sun/net/www/protocol/gopher/GopherClient.java - src/share/classes/sun/net/www/protocol/gopher/Handler.java - src/share/classes/sun/security/tools/CertAndKeyGen.java - src/share/classes/sun/security/tools/JarSigner.java - src/share/classes/sun/security/tools/JarSignerResources.java - src/share/classes/sun/security/tools/JarSignerResources_ja.java - src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java - src/share/classes/sun/security/tools/KeyTool.java - src/share/classes/sun/security/tools/TimestampedSigner.java - src/windows/classes/java/io/Win32FileSystem.java - src/windows/native/java/io/Win32FileSystem_md.c ! test/ProblemList.txt - test/com/sun/jndi/ldap/LdapsReadTimeoutTest.java - test/com/sun/jndi/ldap/ReadTimeoutTest.java Changeset: ac97b1cfc0ea Author: lana Date: 2012-10-31 08:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac97b1cfc0ea Merge ! make/common/shared/Sanity.gmk ! src/share/classes/java/util/concurrent/Executors.java ! src/share/classes/java/util/logging/FileHandler.java ! src/share/classes/java/util/logging/MemoryHandler.java ! src/share/classes/java/util/logging/StreamHandler.java - src/share/classes/sun/net/www/protocol/gopher/GopherClient.java - src/share/classes/sun/net/www/protocol/gopher/Handler.java From christian.thalinger at oracle.com Wed Oct 31 10:54:52 2012 From: christian.thalinger at oracle.com (Christian Thalinger) Date: Wed, 31 Oct 2012 10:54:52 -0700 Subject: 1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge In-Reply-To: <50906205.8020607@oracle.com> References: <50900EC1.4020109@oracle.com> <5090103D.1080404@oracle.com> <50901145.1040500@oracle.com> <50906205.8020607@oracle.com> Message-ID: On Oct 30, 2012, at 4:25 PM, serguei.spitsyn at oracle.com wrote: > Ok, it seems there are some suspicious fragments in the interpreter code. > Christian, could you, please, check and comment the fragments below? > > This is how the Method::max_stack() is defined: > > src/share/vm/oops/method.hpp: > > int verifier_max_stack() const { return _max_stack; } > int max_stack() const { return _max_stack + extra_stack_entries(); } > void set_max_stack(int size) { _max_stack = size; } > . . . > static int extra_stack_entries() { return EnableInvokeDynamic ? 2 : 0; } > > > The following code fragments are unaware that the method->max_stack() returns _max_stack + extra_stack_entries() : > > src/cpu/sparc/vm/cppInterpreter_sparc.cpp: > src/cpu/sparc/vm/cppInterpreter_x86.cpp: > > static int size_activation_helper(int callee_extra_locals, int max_stack, int monitor_size) { > . . . > const int extra_stack = 0; //6815692//Method::extra_stack_entries(); ???? > return (round_to(max_stack + > extra_stack + Remove extra_stack. > . . . > } > . . . > void BytecodeInterpreter::layout_interpreterState(interpreterState to_fill, > . . . > int extra_stack = 0; //6815692//Method::extra_stack_entries(); ???? > to_fill->_stack_limit = stack_base - (method->max_stack() + 1 + extra_stack); Remove extra_stack (but keep the +1; see comment nearby). > . . . > } > > > src/cpu/sparc/vm/templateInterpreter_sparc.cpp: > > static int size_activation_helper(int callee_extra_locals, int max_stack, int monitor_size) { > . . . > const int max_stack_words = max_stack * Interpreter::stackElementWords; > return (round_to((max_stack_words > //6815692//+ Method::extra_stack_words() ???? The comment needs to be removed. > . . . > } > > At the size_activation_helper call sites the second parameter is usually passed as method->max_stack(). > > > src/cpu/x86/vm/templateInterpreter_x86_32.cpp: > src/cpu/x86/vm/templateInterpreter_x86_64.cpp: > > int AbstractInterpreter::size_top_interpreter_activation(Method* method) { > . . . > const int extra_stack = Method::extra_stack_entries(); > const int method_stack = (method->max_locals() + method->max_stack() + extra_stack) * Remove extra_stack. > Interpreter::stackElementWords; > . . . > } > > > src/share/vm/interpreter/oopMapCache.cpp: > > void OopMapForCacheEntry::compute_map(TRAPS) { > . . . > // First check if it is a method where the stackmap is always empty > if (method()->code_size() == 0 || method()->max_locals() + method()->max_stack() == 0) { > _entry->set_mask_size(0); > } else { > . . . > } > > Above, if the invokedynamic is enabled then the method()->max_stack() can not be 0. > We need to check it if this fact does not break the fragment. That means we are always generating oop maps even if we wouldn't need them. Let me think more about this... -- Chris > > > I'm still looking at other places... > > > Thanks, > Serguei > > > On 10/30/12 10:41 AM, serguei.spitsyn at oracle.com wrote: >> I have a plan to look at it, at least for other serviceablity code. >> It'd be good if someone from the runtime or compiler team checked it too. >> >> Thanks, >> Serguei >> >> >> On 10/30/12 10:37 AM, Daniel D. Daugherty wrote: >>> Thumbs up. >>> >>> Is someone going to do an audit for similar missing changes >>> from max_stack() (not max_size()) to verifier_max_stack()? >>> >>> Dan >>> >>> >>> On 10/30/12 1:30 PM, serguei.spitsyn at oracle.com wrote: >>>> Hello, >>>> >>>> >>>> Please, review the fix for CR: >>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194607 >>>> >>>> CR in JIRA: >>>> https://jbs.oracle.com/bugs/browse/JDK-7194607 >>>> >>>> Open webrev: >>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7194607-JVMTI-max_size >>>> >>>> >>>> Summary: >>>> >>>> This issue is caused by the changes in the oops/method.hpp for invokedynamic (JSR 292). >>>> Now the max_stack() adds +2 to the original code attribute stack size if invokedynamic is enabled. >>>> The verifier_max_stack() must be used in the jvmtiClassFileReconstituter.cpp >>>> instead of the max_size() to get the code attribute stack size. >>>> >>>> >>>> Thanks, >>>> Serguei >>>> >> > From naoto.sato at oracle.com Wed Oct 31 11:36:13 2012 From: naoto.sato at oracle.com (naoto.sato at oracle.com) Date: Wed, 31 Oct 2012 18:36:13 +0000 Subject: hg: jdk8/tl/jdk: 8001231: Move locale data out of rt.jar (except the US locale) Message-ID: <20121031183648.E343F476CB@hg.openjdk.java.net> Changeset: 178618fb4300 Author: naoto Date: 2012-10-31 11:33 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/178618fb4300 8001231: Move locale data out of rt.jar (except the US locale) Reviewed-by: alanb, erikj ! make/java/java/genlocales.gmk ! make/java/java/localegen.sh ! make/java/text/base/FILES_java.gmk ! make/java/util/FILES_java.gmk ! make/java/util/FILES_properties.gmk ! make/sun/text/FILES_java.gmk ! make/sun/text/FILES_properties.gmk ! makefiles/CreateJars.gmk ! makefiles/GensrcLocaleDataMetaInfo.gmk ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleDataMetaInfo-XLocales.java.template From jonathan.gibbons at oracle.com Wed Oct 31 13:49:00 2012 From: jonathan.gibbons at oracle.com (jonathan.gibbons at oracle.com) Date: Wed, 31 Oct 2012 20:49:00 +0000 Subject: hg: jdk8/tl/langtools: 8001664: refactor javadoc to use abstraction to handle files Message-ID: <20121031204905.65366476CF@hg.openjdk.java.net> Changeset: b980e8e6aabf Author: jjg Date: 2012-10-31 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b980e8e6aabf 8001664: refactor javadoc to use abstraction to handle files Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java + src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFile.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPaths.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PackageListWriter.java - src/share/classes/com/sun/tools/doclets/internal/toolkit/util/SourcePath.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! test/com/sun/javadoc/testDocFileDir/TestDocFileDir.java From serguei.spitsyn at oracle.com Wed Oct 31 14:13:06 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 31 Oct 2012 14:13:06 -0700 Subject: 1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge In-Reply-To: References: <50900EC1.4020109@oracle.com> <5090103D.1080404@oracle.com> <50901145.1040500@oracle.com> <50906205.8020607@oracle.com> Message-ID: <50919462.7010808@oracle.com> Thanks, Christian. I'm not comfortable to fix it as a part of 7194607. One question is what tests are need to be run to verify possible fixes. I'll open a separate CR under hotspot/runtime to track the Interpreter issues related to max_stack. Thanks, Serguei On 10/31/12 10:54 AM, Christian Thalinger wrote: > On Oct 30, 2012, at 4:25 PM, serguei.spitsyn at oracle.com wrote: > >> Ok, it seems there are some suspicious fragments in the interpreter code. >> Christian, could you, please, check and comment the fragments below? >> >> This is how the Method::max_stack() is defined: >> >> src/share/vm/oops/method.hpp: >> >> int verifier_max_stack() const { return _max_stack; } >> int max_stack() const { return _max_stack + extra_stack_entries(); } >> void set_max_stack(int size) { _max_stack = size; } >> . . . >> static int extra_stack_entries() { return EnableInvokeDynamic ? 2 : 0; } >> >> >> The following code fragments are unaware that the method->max_stack() returns _max_stack + extra_stack_entries() : >> >> src/cpu/sparc/vm/cppInterpreter_sparc.cpp: >> src/cpu/sparc/vm/cppInterpreter_x86.cpp: >> >> static int size_activation_helper(int callee_extra_locals, int max_stack, int monitor_size) { >> . . . >> const int extra_stack = 0; //6815692//Method::extra_stack_entries(); ???? >> return (round_to(max_stack + >> extra_stack + > Remove extra_stack. > >> . . . >> } >> . . . >> void BytecodeInterpreter::layout_interpreterState(interpreterState to_fill, >> . . . >> int extra_stack = 0; //6815692//Method::extra_stack_entries(); ???? >> to_fill->_stack_limit = stack_base - (method->max_stack() + 1 + extra_stack); > Remove extra_stack (but keep the +1; see comment nearby). > >> . . . >> } >> >> >> src/cpu/sparc/vm/templateInterpreter_sparc.cpp: >> >> static int size_activation_helper(int callee_extra_locals, int max_stack, int monitor_size) { >> . . . >> const int max_stack_words = max_stack * Interpreter::stackElementWords; >> return (round_to((max_stack_words >> //6815692//+ Method::extra_stack_words() ???? > The comment needs to be removed. > >> . . . >> } >> >> At the size_activation_helper call sites the second parameter is usually passed as method->max_stack(). >> >> >> src/cpu/x86/vm/templateInterpreter_x86_32.cpp: >> src/cpu/x86/vm/templateInterpreter_x86_64.cpp: >> >> int AbstractInterpreter::size_top_interpreter_activation(Method* method) { >> . . . >> const int extra_stack = Method::extra_stack_entries(); >> const int method_stack = (method->max_locals() + method->max_stack() + extra_stack) * > Remove extra_stack. > >> Interpreter::stackElementWords; >> . . . >> } >> >> >> src/share/vm/interpreter/oopMapCache.cpp: >> >> void OopMapForCacheEntry::compute_map(TRAPS) { >> . . . >> // First check if it is a method where the stackmap is always empty >> if (method()->code_size() == 0 || method()->max_locals() + method()->max_stack() == 0) { >> _entry->set_mask_size(0); >> } else { >> . . . >> } >> >> Above, if the invokedynamic is enabled then the method()->max_stack() can not be 0. >> We need to check it if this fact does not break the fragment. > That means we are always generating oop maps even if we wouldn't need them. Let me think more about this... > > -- Chris > >> >> I'm still looking at other places... >> >> >> Thanks, >> Serguei >> >> >> On 10/30/12 10:41 AM, serguei.spitsyn at oracle.com wrote: >>> I have a plan to look at it, at least for other serviceablity code. >>> It'd be good if someone from the runtime or compiler team checked it too. >>> >>> Thanks, >>> Serguei >>> >>> >>> On 10/30/12 10:37 AM, Daniel D. Daugherty wrote: >>>> Thumbs up. >>>> >>>> Is someone going to do an audit for similar missing changes >>>> from max_stack() (not max_size()) to verifier_max_stack()? >>>> >>>> Dan >>>> >>>> >>>> On 10/30/12 1:30 PM, serguei.spitsyn at oracle.com wrote: >>>>> Hello, >>>>> >>>>> >>>>> Please, review the fix for CR: >>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194607 >>>>> >>>>> CR in JIRA: >>>>> https://jbs.oracle.com/bugs/browse/JDK-7194607 >>>>> >>>>> Open webrev: >>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7194607-JVMTI-max_size >>>>> >>>>> >>>>> Summary: >>>>> >>>>> This issue is caused by the changes in the oops/method.hpp for invokedynamic (JSR 292). >>>>> Now the max_stack() adds +2 to the original code attribute stack size if invokedynamic is enabled. >>>>> The verifier_max_stack() must be used in the jvmtiClassFileReconstituter.cpp >>>>> instead of the max_size() to get the code attribute stack size. >>>>> >>>>> >>>>> Thanks, >>>>> Serguei >>>>> From serguei.spitsyn at oracle.com Wed Oct 31 17:46:07 2012 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Wed, 31 Oct 2012 17:46:07 -0700 Subject: 1-line review request: 7194607 VerifyLocalVariableTableOnRetransformTest.sh fails after JSR-292 merge In-Reply-To: <50919462.7010808@oracle.com> References: <50900EC1.4020109@oracle.com> <5090103D.1080404@oracle.com> <50901145.1040500@oracle.com> <50906205.8020607@oracle.com> <50919462.7010808@oracle.com> Message-ID: <5091C64F.9010602@oracle.com> I've created the hotspot/runtime CR: https://jbs.oracle.com/bugs/browse/JDK-8002087 Assigned to myself. Thanks, Serguei On 10/31/12 2:13 PM, serguei.spitsyn at oracle.com wrote: > Thanks, Christian. > > I'm not comfortable to fix it as a part of 7194607. > One question is what tests are need to be run to verify possible fixes. > > I'll open a separate CR under hotspot/runtime to track the Interpreter > issues related to max_stack. > > > Thanks, > Serguei > > On 10/31/12 10:54 AM, Christian Thalinger wrote: >> On Oct 30, 2012, at 4:25 PM, serguei.spitsyn at oracle.com wrote: >> >>> Ok, it seems there are some suspicious fragments in the interpreter >>> code. >>> Christian, could you, please, check and comment the fragments below? >>> >>> This is how the Method::max_stack() is defined: >>> >>> src/share/vm/oops/method.hpp: >>> >>> int verifier_max_stack() const { return >>> _max_stack; } >>> int max_stack() const { return >>> _max_stack + extra_stack_entries(); } >>> void set_max_stack(int size) { _max_stack = >>> size; } >>> . . . >>> static int extra_stack_entries() { return EnableInvokeDynamic ? 2 >>> : 0; } >>> >>> >>> The following code fragments are unaware that the >>> method->max_stack() returns _max_stack + extra_stack_entries() : >>> >>> src/cpu/sparc/vm/cppInterpreter_sparc.cpp: >>> src/cpu/sparc/vm/cppInterpreter_x86.cpp: >>> >>> static int size_activation_helper(int callee_extra_locals, int >>> max_stack, int monitor_size) { >>> . . . >>> const int extra_stack = 0; >>> //6815692//Method::extra_stack_entries(); ???? >>> return (round_to(max_stack + >>> extra_stack + >> Remove extra_stack. >> >>> . . . >>> } >>> . . . >>> void BytecodeInterpreter::layout_interpreterState(interpreterState >>> to_fill, >>> . . . >>> int extra_stack = 0; >>> //6815692//Method::extra_stack_entries(); ???? >>> to_fill->_stack_limit = stack_base - (method->max_stack() + 1 + >>> extra_stack); >> Remove extra_stack (but keep the +1; see comment nearby). >> >>> . . . >>> } >>> >>> >>> src/cpu/sparc/vm/templateInterpreter_sparc.cpp: >>> >>> static int size_activation_helper(int callee_extra_locals, int >>> max_stack, int monitor_size) { >>> . . . >>> const int max_stack_words = max_stack * >>> Interpreter::stackElementWords; >>> return (round_to((max_stack_words >>> //6815692//+ >>> Method::extra_stack_words() ???? >> The comment needs to be removed. >> >>> . . . >>> } >>> >>> At the size_activation_helper call sites the second parameter is >>> usually passed as method->max_stack(). >>> >>> >>> src/cpu/x86/vm/templateInterpreter_x86_32.cpp: >>> src/cpu/x86/vm/templateInterpreter_x86_64.cpp: >>> >>> int AbstractInterpreter::size_top_interpreter_activation(Method* >>> method) { >>> . . . >>> const int extra_stack = Method::extra_stack_entries(); >>> const int method_stack = (method->max_locals() + >>> method->max_stack() + extra_stack) * >> Remove extra_stack. >> >>> Interpreter::stackElementWords; >>> . . . >>> } >>> >>> >>> src/share/vm/interpreter/oopMapCache.cpp: >>> >>> void OopMapForCacheEntry::compute_map(TRAPS) { >>> . . . >>> // First check if it is a method where the stackmap is always empty >>> if (method()->code_size() == 0 || method()->max_locals() + >>> method()->max_stack() == 0) { >>> _entry->set_mask_size(0); >>> } else { >>> . . . >>> } >>> >>> Above, if the invokedynamic is enabled then the >>> method()->max_stack() can not be 0. >>> We need to check it if this fact does not break the fragment. >> That means we are always generating oop maps even if we wouldn't need >> them. Let me think more about this... >> >> -- Chris >> >>> >>> I'm still looking at other places... >>> >>> >>> Thanks, >>> Serguei >>> >>> >>> On 10/30/12 10:41 AM, serguei.spitsyn at oracle.com wrote: >>>> I have a plan to look at it, at least for other serviceablity code. >>>> It'd be good if someone from the runtime or compiler team checked >>>> it too. >>>> >>>> Thanks, >>>> Serguei >>>> >>>> >>>> On 10/30/12 10:37 AM, Daniel D. Daugherty wrote: >>>>> Thumbs up. >>>>> >>>>> Is someone going to do an audit for similar missing changes >>>>> from max_stack() (not max_size()) to verifier_max_stack()? >>>>> >>>>> Dan >>>>> >>>>> >>>>> On 10/30/12 1:30 PM, serguei.spitsyn at oracle.com wrote: >>>>>> Hello, >>>>>> >>>>>> >>>>>> Please, review the fix for CR: >>>>>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7194607 >>>>>> >>>>>> CR in JIRA: >>>>>> https://jbs.oracle.com/bugs/browse/JDK-7194607 >>>>>> >>>>>> Open webrev: >>>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/7194607-JVMTI-max_size >>>>>> >>>>>> >>>>>> >>>>>> Summary: >>>>>> >>>>>> This issue is caused by the changes in the oops/method.hpp for >>>>>> invokedynamic (JSR 292). >>>>>> Now the max_stack() adds +2 to the original code attribute stack >>>>>> size if invokedynamic is enabled. >>>>>> The verifier_max_stack() must be used in the >>>>>> jvmtiClassFileReconstituter.cpp >>>>>> instead of the max_size() to get the code attribute stack size. >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Serguei >>>>>> > From david.holmes at oracle.com Wed Oct 31 20:41:50 2012 From: david.holmes at oracle.com (David Holmes) Date: Thu, 01 Nov 2012 13:41:50 +1000 Subject: RFR: 8002034 and 8001756 - FDS changes mainly re cross-compiling In-Reply-To: <5090D376.4080204@oracle.com> References: <5090D376.4080204@oracle.com> Message-ID: <5091EF7E.50200@oracle.com> No takers so far - don't be shy, it's not a difficult one I promise :) Updated webrev: http://cr.openjdk.java.net/~dholmes/8002034/webrev.01/ Because of the multiple sub-make invocations that occur during a build the FDS logic gets processed numerous times, many of which are not needed and which might show confusing output (eg that FDS is enabled when you have disabled it). So I added another conditional to at least check that BUILD_FLAVOR has been set - that excludes a couple of the unnecessary executions. Thanks, David On 31/10/2012 5:29 PM, David Holmes wrote: > http://cr.openjdk.java.net/~dholmes/8002034/webrev/ > > This mainly addresses > > JDK-8002034 Allow Full Debug Symbols when cross-compiling > > The initial FDS work simply disables FDS when cross-compilation is > involved. But we're now ready to deal with the cross-compilation case > (and even if we weren't these changes would be fine anyway). So if FDS > is initially enabled we will rely on ALT_OBJCOPY being set to the > correct value for cross-compilation; and we don't set the default > OBJCOPY in that case. So if you do nothing when cross-compiling OBJCOPY > will be empty and that will cause the build to disable FDS, just as if > the OBJCOPY command was not found. > > As this is the same code that causes: > > JDK-8001756 Hotspot makefiles report missing OBJCOPY command in the > wrong circumstances > > I also fixed this by moving the OBJCOPY checks inside the > ENABLE_FULL_DEBUG_SYMBOLS=1 conditional. Basically unless we are asking > for FDS we shouldn't complain if the OBJCOPY command is not found. > > This will be pushed to the hotspot-emb repo as it is needed there ASAP. > > I'll be doing a similar change, under 8002040, for the JDK side of things. > > Thanks, > David