RFR: 8000818: SA constant pool need to reference to reference map after permgen removal

[David Holmes]

On 18/10/2012 10:25 AM, Yumin Qi wrote:
> Hi,
>
> As suggested by David, I created a new bug
> 8001055: Bytes.swap should follow big endian
> to address the issued caused by 6879063 push.

This change looks good to me. I'm still concerned about test coverage.

Thanks,
David
-----

> new webrevs:
> http://cr.openjdk.java.net/~minqi/8000818
> http://cr.openjdk.java.net/~minqi/8001055
>
> Thanks
> Yumin
>
> On 10/16/2012 9:51 PM, Yumin Qi wrote:
>> Hi, all
>>
>> May I have your codereview on
>>
>> http://cr.openjdk.java.net/~minqi/8000818/
>> <http://cr.openjdk.java.net/%7Eminqi/8000818/>
>>
>> 8000818: SA constant pool need to reference to reference map after
>> permgen removal
>> Summary: After permgen removal, constant pool changed to put _ldc and
>> _ldc_w (fast_ldc and fast_ldcw) index to reference map, no longer
>> calculated via constant pool cache.
>> Also, there is a mistake in 6879063: SA should use hsdis. Bytes.swap
>> should only check if the underlying platform is big endian since java
>> code follows big endian. Revert it back to its orginal form, else it
>> will fail ClassDump.
>>
>> Reviewed-by:
>> Contributed-by: yumin.qi at oracle.com
>>
>>
>> Thanks
>> Yumin