RFR: 8000489: older builds of hsdis don't work anymore after 6879063

yumin.qi at oracle.com yumin.qi at oracle.com
Wed Oct 24 14:15:35 PDT 2012


  Krystal,

   Thanks. Updated in same webrev.
   I checked b10, the output looks OK

/Yumin

On 10/24/2012 12:24 PM, Krystal Mok wrote:
> Hi Yumin,
>
> minor typos:
> s/instrurctions/instructions/
>
> By the way, I tried to use a build of hsdis plugin after 6879063 in an 
> earlier JDK build (e.g. JDK8b59) and it was working strangely. A rough 
> look at the output looks like it's missing some newlines, I didn't go 
> into the details. Could you please check if this fix makes the hsdis 
> plugin work properly on earlier JDK builds as well?
>
> Thanks,
> Kris
>
> On Thu, Oct 25, 2012 at 1:01 AM, <yumin.qi at oracle.com 
> <mailto:yumin.qi at oracle.com>> wrote:
>
>      Hi, all
>
>       Can I have your codereview of 8000489: older builds of hsdis
>     don't work anymore after 6879063
>       It caused old build broke the disassembler.
>
>       Webrev: http://cr.openjdk.java.net/~minqi/8000489
>     <http://cr.openjdk.java.net/%7Eminqi/8000489>
>
>     Thanks
>     Yumin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20121024/85f6844f/attachment.html 


More information about the serviceability-dev mailing list