review request: 6533010 SPEC: A few broken links in jvmti.html

[David Holmes]

Serguei,

Does the change to the micro version need to go through approval processes?

That aside I don't quite understand how you can just bump the micro 
version for JDK7 when JDK 7 is already out there with a different micro 
version. The web version of the spec indicates it is 1.2.1 for JDK 7:

http://docs.oracle.com/javase/7/docs/platform/jvmti/jvmti.html#ChangeHistory

(Though the change history has not been updated since 2006 :( )

This addition seems unrelated to LinkCheck:

+     <basetype id="jchar">
+       <description>
+         Holds a Java programming language <code>char</code>.
+         Unsigned 16 bits.
+       </description>
+     </basetype>

Aside: it would be useful to see a blenderrev or specdiff version of the 
change to compare the before and after redndered html.

David

On 25/10/2012 4:14 AM, serguei.spitsyn at oracle.com wrote:
> Hello,
>
>
> Please, review the fix for (preliminary reviewed by
> james.holmlund at oracle.com) :
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6533010
>
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc
>
> Generated jvmti.html:
> http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2012/hotspot/6533010-JVMTI-doc/jvmti.html
>
>
> Summary:
>
> The fix is to remove the errors in generated jvmti.html reported by the
> LinkCheck tool:
> http://javapubs.us.oracle.com/linkcheck_results/javase/7/Platform-Specs.html#platform/jvmti/
>
>
> I verified the fix by looking into the generated jvmti.html:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2012/6533010-JVMTI-doc/jvmti.html
>
>
> One more comment about the JVMTI version and the related changes:
>
> + <change date="11 October 2012" version="1.2.2">
> + Fixed the "HTTP" and "Missing Anchor" errors reported by the LinkCheck
> tool.
> + </change>
> </changehistory>
>
> </specification>
> diff -r 48a75d2640a5 src/share/vm/prims/jvmtiEnvBase.hpp
> --- a/src/share/vm/prims/jvmtiEnvBase.hpp Thu Oct 11 14:27:54 2012 -0400
> +++ b/src/share/vm/prims/jvmtiEnvBase.hpp Mon Oct 22 13:07:54 2012 -0700
> @@ -67,7 +67,7 @@
> enum {
> JDK15_JVMTI_VERSION = JVMTI_VERSION_1_0 + 33, /* version: 1.0.33 */
> JDK16_JVMTI_VERSION = JVMTI_VERSION_1_1 + 102, /* version: 1.1.102 */
> - JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 1 /* version: 1.2.1 */
> + JDK17_JVMTI_VERSION = JVMTI_VERSION_1_2 + 2 /* version: 1.2.2 */
> };
>
> I've decided to fix just micro version, so new version is 1.2.2 that
> matches JDK 7.
> It is because the fix is for both JFK 7 and 8 and it does not add any
> new features related to JDK 8.
> The enum in the jvmtiEnvBase.hpp is not used anywhere in hotspot code.
> It is just to keep track of JVMTI versions matching different versions
> of JDK.
>
>
> Thanks,
> Serguei
>
>
>
>