RFR: 8000489: older builds of hsdis don't work anymore after 6879063

Yumin Qi yumin.qi at oracle.com
Thu Oct 25 13:16:09 PDT 2012


John, and all

   I updated the webrev. I also made changes to make 'nice new line" to 
be a argument of decode_instructions_virtual so it can be changed 
instead of hard coded as 'false'.

   To John's question, it doesn't require changes to disassembler.cpp:

   new version ---> decode_instructions_virtual
   old version   ---> decode_instructions ---> decode_instructions_virtual

   tested with b01 (JDK8) with new hsdis-i386.so.

   same location:

  http://cr.openjdk.java.net/~minqi/8000489


Thanks
Yumin

On 10/24/2012 3:27 PM, John Rose wrote:
> On Oct 24, 2012, at 10:01 AM, Yumin.Qi at oracle.com wrote:
>
>> Hi, all
>>
>>   Can I have your codereview of 8000489: older builds of hsdis don't work anymore after 6879063
>>   It caused old build broke the disassembler.
>>
>>   Webrev: http://cr.openjdk.java.net/~minqi/8000489
> Shouldn't there be a corresponding change to disassembler.cpp?  I didn't see it in the webrev.  — John


More information about the serviceability-dev mailing list