RFR(S): 6963102: sun/tools/jstatd/jstatdDefaults.sh fails

Dmitry Samersoff Dmitry.Samersoff at oracle.com
Wed Sep 5 05:24:02 PDT 2012


Looks good for me.
-Dmitry


On 2012-09-05 15:51, Staffan Larsen wrote:
> Please review the patch below to make the jstatd tests a little bit more
> resilient to different outputs of the jps command. 
> 
> The jps command can output a couple of different error messages when
> information is missing about the target process. See the errorString
> variable
> in http://hg.openjdk.java.net/jdk8/tl/jdk/file/7dda50fe8e1c/src/share/classes/sun/tools/jps/Jps.java
> 
> All of these are preceded by "-- " which makes it easy to match these in
> the test. We currently have a matcher for "-- process information
> unavailable". This change makes that rule more general.
> 
> Thanks,
> /Staffan
> 
> diff --git a/test/sun/tools/jstatd/jpsOutput1.awk
> b/test/sun/tools/jstatd/jpsOutput1.awk
> --- a/test/sun/tools/jstatd/jpsOutput1.awk
> +++ b/test/sun/tools/jstatd/jpsOutput1.awk
> @@ -7,7 +7,7 @@
>     matched++;
>  }
>  
> -/^[0-9]+ -- process information unavailable$/{
> +/^[0-9]+ -- .*$/{
>     matched++;
>  }


-- 
Dmitry Samersoff
Java Hotspot development team, SPB04
* There will come soft rains ...




More information about the serviceability-dev mailing list