Need reviewer for warning error fix on hprof_init.c

David Holmes david.holmes at oracle.com
Sat Sep 15 04:10:48 PDT 2012


On 15/09/2012 11:52 AM, Kelly O'Hair wrote:
>
> 7198327: Fix mac warning error in hprof_init.c
>
> http://cr.openjdk.java.net/~ohair/openjdk8/repo-jdk/webrev/src/share/demo/jvmti/hprof/hprof_init.c.sdiff.html
>
> The Mac warns on the if test for the port number being > 65535
> made more sense for the port to be a simple int.

Seems simpler and more correct to just do:

     if (port == 0 || (int)port > 65535) {

David

> -kto
>


More information about the serviceability-dev mailing list