RFR: 6879063: SA should use hsdis for disassembly

John Rose john.r.rose at oracle.com
Tue Sep 18 12:01:50 PDT 2012


On the whole, I am delighted to see all the code being removed, and pleased to see a fresh purpose for the hsdis plugin.

In hsdis.c, there is a symbol 'decode_instruction_virtual' (no 's' at the end) which appears to have no definition.  Is it a typo?

The "nice newlines" have moved around and proliferated.
Will this break any compatibility with new JVMs running old hsdis.so or vice versa?
I notice that 'do_newline' currently does not have a way to be true.  Was that meant for the old entry point?

But these are minor points.

Reviewed.

— John


More information about the serviceability-dev mailing list