Review Request: 7198070 Eliminate static dependency from JMX to java.beans.ConstructorProperties

[Mandy Chung]

On 9/19/2012 2:01 AM, Alan Bateman wrote:
> On 18/09/2012 23:05, Mandy Chung wrote:
>> Eamonn,
>>
>> I filed a RFE that the serviceability team can follow up your 
>> suggestion:
>>    7199353: Allow ConstructorProperties annotation from any package
>>
>> Alan - I modified the fix to throw InternalError instead of 
>> AssertionError.
> It's great to have this static dependency removed. I should have been 
> clearer in my comment about the AssertionError. What I meant is that I 
> think we should looking at the InvocationTargetException's cause, and 
> if an error or runtime exception then we should re-throw it rather 
> than throwing AssertionError (or InternalError as it is now). That 
> will making it easier to diagnose cases where the value method throws 
> an error or a runtime exception.

Thanks for clarifying that. I agree it's better to rethrow the 
InvocationTargetException's cause if the value method throws an error or 
runtime exception.  I can file a new CR and clean that up later.

Mandy