RFR: 6879063: SA should use hsdis for disassembly

[Staffan Larsen]

Looks good.

On 21 sep 2012, at 05:10, Yumin Qi <yumin.qi at oracle.com> wrote:

> Made a minor changes to CommandProcessor:
> +         // print Java bytecode disassembly
> +         new Command("jdis", "jdis address", false) {
> +             public void doit(Tokens t) {
> +                 int tokens = t.countTokens();
> +                 if (tokens != 1) {
> +                     usage();
> +                     return;
> +                 }
> +                 Address a = VM.getVM().getDebugger().parseAddress(t.nextToken());
> +                 Method m = new Method(a);
> +                 HTMLGenerator html = new HTMLGenerator(false);
> +                 out.println(html.genHTML(m));
> +             }
> +         },
> The input address should be a Method address, not a oop as before.
> built/tested 
> 
> Thanks
> --Yumin
> 
> On 9/19/2012 12:49 AM, Staffan Larsen wrote:
>> 
>> Looks good!
>> 
>> /Staffan
>> 
>> On 18 sep 2012, at 19:19, yumin.qi at oracle.com wrote:
>> 
>>> Again, it is OK now.
>>> 
>>> Thanks
>>> Yumin
>>> 
>>> On 9/18/2012 9:27 AM, yumin.qi at oracle.com wrote:
>>>> Sorry, please ignore this one, since the make files not listed. Will send again.
>>>> 
>>>> Thanks
>>>> Yumin
>>>> 
>>>> On 9/18/2012 9:09 AM, yumin.qi at oracle.com wrote:
>>>>> Hi,
>>>>> 
>>>>>  I have changed code for bsd, enable it work on MacOS, built/tested.
>>>>>  Please have another round of review on files related to bsd.  The changes is in make files and agent/src/os/bsd/MacosxDebuggerLocal.m
>>>>> 
>>>>> http://cr.openjdk.java.net/~minqi/6879063
>>>>> 
>>>>> 
>>>>> Thanks
>>>>> Yumin
>>>>> 
>>>>> On 8/28/2012 5:54 PM, Christian Thalinger wrote:
>>>>>> Looks good.  -- Chris
>>>>>> 
>>>>>> On Aug 28, 2012, at 4:48 PM, Yumin Qi<yumin.qi at oracle.com>  wrote:
>>>>>> 
>>>>>>> Hi, all
>>>>>>> 
>>>>>>>   Updated with feedback suggestions. Please have a look again at the same link.
>>>>>>> 
>>>>>>> Thanks
>>>>>>> Yumin
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> On 2012/8/27 14:07, Yumin Qi wrote:
>>>>>>>> Hi, all
>>>>>>>> 
>>>>>>>>   Can I have you code review of
>>>>>>>>   6879063: SA should use hsdis for disassembly
>>>>>>>> 
>>>>>>>>   http://cr.openjdk.java.net/~minqi/6879063
>>>>>>>> 
>>>>>>>>   The SA has Java based disassemblers for x86 and sparc but amd64.  Instead of porting to amd64 we should switch over to using hsdis for it like the JVM does.  This requires a new entry point into hsdis, decode_instructions_virtual, which separates the address of the code being disassembled from the buffer containing the code.  The existing uses of decode_instructions have been updated to use the new interface and SA Disassembler has Java native methods that call into hsdis and call back up to Java to perform the disassembly. Also changed makefile for hsdis build for both(i386/amd64).
>>>>>>>> 
>>>>>>>>   All the old disassembler logic was deleted since it's incompatible with the new disassembly interface. Also deleted are dbx based SA interface and few other dead files.
>>>>>>>> 
>>>>>>>>   Tested by dumping full assembly from core files.
>>>>>>>> 
>>>>>>>>   Reviewed-by:
>>>>>>>>   Contributed-by: Tom R (never)
>>>>>>>> 
>>>>>>>>   Thanks
>>>>>>>>   Yumin Qi
>>>>>>>> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20120921/c402fcd3/attachment.html