RFR (XXS): 8011400: missing define OPENJDK for windows builds (hsx24)

[Daniel D. Daugherty]

On 4/3/13 2:02 PM, Markus Grönlund wrote:
>
> Greetings,
>
> Please review the following changes to allow building hsx24 from the 
> command-line on Windows:
>
> Bugid: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011400
>
> Webrev: http://cr.openjdk.java.net/~mgronlun/8011400/webrev01/ 
> <http://cr.openjdk.java.net/%7Emgronlun/8011400/webrev01/>
>

make/windows/build.make
     201 !if exist($(WorkSpace)\src\closed)
     202 !else
     203 OPENJDK=true
     204 !endif

     I'm not fond of the empty 'if-statement' style. Does this variation 
work:

     !if not exist($(WorkSpace)\src\closed)
       OPENJDK=true
     !endif

     Also, when I grep make/windows, I see:

     make/windows/build.make:!if exists($(WorkSpace)\src\closed)
     make/windows/makefiles/vm.make:!if exists($(ALTSRC)\share\vm)

     and I see:

     make/windows/makefiles/adlc.make:       if exist $(AdlcOutDir) 
rmdir /s /q $(AdlcOutDir)

     when used as part of a rule. So I have to wonder if your:

     201 !if exist($(WorkSpace)\src\closed)

     should really be a:

     201 !if exists($(WorkSpace)\src\closed)

     since your new use is not part of a rule.


make/windows/makefiles/trace.make
     Does the now unprotected "rm" need an option to not fail if those
     files don't exist?

make/windows/projectfiles/common/Makefile
     49 !if exist($(WorkSpace)\src\closed)
     50 !else
     51 OPENJDK=true
     52 !endif

     Same comments as above...


Dan


> Comment:
>
> Transform missing define information from example in 
> make/linux/makefiles/buildtree.make onto make/windows/build.make.
>
> Thanks
>
> Markus
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130404/c00ca913/attachment.html