hg: hsx/hotspot-rt/hotspot: 8012927: 'assert(nbits == 32 || (-(1 << nbits-1) <= x && x < ( 1 << nbits-1))) failed: value out of range' in interpreter initialization.

[Christian Thalinger]

On Apr 25, 2013, at 6:45 AM, Volker Simonis <volker.simonis at gmail.com> wrote:

> Hi Jiangli,
> 
> that's really sad!
> 
> First because it is not the way it is supposed to work and second
> because we detected and fixed this same problem a few days ago as
> well..
> 
> I don't understand what's the problem to post a review request on the
> list and get the reviews by mail. That shouldn't take much longer than
> a verbal review, even if you and the reviewers all sit in the same
> room.

I concur with Volker.  Open bugs which are pushed to open repositories should have an open review on one of the OpenJDK mailing lists.  No matter if urgent or not.

I hope that an open review system (which I also hope is coming soon) makes it less likely that this happens again.

-- Chris

> 
> Regards,
> Volker
> 
> 
> On Wed, Apr 24, 2013 at 6:26 PM, Jiangli Zhou <jiangli.zhou at oracle.com> wrote:
>> Hi David,
>> 
>> It was an urgent fix and didn't go through the "normal" route.
>> 
>> Thanks,
>> Jiangli
>> 
>> 
>> On 04/23/2013 09:32 PM, David Holmes wrote:
>>> 
>>> Jiangli,
>>> 
>>> I do not see a public Request for Review for this change.
>>> 
>>> David
>>> 
>>> On 24/04/2013 9:11 AM, jiangli.zhou at oracle.com wrote:
>>>> 
>>>> Changeset: 1ea6a35dcbe5
>>>> Author:    jiangli
>>>> Date:      2013-04-23 12:32 -0400
>>>> URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1ea6a35dcbe5
>>>> 
>>>> 8012927: 'assert(nbits == 32 || (-(1 << nbits-1) <= x && x < ( 1 <<
>>>> nbits-1))) failed: value out of range' in interpreter initialization.
>>>> Summary: Change br_null_short() to br_null().
>>>> Reviewed-by: coleenp, hseigel
>>>> 
>>>> ! src/cpu/sparc/vm/interp_masm_sparc.cpp
>>>> 
>>