RR(XS): JDK-8021771 warning: stat64 is deprecated - when building on OSX 10.7.5

[Dmitry Samersoff]

Kris,

Thanks!

Any other reviewers?

-Dmitry

On 2013-08-07 12:14, Krystal Mok wrote:
> On Wed, Aug 7, 2013 at 3:37 PM, Dmitry Samersoff
> <dmitry.samersoff at oracle.com <mailto:dmitry.samersoff at oracle.com>> wrote:
> 
>     Krystal,
> 
>     I built the fix on FreeBSD and it works fine.
> 
>     OpenBSD doesn't have stat64(), NetBSD has stat64() but it just an alias
>     to stat(). On all three systems stat() handles files > 2G without any
>     issues.
> 
>     Moreover for this particular case we don't need stat64 because the code
>     deals with pid file and it doubtly grows over 2GB.
> 
> Great. I'm good with the fix then.
> Thanks again for the info :-)
> 
> - Kris
>  
> 
>     -Dmitry
> 
> 
>     On 2013-08-07 06:31, Krystal Mok wrote:
>     > Hi Dmitry,
>     >
>     > Thanks for taking care of this patch. Has it been confirmed that
>     all BSD
>     > variants are good to use stat instead of stat64?
>     >
>     > Regards,
>     > Kris (kmo)
>     >
>     >
>     > On Wed, Aug 7, 2013 at 3:30 AM, Dmitry Samersoff
>     > <dmitry.samersoff at oracle.com <mailto:dmitry.samersoff at oracle.com>
>     <mailto:dmitry.samersoff at oracle.com
>     <mailto:dmitry.samersoff at oracle.com>>> wrote:
>     >
>     >     Hi Everyone,
>     >
>     >     Please review.
>     >
>     >     stat64 replaced with plan stat.
>     >
>     >     http://cr.openjdk.java.net/~dsamersoff/JDK-8021771/webrev.01/
>     >
>     >     -Dmitry
>     >
>     >     --
>     >     Dmitry Samersoff
>     >     Oracle Java development team, Saint Petersburg, Russia
>     >     * I would love to change the world, but they won't give me the
>     sources.
>     >
>     >
> 
> 
>     --
>     Dmitry Samersoff
>     Oracle Java development team, Saint Petersburg, Russia
>     * I would love to change the world, but they won't give me the
>     source code.
> 
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.