RFR (XS): 6800801: NPE in JConsole when using Nimbus L&F

Erik Gahlin erik.gahlin at oracle.com
Mon Aug 12 04:25:38 PDT 2013


Updated webrev with "==" replaced with "!="

Erik

Erik Gahlin skrev 2013-07-30 22:04:
> Nice catch, thanks Shanliang.
>
> Erik
>
> Shanliang skrev 2013-07-30 09:14:
>> Hi Erik,
>>
>> src/share/classes/sun/tools/jconsole/VMPanel.java
>> 156         if (insets == null) {
>> 157             insets = (Insets) insets.clone();
>> 158             insets.right += connectedIcon24.getIconWidth() + 8;
>> 159             UIManager.put("TabbedPane.tabAreaInsets", insets);
>> 160         }
>>
>> Should Line 156 be:
>>    if (insets != null) { ?
>>
>> Shanliang
>>
>>
>> Erik Gahlin wrote:
>>> Please review a small change.
>>>
>>> Description:
>>> Start JConsole from the commandline using the Nimbus look & feel:
>>>
>>> jconsole 
>>> -J-Dswing.defaultlaf=com.sun.java.swing.plaf.nimbus.NimbusLookAndFeel
>>>
>>> The main window opens, but when creating the 'Connect to..' dialog, 
>>> we get a NPE:
>>>
>>> Bug:
>>> http://monaco.us.oracle.com/detail.jsf?cr=6800801
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~egahlin/6800801/
>>>
>>> Testing:
>>> Clicked around in GUI with Nimbus L&F
>>>
>>> A sponsor is needed.
>>>
>>> Thanks
>>> Erik
>>
>



More information about the serviceability-dev mailing list