RFR: 8011888: sa.js: TypeError: [object JSAdapter] has no such function "__has__"

Krystal Mok rednaxelafx at gmail.com
Mon Aug 12 09:03:41 PDT 2013


Hi Peter,

Looks good to me. Thank you!
I'd like to mention again that the getHandle -> getAddress change has been
purposed by Yunda, which I mentioned in [1], too.

Best regards,
Kris (kmo)

On Monday, August 12, 2013, A. Sundararajan wrote:

>
> Looks good
>
> -Sundar
>
> On Monday 12 August 2013 06:21 PM, Peter Allwin wrote:
>
> Hello!
>
>  This patch addresses several Nashorn compatibility issues with in sa.js
> and is a merge of my patch [0] and Kris' (kmo) [1] which were developed
> separately.
>
>  The merged change is identical to [1] with except for line 785 where
> I've added a conversion to JavaScript String to ensure the correct replace
> method is called.
>
>
>  webrev: http://cr.openjdk.java.net/~allwin/8011888/webrev.01/
> bug: http://bugs.sun.com/view_bug.do?bug_id=8011888
>
>
>  Thanks!
> /Peter
>
>
>  [0] http://cr.openjdk.java.net/~allwin/8011888/webrev.00/
> [1]
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-July/010831.html
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130813/9bb77436/attachment.html 


More information about the serviceability-dev mailing list