RFR: 6696970: JConsole becomes unusable if a plugin throws an exception

[Erik Gahlin]

Thanks for the review!

Erik

Mandy Chung skrev 2013-08-14 22:42:
> Looks okay to me.  Thanks for updating it.
>
> Mandy
>
> On 8/14/2013 11:29 AM, Erik Gahlin wrote:
>> Hi Mandy.
>>
>> I have updated the fix.
>>
>> http://cr.openjdk.java.net/~egahlin/6696970_3/
>>
>> There is a dialog where the user can ignore further exceptions or 
>> exit. It's an application wide ignore. It would be possible to ignore 
>> per VM or plug-in, but I think it would just frustrate the user.
>>
>> If a user wants to see plug-in exceptions they can always run with 
>> -debug. Also, it's not worth spending more time on a more elaborate 
>> ignore mechanism.
>>
>> Thanks
>> Erik
>>
>> Erik Gahlin skrev 2013-08-13 16:34:
>>> Mandy Chung skrev 2013-08-13 02:10:
>>>>
>>>> On 8/6/2013 10:59 AM, Erik Gahlin wrote:
>>>>> Please review this change.
>>>>>
>>>>> An exception from JConsole plug-in should not affect other tabs.
>>>>> http://monaco.us.oracle.com/detail.jsf?cr=6696970
>>>>>
>>>>> Added a plug-in proxy that handles RE. If debug mode is enabled 
>>>>> exceptions are written to System.err. Tested by adding faked 
>>>>> exceptions to the JTop plug-in.
>>>>>
>>>>> Code is targeted for jdk7.
>>>>>
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~egahlin/6696970
>>>>>
>>>>
>>>> The approach is okay.  You added a 
>>>> ExceptionSafePlugin.executeSwingWorker method which isn't used 
>>>> though.  In other words, jconsole will be affected if SwingWorker 
>>>> returned by newSwingWorker throws an exception.
>>>
>>> Thanks, I lost that line.  Here is an updated review
>>> http://cr.openjdk.java.net/~egahlin/6696970_2/
>>>
>>>>
>>>> I wonder if it should inform the user when it detects any exception 
>>>> thrown by a plugin rather than ignoring it.  It seems that a user 
>>>> feedback is appropriate in this case to inform the user that the 
>>>> plugin stops working and maybe something like whether they want to 
>>>> continue without this plugin or exit.
>>>>
>>> Disabling the plug-in is a bigger fix than I anticipated. I will 
>>> look into it and see if it can be done without too much trouble.
>>>
>>> Thanks
>>> Erik
>>>
>>>> Mandy
>>>>
>>>>> A sponsor is needed.
>>>>>
>>>>> Thanks
>>>>> Erik
>>>>
>>>
>>
>