RFR (XS): 7023754 JConsole Javascript plugin demo throws exception on window.print

[Dalibor Topic]

Approved for jdk7u-dev.

cheers,
dalibor topic

On 8/21/13 1:11 AM, Mandy Chung wrote:
> Looks okay to me.
> 
> Mandy
> 
> On 8/19/2013 11:16 AM, Erik Gahlin wrote:
>> Thanks Andreas,
>>
>> Here is an updated webrev with an updated copyright header.
>> http://cr.openjdk.java.net/~egahlin/7023754_2/
>>
>> The same issue was fixed with
>> "8016531: jconsole-plugin script demo does not work with nashorn"
>> http://cr.openjdk.java.net/~sundar/8016531/webrev.01/
>>
>> but it also applies to Rhino.
>>
>> I still need ok from a jdk7u (r)eviewer and/or backport approval to proceed  - can I ask for this please?
>>
>> Thanks
>> Erik
>>
>> Andreas Rieber skrev 2013-08-17 09:54:
>>> Hi Erik,
>>>
>>> the fix looks close to the one fixed in jdk8. Just the year update in copyright header is missing.
>>>
>>> Andreas
>>>
>>> On 17.08.13 00:11, Erik Gahlin wrote:
>>>> Could I please have a review of a fix that allows a script in the
>>>> jconsole script plug-in to call print method in ScriptShellPanel class.
>>>>
>>>> Bug:
>>>> http://monaco.us.oracle.com/detail.jsf?cr=7023754
>>>
>>> http://bugs.sun.com/view_bug.do?bug_id=7023754
>>>
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~egahlin/7023754/src/share/demo/scripting/jconsole-plugin/src/com/sun/demo/scripting/jconsole/ScriptShellPanel.java.sdiff.html
>>>>
>>>>
>>>> Tested by running reproducer in bug report.
>>>>
>>>> Thanks
>>>> Erik
>>>
>>
> 



-- 
Oracle <http://www.oracle.com>
Dalibor Topic | Principal Product Manager
Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961 <tel:+491737185961>
Oracle Java Platform Group

ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg

ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Geschäftsführer: Jürgen Kunz

Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Astrid Kepper, Val Maher

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment