RFR (S): 6461635: [TESTBUG] BasicTests.sh test fails intermittently

[Alan Bateman]

On 02/12/2013 10:51, Mattias Tobiasson wrote:
> Hi,
> Could someone please review this?
> Leonid Mesnik has looked at it and he is ok with the changes. 
> Unfortunately he is not a reviewer.
> I am waiting with another test fix that is dependent on this fix.
>
>
> webrev:
> http://cr.openjdk.java.net/~miauno/6461635/webrev.03/
>
I went through the changes in the webrev and it looks very good and nice 
to see more shell tests going away.

Do you plan to remove the no-longer-exists BasicTests.sh from the 
exclude list (jdk/test/ProblemList.txt), I didn't see this in webrev.03.

I wasn't aware of  JDKToolLauncher and just wonder if it is necessary 
for it to launch the jar command. In other areas then we invoke jar 
directly via sun.tools.jar.Main and this avoids needing to launch a new VM.

One thing about the shell tests is that launch the target VM with the VM 
options that are specified to jtreg via -vmoption. Are these used now? 
(if not maybe this is a separate task for the test infrastructure library).

Some small comments as I read through it:

Application.java - looks like this could use try-with-resources.

jdk/test/sun/tools/jstatd/JstatdTest.java - is this meant to be in the 
webrev?

class Impl. If you are looking for an alternative name then something 
like TestMain might be more obvious.

Otherwise, as I said, this is good work and nice to see BasicTests 
running again (as he has been excluded for a long time, I think mostly 
due to the redefine/Xshare issue).

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20131202/8398e237/attachment.html