RFR 8029890: java/lang/management/ThreadMXBean/ThreadBlockedCount.java fails: Blocked thread has 4 blocked counts. Expected 3

Mandy Chung mandy.chung at oracle.com
Wed Dec 18 12:59:08 PST 2013


Hi Jaroslav,

http://cr.openjdk.java.net/~jbachorik/8029890/webrev.02

This patch looks good in general. Thanks for replacing the 
ThreadExecutionSynchronization with j.u.c.   I think it'd be good to 
make the test fail fast e.g. is it okay for waitForBlocked to throw a 
RuntimeException if being interrupted.

Mandy

On 12/17/2013 2:50 AM, Jaroslav Bachorik wrote:
> Please, review the following test fix.
>
> Issue : https://bugs.openjdk.java.net/browse/JDK-8029890
> Webrev: http://cr.openjdk.java.net/~jbachorik/8029809/webrev.00
>
> The test fails intermittently due to ThreadMXBean.getThreadInfo() 
> blocking the tested thread from time to time. The solution is not to 
> invoke this method from within the tested thread and, in order to make 
> the test more readable and maintainable, replace the 
> ThreadExecutionSynchronizer with the standard j.u.c.Phaser.
>
> Thanks,
>
> -JB-



More information about the serviceability-dev mailing list