RFR [8030698] Several GUI labels in jconsole need corrections
Ivan Gerasimov
ivan.gerasimov at oracle.com
Fri Dec 20 04:16:10 PST 2013
Thank you Staffan!
On 20.12.2013 16:07, Staffan Larsen wrote:
> Looks good!
>
> I assume this is targeted for jdk9 and/or 8u20?
Yes, it's for 9, 8u20 and 7u(80?).
Ivan
> Thanks for fixing this,
> /Staffan
>
>
> On 20 dec 2013, at 12:05, Ivan Gerasimov <ivan.gerasimov at oracle.com> wrote:
>
>> Hello!
>>
>> Would you please review a GUI-only fix for jconsole?
>>
>> It is to fix the following 3 issues:
>> 1) on the 'New Connection' dialog, the label is: 'lt;hostnamegt;...' instead of '<hostname>'.
>> 2) on the Overview page, Thread tab, the label is the constant string 'ThreadTab.infoLabelFormat'.
>> 3) on the VM Summary page, Pending finalization displays constant string '{0} objects'.
>>
>> All of them seem to have been introduced with the huge update JDK-7017818.
>>
>> Would you please help review the proposed fix?
>> http://cr.openjdk.java.net/~igerasim/8030698/0/webrev/
>>
>> The localized messages were taken from these files:
>> http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/file/2dd7fb82f40e/src/share/classes/sun/tools/jconsole/resources/JConsoleResources_ja.java
>> http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/file/2dd7fb82f40e/src/share/classes/sun/tools/jconsole/resources/JConsoleResources_zh_CN.java
>>
>> If approved, the fix will be pushed into 9 and then be backported into 8 and 7.
>>
>> Sincerely yours,
>> Ivan Gerasimov
>>
>
>
More information about the serviceability-dev
mailing list