RFR (S): 8004172: Update jstat counter names to reflect metaspace changes
Erik Helin
erik.helin at oracle.com
Mon Feb 4 08:01:22 PST 2013
There have been some updates to the hotspot code based on feedback from
the hotspot-gc-dev mailing list. The only change to the JDK code is that
the namespace is back to "sun.gc" :)
New webrevs:
- jdk: http://cr.openjdk.java.net/~ehelin/8004172/jdk/webrev.03/
- hotspot: http://cr.openjdk.java.net/~ehelin/8004172/hotspot/webrev.03/
Thanks,
Erik
On 01/28/2013 04:23 PM, Erik Helin wrote:
> Jon Masamitsu suggested that the "sun.rt" namespace should be used
> instead of the "sun.gc" namespace. I've updated both the jdk and the
> hotspot code based on this suggestion.
>
> New webrevs:
> - hotspot: http://cr.openjdk.java.net/~ehelin/8004172/hotspot/webrev.01/
> - jdk: http://cr.openjdk.java.net/~ehelin/8004172/jdk/webrev.02/
>
> Thanks,
> Erik
>
> On 01/25/2013 09:01 AM, Staffan Larsen wrote:
>> Looks good!
>>
>> /Staffan
>>
>> On 24 jan 2013, at 18:36, Erik Helin <erik.helin at oracle.com> wrote:
>>
>>> Hi Staffan,
>>>
>>> thanks for reviewing this!
>>>
>>> On 01/24/2013 01:27 PM, Staffan Larsen wrote:
>>>> The JDK changes look good, but I think there is change needed in
>>>> test/sun/tools/jstatd/jstatGcutilOutput1.awk as well.
>>>
>>> Yes, you are right. Please see an updated webrev at:
>>> http://cr.openjdk.java.net/~ehelin/8004172/jdk/webrev.01/
>>>
>>> Thanks,
>>> Erik
>>>
>>>> Thanks,
>>>> /Staffan
>>>>
>>>> On 24 jan 2013, at 11:51, Erik Helin <erik.helin at oracle.com> wrote:
>>>>
>>>>> Hi all,
>>>>>
>>>>> here are the JDK changes for fixing JDK-8004172. This change
>>>>> updates the jstat resource file to use the new metaspace
>>>>> performance counters and also updates the tests.
>>>>>
>>>>> Note that the fixed tests will continue to fail until the HotSpot
>>>>> part of the change finds it way into the tl forest.
>>>>>
>>>>> The HotSpot part of the change is also out for review on
>>>>> hotspot-gc-dev at openjdk.java.net.
>>>>>
>>>>> Webrev:
>>>>> JDK: http://cr.openjdk.java.net/~ehelin/8004172/jdk/webrev.00/
>>>>> HotSpot: http://cr.openjdk.java.net/~ehelin/8004172/hotspot/webrev.00/
>>>>>
>>>>> Bug:
>>>>> http://bugs.sun.com/view_bug.do?bug_id=8004172
>>>>>
>>>>> Testing:
>>>>> Run the jstat jtreg tests locally on my machine on a repository
>>>>> where I've applied both the JDK changes and the HotSpot changes.
>>>>>
>>>>> Thanks,
>>>>> Erik
>>>>
>>>
>>
>
More information about the serviceability-dev
mailing list