RFR (XS) 8008089: Delete OS dependent check in JdkFinder.getExecutable()

Yekaterina Kantserova yekaterina.kantserova at oracle.com
Wed Feb 13 01:47:32 PST 2013


Hi everyone,

This small fixconcerns jdk.testlibrary.JdkFinder utility class. The 
check below is too OS dependent and should be deleted.
...
         binPath += File.separatorChar + "bin" + File.separatorChar + 
executable;
         File toolFile = new File(binPath);
==> if (!toolFile.exists()) {
             throw new RuntimeException(binPath + " does not exist");
         }
...

On windows if executable is specified as e.g. 'java', without '.exe', 
the File exists() will fail. But it's still possible to run executable.


Webrev:
http://cr.openjdk.java.net/~ykantser/8008089/webrev.00/

Bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008089

Testing:
JPRT

Thanks,
Katja
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130213/872c338a/attachment-0001.html 


More information about the serviceability-dev mailing list